/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_smart_add.py

  • Committer: Robert Collins
  • Date: 2007-03-05 03:10:21 UTC
  • mto: (2255.11.4 dirstate)
  • mto: This revision was merged to the branch mainline in revision 2322.
  • Revision ID: robertc@robertcollins.net-20070305031021-ypbakvagbivyw5mu
Teach delta.report_changes about unversioned files, removing all inventory access during status --short.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005, 2006, 2007, 2009, 2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
from cStringIO import StringIO
 
18
import os
 
19
import unittest
18
20
 
19
 
from bzrlib import (
20
 
    add,
21
 
    inventory,
22
 
    osutils,
23
 
    tests,
 
21
from bzrlib import errors, ignores, osutils
 
22
from bzrlib.add import (
 
23
    AddAction,
 
24
    AddFromBaseAction,
 
25
    smart_add,
 
26
    smart_add_tree,
24
27
    )
25
 
 
26
 
 
27
 
class AddCustomIDAction(add.AddAction):
 
28
from bzrlib.tests import TestCase, TestCaseWithTransport, TestSkipped
 
29
from bzrlib.errors import NoSuchFile
 
30
from bzrlib.inventory import InventoryFile, Inventory
 
31
from bzrlib.workingtree import WorkingTree
 
32
 
 
33
 
 
34
class TestSmartAdd(TestCaseWithTransport):
 
35
 
 
36
    def test_add_dot_from_root(self):
 
37
        """Test adding . from the root of the tree.""" 
 
38
        paths = ("original/", "original/file1", "original/file2")
 
39
        self.build_tree(paths)
 
40
        wt = self.make_branch_and_tree('.')
 
41
        smart_add_tree(wt, (u".",))
 
42
        for path in paths:
 
43
            self.assertNotEqual(wt.path2id(path), None)
 
44
 
 
45
    def test_add_dot_from_subdir(self):
 
46
        """Test adding . from a subdir of the tree.""" 
 
47
        from bzrlib.add import smart_add
 
48
        paths = ("original/", "original/file1", "original/file2")
 
49
        self.build_tree(paths)
 
50
        wt = self.make_branch_and_tree('.')
 
51
        os.chdir("original")
 
52
        smart_add_tree(wt, (u".",))
 
53
        for path in paths:
 
54
            self.assertNotEqual(wt.path2id(path), None)
 
55
 
 
56
    def test_add_tree_from_above_tree(self):
 
57
        """Test adding a tree from above the tree.""" 
 
58
        from bzrlib.add import smart_add
 
59
        paths = ("original/", "original/file1", "original/file2")
 
60
        branch_paths = ("branch/", "branch/original/", "branch/original/file1",
 
61
                        "branch/original/file2")
 
62
        self.build_tree(branch_paths)
 
63
        wt = self.make_branch_and_tree('branch')
 
64
        smart_add_tree(wt, ("branch",))
 
65
        for path in paths:
 
66
            self.assertNotEqual(wt.path2id(path), None)
 
67
 
 
68
    def test_add_above_tree_preserves_tree(self):
 
69
        """Test nested trees are not affect by an add above them."""
 
70
        from bzrlib.add import smart_add
 
71
        paths = ("original/", "original/file1", "original/file2")
 
72
        child_paths = ("path",)
 
73
        full_child_paths = ("original/child", "original/child/path")
 
74
        build_paths = ("original/", "original/file1", "original/file2", 
 
75
                       "original/child/", "original/child/path")
 
76
        
 
77
        self.build_tree(build_paths)
 
78
        wt = self.make_branch_and_tree('.')
 
79
        child_tree = self.make_branch_and_tree('original/child')
 
80
        smart_add_tree(wt, (".",))
 
81
        for path in paths:
 
82
            self.assertNotEqual((path, wt.path2id(path)),
 
83
                                (path, None))
 
84
        for path in full_child_paths:
 
85
            self.assertEqual((path, wt.path2id(path)),
 
86
                             (path, None))
 
87
        for path in child_paths:
 
88
            self.assertEqual(child_tree.path2id(path), None)
 
89
 
 
90
    def test_add_paths(self):
 
91
        """Test smart-adding a list of paths."""
 
92
        from bzrlib.add import smart_add
 
93
        paths = ("file1", "file2")
 
94
        self.build_tree(paths)
 
95
        wt = self.make_branch_and_tree('.')
 
96
        smart_add_tree(wt, paths)
 
97
        for path in paths:
 
98
            self.assertNotEqual(wt.path2id(path), None)
 
99
    
 
100
    def test_add_ignored_nested_paths(self):
 
101
        """Test smart-adding a list of paths which includes ignored ones."""
 
102
        wt = self.make_branch_and_tree('.')
 
103
        tree_shape = ("adir/", "adir/CVS/", "adir/CVS/afile", "adir/CVS/afile2")
 
104
        add_paths = ("adir/CVS", "adir/CVS/afile", "adir")
 
105
        expected_paths = ("adir", "adir/CVS", "adir/CVS/afile", "adir/CVS/afile2")
 
106
        self.build_tree(tree_shape)
 
107
        smart_add_tree(wt, add_paths)
 
108
        for path in expected_paths:
 
109
            self.assertNotEqual(wt.path2id(path), None, "No id added for %s" % path)
 
110
 
 
111
    def test_add_dry_run(self):
 
112
        """Test a dry run add, make sure nothing is added."""
 
113
        from bzrlib.commands import run_bzr
 
114
        eq = self.assertEqual
 
115
        wt = self.make_branch_and_tree('.')
 
116
        self.build_tree(['inertiatic/', 'inertiatic/esp'])
 
117
        eq(list(wt.unknowns()), ['inertiatic'])
 
118
        self.capture('add --dry-run .')
 
119
        eq(list(wt.unknowns()), ['inertiatic'])
 
120
 
 
121
    def test_add_non_existant(self):
 
122
        """Test smart-adding a file that does not exist."""
 
123
        from bzrlib.add import smart_add
 
124
        wt = self.make_branch_and_tree('.')
 
125
        self.assertRaises(NoSuchFile, smart_add_tree, wt, 'non-existant-file')
 
126
 
 
127
    def test_returns_and_ignores(self):
 
128
        """Correctly returns added/ignored files"""
 
129
        from bzrlib.commands import run_bzr
 
130
        wt = self.make_branch_and_tree('.')
 
131
        # The default ignore list includes '*.py[co]', but not CVS
 
132
        ignores._set_user_ignores(['*.py[co]'])
 
133
        self.build_tree(['inertiatic/', 'inertiatic/esp', 'inertiatic/CVS',
 
134
                        'inertiatic/foo.pyc'])
 
135
        added, ignored = smart_add_tree(wt, u'.')
 
136
        self.assertSubset(('inertiatic', 'inertiatic/esp', 'inertiatic/CVS'),
 
137
                          added)
 
138
        self.assertSubset(('*.py[co]',), ignored)
 
139
        self.assertSubset(('inertiatic/foo.pyc',), ignored['*.py[co]'])
 
140
 
 
141
 
 
142
class AddCustomIDAction(AddAction):
28
143
 
29
144
    def __call__(self, inv, parent_ie, path, kind):
30
145
        # The first part just logs if appropriate
31
146
        # Now generate a custom id
32
 
        file_id = osutils.safe_file_id(kind + '-'
33
 
                                       + path.raw_path.replace('/', '%'),
34
 
                                       warn=False)
 
147
        file_id = kind + '-' + path.raw_path.replace('/', '%')
35
148
        if self.should_print:
36
 
            self._to_file.write('added %s with id %s\n'
 
149
            self._to_file.write('added %s with id %s\n' 
37
150
                                % (path.raw_path, file_id))
38
151
        return file_id
39
152
 
40
153
 
41
 
class TestAddFrom(tests.TestCaseWithTransport):
 
154
class TestSmartAddTree(TestCaseWithTransport):
 
155
    """Test smart adds with a specified branch."""
 
156
 
 
157
    def test_add_dot_from_root(self):
 
158
        """Test adding . from the root of the tree.""" 
 
159
        paths = ("original/", "original/file1", "original/file2")
 
160
        self.build_tree(paths)
 
161
        wt = self.make_branch_and_tree('.')
 
162
        smart_add_tree(wt, (u".",))
 
163
        for path in paths:
 
164
            self.assertNotEqual(wt.path2id(path), None)
 
165
 
 
166
    def test_add_dot_from_subdir(self):
 
167
        """Test adding . from a subdir of the tree.""" 
 
168
        paths = ("original/", "original/file1", "original/file2")
 
169
        self.build_tree(paths)
 
170
        wt = self.make_branch_and_tree('.')
 
171
        os.chdir("original")
 
172
        smart_add_tree(wt, (u".",))
 
173
        for path in paths:
 
174
            self.assertNotEqual(wt.path2id(path), None)
 
175
 
 
176
    def test_add_tree_from_above_tree(self):
 
177
        """Test adding a tree from above the tree.""" 
 
178
        paths = ("original/", "original/file1", "original/file2")
 
179
        branch_paths = ("branch/", "branch/original/", "branch/original/file1",
 
180
                        "branch/original/file2")
 
181
        self.build_tree(branch_paths)
 
182
        tree = self.make_branch_and_tree('branch')
 
183
        smart_add_tree(tree, ("branch",))
 
184
        for path in paths:
 
185
            self.assertNotEqual(tree.path2id(path), None)
 
186
 
 
187
    def test_add_above_tree_preserves_tree(self):
 
188
        """Test nested trees are not affect by an add above them."""
 
189
        paths = ("original/", "original/file1", "original/file2")
 
190
        child_paths = ("path")
 
191
        full_child_paths = ("original/child", "original/child/path")
 
192
        build_paths = ("original/", "original/file1", "original/file2", 
 
193
                       "original/child/", "original/child/path")
 
194
        self.build_tree(build_paths)
 
195
        tree = self.make_branch_and_tree('.')
 
196
        child_tree = self.make_branch_and_tree("original/child")
 
197
        smart_add_tree(tree, (u".",))
 
198
        for path in paths:
 
199
            self.assertNotEqual((path, tree.path2id(path)),
 
200
                                (path, None))
 
201
        for path in full_child_paths:
 
202
            self.assertEqual((path, tree.path2id(path)),
 
203
                             (path, None))
 
204
        for path in child_paths:
 
205
            self.assertEqual(child_tree.path2id(path), None)
 
206
 
 
207
    def test_add_paths(self):
 
208
        """Test smart-adding a list of paths."""
 
209
        paths = ("file1", "file2")
 
210
        self.build_tree(paths)
 
211
        wt = self.make_branch_and_tree('.')
 
212
        smart_add_tree(wt, paths)
 
213
        for path in paths:
 
214
            self.assertNotEqual(wt.path2id(path), None)
 
215
 
 
216
    def test_add_multiple_dirs(self):
 
217
        """Test smart adding multiple directories at once."""
 
218
        added_paths = ['file1', 'file2',
 
219
                       'dir1/', 'dir1/file3',
 
220
                       'dir1/subdir2/', 'dir1/subdir2/file4',
 
221
                       'dir2/', 'dir2/file5',
 
222
                      ]
 
223
        not_added = ['file6', 'dir3/', 'dir3/file7', 'dir3/file8']
 
224
        self.build_tree(added_paths)
 
225
        self.build_tree(not_added)
 
226
 
 
227
        wt = self.make_branch_and_tree('.')
 
228
        smart_add_tree(wt, ['file1', 'file2', 'dir1', 'dir2'])
 
229
 
 
230
        for path in added_paths:
 
231
            self.assertNotEqual(None, wt.path2id(path.rstrip('/')),
 
232
                    'Failed to add path: %s' % (path,))
 
233
        for path in not_added:
 
234
            self.assertEqual(None, wt.path2id(path.rstrip('/')),
 
235
                    'Accidentally added path: %s' % (path,))
 
236
 
 
237
    def test_custom_ids(self):
 
238
        sio = StringIO()
 
239
        action = AddCustomIDAction(to_file=sio, should_print=True)
 
240
        self.build_tree(['file1', 'dir1/', 'dir1/file2'])
 
241
 
 
242
        wt = self.make_branch_and_tree('.')
 
243
        smart_add_tree(wt, ['.'], action=action)
 
244
        # The order of adds is not strictly fixed:
 
245
        sio.seek(0)
 
246
        lines = sorted(sio.readlines())
 
247
        self.assertEqualDiff(['added dir1 with id directory-dir1\n',
 
248
                              'added dir1/file2 with id file-dir1%file2\n',
 
249
                              'added file1 with id file-file1\n',
 
250
                             ], lines)
 
251
        wt.lock_read()
 
252
        self.addCleanup(wt.unlock)
 
253
        self.assertEqual([('', wt.path2id('')),
 
254
                          ('dir1', 'directory-dir1'),
 
255
                          ('dir1/file2', 'file-dir1%file2'),
 
256
                          ('file1', 'file-file1'),
 
257
                         ], [(path, ie.file_id) for path, ie
 
258
                                in wt.inventory.iter_entries()])
 
259
 
 
260
 
 
261
class TestAddFrom(TestCaseWithTransport):
42
262
    """Tests for AddFromBaseAction"""
43
263
 
44
264
    def make_base_tree(self):
59
279
        try:
60
280
            new_tree.lock_write()
61
281
            try:
62
 
                action = add.AddFromBaseAction(base_tree, base_path,
63
 
                                               to_file=to_file,
64
 
                                               should_print=should_print)
65
 
                new_tree.smart_add(file_list, action=action)
 
282
                action = AddFromBaseAction(base_tree, base_path,
 
283
                                           to_file=to_file,
 
284
                                           should_print=should_print)
 
285
                smart_add_tree(new_tree, file_list, action=action)
66
286
            finally:
67
287
                new_tree.unlock()
68
288
        finally:
143
363
        self.failIf(a_id in self.base_tree)
144
364
 
145
365
 
146
 
class TestAddActions(tests.TestCase):
 
366
class TestAddNonNormalized(TestCaseWithTransport):
 
367
 
 
368
    def make(self):
 
369
        try:
 
370
            self.build_tree([u'a\u030a'])
 
371
        except UnicodeError:
 
372
            raise TestSkipped('Filesystem cannot create unicode filenames')
 
373
 
 
374
        self.wt = self.make_branch_and_tree('.')
 
375
 
 
376
    def test_accessible_explicit(self):
 
377
        self.make()
 
378
        orig = osutils.normalized_filename
 
379
        osutils.normalized_filename = osutils._accessible_normalized_filename
 
380
        try:
 
381
            smart_add_tree(self.wt, [u'a\u030a'])
 
382
            self.wt.lock_read()
 
383
            self.addCleanup(self.wt.unlock)
 
384
            self.assertEqual([('', 'directory'), (u'\xe5', 'file')],
 
385
                    [(path, ie.kind) for path,ie in 
 
386
                        self.wt.inventory.iter_entries()])
 
387
        finally:
 
388
            osutils.normalized_filename = orig
 
389
 
 
390
    def test_accessible_implicit(self):
 
391
        self.make()
 
392
        orig = osutils.normalized_filename
 
393
        osutils.normalized_filename = osutils._accessible_normalized_filename
 
394
        try:
 
395
            smart_add_tree(self.wt, [])
 
396
            self.wt.lock_read()
 
397
            self.addCleanup(self.wt.unlock)
 
398
            self.assertEqual([('', 'directory'), (u'\xe5', 'file')],
 
399
                    [(path, ie.kind) for path,ie in 
 
400
                        self.wt.inventory.iter_entries()])
 
401
        finally:
 
402
            osutils.normalized_filename = orig
 
403
 
 
404
    def test_inaccessible_explicit(self):
 
405
        self.make()
 
406
        orig = osutils.normalized_filename
 
407
        osutils.normalized_filename = osutils._inaccessible_normalized_filename
 
408
        try:
 
409
            self.assertRaises(errors.InvalidNormalization,
 
410
                    smart_add_tree, self.wt, [u'a\u030a'])
 
411
        finally:
 
412
            osutils.normalized_filename = orig
 
413
 
 
414
    def test_inaccessible_implicit(self):
 
415
        self.make()
 
416
        orig = osutils.normalized_filename
 
417
        osutils.normalized_filename = osutils._inaccessible_normalized_filename
 
418
        try:
 
419
            # TODO: jam 20060701 In the future, this should probably
 
420
            #       just ignore files that don't fit the normalization
 
421
            #       rules, rather than exploding
 
422
            self.assertRaises(errors.InvalidNormalization,
 
423
                    smart_add_tree, self.wt, [])
 
424
        finally:
 
425
            osutils.normalized_filename = orig
 
426
 
 
427
 
 
428
class TestAddActions(TestCase):
147
429
 
148
430
    def test_quiet(self):
149
431
        self.run_action("")
150
432
 
151
433
    def test__print(self):
152
 
        self.run_action("adding path\n")
 
434
        self.run_action("added path\n")
153
435
 
154
436
    def run_action(self, output):
155
 
        from bzrlib.mutabletree import _FastPath
156
 
        inv = inventory.Inventory()
 
437
        from bzrlib.add import AddAction, FastPath
 
438
        inv = Inventory()
157
439
        stdout = StringIO()
158
 
        action = add.AddAction(to_file=stdout, should_print=bool(output))
 
440
        action = AddAction(to_file=stdout, should_print=bool(output))
159
441
 
160
 
        self.apply_redirected(None, stdout, None, action, inv, None,
161
 
            _FastPath('path'), 'file')
 
442
        self.apply_redirected(None, stdout, None, action, inv, None, FastPath('path'), 'file')
162
443
        self.assertEqual(stdout.getvalue(), output)