13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
18
18
"""Tests for the commit CLI of bzr."""
24
23
from bzrlib import (
27
from bzrlib.branch import Branch
28
29
from bzrlib.bzrdir import BzrDir
29
from bzrlib.errors import BzrCommandError
30
from bzrlib.tests import (
30
34
from bzrlib.tests.blackbox import ExternalBase
31
from bzrlib.workingtree import WorkingTree
34
37
class TestCommit(ExternalBase):
36
39
def test_05_empty_commit(self):
37
40
"""Commit of tree with no versioned files should fail"""
38
41
# If forced, it should succeed, but this is not tested here.
42
self.make_branch_and_tree('.')
40
43
self.build_tree(['hello.txt'])
41
44
out,err = self.run_bzr('commit -m empty', retcode=3)
42
45
self.assertEqual('', out)
43
self.assertStartsWith(err, 'bzr: ERROR: no changes to commit.'
44
' use --unchanged to commit anyhow\n')
46
self.assertContainsRe(err, 'bzr: ERROR: No changes to commit\.'
47
' Use --unchanged to commit anyhow.\n')
46
49
def test_commit_success(self):
47
50
"""Successful commit should not leave behind a bzr-commit-* file"""
51
self.make_branch_and_tree('.')
49
52
self.run_bzr('commit --unchanged -m message')
50
53
self.assertEqual('', self.run_bzr('unknowns')[0])
56
59
def test_commit_with_path(self):
57
60
"""Commit tree with path of root specified"""
58
self.run_bzr('init a')
61
a_tree = self.make_branch_and_tree('a')
59
62
self.build_tree(['a/a_file'])
60
self.run_bzr('add a/a_file')
61
64
self.run_bzr(['commit', '-m', 'first commit', 'a'])
63
self.run_bzr('branch a b')
66
b_tree = a_tree.bzrdir.sprout('b').open_workingtree()
64
67
self.build_tree_contents([('b/a_file', 'changes in b')])
65
68
self.run_bzr(['commit', '-m', 'first commit in b', 'b'])
67
70
self.build_tree_contents([('a/a_file', 'new contents')])
68
71
self.run_bzr(['commit', '-m', 'change in a', 'a'])
71
self.run_bzr('merge ../a', retcode=1) # will conflict
73
b_tree.merge_from_branch(a_tree.branch)
74
self.assertEqual(len(b_tree.conflicts()), 1)
73
75
self.run_bzr('resolved b/a_file')
74
76
self.run_bzr(['commit', '-m', 'merge into b', 'b'])
77
79
def test_10_verbose_commit(self):
78
80
"""Add one file and examine verbose commit output"""
81
tree = self.make_branch_and_tree('.')
80
82
self.build_tree(['hello.txt'])
81
self.run_bzr("add hello.txt")
82
84
out,err = self.run_bzr('commit -m added')
83
85
self.assertEqual('', out)
84
self.assertEqual('added hello.txt\n'
85
'Committed revision 1.\n',
86
self.assertContainsRe(err, '^Committing to: .*\n'
88
'Committed revision 1.\n$',)
88
90
def prepare_simple_history(self):
89
91
"""Prepare and return a working tree with one commit of one file"""
135
140
wt.add(['hello.txt'])
136
141
out,err = self.run_bzr('commit -m added')
137
142
self.assertEqual('', out)
138
self.assertEqual('added hello.txt\n'
139
'Committed revision 1.\n',
143
self.assertContainsRe(err, '^Committing to: .*\n'
145
'Committed revision 1\.\n$')
142
147
def test_verbose_commit_with_unchanged(self):
143
148
"""Unchanged files should not be listed by default in verbose output"""
149
tree = self.make_branch_and_tree('.')
145
150
self.build_tree(['hello.txt', 'unchanged.txt'])
146
self.run_bzr('add unchanged.txt')
151
tree.add('unchanged.txt')
147
152
self.run_bzr('commit -m unchanged unchanged.txt')
148
self.run_bzr("add hello.txt")
153
tree.add("hello.txt")
149
154
out,err = self.run_bzr('commit -m added')
150
155
self.assertEqual('', out)
151
self.assertEqual('added hello.txt\n'
152
'Committed revision 2.\n',
156
self.assertContainsRe(err, '^Committing to: .*\n'
158
'Committed revision 2\.$\n')
160
def test_verbose_commit_includes_master_location(self):
161
"""Location of master is displayed when committing to bound branch"""
162
a_tree = self.make_branch_and_tree('a')
163
self.build_tree(['a/b'])
165
a_tree.commit(message='Initial message')
167
b_tree = a_tree.branch.create_checkout('b')
168
expected = "%s/" % (osutils.abspath('a'), )
169
out, err = self.run_bzr('commit -m blah --unchanged', working_dir='b')
170
self.assertEqual(err, 'Committing to: %s\n'
171
'Committed revision 2.\n' % expected)
155
173
def test_commit_merge_reports_all_modified_files(self):
156
174
# the commit command should show all the files that are shown by
203
222
this_tree.merge_from_branch(other_tree.branch)
205
224
out,err = self.run_bzr('commit -m added')
207
225
self.assertEqual('', out)
208
self.assertEqualDiff(
209
'modified filetomodify\n'
212
'renamed dirtorename => renameddir\n'
213
'renamed dirtoreparent => renameddir/reparenteddir\n'
214
'renamed filetoreparent => renameddir/reparentedfile\n'
215
'renamed filetorename => renamedfile\n'
216
'deleted dirtoremove\n'
217
'deleted filetoremove\n'
218
'Committed revision 2.\n',
226
self.assertEqual(set([
227
'Committing to: %s/' % osutils.getcwd(),
228
'modified filetomodify',
231
'renamed dirtorename => renameddir',
232
'renamed filetorename => renamedfile',
233
'renamed dirtoreparent => renameddir/reparenteddir',
234
'renamed filetoreparent => renameddir/reparentedfile',
235
'deleted dirtoremove',
236
'deleted filetoremove',
237
'Committed revision 2.',
239
]), set(err.split('\n')))
221
241
def test_empty_commit_message(self):
223
file('foo.c', 'wt').write('int main() {}')
224
self.run_bzr('add foo.c')
242
tree = self.make_branch_and_tree('.')
243
self.build_tree_contents([('foo.c', 'int main() {}')])
225
245
self.run_bzr('commit -m ""', retcode=3)
247
def test_unsupported_encoding_commit_message(self):
248
tree = self.make_branch_and_tree('.')
249
self.build_tree_contents([('foo.c', 'int main() {}')])
251
# LANG env variable has no effect on Windows
252
# but some characters anyway cannot be represented
253
# in default user encoding
254
char = probe_bad_non_ascii(osutils.get_user_encoding())
256
raise TestSkipped('Cannot find suitable non-ascii character'
257
'for user_encoding (%s)' % osutils.get_user_encoding())
258
out,err = self.run_bzr_subprocess('commit -m "%s"' % char,
260
env_changes={'LANG': 'C'})
261
self.assertContainsRe(err, r'bzrlib.errors.BzrError: Parameter.*is '
262
'unsupported by the current encoding.')
227
264
def test_other_branch_commit(self):
228
265
# this branch is to ensure consistent behaviour, whether we're run
229
266
# inside a branch, or not.
230
os.mkdir('empty_branch')
231
os.chdir('empty_branch')
236
file('foo.c', 'wt').write('int main() {}')
237
file('bar.c', 'wt').write('int main() {}')
239
self.run_bzr('add branch/foo.c')
240
self.run_bzr('add branch')
267
outer_tree = self.make_branch_and_tree('.')
268
inner_tree = self.make_branch_and_tree('branch')
269
self.build_tree_contents([
270
('branch/foo.c', 'int main() {}'),
271
('branch/bar.c', 'int main() {}')])
272
inner_tree.add('foo.c')
273
inner_tree.add('bar.c')
241
274
# can't commit files in different trees; sane error
242
275
self.run_bzr('commit -m newstuff branch/foo.c .', retcode=3)
243
276
self.run_bzr('commit -m newstuff branch/foo.c')
247
280
def test_out_of_date_tree_commit(self):
248
281
# check we get an error code and a clear message committing with an out
249
282
# of date checkout
250
self.make_branch_and_tree('branch')
283
tree = self.make_branch_and_tree('branch')
251
284
# make a checkout
252
self.run_bzr('checkout --lightweight branch checkout')
285
checkout = tree.branch.create_checkout('checkout', lightweight=True)
253
286
# commit to the original branch to make the checkout out of date
254
self.run_bzr('commit --unchanged -m message branch')
287
tree.commit('message branch', allow_pointless=True)
255
288
# now commit to the checkout should emit
256
289
# ERROR: Out of date with the branch, 'bzr update' is suggested
257
290
output = self.run_bzr('commit --unchanged -m checkout_message '
258
291
'checkout', retcode=3)
259
292
self.assertEqual(output,
261
"bzr: ERROR: Working tree is out of date, please run "
294
"bzr: ERROR: Working tree is out of date, please "
295
"run 'bzr update'.\n"))
264
297
def test_local_commit_unbound(self):
265
298
# a --local commit on an unbound branch is an error
272
305
def test_commit_a_text_merge_in_a_checkout(self):
273
306
# checkouts perform multiple actions in a transaction across bond
274
307
# branches and their master, and have been observed to fail in the
275
# past. This is a user story reported to fail in bug #43959 where
308
# past. This is a user story reported to fail in bug #43959 where
276
309
# a merge done in a checkout (using the update command) failed to
277
310
# commit correctly.
278
self.run_bzr('init trunk')
311
trunk = self.make_branch_and_tree('trunk')
280
self.run_bzr('checkout trunk u1')
313
u1 = trunk.branch.create_checkout('u1')
281
314
self.build_tree_contents([('u1/hosts', 'initial contents')])
282
self.run_bzr('add u1/hosts')
283
316
self.run_bzr('commit -m add-hosts u1')
285
self.run_bzr('checkout trunk u2')
318
u2 = trunk.branch.create_checkout('u2')
286
319
self.build_tree_contents([('u2/hosts', 'altered in u2')])
287
320
self.run_bzr('commit -m checkin-from-u2 u2')
301
334
self.build_tree_contents([('u1/hosts', 'merge resolution\n')])
302
335
self.run_bzr('commit -m checkin-merge-of-the-offline-work-from-u1 u1')
337
def test_commit_exclude_excludes_modified_files(self):
338
"""Commit -x foo should ignore changes to foo."""
339
tree = self.make_branch_and_tree('.')
340
self.build_tree(['a', 'b', 'c'])
341
tree.smart_add(['.'])
342
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b'])
343
self.assertFalse('added b' in out)
344
self.assertFalse('added b' in err)
345
# If b was excluded it will still be 'added' in status.
346
out, err = self.run_bzr(['added'])
347
self.assertEqual('b\n', out)
348
self.assertEqual('', err)
350
def test_commit_exclude_twice_uses_both_rules(self):
351
"""Commit -x foo -x bar should ignore changes to foo and bar."""
352
tree = self.make_branch_and_tree('.')
353
self.build_tree(['a', 'b', 'c'])
354
tree.smart_add(['.'])
355
out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b', '-x', 'c'])
356
self.assertFalse('added b' in out)
357
self.assertFalse('added c' in out)
358
self.assertFalse('added b' in err)
359
self.assertFalse('added c' in err)
360
# If b was excluded it will still be 'added' in status.
361
out, err = self.run_bzr(['added'])
362
self.assertTrue('b\n' in out)
363
self.assertTrue('c\n' in out)
364
self.assertEqual('', err)
304
366
def test_commit_respects_spec_for_removals(self):
305
367
"""Commit with a file spec should only commit removals that match"""
306
368
t = self.make_branch_and_tree('.')
466
532
self.build_tree(['tree/hello.txt'])
467
533
tree.add('hello.txt')
468
534
self.run_bzr_error(
469
[r"Invalid bug orange. Must be in the form of 'tag:id'\. "
535
[r"Invalid bug orange. Must be in the form of 'tracker:id'\. "
536
r"See \"bzr help bugs\" for more information on this feature.\n"
470
537
r"Commit refused\."],
471
538
'commit -m add-b --fixes=orange',
472
539
working_dir='tree')
541
def test_no_author(self):
542
"""If the author is not specified, the author property is not set."""
543
tree = self.make_branch_and_tree('tree')
544
self.build_tree(['tree/hello.txt'])
545
tree.add('hello.txt')
546
self.run_bzr( 'commit -m hello tree/hello.txt')
547
last_rev = tree.branch.repository.get_revision(tree.last_revision())
548
properties = last_rev.properties
549
self.assertFalse('author' in properties)
551
def test_author_sets_property(self):
552
"""commit --author='John Doe <jdoe@example.com>' sets the author
555
tree = self.make_branch_and_tree('tree')
556
self.build_tree(['tree/hello.txt'])
557
tree.add('hello.txt')
558
self.run_bzr(["commit", '-m', 'hello',
559
'--author', u'John D\xf6 <jdoe@example.com>',
561
last_rev = tree.branch.repository.get_revision(tree.last_revision())
562
properties = last_rev.properties
563
self.assertEqual(u'John D\xf6 <jdoe@example.com>', properties['authors'])
565
def test_author_no_email(self):
566
"""Author's name without an email address is allowed, too."""
567
tree = self.make_branch_and_tree('tree')
568
self.build_tree(['tree/hello.txt'])
569
tree.add('hello.txt')
570
out, err = self.run_bzr("commit -m hello --author='John Doe' "
572
last_rev = tree.branch.repository.get_revision(tree.last_revision())
573
properties = last_rev.properties
574
self.assertEqual('John Doe', properties['authors'])
576
def test_multiple_authors(self):
577
"""Multiple authors can be specyfied, and all are stored."""
578
tree = self.make_branch_and_tree('tree')
579
self.build_tree(['tree/hello.txt'])
580
tree.add('hello.txt')
581
out, err = self.run_bzr("commit -m hello --author='John Doe' "
582
"--author='Jane Rey' tree/hello.txt")
583
last_rev = tree.branch.repository.get_revision(tree.last_revision())
584
properties = last_rev.properties
585
self.assertEqual('John Doe\nJane Rey', properties['authors'])
587
def test_partial_commit_with_renames_in_tree(self):
588
# this test illustrates bug #140419
589
t = self.make_branch_and_tree('.')
590
self.build_tree(['dir/', 'dir/a', 'test'])
591
t.add(['dir/', 'dir/a', 'test'])
592
t.commit('initial commit')
593
# important part: file dir/a should change parent
594
# and should appear before old parent
595
# then during partial commit we have error
596
# parent_id {dir-XXX} not in inventory
597
t.rename_one('dir/a', 'a')
598
self.build_tree_contents([('test', 'changes in test')])
600
out, err = self.run_bzr('commit test -m "partial commit"')
601
self.assertEquals('', out)
602
self.assertContainsRe(err, r'modified test\nCommitted revision 2.')
604
def test_commit_readonly_checkout(self):
605
# https://bugs.edge.launchpad.net/bzr/+bug/129701
606
# "UnlockableTransport error trying to commit in checkout of readonly
608
self.make_branch('master')
609
master = BzrDir.open_from_transport(
610
self.get_readonly_transport('master')).open_branch()
611
master.create_checkout('checkout')
612
out, err = self.run_bzr(['commit', '--unchanged', '-mfoo', 'checkout'],
614
self.assertContainsRe(err,
615
r'^bzr: ERROR: Cannot lock.*readonly transport')
617
def test_commit_hook_template(self):
618
# Test that commit template hooks work
619
def restoreDefaults():
620
msgeditor.hooks['commit_message_template'] = []
621
osutils.set_or_unset_env('BZR_EDITOR', default_editor)
622
if sys.platform == "win32":
623
f = file('fed.bat', 'w')
624
f.write('@rem dummy fed')
626
default_editor = osutils.set_or_unset_env('BZR_EDITOR', "fed.bat")
628
f = file('fed.sh', 'wb')
629
f.write('#!/bin/sh\n')
631
os.chmod('fed.sh', 0755)
632
default_editor = osutils.set_or_unset_env('BZR_EDITOR', "./fed.sh")
633
self.addCleanup(restoreDefaults)
634
msgeditor.hooks.install_named_hook("commit_message_template",
635
lambda commit_obj, msg: "save me some typing\n", None)
636
tree = self.make_branch_and_tree('tree')
637
self.build_tree(['tree/hello.txt'])
638
tree.add('hello.txt')
639
out, err = self.run_bzr("commit tree/hello.txt")
640
last_rev = tree.branch.repository.get_revision(tree.last_revision())
641
self.assertEqual('save me some typing\n', last_rev.message)