/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_diff.py

  • Committer: Ian Clatworthy
  • Date: 2007-12-04 05:49:37 UTC
  • mto: (3118.1.1 ianc-integration)
  • mto: This revision was merged to the branch mainline in revision 3119.
  • Revision ID: ian.clatworthy@internode.on.net-20071204054937-6v169ypv0lclbyuj
Improved diff based on feedback from abentley

Show diffs side-by-side

added added

removed removed

Lines of Context:
 
1
# Copyright (C) 2005, 2006 Canonical Ltd
 
2
#
 
3
# This program is free software; you can redistribute it and/or modify
 
4
# it under the terms of the GNU General Public License as published by
 
5
# the Free Software Foundation; either version 2 of the License, or
 
6
# (at your option) any later version.
 
7
#
 
8
# This program is distributed in the hope that it will be useful,
 
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 
11
# GNU General Public License for more details.
 
12
#
 
13
# You should have received a copy of the GNU General Public License
 
14
# along with this program; if not, write to the Free Software
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
16
 
 
17
 
 
18
"""Black-box tests for bzr diff.
 
19
"""
 
20
 
 
21
import os
 
22
import re
 
23
 
 
24
import bzrlib
 
25
from bzrlib import workingtree
 
26
from bzrlib.branch import Branch
 
27
from bzrlib.tests import TestSkipped
 
28
from bzrlib.tests.blackbox import ExternalBase
 
29
 
 
30
 
 
31
def subst_dates(string):
 
32
    """Replace date strings with constant values."""
 
33
    return re.sub(r'\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2} [-\+]\d{4}',
 
34
                  'YYYY-MM-DD HH:MM:SS +ZZZZ', string)
 
35
 
 
36
 
 
37
class DiffBase(ExternalBase):
 
38
    """Base class with common setup method"""
 
39
 
 
40
    def make_example_branch(self):
 
41
        tree = self.make_branch_and_tree('.')
 
42
        self.build_tree_contents([
 
43
            ('hello', 'foo\n'),
 
44
            ('goodbye', 'baz\n')])
 
45
        tree.add(['hello'])
 
46
        tree.commit('setup')
 
47
        tree.add(['goodbye'])
 
48
        tree.commit('setup')
 
49
        return tree
 
50
 
 
51
 
 
52
class TestDiff(DiffBase):
 
53
 
 
54
    def test_diff(self):
 
55
        tree = self.make_example_branch()
 
56
        self.build_tree_contents([('hello', 'hello world!')])
 
57
        tree.commit(message='fixing hello')
 
58
        output = self.run_bzr('diff -r 2..3', retcode=1)[0]
 
59
        self.assert_('\n+hello world!' in output)
 
60
        output = self.run_bzr('diff -c 3', retcode=1)[0]
 
61
        self.assert_('\n+hello world!' in output)
 
62
        output = self.run_bzr('diff -r last:3..last:1', retcode=1)[0]
 
63
        self.assert_('\n+baz' in output)
 
64
        output = self.run_bzr('diff -c last:2', retcode=1)[0]
 
65
        self.assert_('\n+baz' in output)
 
66
        self.build_tree(['moo'])
 
67
        tree.add('moo')
 
68
        os.unlink('moo')
 
69
        self.run_bzr('diff')
 
70
 
 
71
    def test_diff_prefix(self):
 
72
        """diff --prefix appends to filenames in output"""
 
73
        self.make_example_branch()
 
74
        self.build_tree_contents([('hello', 'hello world!\n')])
 
75
        out, err = self.run_bzr('diff --prefix old/:new/', retcode=1)
 
76
        self.assertEquals(err, '')
 
77
        self.assertEqualDiff(subst_dates(out), '''\
 
78
=== modified file 'hello'
 
79
--- old/hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
80
+++ new/hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
81
@@ -1,1 +1,1 @@
 
82
-foo
 
83
+hello world!
 
84
 
 
85
''')
 
86
 
 
87
    def test_diff_illegal_prefix_value(self):
 
88
        # There was an error in error reporting for this option
 
89
        out, err = self.run_bzr('diff --prefix old/', retcode=3)
 
90
        self.assertContainsRe(err,
 
91
            '--prefix expects two values separated by a colon')
 
92
 
 
93
    def test_diff_p1(self):
 
94
        """diff -p1 produces lkml-style diffs"""
 
95
        self.make_example_branch()
 
96
        self.build_tree_contents([('hello', 'hello world!\n')])
 
97
        out, err = self.run_bzr('diff -p1', retcode=1)
 
98
        self.assertEquals(err, '')
 
99
        self.assertEqualDiff(subst_dates(out), '''\
 
100
=== modified file 'hello'
 
101
--- old/hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
102
+++ new/hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
103
@@ -1,1 +1,1 @@
 
104
-foo
 
105
+hello world!
 
106
 
 
107
''')
 
108
 
 
109
    def test_diff_p0(self):
 
110
        """diff -p0 produces diffs with no prefix"""
 
111
        self.make_example_branch()
 
112
        self.build_tree_contents([('hello', 'hello world!\n')])
 
113
        out, err = self.run_bzr('diff -p0', retcode=1)
 
114
        self.assertEquals(err, '')
 
115
        self.assertEqualDiff(subst_dates(out), '''\
 
116
=== modified file 'hello'
 
117
--- hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
118
+++ hello\tYYYY-MM-DD HH:MM:SS +ZZZZ
 
119
@@ -1,1 +1,1 @@
 
120
-foo
 
121
+hello world!
 
122
 
 
123
''')
 
124
 
 
125
    def test_diff_nonexistent(self):
 
126
        # Get an error from a file that does not exist at all
 
127
        # (Malone #3619)
 
128
        self.make_example_branch()
 
129
        out, err = self.run_bzr('diff does-not-exist', retcode=3)
 
130
        self.assertContainsRe(err, 'not versioned.*does-not-exist')
 
131
 
 
132
    def test_diff_illegal_revision_specifiers(self):
 
133
        out, err = self.run_bzr('diff -r 1..23..123', retcode=3)
 
134
        self.assertContainsRe(err, 'one or two revision specifiers')
 
135
 
 
136
    def test_diff_unversioned(self):
 
137
        # Get an error when diffing a non-versioned file.
 
138
        # (Malone #3619)
 
139
        self.make_example_branch()
 
140
        self.build_tree(['unversioned-file'])
 
141
        out, err = self.run_bzr('diff unversioned-file', retcode=3)
 
142
        self.assertContainsRe(err, 'not versioned.*unversioned-file')
 
143
 
 
144
    # TODO: What should diff say for a file deleted in working tree?
 
145
 
 
146
    def example_branches(self):
 
147
        branch1_tree = self.make_branch_and_tree('branch1')
 
148
        self.build_tree(['branch1/file'], line_endings='binary')
 
149
        self.build_tree(['branch1/file2'], line_endings='binary')
 
150
        branch1_tree.add('file')
 
151
        branch1_tree.add('file2')
 
152
        branch1_tree.commit(message='add file and file2')
 
153
        branch2_tree = branch1_tree.bzrdir.sprout('branch2').open_workingtree()
 
154
        self.build_tree_contents([('branch2/file', 'new content\n')])
 
155
        branch2_tree.commit(message='update file')
 
156
        return branch1_tree, branch2_tree
 
157
 
 
158
    def test_diff_branches(self):
 
159
        self.example_branches()
 
160
        # should open branch1 and diff against branch2, 
 
161
        out, err = self.run_bzr('diff -r branch:branch2 branch1',
 
162
                                retcode=1)
 
163
        self.assertEquals('', err)
 
164
        self.assertEquals("=== modified file 'file'\n"
 
165
                          "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
166
                          "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
167
                          "@@ -1,1 +1,1 @@\n"
 
168
                          "-new content\n"
 
169
                          "+contents of branch1/file\n"
 
170
                          "\n", subst_dates(out))
 
171
        # Compare two working trees
 
172
        out, err = self.run_bzr('diff --old branch2 --new branch1',
 
173
                                         retcode=1)
 
174
        self.assertEquals('', err)
 
175
        self.assertEqualDiff("=== modified file 'file'\n"
 
176
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
177
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
178
                              "@@ -1,1 +1,1 @@\n"
 
179
                              "-new content\n"
 
180
                              "+contents of branch1/file\n"
 
181
                              "\n", subst_dates(out))
 
182
        # Test with a selected file that was changed
 
183
        out, err = self.run_bzr('diff --old branch2 --new branch1 file',
 
184
                                         retcode=1)
 
185
        self.assertEquals('', err)
 
186
        self.assertEqualDiff("=== modified file 'file'\n"
 
187
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
188
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
189
                              "@@ -1,1 +1,1 @@\n"
 
190
                              "-new content\n"
 
191
                              "+contents of branch1/file\n"
 
192
                              "\n", subst_dates(out))
 
193
        # Test with a selected file that was not changed
 
194
        out, err = self.run_bzr('diff --old branch2 --new branch1 file2',
 
195
                                         retcode=0)
 
196
        self.assertEquals('', err)
 
197
        self.assertEquals('', out)
 
198
 
 
199
    def test_diff_branches_no_working_trees(self):
 
200
        branch1_tree, branch2_tree = self.example_branches()
 
201
        # Compare a working tree to a branch without a WT
 
202
        dir1 = branch1_tree.bzrdir
 
203
        dir1.destroy_workingtree()
 
204
        self.assertFalse(dir1.has_workingtree())
 
205
        out, err = self.run_bzr('diff --old branch2 --new branch1',
 
206
                                         retcode=1)
 
207
        self.assertEquals('', err)
 
208
        self.assertEqualDiff("=== modified file 'file'\n"
 
209
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
210
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
211
                              "@@ -1,1 +1,1 @@\n"
 
212
                              "-new content\n"
 
213
                              "+contents of branch1/file\n"
 
214
                              "\n", subst_dates(out))
 
215
        # Compare a branch without a WT to one with a WT
 
216
        out, err = self.run_bzr('diff --old branch1 --new branch2',
 
217
                                         retcode=1)
 
218
        self.assertEquals('', err)
 
219
        self.assertEqualDiff("=== modified file 'file'\n"
 
220
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
221
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
222
                              "@@ -1,1 +1,1 @@\n"
 
223
                              "-contents of branch1/file\n"
 
224
                              "+new content\n"
 
225
                              "\n", subst_dates(out))
 
226
        # Compare a branch with a WT against another without a WT
 
227
        dir2 = branch2_tree.bzrdir
 
228
        dir2.destroy_workingtree()
 
229
        self.assertFalse(dir2.has_workingtree())
 
230
        out, err = self.run_bzr('diff --old branch1 --new branch2',
 
231
                                         retcode=1)
 
232
        self.assertEquals('', err)
 
233
        self.assertEqualDiff("=== modified file 'file'\n"
 
234
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
235
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
236
                              "@@ -1,1 +1,1 @@\n"
 
237
                              "-contents of branch1/file\n"
 
238
                              "+new content\n"
 
239
                              "\n", subst_dates(out))
 
240
 
 
241
    def test_diff_revno_branches(self):
 
242
        self.example_branches()
 
243
        branch2_tree = workingtree.WorkingTree.open_containing('branch2')[0]
 
244
        self.build_tree_contents([('branch2/file', 'even newer content')])
 
245
        branch2_tree.commit(message='update file once more')
 
246
 
 
247
        out, err = self.run_bzr('diff -r revno:1:branch2..revno:1:branch1',
 
248
                                )
 
249
        self.assertEquals('', err)
 
250
        self.assertEquals('', out)
 
251
        out, err = self.run_bzr('diff -r revno:2:branch2..revno:1:branch1',
 
252
                                retcode=1)
 
253
        self.assertEquals('', err)
 
254
        self.assertEqualDiff("=== modified file 'file'\n"
 
255
                              "--- file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
256
                              "+++ file\tYYYY-MM-DD HH:MM:SS +ZZZZ\n"
 
257
                              "@@ -1,1 +1,1 @@\n"
 
258
                              "-new content\n"
 
259
                              "+contents of branch1/file\n"
 
260
                              "\n", subst_dates(out))
 
261
 
 
262
    def example_branch2(self):
 
263
        branch1_tree = self.make_branch_and_tree('branch1')
 
264
        self.build_tree_contents([('branch1/file1', 'original line\n')])
 
265
        branch1_tree.add('file1')
 
266
        branch1_tree.commit(message='first commit')
 
267
        self.build_tree_contents([('branch1/file1', 'repo line\n')])
 
268
        branch1_tree.commit(message='second commit')
 
269
        return branch1_tree
 
270
 
 
271
    def test_diff_to_working_tree(self):
 
272
        self.example_branch2()
 
273
        self.build_tree_contents([('branch1/file1', 'new line')])
 
274
        output = self.run_bzr('diff -r 1.. branch1', retcode=1)
 
275
        self.assertContainsRe(output[0], '\n\\-original line\n\\+new line\n')
 
276
 
 
277
    def test_diff_across_rename(self):
 
278
        """The working tree path should always be considered for diffing"""
 
279
        tree = self.make_example_branch()
 
280
        self.run_bzr('diff -r 0..1 hello', retcode=1)
 
281
        tree.rename_one('hello', 'hello1')
 
282
        self.run_bzr('diff hello1', retcode=1)
 
283
        self.run_bzr('diff -r 0..1 hello1', retcode=1)
 
284
 
 
285
    def test_diff_to_branch_no_working_tree(self):
 
286
        branch1_tree = self.example_branch2()
 
287
        dir1 = branch1_tree.bzrdir
 
288
        dir1.destroy_workingtree()
 
289
        self.assertFalse(dir1.has_workingtree())
 
290
        output = self.run_bzr('diff -r 1.. branch1', retcode=1)
 
291
        self.assertContainsRe(output[0], '\n\\-original line\n\\+repo line\n')
 
292
 
 
293
 
 
294
class TestCheckoutDiff(TestDiff):
 
295
 
 
296
    def make_example_branch(self):
 
297
        tree = super(TestCheckoutDiff, self).make_example_branch()
 
298
        tree = tree.branch.create_checkout('checkout')
 
299
        os.chdir('checkout')
 
300
        return tree
 
301
 
 
302
    def example_branch2(self):
 
303
        tree = super(TestCheckoutDiff, self).example_branch2()
 
304
        os.mkdir('checkouts')
 
305
        tree = tree.branch.create_checkout('checkouts/branch1')
 
306
        os.chdir('checkouts')
 
307
        return tree
 
308
 
 
309
    def example_branches(self):
 
310
        branch1_tree, branch2_tree = super(TestCheckoutDiff, self).example_branches()
 
311
        os.mkdir('checkouts')
 
312
        branch1_tree = branch1_tree.branch.create_checkout('checkouts/branch1')
 
313
        branch2_tree = branch2_tree.branch.create_checkout('checkouts/branch2')
 
314
        os.chdir('checkouts')
 
315
        return branch1_tree, branch2_tree
 
316
 
 
317
 
 
318
class TestDiffLabels(DiffBase):
 
319
 
 
320
    def test_diff_label_removed(self):
 
321
        tree = super(TestDiffLabels, self).make_example_branch()
 
322
        tree.remove('hello', keep_files=False)
 
323
        diff = self.run_bzr('diff', retcode=1)
 
324
        self.assertTrue("=== removed file 'hello'" in diff[0])
 
325
 
 
326
    def test_diff_label_added(self):
 
327
        tree = super(TestDiffLabels, self).make_example_branch()
 
328
        self.build_tree_contents([('barbar', 'barbar')])
 
329
        tree.add('barbar')
 
330
        diff = self.run_bzr('diff', retcode=1)
 
331
        self.assertTrue("=== added file 'barbar'" in diff[0])
 
332
 
 
333
    def test_diff_label_modified(self):
 
334
        super(TestDiffLabels, self).make_example_branch()
 
335
        self.build_tree_contents([('hello', 'barbar')])
 
336
        diff = self.run_bzr('diff', retcode=1)
 
337
        self.assertTrue("=== modified file 'hello'" in diff[0])
 
338
 
 
339
    def test_diff_label_renamed(self):
 
340
        tree = super(TestDiffLabels, self).make_example_branch()
 
341
        tree.rename_one('hello', 'gruezi')
 
342
        diff = self.run_bzr('diff', retcode=1)
 
343
        self.assertTrue("=== renamed file 'hello' => 'gruezi'" in diff[0])
 
344
 
 
345
 
 
346
class TestExternalDiff(DiffBase):
 
347
 
 
348
    def test_external_diff(self):
 
349
        """Test that we can spawn an external diff process"""
 
350
        # We have to use run_bzr_subprocess, because we need to
 
351
        # test writing directly to stdout, (there was a bug in
 
352
        # subprocess.py that we had to workaround).
 
353
        # However, if 'diff' may not be available
 
354
        self.make_example_branch()
 
355
        orig_progress = os.environ.get('BZR_PROGRESS_BAR')
 
356
        try:
 
357
            os.environ['BZR_PROGRESS_BAR'] = 'none'
 
358
            out, err = self.run_bzr_subprocess('diff -r 1 --diff-options -ub',
 
359
                                               universal_newlines=True,
 
360
                                               retcode=None)
 
361
        finally:
 
362
            if orig_progress is None:
 
363
                del os.environ['BZR_PROGRESS_BAR']
 
364
            else:
 
365
                os.environ['BZR_PROGRESS_BAR'] = orig_progress
 
366
            
 
367
        if 'Diff is not installed on this machine' in err:
 
368
            raise TestSkipped("No external 'diff' is available")
 
369
        self.assertEqual('', err)
 
370
        # We have to skip the stuff in the middle, because it depends
 
371
        # on time.time()
 
372
        self.assertStartsWith(out, "=== added file 'goodbye'\n"
 
373
                                   "--- goodbye\t1970-01-01 00:00:00 +0000\n"
 
374
                                   "+++ goodbye\t")
 
375
        self.assertEndsWith(out, "\n@@ -0,0 +1 @@\n"
 
376
                                 "+baz\n\n")
 
377
 
 
378
 
 
379
class TestDiffOutput(DiffBase):
 
380
 
 
381
    def test_diff_output(self):
 
382
        # check that output doesn't mangle line-endings
 
383
        self.make_example_branch()
 
384
        self.build_tree_contents([('hello', 'hello world!\n')])
 
385
        output = self.run_bzr_subprocess('diff', retcode=1)[0]
 
386
        self.assert_('\n+hello world!\n' in output)