/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: Jelmer Vernooij
  • Date: 2009-04-03 21:50:40 UTC
  • mto: This revision was merged to the branch mainline in revision 4253.
  • Revision ID: jelmer@samba.org-20090403215040-lz70cjc4i8bfg9xd
Review from Aaron: 
- move generic serializer tests to bzrlib.tests.test_serializer.
- fix some formatting
- add NEWS item

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
49
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
50
# the rest of the code; add a deprecation of the old name.
51
51
 
 
52
import os
 
53
import re
 
54
import sys
 
55
import time
 
56
 
 
57
from cStringIO import StringIO
 
58
 
52
59
from bzrlib import (
53
60
    debug,
54
61
    errors,
57
64
    tree,
58
65
    )
59
66
from bzrlib.branch import Branch
60
 
from bzrlib.cleanup import OperationWithCleanups
61
67
import bzrlib.config
62
68
from bzrlib.errors import (BzrError, PointlessCommit,
63
69
                           ConflictsInTree,
64
70
                           StrictCommitFailed
65
71
                           )
66
72
from bzrlib.osutils import (get_user_encoding,
67
 
                            is_inside_any,
 
73
                            kind_marker, isdir,isfile, is_inside_any,
 
74
                            is_inside_or_parent_of_any,
68
75
                            minimum_path_selection,
 
76
                            quotefn, sha_file, split_lines,
69
77
                            splitpath,
70
78
                            )
71
 
from bzrlib.trace import mutter, note, is_quiet
 
79
from bzrlib.testament import Testament
 
80
from bzrlib.trace import mutter, note, warning, is_quiet
72
81
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
73
82
from bzrlib import symbol_versioning
 
83
from bzrlib.symbol_versioning import (deprecated_passed,
 
84
        deprecated_function,
 
85
        DEPRECATED_PARAMETER)
 
86
from bzrlib.workingtree import WorkingTree
74
87
from bzrlib.urlutils import unescape_for_display
75
88
import bzrlib.ui
76
89
 
94
107
    def deleted(self, path):
95
108
        pass
96
109
 
 
110
    def escaped(self, escape_count, message):
 
111
        pass
 
112
 
97
113
    def missing(self, path):
98
114
        pass
99
115
 
132
148
 
133
149
    def completed(self, revno, rev_id):
134
150
        self._note('Committed revision %d.', revno)
135
 
        # self._note goes to the console too; so while we want to log the
136
 
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
 
        # term we should rearrange the reporting structure, but for now
138
 
        # we just mutter seperately. We mutter the revid and revno together
139
 
        # so that concurrent bzr invocations won't lead to confusion.
140
 
        mutter('Committed revid %s as revno %d.', rev_id, revno)
141
151
 
142
152
    def deleted(self, path):
143
153
        self._note('deleted %s', path)
144
154
 
 
155
    def escaped(self, escape_count, message):
 
156
        self._note("replaced %d control characters in message", escape_count)
 
157
 
145
158
    def missing(self, path):
146
159
        self._note('missing %s', path)
147
160
 
174
187
        self.reporter = reporter
175
188
        self.config = config
176
189
 
177
 
    @staticmethod
178
 
    def update_revprops(revprops, branch, authors=None, author=None,
179
 
                        local=False, possible_master_transports=None):
180
 
        if revprops is None:
181
 
            revprops = {}
182
 
        if possible_master_transports is None:
183
 
            possible_master_transports = []
184
 
        if not 'branch-nick' in revprops:
185
 
            revprops['branch-nick'] = branch._get_nick(
186
 
                local,
187
 
                possible_master_transports)
188
 
        if authors is not None:
189
 
            if author is not None:
190
 
                raise AssertionError('Specifying both author and authors '
191
 
                        'is not allowed. Specify just authors instead')
192
 
            if 'author' in revprops or 'authors' in revprops:
193
 
                # XXX: maybe we should just accept one of them?
194
 
                raise AssertionError('author property given twice')
195
 
            if authors:
196
 
                for individual in authors:
197
 
                    if '\n' in individual:
198
 
                        raise AssertionError('\\n is not a valid character '
199
 
                                'in an author identity')
200
 
                revprops['authors'] = '\n'.join(authors)
201
 
        if author is not None:
202
 
            symbol_versioning.warn('The parameter author was deprecated'
203
 
                   ' in version 1.13. Use authors instead',
204
 
                   DeprecationWarning)
205
 
            if 'author' in revprops or 'authors' in revprops:
206
 
                # XXX: maybe we should just accept one of them?
207
 
                raise AssertionError('author property given twice')
208
 
            if '\n' in author:
209
 
                raise AssertionError('\\n is not a valid character '
210
 
                        'in an author identity')
211
 
            revprops['authors'] = author
212
 
        return revprops
213
 
 
214
190
    def commit(self,
215
191
               message=None,
216
192
               timestamp=None,
233
209
        """Commit working copy as a new revision.
234
210
 
235
211
        :param message: the commit message (it or message_callback is required)
236
 
        :param message_callback: A callback: message = message_callback(cmt_obj)
237
212
 
238
213
        :param timestamp: if not None, seconds-since-epoch for a
239
214
            postdated/predated commit.
240
215
 
241
 
        :param specific_files: If not None, commit only those files. An empty
242
 
            list means 'commit no files'.
 
216
        :param specific_files: If true, commit only those files.
243
217
 
244
218
        :param rev_id: If set, use this as the new revision id.
245
219
            Useful for test or import commands that need to tightly
263
237
            commit. Pending changes to excluded files will be ignored by the
264
238
            commit.
265
239
        """
266
 
        operation = OperationWithCleanups(self._commit)
267
 
        self.revprops = revprops or {}
268
 
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
269
 
        self.config = config or self.config
270
 
        return operation.run(
271
 
               message=message,
272
 
               timestamp=timestamp,
273
 
               timezone=timezone,
274
 
               committer=committer,
275
 
               specific_files=specific_files,
276
 
               rev_id=rev_id,
277
 
               allow_pointless=allow_pointless,
278
 
               strict=strict,
279
 
               verbose=verbose,
280
 
               working_tree=working_tree,
281
 
               local=local,
282
 
               reporter=reporter,
283
 
               message_callback=message_callback,
284
 
               recursive=recursive,
285
 
               exclude=exclude,
286
 
               possible_master_transports=possible_master_transports)
287
 
 
288
 
    def _commit(self, operation, message, timestamp, timezone, committer,
289
 
            specific_files, rev_id, allow_pointless, strict, verbose,
290
 
            working_tree, local, reporter, message_callback, recursive,
291
 
            exclude, possible_master_transports):
292
240
        mutter('preparing to commit')
293
241
 
294
242
        if working_tree is None:
317
265
            self.exclude = []
318
266
        self.local = local
319
267
        self.master_branch = None
 
268
        self.master_locked = False
320
269
        self.recursive = recursive
321
270
        self.rev_id = None
322
 
        # self.specific_files is None to indicate no filter, or any iterable to
323
 
        # indicate a filter - [] means no files at all, as per iter_changes.
324
271
        if specific_files is not None:
325
272
            self.specific_files = sorted(
326
273
                minimum_path_selection(specific_files))
328
275
            self.specific_files = None
329
276
            
330
277
        self.allow_pointless = allow_pointless
 
278
        self.revprops = revprops
331
279
        self.message_callback = message_callback
332
280
        self.timestamp = timestamp
333
281
        self.timezone = timezone
336
284
        self.verbose = verbose
337
285
 
338
286
        self.work_tree.lock_write()
339
 
        operation.add_cleanup(self.work_tree.unlock)
340
287
        self.parents = self.work_tree.get_parent_ids()
341
288
        # We can use record_iter_changes IFF iter_changes is compatible with
342
289
        # the command line parameters, and the repository has fast delta
343
290
        # generation. See bug 347649.
344
291
        self.use_record_iter_changes = (
 
292
            not self.specific_files and
345
293
            not self.exclude and 
346
294
            not self.branch.repository._format.supports_tree_reference and
347
295
            (self.branch.repository._format.fast_deltas or
348
296
             len(self.parents) < 2))
349
297
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
350
 
        operation.add_cleanup(self.pb.finished)
351
298
        self.basis_revid = self.work_tree.last_revision()
352
299
        self.basis_tree = self.work_tree.basis_tree()
353
300
        self.basis_tree.lock_read()
354
 
        operation.add_cleanup(self.basis_tree.unlock)
355
 
        # Cannot commit with conflicts present.
356
 
        if len(self.work_tree.conflicts()) > 0:
357
 
            raise ConflictsInTree
358
 
 
359
 
        # Setup the bound branch variables as needed.
360
 
        self._check_bound_branch(operation, possible_master_transports)
361
 
 
362
 
        # Check that the working tree is up to date
363
 
        old_revno, new_revno = self._check_out_of_date_tree()
364
 
 
365
 
        # Complete configuration setup
366
 
        if reporter is not None:
367
 
            self.reporter = reporter
368
 
        elif self.reporter is None:
369
 
            self.reporter = self._select_reporter()
370
 
        if self.config is None:
371
 
            self.config = self.branch.get_config()
372
 
 
373
 
        self._set_specific_file_ids()
374
 
 
375
 
        # Setup the progress bar. As the number of files that need to be
376
 
        # committed in unknown, progress is reported as stages.
377
 
        # We keep track of entries separately though and include that
378
 
        # information in the progress bar during the relevant stages.
379
 
        self.pb_stage_name = ""
380
 
        self.pb_stage_count = 0
381
 
        self.pb_stage_total = 5
382
 
        if self.bound_branch:
383
 
            self.pb_stage_total += 1
384
 
        self.pb.show_pct = False
385
 
        self.pb.show_spinner = False
386
 
        self.pb.show_eta = False
387
 
        self.pb.show_count = True
388
 
        self.pb.show_bar = True
389
 
 
390
 
        self._gather_parents()
391
 
        # After a merge, a selected file commit is not supported.
392
 
        # See 'bzr help merge' for an explanation as to why.
393
 
        if len(self.parents) > 1 and self.specific_files is not None:
394
 
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
395
 
        # Excludes are a form of selected file commit.
396
 
        if len(self.parents) > 1 and self.exclude:
397
 
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
398
 
 
399
 
        # Collect the changes
400
 
        self._set_progress_stage("Collecting changes", counter=True)
401
 
        self.builder = self.branch.get_commit_builder(self.parents,
402
 
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
403
 
 
404
301
        try:
405
 
            self.builder.will_record_deletes()
406
 
            # find the location being committed to
407
 
            if self.bound_branch:
408
 
                master_location = self.master_branch.base
409
 
            else:
410
 
                master_location = self.branch.base
411
 
 
412
 
            # report the start of the commit
413
 
            self.reporter.started(new_revno, self.rev_id, master_location)
414
 
 
415
 
            self._update_builder_with_changes()
416
 
            self._check_pointless()
417
 
 
418
 
            # TODO: Now the new inventory is known, check for conflicts.
419
 
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
420
 
            # weave lines, because nothing should be recorded until it is known
421
 
            # that commit will succeed.
422
 
            self._set_progress_stage("Saving data locally")
423
 
            self.builder.finish_inventory()
424
 
 
425
 
            # Prompt the user for a commit message if none provided
426
 
            message = message_callback(self)
427
 
            self.message = message
428
 
 
429
 
            # Add revision data to the local branch
430
 
            self.rev_id = self.builder.commit(self.message)
431
 
 
432
 
        except Exception, e:
433
 
            mutter("aborting commit write group because of exception:")
434
 
            trace.log_exception_quietly()
435
 
            note("aborting commit write group: %r" % (e,))
436
 
            self.builder.abort()
437
 
            raise
438
 
 
439
 
        self._process_pre_hooks(old_revno, new_revno)
440
 
 
441
 
        # Upload revision data to the master.
442
 
        # this will propagate merged revisions too if needed.
443
 
        if self.bound_branch:
444
 
            self._set_progress_stage("Uploading data to master branch")
445
 
            # 'commit' to the master first so a timeout here causes the
446
 
            # local branch to be out of date
447
 
            self.master_branch.import_last_revision_info(
448
 
                self.branch.repository, new_revno, self.rev_id)
449
 
 
450
 
        # and now do the commit locally.
451
 
        self.branch.set_last_revision_info(new_revno, self.rev_id)
452
 
 
453
 
        # Make the working tree be up to date with the branch. This
454
 
        # includes automatic changes scheduled to be made to the tree, such
455
 
        # as updating its basis and unversioning paths that were missing.
456
 
        self.work_tree.unversion(self.deleted_ids)
457
 
        self._set_progress_stage("Updating the working tree")
458
 
        self.work_tree.update_basis_by_delta(self.rev_id,
459
 
             self.builder.get_basis_delta())
460
 
        self.reporter.completed(new_revno, self.rev_id)
461
 
        self._process_post_hooks(old_revno, new_revno)
 
302
            # Cannot commit with conflicts present.
 
303
            if len(self.work_tree.conflicts()) > 0:
 
304
                raise ConflictsInTree
 
305
 
 
306
            # Setup the bound branch variables as needed.
 
307
            self._check_bound_branch(possible_master_transports)
 
308
 
 
309
            # Check that the working tree is up to date
 
310
            old_revno, new_revno = self._check_out_of_date_tree()
 
311
 
 
312
            # Complete configuration setup
 
313
            if reporter is not None:
 
314
                self.reporter = reporter
 
315
            elif self.reporter is None:
 
316
                self.reporter = self._select_reporter()
 
317
            if self.config is None:
 
318
                self.config = self.branch.get_config()
 
319
 
 
320
            self._set_specific_file_ids()
 
321
 
 
322
            # Setup the progress bar. As the number of files that need to be
 
323
            # committed in unknown, progress is reported as stages.
 
324
            # We keep track of entries separately though and include that
 
325
            # information in the progress bar during the relevant stages.
 
326
            self.pb_stage_name = ""
 
327
            self.pb_stage_count = 0
 
328
            self.pb_stage_total = 5
 
329
            if self.bound_branch:
 
330
                self.pb_stage_total += 1
 
331
            self.pb.show_pct = False
 
332
            self.pb.show_spinner = False
 
333
            self.pb.show_eta = False
 
334
            self.pb.show_count = True
 
335
            self.pb.show_bar = True
 
336
 
 
337
            self._gather_parents()
 
338
            # After a merge, a selected file commit is not supported.
 
339
            # See 'bzr help merge' for an explanation as to why.
 
340
            if len(self.parents) > 1 and self.specific_files:
 
341
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
 
342
            # Excludes are a form of selected file commit.
 
343
            if len(self.parents) > 1 and self.exclude:
 
344
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
 
345
 
 
346
            # Collect the changes
 
347
            self._set_progress_stage("Collecting changes", counter=True)
 
348
            self.builder = self.branch.get_commit_builder(self.parents,
 
349
                self.config, timestamp, timezone, committer, revprops, rev_id)
 
350
 
 
351
            try:
 
352
                self.builder.will_record_deletes()
 
353
                # find the location being committed to
 
354
                if self.bound_branch:
 
355
                    master_location = self.master_branch.base
 
356
                else:
 
357
                    master_location = self.branch.base
 
358
 
 
359
                # report the start of the commit
 
360
                self.reporter.started(new_revno, self.rev_id, master_location)
 
361
 
 
362
                self._update_builder_with_changes()
 
363
                self._check_pointless()
 
364
 
 
365
                # TODO: Now the new inventory is known, check for conflicts.
 
366
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
 
367
                # weave lines, because nothing should be recorded until it is known
 
368
                # that commit will succeed.
 
369
                self._set_progress_stage("Saving data locally")
 
370
                self.builder.finish_inventory()
 
371
 
 
372
                # Prompt the user for a commit message if none provided
 
373
                message = message_callback(self)
 
374
                self.message = message
 
375
                self._escape_commit_message()
 
376
 
 
377
                # Add revision data to the local branch
 
378
                self.rev_id = self.builder.commit(self.message)
 
379
 
 
380
            except Exception, e:
 
381
                mutter("aborting commit write group because of exception:")
 
382
                trace.log_exception_quietly()
 
383
                note("aborting commit write group: %r" % (e,))
 
384
                self.builder.abort()
 
385
                raise
 
386
 
 
387
            self._process_pre_hooks(old_revno, new_revno)
 
388
 
 
389
            # Upload revision data to the master.
 
390
            # this will propagate merged revisions too if needed.
 
391
            if self.bound_branch:
 
392
                self._set_progress_stage("Uploading data to master branch")
 
393
                # 'commit' to the master first so a timeout here causes the
 
394
                # local branch to be out of date
 
395
                self.master_branch.import_last_revision_info(
 
396
                    self.branch.repository, new_revno, self.rev_id)
 
397
 
 
398
            # and now do the commit locally.
 
399
            self.branch.set_last_revision_info(new_revno, self.rev_id)
 
400
 
 
401
            # Make the working tree up to date with the branch
 
402
            self._set_progress_stage("Updating the working tree")
 
403
            self.work_tree.update_basis_by_delta(self.rev_id,
 
404
                 self.builder.get_basis_delta())
 
405
            self.reporter.completed(new_revno, self.rev_id)
 
406
            self._process_post_hooks(old_revno, new_revno)
 
407
        finally:
 
408
            self._cleanup()
462
409
        return self.rev_id
463
410
 
464
411
    def _select_reporter(self):
486
433
            return
487
434
        raise PointlessCommit()
488
435
 
489
 
    def _check_bound_branch(self, operation, possible_master_transports=None):
 
436
    def _check_bound_branch(self, possible_master_transports=None):
490
437
        """Check to see if the local branch is bound.
491
438
 
492
439
        If it is bound, then most of the commit will actually be
527
474
        # so grab the lock
528
475
        self.bound_branch = self.branch
529
476
        self.master_branch.lock_write()
530
 
        operation.add_cleanup(self.master_branch.unlock)
 
477
        self.master_locked = True
531
478
 
532
479
    def _check_out_of_date_tree(self):
533
480
        """Check that the working tree is up to date.
618
565
                     old_revno, old_revid, new_revno, self.rev_id,
619
566
                     tree_delta, future_tree)
620
567
 
 
568
    def _cleanup(self):
 
569
        """Cleanup any open locks, progress bars etc."""
 
570
        cleanups = [self._cleanup_bound_branch,
 
571
                    self.basis_tree.unlock,
 
572
                    self.work_tree.unlock,
 
573
                    self.pb.finished]
 
574
        found_exception = None
 
575
        for cleanup in cleanups:
 
576
            try:
 
577
                cleanup()
 
578
            # we want every cleanup to run no matter what.
 
579
            # so we have a catchall here, but we will raise the
 
580
            # last encountered exception up the stack: and
 
581
            # typically this will be useful enough.
 
582
            except Exception, e:
 
583
                found_exception = e
 
584
        if found_exception is not None:
 
585
            # don't do a plan raise, because the last exception may have been
 
586
            # trashed, e is our sure-to-work exception even though it loses the
 
587
            # full traceback. XXX: RBC 20060421 perhaps we could check the
 
588
            # exc_info and if its the same one do a plain raise otherwise
 
589
            # 'raise e' as we do now.
 
590
            raise e
 
591
 
 
592
    def _cleanup_bound_branch(self):
 
593
        """Executed at the end of a try/finally to cleanup a bound branch.
 
594
 
 
595
        If the branch wasn't bound, this is a no-op.
 
596
        If it was, it resents self.branch to the local branch, instead
 
597
        of being the master.
 
598
        """
 
599
        if not self.bound_branch:
 
600
            return
 
601
        if self.master_locked:
 
602
            self.master_branch.unlock()
 
603
 
 
604
    def _escape_commit_message(self):
 
605
        """Replace xml-incompatible control characters."""
 
606
        # FIXME: RBC 20060419 this should be done by the revision
 
607
        # serialiser not by commit. Then we can also add an unescaper
 
608
        # in the deserializer and start roundtripping revision messages
 
609
        # precisely. See repository_implementations/test_repository.py
 
610
 
 
611
        # Python strings can include characters that can't be
 
612
        # represented in well-formed XML; escape characters that
 
613
        # aren't listed in the XML specification
 
614
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
 
615
        self.message, escape_count = re.subn(
 
616
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
 
617
            lambda match: match.group(0).encode('unicode_escape'),
 
618
            self.message)
 
619
        if escape_count:
 
620
            self.reporter.escaped(escape_count, self.message)
 
621
 
621
622
    def _gather_parents(self):
622
623
        """Record the parents of a merge for merge detection."""
623
624
        # TODO: Make sure that this list doesn't contain duplicate
638
639
        """Update the commit builder with the data about what has changed.
639
640
        """
640
641
        exclude = self.exclude
641
 
        specific_files = self.specific_files
 
642
        specific_files = self.specific_files or []
642
643
        mutter("Selecting files for commit with filter %s", specific_files)
643
644
 
644
645
        self._check_strict()
645
646
        if self.use_record_iter_changes:
646
 
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
647
 
                specific_files=specific_files)
 
647
            iter_changes = self.work_tree.iter_changes(self.basis_tree)
648
648
            iter_changes = self._filter_iter_changes(iter_changes)
649
649
            for file_id, path, fs_hash in self.builder.record_iter_changes(
650
650
                self.work_tree, self.basis_revid, iter_changes):
703
703
                            reporter.snapshot_change('modified', new_path)
704
704
            self._next_progress_entry()
705
705
        # Unversion IDs that were found to be deleted
706
 
        self.deleted_ids = deleted_ids
 
706
        self.work_tree.unversion(deleted_ids)
707
707
 
708
708
    def _record_unselected(self):
709
709
        # If specific files are selected, then all un-selected files must be
822
822
                # _update_builder_with_changes.
823
823
                continue
824
824
            content_summary = self.work_tree.path_content_summary(path)
825
 
            kind = content_summary[0]
826
825
            # Note that when a filter of specific files is given, we must only
827
826
            # skip/record deleted files matching that filter.
828
827
            if not specific_files or is_inside_any(specific_files, path):
829
 
                if kind == 'missing':
 
828
                if content_summary[0] == 'missing':
830
829
                    if not deleted_paths:
831
830
                        # path won't have been split yet.
832
831
                        path_segments = splitpath(path)
839
838
                    continue
840
839
            # TODO: have the builder do the nested commit just-in-time IF and
841
840
            # only if needed.
842
 
            if kind == 'tree-reference':
 
841
            if content_summary[0] == 'tree-reference':
843
842
                # enforce repository nested tree policy.
844
843
                if (not self.work_tree.supports_tree_reference() or
845
844
                    # repository does not support it either.
846
845
                    not self.branch.repository._format.supports_tree_reference):
847
 
                    kind = 'directory'
848
 
                    content_summary = (kind, None, None, None)
849
 
                elif self.recursive == 'down':
 
846
                    content_summary = ('directory',) + content_summary[1:]
 
847
            kind = content_summary[0]
 
848
            # TODO: specific_files filtering before nested tree processing
 
849
            if kind == 'tree-reference':
 
850
                if self.recursive == 'down':
850
851
                    nested_revision_id = self._commit_nested_tree(
851
852
                        file_id, path)
852
 
                    content_summary = (kind, None, None, nested_revision_id)
 
853
                    content_summary = content_summary[:3] + (
 
854
                        nested_revision_id,)
853
855
                else:
854
 
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
855
 
                    content_summary = (kind, None, None, nested_revision_id)
 
856
                    content_summary = content_summary[:3] + (
 
857
                        self.work_tree.get_reference_revision(file_id),)
856
858
 
857
859
            # Record an entry for this item
858
860
            # Note: I don't particularly want to have the existing_ie
864
866
                content_summary)
865
867
 
866
868
        # Unversion IDs that were found to be deleted
867
 
        self.deleted_ids = deleted_ids
 
869
        self.work_tree.unversion(deleted_ids)
868
870
 
869
871
    def _commit_nested_tree(self, file_id, path):
870
872
        "Commit a nested tree."