/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/remote.py

Fix 1 more lock-related test failure.

* tests/test_rename_map.py:
(TestRenameMap.test_guess_renames_preserves_children): Add the
forgotten unlock.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2010 Canonical Ltd
 
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
 
17
# TODO: At some point, handle upgrades by just passing the whole request
 
18
# across to run on the server.
 
19
 
17
20
import bz2
18
21
 
19
22
from bzrlib import (
20
 
    bencode,
21
23
    branch,
22
24
    bzrdir,
23
25
    config,
24
26
    debug,
25
27
    errors,
26
28
    graph,
27
 
    lock,
28
29
    lockdir,
 
30
    pack,
29
31
    repository,
30
 
    repository as _mod_repository,
31
32
    revision,
32
33
    revision as _mod_revision,
33
 
    static_tuple,
34
34
    symbol_versioning,
 
35
    urlutils,
35
36
)
36
 
from bzrlib.branch import BranchReferenceFormat, BranchWriteLockResult
 
37
from bzrlib.branch import BranchReferenceFormat
37
38
from bzrlib.bzrdir import BzrDir, RemoteBzrDirFormat
38
 
from bzrlib.decorators import needs_read_lock, needs_write_lock, only_raises
 
39
from bzrlib.decorators import needs_read_lock, needs_write_lock
39
40
from bzrlib.errors import (
40
41
    NoSuchRevision,
41
42
    SmartProtocolError,
43
44
from bzrlib.lockable_files import LockableFiles
44
45
from bzrlib.smart import client, vfs, repository as smart_repo
45
46
from bzrlib.revision import ensure_null, NULL_REVISION
46
 
from bzrlib.repository import RepositoryWriteLockResult
47
47
from bzrlib.trace import mutter, note, warning
 
48
from bzrlib.util import bencode
48
49
 
49
50
 
50
51
class _RpcHelper(object):
62
63
        except errors.ErrorFromSmartServer, err:
63
64
            self._translate_error(err, **err_context)
64
65
 
65
 
    def _call_with_body_bytes(self, method, args, body_bytes, **err_context):
66
 
        try:
67
 
            return self._client.call_with_body_bytes(method, args, body_bytes)
68
 
        except errors.ErrorFromSmartServer, err:
69
 
            self._translate_error(err, **err_context)
70
 
 
71
66
    def _call_with_body_bytes_expecting_body(self, method, args, body_bytes,
72
67
                                             **err_context):
73
68
        try:
92
87
class RemoteBzrDir(BzrDir, _RpcHelper):
93
88
    """Control directory on a remote server, accessed via bzr:// or similar."""
94
89
 
95
 
    def __init__(self, transport, format, _client=None, _force_probe=False):
 
90
    def __init__(self, transport, format, _client=None):
96
91
        """Construct a RemoteBzrDir.
97
92
 
98
93
        :param _client: Private parameter for testing. Disables probing and the
102
97
        # this object holds a delegated bzrdir that uses file-level operations
103
98
        # to talk to the other side
104
99
        self._real_bzrdir = None
105
 
        self._has_working_tree = None
106
100
        # 1-shot cache for the call pattern 'create_branch; open_branch' - see
107
101
        # create_branch for details.
108
102
        self._next_open_branch_result = None
112
106
            self._client = client._SmartClient(medium)
113
107
        else:
114
108
            self._client = _client
115
 
            if not _force_probe:
116
 
                return
117
 
 
118
 
        self._probe_bzrdir()
119
 
 
120
 
    def __repr__(self):
121
 
        return '%s(%r)' % (self.__class__.__name__, self._client)
122
 
 
123
 
    def _probe_bzrdir(self):
124
 
        medium = self._client._medium
 
109
            return
 
110
 
125
111
        path = self._path_for_remote_call(self._client)
126
 
        if medium._is_remote_before((2, 1)):
127
 
            self._rpc_open(path)
128
 
            return
129
 
        try:
130
 
            self._rpc_open_2_1(path)
131
 
            return
132
 
        except errors.UnknownSmartMethod:
133
 
            medium._remember_remote_is_before((2, 1))
134
 
            self._rpc_open(path)
135
 
 
136
 
    def _rpc_open_2_1(self, path):
137
 
        response = self._call('BzrDir.open_2.1', path)
138
 
        if response == ('no',):
139
 
            raise errors.NotBranchError(path=self.root_transport.base)
140
 
        elif response[0] == 'yes':
141
 
            if response[1] == 'yes':
142
 
                self._has_working_tree = True
143
 
            elif response[1] == 'no':
144
 
                self._has_working_tree = False
145
 
            else:
146
 
                raise errors.UnexpectedSmartServerResponse(response)
147
 
        else:
148
 
            raise errors.UnexpectedSmartServerResponse(response)
149
 
 
150
 
    def _rpc_open(self, path):
151
112
        response = self._call('BzrDir.open', path)
152
113
        if response not in [('yes',), ('no',)]:
153
114
            raise errors.UnexpectedSmartServerResponse(response)
154
115
        if response == ('no',):
155
 
            raise errors.NotBranchError(path=self.root_transport.base)
 
116
            raise errors.NotBranchError(path=transport.base)
156
117
 
157
118
    def _ensure_real(self):
158
119
        """Ensure that there is a _real_bzrdir set.
160
121
        Used before calls to self._real_bzrdir.
161
122
        """
162
123
        if not self._real_bzrdir:
163
 
            if 'hpssvfs' in debug.debug_flags:
164
 
                import traceback
165
 
                warning('VFS BzrDir access triggered\n%s',
166
 
                    ''.join(traceback.format_stack()))
167
124
            self._real_bzrdir = BzrDir.open_from_transport(
168
125
                self.root_transport, _server_formats=False)
169
126
            self._format._network_name = \
245
202
        self._ensure_real()
246
203
        self._real_bzrdir.destroy_repository()
247
204
 
248
 
    def create_branch(self, name=None):
 
205
    def create_branch(self):
249
206
        # as per meta1 formats - just delegate to the format object which may
250
207
        # be parameterised.
251
 
        real_branch = self._format.get_branch_format().initialize(self,
252
 
            name=name)
 
208
        real_branch = self._format.get_branch_format().initialize(self)
253
209
        if not isinstance(real_branch, RemoteBranch):
254
 
            result = RemoteBranch(self, self.find_repository(), real_branch,
255
 
                                  name=name)
 
210
            result = RemoteBranch(self, self.find_repository(), real_branch)
256
211
        else:
257
212
            result = real_branch
258
213
        # BzrDir.clone_on_transport() uses the result of create_branch but does
264
219
        self._next_open_branch_result = result
265
220
        return result
266
221
 
267
 
    def destroy_branch(self, name=None):
 
222
    def destroy_branch(self):
268
223
        """See BzrDir.destroy_branch"""
269
224
        self._ensure_real()
270
 
        self._real_bzrdir.destroy_branch(name=name)
 
225
        self._real_bzrdir.destroy_branch()
271
226
        self._next_open_branch_result = None
272
227
 
273
228
    def create_workingtree(self, revision_id=None, from_branch=None):
292
247
    def _get_branch_reference(self):
293
248
        path = self._path_for_remote_call(self._client)
294
249
        medium = self._client._medium
295
 
        candidate_calls = [
296
 
            ('BzrDir.open_branchV3', (2, 1)),
297
 
            ('BzrDir.open_branchV2', (1, 13)),
298
 
            ('BzrDir.open_branch', None),
299
 
            ]
300
 
        for verb, required_version in candidate_calls:
301
 
            if required_version and medium._is_remote_before(required_version):
302
 
                continue
 
250
        if not medium._is_remote_before((1, 13)):
303
251
            try:
304
 
                response = self._call(verb, path)
 
252
                response = self._call('BzrDir.open_branchV2', path)
 
253
                if response[0] not in ('ref', 'branch'):
 
254
                    raise errors.UnexpectedSmartServerResponse(response)
 
255
                return response
305
256
            except errors.UnknownSmartMethod:
306
 
                if required_version is None:
307
 
                    raise
308
 
                medium._remember_remote_is_before(required_version)
309
 
            else:
310
 
                break
311
 
        if verb == 'BzrDir.open_branch':
312
 
            if response[0] != 'ok':
313
 
                raise errors.UnexpectedSmartServerResponse(response)
314
 
            if response[1] != '':
315
 
                return ('ref', response[1])
316
 
            else:
317
 
                return ('branch', '')
318
 
        if response[0] not in ('ref', 'branch'):
 
257
                medium._remember_remote_is_before((1, 13))
 
258
        response = self._call('BzrDir.open_branch', path)
 
259
        if response[0] != 'ok':
319
260
            raise errors.UnexpectedSmartServerResponse(response)
320
 
        return response
 
261
        if response[1] != '':
 
262
            return ('ref', response[1])
 
263
        else:
 
264
            return ('branch', '')
321
265
 
322
266
    def _get_tree_branch(self):
323
267
        """See BzrDir._get_tree_branch()."""
324
268
        return None, self.open_branch()
325
269
 
326
 
    def open_branch(self, name=None, unsupported=False,
327
 
                    ignore_fallbacks=False):
328
 
        if unsupported:
 
270
    def open_branch(self, _unsupported=False, ignore_fallbacks=False):
 
271
        if _unsupported:
329
272
            raise NotImplementedError('unsupported flag support not implemented yet.')
330
273
        if self._next_open_branch_result is not None:
331
274
            # See create_branch for details.
336
279
        if response[0] == 'ref':
337
280
            # a branch reference, use the existing BranchReference logic.
338
281
            format = BranchReferenceFormat()
339
 
            return format.open(self, name=name, _found=True,
340
 
                location=response[1], ignore_fallbacks=ignore_fallbacks)
 
282
            return format.open(self, _found=True, location=response[1],
 
283
                ignore_fallbacks=ignore_fallbacks)
341
284
        branch_format_name = response[1]
342
285
        if not branch_format_name:
343
286
            branch_format_name = None
344
287
        format = RemoteBranchFormat(network_name=branch_format_name)
345
288
        return RemoteBranch(self, self.find_repository(), format=format,
346
 
            setup_stacking=not ignore_fallbacks, name=name)
 
289
            setup_stacking=not ignore_fallbacks)
347
290
 
348
291
    def _open_repo_v1(self, path):
349
292
        verb = 'BzrDir.find_repository'
410
353
        else:
411
354
            raise errors.NoRepositoryPresent(self)
412
355
 
413
 
    def has_workingtree(self):
414
 
        if self._has_working_tree is None:
415
 
            self._ensure_real()
416
 
            self._has_working_tree = self._real_bzrdir.has_workingtree()
417
 
        return self._has_working_tree
418
 
 
419
356
    def open_workingtree(self, recommend_upgrade=True):
420
 
        if self.has_workingtree():
 
357
        self._ensure_real()
 
358
        if self._real_bzrdir.has_workingtree():
421
359
            raise errors.NotLocalUrl(self.root_transport)
422
360
        else:
423
361
            raise errors.NoWorkingTree(self.root_transport.base)
426
364
        """Return the path to be used for this bzrdir in a remote call."""
427
365
        return client.remote_path_from_transport(self.root_transport)
428
366
 
429
 
    def get_branch_transport(self, branch_format, name=None):
 
367
    def get_branch_transport(self, branch_format):
430
368
        self._ensure_real()
431
 
        return self._real_bzrdir.get_branch_transport(branch_format, name=name)
 
369
        return self._real_bzrdir.get_branch_transport(branch_format)
432
370
 
433
371
    def get_repository_transport(self, repository_format):
434
372
        self._ensure_real()
486
424
        self._custom_format = None
487
425
        self._network_name = None
488
426
        self._creating_bzrdir = None
489
 
        self._supports_chks = None
490
427
        self._supports_external_lookups = None
491
428
        self._supports_tree_reference = None
492
429
        self._rich_root_data = None
493
430
 
494
 
    def __repr__(self):
495
 
        return "%s(_network_name=%r)" % (self.__class__.__name__,
496
 
            self._network_name)
497
 
 
498
431
    @property
499
432
    def fast_deltas(self):
500
433
        self._ensure_real()
508
441
        return self._rich_root_data
509
442
 
510
443
    @property
511
 
    def supports_chks(self):
512
 
        if self._supports_chks is None:
513
 
            self._ensure_real()
514
 
            self._supports_chks = self._custom_format.supports_chks
515
 
        return self._supports_chks
516
 
 
517
 
    @property
518
444
    def supports_external_lookups(self):
519
445
        if self._supports_external_lookups is None:
520
446
            self._ensure_real()
621
547
        return self._custom_format._fetch_reconcile
622
548
 
623
549
    def get_format_description(self):
624
 
        self._ensure_real()
625
 
        return 'Remote: ' + self._custom_format.get_format_description()
 
550
        return 'bzr remote repository'
626
551
 
627
552
    def __eq__(self, other):
628
553
        return self.__class__ is other.__class__
629
554
 
 
555
    def check_conversion_target(self, target_format):
 
556
        if self.rich_root_data and not target_format.rich_root_data:
 
557
            raise errors.BadConversionTarget(
 
558
                'Does not support rich root data.', target_format)
 
559
        if (self.supports_tree_reference and
 
560
            not getattr(target_format, 'supports_tree_reference', False)):
 
561
            raise errors.BadConversionTarget(
 
562
                'Does not support nested trees', target_format)
 
563
 
630
564
    def network_name(self):
631
565
        if self._network_name:
632
566
            return self._network_name
634
568
        return self._creating_repo._real_repository._format.network_name()
635
569
 
636
570
    @property
637
 
    def pack_compresses(self):
638
 
        self._ensure_real()
639
 
        return self._custom_format.pack_compresses
640
 
 
641
 
    @property
642
571
    def _serializer(self):
643
572
        self._ensure_real()
644
573
        return self._custom_format._serializer
645
574
 
646
575
 
647
 
class RemoteRepository(_RpcHelper, lock._RelockDebugMixin,
648
 
    bzrdir.ControlComponent):
 
576
class RemoteRepository(_RpcHelper):
649
577
    """Repository accessed over rpc.
650
578
 
651
579
    For the moment most operations are performed using local transport-backed
694
622
        # Additional places to query for data.
695
623
        self._fallback_repositories = []
696
624
 
697
 
    @property
698
 
    def user_transport(self):
699
 
        return self.bzrdir.user_transport
700
 
 
701
 
    @property
702
 
    def control_transport(self):
703
 
        # XXX: Normally you shouldn't directly get at the remote repository
704
 
        # transport, but I'm not sure it's worth making this method
705
 
        # optional -- mbp 2010-04-21
706
 
        return self.bzrdir.get_repository_transport(None)
707
 
        
708
625
    def __str__(self):
709
626
        return "%s(%s)" % (self.__class__.__name__, self.base)
710
627
 
753
670
        self._ensure_real()
754
671
        return self._real_repository.suspend_write_group()
755
672
 
756
 
    def get_missing_parent_inventories(self, check_for_missing_texts=True):
757
 
        self._ensure_real()
758
 
        return self._real_repository.get_missing_parent_inventories(
759
 
            check_for_missing_texts=check_for_missing_texts)
760
 
 
761
 
    def _get_rev_id_for_revno_vfs(self, revno, known_pair):
762
 
        self._ensure_real()
763
 
        return self._real_repository.get_rev_id_for_revno(
764
 
            revno, known_pair)
765
 
 
766
 
    def get_rev_id_for_revno(self, revno, known_pair):
767
 
        """See Repository.get_rev_id_for_revno."""
768
 
        path = self.bzrdir._path_for_remote_call(self._client)
769
 
        try:
770
 
            if self._client._medium._is_remote_before((1, 17)):
771
 
                return self._get_rev_id_for_revno_vfs(revno, known_pair)
772
 
            response = self._call(
773
 
                'Repository.get_rev_id_for_revno', path, revno, known_pair)
774
 
        except errors.UnknownSmartMethod:
775
 
            self._client._medium._remember_remote_is_before((1, 17))
776
 
            return self._get_rev_id_for_revno_vfs(revno, known_pair)
777
 
        if response[0] == 'ok':
778
 
            return True, response[1]
779
 
        elif response[0] == 'history-incomplete':
780
 
            known_pair = response[1:3]
781
 
            for fallback in self._fallback_repositories:
782
 
                found, result = fallback.get_rev_id_for_revno(revno, known_pair)
783
 
                if found:
784
 
                    return True, result
785
 
                else:
786
 
                    known_pair = result
787
 
            # Not found in any fallbacks
788
 
            return False, known_pair
789
 
        else:
790
 
            raise errors.UnexpectedSmartServerResponse(response)
 
673
    def get_missing_parent_inventories(self):
 
674
        self._ensure_real()
 
675
        return self._real_repository.get_missing_parent_inventories()
791
676
 
792
677
    def _ensure_real(self):
793
678
        """Ensure that there is a _real_repository set.
803
688
        invocation. If in doubt chat to the bzr network team.
804
689
        """
805
690
        if self._real_repository is None:
806
 
            if 'hpssvfs' in debug.debug_flags:
807
 
                import traceback
808
 
                warning('VFS Repository access triggered\n%s',
809
 
                    ''.join(traceback.format_stack()))
810
691
            self._unstacked_provider.missing_keys.clear()
811
692
            self.bzrdir._ensure_real()
812
693
            self._set_real_repository(
893
774
            result.add(_mod_revision.NULL_REVISION)
894
775
        return result
895
776
 
896
 
    def _has_same_fallbacks(self, other_repo):
897
 
        """Returns true if the repositories have the same fallbacks."""
898
 
        # XXX: copied from Repository; it should be unified into a base class
899
 
        # <https://bugs.edge.launchpad.net/bzr/+bug/401622>
900
 
        my_fb = self._fallback_repositories
901
 
        other_fb = other_repo._fallback_repositories
902
 
        if len(my_fb) != len(other_fb):
903
 
            return False
904
 
        for f, g in zip(my_fb, other_fb):
905
 
            if not f.has_same_location(g):
906
 
                return False
907
 
        return True
908
 
 
909
777
    def has_same_location(self, other):
910
 
        # TODO: Move to RepositoryBase and unify with the regular Repository
911
 
        # one; unfortunately the tests rely on slightly different behaviour at
912
 
        # present -- mbp 20090710
913
778
        return (self.__class__ is other.__class__ and
914
779
                self.bzrdir.transport.base == other.bzrdir.transport.base)
915
780
 
918
783
        parents_provider = self._make_parents_provider(other_repository)
919
784
        return graph.Graph(parents_provider)
920
785
 
921
 
    @needs_read_lock
922
 
    def get_known_graph_ancestry(self, revision_ids):
923
 
        """Return the known graph for a set of revision ids and their ancestors.
924
 
        """
925
 
        st = static_tuple.StaticTuple
926
 
        revision_keys = [st(r_id).intern() for r_id in revision_ids]
927
 
        known_graph = self.revisions.get_known_graph_ancestry(revision_keys)
928
 
        return graph.GraphThunkIdsToKeys(known_graph)
929
 
 
930
786
    def gather_stats(self, revid=None, committers=None):
931
787
        """See Repository.gather_stats()."""
932
788
        path = self.bzrdir._path_for_remote_call(self._client)
992
848
    def is_write_locked(self):
993
849
        return self._lock_mode == 'w'
994
850
 
995
 
    def _warn_if_deprecated(self, branch=None):
996
 
        # If we have a real repository, the check will be done there, if we
997
 
        # don't the check will be done remotely.
998
 
        pass
999
 
 
1000
851
    def lock_read(self):
1001
 
        """Lock the repository for read operations.
1002
 
 
1003
 
        :return: A bzrlib.lock.LogicalLockResult.
1004
 
        """
1005
852
        # wrong eventually - want a local lock cache context
1006
853
        if not self._lock_mode:
1007
 
            self._note_lock('r')
1008
854
            self._lock_mode = 'r'
1009
855
            self._lock_count = 1
1010
856
            self._unstacked_provider.enable_cache(cache_misses=True)
1011
857
            if self._real_repository is not None:
1012
858
                self._real_repository.lock_read()
1013
 
            for repo in self._fallback_repositories:
1014
 
                repo.lock_read()
1015
859
        else:
1016
860
            self._lock_count += 1
1017
 
        return lock.LogicalLockResult(self.unlock)
 
861
        for repo in self._fallback_repositories:
 
862
            repo.lock_read()
1018
863
 
1019
864
    def _remote_lock_write(self, token):
1020
865
        path = self.bzrdir._path_for_remote_call(self._client)
1031
876
 
1032
877
    def lock_write(self, token=None, _skip_rpc=False):
1033
878
        if not self._lock_mode:
1034
 
            self._note_lock('w')
1035
879
            if _skip_rpc:
1036
880
                if self._lock_token is not None:
1037
881
                    if token != self._lock_token:
1053
897
            self._lock_count = 1
1054
898
            cache_misses = self._real_repository is None
1055
899
            self._unstacked_provider.enable_cache(cache_misses=cache_misses)
1056
 
            for repo in self._fallback_repositories:
1057
 
                # Writes don't affect fallback repos
1058
 
                repo.lock_read()
1059
900
        elif self._lock_mode == 'r':
1060
901
            raise errors.ReadOnlyError(self)
1061
902
        else:
1062
903
            self._lock_count += 1
1063
 
        return RepositoryWriteLockResult(self.unlock, self._lock_token or None)
 
904
        for repo in self._fallback_repositories:
 
905
            # Writes don't affect fallback repos
 
906
            repo.lock_read()
 
907
        return self._lock_token or None
1064
908
 
1065
909
    def leave_lock_in_place(self):
1066
910
        if not self._lock_token:
1140
984
        else:
1141
985
            raise errors.UnexpectedSmartServerResponse(response)
1142
986
 
1143
 
    @only_raises(errors.LockNotHeld, errors.LockBroken)
1144
987
    def unlock(self):
1145
988
        if not self._lock_count:
1146
 
            return lock.cant_unlock_not_held(self)
 
989
            raise errors.LockNotHeld(self)
1147
990
        self._lock_count -= 1
1148
991
        if self._lock_count > 0:
1149
992
            return
1168
1011
                self._lock_token = None
1169
1012
                if not self._leave_lock:
1170
1013
                    self._unlock(old_token)
1171
 
        # Fallbacks are always 'lock_read()' so we don't pay attention to
1172
 
        # self._leave_lock
1173
 
        for repo in self._fallback_repositories:
1174
 
            repo.unlock()
1175
1014
 
1176
1015
    def break_lock(self):
1177
1016
        # should hand off to the network
1241
1080
        # We need to accumulate additional repositories here, to pass them in
1242
1081
        # on various RPC's.
1243
1082
        #
1244
 
        if self.is_locked():
1245
 
            # We will call fallback.unlock() when we transition to the unlocked
1246
 
            # state, so always add a lock here. If a caller passes us a locked
1247
 
            # repository, they are responsible for unlocking it later.
1248
 
            repository.lock_read()
1249
 
        self._check_fallback_repository(repository)
1250
1083
        self._fallback_repositories.append(repository)
1251
1084
        # If self._real_repository was parameterised already (e.g. because a
1252
1085
        # _real_branch had its get_stacked_on_url method called), then the
1253
1086
        # repository to be added may already be in the _real_repositories list.
1254
1087
        if self._real_repository is not None:
1255
 
            fallback_locations = [repo.user_url for repo in
 
1088
            fallback_locations = [repo.bzrdir.root_transport.base for repo in
1256
1089
                self._real_repository._fallback_repositories]
1257
 
            if repository.user_url not in fallback_locations:
 
1090
            if repository.bzrdir.root_transport.base not in fallback_locations:
1258
1091
                self._real_repository.add_fallback_repository(repository)
1259
1092
 
1260
 
    def _check_fallback_repository(self, repository):
1261
 
        """Check that this repository can fallback to repository safely.
1262
 
 
1263
 
        Raise an error if not.
1264
 
 
1265
 
        :param repository: A repository to fallback to.
1266
 
        """
1267
 
        return _mod_repository.InterRepository._assert_same_model(
1268
 
            self, repository)
1269
 
 
1270
1093
    def add_inventory(self, revid, inv, parents):
1271
1094
        self._ensure_real()
1272
1095
        return self._real_repository.add_inventory(revid, inv, parents)
1273
1096
 
1274
1097
    def add_inventory_by_delta(self, basis_revision_id, delta, new_revision_id,
1275
 
            parents, basis_inv=None, propagate_caches=False):
 
1098
                               parents):
1276
1099
        self._ensure_real()
1277
1100
        return self._real_repository.add_inventory_by_delta(basis_revision_id,
1278
 
            delta, new_revision_id, parents, basis_inv=basis_inv,
1279
 
            propagate_caches=propagate_caches)
 
1101
            delta, new_revision_id, parents)
1280
1102
 
1281
1103
    def add_revision(self, rev_id, rev, inv=None, config=None):
1282
1104
        self._ensure_real()
1288
1110
        self._ensure_real()
1289
1111
        return self._real_repository.get_inventory(revision_id)
1290
1112
 
1291
 
    def iter_inventories(self, revision_ids, ordering=None):
 
1113
    def iter_inventories(self, revision_ids):
1292
1114
        self._ensure_real()
1293
 
        return self._real_repository.iter_inventories(revision_ids, ordering)
 
1115
        return self._real_repository.iter_inventories(revision_ids)
1294
1116
 
1295
1117
    @needs_read_lock
1296
1118
    def get_revision(self, revision_id):
1360
1182
            raise errors.InternalBzrError(
1361
1183
                "May not fetch while in a write group.")
1362
1184
        # fast path same-url fetch operations
1363
 
        if (self.has_same_location(source)
1364
 
            and fetch_spec is None
1365
 
            and self._has_same_fallbacks(source)):
 
1185
        if self.has_same_location(source) and fetch_spec is None:
1366
1186
            # check that last_revision is in 'from' and then return a
1367
1187
            # no-operation.
1368
1188
            if (revision_id is not None and
1541
1361
        return self._real_repository.get_signature_text(revision_id)
1542
1362
 
1543
1363
    @needs_read_lock
1544
 
    def _get_inventory_xml(self, revision_id):
1545
 
        self._ensure_real()
1546
 
        return self._real_repository._get_inventory_xml(revision_id)
 
1364
    def get_inventory_xml(self, revision_id):
 
1365
        self._ensure_real()
 
1366
        return self._real_repository.get_inventory_xml(revision_id)
 
1367
 
 
1368
    def deserialise_inventory(self, revision_id, xml):
 
1369
        self._ensure_real()
 
1370
        return self._real_repository.deserialise_inventory(revision_id, xml)
1547
1371
 
1548
1372
    def reconcile(self, other=None, thorough=False):
1549
1373
        self._ensure_real()
1576
1400
        return self._real_repository.get_revision_reconcile(revision_id)
1577
1401
 
1578
1402
    @needs_read_lock
1579
 
    def check(self, revision_ids=None, callback_refs=None, check_repo=True):
 
1403
    def check(self, revision_ids=None):
1580
1404
        self._ensure_real()
1581
 
        return self._real_repository.check(revision_ids=revision_ids,
1582
 
            callback_refs=callback_refs, check_repo=check_repo)
 
1405
        return self._real_repository.check(revision_ids=revision_ids)
1583
1406
 
1584
1407
    def copy_content_into(self, destination, revision_id=None):
1585
1408
        self._ensure_real()
1625
1448
        return self._real_repository.inventories
1626
1449
 
1627
1450
    @needs_write_lock
1628
 
    def pack(self, hint=None, clean_obsolete_packs=False):
 
1451
    def pack(self):
1629
1452
        """Compress the data within the repository.
1630
1453
 
1631
1454
        This is not currently implemented within the smart server.
1632
1455
        """
1633
1456
        self._ensure_real()
1634
 
        return self._real_repository.pack(hint=hint, clean_obsolete_packs=clean_obsolete_packs)
 
1457
        return self._real_repository.pack()
1635
1458
 
1636
1459
    @property
1637
1460
    def revisions(self):
1725
1548
        self._ensure_real()
1726
1549
        return self._real_repository.revision_graph_can_have_wrong_parents()
1727
1550
 
1728
 
    def _find_inconsistent_revision_parents(self, revisions_iterator=None):
 
1551
    def _find_inconsistent_revision_parents(self):
1729
1552
        self._ensure_real()
1730
 
        return self._real_repository._find_inconsistent_revision_parents(
1731
 
            revisions_iterator)
 
1553
        return self._real_repository._find_inconsistent_revision_parents()
1732
1554
 
1733
1555
    def _check_for_inconsistent_revision_parents(self):
1734
1556
        self._ensure_real()
1740
1562
            providers.insert(0, other)
1741
1563
        providers.extend(r._make_parents_provider() for r in
1742
1564
                         self._fallback_repositories)
1743
 
        return graph.StackedParentsProvider(providers)
 
1565
        return graph._StackedParentsProvider(providers)
1744
1566
 
1745
1567
    def _serialise_search_recipe(self, recipe):
1746
1568
        """Serialise a graph search recipe.
1788
1610
    def insert_stream(self, stream, src_format, resume_tokens):
1789
1611
        target = self.target_repo
1790
1612
        target._unstacked_provider.missing_keys.clear()
1791
 
        candidate_calls = [('Repository.insert_stream_1.19', (1, 19))]
1792
1613
        if target._lock_token:
1793
 
            candidate_calls.append(('Repository.insert_stream_locked', (1, 14)))
1794
 
            lock_args = (target._lock_token or '',)
 
1614
            verb = 'Repository.insert_stream_locked'
 
1615
            extra_args = (target._lock_token or '',)
 
1616
            required_version = (1, 14)
1795
1617
        else:
1796
 
            candidate_calls.append(('Repository.insert_stream', (1, 13)))
1797
 
            lock_args = ()
 
1618
            verb = 'Repository.insert_stream'
 
1619
            extra_args = ()
 
1620
            required_version = (1, 13)
1798
1621
        client = target._client
1799
1622
        medium = client._medium
 
1623
        if medium._is_remote_before(required_version):
 
1624
            # No possible way this can work.
 
1625
            return self._insert_real(stream, src_format, resume_tokens)
1800
1626
        path = target.bzrdir._path_for_remote_call(client)
1801
 
        # Probe for the verb to use with an empty stream before sending the
1802
 
        # real stream to it.  We do this both to avoid the risk of sending a
1803
 
        # large request that is then rejected, and because we don't want to
1804
 
        # implement a way to buffer, rewind, or restart the stream.
1805
 
        found_verb = False
1806
 
        for verb, required_version in candidate_calls:
1807
 
            if medium._is_remote_before(required_version):
1808
 
                continue
1809
 
            if resume_tokens:
1810
 
                # We've already done the probing (and set _is_remote_before) on
1811
 
                # a previous insert.
1812
 
                found_verb = True
1813
 
                break
 
1627
        if not resume_tokens:
 
1628
            # XXX: Ugly but important for correctness, *will* be fixed during
 
1629
            # 1.13 cycle. Pushing a stream that is interrupted results in a
 
1630
            # fallback to the _real_repositories sink *with a partial stream*.
 
1631
            # Thats bad because we insert less data than bzr expected. To avoid
 
1632
            # this we do a trial push to make sure the verb is accessible, and
 
1633
            # do not fallback when actually pushing the stream. A cleanup patch
 
1634
            # is going to look at rewinding/restarting the stream/partial
 
1635
            # buffering etc.
1814
1636
            byte_stream = smart_repo._stream_to_byte_stream([], src_format)
1815
1637
            try:
1816
1638
                response = client.call_with_body_stream(
1817
 
                    (verb, path, '') + lock_args, byte_stream)
 
1639
                    (verb, path, '') + extra_args, byte_stream)
1818
1640
            except errors.UnknownSmartMethod:
1819
1641
                medium._remember_remote_is_before(required_version)
1820
 
            else:
1821
 
                found_verb = True
1822
 
                break
1823
 
        if not found_verb:
1824
 
            # Have to use VFS.
1825
 
            return self._insert_real(stream, src_format, resume_tokens)
1826
 
        self._last_inv_record = None
1827
 
        self._last_substream = None
1828
 
        if required_version < (1, 19):
1829
 
            # Remote side doesn't support inventory deltas.  Wrap the stream to
1830
 
            # make sure we don't send any.  If the stream contains inventory
1831
 
            # deltas we'll interrupt the smart insert_stream request and
1832
 
            # fallback to VFS.
1833
 
            stream = self._stop_stream_if_inventory_delta(stream)
 
1642
                return self._insert_real(stream, src_format, resume_tokens)
1834
1643
        byte_stream = smart_repo._stream_to_byte_stream(
1835
1644
            stream, src_format)
1836
1645
        resume_tokens = ' '.join(resume_tokens)
1837
1646
        response = client.call_with_body_stream(
1838
 
            (verb, path, resume_tokens) + lock_args, byte_stream)
 
1647
            (verb, path, resume_tokens) + extra_args, byte_stream)
1839
1648
        if response[0][0] not in ('ok', 'missing-basis'):
1840
1649
            raise errors.UnexpectedSmartServerResponse(response)
1841
 
        if self._last_substream is not None:
1842
 
            # The stream included an inventory-delta record, but the remote
1843
 
            # side isn't new enough to support them.  So we need to send the
1844
 
            # rest of the stream via VFS.
1845
 
            self.target_repo.refresh_data()
1846
 
            return self._resume_stream_with_vfs(response, src_format)
1847
1650
        if response[0][0] == 'missing-basis':
1848
1651
            tokens, missing_keys = bencode.bdecode_as_tuple(response[0][1])
1849
1652
            resume_tokens = tokens
1852
1655
            self.target_repo.refresh_data()
1853
1656
            return [], set()
1854
1657
 
1855
 
    def _resume_stream_with_vfs(self, response, src_format):
1856
 
        """Resume sending a stream via VFS, first resending the record and
1857
 
        substream that couldn't be sent via an insert_stream verb.
1858
 
        """
1859
 
        if response[0][0] == 'missing-basis':
1860
 
            tokens, missing_keys = bencode.bdecode_as_tuple(response[0][1])
1861
 
            # Ignore missing_keys, we haven't finished inserting yet
1862
 
        else:
1863
 
            tokens = []
1864
 
        def resume_substream():
1865
 
            # Yield the substream that was interrupted.
1866
 
            for record in self._last_substream:
1867
 
                yield record
1868
 
            self._last_substream = None
1869
 
        def resume_stream():
1870
 
            # Finish sending the interrupted substream
1871
 
            yield ('inventory-deltas', resume_substream())
1872
 
            # Then simply continue sending the rest of the stream.
1873
 
            for substream_kind, substream in self._last_stream:
1874
 
                yield substream_kind, substream
1875
 
        return self._insert_real(resume_stream(), src_format, tokens)
1876
 
 
1877
 
    def _stop_stream_if_inventory_delta(self, stream):
1878
 
        """Normally this just lets the original stream pass-through unchanged.
1879
 
 
1880
 
        However if any 'inventory-deltas' substream occurs it will stop
1881
 
        streaming, and store the interrupted substream and stream in
1882
 
        self._last_substream and self._last_stream so that the stream can be
1883
 
        resumed by _resume_stream_with_vfs.
1884
 
        """
1885
 
                    
1886
 
        stream_iter = iter(stream)
1887
 
        for substream_kind, substream in stream_iter:
1888
 
            if substream_kind == 'inventory-deltas':
1889
 
                self._last_substream = substream
1890
 
                self._last_stream = stream_iter
1891
 
                return
1892
 
            else:
1893
 
                yield substream_kind, substream
1894
 
            
1895
1658
 
1896
1659
class RemoteStreamSource(repository.StreamSource):
1897
1660
    """Stream data from a remote server."""
1900
1663
        if (self.from_repository._fallback_repositories and
1901
1664
            self.to_format._fetch_order == 'topological'):
1902
1665
            return self._real_stream(self.from_repository, search)
1903
 
        sources = []
1904
 
        seen = set()
1905
 
        repos = [self.from_repository]
1906
 
        while repos:
1907
 
            repo = repos.pop(0)
1908
 
            if repo in seen:
1909
 
                continue
1910
 
            seen.add(repo)
1911
 
            repos.extend(repo._fallback_repositories)
1912
 
            sources.append(repo)
1913
 
        return self.missing_parents_chain(search, sources)
1914
 
 
1915
 
    def get_stream_for_missing_keys(self, missing_keys):
1916
 
        self.from_repository._ensure_real()
1917
 
        real_repo = self.from_repository._real_repository
1918
 
        real_source = real_repo._get_source(self.to_format)
1919
 
        return real_source.get_stream_for_missing_keys(missing_keys)
 
1666
        return self.missing_parents_chain(search, [self.from_repository] +
 
1667
            self.from_repository._fallback_repositories)
1920
1668
 
1921
1669
    def _real_stream(self, repo, search):
1922
1670
        """Get a stream for search from repo.
1929
1677
        """
1930
1678
        source = repo._get_source(self.to_format)
1931
1679
        if isinstance(source, RemoteStreamSource):
1932
 
            repo._ensure_real()
1933
 
            source = repo._real_repository._get_source(self.to_format)
 
1680
            return repository.StreamSource.get_stream(source, search)
1934
1681
        return source.get_stream(search)
1935
1682
 
1936
1683
    def _get_stream(self, repo, search):
1953
1700
            return self._real_stream(repo, search)
1954
1701
        client = repo._client
1955
1702
        medium = client._medium
 
1703
        if medium._is_remote_before((1, 13)):
 
1704
            # streaming was added in 1.13
 
1705
            return self._real_stream(repo, search)
1956
1706
        path = repo.bzrdir._path_for_remote_call(client)
1957
 
        search_bytes = repo._serialise_search_result(search)
1958
 
        args = (path, self.to_format.network_name())
1959
 
        candidate_verbs = [
1960
 
            ('Repository.get_stream_1.19', (1, 19)),
1961
 
            ('Repository.get_stream', (1, 13))]
1962
 
        found_verb = False
1963
 
        for verb, version in candidate_verbs:
1964
 
            if medium._is_remote_before(version):
1965
 
                continue
1966
 
            try:
1967
 
                response = repo._call_with_body_bytes_expecting_body(
1968
 
                    verb, args, search_bytes)
1969
 
            except errors.UnknownSmartMethod:
1970
 
                medium._remember_remote_is_before(version)
1971
 
            else:
1972
 
                response_tuple, response_handler = response
1973
 
                found_verb = True
1974
 
                break
1975
 
        if not found_verb:
 
1707
        try:
 
1708
            search_bytes = repo._serialise_search_result(search)
 
1709
            response = repo._call_with_body_bytes_expecting_body(
 
1710
                'Repository.get_stream',
 
1711
                (path, self.to_format.network_name()), search_bytes)
 
1712
            response_tuple, response_handler = response
 
1713
        except errors.UnknownSmartMethod:
 
1714
            medium._remember_remote_is_before((1,13))
1976
1715
            return self._real_stream(repo, search)
1977
1716
        if response_tuple[0] != 'ok':
1978
1717
            raise errors.UnexpectedSmartServerResponse(response_tuple)
1990
1729
        :param search: The overall search to satisfy with streams.
1991
1730
        :param sources: A list of Repository objects to query.
1992
1731
        """
1993
 
        self.from_serialiser = self.from_repository._format._serializer
 
1732
        self.serialiser = self.to_format._serializer
1994
1733
        self.seen_revs = set()
1995
1734
        self.referenced_revs = set()
1996
1735
        # If there are heads in the search, or the key count is > 0, we are not
2013
1752
    def missing_parents_rev_handler(self, substream):
2014
1753
        for content in substream:
2015
1754
            revision_bytes = content.get_bytes_as('fulltext')
2016
 
            revision = self.from_serialiser.read_revision_from_string(
2017
 
                revision_bytes)
 
1755
            revision = self.serialiser.read_revision_from_string(revision_bytes)
2018
1756
            self.seen_revs.add(content.key[-1])
2019
1757
            self.referenced_revs.update(revision.parent_ids)
2020
1758
            yield content
2059
1797
                self._network_name)
2060
1798
 
2061
1799
    def get_format_description(self):
2062
 
        self._ensure_real()
2063
 
        return 'Remote: ' + self._custom_format.get_format_description()
 
1800
        return 'Remote BZR Branch'
2064
1801
 
2065
1802
    def network_name(self):
2066
1803
        return self._network_name
2067
1804
 
2068
 
    def open(self, a_bzrdir, name=None, ignore_fallbacks=False):
2069
 
        return a_bzrdir.open_branch(name=name, 
2070
 
            ignore_fallbacks=ignore_fallbacks)
 
1805
    def open(self, a_bzrdir, ignore_fallbacks=False):
 
1806
        return a_bzrdir.open_branch(ignore_fallbacks=ignore_fallbacks)
2071
1807
 
2072
 
    def _vfs_initialize(self, a_bzrdir, name):
 
1808
    def _vfs_initialize(self, a_bzrdir):
2073
1809
        # Initialisation when using a local bzrdir object, or a non-vfs init
2074
1810
        # method is not available on the server.
2075
1811
        # self._custom_format is always set - the start of initialize ensures
2076
1812
        # that.
2077
1813
        if isinstance(a_bzrdir, RemoteBzrDir):
2078
1814
            a_bzrdir._ensure_real()
2079
 
            result = self._custom_format.initialize(a_bzrdir._real_bzrdir,
2080
 
                name)
 
1815
            result = self._custom_format.initialize(a_bzrdir._real_bzrdir)
2081
1816
        else:
2082
1817
            # We assume the bzrdir is parameterised; it may not be.
2083
 
            result = self._custom_format.initialize(a_bzrdir, name)
 
1818
            result = self._custom_format.initialize(a_bzrdir)
2084
1819
        if (isinstance(a_bzrdir, RemoteBzrDir) and
2085
1820
            not isinstance(result, RemoteBranch)):
2086
 
            result = RemoteBranch(a_bzrdir, a_bzrdir.find_repository(), result,
2087
 
                                  name=name)
 
1821
            result = RemoteBranch(a_bzrdir, a_bzrdir.find_repository(), result)
2088
1822
        return result
2089
1823
 
2090
 
    def initialize(self, a_bzrdir, name=None):
 
1824
    def initialize(self, a_bzrdir):
2091
1825
        # 1) get the network name to use.
2092
1826
        if self._custom_format:
2093
1827
            network_name = self._custom_format.network_name()
2099
1833
            network_name = reference_format.network_name()
2100
1834
        # Being asked to create on a non RemoteBzrDir:
2101
1835
        if not isinstance(a_bzrdir, RemoteBzrDir):
2102
 
            return self._vfs_initialize(a_bzrdir, name=name)
 
1836
            return self._vfs_initialize(a_bzrdir)
2103
1837
        medium = a_bzrdir._client._medium
2104
1838
        if medium._is_remote_before((1, 13)):
2105
 
            return self._vfs_initialize(a_bzrdir, name=name)
 
1839
            return self._vfs_initialize(a_bzrdir)
2106
1840
        # Creating on a remote bzr dir.
2107
1841
        # 2) try direct creation via RPC
2108
1842
        path = a_bzrdir._path_for_remote_call(a_bzrdir._client)
2109
 
        if name is not None:
2110
 
            # XXX JRV20100304: Support creating colocated branches
2111
 
            raise errors.NoColocatedBranchSupport(self)
2112
1843
        verb = 'BzrDir.create_branch'
2113
1844
        try:
2114
1845
            response = a_bzrdir._call(verb, path, network_name)
2115
1846
        except errors.UnknownSmartMethod:
2116
1847
            # Fallback - use vfs methods
2117
1848
            medium._remember_remote_is_before((1, 13))
2118
 
            return self._vfs_initialize(a_bzrdir, name=name)
 
1849
            return self._vfs_initialize(a_bzrdir)
2119
1850
        if response[0] != 'ok':
2120
1851
            raise errors.UnexpectedSmartServerResponse(response)
2121
1852
        # Turn the response into a RemoteRepository object.
2129
1860
                a_bzrdir._client)
2130
1861
        remote_repo = RemoteRepository(repo_bzrdir, repo_format)
2131
1862
        remote_branch = RemoteBranch(a_bzrdir, remote_repo,
2132
 
            format=format, setup_stacking=False, name=name)
 
1863
            format=format, setup_stacking=False)
2133
1864
        # XXX: We know this is a new branch, so it must have revno 0, revid
2134
1865
        # NULL_REVISION. Creating the branch locked would make this be unable
2135
1866
        # to be wrong; here its simply very unlikely to be wrong. RBC 20090225
2150
1881
        self._ensure_real()
2151
1882
        return self._custom_format.supports_stacking()
2152
1883
 
2153
 
    def supports_set_append_revisions_only(self):
2154
 
        self._ensure_real()
2155
 
        return self._custom_format.supports_set_append_revisions_only()
2156
 
 
2157
 
 
2158
 
class RemoteBranch(branch.Branch, _RpcHelper, lock._RelockDebugMixin):
 
1884
 
 
1885
class RemoteBranch(branch.Branch, _RpcHelper):
2159
1886
    """Branch stored on a server accessed by HPSS RPC.
2160
1887
 
2161
1888
    At the moment most operations are mapped down to simple file operations.
2162
1889
    """
2163
1890
 
2164
1891
    def __init__(self, remote_bzrdir, remote_repository, real_branch=None,
2165
 
        _client=None, format=None, setup_stacking=True, name=None):
 
1892
        _client=None, format=None, setup_stacking=True):
2166
1893
        """Create a RemoteBranch instance.
2167
1894
 
2168
1895
        :param real_branch: An optional local implementation of the branch
2174
1901
        :param setup_stacking: If True make an RPC call to determine the
2175
1902
            stacked (or not) status of the branch. If False assume the branch
2176
1903
            is not stacked.
2177
 
        :param name: Colocated branch name
2178
1904
        """
2179
1905
        # We intentionally don't call the parent class's __init__, because it
2180
1906
        # will try to assign to self.tags, which is a property in this subclass.
2181
1907
        # And the parent's __init__ doesn't do much anyway.
 
1908
        self._revision_id_to_revno_cache = None
 
1909
        self._partial_revision_id_to_revno_cache = {}
 
1910
        self._revision_history_cache = None
 
1911
        self._last_revision_info_cache = None
 
1912
        self._merge_sorted_revisions_cache = None
2182
1913
        self.bzrdir = remote_bzrdir
2183
1914
        if _client is not None:
2184
1915
            self._client = _client
2198
1929
        else:
2199
1930
            self._real_branch = None
2200
1931
        # Fill out expected attributes of branch for bzrlib API users.
2201
 
        self._clear_cached_state()
2202
 
        # TODO: deprecate self.base in favor of user_url
2203
 
        self.base = self.bzrdir.user_url
2204
 
        self._name = name
 
1932
        self.base = self.bzrdir.root_transport.base
2205
1933
        self._control_files = None
2206
1934
        self._lock_mode = None
2207
1935
        self._lock_token = None
2218
1946
                    self._real_branch._format.network_name()
2219
1947
        else:
2220
1948
            self._format = format
2221
 
        # when we do _ensure_real we may need to pass ignore_fallbacks to the
2222
 
        # branch.open_branch method.
2223
 
        self._real_ignore_fallbacks = not setup_stacking
2224
1949
        if not self._format._network_name:
2225
1950
            # Did not get from open_branchV2 - old server.
2226
1951
            self._ensure_real()
2231
1956
        hooks = branch.Branch.hooks['open']
2232
1957
        for hook in hooks:
2233
1958
            hook(self)
2234
 
        self._is_stacked = False
2235
1959
        if setup_stacking:
2236
1960
            self._setup_stacking()
2237
1961
 
2243
1967
        except (errors.NotStacked, errors.UnstackableBranchFormat,
2244
1968
            errors.UnstackableRepositoryFormat), e:
2245
1969
            return
2246
 
        self._is_stacked = True
2247
 
        self._activate_fallback_location(fallback_url)
 
1970
        self._activate_fallback_location(fallback_url, None)
2248
1971
 
2249
1972
    def _get_config(self):
2250
1973
        return RemoteBranchConfig(self)
2271
1994
                raise AssertionError('smart server vfs must be enabled '
2272
1995
                    'to use vfs implementation')
2273
1996
            self.bzrdir._ensure_real()
2274
 
            self._real_branch = self.bzrdir._real_bzrdir.open_branch(
2275
 
                ignore_fallbacks=self._real_ignore_fallbacks, name=self._name)
 
1997
            self._real_branch = self.bzrdir._real_bzrdir.open_branch()
2276
1998
            if self.repository._real_repository is None:
2277
1999
                # Give the remote repository the matching real repo.
2278
2000
                real_repo = self._real_branch.repository
2352
2074
            raise errors.UnexpectedSmartServerResponse(response)
2353
2075
        return response[1]
2354
2076
 
2355
 
    def set_stacked_on_url(self, url):
2356
 
        branch.Branch.set_stacked_on_url(self, url)
2357
 
        if not url:
2358
 
            self._is_stacked = False
2359
 
        else:
2360
 
            self._is_stacked = True
2361
 
        
2362
2077
    def _vfs_get_tags_bytes(self):
2363
2078
        self._ensure_real()
2364
2079
        return self._real_branch._get_tags_bytes()
2374
2089
            return self._vfs_get_tags_bytes()
2375
2090
        return response[0]
2376
2091
 
2377
 
    def _vfs_set_tags_bytes(self, bytes):
2378
 
        self._ensure_real()
2379
 
        return self._real_branch._set_tags_bytes(bytes)
2380
 
 
2381
 
    def _set_tags_bytes(self, bytes):
2382
 
        medium = self._client._medium
2383
 
        if medium._is_remote_before((1, 18)):
2384
 
            self._vfs_set_tags_bytes(bytes)
2385
 
            return
2386
 
        try:
2387
 
            args = (
2388
 
                self._remote_path(), self._lock_token, self._repo_lock_token)
2389
 
            response = self._call_with_body_bytes(
2390
 
                'Branch.set_tags_bytes', args, bytes)
2391
 
        except errors.UnknownSmartMethod:
2392
 
            medium._remember_remote_is_before((1, 18))
2393
 
            self._vfs_set_tags_bytes(bytes)
2394
 
 
2395
2092
    def lock_read(self):
2396
 
        """Lock the branch for read operations.
2397
 
 
2398
 
        :return: A bzrlib.lock.LogicalLockResult.
2399
 
        """
2400
2093
        self.repository.lock_read()
2401
2094
        if not self._lock_mode:
2402
 
            self._note_lock('r')
2403
2095
            self._lock_mode = 'r'
2404
2096
            self._lock_count = 1
2405
2097
            if self._real_branch is not None:
2406
2098
                self._real_branch.lock_read()
2407
2099
        else:
2408
2100
            self._lock_count += 1
2409
 
        return lock.LogicalLockResult(self.unlock)
2410
2101
 
2411
2102
    def _remote_lock_write(self, token):
2412
2103
        if token is None:
2413
2104
            branch_token = repo_token = ''
2414
2105
        else:
2415
2106
            branch_token = token
2416
 
            repo_token = self.repository.lock_write().repository_token
 
2107
            repo_token = self.repository.lock_write()
2417
2108
            self.repository.unlock()
2418
2109
        err_context = {'token': token}
2419
2110
        response = self._call(
2426
2117
 
2427
2118
    def lock_write(self, token=None):
2428
2119
        if not self._lock_mode:
2429
 
            self._note_lock('w')
2430
2120
            # Lock the branch and repo in one remote call.
2431
2121
            remote_tokens = self._remote_lock_write(token)
2432
2122
            self._lock_token, self._repo_lock_token = remote_tokens
2456
2146
            self._lock_count += 1
2457
2147
            # Re-lock the repository too.
2458
2148
            self.repository.lock_write(self._repo_lock_token)
2459
 
        return BranchWriteLockResult(self.unlock, self._lock_token or None)
 
2149
        return self._lock_token or None
 
2150
 
 
2151
    def _set_tags_bytes(self, bytes):
 
2152
        self._ensure_real()
 
2153
        return self._real_branch._set_tags_bytes(bytes)
2460
2154
 
2461
2155
    def _unlock(self, branch_token, repo_token):
2462
2156
        err_context = {'token': str((branch_token, repo_token))}
2467
2161
            return
2468
2162
        raise errors.UnexpectedSmartServerResponse(response)
2469
2163
 
2470
 
    @only_raises(errors.LockNotHeld, errors.LockBroken)
2471
2164
    def unlock(self):
2472
2165
        try:
2473
2166
            self._lock_count -= 1
2513
2206
            raise NotImplementedError(self.dont_leave_lock_in_place)
2514
2207
        self._leave_lock = False
2515
2208
 
2516
 
    @needs_read_lock
2517
 
    def get_rev_id(self, revno, history=None):
2518
 
        if revno == 0:
2519
 
            return _mod_revision.NULL_REVISION
2520
 
        last_revision_info = self.last_revision_info()
2521
 
        ok, result = self.repository.get_rev_id_for_revno(
2522
 
            revno, last_revision_info)
2523
 
        if ok:
2524
 
            return result
2525
 
        missing_parent = result[1]
2526
 
        # Either the revision named by the server is missing, or its parent
2527
 
        # is.  Call get_parent_map to determine which, so that we report a
2528
 
        # useful error.
2529
 
        parent_map = self.repository.get_parent_map([missing_parent])
2530
 
        if missing_parent in parent_map:
2531
 
            missing_parent = parent_map[missing_parent]
2532
 
        raise errors.RevisionNotPresent(missing_parent, self.repository)
2533
 
 
2534
2209
    def _last_revision_info(self):
2535
2210
        response = self._call('Branch.last_revision_info', self._remote_path())
2536
2211
        if response[0] != 'ok':
2541
2216
 
2542
2217
    def _gen_revision_history(self):
2543
2218
        """See Branch._gen_revision_history()."""
2544
 
        if self._is_stacked:
2545
 
            self._ensure_real()
2546
 
            return self._real_branch._gen_revision_history()
2547
2219
        response_tuple, response_handler = self._call_expecting_body(
2548
2220
            'Branch.revision_history', self._remote_path())
2549
2221
        if response_tuple[0] != 'ok':
2884
2556
                    'Missing key %r in context %r', key_err.args[0], context)
2885
2557
                raise err
2886
2558
 
2887
 
    if err.error_verb == 'IncompatibleRepositories':
2888
 
        raise errors.IncompatibleRepositories(err.error_args[0],
2889
 
            err.error_args[1], err.error_args[2])
2890
 
    elif err.error_verb == 'NoSuchRevision':
 
2559
    if err.error_verb == 'NoSuchRevision':
2891
2560
        raise NoSuchRevision(find('branch'), err.error_args[0])
2892
2561
    elif err.error_verb == 'nosuchrevision':
2893
2562
        raise NoSuchRevision(find('repository'), err.error_args[0])
2894
 
    elif err.error_verb == 'nobranch':
2895
 
        if len(err.error_args) >= 1:
2896
 
            extra = err.error_args[0]
2897
 
        else:
2898
 
            extra = None
2899
 
        raise errors.NotBranchError(path=find('bzrdir').root_transport.base,
2900
 
            detail=extra)
 
2563
    elif err.error_tuple == ('nobranch',):
 
2564
        raise errors.NotBranchError(path=find('bzrdir').root_transport.base)
2901
2565
    elif err.error_verb == 'norepository':
2902
2566
        raise errors.NoRepositoryPresent(find('bzrdir'))
2903
2567
    elif err.error_verb == 'LockContention':