/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: John Arbash Meinel
  • Date: 2009-08-17 15:38:52 UTC
  • mfrom: (4615.1.1 2.0b1-merge-sort)
  • mto: This revision was merged to the branch mainline in revision 4629.
  • Revision ID: john@arbash-meinel.com-20090817153852-9127xf3aabmcoegt
Bring in the changes to merge_sort.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2011 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from __future__ import absolute_import
18
17
 
19
18
# The newly committed revision is going to have a shape corresponding
20
19
# to that of the working tree.  Files that are not in the
50
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
50
# the rest of the code; add a deprecation of the old name.
52
51
 
53
 
from . import (
 
52
import os
 
53
import re
 
54
import sys
 
55
import time
 
56
 
 
57
from cStringIO import StringIO
 
58
 
 
59
from bzrlib import (
54
60
    debug,
55
61
    errors,
 
62
    revision,
56
63
    trace,
57
 
    ui,
 
64
    tree,
 
65
    xml_serializer,
58
66
    )
59
 
from .branch import Branch
60
 
from .cleanup import OperationWithCleanups
61
 
import breezy.config
62
 
from .errors import (BzrError,
63
 
                     ConflictsInTree,
64
 
                     StrictCommitFailed
65
 
                     )
66
 
from .osutils import (get_user_encoding,
67
 
                      is_inside_any,
68
 
                      minimum_path_selection,
69
 
                      )
70
 
from .trace import mutter, note, is_quiet
71
 
from .urlutils import unescape_for_display
72
 
from .i18n import gettext
73
 
 
74
 
 
75
 
class PointlessCommit(BzrError):
76
 
 
77
 
    _fmt = "No changes to commit"
78
 
 
79
 
 
80
 
class CannotCommitSelectedFileMerge(BzrError):
81
 
 
82
 
    _fmt = 'Selected-file commit of merges is not supported yet:'\
83
 
        ' files %(files_str)s'
84
 
 
85
 
    def __init__(self, files):
86
 
        files_str = ', '.join(files)
87
 
        BzrError.__init__(self, files=files, files_str=files_str)
88
 
 
89
 
 
90
 
def filter_excluded(iter_changes, exclude):
91
 
    """Filter exclude filenames.
92
 
 
93
 
    :param iter_changes: iter_changes function
94
 
    :param exclude: List of paths to exclude
95
 
    :return: iter_changes function
96
 
    """
97
 
    for change in iter_changes:
98
 
        old_path = change[1][0]
99
 
        new_path = change[1][1]
100
 
 
101
 
        new_excluded = (new_path is not None and
102
 
                        is_inside_any(exclude, new_path))
103
 
 
104
 
        old_excluded = (old_path is not None and
105
 
                        is_inside_any(exclude, old_path))
106
 
 
107
 
        if old_excluded and new_excluded:
108
 
            continue
109
 
 
110
 
        if old_excluded or new_excluded:
111
 
            # TODO(jelmer): Perhaps raise an error here instead?
112
 
            continue
113
 
 
114
 
        yield change
 
67
from bzrlib.branch import Branch
 
68
import bzrlib.config
 
69
from bzrlib.errors import (BzrError, PointlessCommit,
 
70
                           ConflictsInTree,
 
71
                           StrictCommitFailed
 
72
                           )
 
73
from bzrlib.osutils import (get_user_encoding,
 
74
                            kind_marker, isdir,isfile, is_inside_any,
 
75
                            is_inside_or_parent_of_any,
 
76
                            minimum_path_selection,
 
77
                            quotefn, sha_file, split_lines,
 
78
                            splitpath,
 
79
                            )
 
80
from bzrlib.testament import Testament
 
81
from bzrlib.trace import mutter, note, warning, is_quiet
 
82
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
 
83
from bzrlib import symbol_versioning
 
84
from bzrlib.symbol_versioning import (deprecated_passed,
 
85
        deprecated_function,
 
86
        DEPRECATED_PARAMETER)
 
87
from bzrlib.workingtree import WorkingTree
 
88
from bzrlib.urlutils import unescape_for_display
 
89
import bzrlib.ui
115
90
 
116
91
 
117
92
class NullCommitReporter(object):
118
93
    """I report on progress of a commit."""
119
94
 
120
 
    def started(self, revno, revid, location):
 
95
    def started(self, revno, revid, location=None):
 
96
        if location is None:
 
97
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
98
                                   "to started.", DeprecationWarning,
 
99
                                   stacklevel=2)
121
100
        pass
122
101
 
123
102
    def snapshot_change(self, change, path):
149
128
        note(format, *args)
150
129
 
151
130
    def snapshot_change(self, change, path):
152
 
        if path == '' and change in (gettext('added'), gettext('modified')):
 
131
        if path == '' and change in ('added', 'modified'):
153
132
            return
154
133
        self._note("%s %s", change, path)
155
134
 
156
 
    def started(self, revno, rev_id, location):
157
 
        self._note(
158
 
            gettext('Committing to: %s'),
159
 
            unescape_for_display(location, 'utf-8'))
 
135
    def started(self, revno, rev_id, location=None):
 
136
        if location is not None:
 
137
            location = ' to: ' + unescape_for_display(location, 'utf-8')
 
138
        else:
 
139
            # When started was added, location was only made optional by
 
140
            # accident.  Matt Nordhoff 20071129
 
141
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
142
                                   "to started.", DeprecationWarning,
 
143
                                   stacklevel=2)
 
144
            location = ''
 
145
        self._note('Committing%s', location)
160
146
 
161
147
    def completed(self, revno, rev_id):
162
 
        self._note(gettext('Committed revision %d.'), revno)
163
 
        # self._note goes to the console too; so while we want to log the
164
 
        # rev_id, we can't trivially only log it. (See bug 526425). Long
165
 
        # term we should rearrange the reporting structure, but for now
166
 
        # we just mutter seperately. We mutter the revid and revno together
167
 
        # so that concurrent bzr invocations won't lead to confusion.
168
 
        mutter('Committed revid %s as revno %d.', rev_id, revno)
 
148
        self._note('Committed revision %d.', revno)
169
149
 
170
150
    def deleted(self, path):
171
 
        self._note(gettext('deleted %s'), path)
 
151
        self._note('deleted %s', path)
172
152
 
173
153
    def missing(self, path):
174
 
        self._note(gettext('missing %s'), path)
 
154
        self._note('missing %s', path)
175
155
 
176
156
    def renamed(self, change, old_path, new_path):
177
157
        self._note('%s %s => %s', change, old_path, new_path)
192
172
            the working directory; these should be removed from the
193
173
            working inventory.
194
174
    """
195
 
 
196
175
    def __init__(self,
197
176
                 reporter=None,
198
 
                 config_stack=None):
 
177
                 config=None):
199
178
        """Create a Commit object.
200
179
 
201
180
        :param reporter: the default reporter to use or None to decide later
202
181
        """
203
182
        self.reporter = reporter
204
 
        self.config_stack = config_stack
205
 
 
206
 
    @staticmethod
207
 
    def update_revprops(revprops, branch, authors=None,
208
 
                        local=False, possible_master_transports=None):
209
 
        if revprops is None:
210
 
            revprops = {}
211
 
        if possible_master_transports is None:
212
 
            possible_master_transports = []
213
 
        if (u'branch-nick' not in revprops and
214
 
                branch.repository._format.supports_storing_branch_nick):
215
 
            revprops[u'branch-nick'] = branch._get_nick(
216
 
                local,
217
 
                possible_master_transports)
218
 
        if authors is not None:
219
 
            if u'author' in revprops or u'authors' in revprops:
220
 
                # XXX: maybe we should just accept one of them?
221
 
                raise AssertionError('author property given twice')
222
 
            if authors:
223
 
                for individual in authors:
224
 
                    if '\n' in individual:
225
 
                        raise AssertionError('\\n is not a valid character '
226
 
                                             'in an author identity')
227
 
                revprops[u'authors'] = '\n'.join(authors)
228
 
        return revprops
 
183
        self.config = config
229
184
 
230
185
    def commit(self,
231
186
               message=None,
245
200
               message_callback=None,
246
201
               recursive='down',
247
202
               exclude=None,
248
 
               possible_master_transports=None,
249
 
               lossy=False):
 
203
               possible_master_transports=None):
250
204
        """Commit working copy as a new revision.
251
205
 
252
206
        :param message: the commit message (it or message_callback is required)
253
 
        :param message_callback: A callback: message =
254
 
            message_callback(cmt_obj)
 
207
        :param message_callback: A callback: message = message_callback(cmt_obj)
255
208
 
256
209
        :param timestamp: if not None, seconds-since-epoch for a
257
210
            postdated/predated commit.
258
211
 
259
 
        :param specific_files: If not None, commit only those files. An empty
260
 
            list means 'commit no files'.
 
212
        :param specific_files: If true, commit only those files.
261
213
 
262
214
        :param rev_id: If set, use this as the new revision id.
263
215
            Useful for test or import commands that need to tightly
280
232
        :param exclude: None or a list of relative paths to exclude from the
281
233
            commit. Pending changes to excluded files will be ignored by the
282
234
            commit.
283
 
        :param lossy: When committing to a foreign VCS, ignore any
284
 
            data that can not be natively represented.
285
235
        """
286
 
        operation = OperationWithCleanups(self._commit)
287
 
        self.revprops = revprops or {}
288
 
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
289
 
        self.config_stack = config or self.config_stack
290
 
        return operation.run(
291
 
            message=message,
292
 
            timestamp=timestamp,
293
 
            timezone=timezone,
294
 
            committer=committer,
295
 
            specific_files=specific_files,
296
 
            rev_id=rev_id,
297
 
            allow_pointless=allow_pointless,
298
 
            strict=strict,
299
 
            verbose=verbose,
300
 
            working_tree=working_tree,
301
 
            local=local,
302
 
            reporter=reporter,
303
 
            message_callback=message_callback,
304
 
            recursive=recursive,
305
 
            exclude=exclude,
306
 
            possible_master_transports=possible_master_transports,
307
 
            lossy=lossy)
308
 
 
309
 
    def _commit(self, operation, message, timestamp, timezone, committer,
310
 
                specific_files, rev_id, allow_pointless, strict, verbose,
311
 
                working_tree, local, reporter, message_callback, recursive,
312
 
                exclude, possible_master_transports, lossy):
313
236
        mutter('preparing to commit')
314
237
 
315
238
        if working_tree is None:
322
245
                    raise errors.RootNotRich()
323
246
        if message_callback is None:
324
247
            if message is not None:
325
 
                if isinstance(message, bytes):
 
248
                if isinstance(message, str):
326
249
                    message = message.decode(get_user_encoding())
327
 
 
328
 
                def message_callback(x):
329
 
                    return message
 
250
                message_callback = lambda x: message
330
251
            else:
331
252
                raise BzrError("The message or message_callback keyword"
332
253
                               " parameter is required for commit().")
340
261
            self.exclude = []
341
262
        self.local = local
342
263
        self.master_branch = None
 
264
        self.master_locked = False
343
265
        self.recursive = recursive
344
266
        self.rev_id = None
345
 
        # self.specific_files is None to indicate no filter, or any iterable to
346
 
        # indicate a filter - [] means no files at all, as per iter_changes.
347
267
        if specific_files is not None:
348
268
            self.specific_files = sorted(
349
269
                minimum_path_selection(specific_files))
350
270
        else:
351
271
            self.specific_files = None
352
 
 
 
272
            
353
273
        self.allow_pointless = allow_pointless
 
274
        self.revprops = revprops
354
275
        self.message_callback = message_callback
355
276
        self.timestamp = timestamp
356
277
        self.timezone = timezone
359
280
        self.verbose = verbose
360
281
 
361
282
        self.work_tree.lock_write()
362
 
        operation.add_cleanup(self.work_tree.unlock)
363
283
        self.parents = self.work_tree.get_parent_ids()
364
 
        self.pb = ui.ui_factory.nested_progress_bar()
365
 
        operation.add_cleanup(self.pb.finished)
 
284
        # We can use record_iter_changes IFF iter_changes is compatible with
 
285
        # the command line parameters, and the repository has fast delta
 
286
        # generation. See bug 347649.
 
287
        self.use_record_iter_changes = (
 
288
            not self.specific_files and
 
289
            not self.exclude and 
 
290
            not self.branch.repository._format.supports_tree_reference and
 
291
            (self.branch.repository._format.fast_deltas or
 
292
             len(self.parents) < 2))
 
293
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
366
294
        self.basis_revid = self.work_tree.last_revision()
367
295
        self.basis_tree = self.work_tree.basis_tree()
368
296
        self.basis_tree.lock_read()
369
 
        operation.add_cleanup(self.basis_tree.unlock)
370
 
        # Cannot commit with conflicts present.
371
 
        if len(self.work_tree.conflicts()) > 0:
372
 
            raise ConflictsInTree
373
 
 
374
 
        # Setup the bound branch variables as needed.
375
 
        self._check_bound_branch(operation, possible_master_transports)
376
 
 
377
 
        # Check that the working tree is up to date
378
 
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
379
 
 
380
 
        # Complete configuration setup
381
 
        if reporter is not None:
382
 
            self.reporter = reporter
383
 
        elif self.reporter is None:
384
 
            self.reporter = self._select_reporter()
385
 
        if self.config_stack is None:
386
 
            self.config_stack = self.work_tree.get_config_stack()
387
 
 
388
 
        # Setup the progress bar. As the number of files that need to be
389
 
        # committed in unknown, progress is reported as stages.
390
 
        # We keep track of entries separately though and include that
391
 
        # information in the progress bar during the relevant stages.
392
 
        self.pb_stage_name = ""
393
 
        self.pb_stage_count = 0
394
 
        self.pb_stage_total = 5
395
 
        if self.bound_branch:
396
 
            # 2 extra stages: "Uploading data to master branch" and "Merging
397
 
            # tags to master branch"
398
 
            self.pb_stage_total += 2
399
 
        self.pb.show_pct = False
400
 
        self.pb.show_spinner = False
401
 
        self.pb.show_eta = False
402
 
        self.pb.show_count = True
403
 
        self.pb.show_bar = True
404
 
 
405
 
        # After a merge, a selected file commit is not supported.
406
 
        # See 'bzr help merge' for an explanation as to why.
407
 
        if len(self.parents) > 1 and self.specific_files is not None:
408
 
            raise CannotCommitSelectedFileMerge(self.specific_files)
409
 
        # Excludes are a form of selected file commit.
410
 
        if len(self.parents) > 1 and self.exclude:
411
 
            raise CannotCommitSelectedFileMerge(self.exclude)
412
 
 
413
 
        # Collect the changes
414
 
        self._set_progress_stage("Collecting changes", counter=True)
415
 
        self._lossy = lossy
416
 
        self.builder = self.branch.get_commit_builder(
417
 
            self.parents, self.config_stack, timestamp, timezone, committer,
418
 
            self.revprops, rev_id, lossy=lossy)
419
 
 
420
 
        if self.builder.updates_branch and self.bound_branch:
421
 
            self.builder.abort()
422
 
            raise AssertionError(
423
 
                "bound branches not supported for commit builders "
424
 
                "that update the branch")
425
 
 
426
297
        try:
427
 
            # find the location being committed to
 
298
            # Cannot commit with conflicts present.
 
299
            if len(self.work_tree.conflicts()) > 0:
 
300
                raise ConflictsInTree
 
301
 
 
302
            # Setup the bound branch variables as needed.
 
303
            self._check_bound_branch(possible_master_transports)
 
304
 
 
305
            # Check that the working tree is up to date
 
306
            old_revno, new_revno = self._check_out_of_date_tree()
 
307
 
 
308
            # Complete configuration setup
 
309
            if reporter is not None:
 
310
                self.reporter = reporter
 
311
            elif self.reporter is None:
 
312
                self.reporter = self._select_reporter()
 
313
            if self.config is None:
 
314
                self.config = self.branch.get_config()
 
315
 
 
316
            self._set_specific_file_ids()
 
317
 
 
318
            # Setup the progress bar. As the number of files that need to be
 
319
            # committed in unknown, progress is reported as stages.
 
320
            # We keep track of entries separately though and include that
 
321
            # information in the progress bar during the relevant stages.
 
322
            self.pb_stage_name = ""
 
323
            self.pb_stage_count = 0
 
324
            self.pb_stage_total = 5
428
325
            if self.bound_branch:
429
 
                master_location = self.master_branch.base
430
 
            else:
431
 
                master_location = self.branch.base
432
 
 
433
 
            # report the start of the commit
434
 
            self.reporter.started(new_revno, self.rev_id, master_location)
435
 
 
436
 
            self._update_builder_with_changes()
437
 
            self._check_pointless()
438
 
 
439
 
            # TODO: Now the new inventory is known, check for conflicts.
440
 
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
441
 
            # weave lines, because nothing should be recorded until it is known
442
 
            # that commit will succeed.
443
 
            self._set_progress_stage("Saving data locally")
444
 
            self.builder.finish_inventory()
445
 
 
446
 
            # Prompt the user for a commit message if none provided
447
 
            message = message_callback(self)
448
 
            self.message = message
449
 
 
450
 
            # Add revision data to the local branch
451
 
            self.rev_id = self.builder.commit(self.message)
452
 
 
453
 
        except Exception:
454
 
            mutter("aborting commit write group because of exception:")
455
 
            trace.log_exception_quietly()
456
 
            self.builder.abort()
457
 
            raise
458
 
 
459
 
        self._update_branches(old_revno, old_revid, new_revno)
460
 
 
461
 
        # Make the working tree be up to date with the branch. This
462
 
        # includes automatic changes scheduled to be made to the tree, such
463
 
        # as updating its basis and unversioning paths that were missing.
464
 
        self.work_tree.unversion(self.deleted_paths)
465
 
        self._set_progress_stage("Updating the working tree")
466
 
        self.work_tree.update_basis_by_delta(self.rev_id,
467
 
                                             self.builder.get_basis_delta())
468
 
        self.reporter.completed(new_revno, self.rev_id)
469
 
        self._process_post_hooks(old_revno, new_revno)
470
 
        return self.rev_id
471
 
 
472
 
    def _update_branches(self, old_revno, old_revid, new_revno):
473
 
        """Update the master and local branch to the new revision.
474
 
 
475
 
        This will try to make sure that the master branch is updated
476
 
        before the local branch.
477
 
 
478
 
        :param old_revno: Revision number of master branch before the
479
 
            commit
480
 
        :param old_revid: Tip of master branch before the commit
481
 
        :param new_revno: Revision number of the new commit
482
 
        """
483
 
        if not self.builder.updates_branch:
 
326
                self.pb_stage_total += 1
 
327
            self.pb.show_pct = False
 
328
            self.pb.show_spinner = False
 
329
            self.pb.show_eta = False
 
330
            self.pb.show_count = True
 
331
            self.pb.show_bar = True
 
332
 
 
333
            self._gather_parents()
 
334
            # After a merge, a selected file commit is not supported.
 
335
            # See 'bzr help merge' for an explanation as to why.
 
336
            if len(self.parents) > 1 and self.specific_files:
 
337
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
 
338
            # Excludes are a form of selected file commit.
 
339
            if len(self.parents) > 1 and self.exclude:
 
340
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
 
341
 
 
342
            # Collect the changes
 
343
            self._set_progress_stage("Collecting changes", counter=True)
 
344
            self.builder = self.branch.get_commit_builder(self.parents,
 
345
                self.config, timestamp, timezone, committer, revprops, rev_id)
 
346
 
 
347
            try:
 
348
                self.builder.will_record_deletes()
 
349
                # find the location being committed to
 
350
                if self.bound_branch:
 
351
                    master_location = self.master_branch.base
 
352
                else:
 
353
                    master_location = self.branch.base
 
354
 
 
355
                # report the start of the commit
 
356
                self.reporter.started(new_revno, self.rev_id, master_location)
 
357
 
 
358
                self._update_builder_with_changes()
 
359
                self._check_pointless()
 
360
 
 
361
                # TODO: Now the new inventory is known, check for conflicts.
 
362
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
 
363
                # weave lines, because nothing should be recorded until it is known
 
364
                # that commit will succeed.
 
365
                self._set_progress_stage("Saving data locally")
 
366
                self.builder.finish_inventory()
 
367
 
 
368
                # Prompt the user for a commit message if none provided
 
369
                message = message_callback(self)
 
370
                self.message = message
 
371
 
 
372
                # Add revision data to the local branch
 
373
                self.rev_id = self.builder.commit(self.message)
 
374
 
 
375
            except Exception, e:
 
376
                mutter("aborting commit write group because of exception:")
 
377
                trace.log_exception_quietly()
 
378
                note("aborting commit write group: %r" % (e,))
 
379
                self.builder.abort()
 
380
                raise
 
381
 
484
382
            self._process_pre_hooks(old_revno, new_revno)
485
383
 
486
384
            # Upload revision data to the master.
489
387
                self._set_progress_stage("Uploading data to master branch")
490
388
                # 'commit' to the master first so a timeout here causes the
491
389
                # local branch to be out of date
492
 
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
493
 
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
494
 
                if self._lossy:
495
 
                    self.branch.fetch(self.master_branch, self.rev_id)
 
390
                self.master_branch.import_last_revision_info(
 
391
                    self.branch.repository, new_revno, self.rev_id)
496
392
 
497
393
            # and now do the commit locally.
498
394
            self.branch.set_last_revision_info(new_revno, self.rev_id)
499
 
        else:
500
 
            try:
501
 
                self._process_pre_hooks(old_revno, new_revno)
502
 
            except BaseException:
503
 
                # The commit builder will already have updated the branch,
504
 
                # revert it.
505
 
                self.branch.set_last_revision_info(old_revno, old_revid)
506
 
                raise
507
395
 
508
 
        # Merge local tags to remote
509
 
        if self.bound_branch:
510
 
            self._set_progress_stage("Merging tags to master branch")
511
 
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
512
 
                self.master_branch.tags)
513
 
            if tag_conflicts:
514
 
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
515
 
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
516
 
                    "\n".join(warning_lines))))
 
396
            # Make the working tree be up to date with the branch. This
 
397
            # includes automatic changes scheduled to be made to the tree, such
 
398
            # as updating its basis and unversioning paths that were missing.
 
399
            self.work_tree.unversion(self.deleted_ids)
 
400
            self._set_progress_stage("Updating the working tree")
 
401
            self.work_tree.update_basis_by_delta(self.rev_id,
 
402
                 self.builder.get_basis_delta())
 
403
            self.reporter.completed(new_revno, self.rev_id)
 
404
            self._process_post_hooks(old_revno, new_revno)
 
405
        finally:
 
406
            self._cleanup()
 
407
        return self.rev_id
517
408
 
518
409
    def _select_reporter(self):
519
410
        """Select the CommitReporter to use."""
527
418
        # A merge with no effect on files
528
419
        if len(self.parents) > 1:
529
420
            return
 
421
        # TODO: we could simplify this by using self.builder.basis_delta.
 
422
 
 
423
        # The initial commit adds a root directory, but this in itself is not
 
424
        # a worthwhile commit.
 
425
        if (self.basis_revid == revision.NULL_REVISION and
 
426
            ((self.builder.new_inventory is not None and
 
427
             len(self.builder.new_inventory) == 1) or
 
428
            len(self.builder._basis_delta) == 1)):
 
429
            raise PointlessCommit()
530
430
        if self.builder.any_changes():
531
431
            return
532
432
        raise PointlessCommit()
533
433
 
534
 
    def _check_bound_branch(self, operation, possible_master_transports=None):
 
434
    def _check_bound_branch(self, possible_master_transports=None):
535
435
        """Check to see if the local branch is bound.
536
436
 
537
437
        If it is bound, then most of the commit will actually be
553
453
        # If the master branch is bound, we must fail
554
454
        master_bound_location = self.master_branch.get_bound_location()
555
455
        if master_bound_location:
556
 
            raise errors.CommitToDoubleBoundBranch(
557
 
                self.branch, self.master_branch, master_bound_location)
 
456
            raise errors.CommitToDoubleBoundBranch(self.branch,
 
457
                    self.master_branch, master_bound_location)
558
458
 
559
459
        # TODO: jam 20051230 We could automatically push local
560
460
        #       commits to the remote branch if they would fit.
562
462
        #       to local.
563
463
 
564
464
        # Make sure the local branch is identical to the master
565
 
        master_revid = self.master_branch.last_revision()
566
 
        local_revid = self.branch.last_revision()
567
 
        if local_revid != master_revid:
 
465
        master_info = self.master_branch.last_revision_info()
 
466
        local_info = self.branch.last_revision_info()
 
467
        if local_info != master_info:
568
468
            raise errors.BoundBranchOutOfDate(self.branch,
569
 
                                              self.master_branch)
 
469
                    self.master_branch)
570
470
 
571
471
        # Now things are ready to change the master branch
572
472
        # so grab the lock
573
473
        self.bound_branch = self.branch
574
474
        self.master_branch.lock_write()
575
 
        operation.add_cleanup(self.master_branch.unlock)
 
475
        self.master_locked = True
576
476
 
577
477
    def _check_out_of_date_tree(self):
578
478
        """Check that the working tree is up to date.
579
479
 
580
 
        :return: old_revision_number, old_revision_id, new_revision_number
581
 
            tuple
 
480
        :return: old_revision_number,new_revision_number tuple
582
481
        """
583
482
        try:
584
483
            first_tree_parent = self.work_tree.get_parent_ids()[0]
587
486
            # this is so that we still consider the master branch
588
487
            # - in a checkout scenario the tree may have no
589
488
            # parents but the branch may do.
590
 
            first_tree_parent = breezy.revision.NULL_REVISION
591
 
        try:
592
 
            old_revno, master_last = self.master_branch.last_revision_info()
593
 
        except errors.UnsupportedOperation:
594
 
            master_last = self.master_branch.last_revision()
595
 
            old_revno = self.branch.revision_id_to_revno(master_last)
 
489
            first_tree_parent = bzrlib.revision.NULL_REVISION
 
490
        old_revno, master_last = self.master_branch.last_revision_info()
596
491
        if master_last != first_tree_parent:
597
 
            if master_last != breezy.revision.NULL_REVISION:
 
492
            if master_last != bzrlib.revision.NULL_REVISION:
598
493
                raise errors.OutOfDateTree(self.work_tree)
599
494
        if self.branch.repository.has_revision(first_tree_parent):
600
495
            new_revno = old_revno + 1
601
496
        else:
602
497
            # ghost parents never appear in revision history.
603
498
            new_revno = 1
604
 
        return old_revno, master_last, new_revno
 
499
        return old_revno,new_revno
605
500
 
606
501
    def _process_pre_hooks(self, old_revno, new_revno):
607
502
        """Process any registered pre commit hooks."""
613
508
        # Process the post commit hooks, if any
614
509
        self._set_progress_stage("Running post_commit hooks")
615
510
        # old style commit hooks - should be deprecated ? (obsoleted in
616
 
        # 0.15^H^H^H^H 2.5.0)
617
 
        post_commit = self.config_stack.get('post_commit')
618
 
        if post_commit is not None:
619
 
            hooks = post_commit.split(' ')
 
511
        # 0.15)
 
512
        if self.config.post_commit() is not None:
 
513
            hooks = self.config.post_commit().split(' ')
620
514
            # this would be nicer with twisted.python.reflect.namedAny
621
515
            for hook in hooks:
622
516
                result = eval(hook + '(branch, rev_id)',
623
 
                              {'branch': self.branch,
624
 
                               'breezy': breezy,
625
 
                               'rev_id': self.rev_id})
 
517
                              {'branch':self.branch,
 
518
                               'bzrlib':bzrlib,
 
519
                               'rev_id':self.rev_id})
626
520
        # process new style post commit hooks
627
521
        self._process_hooks("post_commit", old_revno, new_revno)
628
522
 
643
537
        if self.parents:
644
538
            old_revid = self.parents[0]
645
539
        else:
646
 
            old_revid = breezy.revision.NULL_REVISION
 
540
            old_revid = bzrlib.revision.NULL_REVISION
647
541
 
648
542
        if hook_name == "pre_commit":
649
543
            future_tree = self.builder.revision_tree()
650
544
            tree_delta = future_tree.changes_from(self.basis_tree,
651
 
                                                  include_root=True)
 
545
                                             include_root=True)
652
546
 
653
547
        for hook in Branch.hooks[hook_name]:
654
548
            # show the running hook in the progress bar. As hooks may
669
563
                     old_revno, old_revid, new_revno, self.rev_id,
670
564
                     tree_delta, future_tree)
671
565
 
 
566
    def _cleanup(self):
 
567
        """Cleanup any open locks, progress bars etc."""
 
568
        cleanups = [self._cleanup_bound_branch,
 
569
                    self.basis_tree.unlock,
 
570
                    self.work_tree.unlock,
 
571
                    self.pb.finished]
 
572
        found_exception = None
 
573
        for cleanup in cleanups:
 
574
            try:
 
575
                cleanup()
 
576
            # we want every cleanup to run no matter what.
 
577
            # so we have a catchall here, but we will raise the
 
578
            # last encountered exception up the stack: and
 
579
            # typically this will be useful enough.
 
580
            except Exception, e:
 
581
                found_exception = e
 
582
        if found_exception is not None:
 
583
            # don't do a plan raise, because the last exception may have been
 
584
            # trashed, e is our sure-to-work exception even though it loses the
 
585
            # full traceback. XXX: RBC 20060421 perhaps we could check the
 
586
            # exc_info and if its the same one do a plain raise otherwise
 
587
            # 'raise e' as we do now.
 
588
            raise e
 
589
 
 
590
    def _cleanup_bound_branch(self):
 
591
        """Executed at the end of a try/finally to cleanup a bound branch.
 
592
 
 
593
        If the branch wasn't bound, this is a no-op.
 
594
        If it was, it resents self.branch to the local branch, instead
 
595
        of being the master.
 
596
        """
 
597
        if not self.bound_branch:
 
598
            return
 
599
        if self.master_locked:
 
600
            self.master_branch.unlock()
 
601
 
 
602
    def _gather_parents(self):
 
603
        """Record the parents of a merge for merge detection."""
 
604
        # TODO: Make sure that this list doesn't contain duplicate
 
605
        # entries and the order is preserved when doing this.
 
606
        if self.use_record_iter_changes:
 
607
            return
 
608
        self.basis_inv = self.basis_tree.inventory
 
609
        self.parent_invs = [self.basis_inv]
 
610
        for revision in self.parents[1:]:
 
611
            if self.branch.repository.has_revision(revision):
 
612
                mutter('commit parent revision {%s}', revision)
 
613
                inventory = self.branch.repository.get_inventory(revision)
 
614
                self.parent_invs.append(inventory)
 
615
            else:
 
616
                mutter('commit parent ghost revision {%s}', revision)
 
617
 
672
618
    def _update_builder_with_changes(self):
673
619
        """Update the commit builder with the data about what has changed.
674
620
        """
675
 
        specific_files = self.specific_files
676
 
        mutter("Selecting files for commit with filter %r", specific_files)
 
621
        exclude = self.exclude
 
622
        specific_files = self.specific_files or []
 
623
        mutter("Selecting files for commit with filter %s", specific_files)
677
624
 
678
625
        self._check_strict()
679
 
        iter_changes = self.work_tree.iter_changes(
680
 
            self.basis_tree, specific_files=specific_files)
681
 
        if self.exclude:
682
 
            iter_changes = filter_excluded(iter_changes, self.exclude)
683
 
        iter_changes = self._filter_iter_changes(iter_changes)
684
 
        for path, fs_hash in self.builder.record_iter_changes(
 
626
        if self.use_record_iter_changes:
 
627
            iter_changes = self.work_tree.iter_changes(self.basis_tree)
 
628
            iter_changes = self._filter_iter_changes(iter_changes)
 
629
            for file_id, path, fs_hash in self.builder.record_iter_changes(
685
630
                self.work_tree, self.basis_revid, iter_changes):
686
 
            self.work_tree._observed_sha1(path, fs_hash)
 
631
                self.work_tree._observed_sha1(file_id, path, fs_hash)
 
632
        else:
 
633
            # Build the new inventory
 
634
            self._populate_from_inventory()
 
635
            self._record_unselected()
 
636
            self._report_and_accumulate_deletes()
687
637
 
688
638
    def _filter_iter_changes(self, iter_changes):
689
639
        """Process iter_changes.
690
640
 
691
 
        This method reports on the changes in iter_changes to the user, and
 
641
        This method reports on the changes in iter_changes to the user, and 
692
642
        converts 'missing' entries in the iter_changes iterator to 'deleted'
693
643
        entries. 'missing' entries have their
694
644
 
697
647
        """
698
648
        reporter = self.reporter
699
649
        report_changes = reporter.is_verbose()
700
 
        deleted_paths = []
 
650
        deleted_ids = []
701
651
        for change in iter_changes:
702
652
            if report_changes:
703
653
                old_path = change[1][0]
709
659
                # 'missing' path
710
660
                if report_changes:
711
661
                    reporter.missing(new_path)
712
 
                deleted_paths.append(change[1][1])
 
662
                deleted_ids.append(change[0])
713
663
                # Reset the new path (None) and new versioned flag (False)
714
664
                change = (change[0], (change[1][0], None), change[2],
715
 
                          (change[3][0], False)) + change[4:]
716
 
                new_path = change[1][1]
717
 
                versioned = False
 
665
                    (change[3][0], False)) + change[4:]
718
666
            elif kind == 'tree-reference':
719
667
                if self.recursive == 'down':
720
 
                    self._commit_nested_tree(change[1][1])
 
668
                    self._commit_nested_tree(change[0], change[1][1])
721
669
            if change[3][0] or change[3][1]:
722
670
                yield change
723
671
                if report_changes:
724
672
                    if new_path is None:
725
673
                        reporter.deleted(old_path)
726
674
                    elif old_path is None:
727
 
                        reporter.snapshot_change(gettext('added'), new_path)
 
675
                        reporter.snapshot_change('added', new_path)
728
676
                    elif old_path != new_path:
729
 
                        reporter.renamed(gettext('renamed'),
730
 
                                         old_path, new_path)
 
677
                        reporter.renamed('renamed', old_path, new_path)
731
678
                    else:
732
 
                        if (new_path
733
 
                                or self.work_tree.branch.repository._format.rich_root_data):
 
679
                        if (new_path or 
 
680
                            self.work_tree.branch.repository._format.rich_root_data):
734
681
                            # Don't report on changes to '' in non rich root
735
682
                            # repositories.
736
 
                            reporter.snapshot_change(
737
 
                                gettext('modified'), new_path)
 
683
                            reporter.snapshot_change('modified', new_path)
738
684
            self._next_progress_entry()
739
 
        # Unversion files that were found to be deleted
740
 
        self.deleted_paths = deleted_paths
 
685
        # Unversion IDs that were found to be deleted
 
686
        self.deleted_ids = deleted_ids
 
687
 
 
688
    def _record_unselected(self):
 
689
        # If specific files are selected, then all un-selected files must be
 
690
        # recorded in their previous state. For more details, see
 
691
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
 
692
        if self.specific_files or self.exclude:
 
693
            specific_files = self.specific_files or []
 
694
            for path, old_ie in self.basis_inv.iter_entries():
 
695
                if old_ie.file_id in self.builder.new_inventory:
 
696
                    # already added - skip.
 
697
                    continue
 
698
                if (is_inside_any(specific_files, path)
 
699
                    and not is_inside_any(self.exclude, path)):
 
700
                    # was inside the selected path, and not excluded - if not
 
701
                    # present it has been deleted so skip.
 
702
                    continue
 
703
                # From here down it was either not selected, or was excluded:
 
704
                # We preserve the entry unaltered.
 
705
                ie = old_ie.copy()
 
706
                # Note: specific file commits after a merge are currently
 
707
                # prohibited. This test is for sanity/safety in case it's
 
708
                # required after that changes.
 
709
                if len(self.parents) > 1:
 
710
                    ie.revision = None
 
711
                self.builder.record_entry_contents(ie, self.parent_invs, path,
 
712
                    self.basis_tree, None)
 
713
 
 
714
    def _report_and_accumulate_deletes(self):
 
715
        if (isinstance(self.basis_inv, Inventory)
 
716
            and isinstance(self.builder.new_inventory, Inventory)):
 
717
            # the older Inventory classes provide a _byid dict, and building a
 
718
            # set from the keys of this dict is substantially faster than even
 
719
            # getting a set of ids from the inventory
 
720
            #
 
721
            # <lifeless> set(dict) is roughly the same speed as
 
722
            # set(iter(dict)) and both are significantly slower than
 
723
            # set(dict.keys())
 
724
            deleted_ids = set(self.basis_inv._byid.keys()) - \
 
725
               set(self.builder.new_inventory._byid.keys())
 
726
        else:
 
727
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
 
728
        if deleted_ids:
 
729
            self.any_entries_deleted = True
 
730
            deleted = [(self.basis_tree.id2path(file_id), file_id)
 
731
                for file_id in deleted_ids]
 
732
            deleted.sort()
 
733
            # XXX: this is not quite directory-order sorting
 
734
            for path, file_id in deleted:
 
735
                self.builder.record_delete(path, file_id)
 
736
                self.reporter.deleted(path)
741
737
 
742
738
    def _check_strict(self):
743
739
        # XXX: when we use iter_changes this would likely be faster if
748
744
            for unknown in self.work_tree.unknowns():
749
745
                raise StrictCommitFailed()
750
746
 
751
 
    def _commit_nested_tree(self, path):
 
747
    def _populate_from_inventory(self):
 
748
        """Populate the CommitBuilder by walking the working tree inventory."""
 
749
        # Build the revision inventory.
 
750
        #
 
751
        # This starts by creating a new empty inventory. Depending on
 
752
        # which files are selected for commit, and what is present in the
 
753
        # current tree, the new inventory is populated. inventory entries
 
754
        # which are candidates for modification have their revision set to
 
755
        # None; inventory entries that are carried over untouched have their
 
756
        # revision set to their prior value.
 
757
        #
 
758
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
 
759
        # results to create a new inventory at the same time, which results
 
760
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
 
761
        # ADHB 11-07-2006
 
762
 
 
763
        specific_files = self.specific_files
 
764
        exclude = self.exclude
 
765
        report_changes = self.reporter.is_verbose()
 
766
        deleted_ids = []
 
767
        # A tree of paths that have been deleted. E.g. if foo/bar has been
 
768
        # deleted, then we have {'foo':{'bar':{}}}
 
769
        deleted_paths = {}
 
770
        # XXX: Note that entries may have the wrong kind because the entry does
 
771
        # not reflect the status on disk.
 
772
        work_inv = self.work_tree.inventory
 
773
        # NB: entries will include entries within the excluded ids/paths
 
774
        # because iter_entries_by_dir has no 'exclude' facility today.
 
775
        entries = work_inv.iter_entries_by_dir(
 
776
            specific_file_ids=self.specific_file_ids, yield_parents=True)
 
777
        for path, existing_ie in entries:
 
778
            file_id = existing_ie.file_id
 
779
            name = existing_ie.name
 
780
            parent_id = existing_ie.parent_id
 
781
            kind = existing_ie.kind
 
782
            # Skip files that have been deleted from the working tree.
 
783
            # The deleted path ids are also recorded so they can be explicitly
 
784
            # unversioned later.
 
785
            if deleted_paths:
 
786
                path_segments = splitpath(path)
 
787
                deleted_dict = deleted_paths
 
788
                for segment in path_segments:
 
789
                    deleted_dict = deleted_dict.get(segment, None)
 
790
                    if not deleted_dict:
 
791
                        # We either took a path not present in the dict
 
792
                        # (deleted_dict was None), or we've reached an empty
 
793
                        # child dir in the dict, so are now a sub-path.
 
794
                        break
 
795
                else:
 
796
                    deleted_dict = None
 
797
                if deleted_dict is not None:
 
798
                    # the path has a deleted parent, do not add it.
 
799
                    continue
 
800
            if exclude and is_inside_any(exclude, path):
 
801
                # Skip excluded paths. Excluded paths are processed by
 
802
                # _update_builder_with_changes.
 
803
                continue
 
804
            content_summary = self.work_tree.path_content_summary(path)
 
805
            # Note that when a filter of specific files is given, we must only
 
806
            # skip/record deleted files matching that filter.
 
807
            if not specific_files or is_inside_any(specific_files, path):
 
808
                if content_summary[0] == 'missing':
 
809
                    if not deleted_paths:
 
810
                        # path won't have been split yet.
 
811
                        path_segments = splitpath(path)
 
812
                    deleted_dict = deleted_paths
 
813
                    for segment in path_segments:
 
814
                        deleted_dict = deleted_dict.setdefault(segment, {})
 
815
                    self.reporter.missing(path)
 
816
                    self._next_progress_entry()
 
817
                    deleted_ids.append(file_id)
 
818
                    continue
 
819
            # TODO: have the builder do the nested commit just-in-time IF and
 
820
            # only if needed.
 
821
            if content_summary[0] == 'tree-reference':
 
822
                # enforce repository nested tree policy.
 
823
                if (not self.work_tree.supports_tree_reference() or
 
824
                    # repository does not support it either.
 
825
                    not self.branch.repository._format.supports_tree_reference):
 
826
                    content_summary = ('directory',) + content_summary[1:]
 
827
            kind = content_summary[0]
 
828
            # TODO: specific_files filtering before nested tree processing
 
829
            if kind == 'tree-reference':
 
830
                if self.recursive == 'down':
 
831
                    nested_revision_id = self._commit_nested_tree(
 
832
                        file_id, path)
 
833
                    content_summary = content_summary[:3] + (
 
834
                        nested_revision_id,)
 
835
                else:
 
836
                    content_summary = content_summary[:3] + (
 
837
                        self.work_tree.get_reference_revision(file_id),)
 
838
 
 
839
            # Record an entry for this item
 
840
            # Note: I don't particularly want to have the existing_ie
 
841
            # parameter but the test suite currently (28-Jun-07) breaks
 
842
            # without it thanks to a unicode normalisation issue. :-(
 
843
            definitely_changed = kind != existing_ie.kind
 
844
            self._record_entry(path, file_id, specific_files, kind, name,
 
845
                parent_id, definitely_changed, existing_ie, report_changes,
 
846
                content_summary)
 
847
 
 
848
        # Unversion IDs that were found to be deleted
 
849
        self.deleted_ids = deleted_ids
 
850
 
 
851
    def _commit_nested_tree(self, file_id, path):
752
852
        "Commit a nested tree."
753
 
        sub_tree = self.work_tree.get_nested_tree(path)
 
853
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
754
854
        # FIXME: be more comprehensive here:
755
855
        # this works when both trees are in --trees repository,
756
856
        # but when both are bound to a different repository,
758
858
        # finally implement the explicit-caches approach design
759
859
        # a while back - RBC 20070306.
760
860
        if sub_tree.branch.repository.has_same_location(
761
 
                self.work_tree.branch.repository):
 
861
            self.work_tree.branch.repository):
762
862
            sub_tree.branch.repository = \
763
863
                self.work_tree.branch.repository
764
864
        try:
765
865
            return sub_tree.commit(message=None, revprops=self.revprops,
766
 
                                   recursive=self.recursive,
767
 
                                   message_callback=self.message_callback,
768
 
                                   timestamp=self.timestamp,
769
 
                                   timezone=self.timezone,
770
 
                                   committer=self.committer,
771
 
                                   allow_pointless=self.allow_pointless,
772
 
                                   strict=self.strict, verbose=self.verbose,
773
 
                                   local=self.local, reporter=self.reporter)
774
 
        except PointlessCommit:
775
 
            return self.work_tree.get_reference_revision(path)
 
866
                recursive=self.recursive,
 
867
                message_callback=self.message_callback,
 
868
                timestamp=self.timestamp, timezone=self.timezone,
 
869
                committer=self.committer,
 
870
                allow_pointless=self.allow_pointless,
 
871
                strict=self.strict, verbose=self.verbose,
 
872
                local=self.local, reporter=self.reporter)
 
873
        except errors.PointlessCommit:
 
874
            return self.work_tree.get_reference_revision(file_id)
 
875
 
 
876
    def _record_entry(self, path, file_id, specific_files, kind, name,
 
877
        parent_id, definitely_changed, existing_ie, report_changes,
 
878
        content_summary):
 
879
        "Record the new inventory entry for a path if any."
 
880
        # mutter('check %s {%s}', path, file_id)
 
881
        # mutter('%s selected for commit', path)
 
882
        if definitely_changed or existing_ie is None:
 
883
            ie = make_entry(kind, name, parent_id, file_id)
 
884
        else:
 
885
            ie = existing_ie.copy()
 
886
            ie.revision = None
 
887
        # For carried over entries we don't care about the fs hash - the repo
 
888
        # isn't generating a sha, so we're not saving computation time.
 
889
        _, _, fs_hash = self.builder.record_entry_contents(
 
890
            ie, self.parent_invs, path, self.work_tree, content_summary)
 
891
        if report_changes:
 
892
            self._report_change(ie, path)
 
893
        if fs_hash:
 
894
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
 
895
        return ie
 
896
 
 
897
    def _report_change(self, ie, path):
 
898
        """Report a change to the user.
 
899
 
 
900
        The change that has occurred is described relative to the basis
 
901
        inventory.
 
902
        """
 
903
        if (self.basis_inv.has_id(ie.file_id)):
 
904
            basis_ie = self.basis_inv[ie.file_id]
 
905
        else:
 
906
            basis_ie = None
 
907
        change = ie.describe_change(basis_ie, ie)
 
908
        if change in (InventoryEntry.RENAMED,
 
909
            InventoryEntry.MODIFIED_AND_RENAMED):
 
910
            old_path = self.basis_inv.id2path(ie.file_id)
 
911
            self.reporter.renamed(change, old_path, path)
 
912
            self._next_progress_entry()
 
913
        else:
 
914
            if change == 'unchanged':
 
915
                return
 
916
            self.reporter.snapshot_change(change, path)
 
917
            self._next_progress_entry()
776
918
 
777
919
    def _set_progress_stage(self, name, counter=False):
778
920
        """Set the progress stage and emit an update to the progress bar."""
791
933
 
792
934
    def _emit_progress(self):
793
935
        if self.pb_entries_count is not None:
794
 
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
795
 
                                                       self.pb_entries_count)
 
936
            text = "%s [%d] - Stage" % (self.pb_stage_name,
 
937
                self.pb_entries_count)
796
938
        else:
797
 
            text = gettext("%s - Stage") % (self.pb_stage_name, )
 
939
            text = "%s - Stage" % (self.pb_stage_name, )
798
940
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
 
941
 
 
942
    def _set_specific_file_ids(self):
 
943
        """populate self.specific_file_ids if we will use it."""
 
944
        if not self.use_record_iter_changes:
 
945
            # If provided, ensure the specified files are versioned
 
946
            if self.specific_files is not None:
 
947
                # Note: This routine is being called because it raises
 
948
                # PathNotVersionedError as a side effect of finding the IDs. We
 
949
                # later use the ids we found as input to the working tree
 
950
                # inventory iterator, so we only consider those ids rather than
 
951
                # examining the whole tree again.
 
952
                # XXX: Dont we have filter_unversioned to do this more
 
953
                # cheaply?
 
954
                self.specific_file_ids = tree.find_ids_across_trees(
 
955
                    self.specific_files, [self.basis_tree, self.work_tree])
 
956
            else:
 
957
                self.specific_file_ids = None