/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: Vincent Ladeuil
  • Date: 2009-09-02 08:26:27 UTC
  • mto: (4669.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 4670.
  • Revision ID: v.ladeuil+lp@free.fr-20090902082627-cit8vm6tefu9hwk2
Cleanup emacs-bzr-send-XXXXXX.el leaks in /tmp during selftest.

* tests/test_mail_client.py:
(TestEmacsMail.test_commandline,
TestEmacsMail.test_commandline_is_8bit): Cleanup the generated tmp
file.

* mail_client.py:
(EmacsMail.__init__, EmacsMail._get_compose_commandline): Keep
track of the tmp file to ease cleanup during testing.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2011 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from __future__ import absolute_import
18
17
 
19
18
# The newly committed revision is going to have a shape corresponding
20
19
# to that of the working tree.  Files that are not in the
50
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
50
# the rest of the code; add a deprecation of the old name.
52
51
 
53
 
from . import (
 
52
import os
 
53
import re
 
54
import sys
 
55
import time
 
56
 
 
57
from cStringIO import StringIO
 
58
 
 
59
from bzrlib import (
54
60
    debug,
55
61
    errors,
 
62
    revision,
56
63
    trace,
57
 
    ui,
 
64
    tree,
 
65
    xml_serializer,
58
66
    )
59
 
from .branch import Branch
60
 
from .cleanup import ExitStack
61
 
import breezy.config
62
 
from .errors import (BzrError,
63
 
                     ConflictsInTree,
64
 
                     StrictCommitFailed
65
 
                     )
66
 
from .osutils import (get_user_encoding,
67
 
                      has_symlinks,
68
 
                      is_inside_any,
69
 
                      minimum_path_selection,
70
 
                      )
71
 
from .trace import mutter, note, is_quiet
72
 
from .tree import TreeChange
73
 
from .urlutils import unescape_for_display
74
 
from .i18n import gettext
75
 
 
76
 
 
77
 
class PointlessCommit(BzrError):
78
 
 
79
 
    _fmt = "No changes to commit"
80
 
 
81
 
 
82
 
class CannotCommitSelectedFileMerge(BzrError):
83
 
 
84
 
    _fmt = 'Selected-file commit of merges is not supported yet:'\
85
 
        ' files %(files_str)s'
86
 
 
87
 
    def __init__(self, files):
88
 
        files_str = ', '.join(files)
89
 
        BzrError.__init__(self, files=files, files_str=files_str)
90
 
 
91
 
 
92
 
def filter_excluded(iter_changes, exclude):
93
 
    """Filter exclude filenames.
94
 
 
95
 
    :param iter_changes: iter_changes function
96
 
    :param exclude: List of paths to exclude
97
 
    :return: iter_changes function
98
 
    """
99
 
    for change in iter_changes:
100
 
        new_excluded = (change.path[1] is not None and
101
 
                        is_inside_any(exclude, change.path[1]))
102
 
 
103
 
        old_excluded = (change.path[0] is not None and
104
 
                        is_inside_any(exclude, change.path[0]))
105
 
 
106
 
        if old_excluded and new_excluded:
107
 
            continue
108
 
 
109
 
        if old_excluded or new_excluded:
110
 
            # TODO(jelmer): Perhaps raise an error here instead?
111
 
            continue
112
 
 
113
 
        yield change
 
67
from bzrlib.branch import Branch
 
68
import bzrlib.config
 
69
from bzrlib.errors import (BzrError, PointlessCommit,
 
70
                           ConflictsInTree,
 
71
                           StrictCommitFailed
 
72
                           )
 
73
from bzrlib.osutils import (get_user_encoding,
 
74
                            kind_marker, isdir,isfile, is_inside_any,
 
75
                            is_inside_or_parent_of_any,
 
76
                            minimum_path_selection,
 
77
                            quotefn, sha_file, split_lines,
 
78
                            splitpath,
 
79
                            )
 
80
from bzrlib.testament import Testament
 
81
from bzrlib.trace import mutter, note, warning, is_quiet
 
82
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
 
83
from bzrlib import symbol_versioning
 
84
from bzrlib.symbol_versioning import (deprecated_passed,
 
85
        deprecated_function,
 
86
        DEPRECATED_PARAMETER)
 
87
from bzrlib.workingtree import WorkingTree
 
88
from bzrlib.urlutils import unescape_for_display
 
89
import bzrlib.ui
114
90
 
115
91
 
116
92
class NullCommitReporter(object):
117
93
    """I report on progress of a commit."""
118
94
 
119
 
    def started(self, revno, revid, location):
 
95
    def started(self, revno, revid, location=None):
 
96
        if location is None:
 
97
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
98
                                   "to started.", DeprecationWarning,
 
99
                                   stacklevel=2)
120
100
        pass
121
101
 
122
102
    def snapshot_change(self, change, path):
148
128
        note(format, *args)
149
129
 
150
130
    def snapshot_change(self, change, path):
151
 
        if path == '' and change in (gettext('added'), gettext('modified')):
 
131
        if path == '' and change in ('added', 'modified'):
152
132
            return
153
133
        self._note("%s %s", change, path)
154
134
 
155
 
    def started(self, revno, rev_id, location):
156
 
        self._note(
157
 
            gettext('Committing to: %s'),
158
 
            unescape_for_display(location, 'utf-8'))
 
135
    def started(self, revno, rev_id, location=None):
 
136
        if location is not None:
 
137
            location = ' to: ' + unescape_for_display(location, 'utf-8')
 
138
        else:
 
139
            # When started was added, location was only made optional by
 
140
            # accident.  Matt Nordhoff 20071129
 
141
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
142
                                   "to started.", DeprecationWarning,
 
143
                                   stacklevel=2)
 
144
            location = ''
 
145
        self._note('Committing%s', location)
159
146
 
160
147
    def completed(self, revno, rev_id):
161
 
        if revno is not None:
162
 
            self._note(gettext('Committed revision %d.'), revno)
163
 
            # self._note goes to the console too; so while we want to log the
164
 
            # rev_id, we can't trivially only log it. (See bug 526425). Long
165
 
            # term we should rearrange the reporting structure, but for now
166
 
            # we just mutter seperately. We mutter the revid and revno together
167
 
            # so that concurrent bzr invocations won't lead to confusion.
168
 
            mutter('Committed revid %s as revno %d.', rev_id, revno)
169
 
        else:
170
 
            self._note(gettext('Committed revid %s.'), rev_id)
 
148
        self._note('Committed revision %d.', revno)
171
149
 
172
150
    def deleted(self, path):
173
 
        self._note(gettext('deleted %s'), path)
 
151
        self._note('deleted %s', path)
174
152
 
175
153
    def missing(self, path):
176
 
        self._note(gettext('missing %s'), path)
 
154
        self._note('missing %s', path)
177
155
 
178
156
    def renamed(self, change, old_path, new_path):
179
157
        self._note('%s %s => %s', change, old_path, new_path)
194
172
            the working directory; these should be removed from the
195
173
            working inventory.
196
174
    """
197
 
 
198
175
    def __init__(self,
199
176
                 reporter=None,
200
 
                 config_stack=None):
 
177
                 config=None):
201
178
        """Create a Commit object.
202
179
 
203
180
        :param reporter: the default reporter to use or None to decide later
204
181
        """
205
182
        self.reporter = reporter
206
 
        self.config_stack = config_stack
207
 
 
208
 
    @staticmethod
209
 
    def update_revprops(revprops, branch, authors=None,
210
 
                        local=False, possible_master_transports=None):
211
 
        if revprops is None:
212
 
            revprops = {}
213
 
        if possible_master_transports is None:
214
 
            possible_master_transports = []
215
 
        if (u'branch-nick' not in revprops and
216
 
                branch.repository._format.supports_storing_branch_nick):
217
 
            revprops[u'branch-nick'] = branch._get_nick(
218
 
                local,
219
 
                possible_master_transports)
220
 
        if authors is not None:
221
 
            if u'author' in revprops or u'authors' in revprops:
222
 
                # XXX: maybe we should just accept one of them?
223
 
                raise AssertionError('author property given twice')
224
 
            if authors:
225
 
                for individual in authors:
226
 
                    if '\n' in individual:
227
 
                        raise AssertionError('\\n is not a valid character '
228
 
                                             'in an author identity')
229
 
                revprops[u'authors'] = '\n'.join(authors)
230
 
        return revprops
 
183
        self.config = config
231
184
 
232
185
    def commit(self,
233
186
               message=None,
247
200
               message_callback=None,
248
201
               recursive='down',
249
202
               exclude=None,
250
 
               possible_master_transports=None,
251
 
               lossy=False):
 
203
               possible_master_transports=None):
252
204
        """Commit working copy as a new revision.
253
205
 
254
206
        :param message: the commit message (it or message_callback is required)
255
 
        :param message_callback: A callback: message =
256
 
            message_callback(cmt_obj)
 
207
        :param message_callback: A callback: message = message_callback(cmt_obj)
257
208
 
258
209
        :param timestamp: if not None, seconds-since-epoch for a
259
210
            postdated/predated commit.
282
233
        :param exclude: None or a list of relative paths to exclude from the
283
234
            commit. Pending changes to excluded files will be ignored by the
284
235
            commit.
285
 
        :param lossy: When committing to a foreign VCS, ignore any
286
 
            data that can not be natively represented.
287
236
        """
288
 
        with ExitStack() as stack:
289
 
            self.revprops = revprops or {}
290
 
            # XXX: Can be set on __init__ or passed in - this is a bit ugly.
291
 
            self.config_stack = config or self.config_stack
292
 
            mutter('preparing to commit')
293
 
 
294
 
            if working_tree is None:
295
 
                raise BzrError("working_tree must be passed into commit().")
296
 
            else:
297
 
                self.work_tree = working_tree
298
 
                self.branch = self.work_tree.branch
299
 
                if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
300
 
                    if not self.branch.repository.supports_rich_root():
301
 
                        raise errors.RootNotRich()
302
 
            if message_callback is None:
303
 
                if message is not None:
304
 
                    if isinstance(message, bytes):
305
 
                        message = message.decode(get_user_encoding())
306
 
 
307
 
                    def message_callback(x):
308
 
                        return message
309
 
                else:
310
 
                    raise BzrError("The message or message_callback keyword"
311
 
                                   " parameter is required for commit().")
312
 
 
313
 
            self.bound_branch = None
314
 
            self.any_entries_deleted = False
315
 
            if exclude is not None:
316
 
                self.exclude = sorted(
317
 
                    minimum_path_selection(exclude))
318
 
            else:
319
 
                self.exclude = []
320
 
            self.local = local
321
 
            self.master_branch = None
322
 
            self.recursive = recursive
323
 
            self.rev_id = None
324
 
            # self.specific_files is None to indicate no filter, or any iterable to
325
 
            # indicate a filter - [] means no files at all, as per iter_changes.
326
 
            if specific_files is not None:
327
 
                self.specific_files = sorted(
328
 
                    minimum_path_selection(specific_files))
329
 
            else:
330
 
                self.specific_files = None
331
 
 
332
 
            self.allow_pointless = allow_pointless
333
 
            self.message_callback = message_callback
334
 
            self.timestamp = timestamp
335
 
            self.timezone = timezone
336
 
            self.committer = committer
337
 
            self.strict = strict
338
 
            self.verbose = verbose
339
 
 
340
 
            stack.enter_context(self.work_tree.lock_write())
341
 
            self.parents = self.work_tree.get_parent_ids()
342
 
            self.pb = ui.ui_factory.nested_progress_bar()
343
 
            stack.callback(self.pb.finished)
344
 
            self.basis_revid = self.work_tree.last_revision()
345
 
            self.basis_tree = self.work_tree.basis_tree()
346
 
            stack.enter_context(self.basis_tree.lock_read())
 
237
        mutter('preparing to commit')
 
238
 
 
239
        if working_tree is None:
 
240
            raise BzrError("working_tree must be passed into commit().")
 
241
        else:
 
242
            self.work_tree = working_tree
 
243
            self.branch = self.work_tree.branch
 
244
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
 
245
                if not self.branch.repository.supports_rich_root():
 
246
                    raise errors.RootNotRich()
 
247
        if message_callback is None:
 
248
            if message is not None:
 
249
                if isinstance(message, str):
 
250
                    message = message.decode(get_user_encoding())
 
251
                message_callback = lambda x: message
 
252
            else:
 
253
                raise BzrError("The message or message_callback keyword"
 
254
                               " parameter is required for commit().")
 
255
 
 
256
        self.bound_branch = None
 
257
        self.any_entries_deleted = False
 
258
        if exclude is not None:
 
259
            self.exclude = sorted(
 
260
                minimum_path_selection(exclude))
 
261
        else:
 
262
            self.exclude = []
 
263
        self.local = local
 
264
        self.master_branch = None
 
265
        self.master_locked = False
 
266
        self.recursive = recursive
 
267
        self.rev_id = None
 
268
        # self.specific_files is None to indicate no filter, or any iterable to
 
269
        # indicate a filter - [] means no files at all, as per iter_changes.
 
270
        if specific_files is not None:
 
271
            self.specific_files = sorted(
 
272
                minimum_path_selection(specific_files))
 
273
        else:
 
274
            self.specific_files = None
 
275
            
 
276
        self.allow_pointless = allow_pointless
 
277
        self.revprops = revprops
 
278
        self.message_callback = message_callback
 
279
        self.timestamp = timestamp
 
280
        self.timezone = timezone
 
281
        self.committer = committer
 
282
        self.strict = strict
 
283
        self.verbose = verbose
 
284
 
 
285
        self.work_tree.lock_write()
 
286
        self.parents = self.work_tree.get_parent_ids()
 
287
        # We can use record_iter_changes IFF iter_changes is compatible with
 
288
        # the command line parameters, and the repository has fast delta
 
289
        # generation. See bug 347649.
 
290
        self.use_record_iter_changes = (
 
291
            not self.exclude and 
 
292
            not self.branch.repository._format.supports_tree_reference and
 
293
            (self.branch.repository._format.fast_deltas or
 
294
             len(self.parents) < 2))
 
295
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
 
296
        self.basis_revid = self.work_tree.last_revision()
 
297
        self.basis_tree = self.work_tree.basis_tree()
 
298
        self.basis_tree.lock_read()
 
299
        try:
347
300
            # Cannot commit with conflicts present.
348
301
            if len(self.work_tree.conflicts()) > 0:
349
302
                raise ConflictsInTree
350
303
 
351
304
            # Setup the bound branch variables as needed.
352
 
            self._check_bound_branch(stack, possible_master_transports)
353
 
            if self.config_stack is None:
354
 
                self.config_stack = self.work_tree.get_config_stack()
 
305
            self._check_bound_branch(possible_master_transports)
355
306
 
356
307
            # Check that the working tree is up to date
357
 
            old_revno, old_revid, new_revno = self._check_out_of_date_tree()
 
308
            old_revno, new_revno = self._check_out_of_date_tree()
358
309
 
359
310
            # Complete configuration setup
360
311
            if reporter is not None:
361
312
                self.reporter = reporter
362
313
            elif self.reporter is None:
363
314
                self.reporter = self._select_reporter()
 
315
            if self.config is None:
 
316
                self.config = self.branch.get_config()
 
317
 
 
318
            self._set_specific_file_ids()
364
319
 
365
320
            # Setup the progress bar. As the number of files that need to be
366
321
            # committed in unknown, progress is reported as stages.
370
325
            self.pb_stage_count = 0
371
326
            self.pb_stage_total = 5
372
327
            if self.bound_branch:
373
 
                # 2 extra stages: "Uploading data to master branch" and "Merging
374
 
                # tags to master branch"
375
 
                self.pb_stage_total += 2
 
328
                self.pb_stage_total += 1
376
329
            self.pb.show_pct = False
377
330
            self.pb.show_spinner = False
378
331
            self.pb.show_eta = False
379
332
            self.pb.show_count = True
380
333
            self.pb.show_bar = True
381
334
 
 
335
            self._gather_parents()
382
336
            # After a merge, a selected file commit is not supported.
383
337
            # See 'bzr help merge' for an explanation as to why.
384
338
            if len(self.parents) > 1 and self.specific_files is not None:
385
 
                raise CannotCommitSelectedFileMerge(self.specific_files)
 
339
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
386
340
            # Excludes are a form of selected file commit.
387
341
            if len(self.parents) > 1 and self.exclude:
388
 
                raise CannotCommitSelectedFileMerge(self.exclude)
 
342
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
389
343
 
390
344
            # Collect the changes
391
345
            self._set_progress_stage("Collecting changes", counter=True)
392
 
            self._lossy = lossy
393
 
            self.builder = self.branch.get_commit_builder(
394
 
                self.parents, self.config_stack, timestamp, timezone, committer,
395
 
                self.revprops, rev_id, lossy=lossy)
396
 
 
397
 
            if self.builder.updates_branch and self.bound_branch:
398
 
                self.builder.abort()
399
 
                raise AssertionError(
400
 
                    "bound branches not supported for commit builders "
401
 
                    "that update the branch")
 
346
            self.builder = self.branch.get_commit_builder(self.parents,
 
347
                self.config, timestamp, timezone, committer, revprops, rev_id)
402
348
 
403
349
            try:
 
350
                self.builder.will_record_deletes()
404
351
                # find the location being committed to
405
352
                if self.bound_branch:
406
353
                    master_location = self.master_branch.base
427
374
                # Add revision data to the local branch
428
375
                self.rev_id = self.builder.commit(self.message)
429
376
 
430
 
            except Exception:
 
377
            except Exception, e:
431
378
                mutter("aborting commit write group because of exception:")
432
379
                trace.log_exception_quietly()
 
380
                note("aborting commit write group: %r" % (e,))
433
381
                self.builder.abort()
434
382
                raise
435
383
 
436
 
            self._update_branches(old_revno, old_revid, new_revno)
437
 
 
438
 
            # Make the working tree be up to date with the branch. This
439
 
            # includes automatic changes scheduled to be made to the tree, such
440
 
            # as updating its basis and unversioning paths that were missing.
441
 
            self.work_tree.unversion(self.deleted_paths)
442
 
            self._set_progress_stage("Updating the working tree")
443
 
            self.work_tree.update_basis_by_delta(self.rev_id,
444
 
                                                 self.builder.get_basis_delta())
445
 
            self.reporter.completed(new_revno, self.rev_id)
446
 
            self._process_post_hooks(old_revno, new_revno)
447
 
            return self.rev_id
448
 
 
449
 
    def _update_branches(self, old_revno, old_revid, new_revno):
450
 
        """Update the master and local branch to the new revision.
451
 
 
452
 
        This will try to make sure that the master branch is updated
453
 
        before the local branch.
454
 
 
455
 
        :param old_revno: Revision number of master branch before the
456
 
            commit
457
 
        :param old_revid: Tip of master branch before the commit
458
 
        :param new_revno: Revision number of the new commit
459
 
        """
460
 
        if not self.builder.updates_branch:
461
384
            self._process_pre_hooks(old_revno, new_revno)
462
385
 
463
386
            # Upload revision data to the master.
466
389
                self._set_progress_stage("Uploading data to master branch")
467
390
                # 'commit' to the master first so a timeout here causes the
468
391
                # local branch to be out of date
469
 
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
470
 
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
471
 
                if self._lossy:
472
 
                    self.branch.fetch(self.master_branch, self.rev_id)
 
392
                self.master_branch.import_last_revision_info(
 
393
                    self.branch.repository, new_revno, self.rev_id)
473
394
 
474
395
            # and now do the commit locally.
475
 
            if new_revno is None:
476
 
                # Keep existing behaviour around ghosts
477
 
                new_revno = 1
478
396
            self.branch.set_last_revision_info(new_revno, self.rev_id)
479
 
        else:
480
 
            try:
481
 
                self._process_pre_hooks(old_revno, new_revno)
482
 
            except BaseException:
483
 
                # The commit builder will already have updated the branch,
484
 
                # revert it.
485
 
                self.branch.set_last_revision_info(old_revno, old_revid)
486
 
                raise
487
397
 
488
 
        # Merge local tags to remote
489
 
        if self.bound_branch:
490
 
            self._set_progress_stage("Merging tags to master branch")
491
 
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
492
 
                self.master_branch.tags)
493
 
            if tag_conflicts:
494
 
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
495
 
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
496
 
                    "\n".join(warning_lines))))
 
398
            # Make the working tree be up to date with the branch. This
 
399
            # includes automatic changes scheduled to be made to the tree, such
 
400
            # as updating its basis and unversioning paths that were missing.
 
401
            self.work_tree.unversion(self.deleted_ids)
 
402
            self._set_progress_stage("Updating the working tree")
 
403
            self.work_tree.update_basis_by_delta(self.rev_id,
 
404
                 self.builder.get_basis_delta())
 
405
            self.reporter.completed(new_revno, self.rev_id)
 
406
            self._process_post_hooks(old_revno, new_revno)
 
407
        finally:
 
408
            self._cleanup()
 
409
        return self.rev_id
497
410
 
498
411
    def _select_reporter(self):
499
412
        """Select the CommitReporter to use."""
507
420
        # A merge with no effect on files
508
421
        if len(self.parents) > 1:
509
422
            return
 
423
        # TODO: we could simplify this by using self.builder.basis_delta.
 
424
 
 
425
        # The initial commit adds a root directory, but this in itself is not
 
426
        # a worthwhile commit.
 
427
        if (self.basis_revid == revision.NULL_REVISION and
 
428
            ((self.builder.new_inventory is not None and
 
429
             len(self.builder.new_inventory) == 1) or
 
430
            len(self.builder._basis_delta) == 1)):
 
431
            raise PointlessCommit()
510
432
        if self.builder.any_changes():
511
433
            return
512
434
        raise PointlessCommit()
513
435
 
514
 
    def _check_bound_branch(self, stack, possible_master_transports=None):
 
436
    def _check_bound_branch(self, possible_master_transports=None):
515
437
        """Check to see if the local branch is bound.
516
438
 
517
439
        If it is bound, then most of the commit will actually be
533
455
        # If the master branch is bound, we must fail
534
456
        master_bound_location = self.master_branch.get_bound_location()
535
457
        if master_bound_location:
536
 
            raise errors.CommitToDoubleBoundBranch(
537
 
                self.branch, self.master_branch, master_bound_location)
 
458
            raise errors.CommitToDoubleBoundBranch(self.branch,
 
459
                    self.master_branch, master_bound_location)
538
460
 
539
461
        # TODO: jam 20051230 We could automatically push local
540
462
        #       commits to the remote branch if they would fit.
542
464
        #       to local.
543
465
 
544
466
        # Make sure the local branch is identical to the master
545
 
        master_revid = self.master_branch.last_revision()
546
 
        local_revid = self.branch.last_revision()
547
 
        if local_revid != master_revid:
 
467
        master_info = self.master_branch.last_revision_info()
 
468
        local_info = self.branch.last_revision_info()
 
469
        if local_info != master_info:
548
470
            raise errors.BoundBranchOutOfDate(self.branch,
549
 
                                              self.master_branch)
 
471
                    self.master_branch)
550
472
 
551
473
        # Now things are ready to change the master branch
552
474
        # so grab the lock
553
475
        self.bound_branch = self.branch
554
 
        stack.enter_context(self.master_branch.lock_write())
 
476
        self.master_branch.lock_write()
 
477
        self.master_locked = True
555
478
 
556
479
    def _check_out_of_date_tree(self):
557
480
        """Check that the working tree is up to date.
558
481
 
559
 
        :return: old_revision_number, old_revision_id, new_revision_number
560
 
            tuple
 
482
        :return: old_revision_number,new_revision_number tuple
561
483
        """
562
484
        try:
563
485
            first_tree_parent = self.work_tree.get_parent_ids()[0]
566
488
            # this is so that we still consider the master branch
567
489
            # - in a checkout scenario the tree may have no
568
490
            # parents but the branch may do.
569
 
            first_tree_parent = breezy.revision.NULL_REVISION
570
 
        if (self.master_branch._format.stores_revno() or
571
 
                self.config_stack.get('calculate_revnos')):
572
 
            try:
573
 
                old_revno, master_last = self.master_branch.last_revision_info()
574
 
            except errors.UnsupportedOperation:
575
 
                master_last = self.master_branch.last_revision()
576
 
                old_revno = self.branch.revision_id_to_revno(master_last)
577
 
        else:
578
 
            master_last = self.master_branch.last_revision()
579
 
            old_revno = None
 
491
            first_tree_parent = bzrlib.revision.NULL_REVISION
 
492
        old_revno, master_last = self.master_branch.last_revision_info()
580
493
        if master_last != first_tree_parent:
581
 
            if master_last != breezy.revision.NULL_REVISION:
 
494
            if master_last != bzrlib.revision.NULL_REVISION:
582
495
                raise errors.OutOfDateTree(self.work_tree)
583
 
        if (old_revno is not None and
584
 
                self.branch.repository.has_revision(first_tree_parent)):
 
496
        if self.branch.repository.has_revision(first_tree_parent):
585
497
            new_revno = old_revno + 1
586
498
        else:
587
499
            # ghost parents never appear in revision history.
588
 
            new_revno = None
589
 
        return old_revno, master_last, new_revno
 
500
            new_revno = 1
 
501
        return old_revno,new_revno
590
502
 
591
503
    def _process_pre_hooks(self, old_revno, new_revno):
592
504
        """Process any registered pre commit hooks."""
598
510
        # Process the post commit hooks, if any
599
511
        self._set_progress_stage("Running post_commit hooks")
600
512
        # old style commit hooks - should be deprecated ? (obsoleted in
601
 
        # 0.15^H^H^H^H 2.5.0)
602
 
        post_commit = self.config_stack.get('post_commit')
603
 
        if post_commit is not None:
604
 
            hooks = post_commit.split(' ')
 
513
        # 0.15)
 
514
        if self.config.post_commit() is not None:
 
515
            hooks = self.config.post_commit().split(' ')
605
516
            # this would be nicer with twisted.python.reflect.namedAny
606
517
            for hook in hooks:
607
518
                result = eval(hook + '(branch, rev_id)',
608
 
                              {'branch': self.branch,
609
 
                               'breezy': breezy,
610
 
                               'rev_id': self.rev_id})
 
519
                              {'branch':self.branch,
 
520
                               'bzrlib':bzrlib,
 
521
                               'rev_id':self.rev_id})
611
522
        # process new style post commit hooks
612
523
        self._process_hooks("post_commit", old_revno, new_revno)
613
524
 
628
539
        if self.parents:
629
540
            old_revid = self.parents[0]
630
541
        else:
631
 
            old_revid = breezy.revision.NULL_REVISION
 
542
            old_revid = bzrlib.revision.NULL_REVISION
632
543
 
633
544
        if hook_name == "pre_commit":
634
545
            future_tree = self.builder.revision_tree()
635
546
            tree_delta = future_tree.changes_from(self.basis_tree,
636
 
                                                  include_root=True)
 
547
                                             include_root=True)
637
548
 
638
549
        for hook in Branch.hooks[hook_name]:
639
550
            # show the running hook in the progress bar. As hooks may
654
565
                     old_revno, old_revid, new_revno, self.rev_id,
655
566
                     tree_delta, future_tree)
656
567
 
 
568
    def _cleanup(self):
 
569
        """Cleanup any open locks, progress bars etc."""
 
570
        cleanups = [self._cleanup_bound_branch,
 
571
                    self.basis_tree.unlock,
 
572
                    self.work_tree.unlock,
 
573
                    self.pb.finished]
 
574
        found_exception = None
 
575
        for cleanup in cleanups:
 
576
            try:
 
577
                cleanup()
 
578
            # we want every cleanup to run no matter what.
 
579
            # so we have a catchall here, but we will raise the
 
580
            # last encountered exception up the stack: and
 
581
            # typically this will be useful enough.
 
582
            except Exception, e:
 
583
                found_exception = e
 
584
        if found_exception is not None:
 
585
            # don't do a plan raise, because the last exception may have been
 
586
            # trashed, e is our sure-to-work exception even though it loses the
 
587
            # full traceback. XXX: RBC 20060421 perhaps we could check the
 
588
            # exc_info and if its the same one do a plain raise otherwise
 
589
            # 'raise e' as we do now.
 
590
            raise e
 
591
 
 
592
    def _cleanup_bound_branch(self):
 
593
        """Executed at the end of a try/finally to cleanup a bound branch.
 
594
 
 
595
        If the branch wasn't bound, this is a no-op.
 
596
        If it was, it resents self.branch to the local branch, instead
 
597
        of being the master.
 
598
        """
 
599
        if not self.bound_branch:
 
600
            return
 
601
        if self.master_locked:
 
602
            self.master_branch.unlock()
 
603
 
 
604
    def _gather_parents(self):
 
605
        """Record the parents of a merge for merge detection."""
 
606
        # TODO: Make sure that this list doesn't contain duplicate
 
607
        # entries and the order is preserved when doing this.
 
608
        if self.use_record_iter_changes:
 
609
            return
 
610
        self.basis_inv = self.basis_tree.inventory
 
611
        self.parent_invs = [self.basis_inv]
 
612
        for revision in self.parents[1:]:
 
613
            if self.branch.repository.has_revision(revision):
 
614
                mutter('commit parent revision {%s}', revision)
 
615
                inventory = self.branch.repository.get_inventory(revision)
 
616
                self.parent_invs.append(inventory)
 
617
            else:
 
618
                mutter('commit parent ghost revision {%s}', revision)
 
619
 
657
620
    def _update_builder_with_changes(self):
658
621
        """Update the commit builder with the data about what has changed.
659
622
        """
 
623
        exclude = self.exclude
660
624
        specific_files = self.specific_files
661
 
        mutter("Selecting files for commit with filter %r", specific_files)
 
625
        mutter("Selecting files for commit with filter %s", specific_files)
662
626
 
663
627
        self._check_strict()
664
 
        iter_changes = self.work_tree.iter_changes(
665
 
            self.basis_tree, specific_files=specific_files)
666
 
        if self.exclude:
667
 
            iter_changes = filter_excluded(iter_changes, self.exclude)
668
 
        iter_changes = self._filter_iter_changes(iter_changes)
669
 
        for path, fs_hash in self.builder.record_iter_changes(
 
628
        if self.use_record_iter_changes:
 
629
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
 
630
                specific_files=specific_files)
 
631
            iter_changes = self._filter_iter_changes(iter_changes)
 
632
            for file_id, path, fs_hash in self.builder.record_iter_changes(
670
633
                self.work_tree, self.basis_revid, iter_changes):
671
 
            self.work_tree._observed_sha1(path, fs_hash)
 
634
                self.work_tree._observed_sha1(file_id, path, fs_hash)
 
635
        else:
 
636
            # Build the new inventory
 
637
            self._populate_from_inventory()
 
638
            self._record_unselected()
 
639
            self._report_and_accumulate_deletes()
672
640
 
673
641
    def _filter_iter_changes(self, iter_changes):
674
642
        """Process iter_changes.
675
643
 
676
 
        This method reports on the changes in iter_changes to the user, and
 
644
        This method reports on the changes in iter_changes to the user, and 
677
645
        converts 'missing' entries in the iter_changes iterator to 'deleted'
678
646
        entries. 'missing' entries have their
679
647
 
682
650
        """
683
651
        reporter = self.reporter
684
652
        report_changes = reporter.is_verbose()
685
 
        deleted_paths = []
 
653
        deleted_ids = []
686
654
        for change in iter_changes:
687
655
            if report_changes:
688
 
                old_path = change.path[0]
689
 
                new_path = change.path[1]
690
 
                versioned = change.versioned[1]
691
 
            kind = change.kind[1]
692
 
            versioned = change.versioned[1]
 
656
                old_path = change[1][0]
 
657
                new_path = change[1][1]
 
658
                versioned = change[3][1]
 
659
            kind = change[6][1]
 
660
            versioned = change[3][1]
693
661
            if kind is None and versioned:
694
662
                # 'missing' path
695
663
                if report_changes:
696
664
                    reporter.missing(new_path)
697
 
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
698
 
                    trace.warning('Ignoring "%s" as symlinks are not '
699
 
                                  'supported on this filesystem.' % (change.path[0],))
700
 
                    continue
701
 
                deleted_paths.append(change.path[1])
 
665
                deleted_ids.append(change[0])
702
666
                # Reset the new path (None) and new versioned flag (False)
703
 
                change = change.discard_new()
704
 
                new_path = change.path[1]
705
 
                versioned = False
 
667
                change = (change[0], (change[1][0], None), change[2],
 
668
                    (change[3][0], False)) + change[4:]
706
669
            elif kind == 'tree-reference':
707
670
                if self.recursive == 'down':
708
 
                    self._commit_nested_tree(change.path[1])
709
 
            if change.versioned[0] or change.versioned[1]:
 
671
                    self._commit_nested_tree(change[0], change[1][1])
 
672
            if change[3][0] or change[3][1]:
710
673
                yield change
711
674
                if report_changes:
712
675
                    if new_path is None:
713
676
                        reporter.deleted(old_path)
714
677
                    elif old_path is None:
715
 
                        reporter.snapshot_change(gettext('added'), new_path)
 
678
                        reporter.snapshot_change('added', new_path)
716
679
                    elif old_path != new_path:
717
 
                        reporter.renamed(gettext('renamed'),
718
 
                                         old_path, new_path)
 
680
                        reporter.renamed('renamed', old_path, new_path)
719
681
                    else:
720
 
                        if (new_path
721
 
                                or self.work_tree.branch.repository._format.rich_root_data):
 
682
                        if (new_path or 
 
683
                            self.work_tree.branch.repository._format.rich_root_data):
722
684
                            # Don't report on changes to '' in non rich root
723
685
                            # repositories.
724
 
                            reporter.snapshot_change(
725
 
                                gettext('modified'), new_path)
 
686
                            reporter.snapshot_change('modified', new_path)
726
687
            self._next_progress_entry()
727
 
        # Unversion files that were found to be deleted
728
 
        self.deleted_paths = deleted_paths
 
688
        # Unversion IDs that were found to be deleted
 
689
        self.deleted_ids = deleted_ids
 
690
 
 
691
    def _record_unselected(self):
 
692
        # If specific files are selected, then all un-selected files must be
 
693
        # recorded in their previous state. For more details, see
 
694
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
 
695
        if self.specific_files or self.exclude:
 
696
            specific_files = self.specific_files or []
 
697
            for path, old_ie in self.basis_inv.iter_entries():
 
698
                if old_ie.file_id in self.builder.new_inventory:
 
699
                    # already added - skip.
 
700
                    continue
 
701
                if (is_inside_any(specific_files, path)
 
702
                    and not is_inside_any(self.exclude, path)):
 
703
                    # was inside the selected path, and not excluded - if not
 
704
                    # present it has been deleted so skip.
 
705
                    continue
 
706
                # From here down it was either not selected, or was excluded:
 
707
                # We preserve the entry unaltered.
 
708
                ie = old_ie.copy()
 
709
                # Note: specific file commits after a merge are currently
 
710
                # prohibited. This test is for sanity/safety in case it's
 
711
                # required after that changes.
 
712
                if len(self.parents) > 1:
 
713
                    ie.revision = None
 
714
                self.builder.record_entry_contents(ie, self.parent_invs, path,
 
715
                    self.basis_tree, None)
 
716
 
 
717
    def _report_and_accumulate_deletes(self):
 
718
        if (isinstance(self.basis_inv, Inventory)
 
719
            and isinstance(self.builder.new_inventory, Inventory)):
 
720
            # the older Inventory classes provide a _byid dict, and building a
 
721
            # set from the keys of this dict is substantially faster than even
 
722
            # getting a set of ids from the inventory
 
723
            #
 
724
            # <lifeless> set(dict) is roughly the same speed as
 
725
            # set(iter(dict)) and both are significantly slower than
 
726
            # set(dict.keys())
 
727
            deleted_ids = set(self.basis_inv._byid.keys()) - \
 
728
               set(self.builder.new_inventory._byid.keys())
 
729
        else:
 
730
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
 
731
        if deleted_ids:
 
732
            self.any_entries_deleted = True
 
733
            deleted = [(self.basis_tree.id2path(file_id), file_id)
 
734
                for file_id in deleted_ids]
 
735
            deleted.sort()
 
736
            # XXX: this is not quite directory-order sorting
 
737
            for path, file_id in deleted:
 
738
                self.builder.record_delete(path, file_id)
 
739
                self.reporter.deleted(path)
729
740
 
730
741
    def _check_strict(self):
731
742
        # XXX: when we use iter_changes this would likely be faster if
736
747
            for unknown in self.work_tree.unknowns():
737
748
                raise StrictCommitFailed()
738
749
 
739
 
    def _commit_nested_tree(self, path):
 
750
    def _populate_from_inventory(self):
 
751
        """Populate the CommitBuilder by walking the working tree inventory."""
 
752
        # Build the revision inventory.
 
753
        #
 
754
        # This starts by creating a new empty inventory. Depending on
 
755
        # which files are selected for commit, and what is present in the
 
756
        # current tree, the new inventory is populated. inventory entries
 
757
        # which are candidates for modification have their revision set to
 
758
        # None; inventory entries that are carried over untouched have their
 
759
        # revision set to their prior value.
 
760
        #
 
761
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
 
762
        # results to create a new inventory at the same time, which results
 
763
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
 
764
        # ADHB 11-07-2006
 
765
 
 
766
        specific_files = self.specific_files
 
767
        exclude = self.exclude
 
768
        report_changes = self.reporter.is_verbose()
 
769
        deleted_ids = []
 
770
        # A tree of paths that have been deleted. E.g. if foo/bar has been
 
771
        # deleted, then we have {'foo':{'bar':{}}}
 
772
        deleted_paths = {}
 
773
        # XXX: Note that entries may have the wrong kind because the entry does
 
774
        # not reflect the status on disk.
 
775
        work_inv = self.work_tree.inventory
 
776
        # NB: entries will include entries within the excluded ids/paths
 
777
        # because iter_entries_by_dir has no 'exclude' facility today.
 
778
        entries = work_inv.iter_entries_by_dir(
 
779
            specific_file_ids=self.specific_file_ids, yield_parents=True)
 
780
        for path, existing_ie in entries:
 
781
            file_id = existing_ie.file_id
 
782
            name = existing_ie.name
 
783
            parent_id = existing_ie.parent_id
 
784
            kind = existing_ie.kind
 
785
            # Skip files that have been deleted from the working tree.
 
786
            # The deleted path ids are also recorded so they can be explicitly
 
787
            # unversioned later.
 
788
            if deleted_paths:
 
789
                path_segments = splitpath(path)
 
790
                deleted_dict = deleted_paths
 
791
                for segment in path_segments:
 
792
                    deleted_dict = deleted_dict.get(segment, None)
 
793
                    if not deleted_dict:
 
794
                        # We either took a path not present in the dict
 
795
                        # (deleted_dict was None), or we've reached an empty
 
796
                        # child dir in the dict, so are now a sub-path.
 
797
                        break
 
798
                else:
 
799
                    deleted_dict = None
 
800
                if deleted_dict is not None:
 
801
                    # the path has a deleted parent, do not add it.
 
802
                    continue
 
803
            if exclude and is_inside_any(exclude, path):
 
804
                # Skip excluded paths. Excluded paths are processed by
 
805
                # _update_builder_with_changes.
 
806
                continue
 
807
            content_summary = self.work_tree.path_content_summary(path)
 
808
            # Note that when a filter of specific files is given, we must only
 
809
            # skip/record deleted files matching that filter.
 
810
            if not specific_files or is_inside_any(specific_files, path):
 
811
                if content_summary[0] == 'missing':
 
812
                    if not deleted_paths:
 
813
                        # path won't have been split yet.
 
814
                        path_segments = splitpath(path)
 
815
                    deleted_dict = deleted_paths
 
816
                    for segment in path_segments:
 
817
                        deleted_dict = deleted_dict.setdefault(segment, {})
 
818
                    self.reporter.missing(path)
 
819
                    self._next_progress_entry()
 
820
                    deleted_ids.append(file_id)
 
821
                    continue
 
822
            # TODO: have the builder do the nested commit just-in-time IF and
 
823
            # only if needed.
 
824
            if content_summary[0] == 'tree-reference':
 
825
                # enforce repository nested tree policy.
 
826
                if (not self.work_tree.supports_tree_reference() or
 
827
                    # repository does not support it either.
 
828
                    not self.branch.repository._format.supports_tree_reference):
 
829
                    content_summary = ('directory',) + content_summary[1:]
 
830
            kind = content_summary[0]
 
831
            # TODO: specific_files filtering before nested tree processing
 
832
            if kind == 'tree-reference':
 
833
                if self.recursive == 'down':
 
834
                    nested_revision_id = self._commit_nested_tree(
 
835
                        file_id, path)
 
836
                    content_summary = content_summary[:3] + (
 
837
                        nested_revision_id,)
 
838
                else:
 
839
                    content_summary = content_summary[:3] + (
 
840
                        self.work_tree.get_reference_revision(file_id),)
 
841
 
 
842
            # Record an entry for this item
 
843
            # Note: I don't particularly want to have the existing_ie
 
844
            # parameter but the test suite currently (28-Jun-07) breaks
 
845
            # without it thanks to a unicode normalisation issue. :-(
 
846
            definitely_changed = kind != existing_ie.kind
 
847
            self._record_entry(path, file_id, specific_files, kind, name,
 
848
                parent_id, definitely_changed, existing_ie, report_changes,
 
849
                content_summary)
 
850
 
 
851
        # Unversion IDs that were found to be deleted
 
852
        self.deleted_ids = deleted_ids
 
853
 
 
854
    def _commit_nested_tree(self, file_id, path):
740
855
        "Commit a nested tree."
741
 
        sub_tree = self.work_tree.get_nested_tree(path)
 
856
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
742
857
        # FIXME: be more comprehensive here:
743
858
        # this works when both trees are in --trees repository,
744
859
        # but when both are bound to a different repository,
746
861
        # finally implement the explicit-caches approach design
747
862
        # a while back - RBC 20070306.
748
863
        if sub_tree.branch.repository.has_same_location(
749
 
                self.work_tree.branch.repository):
 
864
            self.work_tree.branch.repository):
750
865
            sub_tree.branch.repository = \
751
866
                self.work_tree.branch.repository
752
867
        try:
753
868
            return sub_tree.commit(message=None, revprops=self.revprops,
754
 
                                   recursive=self.recursive,
755
 
                                   message_callback=self.message_callback,
756
 
                                   timestamp=self.timestamp,
757
 
                                   timezone=self.timezone,
758
 
                                   committer=self.committer,
759
 
                                   allow_pointless=self.allow_pointless,
760
 
                                   strict=self.strict, verbose=self.verbose,
761
 
                                   local=self.local, reporter=self.reporter)
762
 
        except PointlessCommit:
763
 
            return self.work_tree.get_reference_revision(path)
 
869
                recursive=self.recursive,
 
870
                message_callback=self.message_callback,
 
871
                timestamp=self.timestamp, timezone=self.timezone,
 
872
                committer=self.committer,
 
873
                allow_pointless=self.allow_pointless,
 
874
                strict=self.strict, verbose=self.verbose,
 
875
                local=self.local, reporter=self.reporter)
 
876
        except errors.PointlessCommit:
 
877
            return self.work_tree.get_reference_revision(file_id)
 
878
 
 
879
    def _record_entry(self, path, file_id, specific_files, kind, name,
 
880
        parent_id, definitely_changed, existing_ie, report_changes,
 
881
        content_summary):
 
882
        "Record the new inventory entry for a path if any."
 
883
        # mutter('check %s {%s}', path, file_id)
 
884
        # mutter('%s selected for commit', path)
 
885
        if definitely_changed or existing_ie is None:
 
886
            ie = make_entry(kind, name, parent_id, file_id)
 
887
        else:
 
888
            ie = existing_ie.copy()
 
889
            ie.revision = None
 
890
        # For carried over entries we don't care about the fs hash - the repo
 
891
        # isn't generating a sha, so we're not saving computation time.
 
892
        _, _, fs_hash = self.builder.record_entry_contents(
 
893
            ie, self.parent_invs, path, self.work_tree, content_summary)
 
894
        if report_changes:
 
895
            self._report_change(ie, path)
 
896
        if fs_hash:
 
897
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
 
898
        return ie
 
899
 
 
900
    def _report_change(self, ie, path):
 
901
        """Report a change to the user.
 
902
 
 
903
        The change that has occurred is described relative to the basis
 
904
        inventory.
 
905
        """
 
906
        if (self.basis_inv.has_id(ie.file_id)):
 
907
            basis_ie = self.basis_inv[ie.file_id]
 
908
        else:
 
909
            basis_ie = None
 
910
        change = ie.describe_change(basis_ie, ie)
 
911
        if change in (InventoryEntry.RENAMED,
 
912
            InventoryEntry.MODIFIED_AND_RENAMED):
 
913
            old_path = self.basis_inv.id2path(ie.file_id)
 
914
            self.reporter.renamed(change, old_path, path)
 
915
            self._next_progress_entry()
 
916
        else:
 
917
            if change == 'unchanged':
 
918
                return
 
919
            self.reporter.snapshot_change(change, path)
 
920
            self._next_progress_entry()
764
921
 
765
922
    def _set_progress_stage(self, name, counter=False):
766
923
        """Set the progress stage and emit an update to the progress bar."""
779
936
 
780
937
    def _emit_progress(self):
781
938
        if self.pb_entries_count is not None:
782
 
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
783
 
                                                       self.pb_entries_count)
 
939
            text = "%s [%d] - Stage" % (self.pb_stage_name,
 
940
                self.pb_entries_count)
784
941
        else:
785
 
            text = gettext("%s - Stage") % (self.pb_stage_name, )
 
942
            text = "%s - Stage" % (self.pb_stage_name, )
786
943
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
 
944
 
 
945
    def _set_specific_file_ids(self):
 
946
        """populate self.specific_file_ids if we will use it."""
 
947
        if not self.use_record_iter_changes:
 
948
            # If provided, ensure the specified files are versioned
 
949
            if self.specific_files is not None:
 
950
                # Note: This routine is being called because it raises
 
951
                # PathNotVersionedError as a side effect of finding the IDs. We
 
952
                # later use the ids we found as input to the working tree
 
953
                # inventory iterator, so we only consider those ids rather than
 
954
                # examining the whole tree again.
 
955
                # XXX: Dont we have filter_unversioned to do this more
 
956
                # cheaply?
 
957
                self.specific_file_ids = tree.find_ids_across_trees(
 
958
                    self.specific_files, [self.basis_tree, self.work_tree])
 
959
            else:
 
960
                self.specific_file_ids = None