/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: Vincent Ladeuil
  • Date: 2009-10-06 14:40:37 UTC
  • mto: (4728.1.2 integration)
  • mto: This revision was merged to the branch mainline in revision 4731.
  • Revision ID: v.ladeuil+lp@free.fr-20091006144037-o76rgosv9hj3td0y
Simplify mutable_tree.has_changes() and update call sites.

* bzrlib/workingtree.py:
(WorkingTree.merge_from_branch): Add a force parameter. Replace
the check_basis() call by the corresponding code, taken the new
'force' parameter into account.

* bzrlib/tests/test_status.py:
(TestStatus.make_multiple_pending_tree): Add force=True on
supplementary merges.

* bzrlib/tests/test_reconfigure.py:
(TestReconfigure): Add a test for pending merges.

* bzrlib/tests/test_msgeditor.py:
(MsgEditorTest.make_multiple_pending_tree): Add force=True on
supplementary merges.

* bzrlib/tests/blackbox/test_uncommit.py:
(TestUncommit.test_uncommit_octopus_merge): Add force=True on
supplementary merges.

* bzrlib/send.py:
(send): Use the simplified has_changes(). Fix typo in comment too.

* bzrlib/reconfigure.py:
(Reconfigure._check): Use the simplified has_changes().

* bzrlib/mutabletree.py:
(MutableTree.has_changes): Make the tree parameter optional but
retain it for tests. Add a pending merges check.

* bzrlib/merge.py:
(Merger.ensure_revision_trees, Merger.file_revisions,
Merger.check_basis, Merger.compare_basis): Deprecate.

* bzrlib/bundle/apply_bundle.py:
(merge_bundle): Replace the check_basis() call by the
corresponding code.

* bzrlib/builtins.py:
(cmd_remove_tree.run, cmd_push.run, cmd_merge.run): Use the
simplified has_changes().
(cmd_merge.run): Replace the check_basis call() by the corresponding
code (minus the alredy done has_changes() check).

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2011 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from __future__ import absolute_import
18
17
 
19
18
# The newly committed revision is going to have a shape corresponding
20
19
# to that of the working tree.  Files that are not in the
50
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
50
# the rest of the code; add a deprecation of the old name.
52
51
 
53
 
from . import (
 
52
import os
 
53
import re
 
54
import sys
 
55
import time
 
56
 
 
57
from cStringIO import StringIO
 
58
 
 
59
from bzrlib import (
54
60
    debug,
55
61
    errors,
 
62
    revision,
56
63
    trace,
57
 
    ui,
 
64
    tree,
 
65
    xml_serializer,
58
66
    )
59
 
from .branch import Branch
60
 
from .cleanup import OperationWithCleanups
61
 
import breezy.config
62
 
from .errors import (BzrError,
63
 
                     ConflictsInTree,
64
 
                     StrictCommitFailed
65
 
                     )
66
 
from .osutils import (get_user_encoding,
67
 
                      is_inside_any,
68
 
                      minimum_path_selection,
69
 
                      )
70
 
from .trace import mutter, note, is_quiet
71
 
from .urlutils import unescape_for_display
72
 
from .i18n import gettext
73
 
 
74
 
 
75
 
class PointlessCommit(BzrError):
76
 
 
77
 
    _fmt = "No changes to commit"
78
 
 
79
 
 
80
 
class CannotCommitSelectedFileMerge(BzrError):
81
 
 
82
 
    _fmt = 'Selected-file commit of merges is not supported yet:'\
83
 
        ' files %(files_str)s'
84
 
 
85
 
    def __init__(self, files):
86
 
        files_str = ', '.join(files)
87
 
        BzrError.__init__(self, files=files, files_str=files_str)
88
 
 
89
 
 
90
 
def filter_excluded(iter_changes, exclude):
91
 
    """Filter exclude filenames.
92
 
 
93
 
    :param iter_changes: iter_changes function
94
 
    :param exclude: List of paths to exclude
95
 
    :return: iter_changes function
96
 
    """
97
 
    for change in iter_changes:
98
 
        old_path = change[1][0]
99
 
        new_path = change[1][1]
100
 
 
101
 
        new_excluded = (new_path is not None and
102
 
                        is_inside_any(exclude, new_path))
103
 
 
104
 
        old_excluded = (old_path is not None and
105
 
                        is_inside_any(exclude, old_path))
106
 
 
107
 
        if old_excluded and new_excluded:
108
 
            continue
109
 
 
110
 
        if old_excluded or new_excluded:
111
 
            # TODO(jelmer): Perhaps raise an error here instead?
112
 
            continue
113
 
 
114
 
        yield change
 
67
from bzrlib.branch import Branch
 
68
import bzrlib.config
 
69
from bzrlib.errors import (BzrError, PointlessCommit,
 
70
                           ConflictsInTree,
 
71
                           StrictCommitFailed
 
72
                           )
 
73
from bzrlib.osutils import (get_user_encoding,
 
74
                            kind_marker, isdir,isfile, is_inside_any,
 
75
                            is_inside_or_parent_of_any,
 
76
                            minimum_path_selection,
 
77
                            quotefn, sha_file, split_lines,
 
78
                            splitpath,
 
79
                            )
 
80
from bzrlib.testament import Testament
 
81
from bzrlib.trace import mutter, note, warning, is_quiet
 
82
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
 
83
from bzrlib import symbol_versioning
 
84
from bzrlib.symbol_versioning import (deprecated_passed,
 
85
        deprecated_function,
 
86
        DEPRECATED_PARAMETER)
 
87
from bzrlib.workingtree import WorkingTree
 
88
from bzrlib.urlutils import unescape_for_display
 
89
import bzrlib.ui
115
90
 
116
91
 
117
92
class NullCommitReporter(object):
118
93
    """I report on progress of a commit."""
119
94
 
120
 
    def started(self, revno, revid, location):
 
95
    def started(self, revno, revid, location=None):
 
96
        if location is None:
 
97
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
98
                                   "to started.", DeprecationWarning,
 
99
                                   stacklevel=2)
121
100
        pass
122
101
 
123
102
    def snapshot_change(self, change, path):
149
128
        note(format, *args)
150
129
 
151
130
    def snapshot_change(self, change, path):
152
 
        if path == '' and change in (gettext('added'), gettext('modified')):
 
131
        if path == '' and change in ('added', 'modified'):
153
132
            return
154
133
        self._note("%s %s", change, path)
155
134
 
156
 
    def started(self, revno, rev_id, location):
157
 
        self._note(
158
 
            gettext('Committing to: %s'),
159
 
            unescape_for_display(location, 'utf-8'))
 
135
    def started(self, revno, rev_id, location=None):
 
136
        if location is not None:
 
137
            location = ' to: ' + unescape_for_display(location, 'utf-8')
 
138
        else:
 
139
            # When started was added, location was only made optional by
 
140
            # accident.  Matt Nordhoff 20071129
 
141
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
 
142
                                   "to started.", DeprecationWarning,
 
143
                                   stacklevel=2)
 
144
            location = ''
 
145
        self._note('Committing%s', location)
160
146
 
161
147
    def completed(self, revno, rev_id):
162
 
        self._note(gettext('Committed revision %d.'), revno)
163
 
        # self._note goes to the console too; so while we want to log the
164
 
        # rev_id, we can't trivially only log it. (See bug 526425). Long
165
 
        # term we should rearrange the reporting structure, but for now
166
 
        # we just mutter seperately. We mutter the revid and revno together
167
 
        # so that concurrent bzr invocations won't lead to confusion.
168
 
        mutter('Committed revid %s as revno %d.', rev_id, revno)
 
148
        self._note('Committed revision %d.', revno)
169
149
 
170
150
    def deleted(self, path):
171
 
        self._note(gettext('deleted %s'), path)
 
151
        self._note('deleted %s', path)
172
152
 
173
153
    def missing(self, path):
174
 
        self._note(gettext('missing %s'), path)
 
154
        self._note('missing %s', path)
175
155
 
176
156
    def renamed(self, change, old_path, new_path):
177
157
        self._note('%s %s => %s', change, old_path, new_path)
192
172
            the working directory; these should be removed from the
193
173
            working inventory.
194
174
    """
195
 
 
196
175
    def __init__(self,
197
176
                 reporter=None,
198
 
                 config_stack=None):
 
177
                 config=None):
199
178
        """Create a Commit object.
200
179
 
201
180
        :param reporter: the default reporter to use or None to decide later
202
181
        """
203
182
        self.reporter = reporter
204
 
        self.config_stack = config_stack
205
 
 
206
 
    @staticmethod
207
 
    def update_revprops(revprops, branch, authors=None,
208
 
                        local=False, possible_master_transports=None):
209
 
        if revprops is None:
210
 
            revprops = {}
211
 
        if possible_master_transports is None:
212
 
            possible_master_transports = []
213
 
        if (u'branch-nick' not in revprops and
214
 
                branch.repository._format.supports_storing_branch_nick):
215
 
            revprops[u'branch-nick'] = branch._get_nick(
216
 
                local,
217
 
                possible_master_transports)
218
 
        if authors is not None:
219
 
            if u'author' in revprops or u'authors' in revprops:
220
 
                # XXX: maybe we should just accept one of them?
221
 
                raise AssertionError('author property given twice')
222
 
            if authors:
223
 
                for individual in authors:
224
 
                    if '\n' in individual:
225
 
                        raise AssertionError('\\n is not a valid character '
226
 
                                             'in an author identity')
227
 
                revprops[u'authors'] = '\n'.join(authors)
228
 
        return revprops
 
183
        self.config = config
229
184
 
230
185
    def commit(self,
231
186
               message=None,
245
200
               message_callback=None,
246
201
               recursive='down',
247
202
               exclude=None,
248
 
               possible_master_transports=None,
249
 
               lossy=False):
 
203
               possible_master_transports=None):
250
204
        """Commit working copy as a new revision.
251
205
 
252
206
        :param message: the commit message (it or message_callback is required)
253
 
        :param message_callback: A callback: message =
254
 
            message_callback(cmt_obj)
 
207
        :param message_callback: A callback: message = message_callback(cmt_obj)
255
208
 
256
209
        :param timestamp: if not None, seconds-since-epoch for a
257
210
            postdated/predated commit.
280
233
        :param exclude: None or a list of relative paths to exclude from the
281
234
            commit. Pending changes to excluded files will be ignored by the
282
235
            commit.
283
 
        :param lossy: When committing to a foreign VCS, ignore any
284
 
            data that can not be natively represented.
285
236
        """
286
 
        operation = OperationWithCleanups(self._commit)
287
 
        self.revprops = revprops or {}
288
 
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
289
 
        self.config_stack = config or self.config_stack
290
 
        return operation.run(
291
 
            message=message,
292
 
            timestamp=timestamp,
293
 
            timezone=timezone,
294
 
            committer=committer,
295
 
            specific_files=specific_files,
296
 
            rev_id=rev_id,
297
 
            allow_pointless=allow_pointless,
298
 
            strict=strict,
299
 
            verbose=verbose,
300
 
            working_tree=working_tree,
301
 
            local=local,
302
 
            reporter=reporter,
303
 
            message_callback=message_callback,
304
 
            recursive=recursive,
305
 
            exclude=exclude,
306
 
            possible_master_transports=possible_master_transports,
307
 
            lossy=lossy)
308
 
 
309
 
    def _commit(self, operation, message, timestamp, timezone, committer,
310
 
                specific_files, rev_id, allow_pointless, strict, verbose,
311
 
                working_tree, local, reporter, message_callback, recursive,
312
 
                exclude, possible_master_transports, lossy):
313
237
        mutter('preparing to commit')
314
238
 
315
239
        if working_tree is None:
322
246
                    raise errors.RootNotRich()
323
247
        if message_callback is None:
324
248
            if message is not None:
325
 
                if isinstance(message, bytes):
 
249
                if isinstance(message, str):
326
250
                    message = message.decode(get_user_encoding())
327
 
 
328
 
                def message_callback(x):
329
 
                    return message
 
251
                message_callback = lambda x: message
330
252
            else:
331
253
                raise BzrError("The message or message_callback keyword"
332
254
                               " parameter is required for commit().")
340
262
            self.exclude = []
341
263
        self.local = local
342
264
        self.master_branch = None
 
265
        self.master_locked = False
343
266
        self.recursive = recursive
344
267
        self.rev_id = None
345
268
        # self.specific_files is None to indicate no filter, or any iterable to
349
272
                minimum_path_selection(specific_files))
350
273
        else:
351
274
            self.specific_files = None
352
 
 
 
275
            
353
276
        self.allow_pointless = allow_pointless
 
277
        self.revprops = revprops
354
278
        self.message_callback = message_callback
355
279
        self.timestamp = timestamp
356
280
        self.timezone = timezone
359
283
        self.verbose = verbose
360
284
 
361
285
        self.work_tree.lock_write()
362
 
        operation.add_cleanup(self.work_tree.unlock)
363
286
        self.parents = self.work_tree.get_parent_ids()
364
 
        self.pb = ui.ui_factory.nested_progress_bar()
365
 
        operation.add_cleanup(self.pb.finished)
 
287
        # We can use record_iter_changes IFF iter_changes is compatible with
 
288
        # the command line parameters, and the repository has fast delta
 
289
        # generation. See bug 347649.
 
290
        self.use_record_iter_changes = (
 
291
            not self.exclude and 
 
292
            not self.branch.repository._format.supports_tree_reference and
 
293
            (self.branch.repository._format.fast_deltas or
 
294
             len(self.parents) < 2))
 
295
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
366
296
        self.basis_revid = self.work_tree.last_revision()
367
297
        self.basis_tree = self.work_tree.basis_tree()
368
298
        self.basis_tree.lock_read()
369
 
        operation.add_cleanup(self.basis_tree.unlock)
370
 
        # Cannot commit with conflicts present.
371
 
        if len(self.work_tree.conflicts()) > 0:
372
 
            raise ConflictsInTree
373
 
 
374
 
        # Setup the bound branch variables as needed.
375
 
        self._check_bound_branch(operation, possible_master_transports)
376
 
 
377
 
        # Check that the working tree is up to date
378
 
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
379
 
 
380
 
        # Complete configuration setup
381
 
        if reporter is not None:
382
 
            self.reporter = reporter
383
 
        elif self.reporter is None:
384
 
            self.reporter = self._select_reporter()
385
 
        if self.config_stack is None:
386
 
            self.config_stack = self.work_tree.get_config_stack()
387
 
 
388
 
        # Setup the progress bar. As the number of files that need to be
389
 
        # committed in unknown, progress is reported as stages.
390
 
        # We keep track of entries separately though and include that
391
 
        # information in the progress bar during the relevant stages.
392
 
        self.pb_stage_name = ""
393
 
        self.pb_stage_count = 0
394
 
        self.pb_stage_total = 5
395
 
        if self.bound_branch:
396
 
            # 2 extra stages: "Uploading data to master branch" and "Merging
397
 
            # tags to master branch"
398
 
            self.pb_stage_total += 2
399
 
        self.pb.show_pct = False
400
 
        self.pb.show_spinner = False
401
 
        self.pb.show_eta = False
402
 
        self.pb.show_count = True
403
 
        self.pb.show_bar = True
404
 
 
405
 
        # After a merge, a selected file commit is not supported.
406
 
        # See 'bzr help merge' for an explanation as to why.
407
 
        if len(self.parents) > 1 and self.specific_files is not None:
408
 
            raise CannotCommitSelectedFileMerge(self.specific_files)
409
 
        # Excludes are a form of selected file commit.
410
 
        if len(self.parents) > 1 and self.exclude:
411
 
            raise CannotCommitSelectedFileMerge(self.exclude)
412
 
 
413
 
        # Collect the changes
414
 
        self._set_progress_stage("Collecting changes", counter=True)
415
 
        self._lossy = lossy
416
 
        self.builder = self.branch.get_commit_builder(
417
 
            self.parents, self.config_stack, timestamp, timezone, committer,
418
 
            self.revprops, rev_id, lossy=lossy)
419
 
 
420
 
        if self.builder.updates_branch and self.bound_branch:
421
 
            self.builder.abort()
422
 
            raise AssertionError(
423
 
                "bound branches not supported for commit builders "
424
 
                "that update the branch")
425
 
 
426
299
        try:
427
 
            # find the location being committed to
 
300
            # Cannot commit with conflicts present.
 
301
            if len(self.work_tree.conflicts()) > 0:
 
302
                raise ConflictsInTree
 
303
 
 
304
            # Setup the bound branch variables as needed.
 
305
            self._check_bound_branch(possible_master_transports)
 
306
 
 
307
            # Check that the working tree is up to date
 
308
            old_revno, new_revno = self._check_out_of_date_tree()
 
309
 
 
310
            # Complete configuration setup
 
311
            if reporter is not None:
 
312
                self.reporter = reporter
 
313
            elif self.reporter is None:
 
314
                self.reporter = self._select_reporter()
 
315
            if self.config is None:
 
316
                self.config = self.branch.get_config()
 
317
 
 
318
            self._set_specific_file_ids()
 
319
 
 
320
            # Setup the progress bar. As the number of files that need to be
 
321
            # committed in unknown, progress is reported as stages.
 
322
            # We keep track of entries separately though and include that
 
323
            # information in the progress bar during the relevant stages.
 
324
            self.pb_stage_name = ""
 
325
            self.pb_stage_count = 0
 
326
            self.pb_stage_total = 5
428
327
            if self.bound_branch:
429
 
                master_location = self.master_branch.base
430
 
            else:
431
 
                master_location = self.branch.base
432
 
 
433
 
            # report the start of the commit
434
 
            self.reporter.started(new_revno, self.rev_id, master_location)
435
 
 
436
 
            self._update_builder_with_changes()
437
 
            self._check_pointless()
438
 
 
439
 
            # TODO: Now the new inventory is known, check for conflicts.
440
 
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
441
 
            # weave lines, because nothing should be recorded until it is known
442
 
            # that commit will succeed.
443
 
            self._set_progress_stage("Saving data locally")
444
 
            self.builder.finish_inventory()
445
 
 
446
 
            # Prompt the user for a commit message if none provided
447
 
            message = message_callback(self)
448
 
            self.message = message
449
 
 
450
 
            # Add revision data to the local branch
451
 
            self.rev_id = self.builder.commit(self.message)
452
 
 
453
 
        except Exception:
454
 
            mutter("aborting commit write group because of exception:")
455
 
            trace.log_exception_quietly()
456
 
            self.builder.abort()
457
 
            raise
458
 
 
459
 
        self._update_branches(old_revno, old_revid, new_revno)
460
 
 
461
 
        # Make the working tree be up to date with the branch. This
462
 
        # includes automatic changes scheduled to be made to the tree, such
463
 
        # as updating its basis and unversioning paths that were missing.
464
 
        self.work_tree.unversion(self.deleted_paths)
465
 
        self._set_progress_stage("Updating the working tree")
466
 
        self.work_tree.update_basis_by_delta(self.rev_id,
467
 
                                             self.builder.get_basis_delta())
468
 
        self.reporter.completed(new_revno, self.rev_id)
469
 
        self._process_post_hooks(old_revno, new_revno)
470
 
        return self.rev_id
471
 
 
472
 
    def _update_branches(self, old_revno, old_revid, new_revno):
473
 
        """Update the master and local branch to the new revision.
474
 
 
475
 
        This will try to make sure that the master branch is updated
476
 
        before the local branch.
477
 
 
478
 
        :param old_revno: Revision number of master branch before the
479
 
            commit
480
 
        :param old_revid: Tip of master branch before the commit
481
 
        :param new_revno: Revision number of the new commit
482
 
        """
483
 
        if not self.builder.updates_branch:
 
328
                self.pb_stage_total += 1
 
329
            self.pb.show_pct = False
 
330
            self.pb.show_spinner = False
 
331
            self.pb.show_eta = False
 
332
            self.pb.show_count = True
 
333
            self.pb.show_bar = True
 
334
 
 
335
            self._gather_parents()
 
336
            # After a merge, a selected file commit is not supported.
 
337
            # See 'bzr help merge' for an explanation as to why.
 
338
            if len(self.parents) > 1 and self.specific_files is not None:
 
339
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
 
340
            # Excludes are a form of selected file commit.
 
341
            if len(self.parents) > 1 and self.exclude:
 
342
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
 
343
 
 
344
            # Collect the changes
 
345
            self._set_progress_stage("Collecting changes", counter=True)
 
346
            self.builder = self.branch.get_commit_builder(self.parents,
 
347
                self.config, timestamp, timezone, committer, revprops, rev_id)
 
348
 
 
349
            try:
 
350
                self.builder.will_record_deletes()
 
351
                # find the location being committed to
 
352
                if self.bound_branch:
 
353
                    master_location = self.master_branch.base
 
354
                else:
 
355
                    master_location = self.branch.base
 
356
 
 
357
                # report the start of the commit
 
358
                self.reporter.started(new_revno, self.rev_id, master_location)
 
359
 
 
360
                self._update_builder_with_changes()
 
361
                self._check_pointless()
 
362
 
 
363
                # TODO: Now the new inventory is known, check for conflicts.
 
364
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
 
365
                # weave lines, because nothing should be recorded until it is known
 
366
                # that commit will succeed.
 
367
                self._set_progress_stage("Saving data locally")
 
368
                self.builder.finish_inventory()
 
369
 
 
370
                # Prompt the user for a commit message if none provided
 
371
                message = message_callback(self)
 
372
                self.message = message
 
373
 
 
374
                # Add revision data to the local branch
 
375
                self.rev_id = self.builder.commit(self.message)
 
376
 
 
377
            except Exception, e:
 
378
                mutter("aborting commit write group because of exception:")
 
379
                trace.log_exception_quietly()
 
380
                note("aborting commit write group: %r" % (e,))
 
381
                self.builder.abort()
 
382
                raise
 
383
 
484
384
            self._process_pre_hooks(old_revno, new_revno)
485
385
 
486
386
            # Upload revision data to the master.
489
389
                self._set_progress_stage("Uploading data to master branch")
490
390
                # 'commit' to the master first so a timeout here causes the
491
391
                # local branch to be out of date
492
 
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
493
 
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
494
 
                if self._lossy:
495
 
                    self.branch.fetch(self.master_branch, self.rev_id)
 
392
                self.master_branch.import_last_revision_info(
 
393
                    self.branch.repository, new_revno, self.rev_id)
496
394
 
497
395
            # and now do the commit locally.
498
396
            self.branch.set_last_revision_info(new_revno, self.rev_id)
499
 
        else:
500
 
            try:
501
 
                self._process_pre_hooks(old_revno, new_revno)
502
 
            except BaseException:
503
 
                # The commit builder will already have updated the branch,
504
 
                # revert it.
505
 
                self.branch.set_last_revision_info(old_revno, old_revid)
506
 
                raise
507
397
 
508
 
        # Merge local tags to remote
509
 
        if self.bound_branch:
510
 
            self._set_progress_stage("Merging tags to master branch")
511
 
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
512
 
                self.master_branch.tags)
513
 
            if tag_conflicts:
514
 
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
515
 
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
516
 
                    "\n".join(warning_lines))))
 
398
            # Make the working tree be up to date with the branch. This
 
399
            # includes automatic changes scheduled to be made to the tree, such
 
400
            # as updating its basis and unversioning paths that were missing.
 
401
            self.work_tree.unversion(self.deleted_ids)
 
402
            self._set_progress_stage("Updating the working tree")
 
403
            self.work_tree.update_basis_by_delta(self.rev_id,
 
404
                 self.builder.get_basis_delta())
 
405
            self.reporter.completed(new_revno, self.rev_id)
 
406
            self._process_post_hooks(old_revno, new_revno)
 
407
        finally:
 
408
            self._cleanup()
 
409
        return self.rev_id
517
410
 
518
411
    def _select_reporter(self):
519
412
        """Select the CommitReporter to use."""
527
420
        # A merge with no effect on files
528
421
        if len(self.parents) > 1:
529
422
            return
 
423
        # TODO: we could simplify this by using self.builder.basis_delta.
 
424
 
 
425
        # The initial commit adds a root directory, but this in itself is not
 
426
        # a worthwhile commit.
 
427
        if (self.basis_revid == revision.NULL_REVISION and
 
428
            ((self.builder.new_inventory is not None and
 
429
             len(self.builder.new_inventory) == 1) or
 
430
            len(self.builder._basis_delta) == 1)):
 
431
            raise PointlessCommit()
530
432
        if self.builder.any_changes():
531
433
            return
532
434
        raise PointlessCommit()
533
435
 
534
 
    def _check_bound_branch(self, operation, possible_master_transports=None):
 
436
    def _check_bound_branch(self, possible_master_transports=None):
535
437
        """Check to see if the local branch is bound.
536
438
 
537
439
        If it is bound, then most of the commit will actually be
553
455
        # If the master branch is bound, we must fail
554
456
        master_bound_location = self.master_branch.get_bound_location()
555
457
        if master_bound_location:
556
 
            raise errors.CommitToDoubleBoundBranch(
557
 
                self.branch, self.master_branch, master_bound_location)
 
458
            raise errors.CommitToDoubleBoundBranch(self.branch,
 
459
                    self.master_branch, master_bound_location)
558
460
 
559
461
        # TODO: jam 20051230 We could automatically push local
560
462
        #       commits to the remote branch if they would fit.
562
464
        #       to local.
563
465
 
564
466
        # Make sure the local branch is identical to the master
565
 
        master_revid = self.master_branch.last_revision()
566
 
        local_revid = self.branch.last_revision()
567
 
        if local_revid != master_revid:
 
467
        master_info = self.master_branch.last_revision_info()
 
468
        local_info = self.branch.last_revision_info()
 
469
        if local_info != master_info:
568
470
            raise errors.BoundBranchOutOfDate(self.branch,
569
 
                                              self.master_branch)
 
471
                    self.master_branch)
570
472
 
571
473
        # Now things are ready to change the master branch
572
474
        # so grab the lock
573
475
        self.bound_branch = self.branch
574
476
        self.master_branch.lock_write()
575
 
        operation.add_cleanup(self.master_branch.unlock)
 
477
        self.master_locked = True
576
478
 
577
479
    def _check_out_of_date_tree(self):
578
480
        """Check that the working tree is up to date.
579
481
 
580
 
        :return: old_revision_number, old_revision_id, new_revision_number
581
 
            tuple
 
482
        :return: old_revision_number,new_revision_number tuple
582
483
        """
583
484
        try:
584
485
            first_tree_parent = self.work_tree.get_parent_ids()[0]
587
488
            # this is so that we still consider the master branch
588
489
            # - in a checkout scenario the tree may have no
589
490
            # parents but the branch may do.
590
 
            first_tree_parent = breezy.revision.NULL_REVISION
591
 
        try:
592
 
            old_revno, master_last = self.master_branch.last_revision_info()
593
 
        except errors.UnsupportedOperation:
594
 
            master_last = self.master_branch.last_revision()
595
 
            old_revno = self.branch.revision_id_to_revno(master_last)
 
491
            first_tree_parent = bzrlib.revision.NULL_REVISION
 
492
        old_revno, master_last = self.master_branch.last_revision_info()
596
493
        if master_last != first_tree_parent:
597
 
            if master_last != breezy.revision.NULL_REVISION:
 
494
            if master_last != bzrlib.revision.NULL_REVISION:
598
495
                raise errors.OutOfDateTree(self.work_tree)
599
496
        if self.branch.repository.has_revision(first_tree_parent):
600
497
            new_revno = old_revno + 1
601
498
        else:
602
499
            # ghost parents never appear in revision history.
603
500
            new_revno = 1
604
 
        return old_revno, master_last, new_revno
 
501
        return old_revno,new_revno
605
502
 
606
503
    def _process_pre_hooks(self, old_revno, new_revno):
607
504
        """Process any registered pre commit hooks."""
613
510
        # Process the post commit hooks, if any
614
511
        self._set_progress_stage("Running post_commit hooks")
615
512
        # old style commit hooks - should be deprecated ? (obsoleted in
616
 
        # 0.15^H^H^H^H 2.5.0)
617
 
        post_commit = self.config_stack.get('post_commit')
618
 
        if post_commit is not None:
619
 
            hooks = post_commit.split(' ')
 
513
        # 0.15)
 
514
        if self.config.post_commit() is not None:
 
515
            hooks = self.config.post_commit().split(' ')
620
516
            # this would be nicer with twisted.python.reflect.namedAny
621
517
            for hook in hooks:
622
518
                result = eval(hook + '(branch, rev_id)',
623
 
                              {'branch': self.branch,
624
 
                               'breezy': breezy,
625
 
                               'rev_id': self.rev_id})
 
519
                              {'branch':self.branch,
 
520
                               'bzrlib':bzrlib,
 
521
                               'rev_id':self.rev_id})
626
522
        # process new style post commit hooks
627
523
        self._process_hooks("post_commit", old_revno, new_revno)
628
524
 
643
539
        if self.parents:
644
540
            old_revid = self.parents[0]
645
541
        else:
646
 
            old_revid = breezy.revision.NULL_REVISION
 
542
            old_revid = bzrlib.revision.NULL_REVISION
647
543
 
648
544
        if hook_name == "pre_commit":
649
545
            future_tree = self.builder.revision_tree()
650
546
            tree_delta = future_tree.changes_from(self.basis_tree,
651
 
                                                  include_root=True)
 
547
                                             include_root=True)
652
548
 
653
549
        for hook in Branch.hooks[hook_name]:
654
550
            # show the running hook in the progress bar. As hooks may
669
565
                     old_revno, old_revid, new_revno, self.rev_id,
670
566
                     tree_delta, future_tree)
671
567
 
 
568
    def _cleanup(self):
 
569
        """Cleanup any open locks, progress bars etc."""
 
570
        cleanups = [self._cleanup_bound_branch,
 
571
                    self.basis_tree.unlock,
 
572
                    self.work_tree.unlock,
 
573
                    self.pb.finished]
 
574
        found_exception = None
 
575
        for cleanup in cleanups:
 
576
            try:
 
577
                cleanup()
 
578
            # we want every cleanup to run no matter what.
 
579
            # so we have a catchall here, but we will raise the
 
580
            # last encountered exception up the stack: and
 
581
            # typically this will be useful enough.
 
582
            except Exception, e:
 
583
                found_exception = e
 
584
        if found_exception is not None:
 
585
            # don't do a plan raise, because the last exception may have been
 
586
            # trashed, e is our sure-to-work exception even though it loses the
 
587
            # full traceback. XXX: RBC 20060421 perhaps we could check the
 
588
            # exc_info and if its the same one do a plain raise otherwise
 
589
            # 'raise e' as we do now.
 
590
            raise e
 
591
 
 
592
    def _cleanup_bound_branch(self):
 
593
        """Executed at the end of a try/finally to cleanup a bound branch.
 
594
 
 
595
        If the branch wasn't bound, this is a no-op.
 
596
        If it was, it resents self.branch to the local branch, instead
 
597
        of being the master.
 
598
        """
 
599
        if not self.bound_branch:
 
600
            return
 
601
        if self.master_locked:
 
602
            self.master_branch.unlock()
 
603
 
 
604
    def _gather_parents(self):
 
605
        """Record the parents of a merge for merge detection."""
 
606
        # TODO: Make sure that this list doesn't contain duplicate
 
607
        # entries and the order is preserved when doing this.
 
608
        if self.use_record_iter_changes:
 
609
            return
 
610
        self.basis_inv = self.basis_tree.inventory
 
611
        self.parent_invs = [self.basis_inv]
 
612
        for revision in self.parents[1:]:
 
613
            if self.branch.repository.has_revision(revision):
 
614
                mutter('commit parent revision {%s}', revision)
 
615
                inventory = self.branch.repository.get_inventory(revision)
 
616
                self.parent_invs.append(inventory)
 
617
            else:
 
618
                mutter('commit parent ghost revision {%s}', revision)
 
619
 
672
620
    def _update_builder_with_changes(self):
673
621
        """Update the commit builder with the data about what has changed.
674
622
        """
 
623
        exclude = self.exclude
675
624
        specific_files = self.specific_files
676
 
        mutter("Selecting files for commit with filter %r", specific_files)
 
625
        mutter("Selecting files for commit with filter %s", specific_files)
677
626
 
678
627
        self._check_strict()
679
 
        iter_changes = self.work_tree.iter_changes(
680
 
            self.basis_tree, specific_files=specific_files)
681
 
        if self.exclude:
682
 
            iter_changes = filter_excluded(iter_changes, self.exclude)
683
 
        iter_changes = self._filter_iter_changes(iter_changes)
684
 
        for path, fs_hash in self.builder.record_iter_changes(
 
628
        if self.use_record_iter_changes:
 
629
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
 
630
                specific_files=specific_files)
 
631
            iter_changes = self._filter_iter_changes(iter_changes)
 
632
            for file_id, path, fs_hash in self.builder.record_iter_changes(
685
633
                self.work_tree, self.basis_revid, iter_changes):
686
 
            self.work_tree._observed_sha1(path, fs_hash)
 
634
                self.work_tree._observed_sha1(file_id, path, fs_hash)
 
635
        else:
 
636
            # Build the new inventory
 
637
            self._populate_from_inventory()
 
638
            self._record_unselected()
 
639
            self._report_and_accumulate_deletes()
687
640
 
688
641
    def _filter_iter_changes(self, iter_changes):
689
642
        """Process iter_changes.
690
643
 
691
 
        This method reports on the changes in iter_changes to the user, and
 
644
        This method reports on the changes in iter_changes to the user, and 
692
645
        converts 'missing' entries in the iter_changes iterator to 'deleted'
693
646
        entries. 'missing' entries have their
694
647
 
697
650
        """
698
651
        reporter = self.reporter
699
652
        report_changes = reporter.is_verbose()
700
 
        deleted_paths = []
 
653
        deleted_ids = []
701
654
        for change in iter_changes:
702
655
            if report_changes:
703
656
                old_path = change[1][0]
709
662
                # 'missing' path
710
663
                if report_changes:
711
664
                    reporter.missing(new_path)
712
 
                deleted_paths.append(change[1][1])
 
665
                deleted_ids.append(change[0])
713
666
                # Reset the new path (None) and new versioned flag (False)
714
667
                change = (change[0], (change[1][0], None), change[2],
715
 
                          (change[3][0], False)) + change[4:]
716
 
                new_path = change[1][1]
717
 
                versioned = False
 
668
                    (change[3][0], False)) + change[4:]
718
669
            elif kind == 'tree-reference':
719
670
                if self.recursive == 'down':
720
 
                    self._commit_nested_tree(change[1][1])
 
671
                    self._commit_nested_tree(change[0], change[1][1])
721
672
            if change[3][0] or change[3][1]:
722
673
                yield change
723
674
                if report_changes:
724
675
                    if new_path is None:
725
676
                        reporter.deleted(old_path)
726
677
                    elif old_path is None:
727
 
                        reporter.snapshot_change(gettext('added'), new_path)
 
678
                        reporter.snapshot_change('added', new_path)
728
679
                    elif old_path != new_path:
729
 
                        reporter.renamed(gettext('renamed'),
730
 
                                         old_path, new_path)
 
680
                        reporter.renamed('renamed', old_path, new_path)
731
681
                    else:
732
 
                        if (new_path
733
 
                                or self.work_tree.branch.repository._format.rich_root_data):
 
682
                        if (new_path or 
 
683
                            self.work_tree.branch.repository._format.rich_root_data):
734
684
                            # Don't report on changes to '' in non rich root
735
685
                            # repositories.
736
 
                            reporter.snapshot_change(
737
 
                                gettext('modified'), new_path)
 
686
                            reporter.snapshot_change('modified', new_path)
738
687
            self._next_progress_entry()
739
 
        # Unversion files that were found to be deleted
740
 
        self.deleted_paths = deleted_paths
 
688
        # Unversion IDs that were found to be deleted
 
689
        self.deleted_ids = deleted_ids
 
690
 
 
691
    def _record_unselected(self):
 
692
        # If specific files are selected, then all un-selected files must be
 
693
        # recorded in their previous state. For more details, see
 
694
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
 
695
        if self.specific_files or self.exclude:
 
696
            specific_files = self.specific_files or []
 
697
            for path, old_ie in self.basis_inv.iter_entries():
 
698
                if old_ie.file_id in self.builder.new_inventory:
 
699
                    # already added - skip.
 
700
                    continue
 
701
                if (is_inside_any(specific_files, path)
 
702
                    and not is_inside_any(self.exclude, path)):
 
703
                    # was inside the selected path, and not excluded - if not
 
704
                    # present it has been deleted so skip.
 
705
                    continue
 
706
                # From here down it was either not selected, or was excluded:
 
707
                # We preserve the entry unaltered.
 
708
                ie = old_ie.copy()
 
709
                # Note: specific file commits after a merge are currently
 
710
                # prohibited. This test is for sanity/safety in case it's
 
711
                # required after that changes.
 
712
                if len(self.parents) > 1:
 
713
                    ie.revision = None
 
714
                self.builder.record_entry_contents(ie, self.parent_invs, path,
 
715
                    self.basis_tree, None)
 
716
 
 
717
    def _report_and_accumulate_deletes(self):
 
718
        if (isinstance(self.basis_inv, Inventory)
 
719
            and isinstance(self.builder.new_inventory, Inventory)):
 
720
            # the older Inventory classes provide a _byid dict, and building a
 
721
            # set from the keys of this dict is substantially faster than even
 
722
            # getting a set of ids from the inventory
 
723
            #
 
724
            # <lifeless> set(dict) is roughly the same speed as
 
725
            # set(iter(dict)) and both are significantly slower than
 
726
            # set(dict.keys())
 
727
            deleted_ids = set(self.basis_inv._byid.keys()) - \
 
728
               set(self.builder.new_inventory._byid.keys())
 
729
        else:
 
730
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
 
731
        if deleted_ids:
 
732
            self.any_entries_deleted = True
 
733
            deleted = [(self.basis_tree.id2path(file_id), file_id)
 
734
                for file_id in deleted_ids]
 
735
            deleted.sort()
 
736
            # XXX: this is not quite directory-order sorting
 
737
            for path, file_id in deleted:
 
738
                self.builder.record_delete(path, file_id)
 
739
                self.reporter.deleted(path)
741
740
 
742
741
    def _check_strict(self):
743
742
        # XXX: when we use iter_changes this would likely be faster if
748
747
            for unknown in self.work_tree.unknowns():
749
748
                raise StrictCommitFailed()
750
749
 
751
 
    def _commit_nested_tree(self, path):
 
750
    def _populate_from_inventory(self):
 
751
        """Populate the CommitBuilder by walking the working tree inventory."""
 
752
        # Build the revision inventory.
 
753
        #
 
754
        # This starts by creating a new empty inventory. Depending on
 
755
        # which files are selected for commit, and what is present in the
 
756
        # current tree, the new inventory is populated. inventory entries
 
757
        # which are candidates for modification have their revision set to
 
758
        # None; inventory entries that are carried over untouched have their
 
759
        # revision set to their prior value.
 
760
        #
 
761
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
 
762
        # results to create a new inventory at the same time, which results
 
763
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
 
764
        # ADHB 11-07-2006
 
765
 
 
766
        specific_files = self.specific_files
 
767
        exclude = self.exclude
 
768
        report_changes = self.reporter.is_verbose()
 
769
        deleted_ids = []
 
770
        # A tree of paths that have been deleted. E.g. if foo/bar has been
 
771
        # deleted, then we have {'foo':{'bar':{}}}
 
772
        deleted_paths = {}
 
773
        # XXX: Note that entries may have the wrong kind because the entry does
 
774
        # not reflect the status on disk.
 
775
        work_inv = self.work_tree.inventory
 
776
        # NB: entries will include entries within the excluded ids/paths
 
777
        # because iter_entries_by_dir has no 'exclude' facility today.
 
778
        entries = work_inv.iter_entries_by_dir(
 
779
            specific_file_ids=self.specific_file_ids, yield_parents=True)
 
780
        for path, existing_ie in entries:
 
781
            file_id = existing_ie.file_id
 
782
            name = existing_ie.name
 
783
            parent_id = existing_ie.parent_id
 
784
            kind = existing_ie.kind
 
785
            # Skip files that have been deleted from the working tree.
 
786
            # The deleted path ids are also recorded so they can be explicitly
 
787
            # unversioned later.
 
788
            if deleted_paths:
 
789
                path_segments = splitpath(path)
 
790
                deleted_dict = deleted_paths
 
791
                for segment in path_segments:
 
792
                    deleted_dict = deleted_dict.get(segment, None)
 
793
                    if not deleted_dict:
 
794
                        # We either took a path not present in the dict
 
795
                        # (deleted_dict was None), or we've reached an empty
 
796
                        # child dir in the dict, so are now a sub-path.
 
797
                        break
 
798
                else:
 
799
                    deleted_dict = None
 
800
                if deleted_dict is not None:
 
801
                    # the path has a deleted parent, do not add it.
 
802
                    continue
 
803
            if exclude and is_inside_any(exclude, path):
 
804
                # Skip excluded paths. Excluded paths are processed by
 
805
                # _update_builder_with_changes.
 
806
                continue
 
807
            content_summary = self.work_tree.path_content_summary(path)
 
808
            kind = content_summary[0]
 
809
            # Note that when a filter of specific files is given, we must only
 
810
            # skip/record deleted files matching that filter.
 
811
            if not specific_files or is_inside_any(specific_files, path):
 
812
                if kind == 'missing':
 
813
                    if not deleted_paths:
 
814
                        # path won't have been split yet.
 
815
                        path_segments = splitpath(path)
 
816
                    deleted_dict = deleted_paths
 
817
                    for segment in path_segments:
 
818
                        deleted_dict = deleted_dict.setdefault(segment, {})
 
819
                    self.reporter.missing(path)
 
820
                    self._next_progress_entry()
 
821
                    deleted_ids.append(file_id)
 
822
                    continue
 
823
            # TODO: have the builder do the nested commit just-in-time IF and
 
824
            # only if needed.
 
825
            if kind == 'tree-reference':
 
826
                # enforce repository nested tree policy.
 
827
                if (not self.work_tree.supports_tree_reference() or
 
828
                    # repository does not support it either.
 
829
                    not self.branch.repository._format.supports_tree_reference):
 
830
                    kind = 'directory'
 
831
                    content_summary = (kind, None, None, None)
 
832
                elif self.recursive == 'down':
 
833
                    nested_revision_id = self._commit_nested_tree(
 
834
                        file_id, path)
 
835
                    content_summary = (kind, None, None, nested_revision_id)
 
836
                else:
 
837
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
 
838
                    content_summary = (kind, None, None, nested_revision_id)
 
839
 
 
840
            # Record an entry for this item
 
841
            # Note: I don't particularly want to have the existing_ie
 
842
            # parameter but the test suite currently (28-Jun-07) breaks
 
843
            # without it thanks to a unicode normalisation issue. :-(
 
844
            definitely_changed = kind != existing_ie.kind
 
845
            self._record_entry(path, file_id, specific_files, kind, name,
 
846
                parent_id, definitely_changed, existing_ie, report_changes,
 
847
                content_summary)
 
848
 
 
849
        # Unversion IDs that were found to be deleted
 
850
        self.deleted_ids = deleted_ids
 
851
 
 
852
    def _commit_nested_tree(self, file_id, path):
752
853
        "Commit a nested tree."
753
 
        sub_tree = self.work_tree.get_nested_tree(path)
 
854
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
754
855
        # FIXME: be more comprehensive here:
755
856
        # this works when both trees are in --trees repository,
756
857
        # but when both are bound to a different repository,
758
859
        # finally implement the explicit-caches approach design
759
860
        # a while back - RBC 20070306.
760
861
        if sub_tree.branch.repository.has_same_location(
761
 
                self.work_tree.branch.repository):
 
862
            self.work_tree.branch.repository):
762
863
            sub_tree.branch.repository = \
763
864
                self.work_tree.branch.repository
764
865
        try:
765
866
            return sub_tree.commit(message=None, revprops=self.revprops,
766
 
                                   recursive=self.recursive,
767
 
                                   message_callback=self.message_callback,
768
 
                                   timestamp=self.timestamp,
769
 
                                   timezone=self.timezone,
770
 
                                   committer=self.committer,
771
 
                                   allow_pointless=self.allow_pointless,
772
 
                                   strict=self.strict, verbose=self.verbose,
773
 
                                   local=self.local, reporter=self.reporter)
774
 
        except PointlessCommit:
775
 
            return self.work_tree.get_reference_revision(path)
 
867
                recursive=self.recursive,
 
868
                message_callback=self.message_callback,
 
869
                timestamp=self.timestamp, timezone=self.timezone,
 
870
                committer=self.committer,
 
871
                allow_pointless=self.allow_pointless,
 
872
                strict=self.strict, verbose=self.verbose,
 
873
                local=self.local, reporter=self.reporter)
 
874
        except errors.PointlessCommit:
 
875
            return self.work_tree.get_reference_revision(file_id)
 
876
 
 
877
    def _record_entry(self, path, file_id, specific_files, kind, name,
 
878
        parent_id, definitely_changed, existing_ie, report_changes,
 
879
        content_summary):
 
880
        "Record the new inventory entry for a path if any."
 
881
        # mutter('check %s {%s}', path, file_id)
 
882
        # mutter('%s selected for commit', path)
 
883
        if definitely_changed or existing_ie is None:
 
884
            ie = make_entry(kind, name, parent_id, file_id)
 
885
        else:
 
886
            ie = existing_ie.copy()
 
887
            ie.revision = None
 
888
        # For carried over entries we don't care about the fs hash - the repo
 
889
        # isn't generating a sha, so we're not saving computation time.
 
890
        _, _, fs_hash = self.builder.record_entry_contents(
 
891
            ie, self.parent_invs, path, self.work_tree, content_summary)
 
892
        if report_changes:
 
893
            self._report_change(ie, path)
 
894
        if fs_hash:
 
895
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
 
896
        return ie
 
897
 
 
898
    def _report_change(self, ie, path):
 
899
        """Report a change to the user.
 
900
 
 
901
        The change that has occurred is described relative to the basis
 
902
        inventory.
 
903
        """
 
904
        if (self.basis_inv.has_id(ie.file_id)):
 
905
            basis_ie = self.basis_inv[ie.file_id]
 
906
        else:
 
907
            basis_ie = None
 
908
        change = ie.describe_change(basis_ie, ie)
 
909
        if change in (InventoryEntry.RENAMED,
 
910
            InventoryEntry.MODIFIED_AND_RENAMED):
 
911
            old_path = self.basis_inv.id2path(ie.file_id)
 
912
            self.reporter.renamed(change, old_path, path)
 
913
            self._next_progress_entry()
 
914
        else:
 
915
            if change == 'unchanged':
 
916
                return
 
917
            self.reporter.snapshot_change(change, path)
 
918
            self._next_progress_entry()
776
919
 
777
920
    def _set_progress_stage(self, name, counter=False):
778
921
        """Set the progress stage and emit an update to the progress bar."""
791
934
 
792
935
    def _emit_progress(self):
793
936
        if self.pb_entries_count is not None:
794
 
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
795
 
                                                       self.pb_entries_count)
 
937
            text = "%s [%d] - Stage" % (self.pb_stage_name,
 
938
                self.pb_entries_count)
796
939
        else:
797
 
            text = gettext("%s - Stage") % (self.pb_stage_name, )
 
940
            text = "%s - Stage" % (self.pb_stage_name, )
798
941
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
 
942
 
 
943
    def _set_specific_file_ids(self):
 
944
        """populate self.specific_file_ids if we will use it."""
 
945
        if not self.use_record_iter_changes:
 
946
            # If provided, ensure the specified files are versioned
 
947
            if self.specific_files is not None:
 
948
                # Note: This routine is being called because it raises
 
949
                # PathNotVersionedError as a side effect of finding the IDs. We
 
950
                # later use the ids we found as input to the working tree
 
951
                # inventory iterator, so we only consider those ids rather than
 
952
                # examining the whole tree again.
 
953
                # XXX: Dont we have filter_unversioned to do this more
 
954
                # cheaply?
 
955
                self.specific_file_ids = tree.find_ids_across_trees(
 
956
                    self.specific_files, [self.basis_tree, self.work_tree])
 
957
            else:
 
958
                self.specific_file_ids = None