/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/add.py

  • Committer: John Arbash Meinel
  • Date: 2009-10-14 15:53:34 UTC
  • mto: This revision was merged to the branch mainline in revision 4746.
  • Revision ID: john@arbash-meinel.com-20091014155334-dxdm0ns610scz5c9
Add a test case for the bug w/ NotImplemented.

Basically, bool(NotImplemented) == True, which means that you have to
check for 'result == Py_NotImplemented' before you check PyObject_IsTrue().
Going further, though, I simplified the _is_equal a lot by switching to
using object definitions (rather than PyObject *).
This now handles exceptions and refcounts properly, and the code is cleaner
to boot. (Exceptions will now include these lines in the traceback, etc.)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/add.py
16
16
 
17
17
"""Helper functions for adding files to working trees."""
18
18
 
 
19
import errno
 
20
import os
19
21
import sys
20
22
 
21
23
import bzrlib.bzrdir
 
24
import bzrlib.errors as errors
22
25
import bzrlib.osutils
23
26
from bzrlib.symbol_versioning import *
 
27
from bzrlib.workingtree import WorkingTree
24
28
 
25
29
 
26
30
class AddAction(object):