/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to doc/developers/diff.txt

  • Committer: John Arbash Meinel
  • Date: 2009-10-14 15:53:34 UTC
  • mto: This revision was merged to the branch mainline in revision 4746.
  • Revision ID: john@arbash-meinel.com-20091014155334-dxdm0ns610scz5c9
Add a test case for the bug w/ NotImplemented.

Basically, bool(NotImplemented) == True, which means that you have to
check for 'result == Py_NotImplemented' before you check PyObject_IsTrue().
Going further, though, I simplified the _is_equal a lot by switching to
using object definitions (rather than PyObject *).
This now handles exceptions and refcounts properly, and the code is cleaner
to boot. (Exceptions will now include these lines in the traceback, etc.)

Show diffs side-by-side

added added

removed removed

Lines of Context:
doc/developers/diff.txt
61
61
that only certain files should be compared.
62
62
 
63
63
Performance can be further improved by caching comparisons to avoid repeating
64
 
them.  Caching could potentially be performed by ``diff`` and perhaps by
 
64
them.  Caching could potentially be performed by ``diff`` and perhaps by 
65
65
``merge``.  Merge is aware of the relationship of a text merge's result to
66
66
the THIS value, and the THIS value is generally the basis value.  So the
67
67
comparison is latent, but present.  The only issue is extracting it.