/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/features.py

  • Committer: John Arbash Meinel
  • Date: 2009-11-06 18:05:03 UTC
  • mto: This revision was merged to the branch mainline in revision 4814.
  • Revision ID: john@arbash-meinel.com-20091106180503-q3hcg1nxmut5b2cb
Stop holding the gil while extracting data.

Previous experience has shown that we don't really spend a lot
of time here, but there isn't any reason to hold the lock while
we do it anyway.

Performance testing has shown that for bzr operations 'with nogil'
doesn't really do much, which was generally expected. Any variation
observed is within the noise margins.

This is mostly about 'the right thing to do', and potential
future work where we may actually use threads.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/features.py
1
 
# Copyright (C) 2009, 2010 Canonical Ltd
 
1
# Copyright (C) 2009 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
import os
18
 
import stat
19
 
 
20
 
from bzrlib import tests
21
 
from bzrlib.symbol_versioning import deprecated_in
22
 
 
23
 
 
24
 
apport = tests.ModuleAvailableFeature('apport')
25
 
paramiko = tests.ModuleAvailableFeature('paramiko')
26
 
pycurl = tests.ModuleAvailableFeature('pycurl')
27
 
subunit = tests.ModuleAvailableFeature('subunit')
28
 
 
29
 
 
30
 
class _PosixPermissionsFeature(tests.Feature):
31
 
 
 
17
 
 
18
from bzrlib.tests import Feature
 
19
 
 
20
 
 
21
class _ApportFeature(Feature):
 
22
    
32
23
    def _probe(self):
33
 
        def has_perms():
34
 
            # create temporary file and check if specified perms are maintained.
35
 
            import tempfile
36
 
 
37
 
            write_perms = stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR
38
 
            f = tempfile.mkstemp(prefix='bzr_perms_chk_')
39
 
            fd, name = f
40
 
            os.close(fd)
41
 
            os.chmod(name, write_perms)
42
 
 
43
 
            read_perms = os.stat(name).st_mode & 0777
44
 
            os.unlink(name)
45
 
            return (write_perms == read_perms)
46
 
 
47
 
        return (os.name == 'posix') and has_perms()
 
24
        try:
 
25
            import apport
 
26
        except ImportError, e:
 
27
            return False
 
28
        else:
 
29
            return True
48
30
 
49
31
    def feature_name(self):
50
 
        return 'POSIX permissions support'
51
 
 
52
 
 
53
 
posix_permissions_feature = _PosixPermissionsFeature()
54
 
 
55
 
 
56
 
class _ChownFeature(tests.Feature):
57
 
    """os.chown is supported"""
58
 
 
59
 
    def _probe(self):
60
 
        return os.name == 'posix' and hasattr(os, 'chown')
61
 
 
62
 
chown_feature = _ChownFeature()
63
 
 
 
32
        return 'apport'
 
33
 
 
34
 
 
35
ApportFeature = _ApportFeature()