/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/repofmt/groupcompress_repo.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/repofmt/groupcompress_repo.py
29
29
    knit,
30
30
    osutils,
31
31
    pack,
 
32
    remote,
32
33
    revision as _mod_revision,
33
34
    trace,
34
35
    ui,
881
882
            if basis_tree is not None:
882
883
                basis_tree.unlock()
883
884
 
884
 
    def _deserialise_inventory(self, revision_id, bytes):
 
885
    def deserialise_inventory(self, revision_id, bytes):
885
886
        return inventory.CHKInventory.deserialise(self.chk_bytes, bytes,
886
887
            (revision_id,))
887
888
 
903
904
    def _iter_inventory_xmls(self, revision_ids, ordering):
904
905
        # Without a native 'xml' inventory, this method doesn't make sense.
905
906
        # However older working trees, and older bundles want it - so we supply
906
 
        # it allowing _get_inventory_xml to work. Bundles currently use the
 
907
        # it allowing get_inventory_xml to work. Bundles currently use the
907
908
        # serializer directly; this also isn't ideal, but there isn't an xml
908
909
        # iteration interface offered at all for repositories. We could make
909
910
        # _iter_inventory_xmls be part of the contract, even if kept private.