/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/features.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/features.py
1
 
# Copyright (C) 2009, 2010 Canonical Ltd
 
1
# Copyright (C) 2009 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
import os
18
 
import stat
19
17
 
20
18
from bzrlib import tests
21
19
from bzrlib.symbol_versioning import deprecated_in
22
20
 
23
21
 
24
22
apport = tests.ModuleAvailableFeature('apport')
 
23
ApportFeature = tests._CompatabilityThunkFeature('bzrlib.tests.features',
 
24
    'ApportFeature', 'bzrlib.tests.features.apport', deprecated_in((2,1,0)))
25
25
paramiko = tests.ModuleAvailableFeature('paramiko')
26
26
pycurl = tests.ModuleAvailableFeature('pycurl')
27
27
subunit = tests.ModuleAvailableFeature('subunit')
28
 
 
29
 
 
30
 
class _PosixPermissionsFeature(tests.Feature):
31
 
 
32
 
    def _probe(self):
33
 
        def has_perms():
34
 
            # create temporary file and check if specified perms are maintained.
35
 
            import tempfile
36
 
 
37
 
            write_perms = stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR
38
 
            f = tempfile.mkstemp(prefix='bzr_perms_chk_')
39
 
            fd, name = f
40
 
            os.close(fd)
41
 
            os.chmod(name, write_perms)
42
 
 
43
 
            read_perms = os.stat(name).st_mode & 0777
44
 
            os.unlink(name)
45
 
            return (write_perms == read_perms)
46
 
 
47
 
        return (os.name == 'posix') and has_perms()
48
 
 
49
 
    def feature_name(self):
50
 
        return 'POSIX permissions support'
51
 
 
52
 
 
53
 
posix_permissions_feature = _PosixPermissionsFeature()
54
 
 
55
 
 
56
 
class _ChownFeature(tests.Feature):
57
 
    """os.chown is supported"""
58
 
 
59
 
    def _probe(self):
60
 
        return os.name == 'posix' and hasattr(os, 'chown')
61
 
 
62
 
chown_feature = _ChownFeature()
63