/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/transport/brokenrename.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/transport/brokenrename.py
23
23
        errors,
24
24
        urlutils,
25
25
        )
26
 
from bzrlib.transport import decorator
27
 
 
28
 
 
29
 
class BrokenRenameTransportDecorator(decorator.TransportDecorator):
 
26
from bzrlib.transport.decorator import TransportDecorator, DecoratorServer
 
27
 
 
28
 
 
29
class BrokenRenameTransportDecorator(TransportDecorator):
30
30
    """A transport that fails to detect clashing renames"""
31
31
 
32
32
    @classmethod
46
46
            return
47
47
 
48
48
 
 
49
class BrokenRenameServer(DecoratorServer):
 
50
    """Server for the BrokenRenameTransportDecorator for testing with."""
 
51
 
 
52
    def get_decorator_class(self):
 
53
        return BrokenRenameTransportDecorator
 
54
 
 
55
 
49
56
def get_test_permutations():
50
57
    """Return the permutations to be used in testing."""
51
58
    # we don't use this for general testing, only for the tests that