/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_bundle.py

  • Committer: Robert Collins
  • Date: 2010-05-05 00:05:29 UTC
  • mto: This revision was merged to the branch mainline in revision 5206.
  • Revision ID: robertc@robertcollins.net-20100505000529-ltmllyms5watqj5u
Make 'pydoc bzrlib.tests.build_tree_shape' useful.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2013, 2016 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
import bz2
18
 
from io import BytesIO
 
17
from cStringIO import StringIO
19
18
import os
20
 
try:
21
 
    import socketserver
22
 
except ImportError:
23
 
    import SocketServer as socketserver
 
19
import socket
24
20
import sys
 
21
import threading
25
22
 
26
 
from .. import (
 
23
from bzrlib import (
 
24
    bzrdir,
27
25
    diff,
28
26
    errors,
 
27
    inventory,
29
28
    merge,
30
29
    osutils,
 
30
    repository,
31
31
    revision as _mod_revision,
32
32
    tests,
33
33
    treebuilder,
34
34
    )
35
 
from ..bzr import (
36
 
    bzrdir,
37
 
    inventory,
38
 
    )
39
 
from ..bundle import read_mergeable_from_url
40
 
from ..bundle.apply_bundle import install_bundle, merge_bundle
41
 
from ..bundle.bundle_data import BundleTree
42
 
from ..directory_service import directories
43
 
from ..bundle.serializer import write_bundle, read_bundle, v09, v4
44
 
from ..bundle.serializer.v08 import BundleSerializerV08
45
 
from ..bundle.serializer.v09 import BundleSerializerV09
46
 
from ..bundle.serializer.v4 import BundleSerializerV4
47
 
from ..bzr import knitrepo
48
 
from . import (
49
 
    features,
 
35
from bzrlib.bundle import read_mergeable_from_url
 
36
from bzrlib.bundle.apply_bundle import install_bundle, merge_bundle
 
37
from bzrlib.bundle.bundle_data import BundleTree
 
38
from bzrlib.bzrdir import BzrDir
 
39
from bzrlib.directory_service import directories
 
40
from bzrlib.bundle.serializer import write_bundle, read_bundle, v09, v4
 
41
from bzrlib.bundle.serializer.v08 import BundleSerializerV08
 
42
from bzrlib.bundle.serializer.v09 import BundleSerializerV09
 
43
from bzrlib.bundle.serializer.v4 import BundleSerializerV4
 
44
from bzrlib.branch import Branch
 
45
from bzrlib.repofmt import knitrepo
 
46
from bzrlib.tests import (
 
47
    test_read_bundle,
50
48
    test_commit,
51
 
    test_read_bundle,
52
 
    test_server,
53
49
    )
54
 
from ..transform import TreeTransform
 
50
from bzrlib.transform import TreeTransform
55
51
 
56
52
 
57
53
def get_text(vf, key):
58
54
    """Get the fulltext for a given revision id that is present in the vf"""
59
55
    stream = vf.get_record_stream([key], 'unordered', True)
60
 
    record = next(stream)
 
56
    record = stream.next()
61
57
    return record.get_bytes_as('fulltext')
62
58
 
63
59
 
64
60
def get_inventory_text(repo, revision_id):
65
61
    """Get the fulltext for the inventory at revision id"""
66
 
    with repo.lock_read():
 
62
    repo.lock_read()
 
63
    try:
67
64
        return get_text(repo.inventories, (revision_id,))
 
65
    finally:
 
66
        repo.unlock()
68
67
 
69
68
 
70
69
class MockTree(object):
71
 
 
72
70
    def __init__(self):
73
 
        from ..bzr.inventory import InventoryDirectory, ROOT_ID
 
71
        from bzrlib.inventory import InventoryDirectory, ROOT_ID
74
72
        object.__init__(self)
75
73
        self.paths = {ROOT_ID: ""}
76
74
        self.ids = {"": ROOT_ID}
77
75
        self.contents = {}
78
76
        self.root = InventoryDirectory(ROOT_ID, '', None)
79
77
 
80
 
    inventory = property(lambda x: x)
81
 
    root_inventory = property(lambda x: x)
82
 
 
83
 
    def get_root_id(self):
84
 
        return self.root.file_id
85
 
 
86
 
    def all_file_ids(self):
87
 
        return set(self.paths.keys())
88
 
 
89
 
    def all_versioned_paths(self):
90
 
        return set(self.paths.values())
91
 
 
92
 
    def is_executable(self, path):
93
 
        # Not all the files are executable.
94
 
        return False
 
78
    inventory = property(lambda x:x)
 
79
 
 
80
    def __iter__(self):
 
81
        return self.paths.iterkeys()
95
82
 
96
83
    def __getitem__(self, file_id):
97
84
        if file_id == self.root.file_id:
99
86
        else:
100
87
            return self.make_entry(file_id, self.paths[file_id])
101
88
 
102
 
    def get_entry_by_path(self, path):
103
 
        return self[self.path2id(path)]
104
 
 
105
89
    def parent_id(self, file_id):
106
90
        parent_dir = os.path.dirname(self.paths[file_id])
107
91
        if parent_dir == "":
109
93
        return self.ids[parent_dir]
110
94
 
111
95
    def iter_entries(self):
112
 
        for path, file_id in self.ids.items():
 
96
        for path, file_id in self.ids.iteritems():
113
97
            yield path, self[file_id]
114
98
 
115
 
    def kind(self, path):
116
 
        if path in self.contents:
 
99
    def get_file_kind(self, file_id):
 
100
        if file_id in self.contents:
117
101
            kind = 'file'
118
102
        else:
119
103
            kind = 'directory'
120
104
        return kind
121
105
 
122
106
    def make_entry(self, file_id, path):
123
 
        from ..bzr.inventory import (InventoryFile, InventoryDirectory,
124
 
                                     InventoryLink)
125
 
        if not isinstance(file_id, bytes):
126
 
            raise TypeError(file_id)
 
107
        from bzrlib.inventory import (InventoryEntry, InventoryFile
 
108
                                    , InventoryDirectory, InventoryLink)
127
109
        name = os.path.basename(path)
128
 
        kind = self.kind(path)
 
110
        kind = self.get_file_kind(file_id)
129
111
        parent_id = self.parent_id(file_id)
130
 
        text_sha_1, text_size = self.contents_stats(path)
 
112
        text_sha_1, text_size = self.contents_stats(file_id)
131
113
        if kind == 'directory':
132
114
            ie = InventoryDirectory(file_id, name, parent_id)
133
115
        elif kind == 'file':
134
116
            ie = InventoryFile(file_id, name, parent_id)
135
 
            ie.text_sha1 = text_sha_1
136
 
            ie.text_size = text_size
137
117
        elif kind == 'symlink':
138
118
            ie = InventoryLink(file_id, name, parent_id)
139
119
        else:
140
120
            raise errors.BzrError('unknown kind %r' % kind)
 
121
        ie.text_sha1 = text_sha_1
 
122
        ie.text_size = text_size
141
123
        return ie
142
124
 
143
125
    def add_dir(self, file_id, path):
144
 
        if not isinstance(file_id, bytes):
145
 
            raise TypeError(file_id)
146
126
        self.paths[file_id] = path
147
127
        self.ids[path] = file_id
148
128
 
149
129
    def add_file(self, file_id, path, contents):
150
 
        if not isinstance(file_id, bytes):
151
 
            raise TypeError(file_id)
152
130
        self.add_dir(file_id, path)
153
 
        self.contents[path] = contents
 
131
        self.contents[file_id] = contents
154
132
 
155
133
    def path2id(self, path):
156
134
        return self.ids.get(path)
161
139
    def has_id(self, file_id):
162
140
        return self.id2path(file_id) is not None
163
141
 
164
 
    def get_file(self, path):
165
 
        result = BytesIO()
166
 
        try:
167
 
            result.write(self.contents[path])
168
 
        except KeyError:
169
 
            raise errors.NoSuchFile(path)
170
 
        result.seek(0, 0)
 
142
    def get_file(self, file_id):
 
143
        result = StringIO()
 
144
        result.write(self.contents[file_id])
 
145
        result.seek(0,0)
171
146
        return result
172
147
 
173
 
    def get_file_revision(self, path):
174
 
        return self.inventory.get_entry_by_path(path).revision
175
 
 
176
 
    def get_file_size(self, path):
177
 
        return self.inventory.get_entry_by_path(path).text_size
178
 
 
179
 
    def get_file_sha1(self, path, file_id=None):
180
 
        return self.inventory.get_entry_by_path(path).text_sha1
181
 
 
182
 
    def contents_stats(self, path):
183
 
        if path not in self.contents:
 
148
    def contents_stats(self, file_id):
 
149
        if file_id not in self.contents:
184
150
            return None, None
185
 
        text_sha1 = osutils.sha_file(self.get_file(path))
186
 
        return text_sha1, len(self.contents[path])
 
151
        text_sha1 = osutils.sha_file(self.get_file(file_id))
 
152
        return text_sha1, len(self.contents[file_id])
187
153
 
188
154
 
189
155
class BTreeTester(tests.TestCase):
191
157
 
192
158
    def make_tree_1(self):
193
159
        mtree = MockTree()
194
 
        mtree.add_dir(b"a", "grandparent")
195
 
        mtree.add_dir(b"b", "grandparent/parent")
196
 
        mtree.add_file(b"c", "grandparent/parent/file", b"Hello\n")
197
 
        mtree.add_dir(b"d", "grandparent/alt_parent")
198
 
        return BundleTree(mtree, b''), mtree
 
160
        mtree.add_dir("a", "grandparent")
 
161
        mtree.add_dir("b", "grandparent/parent")
 
162
        mtree.add_file("c", "grandparent/parent/file", "Hello\n")
 
163
        mtree.add_dir("d", "grandparent/alt_parent")
 
164
        return BundleTree(mtree, ''), mtree
199
165
 
200
166
    def test_renames(self):
201
167
        """Ensure that file renames have the proper effect on children"""
206
172
        self.assertEqual(btree.old_path("grandparent/parent/file"),
207
173
                         "grandparent/parent/file")
208
174
 
209
 
        self.assertEqual(btree.id2path(b"a"), "grandparent")
210
 
        self.assertEqual(btree.id2path(b"b"), "grandparent/parent")
211
 
        self.assertEqual(btree.id2path(b"c"), "grandparent/parent/file")
212
 
 
213
 
        self.assertEqual(btree.path2id("grandparent"), b"a")
214
 
        self.assertEqual(btree.path2id("grandparent/parent"), b"b")
215
 
        self.assertEqual(btree.path2id("grandparent/parent/file"), b"c")
216
 
 
217
 
        self.assertIs(btree.path2id("grandparent2"), None)
218
 
        self.assertIs(btree.path2id("grandparent2/parent"), None)
219
 
        self.assertIs(btree.path2id("grandparent2/parent/file"), None)
 
175
        self.assertEqual(btree.id2path("a"), "grandparent")
 
176
        self.assertEqual(btree.id2path("b"), "grandparent/parent")
 
177
        self.assertEqual(btree.id2path("c"), "grandparent/parent/file")
 
178
 
 
179
        self.assertEqual(btree.path2id("grandparent"), "a")
 
180
        self.assertEqual(btree.path2id("grandparent/parent"), "b")
 
181
        self.assertEqual(btree.path2id("grandparent/parent/file"), "c")
 
182
 
 
183
        self.assertTrue(btree.path2id("grandparent2") is None)
 
184
        self.assertTrue(btree.path2id("grandparent2/parent") is None)
 
185
        self.assertTrue(btree.path2id("grandparent2/parent/file") is None)
220
186
 
221
187
        btree.note_rename("grandparent", "grandparent2")
222
 
        self.assertIs(btree.old_path("grandparent"), None)
223
 
        self.assertIs(btree.old_path("grandparent/parent"), None)
224
 
        self.assertIs(btree.old_path("grandparent/parent/file"), None)
225
 
 
226
 
        self.assertEqual(btree.id2path(b"a"), "grandparent2")
227
 
        self.assertEqual(btree.id2path(b"b"), "grandparent2/parent")
228
 
        self.assertEqual(btree.id2path(b"c"), "grandparent2/parent/file")
229
 
 
230
 
        self.assertEqual(btree.path2id("grandparent2"), b"a")
231
 
        self.assertEqual(btree.path2id("grandparent2/parent"), b"b")
232
 
        self.assertEqual(btree.path2id("grandparent2/parent/file"), b"c")
 
188
        self.assertTrue(btree.old_path("grandparent") is None)
 
189
        self.assertTrue(btree.old_path("grandparent/parent") is None)
 
190
        self.assertTrue(btree.old_path("grandparent/parent/file") is None)
 
191
 
 
192
        self.assertEqual(btree.id2path("a"), "grandparent2")
 
193
        self.assertEqual(btree.id2path("b"), "grandparent2/parent")
 
194
        self.assertEqual(btree.id2path("c"), "grandparent2/parent/file")
 
195
 
 
196
        self.assertEqual(btree.path2id("grandparent2"), "a")
 
197
        self.assertEqual(btree.path2id("grandparent2/parent"), "b")
 
198
        self.assertEqual(btree.path2id("grandparent2/parent/file"), "c")
233
199
 
234
200
        self.assertTrue(btree.path2id("grandparent") is None)
235
201
        self.assertTrue(btree.path2id("grandparent/parent") is None)
236
202
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
237
203
 
238
204
        btree.note_rename("grandparent/parent", "grandparent2/parent2")
239
 
        self.assertEqual(btree.id2path(b"a"), "grandparent2")
240
 
        self.assertEqual(btree.id2path(b"b"), "grandparent2/parent2")
241
 
        self.assertEqual(btree.id2path(b"c"), "grandparent2/parent2/file")
 
205
        self.assertEqual(btree.id2path("a"), "grandparent2")
 
206
        self.assertEqual(btree.id2path("b"), "grandparent2/parent2")
 
207
        self.assertEqual(btree.id2path("c"), "grandparent2/parent2/file")
242
208
 
243
 
        self.assertEqual(btree.path2id("grandparent2"), b"a")
244
 
        self.assertEqual(btree.path2id("grandparent2/parent2"), b"b")
245
 
        self.assertEqual(btree.path2id("grandparent2/parent2/file"), b"c")
 
209
        self.assertEqual(btree.path2id("grandparent2"), "a")
 
210
        self.assertEqual(btree.path2id("grandparent2/parent2"), "b")
 
211
        self.assertEqual(btree.path2id("grandparent2/parent2/file"), "c")
246
212
 
247
213
        self.assertTrue(btree.path2id("grandparent2/parent") is None)
248
214
        self.assertTrue(btree.path2id("grandparent2/parent/file") is None)
249
215
 
250
216
        btree.note_rename("grandparent/parent/file",
251
217
                          "grandparent2/parent2/file2")
252
 
        self.assertEqual(btree.id2path(b"a"), "grandparent2")
253
 
        self.assertEqual(btree.id2path(b"b"), "grandparent2/parent2")
254
 
        self.assertEqual(btree.id2path(b"c"), "grandparent2/parent2/file2")
 
218
        self.assertEqual(btree.id2path("a"), "grandparent2")
 
219
        self.assertEqual(btree.id2path("b"), "grandparent2/parent2")
 
220
        self.assertEqual(btree.id2path("c"), "grandparent2/parent2/file2")
255
221
 
256
 
        self.assertEqual(btree.path2id("grandparent2"), b"a")
257
 
        self.assertEqual(btree.path2id("grandparent2/parent2"), b"b")
258
 
        self.assertEqual(btree.path2id("grandparent2/parent2/file2"), b"c")
 
222
        self.assertEqual(btree.path2id("grandparent2"), "a")
 
223
        self.assertEqual(btree.path2id("grandparent2/parent2"), "b")
 
224
        self.assertEqual(btree.path2id("grandparent2/parent2/file2"), "c")
259
225
 
260
226
        self.assertTrue(btree.path2id("grandparent2/parent2/file") is None)
261
227
 
264
230
        btree = self.make_tree_1()[0]
265
231
        btree.note_rename("grandparent/parent/file",
266
232
                          "grandparent/alt_parent/file")
267
 
        self.assertEqual(btree.id2path(b"c"), "grandparent/alt_parent/file")
268
 
        self.assertEqual(btree.path2id("grandparent/alt_parent/file"), b"c")
 
233
        self.assertEqual(btree.id2path("c"), "grandparent/alt_parent/file")
 
234
        self.assertEqual(btree.path2id("grandparent/alt_parent/file"), "c")
269
235
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
270
236
 
271
237
    def unified_diff(self, old, new):
272
 
        out = BytesIO()
 
238
        out = StringIO()
273
239
        diff.internal_diff("old", old, "new", new, out)
274
 
        out.seek(0, 0)
 
240
        out.seek(0,0)
275
241
        return out.read()
276
242
 
277
243
    def make_tree_2(self):
278
244
        btree = self.make_tree_1()[0]
279
245
        btree.note_rename("grandparent/parent/file",
280
246
                          "grandparent/alt_parent/file")
281
 
        self.assertTrue(btree.id2path(b"e") is None)
282
 
        self.assertFalse(btree.is_versioned("grandparent/parent/file"))
283
 
        btree.note_id(b"e", "grandparent/parent/file")
 
247
        self.assertTrue(btree.id2path("e") is None)
 
248
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
 
249
        btree.note_id("e", "grandparent/parent/file")
284
250
        return btree
285
251
 
286
252
    def test_adds(self):
287
253
        """File/inventory adds"""
288
254
        btree = self.make_tree_2()
289
 
        add_patch = self.unified_diff([], [b"Extra cheese\n"])
 
255
        add_patch = self.unified_diff([], ["Extra cheese\n"])
290
256
        btree.note_patch("grandparent/parent/file", add_patch)
291
 
        btree.note_id(b'f', 'grandparent/parent/symlink', kind='symlink')
 
257
        btree.note_id('f', 'grandparent/parent/symlink', kind='symlink')
292
258
        btree.note_target('grandparent/parent/symlink', 'venus')
293
259
        self.adds_test(btree)
294
260
 
295
261
    def adds_test(self, btree):
296
 
        self.assertEqual(btree.id2path(b"e"), "grandparent/parent/file")
297
 
        self.assertEqual(btree.path2id("grandparent/parent/file"), b"e")
298
 
        with btree.get_file("grandparent/parent/file") as f:
299
 
            self.assertEqual(f.read(), b"Extra cheese\n")
300
 
        self.assertEqual(
301
 
            btree.get_symlink_target('grandparent/parent/symlink'), 'venus')
 
262
        self.assertEqual(btree.id2path("e"), "grandparent/parent/file")
 
263
        self.assertEqual(btree.path2id("grandparent/parent/file"), "e")
 
264
        self.assertEqual(btree.get_file("e").read(), "Extra cheese\n")
 
265
        self.assertEqual(btree.get_symlink_target('f'), 'venus')
302
266
 
303
267
    def test_adds2(self):
304
268
        """File/inventory adds, with patch-compatibile renames"""
305
269
        btree = self.make_tree_2()
306
270
        btree.contents_by_id = False
307
 
        add_patch = self.unified_diff([b"Hello\n"], [b"Extra cheese\n"])
 
271
        add_patch = self.unified_diff(["Hello\n"], ["Extra cheese\n"])
308
272
        btree.note_patch("grandparent/parent/file", add_patch)
309
 
        btree.note_id(b'f', 'grandparent/parent/symlink', kind='symlink')
 
273
        btree.note_id('f', 'grandparent/parent/symlink', kind='symlink')
310
274
        btree.note_target('grandparent/parent/symlink', 'venus')
311
275
        self.adds_test(btree)
312
276
 
313
277
    def make_tree_3(self):
314
278
        btree, mtree = self.make_tree_1()
315
 
        mtree.add_file(b"e", "grandparent/parent/topping", b"Anchovies\n")
 
279
        mtree.add_file("e", "grandparent/parent/topping", "Anchovies\n")
316
280
        btree.note_rename("grandparent/parent/file",
317
281
                          "grandparent/alt_parent/file")
318
282
        btree.note_rename("grandparent/parent/topping",
320
284
        return btree
321
285
 
322
286
    def get_file_test(self, btree):
323
 
        with btree.get_file(btree.id2path(b"e")) as f:
324
 
            self.assertEqual(f.read(), b"Lemon\n")
325
 
        with btree.get_file(btree.id2path(b"c")) as f:
326
 
            self.assertEqual(f.read(), b"Hello\n")
 
287
        self.assertEqual(btree.get_file("e").read(), "Lemon\n")
 
288
        self.assertEqual(btree.get_file("c").read(), "Hello\n")
327
289
 
328
290
    def test_get_file(self):
329
291
        """Get file contents"""
330
292
        btree = self.make_tree_3()
331
 
        mod_patch = self.unified_diff([b"Anchovies\n"], [b"Lemon\n"])
 
293
        mod_patch = self.unified_diff(["Anchovies\n"], ["Lemon\n"])
332
294
        btree.note_patch("grandparent/alt_parent/stopping", mod_patch)
333
295
        self.get_file_test(btree)
334
296
 
335
297
    def test_get_file2(self):
336
 
        """Get file contents, with patch-compatible renames"""
 
298
        """Get file contents, with patch-compatibile renames"""
337
299
        btree = self.make_tree_3()
338
300
        btree.contents_by_id = False
339
 
        mod_patch = self.unified_diff([], [b"Lemon\n"])
 
301
        mod_patch = self.unified_diff([], ["Lemon\n"])
340
302
        btree.note_patch("grandparent/alt_parent/stopping", mod_patch)
341
 
        mod_patch = self.unified_diff([], [b"Hello\n"])
 
303
        mod_patch = self.unified_diff([], ["Hello\n"])
342
304
        btree.note_patch("grandparent/alt_parent/file", mod_patch)
343
305
        self.get_file_test(btree)
344
306
 
345
307
    def test_delete(self):
346
308
        "Deletion by bundle"
347
309
        btree = self.make_tree_1()[0]
348
 
        with btree.get_file(btree.id2path(b"c")) as f:
349
 
            self.assertEqual(f.read(), b"Hello\n")
 
310
        self.assertEqual(btree.get_file("c").read(), "Hello\n")
350
311
        btree.note_deletion("grandparent/parent/file")
351
 
        self.assertTrue(btree.id2path(b"c") is None)
352
 
        self.assertFalse(btree.is_versioned("grandparent/parent/file"))
 
312
        self.assertTrue(btree.id2path("c") is None)
 
313
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
353
314
 
354
315
    def sorted_ids(self, tree):
355
 
        ids = sorted(tree.all_file_ids())
 
316
        ids = list(tree)
 
317
        ids.sort()
356
318
        return ids
357
319
 
358
320
    def test_iteration(self):
359
321
        """Ensure that iteration through ids works properly"""
360
322
        btree = self.make_tree_1()[0]
361
323
        self.assertEqual(self.sorted_ids(btree),
362
 
                         [inventory.ROOT_ID, b'a', b'b', b'c', b'd'])
 
324
            [inventory.ROOT_ID, 'a', 'b', 'c', 'd'])
363
325
        btree.note_deletion("grandparent/parent/file")
364
 
        btree.note_id(b"e", "grandparent/alt_parent/fool", kind="directory")
 
326
        btree.note_id("e", "grandparent/alt_parent/fool", kind="directory")
365
327
        btree.note_last_changed("grandparent/alt_parent/fool",
366
328
                                "revisionidiguess")
367
329
        self.assertEqual(self.sorted_ids(btree),
368
 
                         [inventory.ROOT_ID, b'a', b'b', b'd', b'e'])
 
330
            [inventory.ROOT_ID, 'a', 'b', 'd', 'e'])
369
331
 
370
332
 
371
333
class BundleTester1(tests.TestCaseWithTransport):
376
338
        serializer = BundleSerializerV08('0.8')
377
339
        b = self.make_branch('.', format=format)
378
340
        self.assertRaises(errors.IncompatibleBundleFormat, serializer.write,
379
 
                          b.repository, [], {}, BytesIO())
 
341
                          b.repository, [], {}, StringIO())
380
342
 
381
343
    def test_matched_bundle(self):
382
344
        """Don't raise IncompatibleBundleFormat for knit2 and bundle0.9"""
384
346
        format.repository_format = knitrepo.RepositoryFormatKnit3()
385
347
        serializer = BundleSerializerV09('0.9')
386
348
        b = self.make_branch('.', format=format)
387
 
        serializer.write(b.repository, [], {}, BytesIO())
 
349
        serializer.write(b.repository, [], {}, StringIO())
388
350
 
389
351
    def test_mismatched_model(self):
390
352
        """Try copying a bundle from knit2 to knit1"""
391
353
        format = bzrdir.BzrDirMetaFormat1()
392
354
        format.repository_format = knitrepo.RepositoryFormatKnit3()
393
355
        source = self.make_branch_and_tree('source', format=format)
394
 
        source.commit('one', rev_id=b'one-id')
395
 
        source.commit('two', rev_id=b'two-id')
396
 
        text = BytesIO()
397
 
        write_bundle(source.branch.repository, b'two-id', b'null:', text,
 
356
        source.commit('one', rev_id='one-id')
 
357
        source.commit('two', rev_id='two-id')
 
358
        text = StringIO()
 
359
        write_bundle(source.branch.repository, 'two-id', 'null:', text,
398
360
                     format='0.9')
399
361
        text.seek(0)
400
362
 
424
386
        return tests.TestCaseWithTransport.make_branch(self, path, format)
425
387
 
426
388
    def create_bundle_text(self, base_rev_id, rev_id):
427
 
        bundle_txt = BytesIO()
 
389
        bundle_txt = StringIO()
428
390
        rev_ids = write_bundle(self.b1.repository, rev_id, base_rev_id,
429
391
                               bundle_txt, format=self.format)
430
392
        bundle_txt.seek(0)
431
393
        self.assertEqual(bundle_txt.readline(),
432
 
                         b'# Bazaar revision bundle v%s\n' % self.format.encode('ascii'))
433
 
        self.assertEqual(bundle_txt.readline(), b'#\n')
 
394
                         '# Bazaar revision bundle v%s\n' % self.format)
 
395
        self.assertEqual(bundle_txt.readline(), '#\n')
434
396
 
435
397
        rev = self.b1.repository.get_revision(rev_id)
436
398
        self.assertEqual(bundle_txt.readline().decode('utf-8'),
465
427
                             len(bundle_rev.parent_ids))
466
428
        self.assertEqual(rev_ids,
467
429
                         [r.revision_id for r in bundle.real_revisions])
468
 
        self.valid_apply_bundle(base_rev_id, bundle, checkout_dir=checkout_dir)
 
430
        self.valid_apply_bundle(base_rev_id, bundle,
 
431
                                   checkout_dir=checkout_dir)
469
432
 
470
433
        return bundle
471
434
 
476
439
        :return: The in-memory bundle
477
440
        """
478
441
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
479
 
        new_text = bundle_txt.getvalue().replace(b'executable:no',
480
 
                                                 b'executable:yes')
481
 
        bundle_txt = BytesIO(new_text)
 
442
        new_text = bundle_txt.getvalue().replace('executable:no',
 
443
                                               'executable:yes')
 
444
        bundle_txt = StringIO(new_text)
482
445
        bundle = read_bundle(bundle_txt)
483
446
        self.valid_apply_bundle(base_rev_id, bundle)
484
447
        return bundle
485
448
 
486
449
    def test_non_bundle(self):
487
450
        self.assertRaises(errors.NotABundle,
488
 
                          read_bundle, BytesIO(b'#!/bin/sh\n'))
 
451
                          read_bundle, StringIO('#!/bin/sh\n'))
489
452
 
490
453
    def test_malformed(self):
491
454
        self.assertRaises(errors.BadBundle, read_bundle,
492
 
                          BytesIO(b'# Bazaar revision bundle v'))
 
455
                          StringIO('# Bazaar revision bundle v'))
493
456
 
494
457
    def test_crlf_bundle(self):
495
458
        try:
496
 
            read_bundle(BytesIO(b'# Bazaar revision bundle v0.8\r\n'))
 
459
            read_bundle(StringIO('# Bazaar revision bundle v0.8\r\n'))
497
460
        except errors.BadBundle:
498
461
            # It is currently permitted for bundles with crlf line endings to
499
462
            # make read_bundle raise a BadBundle, but this should be fixed.
510
473
            if not os.path.exists(checkout_dir):
511
474
                os.mkdir(checkout_dir)
512
475
        tree = self.make_branch_and_tree(checkout_dir)
513
 
        s = BytesIO()
514
 
        ancestors = write_bundle(self.b1.repository, rev_id, b'null:', s,
 
476
        s = StringIO()
 
477
        ancestors = write_bundle(self.b1.repository, rev_id, 'null:', s,
515
478
                                 format=self.format)
516
479
        s.seek(0)
517
 
        self.assertIsInstance(s.getvalue(), bytes)
 
480
        self.assertIsInstance(s.getvalue(), str)
518
481
        install_bundle(tree.branch.repository, read_bundle(s))
519
482
        for ancestor in ancestors:
520
483
            old = self.b1.repository.revision_tree(ancestor)
529
492
                                 % (ancestor,))
530
493
 
531
494
                # Now check that the file contents are all correct
532
 
                for path in old.all_versioned_paths():
 
495
                for inventory_id in old:
533
496
                    try:
534
 
                        old_file = old.get_file(path)
 
497
                        old_file = old.get_file(inventory_id)
535
498
                    except errors.NoSuchFile:
536
499
                        continue
537
 
                    self.assertEqual(
538
 
                        old_file.read(), new.get_file(path).read())
 
500
                    if old_file is None:
 
501
                        continue
 
502
                    self.assertEqual(old_file.read(),
 
503
                                     new.get_file(inventory_id).read())
539
504
            finally:
540
505
                new.unlock()
541
506
                old.unlock()
542
507
        if not _mod_revision.is_null(rev_id):
543
 
            tree.branch.generate_revision_history(rev_id)
 
508
            rh = self.b1.revision_history()
 
509
            tree.branch.set_revision_history(rh[:rh.index(rev_id)+1])
544
510
            tree.update()
545
511
            delta = tree.changes_from(self.b1.repository.revision_tree(rev_id))
546
512
            self.assertFalse(delta.has_changed(),
564
530
        original_parents = to_tree.get_parent_ids()
565
531
        self.assertIs(repository.has_revision(base_rev_id), True)
566
532
        for rev in info.real_revisions:
567
 
            self.assertTrue(not repository.has_revision(rev.revision_id),
568
 
                            'Revision {%s} present before applying bundle'
569
 
                            % rev.revision_id)
 
533
            self.assert_(not repository.has_revision(rev.revision_id),
 
534
                'Revision {%s} present before applying bundle'
 
535
                % rev.revision_id)
570
536
        merge_bundle(info, to_tree, True, merge.Merge3Merger, False, False)
571
537
 
572
538
        for rev in info.real_revisions:
573
 
            self.assertTrue(repository.has_revision(rev.revision_id),
574
 
                            'Missing revision {%s} after applying bundle'
575
 
                            % rev.revision_id)
 
539
            self.assert_(repository.has_revision(rev.revision_id),
 
540
                'Missing revision {%s} after applying bundle'
 
541
                % rev.revision_id)
576
542
 
577
 
        self.assertTrue(to_tree.branch.repository.has_revision(info.target))
 
543
        self.assert_(to_tree.branch.repository.has_revision(info.target))
578
544
        # Do we also want to verify that all the texts have been added?
579
545
 
580
546
        self.assertEqual(original_parents + [info.target],
581
 
                         to_tree.get_parent_ids())
 
547
            to_tree.get_parent_ids())
582
548
 
583
549
        rev = info.real_revisions[-1]
584
550
        base_tree = self.b1.repository.revision_tree(rev.revision_id)
595
561
 
596
562
        for path, status, kind, fileid, entry in base_files:
597
563
            # Check that the meta information is the same
598
 
            self.assertEqual(
599
 
                base_tree.get_file_size(path),
600
 
                to_tree.get_file_size(to_tree.id2path(fileid)))
601
 
            self.assertEqual(
602
 
                base_tree.get_file_sha1(path),
603
 
                to_tree.get_file_sha1(to_tree.id2path(fileid)))
 
564
            self.assertEqual(base_tree.get_file_size(fileid),
 
565
                    to_tree.get_file_size(fileid))
 
566
            self.assertEqual(base_tree.get_file_sha1(fileid),
 
567
                    to_tree.get_file_sha1(fileid))
604
568
            # Check that the contents are the same
605
569
            # This is pretty expensive
606
570
            # self.assertEqual(base_tree.get_file(fileid).read(),
610
574
        self.tree1 = self.make_branch_and_tree('b1')
611
575
        self.b1 = self.tree1.branch
612
576
 
613
 
        self.build_tree_contents([('b1/one', b'one\n')])
614
 
        self.tree1.add('one', b'one-id')
615
 
        self.tree1.set_root_id(b'root-id')
616
 
        self.tree1.commit('add one', rev_id=b'a@cset-0-1')
 
577
        self.build_tree_contents([('b1/one', 'one\n')])
 
578
        self.tree1.add('one', 'one-id')
 
579
        self.tree1.set_root_id('root-id')
 
580
        self.tree1.commit('add one', rev_id='a@cset-0-1')
617
581
 
618
 
        bundle = self.get_valid_bundle(b'null:', b'a@cset-0-1')
 
582
        bundle = self.get_valid_bundle('null:', 'a@cset-0-1')
619
583
 
620
584
        # Make sure we can handle files with spaces, tabs, other
621
585
        # bogus characters
622
586
        self.build_tree([
623
 
            'b1/with space.txt', 'b1/dir/', 'b1/dir/filein subdir.c', 'b1/dir/WithCaps.txt', 'b1/dir/ pre space', 'b1/sub/', 'b1/sub/sub/', 'b1/sub/sub/nonempty.txt'
624
 
            ])
625
 
        self.build_tree_contents([('b1/sub/sub/emptyfile.txt', b''),
626
 
                                  ('b1/dir/nolastnewline.txt', b'bloop')])
 
587
                'b1/with space.txt'
 
588
                , 'b1/dir/'
 
589
                , 'b1/dir/filein subdir.c'
 
590
                , 'b1/dir/WithCaps.txt'
 
591
                , 'b1/dir/ pre space'
 
592
                , 'b1/sub/'
 
593
                , 'b1/sub/sub/'
 
594
                , 'b1/sub/sub/nonempty.txt'
 
595
                ])
 
596
        self.build_tree_contents([('b1/sub/sub/emptyfile.txt', ''),
 
597
                                  ('b1/dir/nolastnewline.txt', 'bloop')])
627
598
        tt = TreeTransform(self.tree1)
628
 
        tt.new_file('executable', tt.root, [b'#!/bin/sh\n'], b'exe-1', True)
 
599
        tt.new_file('executable', tt.root, '#!/bin/sh\n', 'exe-1', True)
629
600
        tt.apply()
630
601
        # have to fix length of file-id so that we can predictably rewrite
631
602
        # a (length-prefixed) record containing it later.
632
 
        self.tree1.add('with space.txt', b'withspace-id')
 
603
        self.tree1.add('with space.txt', 'withspace-id')
633
604
        self.tree1.add([
634
 
            'dir', 'dir/filein subdir.c', 'dir/WithCaps.txt', 'dir/ pre space', 'dir/nolastnewline.txt', 'sub', 'sub/sub', 'sub/sub/nonempty.txt', 'sub/sub/emptyfile.txt'
635
 
            ])
636
 
        self.tree1.commit('add whitespace', rev_id=b'a@cset-0-2')
 
605
                  'dir'
 
606
                , 'dir/filein subdir.c'
 
607
                , 'dir/WithCaps.txt'
 
608
                , 'dir/ pre space'
 
609
                , 'dir/nolastnewline.txt'
 
610
                , 'sub'
 
611
                , 'sub/sub'
 
612
                , 'sub/sub/nonempty.txt'
 
613
                , 'sub/sub/emptyfile.txt'
 
614
                ])
 
615
        self.tree1.commit('add whitespace', rev_id='a@cset-0-2')
637
616
 
638
 
        bundle = self.get_valid_bundle(b'a@cset-0-1', b'a@cset-0-2')
 
617
        bundle = self.get_valid_bundle('a@cset-0-1', 'a@cset-0-2')
639
618
 
640
619
        # Check a rollup bundle
641
 
        bundle = self.get_valid_bundle(b'null:', b'a@cset-0-2')
 
620
        bundle = self.get_valid_bundle('null:', 'a@cset-0-2')
642
621
 
643
622
        # Now delete entries
644
623
        self.tree1.remove(
645
 
            ['sub/sub/nonempty.txt', 'sub/sub/emptyfile.txt', 'sub/sub'
646
 
             ])
 
624
                ['sub/sub/nonempty.txt'
 
625
                , 'sub/sub/emptyfile.txt'
 
626
                , 'sub/sub'
 
627
                ])
647
628
        tt = TreeTransform(self.tree1)
648
 
        trans_id = tt.trans_id_tree_path('executable')
 
629
        trans_id = tt.trans_id_tree_file_id('exe-1')
649
630
        tt.set_executability(False, trans_id)
650
631
        tt.apply()
651
 
        self.tree1.commit('removed', rev_id=b'a@cset-0-3')
 
632
        self.tree1.commit('removed', rev_id='a@cset-0-3')
652
633
 
653
 
        bundle = self.get_valid_bundle(b'a@cset-0-2', b'a@cset-0-3')
 
634
        bundle = self.get_valid_bundle('a@cset-0-2', 'a@cset-0-3')
654
635
        self.assertRaises((errors.TestamentMismatch,
655
 
                           errors.VersionedFileInvalidChecksum,
656
 
                           errors.BadBundle), self.get_invalid_bundle,
657
 
                          b'a@cset-0-2', b'a@cset-0-3')
 
636
            errors.VersionedFileInvalidChecksum,
 
637
            errors.BadBundle), self.get_invalid_bundle,
 
638
            'a@cset-0-2', 'a@cset-0-3')
658
639
        # Check a rollup bundle
659
 
        bundle = self.get_valid_bundle(b'null:', b'a@cset-0-3')
 
640
        bundle = self.get_valid_bundle('null:', 'a@cset-0-3')
660
641
 
661
642
        # Now move the directory
662
643
        self.tree1.rename_one('dir', 'sub/dir')
663
 
        self.tree1.commit('rename dir', rev_id=b'a@cset-0-4')
 
644
        self.tree1.commit('rename dir', rev_id='a@cset-0-4')
664
645
 
665
 
        bundle = self.get_valid_bundle(b'a@cset-0-3', b'a@cset-0-4')
 
646
        bundle = self.get_valid_bundle('a@cset-0-3', 'a@cset-0-4')
666
647
        # Check a rollup bundle
667
 
        bundle = self.get_valid_bundle(b'null:', b'a@cset-0-4')
 
648
        bundle = self.get_valid_bundle('null:', 'a@cset-0-4')
668
649
 
669
650
        # Modified files
670
 
        with open('b1/sub/dir/WithCaps.txt', 'ab') as f:
671
 
            f.write(b'\nAdding some text\n')
672
 
        with open('b1/sub/dir/ pre space', 'ab') as f:
673
 
            f.write(
674
 
                b'\r\nAdding some\r\nDOS format lines\r\n')
675
 
        with open('b1/sub/dir/nolastnewline.txt', 'ab') as f:
676
 
            f.write(b'\n')
 
651
        open('b1/sub/dir/WithCaps.txt', 'ab').write('\nAdding some text\n')
 
652
        open('b1/sub/dir/ pre space', 'ab').write(
 
653
             '\r\nAdding some\r\nDOS format lines\r\n')
 
654
        open('b1/sub/dir/nolastnewline.txt', 'ab').write('\n')
677
655
        self.tree1.rename_one('sub/dir/ pre space',
678
656
                              'sub/ start space')
679
 
        self.tree1.commit('Modified files', rev_id=b'a@cset-0-5')
680
 
        bundle = self.get_valid_bundle(b'a@cset-0-4', b'a@cset-0-5')
 
657
        self.tree1.commit('Modified files', rev_id='a@cset-0-5')
 
658
        bundle = self.get_valid_bundle('a@cset-0-4', 'a@cset-0-5')
681
659
 
682
660
        self.tree1.rename_one('sub/dir/WithCaps.txt', 'temp')
683
661
        self.tree1.rename_one('with space.txt', 'WithCaps.txt')
684
662
        self.tree1.rename_one('temp', 'with space.txt')
685
 
        self.tree1.commit(u'swap filenames', rev_id=b'a@cset-0-6',
 
663
        self.tree1.commit(u'swap filenames', rev_id='a@cset-0-6',
686
664
                          verbose=False)
687
 
        bundle = self.get_valid_bundle(b'a@cset-0-5', b'a@cset-0-6')
688
 
        other = self.get_checkout(b'a@cset-0-5')
 
665
        bundle = self.get_valid_bundle('a@cset-0-5', 'a@cset-0-6')
 
666
        other = self.get_checkout('a@cset-0-5')
689
667
        tree1_inv = get_inventory_text(self.tree1.branch.repository,
690
 
                                       b'a@cset-0-5')
 
668
                                       'a@cset-0-5')
691
669
        tree2_inv = get_inventory_text(other.branch.repository,
692
 
                                       b'a@cset-0-5')
 
670
                                       'a@cset-0-5')
693
671
        self.assertEqualDiff(tree1_inv, tree2_inv)
694
672
        other.rename_one('sub/dir/nolastnewline.txt', 'sub/nolastnewline.txt')
695
 
        other.commit('rename file', rev_id=b'a@cset-0-6b')
 
673
        other.commit('rename file', rev_id='a@cset-0-6b')
696
674
        self.tree1.merge_from_branch(other.branch)
697
 
        self.tree1.commit(u'Merge', rev_id=b'a@cset-0-7',
 
675
        self.tree1.commit(u'Merge', rev_id='a@cset-0-7',
698
676
                          verbose=False)
699
 
        bundle = self.get_valid_bundle(b'a@cset-0-6', b'a@cset-0-7')
 
677
        bundle = self.get_valid_bundle('a@cset-0-6', 'a@cset-0-7')
700
678
 
701
679
    def _test_symlink_bundle(self, link_name, link_target, new_link_target):
702
 
        link_id = b'link-1'
 
680
        link_id = 'link-1'
703
681
 
704
 
        self.requireFeature(features.SymlinkFeature)
 
682
        self.requireFeature(tests.SymlinkFeature)
705
683
        self.tree1 = self.make_branch_and_tree('b1')
706
684
        self.b1 = self.tree1.branch
707
685
 
708
686
        tt = TreeTransform(self.tree1)
709
687
        tt.new_symlink(link_name, tt.root, link_target, link_id)
710
688
        tt.apply()
711
 
        self.tree1.commit('add symlink', rev_id=b'l@cset-0-1')
712
 
        bundle = self.get_valid_bundle(b'null:', b'l@cset-0-1')
713
 
        if getattr(bundle, 'revision_tree', None) is not None:
 
689
        self.tree1.commit('add symlink', rev_id='l@cset-0-1')
 
690
        bundle = self.get_valid_bundle('null:', 'l@cset-0-1')
 
691
        if getattr(bundle ,'revision_tree', None) is not None:
714
692
            # Not all bundle formats supports revision_tree
715
 
            bund_tree = bundle.revision_tree(self.b1.repository, b'l@cset-0-1')
716
 
            self.assertEqual(
717
 
                link_target, bund_tree.get_symlink_target(link_name))
 
693
            bund_tree = bundle.revision_tree(self.b1.repository, 'l@cset-0-1')
 
694
            self.assertEqual(link_target, bund_tree.get_symlink_target(link_id))
718
695
 
719
696
        tt = TreeTransform(self.tree1)
720
 
        trans_id = tt.trans_id_tree_path(link_name)
 
697
        trans_id = tt.trans_id_tree_file_id(link_id)
721
698
        tt.adjust_path('link2', tt.root, trans_id)
722
699
        tt.delete_contents(trans_id)
723
700
        tt.create_symlink(new_link_target, trans_id)
724
701
        tt.apply()
725
 
        self.tree1.commit('rename and change symlink', rev_id=b'l@cset-0-2')
726
 
        bundle = self.get_valid_bundle(b'l@cset-0-1', b'l@cset-0-2')
727
 
        if getattr(bundle, 'revision_tree', None) is not None:
 
702
        self.tree1.commit('rename and change symlink', rev_id='l@cset-0-2')
 
703
        bundle = self.get_valid_bundle('l@cset-0-1', 'l@cset-0-2')
 
704
        if getattr(bundle ,'revision_tree', None) is not None:
728
705
            # Not all bundle formats supports revision_tree
729
 
            bund_tree = bundle.revision_tree(self.b1.repository, b'l@cset-0-2')
 
706
            bund_tree = bundle.revision_tree(self.b1.repository, 'l@cset-0-2')
730
707
            self.assertEqual(new_link_target,
731
 
                             bund_tree.get_symlink_target('link2'))
 
708
                             bund_tree.get_symlink_target(link_id))
732
709
 
733
710
        tt = TreeTransform(self.tree1)
734
 
        trans_id = tt.trans_id_tree_path('link2')
 
711
        trans_id = tt.trans_id_tree_file_id(link_id)
735
712
        tt.delete_contents(trans_id)
736
713
        tt.create_symlink('jupiter', trans_id)
737
714
        tt.apply()
738
 
        self.tree1.commit('just change symlink target', rev_id=b'l@cset-0-3')
739
 
        bundle = self.get_valid_bundle(b'l@cset-0-2', b'l@cset-0-3')
 
715
        self.tree1.commit('just change symlink target', rev_id='l@cset-0-3')
 
716
        bundle = self.get_valid_bundle('l@cset-0-2', 'l@cset-0-3')
740
717
 
741
718
        tt = TreeTransform(self.tree1)
742
 
        trans_id = tt.trans_id_tree_path('link2')
 
719
        trans_id = tt.trans_id_tree_file_id(link_id)
743
720
        tt.delete_contents(trans_id)
744
721
        tt.apply()
745
 
        self.tree1.commit('Delete symlink', rev_id=b'l@cset-0-4')
746
 
        bundle = self.get_valid_bundle(b'l@cset-0-3', b'l@cset-0-4')
 
722
        self.tree1.commit('Delete symlink', rev_id='l@cset-0-4')
 
723
        bundle = self.get_valid_bundle('l@cset-0-3', 'l@cset-0-4')
747
724
 
748
725
    def test_symlink_bundle(self):
749
726
        self._test_symlink_bundle('link', 'bar/foo', 'mars')
750
727
 
751
728
    def test_unicode_symlink_bundle(self):
752
 
        self.requireFeature(features.UnicodeFilenameFeature)
 
729
        self.requireFeature(tests.UnicodeFilenameFeature)
753
730
        self._test_symlink_bundle(u'\N{Euro Sign}link',
754
731
                                  u'bar/\N{Euro Sign}foo',
755
732
                                  u'mars\N{Euro Sign}')
760
737
        tt = TreeTransform(self.tree1)
761
738
 
762
739
        # Add
763
 
        tt.new_file('file', tt.root, [
764
 
                    b'\x00\n\x00\r\x01\n\x02\r\xff'], b'binary-1')
765
 
        tt.new_file('file2', tt.root, [b'\x01\n\x02\r\x03\n\x04\r\xff'],
766
 
                    b'binary-2')
 
740
        tt.new_file('file', tt.root, '\x00\n\x00\r\x01\n\x02\r\xff', 'binary-1')
 
741
        tt.new_file('file2', tt.root, '\x01\n\x02\r\x03\n\x04\r\xff',
 
742
            'binary-2')
767
743
        tt.apply()
768
 
        self.tree1.commit('add binary', rev_id=b'b@cset-0-1')
769
 
        self.get_valid_bundle(b'null:', b'b@cset-0-1')
 
744
        self.tree1.commit('add binary', rev_id='b@cset-0-1')
 
745
        self.get_valid_bundle('null:', 'b@cset-0-1')
770
746
 
771
747
        # Delete
772
748
        tt = TreeTransform(self.tree1)
773
 
        trans_id = tt.trans_id_tree_path('file')
 
749
        trans_id = tt.trans_id_tree_file_id('binary-1')
774
750
        tt.delete_contents(trans_id)
775
751
        tt.apply()
776
 
        self.tree1.commit('delete binary', rev_id=b'b@cset-0-2')
777
 
        self.get_valid_bundle(b'b@cset-0-1', b'b@cset-0-2')
 
752
        self.tree1.commit('delete binary', rev_id='b@cset-0-2')
 
753
        self.get_valid_bundle('b@cset-0-1', 'b@cset-0-2')
778
754
 
779
755
        # Rename & modify
780
756
        tt = TreeTransform(self.tree1)
781
 
        trans_id = tt.trans_id_tree_path('file2')
 
757
        trans_id = tt.trans_id_tree_file_id('binary-2')
782
758
        tt.adjust_path('file3', tt.root, trans_id)
783
759
        tt.delete_contents(trans_id)
784
 
        tt.create_file([b'file\rcontents\x00\n\x00'], trans_id)
 
760
        tt.create_file('file\rcontents\x00\n\x00', trans_id)
785
761
        tt.apply()
786
 
        self.tree1.commit('rename and modify binary', rev_id=b'b@cset-0-3')
787
 
        self.get_valid_bundle(b'b@cset-0-2', b'b@cset-0-3')
 
762
        self.tree1.commit('rename and modify binary', rev_id='b@cset-0-3')
 
763
        self.get_valid_bundle('b@cset-0-2', 'b@cset-0-3')
788
764
 
789
765
        # Modify
790
766
        tt = TreeTransform(self.tree1)
791
 
        trans_id = tt.trans_id_tree_path('file3')
 
767
        trans_id = tt.trans_id_tree_file_id('binary-2')
792
768
        tt.delete_contents(trans_id)
793
 
        tt.create_file([b'\x00file\rcontents'], trans_id)
 
769
        tt.create_file('\x00file\rcontents', trans_id)
794
770
        tt.apply()
795
 
        self.tree1.commit('just modify binary', rev_id=b'b@cset-0-4')
796
 
        self.get_valid_bundle(b'b@cset-0-3', b'b@cset-0-4')
 
771
        self.tree1.commit('just modify binary', rev_id='b@cset-0-4')
 
772
        self.get_valid_bundle('b@cset-0-3', 'b@cset-0-4')
797
773
 
798
774
        # Rollup
799
 
        self.get_valid_bundle(b'null:', b'b@cset-0-4')
 
775
        self.get_valid_bundle('null:', 'b@cset-0-4')
800
776
 
801
777
    def test_last_modified(self):
802
778
        self.tree1 = self.make_branch_and_tree('b1')
803
779
        self.b1 = self.tree1.branch
804
780
        tt = TreeTransform(self.tree1)
805
 
        tt.new_file('file', tt.root, [b'file'], b'file')
 
781
        tt.new_file('file', tt.root, 'file', 'file')
806
782
        tt.apply()
807
 
        self.tree1.commit('create file', rev_id=b'a@lmod-0-1')
 
783
        self.tree1.commit('create file', rev_id='a@lmod-0-1')
808
784
 
809
785
        tt = TreeTransform(self.tree1)
810
 
        trans_id = tt.trans_id_tree_path('file')
 
786
        trans_id = tt.trans_id_tree_file_id('file')
811
787
        tt.delete_contents(trans_id)
812
 
        tt.create_file([b'file2'], trans_id)
 
788
        tt.create_file('file2', trans_id)
813
789
        tt.apply()
814
 
        self.tree1.commit('modify text', rev_id=b'a@lmod-0-2a')
 
790
        self.tree1.commit('modify text', rev_id='a@lmod-0-2a')
815
791
 
816
 
        other = self.get_checkout(b'a@lmod-0-1')
 
792
        other = self.get_checkout('a@lmod-0-1')
817
793
        tt = TreeTransform(other)
818
 
        trans_id = tt.trans_id_tree_path('file2')
 
794
        trans_id = tt.trans_id_tree_file_id('file')
819
795
        tt.delete_contents(trans_id)
820
 
        tt.create_file([b'file2'], trans_id)
 
796
        tt.create_file('file2', trans_id)
821
797
        tt.apply()
822
 
        other.commit('modify text in another tree', rev_id=b'a@lmod-0-2b')
 
798
        other.commit('modify text in another tree', rev_id='a@lmod-0-2b')
823
799
        self.tree1.merge_from_branch(other.branch)
824
 
        self.tree1.commit(u'Merge', rev_id=b'a@lmod-0-3',
 
800
        self.tree1.commit(u'Merge', rev_id='a@lmod-0-3',
825
801
                          verbose=False)
826
 
        self.tree1.commit(u'Merge', rev_id=b'a@lmod-0-4')
827
 
        bundle = self.get_valid_bundle(b'a@lmod-0-2a', b'a@lmod-0-4')
 
802
        self.tree1.commit(u'Merge', rev_id='a@lmod-0-4')
 
803
        bundle = self.get_valid_bundle('a@lmod-0-2a', 'a@lmod-0-4')
828
804
 
829
805
    def test_hide_history(self):
830
806
        self.tree1 = self.make_branch_and_tree('b1')
831
807
        self.b1 = self.tree1.branch
832
808
 
833
 
        with open('b1/one', 'wb') as f:
834
 
            f.write(b'one\n')
 
809
        open('b1/one', 'wb').write('one\n')
835
810
        self.tree1.add('one')
836
 
        self.tree1.commit('add file', rev_id=b'a@cset-0-1')
837
 
        with open('b1/one', 'wb') as f:
838
 
            f.write(b'two\n')
839
 
        self.tree1.commit('modify', rev_id=b'a@cset-0-2')
840
 
        with open('b1/one', 'wb') as f:
841
 
            f.write(b'three\n')
842
 
        self.tree1.commit('modify', rev_id=b'a@cset-0-3')
843
 
        bundle_file = BytesIO()
844
 
        rev_ids = write_bundle(self.tree1.branch.repository, b'a@cset-0-3',
845
 
                               b'a@cset-0-1', bundle_file, format=self.format)
846
 
        self.assertNotContainsRe(bundle_file.getvalue(), b'\btwo\b')
847
 
        self.assertContainsRe(self.get_raw(bundle_file), b'one')
848
 
        self.assertContainsRe(self.get_raw(bundle_file), b'three')
 
811
        self.tree1.commit('add file', rev_id='a@cset-0-1')
 
812
        open('b1/one', 'wb').write('two\n')
 
813
        self.tree1.commit('modify', rev_id='a@cset-0-2')
 
814
        open('b1/one', 'wb').write('three\n')
 
815
        self.tree1.commit('modify', rev_id='a@cset-0-3')
 
816
        bundle_file = StringIO()
 
817
        rev_ids = write_bundle(self.tree1.branch.repository, 'a@cset-0-3',
 
818
                               'a@cset-0-1', bundle_file, format=self.format)
 
819
        self.assertNotContainsRe(bundle_file.getvalue(), '\btwo\b')
 
820
        self.assertContainsRe(self.get_raw(bundle_file), 'one')
 
821
        self.assertContainsRe(self.get_raw(bundle_file), 'three')
849
822
 
850
823
    def test_bundle_same_basis(self):
851
824
        """Ensure using the basis as the target doesn't cause an error"""
852
825
        self.tree1 = self.make_branch_and_tree('b1')
853
 
        self.tree1.commit('add file', rev_id=b'a@cset-0-1')
854
 
        bundle_file = BytesIO()
855
 
        rev_ids = write_bundle(self.tree1.branch.repository, b'a@cset-0-1',
856
 
                               b'a@cset-0-1', bundle_file)
 
826
        self.tree1.commit('add file', rev_id='a@cset-0-1')
 
827
        bundle_file = StringIO()
 
828
        rev_ids = write_bundle(self.tree1.branch.repository, 'a@cset-0-1',
 
829
                               'a@cset-0-1', bundle_file)
857
830
 
858
831
    @staticmethod
859
832
    def get_raw(bundle_file):
860
833
        return bundle_file.getvalue()
861
834
 
862
835
    def test_unicode_bundle(self):
863
 
        self.requireFeature(features.UnicodeFilenameFeature)
 
836
        self.requireFeature(tests.UnicodeFilenameFeature)
864
837
        # Handle international characters
865
838
        os.mkdir('b1')
866
839
        f = open(u'b1/with Dod\N{Euro Sign}', 'wb')
869
842
        self.b1 = self.tree1.branch
870
843
 
871
844
        f.write((u'A file\n'
872
 
                 u'With international man of mystery\n'
873
 
                 u'William Dod\xe9\n').encode('utf-8'))
 
845
            u'With international man of mystery\n'
 
846
            u'William Dod\xe9\n').encode('utf-8'))
874
847
        f.close()
875
848
 
876
 
        self.tree1.add([u'with Dod\N{Euro Sign}'], [b'withdod-id'])
 
849
        self.tree1.add([u'with Dod\N{Euro Sign}'], ['withdod-id'])
877
850
        self.tree1.commit(u'i18n commit from William Dod\xe9',
878
 
                          rev_id=b'i18n-1', committer=u'William Dod\xe9')
 
851
                          rev_id='i18n-1', committer=u'William Dod\xe9')
879
852
 
880
853
        # Add
881
 
        bundle = self.get_valid_bundle(b'null:', b'i18n-1')
 
854
        bundle = self.get_valid_bundle('null:', 'i18n-1')
882
855
 
883
856
        # Modified
884
857
        f = open(u'b1/with Dod\N{Euro Sign}', 'wb')
885
858
        f.write(u'Modified \xb5\n'.encode('utf8'))
886
859
        f.close()
887
 
        self.tree1.commit(u'modified', rev_id=b'i18n-2')
 
860
        self.tree1.commit(u'modified', rev_id='i18n-2')
888
861
 
889
 
        bundle = self.get_valid_bundle(b'i18n-1', b'i18n-2')
 
862
        bundle = self.get_valid_bundle('i18n-1', 'i18n-2')
890
863
 
891
864
        # Renamed
892
865
        self.tree1.rename_one(u'with Dod\N{Euro Sign}', u'B\N{Euro Sign}gfors')
893
 
        self.tree1.commit(u'renamed, the new i18n man', rev_id=b'i18n-3',
 
866
        self.tree1.commit(u'renamed, the new i18n man', rev_id='i18n-3',
894
867
                          committer=u'Erik B\xe5gfors')
895
868
 
896
 
        bundle = self.get_valid_bundle(b'i18n-2', b'i18n-3')
 
869
        bundle = self.get_valid_bundle('i18n-2', 'i18n-3')
897
870
 
898
871
        # Removed
899
872
        self.tree1.remove([u'B\N{Euro Sign}gfors'])
900
 
        self.tree1.commit(u'removed', rev_id=b'i18n-4')
 
873
        self.tree1.commit(u'removed', rev_id='i18n-4')
901
874
 
902
 
        bundle = self.get_valid_bundle(b'i18n-3', b'i18n-4')
 
875
        bundle = self.get_valid_bundle('i18n-3', 'i18n-4')
903
876
 
904
877
        # Rollup
905
 
        bundle = self.get_valid_bundle(b'null:', b'i18n-4')
 
878
        bundle = self.get_valid_bundle('null:', 'i18n-4')
 
879
 
906
880
 
907
881
    def test_whitespace_bundle(self):
908
882
        if sys.platform in ('win32', 'cygwin'):
917
891
        #       once we actually support them
918
892
 
919
893
        # Added
920
 
        self.tree1.commit('funky whitespace', rev_id=b'white-1')
 
894
        self.tree1.commit('funky whitespace', rev_id='white-1')
921
895
 
922
 
        bundle = self.get_valid_bundle(b'null:', b'white-1')
 
896
        bundle = self.get_valid_bundle('null:', 'white-1')
923
897
 
924
898
        # Modified
925
 
        with open('b1/trailing space ', 'ab') as f:
926
 
            f.write(b'add some text\n')
927
 
        self.tree1.commit('add text', rev_id=b'white-2')
 
899
        open('b1/trailing space ', 'ab').write('add some text\n')
 
900
        self.tree1.commit('add text', rev_id='white-2')
928
901
 
929
 
        bundle = self.get_valid_bundle(b'white-1', b'white-2')
 
902
        bundle = self.get_valid_bundle('white-1', 'white-2')
930
903
 
931
904
        # Renamed
932
905
        self.tree1.rename_one('trailing space ', ' start and end space ')
933
 
        self.tree1.commit('rename', rev_id=b'white-3')
 
906
        self.tree1.commit('rename', rev_id='white-3')
934
907
 
935
 
        bundle = self.get_valid_bundle(b'white-2', b'white-3')
 
908
        bundle = self.get_valid_bundle('white-2', 'white-3')
936
909
 
937
910
        # Removed
938
911
        self.tree1.remove([' start and end space '])
939
 
        self.tree1.commit('removed', rev_id=b'white-4')
 
912
        self.tree1.commit('removed', rev_id='white-4')
940
913
 
941
 
        bundle = self.get_valid_bundle(b'white-3', b'white-4')
 
914
        bundle = self.get_valid_bundle('white-3', 'white-4')
942
915
 
943
916
        # Now test a complet roll-up
944
 
        bundle = self.get_valid_bundle(b'null:', b'white-4')
 
917
        bundle = self.get_valid_bundle('null:', 'white-4')
945
918
 
946
919
    def test_alt_timezone_bundle(self):
947
920
        self.tree1 = self.make_branch_and_memory_tree('b1')
954
927
        builder.finish_tree()
955
928
 
956
929
        # Asia/Colombo offset = 5 hours 30 minutes
957
 
        self.tree1.commit('non-hour offset timezone', rev_id=b'tz-1',
 
930
        self.tree1.commit('non-hour offset timezone', rev_id='tz-1',
958
931
                          timezone=19800, timestamp=1152544886.0)
959
932
 
960
 
        bundle = self.get_valid_bundle(b'null:', b'tz-1')
 
933
        bundle = self.get_valid_bundle('null:', 'tz-1')
961
934
 
962
935
        rev = bundle.revisions[0]
963
936
        self.assertEqual('Mon 2006-07-10 20:51:26.000000000 +0530', rev.date)
968
941
    def test_bundle_root_id(self):
969
942
        self.tree1 = self.make_branch_and_tree('b1')
970
943
        self.b1 = self.tree1.branch
971
 
        self.tree1.commit('message', rev_id=b'revid1')
972
 
        bundle = self.get_valid_bundle(b'null:', b'revid1')
973
 
        tree = self.get_bundle_tree(bundle, b'revid1')
974
 
        root_revision = tree.get_file_revision(u'')
975
 
        self.assertEqual(b'revid1', root_revision)
 
944
        self.tree1.commit('message', rev_id='revid1')
 
945
        bundle = self.get_valid_bundle('null:', 'revid1')
 
946
        tree = self.get_bundle_tree(bundle, 'revid1')
 
947
        self.assertEqual('revid1', tree.inventory.root.revision)
976
948
 
977
949
    def test_install_revisions(self):
978
950
        self.tree1 = self.make_branch_and_tree('b1')
979
951
        self.b1 = self.tree1.branch
980
 
        self.tree1.commit('message', rev_id=b'rev2a')
981
 
        bundle = self.get_valid_bundle(b'null:', b'rev2a')
 
952
        self.tree1.commit('message', rev_id='rev2a')
 
953
        bundle = self.get_valid_bundle('null:', 'rev2a')
982
954
        branch2 = self.make_branch('b2')
983
 
        self.assertFalse(branch2.repository.has_revision(b'rev2a'))
 
955
        self.assertFalse(branch2.repository.has_revision('rev2a'))
984
956
        target_revision = bundle.install_revisions(branch2.repository)
985
 
        self.assertTrue(branch2.repository.has_revision(b'rev2a'))
986
 
        self.assertEqual(b'rev2a', target_revision)
 
957
        self.assertTrue(branch2.repository.has_revision('rev2a'))
 
958
        self.assertEqual('rev2a', target_revision)
987
959
 
988
960
    def test_bundle_empty_property(self):
989
961
        """Test serializing revision properties with an empty value."""
990
962
        tree = self.make_branch_and_memory_tree('tree')
991
963
        tree.lock_write()
992
964
        self.addCleanup(tree.unlock)
993
 
        tree.add([''], [b'TREE_ROOT'])
994
 
        tree.commit('One', revprops={u'one': 'two',
995
 
                                     u'empty': ''}, rev_id=b'rev1')
 
965
        tree.add([''], ['TREE_ROOT'])
 
966
        tree.commit('One', revprops={'one':'two', 'empty':''}, rev_id='rev1')
996
967
        self.b1 = tree.branch
997
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
968
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
998
969
        bundle = read_bundle(bundle_sio)
999
970
        revision_info = bundle.revisions[0]
1000
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
971
        self.assertEqual('rev1', revision_info.revision_id)
1001
972
        rev = revision_info.as_revision()
1002
 
        self.assertEqual({'branch-nick': 'tree', 'empty': '', 'one': 'two'},
 
973
        self.assertEqual({'branch-nick':'tree', 'empty':'', 'one':'two'},
1003
974
                         rev.properties)
1004
975
 
1005
976
    def test_bundle_sorted_properties(self):
1008
979
        tree.lock_write()
1009
980
        self.addCleanup(tree.unlock)
1010
981
 
1011
 
        tree.add([''], [b'TREE_ROOT'])
1012
 
        tree.commit('One', rev_id=b'rev1',
1013
 
                    revprops={u'a': '4', u'b': '3', u'c': '2', u'd': '1'})
 
982
        tree.add([''], ['TREE_ROOT'])
 
983
        tree.commit('One', rev_id='rev1',
 
984
                    revprops={'a':'4', 'b':'3', 'c':'2', 'd':'1'})
1014
985
        self.b1 = tree.branch
1015
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
986
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1016
987
        bundle = read_bundle(bundle_sio)
1017
988
        revision_info = bundle.revisions[0]
1018
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
989
        self.assertEqual('rev1', revision_info.revision_id)
1019
990
        rev = revision_info.as_revision()
1020
 
        self.assertEqual({'branch-nick': 'tree', 'a': '4', 'b': '3', 'c': '2',
1021
 
                          'd': '1'}, rev.properties)
 
991
        self.assertEqual({'branch-nick':'tree', 'a':'4', 'b':'3', 'c':'2',
 
992
                          'd':'1'}, rev.properties)
1022
993
 
1023
994
    def test_bundle_unicode_properties(self):
1024
995
        """We should be able to round trip a non-ascii property."""
1026
997
        tree.lock_write()
1027
998
        self.addCleanup(tree.unlock)
1028
999
 
1029
 
        tree.add([''], [b'TREE_ROOT'])
 
1000
        tree.add([''], ['TREE_ROOT'])
1030
1001
        # Revisions themselves do not require anything about revision property
1031
1002
        # keys, other than that they are a basestring, and do not contain
1032
1003
        # whitespace.
1033
1004
        # However, Testaments assert than they are str(), and thus should not
1034
1005
        # be Unicode.
1035
 
        tree.commit('One', rev_id=b'rev1',
1036
 
                    revprops={u'omega': u'\u03a9', u'alpha': u'\u03b1'})
 
1006
        tree.commit('One', rev_id='rev1',
 
1007
                    revprops={'omega':u'\u03a9', 'alpha':u'\u03b1'})
1037
1008
        self.b1 = tree.branch
1038
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
1009
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1039
1010
        bundle = read_bundle(bundle_sio)
1040
1011
        revision_info = bundle.revisions[0]
1041
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
1012
        self.assertEqual('rev1', revision_info.revision_id)
1042
1013
        rev = revision_info.as_revision()
1043
 
        self.assertEqual({'branch-nick': 'tree', 'omega': u'\u03a9',
1044
 
                          'alpha': u'\u03b1'}, rev.properties)
 
1014
        self.assertEqual({'branch-nick':'tree', 'omega':u'\u03a9',
 
1015
                          'alpha':u'\u03b1'}, rev.properties)
1045
1016
 
1046
1017
    def test_bundle_with_ghosts(self):
1047
1018
        tree = self.make_branch_and_tree('tree')
1048
1019
        self.b1 = tree.branch
1049
 
        self.build_tree_contents([('tree/file', b'content1')])
 
1020
        self.build_tree_contents([('tree/file', 'content1')])
1050
1021
        tree.add(['file'])
1051
1022
        tree.commit('rev1')
1052
 
        self.build_tree_contents([('tree/file', b'content2')])
1053
 
        tree.add_parent_tree_id(b'ghost')
1054
 
        tree.commit('rev2', rev_id=b'rev2')
1055
 
        bundle = self.get_valid_bundle(b'null:', b'rev2')
 
1023
        self.build_tree_contents([('tree/file', 'content2')])
 
1024
        tree.add_parent_tree_id('ghost')
 
1025
        tree.commit('rev2', rev_id='rev2')
 
1026
        bundle = self.get_valid_bundle('null:', 'rev2')
1056
1027
 
1057
1028
    def make_simple_tree(self, format=None):
1058
1029
        tree = self.make_branch_and_tree('b1', format=format)
1063
1034
 
1064
1035
    def test_across_serializers(self):
1065
1036
        tree = self.make_simple_tree('knit')
1066
 
        tree.commit('hello', rev_id=b'rev1')
1067
 
        tree.commit('hello', rev_id=b'rev2')
1068
 
        bundle = read_bundle(self.create_bundle_text(b'null:', b'rev2')[0])
 
1037
        tree.commit('hello', rev_id='rev1')
 
1038
        tree.commit('hello', rev_id='rev2')
 
1039
        bundle = read_bundle(self.create_bundle_text('null:', 'rev2')[0])
1069
1040
        repo = self.make_repository('repo', format='dirstate-with-subtree')
1070
1041
        bundle.install_revisions(repo)
1071
 
        inv_text = repo._get_inventory_xml(b'rev2')
1072
 
        self.assertNotContainsRe(inv_text, b'format="5"')
1073
 
        self.assertContainsRe(inv_text, b'format="7"')
 
1042
        inv_text = repo._get_inventory_xml('rev2')
 
1043
        self.assertNotContainsRe(inv_text, 'format="5"')
 
1044
        self.assertContainsRe(inv_text, 'format="7"')
1074
1045
 
1075
1046
    def make_repo_with_installed_revisions(self):
1076
1047
        tree = self.make_simple_tree('knit')
1077
 
        tree.commit('hello', rev_id=b'rev1')
1078
 
        tree.commit('hello', rev_id=b'rev2')
1079
 
        bundle = read_bundle(self.create_bundle_text(b'null:', b'rev2')[0])
 
1048
        tree.commit('hello', rev_id='rev1')
 
1049
        tree.commit('hello', rev_id='rev2')
 
1050
        bundle = read_bundle(self.create_bundle_text('null:', 'rev2')[0])
1080
1051
        repo = self.make_repository('repo', format='dirstate-with-subtree')
1081
1052
        bundle.install_revisions(repo)
1082
1053
        return repo
1083
1054
 
1084
1055
    def test_across_models(self):
1085
1056
        repo = self.make_repo_with_installed_revisions()
1086
 
        inv = repo.get_inventory(b'rev2')
1087
 
        self.assertEqual(b'rev2', inv.root.revision)
 
1057
        inv = repo.get_inventory('rev2')
 
1058
        self.assertEqual('rev2', inv.root.revision)
1088
1059
        root_id = inv.root.file_id
1089
1060
        repo.lock_read()
1090
1061
        self.addCleanup(repo.unlock)
1091
 
        self.assertEqual({(root_id, b'rev1'): (),
1092
 
                          (root_id, b'rev2'): ((root_id, b'rev1'),)},
1093
 
                         repo.texts.get_parent_map([(root_id, b'rev1'), (root_id, b'rev2')]))
 
1062
        self.assertEqual({(root_id, 'rev1'):(),
 
1063
            (root_id, 'rev2'):((root_id, 'rev1'),)},
 
1064
            repo.texts.get_parent_map([(root_id, 'rev1'), (root_id, 'rev2')]))
1094
1065
 
1095
1066
    def test_inv_hash_across_serializers(self):
1096
1067
        repo = self.make_repo_with_installed_revisions()
1097
 
        recorded_inv_sha1 = repo.get_revision(b'rev2').inventory_sha1
1098
 
        xml = repo._get_inventory_xml(b'rev2')
 
1068
        recorded_inv_sha1 = repo.get_revision('rev2').inventory_sha1
 
1069
        xml = repo._get_inventory_xml('rev2')
1099
1070
        self.assertEqual(osutils.sha_string(xml), recorded_inv_sha1)
1100
1071
 
1101
1072
    def test_across_models_incompatible(self):
1102
1073
        tree = self.make_simple_tree('dirstate-with-subtree')
1103
 
        tree.commit('hello', rev_id=b'rev1')
1104
 
        tree.commit('hello', rev_id=b'rev2')
 
1074
        tree.commit('hello', rev_id='rev1')
 
1075
        tree.commit('hello', rev_id='rev2')
1105
1076
        try:
1106
 
            bundle = read_bundle(self.create_bundle_text(b'null:', b'rev1')[0])
 
1077
            bundle = read_bundle(self.create_bundle_text('null:', 'rev1')[0])
1107
1078
        except errors.IncompatibleBundleFormat:
1108
1079
            raise tests.TestSkipped("Format 0.8 doesn't work with knit3")
1109
1080
        repo = self.make_repository('repo', format='knit')
1110
1081
        bundle.install_revisions(repo)
1111
1082
 
1112
 
        bundle = read_bundle(self.create_bundle_text(b'null:', b'rev2')[0])
 
1083
        bundle = read_bundle(self.create_bundle_text('null:', 'rev2')[0])
1113
1084
        self.assertRaises(errors.IncompatibleRevision,
1114
1085
                          bundle.install_revisions, repo)
1115
1086
 
1116
1087
    def test_get_merge_request(self):
1117
1088
        tree = self.make_simple_tree()
1118
 
        tree.commit('hello', rev_id=b'rev1')
1119
 
        tree.commit('hello', rev_id=b'rev2')
1120
 
        bundle = read_bundle(self.create_bundle_text(b'null:', b'rev1')[0])
 
1089
        tree.commit('hello', rev_id='rev1')
 
1090
        tree.commit('hello', rev_id='rev2')
 
1091
        bundle = read_bundle(self.create_bundle_text('null:', 'rev1')[0])
1121
1092
        result = bundle.get_merge_request(tree.branch.repository)
1122
 
        self.assertEqual((None, b'rev1', 'inapplicable'), result)
 
1093
        self.assertEqual((None, 'rev1', 'inapplicable'), result)
1123
1094
 
1124
1095
    def test_with_subtree(self):
1125
1096
        tree = self.make_branch_and_tree('tree',
1128
1099
        subtree = self.make_branch_and_tree('tree/subtree',
1129
1100
                                            format='dirstate-with-subtree')
1130
1101
        tree.add('subtree')
1131
 
        tree.commit('hello', rev_id=b'rev1')
 
1102
        tree.commit('hello', rev_id='rev1')
1132
1103
        try:
1133
 
            bundle = read_bundle(self.create_bundle_text(b'null:', b'rev1')[0])
 
1104
            bundle = read_bundle(self.create_bundle_text('null:', 'rev1')[0])
1134
1105
        except errors.IncompatibleBundleFormat:
1135
1106
            raise tests.TestSkipped("Format 0.8 doesn't work with knit3")
1136
1107
        if isinstance(bundle, v09.BundleInfo09):
1145
1116
        self.tree1 = self.make_branch_and_tree('tree')
1146
1117
        self.b1 = self.tree1.branch
1147
1118
        try:
1148
 
            self.tree1.commit('Revision/id/with/slashes', rev_id=b'rev/id')
 
1119
            self.tree1.commit('Revision/id/with/slashes', rev_id='rev/id')
1149
1120
        except ValueError:
1150
1121
            raise tests.TestSkipped(
1151
1122
                "Repository doesn't support revision ids with slashes")
1152
 
        bundle = self.get_valid_bundle(b'null:', b'rev/id')
 
1123
        bundle = self.get_valid_bundle('null:', 'rev/id')
1153
1124
 
1154
1125
    def test_skip_file(self):
1155
1126
        """Make sure we don't accidentally write to the wrong versionedfile"""
1156
1127
        self.tree1 = self.make_branch_and_tree('tree')
1157
1128
        self.b1 = self.tree1.branch
1158
1129
        # rev1 is not present in bundle, done by fetch
1159
 
        self.build_tree_contents([('tree/file2', b'contents1')])
1160
 
        self.tree1.add('file2', b'file2-id')
1161
 
        self.tree1.commit('rev1', rev_id=b'reva')
1162
 
        self.build_tree_contents([('tree/file3', b'contents2')])
 
1130
        self.build_tree_contents([('tree/file2', 'contents1')])
 
1131
        self.tree1.add('file2', 'file2-id')
 
1132
        self.tree1.commit('rev1', rev_id='reva')
 
1133
        self.build_tree_contents([('tree/file3', 'contents2')])
1163
1134
        # rev2 is present in bundle, and done by fetch
1164
1135
        # having file1 in the bunle causes file1's versionedfile to be opened.
1165
 
        self.tree1.add('file3', b'file3-id')
1166
 
        rev2 = self.tree1.commit('rev2')
 
1136
        self.tree1.add('file3', 'file3-id')
 
1137
        self.tree1.commit('rev2')
1167
1138
        # Updating file2 should not cause an attempt to add to file1's vf
1168
 
        target = self.tree1.controldir.sprout('target').open_workingtree()
1169
 
        self.build_tree_contents([('tree/file2', b'contents3')])
1170
 
        self.tree1.commit('rev3', rev_id=b'rev3')
1171
 
        bundle = self.get_valid_bundle(b'reva', b'rev3')
 
1139
        target = self.tree1.bzrdir.sprout('target').open_workingtree()
 
1140
        self.build_tree_contents([('tree/file2', 'contents3')])
 
1141
        self.tree1.commit('rev3', rev_id='rev3')
 
1142
        bundle = self.get_valid_bundle('reva', 'rev3')
1172
1143
        if getattr(bundle, 'get_bundle_reader', None) is None:
1173
1144
            raise tests.TestSkipped('Bundle format cannot provide reader')
1174
 
        file_ids = set(
1175
 
            (f, r) for b, m, k, r, f in bundle.get_bundle_reader().iter_records()
1176
 
            if f is not None)
1177
 
        self.assertEqual(
1178
 
            {(b'file2-id', b'rev3'), (b'file3-id', rev2)}, file_ids)
 
1145
        # be sure that file1 comes before file2
 
1146
        for b, m, k, r, f in bundle.get_bundle_reader().iter_records():
 
1147
            if f == 'file3-id':
 
1148
                break
 
1149
            self.assertNotEqual(f, 'file2-id')
1179
1150
        bundle.install_revisions(target.branch.repository)
1180
1151
 
1181
1152
 
1188
1159
        tree = self.make_branch_and_memory_tree('tree')
1189
1160
        tree.lock_write()
1190
1161
        self.addCleanup(tree.unlock)
1191
 
        tree.add([''], [b'TREE_ROOT'])
1192
 
        tree.commit('One', revprops={u'one': 'two',
1193
 
                                     u'empty': ''}, rev_id=b'rev1')
 
1162
        tree.add([''], ['TREE_ROOT'])
 
1163
        tree.commit('One', revprops={'one':'two', 'empty':''}, rev_id='rev1')
1194
1164
        self.b1 = tree.branch
1195
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
1165
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1196
1166
        self.assertContainsRe(bundle_sio.getvalue(),
1197
 
                              b'# properties:\n'
1198
 
                              b'#   branch-nick: tree\n'
1199
 
                              b'#   empty: \n'
1200
 
                              b'#   one: two\n'
1201
 
                              )
 
1167
                              '# properties:\n'
 
1168
                              '#   branch-nick: tree\n'
 
1169
                              '#   empty: \n'
 
1170
                              '#   one: two\n'
 
1171
                             )
1202
1172
        bundle = read_bundle(bundle_sio)
1203
1173
        revision_info = bundle.revisions[0]
1204
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
1174
        self.assertEqual('rev1', revision_info.revision_id)
1205
1175
        rev = revision_info.as_revision()
1206
 
        self.assertEqual({'branch-nick': 'tree', 'empty': '', 'one': 'two'},
 
1176
        self.assertEqual({'branch-nick':'tree', 'empty':'', 'one':'two'},
1207
1177
                         rev.properties)
1208
1178
 
1209
1179
    def get_bundle_tree(self, bundle, revision_id):
1210
1180
        repository = self.make_repository('repo')
1211
 
        return bundle.revision_tree(repository, b'revid1')
 
1181
        return bundle.revision_tree(repository, 'revid1')
1212
1182
 
1213
1183
    def test_bundle_empty_property_alt(self):
1214
1184
        """Test serializing revision properties with an empty value.
1221
1191
        tree = self.make_branch_and_memory_tree('tree')
1222
1192
        tree.lock_write()
1223
1193
        self.addCleanup(tree.unlock)
1224
 
        tree.add([''], [b'TREE_ROOT'])
1225
 
        tree.commit('One', revprops={u'one': 'two',
1226
 
                                     u'empty': ''}, rev_id=b'rev1')
 
1194
        tree.add([''], ['TREE_ROOT'])
 
1195
        tree.commit('One', revprops={'one':'two', 'empty':''}, rev_id='rev1')
1227
1196
        self.b1 = tree.branch
1228
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
1197
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1229
1198
        txt = bundle_sio.getvalue()
1230
 
        loc = txt.find(b'#   empty: ') + len(b'#   empty:')
 
1199
        loc = txt.find('#   empty: ') + len('#   empty:')
1231
1200
        # Create a new bundle, which strips the trailing space after empty
1232
 
        bundle_sio = BytesIO(txt[:loc] + txt[loc + 1:])
 
1201
        bundle_sio = StringIO(txt[:loc] + txt[loc+1:])
1233
1202
 
1234
1203
        self.assertContainsRe(bundle_sio.getvalue(),
1235
 
                              b'# properties:\n'
1236
 
                              b'#   branch-nick: tree\n'
1237
 
                              b'#   empty:\n'
1238
 
                              b'#   one: two\n'
1239
 
                              )
 
1204
                              '# properties:\n'
 
1205
                              '#   branch-nick: tree\n'
 
1206
                              '#   empty:\n'
 
1207
                              '#   one: two\n'
 
1208
                             )
1240
1209
        bundle = read_bundle(bundle_sio)
1241
1210
        revision_info = bundle.revisions[0]
1242
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
1211
        self.assertEqual('rev1', revision_info.revision_id)
1243
1212
        rev = revision_info.as_revision()
1244
 
        self.assertEqual({'branch-nick': 'tree', 'empty': '', 'one': 'two'},
 
1213
        self.assertEqual({'branch-nick':'tree', 'empty':'', 'one':'two'},
1245
1214
                         rev.properties)
1246
1215
 
1247
1216
    def test_bundle_sorted_properties(self):
1250
1219
        tree.lock_write()
1251
1220
        self.addCleanup(tree.unlock)
1252
1221
 
1253
 
        tree.add([''], [b'TREE_ROOT'])
1254
 
        tree.commit('One', rev_id=b'rev1',
1255
 
                    revprops={u'a': '4', u'b': '3', u'c': '2', u'd': '1'})
 
1222
        tree.add([''], ['TREE_ROOT'])
 
1223
        tree.commit('One', rev_id='rev1',
 
1224
                    revprops={'a':'4', 'b':'3', 'c':'2', 'd':'1'})
1256
1225
        self.b1 = tree.branch
1257
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
1226
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1258
1227
        self.assertContainsRe(bundle_sio.getvalue(),
1259
 
                              b'# properties:\n'
1260
 
                              b'#   a: 4\n'
1261
 
                              b'#   b: 3\n'
1262
 
                              b'#   branch-nick: tree\n'
1263
 
                              b'#   c: 2\n'
1264
 
                              b'#   d: 1\n'
1265
 
                              )
 
1228
                              '# properties:\n'
 
1229
                              '#   a: 4\n'
 
1230
                              '#   b: 3\n'
 
1231
                              '#   branch-nick: tree\n'
 
1232
                              '#   c: 2\n'
 
1233
                              '#   d: 1\n'
 
1234
                             )
1266
1235
        bundle = read_bundle(bundle_sio)
1267
1236
        revision_info = bundle.revisions[0]
1268
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
1237
        self.assertEqual('rev1', revision_info.revision_id)
1269
1238
        rev = revision_info.as_revision()
1270
 
        self.assertEqual({'branch-nick': 'tree', 'a': '4', 'b': '3', 'c': '2',
1271
 
                          'd': '1'}, rev.properties)
 
1239
        self.assertEqual({'branch-nick':'tree', 'a':'4', 'b':'3', 'c':'2',
 
1240
                          'd':'1'}, rev.properties)
1272
1241
 
1273
1242
    def test_bundle_unicode_properties(self):
1274
1243
        """We should be able to round trip a non-ascii property."""
1276
1245
        tree.lock_write()
1277
1246
        self.addCleanup(tree.unlock)
1278
1247
 
1279
 
        tree.add([''], [b'TREE_ROOT'])
 
1248
        tree.add([''], ['TREE_ROOT'])
1280
1249
        # Revisions themselves do not require anything about revision property
1281
1250
        # keys, other than that they are a basestring, and do not contain
1282
1251
        # whitespace.
1283
1252
        # However, Testaments assert than they are str(), and thus should not
1284
1253
        # be Unicode.
1285
 
        tree.commit('One', rev_id=b'rev1',
1286
 
                    revprops={u'omega': u'\u03a9', u'alpha': u'\u03b1'})
 
1254
        tree.commit('One', rev_id='rev1',
 
1255
                    revprops={'omega':u'\u03a9', 'alpha':u'\u03b1'})
1287
1256
        self.b1 = tree.branch
1288
 
        bundle_sio, revision_ids = self.create_bundle_text(b'null:', b'rev1')
 
1257
        bundle_sio, revision_ids = self.create_bundle_text('null:', 'rev1')
1289
1258
        self.assertContainsRe(bundle_sio.getvalue(),
1290
 
                              b'# properties:\n'
1291
 
                              b'#   alpha: \xce\xb1\n'
1292
 
                              b'#   branch-nick: tree\n'
1293
 
                              b'#   omega: \xce\xa9\n'
1294
 
                              )
 
1259
                              '# properties:\n'
 
1260
                              '#   alpha: \xce\xb1\n'
 
1261
                              '#   branch-nick: tree\n'
 
1262
                              '#   omega: \xce\xa9\n'
 
1263
                             )
1295
1264
        bundle = read_bundle(bundle_sio)
1296
1265
        revision_info = bundle.revisions[0]
1297
 
        self.assertEqual(b'rev1', revision_info.revision_id)
 
1266
        self.assertEqual('rev1', revision_info.revision_id)
1298
1267
        rev = revision_info.as_revision()
1299
 
        self.assertEqual({'branch-nick': 'tree', 'omega': u'\u03a9',
1300
 
                          'alpha': u'\u03b1'}, rev.properties)
 
1268
        self.assertEqual({'branch-nick':'tree', 'omega':u'\u03a9',
 
1269
                          'alpha':u'\u03b1'}, rev.properties)
1301
1270
 
1302
1271
 
1303
1272
class V09BundleKnit2Tester(V08BundleTester):
1350
1319
            self.assertEqual(len(branch_rev.parent_ids),
1351
1320
                             len(bundle_rev.parent_ids))
1352
1321
        self.assertEqual(set(rev_ids),
1353
 
                         {r.revision_id for r in bundle.real_revisions})
 
1322
                         set([r.revision_id for r in bundle.real_revisions]))
1354
1323
        self.valid_apply_bundle(base_rev_id, bundle,
1355
 
                                checkout_dir=checkout_dir)
 
1324
                                   checkout_dir=checkout_dir)
1356
1325
 
1357
1326
        return bundle
1358
1327
 
1362
1331
 
1363
1332
        :return: The in-memory bundle
1364
1333
        """
1365
 
        from ..bundle import serializer
 
1334
        from bzrlib.bundle import serializer
1366
1335
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
1367
 
        new_text = self.get_raw(BytesIO(b''.join(bundle_txt)))
1368
 
        new_text = new_text.replace(b'<file file_id="exe-1"',
1369
 
                                    b'<file executable="y" file_id="exe-1"')
1370
 
        new_text = new_text.replace(b'B260', b'B275')
1371
 
        bundle_txt = BytesIO()
 
1336
        new_text = self.get_raw(StringIO(''.join(bundle_txt)))
 
1337
        new_text = new_text.replace('<file file_id="exe-1"',
 
1338
                                    '<file executable="y" file_id="exe-1"')
 
1339
        new_text = new_text.replace('B260', 'B275')
 
1340
        bundle_txt = StringIO()
1372
1341
        bundle_txt.write(serializer._get_bundle_header('4'))
1373
 
        bundle_txt.write(b'\n')
1374
 
        bundle_txt.write(bz2.compress(new_text))
 
1342
        bundle_txt.write('\n')
 
1343
        bundle_txt.write(new_text.encode('bz2'))
1375
1344
        bundle_txt.seek(0)
1376
1345
        bundle = read_bundle(bundle_txt)
1377
1346
        self.valid_apply_bundle(base_rev_id, bundle)
1378
1347
        return bundle
1379
1348
 
1380
1349
    def create_bundle_text(self, base_rev_id, rev_id):
1381
 
        bundle_txt = BytesIO()
 
1350
        bundle_txt = StringIO()
1382
1351
        rev_ids = write_bundle(self.b1.repository, rev_id, base_rev_id,
1383
1352
                               bundle_txt, format=self.format)
1384
1353
        bundle_txt.seek(0)
1385
1354
        self.assertEqual(bundle_txt.readline(),
1386
 
                         b'# Bazaar revision bundle v%s\n' % self.format.encode('ascii'))
1387
 
        self.assertEqual(bundle_txt.readline(), b'#\n')
 
1355
                         '# Bazaar revision bundle v%s\n' % self.format)
 
1356
        self.assertEqual(bundle_txt.readline(), '#\n')
1388
1357
        rev = self.b1.repository.get_revision(rev_id)
1389
1358
        bundle_txt.seek(0)
1390
1359
        return bundle_txt, rev_ids
1396
1365
 
1397
1366
    def test_creation(self):
1398
1367
        tree = self.make_branch_and_tree('tree')
1399
 
        self.build_tree_contents([('tree/file', b'contents1\nstatic\n')])
1400
 
        tree.add('file', b'fileid-2')
1401
 
        tree.commit('added file', rev_id=b'rev1')
1402
 
        self.build_tree_contents([('tree/file', b'contents2\nstatic\n')])
1403
 
        tree.commit('changed file', rev_id=b'rev2')
1404
 
        s = BytesIO()
 
1368
        self.build_tree_contents([('tree/file', 'contents1\nstatic\n')])
 
1369
        tree.add('file', 'fileid-2')
 
1370
        tree.commit('added file', rev_id='rev1')
 
1371
        self.build_tree_contents([('tree/file', 'contents2\nstatic\n')])
 
1372
        tree.commit('changed file', rev_id='rev2')
 
1373
        s = StringIO()
1405
1374
        serializer = BundleSerializerV4('1.0')
1406
 
        with tree.lock_read():
1407
 
            serializer.write_bundle(
1408
 
                tree.branch.repository, b'rev2', b'null:', s)
 
1375
        serializer.write(tree.branch.repository, ['rev1', 'rev2'], {}, s)
1409
1376
        s.seek(0)
1410
1377
        tree2 = self.make_branch_and_tree('target')
1411
1378
        target_repo = tree2.branch.repository
1413
1380
        target_repo.lock_read()
1414
1381
        self.addCleanup(target_repo.unlock)
1415
1382
        # Turn the 'iterators_of_bytes' back into simple strings for comparison
1416
 
        repo_texts = dict((i, b''.join(content)) for i, content
 
1383
        repo_texts = dict((i, ''.join(content)) for i, content
1417
1384
                          in target_repo.iter_files_bytes(
1418
 
            [(b'fileid-2', b'rev1', '1'),
1419
 
             (b'fileid-2', b'rev2', '2')]))
1420
 
        self.assertEqual({'1': b'contents1\nstatic\n',
1421
 
                          '2': b'contents2\nstatic\n'},
 
1385
                                [('fileid-2', 'rev1', '1'),
 
1386
                                 ('fileid-2', 'rev2', '2')]))
 
1387
        self.assertEqual({'1':'contents1\nstatic\n',
 
1388
                          '2':'contents2\nstatic\n'},
1422
1389
                         repo_texts)
1423
 
        rtree = target_repo.revision_tree(b'rev2')
 
1390
        rtree = target_repo.revision_tree('rev2')
1424
1391
        inventory_vf = target_repo.inventories
1425
1392
        # If the inventory store has a graph, it must match the revision graph.
1426
1393
        self.assertSubset(
1427
 
            [inventory_vf.get_parent_map([(b'rev2',)])[(b'rev2',)]],
1428
 
            [None, ((b'rev1',),)])
 
1394
            [inventory_vf.get_parent_map([('rev2',)])[('rev2',)]],
 
1395
            [None, (('rev1',),)])
1429
1396
        self.assertEqual('changed file',
1430
 
                         target_repo.get_revision(b'rev2').message)
 
1397
                         target_repo.get_revision('rev2').message)
1431
1398
 
1432
1399
    @staticmethod
1433
1400
    def get_raw(bundle_file):
1435
1402
        line = bundle_file.readline()
1436
1403
        line = bundle_file.readline()
1437
1404
        lines = bundle_file.readlines()
1438
 
        return bz2.decompress(b''.join(lines))
 
1405
        return ''.join(lines).decode('bz2')
1439
1406
 
1440
1407
    def test_copy_signatures(self):
1441
1408
        tree_a = self.make_branch_and_tree('tree_a')
1442
 
        import breezy.gpg
1443
 
        import breezy.commit as commit
1444
 
        oldstrategy = breezy.gpg.GPGStrategy
 
1409
        import bzrlib.gpg
 
1410
        import bzrlib.commit as commit
 
1411
        oldstrategy = bzrlib.gpg.GPGStrategy
1445
1412
        branch = tree_a.branch
1446
1413
        repo_a = branch.repository
1447
 
        tree_a.commit("base", allow_pointless=True, rev_id=b'A')
1448
 
        self.assertFalse(branch.repository.has_signature_for_revision_id(b'A'))
 
1414
        tree_a.commit("base", allow_pointless=True, rev_id='A')
 
1415
        self.failIf(branch.repository.has_signature_for_revision_id('A'))
1449
1416
        try:
1450
 
            from ..testament import Testament
 
1417
            from bzrlib.testament import Testament
1451
1418
            # monkey patch gpg signing mechanism
1452
 
            breezy.gpg.GPGStrategy = breezy.gpg.LoopbackGPGStrategy
1453
 
            new_config = test_commit.MustSignConfig()
1454
 
            commit.Commit(config_stack=new_config).commit(message="base",
1455
 
                                                          allow_pointless=True,
1456
 
                                                          rev_id=b'B',
1457
 
                                                          working_tree=tree_a)
1458
 
 
 
1419
            bzrlib.gpg.GPGStrategy = bzrlib.gpg.LoopbackGPGStrategy
 
1420
            new_config = test_commit.MustSignConfig(branch)
 
1421
            commit.Commit(config=new_config).commit(message="base",
 
1422
                                                    allow_pointless=True,
 
1423
                                                    rev_id='B',
 
1424
                                                    working_tree=tree_a)
1459
1425
            def sign(text):
1460
 
                return breezy.gpg.LoopbackGPGStrategy(None).sign(text)
1461
 
            self.assertTrue(repo_a.has_signature_for_revision_id(b'B'))
 
1426
                return bzrlib.gpg.LoopbackGPGStrategy(None).sign(text)
 
1427
            self.assertTrue(repo_a.has_signature_for_revision_id('B'))
1462
1428
        finally:
1463
 
            breezy.gpg.GPGStrategy = oldstrategy
 
1429
            bzrlib.gpg.GPGStrategy = oldstrategy
1464
1430
        tree_b = self.make_branch_and_tree('tree_b')
1465
1431
        repo_b = tree_b.branch.repository
1466
 
        s = BytesIO()
 
1432
        s = StringIO()
1467
1433
        serializer = BundleSerializerV4('4')
1468
 
        with tree_a.lock_read():
1469
 
            serializer.write_bundle(
1470
 
                tree_a.branch.repository, b'B', b'null:', s)
 
1434
        serializer.write(tree_a.branch.repository, ['A', 'B'], {}, s)
1471
1435
        s.seek(0)
1472
1436
        install_bundle(repo_b, serializer.read(s))
1473
 
        self.assertTrue(repo_b.has_signature_for_revision_id(b'B'))
1474
 
        self.assertEqual(repo_b.get_signature_text(b'B'),
1475
 
                         repo_a.get_signature_text(b'B'))
 
1437
        self.assertTrue(repo_b.has_signature_for_revision_id('B'))
 
1438
        self.assertEqual(repo_b.get_signature_text('B'),
 
1439
                         repo_a.get_signature_text('B'))
1476
1440
        s.seek(0)
1477
1441
        # ensure repeat installs are harmless
1478
1442
        install_bundle(repo_b, serializer.read(s))
1479
1443
 
1480
1444
 
 
1445
class V4WeaveBundleTester(V4BundleTester):
 
1446
 
 
1447
    def bzrdir_format(self):
 
1448
        return 'metaweave'
 
1449
 
 
1450
 
1481
1451
class V4_2aBundleTester(V4BundleTester):
1482
1452
 
1483
1453
    def bzrdir_format(self):
1489
1459
 
1490
1460
        :return: The in-memory bundle
1491
1461
        """
1492
 
        from ..bundle import serializer
 
1462
        from bzrlib.bundle import serializer
1493
1463
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
1494
 
        new_text = self.get_raw(BytesIO(b''.join(bundle_txt)))
 
1464
        new_text = self.get_raw(StringIO(''.join(bundle_txt)))
1495
1465
        # We are going to be replacing some text to set the executable bit on a
1496
1466
        # file. Make sure the text replacement actually works correctly.
1497
 
        self.assertContainsRe(new_text, b'(?m)B244\n\ni 1\n<inventory')
1498
 
        new_text = new_text.replace(b'<file file_id="exe-1"',
1499
 
                                    b'<file executable="y" file_id="exe-1"')
1500
 
        new_text = new_text.replace(b'B244', b'B259')
1501
 
        bundle_txt = BytesIO()
 
1467
        self.assertContainsRe(new_text, '(?m)B244\n\ni 1\n<inventory')
 
1468
        new_text = new_text.replace('<file file_id="exe-1"',
 
1469
                                    '<file executable="y" file_id="exe-1"')
 
1470
        new_text = new_text.replace('B244', 'B259')
 
1471
        bundle_txt = StringIO()
1502
1472
        bundle_txt.write(serializer._get_bundle_header('4'))
1503
 
        bundle_txt.write(b'\n')
1504
 
        bundle_txt.write(bz2.compress(new_text))
 
1473
        bundle_txt.write('\n')
 
1474
        bundle_txt.write(new_text.encode('bz2'))
1505
1475
        bundle_txt.seek(0)
1506
1476
        bundle = read_bundle(bundle_txt)
1507
1477
        self.valid_apply_bundle(base_rev_id, bundle)
1510
1480
    def make_merged_branch(self):
1511
1481
        builder = self.make_branch_builder('source')
1512
1482
        builder.start_series()
1513
 
        builder.build_snapshot(None, [
1514
 
            ('add', ('', b'root-id', 'directory', None)),
1515
 
            ('add', ('file', b'file-id', 'file', b'original content\n')),
1516
 
            ], revision_id=b'a@cset-0-1')
1517
 
        builder.build_snapshot([b'a@cset-0-1'], [
1518
 
            ('modify', ('file', b'new-content\n')),
1519
 
            ], revision_id=b'a@cset-0-2a')
1520
 
        builder.build_snapshot([b'a@cset-0-1'], [
1521
 
            ('add', ('other-file', b'file2-id', 'file', b'file2-content\n')),
1522
 
            ], revision_id=b'a@cset-0-2b')
1523
 
        builder.build_snapshot([b'a@cset-0-2a', b'a@cset-0-2b'], [
1524
 
            ('add', ('other-file', b'file2-id', 'file', b'file2-content\n')),
1525
 
            ], revision_id=b'a@cset-0-3')
 
1483
        builder.build_snapshot('a@cset-0-1', None, [
 
1484
            ('add', ('', 'root-id', 'directory', None)),
 
1485
            ('add', ('file', 'file-id', 'file', 'original content\n')),
 
1486
            ])
 
1487
        builder.build_snapshot('a@cset-0-2a', ['a@cset-0-1'], [
 
1488
            ('modify', ('file-id', 'new-content\n')),
 
1489
            ])
 
1490
        builder.build_snapshot('a@cset-0-2b', ['a@cset-0-1'], [
 
1491
            ('add', ('other-file', 'file2-id', 'file', 'file2-content\n')),
 
1492
            ])
 
1493
        builder.build_snapshot('a@cset-0-3', ['a@cset-0-2a', 'a@cset-0-2b'], [
 
1494
            ('add', ('other-file', 'file2-id', 'file', 'file2-content\n')),
 
1495
            ])
1526
1496
        builder.finish_series()
1527
1497
        self.b1 = builder.get_branch()
1528
1498
        self.b1.lock_read()
1531
1501
    def make_bundle_just_inventories(self, base_revision_id,
1532
1502
                                     target_revision_id,
1533
1503
                                     revision_ids):
1534
 
        sio = BytesIO()
 
1504
        sio = StringIO()
1535
1505
        writer = v4.BundleWriteOperation(base_revision_id, target_revision_id,
1536
1506
                                         self.b1.repository, sio)
1537
1507
        writer.bundle.begin()
1542
1512
 
1543
1513
    def test_single_inventory_multiple_parents_as_xml(self):
1544
1514
        self.make_merged_branch()
1545
 
        sio = self.make_bundle_just_inventories(b'a@cset-0-1', b'a@cset-0-3',
1546
 
                                                [b'a@cset-0-3'])
 
1515
        sio = self.make_bundle_just_inventories('a@cset-0-1', 'a@cset-0-3',
 
1516
                                                ['a@cset-0-3'])
1547
1517
        reader = v4.BundleReader(sio, stream_input=False)
1548
1518
        records = list(reader.iter_records())
1549
1519
        self.assertEqual(1, len(records))
1550
1520
        (bytes, metadata, repo_kind, revision_id,
1551
1521
         file_id) = records[0]
1552
1522
        self.assertIs(None, file_id)
1553
 
        self.assertEqual(b'a@cset-0-3', revision_id)
 
1523
        self.assertEqual('a@cset-0-3', revision_id)
1554
1524
        self.assertEqual('inventory', repo_kind)
1555
 
        self.assertEqual({b'parents': [b'a@cset-0-2a', b'a@cset-0-2b'],
1556
 
                          b'sha1': b'09c53b0c4de0895e11a2aacc34fef60a6e70865c',
1557
 
                          b'storage_kind': b'mpdiff',
1558
 
                          }, metadata)
 
1525
        self.assertEqual({'parents': ['a@cset-0-2a', 'a@cset-0-2b'],
 
1526
                          'sha1': '09c53b0c4de0895e11a2aacc34fef60a6e70865c',
 
1527
                          'storage_kind': 'mpdiff',
 
1528
                         }, metadata)
1559
1529
        # We should have an mpdiff that takes some lines from both parents.
1560
1530
        self.assertEqualDiff(
1561
 
            b'i 1\n'
1562
 
            b'<inventory format="10" revision_id="a@cset-0-3">\n'
1563
 
            b'\n'
1564
 
            b'c 0 1 1 2\n'
1565
 
            b'c 1 3 3 2\n', bytes)
 
1531
            'i 1\n'
 
1532
            '<inventory format="10" revision_id="a@cset-0-3">\n'
 
1533
            '\n'
 
1534
            'c 0 1 1 2\n'
 
1535
            'c 1 3 3 2\n', bytes)
1566
1536
 
1567
1537
    def test_single_inv_no_parents_as_xml(self):
1568
1538
        self.make_merged_branch()
1569
 
        sio = self.make_bundle_just_inventories(b'null:', b'a@cset-0-1',
1570
 
                                                [b'a@cset-0-1'])
 
1539
        sio = self.make_bundle_just_inventories('null:', 'a@cset-0-1',
 
1540
                                                ['a@cset-0-1'])
1571
1541
        reader = v4.BundleReader(sio, stream_input=False)
1572
1542
        records = list(reader.iter_records())
1573
1543
        self.assertEqual(1, len(records))
1574
1544
        (bytes, metadata, repo_kind, revision_id,
1575
1545
         file_id) = records[0]
1576
1546
        self.assertIs(None, file_id)
1577
 
        self.assertEqual(b'a@cset-0-1', revision_id)
 
1547
        self.assertEqual('a@cset-0-1', revision_id)
1578
1548
        self.assertEqual('inventory', repo_kind)
1579
 
        self.assertEqual({b'parents': [],
1580
 
                          b'sha1': b'a13f42b142d544aac9b085c42595d304150e31a2',
1581
 
                          b'storage_kind': b'mpdiff',
1582
 
                          }, metadata)
 
1549
        self.assertEqual({'parents': [],
 
1550
                          'sha1': 'a13f42b142d544aac9b085c42595d304150e31a2',
 
1551
                          'storage_kind': 'mpdiff',
 
1552
                         }, metadata)
1583
1553
        # We should have an mpdiff that takes some lines from both parents.
1584
1554
        self.assertEqualDiff(
1585
 
            b'i 4\n'
1586
 
            b'<inventory format="10" revision_id="a@cset-0-1">\n'
1587
 
            b'<directory file_id="root-id" name=""'
1588
 
            b' revision="a@cset-0-1" />\n'
1589
 
            b'<file file_id="file-id" name="file" parent_id="root-id"'
1590
 
            b' revision="a@cset-0-1"'
1591
 
            b' text_sha1="09c2f8647e14e49e922b955c194102070597c2d1"'
1592
 
            b' text_size="17" />\n'
1593
 
            b'</inventory>\n'
1594
 
            b'\n', bytes)
 
1555
            'i 4\n'
 
1556
            '<inventory format="10" revision_id="a@cset-0-1">\n'
 
1557
            '<directory file_id="root-id" name=""'
 
1558
                ' revision="a@cset-0-1" />\n'
 
1559
            '<file file_id="file-id" name="file" parent_id="root-id"'
 
1560
                ' revision="a@cset-0-1"'
 
1561
                ' text_sha1="09c2f8647e14e49e922b955c194102070597c2d1"'
 
1562
                ' text_size="17" />\n'
 
1563
            '</inventory>\n'
 
1564
            '\n', bytes)
1595
1565
 
1596
1566
    def test_multiple_inventories_as_xml(self):
1597
1567
        self.make_merged_branch()
1598
 
        sio = self.make_bundle_just_inventories(b'a@cset-0-1', b'a@cset-0-3',
1599
 
                                                [b'a@cset-0-2a', b'a@cset-0-2b', b'a@cset-0-3'])
 
1568
        sio = self.make_bundle_just_inventories('a@cset-0-1', 'a@cset-0-3',
 
1569
            ['a@cset-0-2a', 'a@cset-0-2b', 'a@cset-0-3'])
1600
1570
        reader = v4.BundleReader(sio, stream_input=False)
1601
1571
        records = list(reader.iter_records())
1602
1572
        self.assertEqual(3, len(records))
1603
1573
        revision_ids = [rev_id for b, m, k, rev_id, f in records]
1604
 
        self.assertEqual([b'a@cset-0-2a', b'a@cset-0-2b', b'a@cset-0-3'],
 
1574
        self.assertEqual(['a@cset-0-2a', 'a@cset-0-2b', 'a@cset-0-3'],
1605
1575
                         revision_ids)
1606
1576
        metadata_2a = records[0][1]
1607
 
        self.assertEqual({b'parents': [b'a@cset-0-1'],
1608
 
                          b'sha1': b'1e105886d62d510763e22885eec733b66f5f09bf',
1609
 
                          b'storage_kind': b'mpdiff',
1610
 
                          }, metadata_2a)
 
1577
        self.assertEqual({'parents': ['a@cset-0-1'],
 
1578
                          'sha1': '1e105886d62d510763e22885eec733b66f5f09bf',
 
1579
                          'storage_kind': 'mpdiff',
 
1580
                         }, metadata_2a)
1611
1581
        metadata_2b = records[1][1]
1612
 
        self.assertEqual({b'parents': [b'a@cset-0-1'],
1613
 
                          b'sha1': b'f03f12574bdb5ed2204c28636c98a8547544ccd8',
1614
 
                          b'storage_kind': b'mpdiff',
1615
 
                          }, metadata_2b)
 
1582
        self.assertEqual({'parents': ['a@cset-0-1'],
 
1583
                          'sha1': 'f03f12574bdb5ed2204c28636c98a8547544ccd8',
 
1584
                          'storage_kind': 'mpdiff',
 
1585
                         }, metadata_2b)
1616
1586
        metadata_3 = records[2][1]
1617
 
        self.assertEqual({b'parents': [b'a@cset-0-2a', b'a@cset-0-2b'],
1618
 
                          b'sha1': b'09c53b0c4de0895e11a2aacc34fef60a6e70865c',
1619
 
                          b'storage_kind': b'mpdiff',
1620
 
                          }, metadata_3)
 
1587
        self.assertEqual({'parents': ['a@cset-0-2a', 'a@cset-0-2b'],
 
1588
                          'sha1': '09c53b0c4de0895e11a2aacc34fef60a6e70865c',
 
1589
                          'storage_kind': 'mpdiff',
 
1590
                         }, metadata_3)
1621
1591
        bytes_2a = records[0][0]
1622
1592
        self.assertEqualDiff(
1623
 
            b'i 1\n'
1624
 
            b'<inventory format="10" revision_id="a@cset-0-2a">\n'
1625
 
            b'\n'
1626
 
            b'c 0 1 1 1\n'
1627
 
            b'i 1\n'
1628
 
            b'<file file_id="file-id" name="file" parent_id="root-id"'
1629
 
            b' revision="a@cset-0-2a"'
1630
 
            b' text_sha1="50f545ff40e57b6924b1f3174b267ffc4576e9a9"'
1631
 
            b' text_size="12" />\n'
1632
 
            b'\n'
1633
 
            b'c 0 3 3 1\n', bytes_2a)
 
1593
            'i 1\n'
 
1594
            '<inventory format="10" revision_id="a@cset-0-2a">\n'
 
1595
            '\n'
 
1596
            'c 0 1 1 1\n'
 
1597
            'i 1\n'
 
1598
            '<file file_id="file-id" name="file" parent_id="root-id"'
 
1599
                ' revision="a@cset-0-2a"'
 
1600
                ' text_sha1="50f545ff40e57b6924b1f3174b267ffc4576e9a9"'
 
1601
                ' text_size="12" />\n'
 
1602
            '\n'
 
1603
            'c 0 3 3 1\n', bytes_2a)
1634
1604
        bytes_2b = records[1][0]
1635
1605
        self.assertEqualDiff(
1636
 
            b'i 1\n'
1637
 
            b'<inventory format="10" revision_id="a@cset-0-2b">\n'
1638
 
            b'\n'
1639
 
            b'c 0 1 1 2\n'
1640
 
            b'i 1\n'
1641
 
            b'<file file_id="file2-id" name="other-file" parent_id="root-id"'
1642
 
            b' revision="a@cset-0-2b"'
1643
 
            b' text_sha1="b46c0c8ea1e5ef8e46fc8894bfd4752a88ec939e"'
1644
 
            b' text_size="14" />\n'
1645
 
            b'\n'
1646
 
            b'c 0 3 4 1\n', bytes_2b)
 
1606
            'i 1\n'
 
1607
            '<inventory format="10" revision_id="a@cset-0-2b">\n'
 
1608
            '\n'
 
1609
            'c 0 1 1 2\n'
 
1610
            'i 1\n'
 
1611
            '<file file_id="file2-id" name="other-file" parent_id="root-id"'
 
1612
                ' revision="a@cset-0-2b"'
 
1613
                ' text_sha1="b46c0c8ea1e5ef8e46fc8894bfd4752a88ec939e"'
 
1614
                ' text_size="14" />\n'
 
1615
            '\n'
 
1616
            'c 0 3 4 1\n', bytes_2b)
1647
1617
        bytes_3 = records[2][0]
1648
1618
        self.assertEqualDiff(
1649
 
            b'i 1\n'
1650
 
            b'<inventory format="10" revision_id="a@cset-0-3">\n'
1651
 
            b'\n'
1652
 
            b'c 0 1 1 2\n'
1653
 
            b'c 1 3 3 2\n', bytes_3)
 
1619
            'i 1\n'
 
1620
            '<inventory format="10" revision_id="a@cset-0-3">\n'
 
1621
            '\n'
 
1622
            'c 0 1 1 2\n'
 
1623
            'c 1 3 3 2\n', bytes_3)
1654
1624
 
1655
1625
    def test_creating_bundle_preserves_chk_pages(self):
1656
1626
        self.make_merged_branch()
1657
 
        target = self.b1.controldir.sprout('target',
1658
 
                                           revision_id=b'a@cset-0-2a').open_branch()
1659
 
        bundle_txt, rev_ids = self.create_bundle_text(b'a@cset-0-2a',
1660
 
                                                      b'a@cset-0-3')
1661
 
        self.assertEqual(set([b'a@cset-0-2b', b'a@cset-0-3']), set(rev_ids))
 
1627
        target = self.b1.bzrdir.sprout('target',
 
1628
                                       revision_id='a@cset-0-2a').open_branch()
 
1629
        bundle_txt, rev_ids = self.create_bundle_text('a@cset-0-2a',
 
1630
                                                      'a@cset-0-3')
 
1631
        self.assertEqual(['a@cset-0-2b', 'a@cset-0-3'], rev_ids)
1662
1632
        bundle = read_bundle(bundle_txt)
1663
1633
        target.lock_write()
1664
1634
        self.addCleanup(target.unlock)
1665
1635
        install_bundle(target.repository, bundle)
1666
 
        inv1 = next(self.b1.repository.inventories.get_record_stream([
1667
 
            (b'a@cset-0-3',)], 'unordered',
1668
 
            True)).get_bytes_as('fulltext')
1669
 
        inv2 = next(target.repository.inventories.get_record_stream([
1670
 
            (b'a@cset-0-3',)], 'unordered',
1671
 
            True)).get_bytes_as('fulltext')
 
1636
        inv1 = self.b1.repository.inventories.get_record_stream([
 
1637
            ('a@cset-0-3',)], 'unordered',
 
1638
            True).next().get_bytes_as('fulltext')
 
1639
        inv2 = target.repository.inventories.get_record_stream([
 
1640
            ('a@cset-0-3',)], 'unordered',
 
1641
            True).next().get_bytes_as('fulltext')
1672
1642
        self.assertEqualDiff(inv1, inv2)
1673
1643
 
1674
1644
 
1679
1649
 
1680
1650
        self.build_tree(['b1/one'])
1681
1651
        wt.add('one')
1682
 
        wt.commit('add one', rev_id=b'a@cset-0-1')
 
1652
        wt.commit('add one', rev_id='a@cset-0-1')
1683
1653
        self.build_tree(['b1/two'])
1684
1654
        wt.add('two')
1685
 
        wt.commit('add two', rev_id=b'a@cset-0-2',
1686
 
                  revprops={u'branch-nick': 'test'})
 
1655
        wt.commit('add two', rev_id='a@cset-0-2',
 
1656
                  revprops={'branch-nick':'test'})
1687
1657
 
1688
 
        bundle_txt = BytesIO()
1689
 
        rev_ids = write_bundle(wt.branch.repository, b'a@cset-0-2',
1690
 
                               b'a@cset-0-1', bundle_txt, self.format)
1691
 
        self.assertEqual({b'a@cset-0-2'}, set(rev_ids))
 
1658
        bundle_txt = StringIO()
 
1659
        rev_ids = write_bundle(wt.branch.repository, 'a@cset-0-2',
 
1660
                               'a@cset-0-1', bundle_txt, self.format)
 
1661
        self.assertEqual(set(['a@cset-0-2']), set(rev_ids))
1692
1662
        bundle_txt.seek(0, 0)
1693
1663
        return bundle_txt
1694
1664
 
1695
1665
    def check_valid(self, bundle):
1696
1666
        """Check that after whatever munging, the final object is valid."""
1697
 
        self.assertEqual([b'a@cset-0-2'],
1698
 
                         [r.revision_id for r in bundle.real_revisions])
 
1667
        self.assertEqual(['a@cset-0-2'],
 
1668
            [r.revision_id for r in bundle.real_revisions])
1699
1669
 
1700
1670
    def test_extra_whitespace(self):
1701
1671
        bundle_txt = self.build_test_bundle()
1704
1674
        # Adding one extra newline used to give us
1705
1675
        # TypeError: float() argument must be a string or a number
1706
1676
        bundle_txt.seek(0, 2)
1707
 
        bundle_txt.write(b'\n')
 
1677
        bundle_txt.write('\n')
1708
1678
        bundle_txt.seek(0)
1709
1679
 
1710
1680
        bundle = read_bundle(bundle_txt)
1717
1687
        # Adding two extra newlines used to give us
1718
1688
        # MalformedPatches: The first line of all patches should be ...
1719
1689
        bundle_txt.seek(0, 2)
1720
 
        bundle_txt.write(b'\n\n')
 
1690
        bundle_txt.write('\n\n')
1721
1691
        bundle_txt.seek(0)
1722
1692
 
1723
1693
        bundle = read_bundle(bundle_txt)
1737
1707
        # test is concerned with the exact case where the serializer
1738
1708
        # creates a blank line at the end, and fails if that
1739
1709
        # line is stripped
1740
 
        self.assertEqual(b'\n\n', raw[-2:])
1741
 
        bundle_txt = BytesIO(raw[:-1])
 
1710
        self.assertEqual('\n\n', raw[-2:])
 
1711
        bundle_txt = StringIO(raw[:-1])
1742
1712
 
1743
1713
        bundle = read_bundle(bundle_txt)
1744
1714
        self.check_valid(bundle)
1746
1716
    def test_opening_text(self):
1747
1717
        bundle_txt = self.build_test_bundle()
1748
1718
 
1749
 
        bundle_txt = BytesIO(
1750
 
            b"Some random\nemail comments\n" + bundle_txt.getvalue())
 
1719
        bundle_txt = StringIO("Some random\nemail comments\n"
 
1720
                              + bundle_txt.getvalue())
1751
1721
 
1752
1722
        bundle = read_bundle(bundle_txt)
1753
1723
        self.check_valid(bundle)
1755
1725
    def test_trailing_text(self):
1756
1726
        bundle_txt = self.build_test_bundle()
1757
1727
 
1758
 
        bundle_txt = BytesIO(
1759
 
            bundle_txt.getvalue() + b"Some trailing\nrandom\ntext\n")
 
1728
        bundle_txt = StringIO(bundle_txt.getvalue() +
 
1729
                              "Some trailing\nrandom\ntext\n")
1760
1730
 
1761
1731
        bundle = read_bundle(bundle_txt)
1762
1732
        self.check_valid(bundle)
1770
1740
class TestBundleWriterReader(tests.TestCase):
1771
1741
 
1772
1742
    def test_roundtrip_record(self):
1773
 
        fileobj = BytesIO()
 
1743
        fileobj = StringIO()
1774
1744
        writer = v4.BundleWriter(fileobj)
1775
1745
        writer.begin()
1776
 
        writer.add_info_record({b'foo': b'bar'})
1777
 
        writer._add_record(b"Record body", {b'parents': [b'1', b'3'],
1778
 
                                            b'storage_kind': b'fulltext'}, 'file', b'revid', b'fileid')
 
1746
        writer.add_info_record(foo='bar')
 
1747
        writer._add_record("Record body", {'parents': ['1', '3'],
 
1748
            'storage_kind':'fulltext'}, 'file', 'revid', 'fileid')
1779
1749
        writer.end()
1780
1750
        fileobj.seek(0)
1781
1751
        reader = v4.BundleReader(fileobj, stream_input=True)
1782
1752
        record_iter = reader.iter_records()
1783
 
        record = next(record_iter)
1784
 
        self.assertEqual((None, {b'foo': b'bar', b'storage_kind': b'header'},
1785
 
                          'info', None, None), record)
1786
 
        record = next(record_iter)
1787
 
        self.assertEqual((b"Record body", {b'storage_kind': b'fulltext',
1788
 
                                           b'parents': [b'1', b'3']}, 'file', b'revid', b'fileid'),
1789
 
                         record)
 
1753
        record = record_iter.next()
 
1754
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
 
1755
            'info', None, None), record)
 
1756
        record = record_iter.next()
 
1757
        self.assertEqual(("Record body", {'storage_kind': 'fulltext',
 
1758
                          'parents': ['1', '3']}, 'file', 'revid', 'fileid'),
 
1759
                          record)
1790
1760
 
1791
1761
    def test_roundtrip_record_memory_hungry(self):
1792
 
        fileobj = BytesIO()
 
1762
        fileobj = StringIO()
1793
1763
        writer = v4.BundleWriter(fileobj)
1794
1764
        writer.begin()
1795
 
        writer.add_info_record({b'foo': b'bar'})
1796
 
        writer._add_record(b"Record body", {b'parents': [b'1', b'3'],
1797
 
                                            b'storage_kind': b'fulltext'}, 'file', b'revid', b'fileid')
 
1765
        writer.add_info_record(foo='bar')
 
1766
        writer._add_record("Record body", {'parents': ['1', '3'],
 
1767
            'storage_kind':'fulltext'}, 'file', 'revid', 'fileid')
1798
1768
        writer.end()
1799
1769
        fileobj.seek(0)
1800
1770
        reader = v4.BundleReader(fileobj, stream_input=False)
1801
1771
        record_iter = reader.iter_records()
1802
 
        record = next(record_iter)
1803
 
        self.assertEqual((None, {b'foo': b'bar', b'storage_kind': b'header'},
1804
 
                          'info', None, None), record)
1805
 
        record = next(record_iter)
1806
 
        self.assertEqual((b"Record body", {b'storage_kind': b'fulltext',
1807
 
                                           b'parents': [b'1', b'3']}, 'file', b'revid', b'fileid'),
1808
 
                         record)
 
1772
        record = record_iter.next()
 
1773
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
 
1774
            'info', None, None), record)
 
1775
        record = record_iter.next()
 
1776
        self.assertEqual(("Record body", {'storage_kind': 'fulltext',
 
1777
                          'parents': ['1', '3']}, 'file', 'revid', 'fileid'),
 
1778
                          record)
1809
1779
 
1810
1780
    def test_encode_name(self):
1811
 
        self.assertEqual(b'revision/rev1',
1812
 
                         v4.BundleWriter.encode_name('revision', b'rev1'))
1813
 
        self.assertEqual(b'file/rev//1/file-id-1',
1814
 
                         v4.BundleWriter.encode_name('file', b'rev/1', b'file-id-1'))
1815
 
        self.assertEqual(b'info',
1816
 
                         v4.BundleWriter.encode_name('info', None, None))
 
1781
        self.assertEqual('revision/rev1',
 
1782
            v4.BundleWriter.encode_name('revision', 'rev1'))
 
1783
        self.assertEqual('file/rev//1/file-id-1',
 
1784
            v4.BundleWriter.encode_name('file', 'rev/1', 'file-id-1'))
 
1785
        self.assertEqual('info',
 
1786
            v4.BundleWriter.encode_name('info', None, None))
1817
1787
 
1818
1788
    def test_decode_name(self):
1819
 
        self.assertEqual(('revision', b'rev1', None),
1820
 
                         v4.BundleReader.decode_name(b'revision/rev1'))
1821
 
        self.assertEqual(('file', b'rev/1', b'file-id-1'),
1822
 
                         v4.BundleReader.decode_name(b'file/rev//1/file-id-1'))
 
1789
        self.assertEqual(('revision', 'rev1', None),
 
1790
            v4.BundleReader.decode_name('revision/rev1'))
 
1791
        self.assertEqual(('file', 'rev/1', 'file-id-1'),
 
1792
            v4.BundleReader.decode_name('file/rev//1/file-id-1'))
1823
1793
        self.assertEqual(('info', None, None),
1824
 
                         v4.BundleReader.decode_name(b'info'))
 
1794
                         v4.BundleReader.decode_name('info'))
1825
1795
 
1826
1796
    def test_too_many_names(self):
1827
 
        fileobj = BytesIO()
 
1797
        fileobj = StringIO()
1828
1798
        writer = v4.BundleWriter(fileobj)
1829
1799
        writer.begin()
1830
 
        writer.add_info_record({b'foo': b'bar'})
1831
 
        writer._container.add_bytes_record(b'blah', [(b'two', ), (b'names', )])
 
1800
        writer.add_info_record(foo='bar')
 
1801
        writer._container.add_bytes_record('blah', ['two', 'names'])
1832
1802
        writer.end()
1833
1803
        fileobj.seek(0)
1834
1804
        record_iter = v4.BundleReader(fileobj).iter_records()
1835
 
        record = next(record_iter)
1836
 
        self.assertEqual((None, {b'foo': b'bar', b'storage_kind': b'header'},
1837
 
                          'info', None, None), record)
1838
 
        self.assertRaises(errors.BadBundle, next, record_iter)
 
1805
        record = record_iter.next()
 
1806
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
 
1807
            'info', None, None), record)
 
1808
        self.assertRaises(errors.BadBundle, record_iter.next)
1839
1809
 
1840
1810
 
1841
1811
class TestReadMergeableFromUrl(tests.TestCaseWithTransport):
1844
1814
        """A local bundle named like the URL should not be read.
1845
1815
        """
1846
1816
        out, wt = test_read_bundle.create_bundle_file(self)
1847
 
 
1848
1817
        class FooService(object):
1849
1818
            """A directory service that always returns source"""
1850
1819
 
1859
1828
    def test_infinite_redirects_are_not_a_bundle(self):
1860
1829
        """If a URL causes TooManyRedirections then NotABundle is raised.
1861
1830
        """
1862
 
        from .blackbox.test_push import RedirectingMemoryServer
 
1831
        from bzrlib.tests.blackbox.test_push import RedirectingMemoryServer
1863
1832
        server = RedirectingMemoryServer()
1864
1833
        self.start_server(server)
1865
1834
        url = server.get_url() + 'infinite-loop'
1870
1839
        bundle, then the ConnectionReset error should be propagated.
1871
1840
        """
1872
1841
        # Instantiate a server that will provoke a ConnectionReset
1873
 
        sock_server = DisconnectingServer()
 
1842
        sock_server = _DisconnectingTCPServer()
1874
1843
        self.start_server(sock_server)
1875
1844
        # We don't really care what the url is since the server will close the
1876
1845
        # connection without interpreting it
1878
1847
        self.assertRaises(errors.ConnectionReset, read_mergeable_from_url, url)
1879
1848
 
1880
1849
 
1881
 
class DisconnectingHandler(socketserver.BaseRequestHandler):
1882
 
    """A request handler that immediately closes any connection made to it."""
1883
 
 
1884
 
    def handle(self):
1885
 
        self.request.close()
1886
 
 
1887
 
 
1888
 
class DisconnectingServer(test_server.TestingTCPServerInAThread):
1889
 
 
1890
 
    def __init__(self):
1891
 
        super(DisconnectingServer, self).__init__(
1892
 
            ('127.0.0.1', 0),
1893
 
            test_server.TestingTCPServer,
1894
 
            DisconnectingHandler)
 
1850
class _DisconnectingTCPServer(object):
 
1851
    """A TCP server that immediately closes any connection made to it."""
 
1852
 
 
1853
    def start_server(self):
 
1854
        self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
 
1855
        self.sock.bind(('127.0.0.1', 0))
 
1856
        self.sock.listen(1)
 
1857
        self.port = self.sock.getsockname()[1]
 
1858
        self.thread = threading.Thread(
 
1859
            name='%s (port %d)' % (self.__class__.__name__, self.port),
 
1860
            target=self.accept_and_close)
 
1861
        self.thread.start()
 
1862
 
 
1863
    def accept_and_close(self):
 
1864
        conn, addr = self.sock.accept()
 
1865
        conn.shutdown(socket.SHUT_RDWR)
 
1866
        conn.close()
1895
1867
 
1896
1868
    def get_url(self):
1897
 
        """Return the url of the server"""
1898
 
        return "bzr://%s:%d/" % self.server.server_address
 
1869
        return 'bzr://127.0.0.1:%d/' % (self.port,)
 
1870
 
 
1871
    def stop_server(self):
 
1872
        try:
 
1873
            # make sure the thread dies by connecting to the listening socket,
 
1874
            # just in case the test failed to do so.
 
1875
            conn = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
 
1876
            conn.connect(self.sock.getsockname())
 
1877
            conn.close()
 
1878
        except socket.error:
 
1879
            pass
 
1880
        self.sock.close()
 
1881
        self.thread.join()