/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/builtins.py

  • Committer: Robert Collins
  • Date: 2010-05-06 11:08:10 UTC
  • mto: This revision was merged to the branch mainline in revision 5223.
  • Revision ID: robertc@robertcollins.net-20100506110810-h3j07fh5gmw54s25
Cleaner matcher matching revised unlocking protocol.

Show diffs side-by-side

added added

removed removed

Lines of Context:
180
180
                view_str = views.view_display_str(view_files)
181
181
                note("Ignoring files outside view. View is %s" % view_str)
182
182
        return tree, file_list
183
 
    tree = WorkingTree.open_containing(file_list[0])[0]
 
183
    tree = WorkingTree.open_containing(osutils.realpath(file_list[0]))[0]
184
184
    return tree, safe_relpath_files(tree, file_list, canonicalize,
185
185
        apply_view=apply_view)
186
186
 
232
232
    return view_info
233
233
 
234
234
 
235
 
def _open_directory_or_containing_tree_or_branch(filename, directory):
236
 
    """Open the tree or branch containing the specified file, unless
237
 
    the --directory option is used to specify a different branch."""
238
 
    if directory is not None:
239
 
        return (None, Branch.open(directory), filename)
240
 
    return bzrdir.BzrDir.open_containing_tree_or_branch(filename)
241
 
 
242
 
 
243
235
# TODO: Make sure no commands unconditionally use the working directory as a
244
236
# branch.  If a filename argument is used, the first of them should be used to
245
237
# specify the branch.  (Perhaps this can be factored out into some kind of
348
340
 
349
341
    hidden = True
350
342
    takes_args = ['revision_id?']
351
 
    takes_options = ['directory', 'revision']
 
343
    takes_options = ['revision']
352
344
    # cat-revision is more for frontends so should be exact
353
345
    encoding = 'strict'
354
346
 
361
353
        self.outf.write(revtext.decode('utf-8'))
362
354
 
363
355
    @display_command
364
 
    def run(self, revision_id=None, revision=None, directory=u'.'):
 
356
    def run(self, revision_id=None, revision=None):
365
357
        if revision_id is not None and revision is not None:
366
358
            raise errors.BzrCommandError('You can only supply one of'
367
359
                                         ' revision_id or --revision')
368
360
        if revision_id is None and revision is None:
369
361
            raise errors.BzrCommandError('You must supply either'
370
362
                                         ' --revision or a revision_id')
371
 
        b = WorkingTree.open_containing(directory)[0].branch
 
363
        b = WorkingTree.open_containing(u'.')[0].branch
372
364
 
373
365
        revisions = b.repository.revisions
374
366
        if revisions is None:
491
483
    takes_options = [
492
484
        Option('force',
493
485
               help='Remove the working tree even if it has '
494
 
                    'uncommitted or shelved changes.'),
 
486
                    'uncommitted changes.'),
495
487
        ]
496
488
 
497
489
    def run(self, location_list, force=False):
511
503
            if not force:
512
504
                if (working.has_changes()):
513
505
                    raise errors.UncommittedChanges(working)
514
 
                if working.get_shelf_manager().last_shelf() is not None:
515
 
                    raise errors.ShelvedChanges(working)
516
506
 
517
507
            if working.user_url != working.branch.user_url:
518
508
                raise errors.BzrCommandError("You cannot remove the working tree"
538
528
        if tree:
539
529
            try:
540
530
                wt = WorkingTree.open_containing(location)[0]
541
 
                self.add_cleanup(wt.lock_read().unlock)
 
531
                wt.lock_read()
542
532
            except (errors.NoWorkingTree, errors.NotLocalUrl):
543
533
                raise errors.NoWorkingTree(location)
 
534
            self.add_cleanup(wt.unlock)
544
535
            revid = wt.last_revision()
545
536
            try:
546
537
                revno_t = wt.branch.revision_id_to_dotted_revno(revid)
549
540
            revno = ".".join(str(n) for n in revno_t)
550
541
        else:
551
542
            b = Branch.open_containing(location)[0]
552
 
            self.add_cleanup(b.lock_read().unlock)
 
543
            b.lock_read()
 
544
            self.add_cleanup(b.unlock)
553
545
            revno = b.revno()
554
546
        self.cleanup_now()
555
547
        self.outf.write(str(revno) + '\n')
562
554
    takes_args = ['revision_info*']
563
555
    takes_options = [
564
556
        'revision',
565
 
        custom_help('directory',
 
557
        Option('directory',
566
558
            help='Branch to examine, '
567
 
                 'rather than the one containing the working directory.'),
 
559
                 'rather than the one containing the working directory.',
 
560
            short_name='d',
 
561
            type=unicode,
 
562
            ),
568
563
        Option('tree', help='Show revno of working tree'),
569
564
        ]
570
565
 
575
570
        try:
576
571
            wt = WorkingTree.open_containing(directory)[0]
577
572
            b = wt.branch
578
 
            self.add_cleanup(wt.lock_read().unlock)
 
573
            wt.lock_read()
 
574
            self.add_cleanup(wt.unlock)
579
575
        except (errors.NoWorkingTree, errors.NotLocalUrl):
580
576
            wt = None
581
577
            b = Branch.open_containing(directory)[0]
582
 
            self.add_cleanup(b.lock_read().unlock)
 
578
            b.lock_read()
 
579
            self.add_cleanup(b.unlock)
583
580
        revision_ids = []
584
581
        if revision is not None:
585
582
            revision_ids.extend(rev.as_revision_id(b) for rev in revision)
684
681
                should_print=(not is_quiet()))
685
682
 
686
683
        if base_tree:
687
 
            self.add_cleanup(base_tree.lock_read().unlock)
 
684
            base_tree.lock_read()
 
685
            self.add_cleanup(base_tree.unlock)
688
686
        tree, file_list = tree_files_for_add(file_list)
689
687
        added, ignored = tree.smart_add(file_list, not
690
688
            no_recurse, action=action, save=not dry_run)
762
760
 
763
761
        revision = _get_one_revision('inventory', revision)
764
762
        work_tree, file_list = tree_files(file_list)
765
 
        self.add_cleanup(work_tree.lock_read().unlock)
 
763
        work_tree.lock_read()
 
764
        self.add_cleanup(work_tree.unlock)
766
765
        if revision is not None:
767
766
            tree = revision.as_tree(work_tree.branch)
768
767
 
769
768
            extra_trees = [work_tree]
770
 
            self.add_cleanup(tree.lock_read().unlock)
 
769
            tree.lock_read()
 
770
            self.add_cleanup(tree.unlock)
771
771
        else:
772
772
            tree = work_tree
773
773
            extra_trees = []
833
833
        if len(names_list) < 2:
834
834
            raise errors.BzrCommandError("missing file argument")
835
835
        tree, rel_names = tree_files(names_list, canonicalize=False)
836
 
        self.add_cleanup(tree.lock_tree_write().unlock)
 
836
        tree.lock_tree_write()
 
837
        self.add_cleanup(tree.unlock)
837
838
        self._run(tree, names_list, rel_names, after)
838
839
 
839
840
    def run_auto(self, names_list, after, dry_run):
844
845
            raise errors.BzrCommandError('--after cannot be specified with'
845
846
                                         ' --auto.')
846
847
        work_tree, file_list = tree_files(names_list, default_branch='.')
847
 
        self.add_cleanup(work_tree.lock_tree_write().unlock)
 
848
        work_tree.lock_tree_write()
 
849
        self.add_cleanup(work_tree.unlock)
848
850
        rename_map.RenameMap.guess_renames(work_tree, dry_run)
849
851
 
850
852
    def _run(self, tree, names_list, rel_names, after):
958
960
    takes_options = ['remember', 'overwrite', 'revision',
959
961
        custom_help('verbose',
960
962
            help='Show logs of pulled revisions.'),
961
 
        custom_help('directory',
 
963
        Option('directory',
962
964
            help='Branch to pull into, '
963
 
                 'rather than the one containing the working directory.'),
 
965
                 'rather than the one containing the working directory.',
 
966
            short_name='d',
 
967
            type=unicode,
 
968
            ),
964
969
        Option('local',
965
970
            help="Perform a local pull in a bound "
966
971
                 "branch.  Local pulls are not applied to "
981
986
        try:
982
987
            tree_to = WorkingTree.open_containing(directory)[0]
983
988
            branch_to = tree_to.branch
984
 
            self.add_cleanup(tree_to.lock_write().unlock)
 
989
            tree_to.lock_write()
 
990
            self.add_cleanup(tree_to.unlock)
985
991
        except errors.NoWorkingTree:
986
992
            tree_to = None
987
993
            branch_to = Branch.open_containing(directory)[0]
988
 
            self.add_cleanup(branch_to.lock_write().unlock)
 
994
            branch_to.lock_write()
 
995
            self.add_cleanup(branch_to.unlock)
989
996
 
990
997
        if local and not branch_to.get_bound_location():
991
998
            raise errors.LocalRequiresBoundBranch()
1022
1029
        else:
1023
1030
            branch_from = Branch.open(location,
1024
1031
                possible_transports=possible_transports)
1025
 
            self.add_cleanup(branch_from.lock_read().unlock)
 
1032
            branch_from.lock_read()
 
1033
            self.add_cleanup(branch_from.unlock)
1026
1034
 
1027
1035
            if branch_to.get_parent() is None or remember:
1028
1036
                branch_to.set_parent(branch_from.base)
1080
1088
        Option('create-prefix',
1081
1089
               help='Create the path leading up to the branch '
1082
1090
                    'if it does not already exist.'),
1083
 
        custom_help('directory',
 
1091
        Option('directory',
1084
1092
            help='Branch to push from, '
1085
 
                 'rather than the one containing the working directory.'),
 
1093
                 'rather than the one containing the working directory.',
 
1094
            short_name='d',
 
1095
            type=unicode,
 
1096
            ),
1086
1097
        Option('use-existing-dir',
1087
1098
               help='By default push will fail if the target'
1088
1099
                    ' directory exists, but does not already'
1208
1219
        accelerator_tree, br_from = bzrdir.BzrDir.open_tree_or_branch(
1209
1220
            from_location)
1210
1221
        revision = _get_one_revision('branch', revision)
1211
 
        self.add_cleanup(br_from.lock_read().unlock)
 
1222
        br_from.lock_read()
 
1223
        self.add_cleanup(br_from.unlock)
1212
1224
        if revision is not None:
1213
1225
            revision_id = revision.as_revision_id(br_from)
1214
1226
        else:
1354
1366
    @display_command
1355
1367
    def run(self, dir=u'.'):
1356
1368
        tree = WorkingTree.open_containing(dir)[0]
1357
 
        self.add_cleanup(tree.lock_read().unlock)
 
1369
        tree.lock_read()
 
1370
        self.add_cleanup(tree.unlock)
1358
1371
        new_inv = tree.inventory
1359
1372
        old_tree = tree.basis_tree()
1360
 
        self.add_cleanup(old_tree.lock_read().unlock)
 
1373
        old_tree.lock_read()
 
1374
        self.add_cleanup(old_tree.unlock)
1361
1375
        old_inv = old_tree.inventory
1362
1376
        renames = []
1363
1377
        iterator = tree.iter_changes(old_tree, include_unchanged=True)
1401
1415
        master = branch.get_master_branch(
1402
1416
            possible_transports=possible_transports)
1403
1417
        if master is not None:
 
1418
            tree.lock_write()
1404
1419
            branch_location = master.base
1405
 
            tree.lock_write()
1406
1420
        else:
 
1421
            tree.lock_tree_write()
1407
1422
            branch_location = tree.branch.base
1408
 
            tree.lock_tree_write()
1409
1423
        self.add_cleanup(tree.unlock)
1410
1424
        # get rid of the final '/' and be ready for display
1411
1425
        branch_location = urlutils.unescape_for_display(
1531
1545
        if file_list is not None:
1532
1546
            file_list = [f for f in file_list]
1533
1547
 
1534
 
        self.add_cleanup(tree.lock_write().unlock)
 
1548
        tree.lock_write()
 
1549
        self.add_cleanup(tree.unlock)
1535
1550
        # Heuristics should probably all move into tree.remove_smart or
1536
1551
        # some such?
1537
1552
        if new:
1970
1985
         old_branch, new_branch,
1971
1986
         specific_files, extra_trees) = get_trees_and_branches_to_diff_locked(
1972
1987
            file_list, revision, old, new, self.add_cleanup, apply_view=True)
1973
 
        # GNU diff on Windows uses ANSI encoding for filenames
1974
 
        path_encoding = osutils.get_diff_header_encoding()
1975
1988
        return show_diff_trees(old_tree, new_tree, sys.stdout,
1976
1989
                               specific_files=specific_files,
1977
1990
                               external_diff_options=diff_options,
1978
1991
                               old_label=old_label, new_label=new_label,
1979
 
                               extra_trees=extra_trees,
1980
 
                               path_encoding=path_encoding,
1981
 
                               using=using,
 
1992
                               extra_trees=extra_trees, using=using,
1982
1993
                               format_cls=format)
1983
1994
 
1984
1995
 
1992
2003
    # level of effort but possibly much less IO.  (Or possibly not,
1993
2004
    # if the directories are very large...)
1994
2005
    _see_also = ['status', 'ls']
1995
 
    takes_options = ['directory', 'show-ids']
 
2006
    takes_options = ['show-ids']
1996
2007
 
1997
2008
    @display_command
1998
 
    def run(self, show_ids=False, directory=u'.'):
1999
 
        tree = WorkingTree.open_containing(directory)[0]
2000
 
        self.add_cleanup(tree.lock_read().unlock)
 
2009
    def run(self, show_ids=False):
 
2010
        tree = WorkingTree.open_containing(u'.')[0]
 
2011
        tree.lock_read()
 
2012
        self.add_cleanup(tree.unlock)
2001
2013
        old = tree.basis_tree()
2002
 
        self.add_cleanup(old.lock_read().unlock)
 
2014
        old.lock_read()
 
2015
        self.add_cleanup(old.unlock)
2003
2016
        for path, ie in old.inventory.iter_entries():
2004
2017
            if not tree.has_id(ie.file_id):
2005
2018
                self.outf.write(path)
2015
2028
 
2016
2029
    hidden = True
2017
2030
    _see_also = ['status', 'ls']
2018
 
    takes_options = ['directory', 'null']
 
2031
    takes_options = [
 
2032
            Option('null',
 
2033
                   help='Write an ascii NUL (\\0) separator '
 
2034
                   'between files rather than a newline.')
 
2035
            ]
2019
2036
 
2020
2037
    @display_command
2021
 
    def run(self, null=False, directory=u'.'):
2022
 
        tree = WorkingTree.open_containing(directory)[0]
 
2038
    def run(self, null=False):
 
2039
        tree = WorkingTree.open_containing(u'.')[0]
2023
2040
        td = tree.changes_from(tree.basis_tree())
2024
2041
        for path, id, kind, text_modified, meta_modified in td.modified:
2025
2042
            if null:
2034
2051
 
2035
2052
    hidden = True
2036
2053
    _see_also = ['status', 'ls']
2037
 
    takes_options = ['directory', 'null']
 
2054
    takes_options = [
 
2055
            Option('null',
 
2056
                   help='Write an ascii NUL (\\0) separator '
 
2057
                   'between files rather than a newline.')
 
2058
            ]
2038
2059
 
2039
2060
    @display_command
2040
 
    def run(self, null=False, directory=u'.'):
2041
 
        wt = WorkingTree.open_containing(directory)[0]
2042
 
        self.add_cleanup(wt.lock_read().unlock)
 
2061
    def run(self, null=False):
 
2062
        wt = WorkingTree.open_containing(u'.')[0]
 
2063
        wt.lock_read()
 
2064
        self.add_cleanup(wt.unlock)
2043
2065
        basis = wt.basis_tree()
2044
 
        self.add_cleanup(basis.lock_read().unlock)
 
2066
        basis.lock_read()
 
2067
        self.add_cleanup(basis.unlock)
2045
2068
        basis_inv = basis.inventory
2046
2069
        inv = wt.inventory
2047
2070
        for file_id in inv:
2050
2073
            if inv.is_root(file_id) and len(basis_inv) == 0:
2051
2074
                continue
2052
2075
            path = inv.id2path(file_id)
2053
 
            if not os.access(osutils.pathjoin(wt.basedir, path), os.F_OK):
 
2076
            if not os.access(osutils.abspath(path), os.F_OK):
2054
2077
                continue
2055
2078
            if null:
2056
2079
                self.outf.write(path + '\0')
2256
2279
                   help='Show just the specified revision.'
2257
2280
                   ' See also "help revisionspec".'),
2258
2281
            'log-format',
2259
 
            RegistryOption('authors',
2260
 
                'What names to list as authors - first, all or committer.',
2261
 
                title='Authors',
2262
 
                lazy_registry=('bzrlib.log', 'author_list_registry'),
2263
 
            ),
2264
2282
            Option('levels',
2265
2283
                   short_name='n',
2266
2284
                   help='Number of levels to display - 0 for all, 1 for flat.',
2301
2319
            limit=None,
2302
2320
            show_diff=False,
2303
2321
            include_merges=False,
2304
 
            authors=None,
2305
2322
            exclude_common_ancestry=False,
2306
2323
            ):
2307
2324
        from bzrlib.log import (
2335
2352
        if file_list:
2336
2353
            # find the file ids to log and check for directory filtering
2337
2354
            b, file_info_list, rev1, rev2 = _get_info_for_log_files(
2338
 
                revision, file_list, self.add_cleanup)
 
2355
                revision, file_list)
 
2356
            self.add_cleanup(b.unlock)
2339
2357
            for relpath, file_id, kind in file_info_list:
2340
2358
                if file_id is None:
2341
2359
                    raise errors.BzrCommandError(
2359
2377
                location = '.'
2360
2378
            dir, relpath = bzrdir.BzrDir.open_containing(location)
2361
2379
            b = dir.open_branch()
2362
 
            self.add_cleanup(b.lock_read().unlock)
 
2380
            b.lock_read()
 
2381
            self.add_cleanup(b.unlock)
2363
2382
            rev1, rev2 = _get_revision_range(revision, b, self.name())
2364
2383
 
2365
2384
        # Decide on the type of delta & diff filtering to use
2385
2404
                        show_timezone=timezone,
2386
2405
                        delta_format=get_verbosity_level(),
2387
2406
                        levels=levels,
2388
 
                        show_advice=levels is None,
2389
 
                        author_list_handler=authors)
 
2407
                        show_advice=levels is None)
2390
2408
 
2391
2409
        # Choose the algorithm for doing the logging. It's annoying
2392
2410
        # having multiple code paths like this but necessary until
2490
2508
        tree, relpath = WorkingTree.open_containing(filename)
2491
2509
        file_id = tree.path2id(relpath)
2492
2510
        b = tree.branch
2493
 
        self.add_cleanup(b.lock_read().unlock)
 
2511
        b.lock_read()
 
2512
        self.add_cleanup(b.unlock)
2494
2513
        touching_revs = log.find_touching_revisions(b, file_id)
2495
2514
        for revno, revision_id, what in touching_revs:
2496
2515
            self.outf.write("%6d %s\n" % (revno, what))
2509
2528
                   help='Recurse into subdirectories.'),
2510
2529
            Option('from-root',
2511
2530
                   help='Print paths relative to the root of the branch.'),
2512
 
            Option('unknown', short_name='u',
2513
 
                help='Print unknown files.'),
 
2531
            Option('unknown', help='Print unknown files.'),
2514
2532
            Option('versioned', help='Print versioned files.',
2515
2533
                   short_name='V'),
2516
 
            Option('ignored', short_name='i',
2517
 
                help='Print ignored files.'),
2518
 
            Option('kind', short_name='k',
 
2534
            Option('ignored', help='Print ignored files.'),
 
2535
            Option('null',
 
2536
                   help='Write an ascii NUL (\\0) separator '
 
2537
                   'between files rather than a newline.'),
 
2538
            Option('kind',
2519
2539
                   help='List entries of a particular kind: file, directory, symlink.',
2520
2540
                   type=unicode),
2521
 
            'null',
2522
2541
            'show-ids',
2523
 
            'directory',
2524
2542
            ]
2525
2543
    @display_command
2526
2544
    def run(self, revision=None, verbose=False,
2527
2545
            recursive=False, from_root=False,
2528
2546
            unknown=False, versioned=False, ignored=False,
2529
 
            null=False, kind=None, show_ids=False, path=None, directory=None):
 
2547
            null=False, kind=None, show_ids=False, path=None):
2530
2548
 
2531
2549
        if kind and kind not in ('file', 'directory', 'symlink'):
2532
2550
            raise errors.BzrCommandError('invalid kind specified')
2544
2562
                raise errors.BzrCommandError('cannot specify both --from-root'
2545
2563
                                             ' and PATH')
2546
2564
            fs_path = path
2547
 
        tree, branch, relpath = \
2548
 
            _open_directory_or_containing_tree_or_branch(fs_path, directory)
 
2565
        tree, branch, relpath = bzrdir.BzrDir.open_containing_tree_or_branch(
 
2566
            fs_path)
2549
2567
 
2550
2568
        # Calculate the prefix to use
2551
2569
        prefix = None
2566
2584
                view_str = views.view_display_str(view_files)
2567
2585
                note("Ignoring files outside view. View is %s" % view_str)
2568
2586
 
2569
 
        self.add_cleanup(tree.lock_read().unlock)
 
2587
        tree.lock_read()
 
2588
        self.add_cleanup(tree.unlock)
2570
2589
        for fp, fc, fkind, fid, entry in tree.list_files(include_root=False,
2571
2590
            from_dir=relpath, recursive=recursive):
2572
2591
            # Apply additional masking
2619
2638
 
2620
2639
    hidden = True
2621
2640
    _see_also = ['ls']
2622
 
    takes_options = ['directory']
2623
2641
 
2624
2642
    @display_command
2625
 
    def run(self, directory=u'.'):
2626
 
        for f in WorkingTree.open_containing(directory)[0].unknowns():
 
2643
    def run(self):
 
2644
        for f in WorkingTree.open_containing(u'.')[0].unknowns():
2627
2645
            self.outf.write(osutils.quotefn(f) + '\n')
2628
2646
 
2629
2647
 
2694
2712
 
2695
2713
    _see_also = ['status', 'ignored', 'patterns']
2696
2714
    takes_args = ['name_pattern*']
2697
 
    takes_options = ['directory',
 
2715
    takes_options = [
2698
2716
        Option('default-rules',
2699
2717
               help='Display the default ignore rules that bzr uses.')
2700
2718
        ]
2701
2719
 
2702
 
    def run(self, name_pattern_list=None, default_rules=None,
2703
 
            directory=u'.'):
 
2720
    def run(self, name_pattern_list=None, default_rules=None):
2704
2721
        from bzrlib import ignores
2705
2722
        if default_rules is not None:
2706
2723
            # dump the default rules and exit
2712
2729
                "NAME_PATTERN or --default-rules.")
2713
2730
        name_pattern_list = [globbing.normalize_pattern(p)
2714
2731
                             for p in name_pattern_list]
2715
 
        bad_patterns = ''
2716
 
        for p in name_pattern_list:
2717
 
            if not globbing.Globster.is_pattern_valid(p):
2718
 
                bad_patterns += ('\n  %s' % p)
2719
 
        if bad_patterns:
2720
 
            msg = ('Invalid ignore pattern(s) found. %s' % bad_patterns)
2721
 
            ui.ui_factory.show_error(msg)
2722
 
            raise errors.InvalidPattern('')
2723
2732
        for name_pattern in name_pattern_list:
2724
2733
            if (name_pattern[0] == '/' or
2725
2734
                (len(name_pattern) > 1 and name_pattern[1] == ':')):
2726
2735
                raise errors.BzrCommandError(
2727
2736
                    "NAME_PATTERN should not be an absolute path")
2728
 
        tree, relpath = WorkingTree.open_containing(directory)
 
2737
        tree, relpath = WorkingTree.open_containing(u'.')
2729
2738
        ignores.tree_ignores_add_patterns(tree, name_pattern_list)
2730
2739
        ignored = globbing.Globster(name_pattern_list)
2731
2740
        matches = []
2732
 
        self.add_cleanup(tree.lock_read().unlock)
 
2741
        tree.lock_read()
2733
2742
        for entry in tree.list_files():
2734
2743
            id = entry[3]
2735
2744
            if id is not None:
2736
2745
                filename = entry[0]
2737
2746
                if ignored.match(filename):
2738
2747
                    matches.append(filename)
 
2748
        tree.unlock()
2739
2749
        if len(matches) > 0:
2740
2750
            self.outf.write("Warning: the following files are version controlled and"
2741
2751
                  " match your ignore pattern:\n%s"
2756
2766
 
2757
2767
    encoding_type = 'replace'
2758
2768
    _see_also = ['ignore', 'ls']
2759
 
    takes_options = ['directory']
2760
2769
 
2761
2770
    @display_command
2762
 
    def run(self, directory=u'.'):
2763
 
        tree = WorkingTree.open_containing(directory)[0]
2764
 
        self.add_cleanup(tree.lock_read().unlock)
 
2771
    def run(self):
 
2772
        tree = WorkingTree.open_containing(u'.')[0]
 
2773
        tree.lock_read()
 
2774
        self.add_cleanup(tree.unlock)
2765
2775
        for path, file_class, kind, file_id, entry in tree.list_files():
2766
2776
            if file_class != 'I':
2767
2777
                continue
2778
2788
    """
2779
2789
    hidden = True
2780
2790
    takes_args = ['revno']
2781
 
    takes_options = ['directory']
2782
2791
 
2783
2792
    @display_command
2784
 
    def run(self, revno, directory=u'.'):
 
2793
    def run(self, revno):
2785
2794
        try:
2786
2795
            revno = int(revno)
2787
2796
        except ValueError:
2788
2797
            raise errors.BzrCommandError("not a valid revision-number: %r"
2789
2798
                                         % revno)
2790
 
        revid = WorkingTree.open_containing(directory)[0].branch.get_rev_id(revno)
 
2799
        revid = WorkingTree.open_containing(u'.')[0].branch.get_rev_id(revno)
2791
2800
        self.outf.write("%s\n" % revid)
2792
2801
 
2793
2802
 
2820
2829
      =================       =========================
2821
2830
    """
2822
2831
    takes_args = ['dest', 'branch_or_subdir?']
2823
 
    takes_options = ['directory',
 
2832
    takes_options = [
2824
2833
        Option('format',
2825
2834
               help="Type of file to export to.",
2826
2835
               type=unicode),
2835
2844
                    'revision in which it was changed.'),
2836
2845
        ]
2837
2846
    def run(self, dest, branch_or_subdir=None, revision=None, format=None,
2838
 
        root=None, filters=False, per_file_timestamps=False, directory=u'.'):
 
2847
        root=None, filters=False, per_file_timestamps=False):
2839
2848
        from bzrlib.export import export
2840
2849
 
2841
2850
        if branch_or_subdir is None:
2842
 
            tree = WorkingTree.open_containing(directory)[0]
 
2851
            tree = WorkingTree.open_containing(u'.')[0]
2843
2852
            b = tree.branch
2844
2853
            subdir = None
2845
2854
        else:
2864
2873
    """
2865
2874
 
2866
2875
    _see_also = ['ls']
2867
 
    takes_options = ['directory',
 
2876
    takes_options = [
2868
2877
        Option('name-from-revision', help='The path name in the old tree.'),
2869
2878
        Option('filters', help='Apply content filters to display the '
2870
2879
                'convenience form.'),
2875
2884
 
2876
2885
    @display_command
2877
2886
    def run(self, filename, revision=None, name_from_revision=False,
2878
 
            filters=False, directory=None):
 
2887
            filters=False):
2879
2888
        if revision is not None and len(revision) != 1:
2880
2889
            raise errors.BzrCommandError("bzr cat --revision takes exactly"
2881
2890
                                         " one revision specifier")
2882
2891
        tree, branch, relpath = \
2883
 
            _open_directory_or_containing_tree_or_branch(filename, directory)
2884
 
        self.add_cleanup(branch.lock_read().unlock)
 
2892
            bzrdir.BzrDir.open_containing_tree_or_branch(filename)
 
2893
        branch.lock_read()
 
2894
        self.add_cleanup(branch.unlock)
2885
2895
        return self._run(tree, branch, relpath, filename, revision,
2886
2896
                         name_from_revision, filters)
2887
2897
 
2890
2900
        if tree is None:
2891
2901
            tree = b.basis_tree()
2892
2902
        rev_tree = _get_one_revision_tree('cat', revision, branch=b)
2893
 
        self.add_cleanup(rev_tree.lock_read().unlock)
 
2903
        rev_tree.lock_read()
 
2904
        self.add_cleanup(rev_tree.unlock)
2894
2905
 
2895
2906
        old_file_id = rev_tree.path2id(relpath)
2896
2907
 
3158
3169
        def get_message(commit_obj):
3159
3170
            """Callback to get commit message"""
3160
3171
            if file:
3161
 
                f = codecs.open(file, 'rt', osutils.get_user_encoding())
3162
 
                try:
3163
 
                    my_message = f.read()
3164
 
                finally:
3165
 
                    f.close()
 
3172
                my_message = codecs.open(
 
3173
                    file, 'rt', osutils.get_user_encoding()).read()
3166
3174
            elif message is not None:
3167
3175
                my_message = message
3168
3176
            else:
3322
3330
 
3323
3331
            bzr whoami "Frank Chu <fchu@example.com>"
3324
3332
    """
3325
 
    takes_options = [ 'directory',
3326
 
                      Option('email',
 
3333
    takes_options = [ Option('email',
3327
3334
                             help='Display email address only.'),
3328
3335
                      Option('branch',
3329
3336
                             help='Set identity for the current branch instead of '
3333
3340
    encoding_type = 'replace'
3334
3341
 
3335
3342
    @display_command
3336
 
    def run(self, email=False, branch=False, name=None, directory=None):
 
3343
    def run(self, email=False, branch=False, name=None):
3337
3344
        if name is None:
3338
 
            if directory is None:
3339
 
                # use branch if we're inside one; otherwise global config
3340
 
                try:
3341
 
                    c = Branch.open_containing(u'.')[0].get_config()
3342
 
                except errors.NotBranchError:
3343
 
                    c = config.GlobalConfig()
3344
 
            else:
3345
 
                c = Branch.open(directory).get_config()
 
3345
            # use branch if we're inside one; otherwise global config
 
3346
            try:
 
3347
                c = Branch.open_containing('.')[0].get_config()
 
3348
            except errors.NotBranchError:
 
3349
                c = config.GlobalConfig()
3346
3350
            if email:
3347
3351
                self.outf.write(c.user_email() + '\n')
3348
3352
            else:
3358
3362
 
3359
3363
        # use global config unless --branch given
3360
3364
        if branch:
3361
 
            if directory is None:
3362
 
                c = Branch.open_containing(u'.')[0].get_config()
3363
 
            else:
3364
 
                c = Branch.open(directory).get_config()
 
3365
            c = Branch.open_containing('.')[0].get_config()
3365
3366
        else:
3366
3367
            c = config.GlobalConfig()
3367
3368
        c.set_user_option('email', name)
3379
3380
 
3380
3381
    _see_also = ['info']
3381
3382
    takes_args = ['nickname?']
3382
 
    takes_options = ['directory']
3383
 
    def run(self, nickname=None, directory=u'.'):
3384
 
        branch = Branch.open_containing(directory)[0]
 
3383
    def run(self, nickname=None):
 
3384
        branch = Branch.open_containing(u'.')[0]
3385
3385
        if nickname is None:
3386
3386
            self.printme(branch)
3387
3387
        else:
3537
3537
                                 'throughout the test suite.',
3538
3538
                            type=get_transport_type),
3539
3539
                     Option('benchmark',
3540
 
                            help='Run the benchmarks rather than selftests.',
3541
 
                            hidden=True),
 
3540
                            help='Run the benchmarks rather than selftests.'),
3542
3541
                     Option('lsprof-timed',
3543
3542
                            help='Generate lsprof output for benchmarked'
3544
3543
                                 ' sections of code.'),
3545
3544
                     Option('lsprof-tests',
3546
3545
                            help='Generate lsprof output for each test.'),
 
3546
                     Option('cache-dir', type=str,
 
3547
                            help='Cache intermediate benchmark output in this '
 
3548
                                 'directory.'),
3547
3549
                     Option('first',
3548
3550
                            help='Run all tests, but run specified tests first.',
3549
3551
                            short_name='f',
3583
3585
 
3584
3586
    def run(self, testspecs_list=None, verbose=False, one=False,
3585
3587
            transport=None, benchmark=None,
3586
 
            lsprof_timed=None,
 
3588
            lsprof_timed=None, cache_dir=None,
3587
3589
            first=False, list_only=False,
3588
3590
            randomize=None, exclude=None, strict=False,
3589
3591
            load_list=None, debugflag=None, starting_with=None, subunit=False,
3590
3592
            parallel=None, lsprof_tests=False):
3591
3593
        from bzrlib.tests import selftest
 
3594
        import bzrlib.benchmarks as benchmarks
 
3595
        from bzrlib.benchmarks import tree_creator
3592
3596
 
3593
3597
        # Make deprecation warnings visible, unless -Werror is set
3594
3598
        symbol_versioning.activate_deprecation_warnings(override=False)
3595
3599
 
 
3600
        if cache_dir is not None:
 
3601
            tree_creator.TreeCreator.CACHE_ROOT = osutils.abspath(cache_dir)
3596
3602
        if testspecs_list is not None:
3597
3603
            pattern = '|'.join(testspecs_list)
3598
3604
        else:
3606
3612
            self.additional_selftest_args['runner_class'] = SubUnitBzrRunner
3607
3613
            # On Windows, disable automatic conversion of '\n' to '\r\n' in
3608
3614
            # stdout, which would corrupt the subunit stream. 
3609
 
            # FIXME: This has been fixed in subunit trunk (>0.0.5) so the
3610
 
            # following code can be deleted when it's sufficiently deployed
3611
 
            # -- vila/mgz 20100514
3612
 
            if (sys.platform == "win32"
3613
 
                and getattr(sys.stdout, 'fileno', None) is not None):
 
3615
            if sys.platform == "win32" and sys.stdout.fileno() >= 0:
3614
3616
                import msvcrt
3615
3617
                msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
3616
3618
        if parallel:
3617
3619
            self.additional_selftest_args.setdefault(
3618
3620
                'suite_decorators', []).append(parallel)
3619
3621
        if benchmark:
3620
 
            raise errors.BzrCommandError(
3621
 
                "--benchmark is no longer supported from bzr 2.2; "
3622
 
                "use bzr-usertest instead")
3623
 
        test_suite_factory = None
 
3622
            test_suite_factory = benchmarks.test_suite
 
3623
            # Unless user explicitly asks for quiet, be verbose in benchmarks
 
3624
            verbose = not is_quiet()
 
3625
            # TODO: should possibly lock the history file...
 
3626
            benchfile = open(".perf_history", "at", buffering=1)
 
3627
            self.add_cleanup(benchfile.close)
 
3628
        else:
 
3629
            test_suite_factory = None
 
3630
            benchfile = None
3624
3631
        selftest_kwargs = {"verbose": verbose,
3625
3632
                          "pattern": pattern,
3626
3633
                          "stop_on_failure": one,
3628
3635
                          "test_suite_factory": test_suite_factory,
3629
3636
                          "lsprof_timed": lsprof_timed,
3630
3637
                          "lsprof_tests": lsprof_tests,
 
3638
                          "bench_history": benchfile,
3631
3639
                          "matching_tests_first": first,
3632
3640
                          "list_only": list_only,
3633
3641
                          "random_seed": randomize,
3682
3690
 
3683
3691
        branch1 = Branch.open_containing(branch)[0]
3684
3692
        branch2 = Branch.open_containing(other)[0]
3685
 
        self.add_cleanup(branch1.lock_read().unlock)
3686
 
        self.add_cleanup(branch2.lock_read().unlock)
 
3693
        branch1.lock_read()
 
3694
        self.add_cleanup(branch1.unlock)
 
3695
        branch2.lock_read()
 
3696
        self.add_cleanup(branch2.unlock)
3687
3697
        last1 = ensure_null(branch1.last_revision())
3688
3698
        last2 = ensure_null(branch2.last_revision())
3689
3699
 
3783
3793
                ' completely merged into the source, pull from the'
3784
3794
                ' source rather than merging.  When this happens,'
3785
3795
                ' you do not need to commit the result.'),
3786
 
        custom_help('directory',
 
3796
        Option('directory',
3787
3797
               help='Branch to merge into, '
3788
 
                    'rather than the one containing the working directory.'),
 
3798
                    'rather than the one containing the working directory.',
 
3799
               short_name='d',
 
3800
               type=unicode,
 
3801
               ),
3789
3802
        Option('preview', help='Instead of merging, show a diff of the'
3790
3803
               ' merge.'),
3791
3804
        Option('interactive', help='Select changes interactively.',
3824
3837
            unversioned_filter=tree.is_ignored, view_info=view_info)
3825
3838
        pb = ui.ui_factory.nested_progress_bar()
3826
3839
        self.add_cleanup(pb.finished)
3827
 
        self.add_cleanup(tree.lock_write().unlock)
 
3840
        tree.lock_write()
 
3841
        self.add_cleanup(tree.unlock)
3828
3842
        if location is not None:
3829
3843
            try:
3830
3844
                mergeable = bundle.read_mergeable_from_url(location,
3891
3905
    def _do_preview(self, merger):
3892
3906
        from bzrlib.diff import show_diff_trees
3893
3907
        result_tree = self._get_preview(merger)
3894
 
        path_encoding = osutils.get_diff_header_encoding()
3895
3908
        show_diff_trees(merger.this_tree, result_tree, self.outf,
3896
 
                        old_label='', new_label='',
3897
 
                        path_encoding=path_encoding)
 
3909
                        old_label='', new_label='')
3898
3910
 
3899
3911
    def _do_merge(self, merger, change_reporter, allow_pending, verified):
3900
3912
        merger.change_reporter = change_reporter
4088
4100
        if merge_type is None:
4089
4101
            merge_type = _mod_merge.Merge3Merger
4090
4102
        tree, file_list = tree_files(file_list)
4091
 
        self.add_cleanup(tree.lock_write().unlock)
 
4103
        tree.lock_write()
 
4104
        self.add_cleanup(tree.unlock)
4092
4105
        parents = tree.get_parent_ids()
4093
4106
        if len(parents) != 2:
4094
4107
            raise errors.BzrCommandError("Sorry, remerge only works after normal"
4204
4217
    def run(self, revision=None, no_backup=False, file_list=None,
4205
4218
            forget_merges=None):
4206
4219
        tree, file_list = tree_files(file_list)
4207
 
        self.add_cleanup(tree.lock_tree_write().unlock)
 
4220
        tree.lock_tree_write()
 
4221
        self.add_cleanup(tree.unlock)
4208
4222
        if forget_merges:
4209
4223
            tree.set_parent_ids(tree.get_parent_ids()[:1])
4210
4224
        else:
4299
4313
    _see_also = ['merge', 'pull']
4300
4314
    takes_args = ['other_branch?']
4301
4315
    takes_options = [
4302
 
        'directory',
4303
4316
        Option('reverse', 'Reverse the order of revisions.'),
4304
4317
        Option('mine-only',
4305
4318
               'Display changes in the local branch only.'),
4327
4340
            theirs_only=False,
4328
4341
            log_format=None, long=False, short=False, line=False,
4329
4342
            show_ids=False, verbose=False, this=False, other=False,
4330
 
            include_merges=False, revision=None, my_revision=None,
4331
 
            directory=u'.'):
 
4343
            include_merges=False, revision=None, my_revision=None):
4332
4344
        from bzrlib.missing import find_unmerged, iter_log_revisions
4333
4345
        def message(s):
4334
4346
            if not is_quiet():
4347
4359
        elif theirs_only:
4348
4360
            restrict = 'remote'
4349
4361
 
4350
 
        local_branch = Branch.open_containing(directory)[0]
4351
 
        self.add_cleanup(local_branch.lock_read().unlock)
 
4362
        local_branch = Branch.open_containing(u".")[0]
 
4363
        local_branch.lock_read()
 
4364
        self.add_cleanup(local_branch.unlock)
4352
4365
 
4353
4366
        parent = local_branch.get_parent()
4354
4367
        if other_branch is None:
4365
4378
        if remote_branch.base == local_branch.base:
4366
4379
            remote_branch = local_branch
4367
4380
        else:
4368
 
            self.add_cleanup(remote_branch.lock_read().unlock)
 
4381
            remote_branch.lock_read()
 
4382
            self.add_cleanup(remote_branch.unlock)
4369
4383
 
4370
4384
        local_revid_range = _revision_range_to_revid_range(
4371
4385
            _get_revision_range(my_revision, local_branch,
4426
4440
            message("Branches are up to date.\n")
4427
4441
        self.cleanup_now()
4428
4442
        if not status_code and parent is None and other_branch is not None:
4429
 
            self.add_cleanup(local_branch.lock_write().unlock)
 
4443
            local_branch.lock_write()
 
4444
            self.add_cleanup(local_branch.unlock)
4430
4445
            # handle race conditions - a parent might be set while we run.
4431
4446
            if local_branch.get_parent() is None:
4432
4447
                local_branch.set_parent(remote_branch.base)
4532
4547
            b = Branch.open_containing(branch)[0]
4533
4548
        else:
4534
4549
            b = Branch.open(branch)
4535
 
        self.add_cleanup(b.lock_read().unlock)
 
4550
        b.lock_read()
 
4551
        self.add_cleanup(b.unlock)
4536
4552
        if revision is None:
4537
4553
            rev_id = b.last_revision()
4538
4554
        else:
4562
4578
                     Option('long', help='Show commit date in annotations.'),
4563
4579
                     'revision',
4564
4580
                     'show-ids',
4565
 
                     'directory',
4566
4581
                     ]
4567
4582
    encoding_type = 'exact'
4568
4583
 
4569
4584
    @display_command
4570
4585
    def run(self, filename, all=False, long=False, revision=None,
4571
 
            show_ids=False, directory=None):
 
4586
            show_ids=False):
4572
4587
        from bzrlib.annotate import annotate_file, annotate_file_tree
4573
4588
        wt, branch, relpath = \
4574
 
            _open_directory_or_containing_tree_or_branch(filename, directory)
 
4589
            bzrdir.BzrDir.open_containing_tree_or_branch(filename)
4575
4590
        if wt is not None:
4576
 
            self.add_cleanup(wt.lock_read().unlock)
 
4591
            wt.lock_read()
 
4592
            self.add_cleanup(wt.unlock)
4577
4593
        else:
4578
 
            self.add_cleanup(branch.lock_read().unlock)
 
4594
            branch.lock_read()
 
4595
            self.add_cleanup(branch.unlock)
4579
4596
        tree = _get_one_revision_tree('annotate', revision, branch=branch)
4580
 
        self.add_cleanup(tree.lock_read().unlock)
 
4597
        tree.lock_read()
 
4598
        self.add_cleanup(tree.unlock)
4581
4599
        if wt is not None:
4582
4600
            file_id = wt.path2id(relpath)
4583
4601
        else:
4601
4619
 
4602
4620
    hidden = True # is this right ?
4603
4621
    takes_args = ['revision_id*']
4604
 
    takes_options = ['directory', 'revision']
 
4622
    takes_options = ['revision']
4605
4623
 
4606
 
    def run(self, revision_id_list=None, revision=None, directory=u'.'):
 
4624
    def run(self, revision_id_list=None, revision=None):
4607
4625
        if revision_id_list is not None and revision is not None:
4608
4626
            raise errors.BzrCommandError('You can only supply one of revision_id or --revision')
4609
4627
        if revision_id_list is None and revision is None:
4610
4628
            raise errors.BzrCommandError('You must supply either --revision or a revision_id')
4611
 
        b = WorkingTree.open_containing(directory)[0].branch
4612
 
        self.add_cleanup(b.lock_write().unlock)
 
4629
        b = WorkingTree.open_containing(u'.')[0].branch
 
4630
        b.lock_write()
 
4631
        self.add_cleanup(b.unlock)
4613
4632
        return self._run(b, revision_id_list, revision)
4614
4633
 
4615
4634
    def _run(self, b, revision_id_list, revision):
4674
4693
 
4675
4694
    _see_also = ['checkouts', 'unbind']
4676
4695
    takes_args = ['location?']
4677
 
    takes_options = ['directory']
 
4696
    takes_options = []
4678
4697
 
4679
 
    def run(self, location=None, directory=u'.'):
4680
 
        b, relpath = Branch.open_containing(directory)
 
4698
    def run(self, location=None):
 
4699
        b, relpath = Branch.open_containing(u'.')
4681
4700
        if location is None:
4682
4701
            try:
4683
4702
                location = b.get_old_bound_location()
4710
4729
 
4711
4730
    _see_also = ['checkouts', 'bind']
4712
4731
    takes_args = []
4713
 
    takes_options = ['directory']
 
4732
    takes_options = []
4714
4733
 
4715
 
    def run(self, directory=u'.'):
4716
 
        b, relpath = Branch.open_containing(directory)
 
4734
    def run(self):
 
4735
        b, relpath = Branch.open_containing(u'.')
4717
4736
        if not b.unbind():
4718
4737
            raise errors.BzrCommandError('Local branch is not bound')
4719
4738
 
4765
4784
            b = control.open_branch()
4766
4785
 
4767
4786
        if tree is not None:
4768
 
            self.add_cleanup(tree.lock_write().unlock)
 
4787
            tree.lock_write()
 
4788
            self.add_cleanup(tree.unlock)
4769
4789
        else:
4770
 
            self.add_cleanup(b.lock_write().unlock)
 
4790
            b.lock_write()
 
4791
            self.add_cleanup(b.unlock)
4771
4792
        return self._run(b, tree, dry_run, verbose, revision, force, local=local)
4772
4793
 
4773
4794
    def _run(self, b, tree, dry_run, verbose, revision, force, local=False):
4881
4902
                    'result in a dynamically allocated port.  The default port '
4882
4903
                    'depends on the protocol.',
4883
4904
               type=str),
4884
 
        custom_help('directory',
4885
 
               help='Serve contents of this directory.'),
 
4905
        Option('directory',
 
4906
               help='Serve contents of this directory.',
 
4907
               type=unicode),
4886
4908
        Option('allow-writes',
4887
4909
               help='By default the server is a readonly server.  Supplying '
4888
4910
                    '--allow-writes enables write access to the contents of '
4915
4937
 
4916
4938
    def run(self, port=None, inet=False, directory=None, allow_writes=False,
4917
4939
            protocol=None):
4918
 
        from bzrlib import transport
 
4940
        from bzrlib.transport import get_transport, transport_server_registry
4919
4941
        if directory is None:
4920
4942
            directory = os.getcwd()
4921
4943
        if protocol is None:
4922
 
            protocol = transport.transport_server_registry.get()
 
4944
            protocol = transport_server_registry.get()
4923
4945
        host, port = self.get_host_and_port(port)
4924
4946
        url = urlutils.local_path_to_url(directory)
4925
4947
        if not allow_writes:
4926
4948
            url = 'readonly+' + url
4927
 
        t = transport.get_transport(url)
4928
 
        protocol(t, host, port, inet)
 
4949
        transport = get_transport(url)
 
4950
        protocol(transport, host, port, inet)
4929
4951
 
4930
4952
 
4931
4953
class cmd_join(Command):
5024
5046
    _see_also = ['send']
5025
5047
 
5026
5048
    takes_options = [
5027
 
        'directory',
5028
5049
        RegistryOption.from_kwargs('patch-type',
5029
5050
            'The type of patch to include in the directive.',
5030
5051
            title='Patch type',
5043
5064
    encoding_type = 'exact'
5044
5065
 
5045
5066
    def run(self, submit_branch=None, public_branch=None, patch_type='bundle',
5046
 
            sign=False, revision=None, mail_to=None, message=None,
5047
 
            directory=u'.'):
 
5067
            sign=False, revision=None, mail_to=None, message=None):
5048
5068
        from bzrlib.revision import ensure_null, NULL_REVISION
5049
5069
        include_patch, include_bundle = {
5050
5070
            'plain': (False, False),
5051
5071
            'diff': (True, False),
5052
5072
            'bundle': (True, True),
5053
5073
            }[patch_type]
5054
 
        branch = Branch.open(directory)
 
5074
        branch = Branch.open('.')
5055
5075
        stored_submit_branch = branch.get_submit_branch()
5056
5076
        if submit_branch is None:
5057
5077
            submit_branch = stored_submit_branch
5142
5162
    given, in which case it is sent to a file.
5143
5163
 
5144
5164
    Mail is sent using your preferred mail program.  This should be transparent
5145
 
    on Windows (it uses MAPI).  On Unix, it requires the xdg-email utility.
 
5165
    on Windows (it uses MAPI).  On Linux, it requires the xdg-email utility.
5146
5166
    If the preferred client can't be found (or used), your editor will be used.
5147
5167
 
5148
5168
    To use a specific mail program, set the mail_client configuration option.
5319
5339
        Option('delete',
5320
5340
            help='Delete this tag rather than placing it.',
5321
5341
            ),
5322
 
        custom_help('directory',
5323
 
            help='Branch in which to place the tag.'),
 
5342
        Option('directory',
 
5343
            help='Branch in which to place the tag.',
 
5344
            short_name='d',
 
5345
            type=unicode,
 
5346
            ),
5324
5347
        Option('force',
5325
5348
            help='Replace existing tags.',
5326
5349
            ),
5334
5357
            revision=None,
5335
5358
            ):
5336
5359
        branch, relpath = Branch.open_containing(directory)
5337
 
        self.add_cleanup(branch.lock_write().unlock)
 
5360
        branch.lock_write()
 
5361
        self.add_cleanup(branch.unlock)
5338
5362
        if delete:
5339
5363
            if tag_name is None:
5340
5364
                raise errors.BzrCommandError("No tag specified to delete.")
5368
5392
 
5369
5393
    _see_also = ['tag']
5370
5394
    takes_options = [
5371
 
        custom_help('directory',
5372
 
            help='Branch whose tags should be displayed.'),
 
5395
        Option('directory',
 
5396
            help='Branch whose tags should be displayed.',
 
5397
            short_name='d',
 
5398
            type=unicode,
 
5399
            ),
5373
5400
        RegistryOption.from_kwargs('sort',
5374
5401
            'Sort tags by different criteria.', title='Sorting',
5375
5402
            alpha='Sort tags lexicographically (default).',
5392
5419
        if not tags:
5393
5420
            return
5394
5421
 
5395
 
        self.add_cleanup(branch.lock_read().unlock)
 
5422
        branch.lock_read()
 
5423
        self.add_cleanup(branch.unlock)
5396
5424
        if revision:
5397
5425
            graph = branch.repository.get_graph()
5398
5426
            rev1, rev2 = _get_revision_range(revision, branch, self.name())
5545
5573
    """
5546
5574
 
5547
5575
    takes_args = ['to_location?']
5548
 
    takes_options = ['directory',
5549
 
                     Option('force',
 
5576
    takes_options = [Option('force',
5550
5577
                        help='Switch even if local commits will be lost.'),
5551
5578
                     'revision',
5552
5579
                     Option('create-branch', short_name='b',
5555
5582
                    ]
5556
5583
 
5557
5584
    def run(self, to_location=None, force=False, create_branch=False,
5558
 
            revision=None, directory=u'.'):
 
5585
            revision=None):
5559
5586
        from bzrlib import switch
5560
 
        tree_location = directory
 
5587
        tree_location = '.'
5561
5588
        revision = _get_one_revision('switch', revision)
5562
5589
        control_dir = bzrdir.BzrDir.open_containing(tree_location)[0]
5563
5590
        if to_location is None:
5564
5591
            if revision is None:
5565
5592
                raise errors.BzrCommandError('You must supply either a'
5566
5593
                                             ' revision or a location')
5567
 
            to_location = tree_location
 
5594
            to_location = '.'
5568
5595
        try:
5569
5596
            branch = control_dir.open_branch()
5570
5597
            had_explicit_nick = branch.get_config().has_explicit_nickname()
5845
5872
    takes_args = ['file*']
5846
5873
 
5847
5874
    takes_options = [
5848
 
        'directory',
5849
5875
        'revision',
5850
5876
        Option('all', help='Shelve all changes.'),
5851
5877
        'message',
5860
5886
    _see_also = ['unshelve']
5861
5887
 
5862
5888
    def run(self, revision=None, all=False, file_list=None, message=None,
5863
 
            writer=None, list=False, destroy=False, directory=u'.'):
 
5889
            writer=None, list=False, destroy=False):
5864
5890
        if list:
5865
5891
            return self.run_for_list()
5866
5892
        from bzrlib.shelf_ui import Shelver
5868
5894
            writer = bzrlib.option.diff_writer_registry.get()
5869
5895
        try:
5870
5896
            shelver = Shelver.from_args(writer(sys.stdout), revision, all,
5871
 
                file_list, message, destroy=destroy, directory=directory)
 
5897
                file_list, message, destroy=destroy)
5872
5898
            try:
5873
5899
                shelver.run()
5874
5900
            finally:
5878
5904
 
5879
5905
    def run_for_list(self):
5880
5906
        tree = WorkingTree.open_containing('.')[0]
5881
 
        self.add_cleanup(tree.lock_read().unlock)
 
5907
        tree.lock_read()
 
5908
        self.add_cleanup(tree.unlock)
5882
5909
        manager = tree.get_shelf_manager()
5883
5910
        shelves = manager.active_shelves()
5884
5911
        if len(shelves) == 0:
5902
5929
 
5903
5930
    takes_args = ['shelf_id?']
5904
5931
    takes_options = [
5905
 
        'directory',
5906
5932
        RegistryOption.from_kwargs(
5907
5933
            'action', help="The action to perform.",
5908
5934
            enum_switch=False, value_switches=True,
5916
5942
    ]
5917
5943
    _see_also = ['shelve']
5918
5944
 
5919
 
    def run(self, shelf_id=None, action='apply', directory=u'.'):
 
5945
    def run(self, shelf_id=None, action='apply'):
5920
5946
        from bzrlib.shelf_ui import Unshelver
5921
 
        unshelver = Unshelver.from_args(shelf_id, action, directory=directory)
 
5947
        unshelver = Unshelver.from_args(shelf_id, action)
5922
5948
        try:
5923
5949
            unshelver.run()
5924
5950
        finally:
5940
5966
 
5941
5967
    To check what clean-tree will do, use --dry-run.
5942
5968
    """
5943
 
    takes_options = ['directory',
5944
 
                     Option('ignored', help='Delete all ignored files.'),
 
5969
    takes_options = [Option('ignored', help='Delete all ignored files.'),
5945
5970
                     Option('detritus', help='Delete conflict files, merge'
5946
5971
                            ' backups, and failed selftest dirs.'),
5947
5972
                     Option('unknown',
5950
5975
                            ' deleting them.'),
5951
5976
                     Option('force', help='Do not prompt before deleting.')]
5952
5977
    def run(self, unknown=False, ignored=False, detritus=False, dry_run=False,
5953
 
            force=False, directory=u'.'):
 
5978
            force=False):
5954
5979
        from bzrlib.clean_tree import clean_tree
5955
5980
        if not (unknown or ignored or detritus):
5956
5981
            unknown = True
5957
5982
        if dry_run:
5958
5983
            force = True
5959
 
        clean_tree(directory, unknown=unknown, ignored=ignored,
5960
 
                   detritus=detritus, dry_run=dry_run, no_prompt=force)
 
5984
        clean_tree('.', unknown=unknown, ignored=ignored, detritus=detritus,
 
5985
                   dry_run=dry_run, no_prompt=force)
5961
5986
 
5962
5987
 
5963
5988
class cmd_reference(Command):