/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Robert Collins
  • Date: 2010-05-06 11:08:10 UTC
  • mto: This revision was merged to the branch mainline in revision 5223.
  • Revision ID: robertc@robertcollins.net-20100506110810-h3j07fh5gmw54s25
Cleaner matcher matching revised unlocking protocol.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
 
1
# Copyright (C) 2005-2010 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
import difflib
18
18
import os
19
19
import re
20
 
import shutil
 
20
import string
21
21
import sys
22
22
 
23
23
from bzrlib.lazy_import import lazy_import
28
28
import time
29
29
 
30
30
from bzrlib import (
 
31
    branch as _mod_branch,
31
32
    bzrdir,
32
 
    commands,
 
33
    cmdline,
 
34
    cleanup,
33
35
    errors,
34
36
    osutils,
35
37
    patiencediff,
36
38
    textfile,
37
39
    timestamp,
 
40
    views,
38
41
    )
 
42
 
 
43
from bzrlib.workingtree import WorkingTree
39
44
""")
40
45
 
 
46
from bzrlib.registry import (
 
47
    Registry,
 
48
    )
41
49
from bzrlib.symbol_versioning import (
42
 
        deprecated_function,
43
 
        one_zero,
44
 
        )
45
 
from bzrlib.trace import mutter, warning
 
50
    deprecated_function,
 
51
    deprecated_in,
 
52
    )
 
53
from bzrlib.trace import mutter, note, warning
 
54
 
 
55
 
 
56
class AtTemplate(string.Template):
 
57
    """Templating class that uses @ instead of $."""
 
58
 
 
59
    delimiter = '@'
46
60
 
47
61
 
48
62
# TODO: Rather than building a changeset object, we should probably
77
91
    # both sequences are empty.
78
92
    if not oldlines and not newlines:
79
93
        return
80
 
    
 
94
 
81
95
    if allow_binary is False:
82
96
        textfile.check_text_lines(oldlines)
83
97
        textfile.check_text_lines(newlines)
98
112
        ud[2] = ud[2].replace('-1,0', '-0,0')
99
113
    elif not newlines:
100
114
        ud[2] = ud[2].replace('+1,0', '+0,0')
101
 
    # work around for difflib emitting random spaces after the label
102
 
    ud[0] = ud[0][:-2] + '\n'
103
 
    ud[1] = ud[1][:-2] + '\n'
104
115
 
105
116
    for line in ud:
106
117
        to_file.write(line)
173
184
 
174
185
        if not diff_opts:
175
186
            diff_opts = []
 
187
        if sys.platform == 'win32':
 
188
            # Popen doesn't do the proper encoding for external commands
 
189
            # Since we are dealing with an ANSI api, use mbcs encoding
 
190
            old_filename = old_filename.encode('mbcs')
 
191
            new_filename = new_filename.encode('mbcs')
176
192
        diffcmd = ['diff',
177
193
                   '--label', old_filename,
178
194
                   old_abspath,
201
217
            break
202
218
        else:
203
219
            diffcmd.append('-u')
204
 
                  
 
220
 
205
221
        if diff_opts:
206
222
            diffcmd.extend(diff_opts)
207
223
 
208
224
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
209
225
        out,err = pipe.communicate()
210
226
        rc = pipe.returncode
211
 
        
 
227
 
212
228
        # internal_diff() adds a trailing newline, add one here for consistency
213
229
        out += '\n'
214
230
        if rc == 2:
249
265
                msg = 'signal %d' % (-rc)
250
266
            else:
251
267
                msg = 'exit code %d' % rc
252
 
                
253
 
            raise errors.BzrError('external diff failed with %s; command: %r' 
 
268
 
 
269
            raise errors.BzrError('external diff failed with %s; command: %r'
254
270
                                  % (rc, diffcmd))
255
271
 
256
272
 
274
290
                        new_abspath, e)
275
291
 
276
292
 
277
 
@deprecated_function(one_zero)
278
 
def diff_cmd_helper(tree, specific_files, external_diff_options, 
279
 
                    old_revision_spec=None, new_revision_spec=None,
280
 
                    revision_specs=None,
281
 
                    old_label='a/', new_label='b/'):
282
 
    """Helper for cmd_diff.
283
 
 
284
 
    :param tree:
285
 
        A WorkingTree
286
 
 
287
 
    :param specific_files:
288
 
        The specific files to compare, or None
289
 
 
290
 
    :param external_diff_options:
291
 
        If non-None, run an external diff, and pass it these options
292
 
 
293
 
    :param old_revision_spec:
294
 
        If None, use basis tree as old revision, otherwise use the tree for
295
 
        the specified revision. 
296
 
 
297
 
    :param new_revision_spec:
298
 
        If None, use working tree as new revision, otherwise use the tree for
299
 
        the specified revision.
 
293
@deprecated_function(deprecated_in((2, 2, 0)))
 
294
def get_trees_and_branches_to_diff(path_list, revision_specs, old_url, new_url,
 
295
                                   apply_view=True):
 
296
    """Get the trees and specific files to diff given a list of paths.
 
297
 
 
298
    This method works out the trees to be diff'ed and the files of
 
299
    interest within those trees.
 
300
 
 
301
    :param path_list:
 
302
        the list of arguments passed to the diff command
 
303
    :param revision_specs:
 
304
        Zero, one or two RevisionSpecs from the diff command line,
 
305
        saying what revisions to compare.
 
306
    :param old_url:
 
307
        The url of the old branch or tree. If None, the tree to use is
 
308
        taken from the first path, if any, or the current working tree.
 
309
    :param new_url:
 
310
        The url of the new branch or tree. If None, the tree to use is
 
311
        taken from the first path, if any, or the current working tree.
 
312
    :param apply_view:
 
313
        if True and a view is set, apply the view or check that the paths
 
314
        are within it
 
315
    :returns:
 
316
        a tuple of (old_tree, new_tree, old_branch, new_branch,
 
317
        specific_files, extra_trees) where extra_trees is a sequence of
 
318
        additional trees to search in for file-ids.  The trees and branches
 
319
        are not locked.
 
320
    """
 
321
    op = cleanup.OperationWithCleanups(get_trees_and_branches_to_diff_locked)
 
322
    return op.run_simple(path_list, revision_specs, old_url, new_url,
 
323
            op.add_cleanup, apply_view=apply_view)
300
324
    
301
 
    :param revision_specs: 
302
 
        Zero, one or two RevisionSpecs from the command line, saying what revisions 
303
 
        to compare.  This can be passed as an alternative to the old_revision_spec 
304
 
        and new_revision_spec parameters.
305
 
 
306
 
    The more general form is show_diff_trees(), where the caller
307
 
    supplies any two trees.
308
 
    """
309
 
 
310
 
    # TODO: perhaps remove the old parameters old_revision_spec and
311
 
    # new_revision_spec, since this is only really for use from cmd_diff and
312
 
    # it now always passes through a sequence of revision_specs -- mbp
313
 
    # 20061221
314
 
 
315
 
    def spec_tree(spec):
316
 
        if tree:
317
 
            revision = spec.in_store(tree.branch)
318
 
        else:
319
 
            revision = spec.in_store(None)
320
 
        revision_id = revision.rev_id
321
 
        branch = revision.branch
322
 
        return branch.repository.revision_tree(revision_id)
323
 
 
324
 
    if revision_specs is not None:
325
 
        assert (old_revision_spec is None
326
 
                and new_revision_spec is None)
327
 
        if len(revision_specs) > 0:
328
 
            old_revision_spec = revision_specs[0]
329
 
        if len(revision_specs) > 1:
330
 
            new_revision_spec = revision_specs[1]
331
 
 
332
 
    if old_revision_spec is None:
333
 
        old_tree = tree.basis_tree()
334
 
    else:
335
 
        old_tree = spec_tree(old_revision_spec)
336
 
 
337
 
    if (new_revision_spec is None
338
 
        or new_revision_spec.spec is None):
339
 
        new_tree = tree
340
 
    else:
341
 
        new_tree = spec_tree(new_revision_spec)
342
 
 
343
 
    if new_tree is not tree:
344
 
        extra_trees = (tree,)
345
 
    else:
346
 
        extra_trees = None
347
 
 
348
 
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
349
 
                           external_diff_options,
350
 
                           old_label=old_label, new_label=new_label,
351
 
                           extra_trees=extra_trees)
352
 
 
353
 
 
354
 
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url):
 
325
 
 
326
def get_trees_and_branches_to_diff_locked(
 
327
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
355
328
    """Get the trees and specific files to diff given a list of paths.
356
329
 
357
330
    This method works out the trees to be diff'ed and the files of
368
341
    :param new_url:
369
342
        The url of the new branch or tree. If None, the tree to use is
370
343
        taken from the first path, if any, or the current working tree.
 
344
    :param add_cleanup:
 
345
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
 
346
        will register cleanups that must be run to unlock the trees, etc.
 
347
    :param apply_view:
 
348
        if True and a view is set, apply the view or check that the paths
 
349
        are within it
371
350
    :returns:
372
 
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
373
 
        extra_trees is a sequence of additional trees to search in for
374
 
        file-ids.
 
351
        a tuple of (old_tree, new_tree, old_branch, new_branch,
 
352
        specific_files, extra_trees) where extra_trees is a sequence of
 
353
        additional trees to search in for file-ids.  The trees and branches
 
354
        will be read-locked until the cleanups registered via the add_cleanup
 
355
        param are run.
375
356
    """
376
357
    # Get the old and new revision specs
377
358
    old_revision_spec = None
400
381
        default_location = path_list[0]
401
382
        other_paths = path_list[1:]
402
383
 
 
384
    def lock_tree_or_branch(wt, br):
 
385
        if wt is not None:
 
386
            wt.lock_read()
 
387
            add_cleanup(wt.unlock)
 
388
        elif br is not None:
 
389
            br.lock_read()
 
390
            add_cleanup(br.unlock)
 
391
 
403
392
    # Get the old location
404
393
    specific_files = []
405
394
    if old_url is None:
406
395
        old_url = default_location
407
396
    working_tree, branch, relpath = \
408
397
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
 
398
    lock_tree_or_branch(working_tree, branch)
409
399
    if consider_relpath and relpath != '':
 
400
        if working_tree is not None and apply_view:
 
401
            views.check_path_in_view(working_tree, relpath)
410
402
        specific_files.append(relpath)
411
403
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
 
404
    old_branch = branch
412
405
 
413
406
    # Get the new location
414
407
    if new_url is None:
416
409
    if new_url != old_url:
417
410
        working_tree, branch, relpath = \
418
411
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
 
412
        lock_tree_or_branch(working_tree, branch)
419
413
        if consider_relpath and relpath != '':
 
414
            if working_tree is not None and apply_view:
 
415
                views.check_path_in_view(working_tree, relpath)
420
416
            specific_files.append(relpath)
421
417
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
422
418
        basis_is_default=working_tree is None)
 
419
    new_branch = branch
423
420
 
424
421
    # Get the specific files (all files is None, no files is [])
425
422
    if make_paths_wt_relative and working_tree is not None:
426
 
        other_paths = _relative_paths_in_tree(working_tree, other_paths)
 
423
        try:
 
424
            from bzrlib.builtins import safe_relpath_files
 
425
            other_paths = safe_relpath_files(working_tree, other_paths,
 
426
            apply_view=apply_view)
 
427
        except errors.FileInWrongBranch:
 
428
            raise errors.BzrCommandError("Files are in different branches")
427
429
    specific_files.extend(other_paths)
428
430
    if len(specific_files) == 0:
429
431
        specific_files = None
 
432
        if (working_tree is not None and working_tree.supports_views()
 
433
            and apply_view):
 
434
            view_files = working_tree.views.lookup_view()
 
435
            if view_files:
 
436
                specific_files = view_files
 
437
                view_str = views.view_display_str(view_files)
 
438
                note("*** Ignoring files outside view. View is %s" % view_str)
430
439
 
431
440
    # Get extra trees that ought to be searched for file-ids
432
441
    extra_trees = None
433
442
    if working_tree is not None and working_tree not in (old_tree, new_tree):
434
443
        extra_trees = (working_tree,)
435
 
    return old_tree, new_tree, specific_files, extra_trees
 
444
    return old_tree, new_tree, old_branch, new_branch, specific_files, extra_trees
436
445
 
437
446
 
438
447
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
446
455
                return branch.basis_tree()
447
456
        else:
448
457
            return tree
449
 
    revision = spec.in_store(branch)
450
 
    revision_id = revision.rev_id
451
 
    rev_branch = revision.branch
452
 
    return rev_branch.repository.revision_tree(revision_id)
453
 
 
454
 
 
455
 
def _relative_paths_in_tree(tree, paths):
456
 
    """Get the relative paths within a working tree.
457
 
 
458
 
    Each path may be either an absolute path or a path relative to the
459
 
    current working directory.
460
 
    """
461
 
    result = []
462
 
    for filename in paths:
463
 
        try:
464
 
            result.append(tree.relpath(osutils.dereference_path(filename)))
465
 
        except errors.PathNotChild:
466
 
            raise errors.BzrCommandError("Files are in different branches")
467
 
    return result
 
458
    return spec.as_tree(branch)
468
459
 
469
460
 
470
461
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
472
463
                    old_label='a/', new_label='b/',
473
464
                    extra_trees=None,
474
465
                    path_encoding='utf8',
475
 
                    using=None):
 
466
                    using=None,
 
467
                    format_cls=None):
476
468
    """Show in text form the changes from one tree to another.
477
469
 
478
 
    to_file
479
 
        The output stream.
480
 
 
481
 
    specific_files
482
 
        Include only changes to these files - None for all changes.
483
 
 
484
 
    external_diff_options
485
 
        If set, use an external GNU diff and pass these options.
486
 
 
487
 
    extra_trees
488
 
        If set, more Trees to use for looking up file ids
489
 
 
490
 
    path_encoding
491
 
        If set, the path will be encoded as specified, otherwise is supposed
492
 
        to be utf8
 
470
    :param to_file: The output stream.
 
471
    :param specific_files:Include only changes to these files - None for all
 
472
        changes.
 
473
    :param external_diff_options: If set, use an external GNU diff and pass 
 
474
        these options.
 
475
    :param extra_trees: If set, more Trees to use for looking up file ids
 
476
    :param path_encoding: If set, the path will be encoded as specified, 
 
477
        otherwise is supposed to be utf8
 
478
    :param format_cls: Formatter class (DiffTree subclass)
493
479
    """
 
480
    if format_cls is None:
 
481
        format_cls = DiffTree
494
482
    old_tree.lock_read()
495
483
    try:
496
484
        if extra_trees is not None:
498
486
                tree.lock_read()
499
487
        new_tree.lock_read()
500
488
        try:
501
 
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
502
 
                                                 path_encoding,
503
 
                                                 external_diff_options,
504
 
                                                 old_label, new_label, using)
 
489
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
 
490
                                                   path_encoding,
 
491
                                                   external_diff_options,
 
492
                                                   old_label, new_label, using)
505
493
            return differ.show_diff(specific_files, extra_trees)
506
494
        finally:
507
495
            new_tree.unlock()
514
502
 
515
503
def _patch_header_date(tree, file_id, path):
516
504
    """Returns a timestamp suitable for use in a patch header."""
517
 
    mtime = tree.get_file_mtime(file_id, path)
518
 
    assert mtime is not None, \
519
 
        "got an mtime of None for file-id %s, path %s in tree %s" % (
520
 
                file_id, path, tree)
 
505
    try:
 
506
        mtime = tree.get_file_mtime(file_id, path)
 
507
    except errors.FileTimestampUnavailable:
 
508
        mtime = 0
521
509
    return timestamp.format_patch_date(mtime)
522
510
 
523
511
 
524
 
def _raise_if_nonexistent(paths, old_tree, new_tree):
525
 
    """Complain if paths are not in either inventory or tree.
526
 
 
527
 
    It's OK with the files exist in either tree's inventory, or 
528
 
    if they exist in the tree but are not versioned.
529
 
    
530
 
    This can be used by operations such as bzr status that can accept
531
 
    unknown or ignored files.
532
 
    """
533
 
    mutter("check paths: %r", paths)
534
 
    if not paths:
535
 
        return
536
 
    s = old_tree.filter_unversioned_files(paths)
537
 
    s = new_tree.filter_unversioned_files(s)
538
 
    s = [path for path in s if not new_tree.has_filename(path)]
539
 
    if s:
540
 
        raise errors.PathsDoNotExist(sorted(s))
541
 
 
542
 
 
543
 
def get_prop_change(meta_modified):
544
 
    if meta_modified:
545
 
        return " (properties changed)"
 
512
def get_executable_change(old_is_x, new_is_x):
 
513
    descr = { True:"+x", False:"-x", None:"??" }
 
514
    if old_is_x != new_is_x:
 
515
        return ["%s to %s" % (descr[old_is_x], descr[new_is_x],)]
546
516
    else:
547
 
        return  ""
 
517
        return []
548
518
 
549
519
 
550
520
class DiffPath(object):
719
689
            return self.CANNOT_DIFF
720
690
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
721
691
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
722
 
        return self.diff_text(from_file_id, to_file_id, from_label, to_label)
 
692
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
 
693
            old_path, new_path)
723
694
 
724
 
    def diff_text(self, from_file_id, to_file_id, from_label, to_label):
 
695
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
 
696
        from_path=None, to_path=None):
725
697
        """Diff the content of given files in two trees
726
698
 
727
699
        :param from_file_id: The id of the file in the from tree.  If None,
729
701
        :param to_file_id: The id of the file in the to tree.  This may refer
730
702
            to a different file from from_file_id.  If None,
731
703
            the file is not present in the to tree.
 
704
        :param from_path: The path in the from tree or None if unknown.
 
705
        :param to_path: The path in the to tree or None if unknown.
732
706
        """
733
 
        def _get_text(tree, file_id):
 
707
        def _get_text(tree, file_id, path):
734
708
            if file_id is not None:
735
 
                return tree.get_file(file_id).readlines()
 
709
                return tree.get_file(file_id, path).readlines()
736
710
            else:
737
711
                return []
738
712
        try:
739
 
            from_text = _get_text(self.old_tree, from_file_id)
740
 
            to_text = _get_text(self.new_tree, to_file_id)
 
713
            from_text = _get_text(self.old_tree, from_file_id, from_path)
 
714
            to_text = _get_text(self.new_tree, to_file_id, to_path)
741
715
            self.text_differ(from_label, from_text, to_label, to_text,
742
716
                             self.to_file)
743
717
        except errors.BinaryFile:
753
727
                 path_encoding='utf-8'):
754
728
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
755
729
        self.command_template = command_template
756
 
        self._root = tempfile.mkdtemp(prefix='bzr-diff-')
 
730
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
757
731
 
758
732
    @classmethod
759
733
    def from_string(klass, command_string, old_tree, new_tree, to_file,
760
734
                    path_encoding='utf-8'):
761
 
        command_template = commands.shlex_split_unicode(command_string)
762
 
        command_template.extend(['%(old_path)s', '%(new_path)s'])
 
735
        command_template = cmdline.split(command_string)
 
736
        if '@' not in command_string:
 
737
            command_template.extend(['@old_path', '@new_path'])
763
738
        return klass(command_template, old_tree, new_tree, to_file,
764
739
                     path_encoding)
765
740
 
772
747
 
773
748
    def _get_command(self, old_path, new_path):
774
749
        my_map = {'old_path': old_path, 'new_path': new_path}
775
 
        return [t % my_map for t in self.command_template]
 
750
        return [AtTemplate(t).substitute(my_map) for t in
 
751
                self.command_template]
776
752
 
777
753
    def _execute(self, old_path, new_path):
778
754
        command = self._get_command(old_path, new_path)
788
764
        return proc.wait()
789
765
 
790
766
    def _try_symlink_root(self, tree, prefix):
791
 
        if not (getattr(tree, 'abspath', None) is not None
792
 
                and osutils.has_symlinks()):
 
767
        if (getattr(tree, 'abspath', None) is None
 
768
            or not osutils.host_os_dereferences_symlinks()):
793
769
            return False
794
770
        try:
795
771
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
798
774
                raise
799
775
        return True
800
776
 
801
 
    def _write_file(self, file_id, tree, prefix, relpath):
 
777
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
 
778
                    allow_write=False):
 
779
        if not force_temp and isinstance(tree, WorkingTree):
 
780
            return tree.abspath(tree.id2path(file_id))
 
781
        
802
782
        full_path = osutils.pathjoin(self._root, prefix, relpath)
803
 
        if self._try_symlink_root(tree, prefix):
 
783
        if not force_temp and self._try_symlink_root(tree, prefix):
804
784
            return full_path
805
785
        parent_dir = osutils.dirname(full_path)
806
786
        try:
817
797
                target.close()
818
798
        finally:
819
799
            source.close()
820
 
        osutils.make_readonly(full_path)
821
 
        mtime = tree.get_file_mtime(file_id)
822
 
        os.utime(full_path, (mtime, mtime))
 
800
        try:
 
801
            mtime = tree.get_file_mtime(file_id)
 
802
        except errors.FileTimestampUnavailable:
 
803
            pass
 
804
        else:
 
805
            os.utime(full_path, (mtime, mtime))
 
806
        if not allow_write:
 
807
            osutils.make_readonly(full_path)
823
808
        return full_path
824
809
 
825
 
    def _prepare_files(self, file_id, old_path, new_path):
 
810
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
 
811
                       allow_write_new=False):
826
812
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
827
 
                                         old_path)
 
813
                                         old_path, force_temp)
828
814
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
829
 
                                         new_path)
 
815
                                         new_path, force_temp,
 
816
                                         allow_write=allow_write_new)
830
817
        return old_disk_path, new_disk_path
831
818
 
832
819
    def finish(self):
833
 
        osutils.rmtree(self._root)
 
820
        try:
 
821
            osutils.rmtree(self._root)
 
822
        except OSError, e:
 
823
            if e.errno != errno.ENOENT:
 
824
                mutter("The temporary directory \"%s\" was not "
 
825
                        "cleanly removed: %s." % (self._root, e))
834
826
 
835
827
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
836
828
        if (old_kind, new_kind) != ('file', 'file'):
837
829
            return DiffPath.CANNOT_DIFF
838
 
        self._prepare_files(file_id, old_path, new_path)
839
 
        self._execute(osutils.pathjoin('old', old_path),
840
 
                      osutils.pathjoin('new', new_path))
 
830
        (old_disk_path, new_disk_path) = self._prepare_files(
 
831
                                                file_id, old_path, new_path)
 
832
        self._execute(old_disk_path, new_disk_path)
 
833
 
 
834
    def edit_file(self, file_id):
 
835
        """Use this tool to edit a file.
 
836
 
 
837
        A temporary copy will be edited, and the new contents will be
 
838
        returned.
 
839
 
 
840
        :param file_id: The id of the file to edit.
 
841
        :return: The new contents of the file.
 
842
        """
 
843
        old_path = self.old_tree.id2path(file_id)
 
844
        new_path = self.new_tree.id2path(file_id)
 
845
        new_abs_path = self._prepare_files(file_id, old_path, new_path,
 
846
                                           allow_write_new=True,
 
847
                                           force_temp=True)[1]
 
848
        command = self._get_command(osutils.pathjoin('old', old_path),
 
849
                                    osutils.pathjoin('new', new_path))
 
850
        subprocess.call(command, cwd=self._root)
 
851
        new_file = open(new_abs_path, 'r')
 
852
        try:
 
853
            return new_file.read()
 
854
        finally:
 
855
            new_file.close()
841
856
 
842
857
 
843
858
class DiffTree(object):
904
919
        else:
905
920
            extra_factories = []
906
921
        if external_diff_options:
907
 
            assert isinstance(external_diff_options, basestring)
908
922
            opts = external_diff_options.split()
909
923
            def diff_file(olab, olines, nlab, nlines, to_file):
910
924
                external_diff(olab, olines, nlab, nlines, to_file, opts)
918
932
    def show_diff(self, specific_files, extra_trees=None):
919
933
        """Write tree diff to self.to_file
920
934
 
921
 
        :param sepecific_files: the specific files to compare (recursive)
 
935
        :param specific_files: the specific files to compare (recursive)
922
936
        :param extra_trees: extra trees to use for mapping paths to file_ids
923
937
        """
924
938
        try:
946
960
                return path.encode(self.path_encoding, "replace")
947
961
        for (file_id, paths, changed_content, versioned, parent, name, kind,
948
962
             executable) in sorted(iterator, key=changes_key):
949
 
            if parent == (None, None):
 
963
            # The root does not get diffed, and items with no known kind (that
 
964
            # is, missing) in both trees are skipped as well.
 
965
            if parent == (None, None) or kind == (None, None):
950
966
                continue
951
967
            oldpath, newpath = paths
952
968
            oldpath_encoded = get_encoded_path(paths[0])
954
970
            old_present = (kind[0] is not None and versioned[0])
955
971
            new_present = (kind[1] is not None and versioned[1])
956
972
            renamed = (parent[0], name[0]) != (parent[1], name[1])
957
 
            prop_str = get_prop_change(executable[0] != executable[1])
 
973
 
 
974
            properties_changed = []
 
975
            properties_changed.extend(get_executable_change(executable[0], executable[1]))
 
976
 
 
977
            if properties_changed:
 
978
                prop_str = " (properties changed: %s)" % (", ".join(properties_changed),)
 
979
            else:
 
980
                prop_str = ""
 
981
 
958
982
            if (old_present, new_present) == (True, False):
959
983
                self.to_file.write("=== removed %s '%s'\n" %
960
984
                                   (kind[0], oldpath_encoded))
972
996
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
973
997
                                   newpath_encoded, prop_str))
974
998
            if changed_content:
975
 
                self.diff(file_id, oldpath, newpath)
 
999
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
976
1000
                has_changes = 1
977
1001
            if renamed:
978
1002
                has_changes = 1
993
1017
            new_kind = self.new_tree.kind(file_id)
994
1018
        except (errors.NoSuchId, errors.NoSuchFile):
995
1019
            new_kind = None
996
 
 
 
1020
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
 
1021
 
 
1022
 
 
1023
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
997
1024
        result = DiffPath._diff_many(self.differs, file_id, old_path,
998
1025
                                       new_path, old_kind, new_kind)
999
1026
        if result is DiffPath.CANNOT_DIFF:
1001
1028
            if error_path is None:
1002
1029
                error_path = old_path
1003
1030
            raise errors.NoDiffFound(error_path)
 
1031
 
 
1032
 
 
1033
format_registry = Registry()
 
1034
format_registry.register('default', DiffTree)