/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/uncommit.py

  • Committer: Robert Collins
  • Date: 2010-05-06 11:08:10 UTC
  • mto: This revision was merged to the branch mainline in revision 5223.
  • Revision ID: robertc@robertcollins.net-20100506110810-h3j07fh5gmw54s25
Cleaner matcher matching revised unlocking protocol.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/uncommit.py
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
17
"""Remove the last revision from the history of the current branch."""
18
18
 
19
19
# TODO: make the guts of this methods on tree, branch.
20
20
 
21
 
import os
22
 
 
23
21
from bzrlib import (
24
22
    errors,
25
23
    revision as _mod_revision,
35
33
    :param dry_run: Don't actually change anything
36
34
    :param verbose: Print each step as you do it
37
35
    :param revno: Remove back to this revision
 
36
    :param local: If this branch is bound, only remove the revisions from the
 
37
        local branch. If this branch is not bound, it is an error to pass
 
38
        local=True.
38
39
    """
39
40
    unlockable = []
40
41
    try:
41
42
        if tree is not None:
42
43
            tree.lock_write()
43
44
            unlockable.append(tree)
44
 
        
 
45
 
45
46
        branch.lock_write()
46
47
        unlockable.append(branch)
47
48
 
58
59
            if master is not None:
59
60
                master.lock_write()
60
61
                unlockable.append(master)
61
 
        rh = branch.revision_history()
62
 
        if master is not None and rh[-1] != master.last_revision():
 
62
        old_revno, old_tip = branch.last_revision_info()
 
63
        if master is not None and old_tip != master.last_revision():
63
64
            raise BoundBranchOutOfDate(branch, master)
64
65
        if revno is None:
65
 
            revno = len(rh)
66
 
        old_revno, old_tip = branch.last_revision_info()
67
 
        new_revno = revno -1
 
66
            revno = old_revno
 
67
        new_revno = revno - 1
68
68
 
69
 
        files_to_remove = []
70
 
        for r in range(revno-1, len(rh)):
71
 
            rev_id = rh.pop()
72
 
            # NB: performance would be better using the revision graph rather
73
 
            # than the whole revision.
74
 
            rev = branch.repository.get_revision(rev_id)
 
69
        revid_iterator = branch.repository.iter_reverse_revision_history(
 
70
                            old_tip)
 
71
        cur_revno = old_revno
 
72
        new_revision_id = old_tip
 
73
        graph = branch.repository.get_graph()
 
74
        for rev_id in revid_iterator:
 
75
            if cur_revno == new_revno:
 
76
                new_revision_id = rev_id
 
77
                break
 
78
            if verbose:
 
79
                print 'Removing revno %d: %s' % (cur_revno, rev_id)
 
80
            cur_revno -= 1
 
81
            parents = graph.get_parent_map([rev_id]).get(rev_id, None)
 
82
            if not parents:
 
83
                continue
75
84
            # When we finish popping off the pending merges, we want
76
85
            # them to stay in the order that they used to be.
77
86
            # but we pop from the end, so reverse the order, and
78
87
            # then get the order right at the end
79
 
            pending_merges.extend(reversed(rev.parent_ids[1:]))
80
 
            if verbose:
81
 
                print 'Removing revno %d: %s' % (len(rh)+1, rev_id)
 
88
            pending_merges.extend(reversed(parents[1:]))
 
89
        else:
 
90
            # We ran off the end of revisions, which means we should be trying
 
91
            # to get to NULL_REVISION
 
92
            new_revision_id = _mod_revision.NULL_REVISION
82
93
 
83
 
        # Committing before we start removing files, because
84
 
        # once we have removed at least one, all the rest are invalid.
85
94
        if not dry_run:
86
95
            if master is not None:
87
 
                master.set_revision_history(rh)
88
 
            branch.set_revision_history(rh)
89
 
            new_tip = _mod_revision.ensure_null(branch.last_revision())
 
96
                master.set_last_revision_info(new_revno, new_revision_id)
 
97
            branch.set_last_revision_info(new_revno, new_revision_id)
90
98
            if master is None:
91
99
                hook_local = None
92
100
                hook_master = branch
94
102
                hook_local = branch
95
103
                hook_master = master
96
104
            for hook in Branch.hooks['post_uncommit']:
97
 
                hook_new_tip = new_tip
 
105
                hook_new_tip = new_revision_id
98
106
                if hook_new_tip == _mod_revision.NULL_REVISION:
99
107
                    hook_new_tip = None
100
108
                hook(hook_local, hook_master, old_revno, old_tip, new_revno,
101
109
                     hook_new_tip)
102
110
            if tree is not None:
103
 
                if not _mod_revision.is_null(new_tip):
104
 
                    parents = [new_tip]
 
111
                if not _mod_revision.is_null(new_revision_id):
 
112
                    parents = [new_revision_id]
105
113
                else:
106
114
                    parents = []
107
115
                parents.extend(reversed(pending_merges))