/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/dirstate.py

  • Committer: Marius Kruger
  • Date: 2010-07-10 21:28:56 UTC
  • mto: (5384.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 5385.
  • Revision ID: marius.kruger@enerweb.co.za-20100710212856-uq4ji3go0u5se7hx
* Update documentation
* add NEWS

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2011 Canonical Ltd
 
1
# Copyright (C) 2006-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
20
20
lines by NL. The field delimiters are ommitted in the grammar, line delimiters
21
21
are not - this is done for clarity of reading. All string data is in utf8.
22
22
 
23
 
::
24
 
 
25
 
    MINIKIND = "f" | "d" | "l" | "a" | "r" | "t";
26
 
    NL = "\\n";
27
 
    NULL = "\\0";
28
 
    WHOLE_NUMBER = {digit}, digit;
29
 
    BOOLEAN = "y" | "n";
30
 
    REVISION_ID = a non-empty utf8 string;
31
 
 
32
 
    dirstate format = header line, full checksum, row count, parent details,
33
 
     ghost_details, entries;
34
 
    header line = "#bazaar dirstate flat format 3", NL;
35
 
    full checksum = "crc32: ", ["-"], WHOLE_NUMBER, NL;
36
 
    row count = "num_entries: ", WHOLE_NUMBER, NL;
37
 
    parent_details = WHOLE NUMBER, {REVISION_ID}* NL;
38
 
    ghost_details = WHOLE NUMBER, {REVISION_ID}*, NL;
39
 
    entries = {entry};
40
 
    entry = entry_key, current_entry_details, {parent_entry_details};
41
 
    entry_key = dirname,  basename, fileid;
42
 
    current_entry_details = common_entry_details, working_entry_details;
43
 
    parent_entry_details = common_entry_details, history_entry_details;
44
 
    common_entry_details = MINIKIND, fingerprint, size, executable
45
 
    working_entry_details = packed_stat
46
 
    history_entry_details = REVISION_ID;
47
 
    executable = BOOLEAN;
48
 
    size = WHOLE_NUMBER;
49
 
    fingerprint = a nonempty utf8 sequence with meaning defined by minikind.
50
 
 
51
 
Given this definition, the following is useful to know::
52
 
 
53
 
    entry (aka row) - all the data for a given key.
54
 
    entry[0]: The key (dirname, basename, fileid)
55
 
    entry[0][0]: dirname
56
 
    entry[0][1]: basename
57
 
    entry[0][2]: fileid
58
 
    entry[1]: The tree(s) data for this path and id combination.
59
 
    entry[1][0]: The current tree
60
 
    entry[1][1]: The second tree
61
 
 
62
 
For an entry for a tree, we have (using tree 0 - current tree) to demonstrate::
63
 
 
64
 
    entry[1][0][0]: minikind
65
 
    entry[1][0][1]: fingerprint
66
 
    entry[1][0][2]: size
67
 
    entry[1][0][3]: executable
68
 
    entry[1][0][4]: packed_stat
69
 
 
70
 
OR (for non tree-0)::
71
 
 
72
 
    entry[1][1][4]: revision_id
 
23
MINIKIND = "f" | "d" | "l" | "a" | "r" | "t";
 
24
NL = "\n";
 
25
NULL = "\0";
 
26
WHOLE_NUMBER = {digit}, digit;
 
27
BOOLEAN = "y" | "n";
 
28
REVISION_ID = a non-empty utf8 string;
 
29
 
 
30
dirstate format = header line, full checksum, row count, parent details,
 
31
 ghost_details, entries;
 
32
header line = "#bazaar dirstate flat format 3", NL;
 
33
full checksum = "crc32: ", ["-"], WHOLE_NUMBER, NL;
 
34
row count = "num_entries: ", WHOLE_NUMBER, NL;
 
35
parent_details = WHOLE NUMBER, {REVISION_ID}* NL;
 
36
ghost_details = WHOLE NUMBER, {REVISION_ID}*, NL;
 
37
entries = {entry};
 
38
entry = entry_key, current_entry_details, {parent_entry_details};
 
39
entry_key = dirname,  basename, fileid;
 
40
current_entry_details = common_entry_details, working_entry_details;
 
41
parent_entry_details = common_entry_details, history_entry_details;
 
42
common_entry_details = MINIKIND, fingerprint, size, executable
 
43
working_entry_details = packed_stat
 
44
history_entry_details = REVISION_ID;
 
45
executable = BOOLEAN;
 
46
size = WHOLE_NUMBER;
 
47
fingerprint = a nonempty utf8 sequence with meaning defined by minikind.
 
48
 
 
49
Given this definition, the following is useful to know:
 
50
entry (aka row) - all the data for a given key.
 
51
entry[0]: The key (dirname, basename, fileid)
 
52
entry[0][0]: dirname
 
53
entry[0][1]: basename
 
54
entry[0][2]: fileid
 
55
entry[1]: The tree(s) data for this path and id combination.
 
56
entry[1][0]: The current tree
 
57
entry[1][1]: The second tree
 
58
 
 
59
For an entry for a tree, we have (using tree 0 - current tree) to demonstrate:
 
60
entry[1][0][0]: minikind
 
61
entry[1][0][1]: fingerprint
 
62
entry[1][0][2]: size
 
63
entry[1][0][3]: executable
 
64
entry[1][0][4]: packed_stat
 
65
OR (for non tree-0)
 
66
entry[1][1][4]: revision_id
73
67
 
74
68
There may be multiple rows at the root, one per id present in the root, so the
75
 
in memory root row is now::
76
 
 
77
 
    self._dirblocks[0] -> ('', [entry ...]),
78
 
 
79
 
and the entries in there are::
80
 
 
81
 
    entries[0][0]: b''
82
 
    entries[0][1]: b''
83
 
    entries[0][2]: file_id
84
 
    entries[1][0]: The tree data for the current tree for this fileid at /
85
 
    etc.
86
 
 
87
 
Kinds::
88
 
 
89
 
   b'r' is a relocated entry: This path is not present in this tree with this
90
 
        id, but the id can be found at another location. The fingerprint is
91
 
        used to point to the target location.
92
 
   b'a' is an absent entry: In that tree the id is not present at this path.
93
 
   b'd' is a directory entry: This path in this tree is a directory with the
94
 
        current file id. There is no fingerprint for directories.
95
 
   b'f' is a file entry: As for directory, but it's a file. The fingerprint is
96
 
        the sha1 value of the file's canonical form, i.e. after any read
97
 
        filters have been applied to the convenience form stored in the working
98
 
        tree.
99
 
   b'l' is a symlink entry: As for directory, but a symlink. The fingerprint is
100
 
        the link target.
101
 
   b't' is a reference to a nested subtree; the fingerprint is the referenced
102
 
        revision.
 
69
in memory root row is now:
 
70
self._dirblocks[0] -> ('', [entry ...]),
 
71
and the entries in there are
 
72
entries[0][0]: ''
 
73
entries[0][1]: ''
 
74
entries[0][2]: file_id
 
75
entries[1][0]: The tree data for the current tree for this fileid at /
 
76
etc.
 
77
 
 
78
Kinds:
 
79
'r' is a relocated entry: This path is not present in this tree with this id,
 
80
    but the id can be found at another location. The fingerprint is used to
 
81
    point to the target location.
 
82
'a' is an absent entry: In that tree the id is not present at this path.
 
83
'd' is a directory entry: This path in this tree is a directory with the
 
84
    current file id. There is no fingerprint for directories.
 
85
'f' is a file entry: As for directory, but it's a file. The fingerprint is the
 
86
    sha1 value of the file's canonical form, i.e. after any read filters have
 
87
    been applied to the convenience form stored in the working tree.
 
88
'l' is a symlink entry: As for directory, but a symlink. The fingerprint is the
 
89
    link target.
 
90
't' is a reference to a nested subtree; the fingerprint is the referenced
 
91
    revision.
103
92
 
104
93
Ordering:
105
94
 
106
 
The entries on disk and in memory are ordered according to the following keys::
 
95
The entries on disk and in memory are ordered according to the following keys:
107
96
 
108
97
    directory, as a list of components
109
98
    filename
110
99
    file-id
111
100
 
112
101
--- Format 1 had the following different definition: ---
113
 
 
114
 
::
115
 
 
116
 
    rows = dirname, NULL, basename, NULL, MINIKIND, NULL, fileid_utf8, NULL,
117
 
        WHOLE NUMBER (* size *), NULL, packed stat, NULL, sha1|symlink target,
118
 
        {PARENT ROW}
119
 
    PARENT ROW = NULL, revision_utf8, NULL, MINIKIND, NULL, dirname, NULL,
120
 
        basename, NULL, WHOLE NUMBER (* size *), NULL, "y" | "n", NULL,
121
 
        SHA1
 
102
rows = dirname, NULL, basename, NULL, MINIKIND, NULL, fileid_utf8, NULL,
 
103
    WHOLE NUMBER (* size *), NULL, packed stat, NULL, sha1|symlink target,
 
104
    {PARENT ROW}
 
105
PARENT ROW = NULL, revision_utf8, NULL, MINIKIND, NULL, dirname, NULL,
 
106
    basename, NULL, WHOLE NUMBER (* size *), NULL, "y" | "n", NULL,
 
107
    SHA1
122
108
 
123
109
PARENT ROW's are emitted for every parent that is not in the ghosts details
124
110
line. That is, if the parents are foo, bar, baz, and the ghosts are bar, then
149
135
----
150
136
 
151
137
Design priorities:
152
 
 1. Fast end to end use for bzr's top 5 uses cases. (commmit/diff/status/merge/???)
153
 
 2. fall back current object model as needed.
154
 
 3. scale usably to the largest trees known today - say 50K entries. (mozilla
 
138
 1) Fast end to end use for bzr's top 5 uses cases. (commmit/diff/status/merge/???)
 
139
 2) fall back current object model as needed.
 
140
 3) scale usably to the largest trees known today - say 50K entries. (mozilla
155
141
    is an example of this)
156
142
 
157
143
 
158
144
Locking:
159
 
 
160
145
 Eventually reuse dirstate objects across locks IFF the dirstate file has not
161
146
 been modified, but will require that we flush/ignore cached stat-hit data
162
147
 because we won't want to restat all files on disk just because a lock was
163
148
 acquired, yet we cannot trust the data after the previous lock was released.
164
149
 
165
 
Memory representation::
166
 
 
 
150
Memory representation:
167
151
 vector of all directories, and vector of the childen ?
168
152
   i.e.
169
 
     root_entries = (direntry for root, [parent_direntries_for_root]),
 
153
     root_entrie = (direntry for root, [parent_direntries_for_root]),
170
154
     dirblocks = [
171
155
     ('', ['data for achild', 'data for bchild', 'data for cchild'])
172
156
     ('dir', ['achild', 'cchild', 'echild'])
183
167
    - What's the risk of error here? Once we have the base format being processed
184
168
      we should have a net win regardless of optimality. So we are going to
185
169
      go with what seems reasonable.
186
 
 
187
170
open questions:
188
171
 
189
172
Maybe we should do a test profile of the core structure - 10K simulated
218
201
 
219
202
"""
220
203
 
221
 
from __future__ import absolute_import
222
 
 
223
204
import bisect
 
205
import binascii
224
206
import errno
225
207
import operator
226
208
import os
227
209
from stat import S_IEXEC
228
210
import stat
 
211
import struct
229
212
import sys
230
213
import time
231
214
import zlib
232
215
 
233
 
from . import (
234
 
    inventory,
235
 
    )
236
 
from .. import (
 
216
from bzrlib import (
237
217
    cache_utf8,
238
 
    cleanup,
239
 
    config,
240
218
    debug,
241
219
    errors,
 
220
    inventory,
242
221
    lock,
243
222
    osutils,
244
 
    static_tuple,
245
223
    trace,
246
 
    urlutils,
247
 
    )
248
 
from ..sixish import (
249
 
    range,
250
 
    text_type,
251
 
    viewitems,
252
 
    viewvalues,
253
 
    )
254
 
from ..tree import TreeChange
 
224
    )
255
225
 
256
226
 
257
227
# This is the Windows equivalent of ENOTDIR
261
231
ERROR_DIRECTORY = 267
262
232
 
263
233
 
264
 
class DirstateCorrupt(errors.BzrError):
265
 
 
266
 
    _fmt = "The dirstate file (%(state)s) appears to be corrupt: %(msg)s"
267
 
 
268
 
    def __init__(self, state, msg):
269
 
        errors.BzrError.__init__(self)
270
 
        self.state = state
271
 
        self.msg = msg
 
234
if not getattr(struct, '_compile', None):
 
235
    # Cannot pre-compile the dirstate pack_stat
 
236
    def pack_stat(st, _encode=binascii.b2a_base64, _pack=struct.pack):
 
237
        """Convert stat values into a packed representation."""
 
238
        return _encode(_pack('>LLLLLL', st.st_size, int(st.st_mtime),
 
239
            int(st.st_ctime), st.st_dev, st.st_ino & 0xFFFFFFFF,
 
240
            st.st_mode))[:-1]
 
241
else:
 
242
    # compile the struct compiler we need, so as to only do it once
 
243
    from _struct import Struct
 
244
    _compiled_pack = Struct('>LLLLLL').pack
 
245
    def pack_stat(st, _encode=binascii.b2a_base64, _pack=_compiled_pack):
 
246
        """Convert stat values into a packed representation."""
 
247
        # jam 20060614 it isn't really worth removing more entries if we
 
248
        # are going to leave it in packed form.
 
249
        # With only st_mtime and st_mode filesize is 5.5M and read time is 275ms
 
250
        # With all entries, filesize is 5.9M and read time is maybe 280ms
 
251
        # well within the noise margin
 
252
 
 
253
        # base64 encoding always adds a final newline, so strip it off
 
254
        # The current version
 
255
        return _encode(_pack(st.st_size, int(st.st_mtime), int(st.st_ctime),
 
256
            st.st_dev, st.st_ino & 0xFFFFFFFF, st.st_mode))[:-1]
 
257
        # This is 0.060s / 1.520s faster by not encoding as much information
 
258
        # return _encode(_pack('>LL', int(st.st_mtime), st.st_mode))[:-1]
 
259
        # This is not strictly faster than _encode(_pack())[:-1]
 
260
        # return '%X.%X.%X.%X.%X.%X' % (
 
261
        #      st.st_size, int(st.st_mtime), int(st.st_ctime),
 
262
        #      st.st_dev, st.st_ino, st.st_mode)
 
263
        # Similar to the _encode(_pack('>LL'))
 
264
        # return '%X.%X' % (int(st.st_mtime), st.st_mode)
272
265
 
273
266
 
274
267
class SHA1Provider(object):
284
277
 
285
278
    def stat_and_sha1(self, abspath):
286
279
        """Return the stat and sha1 of a file given its absolute path.
287
 
 
 
280
        
288
281
        :param abspath:  May be a filesystem encoded absolute path
289
282
             or a unicode path.
290
283
 
303
296
 
304
297
    def stat_and_sha1(self, abspath):
305
298
        """Return the stat and sha1 of a file given its absolute path."""
306
 
        with open(abspath, 'rb') as file_obj:
 
299
        file_obj = file(abspath, 'rb')
 
300
        try:
307
301
            statvalue = os.fstat(file_obj.fileno())
308
302
            sha1 = osutils.sha_file(file_obj)
 
303
        finally:
 
304
            file_obj.close()
309
305
        return statvalue, sha1
310
306
 
311
307
 
326
322
    """
327
323
 
328
324
    _kind_to_minikind = {
329
 
        'absent': b'a',
330
 
        'file': b'f',
331
 
        'directory': b'd',
332
 
        'relocated': b'r',
333
 
        'symlink': b'l',
334
 
        'tree-reference': b't',
 
325
            'absent': 'a',
 
326
            'file': 'f',
 
327
            'directory': 'd',
 
328
            'relocated': 'r',
 
329
            'symlink': 'l',
 
330
            'tree-reference': 't',
335
331
        }
336
332
    _minikind_to_kind = {
337
 
        b'a': 'absent',
338
 
        b'f': 'file',
339
 
        b'd': 'directory',
340
 
        b'l': 'symlink',
341
 
        b'r': 'relocated',
342
 
        b't': 'tree-reference',
 
333
            'a': 'absent',
 
334
            'f': 'file',
 
335
            'd': 'directory',
 
336
            'l':'symlink',
 
337
            'r': 'relocated',
 
338
            't': 'tree-reference',
343
339
        }
344
340
    _stat_to_minikind = {
345
 
        stat.S_IFDIR: b'd',
346
 
        stat.S_IFREG: b'f',
347
 
        stat.S_IFLNK: b'l',
 
341
        stat.S_IFDIR:'d',
 
342
        stat.S_IFREG:'f',
 
343
        stat.S_IFLNK:'l',
348
344
    }
349
 
    _to_yesno = {True: b'y', False: b'n'}  # TODO profile the performance gain
350
 
    # of using int conversion rather than a dict here. AND BLAME ANDREW IF
351
 
    # it is faster.
 
345
    _to_yesno = {True:'y', False: 'n'} # TODO profile the performance gain
 
346
     # of using int conversion rather than a dict here. AND BLAME ANDREW IF
 
347
     # it is faster.
352
348
 
353
349
    # TODO: jam 20070221 Figure out what to do if we have a record that exceeds
354
350
    #       the BISECT_PAGE_SIZE. For now, we just have to make it large enough
358
354
    NOT_IN_MEMORY = 0
359
355
    IN_MEMORY_UNMODIFIED = 1
360
356
    IN_MEMORY_MODIFIED = 2
361
 
    IN_MEMORY_HASH_MODIFIED = 3  # Only hash-cache updates
362
357
 
363
358
    # A pack_stat (the x's) that is just noise and will never match the output
364
359
    # of base64 encode.
365
 
    NULLSTAT = b'x' * 32
366
 
    NULL_PARENT_DETAILS = static_tuple.StaticTuple(b'a', b'', 0, False, b'')
367
 
 
368
 
    HEADER_FORMAT_2 = b'#bazaar dirstate flat format 2\n'
369
 
    HEADER_FORMAT_3 = b'#bazaar dirstate flat format 3\n'
370
 
 
371
 
    def __init__(self, path, sha1_provider, worth_saving_limit=0,
372
 
                 use_filesystem_for_exec=True):
 
360
    NULLSTAT = 'x' * 32
 
361
    NULL_PARENT_DETAILS = ('a', '', 0, False, '')
 
362
 
 
363
    HEADER_FORMAT_2 = '#bazaar dirstate flat format 2\n'
 
364
    HEADER_FORMAT_3 = '#bazaar dirstate flat format 3\n'
 
365
 
 
366
    def __init__(self, path, sha1_provider):
373
367
        """Create a  DirState object.
374
368
 
375
369
        :param path: The path at which the dirstate file on disk should live.
376
370
        :param sha1_provider: an object meeting the SHA1Provider interface.
377
 
        :param worth_saving_limit: when the exact number of hash changed
378
 
            entries is known, only bother saving the dirstate if more than
379
 
            this count of entries have changed.
380
 
            -1 means never save hash changes, 0 means always save hash changes.
381
 
        :param use_filesystem_for_exec: Whether to trust the filesystem
382
 
            for executable bit information
383
371
        """
384
372
        # _header_state and _dirblock_state represent the current state
385
373
        # of the dirstate metadata and the per-row data respectiely.
422
410
        # during commit.
423
411
        self._last_block_index = None
424
412
        self._last_entry_index = None
425
 
        # The set of known hash changes
426
 
        self._known_hash_changes = set()
427
 
        # How many hash changed entries can we have without saving
428
 
        self._worth_saving_limit = worth_saving_limit
429
 
        self._config_stack = config.LocationStack(urlutils.local_path_to_url(
430
 
            path))
431
 
        self._use_filesystem_for_exec = use_filesystem_for_exec
432
413
 
433
414
    def __repr__(self):
434
415
        return "%s(%r)" % \
435
416
            (self.__class__.__name__, self._filename)
436
417
 
437
 
    def _mark_modified(self, hash_changed_entries=None, header_modified=False):
438
 
        """Mark this dirstate as modified.
439
 
 
440
 
        :param hash_changed_entries: if non-None, mark just these entries as
441
 
            having their hash modified.
442
 
        :param header_modified: mark the header modified as well, not just the
443
 
            dirblocks.
444
 
        """
445
 
        #trace.mutter_callsite(3, "modified hash entries: %s", hash_changed_entries)
446
 
        if hash_changed_entries:
447
 
            self._known_hash_changes.update(
448
 
                [e[0] for e in hash_changed_entries])
449
 
            if self._dirblock_state in (DirState.NOT_IN_MEMORY,
450
 
                                        DirState.IN_MEMORY_UNMODIFIED):
451
 
                # If the dirstate is already marked a IN_MEMORY_MODIFIED, then
452
 
                # that takes precedence.
453
 
                self._dirblock_state = DirState.IN_MEMORY_HASH_MODIFIED
454
 
        else:
455
 
            # TODO: Since we now have a IN_MEMORY_HASH_MODIFIED state, we
456
 
            #       should fail noisily if someone tries to set
457
 
            #       IN_MEMORY_MODIFIED but we don't have a write-lock!
458
 
            # We don't know exactly what changed so disable smart saving
459
 
            self._dirblock_state = DirState.IN_MEMORY_MODIFIED
460
 
        if header_modified:
461
 
            self._header_state = DirState.IN_MEMORY_MODIFIED
462
 
 
463
 
    def _mark_unmodified(self):
464
 
        """Mark this dirstate as unmodified."""
465
 
        self._header_state = DirState.IN_MEMORY_UNMODIFIED
466
 
        self._dirblock_state = DirState.IN_MEMORY_UNMODIFIED
467
 
        self._known_hash_changes = set()
468
 
 
469
418
    def add(self, path, file_id, kind, stat, fingerprint):
470
419
        """Add a path to be tracked.
471
420
 
472
 
        :param path: The path within the dirstate - b'' is the root, 'foo' is the
 
421
        :param path: The path within the dirstate - '' is the root, 'foo' is the
473
422
            path foo within the root, 'foo/bar' is the path bar within foo
474
423
            within the root.
475
424
        :param file_id: The file id of the path being added.
480
429
            after any read filters have been applied),
481
430
            or the target of a symlink,
482
431
            or the referenced revision id for tree-references,
483
 
            or b'' for directories.
 
432
            or '' for directories.
484
433
        """
485
434
        # adding a file:
486
435
        # find the block its in.
487
436
        # find the location in the block.
488
437
        # check its not there
489
438
        # add it.
490
 
        # ------- copied from inventory.ensure_normalized_name - keep synced.
 
439
        #------- copied from inventory.ensure_normalized_name - keep synced.
491
440
        # --- normalized_filename wants a unicode basename only, so get one.
492
441
        dirname, basename = osutils.split(path)
493
442
        # we dont import normalized_filename directly because we want to be
508
457
        utf8path = (dirname + '/' + basename).strip('/').encode('utf8')
509
458
        dirname, basename = osutils.split(utf8path)
510
459
        # uses __class__ for speed; the check is needed for safety
511
 
        if file_id.__class__ is not bytes:
 
460
        if file_id.__class__ is not str:
512
461
            raise AssertionError(
513
462
                "must be a utf8 file_id not %s" % (type(file_id), ))
514
463
        # Make sure the file_id does not exist in this tree
515
464
        rename_from = None
516
 
        file_id_entry = self._get_entry(
517
 
            0, fileid_utf8=file_id, include_deleted=True)
 
465
        file_id_entry = self._get_entry(0, fileid_utf8=file_id, include_deleted=True)
518
466
        if file_id_entry != (None, None):
519
 
            if file_id_entry[1][0][0] == b'a':
 
467
            if file_id_entry[1][0][0] == 'a':
520
468
                if file_id_entry[0] != (dirname, basename, file_id):
521
469
                    # set the old name's current operation to rename
522
470
                    self.update_minimal(file_id_entry[0],
523
 
                                        b'r',
524
 
                                        path_utf8=b'',
525
 
                                        packed_stat=b'',
526
 
                                        fingerprint=utf8path
527
 
                                        )
 
471
                        'r',
 
472
                        path_utf8='',
 
473
                        packed_stat='',
 
474
                        fingerprint=utf8path
 
475
                    )
528
476
                    rename_from = file_id_entry[0][0:2]
529
477
            else:
530
 
                path = osutils.pathjoin(
531
 
                    file_id_entry[0][0], file_id_entry[0][1])
 
478
                path = osutils.pathjoin(file_id_entry[0][0], file_id_entry[0][1])
532
479
                kind = DirState._minikind_to_kind[file_id_entry[1][0][0]]
533
480
                info = '%s:%s' % (kind, path)
534
481
                raise errors.DuplicateFileId(file_id, info)
535
 
        first_key = (dirname, basename, b'')
 
482
        first_key = (dirname, basename, '')
536
483
        block_index, present = self._find_block_index_from_key(first_key)
537
484
        if present:
538
485
            # check the path is not in the tree
539
486
            block = self._dirblocks[block_index][1]
540
487
            entry_index, _ = self._find_entry_index(first_key, block)
541
488
            while (entry_index < len(block) and
542
 
                   block[entry_index][0][0:2] == first_key[0:2]):
543
 
                if block[entry_index][1][0][0] not in (b'a', b'r'):
 
489
                block[entry_index][0][0:2] == first_key[0:2]):
 
490
                if block[entry_index][1][0][0] not in 'ar':
544
491
                    # this path is in the dirstate in the current tree.
545
 
                    raise Exception("adding already added path!")
 
492
                    raise Exception, "adding already added path!"
546
493
                entry_index += 1
547
494
        else:
548
495
            # The block where we want to put the file is not present. But it
566
513
        minikind = DirState._kind_to_minikind[kind]
567
514
        if rename_from is not None:
568
515
            if rename_from[0]:
569
 
                old_path_utf8 = b'%s/%s' % rename_from
 
516
                old_path_utf8 = '%s/%s' % rename_from
570
517
            else:
571
518
                old_path_utf8 = rename_from[1]
572
 
            parent_info[0] = (b'r', old_path_utf8, 0, False, b'')
 
519
            parent_info[0] = ('r', old_path_utf8, 0, False, '')
573
520
        if kind == 'file':
574
521
            entry_data = entry_key, [
575
522
                (minikind, fingerprint, size, False, packed_stat),
576
523
                ] + parent_info
577
524
        elif kind == 'directory':
578
525
            entry_data = entry_key, [
579
 
                (minikind, b'', 0, False, packed_stat),
 
526
                (minikind, '', 0, False, packed_stat),
580
527
                ] + parent_info
581
528
        elif kind == 'symlink':
582
529
            entry_data = entry_key, [
592
539
        if not present:
593
540
            block.insert(entry_index, entry_data)
594
541
        else:
595
 
            if block[entry_index][1][0][0] != b'a':
596
 
                raise AssertionError(" %r(%r) already added" %
597
 
                                     (basename, file_id))
 
542
            if block[entry_index][1][0][0] != 'a':
 
543
                raise AssertionError(" %r(%r) already added" % (basename, file_id))
598
544
            block[entry_index][1][0] = entry_data[1][0]
599
545
 
600
546
        if kind == 'directory':
601
 
            # insert a new dirblock
602
 
            self._ensure_block(block_index, entry_index, utf8path)
603
 
        self._mark_modified()
 
547
           # insert a new dirblock
 
548
           self._ensure_block(block_index, entry_index, utf8path)
 
549
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
604
550
        if self._id_index:
605
 
            self._add_to_id_index(self._id_index, entry_key)
 
551
            self._id_index.setdefault(entry_key[2], set()).add(entry_key)
606
552
 
607
553
    def _bisect(self, paths):
608
554
        """Bisect through the disk structure for specific rows.
620
566
        # there, this function is only meant to handle when we want to read
621
567
        # part of the disk.
622
568
        if self._dirblock_state != DirState.NOT_IN_MEMORY:
623
 
            raise AssertionError("bad dirblock state %r" %
624
 
                                 self._dirblock_state)
 
569
            raise AssertionError("bad dirblock state %r" % self._dirblock_state)
625
570
 
626
571
        # The disk representation is generally info + '\0\n\0' at the end. But
627
572
        # for bisecting, it is easier to treat this as '\0' + info + '\0\n'
630
575
        file_size = os.fstat(state_file.fileno()).st_size
631
576
        # We end up with 2 extra fields, we should have a trailing '\n' to
632
577
        # ensure that we read the whole record, and we should have a precursur
633
 
        # b'' which ensures that we start after the previous '\n'
 
578
        # '' which ensures that we start after the previous '\n'
634
579
        entry_field_count = self._fields_per_entry() + 1
635
580
 
636
581
        low = self._end_of_header
637
 
        high = file_size - 1  # Ignore the final '\0'
 
582
        high = file_size - 1 # Ignore the final '\0'
638
583
        # Map from (dir, name) => entry
639
584
        found = {}
640
585
 
641
586
        # Avoid infinite seeking
642
 
        max_count = 30 * len(paths)
 
587
        max_count = 30*len(paths)
643
588
        count = 0
644
589
        # pending is a list of places to look.
645
590
        # each entry is a tuple of low, high, dir_names
664
609
            if count > max_count:
665
610
                raise errors.BzrError('Too many seeks, most likely a bug.')
666
611
 
667
 
            mid = max(low, (low + high - page_size) // 2)
 
612
            mid = max(low, (low+high-page_size)/2)
668
613
 
669
614
            state_file.seek(mid)
670
615
            # limit the read size, so we don't end up reading data that we have
671
616
            # already read.
672
 
            read_size = min(page_size, (high - mid) + 1)
 
617
            read_size = min(page_size, (high-mid)+1)
673
618
            block = state_file.read(read_size)
674
619
 
675
620
            start = mid
676
 
            entries = block.split(b'\n')
 
621
            entries = block.split('\n')
677
622
 
678
623
            if len(entries) < 2:
679
624
                # We didn't find a '\n', so we cannot have found any records.
687
632
            # Check the first and last entries, in case they are partial, or if
688
633
            # we don't care about the rest of this page
689
634
            first_entry_num = 0
690
 
            first_fields = entries[0].split(b'\0')
 
635
            first_fields = entries[0].split('\0')
691
636
            if len(first_fields) < entry_field_count:
692
637
                # We didn't get the complete first entry
693
638
                # so move start, and grab the next, which
694
639
                # should be a full entry
695
 
                start += len(entries[0]) + 1
696
 
                first_fields = entries[1].split(b'\0')
 
640
                start += len(entries[0])+1
 
641
                first_fields = entries[1].split('\0')
697
642
                first_entry_num = 1
698
643
 
699
644
            if len(first_fields) <= 2:
707
652
                # after this first record.
708
653
                after = start
709
654
                if first_fields[1]:
710
 
                    first_path = first_fields[1] + b'/' + first_fields[2]
 
655
                    first_path = first_fields[1] + '/' + first_fields[2]
711
656
                else:
712
657
                    first_path = first_fields[2]
713
658
                first_loc = _bisect_path_left(cur_files, first_path)
722
667
                # We have files after the first entry
723
668
 
724
669
                # Parse the last entry
725
 
                last_entry_num = len(entries) - 1
726
 
                last_fields = entries[last_entry_num].split(b'\0')
 
670
                last_entry_num = len(entries)-1
 
671
                last_fields = entries[last_entry_num].split('\0')
727
672
                if len(last_fields) < entry_field_count:
728
673
                    # The very last hunk was not complete,
729
674
                    # read the previous hunk
730
675
                    after = mid + len(block) - len(entries[-1])
731
676
                    last_entry_num -= 1
732
 
                    last_fields = entries[last_entry_num].split(b'\0')
 
677
                    last_fields = entries[last_entry_num].split('\0')
733
678
                else:
734
679
                    after = mid + len(block)
735
680
 
736
681
                if last_fields[1]:
737
 
                    last_path = last_fields[1] + b'/' + last_fields[2]
 
682
                    last_path = last_fields[1] + '/' + last_fields[2]
738
683
                else:
739
684
                    last_path = last_fields[2]
740
685
                last_loc = _bisect_path_right(post, last_path)
755
700
                        post.insert(0, last_path)
756
701
 
757
702
                    # Find out what paths we have
758
 
                    paths = {first_path: [first_fields]}
 
703
                    paths = {first_path:[first_fields]}
759
704
                    # last_path might == first_path so we need to be
760
705
                    # careful if we should append rather than overwrite
761
706
                    if last_entry_num != first_entry_num:
762
707
                        paths.setdefault(last_path, []).append(last_fields)
763
 
                    for num in range(first_entry_num + 1, last_entry_num):
 
708
                    for num in xrange(first_entry_num+1, last_entry_num):
764
709
                        # TODO: jam 20070223 We are already splitting here, so
765
710
                        #       shouldn't we just split the whole thing rather
766
711
                        #       than doing the split again in add_one_record?
767
 
                        fields = entries[num].split(b'\0')
 
712
                        fields = entries[num].split('\0')
768
713
                        if fields[1]:
769
 
                            path = fields[1] + b'/' + fields[2]
 
714
                            path = fields[1] + '/' + fields[2]
770
715
                        else:
771
716
                            path = fields[2]
772
717
                        paths.setdefault(path, []).append(fields)
787
732
            if post:
788
733
                pending.append((after, high, post))
789
734
            if pre:
790
 
                pending.append((low, start - 1, pre))
 
735
                pending.append((low, start-1, pre))
791
736
 
792
737
        # Consider that we may want to return the directory entries in sorted
793
738
        # order. For now, we just return them in whatever order we found them,
814
759
        # there, this function is only meant to handle when we want to read
815
760
        # part of the disk.
816
761
        if self._dirblock_state != DirState.NOT_IN_MEMORY:
817
 
            raise AssertionError("bad dirblock state %r" %
818
 
                                 self._dirblock_state)
 
762
            raise AssertionError("bad dirblock state %r" % self._dirblock_state)
819
763
        # The disk representation is generally info + '\0\n\0' at the end. But
820
764
        # for bisecting, it is easier to treat this as '\0' + info + '\0\n'
821
765
        # Because it means we can sync on the '\n'
823
767
        file_size = os.fstat(state_file.fileno()).st_size
824
768
        # We end up with 2 extra fields, we should have a trailing '\n' to
825
769
        # ensure that we read the whole record, and we should have a precursur
826
 
        # b'' which ensures that we start after the previous '\n'
 
770
        # '' which ensures that we start after the previous '\n'
827
771
        entry_field_count = self._fields_per_entry() + 1
828
772
 
829
773
        low = self._end_of_header
830
 
        high = file_size - 1  # Ignore the final '\0'
 
774
        high = file_size - 1 # Ignore the final '\0'
831
775
        # Map from dir => entry
832
776
        found = {}
833
777
 
834
778
        # Avoid infinite seeking
835
 
        max_count = 30 * len(dir_list)
 
779
        max_count = 30*len(dir_list)
836
780
        count = 0
837
781
        # pending is a list of places to look.
838
782
        # each entry is a tuple of low, high, dir_names
857
801
            if count > max_count:
858
802
                raise errors.BzrError('Too many seeks, most likely a bug.')
859
803
 
860
 
            mid = max(low, (low + high - page_size) // 2)
 
804
            mid = max(low, (low+high-page_size)/2)
861
805
 
862
806
            state_file.seek(mid)
863
807
            # limit the read size, so we don't end up reading data that we have
864
808
            # already read.
865
 
            read_size = min(page_size, (high - mid) + 1)
 
809
            read_size = min(page_size, (high-mid)+1)
866
810
            block = state_file.read(read_size)
867
811
 
868
812
            start = mid
869
 
            entries = block.split(b'\n')
 
813
            entries = block.split('\n')
870
814
 
871
815
            if len(entries) < 2:
872
816
                # We didn't find a '\n', so we cannot have found any records.
880
824
            # Check the first and last entries, in case they are partial, or if
881
825
            # we don't care about the rest of this page
882
826
            first_entry_num = 0
883
 
            first_fields = entries[0].split(b'\0')
 
827
            first_fields = entries[0].split('\0')
884
828
            if len(first_fields) < entry_field_count:
885
829
                # We didn't get the complete first entry
886
830
                # so move start, and grab the next, which
887
831
                # should be a full entry
888
 
                start += len(entries[0]) + 1
889
 
                first_fields = entries[1].split(b'\0')
 
832
                start += len(entries[0])+1
 
833
                first_fields = entries[1].split('\0')
890
834
                first_entry_num = 1
891
835
 
892
836
            if len(first_fields) <= 1:
912
856
                # We have records to look at after the first entry
913
857
 
914
858
                # Parse the last entry
915
 
                last_entry_num = len(entries) - 1
916
 
                last_fields = entries[last_entry_num].split(b'\0')
 
859
                last_entry_num = len(entries)-1
 
860
                last_fields = entries[last_entry_num].split('\0')
917
861
                if len(last_fields) < entry_field_count:
918
862
                    # The very last hunk was not complete,
919
863
                    # read the previous hunk
920
864
                    after = mid + len(block) - len(entries[-1])
921
865
                    last_entry_num -= 1
922
 
                    last_fields = entries[last_entry_num].split(b'\0')
 
866
                    last_fields = entries[last_entry_num].split('\0')
923
867
                else:
924
868
                    after = mid + len(block)
925
869
 
942
886
                        post.insert(0, last_dir)
943
887
 
944
888
                    # Find out what paths we have
945
 
                    paths = {first_dir: [first_fields]}
 
889
                    paths = {first_dir:[first_fields]}
946
890
                    # last_dir might == first_dir so we need to be
947
891
                    # careful if we should append rather than overwrite
948
892
                    if last_entry_num != first_entry_num:
949
893
                        paths.setdefault(last_dir, []).append(last_fields)
950
 
                    for num in range(first_entry_num + 1, last_entry_num):
 
894
                    for num in xrange(first_entry_num+1, last_entry_num):
951
895
                        # TODO: jam 20070223 We are already splitting here, so
952
896
                        #       shouldn't we just split the whole thing rather
953
897
                        #       than doing the split again in add_one_record?
954
 
                        fields = entries[num].split(b'\0')
 
898
                        fields = entries[num].split('\0')
955
899
                        paths.setdefault(fields[1], []).append(fields)
956
900
 
957
901
                    for cur_dir in middle_files:
970
914
            if post:
971
915
                pending.append((after, high, post))
972
916
            if pre:
973
 
                pending.append((low, start - 1, pre))
 
917
                pending.append((low, start-1, pre))
974
918
 
975
919
        return found
976
920
 
982
926
        directories. (and renames?)
983
927
 
984
928
        :param paths: A sorted list of (dir, name) pairs
985
 
             eg: [('', b'a'), ('', b'f'), ('a/b', b'c')]
 
929
             eg: [('', 'a'), ('', 'f'), ('a/b', 'c')]
986
930
        :return: A dictionary mapping (dir, name, file_id) => [tree_info]
987
931
        """
988
932
        # Map from (dir, name, file_id) => [tree_info]
999
943
            # Directories that need to be read
1000
944
            pending_dirs = set()
1001
945
            paths_to_search = set()
1002
 
            for entry_list in viewvalues(newly_found):
 
946
            for entry_list in newly_found.itervalues():
1003
947
                for dir_name_id, trees_info in entry_list:
1004
948
                    found[dir_name_id] = trees_info
1005
949
                    found_dir_names.add(dir_name_id[:2])
1006
950
                    is_dir = False
1007
951
                    for tree_info in trees_info:
1008
952
                        minikind = tree_info[0]
1009
 
                        if minikind == b'd':
 
953
                        if minikind == 'd':
1010
954
                            if is_dir:
1011
955
                                # We already processed this one as a directory,
1012
956
                                # we don't need to do the extra work again.
1016
960
                            is_dir = True
1017
961
                            if path not in processed_dirs:
1018
962
                                pending_dirs.add(path)
1019
 
                        elif minikind == b'r':
 
963
                        elif minikind == 'r':
1020
964
                            # Rename, we need to directly search the target
1021
965
                            # which is contained in the fingerprint column
1022
966
                            dir_name = osutils.split(tree_info[1])
1049
993
            return
1050
994
        # only require all dirblocks if we are doing a full-pass removal.
1051
995
        self._read_dirblocks_if_needed()
1052
 
        dead_patterns = {(b'a', b'r'), (b'a', b'a'),
1053
 
                         (b'r', b'r'), (b'r', b'a')}
1054
 
 
 
996
        dead_patterns = set([('a', 'r'), ('a', 'a'), ('r', 'r'), ('r', 'a')])
1055
997
        def iter_entries_removable():
1056
998
            for block in self._dirblocks:
1057
999
                deleted_positions = []
1076
1018
 
1077
1019
        self._ghosts = []
1078
1020
        self._parents = [parents[0]]
1079
 
        self._mark_modified(header_modified=True)
 
1021
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
 
1022
        self._header_state = DirState.IN_MEMORY_MODIFIED
1080
1023
 
1081
1024
    def _empty_parent_info(self):
1082
1025
        return [DirState.NULL_PARENT_DETAILS] * (len(self._parents) -
1083
 
                                                 len(self._ghosts))
 
1026
                                                    len(self._ghosts))
1084
1027
 
1085
1028
    def _ensure_block(self, parent_block_index, parent_row_index, dirname):
1086
1029
        """Ensure a block for dirname exists.
1102
1045
        :param dirname: The utf8 dirname to ensure there is a block for.
1103
1046
        :return: The index for the block.
1104
1047
        """
1105
 
        if dirname == b'' and parent_row_index == 0 and parent_block_index == 0:
 
1048
        if dirname == '' and parent_row_index == 0 and parent_block_index == 0:
1106
1049
            # This is the signature of the root row, and the
1107
1050
            # contents-of-root row is always index 1
1108
1051
            return 1
1109
1052
        # the basename of the directory must be the end of its full name.
1110
1053
        if not (parent_block_index == -1 and
1111
 
                parent_block_index == -1 and dirname == b''):
 
1054
            parent_block_index == -1 and dirname == ''):
1112
1055
            if not dirname.endswith(
1113
1056
                    self._dirblocks[parent_block_index][1][parent_row_index][0][1]):
1114
1057
                raise AssertionError("bad dirname %r" % dirname)
1115
 
        block_index, present = self._find_block_index_from_key(
1116
 
            (dirname, b'', b''))
 
1058
        block_index, present = self._find_block_index_from_key((dirname, '', ''))
1117
1059
        if not present:
1118
 
            # In future, when doing partial parsing, this should load and
 
1060
            ## In future, when doing partial parsing, this should load and
1119
1061
            # populate the entire block.
1120
1062
            self._dirblocks.insert(block_index, (dirname, []))
1121
1063
        return block_index
1130
1072
            to prevent unneeded overhead when callers have a sorted list already.
1131
1073
        :return: Nothing.
1132
1074
        """
1133
 
        if new_entries[0][0][0:2] != (b'', b''):
 
1075
        if new_entries[0][0][0:2] != ('', ''):
1134
1076
            raise AssertionError(
1135
1077
                "Missing root row %r" % (new_entries[0][0],))
1136
1078
        # The two blocks here are deliberate: the root block and the
1137
1079
        # contents-of-root block.
1138
 
        self._dirblocks = [(b'', []), (b'', [])]
 
1080
        self._dirblocks = [('', []), ('', [])]
1139
1081
        current_block = self._dirblocks[0][1]
1140
 
        current_dirname = b''
1141
 
        root_key = (b'', b'')
 
1082
        current_dirname = ''
 
1083
        root_key = ('', '')
1142
1084
        append_entry = current_block.append
1143
1085
        for entry in new_entries:
1144
1086
            if entry[0][0] != current_dirname:
1160
1102
        # The above loop leaves the "root block" entries mixed with the
1161
1103
        # "contents-of-root block". But we don't want an if check on
1162
1104
        # all entries, so instead we just fix it up here.
1163
 
        if self._dirblocks[1] != (b'', []):
 
1105
        if self._dirblocks[1] != ('', []):
1164
1106
            raise ValueError("bad dirblock start %r" % (self._dirblocks[1],))
1165
1107
        root_block = []
1166
1108
        contents_of_root_block = []
1167
1109
        for entry in self._dirblocks[0][1]:
1168
 
            if not entry[0][1]:  # This is a root entry
 
1110
            if not entry[0][1]: # This is a root entry
1169
1111
                root_block.append(entry)
1170
1112
            else:
1171
1113
                contents_of_root_block.append(entry)
1172
 
        self._dirblocks[0] = (b'', root_block)
1173
 
        self._dirblocks[1] = (b'', contents_of_root_block)
 
1114
        self._dirblocks[0] = ('', root_block)
 
1115
        self._dirblocks[1] = ('', contents_of_root_block)
1174
1116
 
1175
1117
    def _entries_for_path(self, path):
1176
1118
        """Return a list with all the entries that match path for all ids."""
1177
1119
        dirname, basename = os.path.split(path)
1178
 
        key = (dirname, basename, b'')
 
1120
        key = (dirname, basename, '')
1179
1121
        block_index, present = self._find_block_index_from_key(key)
1180
1122
        if not present:
1181
1123
            # the block which should contain path is absent.
1185
1127
        entry_index, _ = self._find_entry_index(key, block)
1186
1128
        # we may need to look at multiple entries at this path: walk while the specific_files match.
1187
1129
        while (entry_index < len(block) and
1188
 
               block[entry_index][0][0:2] == key[0:2]):
 
1130
            block[entry_index][0][0:2] == key[0:2]):
1189
1131
            result.append(block[entry_index])
1190
1132
            entry_index += 1
1191
1133
        return result
1204
1146
            # minikind
1205
1147
            entire_entry[tree_offset + 0] = tree_data[0]
1206
1148
            # size
1207
 
            entire_entry[tree_offset + 2] = b'%d' % tree_data[2]
 
1149
            entire_entry[tree_offset + 2] = str(tree_data[2])
1208
1150
            # executable
1209
1151
            entire_entry[tree_offset + 3] = DirState._to_yesno[tree_data[3]]
1210
 
        return b'\0'.join(entire_entry)
 
1152
        return '\0'.join(entire_entry)
1211
1153
 
1212
1154
    def _fields_per_entry(self):
1213
1155
        """How many null separated fields should be in each entry row.
1214
1156
 
1215
 
        Each line now has an extra '\\n' field which is not used
 
1157
        Each line now has an extra '\n' field which is not used
1216
1158
        so we just skip over it
1217
 
 
1218
 
        entry size::
 
1159
        entry size:
1219
1160
            3 fields for the key
1220
1161
            + number of fields per tree_data (5) * tree count
1221
1162
            + newline
1250
1191
 
1251
1192
        :return: The block index, True if the block for the key is present.
1252
1193
        """
1253
 
        if key[0:2] == (b'', b''):
 
1194
        if key[0:2] == ('', ''):
1254
1195
            return 0, True
1255
1196
        try:
1256
1197
            if (self._last_block_index is not None and
1257
 
                    self._dirblocks[self._last_block_index][0] == key[0]):
 
1198
                self._dirblocks[self._last_block_index][0] == key[0]):
1258
1199
                return self._last_block_index, True
1259
1200
        except IndexError:
1260
1201
            pass
1262
1203
                                      cache=self._split_path_cache)
1263
1204
        # _right returns one-past-where-key is so we have to subtract
1264
1205
        # one to use it. we use _right here because there are two
1265
 
        # b'' blocks - the root, and the contents of root
 
1206
        # '' blocks - the root, and the contents of root
1266
1207
        # we always have a minimum of 2 in self._dirblocks: root and
1267
 
        # root-contents, and for b'', we get 2 back, so this is
 
1208
        # root-contents, and for '', we get 2 back, so this is
1268
1209
        # simple and correct:
1269
1210
        present = (block_index < len(self._dirblocks) and
1270
 
                   self._dirblocks[block_index][0] == key[0])
 
1211
            self._dirblocks[block_index][0] == key[0])
1271
1212
        self._last_block_index = block_index
1272
1213
        # Reset the entry index cache to the beginning of the block.
1273
1214
        self._last_entry_index = -1
1286
1227
                # A hit is when the key is after the last slot, and before or
1287
1228
                # equal to the next slot.
1288
1229
                if ((entry_index > 0 and block[entry_index - 1][0] < key) and
1289
 
                        key <= block[entry_index][0]):
 
1230
                    key <= block[entry_index][0]):
1290
1231
                    self._last_entry_index = entry_index
1291
1232
                    present = (block[entry_index][0] == key)
1292
1233
                    return entry_index, present
1294
1235
            pass
1295
1236
        entry_index = bisect.bisect_left(block, (key, []))
1296
1237
        present = (entry_index < len_block and
1297
 
                   block[entry_index][0] == key)
 
1238
            block[entry_index][0] == key)
1298
1239
        self._last_entry_index = entry_index
1299
1240
        return entry_index, present
1300
1241
 
1310
1251
            (it was locked by DirState.initialize)
1311
1252
        """
1312
1253
        result = DirState.initialize(dir_state_filename,
1313
 
                                     sha1_provider=sha1_provider)
 
1254
            sha1_provider=sha1_provider)
1314
1255
        try:
1315
 
            with cleanup.ExitStack() as exit_stack:
1316
 
                exit_stack.enter_context(tree.lock_read())
 
1256
            tree.lock_read()
 
1257
            try:
1317
1258
                parent_ids = tree.get_parent_ids()
1318
1259
                num_parents = len(parent_ids)
1319
1260
                parent_trees = []
1320
1261
                for parent_id in parent_ids:
1321
 
                    parent_tree = tree.branch.repository.revision_tree(
1322
 
                        parent_id)
 
1262
                    parent_tree = tree.branch.repository.revision_tree(parent_id)
1323
1263
                    parent_trees.append((parent_id, parent_tree))
1324
 
                    exit_stack.enter_context(parent_tree.lock_read())
 
1264
                    parent_tree.lock_read()
1325
1265
                result.set_parent_trees(parent_trees, [])
1326
 
                result.set_state_from_inventory(tree.root_inventory)
 
1266
                result.set_state_from_inventory(tree.inventory)
 
1267
            finally:
 
1268
                for revid, parent_tree in parent_trees:
 
1269
                    parent_tree.unlock()
 
1270
                tree.unlock()
1327
1271
        except:
1328
1272
            # The caller won't have a chance to unlock this, so make sure we
1329
1273
            # cleanup ourselves
1331
1275
            raise
1332
1276
        return result
1333
1277
 
1334
 
    def _check_delta_is_valid(self, delta):
1335
 
        delta = list(inventory._check_delta_unique_ids(
1336
 
                     inventory._check_delta_unique_old_paths(
1337
 
                         inventory._check_delta_unique_new_paths(
1338
 
                             inventory._check_delta_ids_match_entry(
1339
 
                                 inventory._check_delta_ids_are_valid(
1340
 
                                     inventory._check_delta_new_path_entry_both_or_None(delta)))))))
1341
 
 
1342
 
        def delta_key(d):
1343
 
            (old_path, new_path, file_id, new_entry) = d
1344
 
            if old_path is None:
1345
 
                old_path = ''
1346
 
            if new_path is None:
1347
 
                new_path = ''
1348
 
            return (old_path, new_path, file_id, new_entry)
1349
 
        delta.sort(key=delta_key, reverse=True)
1350
 
        return delta
1351
 
 
1352
1278
    def update_by_delta(self, delta):
1353
1279
        """Apply an inventory delta to the dirstate for tree 0
1354
1280
 
1372
1298
        new_ids = set()
1373
1299
        # This loop transforms the delta to single atomic operations that can
1374
1300
        # be executed and validated.
1375
 
        delta = self._check_delta_is_valid(delta)
1376
 
        for old_path, new_path, file_id, inv_entry in delta:
1377
 
            if not isinstance(file_id, bytes):
1378
 
                raise AssertionError(
1379
 
                    "must be a utf8 file_id not %s" % (type(file_id), ))
 
1301
        for old_path, new_path, file_id, inv_entry in sorted(
 
1302
            inventory._check_delta_unique_old_paths(
 
1303
            inventory._check_delta_unique_new_paths(
 
1304
            inventory._check_delta_ids_match_entry(
 
1305
            inventory._check_delta_ids_are_valid(
 
1306
            inventory._check_delta_new_path_entry_both_or_None(delta))))),
 
1307
            reverse=True):
1380
1308
            if (file_id in insertions) or (file_id in removals):
1381
 
                self._raise_invalid(old_path or new_path, file_id,
1382
 
                                    "repeated file_id")
 
1309
                raise errors.InconsistentDelta(old_path or new_path, file_id,
 
1310
                    "repeated file_id")
1383
1311
            if old_path is not None:
1384
1312
                old_path = old_path.encode('utf-8')
1385
1313
                removals[file_id] = old_path
1387
1315
                new_ids.add(file_id)
1388
1316
            if new_path is not None:
1389
1317
                if inv_entry is None:
1390
 
                    self._raise_invalid(new_path, file_id,
1391
 
                                        "new_path with no entry")
 
1318
                    raise errors.InconsistentDelta(new_path, file_id,
 
1319
                        "new_path with no entry")
1392
1320
                new_path = new_path.encode('utf-8')
1393
1321
                dirname_utf8, basename = osutils.split(new_path)
1394
1322
                if basename:
1395
1323
                    parents.add((dirname_utf8, inv_entry.parent_id))
1396
1324
                key = (dirname_utf8, basename, file_id)
1397
1325
                minikind = DirState._kind_to_minikind[inv_entry.kind]
1398
 
                if minikind == b't':
1399
 
                    fingerprint = inv_entry.reference_revision or b''
 
1326
                if minikind == 't':
 
1327
                    fingerprint = inv_entry.reference_revision or ''
1400
1328
                else:
1401
 
                    fingerprint = b''
 
1329
                    fingerprint = ''
1402
1330
                insertions[file_id] = (key, minikind, inv_entry.executable,
1403
1331
                                       fingerprint, new_path)
1404
1332
            # Transform moves into delete+add pairs
1423
1351
                                               fingerprint, new_child_path)
1424
1352
        self._check_delta_ids_absent(new_ids, delta, 0)
1425
1353
        try:
1426
 
            self._apply_removals(viewitems(removals))
1427
 
            self._apply_insertions(viewvalues(insertions))
 
1354
            self._apply_removals(removals.iteritems())
 
1355
            self._apply_insertions(insertions.values())
1428
1356
            # Validate parents
1429
1357
            self._after_delta_check_parents(parents, 0)
1430
 
        except errors.BzrError as e:
 
1358
        except errors.BzrError, e:
1431
1359
            self._changes_aborted = True
1432
1360
            if 'integrity error' not in str(e):
1433
1361
                raise
1434
1362
            # _get_entry raises BzrError when a request is inconsistent; we
1435
 
            # want such errors to be shown as InconsistentDelta - and that
 
1363
            # want such errors to be shown as InconsistentDelta - and that 
1436
1364
            # fits the behaviour we trigger.
1437
 
            raise errors.InconsistentDeltaDelta(delta,
1438
 
                                                "error from _get_entry. %s" % (e,))
 
1365
            raise errors.InconsistentDeltaDelta(delta, "error from _get_entry.")
1439
1366
 
1440
1367
    def _apply_removals(self, removals):
1441
1368
        for file_id, path in sorted(removals, reverse=True,
1442
 
                                    key=operator.itemgetter(1)):
 
1369
            key=operator.itemgetter(1)):
1443
1370
            dirname, basename = osutils.split(path)
1444
1371
            block_i, entry_i, d_present, f_present = \
1445
1372
                self._get_block_entry_index(dirname, basename, 0)
1446
1373
            try:
1447
1374
                entry = self._dirblocks[block_i][1][entry_i]
1448
1375
            except IndexError:
1449
 
                self._raise_invalid(path, file_id,
1450
 
                                    "Wrong path for old path.")
1451
 
            if not f_present or entry[1][0][0] in (b'a', b'r'):
1452
 
                self._raise_invalid(path, file_id,
1453
 
                                    "Wrong path for old path.")
 
1376
                self._changes_aborted = True
 
1377
                raise errors.InconsistentDelta(path, file_id,
 
1378
                    "Wrong path for old path.")
 
1379
            if not f_present or entry[1][0][0] in 'ar':
 
1380
                self._changes_aborted = True
 
1381
                raise errors.InconsistentDelta(path, file_id,
 
1382
                    "Wrong path for old path.")
1454
1383
            if file_id != entry[0][2]:
1455
 
                self._raise_invalid(path, file_id,
1456
 
                                    "Attempt to remove path has wrong id - found %r."
1457
 
                                    % entry[0][2])
 
1384
                self._changes_aborted = True
 
1385
                raise errors.InconsistentDelta(path, file_id,
 
1386
                    "Attempt to remove path has wrong id - found %r."
 
1387
                    % entry[0][2])
1458
1388
            self._make_absent(entry)
1459
1389
            # See if we have a malformed delta: deleting a directory must not
1460
1390
            # leave crud behind. This increases the number of bisects needed
1462
1392
            # is rare enough it shouldn't be an issue (famous last words?) RBC
1463
1393
            # 20080730.
1464
1394
            block_i, entry_i, d_present, f_present = \
1465
 
                self._get_block_entry_index(path, b'', 0)
 
1395
                self._get_block_entry_index(path, '', 0)
1466
1396
            if d_present:
1467
1397
                # The dir block is still present in the dirstate; this could
1468
1398
                # be due to it being in a parent tree, or a corrupt delta.
1469
1399
                for child_entry in self._dirblocks[block_i][1]:
1470
 
                    if child_entry[1][0][0] not in (b'r', b'a'):
1471
 
                        self._raise_invalid(path, entry[0][2],
1472
 
                                            "The file id was deleted but its children were "
1473
 
                                            "not deleted.")
 
1400
                    if child_entry[1][0][0] not in ('r', 'a'):
 
1401
                        self._changes_aborted = True
 
1402
                        raise errors.InconsistentDelta(path, entry[0][2],
 
1403
                            "The file id was deleted but its children were "
 
1404
                            "not deleted.")
1474
1405
 
1475
1406
    def _apply_insertions(self, adds):
1476
1407
        try:
1478
1409
                self.update_minimal(key, minikind, executable, fingerprint,
1479
1410
                                    path_utf8=path_utf8)
1480
1411
        except errors.NotVersionedError:
1481
 
            self._raise_invalid(path_utf8.decode('utf8'), key[2],
1482
 
                                "Missing parent")
 
1412
            self._changes_aborted = True
 
1413
            raise errors.InconsistentDelta(path_utf8.decode('utf8'), key[2],
 
1414
                "Missing parent")
1483
1415
 
1484
1416
    def update_basis_by_delta(self, delta, new_revid):
1485
1417
        """Update the parents of this tree after a commit.
1492
1424
        Note that an exception during the operation of this method will leave
1493
1425
        the dirstate in a corrupt state where it should not be saved.
1494
1426
 
 
1427
        Finally, we expect all changes to be synchronising the basis tree with
 
1428
        the working tree.
 
1429
 
1495
1430
        :param new_revid: The new revision id for the trees parent.
1496
1431
        :param delta: An inventory delta (see apply_inventory_delta) describing
1497
1432
            the changes from the current left most parent revision to new_revid.
1509
1444
 
1510
1445
        self._parents[0] = new_revid
1511
1446
 
1512
 
        delta = self._check_delta_is_valid(delta)
 
1447
        delta = sorted(delta, reverse=True)
1513
1448
        adds = []
1514
1449
        changes = []
1515
1450
        deletes = []
1535
1470
        # ids.
1536
1471
        new_ids = set()
1537
1472
        for old_path, new_path, file_id, inv_entry in delta:
1538
 
            if file_id.__class__ is not bytes:
1539
 
                raise AssertionError(
1540
 
                    "must be a utf8 file_id not %s" % (type(file_id), ))
1541
1473
            if inv_entry is not None and file_id != inv_entry.file_id:
1542
 
                self._raise_invalid(new_path, file_id,
1543
 
                                    "mismatched entry file_id %r" % inv_entry)
1544
 
            if new_path is None:
1545
 
                new_path_utf8 = None
1546
 
            else:
 
1474
                raise errors.InconsistentDelta(new_path, file_id,
 
1475
                    "mismatched entry file_id %r" % inv_entry)
 
1476
            if new_path is not None:
1547
1477
                if inv_entry is None:
1548
 
                    self._raise_invalid(new_path, file_id,
1549
 
                                        "new_path with no entry")
 
1478
                    raise errors.InconsistentDelta(new_path, file_id,
 
1479
                        "new_path with no entry")
1550
1480
                new_path_utf8 = encode(new_path)
1551
1481
                # note the parent for validation
1552
1482
                dirname_utf8, basename_utf8 = osutils.split(new_path_utf8)
1553
1483
                if basename_utf8:
1554
1484
                    parents.add((dirname_utf8, inv_entry.parent_id))
1555
1485
            if old_path is None:
1556
 
                old_path_utf8 = None
1557
 
            else:
1558
 
                old_path_utf8 = encode(old_path)
1559
 
            if old_path is None:
1560
 
                adds.append((None, new_path_utf8, file_id,
1561
 
                             inv_to_entry(inv_entry), True))
 
1486
                adds.append((None, encode(new_path), file_id,
 
1487
                    inv_to_entry(inv_entry), True))
1562
1488
                new_ids.add(file_id)
1563
1489
            elif new_path is None:
1564
 
                deletes.append((old_path_utf8, None, file_id, None, True))
1565
 
            elif (old_path, new_path) == root_only:
1566
 
                # change things in-place
1567
 
                # Note: the case of a parent directory changing its file_id
1568
 
                #       tends to break optimizations here, because officially
1569
 
                #       the file has actually been moved, it just happens to
1570
 
                #       end up at the same path. If we can figure out how to
1571
 
                #       handle that case, we can avoid a lot of add+delete
1572
 
                #       pairs for objects that stay put.
1573
 
                # elif old_path == new_path:
1574
 
                changes.append((old_path_utf8, new_path_utf8, file_id,
1575
 
                                inv_to_entry(inv_entry)))
1576
 
            else:
 
1490
                deletes.append((encode(old_path), None, file_id, None, True))
 
1491
            elif (old_path, new_path) != root_only:
1577
1492
                # Renames:
1578
1493
                # Because renames must preserve their children we must have
1579
1494
                # processed all relocations and removes before hand. The sort
1582
1497
                # pair will result in the deleted item being reinserted, or
1583
1498
                # renamed items being reinserted twice - and possibly at the
1584
1499
                # wrong place. Splitting into a delete/add pair also simplifies
1585
 
                # the handling of entries with (b'f', ...), (b'r' ...) because
1586
 
                # the target of the b'r' is old_path here, and we add that to
 
1500
                # the handling of entries with ('f', ...), ('r' ...) because
 
1501
                # the target of the 'r' is old_path here, and we add that to
1587
1502
                # deletes, meaning that the add handler does not need to check
1588
 
                # for b'r' items on every pass.
 
1503
                # for 'r' items on every pass.
1589
1504
                self._update_basis_apply_deletes(deletes)
1590
1505
                deletes = []
1591
1506
                # Split into an add/delete pair recursively.
1592
 
                adds.append((old_path_utf8, new_path_utf8, file_id,
1593
 
                             inv_to_entry(inv_entry), False))
 
1507
                adds.append((None, new_path_utf8, file_id,
 
1508
                    inv_to_entry(inv_entry), False))
1594
1509
                # Expunge deletes that we've seen so that deleted/renamed
1595
1510
                # children of a rename directory are handled correctly.
1596
 
                new_deletes = reversed(list(
1597
 
                    self._iter_child_entries(1, old_path_utf8)))
 
1511
                new_deletes = reversed(list(self._iter_child_entries(1,
 
1512
                    encode(old_path))))
1598
1513
                # Remove the current contents of the tree at orig_path, and
1599
1514
                # reinsert at the correct new path.
1600
1515
                for entry in new_deletes:
1601
 
                    child_dirname, child_basename, child_file_id = entry[0]
1602
 
                    if child_dirname:
1603
 
                        source_path = child_dirname + b'/' + child_basename
 
1516
                    if entry[0][0]:
 
1517
                        source_path = entry[0][0] + '/' + entry[0][1]
1604
1518
                    else:
1605
 
                        source_path = child_basename
 
1519
                        source_path = entry[0][1]
1606
1520
                    if new_path_utf8:
1607
 
                        target_path = \
1608
 
                            new_path_utf8 + source_path[len(old_path_utf8):]
 
1521
                        target_path = new_path_utf8 + source_path[len(old_path):]
1609
1522
                    else:
1610
 
                        if old_path_utf8 == b'':
 
1523
                        if old_path == '':
1611
1524
                            raise AssertionError("cannot rename directory to"
1612
 
                                                 " itself")
1613
 
                        target_path = source_path[len(old_path_utf8) + 1:]
1614
 
                    adds.append(
1615
 
                        (None, target_path, entry[0][2], entry[1][1], False))
 
1525
                                " itself")
 
1526
                        target_path = source_path[len(old_path) + 1:]
 
1527
                    adds.append((None, target_path, entry[0][2], entry[1][1], False))
1616
1528
                    deletes.append(
1617
1529
                        (source_path, target_path, entry[0][2], None, False))
1618
1530
                deletes.append(
1619
 
                    (old_path_utf8, new_path_utf8, file_id, None, False))
1620
 
 
 
1531
                    (encode(old_path), new_path, file_id, None, False))
 
1532
            else:
 
1533
                # changes to just the root should not require remove/insertion
 
1534
                # of everything.
 
1535
                changes.append((encode(old_path), encode(new_path), file_id,
 
1536
                    inv_to_entry(inv_entry)))
1621
1537
        self._check_delta_ids_absent(new_ids, delta, 1)
1622
1538
        try:
1623
1539
            # Finish expunging deletes/first half of renames.
1628
1544
            self._update_basis_apply_changes(changes)
1629
1545
            # Validate parents
1630
1546
            self._after_delta_check_parents(parents, 1)
1631
 
        except errors.BzrError as e:
 
1547
        except errors.BzrError, e:
1632
1548
            self._changes_aborted = True
1633
1549
            if 'integrity error' not in str(e):
1634
1550
                raise
1635
1551
            # _get_entry raises BzrError when a request is inconsistent; we
1636
 
            # want such errors to be shown as InconsistentDelta - and that
1637
 
            # fits the behaviour we trigger.
1638
 
            raise errors.InconsistentDeltaDelta(delta,
1639
 
                                                "error from _get_entry. %s" % (e,))
 
1552
            # want such errors to be shown as InconsistentDelta - and that 
 
1553
            # fits the behaviour we trigger. Partof this is driven by dirstate
 
1554
            # only supporting deltas that turn the basis into a closer fit to
 
1555
            # the active tree.
 
1556
            raise errors.InconsistentDeltaDelta(delta, "error from _get_entry.")
1640
1557
 
1641
 
        self._mark_modified(header_modified=True)
 
1558
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
 
1559
        self._header_state = DirState.IN_MEMORY_MODIFIED
1642
1560
        self._id_index = None
1643
1561
        return
1644
1562
 
1648
1566
            return
1649
1567
        id_index = self._get_id_index()
1650
1568
        for file_id in new_ids:
1651
 
            for key in id_index.get(file_id, ()):
 
1569
            for key in id_index.get(file_id, []):
1652
1570
                block_i, entry_i, d_present, f_present = \
1653
1571
                    self._get_block_entry_index(key[0], key[1], tree_index)
1654
1572
                if not f_present:
1658
1576
                if entry[0][2] != file_id:
1659
1577
                    # Different file_id, so not what we want.
1660
1578
                    continue
1661
 
                self._raise_invalid((b"%s/%s" % key[0:2]).decode('utf8'), file_id,
1662
 
                                    "This file_id is new in the delta but already present in "
1663
 
                                    "the target")
1664
 
 
1665
 
    def _raise_invalid(self, path, file_id, reason):
1666
 
        self._changes_aborted = True
1667
 
        raise errors.InconsistentDelta(path, file_id, reason)
 
1579
                # NB: No changes made before this helper is called, so no need
 
1580
                # to set the _changes_aborted flag.
 
1581
                raise errors.InconsistentDelta(
 
1582
                    ("%s/%s" % key[0:2]).decode('utf8'), file_id,
 
1583
                    "This file_id is new in the delta but already present in "
 
1584
                    "the target")
1668
1585
 
1669
1586
    def _update_basis_apply_adds(self, adds):
1670
1587
        """Apply a sequence of adds to tree 1 during update_basis_by_delta.
1679
1596
        """
1680
1597
        # Adds are accumulated partly from renames, so can be in any input
1681
1598
        # order - sort it.
1682
 
        # TODO: we may want to sort in dirblocks order. That way each entry
1683
 
        #       will end up in the same directory, allowing the _get_entry
1684
 
        #       fast-path for looking up 2 items in the same dir work.
1685
 
        adds.sort(key=lambda x: x[1])
 
1599
        adds.sort()
1686
1600
        # adds is now in lexographic order, which places all parents before
1687
1601
        # their children, so we can process it linearly.
1688
 
        st = static_tuple.StaticTuple
 
1602
        absent = 'ar'
1689
1603
        for old_path, new_path, file_id, new_details, real_add in adds:
1690
 
            dirname, basename = osutils.split(new_path)
1691
 
            entry_key = st(dirname, basename, file_id)
1692
 
            block_index, present = self._find_block_index_from_key(entry_key)
1693
 
            if not present:
1694
 
                # The block where we want to put the file is not present.
1695
 
                # However, it might have just been an empty directory. Look for
1696
 
                # the parent in the basis-so-far before throwing an error.
1697
 
                parent_dir, parent_base = osutils.split(dirname)
1698
 
                parent_block_idx, parent_entry_idx, _, parent_present = \
1699
 
                    self._get_block_entry_index(parent_dir, parent_base, 1)
1700
 
                if not parent_present:
1701
 
                    self._raise_invalid(new_path, file_id,
1702
 
                                        "Unable to find block for this record."
1703
 
                                        " Was the parent added?")
1704
 
                self._ensure_block(parent_block_idx, parent_entry_idx, dirname)
1705
 
 
1706
 
            block = self._dirblocks[block_index][1]
1707
 
            entry_index, present = self._find_entry_index(entry_key, block)
1708
 
            if real_add:
1709
 
                if old_path is not None:
1710
 
                    self._raise_invalid(new_path, file_id,
1711
 
                                        'considered a real add but still had old_path at %s'
1712
 
                                        % (old_path,))
1713
 
            if present:
1714
 
                entry = block[entry_index]
1715
 
                basis_kind = entry[1][1][0]
1716
 
                if basis_kind == b'a':
1717
 
                    entry[1][1] = new_details
1718
 
                elif basis_kind == b'r':
1719
 
                    raise NotImplementedError()
1720
 
                else:
1721
 
                    self._raise_invalid(new_path, file_id,
1722
 
                                        "An entry was marked as a new add"
1723
 
                                        " but the basis target already existed")
1724
 
            else:
1725
 
                # The exact key was not found in the block. However, we need to
1726
 
                # check if there is a key next to us that would have matched.
1727
 
                # We only need to check 2 locations, because there are only 2
1728
 
                # trees present.
1729
 
                for maybe_index in range(entry_index - 1, entry_index + 1):
1730
 
                    if maybe_index < 0 or maybe_index >= len(block):
1731
 
                        continue
1732
 
                    maybe_entry = block[maybe_index]
1733
 
                    if maybe_entry[0][:2] != (dirname, basename):
1734
 
                        # Just a random neighbor
1735
 
                        continue
1736
 
                    if maybe_entry[0][2] == file_id:
1737
 
                        raise AssertionError(
1738
 
                            '_find_entry_index didnt find a key match'
1739
 
                            ' but walking the data did, for %s'
1740
 
                            % (entry_key,))
1741
 
                    basis_kind = maybe_entry[1][1][0]
1742
 
                    if basis_kind not in (b'a', b'r'):
1743
 
                        self._raise_invalid(new_path, file_id,
1744
 
                                            "we have an add record for path, but the path"
1745
 
                                            " is already present with another file_id %s"
1746
 
                                            % (maybe_entry[0][2],))
1747
 
 
1748
 
                entry = (entry_key, [DirState.NULL_PARENT_DETAILS,
1749
 
                                     new_details])
1750
 
                block.insert(entry_index, entry)
1751
 
 
1752
 
            active_kind = entry[1][0][0]
1753
 
            if active_kind == b'a':
1754
 
                # The active record shows up as absent, this could be genuine,
1755
 
                # or it could be present at some other location. We need to
1756
 
                # verify.
1757
 
                id_index = self._get_id_index()
1758
 
                # The id_index may not be perfectly accurate for tree1, because
1759
 
                # we haven't been keeping it updated. However, it should be
1760
 
                # fine for tree0, and that gives us enough info for what we
1761
 
                # need
1762
 
                keys = id_index.get(file_id, ())
1763
 
                for key in keys:
1764
 
                    block_i, entry_i, d_present, f_present = \
1765
 
                        self._get_block_entry_index(key[0], key[1], 0)
1766
 
                    if not f_present:
1767
 
                        continue
1768
 
                    active_entry = self._dirblocks[block_i][1][entry_i]
1769
 
                    if (active_entry[0][2] != file_id):
1770
 
                        # Some other file is at this path, we don't need to
1771
 
                        # link it.
1772
 
                        continue
1773
 
                    real_active_kind = active_entry[1][0][0]
1774
 
                    if real_active_kind in (b'a', b'r'):
1775
 
                        # We found a record, which was not *this* record,
1776
 
                        # which matches the file_id, but is not actually
1777
 
                        # present. Something seems *really* wrong.
1778
 
                        self._raise_invalid(new_path, file_id,
1779
 
                                            "We found a tree0 entry that doesnt make sense")
1780
 
                    # Now, we've found a tree0 entry which matches the file_id
1781
 
                    # but is at a different location. So update them to be
1782
 
                    # rename records.
1783
 
                    active_dir, active_name = active_entry[0][:2]
1784
 
                    if active_dir:
1785
 
                        active_path = active_dir + b'/' + active_name
1786
 
                    else:
1787
 
                        active_path = active_name
1788
 
                    active_entry[1][1] = st(b'r', new_path, 0, False, b'')
1789
 
                    entry[1][0] = st(b'r', active_path, 0, False, b'')
1790
 
            elif active_kind == b'r':
1791
 
                raise NotImplementedError()
1792
 
 
1793
 
            new_kind = new_details[0]
1794
 
            if new_kind == b'd':
1795
 
                self._ensure_block(block_index, entry_index, new_path)
 
1604
            # the entry for this file_id must be in tree 0.
 
1605
            entry = self._get_entry(0, file_id, new_path)
 
1606
            if entry[0] is None or entry[0][2] != file_id:
 
1607
                self._changes_aborted = True
 
1608
                raise errors.InconsistentDelta(new_path, file_id,
 
1609
                    'working tree does not contain new entry')
 
1610
            if real_add and entry[1][1][0] not in absent:
 
1611
                self._changes_aborted = True
 
1612
                raise errors.InconsistentDelta(new_path, file_id,
 
1613
                    'The entry was considered to be a genuinely new record,'
 
1614
                    ' but there was already an old record for it.')
 
1615
            # We don't need to update the target of an 'r' because the handling
 
1616
            # of renames turns all 'r' situations into a delete at the original
 
1617
            # location.
 
1618
            entry[1][1] = new_details
1796
1619
 
1797
1620
    def _update_basis_apply_changes(self, changes):
1798
1621
        """Apply a sequence of changes to tree 1 during update_basis_by_delta.
1800
1623
        :param adds: A sequence of changes. Each change is a tuple:
1801
1624
            (path_utf8, path_utf8, file_id, (entry_details))
1802
1625
        """
 
1626
        absent = 'ar'
1803
1627
        for old_path, new_path, file_id, new_details in changes:
1804
1628
            # the entry for this file_id must be in tree 0.
1805
 
            entry = self._get_entry(1, file_id, new_path)
1806
 
            if entry[0] is None or entry[1][1][0] in (b'a', b'r'):
1807
 
                self._raise_invalid(new_path, file_id,
1808
 
                                    'changed entry considered not present')
 
1629
            entry = self._get_entry(0, file_id, new_path)
 
1630
            if entry[0] is None or entry[0][2] != file_id:
 
1631
                self._changes_aborted = True
 
1632
                raise errors.InconsistentDelta(new_path, file_id,
 
1633
                    'working tree does not contain new entry')
 
1634
            if (entry[1][0][0] in absent or
 
1635
                entry[1][1][0] in absent):
 
1636
                self._changes_aborted = True
 
1637
                raise errors.InconsistentDelta(new_path, file_id,
 
1638
                    'changed considered absent')
1809
1639
            entry[1][1] = new_details
1810
1640
 
1811
1641
    def _update_basis_apply_deletes(self, deletes):
1823
1653
        null = DirState.NULL_PARENT_DETAILS
1824
1654
        for old_path, new_path, file_id, _, real_delete in deletes:
1825
1655
            if real_delete != (new_path is None):
1826
 
                self._raise_invalid(old_path, file_id, "bad delete delta")
 
1656
                self._changes_aborted = True
 
1657
                raise AssertionError("bad delete delta")
1827
1658
            # the entry for this file_id must be in tree 1.
1828
1659
            dirname, basename = osutils.split(old_path)
1829
1660
            block_index, entry_index, dir_present, file_present = \
1830
1661
                self._get_block_entry_index(dirname, basename, 1)
1831
1662
            if not file_present:
1832
 
                self._raise_invalid(old_path, file_id,
1833
 
                                    'basis tree does not contain removed entry')
 
1663
                self._changes_aborted = True
 
1664
                raise errors.InconsistentDelta(old_path, file_id,
 
1665
                    'basis tree does not contain removed entry')
1834
1666
            entry = self._dirblocks[block_index][1][entry_index]
1835
 
            # The state of the entry in the 'active' WT
1836
 
            active_kind = entry[1][0][0]
1837
1667
            if entry[0][2] != file_id:
1838
 
                self._raise_invalid(old_path, file_id,
1839
 
                                    'mismatched file_id in tree 1')
1840
 
            dir_block = ()
1841
 
            old_kind = entry[1][1][0]
1842
 
            if active_kind in b'ar':
1843
 
                # The active tree doesn't have this file_id.
1844
 
                # The basis tree is changing this record. If this is a
1845
 
                # rename, then we don't want the record here at all
1846
 
                # anymore. If it is just an in-place change, we want the
1847
 
                # record here, but we'll add it if we need to. So we just
1848
 
                # delete it
1849
 
                if active_kind == b'r':
1850
 
                    active_path = entry[1][0][1]
1851
 
                    active_entry = self._get_entry(0, file_id, active_path)
1852
 
                    if active_entry[1][1][0] != b'r':
1853
 
                        self._raise_invalid(old_path, file_id,
1854
 
                                            "Dirstate did not have matching rename entries")
1855
 
                    elif active_entry[1][0][0] in b'ar':
1856
 
                        self._raise_invalid(old_path, file_id,
1857
 
                                            "Dirstate had a rename pointing at an inactive"
1858
 
                                            " tree0")
1859
 
                    active_entry[1][1] = null
 
1668
                self._changes_aborted = True
 
1669
                raise errors.InconsistentDelta(old_path, file_id,
 
1670
                    'mismatched file_id in tree 1')
 
1671
            if real_delete:
 
1672
                if entry[1][0][0] != 'a':
 
1673
                    self._changes_aborted = True
 
1674
                    raise errors.InconsistentDelta(old_path, file_id,
 
1675
                            'This was marked as a real delete, but the WT state'
 
1676
                            ' claims that it still exists and is versioned.')
1860
1677
                del self._dirblocks[block_index][1][entry_index]
1861
 
                if old_kind == b'd':
1862
 
                    # This was a directory, and the active tree says it
1863
 
                    # doesn't exist, and now the basis tree says it doesn't
1864
 
                    # exist. Remove its dirblock if present
1865
 
                    (dir_block_index,
1866
 
                     present) = self._find_block_index_from_key(
1867
 
                        (old_path, b'', b''))
1868
 
                    if present:
1869
 
                        dir_block = self._dirblocks[dir_block_index][1]
1870
 
                        if not dir_block:
1871
 
                            # This entry is empty, go ahead and just remove it
1872
 
                            del self._dirblocks[dir_block_index]
1873
1678
            else:
1874
 
                # There is still an active record, so just mark this
1875
 
                # removed.
1876
 
                entry[1][1] = null
1877
 
                block_i, entry_i, d_present, f_present = \
1878
 
                    self._get_block_entry_index(old_path, b'', 1)
1879
 
                if d_present:
1880
 
                    dir_block = self._dirblocks[block_i][1]
1881
 
            for child_entry in dir_block:
1882
 
                child_basis_kind = child_entry[1][1][0]
1883
 
                if child_basis_kind not in b'ar':
1884
 
                    self._raise_invalid(old_path, file_id,
1885
 
                                        "The file id was deleted but its children were "
1886
 
                                        "not deleted.")
 
1679
                if entry[1][0][0] == 'a':
 
1680
                    self._changes_aborted = True
 
1681
                    raise errors.InconsistentDelta(old_path, file_id,
 
1682
                        'The entry was considered a rename, but the source path'
 
1683
                        ' is marked as absent.')
 
1684
                    # For whatever reason, we were asked to rename an entry
 
1685
                    # that was originally marked as deleted. This could be
 
1686
                    # because we are renaming the parent directory, and the WT
 
1687
                    # current state has the file marked as deleted.
 
1688
                elif entry[1][0][0] == 'r':
 
1689
                    # implement the rename
 
1690
                    del self._dirblocks[block_index][1][entry_index]
 
1691
                else:
 
1692
                    # it is being resurrected here, so blank it out temporarily.
 
1693
                    self._dirblocks[block_index][1][entry_index][1][1] = null
1887
1694
 
1888
1695
    def _after_delta_check_parents(self, parents, index):
1889
1696
        """Check that parents required by the delta are all intact.
1890
 
 
 
1697
        
1891
1698
        :param parents: An iterable of (path_utf8, file_id) tuples which are
1892
1699
            required to be present in tree 'index' at path_utf8 with id file_id
1893
1700
            and be a directory.
1898
1705
            # has the right file id.
1899
1706
            entry = self._get_entry(index, file_id, dirname_utf8)
1900
1707
            if entry[1] is None:
1901
 
                self._raise_invalid(dirname_utf8.decode('utf8'),
1902
 
                                    file_id, "This parent is not present.")
 
1708
                self._changes_aborted = True
 
1709
                raise errors.InconsistentDelta(dirname_utf8.decode('utf8'),
 
1710
                    file_id, "This parent is not present.")
1903
1711
            # Parents of things must be directories
1904
 
            if entry[1][index][0] != b'd':
1905
 
                self._raise_invalid(dirname_utf8.decode('utf8'),
1906
 
                                    file_id, "This parent is not a directory.")
 
1712
            if entry[1][index][0] != 'd':
 
1713
                self._changes_aborted = True
 
1714
                raise errors.InconsistentDelta(dirname_utf8.decode('utf8'),
 
1715
                    file_id, "This parent is not a directory.")
1907
1716
 
1908
1717
    def _observed_sha1(self, entry, sha1, stat_value,
1909
 
                       _stat_to_minikind=_stat_to_minikind):
 
1718
        _stat_to_minikind=_stat_to_minikind, _pack_stat=pack_stat):
1910
1719
        """Note the sha1 of a file.
1911
1720
 
1912
1721
        :param entry: The entry the sha1 is for.
1914
1723
        :param stat_value: The os.lstat for the file.
1915
1724
        """
1916
1725
        try:
1917
 
            minikind = _stat_to_minikind[stat_value.st_mode & 0o170000]
 
1726
            minikind = _stat_to_minikind[stat_value.st_mode & 0170000]
1918
1727
        except KeyError:
1919
1728
            # Unhandled kind
1920
1729
            return None
1921
 
        if minikind == b'f':
 
1730
        packed_stat = _pack_stat(stat_value)
 
1731
        if minikind == 'f':
1922
1732
            if self._cutoff_time is None:
1923
1733
                self._sha_cutoff_time()
1924
1734
            if (stat_value.st_mtime < self._cutoff_time
1925
 
                    and stat_value.st_ctime < self._cutoff_time):
1926
 
                entry[1][0] = (b'f', sha1, stat_value.st_size, entry[1][0][3],
1927
 
                               pack_stat(stat_value))
1928
 
                self._mark_modified([entry])
 
1735
                and stat_value.st_ctime < self._cutoff_time):
 
1736
                entry[1][0] = ('f', sha1, entry[1][0][2], entry[1][0][3],
 
1737
                    packed_stat)
 
1738
                self._dirblock_state = DirState.IN_MEMORY_MODIFIED
1929
1739
 
1930
1740
    def _sha_cutoff_time(self):
1931
1741
        """Return cutoff time.
1952
1762
 
1953
1763
    def _is_executable(self, mode, old_executable):
1954
1764
        """Is this file executable?"""
1955
 
        if self._use_filesystem_for_exec:
1956
 
            return bool(S_IEXEC & mode)
1957
 
        else:
1958
 
            return old_executable
 
1765
        return bool(S_IEXEC & mode)
 
1766
 
 
1767
    def _is_executable_win32(self, mode, old_executable):
 
1768
        """On win32 the executable bit is stored in the dirstate."""
 
1769
        return old_executable
 
1770
 
 
1771
    if sys.platform == 'win32':
 
1772
        _is_executable = _is_executable_win32
1959
1773
 
1960
1774
    def _read_link(self, abspath, old_link):
1961
1775
        """Read the target of a symlink"""
1964
1778
        #       higher level, because there either won't be anything on disk,
1965
1779
        #       or the thing on disk will be a file.
1966
1780
        fs_encoding = osutils._fs_enc
1967
 
        if isinstance(abspath, text_type):
 
1781
        if isinstance(abspath, unicode):
1968
1782
            # abspath is defined as the path to pass to lstat. readlink is
1969
1783
            # buggy in python < 2.6 (it doesn't encode unicode path into FS
1970
1784
            # encoding), so we need to encode ourselves knowing that unicode
1971
1785
            # paths are produced by UnicodeDirReader on purpose.
1972
1786
            abspath = abspath.encode(fs_encoding)
1973
1787
        target = os.readlink(abspath)
1974
 
        if fs_encoding not in ('utf-8', 'ascii'):
 
1788
        if fs_encoding not in ('UTF-8', 'US-ASCII', 'ANSI_X3.4-1968'):
1975
1789
            # Change encoding if needed
1976
1790
            target = target.decode(fs_encoding).encode('UTF-8')
1977
1791
        return target
1984
1798
    def get_lines(self):
1985
1799
        """Serialise the entire dirstate to a sequence of lines."""
1986
1800
        if (self._header_state == DirState.IN_MEMORY_UNMODIFIED and
1987
 
                self._dirblock_state == DirState.IN_MEMORY_UNMODIFIED):
1988
 
            # read what's on disk.
 
1801
            self._dirblock_state == DirState.IN_MEMORY_UNMODIFIED):
 
1802
            # read whats on disk.
1989
1803
            self._state_file.seek(0)
1990
1804
            return self._state_file.readlines()
1991
1805
        lines = []
1992
1806
        lines.append(self._get_parents_line(self.get_parent_ids()))
1993
1807
        lines.append(self._get_ghosts_line(self._ghosts))
1994
 
        lines.extend(self._iter_entry_lines())
 
1808
        # append the root line which is special cased
 
1809
        lines.extend(map(self._entry_to_line, self._iter_entries()))
1995
1810
        return self._get_output_lines(lines)
1996
1811
 
1997
1812
    def _get_ghosts_line(self, ghost_ids):
1998
1813
        """Create a line for the state file for ghost information."""
1999
 
        return b'\0'.join([b'%d' % len(ghost_ids)] + ghost_ids)
 
1814
        return '\0'.join([str(len(ghost_ids))] + ghost_ids)
2000
1815
 
2001
1816
    def _get_parents_line(self, parent_ids):
2002
1817
        """Create a line for the state file for parents information."""
2003
 
        return b'\0'.join([b'%d' % len(parent_ids)] + parent_ids)
2004
 
 
2005
 
    def _iter_entry_lines(self):
2006
 
        """Create lines for entries."""
2007
 
        return map(self._entry_to_line, self._iter_entries())
 
1818
        return '\0'.join([str(len(parent_ids))] + parent_ids)
2008
1819
 
2009
1820
    def _get_fields_to_entry(self):
2010
1821
        """Get a function which converts entry fields into a entry record.
2020
1831
            def fields_to_entry_0_parents(fields, _int=int):
2021
1832
                path_name_file_id_key = (fields[0], fields[1], fields[2])
2022
1833
                return (path_name_file_id_key, [
2023
 
                    (  # Current tree
 
1834
                    ( # Current tree
2024
1835
                        fields[3],                # minikind
2025
1836
                        fields[4],                # fingerprint
2026
1837
                        _int(fields[5]),          # size
2027
 
                        fields[6] == b'y',         # executable
 
1838
                        fields[6] == 'y',         # executable
2028
1839
                        fields[7],                # packed_stat or revision_id
2029
1840
                    )])
2030
1841
            return fields_to_entry_0_parents
2032
1843
            def fields_to_entry_1_parent(fields, _int=int):
2033
1844
                path_name_file_id_key = (fields[0], fields[1], fields[2])
2034
1845
                return (path_name_file_id_key, [
2035
 
                    (  # Current tree
 
1846
                    ( # Current tree
2036
1847
                        fields[3],                # minikind
2037
1848
                        fields[4],                # fingerprint
2038
1849
                        _int(fields[5]),          # size
2039
 
                        fields[6] == b'y',         # executable
 
1850
                        fields[6] == 'y',         # executable
2040
1851
                        fields[7],                # packed_stat or revision_id
2041
1852
                    ),
2042
 
                    (  # Parent 1
 
1853
                    ( # Parent 1
2043
1854
                        fields[8],                # minikind
2044
1855
                        fields[9],                # fingerprint
2045
1856
                        _int(fields[10]),         # size
2046
 
                        fields[11] == b'y',        # executable
 
1857
                        fields[11] == 'y',        # executable
2047
1858
                        fields[12],               # packed_stat or revision_id
2048
1859
                    ),
2049
1860
                    ])
2052
1863
            def fields_to_entry_2_parents(fields, _int=int):
2053
1864
                path_name_file_id_key = (fields[0], fields[1], fields[2])
2054
1865
                return (path_name_file_id_key, [
2055
 
                    (  # Current tree
 
1866
                    ( # Current tree
2056
1867
                        fields[3],                # minikind
2057
1868
                        fields[4],                # fingerprint
2058
1869
                        _int(fields[5]),          # size
2059
 
                        fields[6] == b'y',         # executable
 
1870
                        fields[6] == 'y',         # executable
2060
1871
                        fields[7],                # packed_stat or revision_id
2061
1872
                    ),
2062
 
                    (  # Parent 1
 
1873
                    ( # Parent 1
2063
1874
                        fields[8],                # minikind
2064
1875
                        fields[9],                # fingerprint
2065
1876
                        _int(fields[10]),         # size
2066
 
                        fields[11] == b'y',        # executable
 
1877
                        fields[11] == 'y',        # executable
2067
1878
                        fields[12],               # packed_stat or revision_id
2068
1879
                    ),
2069
 
                    (  # Parent 2
 
1880
                    ( # Parent 2
2070
1881
                        fields[13],               # minikind
2071
1882
                        fields[14],               # fingerprint
2072
1883
                        _int(fields[15]),         # size
2073
 
                        fields[16] == b'y',        # executable
 
1884
                        fields[16] == 'y',        # executable
2074
1885
                        fields[17],               # packed_stat or revision_id
2075
1886
                    ),
2076
1887
                    ])
2079
1890
            def fields_to_entry_n_parents(fields, _int=int):
2080
1891
                path_name_file_id_key = (fields[0], fields[1], fields[2])
2081
1892
                trees = [(fields[cur],                # minikind
2082
 
                          fields[cur + 1],              # fingerprint
2083
 
                          _int(fields[cur + 2]),        # size
2084
 
                          fields[cur + 3] == b'y',       # executable
2085
 
                          fields[cur + 4],              # stat or revision_id
2086
 
                          ) for cur in range(3, len(fields) - 1, 5)]
 
1893
                          fields[cur+1],              # fingerprint
 
1894
                          _int(fields[cur+2]),        # size
 
1895
                          fields[cur+3] == 'y',       # executable
 
1896
                          fields[cur+4],              # stat or revision_id
 
1897
                         ) for cur in xrange(3, len(fields)-1, 5)]
2087
1898
                return path_name_file_id_key, trees
2088
1899
            return fields_to_entry_n_parents
2089
1900
 
2113
1924
            tree present there.
2114
1925
        """
2115
1926
        self._read_dirblocks_if_needed()
2116
 
        key = dirname, basename, b''
 
1927
        key = dirname, basename, ''
2117
1928
        block_index, present = self._find_block_index_from_key(key)
2118
1929
        if not present:
2119
1930
            # no such directory - return the dir index and 0 for the row.
2120
1931
            return block_index, 0, False, False
2121
 
        block = self._dirblocks[block_index][1]  # access the entries only
 
1932
        block = self._dirblocks[block_index][1] # access the entries only
2122
1933
        entry_index, present = self._find_entry_index(key, block)
2123
1934
        # linear search through entries at this path to find the one
2124
1935
        # requested.
2125
1936
        while entry_index < len(block) and block[entry_index][0][1] == basename:
2126
 
            if block[entry_index][1][tree_index][0] not in (b'a', b'r'):
 
1937
            if block[entry_index][1][tree_index][0] not in 'ar':
2127
1938
                # neither absent or relocated
2128
1939
                return block_index, entry_index, True, True
2129
1940
            entry_index += 1
2130
1941
        return block_index, entry_index, True, False
2131
1942
 
2132
 
    def _get_entry(self, tree_index, fileid_utf8=None, path_utf8=None,
2133
 
                   include_deleted=False):
 
1943
    def _get_entry(self, tree_index, fileid_utf8=None, path_utf8=None, include_deleted=False):
2134
1944
        """Get the dirstate entry for path in tree tree_index.
2135
1945
 
2136
1946
        If either file_id or path is supplied, it is used as the key to lookup.
2151
1961
        """
2152
1962
        self._read_dirblocks_if_needed()
2153
1963
        if path_utf8 is not None:
2154
 
            if not isinstance(path_utf8, bytes):
2155
 
                raise errors.BzrError('path_utf8 is not bytes: %s %r'
2156
 
                                      % (type(path_utf8), path_utf8))
 
1964
            if type(path_utf8) is not str:
 
1965
                raise errors.BzrError('path_utf8 is not a str: %s %r'
 
1966
                    % (type(path_utf8), path_utf8))
2157
1967
            # path lookups are faster
2158
1968
            dirname, basename = osutils.split(path_utf8)
2159
1969
            block_index, entry_index, dir_present, file_present = \
2161
1971
            if not file_present:
2162
1972
                return None, None
2163
1973
            entry = self._dirblocks[block_index][1][entry_index]
2164
 
            if not (entry[0][2] and entry[1][tree_index][0] not in (b'a', b'r')):
 
1974
            if not (entry[0][2] and entry[1][tree_index][0] not in ('a', 'r')):
2165
1975
                raise AssertionError('unversioned entry?')
2166
1976
            if fileid_utf8:
2167
1977
                if entry[0][2] != fileid_utf8:
2170
1980
                                          ' tree_index, file_id and path')
2171
1981
            return entry
2172
1982
        else:
2173
 
            possible_keys = self._get_id_index().get(fileid_utf8, ())
 
1983
            possible_keys = self._get_id_index().get(fileid_utf8, None)
2174
1984
            if not possible_keys:
2175
1985
                return None, None
2176
1986
            for key in possible_keys:
2189
1999
                    entry = self._dirblocks[block_index][1][entry_index]
2190
2000
                    # TODO: We might want to assert that entry[0][2] ==
2191
2001
                    #       fileid_utf8.
2192
 
                    # GZ 2017-06-09: Hoist set of minkinds somewhere
2193
 
                    if entry[1][tree_index][0] in {b'f', b'd', b'l', b't'}:
 
2002
                    if entry[1][tree_index][0] in 'fdlt':
2194
2003
                        # this is the result we are looking for: the
2195
2004
                        # real home of this file_id in this tree.
2196
2005
                        return entry
2197
 
                    if entry[1][tree_index][0] == b'a':
 
2006
                    if entry[1][tree_index][0] == 'a':
2198
2007
                        # there is no home for this entry in this tree
2199
2008
                        if include_deleted:
2200
2009
                            return entry
2201
2010
                        return None, None
2202
 
                    if entry[1][tree_index][0] != b'r':
 
2011
                    if entry[1][tree_index][0] != 'r':
2203
2012
                        raise AssertionError(
2204
 
                            "entry %r has invalid minikind %r for tree %r"
 
2013
                            "entry %r has invalid minikind %r for tree %r" \
2205
2014
                            % (entry,
2206
2015
                               entry[1][tree_index][0],
2207
2016
                               tree_index))
2208
2017
                    real_path = entry[1][tree_index][1]
2209
2018
                    return self._get_entry(tree_index, fileid_utf8=fileid_utf8,
2210
 
                                           path_utf8=real_path)
 
2019
                        path_utf8=real_path)
2211
2020
            return None, None
2212
2021
 
2213
2022
    @classmethod
2231
2040
            sha1_provider = DefaultSHA1Provider()
2232
2041
        result = cls(path, sha1_provider)
2233
2042
        # root dir and root dir contents with no children.
2234
 
        empty_tree_dirblocks = [(b'', []), (b'', [])]
 
2043
        empty_tree_dirblocks = [('', []), ('', [])]
2235
2044
        # a new root directory, with a NULLSTAT.
2236
2045
        empty_tree_dirblocks[0][1].append(
2237
 
            ((b'', b'', inventory.ROOT_ID), [
2238
 
                (b'd', b'', 0, False, DirState.NULLSTAT),
 
2046
            (('', '', inventory.ROOT_ID), [
 
2047
                ('d', '', 0, False, DirState.NULLSTAT),
2239
2048
            ]))
2240
2049
        result.lock_write()
2241
2050
        try:
2259
2068
        minikind = DirState._kind_to_minikind[kind]
2260
2069
        tree_data = inv_entry.revision
2261
2070
        if kind == 'directory':
2262
 
            fingerprint = b''
 
2071
            fingerprint = ''
2263
2072
            size = 0
2264
2073
            executable = False
2265
2074
        elif kind == 'symlink':
2266
2075
            if inv_entry.symlink_target is None:
2267
 
                fingerprint = b''
 
2076
                fingerprint = ''
2268
2077
            else:
2269
2078
                fingerprint = inv_entry.symlink_target.encode('utf8')
2270
2079
            size = 0
2271
2080
            executable = False
2272
2081
        elif kind == 'file':
2273
 
            fingerprint = inv_entry.text_sha1 or b''
 
2082
            fingerprint = inv_entry.text_sha1 or ''
2274
2083
            size = inv_entry.text_size or 0
2275
2084
            executable = inv_entry.executable
2276
2085
        elif kind == 'tree-reference':
2277
 
            fingerprint = inv_entry.reference_revision or b''
 
2086
            fingerprint = inv_entry.reference_revision or ''
2278
2087
            size = 0
2279
2088
            executable = False
2280
2089
        else:
2281
2090
            raise Exception("can't pack %s" % inv_entry)
2282
 
        return static_tuple.StaticTuple(minikind, fingerprint, size,
2283
 
                                        executable, tree_data)
 
2091
        return (minikind, fingerprint, size, executable, tree_data)
2284
2092
 
2285
2093
    def _iter_child_entries(self, tree_index, path_utf8):
2286
2094
        """Iterate over all the entries that are children of path_utf.
2287
2095
 
2288
 
        This only returns entries that are present (not in b'a', b'r') in
 
2096
        This only returns entries that are present (not in 'a', 'r') in
2289
2097
        tree_index. tree_index data is not refreshed, so if tree 0 is used,
2290
2098
        results may differ from that obtained if paths were statted to
2291
2099
        determine what ones were directories.
2295
2103
        """
2296
2104
        pending_dirs = []
2297
2105
        next_pending_dirs = [path_utf8]
2298
 
        absent = (b'a', b'r')
 
2106
        absent = 'ar'
2299
2107
        while next_pending_dirs:
2300
2108
            pending_dirs = next_pending_dirs
2301
2109
            next_pending_dirs = []
2302
2110
            for path in pending_dirs:
2303
2111
                block_index, present = self._find_block_index_from_key(
2304
 
                    (path, b'', b''))
 
2112
                    (path, '', ''))
2305
2113
                if block_index == 0:
2306
2114
                    block_index = 1
2307
2115
                    if len(self._dirblocks) == 1:
2316
2124
                    kind = entry[1][tree_index][0]
2317
2125
                    if kind not in absent:
2318
2126
                        yield entry
2319
 
                    if kind == b'd':
 
2127
                    if kind == 'd':
2320
2128
                        if entry[0][0]:
2321
 
                            path = entry[0][0] + b'/' + entry[0][1]
 
2129
                            path = entry[0][0] + '/' + entry[0][1]
2322
2130
                        else:
2323
2131
                            path = entry[0][1]
2324
2132
                        next_pending_dirs.append(path)
2327
2135
        """Iterate over all the entries in the dirstate.
2328
2136
 
2329
2137
        Each yelt item is an entry in the standard format described in the
2330
 
        docstring of breezy.dirstate.
 
2138
        docstring of bzrlib.dirstate.
2331
2139
        """
2332
2140
        self._read_dirblocks_if_needed()
2333
2141
        for directory in self._dirblocks:
2335
2143
                yield entry
2336
2144
 
2337
2145
    def _get_id_index(self):
2338
 
        """Get an id index of self._dirblocks.
2339
 
 
2340
 
        This maps from file_id => [(directory, name, file_id)] entries where
2341
 
        that file_id appears in one of the trees.
2342
 
        """
 
2146
        """Get an id index of self._dirblocks."""
2343
2147
        if self._id_index is None:
2344
2148
            id_index = {}
2345
2149
            for key, tree_details in self._iter_entries():
2346
 
                self._add_to_id_index(id_index, key)
 
2150
                id_index.setdefault(key[2], set()).add(key)
2347
2151
            self._id_index = id_index
2348
2152
        return self._id_index
2349
2153
 
2350
 
    def _add_to_id_index(self, id_index, entry_key):
2351
 
        """Add this entry to the _id_index mapping."""
2352
 
        # This code used to use a set for every entry in the id_index. However,
2353
 
        # it is *rare* to have more than one entry. So a set is a large
2354
 
        # overkill. And even when we do, we won't ever have more than the
2355
 
        # number of parent trees. Which is still a small number (rarely >2). As
2356
 
        # such, we use a simple tuple, and do our own uniqueness checks. While
2357
 
        # the 'in' check is O(N) since N is nicely bounded it shouldn't ever
2358
 
        # cause quadratic failure.
2359
 
        file_id = entry_key[2]
2360
 
        entry_key = static_tuple.StaticTuple.from_sequence(entry_key)
2361
 
        if file_id not in id_index:
2362
 
            id_index[file_id] = static_tuple.StaticTuple(entry_key,)
2363
 
        else:
2364
 
            entry_keys = id_index[file_id]
2365
 
            if entry_key not in entry_keys:
2366
 
                id_index[file_id] = entry_keys + (entry_key,)
2367
 
 
2368
 
    def _remove_from_id_index(self, id_index, entry_key):
2369
 
        """Remove this entry from the _id_index mapping.
2370
 
 
2371
 
        It is an programming error to call this when the entry_key is not
2372
 
        already present.
2373
 
        """
2374
 
        file_id = entry_key[2]
2375
 
        entry_keys = list(id_index[file_id])
2376
 
        entry_keys.remove(entry_key)
2377
 
        id_index[file_id] = static_tuple.StaticTuple.from_sequence(entry_keys)
2378
 
 
2379
2154
    def _get_output_lines(self, lines):
2380
2155
        """Format lines for final output.
2381
2156
 
2383
2158
            path lines.
2384
2159
        """
2385
2160
        output_lines = [DirState.HEADER_FORMAT_3]
2386
 
        lines.append(b'')  # a final newline
2387
 
        inventory_text = b'\0\n\0'.join(lines)
2388
 
        output_lines.append(b'crc32: %d\n' % (zlib.crc32(inventory_text),))
 
2161
        lines.append('') # a final newline
 
2162
        inventory_text = '\0\n\0'.join(lines)
 
2163
        output_lines.append('crc32: %s\n' % (zlib.crc32(inventory_text),))
2389
2164
        # -3, 1 for num parents, 1 for ghosts, 1 for final newline
2390
 
        num_entries = len(lines) - 3
2391
 
        output_lines.append(b'num_entries: %d\n' % (num_entries,))
 
2165
        num_entries = len(lines)-3
 
2166
        output_lines.append('num_entries: %s\n' % (num_entries,))
2392
2167
        output_lines.append(inventory_text)
2393
2168
        return output_lines
2394
2169
 
2395
2170
    def _make_deleted_row(self, fileid_utf8, parents):
2396
2171
        """Return a deleted row for fileid_utf8."""
2397
 
        return (b'/', b'RECYCLED.BIN', b'file', fileid_utf8, 0, DirState.NULLSTAT,
2398
 
                b''), parents
 
2172
        return ('/', 'RECYCLED.BIN', 'file', fileid_utf8, 0, DirState.NULLSTAT,
 
2173
            ''), parents
2399
2174
 
2400
2175
    def _num_present_parents(self):
2401
2176
        """The number of parent entries in each record row."""
2402
2177
        return len(self._parents) - len(self._ghosts)
2403
2178
 
2404
 
    @classmethod
2405
 
    def on_file(cls, path, sha1_provider=None, worth_saving_limit=0,
2406
 
                use_filesystem_for_exec=True):
 
2179
    @staticmethod
 
2180
    def on_file(path, sha1_provider=None):
2407
2181
        """Construct a DirState on the file at path "path".
2408
2182
 
2409
2183
        :param path: The path at which the dirstate file on disk should live.
2410
2184
        :param sha1_provider: an object meeting the SHA1Provider interface.
2411
2185
            If None, a DefaultSHA1Provider is used.
2412
 
        :param worth_saving_limit: when the exact number of hash changed
2413
 
            entries is known, only bother saving the dirstate if more than
2414
 
            this count of entries have changed. -1 means never save.
2415
 
        :param use_filesystem_for_exec: Whether to trust the filesystem
2416
 
            for executable bit information
2417
2186
        :return: An unlocked DirState object, associated with the given path.
2418
2187
        """
2419
2188
        if sha1_provider is None:
2420
2189
            sha1_provider = DefaultSHA1Provider()
2421
 
        result = cls(path, sha1_provider,
2422
 
                     worth_saving_limit=worth_saving_limit,
2423
 
                     use_filesystem_for_exec=use_filesystem_for_exec)
 
2190
        result = DirState(path, sha1_provider)
2424
2191
        return result
2425
2192
 
2426
2193
    def _read_dirblocks_if_needed(self):
2444
2211
        """
2445
2212
        self._read_prelude()
2446
2213
        parent_line = self._state_file.readline()
2447
 
        info = parent_line.split(b'\0')
 
2214
        info = parent_line.split('\0')
2448
2215
        num_parents = int(info[0])
2449
2216
        self._parents = info[1:-1]
2450
2217
        ghost_line = self._state_file.readline()
2451
 
        info = ghost_line.split(b'\0')
 
2218
        info = ghost_line.split('\0')
2452
2219
        num_ghosts = int(info[1])
2453
2220
        self._ghosts = info[2:-1]
2454
2221
        self._header_state = DirState.IN_MEMORY_UNMODIFIED
2476
2243
            raise errors.BzrError(
2477
2244
                'invalid header line: %r' % (header,))
2478
2245
        crc_line = self._state_file.readline()
2479
 
        if not crc_line.startswith(b'crc32: '):
 
2246
        if not crc_line.startswith('crc32: '):
2480
2247
            raise errors.BzrError('missing crc32 checksum: %r' % crc_line)
2481
 
        self.crc_expected = int(crc_line[len(b'crc32: '):-1])
 
2248
        self.crc_expected = int(crc_line[len('crc32: '):-1])
2482
2249
        num_entries_line = self._state_file.readline()
2483
 
        if not num_entries_line.startswith(b'num_entries: '):
 
2250
        if not num_entries_line.startswith('num_entries: '):
2484
2251
            raise errors.BzrError('missing num_entries line')
2485
 
        self._num_entries = int(num_entries_line[len(b'num_entries: '):-1])
 
2252
        self._num_entries = int(num_entries_line[len('num_entries: '):-1])
2486
2253
 
2487
 
    def sha1_from_stat(self, path, stat_result):
 
2254
    def sha1_from_stat(self, path, stat_result, _pack_stat=pack_stat):
2488
2255
        """Find a sha1 given a stat lookup."""
2489
 
        return self._get_packed_stat_index().get(pack_stat(stat_result), None)
 
2256
        return self._get_packed_stat_index().get(_pack_stat(stat_result), None)
2490
2257
 
2491
2258
    def _get_packed_stat_index(self):
2492
2259
        """Get a packed_stat index of self._dirblocks."""
2493
2260
        if self._packed_stat_index is None:
2494
2261
            index = {}
2495
2262
            for key, tree_details in self._iter_entries():
2496
 
                if tree_details[0][0] == b'f':
 
2263
                if tree_details[0][0] == 'f':
2497
2264
                    index[tree_details[0][4]] = tree_details[0][1]
2498
2265
            self._packed_stat_index = index
2499
2266
        return self._packed_stat_index
2516
2283
            # Should this be a warning? For now, I'm expecting that places that
2517
2284
            # mark it inconsistent will warn, making a warning here redundant.
2518
2285
            trace.mutter('Not saving DirState because '
2519
 
                         '_changes_aborted is set.')
2520
 
            return
2521
 
        # TODO: Since we now distinguish IN_MEMORY_MODIFIED from
2522
 
        #       IN_MEMORY_HASH_MODIFIED, we should only fail quietly if we fail
2523
 
        #       to save an IN_MEMORY_HASH_MODIFIED, and fail *noisily* if we
2524
 
        #       fail to save IN_MEMORY_MODIFIED
2525
 
        if not self._worth_saving():
2526
 
            return
 
2286
                    '_changes_aborted is set.')
 
2287
            return
 
2288
        if (self._header_state == DirState.IN_MEMORY_MODIFIED or
 
2289
            self._dirblock_state == DirState.IN_MEMORY_MODIFIED):
2527
2290
 
2528
 
        grabbed_write_lock = False
2529
 
        if self._lock_state != 'w':
2530
 
            grabbed_write_lock, new_lock = self._lock_token.temporary_write_lock()
2531
 
            # Switch over to the new lock, as the old one may be closed.
2532
 
            # TODO: jam 20070315 We should validate the disk file has
2533
 
            #       not changed contents, since temporary_write_lock may
2534
 
            #       not be an atomic operation.
2535
 
            self._lock_token = new_lock
2536
 
            self._state_file = new_lock.f
2537
 
            if not grabbed_write_lock:
2538
 
                # We couldn't grab a write lock, so we switch back to a read one
2539
 
                return
2540
 
        try:
2541
 
            lines = self.get_lines()
2542
 
            self._state_file.seek(0)
2543
 
            self._state_file.writelines(lines)
2544
 
            self._state_file.truncate()
2545
 
            self._state_file.flush()
2546
 
            self._maybe_fdatasync()
2547
 
            self._mark_unmodified()
2548
 
        finally:
2549
 
            if grabbed_write_lock:
2550
 
                self._lock_token = self._lock_token.restore_read_lock()
2551
 
                self._state_file = self._lock_token.f
 
2291
            grabbed_write_lock = False
 
2292
            if self._lock_state != 'w':
 
2293
                grabbed_write_lock, new_lock = self._lock_token.temporary_write_lock()
 
2294
                # Switch over to the new lock, as the old one may be closed.
2552
2295
                # TODO: jam 20070315 We should validate the disk file has
2553
 
                #       not changed contents. Since restore_read_lock may
 
2296
                #       not changed contents. Since temporary_write_lock may
2554
2297
                #       not be an atomic operation.
2555
 
 
2556
 
    def _maybe_fdatasync(self):
2557
 
        """Flush to disk if possible and if not configured off."""
2558
 
        if self._config_stack.get('dirstate.fdatasync'):
2559
 
            osutils.fdatasync(self._state_file.fileno())
2560
 
 
2561
 
    def _worth_saving(self):
2562
 
        """Is it worth saving the dirstate or not?"""
2563
 
        if (self._header_state == DirState.IN_MEMORY_MODIFIED
2564
 
                or self._dirblock_state == DirState.IN_MEMORY_MODIFIED):
2565
 
            return True
2566
 
        if self._dirblock_state == DirState.IN_MEMORY_HASH_MODIFIED:
2567
 
            if self._worth_saving_limit == -1:
2568
 
                # We never save hash changes when the limit is -1
2569
 
                return False
2570
 
            # If we're using smart saving and only a small number of
2571
 
            # entries have changed their hash, don't bother saving. John has
2572
 
            # suggested using a heuristic here based on the size of the
2573
 
            # changed files and/or tree. For now, we go with a configurable
2574
 
            # number of changes, keeping the calculation time
2575
 
            # as low overhead as possible. (This also keeps all existing
2576
 
            # tests passing as the default is 0, i.e. always save.)
2577
 
            if len(self._known_hash_changes) >= self._worth_saving_limit:
2578
 
                return True
2579
 
        return False
 
2298
                self._lock_token = new_lock
 
2299
                self._state_file = new_lock.f
 
2300
                if not grabbed_write_lock:
 
2301
                    # We couldn't grab a write lock, so we switch back to a read one
 
2302
                    return
 
2303
            try:
 
2304
                self._state_file.seek(0)
 
2305
                self._state_file.writelines(self.get_lines())
 
2306
                self._state_file.truncate()
 
2307
                self._state_file.flush()
 
2308
                self._header_state = DirState.IN_MEMORY_UNMODIFIED
 
2309
                self._dirblock_state = DirState.IN_MEMORY_UNMODIFIED
 
2310
            finally:
 
2311
                if grabbed_write_lock:
 
2312
                    self._lock_token = self._lock_token.restore_read_lock()
 
2313
                    self._state_file = self._lock_token.f
 
2314
                    # TODO: jam 20070315 We should validate the disk file has
 
2315
                    #       not changed contents. Since restore_read_lock may
 
2316
                    #       not be an atomic operation.
2580
2317
 
2581
2318
    def _set_data(self, parent_ids, dirblocks):
2582
2319
        """Set the full dirstate data in memory.
2591
2328
        """
2592
2329
        # our memory copy is now authoritative.
2593
2330
        self._dirblocks = dirblocks
2594
 
        self._mark_modified(header_modified=True)
 
2331
        self._header_state = DirState.IN_MEMORY_MODIFIED
 
2332
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
2595
2333
        self._parents = list(parent_ids)
2596
2334
        self._id_index = None
2597
2335
        self._packed_stat_index = None
2599
2337
    def set_path_id(self, path, new_id):
2600
2338
        """Change the id of path to new_id in the current working tree.
2601
2339
 
2602
 
        :param path: The path inside the tree to set - b'' is the root, 'foo'
 
2340
        :param path: The path inside the tree to set - '' is the root, 'foo'
2603
2341
            is the path foo in the root.
2604
2342
        :param new_id: The new id to assign to the path. This must be a utf8
2605
2343
            file id (not unicode, and not None).
2613
2351
        if entry[0][2] == new_id:
2614
2352
            # Nothing to change.
2615
2353
            return
2616
 
        if new_id.__class__ != bytes:
2617
 
            raise AssertionError(
2618
 
                "must be a utf8 file_id not %s" % (type(new_id), ))
2619
2354
        # mark the old path absent, and insert a new root path
2620
2355
        self._make_absent(entry)
2621
 
        self.update_minimal((b'', b'', new_id), b'd',
2622
 
                            path_utf8=b'', packed_stat=entry[1][0][4])
2623
 
        self._mark_modified()
 
2356
        self.update_minimal(('', '', new_id), 'd',
 
2357
            path_utf8='', packed_stat=entry[1][0][4])
 
2358
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
2624
2359
 
2625
2360
    def set_parent_trees(self, trees, ghosts):
2626
2361
        """Set the parent trees for the dirstate.
2671
2406
        parent_trees = [tree for rev_id, tree in trees if rev_id not in ghosts]
2672
2407
        # how many trees do we end up with
2673
2408
        parent_count = len(parent_trees)
2674
 
        st = static_tuple.StaticTuple
2675
2409
 
2676
2410
        # one: the current tree
2677
2411
        for entry in self._iter_entries():
2678
2412
            # skip entries not in the current tree
2679
 
            if entry[1][0][0] in (b'a', b'r'):  # absent, relocated
 
2413
            if entry[1][0][0] in 'ar': # absent, relocated
2680
2414
                continue
2681
2415
            by_path[entry[0]] = [entry[1][0]] + \
2682
2416
                [DirState.NULL_PARENT_DETAILS] * parent_count
2683
 
            # TODO: Possibly inline this, since we know it isn't present yet
2684
 
            #       id_index[entry[0][2]] = (entry[0],)
2685
 
            self._add_to_id_index(id_index, entry[0])
 
2417
            id_index[entry[0][2]] = set([entry[0]])
2686
2418
 
2687
2419
        # now the parent trees:
2688
2420
        for tree_index, tree in enumerate(parent_trees):
2692
2424
            # any fileid in this tree as we set the by_path[id] to:
2693
2425
            # already_processed_tree_details + new_details + new_location_suffix
2694
2426
            # the suffix is from tree_index+1:parent_count+1.
2695
 
            new_location_suffix = [
2696
 
                DirState.NULL_PARENT_DETAILS] * (parent_count - tree_index)
 
2427
            new_location_suffix = [DirState.NULL_PARENT_DETAILS] * (parent_count - tree_index)
2697
2428
            # now stitch in all the entries from this tree
2698
 
            last_dirname = None
2699
 
            for path, entry in tree.iter_entries_by_dir():
 
2429
            for path, entry in tree.inventory.iter_entries_by_dir():
2700
2430
                # here we process each trees details for each item in the tree.
2701
2431
                # we first update any existing entries for the id at other paths,
2702
2432
                # then we either create or update the entry for the id at the
2709
2439
                file_id = entry.file_id
2710
2440
                path_utf8 = path.encode('utf8')
2711
2441
                dirname, basename = osutils.split(path_utf8)
2712
 
                if dirname == last_dirname:
2713
 
                    # Try to re-use objects as much as possible
2714
 
                    dirname = last_dirname
2715
 
                else:
2716
 
                    last_dirname = dirname
2717
 
                new_entry_key = st(dirname, basename, file_id)
 
2442
                new_entry_key = (dirname, basename, file_id)
2718
2443
                # tree index consistency: All other paths for this id in this tree
2719
2444
                # index must point to the correct path.
2720
 
                entry_keys = id_index.get(file_id, ())
2721
 
                for entry_key in entry_keys:
 
2445
                for entry_key in id_index.setdefault(file_id, set()):
2722
2446
                    # TODO:PROFILING: It might be faster to just update
2723
2447
                    # rather than checking if we need to, and then overwrite
2724
2448
                    # the one we are located at.
2727
2451
                        # other trees, so put absent pointers there
2728
2452
                        # This is the vertical axis in the matrix, all pointing
2729
2453
                        # to the real path.
2730
 
                        by_path[entry_key][tree_index] = st(b'r', path_utf8, 0,
2731
 
                                                            False, b'')
2732
 
                # by path consistency: Insert into an existing path record
2733
 
                # (trivial), or add a new one with relocation pointers for the
2734
 
                # other tree indexes.
2735
 
                if new_entry_key in entry_keys:
2736
 
                    # there is already an entry where this data belongs, just
2737
 
                    # insert it.
 
2454
                        by_path[entry_key][tree_index] = ('r', path_utf8, 0, False, '')
 
2455
                # by path consistency: Insert into an existing path record (trivial), or
 
2456
                # add a new one with relocation pointers for the other tree indexes.
 
2457
                if new_entry_key in id_index[file_id]:
 
2458
                    # there is already an entry where this data belongs, just insert it.
2738
2459
                    by_path[new_entry_key][tree_index] = \
2739
2460
                        self._inv_entry_to_details(entry)
2740
2461
                else:
2742
2463
                    # mapping from path,id. We need to look up the correct path
2743
2464
                    # for the indexes from 0 to tree_index -1
2744
2465
                    new_details = []
2745
 
                    for lookup_index in range(tree_index):
 
2466
                    for lookup_index in xrange(tree_index):
2746
2467
                        # boundary case: this is the first occurence of file_id
2747
 
                        # so there are no id_indexes, possibly take this out of
 
2468
                        # so there are no id_indexs, possibly take this out of
2748
2469
                        # the loop?
2749
 
                        if not len(entry_keys):
 
2470
                        if not len(id_index[file_id]):
2750
2471
                            new_details.append(DirState.NULL_PARENT_DETAILS)
2751
2472
                        else:
2752
2473
                            # grab any one entry, use it to find the right path.
2753
 
                            a_key = next(iter(entry_keys))
2754
 
                            if by_path[a_key][lookup_index][0] in (b'r', b'a'):
2755
 
                                # its a pointer or missing statement, use it as
2756
 
                                # is.
2757
 
                                new_details.append(
2758
 
                                    by_path[a_key][lookup_index])
 
2474
                            # TODO: optimise this to reduce memory use in highly
 
2475
                            # fragmented situations by reusing the relocation
 
2476
                            # records.
 
2477
                            a_key = iter(id_index[file_id]).next()
 
2478
                            if by_path[a_key][lookup_index][0] in ('r', 'a'):
 
2479
                                # its a pointer or missing statement, use it as is.
 
2480
                                new_details.append(by_path[a_key][lookup_index])
2759
2481
                            else:
2760
2482
                                # we have the right key, make a pointer to it.
2761
 
                                real_path = (b'/'.join(a_key[0:2])).strip(b'/')
2762
 
                                new_details.append(st(b'r', real_path, 0, False,
2763
 
                                                      b''))
 
2483
                                real_path = ('/'.join(a_key[0:2])).strip('/')
 
2484
                                new_details.append(('r', real_path, 0, False, ''))
2764
2485
                    new_details.append(self._inv_entry_to_details(entry))
2765
2486
                    new_details.extend(new_location_suffix)
2766
2487
                    by_path[new_entry_key] = new_details
2767
 
                    self._add_to_id_index(id_index, new_entry_key)
 
2488
                    id_index[file_id].add(new_entry_key)
2768
2489
        # --- end generation of full tree mappings
2769
2490
 
2770
2491
        # sort and output all the entries
2771
 
        new_entries = self._sort_entries(viewitems(by_path))
 
2492
        new_entries = self._sort_entries(by_path.items())
2772
2493
        self._entries_to_current_state(new_entries)
2773
2494
        self._parents = [rev_id for rev_id, tree in trees]
2774
2495
        self._ghosts = list(ghosts)
2775
 
        self._mark_modified(header_modified=True)
 
2496
        self._header_state = DirState.IN_MEMORY_MODIFIED
 
2497
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
2776
2498
        self._id_index = id_index
2777
2499
 
2778
2500
    def _sort_entries(self, entry_list):
2782
2504
        try to keep everything in sorted blocks all the time, but sometimes
2783
2505
        it's easier to sort after the fact.
2784
2506
        """
2785
 
        # When sorting, we usually have 10x more entries than directories. (69k
2786
 
        # total entries, 4k directories). So cache the results of splitting.
2787
 
        # Saving time and objects. Also, use StaticTuple to avoid putting all
2788
 
        # of these object into python's garbage collector.
2789
 
        split_dirs = {}
2790
 
 
2791
 
        def _key(entry, _split_dirs=split_dirs, _st=static_tuple.StaticTuple):
 
2507
        def _key(entry):
2792
2508
            # sort by: directory parts, file name, file id
2793
 
            dirpath, fname, file_id = entry[0]
2794
 
            try:
2795
 
                split = _split_dirs[dirpath]
2796
 
            except KeyError:
2797
 
                split = _st.from_sequence(dirpath.split(b'/'))
2798
 
                _split_dirs[dirpath] = split
2799
 
            return _st(split, fname, file_id)
 
2509
            return entry[0][0].split('/'), entry[0][1], entry[0][2]
2800
2510
        return sorted(entry_list, key=_key)
2801
2511
 
2802
2512
    def set_state_from_inventory(self, new_inv):
2809
2519
        """
2810
2520
        if 'evil' in debug.debug_flags:
2811
2521
            trace.mutter_callsite(1,
2812
 
                                  "set_state_from_inventory called; please mutate the tree instead")
 
2522
                "set_state_from_inventory called; please mutate the tree instead")
2813
2523
        tracing = 'dirstate' in debug.debug_flags
2814
2524
        if tracing:
2815
2525
            trace.mutter("set_state_from_inventory trace:")
2832
2542
        # underlying dirstate.
2833
2543
        old_iterator = iter(list(self._iter_entries()))
2834
2544
        # both must have roots so this is safe:
2835
 
        current_new = next(new_iterator)
2836
 
        current_old = next(old_iterator)
2837
 
 
 
2545
        current_new = new_iterator.next()
 
2546
        current_old = old_iterator.next()
2838
2547
        def advance(iterator):
2839
2548
            try:
2840
 
                return next(iterator)
 
2549
                return iterator.next()
2841
2550
            except StopIteration:
2842
2551
                return None
2843
2552
        while current_new or current_old:
2844
2553
            # skip entries in old that are not really there
2845
 
            if current_old and current_old[1][0][0] in (b'a', b'r'):
 
2554
            if current_old and current_old[1][0][0] in 'ar':
2846
2555
                # relocated or absent
2847
2556
                current_old = advance(old_iterator)
2848
2557
                continue
2854
2563
                new_entry_key = (new_dirname, new_basename, new_id)
2855
2564
                current_new_minikind = \
2856
2565
                    DirState._kind_to_minikind[current_new[1].kind]
2857
 
                if current_new_minikind == b't':
2858
 
                    fingerprint = current_new[1].reference_revision or b''
 
2566
                if current_new_minikind == 't':
 
2567
                    fingerprint = current_new[1].reference_revision or ''
2859
2568
                else:
2860
2569
                    # We normally only insert or remove records, or update
2861
2570
                    # them when it has significantly changed.  Then we want to
2862
2571
                    # erase its fingerprint.  Unaffected records should
2863
2572
                    # normally not be updated at all.
2864
 
                    fingerprint = b''
 
2573
                    fingerprint = ''
2865
2574
            else:
2866
2575
                # for safety disable variables
2867
2576
                new_path_utf8 = new_dirname = new_basename = new_id = \
2872
2581
                # old is finished: insert current_new into the state.
2873
2582
                if tracing:
2874
2583
                    trace.mutter("Appending from new '%s'.",
2875
 
                                 new_path_utf8.decode('utf8'))
 
2584
                        new_path_utf8.decode('utf8'))
2876
2585
                self.update_minimal(new_entry_key, current_new_minikind,
2877
 
                                    executable=current_new[1].executable,
2878
 
                                    path_utf8=new_path_utf8, fingerprint=fingerprint,
2879
 
                                    fullscan=True)
 
2586
                    executable=current_new[1].executable,
 
2587
                    path_utf8=new_path_utf8, fingerprint=fingerprint,
 
2588
                    fullscan=True)
2880
2589
                current_new = advance(new_iterator)
2881
2590
            elif not current_new:
2882
2591
                # new is finished
2883
2592
                if tracing:
2884
2593
                    trace.mutter("Truncating from old '%s/%s'.",
2885
 
                                 current_old[0][0].decode('utf8'),
2886
 
                                 current_old[0][1].decode('utf8'))
 
2594
                        current_old[0][0].decode('utf8'),
 
2595
                        current_old[0][1].decode('utf8'))
2887
2596
                self._make_absent(current_old)
2888
2597
                current_old = advance(old_iterator)
2889
2598
            elif new_entry_key == current_old[0]:
2895
2604
                # the minimal required trigger is if the execute bit or cached
2896
2605
                # kind has changed.
2897
2606
                if (current_old[1][0][3] != current_new[1].executable or
2898
 
                        current_old[1][0][0] != current_new_minikind):
 
2607
                    current_old[1][0][0] != current_new_minikind):
2899
2608
                    if tracing:
2900
2609
                        trace.mutter("Updating in-place change '%s'.",
2901
 
                                     new_path_utf8.decode('utf8'))
 
2610
                            new_path_utf8.decode('utf8'))
2902
2611
                    self.update_minimal(current_old[0], current_new_minikind,
2903
 
                                        executable=current_new[1].executable,
2904
 
                                        path_utf8=new_path_utf8, fingerprint=fingerprint,
2905
 
                                        fullscan=True)
 
2612
                        executable=current_new[1].executable,
 
2613
                        path_utf8=new_path_utf8, fingerprint=fingerprint,
 
2614
                        fullscan=True)
2906
2615
                # both sides are dealt with, move on
2907
2616
                current_old = advance(old_iterator)
2908
2617
                current_new = advance(new_iterator)
2909
 
            elif (lt_by_dirs(new_dirname, current_old[0][0])
2910
 
                  or (new_dirname == current_old[0][0] and
2911
 
                      new_entry_key[1:] < current_old[0][1:])):
 
2618
            elif (cmp_by_dirs(new_dirname, current_old[0][0]) < 0
 
2619
                  or (new_dirname == current_old[0][0]
 
2620
                      and new_entry_key[1:] < current_old[0][1:])):
2912
2621
                # new comes before:
2913
2622
                # add a entry for this and advance new
2914
2623
                if tracing:
2915
2624
                    trace.mutter("Inserting from new '%s'.",
2916
 
                                 new_path_utf8.decode('utf8'))
 
2625
                        new_path_utf8.decode('utf8'))
2917
2626
                self.update_minimal(new_entry_key, current_new_minikind,
2918
 
                                    executable=current_new[1].executable,
2919
 
                                    path_utf8=new_path_utf8, fingerprint=fingerprint,
2920
 
                                    fullscan=True)
 
2627
                    executable=current_new[1].executable,
 
2628
                    path_utf8=new_path_utf8, fingerprint=fingerprint,
 
2629
                    fullscan=True)
2921
2630
                current_new = advance(new_iterator)
2922
2631
            else:
2923
2632
                # we've advanced past the place where the old key would be,
2924
2633
                # without seeing it in the new list.  so it must be gone.
2925
2634
                if tracing:
2926
2635
                    trace.mutter("Deleting from old '%s/%s'.",
2927
 
                                 current_old[0][0].decode('utf8'),
2928
 
                                 current_old[0][1].decode('utf8'))
 
2636
                        current_old[0][0].decode('utf8'),
 
2637
                        current_old[0][1].decode('utf8'))
2929
2638
                self._make_absent(current_old)
2930
2639
                current_old = advance(old_iterator)
2931
 
        self._mark_modified()
 
2640
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
2932
2641
        self._id_index = None
2933
2642
        self._packed_stat_index = None
2934
2643
        if tracing:
2935
2644
            trace.mutter("set_state_from_inventory complete.")
2936
2645
 
2937
 
    def set_state_from_scratch(self, working_inv, parent_trees, parent_ghosts):
2938
 
        """Wipe the currently stored state and set it to something new.
2939
 
 
2940
 
        This is a hard-reset for the data we are working with.
2941
 
        """
2942
 
        # Technically, we really want a write lock, but until we write, we
2943
 
        # don't really need it.
2944
 
        self._requires_lock()
2945
 
        # root dir and root dir contents with no children. We have to have a
2946
 
        # root for set_state_from_inventory to work correctly.
2947
 
        empty_root = ((b'', b'', inventory.ROOT_ID),
2948
 
                      [(b'd', b'', 0, False, DirState.NULLSTAT)])
2949
 
        empty_tree_dirblocks = [(b'', [empty_root]), (b'', [])]
2950
 
        self._set_data([], empty_tree_dirblocks)
2951
 
        self.set_state_from_inventory(working_inv)
2952
 
        self.set_parent_trees(parent_trees, parent_ghosts)
2953
 
 
2954
2646
    def _make_absent(self, current_old):
2955
2647
        """Mark current_old - an entry - as absent for tree 0.
2956
2648
 
2963
2655
        all_remaining_keys = set()
2964
2656
        # Dont check the working tree, because it's going.
2965
2657
        for details in current_old[1][1:]:
2966
 
            if details[0] not in (b'a', b'r'):  # absent, relocated
 
2658
            if details[0] not in 'ar': # absent, relocated
2967
2659
                all_remaining_keys.add(current_old[0])
2968
 
            elif details[0] == b'r':  # relocated
 
2660
            elif details[0] == 'r': # relocated
2969
2661
                # record the key for the real path.
2970
 
                all_remaining_keys.add(
2971
 
                    tuple(osutils.split(details[1])) + (current_old[0][2],))
 
2662
                all_remaining_keys.add(tuple(osutils.split(details[1])) + (current_old[0][2],))
2972
2663
            # absent rows are not present at any path.
2973
2664
        last_reference = current_old[0] not in all_remaining_keys
2974
2665
        if last_reference:
2976
2667
            # absent), and relocated or absent entries for the other trees:
2977
2668
            # Remove it, its meaningless.
2978
2669
            block = self._find_block(current_old[0])
2979
 
            entry_index, present = self._find_entry_index(
2980
 
                current_old[0], block[1])
 
2670
            entry_index, present = self._find_entry_index(current_old[0], block[1])
2981
2671
            if not present:
2982
 
                raise AssertionError(
2983
 
                    'could not find entry for %s' % (current_old,))
 
2672
                raise AssertionError('could not find entry for %s' % (current_old,))
2984
2673
            block[1].pop(entry_index)
2985
2674
            # if we have an id_index in use, remove this key from it for this id.
2986
2675
            if self._id_index is not None:
2987
 
                self._remove_from_id_index(self._id_index, current_old[0])
 
2676
                self._id_index[current_old[0][2]].remove(current_old[0])
2988
2677
        # update all remaining keys for this id to record it as absent. The
2989
2678
        # existing details may either be the record we are marking as deleted
2990
2679
        # (if there were other trees with the id present at this path), or may
2993
2682
            update_block_index, present = \
2994
2683
                self._find_block_index_from_key(update_key)
2995
2684
            if not present:
2996
 
                raise AssertionError(
2997
 
                    'could not find block for %s' % (update_key,))
 
2685
                raise AssertionError('could not find block for %s' % (update_key,))
2998
2686
            update_entry_index, present = \
2999
 
                self._find_entry_index(
3000
 
                    update_key, self._dirblocks[update_block_index][1])
 
2687
                self._find_entry_index(update_key, self._dirblocks[update_block_index][1])
3001
2688
            if not present:
3002
 
                raise AssertionError(
3003
 
                    'could not find entry for %s' % (update_key,))
 
2689
                raise AssertionError('could not find entry for %s' % (update_key,))
3004
2690
            update_tree_details = self._dirblocks[update_block_index][1][update_entry_index][1]
3005
2691
            # it must not be absent at the moment
3006
 
            if update_tree_details[0][0] == b'a':  # absent
 
2692
            if update_tree_details[0][0] == 'a': # absent
3007
2693
                raise AssertionError('bad row %r' % (update_tree_details,))
3008
2694
            update_tree_details[0] = DirState.NULL_PARENT_DETAILS
3009
 
        self._mark_modified()
 
2695
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
3010
2696
        return last_reference
3011
2697
 
3012
 
    def update_minimal(self, key, minikind, executable=False, fingerprint=b'',
3013
 
                       packed_stat=None, size=0, path_utf8=None, fullscan=False):
 
2698
    def update_minimal(self, key, minikind, executable=False, fingerprint='',
 
2699
        packed_stat=None, size=0, path_utf8=None, fullscan=False):
3014
2700
        """Update an entry to the state in tree 0.
3015
2701
 
3016
2702
        This will either create a new entry at 'key' or update an existing one.
3018
2704
        updated as well.
3019
2705
 
3020
2706
        :param key: (dir, name, file_id) for the new entry
3021
 
        :param minikind: The type for the entry (b'f' == 'file', b'd' ==
 
2707
        :param minikind: The type for the entry ('f' == 'file', 'd' ==
3022
2708
                'directory'), etc.
3023
2709
        :param executable: Should the executable bit be set?
3024
2710
        :param fingerprint: Simple fingerprint for new entry: canonical-form
3037
2723
        block = self._find_block(key)[1]
3038
2724
        if packed_stat is None:
3039
2725
            packed_stat = DirState.NULLSTAT
3040
 
        # XXX: Some callers pass b'' as the packed_stat, and it seems to be
 
2726
        # XXX: Some callers pass '' as the packed_stat, and it seems to be
3041
2727
        # sometimes present in the dirstate - this seems oddly inconsistent.
3042
2728
        # mbp 20071008
3043
2729
        entry_index, present = self._find_entry_index(key, block)
3046
2732
        if not present:
3047
2733
            # New record. Check there isn't a entry at this path already.
3048
2734
            if not fullscan:
3049
 
                low_index, _ = self._find_entry_index(key[0:2] + (b'',), block)
 
2735
                low_index, _ = self._find_entry_index(key[0:2] + ('',), block)
3050
2736
                while low_index < len(block):
3051
2737
                    entry = block[low_index]
3052
2738
                    if entry[0][0:2] == key[0:2]:
3053
 
                        if entry[1][0][0] not in (b'a', b'r'):
 
2739
                        if entry[1][0][0] not in 'ar':
3054
2740
                            # This entry has the same path (but a different id) as
3055
2741
                            # the new entry we're adding, and is present in ths
3056
2742
                            # tree.
3057
 
                            self._raise_invalid(
3058
 
                                (b"%s/%s" % key[0:2]).decode('utf8'), key[2],
 
2743
                            raise errors.InconsistentDelta(
 
2744
                                ("%s/%s" % key[0:2]).decode('utf8'), key[2],
3059
2745
                                "Attempt to add item at path already occupied by "
3060
2746
                                "id %r" % entry[0][2])
3061
2747
                        low_index += 1
3062
2748
                    else:
3063
2749
                        break
3064
2750
            # new entry, synthesis cross reference here,
3065
 
            existing_keys = id_index.get(key[2], ())
 
2751
            existing_keys = id_index.setdefault(key[2], set())
3066
2752
            if not existing_keys:
3067
2753
                # not currently in the state, simplest case
3068
2754
                new_entry = key, [new_details] + self._empty_parent_info()
3098
2784
                    # entry, if not already examined, is skipped over by that
3099
2785
                    # loop.
3100
2786
                    other_entry = other_block[other_entry_index]
3101
 
                    other_entry[1][0] = (b'r', path_utf8, 0, False, b'')
3102
 
                    if self._maybe_remove_row(other_block, other_entry_index,
3103
 
                                              id_index):
3104
 
                        # If the row holding this was removed, we need to
3105
 
                        # recompute where this entry goes
3106
 
                        entry_index, _ = self._find_entry_index(key, block)
 
2787
                    other_entry[1][0] = ('r', path_utf8, 0, False, '')
 
2788
                    self._maybe_remove_row(other_block, other_entry_index,
 
2789
                        id_index)
3107
2790
 
3108
2791
                # This loop:
3109
2792
                # adds a tuple to the new details for each column
3111
2794
                #  - or by creating a new pointer to the right row inside that column
3112
2795
                num_present_parents = self._num_present_parents()
3113
2796
                if num_present_parents:
3114
 
                    # TODO: This re-evaluates the existing_keys set, do we need
3115
 
                    #       to do that ourselves?
3116
2797
                    other_key = list(existing_keys)[0]
3117
 
                for lookup_index in range(1, num_present_parents + 1):
 
2798
                for lookup_index in xrange(1, num_present_parents + 1):
3118
2799
                    # grab any one entry, use it to find the right path.
3119
2800
                    # TODO: optimise this to reduce memory use in highly
3120
2801
                    # fragmented situations by reusing the relocation
3122
2803
                    update_block_index, present = \
3123
2804
                        self._find_block_index_from_key(other_key)
3124
2805
                    if not present:
3125
 
                        raise AssertionError(
3126
 
                            'could not find block for %s' % (other_key,))
 
2806
                        raise AssertionError('could not find block for %s' % (other_key,))
3127
2807
                    update_entry_index, present = \
3128
 
                        self._find_entry_index(
3129
 
                            other_key, self._dirblocks[update_block_index][1])
 
2808
                        self._find_entry_index(other_key, self._dirblocks[update_block_index][1])
3130
2809
                    if not present:
3131
 
                        raise AssertionError(
3132
 
                            'update_minimal: could not find entry for %s' % (other_key,))
 
2810
                        raise AssertionError('update_minimal: could not find entry for %s' % (other_key,))
3133
2811
                    update_details = self._dirblocks[update_block_index][1][update_entry_index][1][lookup_index]
3134
 
                    if update_details[0] in (b'a', b'r'):  # relocated, absent
 
2812
                    if update_details[0] in 'ar': # relocated, absent
3135
2813
                        # its a pointer or absent in lookup_index's tree, use
3136
2814
                        # it as is.
3137
2815
                        new_entry[1].append(update_details)
3138
2816
                    else:
3139
2817
                        # we have the right key, make a pointer to it.
3140
2818
                        pointer_path = osutils.pathjoin(*other_key[0:2])
3141
 
                        new_entry[1].append(
3142
 
                            (b'r', pointer_path, 0, False, b''))
 
2819
                        new_entry[1].append(('r', pointer_path, 0, False, ''))
3143
2820
            block.insert(entry_index, new_entry)
3144
 
            self._add_to_id_index(id_index, key)
 
2821
            existing_keys.add(key)
3145
2822
        else:
3146
2823
            # Does the new state matter?
3147
2824
            block[entry_index][1][0] = new_details
3156
2833
            # converted to relocated.
3157
2834
            if path_utf8 is None:
3158
2835
                raise AssertionError('no path')
3159
 
            existing_keys = id_index.get(key[2], ())
3160
 
            if key not in existing_keys:
3161
 
                raise AssertionError('We found the entry in the blocks, but'
3162
 
                                     ' the key is not in the id_index.'
3163
 
                                     ' key: %s, existing_keys: %s' % (key, existing_keys))
3164
 
            for entry_key in existing_keys:
 
2836
            for entry_key in id_index.setdefault(key[2], set()):
3165
2837
                # TODO:PROFILING: It might be faster to just update
3166
2838
                # rather than checking if we need to, and then overwrite
3167
2839
                # the one we are located at.
3170
2842
                    # other trees, so put absent pointers there
3171
2843
                    # This is the vertical axis in the matrix, all pointing
3172
2844
                    # to the real path.
3173
 
                    block_index, present = self._find_block_index_from_key(
3174
 
                        entry_key)
 
2845
                    block_index, present = self._find_block_index_from_key(entry_key)
3175
2846
                    if not present:
3176
2847
                        raise AssertionError('not present: %r', entry_key)
3177
 
                    entry_index, present = self._find_entry_index(
3178
 
                        entry_key, self._dirblocks[block_index][1])
 
2848
                    entry_index, present = self._find_entry_index(entry_key, self._dirblocks[block_index][1])
3179
2849
                    if not present:
3180
2850
                        raise AssertionError('not present: %r', entry_key)
3181
2851
                    self._dirblocks[block_index][1][entry_index][1][0] = \
3182
 
                        (b'r', path_utf8, 0, False, b'')
 
2852
                        ('r', path_utf8, 0, False, '')
3183
2853
        # add a containing dirblock if needed.
3184
 
        if new_details[0] == b'd':
3185
 
            # GZ 2017-06-09: Using pathjoin why?
3186
 
            subdir_key = (osutils.pathjoin(*key[0:2]), b'', b'')
 
2854
        if new_details[0] == 'd':
 
2855
            subdir_key = (osutils.pathjoin(*key[0:2]), '', '')
3187
2856
            block_index, present = self._find_block_index_from_key(subdir_key)
3188
2857
            if not present:
3189
2858
                self._dirblocks.insert(block_index, (subdir_key[0], []))
3190
2859
 
3191
 
        self._mark_modified()
 
2860
        self._dirblock_state = DirState.IN_MEMORY_MODIFIED
3192
2861
 
3193
2862
    def _maybe_remove_row(self, block, index, id_index):
3194
2863
        """Remove index if it is absent or relocated across the row.
3195
 
 
 
2864
        
3196
2865
        id_index is updated accordingly.
3197
 
        :return: True if we removed the row, False otherwise
3198
2866
        """
3199
2867
        present_in_row = False
3200
2868
        entry = block[index]
3201
2869
        for column in entry[1]:
3202
 
            if column[0] not in (b'a', b'r'):
 
2870
            if column[0] not in 'ar':
3203
2871
                present_in_row = True
3204
2872
                break
3205
2873
        if not present_in_row:
3206
2874
            block.pop(index)
3207
 
            self._remove_from_id_index(id_index, entry[0])
3208
 
            return True
3209
 
        return False
 
2875
            id_index[entry[0][2]].remove(entry[0])
3210
2876
 
3211
2877
    def _validate(self):
3212
2878
        """Check that invariants on the dirblock are correct.
3219
2885
        # NOTE: This must always raise AssertionError not just assert,
3220
2886
        # otherwise it may not behave properly under python -O
3221
2887
        #
3222
 
        # TODO: All entries must have some content that's not b'a' or b'r',
 
2888
        # TODO: All entries must have some content that's not 'a' or 'r',
3223
2889
        # otherwise it could just be removed.
3224
2890
        #
3225
2891
        # TODO: All relocations must point directly to a real entry.
3230
2896
        from pprint import pformat
3231
2897
        self._read_dirblocks_if_needed()
3232
2898
        if len(self._dirblocks) > 0:
3233
 
            if not self._dirblocks[0][0] == b'':
 
2899
            if not self._dirblocks[0][0] == '':
3234
2900
                raise AssertionError(
3235
 
                    "dirblocks don't start with root block:\n"
3236
 
                    + pformat(self._dirblocks))
 
2901
                    "dirblocks don't start with root block:\n" + \
 
2902
                    pformat(self._dirblocks))
3237
2903
        if len(self._dirblocks) > 1:
3238
 
            if not self._dirblocks[1][0] == b'':
 
2904
            if not self._dirblocks[1][0] == '':
3239
2905
                raise AssertionError(
3240
 
                    "dirblocks missing root directory:\n"
3241
 
                    + pformat(self._dirblocks))
 
2906
                    "dirblocks missing root directory:\n" + \
 
2907
                    pformat(self._dirblocks))
3242
2908
        # the dirblocks are sorted by their path components, name, and dir id
3243
 
        dir_names = [d[0].split(b'/')
3244
 
                     for d in self._dirblocks[1:]]
 
2909
        dir_names = [d[0].split('/')
 
2910
                for d in self._dirblocks[1:]]
3245
2911
        if dir_names != sorted(dir_names):
3246
2912
            raise AssertionError(
3247
 
                "dir names are not in sorted order:\n" +
3248
 
                pformat(self._dirblocks) +
 
2913
                "dir names are not in sorted order:\n" + \
 
2914
                pformat(self._dirblocks) + \
3249
2915
                "\nkeys:\n" +
3250
2916
                pformat(dir_names))
3251
2917
        for dirblock in self._dirblocks:
3259
2925
                        (entry, pformat(dirblock)))
3260
2926
            if dirblock[1] != sorted(dirblock[1]):
3261
2927
                raise AssertionError(
3262
 
                    "dirblock for %r is not sorted:\n%s" %
 
2928
                    "dirblock for %r is not sorted:\n%s" % \
3263
2929
                    (dirblock[0], pformat(dirblock)))
3264
2930
 
3265
2931
        def check_valid_parent():
3270
2936
            current tree. (It is invalid to have a non-absent file in an absent
3271
2937
            directory.)
3272
2938
            """
3273
 
            if entry[0][0:2] == (b'', b''):
 
2939
            if entry[0][0:2] == ('', ''):
3274
2940
                # There should be no parent for the root row
3275
2941
                return
3276
2942
            parent_entry = self._get_entry(tree_index, path_utf8=entry[0][0])
3278
2944
                raise AssertionError(
3279
2945
                    "no parent entry for: %s in tree %s"
3280
2946
                    % (this_path, tree_index))
3281
 
            if parent_entry[1][tree_index][0] != b'd':
 
2947
            if parent_entry[1][tree_index][0] != 'd':
3282
2948
                raise AssertionError(
3283
2949
                    "Parent entry for %s is not marked as a valid"
3284
2950
                    " directory. %s" % (this_path, parent_entry,))
3292
2958
        # We check this with a dict per tree pointing either to the present
3293
2959
        # name, or None if absent.
3294
2960
        tree_count = self._num_present_parents() + 1
3295
 
        id_path_maps = [{} for _ in range(tree_count)]
 
2961
        id_path_maps = [dict() for i in range(tree_count)]
3296
2962
        # Make sure that all renamed entries point to the correct location.
3297
2963
        for entry in self._iter_entries():
3298
2964
            file_id = entry[0][2]
3299
2965
            this_path = osutils.pathjoin(entry[0][0], entry[0][1])
3300
2966
            if len(entry[1]) != tree_count:
3301
2967
                raise AssertionError(
3302
 
                    "wrong number of entry details for row\n%s"
3303
 
                    ",\nexpected %d" %
3304
 
                    (pformat(entry), tree_count))
 
2968
                "wrong number of entry details for row\n%s" \
 
2969
                ",\nexpected %d" % \
 
2970
                (pformat(entry), tree_count))
3305
2971
            absent_positions = 0
3306
2972
            for tree_index, tree_state in enumerate(entry[1]):
3307
2973
                this_tree_map = id_path_maps[tree_index]
3308
2974
                minikind = tree_state[0]
3309
 
                if minikind in (b'a', b'r'):
 
2975
                if minikind in 'ar':
3310
2976
                    absent_positions += 1
3311
2977
                # have we seen this id before in this column?
3312
2978
                if file_id in this_tree_map:
3313
2979
                    previous_path, previous_loc = this_tree_map[file_id]
3314
2980
                    # any later mention of this file must be consistent with
3315
2981
                    # what was said before
3316
 
                    if minikind == b'a':
 
2982
                    if minikind == 'a':
3317
2983
                        if previous_path is not None:
3318
2984
                            raise AssertionError(
3319
 
                                "file %s is absent in row %r but also present "
3320
 
                                "at %r" %
3321
 
                                (file_id.decode('utf-8'), entry, previous_path))
3322
 
                    elif minikind == b'r':
 
2985
                            "file %s is absent in row %r but also present " \
 
2986
                            "at %r"% \
 
2987
                            (file_id, entry, previous_path))
 
2988
                    elif minikind == 'r':
3323
2989
                        target_location = tree_state[1]
3324
2990
                        if previous_path != target_location:
3325
2991
                            raise AssertionError(
3326
 
                                "file %s relocation in row %r but also at %r"
3327
 
                                % (file_id, entry, previous_path))
 
2992
                            "file %s relocation in row %r but also at %r" \
 
2993
                            % (file_id, entry, previous_path))
3328
2994
                    else:
3329
2995
                        # a file, directory, etc - may have been previously
3330
2996
                        # pointed to by a relocation, which must point here
3335
3001
                                (entry, previous_path, previous_loc))
3336
3002
                        check_valid_parent()
3337
3003
                else:
3338
 
                    if minikind == b'a':
 
3004
                    if minikind == 'a':
3339
3005
                        # absent; should not occur anywhere else
3340
3006
                        this_tree_map[file_id] = None, this_path
3341
 
                    elif minikind == b'r':
 
3007
                    elif minikind == 'r':
3342
3008
                        # relocation, must occur at expected location
3343
3009
                        this_tree_map[file_id] = tree_state[1], this_path
3344
3010
                    else:
3348
3014
                raise AssertionError(
3349
3015
                    "entry %r has no data for any tree." % (entry,))
3350
3016
        if self._id_index is not None:
3351
 
            for file_id, entry_keys in viewitems(self._id_index):
 
3017
            for file_id, entry_keys in self._id_index.iteritems():
3352
3018
                for entry_key in entry_keys:
3353
 
                    # Check that the entry in the map is pointing to the same
3354
 
                    # file_id
3355
3019
                    if entry_key[2] != file_id:
3356
3020
                        raise AssertionError(
3357
3021
                            'file_id %r did not match entry key %s'
3358
3022
                            % (file_id, entry_key))
3359
 
                    # And that from this entry key, we can look up the original
3360
 
                    # record
3361
 
                    block_index, present = self._find_block_index_from_key(
3362
 
                        entry_key)
3363
 
                    if not present:
3364
 
                        raise AssertionError(
3365
 
                            'missing block for entry key: %r', entry_key)
3366
 
                    entry_index, present = self._find_entry_index(
3367
 
                        entry_key, self._dirblocks[block_index][1])
3368
 
                    if not present:
3369
 
                        raise AssertionError(
3370
 
                            'missing entry for key: %r', entry_key)
3371
 
                if len(entry_keys) != len(set(entry_keys)):
3372
 
                    raise AssertionError(
3373
 
                        'id_index contained non-unique data for %s'
3374
 
                        % (entry_keys,))
3375
3023
 
3376
3024
    def _wipe_state(self):
3377
3025
        """Forget all state information about the dirstate."""
3399
3047
        self._lock_state = 'r'
3400
3048
        self._state_file = self._lock_token.f
3401
3049
        self._wipe_state()
3402
 
        return lock.LogicalLockResult(self.unlock)
3403
3050
 
3404
3051
    def lock_write(self):
3405
3052
        """Acquire a write lock on the dirstate."""
3413
3060
        self._lock_state = 'w'
3414
3061
        self._state_file = self._lock_token.f
3415
3062
        self._wipe_state()
3416
 
        return lock.LogicalLockResult(self.unlock, self._lock_token)
3417
3063
 
3418
3064
    def unlock(self):
3419
3065
        """Drop any locks held on the dirstate."""
3436
3082
 
3437
3083
 
3438
3084
def py_update_entry(state, entry, abspath, stat_value,
3439
 
                    _stat_to_minikind=DirState._stat_to_minikind):
 
3085
                 _stat_to_minikind=DirState._stat_to_minikind,
 
3086
                 _pack_stat=pack_stat):
3440
3087
    """Update the entry based on what is actually on disk.
3441
3088
 
3442
3089
    This function only calculates the sha if it needs to - if the entry is
3451
3098
        target of a symlink.
3452
3099
    """
3453
3100
    try:
3454
 
        minikind = _stat_to_minikind[stat_value.st_mode & 0o170000]
 
3101
        minikind = _stat_to_minikind[stat_value.st_mode & 0170000]
3455
3102
    except KeyError:
3456
3103
        # Unhandled kind
3457
3104
        return None
3458
 
    packed_stat = pack_stat(stat_value)
 
3105
    packed_stat = _pack_stat(stat_value)
3459
3106
    (saved_minikind, saved_link_or_sha1, saved_file_size,
3460
3107
     saved_executable, saved_packed_stat) = entry[1][0]
3461
 
    if not isinstance(saved_minikind, bytes):
3462
 
        raise TypeError(saved_minikind)
3463
3108
 
3464
 
    if minikind == b'd' and saved_minikind == b't':
3465
 
        minikind = b't'
 
3109
    if minikind == 'd' and saved_minikind == 't':
 
3110
        minikind = 't'
3466
3111
    if (minikind == saved_minikind
3467
 
            and packed_stat == saved_packed_stat):
 
3112
        and packed_stat == saved_packed_stat):
3468
3113
        # The stat hasn't changed since we saved, so we can re-use the
3469
3114
        # saved sha hash.
3470
 
        if minikind == b'd':
 
3115
        if minikind == 'd':
3471
3116
            return None
3472
3117
 
3473
3118
        # size should also be in packed_stat
3477
3122
    # If we have gotten this far, that means that we need to actually
3478
3123
    # process this entry.
3479
3124
    link_or_sha1 = None
3480
 
    worth_saving = True
3481
 
    if minikind == b'f':
 
3125
    if minikind == 'f':
3482
3126
        executable = state._is_executable(stat_value.st_mode,
3483
 
                                          saved_executable)
 
3127
                                         saved_executable)
3484
3128
        if state._cutoff_time is None:
3485
3129
            state._sha_cutoff_time()
3486
3130
        if (stat_value.st_mtime < state._cutoff_time
3487
3131
            and stat_value.st_ctime < state._cutoff_time
3488
3132
            and len(entry[1]) > 1
3489
 
                and entry[1][1][0] != b'a'):
 
3133
            and entry[1][1][0] != 'a'):
3490
3134
            # Could check for size changes for further optimised
3491
3135
            # avoidance of sha1's. However the most prominent case of
3492
3136
            # over-shaing is during initial add, which this catches.
3494
3138
            # are calculated at the same time, so checking just the size
3495
3139
            # gains nothing w.r.t. performance.
3496
3140
            link_or_sha1 = state._sha1_file(abspath)
3497
 
            entry[1][0] = (b'f', link_or_sha1, stat_value.st_size,
 
3141
            entry[1][0] = ('f', link_or_sha1, stat_value.st_size,
3498
3142
                           executable, packed_stat)
3499
3143
        else:
3500
 
            entry[1][0] = (b'f', b'', stat_value.st_size,
 
3144
            entry[1][0] = ('f', '', stat_value.st_size,
3501
3145
                           executable, DirState.NULLSTAT)
3502
 
            worth_saving = False
3503
 
    elif minikind == b'd':
 
3146
    elif minikind == 'd':
3504
3147
        link_or_sha1 = None
3505
 
        entry[1][0] = (b'd', b'', 0, False, packed_stat)
3506
 
        if saved_minikind != b'd':
 
3148
        entry[1][0] = ('d', '', 0, False, packed_stat)
 
3149
        if saved_minikind != 'd':
3507
3150
            # This changed from something into a directory. Make sure we
3508
3151
            # have a directory block for it. This doesn't happen very
3509
3152
            # often, so this doesn't have to be super fast.
3510
3153
            block_index, entry_index, dir_present, file_present = \
3511
3154
                state._get_block_entry_index(entry[0][0], entry[0][1], 0)
3512
3155
            state._ensure_block(block_index, entry_index,
3513
 
                                osutils.pathjoin(entry[0][0], entry[0][1]))
3514
 
        else:
3515
 
            worth_saving = False
3516
 
    elif minikind == b'l':
3517
 
        if saved_minikind == b'l':
3518
 
            worth_saving = False
 
3156
                               osutils.pathjoin(entry[0][0], entry[0][1]))
 
3157
    elif minikind == 'l':
3519
3158
        link_or_sha1 = state._read_link(abspath, saved_link_or_sha1)
3520
3159
        if state._cutoff_time is None:
3521
3160
            state._sha_cutoff_time()
3522
3161
        if (stat_value.st_mtime < state._cutoff_time
3523
 
                and stat_value.st_ctime < state._cutoff_time):
3524
 
            entry[1][0] = (b'l', link_or_sha1, stat_value.st_size,
 
3162
            and stat_value.st_ctime < state._cutoff_time):
 
3163
            entry[1][0] = ('l', link_or_sha1, stat_value.st_size,
3525
3164
                           False, packed_stat)
3526
3165
        else:
3527
 
            entry[1][0] = (b'l', b'', stat_value.st_size,
 
3166
            entry[1][0] = ('l', '', stat_value.st_size,
3528
3167
                           False, DirState.NULLSTAT)
3529
 
    if worth_saving:
3530
 
        state._mark_modified([entry])
 
3168
    state._dirblock_state = DirState.IN_MEMORY_MODIFIED
3531
3169
    return link_or_sha1
3532
3170
 
3533
3171
 
3534
3172
class ProcessEntryPython(object):
3535
3173
 
3536
3174
    __slots__ = ["old_dirname_to_file_id", "new_dirname_to_file_id",
3537
 
                 "last_source_parent", "last_target_parent", "include_unchanged",
3538
 
                 "partial", "use_filesystem_for_exec", "utf8_decode",
3539
 
                 "searched_specific_files", "search_specific_files",
3540
 
                 "searched_exact_paths", "search_specific_file_parents", "seen_ids",
3541
 
                 "state", "source_index", "target_index", "want_unversioned", "tree"]
 
3175
        "last_source_parent", "last_target_parent", "include_unchanged",
 
3176
        "partial", "use_filesystem_for_exec", "utf8_decode",
 
3177
        "searched_specific_files", "search_specific_files",
 
3178
        "searched_exact_paths", "search_specific_file_parents", "seen_ids",
 
3179
        "state", "source_index", "target_index", "want_unversioned", "tree"]
3542
3180
 
3543
3181
    def __init__(self, include_unchanged, use_filesystem_for_exec,
3544
 
                 search_specific_files, state, source_index, target_index,
3545
 
                 want_unversioned, tree):
 
3182
        search_specific_files, state, source_index, target_index,
 
3183
        want_unversioned, tree):
3546
3184
        self.old_dirname_to_file_id = {}
3547
3185
        self.new_dirname_to_file_id = {}
3548
3186
        # Are we doing a partial iter_changes?
3549
 
        self.partial = search_specific_files != {''}
 
3187
        self.partial = search_specific_files != set([''])
3550
3188
        # Using a list so that we can access the values and change them in
3551
3189
        # nested scope. Each one is [path, file_id, entry]
3552
3190
        self.last_source_parent = [None, None]
3581
3219
        """Compare an entry and real disk to generate delta information.
3582
3220
 
3583
3221
        :param path_info: top_relpath, basename, kind, lstat, abspath for
3584
 
            the path of entry. If None, then the path is considered absent in
 
3222
            the path of entry. If None, then the path is considered absent in 
3585
3223
            the target (Perhaps we should pass in a concrete entry for this ?)
3586
3224
            Basename is returned as a utf8 string because we expect this
3587
3225
            tuple will be ignored, and don't want to take the time to
3598
3236
            source_details = DirState.NULL_PARENT_DETAILS
3599
3237
        else:
3600
3238
            source_details = entry[1][self.source_index]
3601
 
        # GZ 2017-06-09: Eck, more sets.
3602
 
        _fdltr = {b'f', b'd', b'l', b't', b'r'}
3603
 
        _fdlt = {b'f', b'd', b'l', b't'}
3604
 
        _ra = (b'r', b'a')
3605
3239
        target_details = entry[1][self.target_index]
3606
3240
        target_minikind = target_details[0]
3607
 
        if path_info is not None and target_minikind in _fdlt:
 
3241
        if path_info is not None and target_minikind in 'fdlt':
3608
3242
            if not (self.target_index == 0):
3609
3243
                raise AssertionError()
3610
3244
            link_or_sha1 = update_entry(self.state, entry,
3611
 
                                        abspath=path_info[4], stat_value=path_info[3])
 
3245
                abspath=path_info[4], stat_value=path_info[3])
3612
3246
            # The entry may have been modified by update_entry
3613
3247
            target_details = entry[1][self.target_index]
3614
3248
            target_minikind = target_details[0]
3616
3250
            link_or_sha1 = None
3617
3251
        file_id = entry[0][2]
3618
3252
        source_minikind = source_details[0]
3619
 
        if source_minikind in _fdltr and target_minikind in _fdlt:
 
3253
        if source_minikind in 'fdltr' and target_minikind in 'fdlt':
3620
3254
            # claimed content in both: diff
3621
3255
            #   r    | fdlt   |      | add source to search, add id path move and perform
3622
3256
            #        |        |      | diff check on source-target
3623
3257
            #   r    | fdlt   |  a   | dangling file that was present in the basis.
3624
3258
            #        |        |      | ???
3625
 
            if source_minikind == b'r':
 
3259
            if source_minikind in 'r':
3626
3260
                # add the source to the search path to find any children it
3627
3261
                # has.  TODO ? : only add if it is a container ?
3628
3262
                if not osutils.is_inside_any(self.searched_specific_files,
3634
3268
                old_dirname, old_basename = os.path.split(old_path)
3635
3269
                path = pathjoin(entry[0][0], entry[0][1])
3636
3270
                old_entry = self.state._get_entry(self.source_index,
3637
 
                                                  path_utf8=old_path)
 
3271
                                             path_utf8=old_path)
3638
3272
                # update the source details variable to be the real
3639
3273
                # location.
3640
3274
                if old_entry == (None, None):
3641
 
                    raise DirstateCorrupt(self.state._filename,
3642
 
                                          "entry '%s/%s' is considered renamed from %r"
3643
 
                                          " but source does not exist\n"
3644
 
                                          "entry: %s" % (entry[0][0], entry[0][1], old_path, entry))
 
3275
                    raise errors.CorruptDirstate(self.state._filename,
 
3276
                        "entry '%s/%s' is considered renamed from %r"
 
3277
                        " but source does not exist\n"
 
3278
                        "entry: %s" % (entry[0][0], entry[0][1], old_path, entry))
3645
3279
                source_details = old_entry[1][self.source_index]
3646
3280
                source_minikind = source_details[0]
3647
3281
            else:
3660
3294
                    if path is None:
3661
3295
                        old_path = path = pathjoin(old_dirname, old_basename)
3662
3296
                    self.new_dirname_to_file_id[path] = file_id
3663
 
                    if source_minikind != b'd':
 
3297
                    if source_minikind != 'd':
3664
3298
                        content_change = True
3665
3299
                    else:
3666
3300
                        # directories have no fingerprint
3667
3301
                        content_change = False
3668
3302
                    target_exec = False
3669
3303
                elif target_kind == 'file':
3670
 
                    if source_minikind != b'f':
 
3304
                    if source_minikind != 'f':
3671
3305
                        content_change = True
3672
3306
                    else:
3673
3307
                        # Check the sha. We can't just rely on the size as
3677
3311
                            # Stat cache miss:
3678
3312
                            statvalue, link_or_sha1 = \
3679
3313
                                self.state._sha1_provider.stat_and_sha1(
3680
 
                                    path_info[4])
 
3314
                                path_info[4])
3681
3315
                            self.state._observed_sha1(entry, link_or_sha1,
3682
 
                                                      statvalue)
 
3316
                                statvalue)
3683
3317
                        content_change = (link_or_sha1 != source_details[1])
3684
3318
                    # Target details is updated at update_entry time
3685
3319
                    if self.use_filesystem_for_exec:
3689
3323
                    else:
3690
3324
                        target_exec = target_details[3]
3691
3325
                elif target_kind == 'symlink':
3692
 
                    if source_minikind != b'l':
 
3326
                    if source_minikind != 'l':
3693
3327
                        content_change = True
3694
3328
                    else:
3695
3329
                        content_change = (link_or_sha1 != source_details[1])
3696
3330
                    target_exec = False
3697
3331
                elif target_kind == 'tree-reference':
3698
 
                    if source_minikind != b't':
 
3332
                    if source_minikind != 't':
3699
3333
                        content_change = True
3700
3334
                    else:
3701
3335
                        content_change = False
3704
3338
                    if path is None:
3705
3339
                        path = pathjoin(old_dirname, old_basename)
3706
3340
                    raise errors.BadFileKindError(path, path_info[2])
3707
 
            if source_minikind == b'd':
 
3341
            if source_minikind == 'd':
3708
3342
                if path is None:
3709
3343
                    old_path = path = pathjoin(old_dirname, old_basename)
3710
3344
                self.old_dirname_to_file_id[old_path] = file_id
3716
3350
                    source_parent_id = self.old_dirname_to_file_id[old_dirname]
3717
3351
                except KeyError:
3718
3352
                    source_parent_entry = self.state._get_entry(self.source_index,
3719
 
                                                                path_utf8=old_dirname)
 
3353
                                                           path_utf8=old_dirname)
3720
3354
                    source_parent_id = source_parent_entry[0][2]
3721
3355
                if source_parent_id == entry[0][2]:
3722
3356
                    # This is the root, so the parent is None
3734
3368
                    # TODO: We don't always need to do the lookup, because the
3735
3369
                    #       parent entry will be the same as the source entry.
3736
3370
                    target_parent_entry = self.state._get_entry(self.target_index,
3737
 
                                                                path_utf8=new_dirname)
 
3371
                                                           path_utf8=new_dirname)
3738
3372
                    if target_parent_entry == (None, None):
3739
3373
                        raise AssertionError(
3740
3374
                            "Could not find target parent in wt: %s\nparent of: %s"
3749
3383
 
3750
3384
            source_exec = source_details[3]
3751
3385
            changed = (content_change
3752
 
                       or source_parent_id != target_parent_id
3753
 
                       or old_basename != entry[0][1]
3754
 
                       or source_exec != target_exec
3755
 
                       )
 
3386
                or source_parent_id != target_parent_id
 
3387
                or old_basename != entry[0][1]
 
3388
                or source_exec != target_exec
 
3389
                )
3756
3390
            if not changed and not self.include_unchanged:
3757
3391
                return None, False
3758
3392
            else:
3767
3401
                    else:
3768
3402
                        path_u = self.utf8_decode(path)[0]
3769
3403
                source_kind = DirState._minikind_to_kind[source_minikind]
3770
 
                return TreeChange(
3771
 
                    entry[0][2],
3772
 
                    (old_path_u, path_u),
3773
 
                    content_change,
3774
 
                    (True, True),
3775
 
                    (source_parent_id, target_parent_id),
3776
 
                    (self.utf8_decode(old_basename)[
3777
 
                     0], self.utf8_decode(entry[0][1])[0]),
3778
 
                    (source_kind, target_kind),
3779
 
                    (source_exec, target_exec)), changed
3780
 
        elif source_minikind in b'a' and target_minikind in _fdlt:
 
3404
                return (entry[0][2],
 
3405
                       (old_path_u, path_u),
 
3406
                       content_change,
 
3407
                       (True, True),
 
3408
                       (source_parent_id, target_parent_id),
 
3409
                       (self.utf8_decode(old_basename)[0], self.utf8_decode(entry[0][1])[0]),
 
3410
                       (source_kind, target_kind),
 
3411
                       (source_exec, target_exec)), changed
 
3412
        elif source_minikind in 'a' and target_minikind in 'fdlt':
3781
3413
            # looks like a new file
3782
3414
            path = pathjoin(entry[0][0], entry[0][1])
3783
3415
            # parent id is the entry for the path in the target tree
3784
3416
            # TODO: these are the same for an entire directory: cache em.
3785
3417
            parent_id = self.state._get_entry(self.target_index,
3786
 
                                              path_utf8=entry[0][0])[0][2]
 
3418
                                         path_utf8=entry[0][0])[0][2]
3787
3419
            if parent_id == entry[0][2]:
3788
3420
                parent_id = None
3789
3421
            if path_info is not None:
3796
3428
                        and stat.S_IEXEC & path_info[3].st_mode)
3797
3429
                else:
3798
3430
                    target_exec = target_details[3]
3799
 
                return TreeChange(
3800
 
                    entry[0][2],
3801
 
                    (None, self.utf8_decode(path)[0]),
3802
 
                    True,
3803
 
                    (False, True),
3804
 
                    (None, parent_id),
3805
 
                    (None, self.utf8_decode(entry[0][1])[0]),
3806
 
                    (None, path_info[2]),
3807
 
                    (None, target_exec)), True
 
3431
                return (entry[0][2],
 
3432
                       (None, self.utf8_decode(path)[0]),
 
3433
                       True,
 
3434
                       (False, True),
 
3435
                       (None, parent_id),
 
3436
                       (None, self.utf8_decode(entry[0][1])[0]),
 
3437
                       (None, path_info[2]),
 
3438
                       (None, target_exec)), True
3808
3439
            else:
3809
3440
                # Its a missing file, report it as such.
3810
 
                return TreeChange(
3811
 
                    entry[0][2],
3812
 
                    (None, self.utf8_decode(path)[0]),
3813
 
                    False,
3814
 
                    (False, True),
3815
 
                    (None, parent_id),
3816
 
                    (None, self.utf8_decode(entry[0][1])[0]),
3817
 
                    (None, None),
3818
 
                    (None, False)), True
3819
 
        elif source_minikind in _fdlt and target_minikind in b'a':
 
3441
                return (entry[0][2],
 
3442
                       (None, self.utf8_decode(path)[0]),
 
3443
                       False,
 
3444
                       (False, True),
 
3445
                       (None, parent_id),
 
3446
                       (None, self.utf8_decode(entry[0][1])[0]),
 
3447
                       (None, None),
 
3448
                       (None, False)), True
 
3449
        elif source_minikind in 'fdlt' and target_minikind in 'a':
3820
3450
            # unversioned, possibly, or possibly not deleted: we dont care.
3821
3451
            # if its still on disk, *and* theres no other entry at this
3822
3452
            # path [we dont know this in this routine at the moment -
3823
3453
            # perhaps we should change this - then it would be an unknown.
3824
3454
            old_path = pathjoin(entry[0][0], entry[0][1])
3825
3455
            # parent id is the entry for the path in the target tree
3826
 
            parent_id = self.state._get_entry(
3827
 
                self.source_index, path_utf8=entry[0][0])[0][2]
 
3456
            parent_id = self.state._get_entry(self.source_index, path_utf8=entry[0][0])[0][2]
3828
3457
            if parent_id == entry[0][2]:
3829
3458
                parent_id = None
3830
 
            return TreeChange(
3831
 
                entry[0][2],
3832
 
                (self.utf8_decode(old_path)[0], None),
3833
 
                True,
3834
 
                (True, False),
3835
 
                (parent_id, None),
3836
 
                (self.utf8_decode(entry[0][1])[0], None),
3837
 
                (DirState._minikind_to_kind[source_minikind], None),
3838
 
                (source_details[3], None)), True
3839
 
        elif source_minikind in _fdlt and target_minikind in b'r':
 
3459
            return (entry[0][2],
 
3460
                   (self.utf8_decode(old_path)[0], None),
 
3461
                   True,
 
3462
                   (True, False),
 
3463
                   (parent_id, None),
 
3464
                   (self.utf8_decode(entry[0][1])[0], None),
 
3465
                   (DirState._minikind_to_kind[source_minikind], None),
 
3466
                   (source_details[3], None)), True
 
3467
        elif source_minikind in 'fdlt' and target_minikind in 'r':
3840
3468
            # a rename; could be a true rename, or a rename inherited from
3841
3469
            # a renamed parent. TODO: handle this efficiently. Its not
3842
3470
            # common case to rename dirs though, so a correct but slow
3843
3471
            # implementation will do.
3844
 
            if not osutils.is_inside_any(self.searched_specific_files,
3845
 
                                         target_details[1]):
 
3472
            if not osutils.is_inside_any(self.searched_specific_files, target_details[1]):
3846
3473
                self.search_specific_files.add(target_details[1])
3847
 
        elif source_minikind in _ra and target_minikind in _ra:
 
3474
        elif source_minikind in 'ra' and target_minikind in 'ra':
3848
3475
            # neither of the selected trees contain this file,
3849
3476
            # so skip over it. This is not currently directly tested, but
3850
3477
            # is indirectly via test_too_much.TestCommands.test_conflicts.
3851
3478
            pass
3852
3479
        else:
3853
3480
            raise AssertionError("don't know how to compare "
3854
 
                                 "source_minikind=%r, target_minikind=%r"
3855
 
                                 % (source_minikind, target_minikind))
 
3481
                "source_minikind=%r, target_minikind=%r"
 
3482
                % (source_minikind, target_minikind))
 
3483
            ## import pdb;pdb.set_trace()
3856
3484
        return None, None
3857
3485
 
3858
3486
    def __iter__(self):
3860
3488
 
3861
3489
    def _gather_result_for_consistency(self, result):
3862
3490
        """Check a result we will yield to make sure we are consistent later.
3863
 
 
 
3491
        
3864
3492
        This gathers result's parents into a set to output later.
3865
3493
 
3866
3494
        :param result: A result tuple.
3867
3495
        """
3868
 
        if not self.partial or not result.file_id:
 
3496
        if not self.partial or not result[0]:
3869
3497
            return
3870
 
        self.seen_ids.add(result.file_id)
3871
 
        new_path = result.path[1]
 
3498
        self.seen_ids.add(result[0])
 
3499
        new_path = result[1][1]
3872
3500
        if new_path:
3873
3501
            # Not the root and not a delete: queue up the parents of the path.
3874
3502
            self.search_specific_file_parents.update(
3875
 
                p.encode('utf8') for p in osutils.parent_directories(new_path))
 
3503
                osutils.parent_directories(new_path.encode('utf8')))
3876
3504
            # Add the root directory which parent_directories does not
3877
3505
            # provide.
3878
 
            self.search_specific_file_parents.add(b'')
 
3506
            self.search_specific_file_parents.add('')
3879
3507
 
3880
3508
    def iter_changes(self):
3881
3509
        """Iterate over the changes."""
3882
3510
        utf8_decode = cache_utf8._utf8_decode
3883
 
        _lt_by_dirs = lt_by_dirs
 
3511
        _cmp_by_dirs = cmp_by_dirs
3884
3512
        _process_entry = self._process_entry
3885
3513
        search_specific_files = self.search_specific_files
3886
3514
        searched_specific_files = self.searched_specific_files
3935
3563
            root_abspath = self.tree.abspath(current_root_unicode)
3936
3564
            try:
3937
3565
                root_stat = os.lstat(root_abspath)
3938
 
            except OSError as e:
 
3566
            except OSError, e:
3939
3567
                if e.errno == errno.ENOENT:
3940
3568
                    # the path does not exist: let _process_entry know that.
3941
3569
                    root_dir_info = None
3943
3571
                    # some other random error: hand it up.
3944
3572
                    raise
3945
3573
            else:
3946
 
                root_dir_info = (b'', current_root,
3947
 
                                 osutils.file_kind_from_stat_mode(
3948
 
                                     root_stat.st_mode), root_stat,
3949
 
                                 root_abspath)
 
3574
                root_dir_info = ('', current_root,
 
3575
                    osutils.file_kind_from_stat_mode(root_stat.st_mode), root_stat,
 
3576
                    root_abspath)
3950
3577
                if root_dir_info[2] == 'directory':
3951
3578
                    if self.tree._directory_is_tree_reference(
3952
 
                            current_root.decode('utf8')):
 
3579
                        current_root.decode('utf8')):
3953
3580
                        root_dir_info = root_dir_info[:2] + \
3954
3581
                            ('tree-reference',) + root_dir_info[3:]
3955
3582
 
3969
3596
                new_executable = bool(
3970
3597
                    stat.S_ISREG(root_dir_info[3].st_mode)
3971
3598
                    and stat.S_IEXEC & root_dir_info[3].st_mode)
3972
 
                yield TreeChange(
3973
 
                    None,
3974
 
                    (None, current_root_unicode),
3975
 
                    True,
3976
 
                    (False, False),
3977
 
                    (None, None),
3978
 
                    (None, splitpath(current_root_unicode)[-1]),
3979
 
                    (None, root_dir_info[2]),
3980
 
                    (None, new_executable)
3981
 
                    )
3982
 
            initial_key = (current_root, b'', b'')
 
3599
                yield (None,
 
3600
                       (None, current_root_unicode),
 
3601
                       True,
 
3602
                       (False, False),
 
3603
                       (None, None),
 
3604
                       (None, splitpath(current_root_unicode)[-1]),
 
3605
                       (None, root_dir_info[2]),
 
3606
                       (None, new_executable)
 
3607
                      )
 
3608
            initial_key = (current_root, '', '')
3983
3609
            block_index, _ = self.state._find_block_index_from_key(initial_key)
3984
3610
            if block_index == 0:
3985
3611
                # we have processed the total root already, but because the
3986
3612
                # initial key matched it we should skip it here.
3987
 
                block_index += 1
 
3613
                block_index +=1
3988
3614
            if root_dir_info and root_dir_info[2] == 'tree-reference':
3989
3615
                current_dir_info = None
3990
3616
            else:
3991
 
                dir_iterator = osutils._walkdirs_utf8(
3992
 
                    root_abspath, prefix=current_root)
 
3617
                dir_iterator = osutils._walkdirs_utf8(root_abspath, prefix=current_root)
3993
3618
                try:
3994
 
                    current_dir_info = next(dir_iterator)
3995
 
                except OSError as e:
 
3619
                    current_dir_info = dir_iterator.next()
 
3620
                except OSError, e:
3996
3621
                    # on win32, python2.4 has e.errno == ERROR_DIRECTORY, but
3997
3622
                    # python 2.5 has e.errno == EINVAL,
3998
3623
                    #            and e.winerror == ERROR_DIRECTORY
4004
3629
                    if e.errno in (errno.ENOENT, errno.ENOTDIR, errno.EINVAL):
4005
3630
                        current_dir_info = None
4006
3631
                    elif (sys.platform == 'win32'
4007
 
                          and (e.errno in win_errors or
4008
 
                               e_winerror in win_errors)):
 
3632
                          and (e.errno in win_errors
 
3633
                               or e_winerror in win_errors)):
4009
3634
                        current_dir_info = None
4010
3635
                    else:
4011
3636
                        raise
4012
3637
                else:
4013
 
                    if current_dir_info[0][0] == b'':
 
3638
                    if current_dir_info[0][0] == '':
4014
3639
                        # remove .bzr from iteration
4015
 
                        bzr_index = bisect.bisect_left(
4016
 
                            current_dir_info[1], (b'.bzr',))
4017
 
                        if current_dir_info[1][bzr_index][0] != b'.bzr':
 
3640
                        bzr_index = bisect.bisect_left(current_dir_info[1], ('.bzr',))
 
3641
                        if current_dir_info[1][bzr_index][0] != '.bzr':
4018
3642
                            raise AssertionError()
4019
3643
                        del current_dir_info[1][bzr_index]
4020
3644
            # walk until both the directory listing and the versioned metadata
4021
3645
            # are exhausted.
4022
3646
            if (block_index < len(self.state._dirblocks) and
4023
 
                osutils.is_inside(current_root,
4024
 
                                  self.state._dirblocks[block_index][0])):
 
3647
                osutils.is_inside(current_root, self.state._dirblocks[block_index][0])):
4025
3648
                current_block = self.state._dirblocks[block_index]
4026
3649
            else:
4027
3650
                current_block = None
4028
3651
            while (current_dir_info is not None or
4029
3652
                   current_block is not None):
4030
3653
                if (current_dir_info and current_block
4031
 
                        and current_dir_info[0][0] != current_block[0]):
4032
 
                    if _lt_by_dirs(current_dir_info[0][0], current_block[0]):
 
3654
                    and current_dir_info[0][0] != current_block[0]):
 
3655
                    if _cmp_by_dirs(current_dir_info[0][0], current_block[0]) < 0:
4033
3656
                        # filesystem data refers to paths not covered by the dirblock.
4034
3657
                        # this has two possibilities:
4035
3658
                        # A) it is versioned but empty, so there is no block for it
4041
3664
                        # recurse into unknown directories.
4042
3665
                        path_index = 0
4043
3666
                        while path_index < len(current_dir_info[1]):
4044
 
                            current_path_info = current_dir_info[1][path_index]
4045
 
                            if self.want_unversioned:
4046
 
                                if current_path_info[2] == 'directory':
4047
 
                                    if self.tree._directory_is_tree_reference(
 
3667
                                current_path_info = current_dir_info[1][path_index]
 
3668
                                if self.want_unversioned:
 
3669
                                    if current_path_info[2] == 'directory':
 
3670
                                        if self.tree._directory_is_tree_reference(
4048
3671
                                            current_path_info[0].decode('utf8')):
4049
 
                                        current_path_info = current_path_info[:2] + \
4050
 
                                            ('tree-reference',) + \
4051
 
                                            current_path_info[3:]
4052
 
                                new_executable = bool(
4053
 
                                    stat.S_ISREG(current_path_info[3].st_mode)
4054
 
                                    and stat.S_IEXEC & current_path_info[3].st_mode)
4055
 
                                yield TreeChange(
4056
 
                                    None,
4057
 
                                    (None, utf8_decode(current_path_info[0])[0]),
4058
 
                                    True,
4059
 
                                    (False, False),
4060
 
                                    (None, None),
4061
 
                                    (None, utf8_decode(current_path_info[1])[0]),
4062
 
                                    (None, current_path_info[2]),
4063
 
                                    (None, new_executable))
4064
 
                            # dont descend into this unversioned path if it is
4065
 
                            # a dir
4066
 
                            if current_path_info[2] in ('directory',
4067
 
                                                        'tree-reference'):
4068
 
                                del current_dir_info[1][path_index]
4069
 
                                path_index -= 1
4070
 
                            path_index += 1
 
3672
                                            current_path_info = current_path_info[:2] + \
 
3673
                                                ('tree-reference',) + current_path_info[3:]
 
3674
                                    new_executable = bool(
 
3675
                                        stat.S_ISREG(current_path_info[3].st_mode)
 
3676
                                        and stat.S_IEXEC & current_path_info[3].st_mode)
 
3677
                                    yield (None,
 
3678
                                        (None, utf8_decode(current_path_info[0])[0]),
 
3679
                                        True,
 
3680
                                        (False, False),
 
3681
                                        (None, None),
 
3682
                                        (None, utf8_decode(current_path_info[1])[0]),
 
3683
                                        (None, current_path_info[2]),
 
3684
                                        (None, new_executable))
 
3685
                                # dont descend into this unversioned path if it is
 
3686
                                # a dir
 
3687
                                if current_path_info[2] in ('directory',
 
3688
                                                            'tree-reference'):
 
3689
                                    del current_dir_info[1][path_index]
 
3690
                                    path_index -= 1
 
3691
                                path_index += 1
4071
3692
 
4072
3693
                        # This dir info has been handled, go to the next
4073
3694
                        try:
4074
 
                            current_dir_info = next(dir_iterator)
 
3695
                            current_dir_info = dir_iterator.next()
4075
3696
                        except StopIteration:
4076
3697
                            current_dir_info = None
4077
3698
                    else:
4085
3706
                        for current_entry in current_block[1]:
4086
3707
                            # entry referring to file not present on disk.
4087
3708
                            # advance the entry only, after processing.
4088
 
                            result, changed = _process_entry(
4089
 
                                current_entry, None)
 
3709
                            result, changed = _process_entry(current_entry, None)
4090
3710
                            if changed is not None:
4091
3711
                                if changed:
4092
3712
                                    self._gather_result_for_consistency(result)
4093
3713
                                if changed or self.include_unchanged:
4094
3714
                                    yield result
4095
 
                        block_index += 1
 
3715
                        block_index +=1
4096
3716
                        if (block_index < len(self.state._dirblocks) and
4097
3717
                            osutils.is_inside(current_root,
4098
3718
                                              self.state._dirblocks[block_index][0])):
4111
3731
                    current_path_info = current_dir_info[1][path_index]
4112
3732
                    if current_path_info[2] == 'directory':
4113
3733
                        if self.tree._directory_is_tree_reference(
4114
 
                                current_path_info[0].decode('utf8')):
 
3734
                            current_path_info[0].decode('utf8')):
4115
3735
                            current_path_info = current_path_info[:2] + \
4116
3736
                                ('tree-reference',) + current_path_info[3:]
4117
3737
                else:
4119
3739
                advance_path = True
4120
3740
                path_handled = False
4121
3741
                while (current_entry is not None or
4122
 
                       current_path_info is not None):
 
3742
                    current_path_info is not None):
4123
3743
                    if current_entry is None:
4124
3744
                        # the check for path_handled when the path is advanced
4125
3745
                        # will yield this path if needed.
4126
3746
                        pass
4127
3747
                    elif current_path_info is None:
4128
3748
                        # no path is fine: the per entry code will handle it.
4129
 
                        result, changed = _process_entry(
4130
 
                            current_entry, current_path_info)
 
3749
                        result, changed = _process_entry(current_entry, current_path_info)
4131
3750
                        if changed is not None:
4132
3751
                            if changed:
4133
3752
                                self._gather_result_for_consistency(result)
4134
3753
                            if changed or self.include_unchanged:
4135
3754
                                yield result
4136
3755
                    elif (current_entry[0][1] != current_path_info[1]
4137
 
                          or current_entry[1][self.target_index][0] in (b'a', b'r')):
 
3756
                          or current_entry[1][self.target_index][0] in 'ar'):
4138
3757
                        # The current path on disk doesn't match the dirblock
4139
3758
                        # record. Either the dirblock is marked as absent, or
4140
3759
                        # the file on disk is not present at all in the
4150
3769
                        else:
4151
3770
                            # entry referring to file not present on disk.
4152
3771
                            # advance the entry only, after processing.
4153
 
                            result, changed = _process_entry(
4154
 
                                current_entry, None)
 
3772
                            result, changed = _process_entry(current_entry, None)
4155
3773
                            if changed is not None:
4156
3774
                                if changed:
4157
3775
                                    self._gather_result_for_consistency(result)
4159
3777
                                    yield result
4160
3778
                            advance_path = False
4161
3779
                    else:
4162
 
                        result, changed = _process_entry(
4163
 
                            current_entry, current_path_info)
 
3780
                        result, changed = _process_entry(current_entry, current_path_info)
4164
3781
                        if changed is not None:
4165
3782
                            path_handled = True
4166
3783
                            if changed:
4174
3791
                        else:
4175
3792
                            current_entry = None
4176
3793
                    else:
4177
 
                        advance_entry = True  # reset the advance flaga
 
3794
                        advance_entry = True # reset the advance flaga
4178
3795
                    if advance_path and current_path_info is not None:
4179
3796
                        if not path_handled:
4180
3797
                            # unversioned in all regards
4183
3800
                                    stat.S_ISREG(current_path_info[3].st_mode)
4184
3801
                                    and stat.S_IEXEC & current_path_info[3].st_mode)
4185
3802
                                try:
4186
 
                                    relpath_unicode = utf8_decode(
4187
 
                                        current_path_info[0])[0]
 
3803
                                    relpath_unicode = utf8_decode(current_path_info[0])[0]
4188
3804
                                except UnicodeDecodeError:
4189
3805
                                    raise errors.BadFilenameEncoding(
4190
3806
                                        current_path_info[0], osutils._fs_enc)
4191
 
                                yield TreeChange(
4192
 
                                    None,
 
3807
                                yield (None,
4193
3808
                                    (None, relpath_unicode),
4194
3809
                                    True,
4195
3810
                                    (False, False),
4212
3827
                            current_path_info = current_dir_info[1][path_index]
4213
3828
                            if current_path_info[2] == 'directory':
4214
3829
                                if self.tree._directory_is_tree_reference(
4215
 
                                        current_path_info[0].decode('utf8')):
 
3830
                                    current_path_info[0].decode('utf8')):
4216
3831
                                    current_path_info = current_path_info[:2] + \
4217
 
                                        ('tree-reference',) + \
4218
 
                                        current_path_info[3:]
 
3832
                                        ('tree-reference',) + current_path_info[3:]
4219
3833
                        else:
4220
3834
                            current_path_info = None
4221
3835
                        path_handled = False
4222
3836
                    else:
4223
 
                        advance_path = True  # reset the advance flagg.
 
3837
                        advance_path = True # reset the advance flagg.
4224
3838
                if current_block is not None:
4225
3839
                    block_index += 1
4226
3840
                    if (block_index < len(self.state._dirblocks) and
4227
 
                        osutils.is_inside(current_root,
4228
 
                                          self.state._dirblocks[block_index][0])):
 
3841
                        osutils.is_inside(current_root, self.state._dirblocks[block_index][0])):
4229
3842
                        current_block = self.state._dirblocks[block_index]
4230
3843
                    else:
4231
3844
                        current_block = None
4232
3845
                if current_dir_info is not None:
4233
3846
                    try:
4234
 
                        current_dir_info = next(dir_iterator)
 
3847
                        current_dir_info = dir_iterator.next()
4235
3848
                    except StopIteration:
4236
3849
                        current_dir_info = None
4237
3850
        for result in self._iter_specific_file_parents():
4259
3872
            found_item = False
4260
3873
            for candidate_entry in path_entries:
4261
3874
                # Find entries present in target at this path:
4262
 
                if candidate_entry[1][self.target_index][0] not in (b'a', b'r'):
 
3875
                if candidate_entry[1][self.target_index][0] not in 'ar':
4263
3876
                    found_item = True
4264
3877
                    selected_entries.append(candidate_entry)
4265
3878
                # Find entries present in source at this path:
4266
3879
                elif (self.source_index is not None and
4267
 
                      candidate_entry[1][self.source_index][0] not in (b'a', b'r')):
 
3880
                    candidate_entry[1][self.source_index][0] not in 'ar'):
4268
3881
                    found_item = True
4269
 
                    if candidate_entry[1][self.target_index][0] == b'a':
 
3882
                    if candidate_entry[1][self.target_index][0] == 'a':
4270
3883
                        # Deleted, emit it here.
4271
3884
                        selected_entries.append(candidate_entry)
4272
3885
                    else:
4277
3890
            if not found_item:
4278
3891
                raise AssertionError(
4279
3892
                    "Missing entry for specific path parent %r, %r" % (
4280
 
                        path_utf8, path_entries))
 
3893
                    path_utf8, path_entries))
4281
3894
            path_info = self._path_info(path_utf8, path_utf8.decode('utf8'))
4282
3895
            for entry in selected_entries:
4283
3896
                if entry[0][2] in self.seen_ids:
4287
3900
                    raise AssertionError(
4288
3901
                        "Got entry<->path mismatch for specific path "
4289
3902
                        "%r entry %r path_info %r " % (
4290
 
                            path_utf8, entry, path_info))
 
3903
                        path_utf8, entry, path_info))
4291
3904
                # Only include changes - we're outside the users requested
4292
3905
                # expansion.
4293
3906
                if changed:
4294
3907
                    self._gather_result_for_consistency(result)
4295
 
                    if (result.kind[0] == 'directory' and
4296
 
                            result.kind[1] != 'directory'):
 
3908
                    if (result[6][0] == 'directory' and
 
3909
                        result[6][1] != 'directory'):
4297
3910
                        # This stopped being a directory, the old children have
4298
3911
                        # to be included.
4299
 
                        if entry[1][self.source_index][0] == b'r':
 
3912
                        if entry[1][self.source_index][0] == 'r':
4300
3913
                            # renamed, take the source path
4301
3914
                            entry_path_utf8 = entry[1][self.source_index][1]
4302
3915
                        else:
4303
3916
                            entry_path_utf8 = path_utf8
4304
 
                        initial_key = (entry_path_utf8, b'', b'')
 
3917
                        initial_key = (entry_path_utf8, '', '')
4305
3918
                        block_index, _ = self.state._find_block_index_from_key(
4306
3919
                            initial_key)
4307
3920
                        if block_index == 0:
4308
3921
                            # The children of the root are in block index 1.
4309
 
                            block_index += 1
 
3922
                            block_index +=1
4310
3923
                        current_block = None
4311
3924
                        if block_index < len(self.state._dirblocks):
4312
3925
                            current_block = self.state._dirblocks[block_index]
4313
3926
                            if not osutils.is_inside(
4314
 
                                    entry_path_utf8, current_block[0]):
 
3927
                                entry_path_utf8, current_block[0]):
4315
3928
                                # No entries for this directory at all.
4316
3929
                                current_block = None
4317
3930
                        if current_block is not None:
4318
3931
                            for entry in current_block[1]:
4319
 
                                if entry[1][self.source_index][0] in (b'a', b'r'):
 
3932
                                if entry[1][self.source_index][0] in 'ar':
4320
3933
                                    # Not in the source tree, so doesn't have to be
4321
3934
                                    # included.
4322
3935
                                    continue
4336
3949
        abspath = self.tree.abspath(unicode_path)
4337
3950
        try:
4338
3951
            stat = os.lstat(abspath)
4339
 
        except OSError as e:
 
3952
        except OSError, e:
4340
3953
            if e.errno == errno.ENOENT:
4341
3954
                # the path does not exist.
4342
3955
                return None
4343
3956
            else:
4344
3957
                raise
4345
 
        utf8_basename = utf8_path.rsplit(b'/', 1)[-1]
 
3958
        utf8_basename = utf8_path.rsplit('/', 1)[-1]
4346
3959
        dir_info = (utf8_path, utf8_basename,
4347
 
                    osutils.file_kind_from_stat_mode(stat.st_mode), stat,
4348
 
                    abspath)
 
3960
            osutils.file_kind_from_stat_mode(stat.st_mode), stat,
 
3961
            abspath)
4349
3962
        if dir_info[2] == 'directory':
4350
3963
            if self.tree._directory_is_tree_reference(
4351
 
                    unicode_path):
 
3964
                unicode_path):
4352
3965
                self.root_dir_info = self.root_dir_info[:2] + \
4353
3966
                    ('tree-reference',) + self.root_dir_info[3:]
4354
3967
        return dir_info
4356
3969
 
4357
3970
# Try to load the compiled form if possible
4358
3971
try:
4359
 
    from ._dirstate_helpers_pyx import (
 
3972
    from bzrlib._dirstate_helpers_pyx import (
4360
3973
        _read_dirblocks,
4361
3974
        bisect_dirblock,
4362
3975
        _bisect_path_left,
4363
3976
        _bisect_path_right,
4364
 
        lt_by_dirs,
4365
 
        pack_stat,
 
3977
        cmp_by_dirs,
4366
3978
        ProcessEntryC as _process_entry,
4367
3979
        update_entry as update_entry,
4368
3980
        )
4369
 
except ImportError as e:
 
3981
except ImportError, e:
4370
3982
    osutils.failed_to_load_extension(e)
4371
 
    from ._dirstate_helpers_py import (
 
3983
    from bzrlib._dirstate_helpers_py import (
4372
3984
        _read_dirblocks,
4373
3985
        bisect_dirblock,
4374
3986
        _bisect_path_left,
4375
3987
        _bisect_path_right,
4376
 
        lt_by_dirs,
4377
 
        pack_stat,
 
3988
        cmp_by_dirs,
4378
3989
        )
4379
3990
    # FIXME: It would be nice to be able to track moved lines so that the
4380
3991
    # corresponding python code can be moved to the _dirstate_helpers_py