17
17
"""Tests for the Branch facility that are not interface tests.
19
For interface tests see `tests/per_branch/*.py`.
19
For interface tests see tests/per_branch/*.py.
21
21
For concrete class tests see this file, and for meta-branch tests
22
22
also see this file.
25
from cStringIO import StringIO
27
28
branch as _mod_branch,
36
branch as _mod_bzrbranch,
39
from ..bzr.fullhistory import (
43
from ..sixish import (
48
class TestErrors(tests.TestCase):
50
def test_unstackable_branch_format(self):
53
error = _mod_branch.UnstackableBranchFormat(format, url)
55
"The branch '/foo'(foo) is not a stackable format. "
56
"You will need to upgrade the branch to permit branch stacking.",
60
39
class TestDefaultFormat(tests.TestCase):
62
41
def test_default_format(self):
63
42
# update this if you change the default branch format
64
self.assertIsInstance(_mod_branch.format_registry.get_default(),
65
_mod_bzrbranch.BzrBranchFormat7)
43
self.assertIsInstance(_mod_branch.BranchFormat.get_default_format(),
44
_mod_branch.BzrBranchFormat7)
67
46
def test_default_format_is_same_as_bzrdir_default(self):
68
47
# XXX: it might be nice if there was only one place the default was
69
48
# set, but at the moment that's not true -- mbp 20070814 --
70
49
# https://bugs.launchpad.net/bzr/+bug/132376
72
_mod_branch.format_registry.get_default(),
51
_mod_branch.BranchFormat.get_default_format(),
73
52
bzrdir.BzrDirFormat.get_default_format().get_branch_format())
75
54
def test_get_set_default_format(self):
76
55
# set the format and then set it back again
77
old_format = _mod_branch.format_registry.get_default()
78
_mod_branch.format_registry.set_default(
56
old_format = _mod_branch.BranchFormat.get_default_format()
57
_mod_branch.BranchFormat.set_default_format(SampleBranchFormat())
81
59
# the default branch format is used by the meta dir format
82
60
# which is not the default bzrdir format at this point
108
86
self.assertIsDirectory('.bzr/branch/lock/held', t)
110
88
def test_set_push_location(self):
111
conf = config.LocationConfig.from_string('# comment\n', '.', save=True)
89
from bzrlib.config import (locations_config_filename,
90
ensure_config_dir_exists)
91
ensure_config_dir_exists()
92
fn = locations_config_filename()
93
# write correct newlines to locations.conf
94
# by default ConfigObj uses native line-endings for new files
95
# but uses already existing line-endings if file is not empty
98
f.write('# comment\n')
113
102
branch = self.make_branch('.', format='knit')
114
103
branch.set_push_location('foo')
115
104
local_path = urlutils.local_path_from_url(branch.base[:-1])
116
self.assertFileEqual(b"# comment\n"
118
b"push_location = foo\n"
119
b"push_location:policy = norecurse\n" % local_path.encode(
121
bedding.locations_config_path())
105
self.assertFileEqual("# comment\n"
107
"push_location = foo\n"
108
"push_location:policy = norecurse\n" % local_path,
123
111
# TODO RBC 20051029 test getting a push location from a branch in a
124
112
# recursive section - that is, it appends the branch name.
127
class SampleBranchFormat(_mod_bzrbranch.BranchFormatMetadir):
115
class SampleBranchFormat(_mod_branch.BranchFormat):
128
116
"""A sample format
130
118
this format is initializable, unsupported to aid in testing the
131
119
open and open_downlevel routines.
135
def get_format_string(cls):
122
def get_format_string(self):
136
123
"""See BzrBranchFormat.get_format_string()."""
137
return b"Sample branch format."
124
return "Sample branch format."
139
def initialize(self, a_controldir, name=None, repository=None,
140
append_revisions_only=None):
126
def initialize(self, a_bzrdir, name=None):
141
127
"""Format 4 branches cannot be created."""
142
t = a_controldir.get_branch_transport(self, name=name)
128
t = a_bzrdir.get_branch_transport(self, name=name)
143
129
t.put_bytes('format', self.get_format_string())
144
130
return 'A branch'
146
132
def is_supported(self):
149
def open(self, transport, name=None, _found=False, ignore_fallbacks=False,
150
possible_transports=None):
135
def open(self, transport, name=None, _found=False, ignore_fallbacks=False):
151
136
return "opened branch."
154
139
# Demonstrating how lazy loading is often implemented:
155
140
# A constant string is created.
156
SampleSupportedBranchFormatString = b"Sample supported branch format."
141
SampleSupportedBranchFormatString = "Sample supported branch format."
158
143
# And the format class can then reference the constant to avoid skew.
161
class SampleSupportedBranchFormat(_mod_bzrbranch.BranchFormatMetadir):
144
class SampleSupportedBranchFormat(_mod_branch.BranchFormat):
162
145
"""A sample supported format."""
165
def get_format_string(cls):
147
def get_format_string(self):
166
148
"""See BzrBranchFormat.get_format_string()."""
167
149
return SampleSupportedBranchFormatString
169
def initialize(self, a_controldir, name=None, append_revisions_only=None):
170
t = a_controldir.get_branch_transport(self, name=name)
151
def initialize(self, a_bzrdir, name=None):
152
t = a_bzrdir.get_branch_transport(self, name=name)
171
153
t.put_bytes('format', self.get_format_string())
172
154
return 'A branch'
174
def open(self, transport, name=None, _found=False, ignore_fallbacks=False,
175
possible_transports=None):
156
def open(self, transport, name=None, _found=False, ignore_fallbacks=False):
176
157
return "opened supported branch."
179
class SampleExtraBranchFormat(_mod_branch.BranchFormat):
180
"""A sample format that is not usable in a metadir."""
182
def get_format_string(self):
183
# This format is not usable in a metadir.
186
def network_name(self):
187
# Network name always has to be provided.
190
def initialize(self, a_controldir, name=None):
191
raise NotImplementedError(self.initialize)
193
def open(self, transport, name=None, _found=False, ignore_fallbacks=False,
194
possible_transports=None):
195
raise NotImplementedError(self.open)
198
160
class TestBzrBranchFormat(tests.TestCaseWithTransport):
199
161
"""Tests for the BzrBranchFormat facility."""
203
165
# create a branch with a few known format objects.
204
166
# this is not quite the same as
205
167
self.build_tree(["foo/", "bar/"])
207
168
def check_format(format, url):
208
dir = format._matchingcontroldir.initialize(url)
169
dir = format._matchingbzrdir.initialize(url)
209
170
dir.create_repository()
210
171
format.initialize(dir)
211
found_format = _mod_bzrbranch.BranchFormatMetadir.find_format(dir)
212
self.assertIsInstance(found_format, format.__class__)
213
check_format(BzrBranchFormat5(), "bar")
172
found_format = _mod_branch.BranchFormat.find_format(dir)
173
self.failUnless(isinstance(found_format, format.__class__))
174
check_format(_mod_branch.BzrBranchFormat5(), "bar")
215
def test_from_string(self):
216
self.assertIsInstance(
217
SampleBranchFormat.from_string(b"Sample branch format."),
219
self.assertRaises(AssertionError,
220
SampleBranchFormat.from_string, b"Different branch format.")
176
def test_find_format_factory(self):
177
dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
178
SampleSupportedBranchFormat().initialize(dir)
179
factory = _mod_branch.MetaDirBranchFormatFactory(
180
SampleSupportedBranchFormatString,
181
"bzrlib.tests.test_branch", "SampleSupportedBranchFormat")
182
_mod_branch.BranchFormat.register_format(factory)
183
self.addCleanup(_mod_branch.BranchFormat.unregister_format, factory)
184
b = _mod_branch.Branch.open(self.get_url())
185
self.assertEqual(b, "opened supported branch.")
222
187
def test_find_format_not_branch(self):
223
188
dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
224
189
self.assertRaises(errors.NotBranchError,
225
_mod_bzrbranch.BranchFormatMetadir.find_format,
190
_mod_branch.BranchFormat.find_format,
228
193
def test_find_format_unknown_format(self):
229
194
dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
230
195
SampleBranchFormat().initialize(dir)
231
196
self.assertRaises(errors.UnknownFormatError,
232
_mod_bzrbranch.BranchFormatMetadir.find_format,
197
_mod_branch.BranchFormat.find_format,
235
def test_find_format_with_features(self):
236
tree = self.make_branch_and_tree('.', format='2a')
237
tree.branch.update_feature_flags({b"name": b"optional"})
238
found_format = _mod_bzrbranch.BranchFormatMetadir.find_format(
240
self.assertIsInstance(found_format, _mod_bzrbranch.BranchFormatMetadir)
241
self.assertEqual(found_format.features.get(b"name"), b"optional")
242
tree.branch.update_feature_flags({b"name": None})
243
branch = _mod_branch.Branch.open('.')
244
self.assertEqual(branch._format.features, {})
247
class TestBranchFormatRegistry(tests.TestCase):
250
super(TestBranchFormatRegistry, self).setUp()
251
self.registry = _mod_branch.BranchFormatRegistry()
253
def test_default(self):
254
self.assertIs(None, self.registry.get_default())
255
format = SampleBranchFormat()
256
self.registry.set_default(format)
257
self.assertEqual(format, self.registry.get_default())
259
200
def test_register_unregister_format(self):
260
201
format = SampleBranchFormat()
261
self.registry.register(format)
262
self.assertEqual(format,
263
self.registry.get(b"Sample branch format."))
264
self.registry.remove(format)
265
self.assertRaises(KeyError, self.registry.get,
266
b"Sample branch format.")
268
def test_get_all(self):
269
format = SampleBranchFormat()
270
self.assertEqual([], self.registry._get_all())
271
self.registry.register(format)
272
self.assertEqual([format], self.registry._get_all())
274
def test_register_extra(self):
275
format = SampleExtraBranchFormat()
276
self.assertEqual([], self.registry._get_all())
277
self.registry.register_extra(format)
278
self.assertEqual([format], self.registry._get_all())
280
def test_register_extra_lazy(self):
281
self.assertEqual([], self.registry._get_all())
282
self.registry.register_extra_lazy("breezy.tests.test_branch",
283
"SampleExtraBranchFormat")
284
formats = self.registry._get_all()
285
self.assertEqual(1, len(formats))
286
self.assertIsInstance(formats[0], SampleExtraBranchFormat)
203
dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
205
format.initialize(dir)
206
# register a format for it.
207
_mod_branch.BranchFormat.register_format(format)
208
# which branch.Open will refuse (not supported)
209
self.assertRaises(errors.UnsupportedFormatError,
210
_mod_branch.Branch.open, self.get_url())
211
self.make_branch_and_tree('foo')
212
# but open_downlevel will work
215
bzrdir.BzrDir.open(self.get_url()).open_branch(unsupported=True))
216
# unregister the format
217
_mod_branch.BranchFormat.unregister_format(format)
218
self.make_branch_and_tree('bar')
221
#Used by TestMetaDirBranchFormatFactory
222
FakeLazyFormat = None
225
class TestMetaDirBranchFormatFactory(tests.TestCase):
227
def test_get_format_string_does_not_load(self):
228
"""Formats have a static format string."""
229
factory = _mod_branch.MetaDirBranchFormatFactory("yo", None, None)
230
self.assertEqual("yo", factory.get_format_string())
232
def test_call_loads(self):
233
# __call__ is used by the network_format_registry interface to get a
235
global FakeLazyFormat
237
factory = _mod_branch.MetaDirBranchFormatFactory(None,
238
"bzrlib.tests.test_branch", "FakeLazyFormat")
239
self.assertRaises(AttributeError, factory)
241
def test_call_returns_call_of_referenced_object(self):
242
global FakeLazyFormat
243
FakeLazyFormat = lambda:'called'
244
factory = _mod_branch.MetaDirBranchFormatFactory(None,
245
"bzrlib.tests.test_branch", "FakeLazyFormat")
246
self.assertEqual('called', factory())
289
249
class TestBranch67(object):
311
271
def test_layout(self):
312
272
branch = self.make_branch('a', format=self.get_format_name())
313
self.assertPathExists('a/.bzr/branch/last-revision')
314
self.assertPathDoesNotExist('a/.bzr/branch/revision-history')
315
self.assertPathDoesNotExist('a/.bzr/branch/references')
273
self.failUnlessExists('a/.bzr/branch/last-revision')
274
self.failIfExists('a/.bzr/branch/revision-history')
275
self.failIfExists('a/.bzr/branch/references')
317
277
def test_config(self):
318
278
"""Ensure that all configuration data is stored in the branch"""
319
279
branch = self.make_branch('a', format=self.get_format_name())
320
branch.set_parent('http://example.com')
321
self.assertPathDoesNotExist('a/.bzr/branch/parent')
322
self.assertEqual('http://example.com', branch.get_parent())
323
branch.set_push_location('sftp://example.com')
324
conf = branch.get_config_stack()
325
self.assertEqual('sftp://example.com', conf.get('push_location'))
326
branch.set_bound_location('ftp://example.com')
327
self.assertPathDoesNotExist('a/.bzr/branch/bound')
328
self.assertEqual('ftp://example.com', branch.get_bound_location())
330
def do_checkout_test(self, lightweight):
280
branch.set_parent('http://bazaar-vcs.org')
281
self.failIfExists('a/.bzr/branch/parent')
282
self.assertEqual('http://bazaar-vcs.org', branch.get_parent())
283
branch.set_push_location('sftp://bazaar-vcs.org')
284
config = branch.get_config()._get_branch_data_config()
285
self.assertEqual('sftp://bazaar-vcs.org',
286
config.get_user_option('push_location'))
287
branch.set_bound_location('ftp://bazaar-vcs.org')
288
self.failIfExists('a/.bzr/branch/bound')
289
self.assertEqual('ftp://bazaar-vcs.org', branch.get_bound_location())
291
def test_set_revision_history(self):
292
builder = self.make_branch_builder('.', format=self.get_format_name())
293
builder.build_snapshot('foo', None,
294
[('add', ('', None, 'directory', None))],
296
builder.build_snapshot('bar', None, [], message='bar')
297
branch = builder.get_branch()
299
self.addCleanup(branch.unlock)
300
branch.set_revision_history(['foo', 'bar'])
301
branch.set_revision_history(['foo'])
302
self.assertRaises(errors.NotLefthandHistory,
303
branch.set_revision_history, ['bar'])
305
def do_checkout_test(self, lightweight=False):
331
306
tree = self.make_branch_and_tree('source',
332
format=self.get_format_name_subtree())
307
format=self.get_format_name_subtree())
333
308
subtree = self.make_branch_and_tree('source/subtree',
334
format=self.get_format_name_subtree())
309
format=self.get_format_name_subtree())
335
310
subsubtree = self.make_branch_and_tree('source/subtree/subsubtree',
336
format=self.get_format_name_subtree())
311
format=self.get_format_name_subtree())
337
312
self.build_tree(['source/subtree/file',
338
313
'source/subtree/subsubtree/file'])
339
314
subsubtree.add('file')
340
315
subtree.add('file')
341
316
subtree.add_reference(subsubtree)
342
subtree.set_reference_info('subsubtree', subsubtree.branch.user_url)
343
317
tree.add_reference(subtree)
344
tree.set_reference_info('subtree', subtree.branch.user_url)
345
318
tree.commit('a revision')
346
319
subtree.commit('a subtree file')
347
320
subsubtree.commit('a subsubtree file')
348
321
tree.branch.create_checkout('target', lightweight=lightweight)
349
self.assertPathExists('target')
350
self.assertPathExists('target/subtree')
351
self.assertPathExists('target/subtree/file')
352
self.assertPathExists('target/subtree/subsubtree/file')
322
self.failUnlessExists('target')
323
self.failUnlessExists('target/subtree')
324
self.failUnlessExists('target/subtree/file')
325
self.failUnlessExists('target/subtree/subsubtree/file')
353
326
subbranch = _mod_branch.Branch.open('target/subtree/subsubtree')
355
328
self.assertEndsWith(subbranch.base, 'source/subtree/subsubtree/')
482
469
branch.lock_write()
483
470
self.instrument_branch(branch, gets)
484
471
self.addCleanup(branch.unlock)
485
branch._set_all_reference_info({'path2': ('location2', b'file-id')})
486
location, file_id = branch.get_reference_info('path2')
472
branch._set_all_reference_info({'file-id': ('path2', 'location2')})
473
path, location = branch.get_reference_info('file-id')
487
474
self.assertEqual(0, len(gets))
488
self.assertEqual(b'file-id', file_id)
475
self.assertEqual('path2', path)
489
476
self.assertEqual('location2', location)
491
478
def test_reference_info_caches_cleared(self):
492
479
branch = self.make_branch('branch')
493
with branch.lock_write():
494
branch.set_reference_info(b'file-id', 'location2', 'path2')
481
branch.set_reference_info('file-id', 'path2', 'location2')
495
483
doppelganger = _mod_branch.Branch.open('branch')
496
doppelganger.set_reference_info(b'file-id', 'location3', 'path3')
497
self.assertEqual(('location3', 'path3'),
498
branch.get_reference_info(b'file-id'))
500
def _recordParentMapCalls(self, repo):
501
self._parent_map_calls = []
502
orig_get_parent_map = repo.revisions.get_parent_map
504
def get_parent_map(q):
506
self._parent_map_calls.extend([e[0] for e in q])
507
return orig_get_parent_map(q)
508
repo.revisions.get_parent_map = get_parent_map
484
doppelganger.set_reference_info('file-id', 'path3', 'location3')
485
self.assertEqual(('path3', 'location3'),
486
branch.get_reference_info('file-id'))
511
488
class TestBranchReference(tests.TestCaseWithTransport):
512
489
"""Tests for the branch reference facility."""
514
491
def test_create_open_reference(self):
515
492
bzrdirformat = bzrdir.BzrDirMetaFormat1()
516
t = self.get_transport()
493
t = transport.get_transport(self.get_url('.'))
518
495
dir = bzrdirformat.initialize(self.get_url('repo'))
519
496
dir.create_repository()
520
497
target_branch = dir.create_branch()
521
498
t.mkdir('branch')
522
499
branch_dir = bzrdirformat.initialize(self.get_url('branch'))
523
made_branch = _mod_bzrbranch.BranchReferenceFormat().initialize(
500
made_branch = _mod_branch.BranchReferenceFormat().initialize(
524
501
branch_dir, target_branch=target_branch)
525
502
self.assertEqual(made_branch.base, target_branch.base)
526
503
opened_branch = branch_dir.open_branch()
527
504
self.assertEqual(opened_branch.base, target_branch.base)
529
506
def test_get_reference(self):
530
"""For a BranchReference, get_reference should return the location."""
507
"""For a BranchReference, get_reference should reutrn the location."""
531
508
branch = self.make_branch('target')
532
509
checkout = branch.create_checkout('checkout', lightweight=True)
533
reference_url = branch.controldir.root_transport.abspath('') + '/'
510
reference_url = branch.bzrdir.root_transport.abspath('') + '/'
534
511
# if the api for create_checkout changes to return different checkout types
535
512
# then this file read will fail.
536
self.assertFileEqual(reference_url.encode('utf-8'),
537
'checkout/.bzr/branch/location')
513
self.assertFileEqual(reference_url, 'checkout/.bzr/branch/location')
538
514
self.assertEqual(reference_url,
539
_mod_bzrbranch.BranchReferenceFormat().get_reference(checkout.controldir))
515
_mod_branch.BranchReferenceFormat().get_reference(checkout.bzrdir))
542
518
class TestHooks(tests.TestCaseWithTransport):
567
543
def test_post_branch_init_hook(self):
569
545
_mod_branch.Branch.hooks.install_named_hook('post_branch_init',
571
547
self.assertLength(0, calls)
572
548
branch = self.make_branch('a')
573
549
self.assertLength(1, calls)
574
550
params = calls[0]
575
551
self.assertIsInstance(params, _mod_branch.BranchInitHookParams)
576
self.assertTrue(hasattr(params, 'controldir'))
552
self.assertTrue(hasattr(params, 'bzrdir'))
577
553
self.assertTrue(hasattr(params, 'branch'))
579
def test_post_branch_init_hook_repr(self):
581
_mod_branch.Branch.hooks.install_named_hook('post_branch_init',
582
lambda params: param_reprs.append(repr(params)), None)
583
branch = self.make_branch('a')
584
self.assertLength(1, param_reprs)
585
param_repr = param_reprs[0]
586
self.assertStartsWith(param_repr, '<BranchInitHookParams of ')
588
555
def test_post_switch_hook(self):
589
from .. import switch
556
from bzrlib import switch
591
558
_mod_branch.Branch.hooks.install_named_hook('post_switch',
593
560
tree = self.make_branch_and_tree('branch-1')
594
561
self.build_tree(['branch-1/file-1'])
595
562
tree.add('file-1')
596
563
tree.commit('rev1')
597
to_branch = tree.controldir.sprout('branch-2').open_branch()
564
to_branch = tree.bzrdir.sprout('branch-2').open_branch()
598
565
self.build_tree(['branch-1/file-2'])
599
566
tree.add('file-2')
600
567
tree.remove('file-1')
601
568
tree.commit('rev2')
602
569
checkout = tree.branch.create_checkout('checkout')
603
570
self.assertLength(0, calls)
604
switch.switch(checkout.controldir, to_branch)
571
switch.switch(checkout.bzrdir, to_branch)
605
572
self.assertLength(1, calls)
606
573
params = calls[0]
607
574
self.assertIsInstance(params, _mod_branch.SwitchHookParams)
637
604
def test_invalid_append_revisions_only(self):
638
605
"""Ensure warning is noted on invalid settings"""
639
606
self.warnings = []
641
607
def warning(*args):
642
608
self.warnings.append(args[0] % args[1:])
643
609
self.overrideAttr(trace, 'warning', warning)
644
610
self.check_append_revisions_only(None, 'not-a-bool')
645
611
self.assertLength(1, self.warnings)
646
612
self.assertEqual(
647
'Value "not-a-bool" is not valid for "append_revisions_only"',
613
'Value "not-a-bool" is not a boolean for "append_revisions_only"',
648
614
self.warnings[0])
650
def test_use_fresh_values(self):
651
copy = _mod_branch.Branch.open(self.branch.base)
654
copy.get_config_stack().set('foo', 'bar')
657
self.assertFalse(self.branch.is_locked())
658
# Since the branch is locked, the option value won't be saved on disk
659
# so trying to access the config of locked branch via another older
660
# non-locked branch object pointing to the same branch is not supported
661
self.assertEqual(None, self.branch.get_config_stack().get('foo'))
662
# Using a newly created branch object works as expected
663
fresh = _mod_branch.Branch.open(self.branch.base)
664
self.assertEqual('bar', fresh.get_config_stack().get('foo'))
666
def test_set_from_config_get_from_config_stack(self):
667
self.branch.lock_write()
668
self.addCleanup(self.branch.unlock)
669
self.branch.get_config().set_user_option('foo', 'bar')
670
result = self.branch.get_config_stack().get('foo')
671
# https://bugs.launchpad.net/bzr/+bug/948344
672
self.expectFailure('BranchStack uses cache after set_user_option',
673
self.assertEqual, 'bar', result)
675
def test_set_from_config_stack_get_from_config(self):
676
self.branch.lock_write()
677
self.addCleanup(self.branch.unlock)
678
self.branch.get_config_stack().set('foo', 'bar')
679
# Since the branch is locked, the option value won't be saved on disk
680
# so mixing get() and get_user_option() is broken by design.
681
self.assertEqual(None,
682
self.branch.get_config().get_user_option('foo'))
684
def test_set_delays_write_when_branch_is_locked(self):
685
self.branch.lock_write()
686
self.addCleanup(self.branch.unlock)
687
self.branch.get_config_stack().set('foo', 'bar')
688
copy = _mod_branch.Branch.open(self.branch.base)
689
result = copy.get_config_stack().get('foo')
690
# Accessing from a different branch object is like accessing from a
691
# different process: the option has not been saved yet and the new
692
# value cannot be seen.
693
self.assertIs(None, result)
696
617
class TestPullResult(tests.TestCase):
619
def test_pull_result_to_int(self):
620
# to support old code, the pull result can be used as an int
621
r = _mod_branch.PullResult()
624
# this usage of results is not recommended for new code (because it
625
# doesn't describe very well what happened), but for api stability
626
# it's still supported
627
a = "%d revisions pulled" % r
628
self.assertEqual(a, "10 revisions pulled")
698
630
def test_report_changed(self):
699
631
r = _mod_branch.PullResult()
700
r.old_revid = b"old-revid"
632
r.old_revid = "old-revid"
702
r.new_revid = b"new-revid"
634
r.new_revid = "new-revid"
708
640
def test_report_unchanged(self):
709
641
r = _mod_branch.PullResult()
710
r.old_revid = b"same-revid"
711
r.new_revid = b"same-revid"
642
r.old_revid = "same-revid"
643
r.new_revid = "same-revid"
714
self.assertEqual("No revisions or tags to pull.\n", f.getvalue())
646
self.assertEqual("No revisions to pull.\n", f.getvalue())
649
class _StubLockable(object):
650
"""Helper for TestRunWithWriteLockedTarget."""
652
def __init__(self, calls, unlock_exc=None):
654
self.unlock_exc = unlock_exc
656
def lock_write(self):
657
self.calls.append('lock_write')
660
self.calls.append('unlock')
661
if self.unlock_exc is not None:
662
raise self.unlock_exc
665
class _ErrorFromCallable(Exception):
666
"""Helper for TestRunWithWriteLockedTarget."""
669
class _ErrorFromUnlock(Exception):
670
"""Helper for TestRunWithWriteLockedTarget."""
673
class TestRunWithWriteLockedTarget(tests.TestCase):
674
"""Tests for _run_with_write_locked_target."""
677
tests.TestCase.setUp(self)
680
def func_that_returns_ok(self):
681
self._calls.append('func called')
684
def func_that_raises(self):
685
self._calls.append('func called')
686
raise _ErrorFromCallable()
688
def test_success_unlocks(self):
689
lockable = _StubLockable(self._calls)
690
result = _mod_branch._run_with_write_locked_target(
691
lockable, self.func_that_returns_ok)
692
self.assertEqual('ok', result)
693
self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
695
def test_exception_unlocks_and_propagates(self):
696
lockable = _StubLockable(self._calls)
697
self.assertRaises(_ErrorFromCallable,
698
_mod_branch._run_with_write_locked_target,
699
lockable, self.func_that_raises)
700
self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
702
def test_callable_succeeds_but_error_during_unlock(self):
703
lockable = _StubLockable(self._calls, unlock_exc=_ErrorFromUnlock())
704
self.assertRaises(_ErrorFromUnlock,
705
_mod_branch._run_with_write_locked_target,
706
lockable, self.func_that_returns_ok)
707
self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
709
def test_error_during_unlock_does_not_mask_original_error(self):
710
lockable = _StubLockable(self._calls, unlock_exc=_ErrorFromUnlock())
711
self.assertRaises(_ErrorFromCallable,
712
_mod_branch._run_with_write_locked_target,
713
lockable, self.func_that_raises)
714
self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
added
removed
bzrlib/tests/test_branch.py
