/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Marius Kruger
  • Date: 2010-07-10 21:28:56 UTC
  • mto: (5384.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 5385.
  • Revision ID: marius.kruger@enerweb.co.za-20100710212856-uq4ji3go0u5se7hx
* Update documentation
* add NEWS

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2012, 2015, 2016, 2017 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
20
20
transport implementation, http protocol versions and authentication schemes.
21
21
"""
22
22
 
23
 
# TODO: Should be renamed to breezy.transport.http.tests?
24
 
# TODO: What about renaming to breezy.tests.transport.http ?
 
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
 
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
try:
27
 
    from http.client import UnknownProtocol, parse_headers
28
 
    from http.server import SimpleHTTPRequestHandler
29
 
except ImportError:  # python < 3
30
 
    from httplib import UnknownProtocol
31
 
    from SimpleHTTPServer import SimpleHTTPRequestHandler
32
 
import io
 
26
from cStringIO import StringIO
 
27
import httplib
 
28
import os
 
29
import select
 
30
import SimpleHTTPServer
33
31
import socket
34
32
import sys
35
33
import threading
36
34
 
37
 
import breezy
38
 
from .. import (
 
35
import bzrlib
 
36
from bzrlib import (
 
37
    bzrdir,
39
38
    config,
40
 
    controldir,
41
 
    debug,
42
39
    errors,
43
40
    osutils,
 
41
    remote as _mod_remote,
44
42
    tests,
45
 
    trace,
46
43
    transport,
47
44
    ui,
48
45
    urlutils,
49
46
    )
50
 
from ..bzr import (
51
 
    remote as _mod_remote,
 
47
from bzrlib.symbol_versioning import (
 
48
    deprecated_in,
52
49
    )
53
 
from ..sixish import PY3
54
 
from . import (
 
50
from bzrlib.tests import (
55
51
    features,
56
52
    http_server,
57
53
    http_utils,
58
 
    test_server,
59
 
    )
60
 
from .scenarios import (
61
 
    load_tests_apply_scenarios,
62
 
    multiply_scenarios,
63
 
    )
64
 
from ..transport import (
 
54
    )
 
55
from bzrlib.transport import (
65
56
    http,
66
57
    remote,
67
58
    )
68
 
from ..transport.http import (
69
 
    HttpTransport,
 
59
from bzrlib.transport.http import (
 
60
    _urllib,
 
61
    _urllib2_wrappers,
70
62
    )
71
63
 
72
64
 
73
 
load_tests = load_tests_apply_scenarios
74
 
 
75
 
 
76
 
def vary_by_http_client_implementation():
77
 
    """Test the libraries we can use, currently just urllib."""
 
65
if features.pycurl.available():
 
66
    from bzrlib.transport.http._pycurl import PyCurlTransport
 
67
 
 
68
 
 
69
def load_tests(standard_tests, module, loader):
 
70
    """Multiply tests for http clients and protocol versions."""
 
71
    result = loader.suiteClass()
 
72
 
 
73
    # one for each transport implementation
 
74
    t_tests, remaining_tests = tests.split_suite_by_condition(
 
75
        standard_tests, tests.condition_isinstance((
 
76
                TestHttpTransportRegistration,
 
77
                TestHttpTransportUrls,
 
78
                Test_redirected_to,
 
79
                )))
78
80
    transport_scenarios = [
79
 
        ('urllib', dict(_transport=HttpTransport,
80
 
                        _server=http_server.HttpServer,
81
 
                        _url_protocol='http',)),
82
 
        ]
83
 
    return transport_scenarios
84
 
 
85
 
 
86
 
def vary_by_http_protocol_version():
87
 
    """Test on http/1.0 and 1.1"""
88
 
    return [
89
 
        ('HTTP/1.0', dict(_protocol_version='HTTP/1.0')),
90
 
        ('HTTP/1.1', dict(_protocol_version='HTTP/1.1')),
91
 
        ]
92
 
 
93
 
 
94
 
def vary_by_http_auth_scheme():
95
 
    scenarios = [
 
81
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
 
82
                        _server=http_server.HttpServer_urllib,
 
83
                        _qualified_prefix='http+urllib',)),
 
84
        ]
 
85
    if features.pycurl.available():
 
86
        transport_scenarios.append(
 
87
            ('pycurl', dict(_transport=PyCurlTransport,
 
88
                            _server=http_server.HttpServer_PyCurl,
 
89
                            _qualified_prefix='http+pycurl',)))
 
90
    tests.multiply_tests(t_tests, transport_scenarios, result)
 
91
 
 
92
    protocol_scenarios = [
 
93
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
94
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
 
95
            ]
 
96
 
 
97
    # some tests are parametrized by the protocol version only
 
98
    p_tests, remaining_tests = tests.split_suite_by_condition(
 
99
        remaining_tests, tests.condition_isinstance((
 
100
                TestAuthOnRedirected,
 
101
                )))
 
102
    tests.multiply_tests(p_tests, protocol_scenarios, result)
 
103
 
 
104
    # each implementation tested with each HTTP version
 
105
    tp_tests, remaining_tests = tests.split_suite_by_condition(
 
106
        remaining_tests, tests.condition_isinstance((
 
107
                SmartHTTPTunnellingTest,
 
108
                TestDoCatchRedirections,
 
109
                TestHTTPConnections,
 
110
                TestHTTPRedirections,
 
111
                TestHTTPSilentRedirections,
 
112
                TestLimitedRangeRequestServer,
 
113
                TestPost,
 
114
                TestProxyHttpServer,
 
115
                TestRanges,
 
116
                TestSpecificRequestHandler,
 
117
                )))
 
118
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
 
119
                                            protocol_scenarios)
 
120
    tests.multiply_tests(tp_tests, tp_scenarios, result)
 
121
 
 
122
    # proxy auth: each auth scheme on all http versions on all implementations.
 
123
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
 
124
        remaining_tests, tests.condition_isinstance((
 
125
                TestProxyAuth,
 
126
                )))
 
127
    proxy_auth_scheme_scenarios = [
 
128
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
 
129
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
 
130
        ('basicdigest',
 
131
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
132
        ]
 
133
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
 
134
                                              proxy_auth_scheme_scenarios)
 
135
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
 
136
 
 
137
    # auth: each auth scheme on all http versions on all implementations.
 
138
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
 
139
        remaining_tests, tests.condition_isinstance((
 
140
                TestAuth,
 
141
                )))
 
142
    auth_scheme_scenarios = [
96
143
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
97
144
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
98
145
        ('basicdigest',
99
 
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
100
 
        ]
101
 
    # Add some attributes common to all scenarios
102
 
    for scenario_id, scenario_dict in scenarios:
103
 
        scenario_dict.update(_auth_header='Authorization',
104
 
                             _username_prompt_prefix='',
105
 
                             _password_prompt_prefix='')
106
 
    return scenarios
107
 
 
108
 
 
109
 
def vary_by_http_proxy_auth_scheme():
110
 
    scenarios = [
111
 
        ('proxy-basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
112
 
        ('proxy-digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
113
 
        ('proxy-basicdigest',
114
 
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
115
 
        ]
116
 
    # Add some attributes common to all scenarios
117
 
    for scenario_id, scenario_dict in scenarios:
118
 
        scenario_dict.update(_auth_header='Proxy-Authorization',
119
 
                             _username_prompt_prefix='Proxy ',
120
 
                             _password_prompt_prefix='Proxy ')
121
 
    return scenarios
122
 
 
123
 
 
124
 
def vary_by_http_activity():
 
146
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
147
        ]
 
148
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
 
149
                                             auth_scheme_scenarios)
 
150
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
 
151
 
 
152
    # activity: on all http[s] versions on all implementations
 
153
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
 
154
        remaining_tests, tests.condition_isinstance((
 
155
                TestActivity,
 
156
                )))
125
157
    activity_scenarios = [
126
158
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
127
 
                             _transport=HttpTransport,)),
 
159
                             _transport=_urllib.HttpTransport_urllib,)),
128
160
        ]
129
 
    if features.HTTPSServerFeature.available():
130
 
        # FIXME: Until we have a better way to handle self-signed certificates
131
 
        # (like allowing them in a test specific authentication.conf for
132
 
        # example), we need some specialized urllib transport for tests.
133
 
        # -- vila 2012-01-20
134
 
        from . import (
135
 
            ssl_certs,
136
 
            )
137
 
 
138
 
        class HTTPS_transport(HttpTransport):
139
 
 
140
 
            def __init__(self, base, _from_transport=None):
141
 
                super(HTTPS_transport, self).__init__(
142
 
                    base, _from_transport=_from_transport,
143
 
                    ca_certs=ssl_certs.build_path('ca.crt'))
144
 
 
 
161
    if tests.HTTPSServerFeature.available():
145
162
        activity_scenarios.append(
146
163
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
147
 
                                  _transport=HTTPS_transport,)),)
148
 
    return activity_scenarios
 
164
                                  _transport=_urllib.HttpTransport_urllib,)),)
 
165
    if features.pycurl.available():
 
166
        activity_scenarios.append(
 
167
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
 
168
                                 _transport=PyCurlTransport,)),)
 
169
        if tests.HTTPSServerFeature.available():
 
170
            from bzrlib.tests import (
 
171
                ssl_certs,
 
172
                )
 
173
            # FIXME: Until we have a better way to handle self-signed
 
174
            # certificates (like allowing them in a test specific
 
175
            # authentication.conf for example), we need some specialized pycurl
 
176
            # transport for tests.
 
177
            class HTTPS_pycurl_transport(PyCurlTransport):
 
178
 
 
179
                def __init__(self, base, _from_transport=None):
 
180
                    super(HTTPS_pycurl_transport, self).__init__(
 
181
                        base, _from_transport)
 
182
                    self.cabundle = str(ssl_certs.build_path('ca.crt'))
 
183
 
 
184
            activity_scenarios.append(
 
185
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
 
186
                                      _transport=HTTPS_pycurl_transport,)),)
 
187
 
 
188
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
 
189
                                               protocol_scenarios)
 
190
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
 
191
 
 
192
    # No parametrization for the remaining tests
 
193
    result.addTests(remaining_tests)
 
194
 
 
195
    return result
149
196
 
150
197
 
151
198
class FakeManager(object):
173
220
        self._expect_body_tail = expect_body_tail
174
221
        self.host = None
175
222
        self.port = None
176
 
        self.received_bytes = b''
 
223
        self.received_bytes = ''
177
224
        self.scheme = scheme
178
225
 
179
226
    def get_url(self):
184
231
        self._sock.bind(('127.0.0.1', 0))
185
232
        self.host, self.port = self._sock.getsockname()
186
233
        self._ready = threading.Event()
187
 
        self._thread = test_server.TestThread(
188
 
            sync_event=self._ready, target=self._accept_read_and_reply)
 
234
        self._thread = threading.Thread(target=self._accept_read_and_reply)
 
235
        self._thread.setDaemon(True)
189
236
        self._thread.start()
190
 
        if 'threads' in tests.selftest_debug_flags:
191
 
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
192
 
        self._ready.wait()
 
237
        self._ready.wait(5)
193
238
 
194
239
    def _accept_read_and_reply(self):
195
240
        self._sock.listen(1)
196
241
        self._ready.set()
197
 
        conn, address = self._sock.accept()
198
 
        if self._expect_body_tail is not None:
 
242
        self._sock.settimeout(5)
 
243
        try:
 
244
            conn, address = self._sock.accept()
 
245
            # On win32, the accepted connection will be non-blocking to start
 
246
            # with because we're using settimeout.
 
247
            conn.setblocking(True)
199
248
            while not self.received_bytes.endswith(self._expect_body_tail):
200
249
                self.received_bytes += conn.recv(4096)
201
 
            conn.sendall(b'HTTP/1.1 200 OK\r\n')
202
 
        try:
 
250
            conn.sendall('HTTP/1.1 200 OK\r\n')
 
251
        except socket.timeout:
 
252
            # Make sure the client isn't stuck waiting for us to e.g. accept.
203
253
            self._sock.close()
204
254
        except socket.error:
205
255
            # The client may have already closed the socket.
207
257
 
208
258
    def stop_server(self):
209
259
        try:
210
 
            # Issue a fake connection to wake up the server and allow it to
211
 
            # finish quickly
212
 
            fake_conn = osutils.connect_socket((self.host, self.port))
213
 
            fake_conn.close()
 
260
            self._sock.close()
214
261
        except socket.error:
215
262
            # We might have already closed it.  We don't care.
216
263
            pass
217
264
        self.host = None
218
265
        self.port = None
219
 
        self._thread.join()
220
 
        if 'threads' in tests.selftest_debug_flags:
221
 
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
222
266
 
223
267
 
224
268
class TestAuthHeader(tests.TestCase):
225
269
 
226
270
    def parse_header(self, header, auth_handler_class=None):
227
271
        if auth_handler_class is None:
228
 
            auth_handler_class = http.AbstractAuthHandler
229
 
        self.auth_handler = auth_handler_class()
 
272
            auth_handler_class = _urllib2_wrappers.AbstractAuthHandler
 
273
        self.auth_handler =  auth_handler_class()
230
274
        return self.auth_handler._parse_auth_header(header)
231
275
 
232
276
    def test_empty_header(self):
245
289
        self.assertEqual('basic', scheme)
246
290
        self.assertEqual('realm="Thou should not pass"', remainder)
247
291
 
248
 
    def test_build_basic_header_with_long_creds(self):
249
 
        handler = http.BasicAuthHandler()
250
 
        user = 'user' * 10  # length 40
251
 
        password = 'password' * 5  # length 40
252
 
        header = handler.build_auth_header(
253
 
            dict(user=user, password=password), None)
254
 
        # https://bugs.launchpad.net/bzr/+bug/1606203 was caused by incorrectly
255
 
        # creating a header value with an embedded '\n'
256
 
        self.assertFalse('\n' in header)
257
 
 
258
292
    def test_basic_extract_realm(self):
259
293
        scheme, remainder = self.parse_header(
260
294
            'Basic realm="Thou should not pass"',
261
 
            http.BasicAuthHandler)
 
295
            _urllib2_wrappers.BasicAuthHandler)
262
296
        match, realm = self.auth_handler.extract_realm(remainder)
263
297
        self.assertTrue(match is not None)
264
 
        self.assertEqual(u'Thou should not pass', realm)
 
298
        self.assertEqual('Thou should not pass', realm)
265
299
 
266
300
    def test_digest_header(self):
267
301
        scheme, remainder = self.parse_header(
270
304
        self.assertEqual('realm="Thou should not pass"', remainder)
271
305
 
272
306
 
273
 
class TestHTTPRangeParsing(tests.TestCase):
274
 
 
275
 
    def setUp(self):
276
 
        super(TestHTTPRangeParsing, self).setUp()
277
 
        # We focus on range  parsing here and ignore everything else
278
 
 
279
 
        class RequestHandler(http_server.TestingHTTPRequestHandler):
280
 
            def setup(self): pass
281
 
 
282
 
            def handle(self): pass
283
 
 
284
 
            def finish(self): pass
285
 
 
286
 
        self.req_handler = RequestHandler(None, None, None)
287
 
 
288
 
    def assertRanges(self, ranges, header, file_size):
289
 
        self.assertEqual(ranges,
290
 
                         self.req_handler._parse_ranges(header, file_size))
291
 
 
292
 
    def test_simple_range(self):
293
 
        self.assertRanges([(0, 2)], 'bytes=0-2', 12)
294
 
 
295
 
    def test_tail(self):
296
 
        self.assertRanges([(8, 11)], 'bytes=-4', 12)
297
 
 
298
 
    def test_tail_bigger_than_file(self):
299
 
        self.assertRanges([(0, 11)], 'bytes=-99', 12)
300
 
 
301
 
    def test_range_without_end(self):
302
 
        self.assertRanges([(4, 11)], 'bytes=4-', 12)
303
 
 
304
 
    def test_invalid_ranges(self):
305
 
        self.assertRanges(None, 'bytes=12-22', 12)
306
 
        self.assertRanges(None, 'bytes=1-3,12-22', 12)
307
 
        self.assertRanges(None, 'bytes=-', 12)
308
 
 
309
 
 
310
307
class TestHTTPServer(tests.TestCase):
311
308
    """Test the HTTP servers implementations."""
312
309
 
315
312
 
316
313
            protocol_version = 'HTTP/0.1'
317
314
 
318
 
        self.assertRaises(UnknownProtocol,
319
 
                          http_server.HttpServer, BogusRequestHandler)
 
315
        server = http_server.HttpServer(BogusRequestHandler)
 
316
        try:
 
317
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
 
318
        except:
 
319
            server.stop_server()
 
320
            self.fail('HTTP Server creation did not raise UnknownProtocol')
320
321
 
321
322
    def test_force_invalid_protocol(self):
322
 
        self.assertRaises(UnknownProtocol,
323
 
                          http_server.HttpServer, protocol_version='HTTP/0.1')
 
323
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
 
324
        try:
 
325
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
 
326
        except:
 
327
            server.stop_server()
 
328
            self.fail('HTTP Server creation did not raise UnknownProtocol')
324
329
 
325
330
    def test_server_start_and_stop(self):
326
331
        server = http_server.HttpServer()
327
 
        self.addCleanup(server.stop_server)
328
332
        server.start_server()
329
 
        self.assertTrue(server.server is not None)
330
 
        self.assertTrue(server.server.serving is not None)
331
 
        self.assertTrue(server.server.serving)
 
333
        try:
 
334
            self.assertTrue(server._http_running)
 
335
        finally:
 
336
            server.stop_server()
 
337
        self.assertFalse(server._http_running)
332
338
 
333
339
    def test_create_http_server_one_zero(self):
334
340
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
337
343
 
338
344
        server = http_server.HttpServer(RequestHandlerOneZero)
339
345
        self.start_server(server)
340
 
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
 
346
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
341
347
 
342
348
    def test_create_http_server_one_one(self):
343
349
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
346
352
 
347
353
        server = http_server.HttpServer(RequestHandlerOneOne)
348
354
        self.start_server(server)
349
 
        self.assertIsInstance(server.server,
 
355
        self.assertIsInstance(server._httpd,
350
356
                              http_server.TestingThreadingHTTPServer)
351
357
 
352
358
    def test_create_http_server_force_one_one(self):
357
363
        server = http_server.HttpServer(RequestHandlerOneZero,
358
364
                                        protocol_version='HTTP/1.1')
359
365
        self.start_server(server)
360
 
        self.assertIsInstance(server.server,
 
366
        self.assertIsInstance(server._httpd,
361
367
                              http_server.TestingThreadingHTTPServer)
362
368
 
363
369
    def test_create_http_server_force_one_zero(self):
368
374
        server = http_server.HttpServer(RequestHandlerOneOne,
369
375
                                        protocol_version='HTTP/1.0')
370
376
        self.start_server(server)
371
 
        self.assertIsInstance(server.server,
 
377
        self.assertIsInstance(server._httpd,
372
378
                              http_server.TestingHTTPServer)
373
379
 
374
380
 
 
381
class TestWithTransport_pycurl(object):
 
382
    """Test case to inherit from if pycurl is present"""
 
383
 
 
384
    def _get_pycurl_maybe(self):
 
385
        self.requireFeature(features.pycurl)
 
386
        return PyCurlTransport
 
387
 
 
388
    _transport = property(_get_pycurl_maybe)
 
389
 
 
390
 
 
391
class TestHttpUrls(tests.TestCase):
 
392
 
 
393
    # TODO: This should be moved to authorization tests once they
 
394
    # are written.
 
395
 
 
396
    def test_url_parsing(self):
 
397
        f = FakeManager()
 
398
        url = http.extract_auth('http://example.com', f)
 
399
        self.assertEqual('http://example.com', url)
 
400
        self.assertEqual(0, len(f.credentials))
 
401
        url = http.extract_auth(
 
402
            'http://user:pass@example.com/bzr/bzr.dev', f)
 
403
        self.assertEqual('http://example.com/bzr/bzr.dev', url)
 
404
        self.assertEqual(1, len(f.credentials))
 
405
        self.assertEqual([None, 'example.com', 'user', 'pass'],
 
406
                         f.credentials[0])
 
407
 
 
408
 
375
409
class TestHttpTransportUrls(tests.TestCase):
376
410
    """Test the http urls."""
377
411
 
378
 
    scenarios = vary_by_http_client_implementation()
379
 
 
380
412
    def test_abs_url(self):
381
413
        """Construction of absolute http URLs"""
382
 
        t = self._transport('http://example.com/bzr/bzr.dev/')
 
414
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
383
415
        eq = self.assertEqualDiff
384
 
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
385
 
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
386
 
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
 
416
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
 
417
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
 
418
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
387
419
        eq(t.abspath('.bzr/1//2/./3'),
388
 
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
 
420
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
389
421
 
390
422
    def test_invalid_http_urls(self):
391
423
        """Trap invalid construction of urls"""
392
 
        self._transport('http://example.com/bzr/bzr.dev/')
393
 
        self.assertRaises(urlutils.InvalidURL,
 
424
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
425
        self.assertRaises(errors.InvalidURL,
394
426
                          self._transport,
395
 
                          'http://example.com:port/bzr/bzr.dev/')
 
427
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
396
428
 
397
429
    def test_http_root_urls(self):
398
430
        """Construction of URLs from server root"""
399
 
        t = self._transport('http://example.com/')
 
431
        t = self._transport('http://bzr.ozlabs.org/')
400
432
        eq = self.assertEqualDiff
401
433
        eq(t.abspath('.bzr/tree-version'),
402
 
           'http://example.com/.bzr/tree-version')
 
434
           'http://bzr.ozlabs.org/.bzr/tree-version')
403
435
 
404
436
    def test_http_impl_urls(self):
405
437
        """There are servers which ask for particular clients to connect"""
407
439
        server.start_server()
408
440
        try:
409
441
            url = server.get_url()
410
 
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
 
442
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
411
443
        finally:
412
444
            server.stop_server()
413
445
 
414
446
 
 
447
class TestHttps_pycurl(TestWithTransport_pycurl, tests.TestCase):
 
448
 
 
449
    # TODO: This should really be moved into another pycurl
 
450
    # specific test. When https tests will be implemented, take
 
451
    # this one into account.
 
452
    def test_pycurl_without_https_support(self):
 
453
        """Test that pycurl without SSL do not fail with a traceback.
 
454
 
 
455
        For the purpose of the test, we force pycurl to ignore
 
456
        https by supplying a fake version_info that do not
 
457
        support it.
 
458
        """
 
459
        self.requireFeature(features.pycurl)
 
460
        # Import the module locally now that we now it's available.
 
461
        pycurl = features.pycurl.module
 
462
 
 
463
        self.overrideAttr(pycurl, 'version_info',
 
464
                          # Fake the pycurl version_info This was taken from
 
465
                          # a windows pycurl without SSL (thanks to bialix)
 
466
                          lambda : (2,
 
467
                                    '7.13.2',
 
468
                                    462082,
 
469
                                    'i386-pc-win32',
 
470
                                    2576,
 
471
                                    None,
 
472
                                    0,
 
473
                                    None,
 
474
                                    ('ftp', 'gopher', 'telnet',
 
475
                                     'dict', 'ldap', 'http', 'file'),
 
476
                                    None,
 
477
                                    0,
 
478
                                    None))
 
479
        self.assertRaises(errors.DependencyNotPresent, self._transport,
 
480
                          'https://launchpad.net')
 
481
 
 
482
 
415
483
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
416
484
    """Test the http connections."""
417
485
 
418
 
    scenarios = multiply_scenarios(
419
 
        vary_by_http_client_implementation(),
420
 
        vary_by_http_protocol_version(),
421
 
        )
422
 
 
423
486
    def setUp(self):
424
 
        super(TestHTTPConnections, self).setUp()
 
487
        http_utils.TestCaseWithWebserver.setUp(self)
425
488
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
426
489
                        transport=self.get_transport())
427
490
 
428
491
    def test_http_has(self):
429
492
        server = self.get_readonly_server()
430
 
        t = self.get_readonly_transport()
 
493
        t = self._transport(server.get_url())
431
494
        self.assertEqual(t.has('foo/bar'), True)
432
495
        self.assertEqual(len(server.logs), 1)
433
496
        self.assertContainsRe(server.logs[0],
434
 
                              r'"HEAD /foo/bar HTTP/1.." (200|302) - "-" "Breezy/')
 
497
            r'"HEAD /foo/bar HTTP/1.." (200|302) - "-" "bzr/')
435
498
 
436
499
    def test_http_has_not_found(self):
437
500
        server = self.get_readonly_server()
438
 
        t = self.get_readonly_transport()
 
501
        t = self._transport(server.get_url())
439
502
        self.assertEqual(t.has('not-found'), False)
440
503
        self.assertContainsRe(server.logs[1],
441
 
                              r'"HEAD /not-found HTTP/1.." 404 - "-" "Breezy/')
 
504
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
442
505
 
443
506
    def test_http_get(self):
444
507
        server = self.get_readonly_server()
445
 
        t = self.get_readonly_transport()
 
508
        t = self._transport(server.get_url())
446
509
        fp = t.get('foo/bar')
447
510
        self.assertEqualDiff(
448
511
            fp.read(),
449
 
            b'contents of foo/bar\n')
 
512
            'contents of foo/bar\n')
450
513
        self.assertEqual(len(server.logs), 1)
451
514
        self.assertTrue(server.logs[0].find(
452
 
            '"GET /foo/bar HTTP/1.1" 200 - "-" "Breezy/%s'
453
 
            % breezy.__version__) > -1)
 
515
            '"GET /foo/bar HTTP/1.1" 200 - "-" "bzr/%s'
 
516
            % bzrlib.__version__) > -1)
454
517
 
455
518
    def test_has_on_bogus_host(self):
456
519
        # Get a free address and don't 'accept' on it, so that we
470
533
class TestHttpTransportRegistration(tests.TestCase):
471
534
    """Test registrations of various http implementations"""
472
535
 
473
 
    scenarios = vary_by_http_client_implementation()
474
 
 
475
536
    def test_http_registered(self):
476
 
        t = transport.get_transport_from_url(
477
 
            '%s://foo.com/' % self._url_protocol)
 
537
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
478
538
        self.assertIsInstance(t, transport.Transport)
479
539
        self.assertIsInstance(t, self._transport)
480
540
 
481
541
 
482
542
class TestPost(tests.TestCase):
483
543
 
484
 
    scenarios = multiply_scenarios(
485
 
        vary_by_http_client_implementation(),
486
 
        vary_by_http_protocol_version(),
487
 
        )
488
 
 
489
544
    def test_post_body_is_received(self):
490
 
        server = RecordingServer(expect_body_tail=b'end-of-body',
491
 
                                 scheme=self._url_protocol)
 
545
        server = RecordingServer(expect_body_tail='end-of-body',
 
546
            scheme=self._qualified_prefix)
492
547
        self.start_server(server)
493
548
        url = server.get_url()
494
 
        # FIXME: needs a cleanup -- vila 20100611
495
 
        http_transport = transport.get_transport_from_url(url)
496
 
        code, response = http_transport._post(b'abc def end-of-body')
497
 
        self.assertTrue(
498
 
            server.received_bytes.startswith(b'POST /.bzr/smart HTTP/1.'))
499
 
        self.assertTrue(
500
 
            b'content-length: 19\r' in server.received_bytes.lower())
501
 
        self.assertTrue(b'content-type: application/octet-stream\r'
502
 
                        in server.received_bytes.lower())
 
549
        http_transport = self._transport(url)
 
550
        code, response = http_transport._post('abc def end-of-body')
 
551
        self.assertTrue(
 
552
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
 
553
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
503
554
        # The transport should not be assuming that the server can accept
504
555
        # chunked encoding the first time it connects, because HTTP/1.1, so we
505
556
        # check for the literal string.
506
557
        self.assertTrue(
507
 
            server.received_bytes.endswith(b'\r\n\r\nabc def end-of-body'))
 
558
            server.received_bytes.endswith('\r\n\r\nabc def end-of-body'))
508
559
 
509
560
 
510
561
class TestRangeHeader(tests.TestCase):
511
562
    """Test range_header method"""
512
563
 
513
564
    def check_header(self, value, ranges=[], tail=0):
514
 
        offsets = [(start, end - start + 1) for start, end in ranges]
 
565
        offsets = [ (start, end - start + 1) for start, end in ranges]
515
566
        coalesce = transport.Transport._coalesce_offsets
516
567
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
517
 
        range_header = http.HttpTransport._range_header
 
568
        range_header = http.HttpTransportBase._range_header
518
569
        self.assertEqual(value, range_header(coalesced, tail))
519
570
 
520
571
    def test_range_header_single(self):
521
 
        self.check_header('0-9', ranges=[(0, 9)])
522
 
        self.check_header('100-109', ranges=[(100, 109)])
 
572
        self.check_header('0-9', ranges=[(0,9)])
 
573
        self.check_header('100-109', ranges=[(100,109)])
523
574
 
524
575
    def test_range_header_tail(self):
525
576
        self.check_header('-10', tail=10)
527
578
 
528
579
    def test_range_header_multi(self):
529
580
        self.check_header('0-9,100-200,300-5000',
530
 
                          ranges=[(0, 9), (100, 200), (300, 5000)])
 
581
                          ranges=[(0,9), (100, 200), (300,5000)])
531
582
 
532
583
    def test_range_header_mixed(self):
533
584
        self.check_header('0-9,300-5000,-50',
534
 
                          ranges=[(0, 9), (300, 5000)],
 
585
                          ranges=[(0,9), (300,5000)],
535
586
                          tail=50)
536
587
 
537
588
 
541
592
    Daughter classes are expected to override _req_handler_class
542
593
    """
543
594
 
544
 
    scenarios = multiply_scenarios(
545
 
        vary_by_http_client_implementation(),
546
 
        vary_by_http_protocol_version(),
547
 
        )
548
 
 
549
595
    # Provide a useful default
550
596
    _req_handler_class = http_server.TestingHTTPRequestHandler
551
597
 
552
598
    def create_transport_readonly_server(self):
553
 
        server = http_server.HttpServer(self._req_handler_class,
554
 
                                        protocol_version=self._protocol_version)
555
 
        server._url_protocol = self._url_protocol
556
 
        return server
 
599
        return http_server.HttpServer(self._req_handler_class,
 
600
                                      protocol_version=self._protocol_version)
 
601
 
 
602
    def _testing_pycurl(self):
 
603
        # TODO: This is duplicated for lots of the classes in this file
 
604
        return (features.pycurl.available()
 
605
                and self._transport == PyCurlTransport)
557
606
 
558
607
 
559
608
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
560
609
    """Whatever request comes in, close the connection"""
561
610
 
562
 
    def _handle_one_request(self):
 
611
    def handle_one_request(self):
563
612
        """Handle a single HTTP request, by abruptly closing the connection"""
564
613
        self.close_connection = 1
565
614
 
570
619
    _req_handler_class = WallRequestHandler
571
620
 
572
621
    def test_http_has(self):
573
 
        t = self.get_readonly_transport()
 
622
        server = self.get_readonly_server()
 
623
        t = self._transport(server.get_url())
574
624
        # Unfortunately httplib (see HTTPResponse._read_status
575
625
        # for details) make no distinction between a closed
576
626
        # socket and badly formatted status line, so we can't
577
627
        # just test for ConnectionError, we have to test
578
 
        # InvalidHttpResponse too.
579
 
        self.assertRaises((errors.ConnectionError,
580
 
                           errors.InvalidHttpResponse),
 
628
        # InvalidHttpResponse too. And pycurl may raise ConnectionReset
 
629
        # instead of ConnectionError too.
 
630
        self.assertRaises(( errors.ConnectionError, errors.ConnectionReset,
 
631
                            errors.InvalidHttpResponse),
581
632
                          t.has, 'foo/bar')
582
633
 
583
634
    def test_http_get(self):
584
 
        t = self.get_readonly_transport()
 
635
        server = self.get_readonly_server()
 
636
        t = self._transport(server.get_url())
585
637
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
586
638
                           errors.InvalidHttpResponse),
587
639
                          t.get, 'foo/bar')
603
655
 
604
656
    _req_handler_class = BadStatusRequestHandler
605
657
 
606
 
    def setUp(self):
607
 
        super(TestBadStatusServer, self).setUp()
608
 
        # See https://bugs.launchpad.net/bzr/+bug/1451448 for details.
609
 
        # TD;LR: Running both a TCP client and server in the same process and
610
 
        # thread uncovers a race in python. The fix is to run the server in a
611
 
        # different process. Trying to fix yet another race here is not worth
612
 
        # the effort. -- vila 2015-09-06
613
 
        if 'HTTP/1.0' in self.id():
614
 
            raise tests.TestSkipped(
615
 
                'Client/Server in the same process and thread can hang')
616
 
 
617
658
    def test_http_has(self):
618
 
        t = self.get_readonly_transport()
619
 
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
620
 
                           errors.InvalidHttpResponse),
621
 
                          t.has, 'foo/bar')
 
659
        server = self.get_readonly_server()
 
660
        t = self._transport(server.get_url())
 
661
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
622
662
 
623
663
    def test_http_get(self):
624
 
        t = self.get_readonly_transport()
625
 
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
626
 
                           errors.InvalidHttpResponse),
627
 
                          t.get, 'foo/bar')
 
664
        server = self.get_readonly_server()
 
665
        t = self._transport(server.get_url())
 
666
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
628
667
 
629
668
 
630
669
class InvalidStatusRequestHandler(http_server.TestingHTTPRequestHandler):
633
672
    def parse_request(self):
634
673
        """Fakes handling a single HTTP request, returns a bad status"""
635
674
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
636
 
        self.wfile.write(b"Invalid status line\r\n")
637
 
        # If we don't close the connection pycurl will hang. Since this is a
638
 
        # stress test we don't *have* to respect the protocol, but we don't
639
 
        # have to sabotage it too much either.
640
 
        self.close_connection = True
 
675
        self.wfile.write("Invalid status line\r\n")
641
676
        return False
642
677
 
643
678
 
649
684
 
650
685
    _req_handler_class = InvalidStatusRequestHandler
651
686
 
 
687
    def test_http_has(self):
 
688
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
 
689
            raise tests.KnownFailure(
 
690
                'pycurl hangs if the server send back garbage')
 
691
        super(TestInvalidStatusServer, self).test_http_has()
 
692
 
 
693
    def test_http_get(self):
 
694
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
 
695
            raise tests.KnownFailure(
 
696
                'pycurl hangs if the server send back garbage')
 
697
        super(TestInvalidStatusServer, self).test_http_get()
 
698
 
652
699
 
653
700
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
654
701
    """Whatever request comes in, returns a bad protocol version"""
658
705
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
659
706
        # Returns an invalid protocol version, but curl just
660
707
        # ignores it and those cannot be tested.
661
 
        self.wfile.write(b"%s %d %s\r\n" % (
662
 
            b'HTTP/0.0', 404, b'Look at my protocol version'))
 
708
        self.wfile.write("%s %d %s\r\n" % ('HTTP/0.0',
 
709
                                           404,
 
710
                                           'Look at my protocol version'))
663
711
        return False
664
712
 
665
713
 
668
716
 
669
717
    _req_handler_class = BadProtocolRequestHandler
670
718
 
 
719
    def setUp(self):
 
720
        if self._testing_pycurl():
 
721
            raise tests.TestNotApplicable(
 
722
                "pycurl doesn't check the protocol version")
 
723
        super(TestBadProtocolServer, self).setUp()
 
724
 
671
725
    def test_http_has(self):
672
 
        t = self.get_readonly_transport()
 
726
        server = self.get_readonly_server()
 
727
        t = self._transport(server.get_url())
673
728
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
674
729
 
675
730
    def test_http_get(self):
676
 
        t = self.get_readonly_transport()
 
731
        server = self.get_readonly_server()
 
732
        t = self._transport(server.get_url())
677
733
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
678
734
 
679
735
 
693
749
    _req_handler_class = ForbiddenRequestHandler
694
750
 
695
751
    def test_http_has(self):
696
 
        t = self.get_readonly_transport()
 
752
        server = self.get_readonly_server()
 
753
        t = self._transport(server.get_url())
697
754
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
698
755
 
699
756
    def test_http_get(self):
700
 
        t = self.get_readonly_transport()
 
757
        server = self.get_readonly_server()
 
758
        t = self._transport(server.get_url())
701
759
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
702
760
 
703
761
 
705
763
 
706
764
    def test_create(self):
707
765
        server = RecordingServer(expect_body_tail=None)
708
 
        self.assertEqual(b'', server.received_bytes)
 
766
        self.assertEqual('', server.received_bytes)
709
767
        self.assertEqual(None, server.host)
710
768
        self.assertEqual(None, server.port)
711
769
 
721
779
        self.assertEqual(None, server.port)
722
780
 
723
781
    def test_send_receive_bytes(self):
724
 
        server = RecordingServer(expect_body_tail=b'c', scheme='http')
 
782
        server = RecordingServer(expect_body_tail='c', scheme='http')
725
783
        self.start_server(server)
726
784
        sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
727
785
        sock.connect((server.host, server.port))
728
 
        sock.sendall(b'abc')
729
 
        self.assertEqual(b'HTTP/1.1 200 OK\r\n',
 
786
        sock.sendall('abc')
 
787
        self.assertEqual('HTTP/1.1 200 OK\r\n',
730
788
                         osutils.recv_all(sock, 4096))
731
 
        self.assertEqual(b'abc', server.received_bytes)
 
789
        self.assertEqual('abc', server.received_bytes)
732
790
 
733
791
 
734
792
class TestRangeRequestServer(TestSpecificRequestHandler):
739
797
 
740
798
    def setUp(self):
741
799
        super(TestRangeRequestServer, self).setUp()
742
 
        self.build_tree_contents([('a', b'0123456789')],)
 
800
        self.build_tree_contents([('a', '0123456789')],)
743
801
 
744
802
    def test_readv(self):
745
 
        t = self.get_readonly_transport()
 
803
        server = self.get_readonly_server()
 
804
        t = self._transport(server.get_url())
746
805
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
747
 
        self.assertEqual(l[0], (0, b'0'))
748
 
        self.assertEqual(l[1], (1, b'1'))
749
 
        self.assertEqual(l[2], (3, b'34'))
750
 
        self.assertEqual(l[3], (9, b'9'))
 
806
        self.assertEqual(l[0], (0, '0'))
 
807
        self.assertEqual(l[1], (1, '1'))
 
808
        self.assertEqual(l[2], (3, '34'))
 
809
        self.assertEqual(l[3], (9, '9'))
751
810
 
752
811
    def test_readv_out_of_order(self):
753
 
        t = self.get_readonly_transport()
 
812
        server = self.get_readonly_server()
 
813
        t = self._transport(server.get_url())
754
814
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
755
 
        self.assertEqual(l[0], (1, b'1'))
756
 
        self.assertEqual(l[1], (9, b'9'))
757
 
        self.assertEqual(l[2], (0, b'0'))
758
 
        self.assertEqual(l[3], (3, b'34'))
 
815
        self.assertEqual(l[0], (1, '1'))
 
816
        self.assertEqual(l[1], (9, '9'))
 
817
        self.assertEqual(l[2], (0, '0'))
 
818
        self.assertEqual(l[3], (3, '34'))
759
819
 
760
820
    def test_readv_invalid_ranges(self):
761
 
        t = self.get_readonly_transport()
 
821
        server = self.get_readonly_server()
 
822
        t = self._transport(server.get_url())
762
823
 
763
824
        # This is intentionally reading off the end of the file
764
825
        # since we are sure that it cannot get there
765
826
        self.assertListRaises((errors.InvalidRange, errors.ShortReadvError,),
766
 
                              t.readv, 'a', [(1, 1), (8, 10)])
 
827
                              t.readv, 'a', [(1,1), (8,10)])
767
828
 
768
829
        # This is trying to seek past the end of the file, it should
769
830
        # also raise a special error
770
831
        self.assertListRaises((errors.InvalidRange, errors.ShortReadvError,),
771
 
                              t.readv, 'a', [(12, 2)])
 
832
                              t.readv, 'a', [(12,2)])
772
833
 
773
834
    def test_readv_multiple_get_requests(self):
774
835
        server = self.get_readonly_server()
775
 
        t = self.get_readonly_transport()
 
836
        t = self._transport(server.get_url())
776
837
        # force transport to issue multiple requests
777
838
        t._max_readv_combine = 1
778
839
        t._max_get_ranges = 1
779
840
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
780
 
        self.assertEqual(l[0], (0, b'0'))
781
 
        self.assertEqual(l[1], (1, b'1'))
782
 
        self.assertEqual(l[2], (3, b'34'))
783
 
        self.assertEqual(l[3], (9, b'9'))
 
841
        self.assertEqual(l[0], (0, '0'))
 
842
        self.assertEqual(l[1], (1, '1'))
 
843
        self.assertEqual(l[2], (3, '34'))
 
844
        self.assertEqual(l[3], (9, '9'))
784
845
        # The server should have issued 4 requests
785
846
        self.assertEqual(4, server.GET_request_nb)
786
847
 
787
848
    def test_readv_get_max_size(self):
788
849
        server = self.get_readonly_server()
789
 
        t = self.get_readonly_transport()
 
850
        t = self._transport(server.get_url())
790
851
        # force transport to issue multiple requests by limiting the number of
791
852
        # bytes by request. Note that this apply to coalesced offsets only, a
792
853
        # single range will keep its size even if bigger than the limit.
793
854
        t._get_max_size = 2
794
855
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
795
 
        self.assertEqual(l[0], (0, b'0'))
796
 
        self.assertEqual(l[1], (1, b'1'))
797
 
        self.assertEqual(l[2], (2, b'2345'))
798
 
        self.assertEqual(l[3], (6, b'6789'))
 
856
        self.assertEqual(l[0], (0, '0'))
 
857
        self.assertEqual(l[1], (1, '1'))
 
858
        self.assertEqual(l[2], (2, '2345'))
 
859
        self.assertEqual(l[3], (6, '6789'))
799
860
        # The server should have issued 3 requests
800
861
        self.assertEqual(3, server.GET_request_nb)
801
862
 
802
863
    def test_complete_readv_leave_pipe_clean(self):
803
864
        server = self.get_readonly_server()
804
 
        t = self.get_readonly_transport()
 
865
        t = self._transport(server.get_url())
805
866
        # force transport to issue multiple requests
806
867
        t._get_max_size = 2
807
 
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
868
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
808
869
        # The server should have issued 3 requests
809
870
        self.assertEqual(3, server.GET_request_nb)
810
 
        self.assertEqual(b'0123456789', t.get_bytes('a'))
 
871
        self.assertEqual('0123456789', t.get_bytes('a'))
811
872
        self.assertEqual(4, server.GET_request_nb)
812
873
 
813
874
    def test_incomplete_readv_leave_pipe_clean(self):
814
875
        server = self.get_readonly_server()
815
 
        t = self.get_readonly_transport()
 
876
        t = self._transport(server.get_url())
816
877
        # force transport to issue multiple requests
817
878
        t._get_max_size = 2
818
879
        # Don't collapse readv results into a list so that we leave unread
819
880
        # bytes on the socket
820
881
        ireadv = iter(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
821
 
        self.assertEqual((0, b'0'), next(ireadv))
 
882
        self.assertEqual((0, '0'), ireadv.next())
822
883
        # The server should have issued one request so far
823
884
        self.assertEqual(1, server.GET_request_nb)
824
 
        self.assertEqual(b'0123456789', t.get_bytes('a'))
 
885
        self.assertEqual('0123456789', t.get_bytes('a'))
825
886
        # get_bytes issued an additional request, the readv pending ones are
826
887
        # lost
827
888
        self.assertEqual(2, server.GET_request_nb)
871
932
        # Update the statistics
872
933
        self.server.test_case_server.GET_request_nb += 1
873
934
        # Just bypass the range handling done by TestingHTTPRequestHandler
874
 
        return SimpleHTTPRequestHandler.do_GET(self)
 
935
        return SimpleHTTPServer.SimpleHTTPRequestHandler.do_GET(self)
875
936
 
876
937
 
877
938
class TestNoRangeRequestServer(TestRangeRequestServer):
881
942
 
882
943
 
883
944
class MultipleRangeWithoutContentLengthRequestHandler(
884
 
        http_server.TestingHTTPRequestHandler):
 
945
    http_server.TestingHTTPRequestHandler):
885
946
    """Reply to multiple range requests without content length header."""
886
947
 
887
948
    def get_multiple_ranges(self, file, file_size, ranges):
888
949
        self.send_response(206)
889
950
        self.send_header('Accept-Ranges', 'bytes')
890
 
        # XXX: this is strange; the 'random' name below seems undefined and
891
 
        # yet the tests pass -- mbp 2010-10-11 bug 658773
892
 
        boundary = "%d" % random.randint(0, 0x7FFFFFFF)
 
951
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
893
952
        self.send_header("Content-Type",
894
953
                         "multipart/byteranges; boundary=%s" % boundary)
895
954
        self.end_headers()
896
955
        for (start, end) in ranges:
897
 
            self.wfile.write(b"--%s\r\n" % boundary.encode('ascii'))
 
956
            self.wfile.write("--%s\r\n" % boundary)
898
957
            self.send_header("Content-type", 'application/octet-stream')
899
958
            self.send_header("Content-Range", "bytes %d-%d/%d" % (start,
900
959
                                                                  end,
902
961
            self.end_headers()
903
962
            self.send_range_content(file, start, end - start + 1)
904
963
        # Final boundary
905
 
        self.wfile.write(b"--%s\r\n" % boundary)
 
964
        self.wfile.write("--%s\r\n" % boundary)
906
965
 
907
966
 
908
967
class TestMultipleRangeWithoutContentLengthServer(TestRangeRequestServer):
911
970
 
912
971
 
913
972
class TruncatedMultipleRangeRequestHandler(
914
 
        http_server.TestingHTTPRequestHandler):
 
973
    http_server.TestingHTTPRequestHandler):
915
974
    """Reply to multiple range requests truncating the last ones.
916
975
 
917
976
    This server generates responses whose Content-Length describes all the
927
986
        boundary = 'tagada'
928
987
        self.send_header('Content-Type',
929
988
                         'multipart/byteranges; boundary=%s' % boundary)
930
 
        boundary_line = b'--%s\r\n' % boundary.encode('ascii')
 
989
        boundary_line = '--%s\r\n' % boundary
931
990
        # Calculate the Content-Length
932
991
        content_length = 0
933
992
        for (start, end) in ranges:
936
995
                'Content-type', 'application/octet-stream')
937
996
            content_length += self._header_line_length(
938
997
                'Content-Range', 'bytes %d-%d/%d' % (start, end, file_size))
939
 
            content_length += len('\r\n')  # end headers
940
 
            content_length += end - start  # + 1
 
998
            content_length += len('\r\n') # end headers
 
999
            content_length += end - start # + 1
941
1000
        content_length += len(boundary_line)
942
1001
        self.send_header('Content-length', content_length)
943
1002
        self.end_headers()
956
1015
                return
957
1016
            self.send_range_content(file, start, end - start + 1)
958
1017
            cur += 1
959
 
        # Final boundary
 
1018
        # No final boundary
960
1019
        self.wfile.write(boundary_line)
961
1020
 
962
1021
 
966
1025
 
967
1026
    def setUp(self):
968
1027
        super(TestTruncatedMultipleRangeServer, self).setUp()
969
 
        self.build_tree_contents([('a', b'0123456789')],)
 
1028
        self.build_tree_contents([('a', '0123456789')],)
970
1029
 
971
1030
    def test_readv_with_short_reads(self):
972
1031
        server = self.get_readonly_server()
973
 
        t = self.get_readonly_transport()
 
1032
        t = self._transport(server.get_url())
974
1033
        # Force separate ranges for each offset
975
1034
        t._bytes_to_read_before_seek = 0
976
1035
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
977
 
        self.assertEqual((0, b'0'), next(ireadv))
978
 
        self.assertEqual((2, b'2'), next(ireadv))
979
 
        # Only one request have been issued so far
980
 
        self.assertEqual(1, server.GET_request_nb)
981
 
        self.assertEqual((4, b'45'), next(ireadv))
982
 
        self.assertEqual((9, b'9'), next(ireadv))
983
 
        # We issue 3 requests: two multiple (4 ranges, then 2 ranges) then a
984
 
        # single range.
 
1036
        self.assertEqual((0, '0'), ireadv.next())
 
1037
        self.assertEqual((2, '2'), ireadv.next())
 
1038
        if not self._testing_pycurl():
 
1039
            # Only one request have been issued so far (except for pycurl that
 
1040
            # try to read the whole response at once)
 
1041
            self.assertEqual(1, server.GET_request_nb)
 
1042
        self.assertEqual((4, '45'), ireadv.next())
 
1043
        self.assertEqual((9, '9'), ireadv.next())
 
1044
        # Both implementations issue 3 requests but:
 
1045
        # - urllib does two multiple (4 ranges, then 2 ranges) then a single
 
1046
        #   range,
 
1047
        # - pycurl does two multiple (4 ranges, 4 ranges) then a single range
985
1048
        self.assertEqual(3, server.GET_request_nb)
986
1049
        # Finally the client have tried a single range request and stays in
987
1050
        # that mode
988
1051
        self.assertEqual('single', t._range_hint)
989
1052
 
990
 
 
991
 
class TruncatedBeforeBoundaryRequestHandler(
992
 
        http_server.TestingHTTPRequestHandler):
993
 
    """Truncation before a boundary, like in bug 198646"""
994
 
 
995
 
    _truncated_ranges = 1
996
 
 
997
 
    def get_multiple_ranges(self, file, file_size, ranges):
998
 
        self.send_response(206)
999
 
        self.send_header('Accept-Ranges', 'bytes')
1000
 
        boundary = 'tagada'
1001
 
        self.send_header('Content-Type',
1002
 
                         'multipart/byteranges; boundary=%s' % boundary)
1003
 
        boundary_line = b'--%s\r\n' % boundary.encode('ascii')
1004
 
        # Calculate the Content-Length
1005
 
        content_length = 0
1006
 
        for (start, end) in ranges:
1007
 
            content_length += len(boundary_line)
1008
 
            content_length += self._header_line_length(
1009
 
                'Content-type', 'application/octet-stream')
1010
 
            content_length += self._header_line_length(
1011
 
                'Content-Range', 'bytes %d-%d/%d' % (start, end, file_size))
1012
 
            content_length += len('\r\n')  # end headers
1013
 
            content_length += end - start  # + 1
1014
 
        content_length += len(boundary_line)
1015
 
        self.send_header('Content-length', content_length)
1016
 
        self.end_headers()
1017
 
 
1018
 
        # Send the multipart body
1019
 
        cur = 0
1020
 
        for (start, end) in ranges:
1021
 
            if cur + self._truncated_ranges >= len(ranges):
1022
 
                # Abruptly ends the response and close the connection
1023
 
                self.close_connection = 1
1024
 
                return
1025
 
            self.wfile.write(boundary_line)
1026
 
            self.send_header('Content-type', 'application/octet-stream')
1027
 
            self.send_header('Content-Range', 'bytes %d-%d/%d'
1028
 
                             % (start, end, file_size))
1029
 
            self.end_headers()
1030
 
            self.send_range_content(file, start, end - start + 1)
1031
 
            cur += 1
1032
 
        # Final boundary
1033
 
        self.wfile.write(boundary_line)
1034
 
 
1035
 
 
1036
 
class TestTruncatedBeforeBoundary(TestSpecificRequestHandler):
1037
 
    """Tests the case of bug 198646, disconnecting before a boundary."""
1038
 
 
1039
 
    _req_handler_class = TruncatedBeforeBoundaryRequestHandler
1040
 
 
1041
 
    def setUp(self):
1042
 
        super(TestTruncatedBeforeBoundary, self).setUp()
1043
 
        self.build_tree_contents([('a', b'0123456789')],)
1044
 
 
1045
 
    def test_readv_with_short_reads(self):
1046
 
        server = self.get_readonly_server()
1047
 
        t = self.get_readonly_transport()
1048
 
        # Force separate ranges for each offset
1049
 
        t._bytes_to_read_before_seek = 0
1050
 
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1051
 
        self.assertEqual((0, b'0'), next(ireadv))
1052
 
        self.assertEqual((2, b'2'), next(ireadv))
1053
 
        self.assertEqual((4, b'45'), next(ireadv))
1054
 
        self.assertEqual((9, b'9'), next(ireadv))
1055
 
 
1056
 
 
1057
1053
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1058
1054
    """Errors out when range specifiers exceed the limit"""
1059
1055
 
1083
1079
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1084
1080
    """Tests readv requests against a server erroring out on too much ranges."""
1085
1081
 
1086
 
    scenarios = multiply_scenarios(
1087
 
        vary_by_http_client_implementation(),
1088
 
        vary_by_http_protocol_version(),
1089
 
        )
1090
 
 
1091
1082
    # Requests with more range specifiers will error out
1092
1083
    range_limit = 3
1093
1084
 
1095
1086
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1096
1087
                                      protocol_version=self._protocol_version)
1097
1088
 
 
1089
    def get_transport(self):
 
1090
        return self._transport(self.get_readonly_server().get_url())
 
1091
 
1098
1092
    def setUp(self):
1099
 
        super(TestLimitedRangeRequestServer, self).setUp()
 
1093
        http_utils.TestCaseWithWebserver.setUp(self)
1100
1094
        # We need to manipulate ranges that correspond to real chunks in the
1101
1095
        # response, so we build a content appropriately.
1102
 
        filler = b''.join([b'abcdefghij' for x in range(102)])
1103
 
        content = b''.join([b'%04d' % v + filler for v in range(16)])
 
1096
        filler = ''.join(['abcdefghij' for x in range(102)])
 
1097
        content = ''.join(['%04d' % v + filler for v in range(16)])
1104
1098
        self.build_tree_contents([('a', content)],)
1105
1099
 
1106
1100
    def test_few_ranges(self):
1107
 
        t = self.get_readonly_transport()
 
1101
        t = self.get_transport()
1108
1102
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1109
 
        self.assertEqual(l[0], (0, b'0000'))
1110
 
        self.assertEqual(l[1], (1024, b'0001'))
 
1103
        self.assertEqual(l[0], (0, '0000'))
 
1104
        self.assertEqual(l[1], (1024, '0001'))
1111
1105
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1112
1106
 
1113
1107
    def test_more_ranges(self):
1114
 
        t = self.get_readonly_transport()
 
1108
        t = self.get_transport()
1115
1109
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1116
 
        self.assertEqual(l[0], (0, b'0000'))
1117
 
        self.assertEqual(l[1], (1024, b'0001'))
1118
 
        self.assertEqual(l[2], (4096, b'0004'))
1119
 
        self.assertEqual(l[3], (8192, b'0008'))
 
1110
        self.assertEqual(l[0], (0, '0000'))
 
1111
        self.assertEqual(l[1], (1024, '0001'))
 
1112
        self.assertEqual(l[2], (4096, '0004'))
 
1113
        self.assertEqual(l[3], (8192, '0008'))
1120
1114
        # The server will refuse to serve the first request (too much ranges),
1121
1115
        # a second request will succeed.
1122
1116
        self.assertEqual(2, self.get_readonly_server().GET_request_nb)
1128
1122
    Only the urllib implementation is tested here.
1129
1123
    """
1130
1124
 
 
1125
    def setUp(self):
 
1126
        tests.TestCase.setUp(self)
 
1127
        self._old_env = {}
 
1128
 
 
1129
    def tearDown(self):
 
1130
        self._restore_env()
 
1131
        tests.TestCase.tearDown(self)
 
1132
 
 
1133
    def _install_env(self, env):
 
1134
        for name, value in env.iteritems():
 
1135
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1136
 
 
1137
    def _restore_env(self):
 
1138
        for name, value in self._old_env.iteritems():
 
1139
            osutils.set_or_unset_env(name, value)
 
1140
 
1131
1141
    def _proxied_request(self):
1132
 
        handler = http.ProxyHandler()
1133
 
        request = http.Request('GET', 'http://baz/buzzle')
 
1142
        handler = _urllib2_wrappers.ProxyHandler()
 
1143
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
1134
1144
        handler.set_proxy(request, 'http')
1135
1145
        return request
1136
1146
 
1137
 
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
1138
 
        handler = http.ProxyHandler()
1139
 
        self.assertEqual(expected,
1140
 
                         handler.evaluate_proxy_bypass(host, no_proxy))
1141
 
 
1142
1147
    def test_empty_user(self):
1143
 
        self.overrideEnv('http_proxy', 'http://bar.com')
1144
 
        request = self._proxied_request()
1145
 
        self.assertFalse('Proxy-authorization' in request.headers)
1146
 
 
1147
 
    def test_user_with_at(self):
1148
 
        self.overrideEnv('http_proxy',
1149
 
                         'http://username@domain:password@proxy_host:1234')
1150
 
        request = self._proxied_request()
1151
 
        self.assertFalse('Proxy-authorization' in request.headers)
 
1148
        self._install_env({'http_proxy': 'http://bar.com'})
 
1149
        request = self._proxied_request()
 
1150
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1152
1151
 
1153
1152
    def test_invalid_proxy(self):
1154
1153
        """A proxy env variable without scheme"""
1155
 
        self.overrideEnv('http_proxy', 'host:1234')
1156
 
        self.assertRaises(urlutils.InvalidURL, self._proxied_request)
1157
 
 
1158
 
    def test_evaluate_proxy_bypass_true(self):
1159
 
        """The host is not proxied"""
1160
 
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
1161
 
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
1162
 
 
1163
 
    def test_evaluate_proxy_bypass_false(self):
1164
 
        """The host is proxied"""
1165
 
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
1166
 
 
1167
 
    def test_evaluate_proxy_bypass_unknown(self):
1168
 
        """The host is not explicitly proxied"""
1169
 
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
1170
 
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
1171
 
 
1172
 
    def test_evaluate_proxy_bypass_empty_entries(self):
1173
 
        """Ignore empty entries"""
1174
 
        self.assertEvaluateProxyBypass(None, 'example.com', '')
1175
 
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
1176
 
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1154
        self._install_env({'http_proxy': 'host:1234'})
 
1155
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1177
1156
 
1178
1157
 
1179
1158
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1185
1164
    to the file names).
1186
1165
    """
1187
1166
 
1188
 
    scenarios = multiply_scenarios(
1189
 
        vary_by_http_client_implementation(),
1190
 
        vary_by_http_protocol_version(),
1191
 
        )
1192
 
 
1193
1167
    # FIXME: We don't have an https server available, so we don't
1194
 
    # test https connections. --vila toolongago
 
1168
    # test https connections.
1195
1169
 
1196
1170
    def setUp(self):
1197
1171
        super(TestProxyHttpServer, self).setUp()
1198
 
        self.transport_secondary_server = http_utils.ProxyServer
1199
 
        self.build_tree_contents([('foo', b'contents of foo\n'),
1200
 
                                  ('foo-proxied', b'proxied contents of foo\n')])
 
1172
        self.build_tree_contents([('foo', 'contents of foo\n'),
 
1173
                                  ('foo-proxied', 'proxied contents of foo\n')])
1201
1174
        # Let's setup some attributes for tests
1202
 
        server = self.get_readonly_server()
1203
 
        self.server_host_port = '%s:%d' % (server.host, server.port)
1204
 
        self.no_proxy_host = self.server_host_port
 
1175
        self.server = self.get_readonly_server()
 
1176
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1177
        if self._testing_pycurl():
 
1178
            # Oh my ! pycurl does not check for the port as part of
 
1179
            # no_proxy :-( So we just test the host part
 
1180
            self.no_proxy_host = self.server.host
 
1181
        else:
 
1182
            self.no_proxy_host = self.proxy_address
1205
1183
        # The secondary server is the proxy
1206
 
        self.proxy_url = self.get_secondary_url()
1207
 
 
1208
 
    def assertProxied(self):
1209
 
        t = self.get_readonly_transport()
1210
 
        self.assertEqual(b'proxied contents of foo\n', t.get('foo').read())
1211
 
 
1212
 
    def assertNotProxied(self):
1213
 
        t = self.get_readonly_transport()
1214
 
        self.assertEqual(b'contents of foo\n', t.get('foo').read())
 
1184
        self.proxy = self.get_secondary_server()
 
1185
        self.proxy_url = self.proxy.get_url()
 
1186
        self._old_env = {}
 
1187
 
 
1188
    def _testing_pycurl(self):
 
1189
        # TODO: This is duplicated for lots of the classes in this file
 
1190
        return (features.pycurl.available()
 
1191
                and self._transport == PyCurlTransport)
 
1192
 
 
1193
    def create_transport_secondary_server(self):
 
1194
        """Creates an http server that will serve files with
 
1195
        '-proxied' appended to their names.
 
1196
        """
 
1197
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
 
1198
 
 
1199
    def _install_env(self, env):
 
1200
        for name, value in env.iteritems():
 
1201
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1202
 
 
1203
    def _restore_env(self):
 
1204
        for name, value in self._old_env.iteritems():
 
1205
            osutils.set_or_unset_env(name, value)
 
1206
 
 
1207
    def proxied_in_env(self, env):
 
1208
        self._install_env(env)
 
1209
        url = self.server.get_url()
 
1210
        t = self._transport(url)
 
1211
        try:
 
1212
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1213
        finally:
 
1214
            self._restore_env()
 
1215
 
 
1216
    def not_proxied_in_env(self, env):
 
1217
        self._install_env(env)
 
1218
        url = self.server.get_url()
 
1219
        t = self._transport(url)
 
1220
        try:
 
1221
            self.assertEqual('contents of foo\n', t.get('foo').read())
 
1222
        finally:
 
1223
            self._restore_env()
1215
1224
 
1216
1225
    def test_http_proxy(self):
1217
 
        self.overrideEnv('http_proxy', self.proxy_url)
1218
 
        self.assertProxied()
 
1226
        self.proxied_in_env({'http_proxy': self.proxy_url})
1219
1227
 
1220
1228
    def test_HTTP_PROXY(self):
1221
 
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
1222
 
        self.assertProxied()
 
1229
        if self._testing_pycurl():
 
1230
            # pycurl does not check HTTP_PROXY for security reasons
 
1231
            # (for use in a CGI context that we do not care
 
1232
            # about. Should we ?)
 
1233
            raise tests.TestNotApplicable(
 
1234
                'pycurl does not check HTTP_PROXY for security reasons')
 
1235
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
1223
1236
 
1224
1237
    def test_all_proxy(self):
1225
 
        self.overrideEnv('all_proxy', self.proxy_url)
1226
 
        self.assertProxied()
 
1238
        self.proxied_in_env({'all_proxy': self.proxy_url})
1227
1239
 
1228
1240
    def test_ALL_PROXY(self):
1229
 
        self.overrideEnv('ALL_PROXY', self.proxy_url)
1230
 
        self.assertProxied()
 
1241
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
1231
1242
 
1232
1243
    def test_http_proxy_with_no_proxy(self):
1233
 
        self.overrideEnv('no_proxy', self.no_proxy_host)
1234
 
        self.overrideEnv('http_proxy', self.proxy_url)
1235
 
        self.assertNotProxied()
 
1244
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
 
1245
                                 'no_proxy': self.no_proxy_host})
1236
1246
 
1237
1247
    def test_HTTP_PROXY_with_NO_PROXY(self):
1238
 
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
1239
 
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
1240
 
        self.assertNotProxied()
 
1248
        if self._testing_pycurl():
 
1249
            raise tests.TestNotApplicable(
 
1250
                'pycurl does not check HTTP_PROXY for security reasons')
 
1251
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
 
1252
                                 'NO_PROXY': self.no_proxy_host})
1241
1253
 
1242
1254
    def test_all_proxy_with_no_proxy(self):
1243
 
        self.overrideEnv('no_proxy', self.no_proxy_host)
1244
 
        self.overrideEnv('all_proxy', self.proxy_url)
1245
 
        self.assertNotProxied()
 
1255
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
 
1256
                                 'no_proxy': self.no_proxy_host})
1246
1257
 
1247
1258
    def test_ALL_PROXY_with_NO_PROXY(self):
1248
 
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
1249
 
        self.overrideEnv('ALL_PROXY', self.proxy_url)
1250
 
        self.assertNotProxied()
 
1259
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
 
1260
                                 'NO_PROXY': self.no_proxy_host})
1251
1261
 
1252
1262
    def test_http_proxy_without_scheme(self):
1253
 
        self.overrideEnv('http_proxy', self.server_host_port)
1254
 
        self.assertRaises(urlutils.InvalidURL, self.assertProxied)
 
1263
        if self._testing_pycurl():
 
1264
            # pycurl *ignores* invalid proxy env variables. If that ever change
 
1265
            # in the future, this test will fail indicating that pycurl do not
 
1266
            # ignore anymore such variables.
 
1267
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1268
        else:
 
1269
            self.assertRaises(errors.InvalidURL,
 
1270
                              self.proxied_in_env,
 
1271
                              {'http_proxy': self.proxy_address})
1255
1272
 
1256
1273
 
1257
1274
class TestRanges(http_utils.TestCaseWithWebserver):
1258
1275
    """Test the Range header in GET methods."""
1259
1276
 
1260
 
    scenarios = multiply_scenarios(
1261
 
        vary_by_http_client_implementation(),
1262
 
        vary_by_http_protocol_version(),
1263
 
        )
1264
 
 
1265
1277
    def setUp(self):
1266
 
        super(TestRanges, self).setUp()
1267
 
        self.build_tree_contents([('a', b'0123456789')],)
 
1278
        http_utils.TestCaseWithWebserver.setUp(self)
 
1279
        self.build_tree_contents([('a', '0123456789')],)
 
1280
        server = self.get_readonly_server()
 
1281
        self.transport = self._transport(server.get_url())
1268
1282
 
1269
1283
    def create_transport_readonly_server(self):
1270
1284
        return http_server.HttpServer(protocol_version=self._protocol_version)
1271
1285
 
1272
1286
    def _file_contents(self, relpath, ranges):
1273
 
        t = self.get_readonly_transport()
1274
 
        offsets = [(start, end - start + 1) for start, end in ranges]
1275
 
        coalesce = t._coalesce_offsets
 
1287
        offsets = [ (start, end - start + 1) for start, end in ranges]
 
1288
        coalesce = self.transport._coalesce_offsets
1276
1289
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1277
 
        code, data = t._get(relpath, coalesced)
1278
 
        self.assertTrue(code in (200, 206), '_get returns: %d' % code)
 
1290
        code, data = self.transport._get(relpath, coalesced)
 
1291
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1279
1292
        for start, end in ranges:
1280
1293
            data.seek(start)
1281
1294
            yield data.read(end - start + 1)
1282
1295
 
1283
1296
    def _file_tail(self, relpath, tail_amount):
1284
 
        t = self.get_readonly_transport()
1285
 
        code, data = t._get(relpath, [], tail_amount)
1286
 
        self.assertTrue(code in (200, 206), '_get returns: %d' % code)
 
1297
        code, data = self.transport._get(relpath, [], tail_amount)
 
1298
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1287
1299
        data.seek(-tail_amount, 2)
1288
1300
        return data.read(tail_amount)
1289
1301
 
1290
1302
    def test_range_header(self):
1291
1303
        # Valid ranges
1292
 
        self.assertEqual(
1293
 
            [b'0', b'234'], list(self._file_contents('a', [(0, 0), (2, 4)])))
 
1304
        map(self.assertEqual,['0', '234'],
 
1305
            list(self._file_contents('a', [(0,0), (2,4)])),)
1294
1306
 
1295
1307
    def test_range_header_tail(self):
1296
 
        self.assertEqual(b'789', self._file_tail('a', 3))
 
1308
        self.assertEqual('789', self._file_tail('a', 3))
1297
1309
 
1298
1310
    def test_syntactically_invalid_range_header(self):
1299
1311
        self.assertListRaises(errors.InvalidHttpRange,
1300
 
                              self._file_contents, 'a', [(4, 3)])
 
1312
                          self._file_contents, 'a', [(4, 3)])
1301
1313
 
1302
1314
    def test_semantically_invalid_range_header(self):
1303
1315
        self.assertListRaises(errors.InvalidHttpRange,
1304
 
                              self._file_contents, 'a', [(42, 128)])
 
1316
                          self._file_contents, 'a', [(42, 128)])
1305
1317
 
1306
1318
 
1307
1319
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1308
1320
    """Test redirection between http servers."""
1309
1321
 
1310
 
    scenarios = multiply_scenarios(
1311
 
        vary_by_http_client_implementation(),
1312
 
        vary_by_http_protocol_version(),
1313
 
        )
 
1322
    def create_transport_secondary_server(self):
 
1323
        """Create the secondary server redirecting to the primary server"""
 
1324
        new = self.get_readonly_server()
 
1325
 
 
1326
        redirecting = http_utils.HTTPServerRedirecting(
 
1327
            protocol_version=self._protocol_version)
 
1328
        redirecting.redirect_to(new.host, new.port)
 
1329
        return redirecting
1314
1330
 
1315
1331
    def setUp(self):
1316
1332
        super(TestHTTPRedirections, self).setUp()
1317
 
        self.build_tree_contents([('a', b'0123456789'),
 
1333
        self.build_tree_contents([('a', '0123456789'),
1318
1334
                                  ('bundle',
1319
 
                                   b'# Bazaar revision bundle v0.9\n#\n')
 
1335
                                  '# Bazaar revision bundle v0.9\n#\n')
1320
1336
                                  ],)
 
1337
        # The requests to the old server will be redirected to the new server
 
1338
        self.old_transport = self._transport(self.old_server.get_url())
1321
1339
 
1322
1340
    def test_redirected(self):
1323
 
        self.assertRaises(errors.RedirectRequested,
1324
 
                          self.get_old_transport().get, 'a')
1325
 
        self.assertEqual(
1326
 
            b'0123456789',
1327
 
            self.get_new_transport().get('a').read())
1328
 
 
1329
 
 
1330
 
class RedirectedRequest(http.Request):
 
1341
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
 
1342
        t = self._transport(self.new_server.get_url())
 
1343
        self.assertEqual('0123456789', t.get('a').read())
 
1344
 
 
1345
    def test_read_redirected_bundle_from_url(self):
 
1346
        from bzrlib.bundle import read_bundle_from_url
 
1347
        url = self.old_transport.abspath('bundle')
 
1348
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
 
1349
                read_bundle_from_url, url)
 
1350
        # If read_bundle_from_url was successful we get an empty bundle
 
1351
        self.assertEqual([], bundle.revisions)
 
1352
 
 
1353
 
 
1354
class RedirectedRequest(_urllib2_wrappers.Request):
1331
1355
    """Request following redirections. """
1332
1356
 
1333
 
    init_orig = http.Request.__init__
 
1357
    init_orig = _urllib2_wrappers.Request.__init__
1334
1358
 
1335
1359
    def __init__(self, method, url, *args, **kwargs):
1336
1360
        """Constructor.
1337
1361
 
1338
1362
        """
1339
1363
        # Since the tests using this class will replace
1340
 
        # http.Request, we can't just call the base class __init__
 
1364
        # _urllib2_wrappers.Request, we can't just call the base class __init__
1341
1365
        # or we'll loop.
1342
1366
        RedirectedRequest.init_orig(self, method, url, *args, **kwargs)
1343
1367
        self.follow_redirections = True
1344
1368
 
1345
1369
 
1346
1370
def install_redirected_request(test):
1347
 
    test.overrideAttr(http, 'Request', RedirectedRequest)
1348
 
 
1349
 
 
1350
 
def cleanup_http_redirection_connections(test):
1351
 
    # Some sockets are opened but never seen by _urllib, so we trap them at
1352
 
    # the http level to be able to clean them up.
1353
 
    def socket_disconnect(sock):
1354
 
        try:
1355
 
            sock.shutdown(socket.SHUT_RDWR)
1356
 
            sock.close()
1357
 
        except socket.error:
1358
 
            pass
1359
 
 
1360
 
    def connect(connection):
1361
 
        test.http_connect_orig(connection)
1362
 
        test.addCleanup(socket_disconnect, connection.sock)
1363
 
    test.http_connect_orig = test.overrideAttr(
1364
 
        http.HTTPConnection, 'connect', connect)
1365
 
 
1366
 
    def connect(connection):
1367
 
        test.https_connect_orig(connection)
1368
 
        test.addCleanup(socket_disconnect, connection.sock)
1369
 
    test.https_connect_orig = test.overrideAttr(
1370
 
        http.HTTPSConnection, 'connect', connect)
 
1371
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1371
1372
 
1372
1373
 
1373
1374
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1375
1376
 
1376
1377
    http implementations do not redirect silently anymore (they
1377
1378
    do not redirect at all in fact). The mechanism is still in
1378
 
    place at the http.Request level and these tests
 
1379
    place at the _urllib2_wrappers.Request level and these tests
1379
1380
    exercise it.
 
1381
 
 
1382
    For the pycurl implementation
 
1383
    the redirection have been deleted as we may deprecate pycurl
 
1384
    and I have no place to keep a working implementation.
 
1385
    -- vila 20070212
1380
1386
    """
1381
1387
 
1382
 
    scenarios = multiply_scenarios(
1383
 
        vary_by_http_client_implementation(),
1384
 
        vary_by_http_protocol_version(),
1385
 
        )
1386
 
 
1387
1388
    def setUp(self):
 
1389
        if (features.pycurl.available()
 
1390
            and self._transport == PyCurlTransport):
 
1391
            raise tests.TestNotApplicable(
 
1392
                "pycurl doesn't redirect silently annymore")
1388
1393
        super(TestHTTPSilentRedirections, self).setUp()
1389
1394
        install_redirected_request(self)
1390
 
        cleanup_http_redirection_connections(self)
1391
 
        self.build_tree_contents([('a', b'a'),
 
1395
        self.build_tree_contents([('a','a'),
1392
1396
                                  ('1/',),
1393
 
                                  ('1/a', b'redirected once'),
 
1397
                                  ('1/a', 'redirected once'),
1394
1398
                                  ('2/',),
1395
 
                                  ('2/a', b'redirected twice'),
 
1399
                                  ('2/a', 'redirected twice'),
1396
1400
                                  ('3/',),
1397
 
                                  ('3/a', b'redirected thrice'),
 
1401
                                  ('3/a', 'redirected thrice'),
1398
1402
                                  ('4/',),
1399
 
                                  ('4/a', b'redirected 4 times'),
 
1403
                                  ('4/a', 'redirected 4 times'),
1400
1404
                                  ('5/',),
1401
 
                                  ('5/a', b'redirected 5 times'),
 
1405
                                  ('5/a', 'redirected 5 times'),
1402
1406
                                  ],)
1403
1407
 
 
1408
        self.old_transport = self._transport(self.old_server.get_url())
 
1409
 
 
1410
    def create_transport_secondary_server(self):
 
1411
        """Create the secondary server, redirections are defined in the tests"""
 
1412
        return http_utils.HTTPServerRedirecting(
 
1413
            protocol_version=self._protocol_version)
 
1414
 
1404
1415
    def test_one_redirection(self):
1405
 
        t = self.get_old_transport()
 
1416
        t = self.old_transport
 
1417
 
 
1418
        req = RedirectedRequest('GET', t.abspath('a'))
1406
1419
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1407
1420
                                       self.new_server.port)
1408
1421
        self.old_server.redirections = \
1409
 
            [('(.*)', r'%s/1\1' % (new_prefix), 301), ]
1410
 
        self.assertEqual(
1411
 
            b'redirected once',
1412
 
            t.request('GET', t._remote_path('a'), retries=1).read())
 
1422
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
 
1423
        self.assertEqual('redirected once',t._perform(req).read())
1413
1424
 
1414
1425
    def test_five_redirections(self):
1415
 
        t = self.get_old_transport()
 
1426
        t = self.old_transport
 
1427
 
 
1428
        req = RedirectedRequest('GET', t.abspath('a'))
1416
1429
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1417
1430
                                       self.old_server.port)
1418
1431
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1424
1437
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1425
1438
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1426
1439
            ]
1427
 
        self.assertEqual(
1428
 
            b'redirected 5 times',
1429
 
            t.request('GET', t._remote_path('a'), retries=6).read())
 
1440
        self.assertEqual('redirected 5 times',t._perform(req).read())
1430
1441
 
1431
1442
 
1432
1443
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1433
1444
    """Test transport.do_catching_redirections."""
1434
1445
 
1435
 
    scenarios = multiply_scenarios(
1436
 
        vary_by_http_client_implementation(),
1437
 
        vary_by_http_protocol_version(),
1438
 
        )
1439
 
 
1440
1446
    def setUp(self):
1441
1447
        super(TestDoCatchRedirections, self).setUp()
1442
 
        self.build_tree_contents([('a', b'0123456789'), ],)
1443
 
        cleanup_http_redirection_connections(self)
1444
 
 
1445
 
        self.old_transport = self.get_old_transport()
1446
 
 
1447
 
    def get_a(self, t):
1448
 
        return t.get('a')
 
1448
        self.build_tree_contents([('a', '0123456789'),],)
 
1449
 
 
1450
        self.old_transport = self._transport(self.old_server.get_url())
 
1451
 
 
1452
    def get_a(self, transport):
 
1453
        return transport.get('a')
1449
1454
 
1450
1455
    def test_no_redirection(self):
1451
 
        t = self.get_new_transport()
 
1456
        t = self._transport(self.new_server.get_url())
1452
1457
 
1453
1458
        # We use None for redirected so that we fail if redirected
1454
 
        self.assertEqual(b'0123456789',
 
1459
        self.assertEqual('0123456789',
1455
1460
                         transport.do_catching_redirections(
1456
 
                             self.get_a, t, None).read())
 
1461
                self.get_a, t, None).read())
1457
1462
 
1458
1463
    def test_one_redirection(self):
1459
1464
        self.redirections = 0
1460
1465
 
1461
 
        def redirected(t, exception, redirection_notice):
 
1466
        def redirected(transport, exception, redirection_notice):
1462
1467
            self.redirections += 1
1463
 
            redirected_t = t._redirected_to(exception.source, exception.target)
1464
 
            return redirected_t
 
1468
            dir, file = urlutils.split(exception.target)
 
1469
            return self._transport(dir)
1465
1470
 
1466
 
        self.assertEqual(b'0123456789',
 
1471
        self.assertEqual('0123456789',
1467
1472
                         transport.do_catching_redirections(
1468
 
                             self.get_a, self.old_transport, redirected).read())
 
1473
                self.get_a, self.old_transport, redirected).read())
1469
1474
        self.assertEqual(1, self.redirections)
1470
1475
 
1471
1476
    def test_redirection_loop(self):
1481
1486
                          self.get_a, self.old_transport, redirected)
1482
1487
 
1483
1488
 
1484
 
def _setup_authentication_config(**kwargs):
1485
 
    conf = config.AuthenticationConfig()
1486
 
    conf._get_config().update({'httptest': kwargs})
1487
 
    conf._save()
1488
 
 
1489
 
 
1490
 
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
1491
 
    """Unit tests for glue by which urllib2 asks us for authentication"""
1492
 
 
1493
 
    def test_get_user_password_without_port(self):
1494
 
        """We cope if urllib2 doesn't tell us the port.
1495
 
 
1496
 
        See https://bugs.launchpad.net/bzr/+bug/654684
1497
 
        """
1498
 
        user = 'joe'
1499
 
        password = 'foo'
1500
 
        _setup_authentication_config(scheme='http', host='localhost',
1501
 
                                     user=user, password=password)
1502
 
        handler = http.HTTPAuthHandler()
1503
 
        got_pass = handler.get_user_password(dict(
1504
 
            user='joe',
1505
 
            protocol='http',
1506
 
            host='localhost',
1507
 
            path='/',
1508
 
            realm=u'Realm',
1509
 
            ))
1510
 
        self.assertEqual((user, password), got_pass)
1511
 
 
1512
 
 
1513
1489
class TestAuth(http_utils.TestCaseWithWebserver):
1514
1490
    """Test authentication scheme"""
1515
1491
 
1516
 
    scenarios = multiply_scenarios(
1517
 
        vary_by_http_client_implementation(),
1518
 
        vary_by_http_protocol_version(),
1519
 
        vary_by_http_auth_scheme(),
1520
 
        )
 
1492
    _auth_header = 'Authorization'
 
1493
    _password_prompt_prefix = ''
 
1494
    _username_prompt_prefix = ''
 
1495
    # Set by load_tests
 
1496
    _auth_server = None
1521
1497
 
1522
1498
    def setUp(self):
1523
1499
        super(TestAuth, self).setUp()
1524
1500
        self.server = self.get_readonly_server()
1525
 
        self.build_tree_contents([('a', b'contents of a\n'),
1526
 
                                  ('b', b'contents of b\n'), ])
 
1501
        self.build_tree_contents([('a', 'contents of a\n'),
 
1502
                                  ('b', 'contents of b\n'),])
1527
1503
 
1528
1504
    def create_transport_readonly_server(self):
1529
 
        server = self._auth_server(protocol_version=self._protocol_version)
1530
 
        server._url_protocol = self._url_protocol
1531
 
        return server
 
1505
        return self._auth_server(protocol_version=self._protocol_version)
 
1506
 
 
1507
    def _testing_pycurl(self):
 
1508
        # TODO: This is duplicated for lots of the classes in this file
 
1509
        return (features.pycurl.available()
 
1510
                and self._transport == PyCurlTransport)
1532
1511
 
1533
1512
    def get_user_url(self, user, password):
1534
1513
        """Build an url embedding user and password"""
1542
1521
        return url
1543
1522
 
1544
1523
    def get_user_transport(self, user, password):
1545
 
        t = transport.get_transport_from_url(
1546
 
            self.get_user_url(user, password))
1547
 
        return t
 
1524
        return self._transport(self.get_user_url(user, password))
1548
1525
 
1549
1526
    def test_no_user(self):
1550
1527
        self.server.add_user('joe', 'foo')
1556
1533
    def test_empty_pass(self):
1557
1534
        self.server.add_user('joe', '')
1558
1535
        t = self.get_user_transport('joe', '')
1559
 
        self.assertEqual(b'contents of a\n', t.get('a').read())
 
1536
        self.assertEqual('contents of a\n', t.get('a').read())
1560
1537
        # Only one 'Authentication Required' error should occur
1561
1538
        self.assertEqual(1, self.server.auth_required_errors)
1562
1539
 
1563
1540
    def test_user_pass(self):
1564
1541
        self.server.add_user('joe', 'foo')
1565
1542
        t = self.get_user_transport('joe', 'foo')
1566
 
        self.assertEqual(b'contents of a\n', t.get('a').read())
 
1543
        self.assertEqual('contents of a\n', t.get('a').read())
1567
1544
        # Only one 'Authentication Required' error should occur
1568
1545
        self.assertEqual(1, self.server.auth_required_errors)
1569
1546
 
1585
1562
        self.assertEqual(2, self.server.auth_required_errors)
1586
1563
 
1587
1564
    def test_prompt_for_username(self):
 
1565
        if self._testing_pycurl():
 
1566
            raise tests.TestNotApplicable(
 
1567
                'pycurl cannot prompt, it handles auth by embedding'
 
1568
                ' user:pass in urls only')
 
1569
 
1588
1570
        self.server.add_user('joe', 'foo')
1589
1571
        t = self.get_user_transport(None, None)
1590
 
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n')
1591
 
        stdout, stderr = ui.ui_factory.stdout, ui.ui_factory.stderr
1592
 
        self.assertEqual(b'contents of a\n', t.get('a').read())
 
1572
        stdout = tests.StringIOWrapper()
 
1573
        stderr = tests.StringIOWrapper()
 
1574
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n',
 
1575
                                            stdout=stdout, stderr=stderr)
 
1576
        self.assertEqual('contents of a\n',t.get('a').read())
1593
1577
        # stdin should be empty
1594
1578
        self.assertEqual('', ui.ui_factory.stdin.readline())
1595
1579
        stderr.seek(0)
1600
1584
                                    stderr.readline())
1601
1585
 
1602
1586
    def test_prompt_for_password(self):
 
1587
        if self._testing_pycurl():
 
1588
            raise tests.TestNotApplicable(
 
1589
                'pycurl cannot prompt, it handles auth by embedding'
 
1590
                ' user:pass in urls only')
 
1591
 
1603
1592
        self.server.add_user('joe', 'foo')
1604
1593
        t = self.get_user_transport('joe', None)
1605
 
        ui.ui_factory = tests.TestUIFactory(stdin='foo\n')
1606
 
        stdout, stderr = ui.ui_factory.stdout, ui.ui_factory.stderr
1607
 
        self.assertEqual(b'contents of a\n', t.get('a').read())
 
1594
        stdout = tests.StringIOWrapper()
 
1595
        stderr = tests.StringIOWrapper()
 
1596
        ui.ui_factory = tests.TestUIFactory(stdin='foo\n',
 
1597
                                            stdout=stdout, stderr=stderr)
 
1598
        self.assertEqual('contents of a\n', t.get('a').read())
1608
1599
        # stdin should be empty
1609
1600
        self.assertEqual('', ui.ui_factory.stdin.readline())
1610
1601
        self._check_password_prompt(t._unqualified_scheme, 'joe',
1612
1603
        self.assertEqual('', stdout.getvalue())
1613
1604
        # And we shouldn't prompt again for a different request
1614
1605
        # against the same transport.
1615
 
        self.assertEqual(b'contents of b\n', t.get('b').read())
 
1606
        self.assertEqual('contents of b\n',t.get('b').read())
1616
1607
        t2 = t.clone()
1617
1608
        # And neither against a clone
1618
 
        self.assertEqual(b'contents of b\n', t2.get('b').read())
 
1609
        self.assertEqual('contents of b\n',t2.get('b').read())
1619
1610
        # Only one 'Authentication Required' error should occur
1620
1611
        self.assertEqual(1, self.server.auth_required_errors)
1621
1612
 
1630
1621
    def _expected_username_prompt(self, scheme):
1631
1622
        return (self._username_prompt_prefix
1632
1623
                + "%s %s:%d, Realm: '%s' username: " % (scheme.upper(),
1633
 
                                                        self.server.host, self.server.port,
1634
 
                                                        self.server.auth_realm))
 
1624
                                 self.server.host, self.server.port,
 
1625
                                 self.server.auth_realm))
1635
1626
 
1636
1627
    def test_no_prompt_for_password_when_using_auth_config(self):
1637
 
        user = ' joe'
 
1628
        if self._testing_pycurl():
 
1629
            raise tests.TestNotApplicable(
 
1630
                'pycurl does not support authentication.conf'
 
1631
                ' since it cannot prompt')
 
1632
 
 
1633
        user =' joe'
1638
1634
        password = 'foo'
1639
1635
        stdin_content = 'bar\n'  # Not the right password
1640
1636
        self.server.add_user(user, password)
1641
1637
        t = self.get_user_transport(user, None)
1642
 
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content)
 
1638
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
 
1639
                                            stderr=tests.StringIOWrapper())
1643
1640
        # Create a minimal config file with the right password
1644
 
        _setup_authentication_config(scheme='http', port=self.server.port,
1645
 
                                     user=user, password=password)
 
1641
        conf = config.AuthenticationConfig()
 
1642
        conf._get_config().update(
 
1643
            {'httptest': {'scheme': 'http', 'port': self.server.port,
 
1644
                          'user': user, 'password': password}})
 
1645
        conf._save()
1646
1646
        # Issue a request to the server to connect
1647
 
        with t.get('a') as f:
1648
 
            self.assertEqual(b'contents of a\n', f.read())
 
1647
        self.assertEqual('contents of a\n',t.get('a').read())
1649
1648
        # stdin should have  been left untouched
1650
1649
        self.assertEqual(stdin_content, ui.ui_factory.stdin.readline())
1651
1650
        # Only one 'Authentication Required' error should occur
1652
1651
        self.assertEqual(1, self.server.auth_required_errors)
1653
1652
 
 
1653
    def test_user_from_auth_conf(self):
 
1654
        if self._testing_pycurl():
 
1655
            raise tests.TestNotApplicable(
 
1656
                'pycurl does not support authentication.conf')
 
1657
        user = 'joe'
 
1658
        password = 'foo'
 
1659
        self.server.add_user(user, password)
 
1660
        # Create a minimal config file with the right password
 
1661
        conf = config.AuthenticationConfig()
 
1662
        conf._get_config().update(
 
1663
            {'httptest': {'scheme': 'http', 'port': self.server.port,
 
1664
                          'user': user, 'password': password}})
 
1665
        conf._save()
 
1666
        t = self.get_user_transport(None, None)
 
1667
        # Issue a request to the server to connect
 
1668
        self.assertEqual('contents of a\n', t.get('a').read())
 
1669
        # Only one 'Authentication Required' error should occur
 
1670
        self.assertEqual(1, self.server.auth_required_errors)
 
1671
 
1654
1672
    def test_changing_nonce(self):
1655
1673
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1656
1674
                                     http_utils.ProxyDigestAuthServer):
1657
1675
            raise tests.TestNotApplicable('HTTP/proxy auth digest only test')
 
1676
        if self._testing_pycurl():
 
1677
            raise tests.KnownFailure(
 
1678
                'pycurl does not handle a nonce change')
1658
1679
        self.server.add_user('joe', 'foo')
1659
1680
        t = self.get_user_transport('joe', 'foo')
1660
 
        with t.get('a') as f:
1661
 
            self.assertEqual(b'contents of a\n', f.read())
1662
 
        with t.get('b') as f:
1663
 
            self.assertEqual(b'contents of b\n', f.read())
 
1681
        self.assertEqual('contents of a\n', t.get('a').read())
 
1682
        self.assertEqual('contents of b\n', t.get('b').read())
1664
1683
        # Only one 'Authentication Required' error should have
1665
1684
        # occured so far
1666
1685
        self.assertEqual(1, self.server.auth_required_errors)
1667
1686
        # The server invalidates the current nonce
1668
1687
        self.server.auth_nonce = self.server.auth_nonce + '. No, now!'
1669
 
        self.assertEqual(b'contents of a\n', t.get('a').read())
 
1688
        self.assertEqual('contents of a\n', t.get('a').read())
1670
1689
        # Two 'Authentication Required' errors should occur (the
1671
1690
        # initial 'who are you' and a second 'who are you' with the new nonce)
1672
1691
        self.assertEqual(2, self.server.auth_required_errors)
1673
1692
 
1674
 
    def test_user_from_auth_conf(self):
1675
 
        user = 'joe'
1676
 
        password = 'foo'
1677
 
        self.server.add_user(user, password)
1678
 
        _setup_authentication_config(scheme='http', port=self.server.port,
1679
 
                                     user=user, password=password)
1680
 
        t = self.get_user_transport(None, None)
1681
 
        # Issue a request to the server to connect
1682
 
        with t.get('a') as f:
1683
 
            self.assertEqual(b'contents of a\n', f.read())
1684
 
        # Only one 'Authentication Required' error should occur
1685
 
        self.assertEqual(1, self.server.auth_required_errors)
1686
 
 
1687
 
    def test_no_credential_leaks_in_log(self):
1688
 
        self.overrideAttr(debug, 'debug_flags', {'http'})
1689
 
        user = 'joe'
1690
 
        password = 'very-sensitive-password'
1691
 
        self.server.add_user(user, password)
1692
 
        t = self.get_user_transport(user, password)
1693
 
        # Capture the debug calls to mutter
1694
 
        self.mutters = []
1695
 
 
1696
 
        def mutter(*args):
1697
 
            lines = args[0] % args[1:]
1698
 
            # Some calls output multiple lines, just split them now since we
1699
 
            # care about a single one later.
1700
 
            self.mutters.extend(lines.splitlines())
1701
 
        self.overrideAttr(trace, 'mutter', mutter)
1702
 
        # Issue a request to the server to connect
1703
 
        self.assertEqual(True, t.has('a'))
1704
 
        # Only one 'Authentication Required' error should occur
1705
 
        self.assertEqual(1, self.server.auth_required_errors)
1706
 
        # Since the authentification succeeded, there should be a corresponding
1707
 
        # debug line
1708
 
        sent_auth_headers = [line for line in self.mutters
1709
 
                             if line.startswith('> %s' % (self._auth_header,))]
1710
 
        self.assertLength(1, sent_auth_headers)
1711
 
        self.assertStartsWith(sent_auth_headers[0],
1712
 
                              '> %s: <masked>' % (self._auth_header,))
1713
1693
 
1714
1694
 
1715
1695
class TestProxyAuth(TestAuth):
1716
 
    """Test proxy authentication schemes.
1717
 
 
1718
 
    This inherits from TestAuth to tweak the setUp and filter some failing
1719
 
    tests.
1720
 
    """
1721
 
 
1722
 
    scenarios = multiply_scenarios(
1723
 
        vary_by_http_client_implementation(),
1724
 
        vary_by_http_protocol_version(),
1725
 
        vary_by_http_proxy_auth_scheme(),
1726
 
        )
 
1696
    """Test proxy authentication schemes."""
 
1697
 
 
1698
    _auth_header = 'Proxy-authorization'
 
1699
    _password_prompt_prefix = 'Proxy '
 
1700
    _username_prompt_prefix = 'Proxy '
1727
1701
 
1728
1702
    def setUp(self):
1729
1703
        super(TestProxyAuth, self).setUp()
 
1704
        self._old_env = {}
 
1705
        self.addCleanup(self._restore_env)
1730
1706
        # Override the contents to avoid false positives
1731
 
        self.build_tree_contents([('a', b'not proxied contents of a\n'),
1732
 
                                  ('b', b'not proxied contents of b\n'),
1733
 
                                  ('a-proxied', b'contents of a\n'),
1734
 
                                  ('b-proxied', b'contents of b\n'),
 
1707
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
 
1708
                                  ('b', 'not proxied contents of b\n'),
 
1709
                                  ('a-proxied', 'contents of a\n'),
 
1710
                                  ('b-proxied', 'contents of b\n'),
1735
1711
                                  ])
1736
1712
 
1737
1713
    def get_user_transport(self, user, password):
1738
 
        proxy_url = self.get_user_url(user, password)
1739
 
        self.overrideEnv('all_proxy', proxy_url)
1740
 
        return TestAuth.get_user_transport(self, user, password)
1741
 
 
1742
 
 
1743
 
class NonClosingBytesIO(io.BytesIO):
1744
 
 
1745
 
    def close(self):
1746
 
        """Ignore and leave file open."""
 
1714
        self._install_env({'all_proxy': self.get_user_url(user, password)})
 
1715
        return self._transport(self.server.get_url())
 
1716
 
 
1717
    def _install_env(self, env):
 
1718
        for name, value in env.iteritems():
 
1719
            self._old_env[name] = osutils.set_or_unset_env(name, value)
 
1720
 
 
1721
    def _restore_env(self):
 
1722
        for name, value in self._old_env.iteritems():
 
1723
            osutils.set_or_unset_env(name, value)
 
1724
 
 
1725
    def test_empty_pass(self):
 
1726
        if self._testing_pycurl():
 
1727
            import pycurl
 
1728
            if pycurl.version_info()[1] < '7.16.0':
 
1729
                raise tests.KnownFailure(
 
1730
                    'pycurl < 7.16.0 does not handle empty proxy passwords')
 
1731
        super(TestProxyAuth, self).test_empty_pass()
1747
1732
 
1748
1733
 
1749
1734
class SampleSocket(object):
1754
1739
 
1755
1740
        :param socket_read_content: a byte sequence
1756
1741
        """
1757
 
        self.readfile = io.BytesIO(socket_read_content)
1758
 
        self.writefile = NonClosingBytesIO()
1759
 
 
1760
 
    def close(self):
1761
 
        """Ignore and leave files alone."""
1762
 
 
1763
 
    def sendall(self, bytes):
1764
 
        self.writefile.write(bytes)
 
1742
        # Use plain python StringIO so we can monkey-patch the close method to
 
1743
        # not discard the contents.
 
1744
        from StringIO import StringIO
 
1745
        self.readfile = StringIO(socket_read_content)
 
1746
        self.writefile = StringIO()
 
1747
        self.writefile.close = lambda: None
1765
1748
 
1766
1749
    def makefile(self, mode='r', bufsize=None):
1767
1750
        if 'r' in mode:
1772
1755
 
1773
1756
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1774
1757
 
1775
 
    scenarios = multiply_scenarios(
1776
 
        vary_by_http_client_implementation(),
1777
 
        vary_by_http_protocol_version(),
1778
 
        )
1779
 
 
1780
1758
    def setUp(self):
1781
1759
        super(SmartHTTPTunnellingTest, self).setUp()
1782
1760
        # We use the VFS layer as part of HTTP tunnelling tests.
1783
 
        self.overrideEnv('BRZ_NO_SMART_VFS', None)
 
1761
        self._captureVar('BZR_NO_SMART_VFS', None)
1784
1762
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
1785
 
        self.http_server = self.get_readonly_server()
1786
1763
 
1787
1764
    def create_transport_readonly_server(self):
1788
 
        server = http_utils.HTTPServerWithSmarts(
 
1765
        return http_utils.HTTPServerWithSmarts(
1789
1766
            protocol_version=self._protocol_version)
1790
 
        server._url_protocol = self._url_protocol
1791
 
        return server
1792
1767
 
1793
 
    def test_open_controldir(self):
 
1768
    def test_open_bzrdir(self):
1794
1769
        branch = self.make_branch('relpath')
1795
 
        url = self.http_server.get_url() + 'relpath'
1796
 
        bd = controldir.ControlDir.open(url)
1797
 
        self.addCleanup(bd.transport.disconnect)
 
1770
        http_server = self.get_readonly_server()
 
1771
        url = http_server.get_url() + 'relpath'
 
1772
        bd = bzrdir.BzrDir.open(url)
1798
1773
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1799
1774
 
1800
1775
    def test_bulk_data(self):
1802
1777
        # The 'readv' command in the smart protocol both sends and receives
1803
1778
        # bulk data, so we use that.
1804
1779
        self.build_tree(['data-file'])
1805
 
        http_transport = transport.get_transport_from_url(
1806
 
            self.http_server.get_url())
 
1780
        http_server = self.get_readonly_server()
 
1781
        http_transport = self._transport(http_server.get_url())
1807
1782
        medium = http_transport.get_smart_medium()
1808
1783
        # Since we provide the medium, the url below will be mostly ignored
1809
1784
        # during the test, as long as the path is '/'.
1810
1785
        remote_transport = remote.RemoteTransport('bzr://fake_host/',
1811
1786
                                                  medium=medium)
1812
1787
        self.assertEqual(
1813
 
            [(0, b"c")], list(remote_transport.readv("data-file", [(0, 1)])))
 
1788
            [(0, "c")], list(remote_transport.readv("data-file", [(0,1)])))
1814
1789
 
1815
1790
    def test_http_send_smart_request(self):
1816
1791
 
1817
 
        post_body = b'hello\n'
1818
 
        expected_reply_body = b'ok\x012\n'
 
1792
        post_body = 'hello\n'
 
1793
        expected_reply_body = 'ok\x012\n'
1819
1794
 
1820
 
        http_transport = transport.get_transport_from_url(
1821
 
            self.http_server.get_url())
 
1795
        http_server = self.get_readonly_server()
 
1796
        http_transport = self._transport(http_server.get_url())
1822
1797
        medium = http_transport.get_smart_medium()
1823
1798
        response = medium.send_http_smart_request(post_body)
1824
1799
        reply_body = response.read()
1825
1800
        self.assertEqual(expected_reply_body, reply_body)
1826
1801
 
1827
1802
    def test_smart_http_server_post_request_handler(self):
1828
 
        httpd = self.http_server.server
 
1803
        httpd = self.get_readonly_server()._get_httpd()
1829
1804
 
1830
1805
        socket = SampleSocket(
1831
 
            b'POST /.bzr/smart %s \r\n' % self._protocol_version.encode('ascii') +
 
1806
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1832
1807
            # HTTP/1.1 posts must have a Content-Length (but it doesn't hurt
1833
1808
            # for 1.0)
1834
 
            b'Content-Length: 6\r\n'
1835
 
            b'\r\n'
1836
 
            b'hello\n')
 
1809
            + 'Content-Length: 6\r\n'
 
1810
            '\r\n'
 
1811
            'hello\n')
1837
1812
        # Beware: the ('localhost', 80) below is the
1838
1813
        # client_address parameter, but we don't have one because
1839
1814
        # we have defined a socket which is not bound to an
1843
1818
                                                         ('localhost', 80),
1844
1819
                                                         httpd)
1845
1820
        response = socket.writefile.getvalue()
1846
 
        self.assertStartsWith(
1847
 
            response,
1848
 
            b'%s 200 ' % self._protocol_version.encode('ascii'))
 
1821
        self.assertStartsWith(response, '%s 200 ' % self._protocol_version)
1849
1822
        # This includes the end of the HTTP headers, and all the body.
1850
 
        expected_end_of_response = b'\r\n\r\nok\x012\n'
 
1823
        expected_end_of_response = '\r\n\r\nok\x012\n'
1851
1824
        self.assertEndsWith(response, expected_end_of_response)
1852
1825
 
1853
1826
 
1865
1838
 
1866
1839
    def test_probe_smart_server(self):
1867
1840
        """Test error handling against server refusing smart requests."""
1868
 
        t = self.get_readonly_transport()
 
1841
        server = self.get_readonly_server()
 
1842
        t = self._transport(server.get_url())
1869
1843
        # No need to build a valid smart request here, the server will not even
1870
1844
        # try to interpret it.
1871
1845
        self.assertRaises(errors.SmartProtocolError,
1872
1846
                          t.get_smart_medium().send_http_smart_request,
1873
 
                          b'whatever')
1874
 
 
 
1847
                          'whatever')
1875
1848
 
1876
1849
class Test_redirected_to(tests.TestCase):
1877
1850
 
1878
 
    scenarios = vary_by_http_client_implementation()
1879
 
 
1880
1851
    def test_redirected_to_subdir(self):
1881
1852
        t = self._transport('http://www.example.com/foo')
1882
1853
        r = t._redirected_to('http://www.example.com/foo',
1884
1855
        self.assertIsInstance(r, type(t))
1885
1856
        # Both transports share the some connection
1886
1857
        self.assertEqual(t._get_connection(), r._get_connection())
1887
 
        self.assertEqual('http://www.example.com/foo/subdir/', r.base)
1888
1858
 
1889
1859
    def test_redirected_to_self_with_slash(self):
1890
1860
        t = self._transport('http://www.example.com/foo')
1901
1871
        r = t._redirected_to('http://www.example.com/foo',
1902
1872
                             'http://foo.example.com/foo/subdir')
1903
1873
        self.assertIsInstance(r, type(t))
1904
 
        self.assertEqual('http://foo.example.com/foo/subdir/',
1905
 
                         r.external_url())
1906
1874
 
1907
1875
    def test_redirected_to_same_host_sibling_protocol(self):
1908
1876
        t = self._transport('http://www.example.com/foo')
1909
1877
        r = t._redirected_to('http://www.example.com/foo',
1910
1878
                             'https://www.example.com/foo')
1911
1879
        self.assertIsInstance(r, type(t))
1912
 
        self.assertEqual('https://www.example.com/foo/',
1913
 
                         r.external_url())
1914
1880
 
1915
1881
    def test_redirected_to_same_host_different_protocol(self):
1916
1882
        t = self._transport('http://www.example.com/foo')
1917
1883
        r = t._redirected_to('http://www.example.com/foo',
1918
 
                             'bzr://www.example.com/foo')
1919
 
        self.assertNotEqual(type(r), type(t))
1920
 
        self.assertEqual('bzr://www.example.com/foo/', r.external_url())
1921
 
 
1922
 
    def test_redirected_to_same_host_specific_implementation(self):
1923
 
        t = self._transport('http://www.example.com/foo')
1924
 
        r = t._redirected_to('http://www.example.com/foo',
1925
 
                             'https+urllib://www.example.com/foo')
1926
 
        self.assertEqual('https://www.example.com/foo/', r.external_url())
 
1884
                             'ftp://www.example.com/foo')
 
1885
        self.assertNotEquals(type(r), type(t))
1927
1886
 
1928
1887
    def test_redirected_to_different_host_same_user(self):
1929
1888
        t = self._transport('http://joe@www.example.com/foo')
1930
1889
        r = t._redirected_to('http://www.example.com/foo',
1931
1890
                             'https://foo.example.com/foo')
1932
1891
        self.assertIsInstance(r, type(t))
1933
 
        self.assertEqual(t._parsed_url.user, r._parsed_url.user)
1934
 
        self.assertEqual('https://joe@foo.example.com/foo/', r.external_url())
 
1892
        self.assertEqual(t._user, r._user)
1935
1893
 
1936
1894
 
1937
1895
class PredefinedRequestHandler(http_server.TestingHTTPRequestHandler):
1946
1904
    line.
1947
1905
    """
1948
1906
 
1949
 
    def _handle_one_request(self):
 
1907
    def handle_one_request(self):
1950
1908
        tcs = self.server.test_case_server
1951
1909
        requestline = self.rfile.readline()
1952
 
        if PY3:
1953
 
            headers = parse_headers(self.rfile)
1954
 
            bytes_read = len(headers.as_bytes())
1955
 
            bytes_read += headers.as_bytes().count(b'\n')
1956
 
            bytes_read += len(requestline)
1957
 
        else:
1958
 
            headers = self.MessageClass(self.rfile, 0)
1959
 
            # We just read: the request, the headers, an empty line indicating the
1960
 
            # end of the headers.
1961
 
            bytes_read = len(requestline)
1962
 
            for line in headers.headers:
1963
 
                bytes_read += len(line)
1964
 
            bytes_read += len(b'\r\n')
1965
 
        if requestline.startswith(b'POST'):
 
1910
        headers = self.MessageClass(self.rfile, 0)
 
1911
        # We just read: the request, the headers, an empty line indicating the
 
1912
        # end of the headers.
 
1913
        bytes_read = len(requestline)
 
1914
        for line in headers.headers:
 
1915
            bytes_read += len(line)
 
1916
        bytes_read += len('\r\n')
 
1917
        if requestline.startswith('POST'):
1966
1918
            # The body should be a single line (or we don't know where it ends
1967
1919
            # and we don't want to issue a blocking read)
1968
1920
            body = self.rfile.readline()
1996
1948
    pass
1997
1949
 
1998
1950
 
1999
 
if features.HTTPSServerFeature.available():
2000
 
    from . import https_server
2001
 
 
 
1951
if tests.HTTPSServerFeature.available():
 
1952
    from bzrlib.tests import https_server
2002
1953
    class ActivityHTTPSServer(ActivityServerMixin, https_server.HTTPSServer):
2003
1954
        pass
2004
1955
 
2011
1962
    """
2012
1963
 
2013
1964
    def setUp(self):
 
1965
        tests.TestCase.setUp(self)
2014
1966
        self.server = self._activity_server(self._protocol_version)
2015
1967
        self.server.start_server()
2016
 
        self.addCleanup(self.server.stop_server)
2017
 
        _activities = {}  # Don't close over self and create a cycle
2018
 
 
 
1968
        self.activities = {}
2019
1969
        def report_activity(t, bytes, direction):
2020
 
            count = _activities.get(direction, 0)
 
1970
            count = self.activities.get(direction, 0)
2021
1971
            count += bytes
2022
 
            _activities[direction] = count
2023
 
        self.activities = _activities
 
1972
            self.activities[direction] = count
 
1973
 
2024
1974
        # We override at class level because constructors may propagate the
2025
1975
        # bound method and render instance overriding ineffective (an
2026
1976
        # alternative would be to define a specific ui factory instead...)
2027
 
        self.overrideAttr(self._transport, '_report_activity', report_activity)
 
1977
        self.orig_report_activity = self._transport._report_activity
 
1978
        self._transport._report_activity = report_activity
 
1979
 
 
1980
    def tearDown(self):
 
1981
        self._transport._report_activity = self.orig_report_activity
 
1982
        self.server.stop_server()
 
1983
        tests.TestCase.tearDown(self)
2028
1984
 
2029
1985
    def get_transport(self):
2030
 
        t = self._transport(self.server.get_url())
2031
 
        # FIXME: Needs cleanup -- vila 20100611
2032
 
        return t
 
1986
        return self._transport(self.server.get_url())
2033
1987
 
2034
1988
    def assertActivitiesMatch(self):
2035
1989
        self.assertEqual(self.server.bytes_read,
2038
1992
                         self.activities.get('read', 0), 'read bytes')
2039
1993
 
2040
1994
    def test_get(self):
2041
 
        self.server.canned_response = b'''HTTP/1.1 200 OK\r
 
1995
        self.server.canned_response = '''HTTP/1.1 200 OK\r
2042
1996
Date: Tue, 11 Jul 2006 04:32:56 GMT\r
2043
1997
Server: Apache/2.0.54 (Fedora)\r
2044
1998
Last-Modified: Sun, 23 Apr 2006 19:35:20 GMT\r
2051
2005
Bazaar-NG meta directory, format 1
2052
2006
'''
2053
2007
        t = self.get_transport()
2054
 
        self.assertEqual(b'Bazaar-NG meta directory, format 1\n',
 
2008
        self.assertEqual('Bazaar-NG meta directory, format 1\n',
2055
2009
                         t.get('foo/bar').read())
2056
2010
        self.assertActivitiesMatch()
2057
2011
 
2058
2012
    def test_has(self):
2059
 
        self.server.canned_response = b'''HTTP/1.1 200 OK\r
 
2013
        self.server.canned_response = '''HTTP/1.1 200 OK\r
2060
2014
Server: SimpleHTTP/0.6 Python/2.5.2\r
2061
2015
Date: Thu, 29 Jan 2009 20:21:47 GMT\r
2062
2016
Content-type: application/octet-stream\r
2069
2023
        self.assertActivitiesMatch()
2070
2024
 
2071
2025
    def test_readv(self):
2072
 
        self.server.canned_response = b'''HTTP/1.1 206 Partial Content\r
 
2026
        self.server.canned_response = '''HTTP/1.1 206 Partial Content\r
2073
2027
Date: Tue, 11 Jul 2006 04:49:48 GMT\r
2074
2028
Server: Apache/2.0.54 (Fedora)\r
2075
2029
Last-Modified: Thu, 06 Jul 2006 20:22:05 GMT\r
2122
2076
        # Remember that the request is ignored and that the ranges below
2123
2077
        # doesn't have to match the canned response.
2124
2078
        l = list(t.readv('/foo/bar', ((0, 255), (1000, 1050))))
2125
 
        # Force consumption of the last bytesrange boundary
2126
 
        t._get_connection().cleanup_pipe()
2127
2079
        self.assertEqual(2, len(l))
2128
2080
        self.assertActivitiesMatch()
2129
2081
 
2130
2082
    def test_post(self):
2131
 
        self.server.canned_response = b'''HTTP/1.1 200 OK\r
 
2083
        self.server.canned_response = '''HTTP/1.1 200 OK\r
2132
2084
Date: Tue, 11 Jul 2006 04:32:56 GMT\r
2133
2085
Server: Apache/2.0.54 (Fedora)\r
2134
2086
Last-Modified: Sun, 23 Apr 2006 19:35:20 GMT\r
2142
2094
'''
2143
2095
        t = self.get_transport()
2144
2096
        # We must send a single line of body bytes, see
2145
 
        # PredefinedRequestHandler._handle_one_request
2146
 
        code, f = t._post(b'abc def end-of-body\n')
2147
 
        self.assertEqual(b'lalala whatever as long as itsssss\n', f.read())
 
2097
        # PredefinedRequestHandler.handle_one_request
 
2098
        code, f = t._post('abc def end-of-body\n')
 
2099
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2148
2100
        self.assertActivitiesMatch()
2149
2101
 
2150
2102
 
2151
2103
class TestActivity(tests.TestCase, TestActivityMixin):
2152
2104
 
2153
 
    scenarios = multiply_scenarios(
2154
 
        vary_by_http_activity(),
2155
 
        vary_by_http_protocol_version(),
2156
 
        )
2157
 
 
2158
2105
    def setUp(self):
2159
 
        super(TestActivity, self).setUp()
2160
 
        TestActivityMixin.setUp(self)
 
2106
        tests.TestCase.setUp(self)
 
2107
        self.server = self._activity_server(self._protocol_version)
 
2108
        self.server.start_server()
 
2109
        self.activities = {}
 
2110
        def report_activity(t, bytes, direction):
 
2111
            count = self.activities.get(direction, 0)
 
2112
            count += bytes
 
2113
            self.activities[direction] = count
 
2114
 
 
2115
        # We override at class level because constructors may propagate the
 
2116
        # bound method and render instance overriding ineffective (an
 
2117
        # alternative would be to define a specific ui factory instead...)
 
2118
        self.orig_report_activity = self._transport._report_activity
 
2119
        self._transport._report_activity = report_activity
 
2120
 
 
2121
    def tearDown(self):
 
2122
        self._transport._report_activity = self.orig_report_activity
 
2123
        self.server.stop_server()
 
2124
        tests.TestCase.tearDown(self)
2161
2125
 
2162
2126
 
2163
2127
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2164
2128
 
2165
 
    # Unlike TestActivity, we are really testing ReportingFileSocket and
2166
 
    # ReportingSocket, so we don't need all the parametrization. Since
2167
 
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2168
 
    # test them through their use by the transport than directly (that's a
2169
 
    # bit less clean but far more simpler and effective).
2170
 
    _activity_server = ActivityHTTPServer
2171
 
    _protocol_version = 'HTTP/1.1'
2172
 
 
2173
2129
    def setUp(self):
2174
 
        super(TestNoReportActivity, self).setUp()
2175
 
        self._transport = HttpTransport
2176
 
        TestActivityMixin.setUp(self)
 
2130
        tests.TestCase.setUp(self)
 
2131
        # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2132
        # ReportingSocket, so we don't need all the parametrization. Since
 
2133
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2134
        # test them through their use by the transport than directly (that's a
 
2135
        # bit less clean but far more simpler and effective).
 
2136
        self.server = ActivityHTTPServer('HTTP/1.1')
 
2137
        self._transport=_urllib.HttpTransport_urllib
 
2138
 
 
2139
        self.server.start_server()
 
2140
 
 
2141
        # We override at class level because constructors may propagate the
 
2142
        # bound method and render instance overriding ineffective (an
 
2143
        # alternative would be to define a specific ui factory instead...)
 
2144
        self.orig_report_activity = self._transport._report_activity
 
2145
        self._transport._report_activity = None
 
2146
 
 
2147
    def tearDown(self):
 
2148
        self._transport._report_activity = self.orig_report_activity
 
2149
        self.server.stop_server()
 
2150
        tests.TestCase.tearDown(self)
2177
2151
 
2178
2152
    def assertActivitiesMatch(self):
2179
2153
        # Nothing to check here
2183
2157
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2184
2158
    """Test authentication on the redirected http server."""
2185
2159
 
2186
 
    scenarios = vary_by_http_protocol_version()
2187
 
 
2188
2160
    _auth_header = 'Authorization'
2189
2161
    _password_prompt_prefix = ''
2190
2162
    _username_prompt_prefix = ''
2191
2163
    _auth_server = http_utils.HTTPBasicAuthServer
2192
 
    _transport = HttpTransport
 
2164
    _transport = _urllib.HttpTransport_urllib
 
2165
 
 
2166
    def create_transport_readonly_server(self):
 
2167
        return self._auth_server(protocol_version=self._protocol_version)
 
2168
 
 
2169
    def create_transport_secondary_server(self):
 
2170
        """Create the secondary server redirecting to the primary server"""
 
2171
        new = self.get_readonly_server()
 
2172
 
 
2173
        redirecting = http_utils.HTTPServerRedirecting(
 
2174
            protocol_version=self._protocol_version)
 
2175
        redirecting.redirect_to(new.host, new.port)
 
2176
        return redirecting
2193
2177
 
2194
2178
    def setUp(self):
2195
2179
        super(TestAuthOnRedirected, self).setUp()
2196
 
        self.build_tree_contents([('a', b'a'),
 
2180
        self.build_tree_contents([('a','a'),
2197
2181
                                  ('1/',),
2198
 
                                  ('1/a', b'redirected once'),
 
2182
                                  ('1/a', 'redirected once'),
2199
2183
                                  ],)
2200
2184
        new_prefix = 'http://%s:%s' % (self.new_server.host,
2201
2185
                                       self.new_server.port)
2202
2186
        self.old_server.redirections = [
2203
 
            ('(.*)', r'%s/1\1' % (new_prefix), 301), ]
2204
 
        self.old_transport = self.get_old_transport()
 
2187
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
 
2188
        self.old_transport = self._transport(self.old_server.get_url())
2205
2189
        self.new_server.add_user('joe', 'foo')
2206
 
        cleanup_http_redirection_connections(self)
2207
 
 
2208
 
    def create_transport_readonly_server(self):
2209
 
        server = self._auth_server(protocol_version=self._protocol_version)
2210
 
        server._url_protocol = self._url_protocol
2211
 
        return server
2212
 
 
2213
 
    def get_a(self, t):
2214
 
        return t.get('a')
 
2190
 
 
2191
    def get_a(self, transport):
 
2192
        return transport.get('a')
2215
2193
 
2216
2194
    def test_auth_on_redirected_via_do_catching_redirections(self):
2217
2195
        self.redirections = 0
2218
2196
 
2219
 
        def redirected(t, exception, redirection_notice):
 
2197
        def redirected(transport, exception, redirection_notice):
2220
2198
            self.redirections += 1
2221
 
            redirected_t = t._redirected_to(exception.source, exception.target)
2222
 
            self.addCleanup(redirected_t.disconnect)
2223
 
            return redirected_t
 
2199
            dir, file = urlutils.split(exception.target)
 
2200
            return self._transport(dir)
2224
2201
 
2225
 
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n')
2226
 
        self.assertEqual(b'redirected once',
 
2202
        stdout = tests.StringIOWrapper()
 
2203
        stderr = tests.StringIOWrapper()
 
2204
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n',
 
2205
                                            stdout=stdout, stderr=stderr)
 
2206
        self.assertEqual('redirected once',
2227
2207
                         transport.do_catching_redirections(
2228
 
                             self.get_a, self.old_transport, redirected).read())
 
2208
                self.get_a, self.old_transport, redirected).read())
2229
2209
        self.assertEqual(1, self.redirections)
2230
2210
        # stdin should be empty
2231
2211
        self.assertEqual('', ui.ui_factory.stdin.readline())
2232
2212
        # stdout should be empty, stderr will contains the prompts
2233
 
        self.assertEqual('', ui.ui_factory.stdout.getvalue())
 
2213
        self.assertEqual('', stdout.getvalue())
2234
2214
 
2235
2215
    def test_auth_on_redirected_via_following_redirections(self):
2236
2216
        self.new_server.add_user('joe', 'foo')
2237
 
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n')
 
2217
        stdout = tests.StringIOWrapper()
 
2218
        stderr = tests.StringIOWrapper()
 
2219
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n',
 
2220
                                            stdout=stdout, stderr=stderr)
2238
2221
        t = self.old_transport
 
2222
        req = RedirectedRequest('GET', t.abspath('a'))
2239
2223
        new_prefix = 'http://%s:%s' % (self.new_server.host,
2240
2224
                                       self.new_server.port)
2241
2225
        self.old_server.redirections = [
2242
 
            ('(.*)', r'%s/1\1' % (new_prefix), 301), ]
2243
 
        self.assertEqual(
2244
 
            b'redirected once',
2245
 
            t.request('GET', t.abspath('a'), retries=3).read())
 
2226
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
 
2227
        self.assertEqual('redirected once',t._perform(req).read())
2246
2228
        # stdin should be empty
2247
2229
        self.assertEqual('', ui.ui_factory.stdin.readline())
2248
2230
        # stdout should be empty, stderr will contains the prompts
2249
 
        self.assertEqual('', ui.ui_factory.stdout.getvalue())
 
2231
        self.assertEqual('', stdout.getvalue())
 
2232
 
 
2233