/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_merge.py

  • Committer: Marius Kruger
  • Date: 2010-07-10 21:28:56 UTC
  • mto: (5384.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 5385.
  • Revision ID: marius.kruger@enerweb.co.za-20100710212856-uq4ji3go0u5se7hx
* Update documentation
* add NEWS

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2012, 2016 Canonical Ltd
 
1
# Copyright (C) 2005-2010 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
import contextlib
18
17
import os
 
18
from StringIO import StringIO
19
19
 
20
 
from .. import (
21
 
    branch as _mod_branch,
 
20
from bzrlib import (
22
21
    conflicts,
23
22
    errors,
 
23
    knit,
24
24
    memorytree,
25
25
    merge as _mod_merge,
26
26
    option,
27
 
    revision as _mod_revision,
 
27
    progress,
28
28
    tests,
29
29
    transform,
30
 
    )
31
 
from ..bzr import (
32
 
    inventory,
33
 
    knit,
34
30
    versionedfile,
35
31
    )
36
 
from ..conflicts import ConflictList, TextConflict
37
 
from ..errors import UnrelatedBranches, NoCommits
38
 
from ..merge import transform_tree, merge_inner, _PlanMerge
39
 
from ..osutils import basename, pathjoin, file_kind
40
 
from . import (
41
 
    features,
 
32
from bzrlib.conflicts import ConflictList, TextConflict
 
33
from bzrlib.errors import UnrelatedBranches, NoCommits
 
34
from bzrlib.merge import transform_tree, merge_inner, _PlanMerge
 
35
from bzrlib.osutils import pathjoin, file_kind
 
36
from bzrlib.tests import (
42
37
    TestCaseWithMemoryTransport,
43
38
    TestCaseWithTransport,
44
39
    test_merge_core,
45
40
    )
46
 
from ..workingtree import WorkingTree
 
41
from bzrlib.workingtree import WorkingTree
47
42
 
48
43
 
49
44
class TestMerge(TestCaseWithTransport):
84
79
        tip = wt1.commit('empty commit')
85
80
        wt2 = self.make_branch_and_tree('branch2')
86
81
        wt2.pull(wt1.branch)
87
 
        with open('branch1/foo', 'wb') as f:
88
 
            f.write(b'foo')
89
 
        with open('branch1/bar', 'wb') as f:
90
 
            f.write(b'bar')
 
82
        file('branch1/foo', 'wb').write('foo')
 
83
        file('branch1/bar', 'wb').write('bar')
91
84
        wt1.add('foo')
92
85
        wt1.add('bar')
93
86
        wt1.commit('add foobar')
94
 
        self.run_bzr('merge ../branch1/baz', retcode=3, working_dir='branch2')
95
 
        self.run_bzr('merge ../branch1/foo', working_dir='branch2')
96
 
        self.assertPathExists('branch2/foo')
97
 
        self.assertPathDoesNotExist('branch2/bar')
98
 
        wt2 = WorkingTree.open('branch2')
 
87
        os.chdir('branch2')
 
88
        self.run_bzr('merge ../branch1/baz', retcode=3)
 
89
        self.run_bzr('merge ../branch1/foo')
 
90
        self.failUnlessExists('foo')
 
91
        self.failIfExists('bar')
 
92
        wt2 = WorkingTree.open('.') # opens branch2
99
93
        self.assertEqual([tip], wt2.get_parent_ids())
100
94
 
101
95
    def test_pending_with_null(self):
106
100
        br1.fetch(wt2.branch)
107
101
        # merge all of branch 2 into branch 1 even though they
108
102
        # are not related.
109
 
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), b'null:')
 
103
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), 'null:')
110
104
        self.assertEqual([br1.last_revision(), wt2.branch.last_revision()],
111
 
                         wt1.get_parent_ids())
 
105
            wt1.get_parent_ids())
112
106
        return (wt1, wt2.branch)
113
107
 
114
108
    def test_two_roots(self):
124
118
        finally:
125
119
            wt1.unlock()
126
120
 
127
 
    def test_merge_into_null_tree(self):
128
 
        wt = self.make_branch_and_tree('tree')
129
 
        null_tree = wt.basis_tree()
130
 
        self.build_tree(['tree/file'])
131
 
        wt.add('file')
132
 
        wt.commit('tree with root')
133
 
        merger = _mod_merge.Merge3Merger(null_tree, null_tree, null_tree, wt,
134
 
                                         this_branch=wt.branch,
135
 
                                         do_merge=False)
136
 
        with merger.make_preview_transform() as tt:
137
 
            self.assertEqual([], tt.find_conflicts())
138
 
            preview = tt.get_preview_tree()
139
 
            self.assertEqual(wt.path2id(''), preview.path2id(''))
140
 
 
141
 
    def test_merge_unrelated_retains_root(self):
142
 
        wt = self.make_branch_and_tree('tree')
143
 
        other_tree = self.make_branch_and_tree('other')
144
 
        self.addCleanup(other_tree.lock_read().unlock)
145
 
        merger = _mod_merge.Merge3Merger(wt, wt, wt.basis_tree(), other_tree,
146
 
                                         this_branch=wt.branch,
147
 
                                         do_merge=False)
148
 
        with wt.preview_transform() as merger.tt:
149
 
            merger._compute_transform()
150
 
            new_root_id = merger.tt.final_file_id(merger.tt.root)
151
 
            self.assertEqual(wt.path2id(''), new_root_id)
152
 
 
153
121
    def test_create_rename(self):
154
122
        """Rename an inventory entry while creating the file"""
155
 
        tree = self.make_branch_and_tree('.')
156
 
        with open('name1', 'wb') as f:
157
 
            f.write(b'Hello')
 
123
        tree =self.make_branch_and_tree('.')
 
124
        file('name1', 'wb').write('Hello')
158
125
        tree.add('name1')
159
126
        tree.commit(message="hello")
160
127
        tree.rename_one('name1', 'name2')
163
130
 
164
131
    def test_layered_rename(self):
165
132
        """Rename both child and parent at same time"""
166
 
        tree = self.make_branch_and_tree('.')
 
133
        tree =self.make_branch_and_tree('.')
167
134
        os.mkdir('dirname1')
168
135
        tree.add('dirname1')
169
136
        filename = pathjoin('dirname1', 'name1')
170
 
        with open(filename, 'wb') as f:
171
 
            f.write(b'Hello')
 
137
        file(filename, 'wb').write('Hello')
172
138
        tree.add(filename)
173
139
        tree.commit(message="hello")
174
140
        filename2 = pathjoin('dirname1', 'name2')
178
144
 
179
145
    def test_ignore_zero_merge_inner(self):
180
146
        # Test that merge_inner's ignore zero parameter is effective
181
 
        tree_a = self.make_branch_and_tree('a')
 
147
        tree_a =self.make_branch_and_tree('a')
182
148
        tree_a.commit(message="hello")
183
 
        dir_b = tree_a.controldir.sprout('b')
 
149
        dir_b = tree_a.bzrdir.sprout('b')
184
150
        tree_b = dir_b.open_workingtree()
185
151
        tree_b.lock_write()
186
152
        self.addCleanup(tree_b.unlock)
187
153
        tree_a.commit(message="hello again")
 
154
        log = StringIO()
188
155
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
189
156
                    this_tree=tree_b, ignore_zero=True)
190
 
        self.assertTrue('All changes applied successfully.\n' not in
191
 
                        self.get_log())
 
157
        self.failUnless('All changes applied successfully.\n' not in
 
158
            self.get_log())
192
159
        tree_b.revert()
193
160
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
194
161
                    this_tree=tree_b, ignore_zero=False)
195
 
        self.assertTrue(
196
 
            'All changes applied successfully.\n' in self.get_log())
 
162
        self.failUnless('All changes applied successfully.\n' in self.get_log())
197
163
 
198
164
    def test_merge_inner_conflicts(self):
199
165
        tree_a = self.make_branch_and_tree('a')
204
170
    def test_rmdir_conflict(self):
205
171
        tree_a = self.make_branch_and_tree('a')
206
172
        self.build_tree(['a/b/'])
207
 
        tree_a.add('b', b'b-id')
 
173
        tree_a.add('b', 'b-id')
208
174
        tree_a.commit('added b')
209
175
        # basis_tree() is only guaranteed to be valid as long as it is actually
210
176
        # the basis tree. This mutates the tree after grabbing basis, so go to
211
177
        # the repository.
212
 
        base_tree = tree_a.branch.repository.revision_tree(
213
 
            tree_a.last_revision())
214
 
        tree_z = tree_a.controldir.sprout('z').open_workingtree()
 
178
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
 
179
        tree_z = tree_a.bzrdir.sprout('z').open_workingtree()
215
180
        self.build_tree(['a/b/c'])
216
181
        tree_a.add('b/c')
217
182
        tree_a.commit('added c')
219
184
        tree_z.commit('removed b')
220
185
        merge_inner(tree_z.branch, tree_a, base_tree, this_tree=tree_z)
221
186
        self.assertEqual([
222
 
            conflicts.MissingParent('Created directory', 'b', b'b-id'),
223
 
            conflicts.UnversionedParent('Versioned directory', 'b', b'b-id')],
 
187
            conflicts.MissingParent('Created directory', 'b', 'b-id'),
 
188
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
224
189
            tree_z.conflicts())
225
190
        merge_inner(tree_a.branch, tree_z.basis_tree(), base_tree,
226
191
                    this_tree=tree_a)
227
192
        self.assertEqual([
228
 
            conflicts.DeletingParent('Not deleting', 'b', b'b-id'),
229
 
            conflicts.UnversionedParent('Versioned directory', 'b', b'b-id')],
 
193
            conflicts.DeletingParent('Not deleting', 'b', 'b-id'),
 
194
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
230
195
            tree_a.conflicts())
231
196
 
232
197
    def test_nested_merge(self):
233
 
        self.knownFailure(
234
 
            'iter_changes doesn\'t work with changes in nested trees')
235
198
        tree = self.make_branch_and_tree('tree',
236
 
                                         format='development-subtree')
 
199
            format='dirstate-with-subtree')
237
200
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
238
 
                                             format='development-subtree')
239
 
        sub_tree.set_root_id(b'sub-tree-root')
240
 
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
 
201
            format='dirstate-with-subtree')
 
202
        sub_tree.set_root_id('sub-tree-root')
 
203
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
241
204
        sub_tree.add('file')
242
205
        sub_tree.commit('foo')
243
206
        tree.add_reference(sub_tree)
244
207
        tree.commit('set text to 1')
245
 
        tree2 = tree.controldir.sprout('tree2').open_workingtree()
 
208
        tree2 = tree.bzrdir.sprout('tree2').open_workingtree()
246
209
        # modify the file in the subtree
247
 
        self.build_tree_contents([('tree2/sub-tree/file', b'text2')])
 
210
        self.build_tree_contents([('tree2/sub-tree/file', 'text2')])
248
211
        # and merge the changes from the diverged subtree into the containing
249
212
        # tree
250
213
        tree2.commit('changed file text')
251
214
        tree.merge_from_branch(tree2.branch)
252
 
        self.assertFileEqual(b'text2', 'tree/sub-tree/file')
 
215
        self.assertFileEqual('text2', 'tree/sub-tree/file')
253
216
 
254
217
    def test_merge_with_missing(self):
255
218
        tree_a = self.make_branch_and_tree('tree_a')
256
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
 
219
        self.build_tree_contents([('tree_a/file', 'content_1')])
257
220
        tree_a.add('file')
258
221
        tree_a.commit('commit base')
259
222
        # basis_tree() is only guaranteed to be valid as long as it is actually
260
223
        # the basis tree. This test commits to the tree after grabbing basis,
261
224
        # so we go to the repository.
262
 
        base_tree = tree_a.branch.repository.revision_tree(
263
 
            tree_a.last_revision())
264
 
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
265
 
        self.build_tree_contents([('tree_a/file', b'content_2')])
 
225
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
 
226
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
 
227
        self.build_tree_contents([('tree_a/file', 'content_2')])
266
228
        tree_a.commit('commit other')
267
229
        other_tree = tree_a.basis_tree()
268
230
        # 'file' is now missing but isn't altered in any commit in b so no
272
234
 
273
235
    def test_merge_kind_change(self):
274
236
        tree_a = self.make_branch_and_tree('tree_a')
275
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
276
 
        tree_a.add('file', b'file-id')
 
237
        self.build_tree_contents([('tree_a/file', 'content_1')])
 
238
        tree_a.add('file', 'file-id')
277
239
        tree_a.commit('added file')
278
 
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
 
240
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
279
241
        os.unlink('tree_a/file')
280
242
        self.build_tree(['tree_a/file/'])
281
243
        tree_a.commit('changed file to directory')
283
245
        self.assertEqual('directory', file_kind('tree_b/file'))
284
246
        tree_b.revert()
285
247
        self.assertEqual('file', file_kind('tree_b/file'))
286
 
        self.build_tree_contents([('tree_b/file', b'content_2')])
 
248
        self.build_tree_contents([('tree_b/file', 'content_2')])
287
249
        tree_b.commit('content change')
288
250
        tree_b.merge_from_branch(tree_a.branch)
289
251
        self.assertEqual(tree_b.conflicts(),
290
252
                         [conflicts.ContentsConflict('file',
291
 
                                                     file_id=b'file-id')])
 
253
                          file_id='file-id')])
292
254
 
293
255
    def test_merge_type_registry(self):
294
256
        merge_type_option = option.Option.OPTIONS['merge-type']
295
257
        self.assertFalse('merge4' in [x[0] for x in
296
 
                                      merge_type_option.iter_switches()])
 
258
                        merge_type_option.iter_switches()])
297
259
        registry = _mod_merge.get_merge_type_registry()
298
 
        registry.register_lazy('merge4', 'breezy.merge', 'Merge4Merger',
 
260
        registry.register_lazy('merge4', 'bzrlib.merge', 'Merge4Merger',
299
261
                               'time-travelling merge')
300
262
        self.assertTrue('merge4' in [x[0] for x in
301
 
                                     merge_type_option.iter_switches()])
 
263
                        merge_type_option.iter_switches()])
302
264
        registry.remove('merge4')
303
265
        self.assertFalse('merge4' in [x[0] for x in
304
 
                                      merge_type_option.iter_switches()])
 
266
                        merge_type_option.iter_switches()])
305
267
 
306
268
    def test_merge_other_moves_we_deleted(self):
307
269
        tree_a = self.make_branch_and_tree('A')
309
271
        self.addCleanup(tree_a.unlock)
310
272
        self.build_tree(['A/a'])
311
273
        tree_a.add('a')
312
 
        tree_a.commit('1', rev_id=b'rev-1')
 
274
        tree_a.commit('1', rev_id='rev-1')
313
275
        tree_a.flush()
314
276
        tree_a.rename_one('a', 'b')
315
277
        tree_a.commit('2')
316
 
        bzrdir_b = tree_a.controldir.sprout('B', revision_id=b'rev-1')
 
278
        bzrdir_b = tree_a.bzrdir.sprout('B', revision_id='rev-1')
317
279
        tree_b = bzrdir_b.open_workingtree()
318
280
        tree_b.lock_write()
319
281
        self.addCleanup(tree_b.unlock)
331
293
        tree_a.commit('commit 1')
332
294
        tree_a.add(['file_2'])
333
295
        tree_a.commit('commit 2')
334
 
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
 
296
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
335
297
        tree_b.rename_one('file_1', 'renamed')
336
298
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
337
299
        merger.merge_type = _mod_merge.Merge3Merger
345
307
        tree_a.commit('commit 1')
346
308
        tree_a.add(['file_2'])
347
309
        tree_a.commit('commit 2')
348
 
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
 
310
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
349
311
        tree_b.rename_one('file_1', 'renamed')
350
312
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
351
313
        merger.merge_type = _mod_merge.WeaveMerger
364
326
        'c', but not 'b'.
365
327
        """
366
328
        this_tree = self.make_branch_and_tree('this')
367
 
        self.build_tree_contents([('this/file', b"a\n")])
 
329
        self.build_tree_contents([('this/file', "a\n")])
368
330
        this_tree.add('file')
369
331
        this_tree.commit('rev1')
370
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
371
 
        self.build_tree_contents([('other/file', b"a\nb\n")])
372
 
        other_tree.commit('rev2b', rev_id=b'rev2b')
373
 
        self.build_tree_contents([('other/file', b"c\na\nb\n")])
374
 
        other_tree.commit('rev3b', rev_id=b'rev3b')
 
332
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
333
        self.build_tree_contents([('other/file', "a\nb\n")])
 
334
        other_tree.commit('rev2b', rev_id='rev2b')
 
335
        self.build_tree_contents([('other/file', "c\na\nb\n")])
 
336
        other_tree.commit('rev3b', rev_id='rev3b')
375
337
        this_tree.lock_write()
376
338
        self.addCleanup(this_tree.unlock)
377
339
        return this_tree, other_tree
378
340
 
379
341
    def test_weave_cherrypick(self):
380
342
        this_tree, other_tree = self.prepare_cherrypick()
381
 
        merger = _mod_merge.Merger.from_revision_ids(
382
 
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
 
343
        merger = _mod_merge.Merger.from_revision_ids(None,
 
344
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
383
345
        merger.merge_type = _mod_merge.WeaveMerger
384
346
        merger.do_merge()
385
 
        self.assertFileEqual(b'c\na\n', 'this/file')
 
347
        self.assertFileEqual('c\na\n', 'this/file')
386
348
 
387
349
    def test_weave_cannot_reverse_cherrypick(self):
388
350
        this_tree, other_tree = self.prepare_cherrypick()
389
 
        merger = _mod_merge.Merger.from_revision_ids(
390
 
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
 
351
        merger = _mod_merge.Merger.from_revision_ids(None,
 
352
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
391
353
        merger.merge_type = _mod_merge.WeaveMerger
392
354
        self.assertRaises(errors.CannotReverseCherrypick, merger.do_merge)
393
355
 
394
356
    def test_merge3_can_reverse_cherrypick(self):
395
357
        this_tree, other_tree = self.prepare_cherrypick()
396
 
        merger = _mod_merge.Merger.from_revision_ids(
397
 
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
 
358
        merger = _mod_merge.Merger.from_revision_ids(None,
 
359
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
398
360
        merger.merge_type = _mod_merge.Merge3Merger
399
361
        merger.do_merge()
400
362
 
401
363
    def test_merge3_will_detect_cherrypick(self):
402
364
        this_tree = self.make_branch_and_tree('this')
403
 
        self.build_tree_contents([('this/file', b"a\n")])
 
365
        self.build_tree_contents([('this/file', "a\n")])
404
366
        this_tree.add('file')
405
367
        this_tree.commit('rev1')
406
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
407
 
        self.build_tree_contents([('other/file', b"a\nb\n")])
408
 
        other_tree.commit('rev2b', rev_id=b'rev2b')
409
 
        self.build_tree_contents([('other/file', b"a\nb\nc\n")])
410
 
        other_tree.commit('rev3b', rev_id=b'rev3b')
 
368
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
369
        self.build_tree_contents([('other/file', "a\nb\n")])
 
370
        other_tree.commit('rev2b', rev_id='rev2b')
 
371
        self.build_tree_contents([('other/file', "a\nb\nc\n")])
 
372
        other_tree.commit('rev3b', rev_id='rev3b')
411
373
        this_tree.lock_write()
412
374
        self.addCleanup(this_tree.unlock)
413
375
 
414
 
        merger = _mod_merge.Merger.from_revision_ids(
415
 
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
 
376
        merger = _mod_merge.Merger.from_revision_ids(None,
 
377
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
416
378
        merger.merge_type = _mod_merge.Merge3Merger
417
379
        merger.do_merge()
418
 
        self.assertFileEqual(b'a\n'
419
 
                             b'<<<<<<< TREE\n'
420
 
                             b'=======\n'
421
 
                             b'c\n'
422
 
                             b'>>>>>>> MERGE-SOURCE\n',
 
380
        self.assertFileEqual('a\n'
 
381
                             '<<<<<<< TREE\n'
 
382
                             '=======\n'
 
383
                             'c\n'
 
384
                             '>>>>>>> MERGE-SOURCE\n',
423
385
                             'this/file')
424
386
 
425
 
    def test_merge_reverse_revision_range(self):
426
 
        tree = self.make_branch_and_tree(".")
427
 
        tree.lock_write()
428
 
        self.addCleanup(tree.unlock)
429
 
        self.build_tree(['a'])
430
 
        tree.add('a')
431
 
        first_rev = tree.commit("added a")
432
 
        merger = _mod_merge.Merger.from_revision_ids(tree,
433
 
                                                     _mod_revision.NULL_REVISION,
434
 
                                                     first_rev)
435
 
        merger.merge_type = _mod_merge.Merge3Merger
436
 
        merger.interesting_files = 'a'
437
 
        conflict_count = merger.do_merge()
438
 
        self.assertEqual(0, conflict_count)
439
 
 
440
 
        self.assertPathDoesNotExist("a")
441
 
        tree.revert()
442
 
        self.assertPathExists("a")
443
 
 
444
387
    def test_make_merger(self):
445
388
        this_tree = self.make_branch_and_tree('this')
446
 
        this_tree.commit('rev1', rev_id=b'rev1')
447
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
448
 
        this_tree.commit('rev2', rev_id=b'rev2a')
449
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
389
        this_tree.commit('rev1', rev_id='rev1')
 
390
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
391
        this_tree.commit('rev2', rev_id='rev2a')
 
392
        other_tree.commit('rev2', rev_id='rev2b')
450
393
        this_tree.lock_write()
451
394
        self.addCleanup(this_tree.unlock)
452
 
        merger = _mod_merge.Merger.from_revision_ids(
453
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
395
        merger = _mod_merge.Merger.from_revision_ids(None,
 
396
            this_tree, 'rev2b', other_branch=other_tree.branch)
454
397
        merger.merge_type = _mod_merge.Merge3Merger
455
398
        tree_merger = merger.make_merger()
456
399
        self.assertIs(_mod_merge.Merge3Merger, tree_merger.__class__)
457
 
        self.assertEqual(b'rev2b',
458
 
                         tree_merger.other_tree.get_revision_id())
459
 
        self.assertEqual(b'rev1',
460
 
                         tree_merger.base_tree.get_revision_id())
461
 
        self.assertEqual(other_tree.branch, tree_merger.other_branch)
 
400
        self.assertEqual('rev2b', tree_merger.other_tree.get_revision_id())
 
401
        self.assertEqual('rev1', tree_merger.base_tree.get_revision_id())
462
402
 
463
403
    def test_make_preview_transform(self):
464
404
        this_tree = self.make_branch_and_tree('this')
465
 
        self.build_tree_contents([('this/file', b'1\n')])
466
 
        this_tree.add('file', b'file-id')
467
 
        this_tree.commit('rev1', rev_id=b'rev1')
468
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
469
 
        self.build_tree_contents([('this/file', b'1\n2a\n')])
470
 
        this_tree.commit('rev2', rev_id=b'rev2a')
471
 
        self.build_tree_contents([('other/file', b'2b\n1\n')])
472
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
405
        self.build_tree_contents([('this/file', '1\n')])
 
406
        this_tree.add('file', 'file-id')
 
407
        this_tree.commit('rev1', rev_id='rev1')
 
408
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
409
        self.build_tree_contents([('this/file', '1\n2a\n')])
 
410
        this_tree.commit('rev2', rev_id='rev2a')
 
411
        self.build_tree_contents([('other/file', '2b\n1\n')])
 
412
        other_tree.commit('rev2', rev_id='rev2b')
473
413
        this_tree.lock_write()
474
414
        self.addCleanup(this_tree.unlock)
475
 
        merger = _mod_merge.Merger.from_revision_ids(
476
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
415
        merger = _mod_merge.Merger.from_revision_ids(None,
 
416
            this_tree, 'rev2b', other_branch=other_tree.branch)
477
417
        merger.merge_type = _mod_merge.Merge3Merger
478
418
        tree_merger = merger.make_merger()
479
 
        with tree_merger.make_preview_transform() as tt:
480
 
            preview_tree = tt.get_preview_tree()
481
 
            with this_tree.get_file('file') as tree_file:
482
 
                self.assertEqual(b'1\n2a\n', tree_file.read())
483
 
            with preview_tree.get_file('file') as preview_file:
484
 
                self.assertEqual(b'2b\n1\n2a\n', preview_file.read())
 
419
        tt = tree_merger.make_preview_transform()
 
420
        self.addCleanup(tt.finalize)
 
421
        preview_tree = tt.get_preview_tree()
 
422
        tree_file = this_tree.get_file('file-id')
 
423
        try:
 
424
            self.assertEqual('1\n2a\n', tree_file.read())
 
425
        finally:
 
426
            tree_file.close()
 
427
        preview_file = preview_tree.get_file('file-id')
 
428
        try:
 
429
            self.assertEqual('2b\n1\n2a\n', preview_file.read())
 
430
        finally:
 
431
            preview_file.close()
485
432
 
486
433
    def test_do_merge(self):
487
434
        this_tree = self.make_branch_and_tree('this')
488
 
        self.build_tree_contents([('this/file', b'1\n')])
489
 
        this_tree.add('file', b'file-id')
490
 
        this_tree.commit('rev1', rev_id=b'rev1')
491
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
492
 
        self.build_tree_contents([('this/file', b'1\n2a\n')])
493
 
        this_tree.commit('rev2', rev_id=b'rev2a')
494
 
        self.build_tree_contents([('other/file', b'2b\n1\n')])
495
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
435
        self.build_tree_contents([('this/file', '1\n')])
 
436
        this_tree.add('file', 'file-id')
 
437
        this_tree.commit('rev1', rev_id='rev1')
 
438
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
439
        self.build_tree_contents([('this/file', '1\n2a\n')])
 
440
        this_tree.commit('rev2', rev_id='rev2a')
 
441
        self.build_tree_contents([('other/file', '2b\n1\n')])
 
442
        other_tree.commit('rev2', rev_id='rev2b')
496
443
        this_tree.lock_write()
497
444
        self.addCleanup(this_tree.unlock)
498
 
        merger = _mod_merge.Merger.from_revision_ids(
499
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
445
        merger = _mod_merge.Merger.from_revision_ids(None,
 
446
            this_tree, 'rev2b', other_branch=other_tree.branch)
500
447
        merger.merge_type = _mod_merge.Merge3Merger
501
448
        tree_merger = merger.make_merger()
502
449
        tt = tree_merger.do_merge()
503
 
        with this_tree.get_file('file') as tree_file:
504
 
            self.assertEqual(b'2b\n1\n2a\n', tree_file.read())
505
 
 
506
 
    def test_merge_require_tree_root(self):
507
 
        tree = self.make_branch_and_tree(".")
508
 
        tree.lock_write()
509
 
        self.addCleanup(tree.unlock)
510
 
        self.build_tree(['a'])
511
 
        tree.add('a')
512
 
        first_rev = tree.commit("added a")
513
 
        old_root_id = tree.path2id('')
514
 
        merger = _mod_merge.Merger.from_revision_ids(tree,
515
 
                                                     _mod_revision.NULL_REVISION,
516
 
                                                     first_rev)
517
 
        merger.merge_type = _mod_merge.Merge3Merger
518
 
        conflict_count = merger.do_merge()
519
 
        self.assertEqual(0, conflict_count)
520
 
        self.assertEqual({''}, set(tree.all_versioned_paths()))
521
 
        tree.set_parent_ids([])
 
450
        tree_file = this_tree.get_file('file-id')
 
451
        try:
 
452
            self.assertEqual('2b\n1\n2a\n', tree_file.read())
 
453
        finally:
 
454
            tree_file.close()
522
455
 
523
456
    def test_merge_add_into_deleted_root(self):
524
457
        # Yes, people actually do this.  And report bugs if it breaks.
525
458
        source = self.make_branch_and_tree('source', format='rich-root-pack')
526
459
        self.build_tree(['source/foo/'])
527
 
        source.add('foo', b'foo-id')
 
460
        source.add('foo', 'foo-id')
528
461
        source.commit('Add foo')
529
 
        target = source.controldir.sprout('target').open_workingtree()
530
 
        subtree = target.extract('foo')
 
462
        target = source.bzrdir.sprout('target').open_workingtree()
 
463
        subtree = target.extract('foo-id')
531
464
        subtree.commit('Delete root')
532
465
        self.build_tree(['source/bar'])
533
 
        source.add('bar', b'bar-id')
 
466
        source.add('bar', 'bar-id')
534
467
        source.commit('Add bar')
535
468
        subtree.merge_from_branch(source.branch)
536
469
 
543
476
        self.build_tree(['target/bla'])
544
477
        target.add('bla')
545
478
        target.commit('Add bla')
546
 
        nested = source.controldir.sprout('target/subtree').open_workingtree()
 
479
        nested = source.bzrdir.sprout('target/subtree').open_workingtree()
547
480
        target.subsume(nested)
548
481
        target.commit('Join nested')
549
482
        self.build_tree(['source/bar'])
556
489
class TestPlanMerge(TestCaseWithMemoryTransport):
557
490
 
558
491
    def setUp(self):
559
 
        super(TestPlanMerge, self).setUp()
 
492
        TestCaseWithMemoryTransport.setUp(self)
560
493
        mapper = versionedfile.PrefixMapper()
561
494
        factory = knit.make_file_factory(True, mapper)
562
495
        self.vf = factory(self.get_transport())
563
 
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile(b'root')
 
496
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile('root')
564
497
        self.plan_merge_vf.fallback_versionedfiles.append(self.vf)
565
498
 
566
499
    def add_version(self, key, parents, text):
567
 
        self.vf.add_lines(
568
 
            key, parents, [bytes([c]) + b'\n' for c in bytearray(text)])
 
500
        self.vf.add_lines(key, parents, [c+'\n' for c in text])
569
501
 
570
502
    def add_rev(self, prefix, revision_id, parents, text):
571
503
        self.add_version((prefix, revision_id), [(prefix, p) for p in parents],
573
505
 
574
506
    def add_uncommitted_version(self, key, parents, text):
575
507
        self.plan_merge_vf.add_lines(key, parents,
576
 
                                     [bytes([c]) + b'\n' for c in bytearray(text)])
 
508
                                     [c+'\n' for c in text])
577
509
 
578
510
    def setup_plan_merge(self):
579
 
        self.add_rev(b'root', b'A', [], b'abc')
580
 
        self.add_rev(b'root', b'B', [b'A'], b'acehg')
581
 
        self.add_rev(b'root', b'C', [b'A'], b'fabg')
582
 
        return _PlanMerge(b'B', b'C', self.plan_merge_vf, (b'root',))
 
511
        self.add_rev('root', 'A', [], 'abc')
 
512
        self.add_rev('root', 'B', ['A'], 'acehg')
 
513
        self.add_rev('root', 'C', ['A'], 'fabg')
 
514
        return _PlanMerge('B', 'C', self.plan_merge_vf, ('root',))
583
515
 
584
516
    def setup_plan_merge_uncommitted(self):
585
 
        self.add_version((b'root', b'A'), [], b'abc')
586
 
        self.add_uncommitted_version(
587
 
            (b'root', b'B:'), [(b'root', b'A')], b'acehg')
588
 
        self.add_uncommitted_version(
589
 
            (b'root', b'C:'), [(b'root', b'A')], b'fabg')
590
 
        return _PlanMerge(b'B:', b'C:', self.plan_merge_vf, (b'root',))
 
517
        self.add_version(('root', 'A'), [], 'abc')
 
518
        self.add_uncommitted_version(('root', 'B:'), [('root', 'A')], 'acehg')
 
519
        self.add_uncommitted_version(('root', 'C:'), [('root', 'A')], 'fabg')
 
520
        return _PlanMerge('B:', 'C:', self.plan_merge_vf, ('root',))
591
521
 
592
522
    def test_base_from_plan(self):
593
523
        self.setup_plan_merge()
594
 
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
 
524
        plan = self.plan_merge_vf.plan_merge('B', 'C')
595
525
        pwm = versionedfile.PlanWeaveMerge(plan)
596
 
        self.assertEqual([b'a\n', b'b\n', b'c\n'], pwm.base_from_plan())
 
526
        self.assertEqual(['a\n', 'b\n', 'c\n'], pwm.base_from_plan())
597
527
 
598
528
    def test_unique_lines(self):
599
529
        plan = self.setup_plan_merge()
600
530
        self.assertEqual(plan._unique_lines(
601
 
            plan._get_matching_blocks(b'B', b'C')),
 
531
            plan._get_matching_blocks('B', 'C')),
602
532
            ([1, 2, 3], [0, 2]))
603
533
 
604
534
    def test_plan_merge(self):
605
535
        self.setup_plan_merge()
606
 
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
 
536
        plan = self.plan_merge_vf.plan_merge('B', 'C')
607
537
        self.assertEqual([
608
 
            ('new-b', b'f\n'),
609
 
            ('unchanged', b'a\n'),
610
 
            ('killed-a', b'b\n'),
611
 
            ('killed-b', b'c\n'),
612
 
            ('new-a', b'e\n'),
613
 
            ('new-a', b'h\n'),
614
 
            ('new-a', b'g\n'),
615
 
            ('new-b', b'g\n')],
616
 
            list(plan))
 
538
                          ('new-b', 'f\n'),
 
539
                          ('unchanged', 'a\n'),
 
540
                          ('killed-a', 'b\n'),
 
541
                          ('killed-b', 'c\n'),
 
542
                          ('new-a', 'e\n'),
 
543
                          ('new-a', 'h\n'),
 
544
                          ('new-a', 'g\n'),
 
545
                          ('new-b', 'g\n')],
 
546
                         list(plan))
617
547
 
618
548
    def test_plan_merge_cherrypick(self):
619
 
        self.add_rev(b'root', b'A', [], b'abc')
620
 
        self.add_rev(b'root', b'B', [b'A'], b'abcde')
621
 
        self.add_rev(b'root', b'C', [b'A'], b'abcefg')
622
 
        self.add_rev(b'root', b'D', [b'A', b'B', b'C'], b'abcdegh')
623
 
        my_plan = _PlanMerge(b'B', b'D', self.plan_merge_vf, (b'root',))
 
549
        self.add_rev('root', 'A', [], 'abc')
 
550
        self.add_rev('root', 'B', ['A'], 'abcde')
 
551
        self.add_rev('root', 'C', ['A'], 'abcefg')
 
552
        self.add_rev('root', 'D', ['A', 'B', 'C'], 'abcdegh')
 
553
        my_plan = _PlanMerge('B', 'D', self.plan_merge_vf, ('root',))
624
554
        # We shortcut when one text supersedes the other in the per-file graph.
625
555
        # We don't actually need to compare the texts at this point.
626
556
        self.assertEqual([
627
 
            ('new-b', b'a\n'),
628
 
            ('new-b', b'b\n'),
629
 
            ('new-b', b'c\n'),
630
 
            ('new-b', b'd\n'),
631
 
            ('new-b', b'e\n'),
632
 
            ('new-b', b'g\n'),
633
 
            ('new-b', b'h\n')],
634
 
            list(my_plan.plan_merge()))
 
557
                          ('new-b', 'a\n'),
 
558
                          ('new-b', 'b\n'),
 
559
                          ('new-b', 'c\n'),
 
560
                          ('new-b', 'd\n'),
 
561
                          ('new-b', 'e\n'),
 
562
                          ('new-b', 'g\n'),
 
563
                          ('new-b', 'h\n')],
 
564
                          list(my_plan.plan_merge()))
635
565
 
636
566
    def test_plan_merge_no_common_ancestor(self):
637
 
        self.add_rev(b'root', b'A', [], b'abc')
638
 
        self.add_rev(b'root', b'B', [], b'xyz')
639
 
        my_plan = _PlanMerge(b'A', b'B', self.plan_merge_vf, (b'root',))
 
567
        self.add_rev('root', 'A', [], 'abc')
 
568
        self.add_rev('root', 'B', [], 'xyz')
 
569
        my_plan = _PlanMerge('A', 'B', self.plan_merge_vf, ('root',))
640
570
        self.assertEqual([
641
 
            ('new-a', b'a\n'),
642
 
            ('new-a', b'b\n'),
643
 
            ('new-a', b'c\n'),
644
 
            ('new-b', b'x\n'),
645
 
            ('new-b', b'y\n'),
646
 
            ('new-b', b'z\n')],
647
 
            list(my_plan.plan_merge()))
 
571
                          ('new-a', 'a\n'),
 
572
                          ('new-a', 'b\n'),
 
573
                          ('new-a', 'c\n'),
 
574
                          ('new-b', 'x\n'),
 
575
                          ('new-b', 'y\n'),
 
576
                          ('new-b', 'z\n')],
 
577
                          list(my_plan.plan_merge()))
648
578
 
649
579
    def test_plan_merge_tail_ancestors(self):
650
580
        # The graph looks like this:
666
596
        # are already present in E
667
597
 
668
598
        # Introduce the base text
669
 
        self.add_rev(b'root', b'A', [], b'abc')
 
599
        self.add_rev('root', 'A', [], 'abc')
670
600
        # Introduces a new line B
671
 
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
 
601
        self.add_rev('root', 'B', ['A'], 'aBbc')
672
602
        # Introduces a new line C
673
 
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
 
603
        self.add_rev('root', 'C', ['A'], 'abCc')
674
604
        # Introduce new line D
675
 
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
 
605
        self.add_rev('root', 'D', ['B'], 'DaBbc')
676
606
        # Merges B and C by just incorporating both
677
 
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
 
607
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
678
608
        # Introduce new line F
679
 
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
 
609
        self.add_rev('root', 'F', ['C'], 'abCcF')
680
610
        # Merge D & E by just combining the texts
681
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
 
611
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
682
612
        # Merge F & E by just combining the texts
683
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
 
613
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
684
614
        # Merge G & H by just combining texts
685
 
        self.add_rev(b'root', b'I', [b'G', b'H'], b'DaBbCcF')
 
615
        self.add_rev('root', 'I', ['G', 'H'], 'DaBbCcF')
686
616
        # Merge G & H but supersede an old line in B
687
 
        self.add_rev(b'root', b'J', [b'H', b'G'], b'DaJbCcF')
688
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
617
        self.add_rev('root', 'J', ['H', 'G'], 'DaJbCcF')
 
618
        plan = self.plan_merge_vf.plan_merge('I', 'J')
689
619
        self.assertEqual([
690
 
            ('unchanged', b'D\n'),
691
 
            ('unchanged', b'a\n'),
692
 
            ('killed-b', b'B\n'),
693
 
            ('new-b', b'J\n'),
694
 
            ('unchanged', b'b\n'),
695
 
            ('unchanged', b'C\n'),
696
 
            ('unchanged', b'c\n'),
697
 
            ('unchanged', b'F\n')],
698
 
            list(plan))
 
620
                          ('unchanged', 'D\n'),
 
621
                          ('unchanged', 'a\n'),
 
622
                          ('killed-b', 'B\n'),
 
623
                          ('new-b', 'J\n'),
 
624
                          ('unchanged', 'b\n'),
 
625
                          ('unchanged', 'C\n'),
 
626
                          ('unchanged', 'c\n'),
 
627
                          ('unchanged', 'F\n')],
 
628
                         list(plan))
699
629
 
700
630
    def test_plan_merge_tail_triple_ancestors(self):
701
631
        # The graph looks like this:
715
645
        # a third LCA that doesn't add new lines, but will trigger our more
716
646
        # involved ancestry logic
717
647
 
718
 
        self.add_rev(b'root', b'A', [], b'abc')
719
 
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
720
 
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
721
 
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
722
 
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
723
 
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
724
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
725
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
726
 
        self.add_rev(b'root', b'Q', [b'E'], b'aBbCc')
727
 
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DaBbCcF')
 
648
        self.add_rev('root', 'A', [], 'abc')
 
649
        self.add_rev('root', 'B', ['A'], 'aBbc')
 
650
        self.add_rev('root', 'C', ['A'], 'abCc')
 
651
        self.add_rev('root', 'D', ['B'], 'DaBbc')
 
652
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
 
653
        self.add_rev('root', 'F', ['C'], 'abCcF')
 
654
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
 
655
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
 
656
        self.add_rev('root', 'Q', ['E'], 'aBbCc')
 
657
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DaBbCcF')
728
658
        # Merge G & H but supersede an old line in B
729
 
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DaJbCcF')
730
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
659
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DaJbCcF')
 
660
        plan = self.plan_merge_vf.plan_merge('I', 'J')
731
661
        self.assertEqual([
732
 
            ('unchanged', b'D\n'),
733
 
            ('unchanged', b'a\n'),
734
 
            ('killed-b', b'B\n'),
735
 
            ('new-b', b'J\n'),
736
 
            ('unchanged', b'b\n'),
737
 
            ('unchanged', b'C\n'),
738
 
            ('unchanged', b'c\n'),
739
 
            ('unchanged', b'F\n')],
740
 
            list(plan))
 
662
                          ('unchanged', 'D\n'),
 
663
                          ('unchanged', 'a\n'),
 
664
                          ('killed-b', 'B\n'),
 
665
                          ('new-b', 'J\n'),
 
666
                          ('unchanged', 'b\n'),
 
667
                          ('unchanged', 'C\n'),
 
668
                          ('unchanged', 'c\n'),
 
669
                          ('unchanged', 'F\n')],
 
670
                         list(plan))
741
671
 
742
672
    def test_plan_merge_2_tail_triple_ancestors(self):
743
673
        # The graph looks like this:
755
685
        # This is meant to test after hitting a 3-way LCA, and multiple tail
756
686
        # ancestors (only have NULL_REVISION in common)
757
687
 
758
 
        self.add_rev(b'root', b'A', [], b'abc')
759
 
        self.add_rev(b'root', b'B', [], b'def')
760
 
        self.add_rev(b'root', b'D', [b'A'], b'Dabc')
761
 
        self.add_rev(b'root', b'E', [b'A', b'B'], b'abcdef')
762
 
        self.add_rev(b'root', b'F', [b'B'], b'defF')
763
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'Dabcdef')
764
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'abcdefF')
765
 
        self.add_rev(b'root', b'Q', [b'E'], b'abcdef')
766
 
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DabcdefF')
 
688
        self.add_rev('root', 'A', [], 'abc')
 
689
        self.add_rev('root', 'B', [], 'def')
 
690
        self.add_rev('root', 'D', ['A'], 'Dabc')
 
691
        self.add_rev('root', 'E', ['A', 'B'], 'abcdef')
 
692
        self.add_rev('root', 'F', ['B'], 'defF')
 
693
        self.add_rev('root', 'G', ['D', 'E'], 'Dabcdef')
 
694
        self.add_rev('root', 'H', ['F', 'E'], 'abcdefF')
 
695
        self.add_rev('root', 'Q', ['E'], 'abcdef')
 
696
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DabcdefF')
767
697
        # Merge G & H but supersede an old line in B
768
 
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DabcdJfF')
769
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
698
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DabcdJfF')
 
699
        plan = self.plan_merge_vf.plan_merge('I', 'J')
770
700
        self.assertEqual([
771
 
            ('unchanged', b'D\n'),
772
 
            ('unchanged', b'a\n'),
773
 
            ('unchanged', b'b\n'),
774
 
            ('unchanged', b'c\n'),
775
 
            ('unchanged', b'd\n'),
776
 
            ('killed-b', b'e\n'),
777
 
            ('new-b', b'J\n'),
778
 
            ('unchanged', b'f\n'),
779
 
            ('unchanged', b'F\n')],
780
 
            list(plan))
 
701
                          ('unchanged', 'D\n'),
 
702
                          ('unchanged', 'a\n'),
 
703
                          ('unchanged', 'b\n'),
 
704
                          ('unchanged', 'c\n'),
 
705
                          ('unchanged', 'd\n'),
 
706
                          ('killed-b', 'e\n'),
 
707
                          ('new-b', 'J\n'),
 
708
                          ('unchanged', 'f\n'),
 
709
                          ('unchanged', 'F\n')],
 
710
                         list(plan))
781
711
 
782
712
    def test_plan_merge_uncommitted_files(self):
783
713
        self.setup_plan_merge_uncommitted()
784
 
        plan = self.plan_merge_vf.plan_merge(b'B:', b'C:')
 
714
        plan = self.plan_merge_vf.plan_merge('B:', 'C:')
785
715
        self.assertEqual([
786
 
            ('new-b', b'f\n'),
787
 
            ('unchanged', b'a\n'),
788
 
            ('killed-a', b'b\n'),
789
 
            ('killed-b', b'c\n'),
790
 
            ('new-a', b'e\n'),
791
 
            ('new-a', b'h\n'),
792
 
            ('new-a', b'g\n'),
793
 
            ('new-b', b'g\n')],
794
 
            list(plan))
 
716
                          ('new-b', 'f\n'),
 
717
                          ('unchanged', 'a\n'),
 
718
                          ('killed-a', 'b\n'),
 
719
                          ('killed-b', 'c\n'),
 
720
                          ('new-a', 'e\n'),
 
721
                          ('new-a', 'h\n'),
 
722
                          ('new-a', 'g\n'),
 
723
                          ('new-b', 'g\n')],
 
724
                         list(plan))
795
725
 
796
726
    def test_plan_merge_insert_order(self):
797
727
        """Weave merges are sensitive to the order of insertion.
801
731
        same ordering, then the lines match the parents, if they don't only
802
732
        *some* of the lines match.
803
733
        """
804
 
        self.add_rev(b'root', b'A', [], b'abcdef')
805
 
        self.add_rev(b'root', b'B', [b'A'], b'abwxcdef')
806
 
        self.add_rev(b'root', b'C', [b'A'], b'abyzcdef')
 
734
        self.add_rev('root', 'A', [], 'abcdef')
 
735
        self.add_rev('root', 'B', ['A'], 'abwxcdef')
 
736
        self.add_rev('root', 'C', ['A'], 'abyzcdef')
807
737
        # Merge, and resolve the conflict by adding *both* sets of lines
808
738
        # If we get the ordering wrong, these will look like new lines in D,
809
739
        # rather than carried over from B, C
810
 
        self.add_rev(b'root', b'D', [b'B', b'C'],
811
 
                     b'abwxyzcdef')
 
740
        self.add_rev('root', 'D', ['B', 'C'],
 
741
                         'abwxyzcdef')
812
742
        # Supersede the lines in B and delete the lines in C, which will
813
743
        # conflict if they are treated as being in D
814
 
        self.add_rev(b'root', b'E', [b'C', b'B'],
815
 
                     b'abnocdef')
 
744
        self.add_rev('root', 'E', ['C', 'B'],
 
745
                         'abnocdef')
816
746
        # Same thing for the lines in C
817
 
        self.add_rev(b'root', b'F', [b'C'], b'abpqcdef')
818
 
        plan = self.plan_merge_vf.plan_merge(b'D', b'E')
 
747
        self.add_rev('root', 'F', ['C'], 'abpqcdef')
 
748
        plan = self.plan_merge_vf.plan_merge('D', 'E')
819
749
        self.assertEqual([
820
 
            ('unchanged', b'a\n'),
821
 
            ('unchanged', b'b\n'),
822
 
            ('killed-b', b'w\n'),
823
 
            ('killed-b', b'x\n'),
824
 
            ('killed-b', b'y\n'),
825
 
            ('killed-b', b'z\n'),
826
 
            ('new-b', b'n\n'),
827
 
            ('new-b', b'o\n'),
828
 
            ('unchanged', b'c\n'),
829
 
            ('unchanged', b'd\n'),
830
 
            ('unchanged', b'e\n'),
831
 
            ('unchanged', b'f\n')],
832
 
            list(plan))
833
 
        plan = self.plan_merge_vf.plan_merge(b'E', b'D')
 
750
                          ('unchanged', 'a\n'),
 
751
                          ('unchanged', 'b\n'),
 
752
                          ('killed-b', 'w\n'),
 
753
                          ('killed-b', 'x\n'),
 
754
                          ('killed-b', 'y\n'),
 
755
                          ('killed-b', 'z\n'),
 
756
                          ('new-b', 'n\n'),
 
757
                          ('new-b', 'o\n'),
 
758
                          ('unchanged', 'c\n'),
 
759
                          ('unchanged', 'd\n'),
 
760
                          ('unchanged', 'e\n'),
 
761
                          ('unchanged', 'f\n')],
 
762
                         list(plan))
 
763
        plan = self.plan_merge_vf.plan_merge('E', 'D')
834
764
        # Going in the opposite direction shows the effect of the opposite plan
835
765
        self.assertEqual([
836
 
            ('unchanged', b'a\n'),
837
 
            ('unchanged', b'b\n'),
838
 
            ('new-b', b'w\n'),
839
 
            ('new-b', b'x\n'),
840
 
            ('killed-a', b'y\n'),
841
 
            ('killed-a', b'z\n'),
842
 
            ('killed-both', b'w\n'),
843
 
            ('killed-both', b'x\n'),
844
 
            ('new-a', b'n\n'),
845
 
            ('new-a', b'o\n'),
846
 
            ('unchanged', b'c\n'),
847
 
            ('unchanged', b'd\n'),
848
 
            ('unchanged', b'e\n'),
849
 
            ('unchanged', b'f\n')],
850
 
            list(plan))
 
766
                          ('unchanged', 'a\n'),
 
767
                          ('unchanged', 'b\n'),
 
768
                          ('new-b', 'w\n'),
 
769
                          ('new-b', 'x\n'),
 
770
                          ('killed-a', 'y\n'),
 
771
                          ('killed-a', 'z\n'),
 
772
                          ('killed-both', 'w\n'),
 
773
                          ('killed-both', 'x\n'),
 
774
                          ('new-a', 'n\n'),
 
775
                          ('new-a', 'o\n'),
 
776
                          ('unchanged', 'c\n'),
 
777
                          ('unchanged', 'd\n'),
 
778
                          ('unchanged', 'e\n'),
 
779
                          ('unchanged', 'f\n')],
 
780
                         list(plan))
851
781
 
852
782
    def test_plan_merge_criss_cross(self):
853
783
        # This is specificly trying to trigger problems when using limited
874
804
        #   'foo', it should appear as superseding the value in F (since it
875
805
        #   came from B), rather than conflict because of the resolution during
876
806
        #   C & D.
877
 
        self.add_rev(b'root', b'XX', [], b'qrs')
878
 
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
879
 
        self.add_rev(b'root', b'B', [b'A'], b'axcdef')
880
 
        self.add_rev(b'root', b'C', [b'B'], b'axcdefg')
881
 
        self.add_rev(b'root', b'D', [b'B'], b'haxcdef')
882
 
        self.add_rev(b'root', b'E', [b'A'], b'abcdyf')
 
807
        self.add_rev('root', 'XX', [], 'qrs')
 
808
        self.add_rev('root', 'A', ['XX'], 'abcdef')
 
809
        self.add_rev('root', 'B', ['A'], 'axcdef')
 
810
        self.add_rev('root', 'C', ['B'], 'axcdefg')
 
811
        self.add_rev('root', 'D', ['B'], 'haxcdef')
 
812
        self.add_rev('root', 'E', ['A'], 'abcdyf')
883
813
        # Simple combining of all texts
884
 
        self.add_rev(b'root', b'F', [b'C', b'D', b'E'], b'haxcdyfg')
 
814
        self.add_rev('root', 'F', ['C', 'D', 'E'], 'haxcdyfg')
885
815
        # combine and supersede 'x'
886
 
        self.add_rev(b'root', b'G', [b'C', b'D', b'E'], b'hazcdyfg')
887
 
        plan = self.plan_merge_vf.plan_merge(b'F', b'G')
 
816
        self.add_rev('root', 'G', ['C', 'D', 'E'], 'hazcdyfg')
 
817
        plan = self.plan_merge_vf.plan_merge('F', 'G')
888
818
        self.assertEqual([
889
 
            ('unchanged', b'h\n'),
890
 
            ('unchanged', b'a\n'),
891
 
            ('killed-base', b'b\n'),
892
 
            ('killed-b', b'x\n'),
893
 
            ('new-b', b'z\n'),
894
 
            ('unchanged', b'c\n'),
895
 
            ('unchanged', b'd\n'),
896
 
            ('killed-base', b'e\n'),
897
 
            ('unchanged', b'y\n'),
898
 
            ('unchanged', b'f\n'),
899
 
            ('unchanged', b'g\n')],
900
 
            list(plan))
901
 
        plan = self.plan_merge_vf.plan_lca_merge(b'F', b'G')
 
819
                          ('unchanged', 'h\n'),
 
820
                          ('unchanged', 'a\n'),
 
821
                          ('killed-base', 'b\n'),
 
822
                          ('killed-b', 'x\n'),
 
823
                          ('new-b', 'z\n'),
 
824
                          ('unchanged', 'c\n'),
 
825
                          ('unchanged', 'd\n'),
 
826
                          ('killed-base', 'e\n'),
 
827
                          ('unchanged', 'y\n'),
 
828
                          ('unchanged', 'f\n'),
 
829
                          ('unchanged', 'g\n')],
 
830
                         list(plan))
 
831
        plan = self.plan_merge_vf.plan_lca_merge('F', 'G')
902
832
        # This is one of the main differences between plan_merge and
903
833
        # plan_lca_merge. plan_lca_merge generates a conflict for 'x => z',
904
834
        # because 'x' was not present in one of the bases. However, in this
905
835
        # case it is spurious because 'x' does not exist in the global base A.
906
836
        self.assertEqual([
907
 
            ('unchanged', b'h\n'),
908
 
            ('unchanged', b'a\n'),
909
 
            ('conflicted-a', b'x\n'),
910
 
            ('new-b', b'z\n'),
911
 
            ('unchanged', b'c\n'),
912
 
            ('unchanged', b'd\n'),
913
 
            ('unchanged', b'y\n'),
914
 
            ('unchanged', b'f\n'),
915
 
            ('unchanged', b'g\n')],
916
 
            list(plan))
 
837
                          ('unchanged', 'h\n'),
 
838
                          ('unchanged', 'a\n'),
 
839
                          ('conflicted-a', 'x\n'),
 
840
                          ('new-b', 'z\n'),
 
841
                          ('unchanged', 'c\n'),
 
842
                          ('unchanged', 'd\n'),
 
843
                          ('unchanged', 'y\n'),
 
844
                          ('unchanged', 'f\n'),
 
845
                          ('unchanged', 'g\n')],
 
846
                         list(plan))
917
847
 
918
848
    def test_criss_cross_flip_flop(self):
919
849
        # This is specificly trying to trigger problems when using limited
921
851
        #       XX      unused ancestor, should not show up in the weave
922
852
        #       |
923
853
        #       A       Unique LCA
924
 
        #      / \
 
854
        #      / \  
925
855
        #     B   C     B & C both introduce a new line
926
 
        #     |\ /|
927
 
        #     | X |
928
 
        #     |/ \|
 
856
        #     |\ /|  
 
857
        #     | X |  
 
858
        #     |/ \| 
929
859
        #     D   E     B & C are both merged, so both are common ancestors
930
860
        #               In the process of merging, both sides order the new
931
861
        #               lines differently
932
862
        #
933
 
        self.add_rev(b'root', b'XX', [], b'qrs')
934
 
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
935
 
        self.add_rev(b'root', b'B', [b'A'], b'abcdgef')
936
 
        self.add_rev(b'root', b'C', [b'A'], b'abcdhef')
937
 
        self.add_rev(b'root', b'D', [b'B', b'C'], b'abcdghef')
938
 
        self.add_rev(b'root', b'E', [b'C', b'B'], b'abcdhgef')
939
 
        plan = list(self.plan_merge_vf.plan_merge(b'D', b'E'))
 
863
        self.add_rev('root', 'XX', [], 'qrs')
 
864
        self.add_rev('root', 'A', ['XX'], 'abcdef')
 
865
        self.add_rev('root', 'B', ['A'], 'abcdgef')
 
866
        self.add_rev('root', 'C', ['A'], 'abcdhef')
 
867
        self.add_rev('root', 'D', ['B', 'C'], 'abcdghef')
 
868
        self.add_rev('root', 'E', ['C', 'B'], 'abcdhgef')
 
869
        plan = list(self.plan_merge_vf.plan_merge('D', 'E'))
940
870
        self.assertEqual([
941
 
            ('unchanged', b'a\n'),
942
 
            ('unchanged', b'b\n'),
943
 
            ('unchanged', b'c\n'),
944
 
            ('unchanged', b'd\n'),
945
 
            ('new-b', b'h\n'),
946
 
            ('unchanged', b'g\n'),
947
 
            ('killed-b', b'h\n'),
948
 
            ('unchanged', b'e\n'),
949
 
            ('unchanged', b'f\n'),
950
 
            ], plan)
 
871
                          ('unchanged', 'a\n'),
 
872
                          ('unchanged', 'b\n'),
 
873
                          ('unchanged', 'c\n'),
 
874
                          ('unchanged', 'd\n'),
 
875
                          ('new-b', 'h\n'),
 
876
                          ('unchanged', 'g\n'),
 
877
                          ('killed-b', 'h\n'),
 
878
                          ('unchanged', 'e\n'),
 
879
                          ('unchanged', 'f\n'),
 
880
                         ], plan)
951
881
        pwm = versionedfile.PlanWeaveMerge(plan)
952
 
        self.assertEqualDiff(b'a\nb\nc\nd\ng\nh\ne\nf\n',
953
 
                             b''.join(pwm.base_from_plan()))
 
882
        self.assertEqualDiff('\n'.join('abcdghef') + '\n',
 
883
                             ''.join(pwm.base_from_plan()))
954
884
        # Reversing the order reverses the merge plan, and final order of 'hg'
955
885
        # => 'gh'
956
 
        plan = list(self.plan_merge_vf.plan_merge(b'E', b'D'))
 
886
        plan = list(self.plan_merge_vf.plan_merge('E', 'D'))
957
887
        self.assertEqual([
958
 
            ('unchanged', b'a\n'),
959
 
            ('unchanged', b'b\n'),
960
 
            ('unchanged', b'c\n'),
961
 
            ('unchanged', b'd\n'),
962
 
            ('new-b', b'g\n'),
963
 
            ('unchanged', b'h\n'),
964
 
            ('killed-b', b'g\n'),
965
 
            ('unchanged', b'e\n'),
966
 
            ('unchanged', b'f\n'),
967
 
            ], plan)
 
888
                          ('unchanged', 'a\n'),
 
889
                          ('unchanged', 'b\n'),
 
890
                          ('unchanged', 'c\n'),
 
891
                          ('unchanged', 'd\n'),
 
892
                          ('new-b', 'g\n'),
 
893
                          ('unchanged', 'h\n'),
 
894
                          ('killed-b', 'g\n'),
 
895
                          ('unchanged', 'e\n'),
 
896
                          ('unchanged', 'f\n'),
 
897
                         ], plan)
968
898
        pwm = versionedfile.PlanWeaveMerge(plan)
969
 
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ng\ne\nf\n',
970
 
                             b''.join(pwm.base_from_plan()))
 
899
        self.assertEqualDiff('\n'.join('abcdhgef') + '\n',
 
900
                             ''.join(pwm.base_from_plan()))
971
901
        # This is where lca differs, in that it (fairly correctly) determines
972
902
        # that there is a conflict because both sides resolved the merge
973
903
        # differently
974
 
        plan = list(self.plan_merge_vf.plan_lca_merge(b'D', b'E'))
 
904
        plan = list(self.plan_merge_vf.plan_lca_merge('D', 'E'))
975
905
        self.assertEqual([
976
 
            ('unchanged', b'a\n'),
977
 
            ('unchanged', b'b\n'),
978
 
            ('unchanged', b'c\n'),
979
 
            ('unchanged', b'd\n'),
980
 
            ('conflicted-b', b'h\n'),
981
 
            ('unchanged', b'g\n'),
982
 
            ('conflicted-a', b'h\n'),
983
 
            ('unchanged', b'e\n'),
984
 
            ('unchanged', b'f\n'),
985
 
            ], plan)
 
906
                          ('unchanged', 'a\n'),
 
907
                          ('unchanged', 'b\n'),
 
908
                          ('unchanged', 'c\n'),
 
909
                          ('unchanged', 'd\n'),
 
910
                          ('conflicted-b', 'h\n'),
 
911
                          ('unchanged', 'g\n'),
 
912
                          ('conflicted-a', 'h\n'),
 
913
                          ('unchanged', 'e\n'),
 
914
                          ('unchanged', 'f\n'),
 
915
                         ], plan)
986
916
        pwm = versionedfile.PlanWeaveMerge(plan)
987
 
        self.assertEqualDiff(b'a\nb\nc\nd\ng\ne\nf\n',
988
 
                             b''.join(pwm.base_from_plan()))
 
917
        self.assertEqualDiff('\n'.join('abcdgef') + '\n',
 
918
                             ''.join(pwm.base_from_plan()))
989
919
        # Reversing it changes what line is doubled, but still gives a
990
920
        # double-conflict
991
 
        plan = list(self.plan_merge_vf.plan_lca_merge(b'E', b'D'))
 
921
        plan = list(self.plan_merge_vf.plan_lca_merge('E', 'D'))
992
922
        self.assertEqual([
993
 
            ('unchanged', b'a\n'),
994
 
            ('unchanged', b'b\n'),
995
 
            ('unchanged', b'c\n'),
996
 
            ('unchanged', b'd\n'),
997
 
            ('conflicted-b', b'g\n'),
998
 
            ('unchanged', b'h\n'),
999
 
            ('conflicted-a', b'g\n'),
1000
 
            ('unchanged', b'e\n'),
1001
 
            ('unchanged', b'f\n'),
1002
 
            ], plan)
 
923
                          ('unchanged', 'a\n'),
 
924
                          ('unchanged', 'b\n'),
 
925
                          ('unchanged', 'c\n'),
 
926
                          ('unchanged', 'd\n'),
 
927
                          ('conflicted-b', 'g\n'),
 
928
                          ('unchanged', 'h\n'),
 
929
                          ('conflicted-a', 'g\n'),
 
930
                          ('unchanged', 'e\n'),
 
931
                          ('unchanged', 'f\n'),
 
932
                         ], plan)
1003
933
        pwm = versionedfile.PlanWeaveMerge(plan)
1004
 
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ne\nf\n',
1005
 
                             b''.join(pwm.base_from_plan()))
 
934
        self.assertEqualDiff('\n'.join('abcdhef') + '\n',
 
935
                             ''.join(pwm.base_from_plan()))
1006
936
 
1007
937
    def assertRemoveExternalReferences(self, filtered_parent_map,
1008
938
                                       child_map, tails, parent_map):
1023
953
    def test__remove_external_references(self):
1024
954
        # First, nothing to remove
1025
955
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1026
 
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
 
956
            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
1027
957
        # The reverse direction
1028
958
        self.assertRemoveExternalReferences({1: [2], 2: [3], 3: []},
1029
 
                                            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
 
959
            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
1030
960
        # Extra references
1031
961
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1032
 
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
 
962
            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
1033
963
        # Multiple tails
1034
964
        self.assertRemoveExternalReferences(
1035
965
            {4: [2, 3], 3: [], 2: [1], 1: []},
1045
975
 
1046
976
    def assertPruneTails(self, pruned_map, tails, parent_map):
1047
977
        child_map = {}
1048
 
        for key, parent_keys in parent_map.items():
 
978
        for key, parent_keys in parent_map.iteritems():
1049
979
            child_map.setdefault(key, [])
1050
980
            for pkey in parent_keys:
1051
981
                child_map.setdefault(pkey, []).append(key)
1066
996
        self.assertPruneTails({1: []}, [5],
1067
997
                              {1: [], 2: [3, 4], 3: [5], 4: [5], 5: []})
1068
998
        # Prune a partial chain
1069
 
        self.assertPruneTails({1: [6], 6: []}, [5],
 
999
        self.assertPruneTails({1: [6], 6:[]}, [5],
1070
1000
                              {1: [2, 6], 2: [3, 4], 3: [5], 4: [5], 5: [],
1071
1001
                               6: []})
1072
1002
        # Prune a chain with multiple tips, that pulls out intermediates
1073
 
        self.assertPruneTails({1: [3], 3: []}, [4, 5],
1074
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
1075
 
        self.assertPruneTails({1: [3], 3: []}, [5, 4],
1076
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
 
1003
        self.assertPruneTails({1:[3], 3:[]}, [4, 5],
 
1004
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
 
1005
        self.assertPruneTails({1:[3], 3:[]}, [5, 4],
 
1006
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
1077
1007
 
1078
1008
    def test_subtract_plans(self):
1079
1009
        old_plan = [
1080
 
            ('unchanged', b'a\n'),
1081
 
            ('new-a', b'b\n'),
1082
 
            ('killed-a', b'c\n'),
1083
 
            ('new-b', b'd\n'),
1084
 
            ('new-b', b'e\n'),
1085
 
            ('killed-b', b'f\n'),
1086
 
            ('killed-b', b'g\n'),
 
1010
        ('unchanged', 'a\n'),
 
1011
        ('new-a', 'b\n'),
 
1012
        ('killed-a', 'c\n'),
 
1013
        ('new-b', 'd\n'),
 
1014
        ('new-b', 'e\n'),
 
1015
        ('killed-b', 'f\n'),
 
1016
        ('killed-b', 'g\n'),
1087
1017
        ]
1088
1018
        new_plan = [
1089
 
            ('unchanged', b'a\n'),
1090
 
            ('new-a', b'b\n'),
1091
 
            ('killed-a', b'c\n'),
1092
 
            ('new-b', b'd\n'),
1093
 
            ('new-b', b'h\n'),
1094
 
            ('killed-b', b'f\n'),
1095
 
            ('killed-b', b'i\n'),
 
1019
        ('unchanged', 'a\n'),
 
1020
        ('new-a', 'b\n'),
 
1021
        ('killed-a', 'c\n'),
 
1022
        ('new-b', 'd\n'),
 
1023
        ('new-b', 'h\n'),
 
1024
        ('killed-b', 'f\n'),
 
1025
        ('killed-b', 'i\n'),
1096
1026
        ]
1097
1027
        subtracted_plan = [
1098
 
            ('unchanged', b'a\n'),
1099
 
            ('new-a', b'b\n'),
1100
 
            ('killed-a', b'c\n'),
1101
 
            ('new-b', b'h\n'),
1102
 
            ('unchanged', b'f\n'),
1103
 
            ('killed-b', b'i\n'),
 
1028
        ('unchanged', 'a\n'),
 
1029
        ('new-a', 'b\n'),
 
1030
        ('killed-a', 'c\n'),
 
1031
        ('new-b', 'h\n'),
 
1032
        ('unchanged', 'f\n'),
 
1033
        ('killed-b', 'i\n'),
1104
1034
        ]
1105
1035
        self.assertEqual(subtracted_plan,
1106
 
                         list(_PlanMerge._subtract_plans(old_plan, new_plan)))
 
1036
            list(_PlanMerge._subtract_plans(old_plan, new_plan)))
1107
1037
 
1108
1038
    def setup_merge_with_base(self):
1109
 
        self.add_rev(b'root', b'COMMON', [], b'abc')
1110
 
        self.add_rev(b'root', b'THIS', [b'COMMON'], b'abcd')
1111
 
        self.add_rev(b'root', b'BASE', [b'COMMON'], b'eabc')
1112
 
        self.add_rev(b'root', b'OTHER', [b'BASE'], b'eafb')
 
1039
        self.add_rev('root', 'COMMON', [], 'abc')
 
1040
        self.add_rev('root', 'THIS', ['COMMON'], 'abcd')
 
1041
        self.add_rev('root', 'BASE', ['COMMON'], 'eabc')
 
1042
        self.add_rev('root', 'OTHER', ['BASE'], 'eafb')
1113
1043
 
1114
1044
    def test_plan_merge_with_base(self):
1115
1045
        self.setup_merge_with_base()
1116
 
        plan = self.plan_merge_vf.plan_merge(b'THIS', b'OTHER', b'BASE')
1117
 
        self.assertEqual([('unchanged', b'a\n'),
1118
 
                          ('new-b', b'f\n'),
1119
 
                          ('unchanged', b'b\n'),
1120
 
                          ('killed-b', b'c\n'),
1121
 
                          ('new-a', b'd\n')
1122
 
                          ], list(plan))
 
1046
        plan = self.plan_merge_vf.plan_merge('THIS', 'OTHER', 'BASE')
 
1047
        self.assertEqual([('unchanged', 'a\n'),
 
1048
                          ('new-b', 'f\n'),
 
1049
                          ('unchanged', 'b\n'),
 
1050
                          ('killed-b', 'c\n'),
 
1051
                          ('new-a', 'd\n')
 
1052
                         ], list(plan))
1123
1053
 
1124
1054
    def test_plan_lca_merge(self):
1125
1055
        self.setup_plan_merge()
1126
 
        plan = self.plan_merge_vf.plan_lca_merge(b'B', b'C')
 
1056
        plan = self.plan_merge_vf.plan_lca_merge('B', 'C')
1127
1057
        self.assertEqual([
1128
 
            ('new-b', b'f\n'),
1129
 
            ('unchanged', b'a\n'),
1130
 
            ('killed-b', b'c\n'),
1131
 
            ('new-a', b'e\n'),
1132
 
            ('new-a', b'h\n'),
1133
 
            ('killed-a', b'b\n'),
1134
 
            ('unchanged', b'g\n')],
1135
 
            list(plan))
 
1058
                          ('new-b', 'f\n'),
 
1059
                          ('unchanged', 'a\n'),
 
1060
                          ('killed-b', 'c\n'),
 
1061
                          ('new-a', 'e\n'),
 
1062
                          ('new-a', 'h\n'),
 
1063
                          ('killed-a', 'b\n'),
 
1064
                          ('unchanged', 'g\n')],
 
1065
                         list(plan))
1136
1066
 
1137
1067
    def test_plan_lca_merge_uncommitted_files(self):
1138
1068
        self.setup_plan_merge_uncommitted()
1139
 
        plan = self.plan_merge_vf.plan_lca_merge(b'B:', b'C:')
 
1069
        plan = self.plan_merge_vf.plan_lca_merge('B:', 'C:')
1140
1070
        self.assertEqual([
1141
 
            ('new-b', b'f\n'),
1142
 
            ('unchanged', b'a\n'),
1143
 
            ('killed-b', b'c\n'),
1144
 
            ('new-a', b'e\n'),
1145
 
            ('new-a', b'h\n'),
1146
 
            ('killed-a', b'b\n'),
1147
 
            ('unchanged', b'g\n')],
1148
 
            list(plan))
 
1071
                          ('new-b', 'f\n'),
 
1072
                          ('unchanged', 'a\n'),
 
1073
                          ('killed-b', 'c\n'),
 
1074
                          ('new-a', 'e\n'),
 
1075
                          ('new-a', 'h\n'),
 
1076
                          ('killed-a', 'b\n'),
 
1077
                          ('unchanged', 'g\n')],
 
1078
                         list(plan))
1149
1079
 
1150
1080
    def test_plan_lca_merge_with_base(self):
1151
1081
        self.setup_merge_with_base()
1152
 
        plan = self.plan_merge_vf.plan_lca_merge(b'THIS', b'OTHER', b'BASE')
1153
 
        self.assertEqual([('unchanged', b'a\n'),
1154
 
                          ('new-b', b'f\n'),
1155
 
                          ('unchanged', b'b\n'),
1156
 
                          ('killed-b', b'c\n'),
1157
 
                          ('new-a', b'd\n')
1158
 
                          ], list(plan))
 
1082
        plan = self.plan_merge_vf.plan_lca_merge('THIS', 'OTHER', 'BASE')
 
1083
        self.assertEqual([('unchanged', 'a\n'),
 
1084
                          ('new-b', 'f\n'),
 
1085
                          ('unchanged', 'b\n'),
 
1086
                          ('killed-b', 'c\n'),
 
1087
                          ('new-a', 'd\n')
 
1088
                         ], list(plan))
1159
1089
 
1160
1090
    def test_plan_lca_merge_with_criss_cross(self):
1161
 
        self.add_version((b'root', b'ROOT'), [], b'abc')
 
1091
        self.add_version(('root', 'ROOT'), [], 'abc')
1162
1092
        # each side makes a change
1163
 
        self.add_version((b'root', b'REV1'), [(b'root', b'ROOT')], b'abcd')
1164
 
        self.add_version((b'root', b'REV2'), [(b'root', b'ROOT')], b'abce')
 
1093
        self.add_version(('root', 'REV1'), [('root', 'ROOT')], 'abcd')
 
1094
        self.add_version(('root', 'REV2'), [('root', 'ROOT')], 'abce')
1165
1095
        # both sides merge, discarding others' changes
1166
 
        self.add_version((b'root', b'LCA1'),
1167
 
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'abcd')
1168
 
        self.add_version((b'root', b'LCA2'),
1169
 
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'fabce')
1170
 
        plan = self.plan_merge_vf.plan_lca_merge(b'LCA1', b'LCA2')
1171
 
        self.assertEqual([('new-b', b'f\n'),
1172
 
                          ('unchanged', b'a\n'),
1173
 
                          ('unchanged', b'b\n'),
1174
 
                          ('unchanged', b'c\n'),
1175
 
                          ('conflicted-a', b'd\n'),
1176
 
                          ('conflicted-b', b'e\n'),
1177
 
                          ], list(plan))
 
1096
        self.add_version(('root', 'LCA1'),
 
1097
            [('root', 'REV1'), ('root', 'REV2')], 'abcd')
 
1098
        self.add_version(('root', 'LCA2'),
 
1099
            [('root', 'REV1'), ('root', 'REV2')], 'fabce')
 
1100
        plan = self.plan_merge_vf.plan_lca_merge('LCA1', 'LCA2')
 
1101
        self.assertEqual([('new-b', 'f\n'),
 
1102
                          ('unchanged', 'a\n'),
 
1103
                          ('unchanged', 'b\n'),
 
1104
                          ('unchanged', 'c\n'),
 
1105
                          ('conflicted-a', 'd\n'),
 
1106
                          ('conflicted-b', 'e\n'),
 
1107
                         ], list(plan))
1178
1108
 
1179
1109
    def test_plan_lca_merge_with_null(self):
1180
 
        self.add_version((b'root', b'A'), [], b'ab')
1181
 
        self.add_version((b'root', b'B'), [], b'bc')
1182
 
        plan = self.plan_merge_vf.plan_lca_merge(b'A', b'B')
1183
 
        self.assertEqual([('new-a', b'a\n'),
1184
 
                          ('unchanged', b'b\n'),
1185
 
                          ('new-b', b'c\n'),
1186
 
                          ], list(plan))
 
1110
        self.add_version(('root', 'A'), [], 'ab')
 
1111
        self.add_version(('root', 'B'), [], 'bc')
 
1112
        plan = self.plan_merge_vf.plan_lca_merge('A', 'B')
 
1113
        self.assertEqual([('new-a', 'a\n'),
 
1114
                          ('unchanged', 'b\n'),
 
1115
                          ('new-b', 'c\n'),
 
1116
                         ], list(plan))
1187
1117
 
1188
1118
    def test_plan_merge_with_delete_and_change(self):
1189
 
        self.add_rev(b'root', b'C', [], b'a')
1190
 
        self.add_rev(b'root', b'A', [b'C'], b'b')
1191
 
        self.add_rev(b'root', b'B', [b'C'], b'')
1192
 
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
1193
 
        self.assertEqual([('killed-both', b'a\n'),
1194
 
                          ('new-a', b'b\n'),
1195
 
                          ], list(plan))
 
1119
        self.add_rev('root', 'C', [], 'a')
 
1120
        self.add_rev('root', 'A', ['C'], 'b')
 
1121
        self.add_rev('root', 'B', ['C'], '')
 
1122
        plan = self.plan_merge_vf.plan_merge('A', 'B')
 
1123
        self.assertEqual([('killed-both', 'a\n'),
 
1124
                          ('new-a', 'b\n'),
 
1125
                         ], list(plan))
1196
1126
 
1197
1127
    def test_plan_merge_with_move_and_change(self):
1198
 
        self.add_rev(b'root', b'C', [], b'abcd')
1199
 
        self.add_rev(b'root', b'A', [b'C'], b'acbd')
1200
 
        self.add_rev(b'root', b'B', [b'C'], b'aBcd')
1201
 
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
1202
 
        self.assertEqual([('unchanged', b'a\n'),
1203
 
                          ('new-a', b'c\n'),
1204
 
                          ('killed-b', b'b\n'),
1205
 
                          ('new-b', b'B\n'),
1206
 
                          ('killed-a', b'c\n'),
1207
 
                          ('unchanged', b'd\n'),
1208
 
                          ], list(plan))
 
1128
        self.add_rev('root', 'C', [], 'abcd')
 
1129
        self.add_rev('root', 'A', ['C'], 'acbd')
 
1130
        self.add_rev('root', 'B', ['C'], 'aBcd')
 
1131
        plan = self.plan_merge_vf.plan_merge('A', 'B')
 
1132
        self.assertEqual([('unchanged', 'a\n'),
 
1133
                          ('new-a', 'c\n'),
 
1134
                          ('killed-b', 'b\n'),
 
1135
                          ('new-b', 'B\n'),
 
1136
                          ('killed-a', 'c\n'),
 
1137
                          ('unchanged', 'd\n'),
 
1138
                         ], list(plan))
1209
1139
 
1210
1140
 
1211
1141
class LoggingMerger(object):
1241
1171
        #  B C
1242
1172
        #
1243
1173
        builder = self.get_builder()
1244
 
        builder.build_snapshot(None,
1245
 
                               [('add', ('', None, 'directory', None))],
1246
 
                               revision_id=b'A-id')
1247
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1248
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1174
        builder.build_snapshot('A-id', None,
 
1175
            [('add', ('', None, 'directory', None))])
 
1176
        builder.build_snapshot('C-id', ['A-id'], [])
 
1177
        builder.build_snapshot('B-id', ['A-id'], [])
1249
1178
        return builder
1250
1179
 
1251
1180
    def setup_criss_cross_graph(self):
1259
1188
        # |X|
1260
1189
        # D E
1261
1190
        builder = self.setup_simple_graph()
1262
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1263
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1191
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1192
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1264
1193
        return builder
1265
1194
 
1266
 
    def make_Merger(self, builder, other_revision_id, interesting_files=None):
 
1195
    def make_Merger(self, builder, other_revision_id,
 
1196
                    interesting_files=None, interesting_ids=None):
1267
1197
        """Make a Merger object from a branch builder"""
1268
1198
        mem_tree = memorytree.MemoryTree.create_on_branch(builder.get_branch())
1269
1199
        mem_tree.lock_write()
1270
1200
        self.addCleanup(mem_tree.unlock)
1271
 
        merger = _mod_merge.Merger.from_revision_ids(
 
1201
        merger = _mod_merge.Merger.from_revision_ids(None,
1272
1202
            mem_tree, other_revision_id)
1273
1203
        merger.set_interesting_files(interesting_files)
 
1204
        # It seems there is no matching function for set_interesting_ids
 
1205
        merger.interesting_ids = interesting_ids
1274
1206
        merger.merge_type = _mod_merge.Merge3Merger
1275
1207
        return merger
1276
1208
 
1278
1210
class TestMergerInMemory(TestMergerBase):
1279
1211
 
1280
1212
    def test_cache_trees_with_revision_ids_None(self):
1281
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1213
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1282
1214
        original_cache = dict(merger._cached_trees)
1283
1215
        merger.cache_trees_with_revision_ids([None])
1284
1216
        self.assertEqual(original_cache, merger._cached_trees)
1285
1217
 
1286
1218
    def test_cache_trees_with_revision_ids_no_revision_id(self):
1287
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1219
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1288
1220
        original_cache = dict(merger._cached_trees)
1289
1221
        tree = self.make_branch_and_memory_tree('tree')
1290
1222
        merger.cache_trees_with_revision_ids([tree])
1291
1223
        self.assertEqual(original_cache, merger._cached_trees)
1292
1224
 
1293
1225
    def test_cache_trees_with_revision_ids_having_revision_id(self):
1294
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1226
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1295
1227
        original_cache = dict(merger._cached_trees)
1296
 
        tree = merger.this_branch.repository.revision_tree(b'B-id')
1297
 
        original_cache[b'B-id'] = tree
 
1228
        tree = merger.this_branch.repository.revision_tree('B-id')
 
1229
        original_cache['B-id'] = tree
1298
1230
        merger.cache_trees_with_revision_ids([tree])
1299
1231
        self.assertEqual(original_cache, merger._cached_trees)
1300
1232
 
1301
1233
    def test_find_base(self):
1302
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1303
 
        self.assertEqual(b'A-id', merger.base_rev_id)
 
1234
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1235
        self.assertEqual('A-id', merger.base_rev_id)
1304
1236
        self.assertFalse(merger._is_criss_cross)
1305
1237
        self.assertIs(None, merger._lca_trees)
1306
1238
 
1307
1239
    def test_find_base_criss_cross(self):
1308
1240
        builder = self.setup_criss_cross_graph()
1309
 
        merger = self.make_Merger(builder, b'E-id')
1310
 
        self.assertEqual(b'A-id', merger.base_rev_id)
 
1241
        merger = self.make_Merger(builder, 'E-id')
 
1242
        self.assertEqual('A-id', merger.base_rev_id)
1311
1243
        self.assertTrue(merger._is_criss_cross)
1312
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1313
 
                                              for t in merger._lca_trees])
 
1244
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1245
                                            for t in merger._lca_trees])
1314
1246
        # If we swap the order, we should get a different lca order
1315
 
        builder.build_snapshot([b'E-id'], [], revision_id=b'F-id')
1316
 
        merger = self.make_Merger(builder, b'D-id')
1317
 
        self.assertEqual([b'C-id', b'B-id'], [t.get_revision_id()
1318
 
                                              for t in merger._lca_trees])
 
1247
        builder.build_snapshot('F-id', ['E-id'], [])
 
1248
        merger = self.make_Merger(builder, 'D-id')
 
1249
        self.assertEqual(['C-id', 'B-id'], [t.get_revision_id()
 
1250
                                            for t in merger._lca_trees])
1319
1251
 
1320
1252
    def test_find_base_triple_criss_cross(self):
1321
1253
        #       A-.
1328
1260
        #    \|   |/
1329
1261
        #     G   H
1330
1262
        builder = self.setup_criss_cross_graph()
1331
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'F-id')
1332
 
        builder.build_snapshot([b'E-id', b'F-id'], [], revision_id=b'H-id')
1333
 
        builder.build_snapshot([b'D-id', b'F-id'], [], revision_id=b'G-id')
1334
 
        merger = self.make_Merger(builder, b'H-id')
1335
 
        self.assertEqual([b'B-id', b'C-id', b'F-id'],
 
1263
        builder.build_snapshot('F-id', ['A-id'], [])
 
1264
        builder.build_snapshot('H-id', ['E-id', 'F-id'], [])
 
1265
        builder.build_snapshot('G-id', ['D-id', 'F-id'], [])
 
1266
        merger = self.make_Merger(builder, 'H-id')
 
1267
        self.assertEqual(['B-id', 'C-id', 'F-id'],
1336
1268
                         [t.get_revision_id() for t in merger._lca_trees])
1337
1269
 
1338
 
    def test_find_base_new_root_criss_cross(self):
1339
 
        # A   B
1340
 
        # |\ /|
1341
 
        # | X |
1342
 
        # |/ \|
1343
 
        # C   D
1344
 
        builder = self.get_builder()
1345
 
        builder.build_snapshot(None,
1346
 
                               [('add', ('', None, 'directory', None))],
1347
 
                               revision_id=b'A-id')
1348
 
        builder.build_snapshot([],
1349
 
                               [('add', ('', None, 'directory', None))],
1350
 
                               revision_id=b'B-id')
1351
 
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'D-id')
1352
 
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'C-id')
1353
 
        merger = self.make_Merger(builder, b'D-id')
1354
 
        self.assertEqual(b'A-id', merger.base_rev_id)
1355
 
        self.assertTrue(merger._is_criss_cross)
1356
 
        self.assertEqual([b'A-id', b'B-id'], [t.get_revision_id()
1357
 
                                              for t in merger._lca_trees])
1358
 
 
1359
1270
    def test_no_criss_cross_passed_to_merge_type(self):
1360
1271
        class LCATreesMerger(LoggingMerger):
1361
1272
            supports_lca_trees = True
1362
1273
 
1363
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1274
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1364
1275
        merger.merge_type = LCATreesMerger
1365
1276
        merge_obj = merger.make_merger()
1366
1277
        self.assertIsInstance(merge_obj, LCATreesMerger)
1367
1278
        self.assertFalse('lca_trees' in merge_obj.kwargs)
1368
1279
 
1369
1280
    def test_criss_cross_passed_to_merge_type(self):
1370
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1281
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1371
1282
        merger.merge_type = _mod_merge.Merge3Merger
1372
1283
        merge_obj = merger.make_merger()
1373
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1374
 
                                              for t in merger._lca_trees])
 
1284
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1285
                                            for t in merger._lca_trees])
1375
1286
 
1376
1287
    def test_criss_cross_not_supported_merge_type(self):
1377
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1288
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1378
1289
        # We explicitly do not define supports_lca_trees
1379
1290
        merger.merge_type = LoggingMerger
1380
1291
        merge_obj = merger.make_merger()
1385
1296
        class UnsupportedLCATreesMerger(LoggingMerger):
1386
1297
            supports_lca_trees = False
1387
1298
 
1388
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1299
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1389
1300
        merger.merge_type = UnsupportedLCATreesMerger
1390
1301
        merge_obj = merger.make_merger()
1391
1302
        self.assertIsInstance(merge_obj, UnsupportedLCATreesMerger)
1395
1306
class TestMergerEntriesLCA(TestMergerBase):
1396
1307
 
1397
1308
    def make_merge_obj(self, builder, other_revision_id,
1398
 
                       interesting_files=None):
 
1309
                       interesting_files=None, interesting_ids=None):
1399
1310
        merger = self.make_Merger(builder, other_revision_id,
1400
 
                                  interesting_files=interesting_files)
 
1311
            interesting_files=interesting_files,
 
1312
            interesting_ids=interesting_ids)
1401
1313
        return merger.make_merger()
1402
1314
 
1403
1315
    def test_simple(self):
1404
1316
        builder = self.get_builder()
1405
 
        builder.build_snapshot(None,
1406
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1407
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1408
 
                               revision_id=b'A-id')
1409
 
        builder.build_snapshot([b'A-id'],
1410
 
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
1411
 
                               revision_id=b'C-id')
1412
 
        builder.build_snapshot([b'A-id'],
1413
 
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
1414
 
                               revision_id=b'B-id')
1415
 
        builder.build_snapshot([b'C-id', b'B-id'],
1416
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
1417
 
                               revision_id=b'E-id')
1418
 
        builder.build_snapshot([b'B-id', b'C-id'],
1419
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\n'))],
1420
 
                               revision_id=b'D-id', )
1421
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1317
        builder.build_snapshot('A-id', None,
 
1318
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1319
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1320
        builder.build_snapshot('C-id', ['A-id'],
 
1321
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
 
1322
        builder.build_snapshot('B-id', ['A-id'],
 
1323
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
 
1324
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1325
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
 
1326
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1327
            [('modify', ('a-id', 'a\nB\nb\nC\nc\n'))])
 
1328
        merge_obj = self.make_merge_obj(builder, 'E-id')
1422
1329
 
1423
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1424
 
                                              for t in merge_obj._lca_trees])
1425
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1330
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1331
                                            for t in merge_obj._lca_trees])
 
1332
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1426
1333
        entries = list(merge_obj._entries_lca())
1427
1334
 
1428
1335
        # (file_id, changed, parents, names, executable)
1429
1336
        # BASE, lca1, lca2, OTHER, THIS
1430
 
        root_id = b'a-root-id'
1431
 
        self.assertEqual([(b'a-id', True,
1432
 
                           ((u'a', [u'a', u'a']), u'a', u'a'),
 
1337
        root_id = 'a-root-id'
 
1338
        self.assertEqual([('a-id', True,
1433
1339
                           ((root_id, [root_id, root_id]), root_id, root_id),
1434
1340
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1435
1341
                           ((False, [False, False]), False, False)),
1436
 
                          ], entries)
 
1342
                         ], entries)
1437
1343
 
1438
1344
    def test_not_in_base(self):
1439
1345
        # LCAs all have the same last-modified revision for the file, as do
1448
1354
        #            G modifies 'bar'
1449
1355
 
1450
1356
        builder = self.get_builder()
1451
 
        builder.build_snapshot(None,
1452
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1453
 
                               revision_id=b'A-id')
1454
 
        builder.build_snapshot([b'A-id'],
1455
 
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
1456
 
                               revision_id=b'B-id')
1457
 
        builder.build_snapshot([b'A-id'],
1458
 
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
1459
 
                               revision_id=b'C-id')
1460
 
        builder.build_snapshot([b'B-id', b'C-id'],
1461
 
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
1462
 
                               revision_id=b'D-id')
1463
 
        builder.build_snapshot([b'C-id', b'B-id'],
1464
 
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
1465
 
                               revision_id=b'E-id')
1466
 
        builder.build_snapshot([b'E-id', b'D-id'],
1467
 
                               [('modify', (u'bar', b'd\ne\nf\nG\n'))],
1468
 
                               revision_id=b'G-id')
1469
 
        builder.build_snapshot([b'D-id', b'E-id'], [], revision_id=b'F-id')
1470
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1357
        builder.build_snapshot('A-id', None,
 
1358
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1359
        builder.build_snapshot('B-id', ['A-id'],
 
1360
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
1361
        builder.build_snapshot('C-id', ['A-id'],
 
1362
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
 
1363
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1364
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
 
1365
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1366
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
1367
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1368
            [('modify', (u'bar-id', 'd\ne\nf\nG\n'))])
 
1369
        builder.build_snapshot('F-id', ['D-id', 'E-id'], [])
 
1370
        merge_obj = self.make_merge_obj(builder, 'G-id')
1471
1371
 
1472
 
        self.assertEqual([b'D-id', b'E-id'], [t.get_revision_id()
1473
 
                                              for t in merge_obj._lca_trees])
1474
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1372
        self.assertEqual(['D-id', 'E-id'], [t.get_revision_id()
 
1373
                                            for t in merge_obj._lca_trees])
 
1374
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1475
1375
        entries = list(merge_obj._entries_lca())
1476
 
        root_id = b'a-root-id'
1477
 
        self.assertEqual([(b'bar-id', True,
1478
 
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
 
1376
        root_id = 'a-root-id'
 
1377
        self.assertEqual([('bar-id', True,
1479
1378
                           ((None, [root_id, root_id]), root_id, root_id),
1480
1379
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
1481
1380
                           ((None, [False, False]), False, False)),
1482
 
                          ], entries)
 
1381
                         ], entries)
1483
1382
 
1484
1383
    def test_not_in_this(self):
1485
1384
        builder = self.get_builder()
1486
 
        builder.build_snapshot(None,
1487
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1488
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1489
 
                               revision_id=b'A-id')
1490
 
        builder.build_snapshot([b'A-id'],
1491
 
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
1492
 
                               revision_id=b'B-id')
1493
 
        builder.build_snapshot([b'A-id'],
1494
 
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
1495
 
                               revision_id=b'C-id')
1496
 
        builder.build_snapshot([b'C-id', b'B-id'],
1497
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
1498
 
                               revision_id=b'E-id')
1499
 
        builder.build_snapshot([b'B-id', b'C-id'],
1500
 
                               [('unversion', 'a')],
1501
 
                               revision_id=b'D-id')
1502
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1385
        builder.build_snapshot('A-id', None,
 
1386
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1387
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1388
        builder.build_snapshot('B-id', ['A-id'],
 
1389
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
 
1390
        builder.build_snapshot('C-id', ['A-id'],
 
1391
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
 
1392
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1393
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
 
1394
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1395
            [('unversion', 'a-id')])
 
1396
        merge_obj = self.make_merge_obj(builder, 'E-id')
1503
1397
 
1504
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1505
 
                                              for t in merge_obj._lca_trees])
1506
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1398
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1399
                                            for t in merge_obj._lca_trees])
 
1400
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1507
1401
 
1508
1402
        entries = list(merge_obj._entries_lca())
1509
 
        root_id = b'a-root-id'
1510
 
        self.assertEqual([(b'a-id', True,
1511
 
                           ((u'a', [u'a', u'a']), u'a', None),
 
1403
        root_id = 'a-root-id'
 
1404
        self.assertEqual([('a-id', True,
1512
1405
                           ((root_id, [root_id, root_id]), root_id, None),
1513
1406
                           ((u'a', [u'a', u'a']), u'a', None),
1514
1407
                           ((False, [False, False]), False, None)),
1515
 
                          ], entries)
 
1408
                         ], entries)
1516
1409
 
1517
1410
    def test_file_not_in_one_lca(self):
1518
1411
        #   A   # just root
1521
1414
        #   |X|
1522
1415
        #   D E # D and E both have the file, unchanged from C
1523
1416
        builder = self.get_builder()
1524
 
        builder.build_snapshot(None,
1525
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1526
 
                               revision_id=b'A-id')
1527
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1528
 
        builder.build_snapshot([b'A-id'],
1529
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1530
 
                               revision_id=b'C-id')
1531
 
        builder.build_snapshot([b'C-id', b'B-id'],
1532
 
                               [], revision_id=b'E-id')  # Inherited from C
1533
 
        builder.build_snapshot([b'B-id', b'C-id'],  # Merged from C
1534
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1535
 
                               revision_id=b'D-id')
1536
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1417
        builder.build_snapshot('A-id', None,
 
1418
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1419
        builder.build_snapshot('B-id', ['A-id'], [])
 
1420
        builder.build_snapshot('C-id', ['A-id'],
 
1421
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1422
        builder.build_snapshot('E-id', ['C-id', 'B-id'], []) # Inherited from C
 
1423
        builder.build_snapshot('D-id', ['B-id', 'C-id'], # Merged from C
 
1424
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1425
        merge_obj = self.make_merge_obj(builder, 'E-id')
1537
1426
 
1538
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1539
 
                                              for t in merge_obj._lca_trees])
1540
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1427
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1428
                                            for t in merge_obj._lca_trees])
 
1429
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1541
1430
 
1542
1431
        entries = list(merge_obj._entries_lca())
1543
1432
        self.assertEqual([], entries)
1544
1433
 
1545
1434
    def test_not_in_other(self):
1546
1435
        builder = self.get_builder()
1547
 
        builder.build_snapshot(None,
1548
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1549
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1550
 
                               revision_id=b'A-id')
1551
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1552
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1553
 
        builder.build_snapshot(
1554
 
            [b'C-id', b'B-id'],
1555
 
            [('unversion', 'a')], revision_id=b'E-id')
1556
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1557
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1436
        builder.build_snapshot('A-id', None,
 
1437
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1438
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1439
        builder.build_snapshot('B-id', ['A-id'], [])
 
1440
        builder.build_snapshot('C-id', ['A-id'], [])
 
1441
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1442
            [('unversion', 'a-id')])
 
1443
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1444
        merge_obj = self.make_merge_obj(builder, 'E-id')
1558
1445
 
1559
1446
        entries = list(merge_obj._entries_lca())
1560
 
        root_id = b'a-root-id'
1561
 
        self.assertEqual([(b'a-id', True,
1562
 
                           ((u'a', [u'a', u'a']), None, u'a'),
 
1447
        root_id = 'a-root-id'
 
1448
        self.assertEqual([('a-id', True,
1563
1449
                           ((root_id, [root_id, root_id]), None, root_id),
1564
1450
                           ((u'a', [u'a', u'a']), None, u'a'),
1565
1451
                           ((False, [False, False]), None, False)),
1566
 
                          ], entries)
 
1452
                         ], entries)
1567
1453
 
1568
1454
    def test_not_in_other_or_lca(self):
1569
1455
        #       A    base, introduces 'foo'
1578
1464
        #   C => E, no changes
1579
1465
        # D would then win 'cleanly' and no record would be given
1580
1466
        builder = self.get_builder()
1581
 
        builder.build_snapshot(None,
1582
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1583
 
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
1584
 
                               revision_id=b'A-id')
1585
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1586
 
        builder.build_snapshot([b'A-id'],
1587
 
                               [('unversion', 'foo')], revision_id=b'C-id')
1588
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1589
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1590
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1467
        builder.build_snapshot('A-id', None,
 
1468
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1469
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
 
1470
        builder.build_snapshot('B-id', ['A-id'], [])
 
1471
        builder.build_snapshot('C-id', ['A-id'],
 
1472
            [('unversion', 'foo-id')])
 
1473
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1474
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1475
        merge_obj = self.make_merge_obj(builder, 'E-id')
1591
1476
 
1592
1477
        entries = list(merge_obj._entries_lca())
1593
1478
        self.assertEqual([], entries)
1608
1493
        # In this case, we have a conflict of how the changes were resolved. E
1609
1494
        # picked C and D picked B, so we should issue a conflict
1610
1495
        builder = self.get_builder()
1611
 
        builder.build_snapshot(None,
1612
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1613
 
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
1614
 
                               revision_id=b'A-id')
1615
 
        builder.build_snapshot([b'A-id'], [
1616
 
            ('modify', ('foo', b'new-content\n'))],
1617
 
            revision_id=b'B-id')
1618
 
        builder.build_snapshot([b'A-id'],
1619
 
                               [('unversion', 'foo')],
1620
 
                               revision_id=b'C-id')
1621
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1622
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1623
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1496
        builder.build_snapshot('A-id', None,
 
1497
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1498
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
 
1499
        builder.build_snapshot('B-id', ['A-id'], [
 
1500
            ('modify', ('foo-id', 'new-content\n'))])
 
1501
        builder.build_snapshot('C-id', ['A-id'],
 
1502
            [('unversion', 'foo-id')])
 
1503
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1504
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1505
        merge_obj = self.make_merge_obj(builder, 'E-id')
1624
1506
 
1625
1507
        entries = list(merge_obj._entries_lca())
1626
 
        root_id = b'a-root-id'
1627
 
        self.assertEqual([(b'foo-id', True,
1628
 
                           ((u'foo', [u'foo', None]), None, u'foo'),
 
1508
        root_id = 'a-root-id'
 
1509
        self.assertEqual([('foo-id', True,
1629
1510
                           ((root_id, [root_id, None]), None, root_id),
1630
1511
                           ((u'foo', [u'foo', None]), None, 'foo'),
1631
1512
                           ((False, [False, None]), None, False)),
1632
 
                          ], entries)
 
1513
                         ], entries)
1633
1514
 
1634
1515
    def test_only_in_one_lca(self):
1635
1516
        #   A   add only root
1648
1529
        #   A => C, add file, thus C supersedes B
1649
1530
        #   w/ C=BASE, D=THIS, E=OTHER we have 'happy convergence'
1650
1531
        builder = self.get_builder()
1651
 
        builder.build_snapshot(None,
1652
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1653
 
                               revision_id=b'A-id')
1654
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1655
 
        builder.build_snapshot([b'A-id'],
1656
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1657
 
                               revision_id=b'C-id')
1658
 
        builder.build_snapshot([b'C-id', b'B-id'],
1659
 
                               [('unversion', 'a')],
1660
 
                               revision_id=b'E-id')
1661
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1662
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1532
        builder.build_snapshot('A-id', None,
 
1533
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1534
        builder.build_snapshot('B-id', ['A-id'], [])
 
1535
        builder.build_snapshot('C-id', ['A-id'],
 
1536
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1537
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1538
            [('unversion', 'a-id')])
 
1539
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1540
        merge_obj = self.make_merge_obj(builder, 'E-id')
1663
1541
 
1664
1542
        entries = list(merge_obj._entries_lca())
1665
1543
        self.assertEqual([], entries)
1666
1544
 
1667
1545
    def test_only_in_other(self):
1668
1546
        builder = self.get_builder()
1669
 
        builder.build_snapshot(None,
1670
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1671
 
                               revision_id=b'A-id')
1672
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1673
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1674
 
        builder.build_snapshot([b'C-id', b'B-id'],
1675
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1676
 
                               revision_id=b'E-id')
1677
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1678
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1547
        builder.build_snapshot('A-id', None,
 
1548
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1549
        builder.build_snapshot('B-id', ['A-id'], [])
 
1550
        builder.build_snapshot('C-id', ['A-id'], [])
 
1551
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1552
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1553
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1554
        merge_obj = self.make_merge_obj(builder, 'E-id')
1679
1555
 
1680
1556
        entries = list(merge_obj._entries_lca())
1681
 
        root_id = b'a-root-id'
1682
 
        self.assertEqual([(b'a-id', True,
1683
 
                           ((None, [None, None]), u'a', None),
 
1557
        root_id = 'a-root-id'
 
1558
        self.assertEqual([('a-id', True,
1684
1559
                           ((None, [None, None]), root_id, None),
1685
1560
                           ((None, [None, None]), u'a', None),
1686
1561
                           ((None, [None, None]), False, None)),
1687
 
                          ], entries)
 
1562
                         ], entries)
1688
1563
 
1689
1564
    def test_one_lca_supersedes(self):
1690
1565
        # One LCA supersedes the other LCAs last modified value, but the
1701
1576
        #   though its LCAs disagree. This is because the modification in E
1702
1577
        #   completely supersedes the value in D.
1703
1578
        builder = self.get_builder()
1704
 
        builder.build_snapshot(None,
1705
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1706
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1707
 
                               revision_id=b'A-id')
1708
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1709
 
        builder.build_snapshot([b'A-id'],
1710
 
                               [('modify', ('foo', b'B content\n'))],
1711
 
                               revision_id=b'B-id')
1712
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1713
 
        builder.build_snapshot([b'C-id', b'B-id'],
1714
 
                               [('modify', ('foo', b'E content\n'))],
1715
 
                               revision_id=b'E-id')
1716
 
        builder.build_snapshot([b'E-id', b'D-id'], [], revision_id=b'G-id')
1717
 
        builder.build_snapshot([b'D-id', b'E-id'],
1718
 
                               [('modify', ('foo', b'F content\n'))],
1719
 
                               revision_id=b'F-id')
1720
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1579
        builder.build_snapshot('A-id', None,
 
1580
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1581
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1582
        builder.build_snapshot('C-id', ['A-id'], [])
 
1583
        builder.build_snapshot('B-id', ['A-id'],
 
1584
            [('modify', ('foo-id', 'B content\n'))])
 
1585
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1586
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1587
            [('modify', ('foo-id', 'E content\n'))])
 
1588
        builder.build_snapshot('G-id', ['E-id', 'D-id'], [])
 
1589
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1590
            [('modify', ('foo-id', 'F content\n'))])
 
1591
        merge_obj = self.make_merge_obj(builder, 'G-id')
1721
1592
 
1722
1593
        self.assertEqual([], list(merge_obj._entries_lca()))
1723
1594
 
1751
1622
        # aren't supporting it yet.
1752
1623
        #
1753
1624
        builder = self.get_builder()
1754
 
        builder.build_snapshot(None,
1755
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1756
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1757
 
                               revision_id=b'A-id')
1758
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1759
 
        builder.build_snapshot([b'A-id'],
1760
 
                               [('rename', ('foo', 'bar'))],
1761
 
                               revision_id=b'B-id')
1762
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1763
 
        builder.build_snapshot([b'C-id', b'B-id'],
1764
 
                               [('rename', ('foo', 'bing'))],
1765
 
                               revision_id=b'E-id')  # override to bing
1766
 
        builder.build_snapshot([b'E-id', b'D-id'],
1767
 
                               [('rename', ('bing', 'barry'))],
1768
 
                               revision_id=b'G-id')  # override to barry
1769
 
        builder.build_snapshot([b'D-id', b'E-id'],
1770
 
                               [('rename', ('bar', 'bing'))],
1771
 
                               revision_id=b'F-id')  # Merge in E's change
1772
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1625
        builder.build_snapshot('A-id', None,
 
1626
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1627
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1628
        builder.build_snapshot('C-id', ['A-id'], [])
 
1629
        builder.build_snapshot('B-id', ['A-id'],
 
1630
            [('rename', ('foo', 'bar'))])
 
1631
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1632
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1633
            [('rename', ('foo', 'bing'))]) # override to bing
 
1634
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1635
            [('rename', ('bing', 'barry'))]) # override to barry
 
1636
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1637
            [('rename', ('bar', 'bing'))]) # Merge in E's change
 
1638
        merge_obj = self.make_merge_obj(builder, 'G-id')
1773
1639
 
1774
1640
        self.expectFailure("We don't do an actual heads() check on lca values,"
1775
 
                           " or use the per-attribute graph",
1776
 
                           self.assertEqual, [], list(merge_obj._entries_lca()))
 
1641
            " or use the per-attribute graph",
 
1642
            self.assertEqual, [], list(merge_obj._entries_lca()))
1777
1643
 
1778
1644
    def test_one_lca_accidentally_pruned(self):
1779
1645
        # Another incorrect resolution from the same basic flaw:
1789
1655
        # be pruned from the LCAs, even though it was newly introduced by E
1790
1656
        # (superseding B).
1791
1657
        builder = self.get_builder()
1792
 
        builder.build_snapshot(None,
1793
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1794
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1795
 
                               revision_id=b'A-id')
1796
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1797
 
        builder.build_snapshot([b'A-id'],
1798
 
                               [('rename', ('foo', 'bar'))],
1799
 
                               revision_id=b'B-id')
1800
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1801
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1802
 
        builder.build_snapshot([b'E-id', b'D-id'],
1803
 
                               [('rename', ('foo', 'bar'))],
1804
 
                               revision_id=b'G-id')
1805
 
        builder.build_snapshot([b'D-id', b'E-id'],
1806
 
                               [('rename', ('bar', 'bing'))],
1807
 
                               revision_id=b'F-id')  # should end up conflicting
1808
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1658
        builder.build_snapshot('A-id', None,
 
1659
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1660
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1661
        builder.build_snapshot('C-id', ['A-id'], [])
 
1662
        builder.build_snapshot('B-id', ['A-id'],
 
1663
            [('rename', ('foo', 'bar'))])
 
1664
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1665
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1666
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1667
            [('rename', ('foo', 'bar'))])
 
1668
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1669
            [('rename', ('bar', 'bing'))]) # should end up conflicting
 
1670
        merge_obj = self.make_merge_obj(builder, 'G-id')
1809
1671
 
1810
1672
        entries = list(merge_obj._entries_lca())
1811
 
        root_id = b'a-root-id'
 
1673
        root_id = 'a-root-id'
1812
1674
        self.expectFailure("We prune values from BASE even when relevant.",
1813
 
                           self.assertEqual,
1814
 
                           [(b'foo-id', False,
1815
 
                             ((root_id, [root_id, root_id]), root_id, root_id),
1816
 
                               ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
1817
 
                               ((False, [False, False]), False, False)),
1818
 
                            ], entries)
 
1675
            self.assertEqual,
 
1676
                [('foo-id', False,
 
1677
                  ((root_id, [root_id, root_id]), root_id, root_id),
 
1678
                  ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
 
1679
                  ((False, [False, False]), False, False)),
 
1680
                ], entries)
1819
1681
 
1820
1682
    def test_both_sides_revert(self):
1821
1683
        # Both sides of a criss-cross revert the text to the lca
1826
1688
        #       D E  D reverts to B, E reverts to C
1827
1689
        # This should conflict
1828
1690
        builder = self.get_builder()
1829
 
        builder.build_snapshot(None,
1830
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1831
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1832
 
                               revision_id=b'A-id')
1833
 
        builder.build_snapshot([b'A-id'],
1834
 
                               [('modify', ('foo', b'B content\n'))],
1835
 
                               revision_id=b'B-id')
1836
 
        builder.build_snapshot([b'A-id'],
1837
 
                               [('modify', ('foo', b'C content\n'))],
1838
 
                               revision_id=b'C-id')
1839
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1840
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1841
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1691
        builder.build_snapshot('A-id', None,
 
1692
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1693
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1694
        builder.build_snapshot('B-id', ['A-id'],
 
1695
            [('modify', ('foo-id', 'B content\n'))])
 
1696
        builder.build_snapshot('C-id', ['A-id'],
 
1697
            [('modify', ('foo-id', 'C content\n'))])
 
1698
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1699
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1700
        merge_obj = self.make_merge_obj(builder, 'E-id')
1842
1701
 
1843
1702
        entries = list(merge_obj._entries_lca())
1844
 
        root_id = b'a-root-id'
1845
 
        self.assertEqual([(b'foo-id', True,
1846
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
1703
        root_id = 'a-root-id'
 
1704
        self.assertEqual([('foo-id', True,
1847
1705
                           ((root_id, [root_id, root_id]), root_id, root_id),
1848
1706
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1849
1707
                           ((False, [False, False]), False, False)),
1850
 
                          ], entries)
 
1708
                         ], entries)
1851
1709
 
1852
1710
    def test_different_lca_resolve_one_side_updates_content(self):
1853
1711
        # Both sides converge, but then one side updates the text.
1861
1719
        # We need to emit an entry for 'foo', because D & E differed on the
1862
1720
        # merge resolution
1863
1721
        builder = self.get_builder()
1864
 
        builder.build_snapshot(None,
1865
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1866
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1867
 
                               revision_id=b'A-id')
1868
 
        builder.build_snapshot([b'A-id'],
1869
 
                               [('modify', ('foo', b'B content\n'))],
1870
 
                               revision_id=b'B-id')
1871
 
        builder.build_snapshot([b'A-id'],
1872
 
                               [('modify', ('foo', b'C content\n'))],
1873
 
                               revision_id=b'C-id', )
1874
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1875
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1876
 
        builder.build_snapshot([b'D-id'],
1877
 
                               [('modify', ('foo', b'F content\n'))],
1878
 
                               revision_id=b'F-id')
1879
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1722
        builder.build_snapshot('A-id', None,
 
1723
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1724
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1725
        builder.build_snapshot('B-id', ['A-id'],
 
1726
            [('modify', ('foo-id', 'B content\n'))])
 
1727
        builder.build_snapshot('C-id', ['A-id'],
 
1728
            [('modify', ('foo-id', 'C content\n'))])
 
1729
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1730
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1731
        builder.build_snapshot('F-id', ['D-id'],
 
1732
            [('modify', ('foo-id', 'F content\n'))])
 
1733
        merge_obj = self.make_merge_obj(builder, 'E-id')
1880
1734
 
1881
1735
        entries = list(merge_obj._entries_lca())
1882
 
        root_id = b'a-root-id'
1883
 
        self.assertEqual([(b'foo-id', True,
1884
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
1736
        root_id = 'a-root-id'
 
1737
        self.assertEqual([('foo-id', True,
1885
1738
                           ((root_id, [root_id, root_id]), root_id, root_id),
1886
1739
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1887
1740
                           ((False, [False, False]), False, False)),
1888
 
                          ], entries)
 
1741
                         ], entries)
1889
1742
 
1890
1743
    def test_same_lca_resolution_one_side_updates_content(self):
1891
1744
        # Both sides converge, but then one side updates the text.
1902
1755
        # We need to conflict.
1903
1756
 
1904
1757
        builder = self.get_builder()
1905
 
        builder.build_snapshot(None,
1906
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1907
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1908
 
                               revision_id=b'A-id')
1909
 
        builder.build_snapshot([b'A-id'],
1910
 
                               [('modify', ('foo', b'B content\n'))],
1911
 
                               revision_id=b'B-id')
1912
 
        builder.build_snapshot([b'A-id'],
1913
 
                               [('modify', ('foo', b'C content\n'))],
1914
 
                               revision_id=b'C-id')
1915
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1916
 
        builder.build_snapshot([b'B-id', b'C-id'],
1917
 
                               [('modify', ('foo', b'C content\n'))],
1918
 
                               revision_id=b'D-id')  # Same as E
1919
 
        builder.build_snapshot([b'D-id'],
1920
 
                               [('modify', ('foo', b'F content\n'))],
1921
 
                               revision_id=b'F-id')
1922
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1758
        builder.build_snapshot('A-id', None,
 
1759
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1760
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1761
        builder.build_snapshot('B-id', ['A-id'],
 
1762
            [('modify', ('foo-id', 'B content\n'))])
 
1763
        builder.build_snapshot('C-id', ['A-id'],
 
1764
            [('modify', ('foo-id', 'C content\n'))])
 
1765
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1766
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1767
            [('modify', ('foo-id', 'C content\n'))]) # Same as E
 
1768
        builder.build_snapshot('F-id', ['D-id'],
 
1769
            [('modify', ('foo-id', 'F content\n'))])
 
1770
        merge_obj = self.make_merge_obj(builder, 'E-id')
1923
1771
 
1924
1772
        entries = list(merge_obj._entries_lca())
1925
1773
        self.expectFailure("We don't detect that LCA resolution was the"
1926
1774
                           " same on both sides",
1927
 
                           self.assertEqual, [], entries)
 
1775
            self.assertEqual, [], entries)
1928
1776
 
1929
1777
    def test_only_path_changed(self):
1930
1778
        builder = self.get_builder()
1931
 
        builder.build_snapshot(None,
1932
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1933
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1934
 
                               revision_id=b'A-id')
1935
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1936
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1937
 
        builder.build_snapshot([b'C-id', b'B-id'],
1938
 
                               [('rename', (u'a', u'b'))],
1939
 
                               revision_id=b'E-id')
1940
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1941
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1779
        builder.build_snapshot('A-id', None,
 
1780
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1781
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1782
        builder.build_snapshot('B-id', ['A-id'], [])
 
1783
        builder.build_snapshot('C-id', ['A-id'], [])
 
1784
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1785
            [('rename', (u'a', u'b'))])
 
1786
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1787
        merge_obj = self.make_merge_obj(builder, 'E-id')
1942
1788
        entries = list(merge_obj._entries_lca())
1943
 
        root_id = b'a-root-id'
 
1789
        root_id = 'a-root-id'
1944
1790
        # The content was not changed, only the path
1945
 
        self.assertEqual([(b'a-id', False,
1946
 
                           ((u'a', [u'a', u'a']), u'b', u'a'),
 
1791
        self.assertEqual([('a-id', False,
1947
1792
                           ((root_id, [root_id, root_id]), root_id, root_id),
1948
1793
                           ((u'a', [u'a', u'a']), u'b', u'a'),
1949
1794
                           ((False, [False, False]), False, False)),
1950
 
                          ], entries)
 
1795
                         ], entries)
1951
1796
 
1952
1797
    def test_kind_changed(self):
1953
1798
        # Identical content, except 'D' changes a-id into a directory
1954
1799
        builder = self.get_builder()
1955
 
        builder.build_snapshot(None,
1956
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1957
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1958
 
                               revision_id=b'A-id')
1959
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1960
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1961
 
        builder.build_snapshot([b'C-id', b'B-id'],
1962
 
                               [('unversion', 'a'),
1963
 
                                ('flush', None),
1964
 
                                ('add', (u'a', b'a-id', 'directory', None))],
1965
 
                               revision_id=b'E-id')
1966
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1967
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1800
        builder.build_snapshot('A-id', None,
 
1801
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1802
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1803
        builder.build_snapshot('B-id', ['A-id'], [])
 
1804
        builder.build_snapshot('C-id', ['A-id'], [])
 
1805
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1806
            [('unversion', 'a-id'),
 
1807
             ('add', (u'a', 'a-id', 'directory', None))])
 
1808
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1809
        merge_obj = self.make_merge_obj(builder, 'E-id')
1968
1810
        entries = list(merge_obj._entries_lca())
1969
 
        root_id = b'a-root-id'
 
1811
        root_id = 'a-root-id'
1970
1812
        # Only the kind was changed (content)
1971
 
        self.assertEqual([(b'a-id', True,
1972
 
                           ((u'a', [u'a', u'a']), u'a', u'a'),
 
1813
        self.assertEqual([('a-id', True,
1973
1814
                           ((root_id, [root_id, root_id]), root_id, root_id),
1974
1815
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1975
1816
                           ((False, [False, False]), False, False)),
1976
 
                          ], entries)
 
1817
                         ], entries)
1977
1818
 
1978
1819
    def test_this_changed_kind(self):
1979
1820
        # Identical content, but THIS changes a file to a directory
1980
1821
        builder = self.get_builder()
1981
 
        builder.build_snapshot(None,
1982
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1983
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1984
 
                               revision_id=b'A-id')
1985
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1986
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1987
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1988
 
        builder.build_snapshot([b'B-id', b'C-id'],
1989
 
                               [('unversion', 'a'),
1990
 
                                ('flush', None),
1991
 
                                ('add', (u'a', b'a-id', 'directory', None))],
1992
 
                               revision_id=b'D-id')
1993
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1822
        builder.build_snapshot('A-id', None,
 
1823
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1824
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1825
        builder.build_snapshot('B-id', ['A-id'], [])
 
1826
        builder.build_snapshot('C-id', ['A-id'], [])
 
1827
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1828
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1829
            [('unversion', 'a-id'),
 
1830
             ('add', (u'a', 'a-id', 'directory', None))])
 
1831
        merge_obj = self.make_merge_obj(builder, 'E-id')
1994
1832
        entries = list(merge_obj._entries_lca())
1995
1833
        # Only the kind was changed (content)
1996
1834
        self.assertEqual([], entries)
1998
1836
    def test_interesting_files(self):
1999
1837
        # Two files modified, but we should filter one of them
2000
1838
        builder = self.get_builder()
2001
 
        builder.build_snapshot(None,
2002
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2003
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2004
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2005
 
                               revision_id=b'A-id')
2006
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2007
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2008
 
        builder.build_snapshot([b'C-id', b'B-id'],
2009
 
                               [('modify', ('a', b'new-content\n')),
2010
 
                                ('modify', ('b', b'new-content\n'))],
2011
 
                               revision_id=b'E-id')
2012
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2013
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1839
        builder.build_snapshot('A-id', None,
 
1840
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1841
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1842
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1843
        builder.build_snapshot('B-id', ['A-id'], [])
 
1844
        builder.build_snapshot('C-id', ['A-id'], [])
 
1845
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1846
            [('modify', ('a-id', 'new-content\n')),
 
1847
             ('modify', ('b-id', 'new-content\n'))])
 
1848
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1849
        merge_obj = self.make_merge_obj(builder, 'E-id',
2014
1850
                                        interesting_files=['b'])
2015
1851
        entries = list(merge_obj._entries_lca())
2016
 
        root_id = b'a-root-id'
2017
 
        self.assertEqual([(b'b-id', True,
2018
 
                           ((u'b', [u'b', u'b']), u'b', u'b'),
 
1852
        root_id = 'a-root-id'
 
1853
        self.assertEqual([('b-id', True,
2019
1854
                           ((root_id, [root_id, root_id]), root_id, root_id),
2020
1855
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2021
1856
                           ((False, [False, False]), False, False)),
2022
 
                          ], entries)
 
1857
                         ], entries)
2023
1858
 
2024
1859
    def test_interesting_file_in_this(self):
2025
1860
        # This renamed the file, but it should still match the entry in other
2026
1861
        builder = self.get_builder()
2027
 
        builder.build_snapshot(None,
2028
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2029
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2030
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2031
 
                               revision_id=b'A-id')
2032
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2033
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2034
 
        builder.build_snapshot([b'C-id', b'B-id'],
2035
 
                               [('modify', ('a', b'new-content\n')),
2036
 
                                ('modify', ('b', b'new-content\n'))],
2037
 
                               revision_id=b'E-id')
2038
 
        builder.build_snapshot([b'B-id', b'C-id'],
2039
 
                               [('rename', ('b', 'c'))],
2040
 
                               revision_id=b'D-id')
2041
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1862
        builder.build_snapshot('A-id', None,
 
1863
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1864
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1865
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1866
        builder.build_snapshot('B-id', ['A-id'], [])
 
1867
        builder.build_snapshot('C-id', ['A-id'], [])
 
1868
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1869
            [('modify', ('a-id', 'new-content\n')),
 
1870
             ('modify', ('b-id', 'new-content\n'))])
 
1871
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1872
            [('rename', ('b', 'c'))])
 
1873
        merge_obj = self.make_merge_obj(builder, 'E-id',
2042
1874
                                        interesting_files=['c'])
2043
1875
        entries = list(merge_obj._entries_lca())
2044
 
        root_id = b'a-root-id'
2045
 
        self.assertEqual([(b'b-id', True,
2046
 
                           ((u'b', [u'b', u'b']), u'b', u'c'),
 
1876
        root_id = 'a-root-id'
 
1877
        self.assertEqual([('b-id', True,
2047
1878
                           ((root_id, [root_id, root_id]), root_id, root_id),
2048
1879
                           ((u'b', [u'b', u'b']), u'b', u'c'),
2049
1880
                           ((False, [False, False]), False, False)),
2050
 
                          ], entries)
 
1881
                         ], entries)
2051
1882
 
2052
1883
    def test_interesting_file_in_base(self):
2053
1884
        # This renamed the file, but it should still match the entry in BASE
2054
1885
        builder = self.get_builder()
2055
 
        builder.build_snapshot(None,
2056
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2057
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2058
 
                                   ('add', (u'c', b'c-id', 'file', b'content\n'))],
2059
 
                               revision_id=b'A-id')
2060
 
        builder.build_snapshot([b'A-id'],
2061
 
                               [('rename', ('c', 'b'))],
2062
 
                               revision_id=b'B-id')
2063
 
        builder.build_snapshot([b'A-id'],
2064
 
                               [('rename', ('c', 'b'))],
2065
 
                               revision_id=b'C-id')
2066
 
        builder.build_snapshot([b'C-id', b'B-id'],
2067
 
                               [('modify', ('a', b'new-content\n')),
2068
 
                                ('modify', ('b', b'new-content\n'))],
2069
 
                               revision_id=b'E-id')
2070
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2071
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1886
        builder.build_snapshot('A-id', None,
 
1887
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1888
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1889
             ('add', (u'c', 'c-id', 'file', 'content\n'))])
 
1890
        builder.build_snapshot('B-id', ['A-id'],
 
1891
            [('rename', ('c', 'b'))])
 
1892
        builder.build_snapshot('C-id', ['A-id'],
 
1893
            [('rename', ('c', 'b'))])
 
1894
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1895
            [('modify', ('a-id', 'new-content\n')),
 
1896
             ('modify', ('c-id', 'new-content\n'))])
 
1897
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1898
        merge_obj = self.make_merge_obj(builder, 'E-id',
2072
1899
                                        interesting_files=['c'])
2073
1900
        entries = list(merge_obj._entries_lca())
2074
 
        root_id = b'a-root-id'
2075
 
        self.assertEqual([(b'c-id', True,
2076
 
                           ((u'c', [u'b', u'b']), u'b', u'b'),
 
1901
        root_id = 'a-root-id'
 
1902
        self.assertEqual([('c-id', True,
2077
1903
                           ((root_id, [root_id, root_id]), root_id, root_id),
2078
1904
                           ((u'c', [u'b', u'b']), u'b', u'b'),
2079
1905
                           ((False, [False, False]), False, False)),
2080
 
                          ], entries)
 
1906
                         ], entries)
2081
1907
 
2082
1908
    def test_interesting_file_in_lca(self):
2083
1909
        # This renamed the file, but it should still match the entry in LCA
2084
1910
        builder = self.get_builder()
2085
 
        builder.build_snapshot(None,
2086
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2087
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2088
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2089
 
                               revision_id=b'A-id')
2090
 
        builder.build_snapshot([b'A-id'],
2091
 
                               [('rename', ('b', 'c'))], revision_id=b'B-id')
2092
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2093
 
        builder.build_snapshot([b'C-id', b'B-id'],
2094
 
                               [('modify', ('a', b'new-content\n')),
2095
 
                                ('modify', ('b', b'new-content\n'))],
2096
 
                               revision_id=b'E-id')
2097
 
        builder.build_snapshot([b'B-id', b'C-id'],
2098
 
                               [('rename', ('c', 'b'))], revision_id=b'D-id')
2099
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1911
        builder.build_snapshot('A-id', None,
 
1912
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1913
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1914
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1915
        builder.build_snapshot('B-id', ['A-id'],
 
1916
            [('rename', ('b', 'c'))])
 
1917
        builder.build_snapshot('C-id', ['A-id'], [])
 
1918
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1919
            [('modify', ('a-id', 'new-content\n')),
 
1920
             ('modify', ('b-id', 'new-content\n'))])
 
1921
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1922
            [('rename', ('c', 'b'))])
 
1923
        merge_obj = self.make_merge_obj(builder, 'E-id',
2100
1924
                                        interesting_files=['c'])
2101
1925
        entries = list(merge_obj._entries_lca())
2102
 
        root_id = b'a-root-id'
2103
 
        self.assertEqual([(b'b-id', True,
2104
 
                           ((u'b', [u'c', u'b']), u'b', u'b'),
 
1926
        root_id = 'a-root-id'
 
1927
        self.assertEqual([('b-id', True,
2105
1928
                           ((root_id, [root_id, root_id]), root_id, root_id),
2106
1929
                           ((u'b', [u'c', u'b']), u'b', u'b'),
2107
1930
                           ((False, [False, False]), False, False)),
2108
 
                          ], entries)
 
1931
                         ], entries)
2109
1932
 
2110
 
    def test_interesting_files(self):
 
1933
    def test_interesting_ids(self):
2111
1934
        # Two files modified, but we should filter one of them
2112
1935
        builder = self.get_builder()
2113
 
        builder.build_snapshot(None,
2114
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2115
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2116
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2117
 
                               revision_id=b'A-id')
2118
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2119
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2120
 
        builder.build_snapshot([b'C-id', b'B-id'],
2121
 
                               [('modify', ('a', b'new-content\n')),
2122
 
                                ('modify', ('b', b'new-content\n'))], revision_id=b'E-id')
2123
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2124
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
2125
 
                                        interesting_files=['b'])
 
1936
        builder.build_snapshot('A-id', None,
 
1937
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1938
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1939
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1940
        builder.build_snapshot('B-id', ['A-id'], [])
 
1941
        builder.build_snapshot('C-id', ['A-id'], [])
 
1942
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1943
            [('modify', ('a-id', 'new-content\n')),
 
1944
             ('modify', ('b-id', 'new-content\n'))])
 
1945
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1946
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
1947
                                        interesting_ids=['b-id'])
2126
1948
        entries = list(merge_obj._entries_lca())
2127
 
        root_id = b'a-root-id'
2128
 
        self.assertEqual([(b'b-id', True,
2129
 
                           ((u'b', [u'b', u'b']), u'b', u'b'),
 
1949
        root_id = 'a-root-id'
 
1950
        self.assertEqual([('b-id', True,
2130
1951
                           ((root_id, [root_id, root_id]), root_id, root_id),
2131
1952
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2132
1953
                           ((False, [False, False]), False, False)),
2133
 
                          ], entries)
 
1954
                         ], entries)
 
1955
 
2134
1956
 
2135
1957
 
2136
1958
class TestMergerEntriesLCAOnDisk(tests.TestCaseWithTransport):
2144
1966
    def get_wt_from_builder(self, builder):
2145
1967
        """Get a real WorkingTree from the builder."""
2146
1968
        the_branch = builder.get_branch()
2147
 
        wt = the_branch.controldir.create_workingtree()
 
1969
        wt = the_branch.bzrdir.create_workingtree()
2148
1970
        # Note: This is a little bit ugly, but we are holding the branch
2149
1971
        #       write-locked as part of the build process, and we would like to
2150
1972
        #       maintain that. So we just force the WT to re-use the same
2156
1978
 
2157
1979
    def do_merge(self, builder, other_revision_id):
2158
1980
        wt = self.get_wt_from_builder(builder)
2159
 
        merger = _mod_merge.Merger.from_revision_ids(
 
1981
        merger = _mod_merge.Merger.from_revision_ids(None,
2160
1982
            wt, other_revision_id)
2161
1983
        merger.merge_type = _mod_merge.Merge3Merger
2162
1984
        return wt, merger.do_merge()
2163
1985
 
2164
1986
    def test_simple_lca(self):
2165
1987
        builder = self.get_builder()
2166
 
        builder.build_snapshot(None,
2167
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2168
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
2169
 
                               revision_id=b'A-id')
2170
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2171
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2172
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
2173
 
        builder.build_snapshot([b'B-id', b'C-id'],
2174
 
                               [('modify', ('a', b'a\nb\nc\nd\ne\nf\n'))],
2175
 
                               revision_id=b'D-id')
2176
 
        wt, conflicts = self.do_merge(builder, b'E-id')
 
1988
        builder.build_snapshot('A-id', None,
 
1989
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1990
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1991
        builder.build_snapshot('C-id', ['A-id'], [])
 
1992
        builder.build_snapshot('B-id', ['A-id'], [])
 
1993
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1994
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1995
            [('modify', ('a-id', 'a\nb\nc\nd\ne\nf\n'))])
 
1996
        wt, conflicts = self.do_merge(builder, 'E-id')
2177
1997
        self.assertEqual(0, conflicts)
2178
1998
        # The merge should have simply update the contents of 'a'
2179
 
        self.assertEqual(b'a\nb\nc\nd\ne\nf\n', wt.get_file_text('a'))
 
1999
        self.assertEqual('a\nb\nc\nd\ne\nf\n', wt.get_file_text('a-id'))
2180
2000
 
2181
2001
    def test_conflict_without_lca(self):
2182
2002
        # This test would cause a merge conflict, unless we use the lca trees
2191
2011
        #     |
2192
2012
        #     F     Path at 'baz' in F, which supersedes 'bar' and 'foo'
2193
2013
        builder = self.get_builder()
2194
 
        builder.build_snapshot(None,
2195
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2196
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2197
 
                               revision_id=b'A-id')
2198
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2199
 
        builder.build_snapshot([b'A-id'],
2200
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id', )
2201
 
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
2202
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
2203
 
        builder.build_snapshot([b'E-id'],
2204
 
                               [('rename', ('bar', 'baz'))], revision_id=b'F-id')
2205
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2206
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2014
        builder.build_snapshot('A-id', None,
 
2015
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2016
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2017
        builder.build_snapshot('C-id', ['A-id'], [])
 
2018
        builder.build_snapshot('B-id', ['A-id'],
 
2019
            [('rename', ('foo', 'bar'))])
 
2020
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
 
2021
            [('rename', ('foo', 'bar'))])
 
2022
        builder.build_snapshot('F-id', ['E-id'],
 
2023
            [('rename', ('bar', 'baz'))])
 
2024
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2025
        wt, conflicts = self.do_merge(builder, 'F-id')
2207
2026
        self.assertEqual(0, conflicts)
2208
2027
        # The merge should simply recognize that the final rename takes
2209
2028
        # precedence
2210
 
        self.assertEqual('baz', wt.id2path(b'foo-id'))
 
2029
        self.assertEqual('baz', wt.id2path('foo-id'))
2211
2030
 
2212
2031
    def test_other_deletes_lca_renames(self):
2213
2032
        # This test would cause a merge conflict, unless we use the lca trees
2222
2041
        #     |
2223
2042
        #     F     F deletes 'bar'
2224
2043
        builder = self.get_builder()
2225
 
        builder.build_snapshot(None,
2226
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2227
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2228
 
                               revision_id=b'A-id')
2229
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2230
 
        builder.build_snapshot([b'A-id'],
2231
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
2232
 
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
2233
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
2234
 
        builder.build_snapshot([b'E-id'],
2235
 
                               [('unversion', 'bar')], revision_id=b'F-id')
2236
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2237
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2044
        builder.build_snapshot('A-id', None,
 
2045
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2046
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2047
        builder.build_snapshot('C-id', ['A-id'], [])
 
2048
        builder.build_snapshot('B-id', ['A-id'],
 
2049
            [('rename', ('foo', 'bar'))])
 
2050
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
 
2051
            [('rename', ('foo', 'bar'))])
 
2052
        builder.build_snapshot('F-id', ['E-id'],
 
2053
            [('unversion', 'foo-id')])
 
2054
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2055
        wt, conflicts = self.do_merge(builder, 'F-id')
2238
2056
        self.assertEqual(0, conflicts)
2239
 
        self.assertRaises(errors.NoSuchId, wt.id2path, b'foo-id')
 
2057
        self.assertRaises(errors.NoSuchId, wt.id2path, 'foo-id')
2240
2058
 
2241
2059
    def test_executable_changes(self):
2242
2060
        #   A       Path at 'foo'
2249
2067
        #     |
2250
2068
        #     F     Executable bit changed
2251
2069
        builder = self.get_builder()
2252
 
        builder.build_snapshot(None,
2253
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2254
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2255
 
                               revision_id=b'A-id')
2256
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2257
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2258
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2259
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
2070
        builder.build_snapshot('A-id', None,
 
2071
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2072
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2073
        builder.build_snapshot('C-id', ['A-id'], [])
 
2074
        builder.build_snapshot('B-id', ['A-id'], [])
 
2075
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2076
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2260
2077
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2261
2078
        wt = self.get_wt_from_builder(builder)
2262
 
        with wt.transform() as tt:
2263
 
            tt.set_executability(True, tt.trans_id_tree_path('foo'))
 
2079
        tt = transform.TreeTransform(wt)
 
2080
        try:
 
2081
            tt.set_executability(True, tt.trans_id_tree_file_id('foo-id'))
2264
2082
            tt.apply()
2265
 
        self.assertTrue(wt.is_executable('foo'))
2266
 
        wt.commit('F-id', rev_id=b'F-id')
 
2083
        except:
 
2084
            tt.finalize()
 
2085
            raise
 
2086
        self.assertTrue(wt.is_executable('foo-id'))
 
2087
        wt.commit('F-id', rev_id='F-id')
2267
2088
        # Reset to D, so that we can merge F
2268
 
        wt.set_parent_ids([b'D-id'])
2269
 
        wt.branch.set_last_revision_info(3, b'D-id')
 
2089
        wt.set_parent_ids(['D-id'])
 
2090
        wt.branch.set_last_revision_info(3, 'D-id')
2270
2091
        wt.revert()
2271
 
        self.assertFalse(wt.is_executable('foo'))
2272
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2092
        self.assertFalse(wt.is_executable('foo-id'))
 
2093
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2273
2094
        self.assertEqual(0, conflicts)
2274
 
        self.assertTrue(wt.is_executable('foo'))
 
2095
        self.assertTrue(wt.is_executable('foo-id'))
2275
2096
 
2276
2097
    def test_create_symlink(self):
2277
 
        self.requireFeature(features.SymlinkFeature)
 
2098
        self.requireFeature(tests.SymlinkFeature)
2278
2099
        #   A
2279
2100
        #  / \
2280
2101
        # B   C
2287
2108
        # Have to use a real WT, because BranchBuilder and MemoryTree don't
2288
2109
        # have symlink support
2289
2110
        builder = self.get_builder()
2290
 
        builder.build_snapshot(None,
2291
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
2292
 
                               revision_id=b'A-id')
2293
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2294
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2295
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2296
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
2111
        builder.build_snapshot('A-id', None,
 
2112
            [('add', (u'', 'a-root-id', 'directory', None))])
 
2113
        builder.build_snapshot('C-id', ['A-id'], [])
 
2114
        builder.build_snapshot('B-id', ['A-id'], [])
 
2115
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2116
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2297
2117
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2298
2118
        wt = self.get_wt_from_builder(builder)
2299
2119
        os.symlink('bar', 'path/foo')
2300
 
        wt.add(['foo'], [b'foo-id'])
2301
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
2302
 
        wt.commit('add symlink', rev_id=b'F-id')
 
2120
        wt.add(['foo'], ['foo-id'])
 
2121
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2122
        wt.commit('add symlink', rev_id='F-id')
2303
2123
        # Reset to D, so that we can merge F
2304
 
        wt.set_parent_ids([b'D-id'])
2305
 
        wt.branch.set_last_revision_info(3, b'D-id')
 
2124
        wt.set_parent_ids(['D-id'])
 
2125
        wt.branch.set_last_revision_info(3, 'D-id')
2306
2126
        wt.revert()
2307
 
        self.assertFalse(wt.is_versioned('foo'))
2308
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2127
        self.assertIs(None, wt.path2id('foo'))
 
2128
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2309
2129
        self.assertEqual(0, conflicts)
2310
 
        self.assertEqual(b'foo-id', wt.path2id('foo'))
2311
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
 
2130
        self.assertEqual('foo-id', wt.path2id('foo'))
 
2131
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2312
2132
 
2313
2133
    def test_both_sides_revert(self):
2314
2134
        # Both sides of a criss-cross revert the text to the lca
2321
2141
        # This must be done with a real WorkingTree, because normally their
2322
2142
        # inventory contains "None" rather than a real sha1
2323
2143
        builder = self.get_builder()
2324
 
        builder.build_snapshot(None,
2325
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2326
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
2327
 
                               revision_id=b'A-id')
2328
 
        builder.build_snapshot([b'A-id'],
2329
 
                               [('modify', ('foo', b'B content\n'))],
2330
 
                               revision_id=b'B-id')
2331
 
        builder.build_snapshot([b'A-id'],
2332
 
                               [('modify', ('foo', b'C content\n'))],
2333
 
                               revision_id=b'C-id')
2334
 
        builder.build_snapshot([b'C-id', b'B-id'], [],
2335
 
                               revision_id=b'E-id')
2336
 
        builder.build_snapshot([b'B-id', b'C-id'], [],
2337
 
                               revision_id=b'D-id')
2338
 
        wt, conflicts = self.do_merge(builder, b'E-id')
 
2144
        builder.build_snapshot('A-id', None,
 
2145
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2146
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
2147
        builder.build_snapshot('B-id', ['A-id'],
 
2148
            [('modify', ('foo-id', 'B content\n'))])
 
2149
        builder.build_snapshot('C-id', ['A-id'],
 
2150
            [('modify', ('foo-id', 'C content\n'))])
 
2151
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
2152
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2153
        wt, conflicts = self.do_merge(builder, 'E-id')
2339
2154
        self.assertEqual(1, conflicts)
2340
 
        self.assertEqualDiff(b'<<<<<<< TREE\n'
2341
 
                             b'B content\n'
2342
 
                             b'=======\n'
2343
 
                             b'C content\n'
2344
 
                             b'>>>>>>> MERGE-SOURCE\n',
2345
 
                             wt.get_file_text('foo'))
 
2155
        self.assertEqualDiff('<<<<<<< TREE\n'
 
2156
                             'B content\n'
 
2157
                             '=======\n'
 
2158
                             'C content\n'
 
2159
                             '>>>>>>> MERGE-SOURCE\n',
 
2160
                             wt.get_file_text('foo-id'))
2346
2161
 
2347
2162
    def test_modified_symlink(self):
2348
 
        self.requireFeature(features.SymlinkFeature)
 
2163
        self.requireFeature(tests.SymlinkFeature)
2349
2164
        #   A       Create symlink foo => bar
2350
2165
        #  / \
2351
2166
        # B   C     B relinks foo => baz
2365
2180
        wt.lock_write()
2366
2181
        self.addCleanup(wt.unlock)
2367
2182
        os.symlink('bar', 'path/foo')
2368
 
        wt.add(['foo'], [b'foo-id'])
2369
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2183
        wt.add(['foo'], ['foo-id'])
 
2184
        wt.commit('add symlink', rev_id='A-id')
2370
2185
        os.remove('path/foo')
2371
2186
        os.symlink('baz', 'path/foo')
2372
 
        wt.commit('foo => baz', rev_id=b'B-id')
2373
 
        wt.set_last_revision(b'A-id')
2374
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2187
        wt.commit('foo => baz', rev_id='B-id')
 
2188
        wt.set_last_revision('A-id')
 
2189
        wt.branch.set_last_revision_info(1, 'A-id')
2375
2190
        wt.revert()
2376
 
        wt.commit('C', rev_id=b'C-id')
2377
 
        wt.merge_from_branch(wt.branch, b'B-id')
2378
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2379
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2191
        wt.commit('C', rev_id='C-id')
 
2192
        wt.merge_from_branch(wt.branch, 'B-id')
 
2193
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2194
        wt.commit('E merges C & B', rev_id='E-id')
2380
2195
        os.remove('path/foo')
2381
2196
        os.symlink('bing', 'path/foo')
2382
 
        wt.commit('F foo => bing', rev_id=b'F-id')
2383
 
        wt.set_last_revision(b'B-id')
2384
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2197
        wt.commit('F foo => bing', rev_id='F-id')
 
2198
        wt.set_last_revision('B-id')
 
2199
        wt.branch.set_last_revision_info(2, 'B-id')
2385
2200
        wt.revert()
2386
 
        wt.merge_from_branch(wt.branch, b'C-id')
2387
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2388
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2201
        wt.merge_from_branch(wt.branch, 'C-id')
 
2202
        wt.commit('D merges B & C', rev_id='D-id')
 
2203
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2389
2204
        self.assertEqual(0, conflicts)
2390
 
        self.assertEqual('bing', wt.get_symlink_target('foo'))
 
2205
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2391
2206
 
2392
2207
    def test_renamed_symlink(self):
2393
 
        self.requireFeature(features.SymlinkFeature)
 
2208
        self.requireFeature(tests.SymlinkFeature)
2394
2209
        #   A       Create symlink foo => bar
2395
2210
        #  / \
2396
2211
        # B   C     B renames foo => barry
2408
2223
        wt.lock_write()
2409
2224
        self.addCleanup(wt.unlock)
2410
2225
        os.symlink('bar', 'path/foo')
2411
 
        wt.add(['foo'], [b'foo-id'])
2412
 
        wt.commit('A add symlink', rev_id=b'A-id')
 
2226
        wt.add(['foo'], ['foo-id'])
 
2227
        wt.commit('A add symlink', rev_id='A-id')
2413
2228
        wt.rename_one('foo', 'barry')
2414
 
        wt.commit('B foo => barry', rev_id=b'B-id')
2415
 
        wt.set_last_revision(b'A-id')
2416
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2229
        wt.commit('B foo => barry', rev_id='B-id')
 
2230
        wt.set_last_revision('A-id')
 
2231
        wt.branch.set_last_revision_info(1, 'A-id')
2417
2232
        wt.revert()
2418
 
        wt.commit('C', rev_id=b'C-id')
2419
 
        wt.merge_from_branch(wt.branch, b'B-id')
2420
 
        self.assertEqual('barry', wt.id2path(b'foo-id'))
2421
 
        self.assertEqual('bar', wt.get_symlink_target('barry'))
2422
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2233
        wt.commit('C', rev_id='C-id')
 
2234
        wt.merge_from_branch(wt.branch, 'B-id')
 
2235
        self.assertEqual('barry', wt.id2path('foo-id'))
 
2236
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2237
        wt.commit('E merges C & B', rev_id='E-id')
2423
2238
        wt.rename_one('barry', 'blah')
2424
 
        wt.commit('F barry => blah', rev_id=b'F-id')
2425
 
        wt.set_last_revision(b'B-id')
2426
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2239
        wt.commit('F barry => blah', rev_id='F-id')
 
2240
        wt.set_last_revision('B-id')
 
2241
        wt.branch.set_last_revision_info(2, 'B-id')
2427
2242
        wt.revert()
2428
 
        wt.merge_from_branch(wt.branch, b'C-id')
2429
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2430
 
        self.assertEqual('barry', wt.id2path(b'foo-id'))
 
2243
        wt.merge_from_branch(wt.branch, 'C-id')
 
2244
        wt.commit('D merges B & C', rev_id='D-id')
 
2245
        self.assertEqual('barry', wt.id2path('foo-id'))
2431
2246
        # Check the output of the Merger object directly
2432
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'F-id')
 
2247
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2248
            wt, 'F-id')
2433
2249
        merger.merge_type = _mod_merge.Merge3Merger
2434
2250
        merge_obj = merger.make_merger()
2435
2251
        root_id = wt.path2id('')
2436
2252
        entries = list(merge_obj._entries_lca())
2437
2253
        # No content change, just a path change
2438
 
        self.assertEqual([(b'foo-id', False,
2439
 
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
 
2254
        self.assertEqual([('foo-id', False,
2440
2255
                           ((root_id, [root_id, root_id]), root_id, root_id),
2441
2256
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
2442
2257
                           ((False, [False, False]), False, False)),
2443
 
                          ], entries)
2444
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2258
                         ], entries)
 
2259
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2445
2260
        self.assertEqual(0, conflicts)
2446
 
        self.assertEqual('blah', wt.id2path(b'foo-id'))
 
2261
        self.assertEqual('blah', wt.id2path('foo-id'))
2447
2262
 
2448
2263
    def test_symlink_no_content_change(self):
2449
 
        self.requireFeature(features.SymlinkFeature)
 
2264
        self.requireFeature(tests.SymlinkFeature)
2450
2265
        #   A       Create symlink foo => bar
2451
2266
        #  / \
2452
2267
        # B   C     B relinks foo => baz
2463
2278
        wt.lock_write()
2464
2279
        self.addCleanup(wt.unlock)
2465
2280
        os.symlink('bar', 'path/foo')
2466
 
        wt.add(['foo'], [b'foo-id'])
2467
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2281
        wt.add(['foo'], ['foo-id'])
 
2282
        wt.commit('add symlink', rev_id='A-id')
2468
2283
        os.remove('path/foo')
2469
2284
        os.symlink('baz', 'path/foo')
2470
 
        wt.commit('foo => baz', rev_id=b'B-id')
2471
 
        wt.set_last_revision(b'A-id')
2472
 
        wt.branch.set_last_revision_info(1, b'A-id')
2473
 
        wt.revert()
2474
 
        wt.commit('C', rev_id=b'C-id')
2475
 
        wt.merge_from_branch(wt.branch, b'B-id')
2476
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2477
 
        wt.commit('E merges C & B', rev_id=b'E-id')
2478
 
        wt.set_last_revision(b'B-id')
2479
 
        wt.branch.set_last_revision_info(2, b'B-id')
2480
 
        wt.revert()
2481
 
        wt.merge_from_branch(wt.branch, b'C-id')
2482
 
        wt.commit('D merges B & C', rev_id=b'D-id')
 
2285
        wt.commit('foo => baz', rev_id='B-id')
 
2286
        wt.set_last_revision('A-id')
 
2287
        wt.branch.set_last_revision_info(1, 'A-id')
 
2288
        wt.revert()
 
2289
        wt.commit('C', rev_id='C-id')
 
2290
        wt.merge_from_branch(wt.branch, 'B-id')
 
2291
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2292
        wt.commit('E merges C & B', rev_id='E-id')
 
2293
        wt.set_last_revision('B-id')
 
2294
        wt.branch.set_last_revision_info(2, 'B-id')
 
2295
        wt.revert()
 
2296
        wt.merge_from_branch(wt.branch, 'C-id')
 
2297
        wt.commit('D merges B & C', rev_id='D-id')
2483
2298
        os.remove('path/foo')
2484
2299
        os.symlink('bing', 'path/foo')
2485
 
        wt.commit('F foo => bing', rev_id=b'F-id')
 
2300
        wt.commit('F foo => bing', rev_id='F-id')
2486
2301
 
2487
2302
        # Check the output of the Merger object directly
2488
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2303
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2304
            wt, 'E-id')
2489
2305
        merger.merge_type = _mod_merge.Merge3Merger
2490
2306
        merge_obj = merger.make_merger()
2491
2307
        # Nothing interesting happened in OTHER relative to BASE
2492
2308
        self.assertEqual([], list(merge_obj._entries_lca()))
2493
2309
        # Now do a real merge, just to test the rest of the stack
2494
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'E-id')
 
2310
        conflicts = wt.merge_from_branch(wt.branch, to_revision='E-id')
2495
2311
        self.assertEqual(0, conflicts)
2496
 
        self.assertEqual('bing', wt.get_symlink_target('foo'))
 
2312
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2497
2313
 
2498
2314
    def test_symlink_this_changed_kind(self):
2499
 
        self.requireFeature(features.SymlinkFeature)
 
2315
        self.requireFeature(tests.SymlinkFeature)
2500
2316
        #   A       Nothing
2501
2317
        #  / \
2502
2318
        # B   C     B creates symlink foo => bar
2510
2326
        wt = self.make_branch_and_tree('path')
2511
2327
        wt.lock_write()
2512
2328
        self.addCleanup(wt.unlock)
2513
 
        wt.commit('base', rev_id=b'A-id')
 
2329
        wt.commit('base', rev_id='A-id')
2514
2330
        os.symlink('bar', 'path/foo')
2515
 
        wt.add(['foo'], [b'foo-id'])
2516
 
        wt.commit('add symlink foo => bar', rev_id=b'B-id')
2517
 
        wt.set_last_revision(b'A-id')
2518
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2331
        wt.add(['foo'], ['foo-id'])
 
2332
        wt.commit('add symlink foo => bar', rev_id='B-id')
 
2333
        wt.set_last_revision('A-id')
 
2334
        wt.branch.set_last_revision_info(1, 'A-id')
2519
2335
        wt.revert()
2520
 
        wt.commit('C', rev_id=b'C-id')
2521
 
        wt.merge_from_branch(wt.branch, b'B-id')
2522
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
 
2336
        wt.commit('C', rev_id='C-id')
 
2337
        wt.merge_from_branch(wt.branch, 'B-id')
 
2338
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2523
2339
        os.remove('path/foo')
2524
2340
        # We have to change the link in E, or it won't try to do a comparison
2525
2341
        os.symlink('bing', 'path/foo')
2526
 
        wt.commit('E merges C & B, overrides to bing', rev_id=b'E-id')
2527
 
        wt.set_last_revision(b'B-id')
2528
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2342
        wt.commit('E merges C & B, overrides to bing', rev_id='E-id')
 
2343
        wt.set_last_revision('B-id')
 
2344
        wt.branch.set_last_revision_info(2, 'B-id')
2529
2345
        wt.revert()
2530
 
        wt.merge_from_branch(wt.branch, b'C-id')
 
2346
        wt.merge_from_branch(wt.branch, 'C-id')
2531
2347
        os.remove('path/foo')
2532
 
        self.build_tree_contents([('path/foo', b'file content\n')])
 
2348
        self.build_tree_contents([('path/foo', 'file content\n')])
2533
2349
        # XXX: workaround, WT doesn't detect kind changes unless you do
2534
2350
        # iter_changes()
2535
2351
        list(wt.iter_changes(wt.basis_tree()))
2536
 
        wt.commit('D merges B & C, makes it a file', rev_id=b'D-id')
 
2352
        wt.commit('D merges B & C, makes it a file', rev_id='D-id')
2537
2353
 
2538
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2354
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2355
            wt, 'E-id')
2539
2356
        merger.merge_type = _mod_merge.Merge3Merger
2540
2357
        merge_obj = merger.make_merger()
2541
2358
        entries = list(merge_obj._entries_lca())
2542
2359
        root_id = wt.path2id('')
2543
 
        self.assertEqual([(b'foo-id', True,
2544
 
                           ((None, [u'foo', None]), u'foo', u'foo'),
 
2360
        self.assertEqual([('foo-id', True,
2545
2361
                           ((None, [root_id, None]), root_id, root_id),
2546
2362
                           ((None, [u'foo', None]), u'foo', u'foo'),
2547
2363
                           ((None, [False, None]), False, False)),
2548
 
                          ], entries)
 
2364
                         ], entries)
2549
2365
 
2550
2366
    def test_symlink_all_wt(self):
2551
2367
        """Check behavior if all trees are Working Trees."""
2552
 
        self.requireFeature(features.SymlinkFeature)
 
2368
        self.requireFeature(tests.SymlinkFeature)
2553
2369
        # The big issue is that entry.symlink_target is None for WorkingTrees.
2554
2370
        # So we need to make sure we handle that case correctly.
2555
2371
        #   A   foo => bar
2566
2382
        wt.lock_write()
2567
2383
        self.addCleanup(wt.unlock)
2568
2384
        os.symlink('bar', 'path/foo')
2569
 
        wt.add(['foo'], [b'foo-id'])
2570
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2385
        wt.add(['foo'], ['foo-id'])
 
2386
        wt.commit('add symlink', rev_id='A-id')
2571
2387
        os.remove('path/foo')
2572
2388
        os.symlink('baz', 'path/foo')
2573
 
        wt.commit('foo => baz', rev_id=b'B-id')
2574
 
        wt.set_last_revision(b'A-id')
2575
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2389
        wt.commit('foo => baz', rev_id='B-id')
 
2390
        wt.set_last_revision('A-id')
 
2391
        wt.branch.set_last_revision_info(1, 'A-id')
2576
2392
        wt.revert()
2577
 
        wt.commit('C', rev_id=b'C-id')
2578
 
        wt.merge_from_branch(wt.branch, b'B-id')
2579
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2580
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2393
        wt.commit('C', rev_id='C-id')
 
2394
        wt.merge_from_branch(wt.branch, 'B-id')
 
2395
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2396
        wt.commit('E merges C & B', rev_id='E-id')
2581
2397
        os.remove('path/foo')
2582
2398
        os.symlink('bing', 'path/foo')
2583
 
        wt.commit('F foo => bing', rev_id=b'F-id')
2584
 
        wt.set_last_revision(b'B-id')
2585
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2399
        wt.commit('F foo => bing', rev_id='F-id')
 
2400
        wt.set_last_revision('B-id')
 
2401
        wt.branch.set_last_revision_info(2, 'B-id')
2586
2402
        wt.revert()
2587
 
        wt.merge_from_branch(wt.branch, b'C-id')
2588
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2589
 
        wt_base = wt.controldir.sprout('base', b'A-id').open_workingtree()
 
2403
        wt.merge_from_branch(wt.branch, 'C-id')
 
2404
        wt.commit('D merges B & C', rev_id='D-id')
 
2405
        wt_base = wt.bzrdir.sprout('base', 'A-id').open_workingtree()
2590
2406
        wt_base.lock_read()
2591
2407
        self.addCleanup(wt_base.unlock)
2592
 
        wt_lca1 = wt.controldir.sprout('b-tree', b'B-id').open_workingtree()
 
2408
        wt_lca1 = wt.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
2593
2409
        wt_lca1.lock_read()
2594
2410
        self.addCleanup(wt_lca1.unlock)
2595
 
        wt_lca2 = wt.controldir.sprout('c-tree', b'C-id').open_workingtree()
 
2411
        wt_lca2 = wt.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
2596
2412
        wt_lca2.lock_read()
2597
2413
        self.addCleanup(wt_lca2.unlock)
2598
 
        wt_other = wt.controldir.sprout('other', b'F-id').open_workingtree()
 
2414
        wt_other = wt.bzrdir.sprout('other', 'F-id').open_workingtree()
2599
2415
        wt_other.lock_read()
2600
2416
        self.addCleanup(wt_other.unlock)
2601
2417
        merge_obj = _mod_merge.Merge3Merger(wt, wt, wt_base,
2602
 
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2418
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2603
2419
        entries = list(merge_obj._entries_lca())
2604
2420
        root_id = wt.path2id('')
2605
 
        self.assertEqual([(b'foo-id', True,
2606
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2421
        self.assertEqual([('foo-id', True,
2607
2422
                           ((root_id, [root_id, root_id]), root_id, root_id),
2608
2423
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2609
2424
                           ((False, [False, False]), False, False)),
2610
 
                          ], entries)
 
2425
                         ], entries)
2611
2426
 
2612
2427
    def test_other_reverted_path_to_base(self):
2613
2428
        #   A       Path at 'foo'
2620
2435
        #     |
2621
2436
        #     F     Path at 'foo'
2622
2437
        builder = self.get_builder()
2623
 
        builder.build_snapshot(None,
2624
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2625
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2626
 
                               revision_id=b'A-id')
2627
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2628
 
        builder.build_snapshot([b'A-id'],
2629
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
2630
 
        builder.build_snapshot([b'C-id', b'B-id'],
2631
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')  # merge the rename
2632
 
        builder.build_snapshot([b'E-id'],
2633
 
                               [('rename', ('bar', 'foo'))], revision_id=b'F-id')  # Rename back to BASE
2634
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2635
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2438
        builder.build_snapshot('A-id', None,
 
2439
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2440
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2441
        builder.build_snapshot('C-id', ['A-id'], [])
 
2442
        builder.build_snapshot('B-id', ['A-id'],
 
2443
            [('rename', ('foo', 'bar'))])
 
2444
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2445
            [('rename', ('foo', 'bar'))]) # merge the rename
 
2446
        builder.build_snapshot('F-id', ['E-id'],
 
2447
            [('rename', ('bar', 'foo'))]) # Rename back to BASE
 
2448
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2449
        wt, conflicts = self.do_merge(builder, 'F-id')
2636
2450
        self.assertEqual(0, conflicts)
2637
 
        self.assertEqual('foo', wt.id2path(b'foo-id'))
 
2451
        self.assertEqual('foo', wt.id2path('foo-id'))
2638
2452
 
2639
2453
    def test_other_reverted_content_to_base(self):
2640
2454
        builder = self.get_builder()
2641
 
        builder.build_snapshot(None,
2642
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2643
 
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2644
 
                               revision_id=b'A-id')
2645
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2646
 
        builder.build_snapshot([b'A-id'],
2647
 
                               [('modify', ('foo', b'B content\n'))],
2648
 
                               revision_id=b'B-id')
2649
 
        builder.build_snapshot([b'C-id', b'B-id'],
2650
 
                               [('modify', ('foo', b'B content\n'))],
2651
 
                               revision_id=b'E-id')  # merge the content
2652
 
        builder.build_snapshot([b'E-id'],
2653
 
                               [('modify', ('foo', b'base content\n'))],
2654
 
                               revision_id=b'F-id')  # Revert back to BASE
2655
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2656
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2455
        builder.build_snapshot('A-id', None,
 
2456
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2457
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2458
        builder.build_snapshot('C-id', ['A-id'], [])
 
2459
        builder.build_snapshot('B-id', ['A-id'],
 
2460
            [('modify', ('foo-id', 'B content\n'))])
 
2461
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2462
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
 
2463
        builder.build_snapshot('F-id', ['E-id'],
 
2464
            [('modify', ('foo-id', 'base content\n'))]) # Revert back to BASE
 
2465
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2466
        wt, conflicts = self.do_merge(builder, 'F-id')
2657
2467
        self.assertEqual(0, conflicts)
2658
2468
        # TODO: We need to use the per-file graph to properly select a BASE
2659
2469
        #       before this will work. Or at least use the LCA trees to find
2660
2470
        #       the appropriate content base. (which is B, not A).
2661
 
        self.assertEqual(b'base content\n', wt.get_file_text('foo'))
 
2471
        self.assertEqual('base content\n', wt.get_file_text('foo-id'))
2662
2472
 
2663
2473
    def test_other_modified_content(self):
2664
2474
        builder = self.get_builder()
2665
 
        builder.build_snapshot(None,
2666
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2667
 
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2668
 
                               revision_id=b'A-id')
2669
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2670
 
        builder.build_snapshot([b'A-id'],
2671
 
                               [('modify', ('foo', b'B content\n'))],
2672
 
                               revision_id=b'B-id')
2673
 
        builder.build_snapshot([b'C-id', b'B-id'],
2674
 
                               [('modify', ('foo', b'B content\n'))],
2675
 
                               revision_id=b'E-id')  # merge the content
2676
 
        builder.build_snapshot([b'E-id'],
2677
 
                               [('modify', ('foo', b'F content\n'))],
2678
 
                               revision_id=b'F-id')  # Override B content
2679
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2680
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2475
        builder.build_snapshot('A-id', None,
 
2476
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2477
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2478
        builder.build_snapshot('C-id', ['A-id'], [])
 
2479
        builder.build_snapshot('B-id', ['A-id'],
 
2480
            [('modify', ('foo-id', 'B content\n'))])
 
2481
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2482
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
 
2483
        builder.build_snapshot('F-id', ['E-id'],
 
2484
            [('modify', ('foo-id', 'F content\n'))]) # Override B content
 
2485
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2486
        wt, conflicts = self.do_merge(builder, 'F-id')
2681
2487
        self.assertEqual(0, conflicts)
2682
 
        self.assertEqual(b'F content\n', wt.get_file_text('foo'))
 
2488
        self.assertEqual('F content\n', wt.get_file_text('foo-id'))
2683
2489
 
2684
2490
    def test_all_wt(self):
2685
2491
        """Check behavior if all trees are Working Trees."""
2692
2498
        #   |X|
2693
2499
        #   D E E updates content, renames 'b' => 'c'
2694
2500
        builder = self.get_builder()
2695
 
        builder.build_snapshot(None,
2696
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2697
 
                                ('add', (u'a', b'a-id', 'file', b'base content\n')),
2698
 
                                   ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2699
 
                               revision_id=b'A-id')
2700
 
        builder.build_snapshot([b'A-id'],
2701
 
                               [('modify', ('foo', b'B content\n'))],
2702
 
                               revision_id=b'B-id')
2703
 
        builder.build_snapshot([b'A-id'],
2704
 
                               [('rename', ('a', 'b'))],
2705
 
                               revision_id=b'C-id')
2706
 
        builder.build_snapshot([b'C-id', b'B-id'],
2707
 
                               [('rename', ('b', 'c')),
2708
 
                                ('modify', ('foo', b'E content\n'))],
2709
 
                               revision_id=b'E-id')
2710
 
        builder.build_snapshot([b'B-id', b'C-id'],
2711
 
                               [('rename', ('a', 'b'))], revision_id=b'D-id')  # merged change
 
2501
        builder.build_snapshot('A-id', None,
 
2502
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2503
             ('add', (u'a', 'a-id', 'file', 'base content\n')),
 
2504
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2505
        builder.build_snapshot('B-id', ['A-id'],
 
2506
            [('modify', ('foo-id', 'B content\n'))])
 
2507
        builder.build_snapshot('C-id', ['A-id'],
 
2508
            [('rename', ('a', 'b'))])
 
2509
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2510
            [('rename', ('b', 'c')),
 
2511
             ('modify', ('foo-id', 'E content\n'))])
 
2512
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
2513
            [('rename', ('a', 'b'))]) # merged change
2712
2514
        wt_this = self.get_wt_from_builder(builder)
2713
 
        wt_base = wt_this.controldir.sprout('base', b'A-id').open_workingtree()
 
2515
        wt_base = wt_this.bzrdir.sprout('base', 'A-id').open_workingtree()
2714
2516
        wt_base.lock_read()
2715
2517
        self.addCleanup(wt_base.unlock)
2716
 
        wt_lca1 = wt_this.controldir.sprout(
2717
 
            'b-tree', b'B-id').open_workingtree()
 
2518
        wt_lca1 = wt_this.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
2718
2519
        wt_lca1.lock_read()
2719
2520
        self.addCleanup(wt_lca1.unlock)
2720
 
        wt_lca2 = wt_this.controldir.sprout(
2721
 
            'c-tree', b'C-id').open_workingtree()
 
2521
        wt_lca2 = wt_this.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
2722
2522
        wt_lca2.lock_read()
2723
2523
        self.addCleanup(wt_lca2.unlock)
2724
 
        wt_other = wt_this.controldir.sprout(
2725
 
            'other', b'E-id').open_workingtree()
 
2524
        wt_other = wt_this.bzrdir.sprout('other', 'E-id').open_workingtree()
2726
2525
        wt_other.lock_read()
2727
2526
        self.addCleanup(wt_other.unlock)
2728
2527
        merge_obj = _mod_merge.Merge3Merger(wt_this, wt_this, wt_base,
2729
 
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2528
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2730
2529
        entries = list(merge_obj._entries_lca())
2731
 
        root_id = b'a-root-id'
2732
 
        self.assertEqual([(b'a-id', False,
2733
 
                           ((u'a', [u'a', u'b']), u'c', u'b'),
2734
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2735
 
                           ((u'a', [u'a', u'b']), u'c', u'b'),
2736
 
                           ((False, [False, False]), False, False)),
2737
 
                          (b'foo-id', True,
2738
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2739
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2740
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2741
 
                           ((False, [False, False]), False, False)),
2742
 
                          ], entries)
 
2530
        root_id = 'a-root-id'
 
2531
        self.assertEqual([('a-id', False,
 
2532
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2533
                           ((u'a', [u'a', u'b']), u'c', u'b'),
 
2534
                           ((False, [False, False]), False, False)),
 
2535
                          ('foo-id', True,
 
2536
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2537
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2538
                           ((False, [False, False]), False, False)),
 
2539
                         ], entries)
2743
2540
 
2744
2541
    def test_nested_tree_unmodified(self):
2745
2542
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2746
2543
        # 'tree-reference'
2747
2544
        wt = self.make_branch_and_tree('tree',
2748
 
                                       format='development-subtree')
 
2545
            format='dirstate-with-subtree')
2749
2546
        wt.lock_write()
2750
2547
        self.addCleanup(wt.unlock)
2751
2548
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
2752
 
                                             format='development-subtree')
2753
 
        wt.set_root_id(b'a-root-id')
2754
 
        sub_tree.set_root_id(b'sub-tree-root')
2755
 
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
 
2549
            format='dirstate-with-subtree')
 
2550
        wt.set_root_id('a-root-id')
 
2551
        sub_tree.set_root_id('sub-tree-root')
 
2552
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
2756
2553
        sub_tree.add('file')
2757
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2554
        sub_tree.commit('foo', rev_id='sub-A-id')
2758
2555
        wt.add_reference(sub_tree)
2759
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2556
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2760
2557
        # Now create a criss-cross merge in the parent, without modifying the
2761
2558
        # subtree
2762
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2763
 
        wt.set_last_revision(b'A-id')
2764
 
        wt.branch.set_last_revision_info(1, b'A-id')
2765
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2766
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2767
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2768
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2769
 
        wt.branch.set_last_revision_info(2, b'B-id')
2770
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2559
        wt.commit('B', rev_id='B-id', recursive=None)
 
2560
        wt.set_last_revision('A-id')
 
2561
        wt.branch.set_last_revision_info(1, 'A-id')
 
2562
        wt.commit('C', rev_id='C-id', recursive=None)
 
2563
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2564
        wt.commit('E', rev_id='E-id', recursive=None)
 
2565
        wt.set_parent_ids(['B-id', 'C-id'])
 
2566
        wt.branch.set_last_revision_info(2, 'B-id')
 
2567
        wt.commit('D', rev_id='D-id', recursive=None)
2771
2568
 
2772
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2569
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2570
            wt, 'E-id')
2773
2571
        merger.merge_type = _mod_merge.Merge3Merger
2774
2572
        merge_obj = merger.make_merger()
2775
2573
        entries = list(merge_obj._entries_lca())
2779
2577
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2780
2578
        # 'tree-reference'
2781
2579
        wt = self.make_branch_and_tree('tree',
2782
 
                                       format='development-subtree')
 
2580
            format='dirstate-with-subtree')
2783
2581
        wt.lock_write()
2784
2582
        self.addCleanup(wt.unlock)
2785
2583
        sub_tree = self.make_branch_and_tree('tree/sub',
2786
 
                                             format='development-subtree')
2787
 
        wt.set_root_id(b'a-root-id')
2788
 
        sub_tree.set_root_id(b'sub-tree-root')
2789
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2584
            format='dirstate-with-subtree')
 
2585
        wt.set_root_id('a-root-id')
 
2586
        sub_tree.set_root_id('sub-tree-root')
 
2587
        self.build_tree_contents([('tree/sub/file', 'text1')])
2790
2588
        sub_tree.add('file')
2791
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2589
        sub_tree.commit('foo', rev_id='sub-A-id')
2792
2590
        wt.add_reference(sub_tree)
2793
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2591
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2794
2592
        # Now create a criss-cross merge in the parent, without modifying the
2795
2593
        # subtree
2796
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2797
 
        wt.set_last_revision(b'A-id')
2798
 
        wt.branch.set_last_revision_info(1, b'A-id')
2799
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2800
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2801
 
        self.build_tree_contents([('tree/sub/file', b'text2')])
2802
 
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
2803
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2804
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2805
 
        wt.branch.set_last_revision_info(2, b'B-id')
2806
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2594
        wt.commit('B', rev_id='B-id', recursive=None)
 
2595
        wt.set_last_revision('A-id')
 
2596
        wt.branch.set_last_revision_info(1, 'A-id')
 
2597
        wt.commit('C', rev_id='C-id', recursive=None)
 
2598
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2599
        self.build_tree_contents([('tree/sub/file', 'text2')])
 
2600
        sub_tree.commit('modify contents', rev_id='sub-B-id')
 
2601
        wt.commit('E', rev_id='E-id', recursive=None)
 
2602
        wt.set_parent_ids(['B-id', 'C-id'])
 
2603
        wt.branch.set_last_revision_info(2, 'B-id')
 
2604
        wt.commit('D', rev_id='D-id', recursive=None)
2807
2605
 
2808
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2606
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2607
            wt, 'E-id')
2809
2608
        merger.merge_type = _mod_merge.Merge3Merger
2810
2609
        merge_obj = merger.make_merger()
2811
2610
        entries = list(merge_obj._entries_lca())
2817
2616
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2818
2617
        # 'tree-reference'
2819
2618
        wt = self.make_branch_and_tree('tree',
2820
 
                                       format='development-subtree')
 
2619
            format='dirstate-with-subtree')
2821
2620
        wt.lock_write()
2822
2621
        self.addCleanup(wt.unlock)
2823
2622
        sub_tree = self.make_branch_and_tree('tree/sub',
2824
 
                                             format='development-subtree')
2825
 
        wt.set_root_id(b'a-root-id')
2826
 
        sub_tree.set_root_id(b'sub-tree-root')
2827
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2623
            format='dirstate-with-subtree')
 
2624
        wt.set_root_id('a-root-id')
 
2625
        sub_tree.set_root_id('sub-tree-root')
 
2626
        self.build_tree_contents([('tree/sub/file', 'text1')])
2828
2627
        sub_tree.add('file')
2829
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2628
        sub_tree.commit('foo', rev_id='sub-A-id')
2830
2629
        wt.add_reference(sub_tree)
2831
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2630
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2832
2631
        # Now create a criss-cross merge in the parent, without modifying the
2833
2632
        # subtree
2834
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2835
 
        wt.set_last_revision(b'A-id')
2836
 
        wt.branch.set_last_revision_info(1, b'A-id')
2837
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2838
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
 
2633
        wt.commit('B', rev_id='B-id', recursive=None)
 
2634
        wt.set_last_revision('A-id')
 
2635
        wt.branch.set_last_revision_info(1, 'A-id')
 
2636
        wt.commit('C', rev_id='C-id', recursive=None)
 
2637
        wt.merge_from_branch(wt.branch, to_revision='B-id')
2839
2638
        wt.rename_one('sub', 'alt_sub')
2840
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2841
 
        wt.set_last_revision(b'B-id')
 
2639
        wt.commit('E', rev_id='E-id', recursive=None)
 
2640
        wt.set_last_revision('B-id')
2842
2641
        wt.revert()
2843
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2844
 
        wt.branch.set_last_revision_info(2, b'B-id')
2845
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2642
        wt.set_parent_ids(['B-id', 'C-id'])
 
2643
        wt.branch.set_last_revision_info(2, 'B-id')
 
2644
        wt.commit('D', rev_id='D-id', recursive=None)
2846
2645
 
2847
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2646
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2647
            wt, 'E-id')
2848
2648
        merger.merge_type = _mod_merge.Merge3Merger
2849
2649
        merge_obj = merger.make_merger()
2850
2650
        entries = list(merge_obj._entries_lca())
2851
 
        root_id = b'a-root-id'
2852
 
        self.assertEqual([(b'sub-tree-root', False,
2853
 
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
 
2651
        root_id = 'a-root-id'
 
2652
        self.assertEqual([('sub-tree-root', False,
2854
2653
                           ((root_id, [root_id, root_id]), root_id, root_id),
2855
2654
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2856
2655
                           ((False, [False, False]), False, False)),
2857
 
                          ], entries)
 
2656
                         ], entries)
2858
2657
 
2859
2658
    def test_nested_tree_subtree_renamed_and_modified(self):
2860
2659
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2861
2660
        # 'tree-reference'
2862
2661
        wt = self.make_branch_and_tree('tree',
2863
 
                                       format='development-subtree')
 
2662
            format='dirstate-with-subtree')
2864
2663
        wt.lock_write()
2865
2664
        self.addCleanup(wt.unlock)
2866
2665
        sub_tree = self.make_branch_and_tree('tree/sub',
2867
 
                                             format='development-subtree')
2868
 
        wt.set_root_id(b'a-root-id')
2869
 
        sub_tree.set_root_id(b'sub-tree-root')
2870
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2666
            format='dirstate-with-subtree')
 
2667
        wt.set_root_id('a-root-id')
 
2668
        sub_tree.set_root_id('sub-tree-root')
 
2669
        self.build_tree_contents([('tree/sub/file', 'text1')])
2871
2670
        sub_tree.add('file')
2872
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2671
        sub_tree.commit('foo', rev_id='sub-A-id')
2873
2672
        wt.add_reference(sub_tree)
2874
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2673
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2875
2674
        # Now create a criss-cross merge in the parent, without modifying the
2876
2675
        # subtree
2877
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2878
 
        wt.set_last_revision(b'A-id')
2879
 
        wt.branch.set_last_revision_info(1, b'A-id')
2880
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2881
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2882
 
        self.build_tree_contents([('tree/sub/file', b'text2')])
2883
 
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
 
2676
        wt.commit('B', rev_id='B-id', recursive=None)
 
2677
        wt.set_last_revision('A-id')
 
2678
        wt.branch.set_last_revision_info(1, 'A-id')
 
2679
        wt.commit('C', rev_id='C-id', recursive=None)
 
2680
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2681
        self.build_tree_contents([('tree/sub/file', 'text2')])
 
2682
        sub_tree.commit('modify contents', rev_id='sub-B-id')
2884
2683
        wt.rename_one('sub', 'alt_sub')
2885
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2886
 
        wt.set_last_revision(b'B-id')
 
2684
        wt.commit('E', rev_id='E-id', recursive=None)
 
2685
        wt.set_last_revision('B-id')
2887
2686
        wt.revert()
2888
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2889
 
        wt.branch.set_last_revision_info(2, b'B-id')
2890
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2687
        wt.set_parent_ids(['B-id', 'C-id'])
 
2688
        wt.branch.set_last_revision_info(2, 'B-id')
 
2689
        wt.commit('D', rev_id='D-id', recursive=None)
2891
2690
 
2892
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2691
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2692
            wt, 'E-id')
2893
2693
        merger.merge_type = _mod_merge.Merge3Merger
2894
2694
        merge_obj = merger.make_merger()
2895
2695
        entries = list(merge_obj._entries_lca())
2896
 
        root_id = b'a-root-id'
2897
 
        self.assertEqual([(b'sub-tree-root', False,
2898
 
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
 
2696
        root_id = 'a-root-id'
 
2697
        self.assertEqual([('sub-tree-root', False,
2899
2698
                           ((root_id, [root_id, root_id]), root_id, root_id),
2900
2699
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2901
2700
                           ((False, [False, False]), False, False)),
2902
 
                          ], entries)
 
2701
                         ], entries)
2903
2702
 
2904
2703
 
2905
2704
class TestLCAMultiWay(tests.TestCase):
2907
2706
    def assertLCAMultiWay(self, expected, base, lcas, other, this,
2908
2707
                          allow_overriding_lca=True):
2909
2708
        self.assertEqual(expected, _mod_merge.Merge3Merger._lca_multi_way(
2910
 
            (base, lcas), other, this,
2911
 
            allow_overriding_lca=allow_overriding_lca))
 
2709
                                (base, lcas), other, this,
 
2710
                                allow_overriding_lca=allow_overriding_lca))
2912
2711
 
2913
2712
    def test_other_equal_equal_lcas(self):
2914
2713
        """Test when OTHER=LCA and all LCAs are identical."""
2915
2714
        self.assertLCAMultiWay('this',
2916
 
                               'bval', ['bval', 'bval'], 'bval', 'bval')
2917
 
        self.assertLCAMultiWay('this',
2918
 
                               'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
2919
 
        self.assertLCAMultiWay('this',
2920
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
2921
 
        self.assertLCAMultiWay('this',
2922
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
2923
 
        self.assertLCAMultiWay('this',
2924
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
 
2715
            'bval', ['bval', 'bval'], 'bval', 'bval')
 
2716
        self.assertLCAMultiWay('this',
 
2717
            'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
 
2718
        self.assertLCAMultiWay('this',
 
2719
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
 
2720
        self.assertLCAMultiWay('this',
 
2721
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
 
2722
        self.assertLCAMultiWay('this',
 
2723
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
2925
2724
 
2926
2725
    def test_other_equal_this(self):
2927
2726
        """Test when other and this are identical."""
2928
2727
        self.assertLCAMultiWay('this',
2929
 
                               'bval', ['bval', 'bval'], 'oval', 'oval')
2930
 
        self.assertLCAMultiWay('this',
2931
 
                               'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
2932
 
        self.assertLCAMultiWay('this',
2933
 
                               'bval', ['cval', 'dval'], 'oval', 'oval')
2934
 
        self.assertLCAMultiWay('this',
2935
 
                               'bval', [None, 'lcaval'], 'oval', 'oval')
2936
 
        self.assertLCAMultiWay('this',
2937
 
                               None, [None, 'lcaval'], 'oval', 'oval')
2938
 
        self.assertLCAMultiWay('this',
2939
 
                               None, ['lcaval', 'lcaval'], 'oval', 'oval')
2940
 
        self.assertLCAMultiWay('this',
2941
 
                               None, ['cval', 'dval'], 'oval', 'oval')
2942
 
        self.assertLCAMultiWay('this',
2943
 
                               None, ['cval', 'dval'], None, None)
2944
 
        self.assertLCAMultiWay('this',
2945
 
                               None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
 
2728
            'bval', ['bval', 'bval'], 'oval', 'oval')
 
2729
        self.assertLCAMultiWay('this',
 
2730
            'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
 
2731
        self.assertLCAMultiWay('this',
 
2732
            'bval', ['cval', 'dval'], 'oval', 'oval')
 
2733
        self.assertLCAMultiWay('this',
 
2734
            'bval', [None, 'lcaval'], 'oval', 'oval')
 
2735
        self.assertLCAMultiWay('this',
 
2736
            None, [None, 'lcaval'], 'oval', 'oval')
 
2737
        self.assertLCAMultiWay('this',
 
2738
            None, ['lcaval', 'lcaval'], 'oval', 'oval')
 
2739
        self.assertLCAMultiWay('this',
 
2740
            None, ['cval', 'dval'], 'oval', 'oval')
 
2741
        self.assertLCAMultiWay('this',
 
2742
            None, ['cval', 'dval'], None, None)
 
2743
        self.assertLCAMultiWay('this',
 
2744
            None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
2946
2745
 
2947
2746
    def test_no_lcas(self):
2948
2747
        self.assertLCAMultiWay('this',
2949
 
                               'bval', [], 'bval', 'tval')
 
2748
            'bval', [], 'bval', 'tval')
2950
2749
        self.assertLCAMultiWay('other',
2951
 
                               'bval', [], 'oval', 'bval')
 
2750
            'bval', [], 'oval', 'bval')
2952
2751
        self.assertLCAMultiWay('conflict',
2953
 
                               'bval', [], 'oval', 'tval')
 
2752
            'bval', [], 'oval', 'tval')
2954
2753
        self.assertLCAMultiWay('this',
2955
 
                               'bval', [], 'oval', 'oval')
 
2754
            'bval', [], 'oval', 'oval')
2956
2755
 
2957
2756
    def test_lca_supersedes_other_lca(self):
2958
2757
        """If one lca == base, the other lca takes precedence"""
2959
2758
        self.assertLCAMultiWay('this',
2960
 
                               'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
 
2759
            'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
2961
2760
        self.assertLCAMultiWay('this',
2962
 
                               'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
 
2761
            'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
2963
2762
        # This is actually considered a 'revert' because the 'lcaval' in LCAS
2964
2763
        # supersedes the BASE val (in the other LCA) but then OTHER reverts it
2965
2764
        # back to bval.
2966
2765
        self.assertLCAMultiWay('other',
2967
 
                               'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
 
2766
            'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
2968
2767
        self.assertLCAMultiWay('conflict',
2969
 
                               'bval', ['bval', 'lcaval'], 'bval', 'tval')
 
2768
            'bval', ['bval', 'lcaval'], 'bval', 'tval')
2970
2769
 
2971
2770
    def test_other_and_this_pick_different_lca(self):
2972
2771
        # OTHER and THIS resolve the lca conflict in different ways
2973
2772
        self.assertLCAMultiWay('conflict',
2974
 
                               'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
2975
 
        self.assertLCAMultiWay('conflict',
2976
 
                               'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
2977
 
        self.assertLCAMultiWay('conflict',
2978
 
                               'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
 
2773
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
 
2774
        self.assertLCAMultiWay('conflict',
 
2775
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
 
2776
        self.assertLCAMultiWay('conflict',
 
2777
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
2979
2778
 
2980
2779
    def test_other_in_lca(self):
2981
2780
        # OTHER takes a value of one of the LCAs, THIS takes a new value, which
2982
2781
        # theoretically supersedes both LCA values and 'wins'
2983
 
        self.assertLCAMultiWay(
2984
 
            'this', 'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
2985
 
        self.assertLCAMultiWay(
2986
 
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
2987
 
            'newval')
2988
 
        self.assertLCAMultiWay('conflict',
2989
 
                               'bval', ['lca1val',
2990
 
                                        'lca2val'], 'lca1val', 'newval',
2991
 
                               allow_overriding_lca=False)
2992
 
        self.assertLCAMultiWay('conflict',
2993
 
                               'bval', ['lca1val', 'lca2val',
2994
 
                                        'lca3val'], 'lca1val', 'newval',
2995
 
                               allow_overriding_lca=False)
 
2782
        self.assertLCAMultiWay('this',
 
2783
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
 
2784
        self.assertLCAMultiWay('this',
 
2785
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval')
 
2786
        self.assertLCAMultiWay('conflict',
 
2787
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval',
 
2788
            allow_overriding_lca=False)
 
2789
        self.assertLCAMultiWay('conflict',
 
2790
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval',
 
2791
            allow_overriding_lca=False)
2996
2792
        # THIS reverted back to BASE, but that is an explicit supersede of all
2997
2793
        # LCAs
2998
 
        self.assertLCAMultiWay(
2999
 
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
3000
 
            'bval')
3001
 
        self.assertLCAMultiWay(
3002
 
            'this', 'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
3003
 
        self.assertLCAMultiWay('conflict',
3004
 
                               'bval', ['lca1val', 'lca2val',
3005
 
                                        'lca3val'], 'lca1val', 'bval',
3006
 
                               allow_overriding_lca=False)
3007
 
        self.assertLCAMultiWay('conflict',
3008
 
                               'bval', ['lca1val', 'lca2val',
3009
 
                                        'bval'], 'lca1val', 'bval',
3010
 
                               allow_overriding_lca=False)
 
2794
        self.assertLCAMultiWay('this',
 
2795
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval')
 
2796
        self.assertLCAMultiWay('this',
 
2797
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
 
2798
        self.assertLCAMultiWay('conflict',
 
2799
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval',
 
2800
            allow_overriding_lca=False)
 
2801
        self.assertLCAMultiWay('conflict',
 
2802
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval',
 
2803
            allow_overriding_lca=False)
3011
2804
 
3012
2805
    def test_this_in_lca(self):
3013
2806
        # THIS takes a value of one of the LCAs, OTHER takes a new value, which
3014
2807
        # theoretically supersedes both LCA values and 'wins'
3015
 
        self.assertLCAMultiWay(
3016
 
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
3017
 
        self.assertLCAMultiWay(
3018
 
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
3019
 
        self.assertLCAMultiWay('conflict',
3020
 
                               'bval', ['lca1val',
3021
 
                                        'lca2val'], 'oval', 'lca1val',
3022
 
                               allow_overriding_lca=False)
3023
 
        self.assertLCAMultiWay('conflict',
3024
 
                               'bval', ['lca1val',
3025
 
                                        'lca2val'], 'oval', 'lca2val',
3026
 
                               allow_overriding_lca=False)
 
2808
        self.assertLCAMultiWay('other',
 
2809
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
 
2810
        self.assertLCAMultiWay('other',
 
2811
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
 
2812
        self.assertLCAMultiWay('conflict',
 
2813
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val',
 
2814
            allow_overriding_lca=False)
 
2815
        self.assertLCAMultiWay('conflict',
 
2816
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val',
 
2817
            allow_overriding_lca=False)
3027
2818
        # OTHER reverted back to BASE, but that is an explicit supersede of all
3028
2819
        # LCAs
3029
 
        self.assertLCAMultiWay(
3030
 
            'other', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval',
3031
 
            'lca3val')
3032
 
        self.assertLCAMultiWay(
3033
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'],
3034
 
            'bval', 'lca3val', allow_overriding_lca=False)
 
2820
        self.assertLCAMultiWay('other',
 
2821
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val')
 
2822
        self.assertLCAMultiWay('conflict',
 
2823
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val',
 
2824
            allow_overriding_lca=False)
3035
2825
 
3036
2826
    def test_all_differ(self):
3037
 
        self.assertLCAMultiWay(
3038
 
            'conflict', 'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
3039
 
        self.assertLCAMultiWay(
3040
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval',
3041
 
            'tval')
3042
 
        self.assertLCAMultiWay(
3043
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval',
3044
 
            'tval')
 
2827
        self.assertLCAMultiWay('conflict',
 
2828
            'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
 
2829
        self.assertLCAMultiWay('conflict',
 
2830
            'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval', 'tval')
 
2831
        self.assertLCAMultiWay('conflict',
 
2832
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval', 'tval')
3045
2833
 
3046
2834
 
3047
2835
class TestConfigurableFileMerger(tests.TestCaseWithTransport):
3052
2840
 
3053
2841
    def get_merger_factory(self):
3054
2842
        # Allows  the inner methods to access the test attributes
3055
 
        calls = self.calls
 
2843
        test = self
3056
2844
 
3057
2845
        class FooMerger(_mod_merge.ConfigurableFileMerger):
3058
2846
            name_prefix = "foo"
3059
2847
            default_files = ['bar']
3060
2848
 
3061
2849
            def merge_text(self, params):
3062
 
                calls.append('merge_text')
 
2850
                test.calls.append('merge_text')
3063
2851
                return ('not_applicable', None)
3064
2852
 
3065
2853
        def factory(merger):
3085
2873
        factory = self.get_merger_factory()
3086
2874
        self._install_hook(factory)
3087
2875
        builder = self.make_builder()
3088
 
        builder.add_file(b'bar-id', builder.tree_root,
3089
 
                         file_name, b'text1', True)
3090
 
        builder.change_contents(b'bar-id', other=b'text4', this=b'text3')
 
2876
        builder.add_file('bar-id', builder.tree_root, file_name, 'text1', True)
 
2877
        builder.change_contents('bar-id', other='text4', this='text3')
3091
2878
        return builder
3092
2879
 
3093
2880
    def make_kind_change(self):
3094
2881
        factory = self.get_merger_factory()
3095
2882
        self._install_hook(factory)
3096
2883
        builder = self.make_builder()
3097
 
        builder.add_file(b'bar-id', builder.tree_root, 'bar', b'text1', True,
 
2884
        builder.add_file('bar-id', builder.tree_root, 'bar', 'text1', True,
3098
2885
                         this=False)
3099
 
        builder.add_dir(b'bar-dir', builder.tree_root, 'bar-id',
 
2886
        builder.add_dir('bar-dir', builder.tree_root, 'bar-id',
3100
2887
                        base=False, other=False)
3101
2888
        return builder
3102
2889
 
3103
2890
    def test_uses_this_branch(self):
3104
2891
        builder = self.make_text_conflict()
3105
 
        with builder.make_preview_transform() as tt:
3106
 
            pass
 
2892
        tt = builder.make_preview_transform()
 
2893
        self.addCleanup(tt.finalize)
3107
2894
 
3108
2895
    def test_affected_files_cached(self):
3109
2896
        """Ensures that the config variable is cached"""
3115
2902
 
3116
2903
    def test_hook_called_for_text_conflicts(self):
3117
2904
        builder = self.make_text_conflict()
3118
 
        builder.merge()
 
2905
        conflicts = builder.merge()
3119
2906
        # The hook should call the merge_text() method
3120
2907
        self.assertEqual(['merge_text'], self.calls)
3121
2908
 
3122
2909
    def test_hook_not_called_for_kind_change(self):
3123
2910
        builder = self.make_kind_change()
3124
 
        builder.merge()
 
2911
        conflicts = builder.merge()
3125
2912
        # The hook should not call the merge_text() method
3126
2913
        self.assertEqual([], self.calls)
3127
2914
 
3128
2915
    def test_hook_not_called_for_other_files(self):
3129
2916
        builder = self.make_text_conflict('foobar')
3130
 
        builder.merge()
 
2917
        conflicts = builder.merge()
3131
2918
        # The hook should not call the merge_text() method
3132
2919
        self.assertEqual([], self.calls)
3133
 
 
3134
 
 
3135
 
class TestMergeIntoBase(tests.TestCaseWithTransport):
3136
 
 
3137
 
    def setup_simple_branch(self, relpath, shape=None, root_id=None):
3138
 
        """One commit, containing tree specified by optional shape.
3139
 
 
3140
 
        Default is empty tree (just root entry).
3141
 
        """
3142
 
        if root_id is None:
3143
 
            root_id = b'%s-root-id' % (relpath.encode('ascii'),)
3144
 
        wt = self.make_branch_and_tree(relpath)
3145
 
        wt.set_root_id(root_id)
3146
 
        if shape is not None:
3147
 
            adjusted_shape = [relpath + '/' + elem for elem in shape]
3148
 
            self.build_tree(adjusted_shape)
3149
 
            ids = [
3150
 
                (b'%s-%s-id' % (relpath.encode('utf-8'),
3151
 
                                basename(elem.rstrip('/')).encode('ascii')))
3152
 
                for elem in shape]
3153
 
            wt.add(shape, ids=ids)
3154
 
        rev_id = b'r1-%s' % (relpath.encode('utf-8'),)
3155
 
        wt.commit("Initial commit of %s" % (relpath,), rev_id=rev_id)
3156
 
        self.assertEqual(root_id, wt.path2id(''))
3157
 
        return wt
3158
 
 
3159
 
    def setup_two_branches(self, custom_root_ids=True):
3160
 
        """Setup 2 branches, one will be a library, the other a project."""
3161
 
        if custom_root_ids:
3162
 
            root_id = None
3163
 
        else:
3164
 
            root_id = inventory.ROOT_ID
3165
 
        project_wt = self.setup_simple_branch(
3166
 
            'project', ['README', 'dir/', 'dir/file.c'],
3167
 
            root_id)
3168
 
        lib_wt = self.setup_simple_branch(
3169
 
            'lib1', ['README', 'Makefile', 'foo.c'], root_id)
3170
 
 
3171
 
        return project_wt, lib_wt
3172
 
 
3173
 
    def do_merge_into(self, location, merge_as):
3174
 
        """Helper for using MergeIntoMerger.
3175
 
 
3176
 
        :param location: location of directory to merge from, either the
3177
 
            location of a branch or of a path inside a branch.
3178
 
        :param merge_as: the path in a tree to add the new directory as.
3179
 
        :returns: the conflicts from 'do_merge'.
3180
 
        """
3181
 
        with contextlib.ExitStack() as stack:
3182
 
            # Open and lock the various tree and branch objects
3183
 
            wt, subdir_relpath = WorkingTree.open_containing(merge_as)
3184
 
            stack.enter_context(wt.lock_write())
3185
 
            branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
3186
 
                location)
3187
 
            stack.enter_context(branch_to_merge.lock_read())
3188
 
            other_tree = branch_to_merge.basis_tree()
3189
 
            stack.enter_context(other_tree.lock_read())
3190
 
            # Perform the merge
3191
 
            merger = _mod_merge.MergeIntoMerger(
3192
 
                this_tree=wt, other_tree=other_tree, other_branch=branch_to_merge,
3193
 
                target_subdir=subdir_relpath, source_subpath=subdir_to_merge)
3194
 
            merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
3195
 
            conflicts = merger.do_merge()
3196
 
            merger.set_pending()
3197
 
            return conflicts
3198
 
 
3199
 
    def assertTreeEntriesEqual(self, expected_entries, tree):
3200
 
        """Assert that 'tree' contains the expected inventory entries.
3201
 
 
3202
 
        :param expected_entries: sequence of (path, file-id) pairs.
3203
 
        """
3204
 
        files = [(path, ie.file_id) for path, ie in tree.iter_entries_by_dir()]
3205
 
        self.assertEqual(expected_entries, files)
3206
 
 
3207
 
 
3208
 
class TestMergeInto(TestMergeIntoBase):
3209
 
 
3210
 
    def test_newdir_with_unique_roots(self):
3211
 
        """Merge a branch with a unique root into a new directory."""
3212
 
        project_wt, lib_wt = self.setup_two_branches()
3213
 
        self.do_merge_into('lib1', 'project/lib1')
3214
 
        project_wt.lock_read()
3215
 
        self.addCleanup(project_wt.unlock)
3216
 
        # The r1-lib1 revision should be merged into this one
3217
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3218
 
                         project_wt.get_parent_ids())
3219
 
        self.assertTreeEntriesEqual(
3220
 
            [('', b'project-root-id'),
3221
 
             ('README', b'project-README-id'),
3222
 
             ('dir', b'project-dir-id'),
3223
 
             ('lib1', b'lib1-root-id'),
3224
 
             ('dir/file.c', b'project-file.c-id'),
3225
 
             ('lib1/Makefile', b'lib1-Makefile-id'),
3226
 
             ('lib1/README', b'lib1-README-id'),
3227
 
             ('lib1/foo.c', b'lib1-foo.c-id'),
3228
 
             ], project_wt)
3229
 
 
3230
 
    def test_subdir(self):
3231
 
        """Merge a branch into a subdirectory of an existing directory."""
3232
 
        project_wt, lib_wt = self.setup_two_branches()
3233
 
        self.do_merge_into('lib1', 'project/dir/lib1')
3234
 
        project_wt.lock_read()
3235
 
        self.addCleanup(project_wt.unlock)
3236
 
        # The r1-lib1 revision should be merged into this one
3237
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3238
 
                         project_wt.get_parent_ids())
3239
 
        self.assertTreeEntriesEqual(
3240
 
            [('', b'project-root-id'),
3241
 
             ('README', b'project-README-id'),
3242
 
             ('dir', b'project-dir-id'),
3243
 
             ('dir/file.c', b'project-file.c-id'),
3244
 
             ('dir/lib1', b'lib1-root-id'),
3245
 
             ('dir/lib1/Makefile', b'lib1-Makefile-id'),
3246
 
             ('dir/lib1/README', b'lib1-README-id'),
3247
 
             ('dir/lib1/foo.c', b'lib1-foo.c-id'),
3248
 
             ], project_wt)
3249
 
 
3250
 
    def test_newdir_with_repeat_roots(self):
3251
 
        """If the file-id of the dir to be merged already exists a new ID will
3252
 
        be allocated to let the merge happen.
3253
 
        """
3254
 
        project_wt, lib_wt = self.setup_two_branches(custom_root_ids=False)
3255
 
        root_id = project_wt.path2id('')
3256
 
        self.do_merge_into('lib1', 'project/lib1')
3257
 
        project_wt.lock_read()
3258
 
        self.addCleanup(project_wt.unlock)
3259
 
        # The r1-lib1 revision should be merged into this one
3260
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3261
 
                         project_wt.get_parent_ids())
3262
 
        new_lib1_id = project_wt.path2id('lib1')
3263
 
        self.assertNotEqual(None, new_lib1_id)
3264
 
        self.assertTreeEntriesEqual(
3265
 
            [('', root_id),
3266
 
             ('README', b'project-README-id'),
3267
 
             ('dir', b'project-dir-id'),
3268
 
             ('lib1', new_lib1_id),
3269
 
             ('dir/file.c', b'project-file.c-id'),
3270
 
             ('lib1/Makefile', b'lib1-Makefile-id'),
3271
 
             ('lib1/README', b'lib1-README-id'),
3272
 
             ('lib1/foo.c', b'lib1-foo.c-id'),
3273
 
             ], project_wt)
3274
 
 
3275
 
    def test_name_conflict(self):
3276
 
        """When the target directory name already exists a conflict is
3277
 
        generated and the original directory is renamed to foo.moved.
3278
 
        """
3279
 
        dest_wt = self.setup_simple_branch('dest', ['dir/', 'dir/file.txt'])
3280
 
        self.setup_simple_branch('src', ['README'])
3281
 
        conflicts = self.do_merge_into('src', 'dest/dir')
3282
 
        self.assertEqual(1, conflicts)
3283
 
        dest_wt.lock_read()
3284
 
        self.addCleanup(dest_wt.unlock)
3285
 
        # The r1-lib1 revision should be merged into this one
3286
 
        self.assertEqual([b'r1-dest', b'r1-src'], dest_wt.get_parent_ids())
3287
 
        self.assertTreeEntriesEqual(
3288
 
            [('', b'dest-root-id'),
3289
 
             ('dir', b'src-root-id'),
3290
 
             ('dir.moved', b'dest-dir-id'),
3291
 
             ('dir/README', b'src-README-id'),
3292
 
             ('dir.moved/file.txt', b'dest-file.txt-id'),
3293
 
             ], dest_wt)
3294
 
 
3295
 
    def test_file_id_conflict(self):
3296
 
        """A conflict is generated if the merge-into adds a file (or other
3297
 
        inventory entry) with a file-id that already exists in the target tree.
3298
 
        """
3299
 
        self.setup_simple_branch('dest', ['file.txt'])
3300
 
        # Make a second tree with a file-id that will clash with file.txt in
3301
 
        # dest.
3302
 
        src_wt = self.make_branch_and_tree('src')
3303
 
        self.build_tree(['src/README'])
3304
 
        src_wt.add(['README'], ids=[b'dest-file.txt-id'])
3305
 
        src_wt.commit("Rev 1 of src.", rev_id=b'r1-src')
3306
 
        conflicts = self.do_merge_into('src', 'dest/dir')
3307
 
        # This is an edge case that shouldn't happen to users very often.  So
3308
 
        # we don't care really about the exact presentation of the conflict,
3309
 
        # just that there is one.
3310
 
        self.assertEqual(1, conflicts)
3311
 
 
3312
 
    def test_only_subdir(self):
3313
 
        """When the location points to just part of a tree, merge just that
3314
 
        subtree.
3315
 
        """
3316
 
        dest_wt = self.setup_simple_branch('dest')
3317
 
        self.setup_simple_branch('src', ['hello.txt', 'dir/', 'dir/foo.c'])
3318
 
        self.do_merge_into('src/dir', 'dest/dir')
3319
 
        dest_wt.lock_read()
3320
 
        self.addCleanup(dest_wt.unlock)
3321
 
        # The r1-lib1 revision should NOT be merged into this one (this is a
3322
 
        # partial merge).
3323
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3324
 
        self.assertTreeEntriesEqual(
3325
 
            [('', b'dest-root-id'),
3326
 
             ('dir', b'src-dir-id'),
3327
 
             ('dir/foo.c', b'src-foo.c-id'),
3328
 
             ], dest_wt)
3329
 
 
3330
 
    def test_only_file(self):
3331
 
        """An edge case: merge just one file, not a whole dir."""
3332
 
        dest_wt = self.setup_simple_branch('dest')
3333
 
        self.setup_simple_branch('two-file', ['file1.txt', 'file2.txt'])
3334
 
        self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
3335
 
        dest_wt.lock_read()
3336
 
        self.addCleanup(dest_wt.unlock)
3337
 
        # The r1-lib1 revision should NOT be merged into this one
3338
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3339
 
        self.assertTreeEntriesEqual(
3340
 
            [('', b'dest-root-id'), ('file1.txt', b'two-file-file1.txt-id')],
3341
 
            dest_wt)
3342
 
 
3343
 
    def test_no_such_source_path(self):
3344
 
        """PathNotInTree is raised if the specified path in the source tree
3345
 
        does not exist.
3346
 
        """
3347
 
        dest_wt = self.setup_simple_branch('dest')
3348
 
        self.setup_simple_branch('src', ['dir/'])
3349
 
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3350
 
                          'src/no-such-dir', 'dest/foo')
3351
 
        dest_wt.lock_read()
3352
 
        self.addCleanup(dest_wt.unlock)
3353
 
        # The dest tree is unmodified.
3354
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3355
 
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
3356
 
 
3357
 
    def test_no_such_target_path(self):
3358
 
        """PathNotInTree is also raised if the specified path in the target
3359
 
        tree does not exist.
3360
 
        """
3361
 
        dest_wt = self.setup_simple_branch('dest')
3362
 
        self.setup_simple_branch('src', ['file.txt'])
3363
 
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3364
 
                          'src', 'dest/no-such-dir/foo')
3365
 
        dest_wt.lock_read()
3366
 
        self.addCleanup(dest_wt.unlock)
3367
 
        # The dest tree is unmodified.
3368
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3369
 
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
3370
 
 
3371
 
 
3372
 
class TestMergeHooks(TestCaseWithTransport):
3373
 
 
3374
 
    def setUp(self):
3375
 
        super(TestMergeHooks, self).setUp()
3376
 
        self.tree_a = self.make_branch_and_tree('tree_a')
3377
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
3378
 
        self.tree_a.add('file', b'file-id')
3379
 
        self.tree_a.commit('added file')
3380
 
 
3381
 
        self.tree_b = self.tree_a.controldir.sprout(
3382
 
            'tree_b').open_workingtree()
3383
 
        self.build_tree_contents([('tree_b/file', b'content_2')])
3384
 
        self.tree_b.commit('modify file')
3385
 
 
3386
 
    def test_pre_merge_hook_inject_different_tree(self):
3387
 
        tree_c = self.tree_b.controldir.sprout('tree_c').open_workingtree()
3388
 
        self.build_tree_contents([('tree_c/file', b'content_3')])
3389
 
        tree_c.commit("more content")
3390
 
        calls = []
3391
 
 
3392
 
        def factory(merger):
3393
 
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3394
 
            merger.other_tree = tree_c
3395
 
            calls.append(merger)
3396
 
        _mod_merge.Merger.hooks.install_named_hook('pre_merge',
3397
 
                                                   factory, 'test factory')
3398
 
        self.tree_a.merge_from_branch(self.tree_b.branch)
3399
 
 
3400
 
        self.assertFileEqual(b"content_3", 'tree_a/file')
3401
 
        self.assertLength(1, calls)
3402
 
 
3403
 
    def test_post_merge_hook_called(self):
3404
 
        calls = []
3405
 
 
3406
 
        def factory(merger):
3407
 
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3408
 
            calls.append(merger)
3409
 
        _mod_merge.Merger.hooks.install_named_hook('post_merge',
3410
 
                                                   factory, 'test factory')
3411
 
 
3412
 
        self.tree_a.merge_from_branch(self.tree_b.branch)
3413
 
 
3414
 
        self.assertFileEqual(b"content_2", 'tree_a/file')
3415
 
        self.assertLength(1, calls)