/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/builtins.py

  • Committer: John Arbash Meinel
  • Date: 2010-08-05 16:27:35 UTC
  • mto: This revision was merged to the branch mainline in revision 5374.
  • Revision ID: john@arbash-meinel.com-20100805162735-172opvx34sr5gpbl
Find a case where we are wasting a bit of memory.

Specifically the 'build_details' tuple contains a lot of wasted references,
and we hold on to one of these for each record we are fetching.
And for something like 'bzr pack', that is all keys.

For just loading all text build details on my bzr+ repository, With:
locations = b.repository.texts._index.get_build_details(b.repository.texts.keys())
This drops the memory consumption from:
WorkingSize   77604KiB
 to
WorkingSize   64640KiB

Or around 10.6MB. I worked it out to a savings of about 80 bytes/record
on data that can have hundreds of thousands of records (in 32-bit).

Show diffs side-by-side

added added

removed removed

Lines of Context:
75
75
from bzrlib.trace import mutter, note, warning, is_quiet, get_verbosity_level
76
76
 
77
77
 
 
78
@symbol_versioning.deprecated_function(symbol_versioning.deprecated_in((2, 3, 0)))
78
79
def tree_files(file_list, default_branch=u'.', canonicalize=True,
79
80
    apply_view=True):
80
 
    try:
81
 
        return internal_tree_files(file_list, default_branch, canonicalize,
82
 
            apply_view)
83
 
    except errors.FileInWrongBranch, e:
84
 
        raise errors.BzrCommandError("%s is not in the same branch as %s" %
85
 
                                     (e.path, file_list[0]))
 
81
    return internal_tree_files(file_list, default_branch, canonicalize,
 
82
        apply_view)
86
83
 
87
84
 
88
85
def tree_files_for_add(file_list):
152
149
 
153
150
# XXX: Bad function name; should possibly also be a class method of
154
151
# WorkingTree rather than a function.
 
152
@symbol_versioning.deprecated_function(symbol_versioning.deprecated_in((2, 3, 0)))
155
153
def internal_tree_files(file_list, default_branch=u'.', canonicalize=True,
156
154
    apply_view=True):
157
155
    """Convert command-line paths to a WorkingTree and relative paths.
158
156
 
 
157
    Deprecated: use WorkingTree.open_containing_paths instead.
 
158
 
159
159
    This is typically used for command-line processors that take one or
160
160
    more filenames, and infer the workingtree that contains them.
161
161
 
171
171
 
172
172
    :return: workingtree, [relative_paths]
173
173
    """
174
 
    if file_list is None or len(file_list) == 0:
175
 
        tree = WorkingTree.open_containing(default_branch)[0]
176
 
        if tree.supports_views() and apply_view:
177
 
            view_files = tree.views.lookup_view()
178
 
            if view_files:
179
 
                file_list = view_files
180
 
                view_str = views.view_display_str(view_files)
181
 
                note("Ignoring files outside view. View is %s" % view_str)
182
 
        return tree, file_list
183
 
    tree = WorkingTree.open_containing(osutils.realpath(file_list[0]))[0]
184
 
    return tree, safe_relpath_files(tree, file_list, canonicalize,
185
 
        apply_view=apply_view)
186
 
 
187
 
 
188
 
def safe_relpath_files(tree, file_list, canonicalize=True, apply_view=True):
189
 
    """Convert file_list into a list of relpaths in tree.
190
 
 
191
 
    :param tree: A tree to operate on.
192
 
    :param file_list: A list of user provided paths or None.
193
 
    :param apply_view: if True and a view is set, apply it or check that
194
 
        specified files are within it
195
 
    :return: A list of relative paths.
196
 
    :raises errors.PathNotChild: When a provided path is in a different tree
197
 
        than tree.
198
 
    """
199
 
    if file_list is None:
200
 
        return None
201
 
    if tree.supports_views() and apply_view:
202
 
        view_files = tree.views.lookup_view()
203
 
    else:
204
 
        view_files = []
205
 
    new_list = []
206
 
    # tree.relpath exists as a "thunk" to osutils, but canonical_relpath
207
 
    # doesn't - fix that up here before we enter the loop.
208
 
    if canonicalize:
209
 
        fixer = lambda p: osutils.canonical_relpath(tree.basedir, p)
210
 
    else:
211
 
        fixer = tree.relpath
212
 
    for filename in file_list:
213
 
        try:
214
 
            relpath = fixer(osutils.dereference_path(filename))
215
 
            if  view_files and not osutils.is_inside_any(view_files, relpath):
216
 
                raise errors.FileOutsideView(filename, view_files)
217
 
            new_list.append(relpath)
218
 
        except errors.PathNotChild:
219
 
            raise errors.FileInWrongBranch(tree.branch, filename)
220
 
    return new_list
 
174
    return WorkingTree.open_containing_paths(
 
175
        file_list, default_directory='.',
 
176
        canonicalize=True,
 
177
        apply_view=True)
221
178
 
222
179
 
223
180
def _get_view_info_for_change_reporter(tree):
232
189
    return view_info
233
190
 
234
191
 
 
192
def _open_directory_or_containing_tree_or_branch(filename, directory):
 
193
    """Open the tree or branch containing the specified file, unless
 
194
    the --directory option is used to specify a different branch."""
 
195
    if directory is not None:
 
196
        return (None, Branch.open(directory), filename)
 
197
    return bzrdir.BzrDir.open_containing_tree_or_branch(filename)
 
198
 
 
199
 
235
200
# TODO: Make sure no commands unconditionally use the working directory as a
236
201
# branch.  If a filename argument is used, the first of them should be used to
237
202
# specify the branch.  (Perhaps this can be factored out into some kind of
315
280
            raise errors.BzrCommandError('bzr status --revision takes exactly'
316
281
                                         ' one or two revision specifiers')
317
282
 
318
 
        tree, relfile_list = tree_files(file_list)
 
283
        tree, relfile_list = WorkingTree.open_containing_paths(file_list)
319
284
        # Avoid asking for specific files when that is not needed.
320
285
        if relfile_list == ['']:
321
286
            relfile_list = None
340
305
 
341
306
    hidden = True
342
307
    takes_args = ['revision_id?']
343
 
    takes_options = ['revision']
 
308
    takes_options = ['directory', 'revision']
344
309
    # cat-revision is more for frontends so should be exact
345
310
    encoding = 'strict'
346
311
 
353
318
        self.outf.write(revtext.decode('utf-8'))
354
319
 
355
320
    @display_command
356
 
    def run(self, revision_id=None, revision=None):
 
321
    def run(self, revision_id=None, revision=None, directory=u'.'):
357
322
        if revision_id is not None and revision is not None:
358
323
            raise errors.BzrCommandError('You can only supply one of'
359
324
                                         ' revision_id or --revision')
360
325
        if revision_id is None and revision is None:
361
326
            raise errors.BzrCommandError('You must supply either'
362
327
                                         ' --revision or a revision_id')
363
 
        b = WorkingTree.open_containing(u'.')[0].branch
 
328
        b = WorkingTree.open_containing(directory)[0].branch
364
329
 
365
330
        revisions = b.repository.revisions
366
331
        if revisions is None:
483
448
    takes_options = [
484
449
        Option('force',
485
450
               help='Remove the working tree even if it has '
486
 
                    'uncommitted changes.'),
 
451
                    'uncommitted or shelved changes.'),
487
452
        ]
488
453
 
489
454
    def run(self, location_list, force=False):
503
468
            if not force:
504
469
                if (working.has_changes()):
505
470
                    raise errors.UncommittedChanges(working)
 
471
                if working.get_shelf_manager().last_shelf() is not None:
 
472
                    raise errors.ShelvedChanges(working)
506
473
 
507
474
            if working.user_url != working.branch.user_url:
508
475
                raise errors.BzrCommandError("You cannot remove the working tree"
528
495
        if tree:
529
496
            try:
530
497
                wt = WorkingTree.open_containing(location)[0]
531
 
                wt.lock_read()
 
498
                self.add_cleanup(wt.lock_read().unlock)
532
499
            except (errors.NoWorkingTree, errors.NotLocalUrl):
533
500
                raise errors.NoWorkingTree(location)
534
 
            self.add_cleanup(wt.unlock)
535
501
            revid = wt.last_revision()
536
502
            try:
537
503
                revno_t = wt.branch.revision_id_to_dotted_revno(revid)
540
506
            revno = ".".join(str(n) for n in revno_t)
541
507
        else:
542
508
            b = Branch.open_containing(location)[0]
543
 
            b.lock_read()
544
 
            self.add_cleanup(b.unlock)
 
509
            self.add_cleanup(b.lock_read().unlock)
545
510
            revno = b.revno()
546
511
        self.cleanup_now()
547
512
        self.outf.write(str(revno) + '\n')
554
519
    takes_args = ['revision_info*']
555
520
    takes_options = [
556
521
        'revision',
557
 
        Option('directory',
 
522
        custom_help('directory',
558
523
            help='Branch to examine, '
559
 
                 'rather than the one containing the working directory.',
560
 
            short_name='d',
561
 
            type=unicode,
562
 
            ),
 
524
                 'rather than the one containing the working directory.'),
563
525
        Option('tree', help='Show revno of working tree'),
564
526
        ]
565
527
 
570
532
        try:
571
533
            wt = WorkingTree.open_containing(directory)[0]
572
534
            b = wt.branch
573
 
            wt.lock_read()
574
 
            self.add_cleanup(wt.unlock)
 
535
            self.add_cleanup(wt.lock_read().unlock)
575
536
        except (errors.NoWorkingTree, errors.NotLocalUrl):
576
537
            wt = None
577
538
            b = Branch.open_containing(directory)[0]
578
 
            b.lock_read()
579
 
            self.add_cleanup(b.unlock)
 
539
            self.add_cleanup(b.lock_read().unlock)
580
540
        revision_ids = []
581
541
        if revision is not None:
582
542
            revision_ids.extend(rev.as_revision_id(b) for rev in revision)
681
641
                should_print=(not is_quiet()))
682
642
 
683
643
        if base_tree:
684
 
            base_tree.lock_read()
685
 
            self.add_cleanup(base_tree.unlock)
 
644
            self.add_cleanup(base_tree.lock_read().unlock)
686
645
        tree, file_list = tree_files_for_add(file_list)
687
646
        added, ignored = tree.smart_add(file_list, not
688
647
            no_recurse, action=action, save=not dry_run)
759
718
            raise errors.BzrCommandError('invalid kind %r specified' % (kind,))
760
719
 
761
720
        revision = _get_one_revision('inventory', revision)
762
 
        work_tree, file_list = tree_files(file_list)
763
 
        work_tree.lock_read()
764
 
        self.add_cleanup(work_tree.unlock)
 
721
        work_tree, file_list = WorkingTree.open_containing_paths(file_list)
 
722
        self.add_cleanup(work_tree.lock_read().unlock)
765
723
        if revision is not None:
766
724
            tree = revision.as_tree(work_tree.branch)
767
725
 
768
726
            extra_trees = [work_tree]
769
 
            tree.lock_read()
770
 
            self.add_cleanup(tree.unlock)
 
727
            self.add_cleanup(tree.lock_read().unlock)
771
728
        else:
772
729
            tree = work_tree
773
730
            extra_trees = []
832
789
            names_list = []
833
790
        if len(names_list) < 2:
834
791
            raise errors.BzrCommandError("missing file argument")
835
 
        tree, rel_names = tree_files(names_list, canonicalize=False)
836
 
        tree.lock_tree_write()
837
 
        self.add_cleanup(tree.unlock)
 
792
        tree, rel_names = WorkingTree.open_containing_paths(names_list, canonicalize=False)
 
793
        self.add_cleanup(tree.lock_tree_write().unlock)
838
794
        self._run(tree, names_list, rel_names, after)
839
795
 
840
796
    def run_auto(self, names_list, after, dry_run):
844
800
        if after:
845
801
            raise errors.BzrCommandError('--after cannot be specified with'
846
802
                                         ' --auto.')
847
 
        work_tree, file_list = tree_files(names_list, default_branch='.')
848
 
        work_tree.lock_tree_write()
849
 
        self.add_cleanup(work_tree.unlock)
 
803
        work_tree, file_list = WorkingTree.open_containing_paths(
 
804
            names_list, default_directory='.')
 
805
        self.add_cleanup(work_tree.lock_tree_write().unlock)
850
806
        rename_map.RenameMap.guess_renames(work_tree, dry_run)
851
807
 
852
808
    def _run(self, tree, names_list, rel_names, after):
960
916
    takes_options = ['remember', 'overwrite', 'revision',
961
917
        custom_help('verbose',
962
918
            help='Show logs of pulled revisions.'),
963
 
        Option('directory',
 
919
        custom_help('directory',
964
920
            help='Branch to pull into, '
965
 
                 'rather than the one containing the working directory.',
966
 
            short_name='d',
967
 
            type=unicode,
968
 
            ),
 
921
                 'rather than the one containing the working directory.'),
969
922
        Option('local',
970
923
            help="Perform a local pull in a bound "
971
924
                 "branch.  Local pulls are not applied to "
986
939
        try:
987
940
            tree_to = WorkingTree.open_containing(directory)[0]
988
941
            branch_to = tree_to.branch
989
 
            tree_to.lock_write()
990
 
            self.add_cleanup(tree_to.unlock)
 
942
            self.add_cleanup(tree_to.lock_write().unlock)
991
943
        except errors.NoWorkingTree:
992
944
            tree_to = None
993
945
            branch_to = Branch.open_containing(directory)[0]
994
 
            branch_to.lock_write()
995
 
            self.add_cleanup(branch_to.unlock)
 
946
            self.add_cleanup(branch_to.lock_write().unlock)
996
947
 
997
948
        if local and not branch_to.get_bound_location():
998
949
            raise errors.LocalRequiresBoundBranch()
1029
980
        else:
1030
981
            branch_from = Branch.open(location,
1031
982
                possible_transports=possible_transports)
1032
 
            branch_from.lock_read()
1033
 
            self.add_cleanup(branch_from.unlock)
 
983
            self.add_cleanup(branch_from.lock_read().unlock)
1034
984
 
1035
985
            if branch_to.get_parent() is None or remember:
1036
986
                branch_to.set_parent(branch_from.base)
1088
1038
        Option('create-prefix',
1089
1039
               help='Create the path leading up to the branch '
1090
1040
                    'if it does not already exist.'),
1091
 
        Option('directory',
 
1041
        custom_help('directory',
1092
1042
            help='Branch to push from, '
1093
 
                 'rather than the one containing the working directory.',
1094
 
            short_name='d',
1095
 
            type=unicode,
1096
 
            ),
 
1043
                 'rather than the one containing the working directory.'),
1097
1044
        Option('use-existing-dir',
1098
1045
               help='By default push will fail if the target'
1099
1046
                    ' directory exists, but does not already'
1188
1135
 
1189
1136
    _see_also = ['checkout']
1190
1137
    takes_args = ['from_location', 'to_location?']
1191
 
    takes_options = ['revision', Option('hardlink',
1192
 
        help='Hard-link working tree files where possible.'),
 
1138
    takes_options = ['revision',
 
1139
        Option('hardlink', help='Hard-link working tree files where possible.'),
 
1140
        Option('files-from', type=str,
 
1141
               help="Get file contents from this tree."),
1193
1142
        Option('no-tree',
1194
1143
            help="Create a branch without a working-tree."),
1195
1144
        Option('switch',
1213
1162
 
1214
1163
    def run(self, from_location, to_location=None, revision=None,
1215
1164
            hardlink=False, stacked=False, standalone=False, no_tree=False,
1216
 
            use_existing_dir=False, switch=False, bind=False):
 
1165
            use_existing_dir=False, switch=False, bind=False,
 
1166
            files_from=None):
1217
1167
        from bzrlib import switch as _mod_switch
1218
1168
        from bzrlib.tag import _merge_tags_if_possible
1219
1169
        accelerator_tree, br_from = bzrdir.BzrDir.open_tree_or_branch(
1220
1170
            from_location)
 
1171
        if not (hardlink or files_from):
 
1172
            # accelerator_tree is usually slower because you have to read N
 
1173
            # files (no readahead, lots of seeks, etc), but allow the user to
 
1174
            # explicitly request it
 
1175
            accelerator_tree = None
 
1176
        if files_from is not None and files_from != from_location:
 
1177
            accelerator_tree = WorkingTree.open(files_from)
1221
1178
        revision = _get_one_revision('branch', revision)
1222
 
        br_from.lock_read()
1223
 
        self.add_cleanup(br_from.unlock)
 
1179
        self.add_cleanup(br_from.lock_read().unlock)
1224
1180
        if revision is not None:
1225
1181
            revision_id = revision.as_revision_id(br_from)
1226
1182
        else:
1331
1287
            to_location = branch_location
1332
1288
        accelerator_tree, source = bzrdir.BzrDir.open_tree_or_branch(
1333
1289
            branch_location)
 
1290
        if not (hardlink or files_from):
 
1291
            # accelerator_tree is usually slower because you have to read N
 
1292
            # files (no readahead, lots of seeks, etc), but allow the user to
 
1293
            # explicitly request it
 
1294
            accelerator_tree = None
1334
1295
        revision = _get_one_revision('checkout', revision)
1335
 
        if files_from is not None:
 
1296
        if files_from is not None and files_from != branch_location:
1336
1297
            accelerator_tree = WorkingTree.open(files_from)
1337
1298
        if revision is not None:
1338
1299
            revision_id = revision.as_revision_id(source)
1366
1327
    @display_command
1367
1328
    def run(self, dir=u'.'):
1368
1329
        tree = WorkingTree.open_containing(dir)[0]
1369
 
        tree.lock_read()
1370
 
        self.add_cleanup(tree.unlock)
 
1330
        self.add_cleanup(tree.lock_read().unlock)
1371
1331
        new_inv = tree.inventory
1372
1332
        old_tree = tree.basis_tree()
1373
 
        old_tree.lock_read()
1374
 
        self.add_cleanup(old_tree.unlock)
 
1333
        self.add_cleanup(old_tree.lock_read().unlock)
1375
1334
        old_inv = old_tree.inventory
1376
1335
        renames = []
1377
1336
        iterator = tree.iter_changes(old_tree, include_unchanged=True)
1415
1374
        master = branch.get_master_branch(
1416
1375
            possible_transports=possible_transports)
1417
1376
        if master is not None:
1418
 
            tree.lock_write()
1419
1377
            branch_location = master.base
 
1378
            tree.lock_write()
1420
1379
        else:
 
1380
            branch_location = tree.branch.base
1421
1381
            tree.lock_tree_write()
1422
 
            branch_location = tree.branch.base
1423
1382
        self.add_cleanup(tree.unlock)
1424
1383
        # get rid of the final '/' and be ready for display
1425
1384
        branch_location = urlutils.unescape_for_display(
1540
1499
 
1541
1500
    def run(self, file_list, verbose=False, new=False,
1542
1501
        file_deletion_strategy='safe'):
1543
 
        tree, file_list = tree_files(file_list)
 
1502
        tree, file_list = WorkingTree.open_containing_paths(file_list)
1544
1503
 
1545
1504
        if file_list is not None:
1546
1505
            file_list = [f for f in file_list]
1547
1506
 
1548
 
        tree.lock_write()
1549
 
        self.add_cleanup(tree.unlock)
 
1507
        self.add_cleanup(tree.lock_write().unlock)
1550
1508
        # Heuristics should probably all move into tree.remove_smart or
1551
1509
        # some such?
1552
1510
        if new:
1926
1884
    takes_args = ['file*']
1927
1885
    takes_options = [
1928
1886
        Option('diff-options', type=str,
1929
 
               help='Pass these options to the external diff program.'),
 
1887
               help='Pass these options to the diff program.'),
1930
1888
        Option('prefix', type=str,
1931
1889
               short_name='p',
1932
1890
               help='Set prefixes added to old and new filenames, as '
1973
1931
                '--prefix expects two values separated by a colon'
1974
1932
                ' (eg "old/:new/")')
1975
1933
 
 
1934
        if using is not None and diff_options is not None:
 
1935
            raise errors.BzrCommandError(
 
1936
            '--diff-options and --using are mutually exclusive.')
 
1937
 
1976
1938
        if revision and len(revision) > 2:
1977
1939
            raise errors.BzrCommandError('bzr diff --revision takes exactly'
1978
1940
                                         ' one or two revision specifiers')
1985
1947
         old_branch, new_branch,
1986
1948
         specific_files, extra_trees) = get_trees_and_branches_to_diff_locked(
1987
1949
            file_list, revision, old, new, self.add_cleanup, apply_view=True)
 
1950
        # GNU diff on Windows uses ANSI encoding for filenames
 
1951
        path_encoding = osutils.get_diff_header_encoding()
1988
1952
        return show_diff_trees(old_tree, new_tree, sys.stdout,
1989
1953
                               specific_files=specific_files,
1990
1954
                               external_diff_options=diff_options,
1991
1955
                               old_label=old_label, new_label=new_label,
1992
 
                               extra_trees=extra_trees, using=using,
 
1956
                               extra_trees=extra_trees,
 
1957
                               path_encoding=path_encoding,
 
1958
                               using=using,
1993
1959
                               format_cls=format)
1994
1960
 
1995
1961
 
2003
1969
    # level of effort but possibly much less IO.  (Or possibly not,
2004
1970
    # if the directories are very large...)
2005
1971
    _see_also = ['status', 'ls']
2006
 
    takes_options = ['show-ids']
 
1972
    takes_options = ['directory', 'show-ids']
2007
1973
 
2008
1974
    @display_command
2009
 
    def run(self, show_ids=False):
2010
 
        tree = WorkingTree.open_containing(u'.')[0]
2011
 
        tree.lock_read()
2012
 
        self.add_cleanup(tree.unlock)
 
1975
    def run(self, show_ids=False, directory=u'.'):
 
1976
        tree = WorkingTree.open_containing(directory)[0]
 
1977
        self.add_cleanup(tree.lock_read().unlock)
2013
1978
        old = tree.basis_tree()
2014
 
        old.lock_read()
2015
 
        self.add_cleanup(old.unlock)
 
1979
        self.add_cleanup(old.lock_read().unlock)
2016
1980
        for path, ie in old.inventory.iter_entries():
2017
1981
            if not tree.has_id(ie.file_id):
2018
1982
                self.outf.write(path)
2028
1992
 
2029
1993
    hidden = True
2030
1994
    _see_also = ['status', 'ls']
2031
 
    takes_options = [
2032
 
            Option('null',
2033
 
                   help='Write an ascii NUL (\\0) separator '
2034
 
                   'between files rather than a newline.')
2035
 
            ]
 
1995
    takes_options = ['directory', 'null']
2036
1996
 
2037
1997
    @display_command
2038
 
    def run(self, null=False):
2039
 
        tree = WorkingTree.open_containing(u'.')[0]
 
1998
    def run(self, null=False, directory=u'.'):
 
1999
        tree = WorkingTree.open_containing(directory)[0]
2040
2000
        td = tree.changes_from(tree.basis_tree())
2041
2001
        for path, id, kind, text_modified, meta_modified in td.modified:
2042
2002
            if null:
2051
2011
 
2052
2012
    hidden = True
2053
2013
    _see_also = ['status', 'ls']
2054
 
    takes_options = [
2055
 
            Option('null',
2056
 
                   help='Write an ascii NUL (\\0) separator '
2057
 
                   'between files rather than a newline.')
2058
 
            ]
 
2014
    takes_options = ['directory', 'null']
2059
2015
 
2060
2016
    @display_command
2061
 
    def run(self, null=False):
2062
 
        wt = WorkingTree.open_containing(u'.')[0]
2063
 
        wt.lock_read()
2064
 
        self.add_cleanup(wt.unlock)
 
2017
    def run(self, null=False, directory=u'.'):
 
2018
        wt = WorkingTree.open_containing(directory)[0]
 
2019
        self.add_cleanup(wt.lock_read().unlock)
2065
2020
        basis = wt.basis_tree()
2066
 
        basis.lock_read()
2067
 
        self.add_cleanup(basis.unlock)
 
2021
        self.add_cleanup(basis.lock_read().unlock)
2068
2022
        basis_inv = basis.inventory
2069
2023
        inv = wt.inventory
2070
2024
        for file_id in inv:
2073
2027
            if inv.is_root(file_id) and len(basis_inv) == 0:
2074
2028
                continue
2075
2029
            path = inv.id2path(file_id)
2076
 
            if not os.access(osutils.abspath(path), os.F_OK):
 
2030
            if not os.access(osutils.pathjoin(wt.basedir, path), os.F_OK):
2077
2031
                continue
2078
2032
            if null:
2079
2033
                self.outf.write(path + '\0')
2279
2233
                   help='Show just the specified revision.'
2280
2234
                   ' See also "help revisionspec".'),
2281
2235
            'log-format',
 
2236
            RegistryOption('authors',
 
2237
                'What names to list as authors - first, all or committer.',
 
2238
                title='Authors',
 
2239
                lazy_registry=('bzrlib.log', 'author_list_registry'),
 
2240
            ),
2282
2241
            Option('levels',
2283
2242
                   short_name='n',
2284
2243
                   help='Number of levels to display - 0 for all, 1 for flat.',
2319
2278
            limit=None,
2320
2279
            show_diff=False,
2321
2280
            include_merges=False,
 
2281
            authors=None,
2322
2282
            exclude_common_ancestry=False,
2323
2283
            ):
2324
2284
        from bzrlib.log import (
2352
2312
        if file_list:
2353
2313
            # find the file ids to log and check for directory filtering
2354
2314
            b, file_info_list, rev1, rev2 = _get_info_for_log_files(
2355
 
                revision, file_list)
2356
 
            self.add_cleanup(b.unlock)
 
2315
                revision, file_list, self.add_cleanup)
2357
2316
            for relpath, file_id, kind in file_info_list:
2358
2317
                if file_id is None:
2359
2318
                    raise errors.BzrCommandError(
2377
2336
                location = '.'
2378
2337
            dir, relpath = bzrdir.BzrDir.open_containing(location)
2379
2338
            b = dir.open_branch()
2380
 
            b.lock_read()
2381
 
            self.add_cleanup(b.unlock)
 
2339
            self.add_cleanup(b.lock_read().unlock)
2382
2340
            rev1, rev2 = _get_revision_range(revision, b, self.name())
2383
2341
 
2384
2342
        # Decide on the type of delta & diff filtering to use
2404
2362
                        show_timezone=timezone,
2405
2363
                        delta_format=get_verbosity_level(),
2406
2364
                        levels=levels,
2407
 
                        show_advice=levels is None)
 
2365
                        show_advice=levels is None,
 
2366
                        author_list_handler=authors)
2408
2367
 
2409
2368
        # Choose the algorithm for doing the logging. It's annoying
2410
2369
        # having multiple code paths like this but necessary until
2508
2467
        tree, relpath = WorkingTree.open_containing(filename)
2509
2468
        file_id = tree.path2id(relpath)
2510
2469
        b = tree.branch
2511
 
        b.lock_read()
2512
 
        self.add_cleanup(b.unlock)
 
2470
        self.add_cleanup(b.lock_read().unlock)
2513
2471
        touching_revs = log.find_touching_revisions(b, file_id)
2514
2472
        for revno, revision_id, what in touching_revs:
2515
2473
            self.outf.write("%6d %s\n" % (revno, what))
2528
2486
                   help='Recurse into subdirectories.'),
2529
2487
            Option('from-root',
2530
2488
                   help='Print paths relative to the root of the branch.'),
2531
 
            Option('unknown', help='Print unknown files.'),
 
2489
            Option('unknown', short_name='u',
 
2490
                help='Print unknown files.'),
2532
2491
            Option('versioned', help='Print versioned files.',
2533
2492
                   short_name='V'),
2534
 
            Option('ignored', help='Print ignored files.'),
2535
 
            Option('null',
2536
 
                   help='Write an ascii NUL (\\0) separator '
2537
 
                   'between files rather than a newline.'),
2538
 
            Option('kind',
 
2493
            Option('ignored', short_name='i',
 
2494
                help='Print ignored files.'),
 
2495
            Option('kind', short_name='k',
2539
2496
                   help='List entries of a particular kind: file, directory, symlink.',
2540
2497
                   type=unicode),
 
2498
            'null',
2541
2499
            'show-ids',
 
2500
            'directory',
2542
2501
            ]
2543
2502
    @display_command
2544
2503
    def run(self, revision=None, verbose=False,
2545
2504
            recursive=False, from_root=False,
2546
2505
            unknown=False, versioned=False, ignored=False,
2547
 
            null=False, kind=None, show_ids=False, path=None):
 
2506
            null=False, kind=None, show_ids=False, path=None, directory=None):
2548
2507
 
2549
2508
        if kind and kind not in ('file', 'directory', 'symlink'):
2550
2509
            raise errors.BzrCommandError('invalid kind specified')
2562
2521
                raise errors.BzrCommandError('cannot specify both --from-root'
2563
2522
                                             ' and PATH')
2564
2523
            fs_path = path
2565
 
        tree, branch, relpath = bzrdir.BzrDir.open_containing_tree_or_branch(
2566
 
            fs_path)
 
2524
        tree, branch, relpath = \
 
2525
            _open_directory_or_containing_tree_or_branch(fs_path, directory)
2567
2526
 
2568
2527
        # Calculate the prefix to use
2569
2528
        prefix = None
2584
2543
                view_str = views.view_display_str(view_files)
2585
2544
                note("Ignoring files outside view. View is %s" % view_str)
2586
2545
 
2587
 
        tree.lock_read()
2588
 
        self.add_cleanup(tree.unlock)
 
2546
        self.add_cleanup(tree.lock_read().unlock)
2589
2547
        for fp, fc, fkind, fid, entry in tree.list_files(include_root=False,
2590
2548
            from_dir=relpath, recursive=recursive):
2591
2549
            # Apply additional masking
2638
2596
 
2639
2597
    hidden = True
2640
2598
    _see_also = ['ls']
 
2599
    takes_options = ['directory']
2641
2600
 
2642
2601
    @display_command
2643
 
    def run(self):
2644
 
        for f in WorkingTree.open_containing(u'.')[0].unknowns():
 
2602
    def run(self, directory=u'.'):
 
2603
        for f in WorkingTree.open_containing(directory)[0].unknowns():
2645
2604
            self.outf.write(osutils.quotefn(f) + '\n')
2646
2605
 
2647
2606
 
2712
2671
 
2713
2672
    _see_also = ['status', 'ignored', 'patterns']
2714
2673
    takes_args = ['name_pattern*']
2715
 
    takes_options = [
 
2674
    takes_options = ['directory',
2716
2675
        Option('default-rules',
2717
2676
               help='Display the default ignore rules that bzr uses.')
2718
2677
        ]
2719
2678
 
2720
 
    def run(self, name_pattern_list=None, default_rules=None):
 
2679
    def run(self, name_pattern_list=None, default_rules=None,
 
2680
            directory=u'.'):
2721
2681
        from bzrlib import ignores
2722
2682
        if default_rules is not None:
2723
2683
            # dump the default rules and exit
2729
2689
                "NAME_PATTERN or --default-rules.")
2730
2690
        name_pattern_list = [globbing.normalize_pattern(p)
2731
2691
                             for p in name_pattern_list]
 
2692
        bad_patterns = ''
 
2693
        for p in name_pattern_list:
 
2694
            if not globbing.Globster.is_pattern_valid(p):
 
2695
                bad_patterns += ('\n  %s' % p)
 
2696
        if bad_patterns:
 
2697
            msg = ('Invalid ignore pattern(s) found. %s' % bad_patterns)
 
2698
            ui.ui_factory.show_error(msg)
 
2699
            raise errors.InvalidPattern('')
2732
2700
        for name_pattern in name_pattern_list:
2733
2701
            if (name_pattern[0] == '/' or
2734
2702
                (len(name_pattern) > 1 and name_pattern[1] == ':')):
2735
2703
                raise errors.BzrCommandError(
2736
2704
                    "NAME_PATTERN should not be an absolute path")
2737
 
        tree, relpath = WorkingTree.open_containing(u'.')
 
2705
        tree, relpath = WorkingTree.open_containing(directory)
2738
2706
        ignores.tree_ignores_add_patterns(tree, name_pattern_list)
2739
2707
        ignored = globbing.Globster(name_pattern_list)
2740
2708
        matches = []
2741
 
        tree.lock_read()
 
2709
        self.add_cleanup(tree.lock_read().unlock)
2742
2710
        for entry in tree.list_files():
2743
2711
            id = entry[3]
2744
2712
            if id is not None:
2745
2713
                filename = entry[0]
2746
2714
                if ignored.match(filename):
2747
2715
                    matches.append(filename)
2748
 
        tree.unlock()
2749
2716
        if len(matches) > 0:
2750
2717
            self.outf.write("Warning: the following files are version controlled and"
2751
2718
                  " match your ignore pattern:\n%s"
2766
2733
 
2767
2734
    encoding_type = 'replace'
2768
2735
    _see_also = ['ignore', 'ls']
 
2736
    takes_options = ['directory']
2769
2737
 
2770
2738
    @display_command
2771
 
    def run(self):
2772
 
        tree = WorkingTree.open_containing(u'.')[0]
2773
 
        tree.lock_read()
2774
 
        self.add_cleanup(tree.unlock)
 
2739
    def run(self, directory=u'.'):
 
2740
        tree = WorkingTree.open_containing(directory)[0]
 
2741
        self.add_cleanup(tree.lock_read().unlock)
2775
2742
        for path, file_class, kind, file_id, entry in tree.list_files():
2776
2743
            if file_class != 'I':
2777
2744
                continue
2788
2755
    """
2789
2756
    hidden = True
2790
2757
    takes_args = ['revno']
 
2758
    takes_options = ['directory']
2791
2759
 
2792
2760
    @display_command
2793
 
    def run(self, revno):
 
2761
    def run(self, revno, directory=u'.'):
2794
2762
        try:
2795
2763
            revno = int(revno)
2796
2764
        except ValueError:
2797
2765
            raise errors.BzrCommandError("not a valid revision-number: %r"
2798
2766
                                         % revno)
2799
 
        revid = WorkingTree.open_containing(u'.')[0].branch.get_rev_id(revno)
 
2767
        revid = WorkingTree.open_containing(directory)[0].branch.get_rev_id(revno)
2800
2768
        self.outf.write("%s\n" % revid)
2801
2769
 
2802
2770
 
2829
2797
      =================       =========================
2830
2798
    """
2831
2799
    takes_args = ['dest', 'branch_or_subdir?']
2832
 
    takes_options = [
 
2800
    takes_options = ['directory',
2833
2801
        Option('format',
2834
2802
               help="Type of file to export to.",
2835
2803
               type=unicode),
2844
2812
                    'revision in which it was changed.'),
2845
2813
        ]
2846
2814
    def run(self, dest, branch_or_subdir=None, revision=None, format=None,
2847
 
        root=None, filters=False, per_file_timestamps=False):
 
2815
        root=None, filters=False, per_file_timestamps=False, directory=u'.'):
2848
2816
        from bzrlib.export import export
2849
2817
 
2850
2818
        if branch_or_subdir is None:
2851
 
            tree = WorkingTree.open_containing(u'.')[0]
 
2819
            tree = WorkingTree.open_containing(directory)[0]
2852
2820
            b = tree.branch
2853
2821
            subdir = None
2854
2822
        else:
2873
2841
    """
2874
2842
 
2875
2843
    _see_also = ['ls']
2876
 
    takes_options = [
 
2844
    takes_options = ['directory',
2877
2845
        Option('name-from-revision', help='The path name in the old tree.'),
2878
2846
        Option('filters', help='Apply content filters to display the '
2879
2847
                'convenience form.'),
2884
2852
 
2885
2853
    @display_command
2886
2854
    def run(self, filename, revision=None, name_from_revision=False,
2887
 
            filters=False):
 
2855
            filters=False, directory=None):
2888
2856
        if revision is not None and len(revision) != 1:
2889
2857
            raise errors.BzrCommandError("bzr cat --revision takes exactly"
2890
2858
                                         " one revision specifier")
2891
2859
        tree, branch, relpath = \
2892
 
            bzrdir.BzrDir.open_containing_tree_or_branch(filename)
2893
 
        branch.lock_read()
2894
 
        self.add_cleanup(branch.unlock)
 
2860
            _open_directory_or_containing_tree_or_branch(filename, directory)
 
2861
        self.add_cleanup(branch.lock_read().unlock)
2895
2862
        return self._run(tree, branch, relpath, filename, revision,
2896
2863
                         name_from_revision, filters)
2897
2864
 
2900
2867
        if tree is None:
2901
2868
            tree = b.basis_tree()
2902
2869
        rev_tree = _get_one_revision_tree('cat', revision, branch=b)
2903
 
        rev_tree.lock_read()
2904
 
        self.add_cleanup(rev_tree.unlock)
 
2870
        self.add_cleanup(rev_tree.lock_read().unlock)
2905
2871
 
2906
2872
        old_file_id = rev_tree.path2id(relpath)
2907
2873
 
3128
3094
 
3129
3095
        properties = {}
3130
3096
 
3131
 
        tree, selected_list = tree_files(selected_list)
 
3097
        tree, selected_list = WorkingTree.open_containing_paths(selected_list)
3132
3098
        if selected_list == ['']:
3133
3099
            # workaround - commit of root of tree should be exactly the same
3134
3100
            # as just default commit in that tree, and succeed even though
3169
3135
        def get_message(commit_obj):
3170
3136
            """Callback to get commit message"""
3171
3137
            if file:
3172
 
                my_message = codecs.open(
3173
 
                    file, 'rt', osutils.get_user_encoding()).read()
 
3138
                f = codecs.open(file, 'rt', osutils.get_user_encoding())
 
3139
                try:
 
3140
                    my_message = f.read()
 
3141
                finally:
 
3142
                    f.close()
3174
3143
            elif message is not None:
3175
3144
                my_message = message
3176
3145
            else:
3205
3174
                        reporter=None, verbose=verbose, revprops=properties,
3206
3175
                        authors=author, timestamp=commit_stamp,
3207
3176
                        timezone=offset,
3208
 
                        exclude=safe_relpath_files(tree, exclude))
 
3177
                        exclude=tree.safe_relpath_files(exclude))
3209
3178
        except PointlessCommit:
3210
3179
            raise errors.BzrCommandError("No changes to commit."
3211
3180
                              " Use --unchanged to commit anyhow.")
3330
3299
 
3331
3300
            bzr whoami "Frank Chu <fchu@example.com>"
3332
3301
    """
3333
 
    takes_options = [ Option('email',
 
3302
    takes_options = [ 'directory',
 
3303
                      Option('email',
3334
3304
                             help='Display email address only.'),
3335
3305
                      Option('branch',
3336
3306
                             help='Set identity for the current branch instead of '
3340
3310
    encoding_type = 'replace'
3341
3311
 
3342
3312
    @display_command
3343
 
    def run(self, email=False, branch=False, name=None):
 
3313
    def run(self, email=False, branch=False, name=None, directory=None):
3344
3314
        if name is None:
3345
 
            # use branch if we're inside one; otherwise global config
3346
 
            try:
3347
 
                c = Branch.open_containing('.')[0].get_config()
3348
 
            except errors.NotBranchError:
3349
 
                c = config.GlobalConfig()
 
3315
            if directory is None:
 
3316
                # use branch if we're inside one; otherwise global config
 
3317
                try:
 
3318
                    c = Branch.open_containing(u'.')[0].get_config()
 
3319
                except errors.NotBranchError:
 
3320
                    c = config.GlobalConfig()
 
3321
            else:
 
3322
                c = Branch.open(directory).get_config()
3350
3323
            if email:
3351
3324
                self.outf.write(c.user_email() + '\n')
3352
3325
            else:
3362
3335
 
3363
3336
        # use global config unless --branch given
3364
3337
        if branch:
3365
 
            c = Branch.open_containing('.')[0].get_config()
 
3338
            if directory is None:
 
3339
                c = Branch.open_containing(u'.')[0].get_config()
 
3340
            else:
 
3341
                c = Branch.open(directory).get_config()
3366
3342
        else:
3367
3343
            c = config.GlobalConfig()
3368
3344
        c.set_user_option('email', name)
3380
3356
 
3381
3357
    _see_also = ['info']
3382
3358
    takes_args = ['nickname?']
3383
 
    def run(self, nickname=None):
3384
 
        branch = Branch.open_containing(u'.')[0]
 
3359
    takes_options = ['directory']
 
3360
    def run(self, nickname=None, directory=u'.'):
 
3361
        branch = Branch.open_containing(directory)[0]
3385
3362
        if nickname is None:
3386
3363
            self.printme(branch)
3387
3364
        else:
3537
3514
                                 'throughout the test suite.',
3538
3515
                            type=get_transport_type),
3539
3516
                     Option('benchmark',
3540
 
                            help='Run the benchmarks rather than selftests.'),
 
3517
                            help='Run the benchmarks rather than selftests.',
 
3518
                            hidden=True),
3541
3519
                     Option('lsprof-timed',
3542
3520
                            help='Generate lsprof output for benchmarked'
3543
3521
                                 ' sections of code.'),
3544
3522
                     Option('lsprof-tests',
3545
3523
                            help='Generate lsprof output for each test.'),
3546
 
                     Option('cache-dir', type=str,
3547
 
                            help='Cache intermediate benchmark output in this '
3548
 
                                 'directory.'),
3549
3524
                     Option('first',
3550
3525
                            help='Run all tests, but run specified tests first.',
3551
3526
                            short_name='f',
3585
3560
 
3586
3561
    def run(self, testspecs_list=None, verbose=False, one=False,
3587
3562
            transport=None, benchmark=None,
3588
 
            lsprof_timed=None, cache_dir=None,
 
3563
            lsprof_timed=None,
3589
3564
            first=False, list_only=False,
3590
3565
            randomize=None, exclude=None, strict=False,
3591
3566
            load_list=None, debugflag=None, starting_with=None, subunit=False,
3592
3567
            parallel=None, lsprof_tests=False):
3593
3568
        from bzrlib.tests import selftest
3594
 
        import bzrlib.benchmarks as benchmarks
3595
 
        from bzrlib.benchmarks import tree_creator
3596
3569
 
3597
3570
        # Make deprecation warnings visible, unless -Werror is set
3598
3571
        symbol_versioning.activate_deprecation_warnings(override=False)
3599
3572
 
3600
 
        if cache_dir is not None:
3601
 
            tree_creator.TreeCreator.CACHE_ROOT = osutils.abspath(cache_dir)
3602
3573
        if testspecs_list is not None:
3603
3574
            pattern = '|'.join(testspecs_list)
3604
3575
        else:
3612
3583
            self.additional_selftest_args['runner_class'] = SubUnitBzrRunner
3613
3584
            # On Windows, disable automatic conversion of '\n' to '\r\n' in
3614
3585
            # stdout, which would corrupt the subunit stream. 
3615
 
            if sys.platform == "win32" and sys.stdout.fileno() >= 0:
 
3586
            # FIXME: This has been fixed in subunit trunk (>0.0.5) so the
 
3587
            # following code can be deleted when it's sufficiently deployed
 
3588
            # -- vila/mgz 20100514
 
3589
            if (sys.platform == "win32"
 
3590
                and getattr(sys.stdout, 'fileno', None) is not None):
3616
3591
                import msvcrt
3617
3592
                msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
3618
3593
        if parallel:
3619
3594
            self.additional_selftest_args.setdefault(
3620
3595
                'suite_decorators', []).append(parallel)
3621
3596
        if benchmark:
3622
 
            test_suite_factory = benchmarks.test_suite
3623
 
            # Unless user explicitly asks for quiet, be verbose in benchmarks
3624
 
            verbose = not is_quiet()
3625
 
            # TODO: should possibly lock the history file...
3626
 
            benchfile = open(".perf_history", "at", buffering=1)
3627
 
            self.add_cleanup(benchfile.close)
3628
 
        else:
3629
 
            test_suite_factory = None
3630
 
            benchfile = None
 
3597
            raise errors.BzrCommandError(
 
3598
                "--benchmark is no longer supported from bzr 2.2; "
 
3599
                "use bzr-usertest instead")
 
3600
        test_suite_factory = None
3631
3601
        selftest_kwargs = {"verbose": verbose,
3632
3602
                          "pattern": pattern,
3633
3603
                          "stop_on_failure": one,
3635
3605
                          "test_suite_factory": test_suite_factory,
3636
3606
                          "lsprof_timed": lsprof_timed,
3637
3607
                          "lsprof_tests": lsprof_tests,
3638
 
                          "bench_history": benchfile,
3639
3608
                          "matching_tests_first": first,
3640
3609
                          "list_only": list_only,
3641
3610
                          "random_seed": randomize,
3690
3659
 
3691
3660
        branch1 = Branch.open_containing(branch)[0]
3692
3661
        branch2 = Branch.open_containing(other)[0]
3693
 
        branch1.lock_read()
3694
 
        self.add_cleanup(branch1.unlock)
3695
 
        branch2.lock_read()
3696
 
        self.add_cleanup(branch2.unlock)
 
3662
        self.add_cleanup(branch1.lock_read().unlock)
 
3663
        self.add_cleanup(branch2.lock_read().unlock)
3697
3664
        last1 = ensure_null(branch1.last_revision())
3698
3665
        last2 = ensure_null(branch2.last_revision())
3699
3666
 
3793
3760
                ' completely merged into the source, pull from the'
3794
3761
                ' source rather than merging.  When this happens,'
3795
3762
                ' you do not need to commit the result.'),
3796
 
        Option('directory',
 
3763
        custom_help('directory',
3797
3764
               help='Branch to merge into, '
3798
 
                    'rather than the one containing the working directory.',
3799
 
               short_name='d',
3800
 
               type=unicode,
3801
 
               ),
 
3765
                    'rather than the one containing the working directory.'),
3802
3766
        Option('preview', help='Instead of merging, show a diff of the'
3803
3767
               ' merge.'),
3804
3768
        Option('interactive', help='Select changes interactively.',
3837
3801
            unversioned_filter=tree.is_ignored, view_info=view_info)
3838
3802
        pb = ui.ui_factory.nested_progress_bar()
3839
3803
        self.add_cleanup(pb.finished)
3840
 
        tree.lock_write()
3841
 
        self.add_cleanup(tree.unlock)
 
3804
        self.add_cleanup(tree.lock_write().unlock)
3842
3805
        if location is not None:
3843
3806
            try:
3844
3807
                mergeable = bundle.read_mergeable_from_url(location,
3905
3868
    def _do_preview(self, merger):
3906
3869
        from bzrlib.diff import show_diff_trees
3907
3870
        result_tree = self._get_preview(merger)
 
3871
        path_encoding = osutils.get_diff_header_encoding()
3908
3872
        show_diff_trees(merger.this_tree, result_tree, self.outf,
3909
 
                        old_label='', new_label='')
 
3873
                        old_label='', new_label='',
 
3874
                        path_encoding=path_encoding)
3910
3875
 
3911
3876
    def _do_merge(self, merger, change_reporter, allow_pending, verified):
3912
3877
        merger.change_reporter = change_reporter
4099
4064
        from bzrlib.conflicts import restore
4100
4065
        if merge_type is None:
4101
4066
            merge_type = _mod_merge.Merge3Merger
4102
 
        tree, file_list = tree_files(file_list)
4103
 
        tree.lock_write()
4104
 
        self.add_cleanup(tree.unlock)
 
4067
        tree, file_list = WorkingTree.open_containing_paths(file_list)
 
4068
        self.add_cleanup(tree.lock_write().unlock)
4105
4069
        parents = tree.get_parent_ids()
4106
4070
        if len(parents) != 2:
4107
4071
            raise errors.BzrCommandError("Sorry, remerge only works after normal"
4216
4180
 
4217
4181
    def run(self, revision=None, no_backup=False, file_list=None,
4218
4182
            forget_merges=None):
4219
 
        tree, file_list = tree_files(file_list)
4220
 
        tree.lock_tree_write()
4221
 
        self.add_cleanup(tree.unlock)
 
4183
        tree, file_list = WorkingTree.open_containing_paths(file_list)
 
4184
        self.add_cleanup(tree.lock_tree_write().unlock)
4222
4185
        if forget_merges:
4223
4186
            tree.set_parent_ids(tree.get_parent_ids()[:1])
4224
4187
        else:
4313
4276
    _see_also = ['merge', 'pull']
4314
4277
    takes_args = ['other_branch?']
4315
4278
    takes_options = [
 
4279
        'directory',
4316
4280
        Option('reverse', 'Reverse the order of revisions.'),
4317
4281
        Option('mine-only',
4318
4282
               'Display changes in the local branch only.'),
4340
4304
            theirs_only=False,
4341
4305
            log_format=None, long=False, short=False, line=False,
4342
4306
            show_ids=False, verbose=False, this=False, other=False,
4343
 
            include_merges=False, revision=None, my_revision=None):
 
4307
            include_merges=False, revision=None, my_revision=None,
 
4308
            directory=u'.'):
4344
4309
        from bzrlib.missing import find_unmerged, iter_log_revisions
4345
4310
        def message(s):
4346
4311
            if not is_quiet():
4359
4324
        elif theirs_only:
4360
4325
            restrict = 'remote'
4361
4326
 
4362
 
        local_branch = Branch.open_containing(u".")[0]
4363
 
        local_branch.lock_read()
4364
 
        self.add_cleanup(local_branch.unlock)
 
4327
        local_branch = Branch.open_containing(directory)[0]
 
4328
        self.add_cleanup(local_branch.lock_read().unlock)
4365
4329
 
4366
4330
        parent = local_branch.get_parent()
4367
4331
        if other_branch is None:
4378
4342
        if remote_branch.base == local_branch.base:
4379
4343
            remote_branch = local_branch
4380
4344
        else:
4381
 
            remote_branch.lock_read()
4382
 
            self.add_cleanup(remote_branch.unlock)
 
4345
            self.add_cleanup(remote_branch.lock_read().unlock)
4383
4346
 
4384
4347
        local_revid_range = _revision_range_to_revid_range(
4385
4348
            _get_revision_range(my_revision, local_branch,
4440
4403
            message("Branches are up to date.\n")
4441
4404
        self.cleanup_now()
4442
4405
        if not status_code and parent is None and other_branch is not None:
4443
 
            local_branch.lock_write()
4444
 
            self.add_cleanup(local_branch.unlock)
 
4406
            self.add_cleanup(local_branch.lock_write().unlock)
4445
4407
            # handle race conditions - a parent might be set while we run.
4446
4408
            if local_branch.get_parent() is None:
4447
4409
                local_branch.set_parent(remote_branch.base)
4547
4509
            b = Branch.open_containing(branch)[0]
4548
4510
        else:
4549
4511
            b = Branch.open(branch)
4550
 
        b.lock_read()
4551
 
        self.add_cleanup(b.unlock)
 
4512
        self.add_cleanup(b.lock_read().unlock)
4552
4513
        if revision is None:
4553
4514
            rev_id = b.last_revision()
4554
4515
        else:
4578
4539
                     Option('long', help='Show commit date in annotations.'),
4579
4540
                     'revision',
4580
4541
                     'show-ids',
 
4542
                     'directory',
4581
4543
                     ]
4582
4544
    encoding_type = 'exact'
4583
4545
 
4584
4546
    @display_command
4585
4547
    def run(self, filename, all=False, long=False, revision=None,
4586
 
            show_ids=False):
 
4548
            show_ids=False, directory=None):
4587
4549
        from bzrlib.annotate import annotate_file, annotate_file_tree
4588
4550
        wt, branch, relpath = \
4589
 
            bzrdir.BzrDir.open_containing_tree_or_branch(filename)
 
4551
            _open_directory_or_containing_tree_or_branch(filename, directory)
4590
4552
        if wt is not None:
4591
 
            wt.lock_read()
4592
 
            self.add_cleanup(wt.unlock)
 
4553
            self.add_cleanup(wt.lock_read().unlock)
4593
4554
        else:
4594
 
            branch.lock_read()
4595
 
            self.add_cleanup(branch.unlock)
 
4555
            self.add_cleanup(branch.lock_read().unlock)
4596
4556
        tree = _get_one_revision_tree('annotate', revision, branch=branch)
4597
 
        tree.lock_read()
4598
 
        self.add_cleanup(tree.unlock)
 
4557
        self.add_cleanup(tree.lock_read().unlock)
4599
4558
        if wt is not None:
4600
4559
            file_id = wt.path2id(relpath)
4601
4560
        else:
4619
4578
 
4620
4579
    hidden = True # is this right ?
4621
4580
    takes_args = ['revision_id*']
4622
 
    takes_options = ['revision']
 
4581
    takes_options = ['directory', 'revision']
4623
4582
 
4624
 
    def run(self, revision_id_list=None, revision=None):
 
4583
    def run(self, revision_id_list=None, revision=None, directory=u'.'):
4625
4584
        if revision_id_list is not None and revision is not None:
4626
4585
            raise errors.BzrCommandError('You can only supply one of revision_id or --revision')
4627
4586
        if revision_id_list is None and revision is None:
4628
4587
            raise errors.BzrCommandError('You must supply either --revision or a revision_id')
4629
 
        b = WorkingTree.open_containing(u'.')[0].branch
4630
 
        b.lock_write()
4631
 
        self.add_cleanup(b.unlock)
 
4588
        b = WorkingTree.open_containing(directory)[0].branch
 
4589
        self.add_cleanup(b.lock_write().unlock)
4632
4590
        return self._run(b, revision_id_list, revision)
4633
4591
 
4634
4592
    def _run(self, b, revision_id_list, revision):
4693
4651
 
4694
4652
    _see_also = ['checkouts', 'unbind']
4695
4653
    takes_args = ['location?']
4696
 
    takes_options = []
 
4654
    takes_options = ['directory']
4697
4655
 
4698
 
    def run(self, location=None):
4699
 
        b, relpath = Branch.open_containing(u'.')
 
4656
    def run(self, location=None, directory=u'.'):
 
4657
        b, relpath = Branch.open_containing(directory)
4700
4658
        if location is None:
4701
4659
            try:
4702
4660
                location = b.get_old_bound_location()
4729
4687
 
4730
4688
    _see_also = ['checkouts', 'bind']
4731
4689
    takes_args = []
4732
 
    takes_options = []
 
4690
    takes_options = ['directory']
4733
4691
 
4734
 
    def run(self):
4735
 
        b, relpath = Branch.open_containing(u'.')
 
4692
    def run(self, directory=u'.'):
 
4693
        b, relpath = Branch.open_containing(directory)
4736
4694
        if not b.unbind():
4737
4695
            raise errors.BzrCommandError('Local branch is not bound')
4738
4696
 
4784
4742
            b = control.open_branch()
4785
4743
 
4786
4744
        if tree is not None:
4787
 
            tree.lock_write()
4788
 
            self.add_cleanup(tree.unlock)
 
4745
            self.add_cleanup(tree.lock_write().unlock)
4789
4746
        else:
4790
 
            b.lock_write()
4791
 
            self.add_cleanup(b.unlock)
 
4747
            self.add_cleanup(b.lock_write().unlock)
4792
4748
        return self._run(b, tree, dry_run, verbose, revision, force, local=local)
4793
4749
 
4794
4750
    def _run(self, b, tree, dry_run, verbose, revision, force, local=False):
4902
4858
                    'result in a dynamically allocated port.  The default port '
4903
4859
                    'depends on the protocol.',
4904
4860
               type=str),
4905
 
        Option('directory',
4906
 
               help='Serve contents of this directory.',
4907
 
               type=unicode),
 
4861
        custom_help('directory',
 
4862
               help='Serve contents of this directory.'),
4908
4863
        Option('allow-writes',
4909
4864
               help='By default the server is a readonly server.  Supplying '
4910
4865
                    '--allow-writes enables write access to the contents of '
4937
4892
 
4938
4893
    def run(self, port=None, inet=False, directory=None, allow_writes=False,
4939
4894
            protocol=None):
4940
 
        from bzrlib.transport import get_transport, transport_server_registry
 
4895
        from bzrlib import transport
4941
4896
        if directory is None:
4942
4897
            directory = os.getcwd()
4943
4898
        if protocol is None:
4944
 
            protocol = transport_server_registry.get()
 
4899
            protocol = transport.transport_server_registry.get()
4945
4900
        host, port = self.get_host_and_port(port)
4946
4901
        url = urlutils.local_path_to_url(directory)
4947
4902
        if not allow_writes:
4948
4903
            url = 'readonly+' + url
4949
 
        transport = get_transport(url)
4950
 
        protocol(transport, host, port, inet)
 
4904
        t = transport.get_transport(url)
 
4905
        protocol(t, host, port, inet)
4951
4906
 
4952
4907
 
4953
4908
class cmd_join(Command):
5046
5001
    _see_also = ['send']
5047
5002
 
5048
5003
    takes_options = [
 
5004
        'directory',
5049
5005
        RegistryOption.from_kwargs('patch-type',
5050
5006
            'The type of patch to include in the directive.',
5051
5007
            title='Patch type',
5064
5020
    encoding_type = 'exact'
5065
5021
 
5066
5022
    def run(self, submit_branch=None, public_branch=None, patch_type='bundle',
5067
 
            sign=False, revision=None, mail_to=None, message=None):
 
5023
            sign=False, revision=None, mail_to=None, message=None,
 
5024
            directory=u'.'):
5068
5025
        from bzrlib.revision import ensure_null, NULL_REVISION
5069
5026
        include_patch, include_bundle = {
5070
5027
            'plain': (False, False),
5071
5028
            'diff': (True, False),
5072
5029
            'bundle': (True, True),
5073
5030
            }[patch_type]
5074
 
        branch = Branch.open('.')
 
5031
        branch = Branch.open(directory)
5075
5032
        stored_submit_branch = branch.get_submit_branch()
5076
5033
        if submit_branch is None:
5077
5034
            submit_branch = stored_submit_branch
5162
5119
    given, in which case it is sent to a file.
5163
5120
 
5164
5121
    Mail is sent using your preferred mail program.  This should be transparent
5165
 
    on Windows (it uses MAPI).  On Linux, it requires the xdg-email utility.
 
5122
    on Windows (it uses MAPI).  On Unix, it requires the xdg-email utility.
5166
5123
    If the preferred client can't be found (or used), your editor will be used.
5167
5124
 
5168
5125
    To use a specific mail program, set the mail_client configuration option.
5339
5296
        Option('delete',
5340
5297
            help='Delete this tag rather than placing it.',
5341
5298
            ),
5342
 
        Option('directory',
5343
 
            help='Branch in which to place the tag.',
5344
 
            short_name='d',
5345
 
            type=unicode,
5346
 
            ),
 
5299
        custom_help('directory',
 
5300
            help='Branch in which to place the tag.'),
5347
5301
        Option('force',
5348
5302
            help='Replace existing tags.',
5349
5303
            ),
5357
5311
            revision=None,
5358
5312
            ):
5359
5313
        branch, relpath = Branch.open_containing(directory)
5360
 
        branch.lock_write()
5361
 
        self.add_cleanup(branch.unlock)
 
5314
        self.add_cleanup(branch.lock_write().unlock)
5362
5315
        if delete:
5363
5316
            if tag_name is None:
5364
5317
                raise errors.BzrCommandError("No tag specified to delete.")
5392
5345
 
5393
5346
    _see_also = ['tag']
5394
5347
    takes_options = [
5395
 
        Option('directory',
5396
 
            help='Branch whose tags should be displayed.',
5397
 
            short_name='d',
5398
 
            type=unicode,
5399
 
            ),
 
5348
        custom_help('directory',
 
5349
            help='Branch whose tags should be displayed.'),
5400
5350
        RegistryOption.from_kwargs('sort',
5401
5351
            'Sort tags by different criteria.', title='Sorting',
5402
5352
            alpha='Sort tags lexicographically (default).',
5419
5369
        if not tags:
5420
5370
            return
5421
5371
 
5422
 
        branch.lock_read()
5423
 
        self.add_cleanup(branch.unlock)
 
5372
        self.add_cleanup(branch.lock_read().unlock)
5424
5373
        if revision:
5425
5374
            graph = branch.repository.get_graph()
5426
5375
            rev1, rev2 = _get_revision_range(revision, branch, self.name())
5573
5522
    """
5574
5523
 
5575
5524
    takes_args = ['to_location?']
5576
 
    takes_options = [Option('force',
 
5525
    takes_options = ['directory',
 
5526
                     Option('force',
5577
5527
                        help='Switch even if local commits will be lost.'),
5578
5528
                     'revision',
5579
5529
                     Option('create-branch', short_name='b',
5582
5532
                    ]
5583
5533
 
5584
5534
    def run(self, to_location=None, force=False, create_branch=False,
5585
 
            revision=None):
 
5535
            revision=None, directory=u'.'):
5586
5536
        from bzrlib import switch
5587
 
        tree_location = '.'
 
5537
        tree_location = directory
5588
5538
        revision = _get_one_revision('switch', revision)
5589
5539
        control_dir = bzrdir.BzrDir.open_containing(tree_location)[0]
5590
5540
        if to_location is None:
5591
5541
            if revision is None:
5592
5542
                raise errors.BzrCommandError('You must supply either a'
5593
5543
                                             ' revision or a location')
5594
 
            to_location = '.'
 
5544
            to_location = tree_location
5595
5545
        try:
5596
5546
            branch = control_dir.open_branch()
5597
5547
            had_explicit_nick = branch.get_config().has_explicit_nickname()
5732
5682
            name=None,
5733
5683
            switch=None,
5734
5684
            ):
5735
 
        tree, file_list = tree_files(file_list, apply_view=False)
 
5685
        tree, file_list = WorkingTree.open_containing_paths(file_list,
 
5686
            apply_view=False)
5736
5687
        current_view, view_dict = tree.views.get_view_info()
5737
5688
        if name is None:
5738
5689
            name = current_view
5872
5823
    takes_args = ['file*']
5873
5824
 
5874
5825
    takes_options = [
 
5826
        'directory',
5875
5827
        'revision',
5876
5828
        Option('all', help='Shelve all changes.'),
5877
5829
        'message',
5886
5838
    _see_also = ['unshelve']
5887
5839
 
5888
5840
    def run(self, revision=None, all=False, file_list=None, message=None,
5889
 
            writer=None, list=False, destroy=False):
 
5841
            writer=None, list=False, destroy=False, directory=u'.'):
5890
5842
        if list:
5891
5843
            return self.run_for_list()
5892
5844
        from bzrlib.shelf_ui import Shelver
5894
5846
            writer = bzrlib.option.diff_writer_registry.get()
5895
5847
        try:
5896
5848
            shelver = Shelver.from_args(writer(sys.stdout), revision, all,
5897
 
                file_list, message, destroy=destroy)
 
5849
                file_list, message, destroy=destroy, directory=directory)
5898
5850
            try:
5899
5851
                shelver.run()
5900
5852
            finally:
5904
5856
 
5905
5857
    def run_for_list(self):
5906
5858
        tree = WorkingTree.open_containing('.')[0]
5907
 
        tree.lock_read()
5908
 
        self.add_cleanup(tree.unlock)
 
5859
        self.add_cleanup(tree.lock_read().unlock)
5909
5860
        manager = tree.get_shelf_manager()
5910
5861
        shelves = manager.active_shelves()
5911
5862
        if len(shelves) == 0:
5929
5880
 
5930
5881
    takes_args = ['shelf_id?']
5931
5882
    takes_options = [
 
5883
        'directory',
5932
5884
        RegistryOption.from_kwargs(
5933
5885
            'action', help="The action to perform.",
5934
5886
            enum_switch=False, value_switches=True,
5942
5894
    ]
5943
5895
    _see_also = ['shelve']
5944
5896
 
5945
 
    def run(self, shelf_id=None, action='apply'):
 
5897
    def run(self, shelf_id=None, action='apply', directory=u'.'):
5946
5898
        from bzrlib.shelf_ui import Unshelver
5947
 
        unshelver = Unshelver.from_args(shelf_id, action)
 
5899
        unshelver = Unshelver.from_args(shelf_id, action, directory=directory)
5948
5900
        try:
5949
5901
            unshelver.run()
5950
5902
        finally:
5966
5918
 
5967
5919
    To check what clean-tree will do, use --dry-run.
5968
5920
    """
5969
 
    takes_options = [Option('ignored', help='Delete all ignored files.'),
 
5921
    takes_options = ['directory',
 
5922
                     Option('ignored', help='Delete all ignored files.'),
5970
5923
                     Option('detritus', help='Delete conflict files, merge'
5971
5924
                            ' backups, and failed selftest dirs.'),
5972
5925
                     Option('unknown',
5975
5928
                            ' deleting them.'),
5976
5929
                     Option('force', help='Do not prompt before deleting.')]
5977
5930
    def run(self, unknown=False, ignored=False, detritus=False, dry_run=False,
5978
 
            force=False):
 
5931
            force=False, directory=u'.'):
5979
5932
        from bzrlib.clean_tree import clean_tree
5980
5933
        if not (unknown or ignored or detritus):
5981
5934
            unknown = True
5982
5935
        if dry_run:
5983
5936
            force = True
5984
 
        clean_tree('.', unknown=unknown, ignored=ignored, detritus=detritus,
5985
 
                   dry_run=dry_run, no_prompt=force)
 
5937
        clean_tree(directory, unknown=unknown, ignored=ignored,
 
5938
                   detritus=detritus, dry_run=dry_run, no_prompt=force)
5986
5939
 
5987
5940
 
5988
5941
class cmd_reference(Command):