/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test__simple_set.py

  • Committer: John Arbash Meinel
  • Date: 2010-08-10 20:03:44 UTC
  • mto: This revision was merged to the branch mainline in revision 5376.
  • Revision ID: john@arbash-meinel.com-20100810200344-6muerwvkafqu7w47
Rework things a bit so the logic can be shared.

It turns out that some of the peak memory is actually during the inventory
to string to bundle translations. So re-use the refcount logic there.
This actually does show a decrease in peak memory.
Specifically 'cd bzr.dev; bzr send ../2.2' drops from 221MB peak to 156MB.

We don't speed anything up (16.5s both ways), but peak memory is quite
a bit better.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test__simple_set.py
379
379
        # And even removing an item still causes it to fail
380
380
        obj.discard(k2)
381
381
        self.assertRaises(RuntimeError, iterator.next)
 
382
 
 
383
    def test__sizeof__(self):
 
384
        # SimpleSet needs a custom sizeof implementation, because it allocates
 
385
        # memory that Python cannot directly see (_table).
 
386
        # Too much variability in platform sizes for us to give a fixed size
 
387
        # here. However without a custom implementation, __sizeof__ would give
 
388
        # us only the size of the object, and not its table. We know the table
 
389
        # is at least 4bytes*1024entries in size.
 
390
        obj = self.module.SimpleSet()
 
391
        self.assertTrue(obj.__sizeof__() > 4096)