/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_http.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2011-02-09 10:44:18 UTC
  • mfrom: (5652.1.3 thread-with-exception)
  • Revision ID: pqm@pqm.ubuntu.com-20110209104418-n3058l06ehubtl9a
(vila) Moves CatchingExceptionThread out of the bzrlib.tests hierarchy.
 (Vincent Ladeuil)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
23
23
# TODO: Should be renamed to bzrlib.transport.http.tests?
24
24
# TODO: What about renaming to bzrlib.tests.transport.http ?
25
25
 
26
 
from cStringIO import StringIO
27
26
import httplib
28
 
import os
29
 
import select
30
27
import SimpleHTTPServer
31
28
import socket
32
29
import sys
40
37
    osutils,
41
38
    remote as _mod_remote,
42
39
    tests,
 
40
    thread,
43
41
    transport,
44
42
    ui,
45
 
    urlutils,
46
 
    )
47
 
from bzrlib.symbol_versioning import (
48
 
    deprecated_in,
49
43
    )
50
44
from bzrlib.tests import (
51
45
    features,
52
46
    http_server,
53
47
    http_utils,
 
48
    test_server,
 
49
    )
 
50
from bzrlib.tests.scenarios import (
 
51
    load_tests_apply_scenarios,
 
52
    multiply_scenarios,
54
53
    )
55
54
from bzrlib.transport import (
56
55
    http,
66
65
    from bzrlib.transport.http._pycurl import PyCurlTransport
67
66
 
68
67
 
69
 
def load_tests(standard_tests, module, loader):
70
 
    """Multiply tests for http clients and protocol versions."""
71
 
    result = loader.suiteClass()
72
 
 
73
 
    # one for each transport implementation
74
 
    t_tests, remaining_tests = tests.split_suite_by_condition(
75
 
        standard_tests, tests.condition_isinstance((
76
 
                TestHttpTransportRegistration,
77
 
                TestHttpTransportUrls,
78
 
                Test_redirected_to,
79
 
                )))
 
68
load_tests = load_tests_apply_scenarios
 
69
 
 
70
 
 
71
def vary_by_http_client_implementation():
 
72
    """Test the two libraries we can use, pycurl and urllib."""
80
73
    transport_scenarios = [
81
74
        ('urllib', dict(_transport=_urllib.HttpTransport_urllib,
82
75
                        _server=http_server.HttpServer_urllib,
83
 
                        _qualified_prefix='http+urllib',)),
 
76
                        _url_protocol='http+urllib',)),
84
77
        ]
85
78
    if features.pycurl.available():
86
79
        transport_scenarios.append(
87
80
            ('pycurl', dict(_transport=PyCurlTransport,
88
81
                            _server=http_server.HttpServer_PyCurl,
89
 
                            _qualified_prefix='http+pycurl',)))
90
 
    tests.multiply_tests(t_tests, transport_scenarios, result)
91
 
 
92
 
    # each implementation tested with each HTTP version
93
 
    tp_tests, remaining_tests = tests.split_suite_by_condition(
94
 
        remaining_tests, tests.condition_isinstance((
95
 
                SmartHTTPTunnellingTest,
96
 
                TestDoCatchRedirections,
97
 
                TestHTTPConnections,
98
 
                TestHTTPRedirections,
99
 
                TestHTTPSilentRedirections,
100
 
                TestLimitedRangeRequestServer,
101
 
                TestPost,
102
 
                TestProxyHttpServer,
103
 
                TestRanges,
104
 
                TestSpecificRequestHandler,
105
 
                )))
106
 
    protocol_scenarios = [
107
 
            ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
108
 
            ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
109
 
            ]
110
 
    tp_scenarios = tests.multiply_scenarios(transport_scenarios,
111
 
                                            protocol_scenarios)
112
 
    tests.multiply_tests(tp_tests, tp_scenarios, result)
113
 
 
114
 
    # proxy auth: each auth scheme on all http versions on all implementations.
115
 
    tppa_tests, remaining_tests = tests.split_suite_by_condition(
116
 
        remaining_tests, tests.condition_isinstance((
117
 
                TestProxyAuth,
118
 
                )))
119
 
    proxy_auth_scheme_scenarios = [
 
82
                            _url_protocol='http+pycurl',)))
 
83
    return transport_scenarios
 
84
 
 
85
 
 
86
def vary_by_http_protocol_version():
 
87
    """Test on http/1.0 and 1.1"""
 
88
    return [
 
89
        ('HTTP/1.0',  dict(_protocol_version='HTTP/1.0')),
 
90
        ('HTTP/1.1',  dict(_protocol_version='HTTP/1.1')),
 
91
        ]
 
92
 
 
93
 
 
94
def vary_by_http_proxy_auth_scheme():
 
95
    return [
120
96
        ('basic', dict(_auth_server=http_utils.ProxyBasicAuthServer)),
121
97
        ('digest', dict(_auth_server=http_utils.ProxyDigestAuthServer)),
122
98
        ('basicdigest',
123
 
         dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
 
99
            dict(_auth_server=http_utils.ProxyBasicAndDigestAuthServer)),
124
100
        ]
125
 
    tppa_scenarios = tests.multiply_scenarios(tp_scenarios,
126
 
                                              proxy_auth_scheme_scenarios)
127
 
    tests.multiply_tests(tppa_tests, tppa_scenarios, result)
128
 
 
129
 
    # auth: each auth scheme on all http versions on all implementations.
130
 
    tpa_tests, remaining_tests = tests.split_suite_by_condition(
131
 
        remaining_tests, tests.condition_isinstance((
132
 
                TestAuth,
133
 
                )))
134
 
    auth_scheme_scenarios = [
 
101
 
 
102
 
 
103
def vary_by_http_auth_scheme():
 
104
    return [
135
105
        ('basic', dict(_auth_server=http_utils.HTTPBasicAuthServer)),
136
106
        ('digest', dict(_auth_server=http_utils.HTTPDigestAuthServer)),
137
107
        ('basicdigest',
138
 
         dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
 
108
            dict(_auth_server=http_utils.HTTPBasicAndDigestAuthServer)),
139
109
        ]
140
 
    tpa_scenarios = tests.multiply_scenarios(tp_scenarios,
141
 
                                             auth_scheme_scenarios)
142
 
    tests.multiply_tests(tpa_tests, tpa_scenarios, result)
143
 
 
144
 
    # activity: on all http[s] versions on all implementations
145
 
    tpact_tests, remaining_tests = tests.split_suite_by_condition(
146
 
        remaining_tests, tests.condition_isinstance((
147
 
                TestActivity,
148
 
                )))
 
110
 
 
111
 
 
112
def vary_by_http_activity():
149
113
    activity_scenarios = [
150
114
        ('urllib,http', dict(_activity_server=ActivityHTTPServer,
151
 
                             _transport=_urllib.HttpTransport_urllib,)),
 
115
                            _transport=_urllib.HttpTransport_urllib,)),
152
116
        ]
153
117
    if tests.HTTPSServerFeature.available():
154
118
        activity_scenarios.append(
155
119
            ('urllib,https', dict(_activity_server=ActivityHTTPSServer,
156
 
                                  _transport=_urllib.HttpTransport_urllib,)),)
 
120
                                _transport=_urllib.HttpTransport_urllib,)),)
157
121
    if features.pycurl.available():
158
122
        activity_scenarios.append(
159
123
            ('pycurl,http', dict(_activity_server=ActivityHTTPServer,
160
 
                                 _transport=PyCurlTransport,)),)
 
124
                                _transport=PyCurlTransport,)),)
161
125
        if tests.HTTPSServerFeature.available():
162
126
            from bzrlib.tests import (
163
127
                ssl_certs,
175
139
 
176
140
            activity_scenarios.append(
177
141
                ('pycurl,https', dict(_activity_server=ActivityHTTPSServer,
178
 
                                      _transport=HTTPS_pycurl_transport,)),)
179
 
 
180
 
    tpact_scenarios = tests.multiply_scenarios(activity_scenarios,
181
 
                                               protocol_scenarios)
182
 
    tests.multiply_tests(tpact_tests, tpact_scenarios, result)
183
 
 
184
 
    # No parametrization for the remaining tests
185
 
    result.addTests(remaining_tests)
186
 
 
187
 
    return result
 
142
                                    _transport=HTTPS_pycurl_transport,)),)
 
143
    return activity_scenarios
188
144
 
189
145
 
190
146
class FakeManager(object):
223
179
        self._sock.bind(('127.0.0.1', 0))
224
180
        self.host, self.port = self._sock.getsockname()
225
181
        self._ready = threading.Event()
226
 
        self._thread = threading.Thread(target=self._accept_read_and_reply)
227
 
        self._thread.setDaemon(True)
 
182
        self._thread = test_server.TestThread(
 
183
            sync_event=self._ready, target=self._accept_read_and_reply)
228
184
        self._thread.start()
229
 
        self._ready.wait(5)
 
185
        if 'threads' in tests.selftest_debug_flags:
 
186
            sys.stderr.write('Thread started: %s\n' % (self._thread.ident,))
 
187
        self._ready.wait()
230
188
 
231
189
    def _accept_read_and_reply(self):
232
190
        self._sock.listen(1)
233
191
        self._ready.set()
234
 
        self._sock.settimeout(5)
235
 
        try:
236
 
            conn, address = self._sock.accept()
237
 
            # On win32, the accepted connection will be non-blocking to start
238
 
            # with because we're using settimeout.
239
 
            conn.setblocking(True)
 
192
        conn, address = self._sock.accept()
 
193
        if self._expect_body_tail is not None:
240
194
            while not self.received_bytes.endswith(self._expect_body_tail):
241
195
                self.received_bytes += conn.recv(4096)
242
196
            conn.sendall('HTTP/1.1 200 OK\r\n')
243
 
        except socket.timeout:
244
 
            # Make sure the client isn't stuck waiting for us to e.g. accept.
 
197
        try:
245
198
            self._sock.close()
246
199
        except socket.error:
247
200
            # The client may have already closed the socket.
249
202
 
250
203
    def stop_server(self):
251
204
        try:
252
 
            self._sock.close()
 
205
            # Issue a fake connection to wake up the server and allow it to
 
206
            # finish quickly
 
207
            fake_conn = osutils.connect_socket((self.host, self.port))
 
208
            fake_conn.close()
253
209
        except socket.error:
254
210
            # We might have already closed it.  We don't care.
255
211
            pass
256
212
        self.host = None
257
213
        self.port = None
 
214
        self._thread.join()
 
215
        if 'threads' in tests.selftest_debug_flags:
 
216
            sys.stderr.write('Thread  joined: %s\n' % (self._thread.ident,))
258
217
 
259
218
 
260
219
class TestAuthHeader(tests.TestCase):
304
263
 
305
264
            protocol_version = 'HTTP/0.1'
306
265
 
307
 
        server = http_server.HttpServer(BogusRequestHandler)
308
 
        try:
309
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
310
 
        except:
311
 
            server.stop_server()
312
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
266
        self.assertRaises(httplib.UnknownProtocol,
 
267
                          http_server.HttpServer, BogusRequestHandler)
313
268
 
314
269
    def test_force_invalid_protocol(self):
315
 
        server = http_server.HttpServer(protocol_version='HTTP/0.1')
316
 
        try:
317
 
            self.assertRaises(httplib.UnknownProtocol, server.start_server)
318
 
        except:
319
 
            server.stop_server()
320
 
            self.fail('HTTP Server creation did not raise UnknownProtocol')
 
270
        self.assertRaises(httplib.UnknownProtocol,
 
271
                          http_server.HttpServer, protocol_version='HTTP/0.1')
321
272
 
322
273
    def test_server_start_and_stop(self):
323
274
        server = http_server.HttpServer()
 
275
        self.addCleanup(server.stop_server)
324
276
        server.start_server()
325
 
        try:
326
 
            self.assertTrue(server._http_running)
327
 
        finally:
328
 
            server.stop_server()
329
 
        self.assertFalse(server._http_running)
 
277
        self.assertTrue(server.server is not None)
 
278
        self.assertTrue(server.server.serving is not None)
 
279
        self.assertTrue(server.server.serving)
330
280
 
331
281
    def test_create_http_server_one_zero(self):
332
282
        class RequestHandlerOneZero(http_server.TestingHTTPRequestHandler):
335
285
 
336
286
        server = http_server.HttpServer(RequestHandlerOneZero)
337
287
        self.start_server(server)
338
 
        self.assertIsInstance(server._httpd, http_server.TestingHTTPServer)
 
288
        self.assertIsInstance(server.server, http_server.TestingHTTPServer)
339
289
 
340
290
    def test_create_http_server_one_one(self):
341
291
        class RequestHandlerOneOne(http_server.TestingHTTPRequestHandler):
344
294
 
345
295
        server = http_server.HttpServer(RequestHandlerOneOne)
346
296
        self.start_server(server)
347
 
        self.assertIsInstance(server._httpd,
 
297
        self.assertIsInstance(server.server,
348
298
                              http_server.TestingThreadingHTTPServer)
349
299
 
350
300
    def test_create_http_server_force_one_one(self):
355
305
        server = http_server.HttpServer(RequestHandlerOneZero,
356
306
                                        protocol_version='HTTP/1.1')
357
307
        self.start_server(server)
358
 
        self.assertIsInstance(server._httpd,
 
308
        self.assertIsInstance(server.server,
359
309
                              http_server.TestingThreadingHTTPServer)
360
310
 
361
311
    def test_create_http_server_force_one_zero(self):
366
316
        server = http_server.HttpServer(RequestHandlerOneOne,
367
317
                                        protocol_version='HTTP/1.0')
368
318
        self.start_server(server)
369
 
        self.assertIsInstance(server._httpd,
 
319
        self.assertIsInstance(server.server,
370
320
                              http_server.TestingHTTPServer)
371
321
 
372
322
 
401
351
class TestHttpTransportUrls(tests.TestCase):
402
352
    """Test the http urls."""
403
353
 
 
354
    scenarios = vary_by_http_client_implementation()
 
355
 
404
356
    def test_abs_url(self):
405
357
        """Construction of absolute http URLs"""
406
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
358
        t = self._transport('http://example.com/bzr/bzr.dev/')
407
359
        eq = self.assertEqualDiff
408
 
        eq(t.abspath('.'), 'http://bazaar-vcs.org/bzr/bzr.dev')
409
 
        eq(t.abspath('foo/bar'), 'http://bazaar-vcs.org/bzr/bzr.dev/foo/bar')
410
 
        eq(t.abspath('.bzr'), 'http://bazaar-vcs.org/bzr/bzr.dev/.bzr')
 
360
        eq(t.abspath('.'), 'http://example.com/bzr/bzr.dev')
 
361
        eq(t.abspath('foo/bar'), 'http://example.com/bzr/bzr.dev/foo/bar')
 
362
        eq(t.abspath('.bzr'), 'http://example.com/bzr/bzr.dev/.bzr')
411
363
        eq(t.abspath('.bzr/1//2/./3'),
412
 
           'http://bazaar-vcs.org/bzr/bzr.dev/.bzr/1/2/3')
 
364
           'http://example.com/bzr/bzr.dev/.bzr/1/2/3')
413
365
 
414
366
    def test_invalid_http_urls(self):
415
367
        """Trap invalid construction of urls"""
416
 
        t = self._transport('http://bazaar-vcs.org/bzr/bzr.dev/')
 
368
        self._transport('http://example.com/bzr/bzr.dev/')
417
369
        self.assertRaises(errors.InvalidURL,
418
370
                          self._transport,
419
 
                          'http://http://bazaar-vcs.org/bzr/bzr.dev/')
 
371
                          'http://http://example.com/bzr/bzr.dev/')
420
372
 
421
373
    def test_http_root_urls(self):
422
374
        """Construction of URLs from server root"""
423
 
        t = self._transport('http://bzr.ozlabs.org/')
 
375
        t = self._transport('http://example.com/')
424
376
        eq = self.assertEqualDiff
425
377
        eq(t.abspath('.bzr/tree-version'),
426
 
           'http://bzr.ozlabs.org/.bzr/tree-version')
 
378
           'http://example.com/.bzr/tree-version')
427
379
 
428
380
    def test_http_impl_urls(self):
429
381
        """There are servers which ask for particular clients to connect"""
431
383
        server.start_server()
432
384
        try:
433
385
            url = server.get_url()
434
 
            self.assertTrue(url.startswith('%s://' % self._qualified_prefix))
 
386
            self.assertTrue(url.startswith('%s://' % self._url_protocol))
435
387
        finally:
436
388
            server.stop_server()
437
389
 
475
427
class TestHTTPConnections(http_utils.TestCaseWithWebserver):
476
428
    """Test the http connections."""
477
429
 
 
430
    scenarios = multiply_scenarios(
 
431
        vary_by_http_client_implementation(), 
 
432
        vary_by_http_protocol_version(),
 
433
        )
 
434
 
478
435
    def setUp(self):
479
436
        http_utils.TestCaseWithWebserver.setUp(self)
480
437
        self.build_tree(['foo/', 'foo/bar'], line_endings='binary',
482
439
 
483
440
    def test_http_has(self):
484
441
        server = self.get_readonly_server()
485
 
        t = self._transport(server.get_url())
 
442
        t = self.get_readonly_transport()
486
443
        self.assertEqual(t.has('foo/bar'), True)
487
444
        self.assertEqual(len(server.logs), 1)
488
445
        self.assertContainsRe(server.logs[0],
490
447
 
491
448
    def test_http_has_not_found(self):
492
449
        server = self.get_readonly_server()
493
 
        t = self._transport(server.get_url())
 
450
        t = self.get_readonly_transport()
494
451
        self.assertEqual(t.has('not-found'), False)
495
452
        self.assertContainsRe(server.logs[1],
496
453
            r'"HEAD /not-found HTTP/1.." 404 - "-" "bzr/')
497
454
 
498
455
    def test_http_get(self):
499
456
        server = self.get_readonly_server()
500
 
        t = self._transport(server.get_url())
 
457
        t = self.get_readonly_transport()
501
458
        fp = t.get('foo/bar')
502
459
        self.assertEqualDiff(
503
460
            fp.read(),
525
482
class TestHttpTransportRegistration(tests.TestCase):
526
483
    """Test registrations of various http implementations"""
527
484
 
 
485
    scenarios = vary_by_http_client_implementation()
 
486
 
528
487
    def test_http_registered(self):
529
 
        t = transport.get_transport('%s://foo.com/' % self._qualified_prefix)
 
488
        t = transport.get_transport('%s://foo.com/' % self._url_protocol)
530
489
        self.assertIsInstance(t, transport.Transport)
531
490
        self.assertIsInstance(t, self._transport)
532
491
 
533
492
 
534
493
class TestPost(tests.TestCase):
535
494
 
 
495
    scenarios = multiply_scenarios(
 
496
        vary_by_http_client_implementation(), 
 
497
        vary_by_http_protocol_version(),
 
498
        )
 
499
 
536
500
    def test_post_body_is_received(self):
537
501
        server = RecordingServer(expect_body_tail='end-of-body',
538
 
            scheme=self._qualified_prefix)
 
502
                                 scheme=self._url_protocol)
539
503
        self.start_server(server)
540
504
        url = server.get_url()
541
 
        http_transport = self._transport(url)
 
505
        # FIXME: needs a cleanup -- vila 20100611
 
506
        http_transport = transport.get_transport(url)
542
507
        code, response = http_transport._post('abc def end-of-body')
543
508
        self.assertTrue(
544
509
            server.received_bytes.startswith('POST /.bzr/smart HTTP/1.'))
545
510
        self.assertTrue('content-length: 19\r' in server.received_bytes.lower())
 
511
        self.assertTrue('content-type: application/octet-stream\r'
 
512
                        in server.received_bytes.lower())
546
513
        # The transport should not be assuming that the server can accept
547
514
        # chunked encoding the first time it connects, because HTTP/1.1, so we
548
515
        # check for the literal string.
584
551
    Daughter classes are expected to override _req_handler_class
585
552
    """
586
553
 
 
554
    scenarios = multiply_scenarios(
 
555
        vary_by_http_client_implementation(), 
 
556
        vary_by_http_protocol_version(),
 
557
        )
 
558
 
587
559
    # Provide a useful default
588
560
    _req_handler_class = http_server.TestingHTTPRequestHandler
589
561
 
590
562
    def create_transport_readonly_server(self):
591
 
        return http_server.HttpServer(self._req_handler_class,
592
 
                                      protocol_version=self._protocol_version)
 
563
        server = http_server.HttpServer(self._req_handler_class,
 
564
                                        protocol_version=self._protocol_version)
 
565
        server._url_protocol = self._url_protocol
 
566
        return server
593
567
 
594
568
    def _testing_pycurl(self):
595
569
        # TODO: This is duplicated for lots of the classes in this file
600
574
class WallRequestHandler(http_server.TestingHTTPRequestHandler):
601
575
    """Whatever request comes in, close the connection"""
602
576
 
603
 
    def handle_one_request(self):
 
577
    def _handle_one_request(self):
604
578
        """Handle a single HTTP request, by abruptly closing the connection"""
605
579
        self.close_connection = 1
606
580
 
611
585
    _req_handler_class = WallRequestHandler
612
586
 
613
587
    def test_http_has(self):
614
 
        server = self.get_readonly_server()
615
 
        t = self._transport(server.get_url())
 
588
        t = self.get_readonly_transport()
616
589
        # Unfortunately httplib (see HTTPResponse._read_status
617
590
        # for details) make no distinction between a closed
618
591
        # socket and badly formatted status line, so we can't
624
597
                          t.has, 'foo/bar')
625
598
 
626
599
    def test_http_get(self):
627
 
        server = self.get_readonly_server()
628
 
        t = self._transport(server.get_url())
 
600
        t = self.get_readonly_transport()
629
601
        self.assertRaises((errors.ConnectionError, errors.ConnectionReset,
630
602
                           errors.InvalidHttpResponse),
631
603
                          t.get, 'foo/bar')
648
620
    _req_handler_class = BadStatusRequestHandler
649
621
 
650
622
    def test_http_has(self):
651
 
        server = self.get_readonly_server()
652
 
        t = self._transport(server.get_url())
 
623
        t = self.get_readonly_transport()
653
624
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
654
625
 
655
626
    def test_http_get(self):
656
 
        server = self.get_readonly_server()
657
 
        t = self._transport(server.get_url())
 
627
        t = self.get_readonly_transport()
658
628
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
659
629
 
660
630
 
665
635
        """Fakes handling a single HTTP request, returns a bad status"""
666
636
        ignored = http_server.TestingHTTPRequestHandler.parse_request(self)
667
637
        self.wfile.write("Invalid status line\r\n")
 
638
        # If we don't close the connection pycurl will hang. Since this is a
 
639
        # stress test we don't *have* to respect the protocol, but we don't
 
640
        # have to sabotage it too much either.
 
641
        self.close_connection = True
668
642
        return False
669
643
 
670
644
 
676
650
 
677
651
    _req_handler_class = InvalidStatusRequestHandler
678
652
 
679
 
    def test_http_has(self):
680
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
681
 
            raise tests.KnownFailure(
682
 
                'pycurl hangs if the server send back garbage')
683
 
        super(TestInvalidStatusServer, self).test_http_has()
684
 
 
685
 
    def test_http_get(self):
686
 
        if self._testing_pycurl() and self._protocol_version == 'HTTP/1.1':
687
 
            raise tests.KnownFailure(
688
 
                'pycurl hangs if the server send back garbage')
689
 
        super(TestInvalidStatusServer, self).test_http_get()
690
 
 
691
653
 
692
654
class BadProtocolRequestHandler(http_server.TestingHTTPRequestHandler):
693
655
    """Whatever request comes in, returns a bad protocol version"""
715
677
        super(TestBadProtocolServer, self).setUp()
716
678
 
717
679
    def test_http_has(self):
718
 
        server = self.get_readonly_server()
719
 
        t = self._transport(server.get_url())
 
680
        t = self.get_readonly_transport()
720
681
        self.assertRaises(errors.InvalidHttpResponse, t.has, 'foo/bar')
721
682
 
722
683
    def test_http_get(self):
723
 
        server = self.get_readonly_server()
724
 
        t = self._transport(server.get_url())
 
684
        t = self.get_readonly_transport()
725
685
        self.assertRaises(errors.InvalidHttpResponse, t.get, 'foo/bar')
726
686
 
727
687
 
741
701
    _req_handler_class = ForbiddenRequestHandler
742
702
 
743
703
    def test_http_has(self):
744
 
        server = self.get_readonly_server()
745
 
        t = self._transport(server.get_url())
 
704
        t = self.get_readonly_transport()
746
705
        self.assertRaises(errors.TransportError, t.has, 'foo/bar')
747
706
 
748
707
    def test_http_get(self):
749
 
        server = self.get_readonly_server()
750
 
        t = self._transport(server.get_url())
 
708
        t = self.get_readonly_transport()
751
709
        self.assertRaises(errors.TransportError, t.get, 'foo/bar')
752
710
 
753
711
 
792
750
        self.build_tree_contents([('a', '0123456789')],)
793
751
 
794
752
    def test_readv(self):
795
 
        server = self.get_readonly_server()
796
 
        t = self._transport(server.get_url())
 
753
        t = self.get_readonly_transport()
797
754
        l = list(t.readv('a', ((0, 1), (1, 1), (3, 2), (9, 1))))
798
755
        self.assertEqual(l[0], (0, '0'))
799
756
        self.assertEqual(l[1], (1, '1'))
801
758
        self.assertEqual(l[3], (9, '9'))
802
759
 
803
760
    def test_readv_out_of_order(self):
804
 
        server = self.get_readonly_server()
805
 
        t = self._transport(server.get_url())
 
761
        t = self.get_readonly_transport()
806
762
        l = list(t.readv('a', ((1, 1), (9, 1), (0, 1), (3, 2))))
807
763
        self.assertEqual(l[0], (1, '1'))
808
764
        self.assertEqual(l[1], (9, '9'))
810
766
        self.assertEqual(l[3], (3, '34'))
811
767
 
812
768
    def test_readv_invalid_ranges(self):
813
 
        server = self.get_readonly_server()
814
 
        t = self._transport(server.get_url())
 
769
        t = self.get_readonly_transport()
815
770
 
816
771
        # This is intentionally reading off the end of the file
817
772
        # since we are sure that it cannot get there
825
780
 
826
781
    def test_readv_multiple_get_requests(self):
827
782
        server = self.get_readonly_server()
828
 
        t = self._transport(server.get_url())
 
783
        t = self.get_readonly_transport()
829
784
        # force transport to issue multiple requests
830
785
        t._max_readv_combine = 1
831
786
        t._max_get_ranges = 1
839
794
 
840
795
    def test_readv_get_max_size(self):
841
796
        server = self.get_readonly_server()
842
 
        t = self._transport(server.get_url())
 
797
        t = self.get_readonly_transport()
843
798
        # force transport to issue multiple requests by limiting the number of
844
799
        # bytes by request. Note that this apply to coalesced offsets only, a
845
800
        # single range will keep its size even if bigger than the limit.
854
809
 
855
810
    def test_complete_readv_leave_pipe_clean(self):
856
811
        server = self.get_readonly_server()
857
 
        t = self._transport(server.get_url())
 
812
        t = self.get_readonly_transport()
858
813
        # force transport to issue multiple requests
859
814
        t._get_max_size = 2
860
 
        l = list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
 
815
        list(t.readv('a', ((0, 1), (1, 1), (2, 4), (6, 4))))
861
816
        # The server should have issued 3 requests
862
817
        self.assertEqual(3, server.GET_request_nb)
863
818
        self.assertEqual('0123456789', t.get_bytes('a'))
865
820
 
866
821
    def test_incomplete_readv_leave_pipe_clean(self):
867
822
        server = self.get_readonly_server()
868
 
        t = self._transport(server.get_url())
 
823
        t = self.get_readonly_transport()
869
824
        # force transport to issue multiple requests
870
825
        t._get_max_size = 2
871
826
        # Don't collapse readv results into a list so that we leave unread
940
895
    def get_multiple_ranges(self, file, file_size, ranges):
941
896
        self.send_response(206)
942
897
        self.send_header('Accept-Ranges', 'bytes')
 
898
        # XXX: this is strange; the 'random' name below seems undefined and
 
899
        # yet the tests pass -- mbp 2010-10-11 bug 658773
943
900
        boundary = "%d" % random.randint(0,0x7FFFFFFF)
944
901
        self.send_header("Content-Type",
945
902
                         "multipart/byteranges; boundary=%s" % boundary)
1007
964
                return
1008
965
            self.send_range_content(file, start, end - start + 1)
1009
966
            cur += 1
1010
 
        # No final boundary
 
967
        # Final boundary
1011
968
        self.wfile.write(boundary_line)
1012
969
 
1013
970
 
1021
978
 
1022
979
    def test_readv_with_short_reads(self):
1023
980
        server = self.get_readonly_server()
1024
 
        t = self._transport(server.get_url())
 
981
        t = self.get_readonly_transport()
1025
982
        # Force separate ranges for each offset
1026
983
        t._bytes_to_read_before_seek = 0
1027
984
        ireadv = iter(t.readv('a', ((0, 1), (2, 1), (4, 2), (9, 1))))
1042
999
        # that mode
1043
1000
        self.assertEqual('single', t._range_hint)
1044
1001
 
 
1002
 
1045
1003
class LimitedRangeRequestHandler(http_server.TestingHTTPRequestHandler):
1046
1004
    """Errors out when range specifiers exceed the limit"""
1047
1005
 
1071
1029
class TestLimitedRangeRequestServer(http_utils.TestCaseWithWebserver):
1072
1030
    """Tests readv requests against a server erroring out on too much ranges."""
1073
1031
 
 
1032
    scenarios = multiply_scenarios(
 
1033
        vary_by_http_client_implementation(), 
 
1034
        vary_by_http_protocol_version(),
 
1035
        )
 
1036
 
1074
1037
    # Requests with more range specifiers will error out
1075
1038
    range_limit = 3
1076
1039
 
1078
1041
        return LimitedRangeHTTPServer(range_limit=self.range_limit,
1079
1042
                                      protocol_version=self._protocol_version)
1080
1043
 
1081
 
    def get_transport(self):
1082
 
        return self._transport(self.get_readonly_server().get_url())
1083
 
 
1084
1044
    def setUp(self):
1085
1045
        http_utils.TestCaseWithWebserver.setUp(self)
1086
1046
        # We need to manipulate ranges that correspond to real chunks in the
1090
1050
        self.build_tree_contents([('a', content)],)
1091
1051
 
1092
1052
    def test_few_ranges(self):
1093
 
        t = self.get_transport()
 
1053
        t = self.get_readonly_transport()
1094
1054
        l = list(t.readv('a', ((0, 4), (1024, 4), )))
1095
1055
        self.assertEqual(l[0], (0, '0000'))
1096
1056
        self.assertEqual(l[1], (1024, '0001'))
1097
1057
        self.assertEqual(1, self.get_readonly_server().GET_request_nb)
1098
1058
 
1099
1059
    def test_more_ranges(self):
1100
 
        t = self.get_transport()
 
1060
        t = self.get_readonly_transport()
1101
1061
        l = list(t.readv('a', ((0, 4), (1024, 4), (4096, 4), (8192, 4))))
1102
1062
        self.assertEqual(l[0], (0, '0000'))
1103
1063
        self.assertEqual(l[1], (1024, '0001'))
1114
1074
    Only the urllib implementation is tested here.
1115
1075
    """
1116
1076
 
1117
 
    def setUp(self):
1118
 
        tests.TestCase.setUp(self)
1119
 
        self._old_env = {}
1120
 
 
1121
 
    def tearDown(self):
1122
 
        self._restore_env()
1123
 
        tests.TestCase.tearDown(self)
1124
 
 
1125
 
    def _install_env(self, env):
1126
 
        for name, value in env.iteritems():
1127
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1128
 
 
1129
 
    def _restore_env(self):
1130
 
        for name, value in self._old_env.iteritems():
1131
 
            osutils.set_or_unset_env(name, value)
1132
 
 
1133
1077
    def _proxied_request(self):
1134
1078
        handler = _urllib2_wrappers.ProxyHandler()
1135
1079
        request = _urllib2_wrappers.Request('GET','http://baz/buzzle')
1136
1080
        handler.set_proxy(request, 'http')
1137
1081
        return request
1138
1082
 
 
1083
    def assertEvaluateProxyBypass(self, expected, host, no_proxy):
 
1084
        handler = _urllib2_wrappers.ProxyHandler()
 
1085
        self.assertEquals(expected,
 
1086
                          handler.evaluate_proxy_bypass(host, no_proxy))
 
1087
 
1139
1088
    def test_empty_user(self):
1140
 
        self._install_env({'http_proxy': 'http://bar.com'})
 
1089
        self.overrideEnv('http_proxy', 'http://bar.com')
1141
1090
        request = self._proxied_request()
1142
1091
        self.assertFalse(request.headers.has_key('Proxy-authorization'))
1143
1092
 
1144
1093
    def test_invalid_proxy(self):
1145
1094
        """A proxy env variable without scheme"""
1146
 
        self._install_env({'http_proxy': 'host:1234'})
 
1095
        self.overrideEnv('http_proxy', 'host:1234')
1147
1096
        self.assertRaises(errors.InvalidURL, self._proxied_request)
1148
1097
 
 
1098
    def test_evaluate_proxy_bypass_true(self):
 
1099
        """The host is not proxied"""
 
1100
        self.assertEvaluateProxyBypass(True, 'example.com', 'example.com')
 
1101
        self.assertEvaluateProxyBypass(True, 'bzr.example.com', '*example.com')
 
1102
 
 
1103
    def test_evaluate_proxy_bypass_false(self):
 
1104
        """The host is proxied"""
 
1105
        self.assertEvaluateProxyBypass(False, 'bzr.example.com', None)
 
1106
 
 
1107
    def test_evaluate_proxy_bypass_unknown(self):
 
1108
        """The host is not explicitly proxied"""
 
1109
        self.assertEvaluateProxyBypass(None, 'example.com', 'not.example.com')
 
1110
        self.assertEvaluateProxyBypass(None, 'bzr.example.com', 'example.com')
 
1111
 
 
1112
    def test_evaluate_proxy_bypass_empty_entries(self):
 
1113
        """Ignore empty entries"""
 
1114
        self.assertEvaluateProxyBypass(None, 'example.com', '')
 
1115
        self.assertEvaluateProxyBypass(None, 'example.com', ',')
 
1116
        self.assertEvaluateProxyBypass(None, 'example.com', 'foo,,bar')
 
1117
 
1149
1118
 
1150
1119
class TestProxyHttpServer(http_utils.TestCaseWithTwoWebservers):
1151
1120
    """Tests proxy server.
1156
1125
    to the file names).
1157
1126
    """
1158
1127
 
 
1128
    scenarios = multiply_scenarios(
 
1129
        vary_by_http_client_implementation(), 
 
1130
        vary_by_http_protocol_version(),
 
1131
        )
 
1132
 
1159
1133
    # FIXME: We don't have an https server available, so we don't
1160
 
    # test https connections.
 
1134
    # test https connections. --vila toolongago
1161
1135
 
1162
1136
    def setUp(self):
1163
1137
        super(TestProxyHttpServer, self).setUp()
 
1138
        self.transport_secondary_server = http_utils.ProxyServer
1164
1139
        self.build_tree_contents([('foo', 'contents of foo\n'),
1165
1140
                                  ('foo-proxied', 'proxied contents of foo\n')])
1166
1141
        # Let's setup some attributes for tests
1167
 
        self.server = self.get_readonly_server()
1168
 
        self.proxy_address = '%s:%d' % (self.server.host, self.server.port)
 
1142
        server = self.get_readonly_server()
 
1143
        self.server_host_port = '%s:%d' % (server.host, server.port)
1169
1144
        if self._testing_pycurl():
1170
1145
            # Oh my ! pycurl does not check for the port as part of
1171
1146
            # no_proxy :-( So we just test the host part
1172
 
            self.no_proxy_host = self.server.host
 
1147
            self.no_proxy_host = server.host
1173
1148
        else:
1174
 
            self.no_proxy_host = self.proxy_address
 
1149
            self.no_proxy_host = self.server_host_port
1175
1150
        # The secondary server is the proxy
1176
 
        self.proxy = self.get_secondary_server()
1177
 
        self.proxy_url = self.proxy.get_url()
1178
 
        self._old_env = {}
 
1151
        self.proxy_url = self.get_secondary_url()
1179
1152
 
1180
1153
    def _testing_pycurl(self):
1181
1154
        # TODO: This is duplicated for lots of the classes in this file
1182
1155
        return (features.pycurl.available()
1183
1156
                and self._transport == PyCurlTransport)
1184
1157
 
1185
 
    def create_transport_secondary_server(self):
1186
 
        """Creates an http server that will serve files with
1187
 
        '-proxied' appended to their names.
1188
 
        """
1189
 
        return http_utils.ProxyServer(protocol_version=self._protocol_version)
1190
 
 
1191
 
    def _install_env(self, env):
1192
 
        for name, value in env.iteritems():
1193
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1194
 
 
1195
 
    def _restore_env(self):
1196
 
        for name, value in self._old_env.iteritems():
1197
 
            osutils.set_or_unset_env(name, value)
1198
 
 
1199
 
    def proxied_in_env(self, env):
1200
 
        self._install_env(env)
1201
 
        url = self.server.get_url()
1202
 
        t = self._transport(url)
1203
 
        try:
1204
 
            self.assertEqual('proxied contents of foo\n', t.get('foo').read())
1205
 
        finally:
1206
 
            self._restore_env()
1207
 
 
1208
 
    def not_proxied_in_env(self, env):
1209
 
        self._install_env(env)
1210
 
        url = self.server.get_url()
1211
 
        t = self._transport(url)
1212
 
        try:
1213
 
            self.assertEqual('contents of foo\n', t.get('foo').read())
1214
 
        finally:
1215
 
            self._restore_env()
 
1158
    def assertProxied(self):
 
1159
        t = self.get_readonly_transport()
 
1160
        self.assertEqual('proxied contents of foo\n', t.get('foo').read())
 
1161
 
 
1162
    def assertNotProxied(self):
 
1163
        t = self.get_readonly_transport()
 
1164
        self.assertEqual('contents of foo\n', t.get('foo').read())
1216
1165
 
1217
1166
    def test_http_proxy(self):
1218
 
        self.proxied_in_env({'http_proxy': self.proxy_url})
 
1167
        self.overrideEnv('http_proxy', self.proxy_url)
 
1168
        self.assertProxied()
1219
1169
 
1220
1170
    def test_HTTP_PROXY(self):
1221
1171
        if self._testing_pycurl():
1224
1174
            # about. Should we ?)
1225
1175
            raise tests.TestNotApplicable(
1226
1176
                'pycurl does not check HTTP_PROXY for security reasons')
1227
 
        self.proxied_in_env({'HTTP_PROXY': self.proxy_url})
 
1177
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1178
        self.assertProxied()
1228
1179
 
1229
1180
    def test_all_proxy(self):
1230
 
        self.proxied_in_env({'all_proxy': self.proxy_url})
 
1181
        self.overrideEnv('all_proxy', self.proxy_url)
 
1182
        self.assertProxied()
1231
1183
 
1232
1184
    def test_ALL_PROXY(self):
1233
 
        self.proxied_in_env({'ALL_PROXY': self.proxy_url})
 
1185
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1186
        self.assertProxied()
1234
1187
 
1235
1188
    def test_http_proxy_with_no_proxy(self):
1236
 
        self.not_proxied_in_env({'http_proxy': self.proxy_url,
1237
 
                                 'no_proxy': self.no_proxy_host})
 
1189
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1190
        self.overrideEnv('http_proxy', self.proxy_url)
 
1191
        self.assertNotProxied()
1238
1192
 
1239
1193
    def test_HTTP_PROXY_with_NO_PROXY(self):
1240
1194
        if self._testing_pycurl():
1241
1195
            raise tests.TestNotApplicable(
1242
1196
                'pycurl does not check HTTP_PROXY for security reasons')
1243
 
        self.not_proxied_in_env({'HTTP_PROXY': self.proxy_url,
1244
 
                                 'NO_PROXY': self.no_proxy_host})
 
1197
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1198
        self.overrideEnv('HTTP_PROXY', self.proxy_url)
 
1199
        self.assertNotProxied()
1245
1200
 
1246
1201
    def test_all_proxy_with_no_proxy(self):
1247
 
        self.not_proxied_in_env({'all_proxy': self.proxy_url,
1248
 
                                 'no_proxy': self.no_proxy_host})
 
1202
        self.overrideEnv('no_proxy', self.no_proxy_host)
 
1203
        self.overrideEnv('all_proxy', self.proxy_url)
 
1204
        self.assertNotProxied()
1249
1205
 
1250
1206
    def test_ALL_PROXY_with_NO_PROXY(self):
1251
 
        self.not_proxied_in_env({'ALL_PROXY': self.proxy_url,
1252
 
                                 'NO_PROXY': self.no_proxy_host})
 
1207
        self.overrideEnv('NO_PROXY', self.no_proxy_host)
 
1208
        self.overrideEnv('ALL_PROXY', self.proxy_url)
 
1209
        self.assertNotProxied()
1253
1210
 
1254
1211
    def test_http_proxy_without_scheme(self):
 
1212
        self.overrideEnv('http_proxy', self.server_host_port)
1255
1213
        if self._testing_pycurl():
1256
1214
            # pycurl *ignores* invalid proxy env variables. If that ever change
1257
1215
            # in the future, this test will fail indicating that pycurl do not
1258
1216
            # ignore anymore such variables.
1259
 
            self.not_proxied_in_env({'http_proxy': self.proxy_address})
 
1217
            self.assertNotProxied()
1260
1218
        else:
1261
 
            self.assertRaises(errors.InvalidURL,
1262
 
                              self.proxied_in_env,
1263
 
                              {'http_proxy': self.proxy_address})
 
1219
            self.assertRaises(errors.InvalidURL, self.assertProxied)
1264
1220
 
1265
1221
 
1266
1222
class TestRanges(http_utils.TestCaseWithWebserver):
1267
1223
    """Test the Range header in GET methods."""
1268
1224
 
 
1225
    scenarios = multiply_scenarios(
 
1226
        vary_by_http_client_implementation(), 
 
1227
        vary_by_http_protocol_version(),
 
1228
        )
 
1229
 
1269
1230
    def setUp(self):
1270
1231
        http_utils.TestCaseWithWebserver.setUp(self)
1271
1232
        self.build_tree_contents([('a', '0123456789')],)
1272
 
        server = self.get_readonly_server()
1273
 
        self.transport = self._transport(server.get_url())
1274
1233
 
1275
1234
    def create_transport_readonly_server(self):
1276
1235
        return http_server.HttpServer(protocol_version=self._protocol_version)
1277
1236
 
1278
1237
    def _file_contents(self, relpath, ranges):
 
1238
        t = self.get_readonly_transport()
1279
1239
        offsets = [ (start, end - start + 1) for start, end in ranges]
1280
 
        coalesce = self.transport._coalesce_offsets
 
1240
        coalesce = t._coalesce_offsets
1281
1241
        coalesced = list(coalesce(offsets, limit=0, fudge_factor=0))
1282
 
        code, data = self.transport._get(relpath, coalesced)
 
1242
        code, data = t._get(relpath, coalesced)
1283
1243
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1284
1244
        for start, end in ranges:
1285
1245
            data.seek(start)
1286
1246
            yield data.read(end - start + 1)
1287
1247
 
1288
1248
    def _file_tail(self, relpath, tail_amount):
1289
 
        code, data = self.transport._get(relpath, [], tail_amount)
 
1249
        t = self.get_readonly_transport()
 
1250
        code, data = t._get(relpath, [], tail_amount)
1290
1251
        self.assertTrue(code in (200, 206),'_get returns: %d' % code)
1291
1252
        data.seek(-tail_amount, 2)
1292
1253
        return data.read(tail_amount)
1311
1272
class TestHTTPRedirections(http_utils.TestCaseWithRedirectedWebserver):
1312
1273
    """Test redirection between http servers."""
1313
1274
 
1314
 
    def create_transport_secondary_server(self):
1315
 
        """Create the secondary server redirecting to the primary server"""
1316
 
        new = self.get_readonly_server()
1317
 
 
1318
 
        redirecting = http_utils.HTTPServerRedirecting(
1319
 
            protocol_version=self._protocol_version)
1320
 
        redirecting.redirect_to(new.host, new.port)
1321
 
        return redirecting
 
1275
    scenarios = multiply_scenarios(
 
1276
        vary_by_http_client_implementation(), 
 
1277
        vary_by_http_protocol_version(),
 
1278
        )
1322
1279
 
1323
1280
    def setUp(self):
1324
1281
        super(TestHTTPRedirections, self).setUp()
1326
1283
                                  ('bundle',
1327
1284
                                  '# Bazaar revision bundle v0.9\n#\n')
1328
1285
                                  ],)
1329
 
        # The requests to the old server will be redirected to the new server
1330
 
        self.old_transport = self._transport(self.old_server.get_url())
1331
1286
 
1332
1287
    def test_redirected(self):
1333
 
        self.assertRaises(errors.RedirectRequested, self.old_transport.get, 'a')
1334
 
        t = self._transport(self.new_server.get_url())
1335
 
        self.assertEqual('0123456789', t.get('a').read())
1336
 
 
1337
 
    def test_read_redirected_bundle_from_url(self):
1338
 
        from bzrlib.bundle import read_bundle_from_url
1339
 
        url = self.old_transport.abspath('bundle')
1340
 
        bundle = self.applyDeprecated(deprecated_in((1, 12, 0)),
1341
 
                read_bundle_from_url, url)
1342
 
        # If read_bundle_from_url was successful we get an empty bundle
1343
 
        self.assertEqual([], bundle.revisions)
 
1288
        self.assertRaises(errors.RedirectRequested,
 
1289
                          self.get_old_transport().get, 'a')
 
1290
        self.assertEqual('0123456789', self.get_new_transport().get('a').read())
1344
1291
 
1345
1292
 
1346
1293
class RedirectedRequest(_urllib2_wrappers.Request):
1363
1310
    test.overrideAttr(_urllib2_wrappers, 'Request', RedirectedRequest)
1364
1311
 
1365
1312
 
 
1313
def cleanup_http_redirection_connections(test):
 
1314
    # Some sockets are opened but never seen by _urllib, so we trap them at
 
1315
    # the _urllib2_wrappers level to be able to clean them up.
 
1316
    def socket_disconnect(sock):
 
1317
        try:
 
1318
            sock.shutdown(socket.SHUT_RDWR)
 
1319
            sock.close()
 
1320
        except socket.error:
 
1321
            pass
 
1322
    def connect(connection):
 
1323
        test.http_connect_orig(connection)
 
1324
        test.addCleanup(socket_disconnect, connection.sock)
 
1325
    test.http_connect_orig = test.overrideAttr(
 
1326
        _urllib2_wrappers.HTTPConnection, 'connect', connect)
 
1327
    def connect(connection):
 
1328
        test.https_connect_orig(connection)
 
1329
        test.addCleanup(socket_disconnect, connection.sock)
 
1330
    test.https_connect_orig = test.overrideAttr(
 
1331
        _urllib2_wrappers.HTTPSConnection, 'connect', connect)
 
1332
 
 
1333
 
1366
1334
class TestHTTPSilentRedirections(http_utils.TestCaseWithRedirectedWebserver):
1367
1335
    """Test redirections.
1368
1336
 
1377
1345
    -- vila 20070212
1378
1346
    """
1379
1347
 
 
1348
    scenarios = multiply_scenarios(
 
1349
        vary_by_http_client_implementation(), 
 
1350
        vary_by_http_protocol_version(),
 
1351
        )
 
1352
 
1380
1353
    def setUp(self):
1381
1354
        if (features.pycurl.available()
1382
1355
            and self._transport == PyCurlTransport):
1383
1356
            raise tests.TestNotApplicable(
1384
 
                "pycurl doesn't redirect silently annymore")
 
1357
                "pycurl doesn't redirect silently anymore")
1385
1358
        super(TestHTTPSilentRedirections, self).setUp()
1386
1359
        install_redirected_request(self)
 
1360
        cleanup_http_redirection_connections(self)
1387
1361
        self.build_tree_contents([('a','a'),
1388
1362
                                  ('1/',),
1389
1363
                                  ('1/a', 'redirected once'),
1397
1371
                                  ('5/a', 'redirected 5 times'),
1398
1372
                                  ],)
1399
1373
 
1400
 
        self.old_transport = self._transport(self.old_server.get_url())
1401
 
 
1402
 
    def create_transport_secondary_server(self):
1403
 
        """Create the secondary server, redirections are defined in the tests"""
1404
 
        return http_utils.HTTPServerRedirecting(
1405
 
            protocol_version=self._protocol_version)
1406
 
 
1407
1374
    def test_one_redirection(self):
1408
 
        t = self.old_transport
1409
 
 
1410
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1375
        t = self.get_old_transport()
 
1376
        req = RedirectedRequest('GET', t._remote_path('a'))
1411
1377
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1412
1378
                                       self.new_server.port)
1413
1379
        self.old_server.redirections = \
1414
1380
            [('(.*)', r'%s/1\1' % (new_prefix), 301),]
1415
 
        self.assertEqual('redirected once',t._perform(req).read())
 
1381
        self.assertEqual('redirected once', t._perform(req).read())
1416
1382
 
1417
1383
    def test_five_redirections(self):
1418
 
        t = self.old_transport
1419
 
 
1420
 
        req = RedirectedRequest('GET', t.abspath('a'))
 
1384
        t = self.get_old_transport()
 
1385
        req = RedirectedRequest('GET', t._remote_path('a'))
1421
1386
        old_prefix = 'http://%s:%s' % (self.old_server.host,
1422
1387
                                       self.old_server.port)
1423
1388
        new_prefix = 'http://%s:%s' % (self.new_server.host,
1429
1394
            ('/4(.*)', r'%s/5\1' % (new_prefix), 301),
1430
1395
            ('(/[^/]+)', r'%s/1\1' % (old_prefix), 301),
1431
1396
            ]
1432
 
        self.assertEqual('redirected 5 times',t._perform(req).read())
 
1397
        self.assertEqual('redirected 5 times', t._perform(req).read())
1433
1398
 
1434
1399
 
1435
1400
class TestDoCatchRedirections(http_utils.TestCaseWithRedirectedWebserver):
1436
1401
    """Test transport.do_catching_redirections."""
1437
1402
 
 
1403
    scenarios = multiply_scenarios(
 
1404
        vary_by_http_client_implementation(), 
 
1405
        vary_by_http_protocol_version(),
 
1406
        )
 
1407
 
1438
1408
    def setUp(self):
1439
1409
        super(TestDoCatchRedirections, self).setUp()
1440
1410
        self.build_tree_contents([('a', '0123456789'),],)
1441
 
 
1442
 
        self.old_transport = self._transport(self.old_server.get_url())
1443
 
 
1444
 
    def get_a(self, transport):
1445
 
        return transport.get('a')
 
1411
        cleanup_http_redirection_connections(self)
 
1412
 
 
1413
        self.old_transport = self.get_old_transport()
 
1414
 
 
1415
    def get_a(self, t):
 
1416
        return t.get('a')
1446
1417
 
1447
1418
    def test_no_redirection(self):
1448
 
        t = self._transport(self.new_server.get_url())
 
1419
        t = self.get_new_transport()
1449
1420
 
1450
1421
        # We use None for redirected so that we fail if redirected
1451
1422
        self.assertEqual('0123456789',
1455
1426
    def test_one_redirection(self):
1456
1427
        self.redirections = 0
1457
1428
 
1458
 
        def redirected(transport, exception, redirection_notice):
 
1429
        def redirected(t, exception, redirection_notice):
1459
1430
            self.redirections += 1
1460
 
            dir, file = urlutils.split(exception.target)
1461
 
            return self._transport(dir)
 
1431
            redirected_t = t._redirected_to(exception.source, exception.target)
 
1432
            return redirected_t
1462
1433
 
1463
1434
        self.assertEqual('0123456789',
1464
1435
                         transport.do_catching_redirections(
1481
1452
class TestAuth(http_utils.TestCaseWithWebserver):
1482
1453
    """Test authentication scheme"""
1483
1454
 
 
1455
    scenarios = multiply_scenarios(
 
1456
        vary_by_http_client_implementation(),
 
1457
        vary_by_http_protocol_version(),
 
1458
        vary_by_http_auth_scheme(),
 
1459
        )
 
1460
 
1484
1461
    _auth_header = 'Authorization'
1485
1462
    _password_prompt_prefix = ''
1486
1463
    _username_prompt_prefix = ''
1494
1471
                                  ('b', 'contents of b\n'),])
1495
1472
 
1496
1473
    def create_transport_readonly_server(self):
1497
 
        return self._auth_server(protocol_version=self._protocol_version)
 
1474
        server = self._auth_server(protocol_version=self._protocol_version)
 
1475
        server._url_protocol = self._url_protocol
 
1476
        return server
1498
1477
 
1499
1478
    def _testing_pycurl(self):
1500
1479
        # TODO: This is duplicated for lots of the classes in this file
1513
1492
        return url
1514
1493
 
1515
1494
    def get_user_transport(self, user, password):
1516
 
        return self._transport(self.get_user_url(user, password))
 
1495
        t = transport.get_transport(self.get_user_url(user, password))
 
1496
        return t
1517
1497
 
1518
1498
    def test_no_user(self):
1519
1499
        self.server.add_user('joe', 'foo')
1630
1610
        ui.ui_factory = tests.TestUIFactory(stdin=stdin_content,
1631
1611
                                            stderr=tests.StringIOWrapper())
1632
1612
        # Create a minimal config file with the right password
1633
 
        conf = config.AuthenticationConfig()
1634
 
        conf._get_config().update(
1635
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1636
 
                          'user': user, 'password': password}})
1637
 
        conf._save()
 
1613
        _setup_authentication_config(
 
1614
            scheme='http', 
 
1615
            port=self.server.port,
 
1616
            user=user,
 
1617
            password=password)
1638
1618
        # Issue a request to the server to connect
1639
1619
        self.assertEqual('contents of a\n',t.get('a').read())
1640
1620
        # stdin should have  been left untouched
1642
1622
        # Only one 'Authentication Required' error should occur
1643
1623
        self.assertEqual(1, self.server.auth_required_errors)
1644
1624
 
1645
 
    def test_user_from_auth_conf(self):
1646
 
        if self._testing_pycurl():
1647
 
            raise tests.TestNotApplicable(
1648
 
                'pycurl does not support authentication.conf')
1649
 
        user = 'joe'
1650
 
        password = 'foo'
1651
 
        self.server.add_user(user, password)
1652
 
        # Create a minimal config file with the right password
1653
 
        conf = config.AuthenticationConfig()
1654
 
        conf._get_config().update(
1655
 
            {'httptest': {'scheme': 'http', 'port': self.server.port,
1656
 
                          'user': user, 'password': password}})
1657
 
        conf._save()
1658
 
        t = self.get_user_transport(None, None)
1659
 
        # Issue a request to the server to connect
1660
 
        self.assertEqual('contents of a\n', t.get('a').read())
1661
 
        # Only one 'Authentication Required' error should occur
1662
 
        self.assertEqual(1, self.server.auth_required_errors)
1663
 
 
1664
1625
    def test_changing_nonce(self):
1665
1626
        if self._auth_server not in (http_utils.HTTPDigestAuthServer,
1666
1627
                                     http_utils.ProxyDigestAuthServer):
1682
1643
        # initial 'who are you' and a second 'who are you' with the new nonce)
1683
1644
        self.assertEqual(2, self.server.auth_required_errors)
1684
1645
 
 
1646
    def test_user_from_auth_conf(self):
 
1647
        if self._testing_pycurl():
 
1648
            raise tests.TestNotApplicable(
 
1649
                'pycurl does not support authentication.conf')
 
1650
        user = 'joe'
 
1651
        password = 'foo'
 
1652
        self.server.add_user(user, password)
 
1653
        _setup_authentication_config(
 
1654
            scheme='http', 
 
1655
            port=self.server.port,
 
1656
            user=user,
 
1657
            password=password)
 
1658
        t = self.get_user_transport(None, None)
 
1659
        # Issue a request to the server to connect
 
1660
        self.assertEqual('contents of a\n', t.get('a').read())
 
1661
        # Only one 'Authentication Required' error should occur
 
1662
        self.assertEqual(1, self.server.auth_required_errors)
 
1663
 
 
1664
 
 
1665
def _setup_authentication_config(**kwargs):
 
1666
    conf = config.AuthenticationConfig()
 
1667
    conf._get_config().update({'httptest': kwargs})
 
1668
    conf._save()
 
1669
 
 
1670
 
 
1671
 
 
1672
class TestUrllib2AuthHandler(tests.TestCaseWithTransport):
 
1673
    """Unit tests for glue by which urllib2 asks us for authentication"""
 
1674
 
 
1675
    def test_get_user_password_without_port(self):
 
1676
        """We cope if urllib2 doesn't tell us the port.
 
1677
 
 
1678
        See https://bugs.launchpad.net/bzr/+bug/654684
 
1679
        """
 
1680
        user = 'joe'
 
1681
        password = 'foo'
 
1682
        _setup_authentication_config(
 
1683
            scheme='http', 
 
1684
            host='localhost',
 
1685
            user=user,
 
1686
            password=password)
 
1687
        handler = _urllib2_wrappers.HTTPAuthHandler()
 
1688
        got_pass = handler.get_user_password(dict(
 
1689
            user='joe',
 
1690
            protocol='http',
 
1691
            host='localhost',
 
1692
            path='/',
 
1693
            realm='Realm',
 
1694
            ))
 
1695
        self.assertEquals((user, password), got_pass)
1685
1696
 
1686
1697
 
1687
1698
class TestProxyAuth(TestAuth):
1688
1699
    """Test proxy authentication schemes."""
1689
1700
 
 
1701
    scenarios = multiply_scenarios(
 
1702
        vary_by_http_client_implementation(),
 
1703
        vary_by_http_protocol_version(),
 
1704
        vary_by_http_proxy_auth_scheme(),
 
1705
        )
 
1706
 
1690
1707
    _auth_header = 'Proxy-authorization'
1691
1708
    _password_prompt_prefix = 'Proxy '
1692
1709
    _username_prompt_prefix = 'Proxy '
1693
1710
 
1694
1711
    def setUp(self):
1695
1712
        super(TestProxyAuth, self).setUp()
1696
 
        self._old_env = {}
1697
 
        self.addCleanup(self._restore_env)
1698
1713
        # Override the contents to avoid false positives
1699
1714
        self.build_tree_contents([('a', 'not proxied contents of a\n'),
1700
1715
                                  ('b', 'not proxied contents of b\n'),
1703
1718
                                  ])
1704
1719
 
1705
1720
    def get_user_transport(self, user, password):
1706
 
        self._install_env({'all_proxy': self.get_user_url(user, password)})
1707
 
        return self._transport(self.server.get_url())
1708
 
 
1709
 
    def _install_env(self, env):
1710
 
        for name, value in env.iteritems():
1711
 
            self._old_env[name] = osutils.set_or_unset_env(name, value)
1712
 
 
1713
 
    def _restore_env(self):
1714
 
        for name, value in self._old_env.iteritems():
1715
 
            osutils.set_or_unset_env(name, value)
 
1721
        self.overrideEnv('all_proxy', self.get_user_url(user, password))
 
1722
        return TestAuth.get_user_transport(self, user, password)
1716
1723
 
1717
1724
    def test_empty_pass(self):
1718
1725
        if self._testing_pycurl():
1737
1744
        self.readfile = StringIO(socket_read_content)
1738
1745
        self.writefile = StringIO()
1739
1746
        self.writefile.close = lambda: None
 
1747
        self.close = lambda: None
1740
1748
 
1741
1749
    def makefile(self, mode='r', bufsize=None):
1742
1750
        if 'r' in mode:
1747
1755
 
1748
1756
class SmartHTTPTunnellingTest(tests.TestCaseWithTransport):
1749
1757
 
 
1758
    scenarios = multiply_scenarios(
 
1759
        vary_by_http_client_implementation(), 
 
1760
        vary_by_http_protocol_version(),
 
1761
        )
 
1762
 
1750
1763
    def setUp(self):
1751
1764
        super(SmartHTTPTunnellingTest, self).setUp()
1752
1765
        # We use the VFS layer as part of HTTP tunnelling tests.
1753
 
        self._captureVar('BZR_NO_SMART_VFS', None)
 
1766
        self.overrideEnv('BZR_NO_SMART_VFS', None)
1754
1767
        self.transport_readonly_server = http_utils.HTTPServerWithSmarts
 
1768
        self.http_server = self.get_readonly_server()
1755
1769
 
1756
1770
    def create_transport_readonly_server(self):
1757
 
        return http_utils.HTTPServerWithSmarts(
 
1771
        server = http_utils.HTTPServerWithSmarts(
1758
1772
            protocol_version=self._protocol_version)
 
1773
        server._url_protocol = self._url_protocol
 
1774
        return server
1759
1775
 
1760
1776
    def test_open_bzrdir(self):
1761
1777
        branch = self.make_branch('relpath')
1762
 
        http_server = self.get_readonly_server()
1763
 
        url = http_server.get_url() + 'relpath'
 
1778
        url = self.http_server.get_url() + 'relpath'
1764
1779
        bd = bzrdir.BzrDir.open(url)
 
1780
        self.addCleanup(bd.transport.disconnect)
1765
1781
        self.assertIsInstance(bd, _mod_remote.RemoteBzrDir)
1766
1782
 
1767
1783
    def test_bulk_data(self):
1769
1785
        # The 'readv' command in the smart protocol both sends and receives
1770
1786
        # bulk data, so we use that.
1771
1787
        self.build_tree(['data-file'])
1772
 
        http_server = self.get_readonly_server()
1773
 
        http_transport = self._transport(http_server.get_url())
 
1788
        http_transport = transport.get_transport(self.http_server.get_url())
1774
1789
        medium = http_transport.get_smart_medium()
1775
1790
        # Since we provide the medium, the url below will be mostly ignored
1776
1791
        # during the test, as long as the path is '/'.
1784
1799
        post_body = 'hello\n'
1785
1800
        expected_reply_body = 'ok\x012\n'
1786
1801
 
1787
 
        http_server = self.get_readonly_server()
1788
 
        http_transport = self._transport(http_server.get_url())
 
1802
        http_transport = transport.get_transport(self.http_server.get_url())
1789
1803
        medium = http_transport.get_smart_medium()
1790
1804
        response = medium.send_http_smart_request(post_body)
1791
1805
        reply_body = response.read()
1792
1806
        self.assertEqual(expected_reply_body, reply_body)
1793
1807
 
1794
1808
    def test_smart_http_server_post_request_handler(self):
1795
 
        httpd = self.get_readonly_server()._get_httpd()
 
1809
        httpd = self.http_server.server
1796
1810
 
1797
1811
        socket = SampleSocket(
1798
1812
            'POST /.bzr/smart %s \r\n' % self._protocol_version
1830
1844
 
1831
1845
    def test_probe_smart_server(self):
1832
1846
        """Test error handling against server refusing smart requests."""
1833
 
        server = self.get_readonly_server()
1834
 
        t = self._transport(server.get_url())
 
1847
        t = self.get_readonly_transport()
1835
1848
        # No need to build a valid smart request here, the server will not even
1836
1849
        # try to interpret it.
1837
1850
        self.assertRaises(errors.SmartProtocolError,
1838
1851
                          t.get_smart_medium().send_http_smart_request,
1839
1852
                          'whatever')
1840
1853
 
 
1854
 
1841
1855
class Test_redirected_to(tests.TestCase):
1842
1856
 
 
1857
    scenarios = vary_by_http_client_implementation()
 
1858
 
1843
1859
    def test_redirected_to_subdir(self):
1844
1860
        t = self._transport('http://www.example.com/foo')
1845
1861
        r = t._redirected_to('http://www.example.com/foo',
1896
1912
    line.
1897
1913
    """
1898
1914
 
1899
 
    def handle_one_request(self):
 
1915
    def _handle_one_request(self):
1900
1916
        tcs = self.server.test_case_server
1901
1917
        requestline = self.rfile.readline()
1902
1918
        headers = self.MessageClass(self.rfile, 0)
1966
1982
        # We override at class level because constructors may propagate the
1967
1983
        # bound method and render instance overriding ineffective (an
1968
1984
        # alternative would be to define a specific ui factory instead...)
1969
 
        self.orig_report_activity = self._transport._report_activity
1970
 
        self._transport._report_activity = report_activity
1971
 
 
1972
 
    def tearDown(self):
1973
 
        self._transport._report_activity = self.orig_report_activity
1974
 
        self.server.stop_server()
1975
 
        tests.TestCase.tearDown(self)
 
1985
        self.overrideAttr(self._transport, '_report_activity', report_activity)
 
1986
        self.addCleanup(self.server.stop_server)
1976
1987
 
1977
1988
    def get_transport(self):
1978
 
        return self._transport(self.server.get_url())
 
1989
        t = self._transport(self.server.get_url())
 
1990
        # FIXME: Needs cleanup -- vila 20100611
 
1991
        return t
1979
1992
 
1980
1993
    def assertActivitiesMatch(self):
1981
1994
        self.assertEqual(self.server.bytes_read,
2086
2099
'''
2087
2100
        t = self.get_transport()
2088
2101
        # We must send a single line of body bytes, see
2089
 
        # PredefinedRequestHandler.handle_one_request
 
2102
        # PredefinedRequestHandler._handle_one_request
2090
2103
        code, f = t._post('abc def end-of-body\n')
2091
2104
        self.assertEqual('lalala whatever as long as itsssss\n', f.read())
2092
2105
        self.assertActivitiesMatch()
2094
2107
 
2095
2108
class TestActivity(tests.TestCase, TestActivityMixin):
2096
2109
 
 
2110
    scenarios = multiply_scenarios(
 
2111
        vary_by_http_activity(),
 
2112
        vary_by_http_protocol_version(),
 
2113
        )
 
2114
 
2097
2115
    def setUp(self):
2098
 
        tests.TestCase.setUp(self)
2099
 
        self.server = self._activity_server(self._protocol_version)
2100
 
        self.server.start_server()
2101
 
        self.activities = {}
2102
 
        def report_activity(t, bytes, direction):
2103
 
            count = self.activities.get(direction, 0)
2104
 
            count += bytes
2105
 
            self.activities[direction] = count
2106
 
 
2107
 
        # We override at class level because constructors may propagate the
2108
 
        # bound method and render instance overriding ineffective (an
2109
 
        # alternative would be to define a specific ui factory instead...)
2110
 
        self.orig_report_activity = self._transport._report_activity
2111
 
        self._transport._report_activity = report_activity
2112
 
 
2113
 
    def tearDown(self):
2114
 
        self._transport._report_activity = self.orig_report_activity
2115
 
        self.server.stop_server()
2116
 
        tests.TestCase.tearDown(self)
 
2116
        TestActivityMixin.setUp(self)
2117
2117
 
2118
2118
 
2119
2119
class TestNoReportActivity(tests.TestCase, TestActivityMixin):
2120
2120
 
 
2121
    # Unlike TestActivity, we are really testing ReportingFileSocket and
 
2122
    # ReportingSocket, so we don't need all the parametrization. Since
 
2123
    # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
 
2124
    # test them through their use by the transport than directly (that's a
 
2125
    # bit less clean but far more simpler and effective).
 
2126
    _activity_server = ActivityHTTPServer
 
2127
    _protocol_version = 'HTTP/1.1'
 
2128
 
2121
2129
    def setUp(self):
2122
 
        tests.TestCase.setUp(self)
2123
 
        # Unlike TestActivity, we are really testing ReportingFileSocket and
2124
 
        # ReportingSocket, so we don't need all the parametrization. Since
2125
 
        # ReportingFileSocket and ReportingSocket are wrappers, it's easier to
2126
 
        # test them through their use by the transport than directly (that's a
2127
 
        # bit less clean but far more simpler and effective).
2128
 
        self.server = ActivityHTTPServer('HTTP/1.1')
2129
 
        self._transport=_urllib.HttpTransport_urllib
2130
 
 
2131
 
        self.server.start_server()
2132
 
 
2133
 
        # We override at class level because constructors may propagate the
2134
 
        # bound method and render instance overriding ineffective (an
2135
 
        # alternative would be to define a specific ui factory instead...)
2136
 
        self.orig_report_activity = self._transport._report_activity
2137
 
        self._transport._report_activity = None
2138
 
 
2139
 
    def tearDown(self):
2140
 
        self._transport._report_activity = self.orig_report_activity
2141
 
        self.server.stop_server()
2142
 
        tests.TestCase.tearDown(self)
 
2130
        self._transport =_urllib.HttpTransport_urllib
 
2131
        TestActivityMixin.setUp(self)
2143
2132
 
2144
2133
    def assertActivitiesMatch(self):
2145
2134
        # Nothing to check here
2149
2138
class TestAuthOnRedirected(http_utils.TestCaseWithRedirectedWebserver):
2150
2139
    """Test authentication on the redirected http server."""
2151
2140
 
 
2141
    scenarios = vary_by_http_protocol_version()
 
2142
 
2152
2143
    _auth_header = 'Authorization'
2153
2144
    _password_prompt_prefix = ''
2154
2145
    _username_prompt_prefix = ''
2155
2146
    _auth_server = http_utils.HTTPBasicAuthServer
2156
2147
    _transport = _urllib.HttpTransport_urllib
2157
2148
 
2158
 
    def create_transport_readonly_server(self):
2159
 
        return self._auth_server()
2160
 
 
2161
 
    def create_transport_secondary_server(self):
2162
 
        """Create the secondary server redirecting to the primary server"""
2163
 
        new = self.get_readonly_server()
2164
 
 
2165
 
        redirecting = http_utils.HTTPServerRedirecting()
2166
 
        redirecting.redirect_to(new.host, new.port)
2167
 
        return redirecting
2168
 
 
2169
2149
    def setUp(self):
2170
2150
        super(TestAuthOnRedirected, self).setUp()
2171
2151
        self.build_tree_contents([('a','a'),
2176
2156
                                       self.new_server.port)
2177
2157
        self.old_server.redirections = [
2178
2158
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2179
 
        self.old_transport = self._transport(self.old_server.get_url())
 
2159
        self.old_transport = self.get_old_transport()
2180
2160
        self.new_server.add_user('joe', 'foo')
2181
 
 
2182
 
    def get_a(self, transport):
2183
 
        return transport.get('a')
 
2161
        cleanup_http_redirection_connections(self)
 
2162
 
 
2163
    def create_transport_readonly_server(self):
 
2164
        server = self._auth_server(protocol_version=self._protocol_version)
 
2165
        server._url_protocol = self._url_protocol
 
2166
        return server
 
2167
 
 
2168
    def get_a(self, t):
 
2169
        return t.get('a')
2184
2170
 
2185
2171
    def test_auth_on_redirected_via_do_catching_redirections(self):
2186
2172
        self.redirections = 0
2187
2173
 
2188
 
        def redirected(transport, exception, redirection_notice):
 
2174
        def redirected(t, exception, redirection_notice):
2189
2175
            self.redirections += 1
2190
 
            dir, file = urlutils.split(exception.target)
2191
 
            return self._transport(dir)
 
2176
            redirected_t = t._redirected_to(exception.source, exception.target)
 
2177
            self.addCleanup(redirected_t.disconnect)
 
2178
            return redirected_t
2192
2179
 
2193
2180
        stdout = tests.StringIOWrapper()
2194
2181
        stderr = tests.StringIOWrapper()
2215
2202
                                       self.new_server.port)
2216
2203
        self.old_server.redirections = [
2217
2204
            ('(.*)', r'%s/1\1' % (new_prefix), 301),]
2218
 
        self.assertEqual('redirected once',t._perform(req).read())
 
2205
        self.assertEqual('redirected once', t._perform(req).read())
2219
2206
        # stdin should be empty
2220
2207
        self.assertEqual('', ui.ui_factory.stdin.readline())
2221
2208
        # stdout should be empty, stderr will contains the prompts