/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to tools/win32/bzr.iss.cog

  • Committer: John Arbash Meinel
  • Date: 2011-04-20 14:27:19 UTC
  • mto: This revision was merged to the branch mainline in revision 5837.
  • Revision ID: john@arbash-meinel.com-20110420142719-advs1k5vztqzbrgv
https://launchpad.net/bugs/767177
Fix bug #767177. Be more agressive with file.close() calls.

Our test suite gets a number of thread leaks and failures because it happens to get async
SFTPFile.close() calls. (if an SFTPFile closes due to __del__ it is done as an async request,
while if you call SFTPFile.close() it is done as a synchronous request.)
We have a couple other cases, probably. Namely SFTPTransport.get() also does an async
prefetch of the content, so if you don't .read() you'll also leak threads that think they
are doing work that you want.

The biggest change here, though, is using a try/finally in a generator, which is not 
python2.4 compatible.

Show diffs side-by-side

added added

removed removed

Lines of Context:
tools/win32/bzr.iss.cog
71
71
 
72
72
AppComments="Bazaar: Friendly distributed version control system"
73
73
AppPublisher="Canonical Ltd."
74
 
AppPublisherURL="http://www.bazaar-vcs.org"
75
 
AppSupportURL="http://www.bazaar-vcs.org/BzrSupport"
76
 
AppUpdatesURL="http://www.bazaar-vcs.org/WindowsDownloads"
 
74
AppPublisherURL="http://bazaar.canonical.com"
 
75
AppSupportURL="http://wiki.bazaar.canonical.com/BzrSupport"
 
76
AppUpdatesURL="http://wiki.bazaar.canonical.com/WindowsDownloads"
77
77
; [[[cog cog.outl('AppVersion=%s' % VERSION) ]]]
78
78
; [[[end]]]
79
79
 
177
177
 
178
178
[Icons]
179
179
Name: "{group}\Documentation index"; Filename: "{app}\doc\index.html"; WorkingDir: "{app}\doc";
180
 
Name: "{group}\Bazaar Home Page"; Filename: "{app}\bazaar.url"; Comment: "http://www.bazaar-vcs.org";
 
180
Name: "{group}\Bazaar Home Page"; Filename: "{app}\bazaar.url"; Comment: "http://bazaar.canonical.com";
181
181
Name: "{group}\Start Bzr in cmd shell"; Filename: "{cmd}"; Parameters: "/K start_bzr.bat"; WorkingDir: "{app}"; IconFilename: "{app}\bzr.exe"; Comment: "Open new Bzr session";
182
182
; NOTE: Intent is to change the log file location - the line below will need to change to reflect that.
183
183
Name: "{group}\Open Bzr log file"; Filename: "notepad.exe"; Parameters: "{userdocs}\.bzr.log"; Comment: "Launch notepad to view the bzr log file";