/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/smart/client.py

  • Committer: Martin von Gagern
  • Date: 2011-05-27 12:01:22 UTC
  • mto: (5939.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 5940.
  • Revision ID: martin.vgagern@gmx.net-20110527120122-7f2yvh17wrech14v
https://launchpad.net/bugs/421776
Use move instead of rename when adding packs to repository.

A rename might fail (e.g. on sftp) if the target file does exist. This is
because rename is guaranteed to be atomic.  The move operation, on the other
hand, does guarantee deletion of any existing target if possible, so it is
more appropriate here, where we are not dealing with locks but with content
files.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/smart/client.py
194
194
class SmartClientHooks(hooks.Hooks):
195
195
 
196
196
    def __init__(self):
197
 
        hooks.Hooks.__init__(self)
198
 
        self.create_hook(hooks.HookPoint('call',
 
197
        hooks.Hooks.__init__(self, "bzrlib.smart.client", "_SmartClient.hooks")
 
198
        self.add_hook('call',
199
199
            "Called when the smart client is submitting a request to the "
200
200
            "smart server. Called with a bzrlib.smart.client.CallHookParams "
201
201
            "object. Streaming request bodies, and responses, are not "
202
 
            "accessible.", None, None))
 
202
            "accessible.", None)
203
203
 
204
204
 
205
205
_SmartClient.hooks = SmartClientHooks()