/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_config.py

  • Committer: Jelmer Vernooij
  • Date: 2011-12-24 12:51:20 UTC
  • mto: This revision was merged to the branch mainline in revision 6408.
  • Revision ID: jelmer@samba.org-20111224125120-0cyozj3fb7loj81b
Some documentation.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
19
19
from cStringIO import StringIO
20
20
import os
21
21
import sys
 
22
import threading
 
23
 
 
24
 
 
25
from testtools import matchers
22
26
 
23
27
#import bzrlib specific imports here
24
28
from bzrlib import (
31
35
    mail_client,
32
36
    ui,
33
37
    urlutils,
 
38
    remote,
34
39
    tests,
35
40
    trace,
36
 
    transport,
 
41
    )
 
42
from bzrlib.symbol_versioning import (
 
43
    deprecated_in,
 
44
    )
 
45
from bzrlib.transport import remote as transport_remote
 
46
from bzrlib.tests import (
 
47
    features,
 
48
    scenarios,
 
49
    test_server,
37
50
    )
38
51
from bzrlib.util.configobj import configobj
39
52
 
40
53
 
 
54
def lockable_config_scenarios():
 
55
    return [
 
56
        ('global',
 
57
         {'config_class': config.GlobalConfig,
 
58
          'config_args': [],
 
59
          'config_section': 'DEFAULT'}),
 
60
        ('locations',
 
61
         {'config_class': config.LocationConfig,
 
62
          'config_args': ['.'],
 
63
          'config_section': '.'}),]
 
64
 
 
65
 
 
66
load_tests = scenarios.load_tests_apply_scenarios
 
67
 
 
68
# Register helpers to build stores
 
69
config.test_store_builder_registry.register(
 
70
    'configobj', lambda test: config.TransportIniFileStore(
 
71
        test.get_transport(), 'configobj.conf'))
 
72
config.test_store_builder_registry.register(
 
73
    'bazaar', lambda test: config.GlobalStore())
 
74
config.test_store_builder_registry.register(
 
75
    'location', lambda test: config.LocationStore())
 
76
 
 
77
 
 
78
def build_backing_branch(test, relpath,
 
79
                         transport_class=None, server_class=None):
 
80
    """Test helper to create a backing branch only once.
 
81
 
 
82
    Some tests needs multiple stores/stacks to check concurrent update
 
83
    behaviours. As such, they need to build different branch *objects* even if
 
84
    they share the branch on disk.
 
85
 
 
86
    :param relpath: The relative path to the branch. (Note that the helper
 
87
        should always specify the same relpath).
 
88
 
 
89
    :param transport_class: The Transport class the test needs to use.
 
90
 
 
91
    :param server_class: The server associated with the ``transport_class``
 
92
        above.
 
93
 
 
94
    Either both or neither of ``transport_class`` and ``server_class`` should
 
95
    be specified.
 
96
    """
 
97
    if transport_class is not None and server_class is not None:
 
98
        test.transport_class = transport_class
 
99
        test.transport_server = server_class
 
100
    elif not (transport_class is None and server_class is None):
 
101
        raise AssertionError('Specify both ``transport_class`` and '
 
102
                             '``server_class`` or neither of them')
 
103
    if getattr(test, 'backing_branch', None) is None:
 
104
        # First call, let's build the branch on disk
 
105
        test.backing_branch = test.make_branch(relpath)
 
106
 
 
107
 
 
108
def build_branch_store(test):
 
109
    build_backing_branch(test, 'branch')
 
110
    b = branch.Branch.open('branch')
 
111
    return config.BranchStore(b)
 
112
config.test_store_builder_registry.register('branch', build_branch_store)
 
113
 
 
114
 
 
115
def build_control_store(test):
 
116
    build_backing_branch(test, 'branch')
 
117
    b = bzrdir.BzrDir.open('branch')
 
118
    return config.ControlStore(b)
 
119
config.test_store_builder_registry.register('control', build_control_store)
 
120
 
 
121
 
 
122
def build_remote_branch_store(test):
 
123
    # There is only one permutation (but we won't be able to handle more with
 
124
    # this design anyway)
 
125
    (transport_class,
 
126
     server_class) = transport_remote.get_test_permutations()[0]
 
127
    build_backing_branch(test, 'branch', transport_class, server_class)
 
128
    b = branch.Branch.open(test.get_url('branch'))
 
129
    return config.BranchStore(b)
 
130
config.test_store_builder_registry.register('remote_branch',
 
131
                                            build_remote_branch_store)
 
132
 
 
133
 
 
134
config.test_stack_builder_registry.register(
 
135
    'bazaar', lambda test: config.GlobalStack())
 
136
config.test_stack_builder_registry.register(
 
137
    'location', lambda test: config.LocationStack('.'))
 
138
 
 
139
 
 
140
def build_branch_stack(test):
 
141
    build_backing_branch(test, 'branch')
 
142
    b = branch.Branch.open('branch')
 
143
    return config.BranchStack(b)
 
144
config.test_stack_builder_registry.register('branch', build_branch_stack)
 
145
 
 
146
 
 
147
def build_remote_branch_stack(test):
 
148
    # There is only one permutation (but we won't be able to handle more with
 
149
    # this design anyway)
 
150
    (transport_class,
 
151
     server_class) = transport_remote.get_test_permutations()[0]
 
152
    build_backing_branch(test, 'branch', transport_class, server_class)
 
153
    b = branch.Branch.open(test.get_url('branch'))
 
154
    return config.RemoteBranchStack(b)
 
155
config.test_stack_builder_registry.register('remote_branch',
 
156
                                            build_remote_branch_stack)
 
157
 
 
158
def build_remote_control_stack(test):
 
159
    # There is only one permutation (but we won't be able to handle more with
 
160
    # this design anyway)
 
161
    (transport_class,
 
162
     server_class) = transport_remote.get_test_permutations()[0]
 
163
    # We need only a bzrdir for this, not a full branch, but it's not worth
 
164
    # creating a dedicated helper to create only the bzrdir
 
165
    build_backing_branch(test, 'branch', transport_class, server_class)
 
166
    b = branch.Branch.open(test.get_url('branch'))
 
167
    return config.RemoteControlStack(b.bzrdir)
 
168
config.test_stack_builder_registry.register('remote_control',
 
169
                                            build_remote_control_stack)
 
170
 
 
171
 
41
172
sample_long_alias="log -r-15..-1 --line"
42
173
sample_config_text = u"""
43
174
[DEFAULT]
45
176
editor=vim
46
177
change_editor=vimdiff -of @new_path @old_path
47
178
gpg_signing_command=gnome-gpg
 
179
gpg_signing_key=DD4D5088
48
180
log_format=short
 
181
validate_signatures_in_log=true
 
182
acceptable_keys=amy
49
183
user_global_option=something
 
184
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
 
185
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
 
186
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
 
187
bzr.default_mergetool=sometool
50
188
[ALIASES]
51
189
h=help
52
190
ll=""" + sample_long_alias + "\n"
94
232
[/a/]
95
233
check_signatures=check-available
96
234
gpg_signing_command=false
 
235
gpg_signing_key=default
97
236
user_local_option=local
98
237
# test trailing / matching
99
238
[/a/*]
105
244
"""
106
245
 
107
246
 
 
247
def create_configs(test):
 
248
    """Create configuration files for a given test.
 
249
 
 
250
    This requires creating a tree (and populate the ``test.tree`` attribute)
 
251
    and its associated branch and will populate the following attributes:
 
252
 
 
253
    - branch_config: A BranchConfig for the associated branch.
 
254
 
 
255
    - locations_config : A LocationConfig for the associated branch
 
256
 
 
257
    - bazaar_config: A GlobalConfig.
 
258
 
 
259
    The tree and branch are created in a 'tree' subdirectory so the tests can
 
260
    still use the test directory to stay outside of the branch.
 
261
    """
 
262
    tree = test.make_branch_and_tree('tree')
 
263
    test.tree = tree
 
264
    test.branch_config = config.BranchConfig(tree.branch)
 
265
    test.locations_config = config.LocationConfig(tree.basedir)
 
266
    test.bazaar_config = config.GlobalConfig()
 
267
 
 
268
 
 
269
def create_configs_with_file_option(test):
 
270
    """Create configuration files with a ``file`` option set in each.
 
271
 
 
272
    This builds on ``create_configs`` and add one ``file`` option in each
 
273
    configuration with a value which allows identifying the configuration file.
 
274
    """
 
275
    create_configs(test)
 
276
    test.bazaar_config.set_user_option('file', 'bazaar')
 
277
    test.locations_config.set_user_option('file', 'locations')
 
278
    test.branch_config.set_user_option('file', 'branch')
 
279
 
 
280
 
 
281
class TestOptionsMixin:
 
282
 
 
283
    def assertOptions(self, expected, conf):
 
284
        # We don't care about the parser (as it will make tests hard to write
 
285
        # and error-prone anyway)
 
286
        self.assertThat([opt[:4] for opt in conf._get_options()],
 
287
                        matchers.Equals(expected))
 
288
 
 
289
 
108
290
class InstrumentedConfigObj(object):
109
291
    """A config obj look-enough-alike to record calls made to it."""
110
292
 
129
311
        self._calls.append(('keys',))
130
312
        return []
131
313
 
 
314
    def reload(self):
 
315
        self._calls.append(('reload',))
 
316
 
132
317
    def write(self, arg):
133
318
        self._calls.append(('write',))
134
319
 
143
328
 
144
329
class FakeBranch(object):
145
330
 
146
 
    def __init__(self, base=None, user_id=None):
 
331
    def __init__(self, base=None):
147
332
        if base is None:
148
333
            self.base = "http://example.com/branches/demo"
149
334
        else:
150
335
            self.base = base
151
336
        self._transport = self.control_files = \
152
 
            FakeControlFilesAndTransport(user_id=user_id)
 
337
            FakeControlFilesAndTransport()
153
338
 
154
339
    def _get_config(self):
155
340
        return config.TransportConfig(self._transport, 'branch.conf')
163
348
 
164
349
class FakeControlFilesAndTransport(object):
165
350
 
166
 
    def __init__(self, user_id=None):
 
351
    def __init__(self):
167
352
        self.files = {}
168
 
        if user_id:
169
 
            self.files['email'] = user_id
170
353
        self._transport = self
171
354
 
172
 
    def get_utf8(self, filename):
173
 
        # from LockableFiles
174
 
        raise AssertionError("get_utf8 should no longer be used")
175
 
 
176
355
    def get(self, filename):
177
356
        # from Transport
178
357
        try:
240
419
        """
241
420
        co = config.ConfigObj()
242
421
        co['test'] = 'foo#bar'
243
 
        lines = co.write()
 
422
        outfile = StringIO()
 
423
        co.write(outfile=outfile)
 
424
        lines = outfile.getvalue().splitlines()
244
425
        self.assertEqual(lines, ['test = "foo#bar"'])
245
426
        co2 = config.ConfigObj(lines)
246
427
        self.assertEqual(co2['test'], 'foo#bar')
247
428
 
 
429
    def test_triple_quotes(self):
 
430
        # Bug #710410: if the value string has triple quotes
 
431
        # then ConfigObj versions up to 4.7.2 will quote them wrong
 
432
        # and won't able to read them back
 
433
        triple_quotes_value = '''spam
 
434
""" that's my spam """
 
435
eggs'''
 
436
        co = config.ConfigObj()
 
437
        co['test'] = triple_quotes_value
 
438
        # While writing this test another bug in ConfigObj has been found:
 
439
        # method co.write() without arguments produces list of lines
 
440
        # one option per line, and multiline values are not split
 
441
        # across multiple lines,
 
442
        # and that breaks the parsing these lines back by ConfigObj.
 
443
        # This issue only affects test, but it's better to avoid
 
444
        # `co.write()` construct at all.
 
445
        # [bialix 20110222] bug report sent to ConfigObj's author
 
446
        outfile = StringIO()
 
447
        co.write(outfile=outfile)
 
448
        output = outfile.getvalue()
 
449
        # now we're trying to read it back
 
450
        co2 = config.ConfigObj(StringIO(output))
 
451
        self.assertEquals(triple_quotes_value, co2['test'])
 
452
 
248
453
 
249
454
erroneous_config = """[section] # line 1
250
455
good=good # line 2
271
476
        config.Config()
272
477
 
273
478
    def test_no_default_editor(self):
274
 
        self.assertRaises(NotImplementedError, config.Config().get_editor)
 
479
        self.assertRaises(
 
480
            NotImplementedError,
 
481
            self.applyDeprecated, deprecated_in((2, 4, 0)),
 
482
            config.Config().get_editor)
275
483
 
276
484
    def test_user_email(self):
277
485
        my_config = InstrumentedConfig()
286
494
 
287
495
    def test_signatures_default(self):
288
496
        my_config = config.Config()
289
 
        self.assertFalse(my_config.signature_needed())
 
497
        self.assertFalse(
 
498
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
499
                my_config.signature_needed))
290
500
        self.assertEqual(config.CHECK_IF_POSSIBLE,
291
 
                         my_config.signature_checking())
 
501
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
502
                my_config.signature_checking))
292
503
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
293
 
                         my_config.signing_policy())
 
504
                self.applyDeprecated(deprecated_in((2, 5, 0)),
 
505
                    my_config.signing_policy))
294
506
 
295
507
    def test_signatures_template_method(self):
296
508
        my_config = InstrumentedConfig()
297
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
 
509
        self.assertEqual(config.CHECK_NEVER,
 
510
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
511
                my_config.signature_checking))
298
512
        self.assertEqual(['_get_signature_checking'], my_config._calls)
299
513
 
300
514
    def test_signatures_template_method_none(self):
301
515
        my_config = InstrumentedConfig()
302
516
        my_config._signatures = None
303
517
        self.assertEqual(config.CHECK_IF_POSSIBLE,
304
 
                         my_config.signature_checking())
 
518
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
519
                             my_config.signature_checking))
305
520
        self.assertEqual(['_get_signature_checking'], my_config._calls)
306
521
 
307
522
    def test_gpg_signing_command_default(self):
308
523
        my_config = config.Config()
309
 
        self.assertEqual('gpg', my_config.gpg_signing_command())
 
524
        self.assertEqual('gpg',
 
525
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
526
                my_config.gpg_signing_command))
310
527
 
311
528
    def test_get_user_option_default(self):
312
529
        my_config = config.Config()
314
531
 
315
532
    def test_post_commit_default(self):
316
533
        my_config = config.Config()
317
 
        self.assertEqual(None, my_config.post_commit())
 
534
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
535
                                                    my_config.post_commit))
 
536
 
318
537
 
319
538
    def test_log_format_default(self):
320
539
        my_config = config.Config()
321
 
        self.assertEqual('long', my_config.log_format())
 
540
        self.assertEqual('long',
 
541
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
542
                                              my_config.log_format))
 
543
 
 
544
    def test_acceptable_keys_default(self):
 
545
        my_config = config.Config()
 
546
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
547
            my_config.acceptable_keys))
 
548
 
 
549
    def test_validate_signatures_in_log_default(self):
 
550
        my_config = config.Config()
 
551
        self.assertEqual(False, my_config.validate_signatures_in_log())
322
552
 
323
553
    def test_get_change_editor(self):
324
554
        my_config = InstrumentedConfig()
333
563
 
334
564
    def setUp(self):
335
565
        super(TestConfigPath, self).setUp()
336
 
        os.environ['HOME'] = '/home/bogus'
337
 
        os.environ['XDG_CACHE_DIR'] = ''
 
566
        self.overrideEnv('HOME', '/home/bogus')
 
567
        self.overrideEnv('XDG_CACHE_DIR', '')
338
568
        if sys.platform == 'win32':
339
 
            os.environ['BZR_HOME'] = \
340
 
                r'C:\Documents and Settings\bogus\Application Data'
 
569
            self.overrideEnv(
 
570
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
341
571
            self.bzr_home = \
342
572
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
343
573
        else:
350
580
        self.assertEqual(config.config_filename(),
351
581
                         self.bzr_home + '/bazaar.conf')
352
582
 
353
 
    def test_branches_config_filename(self):
354
 
        self.assertEqual(config.branches_config_filename(),
355
 
                         self.bzr_home + '/branches.conf')
356
 
 
357
583
    def test_locations_config_filename(self):
358
584
        self.assertEqual(config.locations_config_filename(),
359
585
                         self.bzr_home + '/locations.conf')
367
593
            '/home/bogus/.cache')
368
594
 
369
595
 
370
 
class TestIniConfig(tests.TestCase):
 
596
class TestXDGConfigDir(tests.TestCaseInTempDir):
 
597
    # must be in temp dir because config tests for the existence of the bazaar
 
598
    # subdirectory of $XDG_CONFIG_HOME
 
599
 
 
600
    def setUp(self):
 
601
        if sys.platform in ('darwin', 'win32'):
 
602
            raise tests.TestNotApplicable(
 
603
                'XDG config dir not used on this platform')
 
604
        super(TestXDGConfigDir, self).setUp()
 
605
        self.overrideEnv('HOME', self.test_home_dir)
 
606
        # BZR_HOME overrides everything we want to test so unset it.
 
607
        self.overrideEnv('BZR_HOME', None)
 
608
 
 
609
    def test_xdg_config_dir_exists(self):
 
610
        """When ~/.config/bazaar exists, use it as the config dir."""
 
611
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
 
612
        os.makedirs(newdir)
 
613
        self.assertEqual(config.config_dir(), newdir)
 
614
 
 
615
    def test_xdg_config_home(self):
 
616
        """When XDG_CONFIG_HOME is set, use it."""
 
617
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
 
618
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
 
619
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
 
620
        os.makedirs(newdir)
 
621
        self.assertEqual(config.config_dir(), newdir)
 
622
 
 
623
 
 
624
class TestIniConfig(tests.TestCaseInTempDir):
371
625
 
372
626
    def make_config_parser(self, s):
373
 
        conf = config.IniBasedConfig(None)
374
 
        parser = conf._get_parser(file=StringIO(s.encode('utf-8')))
375
 
        return conf, parser
 
627
        conf = config.IniBasedConfig.from_string(s)
 
628
        return conf, conf._get_parser()
376
629
 
377
630
 
378
631
class TestIniConfigBuilding(TestIniConfig):
379
632
 
380
633
    def test_contructs(self):
381
 
        my_config = config.IniBasedConfig("nothing")
 
634
        my_config = config.IniBasedConfig()
382
635
 
383
636
    def test_from_fp(self):
384
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
385
 
        my_config = config.IniBasedConfig(None)
386
 
        self.failUnless(
387
 
            isinstance(my_config._get_parser(file=config_file),
388
 
                        configobj.ConfigObj))
 
637
        my_config = config.IniBasedConfig.from_string(sample_config_text)
 
638
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
389
639
 
390
640
    def test_cached(self):
 
641
        my_config = config.IniBasedConfig.from_string(sample_config_text)
 
642
        parser = my_config._get_parser()
 
643
        self.assertTrue(my_config._get_parser() is parser)
 
644
 
 
645
    def _dummy_chown(self, path, uid, gid):
 
646
        self.path, self.uid, self.gid = path, uid, gid
 
647
 
 
648
    def test_ini_config_ownership(self):
 
649
        """Ensure that chown is happening during _write_config_file"""
 
650
        self.requireFeature(features.chown_feature)
 
651
        self.overrideAttr(os, 'chown', self._dummy_chown)
 
652
        self.path = self.uid = self.gid = None
 
653
        conf = config.IniBasedConfig(file_name='./foo.conf')
 
654
        conf._write_config_file()
 
655
        self.assertEquals(self.path, './foo.conf')
 
656
        self.assertTrue(isinstance(self.uid, int))
 
657
        self.assertTrue(isinstance(self.gid, int))
 
658
 
 
659
    def test_get_filename_parameter_is_deprecated_(self):
 
660
        conf = self.callDeprecated([
 
661
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
 
662
            ' Use file_name instead.'],
 
663
            config.IniBasedConfig, lambda: 'ini.conf')
 
664
        self.assertEqual('ini.conf', conf.file_name)
 
665
 
 
666
    def test_get_parser_file_parameter_is_deprecated_(self):
391
667
        config_file = StringIO(sample_config_text.encode('utf-8'))
392
 
        my_config = config.IniBasedConfig(None)
393
 
        parser = my_config._get_parser(file=config_file)
394
 
        self.failUnless(my_config._get_parser() is parser)
 
668
        conf = config.IniBasedConfig.from_string(sample_config_text)
 
669
        conf = self.callDeprecated([
 
670
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
 
671
            ' Use IniBasedConfig(_content=xxx) instead.'],
 
672
            conf._get_parser, file=config_file)
 
673
 
 
674
 
 
675
class TestIniConfigSaving(tests.TestCaseInTempDir):
 
676
 
 
677
    def test_cant_save_without_a_file_name(self):
 
678
        conf = config.IniBasedConfig()
 
679
        self.assertRaises(AssertionError, conf._write_config_file)
 
680
 
 
681
    def test_saved_with_content(self):
 
682
        content = 'foo = bar\n'
 
683
        conf = config.IniBasedConfig.from_string(
 
684
            content, file_name='./test.conf', save=True)
 
685
        self.assertFileEqual(content, 'test.conf')
 
686
 
 
687
 
 
688
class TestIniConfigOptionExpansionDefaultValue(tests.TestCaseInTempDir):
 
689
    """What is the default value of expand for config options.
 
690
 
 
691
    This is an opt-in beta feature used to evaluate whether or not option
 
692
    references can appear in dangerous place raising exceptions, disapearing
 
693
    (and as such corrupting data) or if it's safe to activate the option by
 
694
    default.
 
695
 
 
696
    Note that these tests relies on config._expand_default_value being already
 
697
    overwritten in the parent class setUp.
 
698
    """
 
699
 
 
700
    def setUp(self):
 
701
        super(TestIniConfigOptionExpansionDefaultValue, self).setUp()
 
702
        self.config = None
 
703
        self.warnings = []
 
704
        def warning(*args):
 
705
            self.warnings.append(args[0] % args[1:])
 
706
        self.overrideAttr(trace, 'warning', warning)
 
707
 
 
708
    def get_config(self, expand):
 
709
        c = config.GlobalConfig.from_string('bzr.config.expand=%s' % (expand,),
 
710
                                            save=True)
 
711
        return c
 
712
 
 
713
    def assertExpandIs(self, expected):
 
714
        actual = config._get_expand_default_value()
 
715
        #self.config.get_user_option_as_bool('bzr.config.expand')
 
716
        self.assertEquals(expected, actual)
 
717
 
 
718
    def test_default_is_None(self):
 
719
        self.assertEquals(None, config._expand_default_value)
 
720
 
 
721
    def test_default_is_False_even_if_None(self):
 
722
        self.config = self.get_config(None)
 
723
        self.assertExpandIs(False)
 
724
 
 
725
    def test_default_is_False_even_if_invalid(self):
 
726
        self.config = self.get_config('<your choice>')
 
727
        self.assertExpandIs(False)
 
728
        # ...
 
729
        # Huh ? My choice is False ? Thanks, always happy to hear that :D
 
730
        # Wait, you've been warned !
 
731
        self.assertLength(1, self.warnings)
 
732
        self.assertEquals(
 
733
            'Value "<your choice>" is not a boolean for "bzr.config.expand"',
 
734
            self.warnings[0])
 
735
 
 
736
    def test_default_is_True(self):
 
737
        self.config = self.get_config(True)
 
738
        self.assertExpandIs(True)
 
739
 
 
740
    def test_default_is_False(self):
 
741
        self.config = self.get_config(False)
 
742
        self.assertExpandIs(False)
 
743
 
 
744
 
 
745
class TestIniConfigOptionExpansion(tests.TestCase):
 
746
    """Test option expansion from the IniConfig level.
 
747
 
 
748
    What we really want here is to test the Config level, but the class being
 
749
    abstract as far as storing values is concerned, this can't be done
 
750
    properly (yet).
 
751
    """
 
752
    # FIXME: This should be rewritten when all configs share a storage
 
753
    # implementation -- vila 2011-02-18
 
754
 
 
755
    def get_config(self, string=None):
 
756
        if string is None:
 
757
            string = ''
 
758
        c = config.IniBasedConfig.from_string(string)
 
759
        return c
 
760
 
 
761
    def assertExpansion(self, expected, conf, string, env=None):
 
762
        self.assertEquals(expected, conf.expand_options(string, env))
 
763
 
 
764
    def test_no_expansion(self):
 
765
        c = self.get_config('')
 
766
        self.assertExpansion('foo', c, 'foo')
 
767
 
 
768
    def test_env_adding_options(self):
 
769
        c = self.get_config('')
 
770
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
771
 
 
772
    def test_env_overriding_options(self):
 
773
        c = self.get_config('foo=baz')
 
774
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
775
 
 
776
    def test_simple_ref(self):
 
777
        c = self.get_config('foo=xxx')
 
778
        self.assertExpansion('xxx', c, '{foo}')
 
779
 
 
780
    def test_unknown_ref(self):
 
781
        c = self.get_config('')
 
782
        self.assertRaises(errors.ExpandingUnknownOption,
 
783
                          c.expand_options, '{foo}')
 
784
 
 
785
    def test_indirect_ref(self):
 
786
        c = self.get_config('''
 
787
foo=xxx
 
788
bar={foo}
 
789
''')
 
790
        self.assertExpansion('xxx', c, '{bar}')
 
791
 
 
792
    def test_embedded_ref(self):
 
793
        c = self.get_config('''
 
794
foo=xxx
 
795
bar=foo
 
796
''')
 
797
        self.assertExpansion('xxx', c, '{{bar}}')
 
798
 
 
799
    def test_simple_loop(self):
 
800
        c = self.get_config('foo={foo}')
 
801
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
 
802
 
 
803
    def test_indirect_loop(self):
 
804
        c = self.get_config('''
 
805
foo={bar}
 
806
bar={baz}
 
807
baz={foo}''')
 
808
        e = self.assertRaises(errors.OptionExpansionLoop,
 
809
                              c.expand_options, '{foo}')
 
810
        self.assertEquals('foo->bar->baz', e.refs)
 
811
        self.assertEquals('{foo}', e.string)
 
812
 
 
813
    def test_list(self):
 
814
        conf = self.get_config('''
 
815
foo=start
 
816
bar=middle
 
817
baz=end
 
818
list={foo},{bar},{baz}
 
819
''')
 
820
        self.assertEquals(['start', 'middle', 'end'],
 
821
                           conf.get_user_option('list', expand=True))
 
822
 
 
823
    def test_cascading_list(self):
 
824
        conf = self.get_config('''
 
825
foo=start,{bar}
 
826
bar=middle,{baz}
 
827
baz=end
 
828
list={foo}
 
829
''')
 
830
        self.assertEquals(['start', 'middle', 'end'],
 
831
                           conf.get_user_option('list', expand=True))
 
832
 
 
833
    def test_pathological_hidden_list(self):
 
834
        conf = self.get_config('''
 
835
foo=bin
 
836
bar=go
 
837
start={foo
 
838
middle=},{
 
839
end=bar}
 
840
hidden={start}{middle}{end}
 
841
''')
 
842
        # Nope, it's either a string or a list, and the list wins as soon as a
 
843
        # ',' appears, so the string concatenation never occur.
 
844
        self.assertEquals(['{foo', '}', '{', 'bar}'],
 
845
                          conf.get_user_option('hidden', expand=True))
 
846
 
 
847
 
 
848
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
 
849
 
 
850
    def get_config(self, location, string=None):
 
851
        if string is None:
 
852
            string = ''
 
853
        # Since we don't save the config we won't strictly require to inherit
 
854
        # from TestCaseInTempDir, but an error occurs so quickly...
 
855
        c = config.LocationConfig.from_string(string, location)
 
856
        return c
 
857
 
 
858
    def test_dont_cross_unrelated_section(self):
 
859
        c = self.get_config('/another/branch/path','''
 
860
[/one/branch/path]
 
861
foo = hello
 
862
bar = {foo}/2
 
863
 
 
864
[/another/branch/path]
 
865
bar = {foo}/2
 
866
''')
 
867
        self.assertRaises(errors.ExpandingUnknownOption,
 
868
                          c.get_user_option, 'bar', expand=True)
 
869
 
 
870
    def test_cross_related_sections(self):
 
871
        c = self.get_config('/project/branch/path','''
 
872
[/project]
 
873
foo = qu
 
874
 
 
875
[/project/branch/path]
 
876
bar = {foo}ux
 
877
''')
 
878
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
 
879
 
 
880
 
 
881
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
 
882
 
 
883
    def test_cannot_reload_without_name(self):
 
884
        conf = config.IniBasedConfig.from_string(sample_config_text)
 
885
        self.assertRaises(AssertionError, conf.reload)
 
886
 
 
887
    def test_reload_see_new_value(self):
 
888
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
 
889
                                               file_name='./test/conf')
 
890
        c1._write_config_file()
 
891
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
 
892
                                               file_name='./test/conf')
 
893
        c2._write_config_file()
 
894
        self.assertEqual('vim', c1.get_user_option('editor'))
 
895
        self.assertEqual('emacs', c2.get_user_option('editor'))
 
896
        # Make sure we get the Right value
 
897
        c1.reload()
 
898
        self.assertEqual('emacs', c1.get_user_option('editor'))
 
899
 
 
900
 
 
901
class TestLockableConfig(tests.TestCaseInTempDir):
 
902
 
 
903
    scenarios = lockable_config_scenarios()
 
904
 
 
905
    # Set by load_tests
 
906
    config_class = None
 
907
    config_args = None
 
908
    config_section = None
 
909
 
 
910
    def setUp(self):
 
911
        super(TestLockableConfig, self).setUp()
 
912
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
 
913
        self.config = self.create_config(self._content)
 
914
 
 
915
    def get_existing_config(self):
 
916
        return self.config_class(*self.config_args)
 
917
 
 
918
    def create_config(self, content):
 
919
        kwargs = dict(save=True)
 
920
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
 
921
        return c
 
922
 
 
923
    def test_simple_read_access(self):
 
924
        self.assertEquals('1', self.config.get_user_option('one'))
 
925
 
 
926
    def test_simple_write_access(self):
 
927
        self.config.set_user_option('one', 'one')
 
928
        self.assertEquals('one', self.config.get_user_option('one'))
 
929
 
 
930
    def test_listen_to_the_last_speaker(self):
 
931
        c1 = self.config
 
932
        c2 = self.get_existing_config()
 
933
        c1.set_user_option('one', 'ONE')
 
934
        c2.set_user_option('two', 'TWO')
 
935
        self.assertEquals('ONE', c1.get_user_option('one'))
 
936
        self.assertEquals('TWO', c2.get_user_option('two'))
 
937
        # The second update respect the first one
 
938
        self.assertEquals('ONE', c2.get_user_option('one'))
 
939
 
 
940
    def test_last_speaker_wins(self):
 
941
        # If the same config is not shared, the same variable modified twice
 
942
        # can only see a single result.
 
943
        c1 = self.config
 
944
        c2 = self.get_existing_config()
 
945
        c1.set_user_option('one', 'c1')
 
946
        c2.set_user_option('one', 'c2')
 
947
        self.assertEquals('c2', c2._get_user_option('one'))
 
948
        # The first modification is still available until another refresh
 
949
        # occur
 
950
        self.assertEquals('c1', c1._get_user_option('one'))
 
951
        c1.set_user_option('two', 'done')
 
952
        self.assertEquals('c2', c1._get_user_option('one'))
 
953
 
 
954
    def test_writes_are_serialized(self):
 
955
        c1 = self.config
 
956
        c2 = self.get_existing_config()
 
957
 
 
958
        # We spawn a thread that will pause *during* the write
 
959
        before_writing = threading.Event()
 
960
        after_writing = threading.Event()
 
961
        writing_done = threading.Event()
 
962
        c1_orig = c1._write_config_file
 
963
        def c1_write_config_file():
 
964
            before_writing.set()
 
965
            c1_orig()
 
966
            # The lock is held. We wait for the main thread to decide when to
 
967
            # continue
 
968
            after_writing.wait()
 
969
        c1._write_config_file = c1_write_config_file
 
970
        def c1_set_option():
 
971
            c1.set_user_option('one', 'c1')
 
972
            writing_done.set()
 
973
        t1 = threading.Thread(target=c1_set_option)
 
974
        # Collect the thread after the test
 
975
        self.addCleanup(t1.join)
 
976
        # Be ready to unblock the thread if the test goes wrong
 
977
        self.addCleanup(after_writing.set)
 
978
        t1.start()
 
979
        before_writing.wait()
 
980
        self.assertTrue(c1._lock.is_held)
 
981
        self.assertRaises(errors.LockContention,
 
982
                          c2.set_user_option, 'one', 'c2')
 
983
        self.assertEquals('c1', c1.get_user_option('one'))
 
984
        # Let the lock be released
 
985
        after_writing.set()
 
986
        writing_done.wait()
 
987
        c2.set_user_option('one', 'c2')
 
988
        self.assertEquals('c2', c2.get_user_option('one'))
 
989
 
 
990
    def test_read_while_writing(self):
 
991
       c1 = self.config
 
992
       # We spawn a thread that will pause *during* the write
 
993
       ready_to_write = threading.Event()
 
994
       do_writing = threading.Event()
 
995
       writing_done = threading.Event()
 
996
       c1_orig = c1._write_config_file
 
997
       def c1_write_config_file():
 
998
           ready_to_write.set()
 
999
           # The lock is held. We wait for the main thread to decide when to
 
1000
           # continue
 
1001
           do_writing.wait()
 
1002
           c1_orig()
 
1003
           writing_done.set()
 
1004
       c1._write_config_file = c1_write_config_file
 
1005
       def c1_set_option():
 
1006
           c1.set_user_option('one', 'c1')
 
1007
       t1 = threading.Thread(target=c1_set_option)
 
1008
       # Collect the thread after the test
 
1009
       self.addCleanup(t1.join)
 
1010
       # Be ready to unblock the thread if the test goes wrong
 
1011
       self.addCleanup(do_writing.set)
 
1012
       t1.start()
 
1013
       # Ensure the thread is ready to write
 
1014
       ready_to_write.wait()
 
1015
       self.assertTrue(c1._lock.is_held)
 
1016
       self.assertEquals('c1', c1.get_user_option('one'))
 
1017
       # If we read during the write, we get the old value
 
1018
       c2 = self.get_existing_config()
 
1019
       self.assertEquals('1', c2.get_user_option('one'))
 
1020
       # Let the writing occur and ensure it occurred
 
1021
       do_writing.set()
 
1022
       writing_done.wait()
 
1023
       # Now we get the updated value
 
1024
       c3 = self.get_existing_config()
 
1025
       self.assertEquals('c1', c3.get_user_option('one'))
395
1026
 
396
1027
 
397
1028
class TestGetUserOptionAs(TestIniConfig):
430
1061
        # automatically cast to list
431
1062
        self.assertEqual(['x'], get_list('one_item'))
432
1063
 
 
1064
    def test_get_user_option_as_int_from_SI(self):
 
1065
        conf, parser = self.make_config_parser("""
 
1066
plain = 100
 
1067
si_k = 5k,
 
1068
si_kb = 5kb,
 
1069
si_m = 5M,
 
1070
si_mb = 5MB,
 
1071
si_g = 5g,
 
1072
si_gb = 5gB,
 
1073
""")
 
1074
        def get_si(s, default=None):
 
1075
            return self.applyDeprecated(
 
1076
                deprecated_in((2, 5, 0)),
 
1077
                conf.get_user_option_as_int_from_SI, s, default)
 
1078
        self.assertEqual(100, get_si('plain'))
 
1079
        self.assertEqual(5000, get_si('si_k'))
 
1080
        self.assertEqual(5000, get_si('si_kb'))
 
1081
        self.assertEqual(5000000, get_si('si_m'))
 
1082
        self.assertEqual(5000000, get_si('si_mb'))
 
1083
        self.assertEqual(5000000000, get_si('si_g'))
 
1084
        self.assertEqual(5000000000, get_si('si_gb'))
 
1085
        self.assertEqual(None, get_si('non-exist'))
 
1086
        self.assertEqual(42, get_si('non-exist-with-default',  42))
 
1087
 
433
1088
 
434
1089
class TestSupressWarning(TestIniConfig):
435
1090
 
462
1117
            parser = my_config._get_parser()
463
1118
        finally:
464
1119
            config.ConfigObj = oldparserclass
465
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1120
        self.assertIsInstance(parser, InstrumentedConfigObj)
466
1121
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
467
1122
                                          'utf-8')])
468
1123
 
479
1134
        my_config = config.BranchConfig(branch)
480
1135
        location_config = my_config._get_location_config()
481
1136
        self.assertEqual(branch.base, location_config.location)
482
 
        self.failUnless(location_config is my_config._get_location_config())
 
1137
        self.assertIs(location_config, my_config._get_location_config())
483
1138
 
484
1139
    def test_get_config(self):
485
1140
        """The Branch.get_config method works properly"""
505
1160
        branch = self.make_branch('branch')
506
1161
        self.assertEqual('branch', branch.nick)
507
1162
 
508
 
        locations = config.locations_config_filename()
509
 
        config.ensure_config_dir_exists()
510
1163
        local_url = urlutils.local_path_to_url('branch')
511
 
        open(locations, 'wb').write('[%s]\nnickname = foobar'
512
 
                                    % (local_url,))
 
1164
        conf = config.LocationConfig.from_string(
 
1165
            '[%s]\nnickname = foobar' % (local_url,),
 
1166
            local_url, save=True)
513
1167
        self.assertEqual('foobar', branch.nick)
514
1168
 
515
1169
    def test_config_local_path(self):
517
1171
        branch = self.make_branch('branch')
518
1172
        self.assertEqual('branch', branch.nick)
519
1173
 
520
 
        locations = config.locations_config_filename()
521
 
        config.ensure_config_dir_exists()
522
 
        open(locations, 'wb').write('[%s/branch]\nnickname = barry'
523
 
                                    % (osutils.getcwd().encode('utf8'),))
 
1174
        local_path = osutils.getcwd().encode('utf8')
 
1175
        conf = config.LocationConfig.from_string(
 
1176
            '[%s/branch]\nnickname = barry' % (local_path,),
 
1177
            'branch',  save=True)
524
1178
        self.assertEqual('barry', branch.nick)
525
1179
 
526
1180
    def test_config_creates_local(self):
527
1181
        """Creating a new entry in config uses a local path."""
528
1182
        branch = self.make_branch('branch', format='knit')
529
1183
        branch.set_push_location('http://foobar')
530
 
        locations = config.locations_config_filename()
531
1184
        local_path = osutils.getcwd().encode('utf8')
532
1185
        # Surprisingly ConfigObj doesn't create a trailing newline
533
 
        self.check_file_contents(locations,
 
1186
        self.check_file_contents(config.locations_config_filename(),
534
1187
                                 '[%s/branch]\n'
535
1188
                                 'push_location = http://foobar\n'
536
1189
                                 'push_location:policy = norecurse\n'
541
1194
        self.assertEqual('!repo', b.get_config().get_nickname())
542
1195
 
543
1196
    def test_warn_if_masked(self):
544
 
        _warning = trace.warning
545
1197
        warnings = []
546
1198
        def warning(*args):
547
1199
            warnings.append(args[0] % args[1:])
 
1200
        self.overrideAttr(trace, 'warning', warning)
548
1201
 
549
1202
        def set_option(store, warn_masked=True):
550
1203
            warnings[:] = []
556
1209
            else:
557
1210
                self.assertEqual(1, len(warnings))
558
1211
                self.assertEqual(warning, warnings[0])
559
 
        trace.warning = warning
560
 
        try:
561
 
            branch = self.make_branch('.')
562
 
            conf = branch.get_config()
563
 
            set_option(config.STORE_GLOBAL)
564
 
            assertWarning(None)
565
 
            set_option(config.STORE_BRANCH)
566
 
            assertWarning(None)
567
 
            set_option(config.STORE_GLOBAL)
568
 
            assertWarning('Value "4" is masked by "3" from branch.conf')
569
 
            set_option(config.STORE_GLOBAL, warn_masked=False)
570
 
            assertWarning(None)
571
 
            set_option(config.STORE_LOCATION)
572
 
            assertWarning(None)
573
 
            set_option(config.STORE_BRANCH)
574
 
            assertWarning('Value "3" is masked by "0" from locations.conf')
575
 
            set_option(config.STORE_BRANCH, warn_masked=False)
576
 
            assertWarning(None)
577
 
        finally:
578
 
            trace.warning = _warning
579
 
 
580
 
 
581
 
class TestGlobalConfigItems(tests.TestCase):
 
1212
        branch = self.make_branch('.')
 
1213
        conf = branch.get_config()
 
1214
        set_option(config.STORE_GLOBAL)
 
1215
        assertWarning(None)
 
1216
        set_option(config.STORE_BRANCH)
 
1217
        assertWarning(None)
 
1218
        set_option(config.STORE_GLOBAL)
 
1219
        assertWarning('Value "4" is masked by "3" from branch.conf')
 
1220
        set_option(config.STORE_GLOBAL, warn_masked=False)
 
1221
        assertWarning(None)
 
1222
        set_option(config.STORE_LOCATION)
 
1223
        assertWarning(None)
 
1224
        set_option(config.STORE_BRANCH)
 
1225
        assertWarning('Value "3" is masked by "0" from locations.conf')
 
1226
        set_option(config.STORE_BRANCH, warn_masked=False)
 
1227
        assertWarning(None)
 
1228
 
 
1229
 
 
1230
class TestGlobalConfigItems(tests.TestCaseInTempDir):
582
1231
 
583
1232
    def test_user_id(self):
584
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
585
 
        my_config = config.GlobalConfig()
586
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1233
        my_config = config.GlobalConfig.from_string(sample_config_text)
587
1234
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
588
1235
                         my_config._get_user_id())
589
1236
 
590
1237
    def test_absent_user_id(self):
591
 
        config_file = StringIO("")
592
1238
        my_config = config.GlobalConfig()
593
 
        my_config._parser = my_config._get_parser(file=config_file)
594
1239
        self.assertEqual(None, my_config._get_user_id())
595
1240
 
596
1241
    def test_configured_editor(self):
597
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
598
 
        my_config = config.GlobalConfig()
599
 
        my_config._parser = my_config._get_parser(file=config_file)
600
 
        self.assertEqual("vim", my_config.get_editor())
 
1242
        my_config = config.GlobalConfig.from_string(sample_config_text)
 
1243
        editor = self.applyDeprecated(
 
1244
            deprecated_in((2, 4, 0)), my_config.get_editor)
 
1245
        self.assertEqual('vim', editor)
601
1246
 
602
1247
    def test_signatures_always(self):
603
 
        config_file = StringIO(sample_always_signatures)
604
 
        my_config = config.GlobalConfig()
605
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1248
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
606
1249
        self.assertEqual(config.CHECK_NEVER,
607
 
                         my_config.signature_checking())
 
1250
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1251
                             my_config.signature_checking))
608
1252
        self.assertEqual(config.SIGN_ALWAYS,
609
 
                         my_config.signing_policy())
610
 
        self.assertEqual(True, my_config.signature_needed())
 
1253
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1254
                             my_config.signing_policy))
 
1255
        self.assertEqual(True,
 
1256
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1257
                my_config.signature_needed))
611
1258
 
612
1259
    def test_signatures_if_possible(self):
613
 
        config_file = StringIO(sample_maybe_signatures)
614
 
        my_config = config.GlobalConfig()
615
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1260
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
616
1261
        self.assertEqual(config.CHECK_NEVER,
617
 
                         my_config.signature_checking())
 
1262
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1263
                             my_config.signature_checking))
618
1264
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
619
 
                         my_config.signing_policy())
620
 
        self.assertEqual(False, my_config.signature_needed())
 
1265
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1266
                             my_config.signing_policy))
 
1267
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1268
            my_config.signature_needed))
621
1269
 
622
1270
    def test_signatures_ignore(self):
623
 
        config_file = StringIO(sample_ignore_signatures)
624
 
        my_config = config.GlobalConfig()
625
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1271
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
626
1272
        self.assertEqual(config.CHECK_ALWAYS,
627
 
                         my_config.signature_checking())
 
1273
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1274
                             my_config.signature_checking))
628
1275
        self.assertEqual(config.SIGN_NEVER,
629
 
                         my_config.signing_policy())
630
 
        self.assertEqual(False, my_config.signature_needed())
 
1276
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1277
                             my_config.signing_policy))
 
1278
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1279
            my_config.signature_needed))
631
1280
 
632
1281
    def _get_sample_config(self):
633
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
634
 
        my_config = config.GlobalConfig()
635
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1282
        my_config = config.GlobalConfig.from_string(sample_config_text)
636
1283
        return my_config
637
1284
 
638
1285
    def test_gpg_signing_command(self):
639
1286
        my_config = self._get_sample_config()
640
 
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
641
 
        self.assertEqual(False, my_config.signature_needed())
 
1287
        self.assertEqual("gnome-gpg",
 
1288
            self.applyDeprecated(
 
1289
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
 
1290
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1291
            my_config.signature_needed))
 
1292
 
 
1293
    def test_gpg_signing_key(self):
 
1294
        my_config = self._get_sample_config()
 
1295
        self.assertEqual("DD4D5088",
 
1296
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1297
                my_config.gpg_signing_key))
642
1298
 
643
1299
    def _get_empty_config(self):
644
 
        config_file = StringIO("")
645
1300
        my_config = config.GlobalConfig()
646
 
        my_config._parser = my_config._get_parser(file=config_file)
647
1301
        return my_config
648
1302
 
649
1303
    def test_gpg_signing_command_unset(self):
650
1304
        my_config = self._get_empty_config()
651
 
        self.assertEqual("gpg", my_config.gpg_signing_command())
 
1305
        self.assertEqual("gpg",
 
1306
            self.applyDeprecated(
 
1307
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
652
1308
 
653
1309
    def test_get_user_option_default(self):
654
1310
        my_config = self._get_empty_config()
661
1317
 
662
1318
    def test_post_commit_default(self):
663
1319
        my_config = self._get_sample_config()
664
 
        self.assertEqual(None, my_config.post_commit())
 
1320
        self.assertEqual(None,
 
1321
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1322
                                              my_config.post_commit))
665
1323
 
666
1324
    def test_configured_logformat(self):
667
1325
        my_config = self._get_sample_config()
668
 
        self.assertEqual("short", my_config.log_format())
 
1326
        self.assertEqual("short",
 
1327
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1328
                                              my_config.log_format))
 
1329
 
 
1330
    def test_configured_acceptable_keys(self):
 
1331
        my_config = self._get_sample_config()
 
1332
        self.assertEqual("amy",
 
1333
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1334
                my_config.acceptable_keys))
 
1335
 
 
1336
    def test_configured_validate_signatures_in_log(self):
 
1337
        my_config = self._get_sample_config()
 
1338
        self.assertEqual(True, my_config.validate_signatures_in_log())
669
1339
 
670
1340
    def test_get_alias(self):
671
1341
        my_config = self._get_sample_config()
699
1369
        change_editor = my_config.get_change_editor('old', 'new')
700
1370
        self.assertIs(None, change_editor)
701
1371
 
 
1372
    def test_get_merge_tools(self):
 
1373
        conf = self._get_sample_config()
 
1374
        tools = conf.get_merge_tools()
 
1375
        self.log(repr(tools))
 
1376
        self.assertEqual(
 
1377
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
 
1378
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
 
1379
            u'newtool' : u'"newtool with spaces" {this_temp}'},
 
1380
            tools)
 
1381
 
 
1382
    def test_get_merge_tools_empty(self):
 
1383
        conf = self._get_empty_config()
 
1384
        tools = conf.get_merge_tools()
 
1385
        self.assertEqual({}, tools)
 
1386
 
 
1387
    def test_find_merge_tool(self):
 
1388
        conf = self._get_sample_config()
 
1389
        cmdline = conf.find_merge_tool('sometool')
 
1390
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
 
1391
 
 
1392
    def test_find_merge_tool_not_found(self):
 
1393
        conf = self._get_sample_config()
 
1394
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
 
1395
        self.assertIs(cmdline, None)
 
1396
 
 
1397
    def test_find_merge_tool_known(self):
 
1398
        conf = self._get_empty_config()
 
1399
        cmdline = conf.find_merge_tool('kdiff3')
 
1400
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
 
1401
 
 
1402
    def test_find_merge_tool_override_known(self):
 
1403
        conf = self._get_empty_config()
 
1404
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
 
1405
        cmdline = conf.find_merge_tool('kdiff3')
 
1406
        self.assertEqual('kdiff3 blah', cmdline)
 
1407
 
702
1408
 
703
1409
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
704
1410
 
722
1428
        self.assertIs(None, new_config.get_alias('commit'))
723
1429
 
724
1430
 
725
 
class TestLocationConfig(tests.TestCaseInTempDir):
 
1431
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
726
1432
 
727
1433
    def test_constructs(self):
728
1434
        my_config = config.LocationConfig('http://example.com')
740
1446
            parser = my_config._get_parser()
741
1447
        finally:
742
1448
            config.ConfigObj = oldparserclass
743
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1449
        self.assertIsInstance(parser, InstrumentedConfigObj)
744
1450
        self.assertEqual(parser._calls,
745
1451
                         [('__init__', config.locations_config_filename(),
746
1452
                           'utf-8')])
747
 
        config.ensure_config_dir_exists()
748
 
        #os.mkdir(config.config_dir())
749
 
        f = file(config.branches_config_filename(), 'wb')
750
 
        f.write('')
751
 
        f.close()
752
 
        oldparserclass = config.ConfigObj
753
 
        config.ConfigObj = InstrumentedConfigObj
754
 
        try:
755
 
            my_config = config.LocationConfig('http://www.example.com')
756
 
            parser = my_config._get_parser()
757
 
        finally:
758
 
            config.ConfigObj = oldparserclass
759
1453
 
760
1454
    def test_get_global_config(self):
761
1455
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
762
1456
        global_config = my_config._get_global_config()
763
 
        self.failUnless(isinstance(global_config, config.GlobalConfig))
764
 
        self.failUnless(global_config is my_config._get_global_config())
 
1457
        self.assertIsInstance(global_config, config.GlobalConfig)
 
1458
        self.assertIs(global_config, my_config._get_global_config())
 
1459
 
 
1460
    def assertLocationMatching(self, expected):
 
1461
        self.assertEqual(expected,
 
1462
                         list(self.my_location_config._get_matching_sections()))
765
1463
 
766
1464
    def test__get_matching_sections_no_match(self):
767
1465
        self.get_branch_config('/')
768
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1466
        self.assertLocationMatching([])
769
1467
 
770
1468
    def test__get_matching_sections_exact(self):
771
1469
        self.get_branch_config('http://www.example.com')
772
 
        self.assertEqual([('http://www.example.com', '')],
773
 
                         self.my_location_config._get_matching_sections())
 
1470
        self.assertLocationMatching([('http://www.example.com', '')])
774
1471
 
775
1472
    def test__get_matching_sections_suffix_does_not(self):
776
1473
        self.get_branch_config('http://www.example.com-com')
777
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1474
        self.assertLocationMatching([])
778
1475
 
779
1476
    def test__get_matching_sections_subdir_recursive(self):
780
1477
        self.get_branch_config('http://www.example.com/com')
781
 
        self.assertEqual([('http://www.example.com', 'com')],
782
 
                         self.my_location_config._get_matching_sections())
 
1478
        self.assertLocationMatching([('http://www.example.com', 'com')])
783
1479
 
784
1480
    def test__get_matching_sections_ignoreparent(self):
785
1481
        self.get_branch_config('http://www.example.com/ignoreparent')
786
 
        self.assertEqual([('http://www.example.com/ignoreparent', '')],
787
 
                         self.my_location_config._get_matching_sections())
 
1482
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1483
                                      '')])
788
1484
 
789
1485
    def test__get_matching_sections_ignoreparent_subdir(self):
790
1486
        self.get_branch_config(
791
1487
            'http://www.example.com/ignoreparent/childbranch')
792
 
        self.assertEqual([('http://www.example.com/ignoreparent',
793
 
                           'childbranch')],
794
 
                         self.my_location_config._get_matching_sections())
 
1488
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1489
                                      'childbranch')])
795
1490
 
796
1491
    def test__get_matching_sections_subdir_trailing_slash(self):
797
1492
        self.get_branch_config('/b')
798
 
        self.assertEqual([('/b/', '')],
799
 
                         self.my_location_config._get_matching_sections())
 
1493
        self.assertLocationMatching([('/b/', '')])
800
1494
 
801
1495
    def test__get_matching_sections_subdir_child(self):
802
1496
        self.get_branch_config('/a/foo')
803
 
        self.assertEqual([('/a/*', ''), ('/a/', 'foo')],
804
 
                         self.my_location_config._get_matching_sections())
 
1497
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
805
1498
 
806
1499
    def test__get_matching_sections_subdir_child_child(self):
807
1500
        self.get_branch_config('/a/foo/bar')
808
 
        self.assertEqual([('/a/*', 'bar'), ('/a/', 'foo/bar')],
809
 
                         self.my_location_config._get_matching_sections())
 
1501
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
810
1502
 
811
1503
    def test__get_matching_sections_trailing_slash_with_children(self):
812
1504
        self.get_branch_config('/a/')
813
 
        self.assertEqual([('/a/', '')],
814
 
                         self.my_location_config._get_matching_sections())
 
1505
        self.assertLocationMatching([('/a/', '')])
815
1506
 
816
1507
    def test__get_matching_sections_explicit_over_glob(self):
817
1508
        # XXX: 2006-09-08 jamesh
819
1510
        # was a config section for '/a/?', it would get precedence
820
1511
        # over '/a/c'.
821
1512
        self.get_branch_config('/a/c')
822
 
        self.assertEqual([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')],
823
 
                         self.my_location_config._get_matching_sections())
 
1513
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
824
1514
 
825
1515
    def test__get_option_policy_normal(self):
826
1516
        self.get_branch_config('http://www.example.com')
848
1538
            'http://www.example.com', 'appendpath_option'),
849
1539
            config.POLICY_APPENDPATH)
850
1540
 
 
1541
    def test__get_options_with_policy(self):
 
1542
        self.get_branch_config('/dir/subdir',
 
1543
                               location_config="""\
 
1544
[/dir]
 
1545
other_url = /other-dir
 
1546
other_url:policy = appendpath
 
1547
[/dir/subdir]
 
1548
other_url = /other-subdir
 
1549
""")
 
1550
        self.assertOptions(
 
1551
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
 
1552
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
 
1553
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
 
1554
            self.my_location_config)
 
1555
 
851
1556
    def test_location_without_username(self):
852
1557
        self.get_branch_config('http://www.example.com/ignoreparent')
853
1558
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
868
1573
        self.get_branch_config('http://www.example.com',
869
1574
                                 global_config=sample_ignore_signatures)
870
1575
        self.assertEqual(config.CHECK_ALWAYS,
871
 
                         self.my_config.signature_checking())
 
1576
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1577
                             self.my_config.signature_checking))
872
1578
        self.assertEqual(config.SIGN_NEVER,
873
 
                         self.my_config.signing_policy())
 
1579
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1580
                             self.my_config.signing_policy))
874
1581
 
875
1582
    def test_signatures_never(self):
876
1583
        self.get_branch_config('/a/c')
877
1584
        self.assertEqual(config.CHECK_NEVER,
878
 
                         self.my_config.signature_checking())
 
1585
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1586
                             self.my_config.signature_checking))
879
1587
 
880
1588
    def test_signatures_when_available(self):
881
1589
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
882
1590
        self.assertEqual(config.CHECK_IF_POSSIBLE,
883
 
                         self.my_config.signature_checking())
 
1591
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1592
                             self.my_config.signature_checking))
884
1593
 
885
1594
    def test_signatures_always(self):
886
1595
        self.get_branch_config('/b')
887
1596
        self.assertEqual(config.CHECK_ALWAYS,
888
 
                         self.my_config.signature_checking())
 
1597
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1598
                         self.my_config.signature_checking))
889
1599
 
890
1600
    def test_gpg_signing_command(self):
891
1601
        self.get_branch_config('/b')
892
 
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
 
1602
        self.assertEqual("gnome-gpg",
 
1603
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1604
                self.my_config.gpg_signing_command))
893
1605
 
894
1606
    def test_gpg_signing_command_missing(self):
895
1607
        self.get_branch_config('/a')
896
 
        self.assertEqual("false", self.my_config.gpg_signing_command())
 
1608
        self.assertEqual("false",
 
1609
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1610
                self.my_config.gpg_signing_command))
 
1611
 
 
1612
    def test_gpg_signing_key(self):
 
1613
        self.get_branch_config('/b')
 
1614
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1615
            self.my_config.gpg_signing_key))
 
1616
 
 
1617
    def test_gpg_signing_key_default(self):
 
1618
        self.get_branch_config('/a')
 
1619
        self.assertEqual("erik@bagfors.nu",
 
1620
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1621
                self.my_config.gpg_signing_key))
897
1622
 
898
1623
    def test_get_user_option_global(self):
899
1624
        self.get_branch_config('/a')
987
1712
    def test_post_commit_default(self):
988
1713
        self.get_branch_config('/a/c')
989
1714
        self.assertEqual('bzrlib.tests.test_config.post_commit',
990
 
                         self.my_config.post_commit())
 
1715
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1716
                                              self.my_config.post_commit))
991
1717
 
992
 
    def get_branch_config(self, location, global_config=None):
 
1718
    def get_branch_config(self, location, global_config=None,
 
1719
                          location_config=None):
 
1720
        my_branch = FakeBranch(location)
993
1721
        if global_config is None:
994
 
            global_file = StringIO(sample_config_text.encode('utf-8'))
995
 
        else:
996
 
            global_file = StringIO(global_config.encode('utf-8'))
997
 
        branches_file = StringIO(sample_branches_text.encode('utf-8'))
998
 
        self.my_config = config.BranchConfig(FakeBranch(location))
999
 
        # Force location config to use specified file
1000
 
        self.my_location_config = self.my_config._get_location_config()
1001
 
        self.my_location_config._get_parser(branches_file)
1002
 
        # Force global config to use specified file
1003
 
        self.my_config._get_global_config()._get_parser(global_file)
 
1722
            global_config = sample_config_text
 
1723
        if location_config is None:
 
1724
            location_config = sample_branches_text
 
1725
 
 
1726
        my_global_config = config.GlobalConfig.from_string(global_config,
 
1727
                                                           save=True)
 
1728
        my_location_config = config.LocationConfig.from_string(
 
1729
            location_config, my_branch.base, save=True)
 
1730
        my_config = config.BranchConfig(my_branch)
 
1731
        self.my_config = my_config
 
1732
        self.my_location_config = my_config._get_location_config()
1004
1733
 
1005
1734
    def test_set_user_setting_sets_and_saves(self):
1006
1735
        self.get_branch_config('/a/c')
1007
1736
        record = InstrumentedConfigObj("foo")
1008
1737
        self.my_location_config._parser = record
1009
1738
 
1010
 
        real_mkdir = os.mkdir
1011
 
        self.created = False
1012
 
        def checked_mkdir(path, mode=0777):
1013
 
            self.log('making directory: %s', path)
1014
 
            real_mkdir(path, mode)
1015
 
            self.created = True
1016
 
 
1017
 
        os.mkdir = checked_mkdir
1018
 
        try:
1019
 
            self.callDeprecated(['The recurse option is deprecated as of '
1020
 
                                 '0.14.  The section "/a/c" has been '
1021
 
                                 'converted to use policies.'],
1022
 
                                self.my_config.set_user_option,
1023
 
                                'foo', 'bar', store=config.STORE_LOCATION)
1024
 
        finally:
1025
 
            os.mkdir = real_mkdir
1026
 
 
1027
 
        self.failUnless(self.created, 'Failed to create ~/.bazaar')
1028
 
        self.assertEqual([('__contains__', '/a/c'),
 
1739
        self.callDeprecated(['The recurse option is deprecated as of '
 
1740
                             '0.14.  The section "/a/c" has been '
 
1741
                             'converted to use policies.'],
 
1742
                            self.my_config.set_user_option,
 
1743
                            'foo', 'bar', store=config.STORE_LOCATION)
 
1744
        self.assertEqual([('reload',),
 
1745
                          ('__contains__', '/a/c'),
1029
1746
                          ('__contains__', '/a/c/'),
1030
1747
                          ('__setitem__', '/a/c', {}),
1031
1748
                          ('__getitem__', '/a/c'),
1060
1777
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1061
1778
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1062
1779
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
1063
 
        os.environ['BZR_REMOTE_PATH'] = '/environ-bzr'
 
1780
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1064
1781
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1065
1782
 
1066
1783
 
1074
1791
option = exact
1075
1792
"""
1076
1793
 
1077
 
 
1078
1794
class TestBranchConfigItems(tests.TestCaseInTempDir):
1079
1795
 
1080
1796
    def get_branch_config(self, global_config=None, location=None,
1081
1797
                          location_config=None, branch_data_config=None):
1082
 
        my_config = config.BranchConfig(FakeBranch(location))
 
1798
        my_branch = FakeBranch(location)
1083
1799
        if global_config is not None:
1084
 
            global_file = StringIO(global_config.encode('utf-8'))
1085
 
            my_config._get_global_config()._get_parser(global_file)
1086
 
        self.my_location_config = my_config._get_location_config()
 
1800
            my_global_config = config.GlobalConfig.from_string(global_config,
 
1801
                                                               save=True)
1087
1802
        if location_config is not None:
1088
 
            location_file = StringIO(location_config.encode('utf-8'))
1089
 
            self.my_location_config._get_parser(location_file)
 
1803
            my_location_config = config.LocationConfig.from_string(
 
1804
                location_config, my_branch.base, save=True)
 
1805
        my_config = config.BranchConfig(my_branch)
1090
1806
        if branch_data_config is not None:
1091
1807
            my_config.branch.control_files.files['branch.conf'] = \
1092
1808
                branch_data_config
1093
1809
        return my_config
1094
1810
 
1095
1811
    def test_user_id(self):
1096
 
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
 
1812
        branch = FakeBranch()
1097
1813
        my_config = config.BranchConfig(branch)
1098
 
        self.assertEqual("Robert Collins <robertc@example.net>",
1099
 
                         my_config.username())
 
1814
        self.assertIsNot(None, my_config.username())
1100
1815
        my_config.branch.control_files.files['email'] = "John"
1101
1816
        my_config.set_user_option('email',
1102
1817
                                  "Robert Collins <robertc@example.org>")
1103
 
        self.assertEqual("John", my_config.username())
1104
 
        del my_config.branch.control_files.files['email']
1105
1818
        self.assertEqual("Robert Collins <robertc@example.org>",
1106
 
                         my_config.username())
1107
 
 
1108
 
    def test_not_set_in_branch(self):
1109
 
        my_config = self.get_branch_config(sample_config_text)
1110
 
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1111
 
                         my_config._get_user_id())
1112
 
        my_config.branch.control_files.files['email'] = "John"
1113
 
        self.assertEqual("John", my_config._get_user_id())
 
1819
                        my_config.username())
1114
1820
 
1115
1821
    def test_BZR_EMAIL_OVERRIDES(self):
1116
 
        os.environ['BZR_EMAIL'] = "Robert Collins <robertc@example.org>"
 
1822
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1117
1823
        branch = FakeBranch()
1118
1824
        my_config = config.BranchConfig(branch)
1119
1825
        self.assertEqual("Robert Collins <robertc@example.org>",
1122
1828
    def test_signatures_forced(self):
1123
1829
        my_config = self.get_branch_config(
1124
1830
            global_config=sample_always_signatures)
1125
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1126
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1127
 
        self.assertTrue(my_config.signature_needed())
 
1831
        self.assertEqual(config.CHECK_NEVER,
 
1832
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1833
                my_config.signature_checking))
 
1834
        self.assertEqual(config.SIGN_ALWAYS,
 
1835
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1836
                my_config.signing_policy))
 
1837
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1838
            my_config.signature_needed))
1128
1839
 
1129
1840
    def test_signatures_forced_branch(self):
1130
1841
        my_config = self.get_branch_config(
1131
1842
            global_config=sample_ignore_signatures,
1132
1843
            branch_data_config=sample_always_signatures)
1133
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1134
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1135
 
        self.assertTrue(my_config.signature_needed())
 
1844
        self.assertEqual(config.CHECK_NEVER,
 
1845
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1846
                my_config.signature_checking))
 
1847
        self.assertEqual(config.SIGN_ALWAYS,
 
1848
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1849
                my_config.signing_policy))
 
1850
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1851
            my_config.signature_needed))
1136
1852
 
1137
1853
    def test_gpg_signing_command(self):
1138
1854
        my_config = self.get_branch_config(
 
1855
            global_config=sample_config_text,
1139
1856
            # branch data cannot set gpg_signing_command
1140
1857
            branch_data_config="gpg_signing_command=pgp")
1141
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
1142
 
        my_config._get_global_config()._get_parser(config_file)
1143
 
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
 
1858
        self.assertEqual('gnome-gpg',
 
1859
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1860
                my_config.gpg_signing_command))
1144
1861
 
1145
1862
    def test_get_user_option_global(self):
1146
 
        branch = FakeBranch()
1147
 
        my_config = config.BranchConfig(branch)
1148
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
1149
 
        (my_config._get_global_config()._get_parser(config_file))
 
1863
        my_config = self.get_branch_config(global_config=sample_config_text)
1150
1864
        self.assertEqual('something',
1151
1865
                         my_config.get_user_option('user_global_option'))
1152
1866
 
1153
1867
    def test_post_commit_default(self):
1154
 
        branch = FakeBranch()
1155
 
        my_config = self.get_branch_config(sample_config_text, '/a/c',
1156
 
                                           sample_branches_text)
 
1868
        my_config = self.get_branch_config(global_config=sample_config_text,
 
1869
                                      location='/a/c',
 
1870
                                      location_config=sample_branches_text)
1157
1871
        self.assertEqual(my_config.branch.base, '/a/c')
1158
1872
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1159
 
                         my_config.post_commit())
 
1873
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1874
                                              my_config.post_commit))
1160
1875
        my_config.set_user_option('post_commit', 'rmtree_root')
1161
 
        # post-commit is ignored when bresent in branch data
 
1876
        # post-commit is ignored when present in branch data
1162
1877
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1163
 
                         my_config.post_commit())
 
1878
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1879
                                              my_config.post_commit))
1164
1880
        my_config.set_user_option('post_commit', 'rmtree_root',
1165
1881
                                  store=config.STORE_LOCATION)
1166
 
        self.assertEqual('rmtree_root', my_config.post_commit())
 
1882
        self.assertEqual('rmtree_root',
 
1883
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1884
                                              my_config.post_commit))
1167
1885
 
1168
1886
    def test_config_precedence(self):
 
1887
        # FIXME: eager test, luckily no persitent config file makes it fail
 
1888
        # -- vila 20100716
1169
1889
        my_config = self.get_branch_config(global_config=precedence_global)
1170
1890
        self.assertEqual(my_config.get_user_option('option'), 'global')
1171
1891
        my_config = self.get_branch_config(global_config=precedence_global,
1172
 
                                      branch_data_config=precedence_branch)
 
1892
                                           branch_data_config=precedence_branch)
1173
1893
        self.assertEqual(my_config.get_user_option('option'), 'branch')
1174
 
        my_config = self.get_branch_config(global_config=precedence_global,
1175
 
                                      branch_data_config=precedence_branch,
1176
 
                                      location_config=precedence_location)
 
1894
        my_config = self.get_branch_config(
 
1895
            global_config=precedence_global,
 
1896
            branch_data_config=precedence_branch,
 
1897
            location_config=precedence_location)
1177
1898
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
1178
 
        my_config = self.get_branch_config(global_config=precedence_global,
1179
 
                                      branch_data_config=precedence_branch,
1180
 
                                      location_config=precedence_location,
1181
 
                                      location='http://example.com/specific')
 
1899
        my_config = self.get_branch_config(
 
1900
            global_config=precedence_global,
 
1901
            branch_data_config=precedence_branch,
 
1902
            location_config=precedence_location,
 
1903
            location='http://example.com/specific')
1182
1904
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1183
1905
 
1184
1906
    def test_get_mail_client(self):
1274
1996
 
1275
1997
class TestTransportConfig(tests.TestCaseWithTransport):
1276
1998
 
 
1999
    def test_load_utf8(self):
 
2000
        """Ensure we can load an utf8-encoded file."""
 
2001
        t = self.get_transport()
 
2002
        unicode_user = u'b\N{Euro Sign}ar'
 
2003
        unicode_content = u'user=%s' % (unicode_user,)
 
2004
        utf8_content = unicode_content.encode('utf8')
 
2005
        # Store the raw content in the config file
 
2006
        t.put_bytes('foo.conf', utf8_content)
 
2007
        conf = config.TransportConfig(t, 'foo.conf')
 
2008
        self.assertEquals(unicode_user, conf.get_option('user'))
 
2009
 
 
2010
    def test_load_non_ascii(self):
 
2011
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2012
        t = self.get_transport()
 
2013
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
 
2014
        conf = config.TransportConfig(t, 'foo.conf')
 
2015
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
 
2016
 
 
2017
    def test_load_erroneous_content(self):
 
2018
        """Ensure we display a proper error on content that can't be parsed."""
 
2019
        t = self.get_transport()
 
2020
        t.put_bytes('foo.conf', '[open_section\n')
 
2021
        conf = config.TransportConfig(t, 'foo.conf')
 
2022
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
 
2023
 
 
2024
    def test_load_permission_denied(self):
 
2025
        """Ensure we get an empty config file if the file is inaccessible."""
 
2026
        warnings = []
 
2027
        def warning(*args):
 
2028
            warnings.append(args[0] % args[1:])
 
2029
        self.overrideAttr(trace, 'warning', warning)
 
2030
 
 
2031
        class DenyingTransport(object):
 
2032
 
 
2033
            def __init__(self, base):
 
2034
                self.base = base
 
2035
 
 
2036
            def get_bytes(self, relpath):
 
2037
                raise errors.PermissionDenied(relpath, "")
 
2038
 
 
2039
        cfg = config.TransportConfig(
 
2040
            DenyingTransport("nonexisting://"), 'control.conf')
 
2041
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
 
2042
        self.assertEquals(
 
2043
            warnings,
 
2044
            [u'Permission denied while trying to open configuration file '
 
2045
             u'nonexisting:///control.conf.'])
 
2046
 
1277
2047
    def test_get_value(self):
1278
2048
        """Test that retreiving a value from a section is possible"""
1279
 
        bzrdir_config = config.TransportConfig(transport.get_transport('.'),
 
2049
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
1280
2050
                                               'control.conf')
1281
2051
        bzrdir_config.set_option('value', 'key', 'SECTION')
1282
2052
        bzrdir_config.set_option('value2', 'key2')
1312
2082
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1313
2083
 
1314
2084
 
 
2085
class TestOldConfigHooks(tests.TestCaseWithTransport):
 
2086
 
 
2087
    def setUp(self):
 
2088
        super(TestOldConfigHooks, self).setUp()
 
2089
        create_configs_with_file_option(self)
 
2090
 
 
2091
    def assertGetHook(self, conf, name, value):
 
2092
        calls = []
 
2093
        def hook(*args):
 
2094
            calls.append(args)
 
2095
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2096
        self.addCleanup(
 
2097
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2098
        self.assertLength(0, calls)
 
2099
        actual_value = conf.get_user_option(name)
 
2100
        self.assertEquals(value, actual_value)
 
2101
        self.assertLength(1, calls)
 
2102
        self.assertEquals((conf, name, value), calls[0])
 
2103
 
 
2104
    def test_get_hook_bazaar(self):
 
2105
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
 
2106
 
 
2107
    def test_get_hook_locations(self):
 
2108
        self.assertGetHook(self.locations_config, 'file', 'locations')
 
2109
 
 
2110
    def test_get_hook_branch(self):
 
2111
        # Since locations masks branch, we define a different option
 
2112
        self.branch_config.set_user_option('file2', 'branch')
 
2113
        self.assertGetHook(self.branch_config, 'file2', 'branch')
 
2114
 
 
2115
    def assertSetHook(self, conf, name, value):
 
2116
        calls = []
 
2117
        def hook(*args):
 
2118
            calls.append(args)
 
2119
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2120
        self.addCleanup(
 
2121
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2122
        self.assertLength(0, calls)
 
2123
        conf.set_user_option(name, value)
 
2124
        self.assertLength(1, calls)
 
2125
        # We can't assert the conf object below as different configs use
 
2126
        # different means to implement set_user_option and we care only about
 
2127
        # coverage here.
 
2128
        self.assertEquals((name, value), calls[0][1:])
 
2129
 
 
2130
    def test_set_hook_bazaar(self):
 
2131
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
 
2132
 
 
2133
    def test_set_hook_locations(self):
 
2134
        self.assertSetHook(self.locations_config, 'foo', 'locations')
 
2135
 
 
2136
    def test_set_hook_branch(self):
 
2137
        self.assertSetHook(self.branch_config, 'foo', 'branch')
 
2138
 
 
2139
    def assertRemoveHook(self, conf, name, section_name=None):
 
2140
        calls = []
 
2141
        def hook(*args):
 
2142
            calls.append(args)
 
2143
        config.OldConfigHooks.install_named_hook('remove', hook, None)
 
2144
        self.addCleanup(
 
2145
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
 
2146
        self.assertLength(0, calls)
 
2147
        conf.remove_user_option(name, section_name)
 
2148
        self.assertLength(1, calls)
 
2149
        # We can't assert the conf object below as different configs use
 
2150
        # different means to implement remove_user_option and we care only about
 
2151
        # coverage here.
 
2152
        self.assertEquals((name,), calls[0][1:])
 
2153
 
 
2154
    def test_remove_hook_bazaar(self):
 
2155
        self.assertRemoveHook(self.bazaar_config, 'file')
 
2156
 
 
2157
    def test_remove_hook_locations(self):
 
2158
        self.assertRemoveHook(self.locations_config, 'file',
 
2159
                              self.locations_config.location)
 
2160
 
 
2161
    def test_remove_hook_branch(self):
 
2162
        self.assertRemoveHook(self.branch_config, 'file')
 
2163
 
 
2164
    def assertLoadHook(self, name, conf_class, *conf_args):
 
2165
        calls = []
 
2166
        def hook(*args):
 
2167
            calls.append(args)
 
2168
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2169
        self.addCleanup(
 
2170
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2171
        self.assertLength(0, calls)
 
2172
        # Build a config
 
2173
        conf = conf_class(*conf_args)
 
2174
        # Access an option to trigger a load
 
2175
        conf.get_user_option(name)
 
2176
        self.assertLength(1, calls)
 
2177
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2178
 
 
2179
    def test_load_hook_bazaar(self):
 
2180
        self.assertLoadHook('file', config.GlobalConfig)
 
2181
 
 
2182
    def test_load_hook_locations(self):
 
2183
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
 
2184
 
 
2185
    def test_load_hook_branch(self):
 
2186
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
 
2187
 
 
2188
    def assertSaveHook(self, conf):
 
2189
        calls = []
 
2190
        def hook(*args):
 
2191
            calls.append(args)
 
2192
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2193
        self.addCleanup(
 
2194
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2195
        self.assertLength(0, calls)
 
2196
        # Setting an option triggers a save
 
2197
        conf.set_user_option('foo', 'bar')
 
2198
        self.assertLength(1, calls)
 
2199
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2200
 
 
2201
    def test_save_hook_bazaar(self):
 
2202
        self.assertSaveHook(self.bazaar_config)
 
2203
 
 
2204
    def test_save_hook_locations(self):
 
2205
        self.assertSaveHook(self.locations_config)
 
2206
 
 
2207
    def test_save_hook_branch(self):
 
2208
        self.assertSaveHook(self.branch_config)
 
2209
 
 
2210
 
 
2211
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
 
2212
    """Tests config hooks for remote configs.
 
2213
 
 
2214
    No tests for the remove hook as this is not implemented there.
 
2215
    """
 
2216
 
 
2217
    def setUp(self):
 
2218
        super(TestOldConfigHooksForRemote, self).setUp()
 
2219
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2220
        create_configs_with_file_option(self)
 
2221
 
 
2222
    def assertGetHook(self, conf, name, value):
 
2223
        calls = []
 
2224
        def hook(*args):
 
2225
            calls.append(args)
 
2226
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2227
        self.addCleanup(
 
2228
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2229
        self.assertLength(0, calls)
 
2230
        actual_value = conf.get_option(name)
 
2231
        self.assertEquals(value, actual_value)
 
2232
        self.assertLength(1, calls)
 
2233
        self.assertEquals((conf, name, value), calls[0])
 
2234
 
 
2235
    def test_get_hook_remote_branch(self):
 
2236
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2237
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
 
2238
 
 
2239
    def test_get_hook_remote_bzrdir(self):
 
2240
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2241
        conf = remote_bzrdir._get_config()
 
2242
        conf.set_option('remotedir', 'file')
 
2243
        self.assertGetHook(conf, 'file', 'remotedir')
 
2244
 
 
2245
    def assertSetHook(self, conf, name, value):
 
2246
        calls = []
 
2247
        def hook(*args):
 
2248
            calls.append(args)
 
2249
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2250
        self.addCleanup(
 
2251
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2252
        self.assertLength(0, calls)
 
2253
        conf.set_option(value, name)
 
2254
        self.assertLength(1, calls)
 
2255
        # We can't assert the conf object below as different configs use
 
2256
        # different means to implement set_user_option and we care only about
 
2257
        # coverage here.
 
2258
        self.assertEquals((name, value), calls[0][1:])
 
2259
 
 
2260
    def test_set_hook_remote_branch(self):
 
2261
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2262
        self.addCleanup(remote_branch.lock_write().unlock)
 
2263
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
 
2264
 
 
2265
    def test_set_hook_remote_bzrdir(self):
 
2266
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2267
        self.addCleanup(remote_branch.lock_write().unlock)
 
2268
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2269
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
 
2270
 
 
2271
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
 
2272
        calls = []
 
2273
        def hook(*args):
 
2274
            calls.append(args)
 
2275
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2276
        self.addCleanup(
 
2277
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2278
        self.assertLength(0, calls)
 
2279
        # Build a config
 
2280
        conf = conf_class(*conf_args)
 
2281
        # Access an option to trigger a load
 
2282
        conf.get_option(name)
 
2283
        self.assertLength(expected_nb_calls, calls)
 
2284
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2285
 
 
2286
    def test_load_hook_remote_branch(self):
 
2287
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2288
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
 
2289
 
 
2290
    def test_load_hook_remote_bzrdir(self):
 
2291
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2292
        # The config file doesn't exist, set an option to force its creation
 
2293
        conf = remote_bzrdir._get_config()
 
2294
        conf.set_option('remotedir', 'file')
 
2295
        # We get one call for the server and one call for the client, this is
 
2296
        # caused by the differences in implementations betwen
 
2297
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
 
2298
        # SmartServerBranchGetConfigFile (in smart/branch.py)
 
2299
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
 
2300
 
 
2301
    def assertSaveHook(self, conf):
 
2302
        calls = []
 
2303
        def hook(*args):
 
2304
            calls.append(args)
 
2305
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2306
        self.addCleanup(
 
2307
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2308
        self.assertLength(0, calls)
 
2309
        # Setting an option triggers a save
 
2310
        conf.set_option('foo', 'bar')
 
2311
        self.assertLength(1, calls)
 
2312
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2313
 
 
2314
    def test_save_hook_remote_branch(self):
 
2315
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2316
        self.addCleanup(remote_branch.lock_write().unlock)
 
2317
        self.assertSaveHook(remote_branch._get_config())
 
2318
 
 
2319
    def test_save_hook_remote_bzrdir(self):
 
2320
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2321
        self.addCleanup(remote_branch.lock_write().unlock)
 
2322
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2323
        self.assertSaveHook(remote_bzrdir._get_config())
 
2324
 
 
2325
 
 
2326
class TestOption(tests.TestCase):
 
2327
 
 
2328
    def test_default_value(self):
 
2329
        opt = config.Option('foo', default='bar')
 
2330
        self.assertEquals('bar', opt.get_default())
 
2331
 
 
2332
    def test_callable_default_value(self):
 
2333
        def bar_as_unicode():
 
2334
            return u'bar'
 
2335
        opt = config.Option('foo', default=bar_as_unicode)
 
2336
        self.assertEquals('bar', opt.get_default())
 
2337
 
 
2338
    def test_default_value_from_env(self):
 
2339
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
 
2340
        self.overrideEnv('FOO', 'quux')
 
2341
        # Env variable provides a default taking over the option one
 
2342
        self.assertEquals('quux', opt.get_default())
 
2343
 
 
2344
    def test_first_default_value_from_env_wins(self):
 
2345
        opt = config.Option('foo', default='bar',
 
2346
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
 
2347
        self.overrideEnv('FOO', 'foo')
 
2348
        self.overrideEnv('BAZ', 'baz')
 
2349
        # The first env var set wins
 
2350
        self.assertEquals('foo', opt.get_default())
 
2351
 
 
2352
    def test_not_supported_list_default_value(self):
 
2353
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
 
2354
 
 
2355
    def test_not_supported_object_default_value(self):
 
2356
        self.assertRaises(AssertionError, config.Option, 'foo',
 
2357
                          default=object())
 
2358
 
 
2359
    def test_not_supported_callable_default_value_not_unicode(self):
 
2360
        def bar_not_unicode():
 
2361
            return 'bar'
 
2362
        opt = config.Option('foo', default=bar_not_unicode)
 
2363
        self.assertRaises(AssertionError, opt.get_default)
 
2364
 
 
2365
 
 
2366
class TestOptionConverterMixin(object):
 
2367
 
 
2368
    def assertConverted(self, expected, opt, value):
 
2369
        self.assertEquals(expected, opt.convert_from_unicode(value),
 
2370
                          'Expecting %s, got %s' % (expected, value,))
 
2371
 
 
2372
    def assertWarns(self, opt, value):
 
2373
        warnings = []
 
2374
        def warning(*args):
 
2375
            warnings.append(args[0] % args[1:])
 
2376
        self.overrideAttr(trace, 'warning', warning)
 
2377
        self.assertEquals(None, opt.convert_from_unicode(value))
 
2378
        self.assertLength(1, warnings)
 
2379
        self.assertEquals(
 
2380
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2381
            warnings[0])
 
2382
 
 
2383
    def assertErrors(self, opt, value):
 
2384
        self.assertRaises(errors.ConfigOptionValueError,
 
2385
                          opt.convert_from_unicode, value)
 
2386
 
 
2387
    def assertConvertInvalid(self, opt, invalid_value):
 
2388
        opt.invalid = None
 
2389
        self.assertEquals(None, opt.convert_from_unicode(invalid_value),
 
2390
                          '%s is not None' % (invalid_value,))
 
2391
        opt.invalid = 'warning'
 
2392
        self.assertWarns(opt, invalid_value)
 
2393
        opt.invalid = 'error'
 
2394
        self.assertErrors(opt, invalid_value)
 
2395
 
 
2396
 
 
2397
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2398
 
 
2399
    def get_option(self):
 
2400
        return config.Option('foo', help='A boolean.',
 
2401
                             from_unicode=config.bool_from_store)
 
2402
 
 
2403
    def test_convert_invalid(self):
 
2404
        opt = self.get_option()
 
2405
        # A string that is not recognized as a boolean
 
2406
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2407
        # A list of strings is never recognized as a boolean
 
2408
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2409
 
 
2410
    def test_convert_valid(self):
 
2411
        opt = self.get_option()
 
2412
        self.assertConverted(True, opt, u'True')
 
2413
        self.assertConverted(True, opt, u'1')
 
2414
        self.assertConverted(False, opt, u'False')
 
2415
 
 
2416
 
 
2417
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2418
 
 
2419
    def get_option(self):
 
2420
        return config.Option('foo', help='An integer.',
 
2421
                             from_unicode=config.int_from_store)
 
2422
 
 
2423
    def test_convert_invalid(self):
 
2424
        opt = self.get_option()
 
2425
        # A string that is not recognized as an integer
 
2426
        self.assertConvertInvalid(opt, u'forty-two')
 
2427
        # A list of strings is never recognized as an integer
 
2428
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2429
 
 
2430
    def test_convert_valid(self):
 
2431
        opt = self.get_option()
 
2432
        self.assertConverted(16, opt, u'16')
 
2433
 
 
2434
 
 
2435
class TestOptionWithSIUnitConverter(tests.TestCase, TestOptionConverterMixin):
 
2436
 
 
2437
    def get_option(self):
 
2438
        return config.Option('foo', help='An integer in SI units.',
 
2439
                             from_unicode=config.int_SI_from_store)
 
2440
 
 
2441
    def test_convert_invalid(self):
 
2442
        opt = self.get_option()
 
2443
        self.assertConvertInvalid(opt, u'not-a-unit')
 
2444
        self.assertConvertInvalid(opt, u'Gb') # Forgot the int
 
2445
        self.assertConvertInvalid(opt, u'1b') # Forgot the unit
 
2446
        self.assertConvertInvalid(opt, u'1GG')
 
2447
        self.assertConvertInvalid(opt, u'1Mbb')
 
2448
        self.assertConvertInvalid(opt, u'1MM')
 
2449
 
 
2450
    def test_convert_valid(self):
 
2451
        opt = self.get_option()
 
2452
        self.assertConverted(int(5e3), opt, u'5kb')
 
2453
        self.assertConverted(int(5e6), opt, u'5M')
 
2454
        self.assertConverted(int(5e6), opt, u'5MB')
 
2455
        self.assertConverted(int(5e9), opt, u'5g')
 
2456
        self.assertConverted(int(5e9), opt, u'5gB')
 
2457
        self.assertConverted(100, opt, u'100')
 
2458
 
 
2459
 
 
2460
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
 
2461
 
 
2462
    def get_option(self):
 
2463
        return config.Option('foo', help='A list.',
 
2464
                             from_unicode=config.list_from_store)
 
2465
 
 
2466
    def test_convert_invalid(self):
 
2467
        # No string is invalid as all forms can be converted to a list
 
2468
        pass
 
2469
 
 
2470
    def test_convert_valid(self):
 
2471
        opt = self.get_option()
 
2472
        # An empty string is an empty list
 
2473
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2474
        self.assertConverted([], opt, u'')
 
2475
        # A boolean
 
2476
        self.assertConverted([u'True'], opt, u'True')
 
2477
        # An integer
 
2478
        self.assertConverted([u'42'], opt, u'42')
 
2479
        # A single string
 
2480
        self.assertConverted([u'bar'], opt, u'bar')
 
2481
        # A list remains a list (configObj will turn a string containing commas
 
2482
        # into a list, but that's not what we're testing here)
 
2483
        self.assertConverted([u'foo', u'1', u'True'],
 
2484
                             opt, [u'foo', u'1', u'True'])
 
2485
 
 
2486
 
 
2487
class TestOptionConverterMixin(object):
 
2488
 
 
2489
    def assertConverted(self, expected, opt, value):
 
2490
        self.assertEquals(expected, opt.convert_from_unicode(value))
 
2491
 
 
2492
    def assertWarns(self, opt, value):
 
2493
        warnings = []
 
2494
        def warning(*args):
 
2495
            warnings.append(args[0] % args[1:])
 
2496
        self.overrideAttr(trace, 'warning', warning)
 
2497
        self.assertEquals(None, opt.convert_from_unicode(value))
 
2498
        self.assertLength(1, warnings)
 
2499
        self.assertEquals(
 
2500
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2501
            warnings[0])
 
2502
 
 
2503
    def assertErrors(self, opt, value):
 
2504
        self.assertRaises(errors.ConfigOptionValueError,
 
2505
                          opt.convert_from_unicode, value)
 
2506
 
 
2507
    def assertConvertInvalid(self, opt, invalid_value):
 
2508
        opt.invalid = None
 
2509
        self.assertEquals(None, opt.convert_from_unicode(invalid_value))
 
2510
        opt.invalid = 'warning'
 
2511
        self.assertWarns(opt, invalid_value)
 
2512
        opt.invalid = 'error'
 
2513
        self.assertErrors(opt, invalid_value)
 
2514
 
 
2515
 
 
2516
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2517
 
 
2518
    def get_option(self):
 
2519
        return config.Option('foo', help='A boolean.',
 
2520
                             from_unicode=config.bool_from_store)
 
2521
 
 
2522
    def test_convert_invalid(self):
 
2523
        opt = self.get_option()
 
2524
        # A string that is not recognized as a boolean
 
2525
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2526
        # A list of strings is never recognized as a boolean
 
2527
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2528
 
 
2529
    def test_convert_valid(self):
 
2530
        opt = self.get_option()
 
2531
        self.assertConverted(True, opt, u'True')
 
2532
        self.assertConverted(True, opt, u'1')
 
2533
        self.assertConverted(False, opt, u'False')
 
2534
 
 
2535
 
 
2536
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2537
 
 
2538
    def get_option(self):
 
2539
        return config.Option('foo', help='An integer.',
 
2540
                             from_unicode=config.int_from_store)
 
2541
 
 
2542
    def test_convert_invalid(self):
 
2543
        opt = self.get_option()
 
2544
        # A string that is not recognized as an integer
 
2545
        self.assertConvertInvalid(opt, u'forty-two')
 
2546
        # A list of strings is never recognized as an integer
 
2547
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2548
 
 
2549
    def test_convert_valid(self):
 
2550
        opt = self.get_option()
 
2551
        self.assertConverted(16, opt, u'16')
 
2552
 
 
2553
 
 
2554
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
 
2555
 
 
2556
    def get_option(self):
 
2557
        return config.Option('foo', help='A list.',
 
2558
                             from_unicode=config.list_from_store)
 
2559
 
 
2560
    def test_convert_invalid(self):
 
2561
        opt = self.get_option()
 
2562
        # We don't even try to convert a list into a list, we only expect
 
2563
        # strings
 
2564
        self.assertConvertInvalid(opt, [1])
 
2565
        # No string is invalid as all forms can be converted to a list
 
2566
 
 
2567
    def test_convert_valid(self):
 
2568
        opt = self.get_option()
 
2569
        # An empty string is an empty list
 
2570
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2571
        self.assertConverted([], opt, u'')
 
2572
        # A boolean
 
2573
        self.assertConverted([u'True'], opt, u'True')
 
2574
        # An integer
 
2575
        self.assertConverted([u'42'], opt, u'42')
 
2576
        # A single string
 
2577
        self.assertConverted([u'bar'], opt, u'bar')
 
2578
 
 
2579
 
 
2580
class TestOptionRegistry(tests.TestCase):
 
2581
 
 
2582
    def setUp(self):
 
2583
        super(TestOptionRegistry, self).setUp()
 
2584
        # Always start with an empty registry
 
2585
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2586
        self.registry = config.option_registry
 
2587
 
 
2588
    def test_register(self):
 
2589
        opt = config.Option('foo')
 
2590
        self.registry.register(opt)
 
2591
        self.assertIs(opt, self.registry.get('foo'))
 
2592
 
 
2593
    def test_registered_help(self):
 
2594
        opt = config.Option('foo', help='A simple option')
 
2595
        self.registry.register(opt)
 
2596
        self.assertEquals('A simple option', self.registry.get_help('foo'))
 
2597
 
 
2598
    lazy_option = config.Option('lazy_foo', help='Lazy help')
 
2599
 
 
2600
    def test_register_lazy(self):
 
2601
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2602
                                    'TestOptionRegistry.lazy_option')
 
2603
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
 
2604
 
 
2605
    def test_registered_lazy_help(self):
 
2606
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2607
                                    'TestOptionRegistry.lazy_option')
 
2608
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
 
2609
 
 
2610
 
 
2611
class TestRegisteredOptions(tests.TestCase):
 
2612
    """All registered options should verify some constraints."""
 
2613
 
 
2614
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
 
2615
                 in config.option_registry.iteritems()]
 
2616
 
 
2617
    def setUp(self):
 
2618
        super(TestRegisteredOptions, self).setUp()
 
2619
        self.registry = config.option_registry
 
2620
 
 
2621
    def test_proper_name(self):
 
2622
        # An option should be registered under its own name, this can't be
 
2623
        # checked at registration time for the lazy ones.
 
2624
        self.assertEquals(self.option_name, self.option.name)
 
2625
 
 
2626
    def test_help_is_set(self):
 
2627
        option_help = self.registry.get_help(self.option_name)
 
2628
        self.assertNotEquals(None, option_help)
 
2629
        # Come on, think about the user, he really wants to know what the
 
2630
        # option is about
 
2631
        self.assertIsNot(None, option_help)
 
2632
        self.assertNotEquals('', option_help)
 
2633
 
 
2634
 
 
2635
class TestSection(tests.TestCase):
 
2636
 
 
2637
    # FIXME: Parametrize so that all sections produced by Stores run these
 
2638
    # tests -- vila 2011-04-01
 
2639
 
 
2640
    def test_get_a_value(self):
 
2641
        a_dict = dict(foo='bar')
 
2642
        section = config.Section('myID', a_dict)
 
2643
        self.assertEquals('bar', section.get('foo'))
 
2644
 
 
2645
    def test_get_unknown_option(self):
 
2646
        a_dict = dict()
 
2647
        section = config.Section(None, a_dict)
 
2648
        self.assertEquals('out of thin air',
 
2649
                          section.get('foo', 'out of thin air'))
 
2650
 
 
2651
    def test_options_is_shared(self):
 
2652
        a_dict = dict()
 
2653
        section = config.Section(None, a_dict)
 
2654
        self.assertIs(a_dict, section.options)
 
2655
 
 
2656
 
 
2657
class TestMutableSection(tests.TestCase):
 
2658
 
 
2659
    scenarios = [('mutable',
 
2660
                  {'get_section':
 
2661
                       lambda opts: config.MutableSection('myID', opts)},),
 
2662
        ]
 
2663
 
 
2664
    def test_set(self):
 
2665
        a_dict = dict(foo='bar')
 
2666
        section = self.get_section(a_dict)
 
2667
        section.set('foo', 'new_value')
 
2668
        self.assertEquals('new_value', section.get('foo'))
 
2669
        # The change appears in the shared section
 
2670
        self.assertEquals('new_value', a_dict.get('foo'))
 
2671
        # We keep track of the change
 
2672
        self.assertTrue('foo' in section.orig)
 
2673
        self.assertEquals('bar', section.orig.get('foo'))
 
2674
 
 
2675
    def test_set_preserve_original_once(self):
 
2676
        a_dict = dict(foo='bar')
 
2677
        section = self.get_section(a_dict)
 
2678
        section.set('foo', 'first_value')
 
2679
        section.set('foo', 'second_value')
 
2680
        # We keep track of the original value
 
2681
        self.assertTrue('foo' in section.orig)
 
2682
        self.assertEquals('bar', section.orig.get('foo'))
 
2683
 
 
2684
    def test_remove(self):
 
2685
        a_dict = dict(foo='bar')
 
2686
        section = self.get_section(a_dict)
 
2687
        section.remove('foo')
 
2688
        # We get None for unknown options via the default value
 
2689
        self.assertEquals(None, section.get('foo'))
 
2690
        # Or we just get the default value
 
2691
        self.assertEquals('unknown', section.get('foo', 'unknown'))
 
2692
        self.assertFalse('foo' in section.options)
 
2693
        # We keep track of the deletion
 
2694
        self.assertTrue('foo' in section.orig)
 
2695
        self.assertEquals('bar', section.orig.get('foo'))
 
2696
 
 
2697
    def test_remove_new_option(self):
 
2698
        a_dict = dict()
 
2699
        section = self.get_section(a_dict)
 
2700
        section.set('foo', 'bar')
 
2701
        section.remove('foo')
 
2702
        self.assertFalse('foo' in section.options)
 
2703
        # The option didn't exist initially so it we need to keep track of it
 
2704
        # with a special value
 
2705
        self.assertTrue('foo' in section.orig)
 
2706
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
 
2707
 
 
2708
 
 
2709
class TestCommandLineStore(tests.TestCase):
 
2710
 
 
2711
    def setUp(self):
 
2712
        super(TestCommandLineStore, self).setUp()
 
2713
        self.store = config.CommandLineStore()
 
2714
 
 
2715
    def get_section(self):
 
2716
        """Get the unique section for the command line overrides."""
 
2717
        sections = list(self.store.get_sections())
 
2718
        self.assertLength(1, sections)
 
2719
        store, section = sections[0]
 
2720
        self.assertEquals(self.store, store)
 
2721
        return section
 
2722
 
 
2723
    def test_no_override(self):
 
2724
        self.store._from_cmdline([])
 
2725
        section = self.get_section()
 
2726
        self.assertLength(0, list(section.iter_option_names()))
 
2727
 
 
2728
    def test_simple_override(self):
 
2729
        self.store._from_cmdline(['a=b'])
 
2730
        section = self.get_section()
 
2731
        self.assertEqual('b', section.get('a'))
 
2732
 
 
2733
    def test_list_override(self):
 
2734
        self.store._from_cmdline(['l=1,2,3'])
 
2735
        val = self.get_section().get('l')
 
2736
        self.assertEqual('1,2,3', val)
 
2737
        # Reminder: lists should be registered as such explicitely, otherwise
 
2738
        # the conversion needs to be done afterwards.
 
2739
        self.assertEqual(['1', '2', '3'], config.list_from_store(val))
 
2740
 
 
2741
    def test_multiple_overrides(self):
 
2742
        self.store._from_cmdline(['a=b', 'x=y'])
 
2743
        section = self.get_section()
 
2744
        self.assertEquals('b', section.get('a'))
 
2745
        self.assertEquals('y', section.get('x'))
 
2746
 
 
2747
    def test_wrong_syntax(self):
 
2748
        self.assertRaises(errors.BzrCommandError,
 
2749
                          self.store._from_cmdline, ['a=b', 'c'])
 
2750
 
 
2751
 
 
2752
class TestStore(tests.TestCaseWithTransport):
 
2753
 
 
2754
    def assertSectionContent(self, expected, (store, section)):
 
2755
        """Assert that some options have the proper values in a section."""
 
2756
        expected_name, expected_options = expected
 
2757
        self.assertEquals(expected_name, section.id)
 
2758
        self.assertEquals(
 
2759
            expected_options,
 
2760
            dict([(k, section.get(k)) for k in expected_options.keys()]))
 
2761
 
 
2762
 
 
2763
class TestReadonlyStore(TestStore):
 
2764
 
 
2765
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2766
                 in config.test_store_builder_registry.iteritems()]
 
2767
 
 
2768
    def test_building_delays_load(self):
 
2769
        store = self.get_store(self)
 
2770
        self.assertEquals(False, store.is_loaded())
 
2771
        store._load_from_string('')
 
2772
        self.assertEquals(True, store.is_loaded())
 
2773
 
 
2774
    def test_get_no_sections_for_empty(self):
 
2775
        store = self.get_store(self)
 
2776
        store._load_from_string('')
 
2777
        self.assertEquals([], list(store.get_sections()))
 
2778
 
 
2779
    def test_get_default_section(self):
 
2780
        store = self.get_store(self)
 
2781
        store._load_from_string('foo=bar')
 
2782
        sections = list(store.get_sections())
 
2783
        self.assertLength(1, sections)
 
2784
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2785
 
 
2786
    def test_get_named_section(self):
 
2787
        store = self.get_store(self)
 
2788
        store._load_from_string('[baz]\nfoo=bar')
 
2789
        sections = list(store.get_sections())
 
2790
        self.assertLength(1, sections)
 
2791
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2792
 
 
2793
    def test_load_from_string_fails_for_non_empty_store(self):
 
2794
        store = self.get_store(self)
 
2795
        store._load_from_string('foo=bar')
 
2796
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
 
2797
 
 
2798
 
 
2799
class TestIniFileStoreContent(tests.TestCaseWithTransport):
 
2800
    """Simulate loading a config store with content of various encodings.
 
2801
 
 
2802
    All files produced by bzr are in utf8 content.
 
2803
 
 
2804
    Users may modify them manually and end up with a file that can't be
 
2805
    loaded. We need to issue proper error messages in this case.
 
2806
    """
 
2807
 
 
2808
    invalid_utf8_char = '\xff'
 
2809
 
 
2810
    def test_load_utf8(self):
 
2811
        """Ensure we can load an utf8-encoded file."""
 
2812
        t = self.get_transport()
 
2813
        # From http://pad.lv/799212
 
2814
        unicode_user = u'b\N{Euro Sign}ar'
 
2815
        unicode_content = u'user=%s' % (unicode_user,)
 
2816
        utf8_content = unicode_content.encode('utf8')
 
2817
        # Store the raw content in the config file
 
2818
        t.put_bytes('foo.conf', utf8_content)
 
2819
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2820
        store.load()
 
2821
        stack = config.Stack([store.get_sections], store)
 
2822
        self.assertEquals(unicode_user, stack.get('user'))
 
2823
 
 
2824
    def test_load_non_ascii(self):
 
2825
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2826
        t = self.get_transport()
 
2827
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2828
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2829
        self.assertRaises(errors.ConfigContentError, store.load)
 
2830
 
 
2831
    def test_load_erroneous_content(self):
 
2832
        """Ensure we display a proper error on content that can't be parsed."""
 
2833
        t = self.get_transport()
 
2834
        t.put_bytes('foo.conf', '[open_section\n')
 
2835
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2836
        self.assertRaises(errors.ParseConfigError, store.load)
 
2837
 
 
2838
    def test_load_permission_denied(self):
 
2839
        """Ensure we get warned when trying to load an inaccessible file."""
 
2840
        warnings = []
 
2841
        def warning(*args):
 
2842
            warnings.append(args[0] % args[1:])
 
2843
        self.overrideAttr(trace, 'warning', warning)
 
2844
 
 
2845
        t = self.get_transport()
 
2846
 
 
2847
        def get_bytes(relpath):
 
2848
            raise errors.PermissionDenied(relpath, "")
 
2849
        t.get_bytes = get_bytes
 
2850
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2851
        self.assertRaises(errors.PermissionDenied, store.load)
 
2852
        self.assertEquals(
 
2853
            warnings,
 
2854
            [u'Permission denied while trying to load configuration store %s.'
 
2855
             % store.external_url()])
 
2856
 
 
2857
 
 
2858
class TestIniConfigContent(tests.TestCaseWithTransport):
 
2859
    """Simulate loading a IniBasedConfig with content of various encodings.
 
2860
 
 
2861
    All files produced by bzr are in utf8 content.
 
2862
 
 
2863
    Users may modify them manually and end up with a file that can't be
 
2864
    loaded. We need to issue proper error messages in this case.
 
2865
    """
 
2866
 
 
2867
    invalid_utf8_char = '\xff'
 
2868
 
 
2869
    def test_load_utf8(self):
 
2870
        """Ensure we can load an utf8-encoded file."""
 
2871
        # From http://pad.lv/799212
 
2872
        unicode_user = u'b\N{Euro Sign}ar'
 
2873
        unicode_content = u'user=%s' % (unicode_user,)
 
2874
        utf8_content = unicode_content.encode('utf8')
 
2875
        # Store the raw content in the config file
 
2876
        with open('foo.conf', 'wb') as f:
 
2877
            f.write(utf8_content)
 
2878
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2879
        self.assertEquals(unicode_user, conf.get_user_option('user'))
 
2880
 
 
2881
    def test_load_badly_encoded_content(self):
 
2882
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2883
        with open('foo.conf', 'wb') as f:
 
2884
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2885
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2886
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
 
2887
 
 
2888
    def test_load_erroneous_content(self):
 
2889
        """Ensure we display a proper error on content that can't be parsed."""
 
2890
        with open('foo.conf', 'wb') as f:
 
2891
            f.write('[open_section\n')
 
2892
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2893
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
 
2894
 
 
2895
 
 
2896
class TestMutableStore(TestStore):
 
2897
 
 
2898
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
 
2899
                 in config.test_store_builder_registry.iteritems()]
 
2900
 
 
2901
    def setUp(self):
 
2902
        super(TestMutableStore, self).setUp()
 
2903
        self.transport = self.get_transport()
 
2904
 
 
2905
    def has_store(self, store):
 
2906
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
2907
                                               store.external_url())
 
2908
        return self.transport.has(store_basename)
 
2909
 
 
2910
    def test_save_empty_creates_no_file(self):
 
2911
        # FIXME: There should be a better way than relying on the test
 
2912
        # parametrization to identify branch.conf -- vila 2011-0526
 
2913
        if self.store_id in ('branch', 'remote_branch'):
 
2914
            raise tests.TestNotApplicable(
 
2915
                'branch.conf is *always* created when a branch is initialized')
 
2916
        store = self.get_store(self)
 
2917
        store.save()
 
2918
        self.assertEquals(False, self.has_store(store))
 
2919
 
 
2920
    def test_save_emptied_succeeds(self):
 
2921
        store = self.get_store(self)
 
2922
        store._load_from_string('foo=bar\n')
 
2923
        section = store.get_mutable_section(None)
 
2924
        section.remove('foo')
 
2925
        store.save()
 
2926
        self.assertEquals(True, self.has_store(store))
 
2927
        modified_store = self.get_store(self)
 
2928
        sections = list(modified_store.get_sections())
 
2929
        self.assertLength(0, sections)
 
2930
 
 
2931
    def test_save_with_content_succeeds(self):
 
2932
        # FIXME: There should be a better way than relying on the test
 
2933
        # parametrization to identify branch.conf -- vila 2011-0526
 
2934
        if self.store_id in ('branch', 'remote_branch'):
 
2935
            raise tests.TestNotApplicable(
 
2936
                'branch.conf is *always* created when a branch is initialized')
 
2937
        store = self.get_store(self)
 
2938
        store._load_from_string('foo=bar\n')
 
2939
        self.assertEquals(False, self.has_store(store))
 
2940
        store.save()
 
2941
        self.assertEquals(True, self.has_store(store))
 
2942
        modified_store = self.get_store(self)
 
2943
        sections = list(modified_store.get_sections())
 
2944
        self.assertLength(1, sections)
 
2945
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2946
 
 
2947
    def test_set_option_in_empty_store(self):
 
2948
        store = self.get_store(self)
 
2949
        section = store.get_mutable_section(None)
 
2950
        section.set('foo', 'bar')
 
2951
        store.save()
 
2952
        modified_store = self.get_store(self)
 
2953
        sections = list(modified_store.get_sections())
 
2954
        self.assertLength(1, sections)
 
2955
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2956
 
 
2957
    def test_set_option_in_default_section(self):
 
2958
        store = self.get_store(self)
 
2959
        store._load_from_string('')
 
2960
        section = store.get_mutable_section(None)
 
2961
        section.set('foo', 'bar')
 
2962
        store.save()
 
2963
        modified_store = self.get_store(self)
 
2964
        sections = list(modified_store.get_sections())
 
2965
        self.assertLength(1, sections)
 
2966
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2967
 
 
2968
    def test_set_option_in_named_section(self):
 
2969
        store = self.get_store(self)
 
2970
        store._load_from_string('')
 
2971
        section = store.get_mutable_section('baz')
 
2972
        section.set('foo', 'bar')
 
2973
        store.save()
 
2974
        modified_store = self.get_store(self)
 
2975
        sections = list(modified_store.get_sections())
 
2976
        self.assertLength(1, sections)
 
2977
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2978
 
 
2979
    def test_load_hook(self):
 
2980
        # We first needs to ensure that the store exists
 
2981
        store = self.get_store(self)
 
2982
        section = store.get_mutable_section('baz')
 
2983
        section.set('foo', 'bar')
 
2984
        store.save()
 
2985
        # Now we can try to load it
 
2986
        store = self.get_store(self)
 
2987
        calls = []
 
2988
        def hook(*args):
 
2989
            calls.append(args)
 
2990
        config.ConfigHooks.install_named_hook('load', hook, None)
 
2991
        self.assertLength(0, calls)
 
2992
        store.load()
 
2993
        self.assertLength(1, calls)
 
2994
        self.assertEquals((store,), calls[0])
 
2995
 
 
2996
    def test_save_hook(self):
 
2997
        calls = []
 
2998
        def hook(*args):
 
2999
            calls.append(args)
 
3000
        config.ConfigHooks.install_named_hook('save', hook, None)
 
3001
        self.assertLength(0, calls)
 
3002
        store = self.get_store(self)
 
3003
        section = store.get_mutable_section('baz')
 
3004
        section.set('foo', 'bar')
 
3005
        store.save()
 
3006
        self.assertLength(1, calls)
 
3007
        self.assertEquals((store,), calls[0])
 
3008
 
 
3009
 
 
3010
class TestTransportIniFileStore(TestStore):
 
3011
 
 
3012
    def test_loading_unknown_file_fails(self):
 
3013
        store = config.TransportIniFileStore(self.get_transport(),
 
3014
            'I-do-not-exist')
 
3015
        self.assertRaises(errors.NoSuchFile, store.load)
 
3016
 
 
3017
    def test_invalid_content(self):
 
3018
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3019
        self.assertEquals(False, store.is_loaded())
 
3020
        exc = self.assertRaises(
 
3021
            errors.ParseConfigError, store._load_from_string,
 
3022
            'this is invalid !')
 
3023
        self.assertEndsWith(exc.filename, 'foo.conf')
 
3024
        # And the load failed
 
3025
        self.assertEquals(False, store.is_loaded())
 
3026
 
 
3027
    def test_get_embedded_sections(self):
 
3028
        # A more complicated example (which also shows that section names and
 
3029
        # option names share the same name space...)
 
3030
        # FIXME: This should be fixed by forbidding dicts as values ?
 
3031
        # -- vila 2011-04-05
 
3032
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3033
        store._load_from_string('''
 
3034
foo=bar
 
3035
l=1,2
 
3036
[DEFAULT]
 
3037
foo_in_DEFAULT=foo_DEFAULT
 
3038
[bar]
 
3039
foo_in_bar=barbar
 
3040
[baz]
 
3041
foo_in_baz=barbaz
 
3042
[[qux]]
 
3043
foo_in_qux=quux
 
3044
''')
 
3045
        sections = list(store.get_sections())
 
3046
        self.assertLength(4, sections)
 
3047
        # The default section has no name.
 
3048
        # List values are provided as strings and need to be explicitly
 
3049
        # converted by specifying from_unicode=list_from_store at option
 
3050
        # registration
 
3051
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
 
3052
                                  sections[0])
 
3053
        self.assertSectionContent(
 
3054
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
 
3055
        self.assertSectionContent(
 
3056
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
 
3057
        # sub sections are provided as embedded dicts.
 
3058
        self.assertSectionContent(
 
3059
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
 
3060
            sections[3])
 
3061
 
 
3062
 
 
3063
class TestLockableIniFileStore(TestStore):
 
3064
 
 
3065
    def test_create_store_in_created_dir(self):
 
3066
        self.assertPathDoesNotExist('dir')
 
3067
        t = self.get_transport('dir/subdir')
 
3068
        store = config.LockableIniFileStore(t, 'foo.conf')
 
3069
        store.get_mutable_section(None).set('foo', 'bar')
 
3070
        store.save()
 
3071
        self.assertPathExists('dir/subdir')
 
3072
 
 
3073
 
 
3074
class TestConcurrentStoreUpdates(TestStore):
 
3075
    """Test that Stores properly handle conccurent updates.
 
3076
 
 
3077
    New Store implementation may fail some of these tests but until such
 
3078
    implementations exist it's hard to properly filter them from the scenarios
 
3079
    applied here. If you encounter such a case, contact the bzr devs.
 
3080
    """
 
3081
 
 
3082
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3083
                 in config.test_stack_builder_registry.iteritems()]
 
3084
 
 
3085
    def setUp(self):
 
3086
        super(TestConcurrentStoreUpdates, self).setUp()
 
3087
        self.stack = self.get_stack(self)
 
3088
        if not isinstance(self.stack, config._CompatibleStack):
 
3089
            raise tests.TestNotApplicable(
 
3090
                '%s is not meant to be compatible with the old config design'
 
3091
                % (self.stack,))
 
3092
        self.stack.set('one', '1')
 
3093
        self.stack.set('two', '2')
 
3094
        # Flush the store
 
3095
        self.stack.store.save()
 
3096
 
 
3097
    def test_simple_read_access(self):
 
3098
        self.assertEquals('1', self.stack.get('one'))
 
3099
 
 
3100
    def test_simple_write_access(self):
 
3101
        self.stack.set('one', 'one')
 
3102
        self.assertEquals('one', self.stack.get('one'))
 
3103
 
 
3104
    def test_listen_to_the_last_speaker(self):
 
3105
        c1 = self.stack
 
3106
        c2 = self.get_stack(self)
 
3107
        c1.set('one', 'ONE')
 
3108
        c2.set('two', 'TWO')
 
3109
        self.assertEquals('ONE', c1.get('one'))
 
3110
        self.assertEquals('TWO', c2.get('two'))
 
3111
        # The second update respect the first one
 
3112
        self.assertEquals('ONE', c2.get('one'))
 
3113
 
 
3114
    def test_last_speaker_wins(self):
 
3115
        # If the same config is not shared, the same variable modified twice
 
3116
        # can only see a single result.
 
3117
        c1 = self.stack
 
3118
        c2 = self.get_stack(self)
 
3119
        c1.set('one', 'c1')
 
3120
        c2.set('one', 'c2')
 
3121
        self.assertEquals('c2', c2.get('one'))
 
3122
        # The first modification is still available until another refresh
 
3123
        # occur
 
3124
        self.assertEquals('c1', c1.get('one'))
 
3125
        c1.set('two', 'done')
 
3126
        self.assertEquals('c2', c1.get('one'))
 
3127
 
 
3128
    def test_writes_are_serialized(self):
 
3129
        c1 = self.stack
 
3130
        c2 = self.get_stack(self)
 
3131
 
 
3132
        # We spawn a thread that will pause *during* the config saving.
 
3133
        before_writing = threading.Event()
 
3134
        after_writing = threading.Event()
 
3135
        writing_done = threading.Event()
 
3136
        c1_save_without_locking_orig = c1.store.save_without_locking
 
3137
        def c1_save_without_locking():
 
3138
            before_writing.set()
 
3139
            c1_save_without_locking_orig()
 
3140
            # The lock is held. We wait for the main thread to decide when to
 
3141
            # continue
 
3142
            after_writing.wait()
 
3143
        c1.store.save_without_locking = c1_save_without_locking
 
3144
        def c1_set():
 
3145
            c1.set('one', 'c1')
 
3146
            writing_done.set()
 
3147
        t1 = threading.Thread(target=c1_set)
 
3148
        # Collect the thread after the test
 
3149
        self.addCleanup(t1.join)
 
3150
        # Be ready to unblock the thread if the test goes wrong
 
3151
        self.addCleanup(after_writing.set)
 
3152
        t1.start()
 
3153
        before_writing.wait()
 
3154
        self.assertRaises(errors.LockContention,
 
3155
                          c2.set, 'one', 'c2')
 
3156
        self.assertEquals('c1', c1.get('one'))
 
3157
        # Let the lock be released
 
3158
        after_writing.set()
 
3159
        writing_done.wait()
 
3160
        c2.set('one', 'c2')
 
3161
        self.assertEquals('c2', c2.get('one'))
 
3162
 
 
3163
    def test_read_while_writing(self):
 
3164
       c1 = self.stack
 
3165
       # We spawn a thread that will pause *during* the write
 
3166
       ready_to_write = threading.Event()
 
3167
       do_writing = threading.Event()
 
3168
       writing_done = threading.Event()
 
3169
       # We override the _save implementation so we know the store is locked
 
3170
       c1_save_without_locking_orig = c1.store.save_without_locking
 
3171
       def c1_save_without_locking():
 
3172
           ready_to_write.set()
 
3173
           # The lock is held. We wait for the main thread to decide when to
 
3174
           # continue
 
3175
           do_writing.wait()
 
3176
           c1_save_without_locking_orig()
 
3177
           writing_done.set()
 
3178
       c1.store.save_without_locking = c1_save_without_locking
 
3179
       def c1_set():
 
3180
           c1.set('one', 'c1')
 
3181
       t1 = threading.Thread(target=c1_set)
 
3182
       # Collect the thread after the test
 
3183
       self.addCleanup(t1.join)
 
3184
       # Be ready to unblock the thread if the test goes wrong
 
3185
       self.addCleanup(do_writing.set)
 
3186
       t1.start()
 
3187
       # Ensure the thread is ready to write
 
3188
       ready_to_write.wait()
 
3189
       self.assertEquals('c1', c1.get('one'))
 
3190
       # If we read during the write, we get the old value
 
3191
       c2 = self.get_stack(self)
 
3192
       self.assertEquals('1', c2.get('one'))
 
3193
       # Let the writing occur and ensure it occurred
 
3194
       do_writing.set()
 
3195
       writing_done.wait()
 
3196
       # Now we get the updated value
 
3197
       c3 = self.get_stack(self)
 
3198
       self.assertEquals('c1', c3.get('one'))
 
3199
 
 
3200
    # FIXME: It may be worth looking into removing the lock dir when it's not
 
3201
    # needed anymore and look at possible fallouts for concurrent lockers. This
 
3202
    # will matter if/when we use config files outside of bazaar directories
 
3203
    # (.bazaar or .bzr) -- vila 20110-04-111
 
3204
 
 
3205
 
 
3206
class TestSectionMatcher(TestStore):
 
3207
 
 
3208
    scenarios = [('location', {'matcher': config.LocationMatcher}),
 
3209
                 ('id', {'matcher': config.NameMatcher}),]
 
3210
 
 
3211
    def setUp(self):
 
3212
        super(TestSectionMatcher, self).setUp()
 
3213
        # Any simple store is good enough
 
3214
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3215
 
 
3216
    def test_no_matches_for_empty_stores(self):
 
3217
        store = self.get_store(self)
 
3218
        store._load_from_string('')
 
3219
        matcher = self.matcher(store, '/bar')
 
3220
        self.assertEquals([], list(matcher.get_sections()))
 
3221
 
 
3222
    def test_build_doesnt_load_store(self):
 
3223
        store = self.get_store(self)
 
3224
        matcher = self.matcher(store, '/bar')
 
3225
        self.assertFalse(store.is_loaded())
 
3226
 
 
3227
 
 
3228
class TestLocationSection(tests.TestCase):
 
3229
 
 
3230
    def get_section(self, options, extra_path):
 
3231
        section = config.Section('foo', options)
 
3232
        # We don't care about the length so we use '0'
 
3233
        return config.LocationSection(section, 0, extra_path)
 
3234
 
 
3235
    def test_simple_option(self):
 
3236
        section = self.get_section({'foo': 'bar'}, '')
 
3237
        self.assertEquals('bar', section.get('foo'))
 
3238
 
 
3239
    def test_option_with_extra_path(self):
 
3240
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
 
3241
                                   'baz')
 
3242
        self.assertEquals('bar/baz', section.get('foo'))
 
3243
 
 
3244
    def test_invalid_policy(self):
 
3245
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
 
3246
                                   'baz')
 
3247
        # invalid policies are ignored
 
3248
        self.assertEquals('bar', section.get('foo'))
 
3249
 
 
3250
 
 
3251
class TestLocationMatcher(TestStore):
 
3252
 
 
3253
    def setUp(self):
 
3254
        super(TestLocationMatcher, self).setUp()
 
3255
        # Any simple store is good enough
 
3256
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3257
 
 
3258
    def test_unrelated_section_excluded(self):
 
3259
        store = self.get_store(self)
 
3260
        store._load_from_string('''
 
3261
[/foo]
 
3262
section=/foo
 
3263
[/foo/baz]
 
3264
section=/foo/baz
 
3265
[/foo/bar]
 
3266
section=/foo/bar
 
3267
[/foo/bar/baz]
 
3268
section=/foo/bar/baz
 
3269
[/quux/quux]
 
3270
section=/quux/quux
 
3271
''')
 
3272
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
 
3273
                           '/quux/quux'],
 
3274
                          [section.id for _, section in store.get_sections()])
 
3275
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
 
3276
        sections = [section for s, section in matcher.get_sections()]
 
3277
        self.assertEquals([3, 2],
 
3278
                          [section.length for section in sections])
 
3279
        self.assertEquals(['/foo/bar', '/foo'],
 
3280
                          [section.id for section in sections])
 
3281
        self.assertEquals(['quux', 'bar/quux'],
 
3282
                          [section.extra_path for section in sections])
 
3283
 
 
3284
    def test_more_specific_sections_first(self):
 
3285
        store = self.get_store(self)
 
3286
        store._load_from_string('''
 
3287
[/foo]
 
3288
section=/foo
 
3289
[/foo/bar]
 
3290
section=/foo/bar
 
3291
''')
 
3292
        self.assertEquals(['/foo', '/foo/bar'],
 
3293
                          [section.id for _, section in store.get_sections()])
 
3294
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
 
3295
        sections = [section for s, section in matcher.get_sections()]
 
3296
        self.assertEquals([3, 2],
 
3297
                          [section.length for section in sections])
 
3298
        self.assertEquals(['/foo/bar', '/foo'],
 
3299
                          [section.id for section in sections])
 
3300
        self.assertEquals(['baz', 'bar/baz'],
 
3301
                          [section.extra_path for section in sections])
 
3302
 
 
3303
    def test_appendpath_in_no_name_section(self):
 
3304
        # It's a bit weird to allow appendpath in a no-name section, but
 
3305
        # someone may found a use for it
 
3306
        store = self.get_store(self)
 
3307
        store._load_from_string('''
 
3308
foo=bar
 
3309
foo:policy = appendpath
 
3310
''')
 
3311
        matcher = config.LocationMatcher(store, 'dir/subdir')
 
3312
        sections = list(matcher.get_sections())
 
3313
        self.assertLength(1, sections)
 
3314
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
 
3315
 
 
3316
    def test_file_urls_are_normalized(self):
 
3317
        store = self.get_store(self)
 
3318
        if sys.platform == 'win32':
 
3319
            expected_url = 'file:///C:/dir/subdir'
 
3320
            expected_location = 'C:/dir/subdir'
 
3321
        else:
 
3322
            expected_url = 'file:///dir/subdir'
 
3323
            expected_location = '/dir/subdir'
 
3324
        matcher = config.LocationMatcher(store, expected_url)
 
3325
        self.assertEquals(expected_location, matcher.location)
 
3326
 
 
3327
 
 
3328
class TestNameMatcher(TestStore):
 
3329
 
 
3330
    def setUp(self):
 
3331
        super(TestNameMatcher, self).setUp()
 
3332
        self.matcher = config.NameMatcher
 
3333
        # Any simple store is good enough
 
3334
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3335
 
 
3336
    def get_matching_sections(self, name):
 
3337
        store = self.get_store(self)
 
3338
        store._load_from_string('''
 
3339
[foo]
 
3340
option=foo
 
3341
[foo/baz]
 
3342
option=foo/baz
 
3343
[bar]
 
3344
option=bar
 
3345
''')
 
3346
        matcher = self.matcher(store, name)
 
3347
        return list(matcher.get_sections())
 
3348
 
 
3349
    def test_matching(self):
 
3350
        sections = self.get_matching_sections('foo')
 
3351
        self.assertLength(1, sections)
 
3352
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
 
3353
 
 
3354
    def test_not_matching(self):
 
3355
        sections = self.get_matching_sections('baz')
 
3356
        self.assertLength(0, sections)
 
3357
 
 
3358
 
 
3359
class TestStackGet(tests.TestCase):
 
3360
 
 
3361
    # FIXME: This should be parametrized for all known Stack or dedicated
 
3362
    # paramerized tests created to avoid bloating -- vila 2011-03-31
 
3363
 
 
3364
    def overrideOptionRegistry(self):
 
3365
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3366
 
 
3367
    def test_single_config_get(self):
 
3368
        conf = dict(foo='bar')
 
3369
        conf_stack = config.Stack([conf])
 
3370
        self.assertEquals('bar', conf_stack.get('foo'))
 
3371
 
 
3372
    def test_get_with_registered_default_value(self):
 
3373
        conf_stack = config.Stack([dict()])
 
3374
        opt = config.Option('foo', default='bar')
 
3375
        self.overrideOptionRegistry()
 
3376
        config.option_registry.register('foo', opt)
 
3377
        self.assertEquals('bar', conf_stack.get('foo'))
 
3378
 
 
3379
    def test_get_without_registered_default_value(self):
 
3380
        conf_stack = config.Stack([dict()])
 
3381
        opt = config.Option('foo')
 
3382
        self.overrideOptionRegistry()
 
3383
        config.option_registry.register('foo', opt)
 
3384
        self.assertEquals(None, conf_stack.get('foo'))
 
3385
 
 
3386
    def test_get_without_default_value_for_not_registered(self):
 
3387
        conf_stack = config.Stack([dict()])
 
3388
        opt = config.Option('foo')
 
3389
        self.overrideOptionRegistry()
 
3390
        self.assertEquals(None, conf_stack.get('foo'))
 
3391
 
 
3392
    def test_get_first_definition(self):
 
3393
        conf1 = dict(foo='bar')
 
3394
        conf2 = dict(foo='baz')
 
3395
        conf_stack = config.Stack([conf1, conf2])
 
3396
        self.assertEquals('bar', conf_stack.get('foo'))
 
3397
 
 
3398
    def test_get_embedded_definition(self):
 
3399
        conf1 = dict(yy='12')
 
3400
        conf2 = config.Stack([dict(xx='42'), dict(foo='baz')])
 
3401
        conf_stack = config.Stack([conf1, conf2])
 
3402
        self.assertEquals('baz', conf_stack.get('foo'))
 
3403
 
 
3404
    def test_get_for_empty_section_callable(self):
 
3405
        conf_stack = config.Stack([lambda : []])
 
3406
        self.assertEquals(None, conf_stack.get('foo'))
 
3407
 
 
3408
    def test_get_for_broken_callable(self):
 
3409
        # Trying to use and invalid callable raises an exception on first use
 
3410
        conf_stack = config.Stack([lambda : object()])
 
3411
        self.assertRaises(TypeError, conf_stack.get, 'foo')
 
3412
 
 
3413
 
 
3414
class TestStackWithTransport(tests.TestCaseWithTransport):
 
3415
 
 
3416
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3417
                 in config.test_stack_builder_registry.iteritems()]
 
3418
 
 
3419
 
 
3420
class TestConcreteStacks(TestStackWithTransport):
 
3421
 
 
3422
    def test_build_stack(self):
 
3423
        # Just a smoke test to help debug builders
 
3424
        stack = self.get_stack(self)
 
3425
 
 
3426
 
 
3427
class TestStackGet(TestStackWithTransport):
 
3428
 
 
3429
    def setUp(self):
 
3430
        super(TestStackGet, self).setUp()
 
3431
        self.conf = self.get_stack(self)
 
3432
 
 
3433
    def test_get_for_empty_stack(self):
 
3434
        self.assertEquals(None, self.conf.get('foo'))
 
3435
 
 
3436
    def test_get_hook(self):
 
3437
        self.conf.set('foo', 'bar')
 
3438
        calls = []
 
3439
        def hook(*args):
 
3440
            calls.append(args)
 
3441
        config.ConfigHooks.install_named_hook('get', hook, None)
 
3442
        self.assertLength(0, calls)
 
3443
        value = self.conf.get('foo')
 
3444
        self.assertEquals('bar', value)
 
3445
        self.assertLength(1, calls)
 
3446
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
 
3447
 
 
3448
 
 
3449
class TestStackGetWithConverter(tests.TestCaseWithTransport):
 
3450
 
 
3451
    def setUp(self):
 
3452
        super(TestStackGetWithConverter, self).setUp()
 
3453
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3454
        self.registry = config.option_registry
 
3455
        # We just want a simple stack with a simple store so we can inject
 
3456
        # whatever content the tests need without caring about what section
 
3457
        # names are valid for a given store/stack.
 
3458
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3459
        self.conf = config.Stack([store.get_sections], store)
 
3460
 
 
3461
    def register_bool_option(self, name, default=None, default_from_env=None):
 
3462
        b = config.Option(name, help='A boolean.',
 
3463
                          default=default, default_from_env=default_from_env,
 
3464
                          from_unicode=config.bool_from_store)
 
3465
        self.registry.register(b)
 
3466
 
 
3467
    def test_get_default_bool_None(self):
 
3468
        self.register_bool_option('foo')
 
3469
        self.assertEquals(None, self.conf.get('foo'))
 
3470
 
 
3471
    def test_get_default_bool_True(self):
 
3472
        self.register_bool_option('foo', u'True')
 
3473
        self.assertEquals(True, self.conf.get('foo'))
 
3474
 
 
3475
    def test_get_default_bool_False(self):
 
3476
        self.register_bool_option('foo', False)
 
3477
        self.assertEquals(False, self.conf.get('foo'))
 
3478
 
 
3479
    def test_get_default_bool_False_as_string(self):
 
3480
        self.register_bool_option('foo', u'False')
 
3481
        self.assertEquals(False, self.conf.get('foo'))
 
3482
 
 
3483
    def test_get_default_bool_from_env_converted(self):
 
3484
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
 
3485
        self.overrideEnv('FOO', 'False')
 
3486
        self.assertEquals(False, self.conf.get('foo'))
 
3487
 
 
3488
    def test_get_default_bool_when_conversion_fails(self):
 
3489
        self.register_bool_option('foo', default='True')
 
3490
        self.conf.store._load_from_string('foo=invalid boolean')
 
3491
        self.assertEquals(True, self.conf.get('foo'))
 
3492
 
 
3493
    def register_integer_option(self, name,
 
3494
                                default=None, default_from_env=None):
 
3495
        i = config.Option(name, help='An integer.',
 
3496
                          default=default, default_from_env=default_from_env,
 
3497
                          from_unicode=config.int_from_store)
 
3498
        self.registry.register(i)
 
3499
 
 
3500
    def test_get_default_integer_None(self):
 
3501
        self.register_integer_option('foo')
 
3502
        self.assertEquals(None, self.conf.get('foo'))
 
3503
 
 
3504
    def test_get_default_integer(self):
 
3505
        self.register_integer_option('foo', 42)
 
3506
        self.assertEquals(42, self.conf.get('foo'))
 
3507
 
 
3508
    def test_get_default_integer_as_string(self):
 
3509
        self.register_integer_option('foo', u'42')
 
3510
        self.assertEquals(42, self.conf.get('foo'))
 
3511
 
 
3512
    def test_get_default_integer_from_env(self):
 
3513
        self.register_integer_option('foo', default_from_env=['FOO'])
 
3514
        self.overrideEnv('FOO', '18')
 
3515
        self.assertEquals(18, self.conf.get('foo'))
 
3516
 
 
3517
    def test_get_default_integer_when_conversion_fails(self):
 
3518
        self.register_integer_option('foo', default='12')
 
3519
        self.conf.store._load_from_string('foo=invalid integer')
 
3520
        self.assertEquals(12, self.conf.get('foo'))
 
3521
 
 
3522
    def register_list_option(self, name, default=None, default_from_env=None):
 
3523
        l = config.Option(name, help='A list.',
 
3524
                          default=default, default_from_env=default_from_env,
 
3525
                          from_unicode=config.list_from_store)
 
3526
        self.registry.register(l)
 
3527
 
 
3528
    def test_get_default_list_None(self):
 
3529
        self.register_list_option('foo')
 
3530
        self.assertEquals(None, self.conf.get('foo'))
 
3531
 
 
3532
    def test_get_default_list_empty(self):
 
3533
        self.register_list_option('foo', '')
 
3534
        self.assertEquals([], self.conf.get('foo'))
 
3535
 
 
3536
    def test_get_default_list_from_env(self):
 
3537
        self.register_list_option('foo', default_from_env=['FOO'])
 
3538
        self.overrideEnv('FOO', '')
 
3539
        self.assertEquals([], self.conf.get('foo'))
 
3540
 
 
3541
    def test_get_with_list_converter_no_item(self):
 
3542
        self.register_list_option('foo', None)
 
3543
        self.conf.store._load_from_string('foo=,')
 
3544
        self.assertEquals([], self.conf.get('foo'))
 
3545
 
 
3546
    def test_get_with_list_converter_many_items(self):
 
3547
        self.register_list_option('foo', None)
 
3548
        self.conf.store._load_from_string('foo=m,o,r,e')
 
3549
        self.assertEquals(['m', 'o', 'r', 'e'], self.conf.get('foo'))
 
3550
 
 
3551
    def test_get_with_list_converter_embedded_spaces_many_items(self):
 
3552
        self.register_list_option('foo', None)
 
3553
        self.conf.store._load_from_string('foo=" bar", "baz "')
 
3554
        self.assertEquals([' bar', 'baz '], self.conf.get('foo'))
 
3555
 
 
3556
    def test_get_with_list_converter_stripped_spaces_many_items(self):
 
3557
        self.register_list_option('foo', None)
 
3558
        self.conf.store._load_from_string('foo= bar ,  baz ')
 
3559
        self.assertEquals(['bar', 'baz'], self.conf.get('foo'))
 
3560
 
 
3561
 
 
3562
class TestIterOptionRefs(tests.TestCase):
 
3563
    """iter_option_refs is a bit unusual, document some cases."""
 
3564
 
 
3565
    def assertRefs(self, expected, string):
 
3566
        self.assertEquals(expected, list(config.iter_option_refs(string)))
 
3567
 
 
3568
    def test_empty(self):
 
3569
        self.assertRefs([(False, '')], '')
 
3570
 
 
3571
    def test_no_refs(self):
 
3572
        self.assertRefs([(False, 'foo bar')], 'foo bar')
 
3573
 
 
3574
    def test_single_ref(self):
 
3575
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
 
3576
 
 
3577
    def test_broken_ref(self):
 
3578
        self.assertRefs([(False, '{foo')], '{foo')
 
3579
 
 
3580
    def test_embedded_ref(self):
 
3581
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
 
3582
                        '{{foo}}')
 
3583
 
 
3584
    def test_two_refs(self):
 
3585
        self.assertRefs([(False, ''), (True, '{foo}'),
 
3586
                         (False, ''), (True, '{bar}'),
 
3587
                         (False, ''),],
 
3588
                        '{foo}{bar}')
 
3589
 
 
3590
    def test_newline_in_refs_are_not_matched(self):
 
3591
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
 
3592
 
 
3593
 
 
3594
class TestStackExpandOptions(tests.TestCaseWithTransport):
 
3595
 
 
3596
    def setUp(self):
 
3597
        super(TestStackExpandOptions, self).setUp()
 
3598
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3599
        self.registry = config.option_registry
 
3600
        self.conf = build_branch_stack(self)
 
3601
 
 
3602
    def assertExpansion(self, expected, string, env=None):
 
3603
        self.assertEquals(expected, self.conf.expand_options(string, env))
 
3604
 
 
3605
    def test_no_expansion(self):
 
3606
        self.assertExpansion('foo', 'foo')
 
3607
 
 
3608
    def test_expand_default_value(self):
 
3609
        self.conf.store._load_from_string('bar=baz')
 
3610
        self.registry.register(config.Option('foo', default=u'{bar}'))
 
3611
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3612
 
 
3613
    def test_expand_default_from_env(self):
 
3614
        self.conf.store._load_from_string('bar=baz')
 
3615
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
 
3616
        self.overrideEnv('FOO', '{bar}')
 
3617
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3618
 
 
3619
    def test_expand_default_on_failed_conversion(self):
 
3620
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
 
3621
        self.registry.register(
 
3622
            config.Option('foo', default=u'{bar}',
 
3623
                          from_unicode=config.int_from_store))
 
3624
        self.assertEquals(42, self.conf.get('foo', expand=True))
 
3625
 
 
3626
    def test_env_adding_options(self):
 
3627
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3628
 
 
3629
    def test_env_overriding_options(self):
 
3630
        self.conf.store._load_from_string('foo=baz')
 
3631
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3632
 
 
3633
    def test_simple_ref(self):
 
3634
        self.conf.store._load_from_string('foo=xxx')
 
3635
        self.assertExpansion('xxx', '{foo}')
 
3636
 
 
3637
    def test_unknown_ref(self):
 
3638
        self.assertRaises(errors.ExpandingUnknownOption,
 
3639
                          self.conf.expand_options, '{foo}')
 
3640
 
 
3641
    def test_indirect_ref(self):
 
3642
        self.conf.store._load_from_string('''
 
3643
foo=xxx
 
3644
bar={foo}
 
3645
''')
 
3646
        self.assertExpansion('xxx', '{bar}')
 
3647
 
 
3648
    def test_embedded_ref(self):
 
3649
        self.conf.store._load_from_string('''
 
3650
foo=xxx
 
3651
bar=foo
 
3652
''')
 
3653
        self.assertExpansion('xxx', '{{bar}}')
 
3654
 
 
3655
    def test_simple_loop(self):
 
3656
        self.conf.store._load_from_string('foo={foo}')
 
3657
        self.assertRaises(errors.OptionExpansionLoop,
 
3658
                          self.conf.expand_options, '{foo}')
 
3659
 
 
3660
    def test_indirect_loop(self):
 
3661
        self.conf.store._load_from_string('''
 
3662
foo={bar}
 
3663
bar={baz}
 
3664
baz={foo}''')
 
3665
        e = self.assertRaises(errors.OptionExpansionLoop,
 
3666
                              self.conf.expand_options, '{foo}')
 
3667
        self.assertEquals('foo->bar->baz', e.refs)
 
3668
        self.assertEquals('{foo}', e.string)
 
3669
 
 
3670
    def test_list(self):
 
3671
        self.conf.store._load_from_string('''
 
3672
foo=start
 
3673
bar=middle
 
3674
baz=end
 
3675
list={foo},{bar},{baz}
 
3676
''')
 
3677
        self.registry.register(
 
3678
            config.Option('list', from_unicode=config.list_from_store))
 
3679
        self.assertEquals(['start', 'middle', 'end'],
 
3680
                           self.conf.get('list', expand=True))
 
3681
 
 
3682
    def test_cascading_list(self):
 
3683
        self.conf.store._load_from_string('''
 
3684
foo=start,{bar}
 
3685
bar=middle,{baz}
 
3686
baz=end
 
3687
list={foo}
 
3688
''')
 
3689
        self.registry.register(
 
3690
            config.Option('list', from_unicode=config.list_from_store))
 
3691
        self.assertEquals(['start', 'middle', 'end'],
 
3692
                           self.conf.get('list', expand=True))
 
3693
 
 
3694
    def test_pathologically_hidden_list(self):
 
3695
        self.conf.store._load_from_string('''
 
3696
foo=bin
 
3697
bar=go
 
3698
start={foo
 
3699
middle=},{
 
3700
end=bar}
 
3701
hidden={start}{middle}{end}
 
3702
''')
 
3703
        # What matters is what the registration says, the conversion happens
 
3704
        # only after all expansions have been performed
 
3705
        self.registry.register(
 
3706
            config.Option('hidden', from_unicode=config.list_from_store))
 
3707
        self.assertEquals(['bin', 'go'],
 
3708
                          self.conf.get('hidden', expand=True))
 
3709
 
 
3710
 
 
3711
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
 
3712
 
 
3713
    def setUp(self):
 
3714
        super(TestStackCrossSectionsExpand, self).setUp()
 
3715
 
 
3716
    def get_config(self, location, string):
 
3717
        if string is None:
 
3718
            string = ''
 
3719
        # Since we don't save the config we won't strictly require to inherit
 
3720
        # from TestCaseInTempDir, but an error occurs so quickly...
 
3721
        c = config.LocationStack(location)
 
3722
        c.store._load_from_string(string)
 
3723
        return c
 
3724
 
 
3725
    def test_dont_cross_unrelated_section(self):
 
3726
        c = self.get_config('/another/branch/path','''
 
3727
[/one/branch/path]
 
3728
foo = hello
 
3729
bar = {foo}/2
 
3730
 
 
3731
[/another/branch/path]
 
3732
bar = {foo}/2
 
3733
''')
 
3734
        self.assertRaises(errors.ExpandingUnknownOption,
 
3735
                          c.get, 'bar', expand=True)
 
3736
 
 
3737
    def test_cross_related_sections(self):
 
3738
        c = self.get_config('/project/branch/path','''
 
3739
[/project]
 
3740
foo = qu
 
3741
 
 
3742
[/project/branch/path]
 
3743
bar = {foo}ux
 
3744
''')
 
3745
        self.assertEquals('quux', c.get('bar', expand=True))
 
3746
 
 
3747
 
 
3748
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
 
3749
 
 
3750
    def test_cross_global_locations(self):
 
3751
        l_store = config.LocationStore()
 
3752
        l_store._load_from_string('''
 
3753
[/branch]
 
3754
lfoo = loc-foo
 
3755
lbar = {gbar}
 
3756
''')
 
3757
        l_store.save()
 
3758
        g_store = config.GlobalStore()
 
3759
        g_store._load_from_string('''
 
3760
[DEFAULT]
 
3761
gfoo = {lfoo}
 
3762
gbar = glob-bar
 
3763
''')
 
3764
        g_store.save()
 
3765
        stack = config.LocationStack('/branch')
 
3766
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
3767
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
 
3768
 
 
3769
 
 
3770
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
 
3771
 
 
3772
    def test_expand_locals_empty(self):
 
3773
        l_store = config.LocationStore()
 
3774
        l_store._load_from_string('''
 
3775
[/home/user/project]
 
3776
base = {basename}
 
3777
rel = {relpath}
 
3778
''')
 
3779
        l_store.save()
 
3780
        stack = config.LocationStack('/home/user/project/')
 
3781
        self.assertEquals('', stack.get('base', expand=True))
 
3782
        self.assertEquals('', stack.get('rel', expand=True))
 
3783
 
 
3784
    def test_expand_basename_locally(self):
 
3785
        l_store = config.LocationStore()
 
3786
        l_store._load_from_string('''
 
3787
[/home/user/project]
 
3788
bfoo = {basename}
 
3789
''')
 
3790
        l_store.save()
 
3791
        stack = config.LocationStack('/home/user/project/branch')
 
3792
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
3793
 
 
3794
    def test_expand_basename_locally_longer_path(self):
 
3795
        l_store = config.LocationStore()
 
3796
        l_store._load_from_string('''
 
3797
[/home/user]
 
3798
bfoo = {basename}
 
3799
''')
 
3800
        l_store.save()
 
3801
        stack = config.LocationStack('/home/user/project/dir/branch')
 
3802
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
3803
 
 
3804
    def test_expand_relpath_locally(self):
 
3805
        l_store = config.LocationStore()
 
3806
        l_store._load_from_string('''
 
3807
[/home/user/project]
 
3808
lfoo = loc-foo/{relpath}
 
3809
''')
 
3810
        l_store.save()
 
3811
        stack = config.LocationStack('/home/user/project/branch')
 
3812
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
3813
 
 
3814
    def test_expand_relpath_unknonw_in_global(self):
 
3815
        g_store = config.GlobalStore()
 
3816
        g_store._load_from_string('''
 
3817
[DEFAULT]
 
3818
gfoo = {relpath}
 
3819
''')
 
3820
        g_store.save()
 
3821
        stack = config.LocationStack('/home/user/project/branch')
 
3822
        self.assertRaises(errors.ExpandingUnknownOption,
 
3823
                          stack.get, 'gfoo', expand=True)
 
3824
 
 
3825
    def test_expand_local_option_locally(self):
 
3826
        l_store = config.LocationStore()
 
3827
        l_store._load_from_string('''
 
3828
[/home/user/project]
 
3829
lfoo = loc-foo/{relpath}
 
3830
lbar = {gbar}
 
3831
''')
 
3832
        l_store.save()
 
3833
        g_store = config.GlobalStore()
 
3834
        g_store._load_from_string('''
 
3835
[DEFAULT]
 
3836
gfoo = {lfoo}
 
3837
gbar = glob-bar
 
3838
''')
 
3839
        g_store.save()
 
3840
        stack = config.LocationStack('/home/user/project/branch')
 
3841
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
3842
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
 
3843
 
 
3844
    def test_locals_dont_leak(self):
 
3845
        """Make sure we chose the right local in presence of several sections.
 
3846
        """
 
3847
        l_store = config.LocationStore()
 
3848
        l_store._load_from_string('''
 
3849
[/home/user]
 
3850
lfoo = loc-foo/{relpath}
 
3851
[/home/user/project]
 
3852
lfoo = loc-foo/{relpath}
 
3853
''')
 
3854
        l_store.save()
 
3855
        stack = config.LocationStack('/home/user/project/branch')
 
3856
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
3857
        stack = config.LocationStack('/home/user/bar/baz')
 
3858
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
 
3859
 
 
3860
 
 
3861
 
 
3862
class TestStackSet(TestStackWithTransport):
 
3863
 
 
3864
    def test_simple_set(self):
 
3865
        conf = self.get_stack(self)
 
3866
        self.assertEquals(None, conf.get('foo'))
 
3867
        conf.set('foo', 'baz')
 
3868
        # Did we get it back ?
 
3869
        self.assertEquals('baz', conf.get('foo'))
 
3870
 
 
3871
    def test_set_creates_a_new_section(self):
 
3872
        conf = self.get_stack(self)
 
3873
        conf.set('foo', 'baz')
 
3874
        self.assertEquals, 'baz', conf.get('foo')
 
3875
 
 
3876
    def test_set_hook(self):
 
3877
        calls = []
 
3878
        def hook(*args):
 
3879
            calls.append(args)
 
3880
        config.ConfigHooks.install_named_hook('set', hook, None)
 
3881
        self.assertLength(0, calls)
 
3882
        conf = self.get_stack(self)
 
3883
        conf.set('foo', 'bar')
 
3884
        self.assertLength(1, calls)
 
3885
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
 
3886
 
 
3887
 
 
3888
class TestStackRemove(TestStackWithTransport):
 
3889
 
 
3890
    def test_remove_existing(self):
 
3891
        conf = self.get_stack(self)
 
3892
        conf.set('foo', 'bar')
 
3893
        self.assertEquals('bar', conf.get('foo'))
 
3894
        conf.remove('foo')
 
3895
        # Did we get it back ?
 
3896
        self.assertEquals(None, conf.get('foo'))
 
3897
 
 
3898
    def test_remove_unknown(self):
 
3899
        conf = self.get_stack(self)
 
3900
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
 
3901
 
 
3902
    def test_remove_hook(self):
 
3903
        calls = []
 
3904
        def hook(*args):
 
3905
            calls.append(args)
 
3906
        config.ConfigHooks.install_named_hook('remove', hook, None)
 
3907
        self.assertLength(0, calls)
 
3908
        conf = self.get_stack(self)
 
3909
        conf.set('foo', 'bar')
 
3910
        conf.remove('foo')
 
3911
        self.assertLength(1, calls)
 
3912
        self.assertEquals((conf, 'foo'), calls[0])
 
3913
 
 
3914
 
 
3915
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
 
3916
 
 
3917
    def setUp(self):
 
3918
        super(TestConfigGetOptions, self).setUp()
 
3919
        create_configs(self)
 
3920
 
 
3921
    def test_no_variable(self):
 
3922
        # Using branch should query branch, locations and bazaar
 
3923
        self.assertOptions([], self.branch_config)
 
3924
 
 
3925
    def test_option_in_bazaar(self):
 
3926
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3927
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
 
3928
                           self.bazaar_config)
 
3929
 
 
3930
    def test_option_in_locations(self):
 
3931
        self.locations_config.set_user_option('file', 'locations')
 
3932
        self.assertOptions(
 
3933
            [('file', 'locations', self.tree.basedir, 'locations')],
 
3934
            self.locations_config)
 
3935
 
 
3936
    def test_option_in_branch(self):
 
3937
        self.branch_config.set_user_option('file', 'branch')
 
3938
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
 
3939
                           self.branch_config)
 
3940
 
 
3941
    def test_option_in_bazaar_and_branch(self):
 
3942
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3943
        self.branch_config.set_user_option('file', 'branch')
 
3944
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
 
3945
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3946
                           self.branch_config)
 
3947
 
 
3948
    def test_option_in_branch_and_locations(self):
 
3949
        # Hmm, locations override branch :-/
 
3950
        self.locations_config.set_user_option('file', 'locations')
 
3951
        self.branch_config.set_user_option('file', 'branch')
 
3952
        self.assertOptions(
 
3953
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3954
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
3955
            self.branch_config)
 
3956
 
 
3957
    def test_option_in_bazaar_locations_and_branch(self):
 
3958
        self.bazaar_config.set_user_option('file', 'bazaar')
 
3959
        self.locations_config.set_user_option('file', 'locations')
 
3960
        self.branch_config.set_user_option('file', 'branch')
 
3961
        self.assertOptions(
 
3962
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3963
             ('file', 'branch', 'DEFAULT', 'branch'),
 
3964
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3965
            self.branch_config)
 
3966
 
 
3967
 
 
3968
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
 
3969
 
 
3970
    def setUp(self):
 
3971
        super(TestConfigRemoveOption, self).setUp()
 
3972
        create_configs_with_file_option(self)
 
3973
 
 
3974
    def test_remove_in_locations(self):
 
3975
        self.locations_config.remove_user_option('file', self.tree.basedir)
 
3976
        self.assertOptions(
 
3977
            [('file', 'branch', 'DEFAULT', 'branch'),
 
3978
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3979
            self.branch_config)
 
3980
 
 
3981
    def test_remove_in_branch(self):
 
3982
        self.branch_config.remove_user_option('file')
 
3983
        self.assertOptions(
 
3984
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3985
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
3986
            self.branch_config)
 
3987
 
 
3988
    def test_remove_in_bazaar(self):
 
3989
        self.bazaar_config.remove_user_option('file')
 
3990
        self.assertOptions(
 
3991
            [('file', 'locations', self.tree.basedir, 'locations'),
 
3992
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
3993
            self.branch_config)
 
3994
 
 
3995
 
 
3996
class TestConfigGetSections(tests.TestCaseWithTransport):
 
3997
 
 
3998
    def setUp(self):
 
3999
        super(TestConfigGetSections, self).setUp()
 
4000
        create_configs(self)
 
4001
 
 
4002
    def assertSectionNames(self, expected, conf, name=None):
 
4003
        """Check which sections are returned for a given config.
 
4004
 
 
4005
        If fallback configurations exist their sections can be included.
 
4006
 
 
4007
        :param expected: A list of section names.
 
4008
 
 
4009
        :param conf: The configuration that will be queried.
 
4010
 
 
4011
        :param name: An optional section name that will be passed to
 
4012
            get_sections().
 
4013
        """
 
4014
        sections = list(conf._get_sections(name))
 
4015
        self.assertLength(len(expected), sections)
 
4016
        self.assertEqual(expected, [name for name, _, _ in sections])
 
4017
 
 
4018
    def test_bazaar_default_section(self):
 
4019
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
 
4020
 
 
4021
    def test_locations_default_section(self):
 
4022
        # No sections are defined in an empty file
 
4023
        self.assertSectionNames([], self.locations_config)
 
4024
 
 
4025
    def test_locations_named_section(self):
 
4026
        self.locations_config.set_user_option('file', 'locations')
 
4027
        self.assertSectionNames([self.tree.basedir], self.locations_config)
 
4028
 
 
4029
    def test_locations_matching_sections(self):
 
4030
        loc_config = self.locations_config
 
4031
        loc_config.set_user_option('file', 'locations')
 
4032
        # We need to cheat a bit here to create an option in sections above and
 
4033
        # below the 'location' one.
 
4034
        parser = loc_config._get_parser()
 
4035
        # locations.cong deals with '/' ignoring native os.sep
 
4036
        location_names = self.tree.basedir.split('/')
 
4037
        parent = '/'.join(location_names[:-1])
 
4038
        child = '/'.join(location_names + ['child'])
 
4039
        parser[parent] = {}
 
4040
        parser[parent]['file'] = 'parent'
 
4041
        parser[child] = {}
 
4042
        parser[child]['file'] = 'child'
 
4043
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
 
4044
 
 
4045
    def test_branch_data_default_section(self):
 
4046
        self.assertSectionNames([None],
 
4047
                                self.branch_config._get_branch_data_config())
 
4048
 
 
4049
    def test_branch_default_sections(self):
 
4050
        # No sections are defined in an empty locations file
 
4051
        self.assertSectionNames([None, 'DEFAULT'],
 
4052
                                self.branch_config)
 
4053
        # Unless we define an option
 
4054
        self.branch_config._get_location_config().set_user_option(
 
4055
            'file', 'locations')
 
4056
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
 
4057
                                self.branch_config)
 
4058
 
 
4059
    def test_bazaar_named_section(self):
 
4060
        # We need to cheat as the API doesn't give direct access to sections
 
4061
        # other than DEFAULT.
 
4062
        self.bazaar_config.set_alias('bazaar', 'bzr')
 
4063
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
 
4064
 
 
4065
 
1315
4066
class TestAuthenticationConfigFile(tests.TestCase):
1316
4067
    """Test the authentication.conf file matching"""
1317
4068
 
1332
4083
        self.assertEquals({}, conf._get_config())
1333
4084
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
1334
4085
 
 
4086
    def test_non_utf8_config(self):
 
4087
        conf = config.AuthenticationConfig(_file=StringIO(
 
4088
                'foo = bar\xff'))
 
4089
        self.assertRaises(errors.ConfigContentError, conf._get_config)
 
4090
 
1335
4091
    def test_missing_auth_section_header(self):
1336
4092
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
1337
4093
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
1595
4351
 
1596
4352
    def test_username_defaults_prompts(self):
1597
4353
        # HTTP prompts can't be tested here, see test_http.py
1598
 
        self._check_default_username_prompt('FTP %(host)s username: ', 'ftp')
1599
 
        self._check_default_username_prompt(
1600
 
            'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
1601
 
        self._check_default_username_prompt(
1602
 
            'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
 
4354
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
 
4355
        self._check_default_username_prompt(
 
4356
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
 
4357
        self._check_default_username_prompt(
 
4358
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
1603
4359
 
1604
4360
    def test_username_default_no_prompt(self):
1605
4361
        conf = config.AuthenticationConfig()
1611
4367
    def test_password_default_prompts(self):
1612
4368
        # HTTP prompts can't be tested here, see test_http.py
1613
4369
        self._check_default_password_prompt(
1614
 
            'FTP %(user)s@%(host)s password: ', 'ftp')
1615
 
        self._check_default_password_prompt(
1616
 
            'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
1617
 
        self._check_default_password_prompt(
1618
 
            'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
 
4370
            u'FTP %(user)s@%(host)s password: ', 'ftp')
 
4371
        self._check_default_password_prompt(
 
4372
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
 
4373
        self._check_default_password_prompt(
 
4374
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
1619
4375
        # SMTP port handling is a bit special (it's handled if embedded in the
1620
4376
        # host too)
1621
4377
        # FIXME: should we: forbid that, extend it to other schemes, leave
1622
4378
        # things as they are that's fine thank you ?
1623
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1624
 
                                            'smtp')
1625
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1626
 
                                            'smtp', host='bar.org:10025')
1627
 
        self._check_default_password_prompt(
1628
 
            'SMTP %(user)s@%(host)s:%(port)d password: ',
1629
 
            'smtp', port=10025)
 
4379
        self._check_default_password_prompt(
 
4380
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
 
4381
        self._check_default_password_prompt(
 
4382
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
 
4383
        self._check_default_password_prompt(
 
4384
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
1630
4385
 
1631
4386
    def test_ssh_password_emits_warning(self):
1632
4387
        conf = config.AuthenticationConfig(_file=StringIO(
1812
4567
# test_user_prompted ?
1813
4568
class TestAuthenticationRing(tests.TestCaseWithTransport):
1814
4569
    pass
 
4570
 
 
4571
 
 
4572
class TestAutoUserId(tests.TestCase):
 
4573
    """Test inferring an automatic user name."""
 
4574
 
 
4575
    def test_auto_user_id(self):
 
4576
        """Automatic inference of user name.
 
4577
 
 
4578
        This is a bit hard to test in an isolated way, because it depends on
 
4579
        system functions that go direct to /etc or perhaps somewhere else.
 
4580
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
 
4581
        to be able to choose a user name with no configuration.
 
4582
        """
 
4583
        if sys.platform == 'win32':
 
4584
            raise tests.TestSkipped(
 
4585
                "User name inference not implemented on win32")
 
4586
        realname, address = config._auto_user_id()
 
4587
        if os.path.exists('/etc/mailname'):
 
4588
            self.assertIsNot(None, realname)
 
4589
            self.assertIsNot(None, address)
 
4590
        else:
 
4591
            self.assertEquals((None, None), (realname, address))
 
4592
 
 
4593
 
 
4594
class EmailOptionTests(tests.TestCase):
 
4595
 
 
4596
    def test_default_email_uses_BZR_EMAIL(self):
 
4597
        # BZR_EMAIL takes precedence over EMAIL
 
4598
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
 
4599
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4600
        self.assertEquals('jelmer@samba.org', config.default_email())
 
4601
 
 
4602
    def test_default_email_uses_EMAIL(self):
 
4603
        self.overrideEnv('BZR_EMAIL', None)
 
4604
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4605
        self.assertEquals('jelmer@apache.org', config.default_email())
 
4606
 
 
4607
    def test_BZR_EMAIL_overrides(self):
 
4608
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
 
4609
        self.assertEquals('jelmer@apache.org',
 
4610
            config.email_from_store('jelmer@debian.org'))
 
4611
        self.overrideEnv('BZR_EMAIL', None)
 
4612
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
 
4613
        self.assertEquals('jelmer@debian.org',
 
4614
            config.email_from_store('jelmer@debian.org'))