/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_hooks.py

  • Committer: Vincent Ladeuil
  • Date: 2012-01-05 14:26:58 UTC
  • mto: This revision was merged to the branch mainline in revision 6468.
  • Revision ID: v.ladeuil+lp@free.fr-20120105142658-vek3v6pzlxb751s2
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made. 

@only_raises is evil and gave a hard time since any exception during
save_changes() was swallowed.

Possible improvements: 

- add some needs_write_lock decorators to crucial
  methods (_set_config_location ?) but keep locking the branch at higher levels

- decorate branch.unlock to call stack.save if last_lock() it True
  outside of @only_raises scope (evil decorator)

- add @needs_write_lock to stack.set and stack.remove (will probably get
  rid of most testing issues) we probably need a specialized decorator
  that can relay to the store and from there to the branch or whatever is
  needed. This will also helps bzr config to get it right. The
  get_mutable_section trick should not be needed anymore either.

- decorate branch.unlock to call stack.save if last_lock() it True outside
  of @only_raises scope (evil decorator)

Show diffs side-by-side

added added

removed removed

Lines of Context:
19
19
from bzrlib.branch import Branch
20
20
from bzrlib.tests import TestCaseWithTransport
21
21
 
 
22
def _foo_hook():
 
23
    pass
22
24
 
23
25
class TestHooks(TestCaseWithTransport):
24
26
 
51
53
 
52
54
    def test_hooks_no_branch(self):
53
55
        self.run_bzr('hooks')
 
56
 
 
57
    def test_hooks_lazy_with_unnamed_hook(self):
 
58
        self.make_branch('.')
 
59
        def foo(): return
 
60
        Branch.hooks.install_named_hook_lazy('set_rh',
 
61
            'bzrlib.tests.blackbox.test_hooks',
 
62
            '_foo_hook',
 
63
            None)
 
64
        out, err = self.run_bzr('hooks')
 
65
        self._check_hooks_output(out, {'set_rh': ["No hook name"]})
 
66
        
 
67
    def test_hooks_lazy_with_named_hook(self):
 
68
        self.make_branch('.')
 
69
        def foo(): return
 
70
        Branch.hooks.install_named_hook_lazy('set_rh',
 
71
            'bzrlib.tests.blackbox.test_hooks',
 
72
            '_foo_hook',
 
73
            'hook has a name')
 
74
        out, err = self.run_bzr('hooks')
 
75
        self._check_hooks_output(out, {'set_rh': ["hook has a name"]})