/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_join.py

  • Committer: Vincent Ladeuil
  • Date: 2012-01-05 14:26:58 UTC
  • mto: This revision was merged to the branch mainline in revision 6468.
  • Revision ID: v.ladeuil+lp@free.fr-20120105142658-vek3v6pzlxb751s2
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made. 

@only_raises is evil and gave a hard time since any exception during
save_changes() was swallowed.

Possible improvements: 

- add some needs_write_lock decorators to crucial
  methods (_set_config_location ?) but keep locking the branch at higher levels

- decorate branch.unlock to call stack.save if last_lock() it True
  outside of @only_raises scope (evil decorator)

- add @needs_write_lock to stack.set and stack.remove (will probably get
  rid of most testing issues) we probably need a specialized decorator
  that can relay to the store and from there to the branch or whatever is
  needed. This will also helps bzr config to get it right. The
  get_mutable_section trick should not be needed anymore either.

- decorate branch.unlock to call stack.save if last_lock() it True outside
  of @only_raises scope (evil decorator)

Show diffs side-by-side

added added

removed removed

Lines of Context:
74
74
        sub_tree.lock_read()
75
75
        self.addCleanup(sub_tree.unlock)
76
76
        self.assertEqual('file1-id', sub_tree.path2id('file1'))
77
 
        self.assertTrue('file1-id' in sub_tree)
 
77
        self.assertTrue(sub_tree.has_id('file1-id'))
78
78
        self.assertEqual('subtree-root-id', sub_tree.path2id(''))
79
79
        self.assertEqual('', sub_tree.id2path('subtree-root-id'))
80
80
        self.assertIs(None, base_tree.path2id('subtree/file1'))
81
81
        base_tree.lock_read()
82
82
        self.addCleanup(base_tree.unlock)
83
 
        self.assertTrue('file1-id' not in base_tree)
 
83
        self.assertFalse(base_tree.has_id('file1-id'))
84
84
        self.assertEqual('subtree-root-id', base_tree.path2id('subtree'))
85
85
        self.assertEqual('subtree', base_tree.id2path('subtree-root-id'))
86
86
 
95
95
                                retcode=3)
96
96
        self.assertContainsRe(err, r"Can't join trees")
97
97
        self.assertContainsRe(err, r"use bzr upgrade")
98
 
 
99