/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_remerge.py

  • Committer: Vincent Ladeuil
  • Date: 2012-01-05 14:26:58 UTC
  • mto: This revision was merged to the branch mainline in revision 6468.
  • Revision ID: v.ladeuil+lp@free.fr-20120105142658-vek3v6pzlxb751s2
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made. 

@only_raises is evil and gave a hard time since any exception during
save_changes() was swallowed.

Possible improvements: 

- add some needs_write_lock decorators to crucial
  methods (_set_config_location ?) but keep locking the branch at higher levels

- decorate branch.unlock to call stack.save if last_lock() it True
  outside of @only_raises scope (evil decorator)

- add @needs_write_lock to stack.set and stack.remove (will probably get
  rid of most testing issues) we probably need a specialized decorator
  that can relay to the store and from there to the branch or whatever is
  needed. This will also helps bzr config to get it right. The
  get_mutable_section trick should not be needed anymore either.

- decorate branch.unlock to call stack.save if last_lock() it True outside
  of @only_raises scope (evil decorator)

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/blackbox/test_remerge.py
17
17
 
18
18
import os
19
19
 
20
 
from bzrlib.tests.blackbox import ExternalBase
 
20
from bzrlib.tests import TestCaseWithTransport
21
21
from bzrlib.workingtree import WorkingTree
22
22
 
23
23
 
24
 
class TestRemerge(ExternalBase):
 
24
class TestRemerge(TestCaseWithTransport):
25
25
 
26
26
    def make_file(self, name, contents):
27
27
        f = open(name, 'wb')
74
74
                           'remerge hello --merge-type weave',
75
75
                           retcode=1)
76
76
 
77
 
        self.failUnlessExists('hello.OTHER')
78
 
        self.failIfExists('question.OTHER')
 
77
        self.assertPathExists('hello.OTHER')
 
78
        self.assertPathDoesNotExist('question.OTHER')
79
79
 
80
80
        file_id = self.run_bzr('file-id hello')[0]
81
81
        self.run_bzr_error(['hello.THIS is not versioned'],
84
84
        self.run_bzr_error(['conflicts encountered'],
85
85
                           'remerge --merge-type weave', retcode=1)
86
86
 
87
 
        self.failUnlessExists('hello.OTHER')
88
 
        self.failUnless('hello.BASE')
 
87
        self.assertPathExists('hello.OTHER')
 
88
        self.assertTrue('hello.BASE')
89
89
        self.assertFalse('|||||||' in conflict_text)
90
90
        self.assertFalse('hi world' in conflict_text)
91
91