/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_hooks.py

  • Committer: Vincent Ladeuil
  • Date: 2012-01-18 14:09:19 UTC
  • mto: This revision was merged to the branch mainline in revision 6468.
  • Revision ID: v.ladeuil+lp@free.fr-20120118140919-rlvdrhpc0nq1lbwi
Change set/remove to require a lock for the branch config files.

This means that tests (or any plugin for that matter) do not requires an
explicit lock on the branch anymore to change a single option. This also
means the optimisation becomes "opt-in" and as such won't be as
spectacular as it may be and/or harder to get right (nothing fails
anymore).

This reduces the diff by ~300 lines.

Code/tests that were updating more than one config option is still taking
a lock to at least avoid some IOs and demonstrate the benefits through
the decreased number of hpss calls.

The duplication between BranchStack and BranchOnlyStack will be removed
once the same sharing is in place for local config files, at which point
the Stack class itself may be able to host the changes.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_hooks.py
29
29
    install_lazy_named_hook,
30
30
    known_hooks,
31
31
    known_hooks_key_to_object,
 
32
    known_hooks_key_to_parent_and_attribute,
32
33
    )
33
34
from bzrlib.symbol_versioning import (
34
35
    deprecated_in,
37
38
 
38
39
class TestHooks(tests.TestCase):
39
40
 
 
41
    def test_create_hook_first(self):
 
42
        hooks = Hooks("bzrlib.tests.test_hooks", "some_hooks")
 
43
        doc = ("Invoked after changing the tip of a branch object. Called with"
 
44
            "a bzrlib.branch.PostChangeBranchTipParams object")
 
45
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
 
46
        self.applyDeprecated(deprecated_in((2, 4)), hooks.create_hook, hook)
 
47
        self.assertEqual(hook, hooks['post_tip_change'])
 
48
 
 
49
    def test_create_hook_name_collision_errors(self):
 
50
        hooks = Hooks("bzrlib.tests.test_hooks", "some_hooks")
 
51
        doc = ("Invoked after changing the tip of a branch object. Called with"
 
52
            "a bzrlib.branch.PostChangeBranchTipParams object")
 
53
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
 
54
        hook2 = HookPoint("post_tip_change", None, None, None)
 
55
        self.applyDeprecated(deprecated_in((2, 4)), hooks.create_hook, hook)
 
56
        self.assertRaises(errors.DuplicateKey, self.applyDeprecated,
 
57
            deprecated_in((2, 4, 0)), hooks.create_hook, hook2)
 
58
        self.assertEqual(hook, hooks['post_tip_change'])
 
59
 
40
60
    def test_docs(self):
41
61
        """docs() should return something reasonable about the Hooks."""
42
62
        class MyHooks(Hooks):
266
286
        self.assertIs(branch.Branch.hooks,
267
287
            known_hooks_key_to_object(('bzrlib.branch', 'Branch.hooks')))
268
288
 
 
289
    def test_known_hooks_key_to_parent_and_attribute_deprecated(self):
 
290
        self.assertEqual((branch.Branch, 'hooks'),
 
291
            self.applyDeprecated(deprecated_in((2,3)),
 
292
                known_hooks_key_to_parent_and_attribute,
 
293
                ('bzrlib.branch', 'Branch.hooks')))
 
294
        self.assertEqual((branch, 'Branch'),
 
295
            self.applyDeprecated(deprecated_in((2,3)),
 
296
                known_hooks_key_to_parent_and_attribute,
 
297
                ('bzrlib.branch', 'Branch')))
 
298
 
269
299
    def test_known_hooks_key_to_parent_and_attribute(self):
270
300
        self.assertEqual((branch.Branch, 'hooks'),
271
301
            known_hooks.key_to_parent_and_attribute(