/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_config.py

  • Committer: Patch Queue Manager
  • Date: 2012-02-23 19:39:07 UTC
  • mfrom: (6468.3.3 bzr)
  • Revision ID: pqm@pqm.ubuntu.com-20120223193907-11erj8xxjmrchawp
(jelmer) Use Tree.iter_children() in a couple more places. (Jelmer Vernooij)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2012 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
19
19
from cStringIO import StringIO
20
20
import os
21
21
import sys
 
22
import threading
 
23
 
 
24
 
 
25
from testtools import matchers
22
26
 
23
27
#import bzrlib specific imports here
24
28
from bzrlib import (
31
35
    mail_client,
32
36
    ui,
33
37
    urlutils,
 
38
    registry as _mod_registry,
 
39
    remote,
34
40
    tests,
35
41
    trace,
36
 
    transport,
 
42
    )
 
43
from bzrlib.symbol_versioning import (
 
44
    deprecated_in,
 
45
    )
 
46
from bzrlib.transport import remote as transport_remote
 
47
from bzrlib.tests import (
 
48
    features,
 
49
    scenarios,
 
50
    test_server,
37
51
    )
38
52
from bzrlib.util.configobj import configobj
39
53
 
40
54
 
 
55
def lockable_config_scenarios():
 
56
    return [
 
57
        ('global',
 
58
         {'config_class': config.GlobalConfig,
 
59
          'config_args': [],
 
60
          'config_section': 'DEFAULT'}),
 
61
        ('locations',
 
62
         {'config_class': config.LocationConfig,
 
63
          'config_args': ['.'],
 
64
          'config_section': '.'}),]
 
65
 
 
66
 
 
67
load_tests = scenarios.load_tests_apply_scenarios
 
68
 
 
69
# Register helpers to build stores
 
70
config.test_store_builder_registry.register(
 
71
    'configobj', lambda test: config.TransportIniFileStore(
 
72
        test.get_transport(), 'configobj.conf'))
 
73
config.test_store_builder_registry.register(
 
74
    'bazaar', lambda test: config.GlobalStore())
 
75
config.test_store_builder_registry.register(
 
76
    'location', lambda test: config.LocationStore())
 
77
 
 
78
 
 
79
def build_backing_branch(test, relpath,
 
80
                         transport_class=None, server_class=None):
 
81
    """Test helper to create a backing branch only once.
 
82
 
 
83
    Some tests needs multiple stores/stacks to check concurrent update
 
84
    behaviours. As such, they need to build different branch *objects* even if
 
85
    they share the branch on disk.
 
86
 
 
87
    :param relpath: The relative path to the branch. (Note that the helper
 
88
        should always specify the same relpath).
 
89
 
 
90
    :param transport_class: The Transport class the test needs to use.
 
91
 
 
92
    :param server_class: The server associated with the ``transport_class``
 
93
        above.
 
94
 
 
95
    Either both or neither of ``transport_class`` and ``server_class`` should
 
96
    be specified.
 
97
    """
 
98
    if transport_class is not None and server_class is not None:
 
99
        test.transport_class = transport_class
 
100
        test.transport_server = server_class
 
101
    elif not (transport_class is None and server_class is None):
 
102
        raise AssertionError('Specify both ``transport_class`` and '
 
103
                             '``server_class`` or neither of them')
 
104
    if getattr(test, 'backing_branch', None) is None:
 
105
        # First call, let's build the branch on disk
 
106
        test.backing_branch = test.make_branch(relpath)
 
107
 
 
108
 
 
109
def build_branch_store(test):
 
110
    build_backing_branch(test, 'branch')
 
111
    b = branch.Branch.open('branch')
 
112
    return config.BranchStore(b)
 
113
config.test_store_builder_registry.register('branch', build_branch_store)
 
114
 
 
115
 
 
116
def build_control_store(test):
 
117
    build_backing_branch(test, 'branch')
 
118
    b = bzrdir.BzrDir.open('branch')
 
119
    return config.ControlStore(b)
 
120
config.test_store_builder_registry.register('control', build_control_store)
 
121
 
 
122
 
 
123
def build_remote_branch_store(test):
 
124
    # There is only one permutation (but we won't be able to handle more with
 
125
    # this design anyway)
 
126
    (transport_class,
 
127
     server_class) = transport_remote.get_test_permutations()[0]
 
128
    build_backing_branch(test, 'branch', transport_class, server_class)
 
129
    b = branch.Branch.open(test.get_url('branch'))
 
130
    return config.BranchStore(b)
 
131
config.test_store_builder_registry.register('remote_branch',
 
132
                                            build_remote_branch_store)
 
133
 
 
134
 
 
135
config.test_stack_builder_registry.register(
 
136
    'bazaar', lambda test: config.GlobalStack())
 
137
config.test_stack_builder_registry.register(
 
138
    'location', lambda test: config.LocationStack('.'))
 
139
 
 
140
 
 
141
def build_branch_stack(test):
 
142
    build_backing_branch(test, 'branch')
 
143
    b = branch.Branch.open('branch')
 
144
    return config.BranchStack(b)
 
145
config.test_stack_builder_registry.register('branch', build_branch_stack)
 
146
 
 
147
 
 
148
def build_branch_only_stack(test):
 
149
    # There is only one permutation (but we won't be able to handle more with
 
150
    # this design anyway)
 
151
    (transport_class,
 
152
     server_class) = transport_remote.get_test_permutations()[0]
 
153
    build_backing_branch(test, 'branch', transport_class, server_class)
 
154
    b = branch.Branch.open(test.get_url('branch'))
 
155
    return config.BranchOnlyStack(b)
 
156
config.test_stack_builder_registry.register('branch_only',
 
157
                                            build_branch_only_stack)
 
158
 
 
159
def build_remote_control_stack(test):
 
160
    # There is only one permutation (but we won't be able to handle more with
 
161
    # this design anyway)
 
162
    (transport_class,
 
163
     server_class) = transport_remote.get_test_permutations()[0]
 
164
    # We need only a bzrdir for this, not a full branch, but it's not worth
 
165
    # creating a dedicated helper to create only the bzrdir
 
166
    build_backing_branch(test, 'branch', transport_class, server_class)
 
167
    b = branch.Branch.open(test.get_url('branch'))
 
168
    return config.RemoteControlStack(b.bzrdir)
 
169
config.test_stack_builder_registry.register('remote_control',
 
170
                                            build_remote_control_stack)
 
171
 
 
172
 
41
173
sample_long_alias="log -r-15..-1 --line"
42
174
sample_config_text = u"""
43
175
[DEFAULT]
45
177
editor=vim
46
178
change_editor=vimdiff -of @new_path @old_path
47
179
gpg_signing_command=gnome-gpg
 
180
gpg_signing_key=DD4D5088
48
181
log_format=short
 
182
validate_signatures_in_log=true
 
183
acceptable_keys=amy
49
184
user_global_option=something
 
185
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
 
186
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
 
187
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
 
188
bzr.default_mergetool=sometool
50
189
[ALIASES]
51
190
h=help
52
191
ll=""" + sample_long_alias + "\n"
94
233
[/a/]
95
234
check_signatures=check-available
96
235
gpg_signing_command=false
 
236
gpg_signing_key=default
97
237
user_local_option=local
98
238
# test trailing / matching
99
239
[/a/*]
105
245
"""
106
246
 
107
247
 
 
248
def create_configs(test):
 
249
    """Create configuration files for a given test.
 
250
 
 
251
    This requires creating a tree (and populate the ``test.tree`` attribute)
 
252
    and its associated branch and will populate the following attributes:
 
253
 
 
254
    - branch_config: A BranchConfig for the associated branch.
 
255
 
 
256
    - locations_config : A LocationConfig for the associated branch
 
257
 
 
258
    - bazaar_config: A GlobalConfig.
 
259
 
 
260
    The tree and branch are created in a 'tree' subdirectory so the tests can
 
261
    still use the test directory to stay outside of the branch.
 
262
    """
 
263
    tree = test.make_branch_and_tree('tree')
 
264
    test.tree = tree
 
265
    test.branch_config = config.BranchConfig(tree.branch)
 
266
    test.locations_config = config.LocationConfig(tree.basedir)
 
267
    test.bazaar_config = config.GlobalConfig()
 
268
 
 
269
 
 
270
def create_configs_with_file_option(test):
 
271
    """Create configuration files with a ``file`` option set in each.
 
272
 
 
273
    This builds on ``create_configs`` and add one ``file`` option in each
 
274
    configuration with a value which allows identifying the configuration file.
 
275
    """
 
276
    create_configs(test)
 
277
    test.bazaar_config.set_user_option('file', 'bazaar')
 
278
    test.locations_config.set_user_option('file', 'locations')
 
279
    test.branch_config.set_user_option('file', 'branch')
 
280
 
 
281
 
 
282
class TestOptionsMixin:
 
283
 
 
284
    def assertOptions(self, expected, conf):
 
285
        # We don't care about the parser (as it will make tests hard to write
 
286
        # and error-prone anyway)
 
287
        self.assertThat([opt[:4] for opt in conf._get_options()],
 
288
                        matchers.Equals(expected))
 
289
 
 
290
 
108
291
class InstrumentedConfigObj(object):
109
292
    """A config obj look-enough-alike to record calls made to it."""
110
293
 
129
312
        self._calls.append(('keys',))
130
313
        return []
131
314
 
 
315
    def reload(self):
 
316
        self._calls.append(('reload',))
 
317
 
132
318
    def write(self, arg):
133
319
        self._calls.append(('write',))
134
320
 
143
329
 
144
330
class FakeBranch(object):
145
331
 
146
 
    def __init__(self, base=None, user_id=None):
 
332
    def __init__(self, base=None):
147
333
        if base is None:
148
334
            self.base = "http://example.com/branches/demo"
149
335
        else:
150
336
            self.base = base
151
337
        self._transport = self.control_files = \
152
 
            FakeControlFilesAndTransport(user_id=user_id)
 
338
            FakeControlFilesAndTransport()
153
339
 
154
340
    def _get_config(self):
155
341
        return config.TransportConfig(self._transport, 'branch.conf')
163
349
 
164
350
class FakeControlFilesAndTransport(object):
165
351
 
166
 
    def __init__(self, user_id=None):
 
352
    def __init__(self):
167
353
        self.files = {}
168
 
        if user_id:
169
 
            self.files['email'] = user_id
170
354
        self._transport = self
171
355
 
172
 
    def get_utf8(self, filename):
173
 
        # from LockableFiles
174
 
        raise AssertionError("get_utf8 should no longer be used")
175
 
 
176
356
    def get(self, filename):
177
357
        # from Transport
178
358
        try:
240
420
        """
241
421
        co = config.ConfigObj()
242
422
        co['test'] = 'foo#bar'
243
 
        lines = co.write()
 
423
        outfile = StringIO()
 
424
        co.write(outfile=outfile)
 
425
        lines = outfile.getvalue().splitlines()
244
426
        self.assertEqual(lines, ['test = "foo#bar"'])
245
427
        co2 = config.ConfigObj(lines)
246
428
        self.assertEqual(co2['test'], 'foo#bar')
247
429
 
 
430
    def test_triple_quotes(self):
 
431
        # Bug #710410: if the value string has triple quotes
 
432
        # then ConfigObj versions up to 4.7.2 will quote them wrong
 
433
        # and won't able to read them back
 
434
        triple_quotes_value = '''spam
 
435
""" that's my spam """
 
436
eggs'''
 
437
        co = config.ConfigObj()
 
438
        co['test'] = triple_quotes_value
 
439
        # While writing this test another bug in ConfigObj has been found:
 
440
        # method co.write() without arguments produces list of lines
 
441
        # one option per line, and multiline values are not split
 
442
        # across multiple lines,
 
443
        # and that breaks the parsing these lines back by ConfigObj.
 
444
        # This issue only affects test, but it's better to avoid
 
445
        # `co.write()` construct at all.
 
446
        # [bialix 20110222] bug report sent to ConfigObj's author
 
447
        outfile = StringIO()
 
448
        co.write(outfile=outfile)
 
449
        output = outfile.getvalue()
 
450
        # now we're trying to read it back
 
451
        co2 = config.ConfigObj(StringIO(output))
 
452
        self.assertEquals(triple_quotes_value, co2['test'])
 
453
 
248
454
 
249
455
erroneous_config = """[section] # line 1
250
456
good=good # line 2
271
477
        config.Config()
272
478
 
273
479
    def test_no_default_editor(self):
274
 
        self.assertRaises(NotImplementedError, config.Config().get_editor)
 
480
        self.assertRaises(
 
481
            NotImplementedError,
 
482
            self.applyDeprecated, deprecated_in((2, 4, 0)),
 
483
            config.Config().get_editor)
275
484
 
276
485
    def test_user_email(self):
277
486
        my_config = InstrumentedConfig()
286
495
 
287
496
    def test_signatures_default(self):
288
497
        my_config = config.Config()
289
 
        self.assertFalse(my_config.signature_needed())
 
498
        self.assertFalse(
 
499
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
500
                my_config.signature_needed))
290
501
        self.assertEqual(config.CHECK_IF_POSSIBLE,
291
 
                         my_config.signature_checking())
 
502
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
503
                my_config.signature_checking))
292
504
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
293
 
                         my_config.signing_policy())
 
505
                self.applyDeprecated(deprecated_in((2, 5, 0)),
 
506
                    my_config.signing_policy))
294
507
 
295
508
    def test_signatures_template_method(self):
296
509
        my_config = InstrumentedConfig()
297
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
 
510
        self.assertEqual(config.CHECK_NEVER,
 
511
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
512
                my_config.signature_checking))
298
513
        self.assertEqual(['_get_signature_checking'], my_config._calls)
299
514
 
300
515
    def test_signatures_template_method_none(self):
301
516
        my_config = InstrumentedConfig()
302
517
        my_config._signatures = None
303
518
        self.assertEqual(config.CHECK_IF_POSSIBLE,
304
 
                         my_config.signature_checking())
 
519
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
520
                             my_config.signature_checking))
305
521
        self.assertEqual(['_get_signature_checking'], my_config._calls)
306
522
 
307
523
    def test_gpg_signing_command_default(self):
308
524
        my_config = config.Config()
309
 
        self.assertEqual('gpg', my_config.gpg_signing_command())
 
525
        self.assertEqual('gpg',
 
526
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
527
                my_config.gpg_signing_command))
310
528
 
311
529
    def test_get_user_option_default(self):
312
530
        my_config = config.Config()
314
532
 
315
533
    def test_post_commit_default(self):
316
534
        my_config = config.Config()
317
 
        self.assertEqual(None, my_config.post_commit())
 
535
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
536
                                                    my_config.post_commit))
 
537
 
318
538
 
319
539
    def test_log_format_default(self):
320
540
        my_config = config.Config()
321
 
        self.assertEqual('long', my_config.log_format())
 
541
        self.assertEqual('long',
 
542
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
543
                                              my_config.log_format))
 
544
 
 
545
    def test_acceptable_keys_default(self):
 
546
        my_config = config.Config()
 
547
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
548
            my_config.acceptable_keys))
 
549
 
 
550
    def test_validate_signatures_in_log_default(self):
 
551
        my_config = config.Config()
 
552
        self.assertEqual(False, my_config.validate_signatures_in_log())
322
553
 
323
554
    def test_get_change_editor(self):
324
555
        my_config = InstrumentedConfig()
333
564
 
334
565
    def setUp(self):
335
566
        super(TestConfigPath, self).setUp()
336
 
        os.environ['HOME'] = '/home/bogus'
337
 
        os.environ['XDG_CACHE_DIR'] = ''
 
567
        self.overrideEnv('HOME', '/home/bogus')
 
568
        self.overrideEnv('XDG_CACHE_DIR', '')
338
569
        if sys.platform == 'win32':
339
 
            os.environ['BZR_HOME'] = \
340
 
                r'C:\Documents and Settings\bogus\Application Data'
 
570
            self.overrideEnv(
 
571
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
341
572
            self.bzr_home = \
342
573
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
343
574
        else:
346
577
    def test_config_dir(self):
347
578
        self.assertEqual(config.config_dir(), self.bzr_home)
348
579
 
 
580
    def test_config_dir_is_unicode(self):
 
581
        self.assertIsInstance(config.config_dir(), unicode)
 
582
 
349
583
    def test_config_filename(self):
350
584
        self.assertEqual(config.config_filename(),
351
585
                         self.bzr_home + '/bazaar.conf')
352
586
 
353
 
    def test_branches_config_filename(self):
354
 
        self.assertEqual(config.branches_config_filename(),
355
 
                         self.bzr_home + '/branches.conf')
356
 
 
357
587
    def test_locations_config_filename(self):
358
588
        self.assertEqual(config.locations_config_filename(),
359
589
                         self.bzr_home + '/locations.conf')
367
597
            '/home/bogus/.cache')
368
598
 
369
599
 
370
 
class TestIniConfig(tests.TestCase):
 
600
class TestXDGConfigDir(tests.TestCaseInTempDir):
 
601
    # must be in temp dir because config tests for the existence of the bazaar
 
602
    # subdirectory of $XDG_CONFIG_HOME
 
603
 
 
604
    def setUp(self):
 
605
        if sys.platform in ('darwin', 'win32'):
 
606
            raise tests.TestNotApplicable(
 
607
                'XDG config dir not used on this platform')
 
608
        super(TestXDGConfigDir, self).setUp()
 
609
        self.overrideEnv('HOME', self.test_home_dir)
 
610
        # BZR_HOME overrides everything we want to test so unset it.
 
611
        self.overrideEnv('BZR_HOME', None)
 
612
 
 
613
    def test_xdg_config_dir_exists(self):
 
614
        """When ~/.config/bazaar exists, use it as the config dir."""
 
615
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
 
616
        os.makedirs(newdir)
 
617
        self.assertEqual(config.config_dir(), newdir)
 
618
 
 
619
    def test_xdg_config_home(self):
 
620
        """When XDG_CONFIG_HOME is set, use it."""
 
621
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
 
622
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
 
623
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
 
624
        os.makedirs(newdir)
 
625
        self.assertEqual(config.config_dir(), newdir)
 
626
 
 
627
 
 
628
class TestIniConfig(tests.TestCaseInTempDir):
371
629
 
372
630
    def make_config_parser(self, s):
373
 
        conf = config.IniBasedConfig(None)
374
 
        parser = conf._get_parser(file=StringIO(s.encode('utf-8')))
375
 
        return conf, parser
 
631
        conf = config.IniBasedConfig.from_string(s)
 
632
        return conf, conf._get_parser()
376
633
 
377
634
 
378
635
class TestIniConfigBuilding(TestIniConfig):
379
636
 
380
637
    def test_contructs(self):
381
 
        my_config = config.IniBasedConfig("nothing")
 
638
        my_config = config.IniBasedConfig()
382
639
 
383
640
    def test_from_fp(self):
384
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
385
 
        my_config = config.IniBasedConfig(None)
386
 
        self.failUnless(
387
 
            isinstance(my_config._get_parser(file=config_file),
388
 
                        configobj.ConfigObj))
 
641
        my_config = config.IniBasedConfig.from_string(sample_config_text)
 
642
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
389
643
 
390
644
    def test_cached(self):
 
645
        my_config = config.IniBasedConfig.from_string(sample_config_text)
 
646
        parser = my_config._get_parser()
 
647
        self.assertTrue(my_config._get_parser() is parser)
 
648
 
 
649
    def _dummy_chown(self, path, uid, gid):
 
650
        self.path, self.uid, self.gid = path, uid, gid
 
651
 
 
652
    def test_ini_config_ownership(self):
 
653
        """Ensure that chown is happening during _write_config_file"""
 
654
        self.requireFeature(features.chown_feature)
 
655
        self.overrideAttr(os, 'chown', self._dummy_chown)
 
656
        self.path = self.uid = self.gid = None
 
657
        conf = config.IniBasedConfig(file_name='./foo.conf')
 
658
        conf._write_config_file()
 
659
        self.assertEquals(self.path, './foo.conf')
 
660
        self.assertTrue(isinstance(self.uid, int))
 
661
        self.assertTrue(isinstance(self.gid, int))
 
662
 
 
663
    def test_get_filename_parameter_is_deprecated_(self):
 
664
        conf = self.callDeprecated([
 
665
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
 
666
            ' Use file_name instead.'],
 
667
            config.IniBasedConfig, lambda: 'ini.conf')
 
668
        self.assertEqual('ini.conf', conf.file_name)
 
669
 
 
670
    def test_get_parser_file_parameter_is_deprecated_(self):
391
671
        config_file = StringIO(sample_config_text.encode('utf-8'))
392
 
        my_config = config.IniBasedConfig(None)
393
 
        parser = my_config._get_parser(file=config_file)
394
 
        self.failUnless(my_config._get_parser() is parser)
 
672
        conf = config.IniBasedConfig.from_string(sample_config_text)
 
673
        conf = self.callDeprecated([
 
674
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
 
675
            ' Use IniBasedConfig(_content=xxx) instead.'],
 
676
            conf._get_parser, file=config_file)
 
677
 
 
678
 
 
679
class TestIniConfigSaving(tests.TestCaseInTempDir):
 
680
 
 
681
    def test_cant_save_without_a_file_name(self):
 
682
        conf = config.IniBasedConfig()
 
683
        self.assertRaises(AssertionError, conf._write_config_file)
 
684
 
 
685
    def test_saved_with_content(self):
 
686
        content = 'foo = bar\n'
 
687
        conf = config.IniBasedConfig.from_string(
 
688
            content, file_name='./test.conf', save=True)
 
689
        self.assertFileEqual(content, 'test.conf')
 
690
 
 
691
 
 
692
class TestIniConfigOptionExpansionDefaultValue(tests.TestCaseInTempDir):
 
693
    """What is the default value of expand for config options.
 
694
 
 
695
    This is an opt-in beta feature used to evaluate whether or not option
 
696
    references can appear in dangerous place raising exceptions, disapearing
 
697
    (and as such corrupting data) or if it's safe to activate the option by
 
698
    default.
 
699
 
 
700
    Note that these tests relies on config._expand_default_value being already
 
701
    overwritten in the parent class setUp.
 
702
    """
 
703
 
 
704
    def setUp(self):
 
705
        super(TestIniConfigOptionExpansionDefaultValue, self).setUp()
 
706
        self.config = None
 
707
        self.warnings = []
 
708
        def warning(*args):
 
709
            self.warnings.append(args[0] % args[1:])
 
710
        self.overrideAttr(trace, 'warning', warning)
 
711
 
 
712
    def get_config(self, expand):
 
713
        c = config.GlobalConfig.from_string('bzr.config.expand=%s' % (expand,),
 
714
                                            save=True)
 
715
        return c
 
716
 
 
717
    def assertExpandIs(self, expected):
 
718
        actual = config._get_expand_default_value()
 
719
        #self.config.get_user_option_as_bool('bzr.config.expand')
 
720
        self.assertEquals(expected, actual)
 
721
 
 
722
    def test_default_is_None(self):
 
723
        self.assertEquals(None, config._expand_default_value)
 
724
 
 
725
    def test_default_is_False_even_if_None(self):
 
726
        self.config = self.get_config(None)
 
727
        self.assertExpandIs(False)
 
728
 
 
729
    def test_default_is_False_even_if_invalid(self):
 
730
        self.config = self.get_config('<your choice>')
 
731
        self.assertExpandIs(False)
 
732
        # ...
 
733
        # Huh ? My choice is False ? Thanks, always happy to hear that :D
 
734
        # Wait, you've been warned !
 
735
        self.assertLength(1, self.warnings)
 
736
        self.assertEquals(
 
737
            'Value "<your choice>" is not a boolean for "bzr.config.expand"',
 
738
            self.warnings[0])
 
739
 
 
740
    def test_default_is_True(self):
 
741
        self.config = self.get_config(True)
 
742
        self.assertExpandIs(True)
 
743
 
 
744
    def test_default_is_False(self):
 
745
        self.config = self.get_config(False)
 
746
        self.assertExpandIs(False)
 
747
 
 
748
 
 
749
class TestIniConfigOptionExpansion(tests.TestCase):
 
750
    """Test option expansion from the IniConfig level.
 
751
 
 
752
    What we really want here is to test the Config level, but the class being
 
753
    abstract as far as storing values is concerned, this can't be done
 
754
    properly (yet).
 
755
    """
 
756
    # FIXME: This should be rewritten when all configs share a storage
 
757
    # implementation -- vila 2011-02-18
 
758
 
 
759
    def get_config(self, string=None):
 
760
        if string is None:
 
761
            string = ''
 
762
        c = config.IniBasedConfig.from_string(string)
 
763
        return c
 
764
 
 
765
    def assertExpansion(self, expected, conf, string, env=None):
 
766
        self.assertEquals(expected, conf.expand_options(string, env))
 
767
 
 
768
    def test_no_expansion(self):
 
769
        c = self.get_config('')
 
770
        self.assertExpansion('foo', c, 'foo')
 
771
 
 
772
    def test_env_adding_options(self):
 
773
        c = self.get_config('')
 
774
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
775
 
 
776
    def test_env_overriding_options(self):
 
777
        c = self.get_config('foo=baz')
 
778
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
 
779
 
 
780
    def test_simple_ref(self):
 
781
        c = self.get_config('foo=xxx')
 
782
        self.assertExpansion('xxx', c, '{foo}')
 
783
 
 
784
    def test_unknown_ref(self):
 
785
        c = self.get_config('')
 
786
        self.assertRaises(errors.ExpandingUnknownOption,
 
787
                          c.expand_options, '{foo}')
 
788
 
 
789
    def test_indirect_ref(self):
 
790
        c = self.get_config('''
 
791
foo=xxx
 
792
bar={foo}
 
793
''')
 
794
        self.assertExpansion('xxx', c, '{bar}')
 
795
 
 
796
    def test_embedded_ref(self):
 
797
        c = self.get_config('''
 
798
foo=xxx
 
799
bar=foo
 
800
''')
 
801
        self.assertExpansion('xxx', c, '{{bar}}')
 
802
 
 
803
    def test_simple_loop(self):
 
804
        c = self.get_config('foo={foo}')
 
805
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
 
806
 
 
807
    def test_indirect_loop(self):
 
808
        c = self.get_config('''
 
809
foo={bar}
 
810
bar={baz}
 
811
baz={foo}''')
 
812
        e = self.assertRaises(errors.OptionExpansionLoop,
 
813
                              c.expand_options, '{foo}')
 
814
        self.assertEquals('foo->bar->baz', e.refs)
 
815
        self.assertEquals('{foo}', e.string)
 
816
 
 
817
    def test_list(self):
 
818
        conf = self.get_config('''
 
819
foo=start
 
820
bar=middle
 
821
baz=end
 
822
list={foo},{bar},{baz}
 
823
''')
 
824
        self.assertEquals(['start', 'middle', 'end'],
 
825
                           conf.get_user_option('list', expand=True))
 
826
 
 
827
    def test_cascading_list(self):
 
828
        conf = self.get_config('''
 
829
foo=start,{bar}
 
830
bar=middle,{baz}
 
831
baz=end
 
832
list={foo}
 
833
''')
 
834
        self.assertEquals(['start', 'middle', 'end'],
 
835
                           conf.get_user_option('list', expand=True))
 
836
 
 
837
    def test_pathological_hidden_list(self):
 
838
        conf = self.get_config('''
 
839
foo=bin
 
840
bar=go
 
841
start={foo
 
842
middle=},{
 
843
end=bar}
 
844
hidden={start}{middle}{end}
 
845
''')
 
846
        # Nope, it's either a string or a list, and the list wins as soon as a
 
847
        # ',' appears, so the string concatenation never occur.
 
848
        self.assertEquals(['{foo', '}', '{', 'bar}'],
 
849
                          conf.get_user_option('hidden', expand=True))
 
850
 
 
851
 
 
852
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
 
853
 
 
854
    def get_config(self, location, string=None):
 
855
        if string is None:
 
856
            string = ''
 
857
        # Since we don't save the config we won't strictly require to inherit
 
858
        # from TestCaseInTempDir, but an error occurs so quickly...
 
859
        c = config.LocationConfig.from_string(string, location)
 
860
        return c
 
861
 
 
862
    def test_dont_cross_unrelated_section(self):
 
863
        c = self.get_config('/another/branch/path','''
 
864
[/one/branch/path]
 
865
foo = hello
 
866
bar = {foo}/2
 
867
 
 
868
[/another/branch/path]
 
869
bar = {foo}/2
 
870
''')
 
871
        self.assertRaises(errors.ExpandingUnknownOption,
 
872
                          c.get_user_option, 'bar', expand=True)
 
873
 
 
874
    def test_cross_related_sections(self):
 
875
        c = self.get_config('/project/branch/path','''
 
876
[/project]
 
877
foo = qu
 
878
 
 
879
[/project/branch/path]
 
880
bar = {foo}ux
 
881
''')
 
882
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
 
883
 
 
884
 
 
885
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
 
886
 
 
887
    def test_cannot_reload_without_name(self):
 
888
        conf = config.IniBasedConfig.from_string(sample_config_text)
 
889
        self.assertRaises(AssertionError, conf.reload)
 
890
 
 
891
    def test_reload_see_new_value(self):
 
892
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
 
893
                                               file_name='./test/conf')
 
894
        c1._write_config_file()
 
895
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
 
896
                                               file_name='./test/conf')
 
897
        c2._write_config_file()
 
898
        self.assertEqual('vim', c1.get_user_option('editor'))
 
899
        self.assertEqual('emacs', c2.get_user_option('editor'))
 
900
        # Make sure we get the Right value
 
901
        c1.reload()
 
902
        self.assertEqual('emacs', c1.get_user_option('editor'))
 
903
 
 
904
 
 
905
class TestLockableConfig(tests.TestCaseInTempDir):
 
906
 
 
907
    scenarios = lockable_config_scenarios()
 
908
 
 
909
    # Set by load_tests
 
910
    config_class = None
 
911
    config_args = None
 
912
    config_section = None
 
913
 
 
914
    def setUp(self):
 
915
        super(TestLockableConfig, self).setUp()
 
916
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
 
917
        self.config = self.create_config(self._content)
 
918
 
 
919
    def get_existing_config(self):
 
920
        return self.config_class(*self.config_args)
 
921
 
 
922
    def create_config(self, content):
 
923
        kwargs = dict(save=True)
 
924
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
 
925
        return c
 
926
 
 
927
    def test_simple_read_access(self):
 
928
        self.assertEquals('1', self.config.get_user_option('one'))
 
929
 
 
930
    def test_simple_write_access(self):
 
931
        self.config.set_user_option('one', 'one')
 
932
        self.assertEquals('one', self.config.get_user_option('one'))
 
933
 
 
934
    def test_listen_to_the_last_speaker(self):
 
935
        c1 = self.config
 
936
        c2 = self.get_existing_config()
 
937
        c1.set_user_option('one', 'ONE')
 
938
        c2.set_user_option('two', 'TWO')
 
939
        self.assertEquals('ONE', c1.get_user_option('one'))
 
940
        self.assertEquals('TWO', c2.get_user_option('two'))
 
941
        # The second update respect the first one
 
942
        self.assertEquals('ONE', c2.get_user_option('one'))
 
943
 
 
944
    def test_last_speaker_wins(self):
 
945
        # If the same config is not shared, the same variable modified twice
 
946
        # can only see a single result.
 
947
        c1 = self.config
 
948
        c2 = self.get_existing_config()
 
949
        c1.set_user_option('one', 'c1')
 
950
        c2.set_user_option('one', 'c2')
 
951
        self.assertEquals('c2', c2._get_user_option('one'))
 
952
        # The first modification is still available until another refresh
 
953
        # occur
 
954
        self.assertEquals('c1', c1._get_user_option('one'))
 
955
        c1.set_user_option('two', 'done')
 
956
        self.assertEquals('c2', c1._get_user_option('one'))
 
957
 
 
958
    def test_writes_are_serialized(self):
 
959
        c1 = self.config
 
960
        c2 = self.get_existing_config()
 
961
 
 
962
        # We spawn a thread that will pause *during* the write
 
963
        before_writing = threading.Event()
 
964
        after_writing = threading.Event()
 
965
        writing_done = threading.Event()
 
966
        c1_orig = c1._write_config_file
 
967
        def c1_write_config_file():
 
968
            before_writing.set()
 
969
            c1_orig()
 
970
            # The lock is held. We wait for the main thread to decide when to
 
971
            # continue
 
972
            after_writing.wait()
 
973
        c1._write_config_file = c1_write_config_file
 
974
        def c1_set_option():
 
975
            c1.set_user_option('one', 'c1')
 
976
            writing_done.set()
 
977
        t1 = threading.Thread(target=c1_set_option)
 
978
        # Collect the thread after the test
 
979
        self.addCleanup(t1.join)
 
980
        # Be ready to unblock the thread if the test goes wrong
 
981
        self.addCleanup(after_writing.set)
 
982
        t1.start()
 
983
        before_writing.wait()
 
984
        self.assertTrue(c1._lock.is_held)
 
985
        self.assertRaises(errors.LockContention,
 
986
                          c2.set_user_option, 'one', 'c2')
 
987
        self.assertEquals('c1', c1.get_user_option('one'))
 
988
        # Let the lock be released
 
989
        after_writing.set()
 
990
        writing_done.wait()
 
991
        c2.set_user_option('one', 'c2')
 
992
        self.assertEquals('c2', c2.get_user_option('one'))
 
993
 
 
994
    def test_read_while_writing(self):
 
995
       c1 = self.config
 
996
       # We spawn a thread that will pause *during* the write
 
997
       ready_to_write = threading.Event()
 
998
       do_writing = threading.Event()
 
999
       writing_done = threading.Event()
 
1000
       c1_orig = c1._write_config_file
 
1001
       def c1_write_config_file():
 
1002
           ready_to_write.set()
 
1003
           # The lock is held. We wait for the main thread to decide when to
 
1004
           # continue
 
1005
           do_writing.wait()
 
1006
           c1_orig()
 
1007
           writing_done.set()
 
1008
       c1._write_config_file = c1_write_config_file
 
1009
       def c1_set_option():
 
1010
           c1.set_user_option('one', 'c1')
 
1011
       t1 = threading.Thread(target=c1_set_option)
 
1012
       # Collect the thread after the test
 
1013
       self.addCleanup(t1.join)
 
1014
       # Be ready to unblock the thread if the test goes wrong
 
1015
       self.addCleanup(do_writing.set)
 
1016
       t1.start()
 
1017
       # Ensure the thread is ready to write
 
1018
       ready_to_write.wait()
 
1019
       self.assertTrue(c1._lock.is_held)
 
1020
       self.assertEquals('c1', c1.get_user_option('one'))
 
1021
       # If we read during the write, we get the old value
 
1022
       c2 = self.get_existing_config()
 
1023
       self.assertEquals('1', c2.get_user_option('one'))
 
1024
       # Let the writing occur and ensure it occurred
 
1025
       do_writing.set()
 
1026
       writing_done.wait()
 
1027
       # Now we get the updated value
 
1028
       c3 = self.get_existing_config()
 
1029
       self.assertEquals('c1', c3.get_user_option('one'))
395
1030
 
396
1031
 
397
1032
class TestGetUserOptionAs(TestIniConfig):
430
1065
        # automatically cast to list
431
1066
        self.assertEqual(['x'], get_list('one_item'))
432
1067
 
 
1068
    def test_get_user_option_as_int_from_SI(self):
 
1069
        conf, parser = self.make_config_parser("""
 
1070
plain = 100
 
1071
si_k = 5k,
 
1072
si_kb = 5kb,
 
1073
si_m = 5M,
 
1074
si_mb = 5MB,
 
1075
si_g = 5g,
 
1076
si_gb = 5gB,
 
1077
""")
 
1078
        def get_si(s, default=None):
 
1079
            return self.applyDeprecated(
 
1080
                deprecated_in((2, 5, 0)),
 
1081
                conf.get_user_option_as_int_from_SI, s, default)
 
1082
        self.assertEqual(100, get_si('plain'))
 
1083
        self.assertEqual(5000, get_si('si_k'))
 
1084
        self.assertEqual(5000, get_si('si_kb'))
 
1085
        self.assertEqual(5000000, get_si('si_m'))
 
1086
        self.assertEqual(5000000, get_si('si_mb'))
 
1087
        self.assertEqual(5000000000, get_si('si_g'))
 
1088
        self.assertEqual(5000000000, get_si('si_gb'))
 
1089
        self.assertEqual(None, get_si('non-exist'))
 
1090
        self.assertEqual(42, get_si('non-exist-with-default',  42))
 
1091
 
433
1092
 
434
1093
class TestSupressWarning(TestIniConfig):
435
1094
 
462
1121
            parser = my_config._get_parser()
463
1122
        finally:
464
1123
            config.ConfigObj = oldparserclass
465
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1124
        self.assertIsInstance(parser, InstrumentedConfigObj)
466
1125
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
467
1126
                                          'utf-8')])
468
1127
 
479
1138
        my_config = config.BranchConfig(branch)
480
1139
        location_config = my_config._get_location_config()
481
1140
        self.assertEqual(branch.base, location_config.location)
482
 
        self.failUnless(location_config is my_config._get_location_config())
 
1141
        self.assertIs(location_config, my_config._get_location_config())
483
1142
 
484
1143
    def test_get_config(self):
485
1144
        """The Branch.get_config method works properly"""
505
1164
        branch = self.make_branch('branch')
506
1165
        self.assertEqual('branch', branch.nick)
507
1166
 
508
 
        locations = config.locations_config_filename()
509
 
        config.ensure_config_dir_exists()
510
1167
        local_url = urlutils.local_path_to_url('branch')
511
 
        open(locations, 'wb').write('[%s]\nnickname = foobar'
512
 
                                    % (local_url,))
 
1168
        conf = config.LocationConfig.from_string(
 
1169
            '[%s]\nnickname = foobar' % (local_url,),
 
1170
            local_url, save=True)
513
1171
        self.assertEqual('foobar', branch.nick)
514
1172
 
515
1173
    def test_config_local_path(self):
517
1175
        branch = self.make_branch('branch')
518
1176
        self.assertEqual('branch', branch.nick)
519
1177
 
520
 
        locations = config.locations_config_filename()
521
 
        config.ensure_config_dir_exists()
522
 
        open(locations, 'wb').write('[%s/branch]\nnickname = barry'
523
 
                                    % (osutils.getcwd().encode('utf8'),))
 
1178
        local_path = osutils.getcwd().encode('utf8')
 
1179
        conf = config.LocationConfig.from_string(
 
1180
            '[%s/branch]\nnickname = barry' % (local_path,),
 
1181
            'branch',  save=True)
524
1182
        self.assertEqual('barry', branch.nick)
525
1183
 
526
1184
    def test_config_creates_local(self):
527
1185
        """Creating a new entry in config uses a local path."""
528
1186
        branch = self.make_branch('branch', format='knit')
529
1187
        branch.set_push_location('http://foobar')
530
 
        locations = config.locations_config_filename()
531
1188
        local_path = osutils.getcwd().encode('utf8')
532
1189
        # Surprisingly ConfigObj doesn't create a trailing newline
533
 
        self.check_file_contents(locations,
 
1190
        self.check_file_contents(config.locations_config_filename(),
534
1191
                                 '[%s/branch]\n'
535
1192
                                 'push_location = http://foobar\n'
536
1193
                                 'push_location:policy = norecurse\n'
540
1197
        b = self.make_branch('!repo')
541
1198
        self.assertEqual('!repo', b.get_config().get_nickname())
542
1199
 
 
1200
    def test_autonick_uses_branch_name(self):
 
1201
        b = self.make_branch('foo', name='bar')
 
1202
        self.assertEqual('bar', b.get_config().get_nickname())
 
1203
 
543
1204
    def test_warn_if_masked(self):
544
 
        _warning = trace.warning
545
1205
        warnings = []
546
1206
        def warning(*args):
547
1207
            warnings.append(args[0] % args[1:])
 
1208
        self.overrideAttr(trace, 'warning', warning)
548
1209
 
549
1210
        def set_option(store, warn_masked=True):
550
1211
            warnings[:] = []
556
1217
            else:
557
1218
                self.assertEqual(1, len(warnings))
558
1219
                self.assertEqual(warning, warnings[0])
559
 
        trace.warning = warning
560
 
        try:
561
 
            branch = self.make_branch('.')
562
 
            conf = branch.get_config()
563
 
            set_option(config.STORE_GLOBAL)
564
 
            assertWarning(None)
565
 
            set_option(config.STORE_BRANCH)
566
 
            assertWarning(None)
567
 
            set_option(config.STORE_GLOBAL)
568
 
            assertWarning('Value "4" is masked by "3" from branch.conf')
569
 
            set_option(config.STORE_GLOBAL, warn_masked=False)
570
 
            assertWarning(None)
571
 
            set_option(config.STORE_LOCATION)
572
 
            assertWarning(None)
573
 
            set_option(config.STORE_BRANCH)
574
 
            assertWarning('Value "3" is masked by "0" from locations.conf')
575
 
            set_option(config.STORE_BRANCH, warn_masked=False)
576
 
            assertWarning(None)
577
 
        finally:
578
 
            trace.warning = _warning
579
 
 
580
 
 
581
 
class TestGlobalConfigItems(tests.TestCase):
 
1220
        branch = self.make_branch('.')
 
1221
        conf = branch.get_config()
 
1222
        set_option(config.STORE_GLOBAL)
 
1223
        assertWarning(None)
 
1224
        set_option(config.STORE_BRANCH)
 
1225
        assertWarning(None)
 
1226
        set_option(config.STORE_GLOBAL)
 
1227
        assertWarning('Value "4" is masked by "3" from branch.conf')
 
1228
        set_option(config.STORE_GLOBAL, warn_masked=False)
 
1229
        assertWarning(None)
 
1230
        set_option(config.STORE_LOCATION)
 
1231
        assertWarning(None)
 
1232
        set_option(config.STORE_BRANCH)
 
1233
        assertWarning('Value "3" is masked by "0" from locations.conf')
 
1234
        set_option(config.STORE_BRANCH, warn_masked=False)
 
1235
        assertWarning(None)
 
1236
 
 
1237
 
 
1238
class TestGlobalConfigItems(tests.TestCaseInTempDir):
582
1239
 
583
1240
    def test_user_id(self):
584
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
585
 
        my_config = config.GlobalConfig()
586
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1241
        my_config = config.GlobalConfig.from_string(sample_config_text)
587
1242
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
588
1243
                         my_config._get_user_id())
589
1244
 
590
1245
    def test_absent_user_id(self):
591
 
        config_file = StringIO("")
592
1246
        my_config = config.GlobalConfig()
593
 
        my_config._parser = my_config._get_parser(file=config_file)
594
1247
        self.assertEqual(None, my_config._get_user_id())
595
1248
 
596
1249
    def test_configured_editor(self):
597
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
598
 
        my_config = config.GlobalConfig()
599
 
        my_config._parser = my_config._get_parser(file=config_file)
600
 
        self.assertEqual("vim", my_config.get_editor())
 
1250
        my_config = config.GlobalConfig.from_string(sample_config_text)
 
1251
        editor = self.applyDeprecated(
 
1252
            deprecated_in((2, 4, 0)), my_config.get_editor)
 
1253
        self.assertEqual('vim', editor)
601
1254
 
602
1255
    def test_signatures_always(self):
603
 
        config_file = StringIO(sample_always_signatures)
604
 
        my_config = config.GlobalConfig()
605
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1256
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
606
1257
        self.assertEqual(config.CHECK_NEVER,
607
 
                         my_config.signature_checking())
 
1258
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1259
                             my_config.signature_checking))
608
1260
        self.assertEqual(config.SIGN_ALWAYS,
609
 
                         my_config.signing_policy())
610
 
        self.assertEqual(True, my_config.signature_needed())
 
1261
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1262
                             my_config.signing_policy))
 
1263
        self.assertEqual(True,
 
1264
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1265
                my_config.signature_needed))
611
1266
 
612
1267
    def test_signatures_if_possible(self):
613
 
        config_file = StringIO(sample_maybe_signatures)
614
 
        my_config = config.GlobalConfig()
615
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1268
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
616
1269
        self.assertEqual(config.CHECK_NEVER,
617
 
                         my_config.signature_checking())
 
1270
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1271
                             my_config.signature_checking))
618
1272
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
619
 
                         my_config.signing_policy())
620
 
        self.assertEqual(False, my_config.signature_needed())
 
1273
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1274
                             my_config.signing_policy))
 
1275
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1276
            my_config.signature_needed))
621
1277
 
622
1278
    def test_signatures_ignore(self):
623
 
        config_file = StringIO(sample_ignore_signatures)
624
 
        my_config = config.GlobalConfig()
625
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1279
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
626
1280
        self.assertEqual(config.CHECK_ALWAYS,
627
 
                         my_config.signature_checking())
 
1281
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1282
                             my_config.signature_checking))
628
1283
        self.assertEqual(config.SIGN_NEVER,
629
 
                         my_config.signing_policy())
630
 
        self.assertEqual(False, my_config.signature_needed())
 
1284
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1285
                             my_config.signing_policy))
 
1286
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1287
            my_config.signature_needed))
631
1288
 
632
1289
    def _get_sample_config(self):
633
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
634
 
        my_config = config.GlobalConfig()
635
 
        my_config._parser = my_config._get_parser(file=config_file)
 
1290
        my_config = config.GlobalConfig.from_string(sample_config_text)
636
1291
        return my_config
637
1292
 
638
1293
    def test_gpg_signing_command(self):
639
1294
        my_config = self._get_sample_config()
640
 
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
641
 
        self.assertEqual(False, my_config.signature_needed())
 
1295
        self.assertEqual("gnome-gpg",
 
1296
            self.applyDeprecated(
 
1297
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
 
1298
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1299
            my_config.signature_needed))
 
1300
 
 
1301
    def test_gpg_signing_key(self):
 
1302
        my_config = self._get_sample_config()
 
1303
        self.assertEqual("DD4D5088",
 
1304
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1305
                my_config.gpg_signing_key))
642
1306
 
643
1307
    def _get_empty_config(self):
644
 
        config_file = StringIO("")
645
1308
        my_config = config.GlobalConfig()
646
 
        my_config._parser = my_config._get_parser(file=config_file)
647
1309
        return my_config
648
1310
 
649
1311
    def test_gpg_signing_command_unset(self):
650
1312
        my_config = self._get_empty_config()
651
 
        self.assertEqual("gpg", my_config.gpg_signing_command())
 
1313
        self.assertEqual("gpg",
 
1314
            self.applyDeprecated(
 
1315
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
652
1316
 
653
1317
    def test_get_user_option_default(self):
654
1318
        my_config = self._get_empty_config()
661
1325
 
662
1326
    def test_post_commit_default(self):
663
1327
        my_config = self._get_sample_config()
664
 
        self.assertEqual(None, my_config.post_commit())
 
1328
        self.assertEqual(None,
 
1329
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1330
                                              my_config.post_commit))
665
1331
 
666
1332
    def test_configured_logformat(self):
667
1333
        my_config = self._get_sample_config()
668
 
        self.assertEqual("short", my_config.log_format())
 
1334
        self.assertEqual("short",
 
1335
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1336
                                              my_config.log_format))
 
1337
 
 
1338
    def test_configured_acceptable_keys(self):
 
1339
        my_config = self._get_sample_config()
 
1340
        self.assertEqual("amy",
 
1341
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1342
                my_config.acceptable_keys))
 
1343
 
 
1344
    def test_configured_validate_signatures_in_log(self):
 
1345
        my_config = self._get_sample_config()
 
1346
        self.assertEqual(True, my_config.validate_signatures_in_log())
669
1347
 
670
1348
    def test_get_alias(self):
671
1349
        my_config = self._get_sample_config()
699
1377
        change_editor = my_config.get_change_editor('old', 'new')
700
1378
        self.assertIs(None, change_editor)
701
1379
 
 
1380
    def test_get_merge_tools(self):
 
1381
        conf = self._get_sample_config()
 
1382
        tools = conf.get_merge_tools()
 
1383
        self.log(repr(tools))
 
1384
        self.assertEqual(
 
1385
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
 
1386
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
 
1387
            u'newtool' : u'"newtool with spaces" {this_temp}'},
 
1388
            tools)
 
1389
 
 
1390
    def test_get_merge_tools_empty(self):
 
1391
        conf = self._get_empty_config()
 
1392
        tools = conf.get_merge_tools()
 
1393
        self.assertEqual({}, tools)
 
1394
 
 
1395
    def test_find_merge_tool(self):
 
1396
        conf = self._get_sample_config()
 
1397
        cmdline = conf.find_merge_tool('sometool')
 
1398
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
 
1399
 
 
1400
    def test_find_merge_tool_not_found(self):
 
1401
        conf = self._get_sample_config()
 
1402
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
 
1403
        self.assertIs(cmdline, None)
 
1404
 
 
1405
    def test_find_merge_tool_known(self):
 
1406
        conf = self._get_empty_config()
 
1407
        cmdline = conf.find_merge_tool('kdiff3')
 
1408
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
 
1409
 
 
1410
    def test_find_merge_tool_override_known(self):
 
1411
        conf = self._get_empty_config()
 
1412
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
 
1413
        cmdline = conf.find_merge_tool('kdiff3')
 
1414
        self.assertEqual('kdiff3 blah', cmdline)
 
1415
 
702
1416
 
703
1417
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
704
1418
 
722
1436
        self.assertIs(None, new_config.get_alias('commit'))
723
1437
 
724
1438
 
725
 
class TestLocationConfig(tests.TestCaseInTempDir):
 
1439
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
726
1440
 
727
1441
    def test_constructs(self):
728
1442
        my_config = config.LocationConfig('http://example.com')
740
1454
            parser = my_config._get_parser()
741
1455
        finally:
742
1456
            config.ConfigObj = oldparserclass
743
 
        self.failUnless(isinstance(parser, InstrumentedConfigObj))
 
1457
        self.assertIsInstance(parser, InstrumentedConfigObj)
744
1458
        self.assertEqual(parser._calls,
745
1459
                         [('__init__', config.locations_config_filename(),
746
1460
                           'utf-8')])
747
 
        config.ensure_config_dir_exists()
748
 
        #os.mkdir(config.config_dir())
749
 
        f = file(config.branches_config_filename(), 'wb')
750
 
        f.write('')
751
 
        f.close()
752
 
        oldparserclass = config.ConfigObj
753
 
        config.ConfigObj = InstrumentedConfigObj
754
 
        try:
755
 
            my_config = config.LocationConfig('http://www.example.com')
756
 
            parser = my_config._get_parser()
757
 
        finally:
758
 
            config.ConfigObj = oldparserclass
759
1461
 
760
1462
    def test_get_global_config(self):
761
1463
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
762
1464
        global_config = my_config._get_global_config()
763
 
        self.failUnless(isinstance(global_config, config.GlobalConfig))
764
 
        self.failUnless(global_config is my_config._get_global_config())
 
1465
        self.assertIsInstance(global_config, config.GlobalConfig)
 
1466
        self.assertIs(global_config, my_config._get_global_config())
 
1467
 
 
1468
    def assertLocationMatching(self, expected):
 
1469
        self.assertEqual(expected,
 
1470
                         list(self.my_location_config._get_matching_sections()))
765
1471
 
766
1472
    def test__get_matching_sections_no_match(self):
767
1473
        self.get_branch_config('/')
768
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1474
        self.assertLocationMatching([])
769
1475
 
770
1476
    def test__get_matching_sections_exact(self):
771
1477
        self.get_branch_config('http://www.example.com')
772
 
        self.assertEqual([('http://www.example.com', '')],
773
 
                         self.my_location_config._get_matching_sections())
 
1478
        self.assertLocationMatching([('http://www.example.com', '')])
774
1479
 
775
1480
    def test__get_matching_sections_suffix_does_not(self):
776
1481
        self.get_branch_config('http://www.example.com-com')
777
 
        self.assertEqual([], self.my_location_config._get_matching_sections())
 
1482
        self.assertLocationMatching([])
778
1483
 
779
1484
    def test__get_matching_sections_subdir_recursive(self):
780
1485
        self.get_branch_config('http://www.example.com/com')
781
 
        self.assertEqual([('http://www.example.com', 'com')],
782
 
                         self.my_location_config._get_matching_sections())
 
1486
        self.assertLocationMatching([('http://www.example.com', 'com')])
783
1487
 
784
1488
    def test__get_matching_sections_ignoreparent(self):
785
1489
        self.get_branch_config('http://www.example.com/ignoreparent')
786
 
        self.assertEqual([('http://www.example.com/ignoreparent', '')],
787
 
                         self.my_location_config._get_matching_sections())
 
1490
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1491
                                      '')])
788
1492
 
789
1493
    def test__get_matching_sections_ignoreparent_subdir(self):
790
1494
        self.get_branch_config(
791
1495
            'http://www.example.com/ignoreparent/childbranch')
792
 
        self.assertEqual([('http://www.example.com/ignoreparent',
793
 
                           'childbranch')],
794
 
                         self.my_location_config._get_matching_sections())
 
1496
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
 
1497
                                      'childbranch')])
795
1498
 
796
1499
    def test__get_matching_sections_subdir_trailing_slash(self):
797
1500
        self.get_branch_config('/b')
798
 
        self.assertEqual([('/b/', '')],
799
 
                         self.my_location_config._get_matching_sections())
 
1501
        self.assertLocationMatching([('/b/', '')])
800
1502
 
801
1503
    def test__get_matching_sections_subdir_child(self):
802
1504
        self.get_branch_config('/a/foo')
803
 
        self.assertEqual([('/a/*', ''), ('/a/', 'foo')],
804
 
                         self.my_location_config._get_matching_sections())
 
1505
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
805
1506
 
806
1507
    def test__get_matching_sections_subdir_child_child(self):
807
1508
        self.get_branch_config('/a/foo/bar')
808
 
        self.assertEqual([('/a/*', 'bar'), ('/a/', 'foo/bar')],
809
 
                         self.my_location_config._get_matching_sections())
 
1509
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
810
1510
 
811
1511
    def test__get_matching_sections_trailing_slash_with_children(self):
812
1512
        self.get_branch_config('/a/')
813
 
        self.assertEqual([('/a/', '')],
814
 
                         self.my_location_config._get_matching_sections())
 
1513
        self.assertLocationMatching([('/a/', '')])
815
1514
 
816
1515
    def test__get_matching_sections_explicit_over_glob(self):
817
1516
        # XXX: 2006-09-08 jamesh
819
1518
        # was a config section for '/a/?', it would get precedence
820
1519
        # over '/a/c'.
821
1520
        self.get_branch_config('/a/c')
822
 
        self.assertEqual([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')],
823
 
                         self.my_location_config._get_matching_sections())
 
1521
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
824
1522
 
825
1523
    def test__get_option_policy_normal(self):
826
1524
        self.get_branch_config('http://www.example.com')
848
1546
            'http://www.example.com', 'appendpath_option'),
849
1547
            config.POLICY_APPENDPATH)
850
1548
 
 
1549
    def test__get_options_with_policy(self):
 
1550
        self.get_branch_config('/dir/subdir',
 
1551
                               location_config="""\
 
1552
[/dir]
 
1553
other_url = /other-dir
 
1554
other_url:policy = appendpath
 
1555
[/dir/subdir]
 
1556
other_url = /other-subdir
 
1557
""")
 
1558
        self.assertOptions(
 
1559
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
 
1560
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
 
1561
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
 
1562
            self.my_location_config)
 
1563
 
851
1564
    def test_location_without_username(self):
852
1565
        self.get_branch_config('http://www.example.com/ignoreparent')
853
1566
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
868
1581
        self.get_branch_config('http://www.example.com',
869
1582
                                 global_config=sample_ignore_signatures)
870
1583
        self.assertEqual(config.CHECK_ALWAYS,
871
 
                         self.my_config.signature_checking())
 
1584
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1585
                             self.my_config.signature_checking))
872
1586
        self.assertEqual(config.SIGN_NEVER,
873
 
                         self.my_config.signing_policy())
 
1587
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1588
                             self.my_config.signing_policy))
874
1589
 
875
1590
    def test_signatures_never(self):
876
1591
        self.get_branch_config('/a/c')
877
1592
        self.assertEqual(config.CHECK_NEVER,
878
 
                         self.my_config.signature_checking())
 
1593
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1594
                             self.my_config.signature_checking))
879
1595
 
880
1596
    def test_signatures_when_available(self):
881
1597
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
882
1598
        self.assertEqual(config.CHECK_IF_POSSIBLE,
883
 
                         self.my_config.signature_checking())
 
1599
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1600
                             self.my_config.signature_checking))
884
1601
 
885
1602
    def test_signatures_always(self):
886
1603
        self.get_branch_config('/b')
887
1604
        self.assertEqual(config.CHECK_ALWAYS,
888
 
                         self.my_config.signature_checking())
 
1605
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1606
                         self.my_config.signature_checking))
889
1607
 
890
1608
    def test_gpg_signing_command(self):
891
1609
        self.get_branch_config('/b')
892
 
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
 
1610
        self.assertEqual("gnome-gpg",
 
1611
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1612
                self.my_config.gpg_signing_command))
893
1613
 
894
1614
    def test_gpg_signing_command_missing(self):
895
1615
        self.get_branch_config('/a')
896
 
        self.assertEqual("false", self.my_config.gpg_signing_command())
 
1616
        self.assertEqual("false",
 
1617
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1618
                self.my_config.gpg_signing_command))
 
1619
 
 
1620
    def test_gpg_signing_key(self):
 
1621
        self.get_branch_config('/b')
 
1622
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1623
            self.my_config.gpg_signing_key))
 
1624
 
 
1625
    def test_gpg_signing_key_default(self):
 
1626
        self.get_branch_config('/a')
 
1627
        self.assertEqual("erik@bagfors.nu",
 
1628
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1629
                self.my_config.gpg_signing_key))
897
1630
 
898
1631
    def test_get_user_option_global(self):
899
1632
        self.get_branch_config('/a')
987
1720
    def test_post_commit_default(self):
988
1721
        self.get_branch_config('/a/c')
989
1722
        self.assertEqual('bzrlib.tests.test_config.post_commit',
990
 
                         self.my_config.post_commit())
 
1723
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1724
                                              self.my_config.post_commit))
991
1725
 
992
 
    def get_branch_config(self, location, global_config=None):
 
1726
    def get_branch_config(self, location, global_config=None,
 
1727
                          location_config=None):
 
1728
        my_branch = FakeBranch(location)
993
1729
        if global_config is None:
994
 
            global_file = StringIO(sample_config_text.encode('utf-8'))
995
 
        else:
996
 
            global_file = StringIO(global_config.encode('utf-8'))
997
 
        branches_file = StringIO(sample_branches_text.encode('utf-8'))
998
 
        self.my_config = config.BranchConfig(FakeBranch(location))
999
 
        # Force location config to use specified file
1000
 
        self.my_location_config = self.my_config._get_location_config()
1001
 
        self.my_location_config._get_parser(branches_file)
1002
 
        # Force global config to use specified file
1003
 
        self.my_config._get_global_config()._get_parser(global_file)
 
1730
            global_config = sample_config_text
 
1731
        if location_config is None:
 
1732
            location_config = sample_branches_text
 
1733
 
 
1734
        my_global_config = config.GlobalConfig.from_string(global_config,
 
1735
                                                           save=True)
 
1736
        my_location_config = config.LocationConfig.from_string(
 
1737
            location_config, my_branch.base, save=True)
 
1738
        my_config = config.BranchConfig(my_branch)
 
1739
        self.my_config = my_config
 
1740
        self.my_location_config = my_config._get_location_config()
1004
1741
 
1005
1742
    def test_set_user_setting_sets_and_saves(self):
1006
1743
        self.get_branch_config('/a/c')
1007
1744
        record = InstrumentedConfigObj("foo")
1008
1745
        self.my_location_config._parser = record
1009
1746
 
1010
 
        real_mkdir = os.mkdir
1011
 
        self.created = False
1012
 
        def checked_mkdir(path, mode=0777):
1013
 
            self.log('making directory: %s', path)
1014
 
            real_mkdir(path, mode)
1015
 
            self.created = True
1016
 
 
1017
 
        os.mkdir = checked_mkdir
1018
 
        try:
1019
 
            self.callDeprecated(['The recurse option is deprecated as of '
1020
 
                                 '0.14.  The section "/a/c" has been '
1021
 
                                 'converted to use policies.'],
1022
 
                                self.my_config.set_user_option,
1023
 
                                'foo', 'bar', store=config.STORE_LOCATION)
1024
 
        finally:
1025
 
            os.mkdir = real_mkdir
1026
 
 
1027
 
        self.failUnless(self.created, 'Failed to create ~/.bazaar')
1028
 
        self.assertEqual([('__contains__', '/a/c'),
 
1747
        self.callDeprecated(['The recurse option is deprecated as of '
 
1748
                             '0.14.  The section "/a/c" has been '
 
1749
                             'converted to use policies.'],
 
1750
                            self.my_config.set_user_option,
 
1751
                            'foo', 'bar', store=config.STORE_LOCATION)
 
1752
        self.assertEqual([('reload',),
 
1753
                          ('__contains__', '/a/c'),
1029
1754
                          ('__contains__', '/a/c/'),
1030
1755
                          ('__setitem__', '/a/c', {}),
1031
1756
                          ('__getitem__', '/a/c'),
1060
1785
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1061
1786
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1062
1787
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
1063
 
        os.environ['BZR_REMOTE_PATH'] = '/environ-bzr'
 
1788
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1064
1789
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1065
1790
 
1066
1791
 
1074
1799
option = exact
1075
1800
"""
1076
1801
 
1077
 
 
1078
1802
class TestBranchConfigItems(tests.TestCaseInTempDir):
1079
1803
 
1080
1804
    def get_branch_config(self, global_config=None, location=None,
1081
1805
                          location_config=None, branch_data_config=None):
1082
 
        my_config = config.BranchConfig(FakeBranch(location))
 
1806
        my_branch = FakeBranch(location)
1083
1807
        if global_config is not None:
1084
 
            global_file = StringIO(global_config.encode('utf-8'))
1085
 
            my_config._get_global_config()._get_parser(global_file)
1086
 
        self.my_location_config = my_config._get_location_config()
 
1808
            my_global_config = config.GlobalConfig.from_string(global_config,
 
1809
                                                               save=True)
1087
1810
        if location_config is not None:
1088
 
            location_file = StringIO(location_config.encode('utf-8'))
1089
 
            self.my_location_config._get_parser(location_file)
 
1811
            my_location_config = config.LocationConfig.from_string(
 
1812
                location_config, my_branch.base, save=True)
 
1813
        my_config = config.BranchConfig(my_branch)
1090
1814
        if branch_data_config is not None:
1091
1815
            my_config.branch.control_files.files['branch.conf'] = \
1092
1816
                branch_data_config
1093
1817
        return my_config
1094
1818
 
1095
1819
    def test_user_id(self):
1096
 
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
 
1820
        branch = FakeBranch()
1097
1821
        my_config = config.BranchConfig(branch)
1098
 
        self.assertEqual("Robert Collins <robertc@example.net>",
1099
 
                         my_config.username())
 
1822
        self.assertIsNot(None, my_config.username())
1100
1823
        my_config.branch.control_files.files['email'] = "John"
1101
1824
        my_config.set_user_option('email',
1102
1825
                                  "Robert Collins <robertc@example.org>")
1103
 
        self.assertEqual("John", my_config.username())
1104
 
        del my_config.branch.control_files.files['email']
1105
1826
        self.assertEqual("Robert Collins <robertc@example.org>",
1106
 
                         my_config.username())
1107
 
 
1108
 
    def test_not_set_in_branch(self):
1109
 
        my_config = self.get_branch_config(sample_config_text)
1110
 
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1111
 
                         my_config._get_user_id())
1112
 
        my_config.branch.control_files.files['email'] = "John"
1113
 
        self.assertEqual("John", my_config._get_user_id())
 
1827
                        my_config.username())
1114
1828
 
1115
1829
    def test_BZR_EMAIL_OVERRIDES(self):
1116
 
        os.environ['BZR_EMAIL'] = "Robert Collins <robertc@example.org>"
 
1830
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1117
1831
        branch = FakeBranch()
1118
1832
        my_config = config.BranchConfig(branch)
1119
1833
        self.assertEqual("Robert Collins <robertc@example.org>",
1122
1836
    def test_signatures_forced(self):
1123
1837
        my_config = self.get_branch_config(
1124
1838
            global_config=sample_always_signatures)
1125
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1126
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1127
 
        self.assertTrue(my_config.signature_needed())
 
1839
        self.assertEqual(config.CHECK_NEVER,
 
1840
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1841
                my_config.signature_checking))
 
1842
        self.assertEqual(config.SIGN_ALWAYS,
 
1843
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1844
                my_config.signing_policy))
 
1845
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1846
            my_config.signature_needed))
1128
1847
 
1129
1848
    def test_signatures_forced_branch(self):
1130
1849
        my_config = self.get_branch_config(
1131
1850
            global_config=sample_ignore_signatures,
1132
1851
            branch_data_config=sample_always_signatures)
1133
 
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1134
 
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1135
 
        self.assertTrue(my_config.signature_needed())
 
1852
        self.assertEqual(config.CHECK_NEVER,
 
1853
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1854
                my_config.signature_checking))
 
1855
        self.assertEqual(config.SIGN_ALWAYS,
 
1856
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1857
                my_config.signing_policy))
 
1858
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1859
            my_config.signature_needed))
1136
1860
 
1137
1861
    def test_gpg_signing_command(self):
1138
1862
        my_config = self.get_branch_config(
 
1863
            global_config=sample_config_text,
1139
1864
            # branch data cannot set gpg_signing_command
1140
1865
            branch_data_config="gpg_signing_command=pgp")
1141
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
1142
 
        my_config._get_global_config()._get_parser(config_file)
1143
 
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
 
1866
        self.assertEqual('gnome-gpg',
 
1867
            self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1868
                my_config.gpg_signing_command))
1144
1869
 
1145
1870
    def test_get_user_option_global(self):
1146
 
        branch = FakeBranch()
1147
 
        my_config = config.BranchConfig(branch)
1148
 
        config_file = StringIO(sample_config_text.encode('utf-8'))
1149
 
        (my_config._get_global_config()._get_parser(config_file))
 
1871
        my_config = self.get_branch_config(global_config=sample_config_text)
1150
1872
        self.assertEqual('something',
1151
1873
                         my_config.get_user_option('user_global_option'))
1152
1874
 
1153
1875
    def test_post_commit_default(self):
1154
 
        branch = FakeBranch()
1155
 
        my_config = self.get_branch_config(sample_config_text, '/a/c',
1156
 
                                           sample_branches_text)
 
1876
        my_config = self.get_branch_config(global_config=sample_config_text,
 
1877
                                      location='/a/c',
 
1878
                                      location_config=sample_branches_text)
1157
1879
        self.assertEqual(my_config.branch.base, '/a/c')
1158
1880
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1159
 
                         my_config.post_commit())
 
1881
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1882
                                              my_config.post_commit))
1160
1883
        my_config.set_user_option('post_commit', 'rmtree_root')
1161
 
        # post-commit is ignored when bresent in branch data
 
1884
        # post-commit is ignored when present in branch data
1162
1885
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1163
 
                         my_config.post_commit())
 
1886
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1887
                                              my_config.post_commit))
1164
1888
        my_config.set_user_option('post_commit', 'rmtree_root',
1165
1889
                                  store=config.STORE_LOCATION)
1166
 
        self.assertEqual('rmtree_root', my_config.post_commit())
 
1890
        self.assertEqual('rmtree_root',
 
1891
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
 
1892
                                              my_config.post_commit))
1167
1893
 
1168
1894
    def test_config_precedence(self):
 
1895
        # FIXME: eager test, luckily no persitent config file makes it fail
 
1896
        # -- vila 20100716
1169
1897
        my_config = self.get_branch_config(global_config=precedence_global)
1170
1898
        self.assertEqual(my_config.get_user_option('option'), 'global')
1171
1899
        my_config = self.get_branch_config(global_config=precedence_global,
1172
 
                                      branch_data_config=precedence_branch)
 
1900
                                           branch_data_config=precedence_branch)
1173
1901
        self.assertEqual(my_config.get_user_option('option'), 'branch')
1174
 
        my_config = self.get_branch_config(global_config=precedence_global,
1175
 
                                      branch_data_config=precedence_branch,
1176
 
                                      location_config=precedence_location)
 
1902
        my_config = self.get_branch_config(
 
1903
            global_config=precedence_global,
 
1904
            branch_data_config=precedence_branch,
 
1905
            location_config=precedence_location)
1177
1906
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
1178
 
        my_config = self.get_branch_config(global_config=precedence_global,
1179
 
                                      branch_data_config=precedence_branch,
1180
 
                                      location_config=precedence_location,
1181
 
                                      location='http://example.com/specific')
 
1907
        my_config = self.get_branch_config(
 
1908
            global_config=precedence_global,
 
1909
            branch_data_config=precedence_branch,
 
1910
            location_config=precedence_location,
 
1911
            location='http://example.com/specific')
1182
1912
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1183
1913
 
1184
 
    def test_get_mail_client(self):
1185
 
        config = self.get_branch_config()
1186
 
        client = config.get_mail_client()
1187
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1188
 
 
1189
 
        # Specific clients
1190
 
        config.set_user_option('mail_client', 'evolution')
1191
 
        client = config.get_mail_client()
1192
 
        self.assertIsInstance(client, mail_client.Evolution)
1193
 
 
1194
 
        config.set_user_option('mail_client', 'kmail')
1195
 
        client = config.get_mail_client()
1196
 
        self.assertIsInstance(client, mail_client.KMail)
1197
 
 
1198
 
        config.set_user_option('mail_client', 'mutt')
1199
 
        client = config.get_mail_client()
1200
 
        self.assertIsInstance(client, mail_client.Mutt)
1201
 
 
1202
 
        config.set_user_option('mail_client', 'thunderbird')
1203
 
        client = config.get_mail_client()
1204
 
        self.assertIsInstance(client, mail_client.Thunderbird)
1205
 
 
1206
 
        # Generic options
1207
 
        config.set_user_option('mail_client', 'default')
1208
 
        client = config.get_mail_client()
1209
 
        self.assertIsInstance(client, mail_client.DefaultMail)
1210
 
 
1211
 
        config.set_user_option('mail_client', 'editor')
1212
 
        client = config.get_mail_client()
1213
 
        self.assertIsInstance(client, mail_client.Editor)
1214
 
 
1215
 
        config.set_user_option('mail_client', 'mapi')
1216
 
        client = config.get_mail_client()
1217
 
        self.assertIsInstance(client, mail_client.MAPIClient)
1218
 
 
1219
 
        config.set_user_option('mail_client', 'xdg-email')
1220
 
        client = config.get_mail_client()
1221
 
        self.assertIsInstance(client, mail_client.XDGEmail)
1222
 
 
1223
 
        config.set_user_option('mail_client', 'firebird')
1224
 
        self.assertRaises(errors.UnknownMailClient, config.get_mail_client)
1225
 
 
1226
1914
 
1227
1915
class TestMailAddressExtraction(tests.TestCase):
1228
1916
 
1274
1962
 
1275
1963
class TestTransportConfig(tests.TestCaseWithTransport):
1276
1964
 
 
1965
    def test_load_utf8(self):
 
1966
        """Ensure we can load an utf8-encoded file."""
 
1967
        t = self.get_transport()
 
1968
        unicode_user = u'b\N{Euro Sign}ar'
 
1969
        unicode_content = u'user=%s' % (unicode_user,)
 
1970
        utf8_content = unicode_content.encode('utf8')
 
1971
        # Store the raw content in the config file
 
1972
        t.put_bytes('foo.conf', utf8_content)
 
1973
        conf = config.TransportConfig(t, 'foo.conf')
 
1974
        self.assertEquals(unicode_user, conf.get_option('user'))
 
1975
 
 
1976
    def test_load_non_ascii(self):
 
1977
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
1978
        t = self.get_transport()
 
1979
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
 
1980
        conf = config.TransportConfig(t, 'foo.conf')
 
1981
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
 
1982
 
 
1983
    def test_load_erroneous_content(self):
 
1984
        """Ensure we display a proper error on content that can't be parsed."""
 
1985
        t = self.get_transport()
 
1986
        t.put_bytes('foo.conf', '[open_section\n')
 
1987
        conf = config.TransportConfig(t, 'foo.conf')
 
1988
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
 
1989
 
 
1990
    def test_load_permission_denied(self):
 
1991
        """Ensure we get an empty config file if the file is inaccessible."""
 
1992
        warnings = []
 
1993
        def warning(*args):
 
1994
            warnings.append(args[0] % args[1:])
 
1995
        self.overrideAttr(trace, 'warning', warning)
 
1996
 
 
1997
        class DenyingTransport(object):
 
1998
 
 
1999
            def __init__(self, base):
 
2000
                self.base = base
 
2001
 
 
2002
            def get_bytes(self, relpath):
 
2003
                raise errors.PermissionDenied(relpath, "")
 
2004
 
 
2005
        cfg = config.TransportConfig(
 
2006
            DenyingTransport("nonexisting://"), 'control.conf')
 
2007
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
 
2008
        self.assertEquals(
 
2009
            warnings,
 
2010
            [u'Permission denied while trying to open configuration file '
 
2011
             u'nonexisting:///control.conf.'])
 
2012
 
1277
2013
    def test_get_value(self):
1278
2014
        """Test that retreiving a value from a section is possible"""
1279
 
        bzrdir_config = config.TransportConfig(transport.get_transport('.'),
 
2015
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
1280
2016
                                               'control.conf')
1281
2017
        bzrdir_config.set_option('value', 'key', 'SECTION')
1282
2018
        bzrdir_config.set_option('value2', 'key2')
1312
2048
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1313
2049
 
1314
2050
 
 
2051
class TestOldConfigHooks(tests.TestCaseWithTransport):
 
2052
 
 
2053
    def setUp(self):
 
2054
        super(TestOldConfigHooks, self).setUp()
 
2055
        create_configs_with_file_option(self)
 
2056
 
 
2057
    def assertGetHook(self, conf, name, value):
 
2058
        calls = []
 
2059
        def hook(*args):
 
2060
            calls.append(args)
 
2061
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2062
        self.addCleanup(
 
2063
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2064
        self.assertLength(0, calls)
 
2065
        actual_value = conf.get_user_option(name)
 
2066
        self.assertEquals(value, actual_value)
 
2067
        self.assertLength(1, calls)
 
2068
        self.assertEquals((conf, name, value), calls[0])
 
2069
 
 
2070
    def test_get_hook_bazaar(self):
 
2071
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
 
2072
 
 
2073
    def test_get_hook_locations(self):
 
2074
        self.assertGetHook(self.locations_config, 'file', 'locations')
 
2075
 
 
2076
    def test_get_hook_branch(self):
 
2077
        # Since locations masks branch, we define a different option
 
2078
        self.branch_config.set_user_option('file2', 'branch')
 
2079
        self.assertGetHook(self.branch_config, 'file2', 'branch')
 
2080
 
 
2081
    def assertSetHook(self, conf, name, value):
 
2082
        calls = []
 
2083
        def hook(*args):
 
2084
            calls.append(args)
 
2085
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2086
        self.addCleanup(
 
2087
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2088
        self.assertLength(0, calls)
 
2089
        conf.set_user_option(name, value)
 
2090
        self.assertLength(1, calls)
 
2091
        # We can't assert the conf object below as different configs use
 
2092
        # different means to implement set_user_option and we care only about
 
2093
        # coverage here.
 
2094
        self.assertEquals((name, value), calls[0][1:])
 
2095
 
 
2096
    def test_set_hook_bazaar(self):
 
2097
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
 
2098
 
 
2099
    def test_set_hook_locations(self):
 
2100
        self.assertSetHook(self.locations_config, 'foo', 'locations')
 
2101
 
 
2102
    def test_set_hook_branch(self):
 
2103
        self.assertSetHook(self.branch_config, 'foo', 'branch')
 
2104
 
 
2105
    def assertRemoveHook(self, conf, name, section_name=None):
 
2106
        calls = []
 
2107
        def hook(*args):
 
2108
            calls.append(args)
 
2109
        config.OldConfigHooks.install_named_hook('remove', hook, None)
 
2110
        self.addCleanup(
 
2111
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
 
2112
        self.assertLength(0, calls)
 
2113
        conf.remove_user_option(name, section_name)
 
2114
        self.assertLength(1, calls)
 
2115
        # We can't assert the conf object below as different configs use
 
2116
        # different means to implement remove_user_option and we care only about
 
2117
        # coverage here.
 
2118
        self.assertEquals((name,), calls[0][1:])
 
2119
 
 
2120
    def test_remove_hook_bazaar(self):
 
2121
        self.assertRemoveHook(self.bazaar_config, 'file')
 
2122
 
 
2123
    def test_remove_hook_locations(self):
 
2124
        self.assertRemoveHook(self.locations_config, 'file',
 
2125
                              self.locations_config.location)
 
2126
 
 
2127
    def test_remove_hook_branch(self):
 
2128
        self.assertRemoveHook(self.branch_config, 'file')
 
2129
 
 
2130
    def assertLoadHook(self, name, conf_class, *conf_args):
 
2131
        calls = []
 
2132
        def hook(*args):
 
2133
            calls.append(args)
 
2134
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2135
        self.addCleanup(
 
2136
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2137
        self.assertLength(0, calls)
 
2138
        # Build a config
 
2139
        conf = conf_class(*conf_args)
 
2140
        # Access an option to trigger a load
 
2141
        conf.get_user_option(name)
 
2142
        self.assertLength(1, calls)
 
2143
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2144
 
 
2145
    def test_load_hook_bazaar(self):
 
2146
        self.assertLoadHook('file', config.GlobalConfig)
 
2147
 
 
2148
    def test_load_hook_locations(self):
 
2149
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
 
2150
 
 
2151
    def test_load_hook_branch(self):
 
2152
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
 
2153
 
 
2154
    def assertSaveHook(self, conf):
 
2155
        calls = []
 
2156
        def hook(*args):
 
2157
            calls.append(args)
 
2158
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2159
        self.addCleanup(
 
2160
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2161
        self.assertLength(0, calls)
 
2162
        # Setting an option triggers a save
 
2163
        conf.set_user_option('foo', 'bar')
 
2164
        self.assertLength(1, calls)
 
2165
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2166
 
 
2167
    def test_save_hook_bazaar(self):
 
2168
        self.assertSaveHook(self.bazaar_config)
 
2169
 
 
2170
    def test_save_hook_locations(self):
 
2171
        self.assertSaveHook(self.locations_config)
 
2172
 
 
2173
    def test_save_hook_branch(self):
 
2174
        self.assertSaveHook(self.branch_config)
 
2175
 
 
2176
 
 
2177
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
 
2178
    """Tests config hooks for remote configs.
 
2179
 
 
2180
    No tests for the remove hook as this is not implemented there.
 
2181
    """
 
2182
 
 
2183
    def setUp(self):
 
2184
        super(TestOldConfigHooksForRemote, self).setUp()
 
2185
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2186
        create_configs_with_file_option(self)
 
2187
 
 
2188
    def assertGetHook(self, conf, name, value):
 
2189
        calls = []
 
2190
        def hook(*args):
 
2191
            calls.append(args)
 
2192
        config.OldConfigHooks.install_named_hook('get', hook, None)
 
2193
        self.addCleanup(
 
2194
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
 
2195
        self.assertLength(0, calls)
 
2196
        actual_value = conf.get_option(name)
 
2197
        self.assertEquals(value, actual_value)
 
2198
        self.assertLength(1, calls)
 
2199
        self.assertEquals((conf, name, value), calls[0])
 
2200
 
 
2201
    def test_get_hook_remote_branch(self):
 
2202
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2203
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
 
2204
 
 
2205
    def test_get_hook_remote_bzrdir(self):
 
2206
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2207
        conf = remote_bzrdir._get_config()
 
2208
        conf.set_option('remotedir', 'file')
 
2209
        self.assertGetHook(conf, 'file', 'remotedir')
 
2210
 
 
2211
    def assertSetHook(self, conf, name, value):
 
2212
        calls = []
 
2213
        def hook(*args):
 
2214
            calls.append(args)
 
2215
        config.OldConfigHooks.install_named_hook('set', hook, None)
 
2216
        self.addCleanup(
 
2217
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
 
2218
        self.assertLength(0, calls)
 
2219
        conf.set_option(value, name)
 
2220
        self.assertLength(1, calls)
 
2221
        # We can't assert the conf object below as different configs use
 
2222
        # different means to implement set_user_option and we care only about
 
2223
        # coverage here.
 
2224
        self.assertEquals((name, value), calls[0][1:])
 
2225
 
 
2226
    def test_set_hook_remote_branch(self):
 
2227
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2228
        self.addCleanup(remote_branch.lock_write().unlock)
 
2229
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
 
2230
 
 
2231
    def test_set_hook_remote_bzrdir(self):
 
2232
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2233
        self.addCleanup(remote_branch.lock_write().unlock)
 
2234
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2235
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
 
2236
 
 
2237
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
 
2238
        calls = []
 
2239
        def hook(*args):
 
2240
            calls.append(args)
 
2241
        config.OldConfigHooks.install_named_hook('load', hook, None)
 
2242
        self.addCleanup(
 
2243
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
 
2244
        self.assertLength(0, calls)
 
2245
        # Build a config
 
2246
        conf = conf_class(*conf_args)
 
2247
        # Access an option to trigger a load
 
2248
        conf.get_option(name)
 
2249
        self.assertLength(expected_nb_calls, calls)
 
2250
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2251
 
 
2252
    def test_load_hook_remote_branch(self):
 
2253
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2254
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
 
2255
 
 
2256
    def test_load_hook_remote_bzrdir(self):
 
2257
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2258
        # The config file doesn't exist, set an option to force its creation
 
2259
        conf = remote_bzrdir._get_config()
 
2260
        conf.set_option('remotedir', 'file')
 
2261
        # We get one call for the server and one call for the client, this is
 
2262
        # caused by the differences in implementations betwen
 
2263
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
 
2264
        # SmartServerBranchGetConfigFile (in smart/branch.py)
 
2265
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
 
2266
 
 
2267
    def assertSaveHook(self, conf):
 
2268
        calls = []
 
2269
        def hook(*args):
 
2270
            calls.append(args)
 
2271
        config.OldConfigHooks.install_named_hook('save', hook, None)
 
2272
        self.addCleanup(
 
2273
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
 
2274
        self.assertLength(0, calls)
 
2275
        # Setting an option triggers a save
 
2276
        conf.set_option('foo', 'bar')
 
2277
        self.assertLength(1, calls)
 
2278
        # Since we can't assert about conf, we just use the number of calls ;-/
 
2279
 
 
2280
    def test_save_hook_remote_branch(self):
 
2281
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2282
        self.addCleanup(remote_branch.lock_write().unlock)
 
2283
        self.assertSaveHook(remote_branch._get_config())
 
2284
 
 
2285
    def test_save_hook_remote_bzrdir(self):
 
2286
        remote_branch = branch.Branch.open(self.get_url('tree'))
 
2287
        self.addCleanup(remote_branch.lock_write().unlock)
 
2288
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
 
2289
        self.assertSaveHook(remote_bzrdir._get_config())
 
2290
 
 
2291
 
 
2292
class TestOption(tests.TestCase):
 
2293
 
 
2294
    def test_default_value(self):
 
2295
        opt = config.Option('foo', default='bar')
 
2296
        self.assertEquals('bar', opt.get_default())
 
2297
 
 
2298
    def test_callable_default_value(self):
 
2299
        def bar_as_unicode():
 
2300
            return u'bar'
 
2301
        opt = config.Option('foo', default=bar_as_unicode)
 
2302
        self.assertEquals('bar', opt.get_default())
 
2303
 
 
2304
    def test_default_value_from_env(self):
 
2305
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
 
2306
        self.overrideEnv('FOO', 'quux')
 
2307
        # Env variable provides a default taking over the option one
 
2308
        self.assertEquals('quux', opt.get_default())
 
2309
 
 
2310
    def test_first_default_value_from_env_wins(self):
 
2311
        opt = config.Option('foo', default='bar',
 
2312
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
 
2313
        self.overrideEnv('FOO', 'foo')
 
2314
        self.overrideEnv('BAZ', 'baz')
 
2315
        # The first env var set wins
 
2316
        self.assertEquals('foo', opt.get_default())
 
2317
 
 
2318
    def test_not_supported_list_default_value(self):
 
2319
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
 
2320
 
 
2321
    def test_not_supported_object_default_value(self):
 
2322
        self.assertRaises(AssertionError, config.Option, 'foo',
 
2323
                          default=object())
 
2324
 
 
2325
    def test_not_supported_callable_default_value_not_unicode(self):
 
2326
        def bar_not_unicode():
 
2327
            return 'bar'
 
2328
        opt = config.Option('foo', default=bar_not_unicode)
 
2329
        self.assertRaises(AssertionError, opt.get_default)
 
2330
 
 
2331
 
 
2332
class TestOptionConverterMixin(object):
 
2333
 
 
2334
    def assertConverted(self, expected, opt, value):
 
2335
        self.assertEquals(expected, opt.convert_from_unicode(None, value))
 
2336
 
 
2337
    def assertWarns(self, opt, value):
 
2338
        warnings = []
 
2339
        def warning(*args):
 
2340
            warnings.append(args[0] % args[1:])
 
2341
        self.overrideAttr(trace, 'warning', warning)
 
2342
        self.assertEquals(None, opt.convert_from_unicode(None, value))
 
2343
        self.assertLength(1, warnings)
 
2344
        self.assertEquals(
 
2345
            'Value "%s" is not valid for "%s"' % (value, opt.name),
 
2346
            warnings[0])
 
2347
 
 
2348
    def assertErrors(self, opt, value):
 
2349
        self.assertRaises(errors.ConfigOptionValueError,
 
2350
                          opt.convert_from_unicode, None, value)
 
2351
 
 
2352
    def assertConvertInvalid(self, opt, invalid_value):
 
2353
        opt.invalid = None
 
2354
        self.assertEquals(None, opt.convert_from_unicode(None, invalid_value))
 
2355
        opt.invalid = 'warning'
 
2356
        self.assertWarns(opt, invalid_value)
 
2357
        opt.invalid = 'error'
 
2358
        self.assertErrors(opt, invalid_value)
 
2359
 
 
2360
 
 
2361
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
 
2362
 
 
2363
    def get_option(self):
 
2364
        return config.Option('foo', help='A boolean.',
 
2365
                             from_unicode=config.bool_from_store)
 
2366
 
 
2367
    def test_convert_invalid(self):
 
2368
        opt = self.get_option()
 
2369
        # A string that is not recognized as a boolean
 
2370
        self.assertConvertInvalid(opt, u'invalid-boolean')
 
2371
        # A list of strings is never recognized as a boolean
 
2372
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
 
2373
 
 
2374
    def test_convert_valid(self):
 
2375
        opt = self.get_option()
 
2376
        self.assertConverted(True, opt, u'True')
 
2377
        self.assertConverted(True, opt, u'1')
 
2378
        self.assertConverted(False, opt, u'False')
 
2379
 
 
2380
 
 
2381
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
 
2382
 
 
2383
    def get_option(self):
 
2384
        return config.Option('foo', help='An integer.',
 
2385
                             from_unicode=config.int_from_store)
 
2386
 
 
2387
    def test_convert_invalid(self):
 
2388
        opt = self.get_option()
 
2389
        # A string that is not recognized as an integer
 
2390
        self.assertConvertInvalid(opt, u'forty-two')
 
2391
        # A list of strings is never recognized as an integer
 
2392
        self.assertConvertInvalid(opt, [u'a', u'list'])
 
2393
 
 
2394
    def test_convert_valid(self):
 
2395
        opt = self.get_option()
 
2396
        self.assertConverted(16, opt, u'16')
 
2397
 
 
2398
 
 
2399
class TestOptionWithSIUnitConverter(tests.TestCase, TestOptionConverterMixin):
 
2400
 
 
2401
    def get_option(self):
 
2402
        return config.Option('foo', help='An integer in SI units.',
 
2403
                             from_unicode=config.int_SI_from_store)
 
2404
 
 
2405
    def test_convert_invalid(self):
 
2406
        opt = self.get_option()
 
2407
        self.assertConvertInvalid(opt, u'not-a-unit')
 
2408
        self.assertConvertInvalid(opt, u'Gb') # Forgot the int
 
2409
        self.assertConvertInvalid(opt, u'1b') # Forgot the unit
 
2410
        self.assertConvertInvalid(opt, u'1GG')
 
2411
        self.assertConvertInvalid(opt, u'1Mbb')
 
2412
        self.assertConvertInvalid(opt, u'1MM')
 
2413
 
 
2414
    def test_convert_valid(self):
 
2415
        opt = self.get_option()
 
2416
        self.assertConverted(int(5e3), opt, u'5kb')
 
2417
        self.assertConverted(int(5e6), opt, u'5M')
 
2418
        self.assertConverted(int(5e6), opt, u'5MB')
 
2419
        self.assertConverted(int(5e9), opt, u'5g')
 
2420
        self.assertConverted(int(5e9), opt, u'5gB')
 
2421
        self.assertConverted(100, opt, u'100')
 
2422
 
 
2423
 
 
2424
class TestListOption(tests.TestCase, TestOptionConverterMixin):
 
2425
 
 
2426
    def get_option(self):
 
2427
        return config.ListOption('foo', help='A list.')
 
2428
 
 
2429
    def test_convert_invalid(self):
 
2430
        opt = self.get_option()
 
2431
        # We don't even try to convert a list into a list, we only expect
 
2432
        # strings
 
2433
        self.assertConvertInvalid(opt, [1])
 
2434
        # No string is invalid as all forms can be converted to a list
 
2435
 
 
2436
    def test_convert_valid(self):
 
2437
        opt = self.get_option()
 
2438
        # An empty string is an empty list
 
2439
        self.assertConverted([], opt, '') # Using a bare str() just in case
 
2440
        self.assertConverted([], opt, u'')
 
2441
        # A boolean
 
2442
        self.assertConverted([u'True'], opt, u'True')
 
2443
        # An integer
 
2444
        self.assertConverted([u'42'], opt, u'42')
 
2445
        # A single string
 
2446
        self.assertConverted([u'bar'], opt, u'bar')
 
2447
 
 
2448
 
 
2449
class TestRegistryOption(tests.TestCase, TestOptionConverterMixin):
 
2450
 
 
2451
    def get_option(self, registry):
 
2452
        return config.RegistryOption('foo', registry,
 
2453
                help='A registry option.')
 
2454
 
 
2455
    def test_convert_invalid(self):
 
2456
        registry = _mod_registry.Registry()
 
2457
        opt = self.get_option(registry)
 
2458
        self.assertConvertInvalid(opt, [1])
 
2459
        self.assertConvertInvalid(opt, u"notregistered")
 
2460
 
 
2461
    def test_convert_valid(self):
 
2462
        registry = _mod_registry.Registry()
 
2463
        registry.register("someval", 1234)
 
2464
        opt = self.get_option(registry)
 
2465
        # Using a bare str() just in case
 
2466
        self.assertConverted(1234, opt, "someval")
 
2467
        self.assertConverted(1234, opt, u'someval')
 
2468
        self.assertConverted(None, opt, None)
 
2469
 
 
2470
    def test_help(self):
 
2471
        registry = _mod_registry.Registry()
 
2472
        registry.register("someval", 1234, help="some option")
 
2473
        registry.register("dunno", 1234, help="some other option")
 
2474
        opt = self.get_option(registry)
 
2475
        self.assertEquals(
 
2476
            'A registry option.\n'
 
2477
            '\n'
 
2478
            'The following values are supported:\n'
 
2479
            ' dunno - some other option\n'
 
2480
            ' someval - some option\n',
 
2481
            opt.help)
 
2482
 
 
2483
    def test_get_help_text(self):
 
2484
        registry = _mod_registry.Registry()
 
2485
        registry.register("someval", 1234, help="some option")
 
2486
        registry.register("dunno", 1234, help="some other option")
 
2487
        opt = self.get_option(registry)
 
2488
        self.assertEquals(
 
2489
            'A registry option.\n'
 
2490
            '\n'
 
2491
            'The following values are supported:\n'
 
2492
            ' dunno - some other option\n'
 
2493
            ' someval - some option\n',
 
2494
            opt.get_help_text())
 
2495
 
 
2496
 
 
2497
class TestOptionRegistry(tests.TestCase):
 
2498
 
 
2499
    def setUp(self):
 
2500
        super(TestOptionRegistry, self).setUp()
 
2501
        # Always start with an empty registry
 
2502
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2503
        self.registry = config.option_registry
 
2504
 
 
2505
    def test_register(self):
 
2506
        opt = config.Option('foo')
 
2507
        self.registry.register(opt)
 
2508
        self.assertIs(opt, self.registry.get('foo'))
 
2509
 
 
2510
    def test_registered_help(self):
 
2511
        opt = config.Option('foo', help='A simple option')
 
2512
        self.registry.register(opt)
 
2513
        self.assertEquals('A simple option', self.registry.get_help('foo'))
 
2514
 
 
2515
    lazy_option = config.Option('lazy_foo', help='Lazy help')
 
2516
 
 
2517
    def test_register_lazy(self):
 
2518
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2519
                                    'TestOptionRegistry.lazy_option')
 
2520
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
 
2521
 
 
2522
    def test_registered_lazy_help(self):
 
2523
        self.registry.register_lazy('lazy_foo', self.__module__,
 
2524
                                    'TestOptionRegistry.lazy_option')
 
2525
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
 
2526
 
 
2527
 
 
2528
class TestRegisteredOptions(tests.TestCase):
 
2529
    """All registered options should verify some constraints."""
 
2530
 
 
2531
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
 
2532
                 in config.option_registry.iteritems()]
 
2533
 
 
2534
    def setUp(self):
 
2535
        super(TestRegisteredOptions, self).setUp()
 
2536
        self.registry = config.option_registry
 
2537
 
 
2538
    def test_proper_name(self):
 
2539
        # An option should be registered under its own name, this can't be
 
2540
        # checked at registration time for the lazy ones.
 
2541
        self.assertEquals(self.option_name, self.option.name)
 
2542
 
 
2543
    def test_help_is_set(self):
 
2544
        option_help = self.registry.get_help(self.option_name)
 
2545
        self.assertNotEquals(None, option_help)
 
2546
        # Come on, think about the user, he really wants to know what the
 
2547
        # option is about
 
2548
        self.assertIsNot(None, option_help)
 
2549
        self.assertNotEquals('', option_help)
 
2550
 
 
2551
 
 
2552
class TestSection(tests.TestCase):
 
2553
 
 
2554
    # FIXME: Parametrize so that all sections produced by Stores run these
 
2555
    # tests -- vila 2011-04-01
 
2556
 
 
2557
    def test_get_a_value(self):
 
2558
        a_dict = dict(foo='bar')
 
2559
        section = config.Section('myID', a_dict)
 
2560
        self.assertEquals('bar', section.get('foo'))
 
2561
 
 
2562
    def test_get_unknown_option(self):
 
2563
        a_dict = dict()
 
2564
        section = config.Section(None, a_dict)
 
2565
        self.assertEquals('out of thin air',
 
2566
                          section.get('foo', 'out of thin air'))
 
2567
 
 
2568
    def test_options_is_shared(self):
 
2569
        a_dict = dict()
 
2570
        section = config.Section(None, a_dict)
 
2571
        self.assertIs(a_dict, section.options)
 
2572
 
 
2573
 
 
2574
class TestMutableSection(tests.TestCase):
 
2575
 
 
2576
    scenarios = [('mutable',
 
2577
                  {'get_section':
 
2578
                       lambda opts: config.MutableSection('myID', opts)},),
 
2579
        ]
 
2580
 
 
2581
    def test_set(self):
 
2582
        a_dict = dict(foo='bar')
 
2583
        section = self.get_section(a_dict)
 
2584
        section.set('foo', 'new_value')
 
2585
        self.assertEquals('new_value', section.get('foo'))
 
2586
        # The change appears in the shared section
 
2587
        self.assertEquals('new_value', a_dict.get('foo'))
 
2588
        # We keep track of the change
 
2589
        self.assertTrue('foo' in section.orig)
 
2590
        self.assertEquals('bar', section.orig.get('foo'))
 
2591
 
 
2592
    def test_set_preserve_original_once(self):
 
2593
        a_dict = dict(foo='bar')
 
2594
        section = self.get_section(a_dict)
 
2595
        section.set('foo', 'first_value')
 
2596
        section.set('foo', 'second_value')
 
2597
        # We keep track of the original value
 
2598
        self.assertTrue('foo' in section.orig)
 
2599
        self.assertEquals('bar', section.orig.get('foo'))
 
2600
 
 
2601
    def test_remove(self):
 
2602
        a_dict = dict(foo='bar')
 
2603
        section = self.get_section(a_dict)
 
2604
        section.remove('foo')
 
2605
        # We get None for unknown options via the default value
 
2606
        self.assertEquals(None, section.get('foo'))
 
2607
        # Or we just get the default value
 
2608
        self.assertEquals('unknown', section.get('foo', 'unknown'))
 
2609
        self.assertFalse('foo' in section.options)
 
2610
        # We keep track of the deletion
 
2611
        self.assertTrue('foo' in section.orig)
 
2612
        self.assertEquals('bar', section.orig.get('foo'))
 
2613
 
 
2614
    def test_remove_new_option(self):
 
2615
        a_dict = dict()
 
2616
        section = self.get_section(a_dict)
 
2617
        section.set('foo', 'bar')
 
2618
        section.remove('foo')
 
2619
        self.assertFalse('foo' in section.options)
 
2620
        # The option didn't exist initially so it we need to keep track of it
 
2621
        # with a special value
 
2622
        self.assertTrue('foo' in section.orig)
 
2623
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
 
2624
 
 
2625
 
 
2626
class TestCommandLineStore(tests.TestCase):
 
2627
 
 
2628
    def setUp(self):
 
2629
        super(TestCommandLineStore, self).setUp()
 
2630
        self.store = config.CommandLineStore()
 
2631
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
2632
 
 
2633
    def get_section(self):
 
2634
        """Get the unique section for the command line overrides."""
 
2635
        sections = list(self.store.get_sections())
 
2636
        self.assertLength(1, sections)
 
2637
        store, section = sections[0]
 
2638
        self.assertEquals(self.store, store)
 
2639
        return section
 
2640
 
 
2641
    def test_no_override(self):
 
2642
        self.store._from_cmdline([])
 
2643
        section = self.get_section()
 
2644
        self.assertLength(0, list(section.iter_option_names()))
 
2645
 
 
2646
    def test_simple_override(self):
 
2647
        self.store._from_cmdline(['a=b'])
 
2648
        section = self.get_section()
 
2649
        self.assertEqual('b', section.get('a'))
 
2650
 
 
2651
    def test_list_override(self):
 
2652
        opt = config.ListOption('l')
 
2653
        config.option_registry.register(opt)
 
2654
        self.store._from_cmdline(['l=1,2,3'])
 
2655
        val = self.get_section().get('l')
 
2656
        self.assertEqual('1,2,3', val)
 
2657
        # Reminder: lists should be registered as such explicitely, otherwise
 
2658
        # the conversion needs to be done afterwards.
 
2659
        self.assertEqual(['1', '2', '3'],
 
2660
                         opt.convert_from_unicode(self.store, val))
 
2661
 
 
2662
    def test_multiple_overrides(self):
 
2663
        self.store._from_cmdline(['a=b', 'x=y'])
 
2664
        section = self.get_section()
 
2665
        self.assertEquals('b', section.get('a'))
 
2666
        self.assertEquals('y', section.get('x'))
 
2667
 
 
2668
    def test_wrong_syntax(self):
 
2669
        self.assertRaises(errors.BzrCommandError,
 
2670
                          self.store._from_cmdline, ['a=b', 'c'])
 
2671
 
 
2672
class TestStoreMinimalAPI(tests.TestCaseWithTransport):
 
2673
 
 
2674
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2675
                 in config.test_store_builder_registry.iteritems()] + [
 
2676
        ('cmdline', {'get_store': lambda test: config.CommandLineStore()})]
 
2677
 
 
2678
    def test_id(self):
 
2679
        store = self.get_store(self)
 
2680
        if type(store) == config.TransportIniFileStore:
 
2681
            raise tests.TestNotApplicable(
 
2682
                "%s is not a concrete Store implementation"
 
2683
                " so it doesn't need an id" % (store.__class__.__name__,))
 
2684
        self.assertIsNot(None, store.id)
 
2685
 
 
2686
 
 
2687
class TestStore(tests.TestCaseWithTransport):
 
2688
 
 
2689
    def assertSectionContent(self, expected, (store, section)):
 
2690
        """Assert that some options have the proper values in a section."""
 
2691
        expected_name, expected_options = expected
 
2692
        self.assertEquals(expected_name, section.id)
 
2693
        self.assertEquals(
 
2694
            expected_options,
 
2695
            dict([(k, section.get(k)) for k in expected_options.keys()]))
 
2696
 
 
2697
 
 
2698
class TestReadonlyStore(TestStore):
 
2699
 
 
2700
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2701
                 in config.test_store_builder_registry.iteritems()]
 
2702
 
 
2703
    def test_building_delays_load(self):
 
2704
        store = self.get_store(self)
 
2705
        self.assertEquals(False, store.is_loaded())
 
2706
        store._load_from_string('')
 
2707
        self.assertEquals(True, store.is_loaded())
 
2708
 
 
2709
    def test_get_no_sections_for_empty(self):
 
2710
        store = self.get_store(self)
 
2711
        store._load_from_string('')
 
2712
        self.assertEquals([], list(store.get_sections()))
 
2713
 
 
2714
    def test_get_default_section(self):
 
2715
        store = self.get_store(self)
 
2716
        store._load_from_string('foo=bar')
 
2717
        sections = list(store.get_sections())
 
2718
        self.assertLength(1, sections)
 
2719
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2720
 
 
2721
    def test_get_named_section(self):
 
2722
        store = self.get_store(self)
 
2723
        store._load_from_string('[baz]\nfoo=bar')
 
2724
        sections = list(store.get_sections())
 
2725
        self.assertLength(1, sections)
 
2726
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
2727
 
 
2728
    def test_load_from_string_fails_for_non_empty_store(self):
 
2729
        store = self.get_store(self)
 
2730
        store._load_from_string('foo=bar')
 
2731
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
 
2732
 
 
2733
 
 
2734
class TestStoreQuoting(TestStore):
 
2735
 
 
2736
    scenarios = [(key, {'get_store': builder}) for key, builder
 
2737
                 in config.test_store_builder_registry.iteritems()]
 
2738
 
 
2739
    def setUp(self):
 
2740
        super(TestStoreQuoting, self).setUp()
 
2741
        self.store = self.get_store(self)
 
2742
        # We need a loaded store but any content will do
 
2743
        self.store._load_from_string('')
 
2744
 
 
2745
    def assertIdempotent(self, s):
 
2746
        """Assert that quoting an unquoted string is a no-op and vice-versa.
 
2747
 
 
2748
        What matters here is that option values, as they appear in a store, can
 
2749
        be safely round-tripped out of the store and back.
 
2750
 
 
2751
        :param s: A string, quoted if required.
 
2752
        """
 
2753
        self.assertEquals(s, self.store.quote(self.store.unquote(s)))
 
2754
        self.assertEquals(s, self.store.unquote(self.store.quote(s)))
 
2755
 
 
2756
    def test_empty_string(self):
 
2757
        if isinstance(self.store, config.IniFileStore):
 
2758
            # configobj._quote doesn't handle empty values
 
2759
            self.assertRaises(AssertionError,
 
2760
                              self.assertIdempotent, '')
 
2761
        else:
 
2762
            self.assertIdempotent('')
 
2763
        # But quoted empty strings are ok
 
2764
        self.assertIdempotent('""')
 
2765
 
 
2766
    def test_embedded_spaces(self):
 
2767
        self.assertIdempotent('" a b c "')
 
2768
 
 
2769
    def test_embedded_commas(self):
 
2770
        self.assertIdempotent('" a , b c "')
 
2771
 
 
2772
    def test_simple_comma(self):
 
2773
        if isinstance(self.store, config.IniFileStore):
 
2774
            # configobj requires that lists are special-cased
 
2775
           self.assertRaises(AssertionError,
 
2776
                             self.assertIdempotent, ',')
 
2777
        else:
 
2778
            self.assertIdempotent(',')
 
2779
        # When a single comma is required, quoting is also required
 
2780
        self.assertIdempotent('","')
 
2781
 
 
2782
    def test_list(self):
 
2783
        if isinstance(self.store, config.IniFileStore):
 
2784
            # configobj requires that lists are special-cased
 
2785
            self.assertRaises(AssertionError,
 
2786
                              self.assertIdempotent, 'a,b')
 
2787
        else:
 
2788
            self.assertIdempotent('a,b')
 
2789
 
 
2790
 
 
2791
class TestDictFromStore(tests.TestCase):
 
2792
 
 
2793
    def test_unquote_not_string(self):
 
2794
        conf = config.MemoryStack('x=2\n[a_section]\na=1\n')
 
2795
        value = conf.get('a_section')
 
2796
        # Urgh, despite 'conf' asking for the no-name section, we get the
 
2797
        # content of another section as a dict o_O
 
2798
        self.assertEquals({'a': '1'}, value)
 
2799
        unquoted = conf.store.unquote(value)
 
2800
        # Which cannot be unquoted but shouldn't crash either (the use cases
 
2801
        # are getting the value or displaying it. In the later case, '%s' will
 
2802
        # do).
 
2803
        self.assertEquals({'a': '1'}, unquoted)
 
2804
        self.assertEquals("{u'a': u'1'}", '%s' % (unquoted,))
 
2805
 
 
2806
 
 
2807
class TestIniFileStoreContent(tests.TestCaseWithTransport):
 
2808
    """Simulate loading a config store with content of various encodings.
 
2809
 
 
2810
    All files produced by bzr are in utf8 content.
 
2811
 
 
2812
    Users may modify them manually and end up with a file that can't be
 
2813
    loaded. We need to issue proper error messages in this case.
 
2814
    """
 
2815
 
 
2816
    invalid_utf8_char = '\xff'
 
2817
 
 
2818
    def test_load_utf8(self):
 
2819
        """Ensure we can load an utf8-encoded file."""
 
2820
        t = self.get_transport()
 
2821
        # From http://pad.lv/799212
 
2822
        unicode_user = u'b\N{Euro Sign}ar'
 
2823
        unicode_content = u'user=%s' % (unicode_user,)
 
2824
        utf8_content = unicode_content.encode('utf8')
 
2825
        # Store the raw content in the config file
 
2826
        t.put_bytes('foo.conf', utf8_content)
 
2827
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2828
        store.load()
 
2829
        stack = config.Stack([store.get_sections], store)
 
2830
        self.assertEquals(unicode_user, stack.get('user'))
 
2831
 
 
2832
    def test_load_non_ascii(self):
 
2833
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2834
        t = self.get_transport()
 
2835
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2836
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2837
        self.assertRaises(errors.ConfigContentError, store.load)
 
2838
 
 
2839
    def test_load_erroneous_content(self):
 
2840
        """Ensure we display a proper error on content that can't be parsed."""
 
2841
        t = self.get_transport()
 
2842
        t.put_bytes('foo.conf', '[open_section\n')
 
2843
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2844
        self.assertRaises(errors.ParseConfigError, store.load)
 
2845
 
 
2846
    def test_load_permission_denied(self):
 
2847
        """Ensure we get warned when trying to load an inaccessible file."""
 
2848
        warnings = []
 
2849
        def warning(*args):
 
2850
            warnings.append(args[0] % args[1:])
 
2851
        self.overrideAttr(trace, 'warning', warning)
 
2852
 
 
2853
        t = self.get_transport()
 
2854
 
 
2855
        def get_bytes(relpath):
 
2856
            raise errors.PermissionDenied(relpath, "")
 
2857
        t.get_bytes = get_bytes
 
2858
        store = config.TransportIniFileStore(t, 'foo.conf')
 
2859
        self.assertRaises(errors.PermissionDenied, store.load)
 
2860
        self.assertEquals(
 
2861
            warnings,
 
2862
            [u'Permission denied while trying to load configuration store %s.'
 
2863
             % store.external_url()])
 
2864
 
 
2865
 
 
2866
class TestIniConfigContent(tests.TestCaseWithTransport):
 
2867
    """Simulate loading a IniBasedConfig with content of various encodings.
 
2868
 
 
2869
    All files produced by bzr are in utf8 content.
 
2870
 
 
2871
    Users may modify them manually and end up with a file that can't be
 
2872
    loaded. We need to issue proper error messages in this case.
 
2873
    """
 
2874
 
 
2875
    invalid_utf8_char = '\xff'
 
2876
 
 
2877
    def test_load_utf8(self):
 
2878
        """Ensure we can load an utf8-encoded file."""
 
2879
        # From http://pad.lv/799212
 
2880
        unicode_user = u'b\N{Euro Sign}ar'
 
2881
        unicode_content = u'user=%s' % (unicode_user,)
 
2882
        utf8_content = unicode_content.encode('utf8')
 
2883
        # Store the raw content in the config file
 
2884
        with open('foo.conf', 'wb') as f:
 
2885
            f.write(utf8_content)
 
2886
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2887
        self.assertEquals(unicode_user, conf.get_user_option('user'))
 
2888
 
 
2889
    def test_load_badly_encoded_content(self):
 
2890
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
 
2891
        with open('foo.conf', 'wb') as f:
 
2892
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
 
2893
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2894
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
 
2895
 
 
2896
    def test_load_erroneous_content(self):
 
2897
        """Ensure we display a proper error on content that can't be parsed."""
 
2898
        with open('foo.conf', 'wb') as f:
 
2899
            f.write('[open_section\n')
 
2900
        conf = config.IniBasedConfig(file_name='foo.conf')
 
2901
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
 
2902
 
 
2903
 
 
2904
class TestMutableStore(TestStore):
 
2905
 
 
2906
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
 
2907
                 in config.test_store_builder_registry.iteritems()]
 
2908
 
 
2909
    def setUp(self):
 
2910
        super(TestMutableStore, self).setUp()
 
2911
        self.transport = self.get_transport()
 
2912
 
 
2913
    def has_store(self, store):
 
2914
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
2915
                                               store.external_url())
 
2916
        return self.transport.has(store_basename)
 
2917
 
 
2918
    def test_save_empty_creates_no_file(self):
 
2919
        # FIXME: There should be a better way than relying on the test
 
2920
        # parametrization to identify branch.conf -- vila 2011-0526
 
2921
        if self.store_id in ('branch', 'remote_branch'):
 
2922
            raise tests.TestNotApplicable(
 
2923
                'branch.conf is *always* created when a branch is initialized')
 
2924
        store = self.get_store(self)
 
2925
        store.save()
 
2926
        self.assertEquals(False, self.has_store(store))
 
2927
 
 
2928
    def test_save_emptied_succeeds(self):
 
2929
        store = self.get_store(self)
 
2930
        store._load_from_string('foo=bar\n')
 
2931
        # FIXME: There should be a better way than relying on the test
 
2932
        # parametrization to identify branch.conf -- vila 2011-0526
 
2933
        if self.store_id in ('branch', 'remote_branch'):
 
2934
            # branch stores requires write locked branches
 
2935
            self.addCleanup(store.branch.lock_write().unlock)
 
2936
        section = store.get_mutable_section(None)
 
2937
        section.remove('foo')
 
2938
        store.save()
 
2939
        self.assertEquals(True, self.has_store(store))
 
2940
        modified_store = self.get_store(self)
 
2941
        sections = list(modified_store.get_sections())
 
2942
        self.assertLength(0, sections)
 
2943
 
 
2944
    def test_save_with_content_succeeds(self):
 
2945
        # FIXME: There should be a better way than relying on the test
 
2946
        # parametrization to identify branch.conf -- vila 2011-0526
 
2947
        if self.store_id in ('branch', 'remote_branch'):
 
2948
            raise tests.TestNotApplicable(
 
2949
                'branch.conf is *always* created when a branch is initialized')
 
2950
        store = self.get_store(self)
 
2951
        store._load_from_string('foo=bar\n')
 
2952
        self.assertEquals(False, self.has_store(store))
 
2953
        store.save()
 
2954
        self.assertEquals(True, self.has_store(store))
 
2955
        modified_store = self.get_store(self)
 
2956
        sections = list(modified_store.get_sections())
 
2957
        self.assertLength(1, sections)
 
2958
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2959
 
 
2960
    def test_set_option_in_empty_store(self):
 
2961
        store = self.get_store(self)
 
2962
        # FIXME: There should be a better way than relying on the test
 
2963
        # parametrization to identify branch.conf -- vila 2011-0526
 
2964
        if self.store_id in ('branch', 'remote_branch'):
 
2965
            # branch stores requires write locked branches
 
2966
            self.addCleanup(store.branch.lock_write().unlock)
 
2967
        section = store.get_mutable_section(None)
 
2968
        section.set('foo', 'bar')
 
2969
        store.save()
 
2970
        modified_store = self.get_store(self)
 
2971
        sections = list(modified_store.get_sections())
 
2972
        self.assertLength(1, sections)
 
2973
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2974
 
 
2975
    def test_set_option_in_default_section(self):
 
2976
        store = self.get_store(self)
 
2977
        store._load_from_string('')
 
2978
        # FIXME: There should be a better way than relying on the test
 
2979
        # parametrization to identify branch.conf -- vila 2011-0526
 
2980
        if self.store_id in ('branch', 'remote_branch'):
 
2981
            # branch stores requires write locked branches
 
2982
            self.addCleanup(store.branch.lock_write().unlock)
 
2983
        section = store.get_mutable_section(None)
 
2984
        section.set('foo', 'bar')
 
2985
        store.save()
 
2986
        modified_store = self.get_store(self)
 
2987
        sections = list(modified_store.get_sections())
 
2988
        self.assertLength(1, sections)
 
2989
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
 
2990
 
 
2991
    def test_set_option_in_named_section(self):
 
2992
        store = self.get_store(self)
 
2993
        store._load_from_string('')
 
2994
        # FIXME: There should be a better way than relying on the test
 
2995
        # parametrization to identify branch.conf -- vila 2011-0526
 
2996
        if self.store_id in ('branch', 'remote_branch'):
 
2997
            # branch stores requires write locked branches
 
2998
            self.addCleanup(store.branch.lock_write().unlock)
 
2999
        section = store.get_mutable_section('baz')
 
3000
        section.set('foo', 'bar')
 
3001
        store.save()
 
3002
        modified_store = self.get_store(self)
 
3003
        sections = list(modified_store.get_sections())
 
3004
        self.assertLength(1, sections)
 
3005
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
 
3006
 
 
3007
    def test_load_hook(self):
 
3008
        # First, we need to ensure that the store exists
 
3009
        store = self.get_store(self)
 
3010
        # FIXME: There should be a better way than relying on the test
 
3011
        # parametrization to identify branch.conf -- vila 2011-0526
 
3012
        if self.store_id in ('branch', 'remote_branch'):
 
3013
            # branch stores requires write locked branches
 
3014
            self.addCleanup(store.branch.lock_write().unlock)
 
3015
        section = store.get_mutable_section('baz')
 
3016
        section.set('foo', 'bar')
 
3017
        store.save()
 
3018
        # Now we can try to load it
 
3019
        store = self.get_store(self)
 
3020
        calls = []
 
3021
        def hook(*args):
 
3022
            calls.append(args)
 
3023
        config.ConfigHooks.install_named_hook('load', hook, None)
 
3024
        self.assertLength(0, calls)
 
3025
        store.load()
 
3026
        self.assertLength(1, calls)
 
3027
        self.assertEquals((store,), calls[0])
 
3028
 
 
3029
    def test_save_hook(self):
 
3030
        calls = []
 
3031
        def hook(*args):
 
3032
            calls.append(args)
 
3033
        config.ConfigHooks.install_named_hook('save', hook, None)
 
3034
        self.assertLength(0, calls)
 
3035
        store = self.get_store(self)
 
3036
        # FIXME: There should be a better way than relying on the test
 
3037
        # parametrization to identify branch.conf -- vila 2011-0526
 
3038
        if self.store_id in ('branch', 'remote_branch'):
 
3039
            # branch stores requires write locked branches
 
3040
            self.addCleanup(store.branch.lock_write().unlock)
 
3041
        section = store.get_mutable_section('baz')
 
3042
        section.set('foo', 'bar')
 
3043
        store.save()
 
3044
        self.assertLength(1, calls)
 
3045
        self.assertEquals((store,), calls[0])
 
3046
 
 
3047
    def test_set_mark_dirty(self):
 
3048
        stack = config.MemoryStack('')
 
3049
        self.assertLength(0, stack.store.dirty_sections)
 
3050
        stack.set('foo', 'baz')
 
3051
        self.assertLength(1, stack.store.dirty_sections)
 
3052
        self.assertTrue(stack.store._need_saving())
 
3053
 
 
3054
    def test_remove_mark_dirty(self):
 
3055
        stack = config.MemoryStack('foo=bar')
 
3056
        self.assertLength(0, stack.store.dirty_sections)
 
3057
        stack.remove('foo')
 
3058
        self.assertLength(1, stack.store.dirty_sections)
 
3059
        self.assertTrue(stack.store._need_saving())
 
3060
 
 
3061
 
 
3062
class TestStoreSaveChanges(tests.TestCaseWithTransport):
 
3063
    """Tests that config changes are kept in memory and saved on-demand."""
 
3064
 
 
3065
    def setUp(self):
 
3066
        super(TestStoreSaveChanges, self).setUp()
 
3067
        self.transport = self.get_transport()
 
3068
        # Most of the tests involve two stores pointing to the same persistent
 
3069
        # storage to observe the effects of concurrent changes
 
3070
        self.st1 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3071
        self.st2 = config.TransportIniFileStore(self.transport, 'foo.conf')
 
3072
        self.warnings = []
 
3073
        def warning(*args):
 
3074
            self.warnings.append(args[0] % args[1:])
 
3075
        self.overrideAttr(trace, 'warning', warning)
 
3076
 
 
3077
    def has_store(self, store):
 
3078
        store_basename = urlutils.relative_url(self.transport.external_url(),
 
3079
                                               store.external_url())
 
3080
        return self.transport.has(store_basename)
 
3081
 
 
3082
    def get_stack(self, store):
 
3083
        # Any stack will do as long as it uses the right store, just a single
 
3084
        # no-name section is enough
 
3085
        return config.Stack([store.get_sections], store)
 
3086
 
 
3087
    def test_no_changes_no_save(self):
 
3088
        s = self.get_stack(self.st1)
 
3089
        s.store.save_changes()
 
3090
        self.assertEquals(False, self.has_store(self.st1))
 
3091
 
 
3092
    def test_unrelated_concurrent_update(self):
 
3093
        s1 = self.get_stack(self.st1)
 
3094
        s2 = self.get_stack(self.st2)
 
3095
        s1.set('foo', 'bar')
 
3096
        s2.set('baz', 'quux')
 
3097
        s1.store.save()
 
3098
        # Changes don't propagate magically
 
3099
        self.assertEquals(None, s1.get('baz'))
 
3100
        s2.store.save_changes()
 
3101
        self.assertEquals('quux', s2.get('baz'))
 
3102
        # Changes are acquired when saving
 
3103
        self.assertEquals('bar', s2.get('foo'))
 
3104
        # Since there is no overlap, no warnings are emitted
 
3105
        self.assertLength(0, self.warnings)
 
3106
 
 
3107
    def test_concurrent_update_modified(self):
 
3108
        s1 = self.get_stack(self.st1)
 
3109
        s2 = self.get_stack(self.st2)
 
3110
        s1.set('foo', 'bar')
 
3111
        s2.set('foo', 'baz')
 
3112
        s1.store.save()
 
3113
        # Last speaker wins
 
3114
        s2.store.save_changes()
 
3115
        self.assertEquals('baz', s2.get('foo'))
 
3116
        # But the user get a warning
 
3117
        self.assertLength(1, self.warnings)
 
3118
        warning = self.warnings[0]
 
3119
        self.assertStartsWith(warning, 'Option foo in section None')
 
3120
        self.assertEndsWith(warning, 'was changed from <CREATED> to bar.'
 
3121
                            ' The baz value will be saved.')
 
3122
 
 
3123
    def test_concurrent_deletion(self):
 
3124
        self.st1._load_from_string('foo=bar')
 
3125
        self.st1.save()
 
3126
        s1 = self.get_stack(self.st1)
 
3127
        s2 = self.get_stack(self.st2)
 
3128
        s1.remove('foo')
 
3129
        s2.remove('foo')
 
3130
        s1.store.save_changes()
 
3131
        # No warning yet
 
3132
        self.assertLength(0, self.warnings)
 
3133
        s2.store.save_changes()
 
3134
        # Now we get one
 
3135
        self.assertLength(1, self.warnings)
 
3136
        warning = self.warnings[0]
 
3137
        self.assertStartsWith(warning, 'Option foo in section None')
 
3138
        self.assertEndsWith(warning, 'was changed from bar to <CREATED>.'
 
3139
                            ' The <DELETED> value will be saved.')
 
3140
 
 
3141
 
 
3142
class TestQuotingIniFileStore(tests.TestCaseWithTransport):
 
3143
 
 
3144
    def get_store(self):
 
3145
        return config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3146
 
 
3147
    def test_get_quoted_string(self):
 
3148
        store = self.get_store()
 
3149
        store._load_from_string('foo= " abc "')
 
3150
        stack = config.Stack([store.get_sections])
 
3151
        self.assertEquals(' abc ', stack.get('foo'))
 
3152
 
 
3153
    def test_set_quoted_string(self):
 
3154
        store = self.get_store()
 
3155
        stack = config.Stack([store.get_sections], store)
 
3156
        stack.set('foo', ' a b c ')
 
3157
        store.save()
 
3158
        self.assertFileEqual('foo = " a b c "' + os.linesep, 'foo.conf')
 
3159
 
 
3160
 
 
3161
class TestTransportIniFileStore(TestStore):
 
3162
 
 
3163
    def test_loading_unknown_file_fails(self):
 
3164
        store = config.TransportIniFileStore(self.get_transport(),
 
3165
            'I-do-not-exist')
 
3166
        self.assertRaises(errors.NoSuchFile, store.load)
 
3167
 
 
3168
    def test_invalid_content(self):
 
3169
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3170
        self.assertEquals(False, store.is_loaded())
 
3171
        exc = self.assertRaises(
 
3172
            errors.ParseConfigError, store._load_from_string,
 
3173
            'this is invalid !')
 
3174
        self.assertEndsWith(exc.filename, 'foo.conf')
 
3175
        # And the load failed
 
3176
        self.assertEquals(False, store.is_loaded())
 
3177
 
 
3178
    def test_get_embedded_sections(self):
 
3179
        # A more complicated example (which also shows that section names and
 
3180
        # option names share the same name space...)
 
3181
        # FIXME: This should be fixed by forbidding dicts as values ?
 
3182
        # -- vila 2011-04-05
 
3183
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3184
        store._load_from_string('''
 
3185
foo=bar
 
3186
l=1,2
 
3187
[DEFAULT]
 
3188
foo_in_DEFAULT=foo_DEFAULT
 
3189
[bar]
 
3190
foo_in_bar=barbar
 
3191
[baz]
 
3192
foo_in_baz=barbaz
 
3193
[[qux]]
 
3194
foo_in_qux=quux
 
3195
''')
 
3196
        sections = list(store.get_sections())
 
3197
        self.assertLength(4, sections)
 
3198
        # The default section has no name.
 
3199
        # List values are provided as strings and need to be explicitly
 
3200
        # converted by specifying from_unicode=list_from_store at option
 
3201
        # registration
 
3202
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
 
3203
                                  sections[0])
 
3204
        self.assertSectionContent(
 
3205
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
 
3206
        self.assertSectionContent(
 
3207
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
 
3208
        # sub sections are provided as embedded dicts.
 
3209
        self.assertSectionContent(
 
3210
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
 
3211
            sections[3])
 
3212
 
 
3213
 
 
3214
class TestLockableIniFileStore(TestStore):
 
3215
 
 
3216
    def test_create_store_in_created_dir(self):
 
3217
        self.assertPathDoesNotExist('dir')
 
3218
        t = self.get_transport('dir/subdir')
 
3219
        store = config.LockableIniFileStore(t, 'foo.conf')
 
3220
        store.get_mutable_section(None).set('foo', 'bar')
 
3221
        store.save()
 
3222
        self.assertPathExists('dir/subdir')
 
3223
 
 
3224
 
 
3225
class TestConcurrentStoreUpdates(TestStore):
 
3226
    """Test that Stores properly handle conccurent updates.
 
3227
 
 
3228
    New Store implementation may fail some of these tests but until such
 
3229
    implementations exist it's hard to properly filter them from the scenarios
 
3230
    applied here. If you encounter such a case, contact the bzr devs.
 
3231
    """
 
3232
 
 
3233
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3234
                 in config.test_stack_builder_registry.iteritems()]
 
3235
 
 
3236
    def setUp(self):
 
3237
        super(TestConcurrentStoreUpdates, self).setUp()
 
3238
        self.stack = self.get_stack(self)
 
3239
        if not isinstance(self.stack, config._CompatibleStack):
 
3240
            raise tests.TestNotApplicable(
 
3241
                '%s is not meant to be compatible with the old config design'
 
3242
                % (self.stack,))
 
3243
        self.stack.set('one', '1')
 
3244
        self.stack.set('two', '2')
 
3245
        # Flush the store
 
3246
        self.stack.store.save()
 
3247
 
 
3248
    def test_simple_read_access(self):
 
3249
        self.assertEquals('1', self.stack.get('one'))
 
3250
 
 
3251
    def test_simple_write_access(self):
 
3252
        self.stack.set('one', 'one')
 
3253
        self.assertEquals('one', self.stack.get('one'))
 
3254
 
 
3255
    def test_listen_to_the_last_speaker(self):
 
3256
        c1 = self.stack
 
3257
        c2 = self.get_stack(self)
 
3258
        c1.set('one', 'ONE')
 
3259
        c2.set('two', 'TWO')
 
3260
        self.assertEquals('ONE', c1.get('one'))
 
3261
        self.assertEquals('TWO', c2.get('two'))
 
3262
        # The second update respect the first one
 
3263
        self.assertEquals('ONE', c2.get('one'))
 
3264
 
 
3265
    def test_last_speaker_wins(self):
 
3266
        # If the same config is not shared, the same variable modified twice
 
3267
        # can only see a single result.
 
3268
        c1 = self.stack
 
3269
        c2 = self.get_stack(self)
 
3270
        c1.set('one', 'c1')
 
3271
        c2.set('one', 'c2')
 
3272
        self.assertEquals('c2', c2.get('one'))
 
3273
        # The first modification is still available until another refresh
 
3274
        # occur
 
3275
        self.assertEquals('c1', c1.get('one'))
 
3276
        c1.set('two', 'done')
 
3277
        self.assertEquals('c2', c1.get('one'))
 
3278
 
 
3279
    def test_writes_are_serialized(self):
 
3280
        c1 = self.stack
 
3281
        c2 = self.get_stack(self)
 
3282
 
 
3283
        # We spawn a thread that will pause *during* the config saving.
 
3284
        before_writing = threading.Event()
 
3285
        after_writing = threading.Event()
 
3286
        writing_done = threading.Event()
 
3287
        c1_save_without_locking_orig = c1.store.save_without_locking
 
3288
        def c1_save_without_locking():
 
3289
            before_writing.set()
 
3290
            c1_save_without_locking_orig()
 
3291
            # The lock is held. We wait for the main thread to decide when to
 
3292
            # continue
 
3293
            after_writing.wait()
 
3294
        c1.store.save_without_locking = c1_save_without_locking
 
3295
        def c1_set():
 
3296
            c1.set('one', 'c1')
 
3297
            writing_done.set()
 
3298
        t1 = threading.Thread(target=c1_set)
 
3299
        # Collect the thread after the test
 
3300
        self.addCleanup(t1.join)
 
3301
        # Be ready to unblock the thread if the test goes wrong
 
3302
        self.addCleanup(after_writing.set)
 
3303
        t1.start()
 
3304
        before_writing.wait()
 
3305
        self.assertRaises(errors.LockContention,
 
3306
                          c2.set, 'one', 'c2')
 
3307
        self.assertEquals('c1', c1.get('one'))
 
3308
        # Let the lock be released
 
3309
        after_writing.set()
 
3310
        writing_done.wait()
 
3311
        c2.set('one', 'c2')
 
3312
        self.assertEquals('c2', c2.get('one'))
 
3313
 
 
3314
    def test_read_while_writing(self):
 
3315
       c1 = self.stack
 
3316
       # We spawn a thread that will pause *during* the write
 
3317
       ready_to_write = threading.Event()
 
3318
       do_writing = threading.Event()
 
3319
       writing_done = threading.Event()
 
3320
       # We override the _save implementation so we know the store is locked
 
3321
       c1_save_without_locking_orig = c1.store.save_without_locking
 
3322
       def c1_save_without_locking():
 
3323
           ready_to_write.set()
 
3324
           # The lock is held. We wait for the main thread to decide when to
 
3325
           # continue
 
3326
           do_writing.wait()
 
3327
           c1_save_without_locking_orig()
 
3328
           writing_done.set()
 
3329
       c1.store.save_without_locking = c1_save_without_locking
 
3330
       def c1_set():
 
3331
           c1.set('one', 'c1')
 
3332
       t1 = threading.Thread(target=c1_set)
 
3333
       # Collect the thread after the test
 
3334
       self.addCleanup(t1.join)
 
3335
       # Be ready to unblock the thread if the test goes wrong
 
3336
       self.addCleanup(do_writing.set)
 
3337
       t1.start()
 
3338
       # Ensure the thread is ready to write
 
3339
       ready_to_write.wait()
 
3340
       self.assertEquals('c1', c1.get('one'))
 
3341
       # If we read during the write, we get the old value
 
3342
       c2 = self.get_stack(self)
 
3343
       self.assertEquals('1', c2.get('one'))
 
3344
       # Let the writing occur and ensure it occurred
 
3345
       do_writing.set()
 
3346
       writing_done.wait()
 
3347
       # Now we get the updated value
 
3348
       c3 = self.get_stack(self)
 
3349
       self.assertEquals('c1', c3.get('one'))
 
3350
 
 
3351
    # FIXME: It may be worth looking into removing the lock dir when it's not
 
3352
    # needed anymore and look at possible fallouts for concurrent lockers. This
 
3353
    # will matter if/when we use config files outside of bazaar directories
 
3354
    # (.bazaar or .bzr) -- vila 20110-04-111
 
3355
 
 
3356
 
 
3357
class TestSectionMatcher(TestStore):
 
3358
 
 
3359
    scenarios = [('location', {'matcher': config.LocationMatcher}),
 
3360
                 ('id', {'matcher': config.NameMatcher}),]
 
3361
 
 
3362
    def setUp(self):
 
3363
        super(TestSectionMatcher, self).setUp()
 
3364
        # Any simple store is good enough
 
3365
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3366
 
 
3367
    def test_no_matches_for_empty_stores(self):
 
3368
        store = self.get_store(self)
 
3369
        store._load_from_string('')
 
3370
        matcher = self.matcher(store, '/bar')
 
3371
        self.assertEquals([], list(matcher.get_sections()))
 
3372
 
 
3373
    def test_build_doesnt_load_store(self):
 
3374
        store = self.get_store(self)
 
3375
        matcher = self.matcher(store, '/bar')
 
3376
        self.assertFalse(store.is_loaded())
 
3377
 
 
3378
 
 
3379
class TestLocationSection(tests.TestCase):
 
3380
 
 
3381
    def get_section(self, options, extra_path):
 
3382
        section = config.Section('foo', options)
 
3383
        return config.LocationSection(section, extra_path)
 
3384
 
 
3385
    def test_simple_option(self):
 
3386
        section = self.get_section({'foo': 'bar'}, '')
 
3387
        self.assertEquals('bar', section.get('foo'))
 
3388
 
 
3389
    def test_option_with_extra_path(self):
 
3390
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
 
3391
                                   'baz')
 
3392
        self.assertEquals('bar/baz', section.get('foo'))
 
3393
 
 
3394
    def test_invalid_policy(self):
 
3395
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
 
3396
                                   'baz')
 
3397
        # invalid policies are ignored
 
3398
        self.assertEquals('bar', section.get('foo'))
 
3399
 
 
3400
 
 
3401
class TestLocationMatcher(TestStore):
 
3402
 
 
3403
    def setUp(self):
 
3404
        super(TestLocationMatcher, self).setUp()
 
3405
        # Any simple store is good enough
 
3406
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3407
 
 
3408
    def test_unrelated_section_excluded(self):
 
3409
        store = self.get_store(self)
 
3410
        store._load_from_string('''
 
3411
[/foo]
 
3412
section=/foo
 
3413
[/foo/baz]
 
3414
section=/foo/baz
 
3415
[/foo/bar]
 
3416
section=/foo/bar
 
3417
[/foo/bar/baz]
 
3418
section=/foo/bar/baz
 
3419
[/quux/quux]
 
3420
section=/quux/quux
 
3421
''')
 
3422
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
 
3423
                           '/quux/quux'],
 
3424
                          [section.id for _, section in store.get_sections()])
 
3425
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
 
3426
        sections = [section for _, section in matcher.get_sections()]
 
3427
        self.assertEquals(['/foo/bar', '/foo'],
 
3428
                          [section.id for section in sections])
 
3429
        self.assertEquals(['quux', 'bar/quux'],
 
3430
                          [section.extra_path for section in sections])
 
3431
 
 
3432
    def test_more_specific_sections_first(self):
 
3433
        store = self.get_store(self)
 
3434
        store._load_from_string('''
 
3435
[/foo]
 
3436
section=/foo
 
3437
[/foo/bar]
 
3438
section=/foo/bar
 
3439
''')
 
3440
        self.assertEquals(['/foo', '/foo/bar'],
 
3441
                          [section.id for _, section in store.get_sections()])
 
3442
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
 
3443
        sections = [section for _, section in matcher.get_sections()]
 
3444
        self.assertEquals(['/foo/bar', '/foo'],
 
3445
                          [section.id for section in sections])
 
3446
        self.assertEquals(['baz', 'bar/baz'],
 
3447
                          [section.extra_path for section in sections])
 
3448
 
 
3449
    def test_appendpath_in_no_name_section(self):
 
3450
        # It's a bit weird to allow appendpath in a no-name section, but
 
3451
        # someone may found a use for it
 
3452
        store = self.get_store(self)
 
3453
        store._load_from_string('''
 
3454
foo=bar
 
3455
foo:policy = appendpath
 
3456
''')
 
3457
        matcher = config.LocationMatcher(store, 'dir/subdir')
 
3458
        sections = list(matcher.get_sections())
 
3459
        self.assertLength(1, sections)
 
3460
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
 
3461
 
 
3462
    def test_file_urls_are_normalized(self):
 
3463
        store = self.get_store(self)
 
3464
        if sys.platform == 'win32':
 
3465
            expected_url = 'file:///C:/dir/subdir'
 
3466
            expected_location = 'C:/dir/subdir'
 
3467
        else:
 
3468
            expected_url = 'file:///dir/subdir'
 
3469
            expected_location = '/dir/subdir'
 
3470
        matcher = config.LocationMatcher(store, expected_url)
 
3471
        self.assertEquals(expected_location, matcher.location)
 
3472
 
 
3473
 
 
3474
class TestStartingPathMatcher(TestStore):
 
3475
 
 
3476
    def setUp(self):
 
3477
        super(TestStartingPathMatcher, self).setUp()
 
3478
        # Any simple store is good enough
 
3479
        self.store = config.IniFileStore()
 
3480
 
 
3481
    def assertSectionIDs(self, expected, location, content):
 
3482
        self.store._load_from_string(content)
 
3483
        matcher = config.StartingPathMatcher(self.store, location)
 
3484
        sections = list(matcher.get_sections())
 
3485
        self.assertLength(len(expected), sections)
 
3486
        self.assertEqual(expected, [section.id for _, section in sections])
 
3487
        return sections
 
3488
 
 
3489
    def test_empty(self):
 
3490
        self.assertSectionIDs([], self.get_url(), '')
 
3491
 
 
3492
    def test_url_vs_local_paths(self):
 
3493
        # The matcher location is an url and the section names are local paths
 
3494
        sections = self.assertSectionIDs(['/foo/bar', '/foo'],
 
3495
                                         'file:///foo/bar/baz', '''\
 
3496
[/foo]
 
3497
[/foo/bar]
 
3498
''')
 
3499
 
 
3500
    def test_local_path_vs_url(self):
 
3501
        # The matcher location is a local path and the section names are urls
 
3502
        sections = self.assertSectionIDs(['file:///foo/bar', 'file:///foo'],
 
3503
                                         '/foo/bar/baz', '''\
 
3504
[file:///foo]
 
3505
[file:///foo/bar]
 
3506
''')
 
3507
 
 
3508
 
 
3509
    def test_no_name_section_included_when_present(self):
 
3510
        # Note that other tests will cover the case where the no-name section
 
3511
        # is empty and as such, not included.
 
3512
        sections = self.assertSectionIDs(['/foo/bar', '/foo', None],
 
3513
                                         '/foo/bar/baz', '''\
 
3514
option = defined so the no-name section exists
 
3515
[/foo]
 
3516
[/foo/bar]
 
3517
''')
 
3518
        self.assertEquals(['baz', 'bar/baz', '/foo/bar/baz'],
 
3519
                          [s.locals['relpath'] for _, s in sections])
 
3520
 
 
3521
    def test_order_reversed(self):
 
3522
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3523
[/foo]
 
3524
[/foo/bar]
 
3525
''')
 
3526
 
 
3527
    def test_unrelated_section_excluded(self):
 
3528
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
 
3529
[/foo]
 
3530
[/foo/qux]
 
3531
[/foo/bar]
 
3532
''')
 
3533
 
 
3534
    def test_glob_included(self):
 
3535
        sections = self.assertSectionIDs(['/foo/*/baz', '/foo/b*', '/foo'],
 
3536
                                         '/foo/bar/baz', '''\
 
3537
[/foo]
 
3538
[/foo/qux]
 
3539
[/foo/b*]
 
3540
[/foo/*/baz]
 
3541
''')
 
3542
        # Note that 'baz' as a relpath for /foo/b* is not fully correct, but
 
3543
        # nothing really is... as far using {relpath} to append it to something
 
3544
        # else, this seems good enough though.
 
3545
        self.assertEquals(['', 'baz', 'bar/baz'],
 
3546
                          [s.locals['relpath'] for _, s in sections])
 
3547
 
 
3548
    def test_respect_order(self):
 
3549
        self.assertSectionIDs(['/foo', '/foo/b*', '/foo/*/baz'],
 
3550
                              '/foo/bar/baz', '''\
 
3551
[/foo/*/baz]
 
3552
[/foo/qux]
 
3553
[/foo/b*]
 
3554
[/foo]
 
3555
''')
 
3556
 
 
3557
 
 
3558
class TestNameMatcher(TestStore):
 
3559
 
 
3560
    def setUp(self):
 
3561
        super(TestNameMatcher, self).setUp()
 
3562
        self.matcher = config.NameMatcher
 
3563
        # Any simple store is good enough
 
3564
        self.get_store = config.test_store_builder_registry.get('configobj')
 
3565
 
 
3566
    def get_matching_sections(self, name):
 
3567
        store = self.get_store(self)
 
3568
        store._load_from_string('''
 
3569
[foo]
 
3570
option=foo
 
3571
[foo/baz]
 
3572
option=foo/baz
 
3573
[bar]
 
3574
option=bar
 
3575
''')
 
3576
        matcher = self.matcher(store, name)
 
3577
        return list(matcher.get_sections())
 
3578
 
 
3579
    def test_matching(self):
 
3580
        sections = self.get_matching_sections('foo')
 
3581
        self.assertLength(1, sections)
 
3582
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
 
3583
 
 
3584
    def test_not_matching(self):
 
3585
        sections = self.get_matching_sections('baz')
 
3586
        self.assertLength(0, sections)
 
3587
 
 
3588
 
 
3589
class TestBaseStackGet(tests.TestCase):
 
3590
 
 
3591
    def setUp(self):
 
3592
        super(TestBaseStackGet, self).setUp()
 
3593
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3594
 
 
3595
    def test_get_first_definition(self):
 
3596
        store1 = config.IniFileStore()
 
3597
        store1._load_from_string('foo=bar')
 
3598
        store2 = config.IniFileStore()
 
3599
        store2._load_from_string('foo=baz')
 
3600
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3601
        self.assertEquals('bar', conf.get('foo'))
 
3602
 
 
3603
    def test_get_with_registered_default_value(self):
 
3604
        config.option_registry.register(config.Option('foo', default='bar'))
 
3605
        conf_stack = config.Stack([])
 
3606
        self.assertEquals('bar', conf_stack.get('foo'))
 
3607
 
 
3608
    def test_get_without_registered_default_value(self):
 
3609
        config.option_registry.register(config.Option('foo'))
 
3610
        conf_stack = config.Stack([])
 
3611
        self.assertEquals(None, conf_stack.get('foo'))
 
3612
 
 
3613
    def test_get_without_default_value_for_not_registered(self):
 
3614
        conf_stack = config.Stack([])
 
3615
        self.assertEquals(None, conf_stack.get('foo'))
 
3616
 
 
3617
    def test_get_for_empty_section_callable(self):
 
3618
        conf_stack = config.Stack([lambda : []])
 
3619
        self.assertEquals(None, conf_stack.get('foo'))
 
3620
 
 
3621
    def test_get_for_broken_callable(self):
 
3622
        # Trying to use and invalid callable raises an exception on first use
 
3623
        conf_stack = config.Stack([object])
 
3624
        self.assertRaises(TypeError, conf_stack.get, 'foo')
 
3625
 
 
3626
 
 
3627
class TestStackWithSimpleStore(tests.TestCase):
 
3628
 
 
3629
    def setUp(self):
 
3630
        super(TestStackWithSimpleStore, self).setUp()
 
3631
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3632
        self.registry = config.option_registry
 
3633
 
 
3634
    def get_conf(self, content=None):
 
3635
        return config.MemoryStack(content)
 
3636
 
 
3637
    def test_override_value_from_env(self):
 
3638
        self.registry.register(
 
3639
            config.Option('foo', default='bar', override_from_env=['FOO']))
 
3640
        self.overrideEnv('FOO', 'quux')
 
3641
        # Env variable provides a default taking over the option one
 
3642
        conf = self.get_conf('foo=store')
 
3643
        self.assertEquals('quux', conf.get('foo'))
 
3644
 
 
3645
    def test_first_override_value_from_env_wins(self):
 
3646
        self.registry.register(
 
3647
            config.Option('foo', default='bar',
 
3648
                          override_from_env=['NO_VALUE', 'FOO', 'BAZ']))
 
3649
        self.overrideEnv('FOO', 'foo')
 
3650
        self.overrideEnv('BAZ', 'baz')
 
3651
        # The first env var set wins
 
3652
        conf = self.get_conf('foo=store')
 
3653
        self.assertEquals('foo', conf.get('foo'))
 
3654
 
 
3655
 
 
3656
class TestMemoryStack(tests.TestCase):
 
3657
 
 
3658
    def test_get(self):
 
3659
        conf = config.MemoryStack('foo=bar')
 
3660
        self.assertEquals('bar', conf.get('foo'))
 
3661
 
 
3662
    def test_set(self):
 
3663
        conf = config.MemoryStack('foo=bar')
 
3664
        conf.set('foo', 'baz')
 
3665
        self.assertEquals('baz', conf.get('foo'))
 
3666
 
 
3667
    def test_no_content(self):
 
3668
        conf = config.MemoryStack()
 
3669
        # No content means no loading
 
3670
        self.assertFalse(conf.store.is_loaded())
 
3671
        self.assertRaises(NotImplementedError, conf.get, 'foo')
 
3672
        # But a content can still be provided
 
3673
        conf.store._load_from_string('foo=bar')
 
3674
        self.assertEquals('bar', conf.get('foo'))
 
3675
 
 
3676
 
 
3677
class TestStackIterSections(tests.TestCase):
 
3678
 
 
3679
    def test_empty_stack(self):
 
3680
        conf = config.Stack([])
 
3681
        sections = list(conf.iter_sections())
 
3682
        self.assertLength(0, sections)
 
3683
 
 
3684
    def test_empty_store(self):
 
3685
        store = config.IniFileStore()
 
3686
        store._load_from_string('')
 
3687
        conf = config.Stack([store.get_sections])
 
3688
        sections = list(conf.iter_sections())
 
3689
        self.assertLength(0, sections)
 
3690
 
 
3691
    def test_simple_store(self):
 
3692
        store = config.IniFileStore()
 
3693
        store._load_from_string('foo=bar')
 
3694
        conf = config.Stack([store.get_sections])
 
3695
        tuples = list(conf.iter_sections())
 
3696
        self.assertLength(1, tuples)
 
3697
        (found_store, found_section) = tuples[0]
 
3698
        self.assertIs(store, found_store)
 
3699
 
 
3700
    def test_two_stores(self):
 
3701
        store1 = config.IniFileStore()
 
3702
        store1._load_from_string('foo=bar')
 
3703
        store2 = config.IniFileStore()
 
3704
        store2._load_from_string('bar=qux')
 
3705
        conf = config.Stack([store1.get_sections, store2.get_sections])
 
3706
        tuples = list(conf.iter_sections())
 
3707
        self.assertLength(2, tuples)
 
3708
        self.assertIs(store1, tuples[0][0])
 
3709
        self.assertIs(store2, tuples[1][0])
 
3710
 
 
3711
 
 
3712
class TestStackWithTransport(tests.TestCaseWithTransport):
 
3713
 
 
3714
    scenarios = [(key, {'get_stack': builder}) for key, builder
 
3715
                 in config.test_stack_builder_registry.iteritems()]
 
3716
 
 
3717
 
 
3718
class TestConcreteStacks(TestStackWithTransport):
 
3719
 
 
3720
    def test_build_stack(self):
 
3721
        # Just a smoke test to help debug builders
 
3722
        stack = self.get_stack(self)
 
3723
 
 
3724
 
 
3725
class TestStackGet(TestStackWithTransport):
 
3726
 
 
3727
    def setUp(self):
 
3728
        super(TestStackGet, self).setUp()
 
3729
        self.conf = self.get_stack(self)
 
3730
 
 
3731
    def test_get_for_empty_stack(self):
 
3732
        self.assertEquals(None, self.conf.get('foo'))
 
3733
 
 
3734
    def test_get_hook(self):
 
3735
        self.conf.set('foo', 'bar')
 
3736
        calls = []
 
3737
        def hook(*args):
 
3738
            calls.append(args)
 
3739
        config.ConfigHooks.install_named_hook('get', hook, None)
 
3740
        self.assertLength(0, calls)
 
3741
        value = self.conf.get('foo')
 
3742
        self.assertEquals('bar', value)
 
3743
        self.assertLength(1, calls)
 
3744
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
 
3745
 
 
3746
 
 
3747
class TestStackGetWithConverter(tests.TestCase):
 
3748
 
 
3749
    def setUp(self):
 
3750
        super(TestStackGetWithConverter, self).setUp()
 
3751
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3752
        self.registry = config.option_registry
 
3753
 
 
3754
    def get_conf(self, content=None):
 
3755
        return config.MemoryStack(content)
 
3756
 
 
3757
    def register_bool_option(self, name, default=None, default_from_env=None):
 
3758
        b = config.Option(name, help='A boolean.',
 
3759
                          default=default, default_from_env=default_from_env,
 
3760
                          from_unicode=config.bool_from_store)
 
3761
        self.registry.register(b)
 
3762
 
 
3763
    def test_get_default_bool_None(self):
 
3764
        self.register_bool_option('foo')
 
3765
        conf = self.get_conf('')
 
3766
        self.assertEquals(None, conf.get('foo'))
 
3767
 
 
3768
    def test_get_default_bool_True(self):
 
3769
        self.register_bool_option('foo', u'True')
 
3770
        conf = self.get_conf('')
 
3771
        self.assertEquals(True, conf.get('foo'))
 
3772
 
 
3773
    def test_get_default_bool_False(self):
 
3774
        self.register_bool_option('foo', False)
 
3775
        conf = self.get_conf('')
 
3776
        self.assertEquals(False, conf.get('foo'))
 
3777
 
 
3778
    def test_get_default_bool_False_as_string(self):
 
3779
        self.register_bool_option('foo', u'False')
 
3780
        conf = self.get_conf('')
 
3781
        self.assertEquals(False, conf.get('foo'))
 
3782
 
 
3783
    def test_get_default_bool_from_env_converted(self):
 
3784
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
 
3785
        self.overrideEnv('FOO', 'False')
 
3786
        conf = self.get_conf('')
 
3787
        self.assertEquals(False, conf.get('foo'))
 
3788
 
 
3789
    def test_get_default_bool_when_conversion_fails(self):
 
3790
        self.register_bool_option('foo', default='True')
 
3791
        conf = self.get_conf('foo=invalid boolean')
 
3792
        self.assertEquals(True, conf.get('foo'))
 
3793
 
 
3794
    def register_integer_option(self, name,
 
3795
                                default=None, default_from_env=None):
 
3796
        i = config.Option(name, help='An integer.',
 
3797
                          default=default, default_from_env=default_from_env,
 
3798
                          from_unicode=config.int_from_store)
 
3799
        self.registry.register(i)
 
3800
 
 
3801
    def test_get_default_integer_None(self):
 
3802
        self.register_integer_option('foo')
 
3803
        conf = self.get_conf('')
 
3804
        self.assertEquals(None, conf.get('foo'))
 
3805
 
 
3806
    def test_get_default_integer(self):
 
3807
        self.register_integer_option('foo', 42)
 
3808
        conf = self.get_conf('')
 
3809
        self.assertEquals(42, conf.get('foo'))
 
3810
 
 
3811
    def test_get_default_integer_as_string(self):
 
3812
        self.register_integer_option('foo', u'42')
 
3813
        conf = self.get_conf('')
 
3814
        self.assertEquals(42, conf.get('foo'))
 
3815
 
 
3816
    def test_get_default_integer_from_env(self):
 
3817
        self.register_integer_option('foo', default_from_env=['FOO'])
 
3818
        self.overrideEnv('FOO', '18')
 
3819
        conf = self.get_conf('')
 
3820
        self.assertEquals(18, conf.get('foo'))
 
3821
 
 
3822
    def test_get_default_integer_when_conversion_fails(self):
 
3823
        self.register_integer_option('foo', default='12')
 
3824
        conf = self.get_conf('foo=invalid integer')
 
3825
        self.assertEquals(12, conf.get('foo'))
 
3826
 
 
3827
    def register_list_option(self, name, default=None, default_from_env=None):
 
3828
        l = config.ListOption(name, help='A list.', default=default,
 
3829
                              default_from_env=default_from_env)
 
3830
        self.registry.register(l)
 
3831
 
 
3832
    def test_get_default_list_None(self):
 
3833
        self.register_list_option('foo')
 
3834
        conf = self.get_conf('')
 
3835
        self.assertEquals(None, conf.get('foo'))
 
3836
 
 
3837
    def test_get_default_list_empty(self):
 
3838
        self.register_list_option('foo', '')
 
3839
        conf = self.get_conf('')
 
3840
        self.assertEquals([], conf.get('foo'))
 
3841
 
 
3842
    def test_get_default_list_from_env(self):
 
3843
        self.register_list_option('foo', default_from_env=['FOO'])
 
3844
        self.overrideEnv('FOO', '')
 
3845
        conf = self.get_conf('')
 
3846
        self.assertEquals([], conf.get('foo'))
 
3847
 
 
3848
    def test_get_with_list_converter_no_item(self):
 
3849
        self.register_list_option('foo', None)
 
3850
        conf = self.get_conf('foo=,')
 
3851
        self.assertEquals([], conf.get('foo'))
 
3852
 
 
3853
    def test_get_with_list_converter_many_items(self):
 
3854
        self.register_list_option('foo', None)
 
3855
        conf = self.get_conf('foo=m,o,r,e')
 
3856
        self.assertEquals(['m', 'o', 'r', 'e'], conf.get('foo'))
 
3857
 
 
3858
    def test_get_with_list_converter_embedded_spaces_many_items(self):
 
3859
        self.register_list_option('foo', None)
 
3860
        conf = self.get_conf('foo=" bar", "baz "')
 
3861
        self.assertEquals([' bar', 'baz '], conf.get('foo'))
 
3862
 
 
3863
    def test_get_with_list_converter_stripped_spaces_many_items(self):
 
3864
        self.register_list_option('foo', None)
 
3865
        conf = self.get_conf('foo= bar ,  baz ')
 
3866
        self.assertEquals(['bar', 'baz'], conf.get('foo'))
 
3867
 
 
3868
 
 
3869
class TestIterOptionRefs(tests.TestCase):
 
3870
    """iter_option_refs is a bit unusual, document some cases."""
 
3871
 
 
3872
    def assertRefs(self, expected, string):
 
3873
        self.assertEquals(expected, list(config.iter_option_refs(string)))
 
3874
 
 
3875
    def test_empty(self):
 
3876
        self.assertRefs([(False, '')], '')
 
3877
 
 
3878
    def test_no_refs(self):
 
3879
        self.assertRefs([(False, 'foo bar')], 'foo bar')
 
3880
 
 
3881
    def test_single_ref(self):
 
3882
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
 
3883
 
 
3884
    def test_broken_ref(self):
 
3885
        self.assertRefs([(False, '{foo')], '{foo')
 
3886
 
 
3887
    def test_embedded_ref(self):
 
3888
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
 
3889
                        '{{foo}}')
 
3890
 
 
3891
    def test_two_refs(self):
 
3892
        self.assertRefs([(False, ''), (True, '{foo}'),
 
3893
                         (False, ''), (True, '{bar}'),
 
3894
                         (False, ''),],
 
3895
                        '{foo}{bar}')
 
3896
 
 
3897
    def test_newline_in_refs_are_not_matched(self):
 
3898
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
 
3899
 
 
3900
 
 
3901
class TestStackExpandOptions(tests.TestCaseWithTransport):
 
3902
 
 
3903
    def setUp(self):
 
3904
        super(TestStackExpandOptions, self).setUp()
 
3905
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
 
3906
        self.registry = config.option_registry
 
3907
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
 
3908
        self.conf = config.Stack([store.get_sections], store)
 
3909
 
 
3910
    def assertExpansion(self, expected, string, env=None):
 
3911
        self.assertEquals(expected, self.conf.expand_options(string, env))
 
3912
 
 
3913
    def test_no_expansion(self):
 
3914
        self.assertExpansion('foo', 'foo')
 
3915
 
 
3916
    def test_expand_default_value(self):
 
3917
        self.conf.store._load_from_string('bar=baz')
 
3918
        self.registry.register(config.Option('foo', default=u'{bar}'))
 
3919
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3920
 
 
3921
    def test_expand_default_from_env(self):
 
3922
        self.conf.store._load_from_string('bar=baz')
 
3923
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
 
3924
        self.overrideEnv('FOO', '{bar}')
 
3925
        self.assertEquals('baz', self.conf.get('foo', expand=True))
 
3926
 
 
3927
    def test_expand_default_on_failed_conversion(self):
 
3928
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
 
3929
        self.registry.register(
 
3930
            config.Option('foo', default=u'{bar}',
 
3931
                          from_unicode=config.int_from_store))
 
3932
        self.assertEquals(42, self.conf.get('foo', expand=True))
 
3933
 
 
3934
    def test_env_adding_options(self):
 
3935
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3936
 
 
3937
    def test_env_overriding_options(self):
 
3938
        self.conf.store._load_from_string('foo=baz')
 
3939
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
 
3940
 
 
3941
    def test_simple_ref(self):
 
3942
        self.conf.store._load_from_string('foo=xxx')
 
3943
        self.assertExpansion('xxx', '{foo}')
 
3944
 
 
3945
    def test_unknown_ref(self):
 
3946
        self.assertRaises(errors.ExpandingUnknownOption,
 
3947
                          self.conf.expand_options, '{foo}')
 
3948
 
 
3949
    def test_indirect_ref(self):
 
3950
        self.conf.store._load_from_string('''
 
3951
foo=xxx
 
3952
bar={foo}
 
3953
''')
 
3954
        self.assertExpansion('xxx', '{bar}')
 
3955
 
 
3956
    def test_embedded_ref(self):
 
3957
        self.conf.store._load_from_string('''
 
3958
foo=xxx
 
3959
bar=foo
 
3960
''')
 
3961
        self.assertExpansion('xxx', '{{bar}}')
 
3962
 
 
3963
    def test_simple_loop(self):
 
3964
        self.conf.store._load_from_string('foo={foo}')
 
3965
        self.assertRaises(errors.OptionExpansionLoop,
 
3966
                          self.conf.expand_options, '{foo}')
 
3967
 
 
3968
    def test_indirect_loop(self):
 
3969
        self.conf.store._load_from_string('''
 
3970
foo={bar}
 
3971
bar={baz}
 
3972
baz={foo}''')
 
3973
        e = self.assertRaises(errors.OptionExpansionLoop,
 
3974
                              self.conf.expand_options, '{foo}')
 
3975
        self.assertEquals('foo->bar->baz', e.refs)
 
3976
        self.assertEquals('{foo}', e.string)
 
3977
 
 
3978
    def test_list(self):
 
3979
        self.conf.store._load_from_string('''
 
3980
foo=start
 
3981
bar=middle
 
3982
baz=end
 
3983
list={foo},{bar},{baz}
 
3984
''')
 
3985
        self.registry.register(
 
3986
            config.ListOption('list'))
 
3987
        self.assertEquals(['start', 'middle', 'end'],
 
3988
                           self.conf.get('list', expand=True))
 
3989
 
 
3990
    def test_cascading_list(self):
 
3991
        self.conf.store._load_from_string('''
 
3992
foo=start,{bar}
 
3993
bar=middle,{baz}
 
3994
baz=end
 
3995
list={foo}
 
3996
''')
 
3997
        self.registry.register(config.ListOption('list'))
 
3998
        # Register an intermediate option as a list to ensure no conversion
 
3999
        # happen while expanding. Conversion should only occur for the original
 
4000
        # option ('list' here).
 
4001
        self.registry.register(config.ListOption('baz'))
 
4002
        self.assertEquals(['start', 'middle', 'end'],
 
4003
                           self.conf.get('list', expand=True))
 
4004
 
 
4005
    def test_pathologically_hidden_list(self):
 
4006
        self.conf.store._load_from_string('''
 
4007
foo=bin
 
4008
bar=go
 
4009
start={foo
 
4010
middle=},{
 
4011
end=bar}
 
4012
hidden={start}{middle}{end}
 
4013
''')
 
4014
        # What matters is what the registration says, the conversion happens
 
4015
        # only after all expansions have been performed
 
4016
        self.registry.register(config.ListOption('hidden'))
 
4017
        self.assertEquals(['bin', 'go'],
 
4018
                          self.conf.get('hidden', expand=True))
 
4019
 
 
4020
 
 
4021
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
 
4022
 
 
4023
    def setUp(self):
 
4024
        super(TestStackCrossSectionsExpand, self).setUp()
 
4025
 
 
4026
    def get_config(self, location, string):
 
4027
        if string is None:
 
4028
            string = ''
 
4029
        # Since we don't save the config we won't strictly require to inherit
 
4030
        # from TestCaseInTempDir, but an error occurs so quickly...
 
4031
        c = config.LocationStack(location)
 
4032
        c.store._load_from_string(string)
 
4033
        return c
 
4034
 
 
4035
    def test_dont_cross_unrelated_section(self):
 
4036
        c = self.get_config('/another/branch/path','''
 
4037
[/one/branch/path]
 
4038
foo = hello
 
4039
bar = {foo}/2
 
4040
 
 
4041
[/another/branch/path]
 
4042
bar = {foo}/2
 
4043
''')
 
4044
        self.assertRaises(errors.ExpandingUnknownOption,
 
4045
                          c.get, 'bar', expand=True)
 
4046
 
 
4047
    def test_cross_related_sections(self):
 
4048
        c = self.get_config('/project/branch/path','''
 
4049
[/project]
 
4050
foo = qu
 
4051
 
 
4052
[/project/branch/path]
 
4053
bar = {foo}ux
 
4054
''')
 
4055
        self.assertEquals('quux', c.get('bar', expand=True))
 
4056
 
 
4057
 
 
4058
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
 
4059
 
 
4060
    def test_cross_global_locations(self):
 
4061
        l_store = config.LocationStore()
 
4062
        l_store._load_from_string('''
 
4063
[/branch]
 
4064
lfoo = loc-foo
 
4065
lbar = {gbar}
 
4066
''')
 
4067
        l_store.save()
 
4068
        g_store = config.GlobalStore()
 
4069
        g_store._load_from_string('''
 
4070
[DEFAULT]
 
4071
gfoo = {lfoo}
 
4072
gbar = glob-bar
 
4073
''')
 
4074
        g_store.save()
 
4075
        stack = config.LocationStack('/branch')
 
4076
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4077
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
 
4078
 
 
4079
 
 
4080
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
 
4081
 
 
4082
    def test_expand_locals_empty(self):
 
4083
        l_store = config.LocationStore()
 
4084
        l_store._load_from_string('''
 
4085
[/home/user/project]
 
4086
base = {basename}
 
4087
rel = {relpath}
 
4088
''')
 
4089
        l_store.save()
 
4090
        stack = config.LocationStack('/home/user/project/')
 
4091
        self.assertEquals('', stack.get('base', expand=True))
 
4092
        self.assertEquals('', stack.get('rel', expand=True))
 
4093
 
 
4094
    def test_expand_basename_locally(self):
 
4095
        l_store = config.LocationStore()
 
4096
        l_store._load_from_string('''
 
4097
[/home/user/project]
 
4098
bfoo = {basename}
 
4099
''')
 
4100
        l_store.save()
 
4101
        stack = config.LocationStack('/home/user/project/branch')
 
4102
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4103
 
 
4104
    def test_expand_basename_locally_longer_path(self):
 
4105
        l_store = config.LocationStore()
 
4106
        l_store._load_from_string('''
 
4107
[/home/user]
 
4108
bfoo = {basename}
 
4109
''')
 
4110
        l_store.save()
 
4111
        stack = config.LocationStack('/home/user/project/dir/branch')
 
4112
        self.assertEquals('branch', stack.get('bfoo', expand=True))
 
4113
 
 
4114
    def test_expand_relpath_locally(self):
 
4115
        l_store = config.LocationStore()
 
4116
        l_store._load_from_string('''
 
4117
[/home/user/project]
 
4118
lfoo = loc-foo/{relpath}
 
4119
''')
 
4120
        l_store.save()
 
4121
        stack = config.LocationStack('/home/user/project/branch')
 
4122
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4123
 
 
4124
    def test_expand_relpath_unknonw_in_global(self):
 
4125
        g_store = config.GlobalStore()
 
4126
        g_store._load_from_string('''
 
4127
[DEFAULT]
 
4128
gfoo = {relpath}
 
4129
''')
 
4130
        g_store.save()
 
4131
        stack = config.LocationStack('/home/user/project/branch')
 
4132
        self.assertRaises(errors.ExpandingUnknownOption,
 
4133
                          stack.get, 'gfoo', expand=True)
 
4134
 
 
4135
    def test_expand_local_option_locally(self):
 
4136
        l_store = config.LocationStore()
 
4137
        l_store._load_from_string('''
 
4138
[/home/user/project]
 
4139
lfoo = loc-foo/{relpath}
 
4140
lbar = {gbar}
 
4141
''')
 
4142
        l_store.save()
 
4143
        g_store = config.GlobalStore()
 
4144
        g_store._load_from_string('''
 
4145
[DEFAULT]
 
4146
gfoo = {lfoo}
 
4147
gbar = glob-bar
 
4148
''')
 
4149
        g_store.save()
 
4150
        stack = config.LocationStack('/home/user/project/branch')
 
4151
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
 
4152
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
 
4153
 
 
4154
    def test_locals_dont_leak(self):
 
4155
        """Make sure we chose the right local in presence of several sections.
 
4156
        """
 
4157
        l_store = config.LocationStore()
 
4158
        l_store._load_from_string('''
 
4159
[/home/user]
 
4160
lfoo = loc-foo/{relpath}
 
4161
[/home/user/project]
 
4162
lfoo = loc-foo/{relpath}
 
4163
''')
 
4164
        l_store.save()
 
4165
        stack = config.LocationStack('/home/user/project/branch')
 
4166
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
 
4167
        stack = config.LocationStack('/home/user/bar/baz')
 
4168
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
 
4169
 
 
4170
 
 
4171
 
 
4172
class TestStackSet(TestStackWithTransport):
 
4173
 
 
4174
    def test_simple_set(self):
 
4175
        conf = self.get_stack(self)
 
4176
        self.assertEquals(None, conf.get('foo'))
 
4177
        conf.set('foo', 'baz')
 
4178
        # Did we get it back ?
 
4179
        self.assertEquals('baz', conf.get('foo'))
 
4180
 
 
4181
    def test_set_creates_a_new_section(self):
 
4182
        conf = self.get_stack(self)
 
4183
        conf.set('foo', 'baz')
 
4184
        self.assertEquals, 'baz', conf.get('foo')
 
4185
 
 
4186
    def test_set_hook(self):
 
4187
        calls = []
 
4188
        def hook(*args):
 
4189
            calls.append(args)
 
4190
        config.ConfigHooks.install_named_hook('set', hook, None)
 
4191
        self.assertLength(0, calls)
 
4192
        conf = self.get_stack(self)
 
4193
        conf.set('foo', 'bar')
 
4194
        self.assertLength(1, calls)
 
4195
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
 
4196
 
 
4197
 
 
4198
class TestStackRemove(TestStackWithTransport):
 
4199
 
 
4200
    def test_remove_existing(self):
 
4201
        conf = self.get_stack(self)
 
4202
        conf.set('foo', 'bar')
 
4203
        self.assertEquals('bar', conf.get('foo'))
 
4204
        conf.remove('foo')
 
4205
        # Did we get it back ?
 
4206
        self.assertEquals(None, conf.get('foo'))
 
4207
 
 
4208
    def test_remove_unknown(self):
 
4209
        conf = self.get_stack(self)
 
4210
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
 
4211
 
 
4212
    def test_remove_hook(self):
 
4213
        calls = []
 
4214
        def hook(*args):
 
4215
            calls.append(args)
 
4216
        config.ConfigHooks.install_named_hook('remove', hook, None)
 
4217
        self.assertLength(0, calls)
 
4218
        conf = self.get_stack(self)
 
4219
        conf.set('foo', 'bar')
 
4220
        conf.remove('foo')
 
4221
        self.assertLength(1, calls)
 
4222
        self.assertEquals((conf, 'foo'), calls[0])
 
4223
 
 
4224
 
 
4225
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
 
4226
 
 
4227
    def setUp(self):
 
4228
        super(TestConfigGetOptions, self).setUp()
 
4229
        create_configs(self)
 
4230
 
 
4231
    def test_no_variable(self):
 
4232
        # Using branch should query branch, locations and bazaar
 
4233
        self.assertOptions([], self.branch_config)
 
4234
 
 
4235
    def test_option_in_bazaar(self):
 
4236
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4237
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
 
4238
                           self.bazaar_config)
 
4239
 
 
4240
    def test_option_in_locations(self):
 
4241
        self.locations_config.set_user_option('file', 'locations')
 
4242
        self.assertOptions(
 
4243
            [('file', 'locations', self.tree.basedir, 'locations')],
 
4244
            self.locations_config)
 
4245
 
 
4246
    def test_option_in_branch(self):
 
4247
        self.branch_config.set_user_option('file', 'branch')
 
4248
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
 
4249
                           self.branch_config)
 
4250
 
 
4251
    def test_option_in_bazaar_and_branch(self):
 
4252
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4253
        self.branch_config.set_user_option('file', 'branch')
 
4254
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
 
4255
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4256
                           self.branch_config)
 
4257
 
 
4258
    def test_option_in_branch_and_locations(self):
 
4259
        # Hmm, locations override branch :-/
 
4260
        self.locations_config.set_user_option('file', 'locations')
 
4261
        self.branch_config.set_user_option('file', 'branch')
 
4262
        self.assertOptions(
 
4263
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4264
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4265
            self.branch_config)
 
4266
 
 
4267
    def test_option_in_bazaar_locations_and_branch(self):
 
4268
        self.bazaar_config.set_user_option('file', 'bazaar')
 
4269
        self.locations_config.set_user_option('file', 'locations')
 
4270
        self.branch_config.set_user_option('file', 'branch')
 
4271
        self.assertOptions(
 
4272
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4273
             ('file', 'branch', 'DEFAULT', 'branch'),
 
4274
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4275
            self.branch_config)
 
4276
 
 
4277
 
 
4278
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
 
4279
 
 
4280
    def setUp(self):
 
4281
        super(TestConfigRemoveOption, self).setUp()
 
4282
        create_configs_with_file_option(self)
 
4283
 
 
4284
    def test_remove_in_locations(self):
 
4285
        self.locations_config.remove_user_option('file', self.tree.basedir)
 
4286
        self.assertOptions(
 
4287
            [('file', 'branch', 'DEFAULT', 'branch'),
 
4288
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4289
            self.branch_config)
 
4290
 
 
4291
    def test_remove_in_branch(self):
 
4292
        self.branch_config.remove_user_option('file')
 
4293
        self.assertOptions(
 
4294
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4295
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
 
4296
            self.branch_config)
 
4297
 
 
4298
    def test_remove_in_bazaar(self):
 
4299
        self.bazaar_config.remove_user_option('file')
 
4300
        self.assertOptions(
 
4301
            [('file', 'locations', self.tree.basedir, 'locations'),
 
4302
             ('file', 'branch', 'DEFAULT', 'branch'),],
 
4303
            self.branch_config)
 
4304
 
 
4305
 
 
4306
class TestConfigGetSections(tests.TestCaseWithTransport):
 
4307
 
 
4308
    def setUp(self):
 
4309
        super(TestConfigGetSections, self).setUp()
 
4310
        create_configs(self)
 
4311
 
 
4312
    def assertSectionNames(self, expected, conf, name=None):
 
4313
        """Check which sections are returned for a given config.
 
4314
 
 
4315
        If fallback configurations exist their sections can be included.
 
4316
 
 
4317
        :param expected: A list of section names.
 
4318
 
 
4319
        :param conf: The configuration that will be queried.
 
4320
 
 
4321
        :param name: An optional section name that will be passed to
 
4322
            get_sections().
 
4323
        """
 
4324
        sections = list(conf._get_sections(name))
 
4325
        self.assertLength(len(expected), sections)
 
4326
        self.assertEqual(expected, [name for name, _, _ in sections])
 
4327
 
 
4328
    def test_bazaar_default_section(self):
 
4329
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
 
4330
 
 
4331
    def test_locations_default_section(self):
 
4332
        # No sections are defined in an empty file
 
4333
        self.assertSectionNames([], self.locations_config)
 
4334
 
 
4335
    def test_locations_named_section(self):
 
4336
        self.locations_config.set_user_option('file', 'locations')
 
4337
        self.assertSectionNames([self.tree.basedir], self.locations_config)
 
4338
 
 
4339
    def test_locations_matching_sections(self):
 
4340
        loc_config = self.locations_config
 
4341
        loc_config.set_user_option('file', 'locations')
 
4342
        # We need to cheat a bit here to create an option in sections above and
 
4343
        # below the 'location' one.
 
4344
        parser = loc_config._get_parser()
 
4345
        # locations.cong deals with '/' ignoring native os.sep
 
4346
        location_names = self.tree.basedir.split('/')
 
4347
        parent = '/'.join(location_names[:-1])
 
4348
        child = '/'.join(location_names + ['child'])
 
4349
        parser[parent] = {}
 
4350
        parser[parent]['file'] = 'parent'
 
4351
        parser[child] = {}
 
4352
        parser[child]['file'] = 'child'
 
4353
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
 
4354
 
 
4355
    def test_branch_data_default_section(self):
 
4356
        self.assertSectionNames([None],
 
4357
                                self.branch_config._get_branch_data_config())
 
4358
 
 
4359
    def test_branch_default_sections(self):
 
4360
        # No sections are defined in an empty locations file
 
4361
        self.assertSectionNames([None, 'DEFAULT'],
 
4362
                                self.branch_config)
 
4363
        # Unless we define an option
 
4364
        self.branch_config._get_location_config().set_user_option(
 
4365
            'file', 'locations')
 
4366
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
 
4367
                                self.branch_config)
 
4368
 
 
4369
    def test_bazaar_named_section(self):
 
4370
        # We need to cheat as the API doesn't give direct access to sections
 
4371
        # other than DEFAULT.
 
4372
        self.bazaar_config.set_alias('bazaar', 'bzr')
 
4373
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
 
4374
 
 
4375
 
1315
4376
class TestAuthenticationConfigFile(tests.TestCase):
1316
4377
    """Test the authentication.conf file matching"""
1317
4378
 
1332
4393
        self.assertEquals({}, conf._get_config())
1333
4394
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
1334
4395
 
 
4396
    def test_non_utf8_config(self):
 
4397
        conf = config.AuthenticationConfig(_file=StringIO(
 
4398
                'foo = bar\xff'))
 
4399
        self.assertRaises(errors.ConfigContentError, conf._get_config)
 
4400
 
1335
4401
    def test_missing_auth_section_header(self):
1336
4402
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
1337
4403
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
1595
4661
 
1596
4662
    def test_username_defaults_prompts(self):
1597
4663
        # HTTP prompts can't be tested here, see test_http.py
1598
 
        self._check_default_username_prompt('FTP %(host)s username: ', 'ftp')
1599
 
        self._check_default_username_prompt(
1600
 
            'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
1601
 
        self._check_default_username_prompt(
1602
 
            'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
 
4664
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
 
4665
        self._check_default_username_prompt(
 
4666
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
 
4667
        self._check_default_username_prompt(
 
4668
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
1603
4669
 
1604
4670
    def test_username_default_no_prompt(self):
1605
4671
        conf = config.AuthenticationConfig()
1611
4677
    def test_password_default_prompts(self):
1612
4678
        # HTTP prompts can't be tested here, see test_http.py
1613
4679
        self._check_default_password_prompt(
1614
 
            'FTP %(user)s@%(host)s password: ', 'ftp')
1615
 
        self._check_default_password_prompt(
1616
 
            'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
1617
 
        self._check_default_password_prompt(
1618
 
            'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
 
4680
            u'FTP %(user)s@%(host)s password: ', 'ftp')
 
4681
        self._check_default_password_prompt(
 
4682
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
 
4683
        self._check_default_password_prompt(
 
4684
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
1619
4685
        # SMTP port handling is a bit special (it's handled if embedded in the
1620
4686
        # host too)
1621
4687
        # FIXME: should we: forbid that, extend it to other schemes, leave
1622
4688
        # things as they are that's fine thank you ?
1623
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1624
 
                                            'smtp')
1625
 
        self._check_default_password_prompt('SMTP %(user)s@%(host)s password: ',
1626
 
                                            'smtp', host='bar.org:10025')
1627
 
        self._check_default_password_prompt(
1628
 
            'SMTP %(user)s@%(host)s:%(port)d password: ',
1629
 
            'smtp', port=10025)
 
4689
        self._check_default_password_prompt(
 
4690
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
 
4691
        self._check_default_password_prompt(
 
4692
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
 
4693
        self._check_default_password_prompt(
 
4694
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
1630
4695
 
1631
4696
    def test_ssh_password_emits_warning(self):
1632
4697
        conf = config.AuthenticationConfig(_file=StringIO(
1812
4877
# test_user_prompted ?
1813
4878
class TestAuthenticationRing(tests.TestCaseWithTransport):
1814
4879
    pass
 
4880
 
 
4881
 
 
4882
class TestAutoUserId(tests.TestCase):
 
4883
    """Test inferring an automatic user name."""
 
4884
 
 
4885
    def test_auto_user_id(self):
 
4886
        """Automatic inference of user name.
 
4887
 
 
4888
        This is a bit hard to test in an isolated way, because it depends on
 
4889
        system functions that go direct to /etc or perhaps somewhere else.
 
4890
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
 
4891
        to be able to choose a user name with no configuration.
 
4892
        """
 
4893
        if sys.platform == 'win32':
 
4894
            raise tests.TestSkipped(
 
4895
                "User name inference not implemented on win32")
 
4896
        realname, address = config._auto_user_id()
 
4897
        if os.path.exists('/etc/mailname'):
 
4898
            self.assertIsNot(None, realname)
 
4899
            self.assertIsNot(None, address)
 
4900
        else:
 
4901
            self.assertEquals((None, None), (realname, address))
 
4902
 
 
4903
 
 
4904
class EmailOptionTests(tests.TestCase):
 
4905
 
 
4906
    def test_default_email_uses_BZR_EMAIL(self):
 
4907
        conf = config.MemoryStack('email=jelmer@debian.org')
 
4908
        # BZR_EMAIL takes precedence over EMAIL
 
4909
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
 
4910
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4911
        self.assertEquals('jelmer@samba.org', conf.get('email'))
 
4912
 
 
4913
    def test_default_email_uses_EMAIL(self):
 
4914
        conf = config.MemoryStack('')
 
4915
        self.overrideEnv('BZR_EMAIL', None)
 
4916
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
 
4917
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
4918
 
 
4919
    def test_BZR_EMAIL_overrides(self):
 
4920
        conf = config.MemoryStack('email=jelmer@debian.org')
 
4921
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
 
4922
        self.assertEquals('jelmer@apache.org', conf.get('email'))
 
4923
        self.overrideEnv('BZR_EMAIL', None)
 
4924
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
 
4925
        self.assertEquals('jelmer@debian.org', conf.get('email'))
 
4926
 
 
4927
 
 
4928
class MailClientOptionTests(tests.TestCase):
 
4929
 
 
4930
    def test_default(self):
 
4931
        conf = config.MemoryStack('')
 
4932
        client = conf.get('mail_client')
 
4933
        self.assertIs(client, mail_client.DefaultMail)
 
4934
 
 
4935
    def test_evolution(self):
 
4936
        conf = config.MemoryStack('mail_client=evolution')
 
4937
        client = conf.get('mail_client')
 
4938
        self.assertIs(client, mail_client.Evolution)
 
4939
 
 
4940
    def test_kmail(self):
 
4941
        conf = config.MemoryStack('mail_client=kmail')
 
4942
        client = conf.get('mail_client')
 
4943
        self.assertIs(client, mail_client.KMail)
 
4944
 
 
4945
    def test_mutt(self):
 
4946
        conf = config.MemoryStack('mail_client=mutt')
 
4947
        client = conf.get('mail_client')
 
4948
        self.assertIs(client, mail_client.Mutt)
 
4949
 
 
4950
    def test_thunderbird(self):
 
4951
        conf = config.MemoryStack('mail_client=thunderbird')
 
4952
        client = conf.get('mail_client')
 
4953
        self.assertIs(client, mail_client.Thunderbird)
 
4954
 
 
4955
    def test_explicit_default(self):
 
4956
        conf = config.MemoryStack('mail_client=default')
 
4957
        client = conf.get('mail_client')
 
4958
        self.assertIs(client, mail_client.DefaultMail)
 
4959
 
 
4960
    def test_editor(self):
 
4961
        conf = config.MemoryStack('mail_client=editor')
 
4962
        client = conf.get('mail_client')
 
4963
        self.assertIs(client, mail_client.Editor)
 
4964
 
 
4965
    def test_mapi(self):
 
4966
        conf = config.MemoryStack('mail_client=mapi')
 
4967
        client = conf.get('mail_client')
 
4968
        self.assertIs(client, mail_client.MAPIClient)
 
4969
 
 
4970
    def test_xdg_email(self):
 
4971
        conf = config.MemoryStack('mail_client=xdg-email')
 
4972
        client = conf.get('mail_client')
 
4973
        self.assertIs(client, mail_client.XDGEmail)
 
4974
 
 
4975
    def test_unknown(self):
 
4976
        conf = config.MemoryStack('mail_client=firebird')
 
4977
        self.assertRaises(errors.ConfigOptionValueError, conf.get,
 
4978
                'mail_client')