/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to brzlib/tests/test_merge.py

  • Committer: Jelmer Vernooij
  • Date: 2017-05-21 12:41:27 UTC
  • mto: This revision was merged to the branch mainline in revision 6623.
  • Revision ID: jelmer@jelmer.uk-20170521124127-iv8etg0vwymyai6y
s/bzr/brz/ in apport config.

Show diffs side-by-side

added added

removed removed

Lines of Context:
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
import contextlib
18
17
import os
 
18
from StringIO import StringIO
19
19
 
20
 
from .. import (
 
20
from brzlib import (
21
21
    branch as _mod_branch,
 
22
    cleanup,
22
23
    conflicts,
23
24
    errors,
 
25
    inventory,
 
26
    knit,
24
27
    memorytree,
25
28
    merge as _mod_merge,
26
29
    option,
27
30
    revision as _mod_revision,
28
31
    tests,
29
32
    transform,
30
 
    )
31
 
from ..bzr import (
32
 
    inventory,
33
 
    knit,
34
33
    versionedfile,
35
34
    )
36
 
from ..conflicts import ConflictList, TextConflict
37
 
from ..errors import UnrelatedBranches, NoCommits
38
 
from ..merge import transform_tree, merge_inner, _PlanMerge
39
 
from ..osutils import basename, pathjoin, file_kind
40
 
from . import (
 
35
from brzlib.conflicts import ConflictList, TextConflict
 
36
from brzlib.errors import UnrelatedBranches, NoCommits
 
37
from brzlib.merge import transform_tree, merge_inner, _PlanMerge
 
38
from brzlib.osutils import basename, pathjoin, file_kind
 
39
from brzlib.tests import (
41
40
    features,
42
41
    TestCaseWithMemoryTransport,
43
42
    TestCaseWithTransport,
44
43
    test_merge_core,
45
44
    )
46
 
from ..workingtree import WorkingTree
 
45
from brzlib.workingtree import WorkingTree
47
46
 
48
47
 
49
48
class TestMerge(TestCaseWithTransport):
84
83
        tip = wt1.commit('empty commit')
85
84
        wt2 = self.make_branch_and_tree('branch2')
86
85
        wt2.pull(wt1.branch)
87
 
        with open('branch1/foo', 'wb') as f:
88
 
            f.write(b'foo')
89
 
        with open('branch1/bar', 'wb') as f:
90
 
            f.write(b'bar')
 
86
        with file('branch1/foo', 'wb') as f:
 
87
            f.write('foo')
 
88
        with file('branch1/bar', 'wb') as f:
 
89
            f.write('bar')
91
90
        wt1.add('foo')
92
91
        wt1.add('bar')
93
92
        wt1.commit('add foobar')
106
105
        br1.fetch(wt2.branch)
107
106
        # merge all of branch 2 into branch 1 even though they
108
107
        # are not related.
109
 
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), b'null:')
 
108
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), 'null:')
110
109
        self.assertEqual([br1.last_revision(), wt2.branch.last_revision()],
111
 
                         wt1.get_parent_ids())
 
110
            wt1.get_parent_ids())
112
111
        return (wt1, wt2.branch)
113
112
 
114
113
    def test_two_roots(self):
136
135
        with merger.make_preview_transform() as tt:
137
136
            self.assertEqual([], tt.find_conflicts())
138
137
            preview = tt.get_preview_tree()
139
 
            self.assertEqual(wt.path2id(''), preview.path2id(''))
 
138
            self.assertEqual(wt.get_root_id(), preview.get_root_id())
140
139
 
141
140
    def test_merge_unrelated_retains_root(self):
142
141
        wt = self.make_branch_and_tree('tree')
148
147
        with transform.TransformPreview(wt) as merger.tt:
149
148
            merger._compute_transform()
150
149
            new_root_id = merger.tt.final_file_id(merger.tt.root)
151
 
            self.assertEqual(wt.path2id(''), new_root_id)
 
150
            self.assertEqual(wt.get_root_id(), new_root_id)
152
151
 
153
152
    def test_create_rename(self):
154
153
        """Rename an inventory entry while creating the file"""
155
 
        tree = self.make_branch_and_tree('.')
156
 
        with open('name1', 'wb') as f:
157
 
            f.write(b'Hello')
 
154
        tree =self.make_branch_and_tree('.')
 
155
        with file('name1', 'wb') as f: f.write('Hello')
158
156
        tree.add('name1')
159
157
        tree.commit(message="hello")
160
158
        tree.rename_one('name1', 'name2')
163
161
 
164
162
    def test_layered_rename(self):
165
163
        """Rename both child and parent at same time"""
166
 
        tree = self.make_branch_and_tree('.')
 
164
        tree =self.make_branch_and_tree('.')
167
165
        os.mkdir('dirname1')
168
166
        tree.add('dirname1')
169
167
        filename = pathjoin('dirname1', 'name1')
170
 
        with open(filename, 'wb') as f:
171
 
            f.write(b'Hello')
 
168
        with file(filename, 'wb') as f: f.write('Hello')
172
169
        tree.add(filename)
173
170
        tree.commit(message="hello")
174
171
        filename2 = pathjoin('dirname1', 'name2')
178
175
 
179
176
    def test_ignore_zero_merge_inner(self):
180
177
        # Test that merge_inner's ignore zero parameter is effective
181
 
        tree_a = self.make_branch_and_tree('a')
 
178
        tree_a =self.make_branch_and_tree('a')
182
179
        tree_a.commit(message="hello")
183
 
        dir_b = tree_a.controldir.sprout('b')
 
180
        dir_b = tree_a.bzrdir.sprout('b')
184
181
        tree_b = dir_b.open_workingtree()
185
182
        tree_b.lock_write()
186
183
        self.addCleanup(tree_b.unlock)
187
184
        tree_a.commit(message="hello again")
 
185
        log = StringIO()
188
186
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
189
187
                    this_tree=tree_b, ignore_zero=True)
190
188
        self.assertTrue('All changes applied successfully.\n' not in
191
 
                        self.get_log())
 
189
            self.get_log())
192
190
        tree_b.revert()
193
191
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
194
192
                    this_tree=tree_b, ignore_zero=False)
195
 
        self.assertTrue(
196
 
            'All changes applied successfully.\n' in self.get_log())
 
193
        self.assertTrue('All changes applied successfully.\n' in self.get_log())
197
194
 
198
195
    def test_merge_inner_conflicts(self):
199
196
        tree_a = self.make_branch_and_tree('a')
204
201
    def test_rmdir_conflict(self):
205
202
        tree_a = self.make_branch_and_tree('a')
206
203
        self.build_tree(['a/b/'])
207
 
        tree_a.add('b', b'b-id')
 
204
        tree_a.add('b', 'b-id')
208
205
        tree_a.commit('added b')
209
206
        # basis_tree() is only guaranteed to be valid as long as it is actually
210
207
        # the basis tree. This mutates the tree after grabbing basis, so go to
211
208
        # the repository.
212
 
        base_tree = tree_a.branch.repository.revision_tree(
213
 
            tree_a.last_revision())
214
 
        tree_z = tree_a.controldir.sprout('z').open_workingtree()
 
209
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
 
210
        tree_z = tree_a.bzrdir.sprout('z').open_workingtree()
215
211
        self.build_tree(['a/b/c'])
216
212
        tree_a.add('b/c')
217
213
        tree_a.commit('added c')
219
215
        tree_z.commit('removed b')
220
216
        merge_inner(tree_z.branch, tree_a, base_tree, this_tree=tree_z)
221
217
        self.assertEqual([
222
 
            conflicts.MissingParent('Created directory', 'b', b'b-id'),
223
 
            conflicts.UnversionedParent('Versioned directory', 'b', b'b-id')],
 
218
            conflicts.MissingParent('Created directory', 'b', 'b-id'),
 
219
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
224
220
            tree_z.conflicts())
225
221
        merge_inner(tree_a.branch, tree_z.basis_tree(), base_tree,
226
222
                    this_tree=tree_a)
227
223
        self.assertEqual([
228
 
            conflicts.DeletingParent('Not deleting', 'b', b'b-id'),
229
 
            conflicts.UnversionedParent('Versioned directory', 'b', b'b-id')],
 
224
            conflicts.DeletingParent('Not deleting', 'b', 'b-id'),
 
225
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
230
226
            tree_a.conflicts())
231
227
 
232
228
    def test_nested_merge(self):
233
 
        self.knownFailure(
234
 
            'iter_changes doesn\'t work with changes in nested trees')
235
229
        tree = self.make_branch_and_tree('tree',
236
 
                                         format='development-subtree')
 
230
            format='development-subtree')
237
231
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
238
 
                                             format='development-subtree')
239
 
        sub_tree.set_root_id(b'sub-tree-root')
240
 
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
 
232
            format='development-subtree')
 
233
        sub_tree.set_root_id('sub-tree-root')
 
234
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
241
235
        sub_tree.add('file')
242
236
        sub_tree.commit('foo')
243
237
        tree.add_reference(sub_tree)
244
238
        tree.commit('set text to 1')
245
 
        tree2 = tree.controldir.sprout('tree2').open_workingtree()
 
239
        tree2 = tree.bzrdir.sprout('tree2').open_workingtree()
246
240
        # modify the file in the subtree
247
 
        self.build_tree_contents([('tree2/sub-tree/file', b'text2')])
 
241
        self.build_tree_contents([('tree2/sub-tree/file', 'text2')])
248
242
        # and merge the changes from the diverged subtree into the containing
249
243
        # tree
250
244
        tree2.commit('changed file text')
251
245
        tree.merge_from_branch(tree2.branch)
252
 
        self.assertFileEqual(b'text2', 'tree/sub-tree/file')
 
246
        self.assertFileEqual('text2', 'tree/sub-tree/file')
253
247
 
254
248
    def test_merge_with_missing(self):
255
249
        tree_a = self.make_branch_and_tree('tree_a')
256
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
 
250
        self.build_tree_contents([('tree_a/file', 'content_1')])
257
251
        tree_a.add('file')
258
252
        tree_a.commit('commit base')
259
253
        # basis_tree() is only guaranteed to be valid as long as it is actually
260
254
        # the basis tree. This test commits to the tree after grabbing basis,
261
255
        # so we go to the repository.
262
 
        base_tree = tree_a.branch.repository.revision_tree(
263
 
            tree_a.last_revision())
264
 
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
265
 
        self.build_tree_contents([('tree_a/file', b'content_2')])
 
256
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
 
257
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
 
258
        self.build_tree_contents([('tree_a/file', 'content_2')])
266
259
        tree_a.commit('commit other')
267
260
        other_tree = tree_a.basis_tree()
268
261
        # 'file' is now missing but isn't altered in any commit in b so no
272
265
 
273
266
    def test_merge_kind_change(self):
274
267
        tree_a = self.make_branch_and_tree('tree_a')
275
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
276
 
        tree_a.add('file', b'file-id')
 
268
        self.build_tree_contents([('tree_a/file', 'content_1')])
 
269
        tree_a.add('file', 'file-id')
277
270
        tree_a.commit('added file')
278
 
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
 
271
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
279
272
        os.unlink('tree_a/file')
280
273
        self.build_tree(['tree_a/file/'])
281
274
        tree_a.commit('changed file to directory')
283
276
        self.assertEqual('directory', file_kind('tree_b/file'))
284
277
        tree_b.revert()
285
278
        self.assertEqual('file', file_kind('tree_b/file'))
286
 
        self.build_tree_contents([('tree_b/file', b'content_2')])
 
279
        self.build_tree_contents([('tree_b/file', 'content_2')])
287
280
        tree_b.commit('content change')
288
281
        tree_b.merge_from_branch(tree_a.branch)
289
282
        self.assertEqual(tree_b.conflicts(),
290
283
                         [conflicts.ContentsConflict('file',
291
 
                                                     file_id=b'file-id')])
 
284
                          file_id='file-id')])
292
285
 
293
286
    def test_merge_type_registry(self):
294
287
        merge_type_option = option.Option.OPTIONS['merge-type']
295
288
        self.assertFalse('merge4' in [x[0] for x in
296
 
                                      merge_type_option.iter_switches()])
 
289
                        merge_type_option.iter_switches()])
297
290
        registry = _mod_merge.get_merge_type_registry()
298
 
        registry.register_lazy('merge4', 'breezy.merge', 'Merge4Merger',
 
291
        registry.register_lazy('merge4', 'brzlib.merge', 'Merge4Merger',
299
292
                               'time-travelling merge')
300
293
        self.assertTrue('merge4' in [x[0] for x in
301
 
                                     merge_type_option.iter_switches()])
 
294
                        merge_type_option.iter_switches()])
302
295
        registry.remove('merge4')
303
296
        self.assertFalse('merge4' in [x[0] for x in
304
 
                                      merge_type_option.iter_switches()])
 
297
                        merge_type_option.iter_switches()])
305
298
 
306
299
    def test_merge_other_moves_we_deleted(self):
307
300
        tree_a = self.make_branch_and_tree('A')
309
302
        self.addCleanup(tree_a.unlock)
310
303
        self.build_tree(['A/a'])
311
304
        tree_a.add('a')
312
 
        tree_a.commit('1', rev_id=b'rev-1')
 
305
        tree_a.commit('1', rev_id='rev-1')
313
306
        tree_a.flush()
314
307
        tree_a.rename_one('a', 'b')
315
308
        tree_a.commit('2')
316
 
        bzrdir_b = tree_a.controldir.sprout('B', revision_id=b'rev-1')
 
309
        bzrdir_b = tree_a.bzrdir.sprout('B', revision_id='rev-1')
317
310
        tree_b = bzrdir_b.open_workingtree()
318
311
        tree_b.lock_write()
319
312
        self.addCleanup(tree_b.unlock)
331
324
        tree_a.commit('commit 1')
332
325
        tree_a.add(['file_2'])
333
326
        tree_a.commit('commit 2')
334
 
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
 
327
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
335
328
        tree_b.rename_one('file_1', 'renamed')
336
329
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
337
330
        merger.merge_type = _mod_merge.Merge3Merger
345
338
        tree_a.commit('commit 1')
346
339
        tree_a.add(['file_2'])
347
340
        tree_a.commit('commit 2')
348
 
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
 
341
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
349
342
        tree_b.rename_one('file_1', 'renamed')
350
343
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
351
344
        merger.merge_type = _mod_merge.WeaveMerger
364
357
        'c', but not 'b'.
365
358
        """
366
359
        this_tree = self.make_branch_and_tree('this')
367
 
        self.build_tree_contents([('this/file', b"a\n")])
 
360
        self.build_tree_contents([('this/file', "a\n")])
368
361
        this_tree.add('file')
369
362
        this_tree.commit('rev1')
370
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
371
 
        self.build_tree_contents([('other/file', b"a\nb\n")])
372
 
        other_tree.commit('rev2b', rev_id=b'rev2b')
373
 
        self.build_tree_contents([('other/file', b"c\na\nb\n")])
374
 
        other_tree.commit('rev3b', rev_id=b'rev3b')
 
363
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
364
        self.build_tree_contents([('other/file', "a\nb\n")])
 
365
        other_tree.commit('rev2b', rev_id='rev2b')
 
366
        self.build_tree_contents([('other/file', "c\na\nb\n")])
 
367
        other_tree.commit('rev3b', rev_id='rev3b')
375
368
        this_tree.lock_write()
376
369
        self.addCleanup(this_tree.unlock)
377
370
        return this_tree, other_tree
378
371
 
379
372
    def test_weave_cherrypick(self):
380
373
        this_tree, other_tree = self.prepare_cherrypick()
381
 
        merger = _mod_merge.Merger.from_revision_ids(
382
 
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
 
374
        merger = _mod_merge.Merger.from_revision_ids(None,
 
375
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
383
376
        merger.merge_type = _mod_merge.WeaveMerger
384
377
        merger.do_merge()
385
 
        self.assertFileEqual(b'c\na\n', 'this/file')
 
378
        self.assertFileEqual('c\na\n', 'this/file')
386
379
 
387
380
    def test_weave_cannot_reverse_cherrypick(self):
388
381
        this_tree, other_tree = self.prepare_cherrypick()
389
 
        merger = _mod_merge.Merger.from_revision_ids(
390
 
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
 
382
        merger = _mod_merge.Merger.from_revision_ids(None,
 
383
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
391
384
        merger.merge_type = _mod_merge.WeaveMerger
392
385
        self.assertRaises(errors.CannotReverseCherrypick, merger.do_merge)
393
386
 
394
387
    def test_merge3_can_reverse_cherrypick(self):
395
388
        this_tree, other_tree = self.prepare_cherrypick()
396
 
        merger = _mod_merge.Merger.from_revision_ids(
397
 
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
 
389
        merger = _mod_merge.Merger.from_revision_ids(None,
 
390
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
398
391
        merger.merge_type = _mod_merge.Merge3Merger
399
392
        merger.do_merge()
400
393
 
401
394
    def test_merge3_will_detect_cherrypick(self):
402
395
        this_tree = self.make_branch_and_tree('this')
403
 
        self.build_tree_contents([('this/file', b"a\n")])
 
396
        self.build_tree_contents([('this/file', "a\n")])
404
397
        this_tree.add('file')
405
398
        this_tree.commit('rev1')
406
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
407
 
        self.build_tree_contents([('other/file', b"a\nb\n")])
408
 
        other_tree.commit('rev2b', rev_id=b'rev2b')
409
 
        self.build_tree_contents([('other/file', b"a\nb\nc\n")])
410
 
        other_tree.commit('rev3b', rev_id=b'rev3b')
 
399
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
400
        self.build_tree_contents([('other/file', "a\nb\n")])
 
401
        other_tree.commit('rev2b', rev_id='rev2b')
 
402
        self.build_tree_contents([('other/file', "a\nb\nc\n")])
 
403
        other_tree.commit('rev3b', rev_id='rev3b')
411
404
        this_tree.lock_write()
412
405
        self.addCleanup(this_tree.unlock)
413
406
 
414
 
        merger = _mod_merge.Merger.from_revision_ids(
415
 
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
 
407
        merger = _mod_merge.Merger.from_revision_ids(None,
 
408
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
416
409
        merger.merge_type = _mod_merge.Merge3Merger
417
410
        merger.do_merge()
418
 
        self.assertFileEqual(b'a\n'
419
 
                             b'<<<<<<< TREE\n'
420
 
                             b'=======\n'
421
 
                             b'c\n'
422
 
                             b'>>>>>>> MERGE-SOURCE\n',
 
411
        self.assertFileEqual('a\n'
 
412
                             '<<<<<<< TREE\n'
 
413
                             '=======\n'
 
414
                             'c\n'
 
415
                             '>>>>>>> MERGE-SOURCE\n',
423
416
                             'this/file')
424
417
 
425
418
    def test_merge_reverse_revision_range(self):
429
422
        self.build_tree(['a'])
430
423
        tree.add('a')
431
424
        first_rev = tree.commit("added a")
432
 
        merger = _mod_merge.Merger.from_revision_ids(tree,
433
 
                                                     _mod_revision.NULL_REVISION,
434
 
                                                     first_rev)
 
425
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
 
426
                                          _mod_revision.NULL_REVISION,
 
427
                                          first_rev)
435
428
        merger.merge_type = _mod_merge.Merge3Merger
436
429
        merger.interesting_files = 'a'
437
430
        conflict_count = merger.do_merge()
443
436
 
444
437
    def test_make_merger(self):
445
438
        this_tree = self.make_branch_and_tree('this')
446
 
        this_tree.commit('rev1', rev_id=b'rev1')
447
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
448
 
        this_tree.commit('rev2', rev_id=b'rev2a')
449
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
439
        this_tree.commit('rev1', rev_id='rev1')
 
440
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
441
        this_tree.commit('rev2', rev_id='rev2a')
 
442
        other_tree.commit('rev2', rev_id='rev2b')
450
443
        this_tree.lock_write()
451
444
        self.addCleanup(this_tree.unlock)
452
 
        merger = _mod_merge.Merger.from_revision_ids(
453
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
445
        merger = _mod_merge.Merger.from_revision_ids(None,
 
446
            this_tree, 'rev2b', other_branch=other_tree.branch)
454
447
        merger.merge_type = _mod_merge.Merge3Merger
455
448
        tree_merger = merger.make_merger()
456
449
        self.assertIs(_mod_merge.Merge3Merger, tree_merger.__class__)
457
 
        self.assertEqual(b'rev2b',
458
 
                         tree_merger.other_tree.get_revision_id())
459
 
        self.assertEqual(b'rev1',
460
 
                         tree_merger.base_tree.get_revision_id())
 
450
        self.assertEqual('rev2b',
 
451
            tree_merger.other_tree.get_revision_id())
 
452
        self.assertEqual('rev1',
 
453
            tree_merger.base_tree.get_revision_id())
461
454
        self.assertEqual(other_tree.branch, tree_merger.other_branch)
462
455
 
463
456
    def test_make_preview_transform(self):
464
457
        this_tree = self.make_branch_and_tree('this')
465
 
        self.build_tree_contents([('this/file', b'1\n')])
466
 
        this_tree.add('file', b'file-id')
467
 
        this_tree.commit('rev1', rev_id=b'rev1')
468
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
469
 
        self.build_tree_contents([('this/file', b'1\n2a\n')])
470
 
        this_tree.commit('rev2', rev_id=b'rev2a')
471
 
        self.build_tree_contents([('other/file', b'2b\n1\n')])
472
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
458
        self.build_tree_contents([('this/file', '1\n')])
 
459
        this_tree.add('file', 'file-id')
 
460
        this_tree.commit('rev1', rev_id='rev1')
 
461
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
462
        self.build_tree_contents([('this/file', '1\n2a\n')])
 
463
        this_tree.commit('rev2', rev_id='rev2a')
 
464
        self.build_tree_contents([('other/file', '2b\n1\n')])
 
465
        other_tree.commit('rev2', rev_id='rev2b')
473
466
        this_tree.lock_write()
474
467
        self.addCleanup(this_tree.unlock)
475
 
        merger = _mod_merge.Merger.from_revision_ids(
476
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
468
        merger = _mod_merge.Merger.from_revision_ids(None,
 
469
            this_tree, 'rev2b', other_branch=other_tree.branch)
477
470
        merger.merge_type = _mod_merge.Merge3Merger
478
471
        tree_merger = merger.make_merger()
479
 
        with tree_merger.make_preview_transform() as tt:
480
 
            preview_tree = tt.get_preview_tree()
481
 
            with this_tree.get_file('file') as tree_file:
482
 
                self.assertEqual(b'1\n2a\n', tree_file.read())
483
 
            with preview_tree.get_file('file') as preview_file:
484
 
                self.assertEqual(b'2b\n1\n2a\n', preview_file.read())
 
472
        tt = tree_merger.make_preview_transform()
 
473
        self.addCleanup(tt.finalize)
 
474
        preview_tree = tt.get_preview_tree()
 
475
        tree_file = this_tree.get_file('file-id')
 
476
        try:
 
477
            self.assertEqual('1\n2a\n', tree_file.read())
 
478
        finally:
 
479
            tree_file.close()
 
480
        preview_file = preview_tree.get_file('file-id')
 
481
        try:
 
482
            self.assertEqual('2b\n1\n2a\n', preview_file.read())
 
483
        finally:
 
484
            preview_file.close()
485
485
 
486
486
    def test_do_merge(self):
487
487
        this_tree = self.make_branch_and_tree('this')
488
 
        self.build_tree_contents([('this/file', b'1\n')])
489
 
        this_tree.add('file', b'file-id')
490
 
        this_tree.commit('rev1', rev_id=b'rev1')
491
 
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
492
 
        self.build_tree_contents([('this/file', b'1\n2a\n')])
493
 
        this_tree.commit('rev2', rev_id=b'rev2a')
494
 
        self.build_tree_contents([('other/file', b'2b\n1\n')])
495
 
        other_tree.commit('rev2', rev_id=b'rev2b')
 
488
        self.build_tree_contents([('this/file', '1\n')])
 
489
        this_tree.add('file', 'file-id')
 
490
        this_tree.commit('rev1', rev_id='rev1')
 
491
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
492
        self.build_tree_contents([('this/file', '1\n2a\n')])
 
493
        this_tree.commit('rev2', rev_id='rev2a')
 
494
        self.build_tree_contents([('other/file', '2b\n1\n')])
 
495
        other_tree.commit('rev2', rev_id='rev2b')
496
496
        this_tree.lock_write()
497
497
        self.addCleanup(this_tree.unlock)
498
 
        merger = _mod_merge.Merger.from_revision_ids(
499
 
            this_tree, b'rev2b', other_branch=other_tree.branch)
 
498
        merger = _mod_merge.Merger.from_revision_ids(None,
 
499
            this_tree, 'rev2b', other_branch=other_tree.branch)
500
500
        merger.merge_type = _mod_merge.Merge3Merger
501
501
        tree_merger = merger.make_merger()
502
502
        tt = tree_merger.do_merge()
503
 
        with this_tree.get_file('file') as tree_file:
504
 
            self.assertEqual(b'2b\n1\n2a\n', tree_file.read())
 
503
        tree_file = this_tree.get_file('file-id')
 
504
        try:
 
505
            self.assertEqual('2b\n1\n2a\n', tree_file.read())
 
506
        finally:
 
507
            tree_file.close()
505
508
 
506
509
    def test_merge_require_tree_root(self):
507
510
        tree = self.make_branch_and_tree(".")
510
513
        self.build_tree(['a'])
511
514
        tree.add('a')
512
515
        first_rev = tree.commit("added a")
513
 
        old_root_id = tree.path2id('')
514
 
        merger = _mod_merge.Merger.from_revision_ids(tree,
515
 
                                                     _mod_revision.NULL_REVISION,
516
 
                                                     first_rev)
 
516
        old_root_id = tree.get_root_id()
 
517
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
 
518
                                          _mod_revision.NULL_REVISION,
 
519
                                          first_rev)
517
520
        merger.merge_type = _mod_merge.Merge3Merger
518
521
        conflict_count = merger.do_merge()
519
522
        self.assertEqual(0, conflict_count)
520
 
        self.assertEqual({''}, set(tree.all_versioned_paths()))
 
523
        self.assertEqual(set([old_root_id]), tree.all_file_ids())
521
524
        tree.set_parent_ids([])
522
525
 
523
526
    def test_merge_add_into_deleted_root(self):
524
527
        # Yes, people actually do this.  And report bugs if it breaks.
525
528
        source = self.make_branch_and_tree('source', format='rich-root-pack')
526
529
        self.build_tree(['source/foo/'])
527
 
        source.add('foo', b'foo-id')
 
530
        source.add('foo', 'foo-id')
528
531
        source.commit('Add foo')
529
 
        target = source.controldir.sprout('target').open_workingtree()
530
 
        subtree = target.extract('foo')
 
532
        target = source.bzrdir.sprout('target').open_workingtree()
 
533
        subtree = target.extract('foo-id')
531
534
        subtree.commit('Delete root')
532
535
        self.build_tree(['source/bar'])
533
 
        source.add('bar', b'bar-id')
 
536
        source.add('bar', 'bar-id')
534
537
        source.commit('Add bar')
535
538
        subtree.merge_from_branch(source.branch)
536
539
 
543
546
        self.build_tree(['target/bla'])
544
547
        target.add('bla')
545
548
        target.commit('Add bla')
546
 
        nested = source.controldir.sprout('target/subtree').open_workingtree()
 
549
        nested = source.bzrdir.sprout('target/subtree').open_workingtree()
547
550
        target.subsume(nested)
548
551
        target.commit('Join nested')
549
552
        self.build_tree(['source/bar'])
560
563
        mapper = versionedfile.PrefixMapper()
561
564
        factory = knit.make_file_factory(True, mapper)
562
565
        self.vf = factory(self.get_transport())
563
 
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile(b'root')
 
566
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile('root')
564
567
        self.plan_merge_vf.fallback_versionedfiles.append(self.vf)
565
568
 
566
569
    def add_version(self, key, parents, text):
567
 
        self.vf.add_lines(
568
 
            key, parents, [bytes([c]) + b'\n' for c in bytearray(text)])
 
570
        self.vf.add_lines(key, parents, [c+'\n' for c in text])
569
571
 
570
572
    def add_rev(self, prefix, revision_id, parents, text):
571
573
        self.add_version((prefix, revision_id), [(prefix, p) for p in parents],
573
575
 
574
576
    def add_uncommitted_version(self, key, parents, text):
575
577
        self.plan_merge_vf.add_lines(key, parents,
576
 
                                     [bytes([c]) + b'\n' for c in bytearray(text)])
 
578
                                     [c+'\n' for c in text])
577
579
 
578
580
    def setup_plan_merge(self):
579
 
        self.add_rev(b'root', b'A', [], b'abc')
580
 
        self.add_rev(b'root', b'B', [b'A'], b'acehg')
581
 
        self.add_rev(b'root', b'C', [b'A'], b'fabg')
582
 
        return _PlanMerge(b'B', b'C', self.plan_merge_vf, (b'root',))
 
581
        self.add_rev('root', 'A', [], 'abc')
 
582
        self.add_rev('root', 'B', ['A'], 'acehg')
 
583
        self.add_rev('root', 'C', ['A'], 'fabg')
 
584
        return _PlanMerge('B', 'C', self.plan_merge_vf, ('root',))
583
585
 
584
586
    def setup_plan_merge_uncommitted(self):
585
 
        self.add_version((b'root', b'A'), [], b'abc')
586
 
        self.add_uncommitted_version(
587
 
            (b'root', b'B:'), [(b'root', b'A')], b'acehg')
588
 
        self.add_uncommitted_version(
589
 
            (b'root', b'C:'), [(b'root', b'A')], b'fabg')
590
 
        return _PlanMerge(b'B:', b'C:', self.plan_merge_vf, (b'root',))
 
587
        self.add_version(('root', 'A'), [], 'abc')
 
588
        self.add_uncommitted_version(('root', 'B:'), [('root', 'A')], 'acehg')
 
589
        self.add_uncommitted_version(('root', 'C:'), [('root', 'A')], 'fabg')
 
590
        return _PlanMerge('B:', 'C:', self.plan_merge_vf, ('root',))
591
591
 
592
592
    def test_base_from_plan(self):
593
593
        self.setup_plan_merge()
594
 
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
 
594
        plan = self.plan_merge_vf.plan_merge('B', 'C')
595
595
        pwm = versionedfile.PlanWeaveMerge(plan)
596
 
        self.assertEqual([b'a\n', b'b\n', b'c\n'], pwm.base_from_plan())
 
596
        self.assertEqual(['a\n', 'b\n', 'c\n'], pwm.base_from_plan())
597
597
 
598
598
    def test_unique_lines(self):
599
599
        plan = self.setup_plan_merge()
600
600
        self.assertEqual(plan._unique_lines(
601
 
            plan._get_matching_blocks(b'B', b'C')),
 
601
            plan._get_matching_blocks('B', 'C')),
602
602
            ([1, 2, 3], [0, 2]))
603
603
 
604
604
    def test_plan_merge(self):
605
605
        self.setup_plan_merge()
606
 
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
 
606
        plan = self.plan_merge_vf.plan_merge('B', 'C')
607
607
        self.assertEqual([
608
 
            ('new-b', b'f\n'),
609
 
            ('unchanged', b'a\n'),
610
 
            ('killed-a', b'b\n'),
611
 
            ('killed-b', b'c\n'),
612
 
            ('new-a', b'e\n'),
613
 
            ('new-a', b'h\n'),
614
 
            ('new-a', b'g\n'),
615
 
            ('new-b', b'g\n')],
616
 
            list(plan))
 
608
                          ('new-b', 'f\n'),
 
609
                          ('unchanged', 'a\n'),
 
610
                          ('killed-a', 'b\n'),
 
611
                          ('killed-b', 'c\n'),
 
612
                          ('new-a', 'e\n'),
 
613
                          ('new-a', 'h\n'),
 
614
                          ('new-a', 'g\n'),
 
615
                          ('new-b', 'g\n')],
 
616
                         list(plan))
617
617
 
618
618
    def test_plan_merge_cherrypick(self):
619
 
        self.add_rev(b'root', b'A', [], b'abc')
620
 
        self.add_rev(b'root', b'B', [b'A'], b'abcde')
621
 
        self.add_rev(b'root', b'C', [b'A'], b'abcefg')
622
 
        self.add_rev(b'root', b'D', [b'A', b'B', b'C'], b'abcdegh')
623
 
        my_plan = _PlanMerge(b'B', b'D', self.plan_merge_vf, (b'root',))
 
619
        self.add_rev('root', 'A', [], 'abc')
 
620
        self.add_rev('root', 'B', ['A'], 'abcde')
 
621
        self.add_rev('root', 'C', ['A'], 'abcefg')
 
622
        self.add_rev('root', 'D', ['A', 'B', 'C'], 'abcdegh')
 
623
        my_plan = _PlanMerge('B', 'D', self.plan_merge_vf, ('root',))
624
624
        # We shortcut when one text supersedes the other in the per-file graph.
625
625
        # We don't actually need to compare the texts at this point.
626
626
        self.assertEqual([
627
 
            ('new-b', b'a\n'),
628
 
            ('new-b', b'b\n'),
629
 
            ('new-b', b'c\n'),
630
 
            ('new-b', b'd\n'),
631
 
            ('new-b', b'e\n'),
632
 
            ('new-b', b'g\n'),
633
 
            ('new-b', b'h\n')],
634
 
            list(my_plan.plan_merge()))
 
627
                          ('new-b', 'a\n'),
 
628
                          ('new-b', 'b\n'),
 
629
                          ('new-b', 'c\n'),
 
630
                          ('new-b', 'd\n'),
 
631
                          ('new-b', 'e\n'),
 
632
                          ('new-b', 'g\n'),
 
633
                          ('new-b', 'h\n')],
 
634
                          list(my_plan.plan_merge()))
635
635
 
636
636
    def test_plan_merge_no_common_ancestor(self):
637
 
        self.add_rev(b'root', b'A', [], b'abc')
638
 
        self.add_rev(b'root', b'B', [], b'xyz')
639
 
        my_plan = _PlanMerge(b'A', b'B', self.plan_merge_vf, (b'root',))
 
637
        self.add_rev('root', 'A', [], 'abc')
 
638
        self.add_rev('root', 'B', [], 'xyz')
 
639
        my_plan = _PlanMerge('A', 'B', self.plan_merge_vf, ('root',))
640
640
        self.assertEqual([
641
 
            ('new-a', b'a\n'),
642
 
            ('new-a', b'b\n'),
643
 
            ('new-a', b'c\n'),
644
 
            ('new-b', b'x\n'),
645
 
            ('new-b', b'y\n'),
646
 
            ('new-b', b'z\n')],
647
 
            list(my_plan.plan_merge()))
 
641
                          ('new-a', 'a\n'),
 
642
                          ('new-a', 'b\n'),
 
643
                          ('new-a', 'c\n'),
 
644
                          ('new-b', 'x\n'),
 
645
                          ('new-b', 'y\n'),
 
646
                          ('new-b', 'z\n')],
 
647
                          list(my_plan.plan_merge()))
648
648
 
649
649
    def test_plan_merge_tail_ancestors(self):
650
650
        # The graph looks like this:
666
666
        # are already present in E
667
667
 
668
668
        # Introduce the base text
669
 
        self.add_rev(b'root', b'A', [], b'abc')
 
669
        self.add_rev('root', 'A', [], 'abc')
670
670
        # Introduces a new line B
671
 
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
 
671
        self.add_rev('root', 'B', ['A'], 'aBbc')
672
672
        # Introduces a new line C
673
 
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
 
673
        self.add_rev('root', 'C', ['A'], 'abCc')
674
674
        # Introduce new line D
675
 
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
 
675
        self.add_rev('root', 'D', ['B'], 'DaBbc')
676
676
        # Merges B and C by just incorporating both
677
 
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
 
677
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
678
678
        # Introduce new line F
679
 
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
 
679
        self.add_rev('root', 'F', ['C'], 'abCcF')
680
680
        # Merge D & E by just combining the texts
681
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
 
681
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
682
682
        # Merge F & E by just combining the texts
683
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
 
683
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
684
684
        # Merge G & H by just combining texts
685
 
        self.add_rev(b'root', b'I', [b'G', b'H'], b'DaBbCcF')
 
685
        self.add_rev('root', 'I', ['G', 'H'], 'DaBbCcF')
686
686
        # Merge G & H but supersede an old line in B
687
 
        self.add_rev(b'root', b'J', [b'H', b'G'], b'DaJbCcF')
688
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
687
        self.add_rev('root', 'J', ['H', 'G'], 'DaJbCcF')
 
688
        plan = self.plan_merge_vf.plan_merge('I', 'J')
689
689
        self.assertEqual([
690
 
            ('unchanged', b'D\n'),
691
 
            ('unchanged', b'a\n'),
692
 
            ('killed-b', b'B\n'),
693
 
            ('new-b', b'J\n'),
694
 
            ('unchanged', b'b\n'),
695
 
            ('unchanged', b'C\n'),
696
 
            ('unchanged', b'c\n'),
697
 
            ('unchanged', b'F\n')],
698
 
            list(plan))
 
690
                          ('unchanged', 'D\n'),
 
691
                          ('unchanged', 'a\n'),
 
692
                          ('killed-b', 'B\n'),
 
693
                          ('new-b', 'J\n'),
 
694
                          ('unchanged', 'b\n'),
 
695
                          ('unchanged', 'C\n'),
 
696
                          ('unchanged', 'c\n'),
 
697
                          ('unchanged', 'F\n')],
 
698
                         list(plan))
699
699
 
700
700
    def test_plan_merge_tail_triple_ancestors(self):
701
701
        # The graph looks like this:
715
715
        # a third LCA that doesn't add new lines, but will trigger our more
716
716
        # involved ancestry logic
717
717
 
718
 
        self.add_rev(b'root', b'A', [], b'abc')
719
 
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
720
 
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
721
 
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
722
 
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
723
 
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
724
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
725
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
726
 
        self.add_rev(b'root', b'Q', [b'E'], b'aBbCc')
727
 
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DaBbCcF')
 
718
        self.add_rev('root', 'A', [], 'abc')
 
719
        self.add_rev('root', 'B', ['A'], 'aBbc')
 
720
        self.add_rev('root', 'C', ['A'], 'abCc')
 
721
        self.add_rev('root', 'D', ['B'], 'DaBbc')
 
722
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
 
723
        self.add_rev('root', 'F', ['C'], 'abCcF')
 
724
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
 
725
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
 
726
        self.add_rev('root', 'Q', ['E'], 'aBbCc')
 
727
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DaBbCcF')
728
728
        # Merge G & H but supersede an old line in B
729
 
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DaJbCcF')
730
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
729
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DaJbCcF')
 
730
        plan = self.plan_merge_vf.plan_merge('I', 'J')
731
731
        self.assertEqual([
732
 
            ('unchanged', b'D\n'),
733
 
            ('unchanged', b'a\n'),
734
 
            ('killed-b', b'B\n'),
735
 
            ('new-b', b'J\n'),
736
 
            ('unchanged', b'b\n'),
737
 
            ('unchanged', b'C\n'),
738
 
            ('unchanged', b'c\n'),
739
 
            ('unchanged', b'F\n')],
740
 
            list(plan))
 
732
                          ('unchanged', 'D\n'),
 
733
                          ('unchanged', 'a\n'),
 
734
                          ('killed-b', 'B\n'),
 
735
                          ('new-b', 'J\n'),
 
736
                          ('unchanged', 'b\n'),
 
737
                          ('unchanged', 'C\n'),
 
738
                          ('unchanged', 'c\n'),
 
739
                          ('unchanged', 'F\n')],
 
740
                         list(plan))
741
741
 
742
742
    def test_plan_merge_2_tail_triple_ancestors(self):
743
743
        # The graph looks like this:
755
755
        # This is meant to test after hitting a 3-way LCA, and multiple tail
756
756
        # ancestors (only have NULL_REVISION in common)
757
757
 
758
 
        self.add_rev(b'root', b'A', [], b'abc')
759
 
        self.add_rev(b'root', b'B', [], b'def')
760
 
        self.add_rev(b'root', b'D', [b'A'], b'Dabc')
761
 
        self.add_rev(b'root', b'E', [b'A', b'B'], b'abcdef')
762
 
        self.add_rev(b'root', b'F', [b'B'], b'defF')
763
 
        self.add_rev(b'root', b'G', [b'D', b'E'], b'Dabcdef')
764
 
        self.add_rev(b'root', b'H', [b'F', b'E'], b'abcdefF')
765
 
        self.add_rev(b'root', b'Q', [b'E'], b'abcdef')
766
 
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DabcdefF')
 
758
        self.add_rev('root', 'A', [], 'abc')
 
759
        self.add_rev('root', 'B', [], 'def')
 
760
        self.add_rev('root', 'D', ['A'], 'Dabc')
 
761
        self.add_rev('root', 'E', ['A', 'B'], 'abcdef')
 
762
        self.add_rev('root', 'F', ['B'], 'defF')
 
763
        self.add_rev('root', 'G', ['D', 'E'], 'Dabcdef')
 
764
        self.add_rev('root', 'H', ['F', 'E'], 'abcdefF')
 
765
        self.add_rev('root', 'Q', ['E'], 'abcdef')
 
766
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DabcdefF')
767
767
        # Merge G & H but supersede an old line in B
768
 
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DabcdJfF')
769
 
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
 
768
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DabcdJfF')
 
769
        plan = self.plan_merge_vf.plan_merge('I', 'J')
770
770
        self.assertEqual([
771
 
            ('unchanged', b'D\n'),
772
 
            ('unchanged', b'a\n'),
773
 
            ('unchanged', b'b\n'),
774
 
            ('unchanged', b'c\n'),
775
 
            ('unchanged', b'd\n'),
776
 
            ('killed-b', b'e\n'),
777
 
            ('new-b', b'J\n'),
778
 
            ('unchanged', b'f\n'),
779
 
            ('unchanged', b'F\n')],
780
 
            list(plan))
 
771
                          ('unchanged', 'D\n'),
 
772
                          ('unchanged', 'a\n'),
 
773
                          ('unchanged', 'b\n'),
 
774
                          ('unchanged', 'c\n'),
 
775
                          ('unchanged', 'd\n'),
 
776
                          ('killed-b', 'e\n'),
 
777
                          ('new-b', 'J\n'),
 
778
                          ('unchanged', 'f\n'),
 
779
                          ('unchanged', 'F\n')],
 
780
                         list(plan))
781
781
 
782
782
    def test_plan_merge_uncommitted_files(self):
783
783
        self.setup_plan_merge_uncommitted()
784
 
        plan = self.plan_merge_vf.plan_merge(b'B:', b'C:')
 
784
        plan = self.plan_merge_vf.plan_merge('B:', 'C:')
785
785
        self.assertEqual([
786
 
            ('new-b', b'f\n'),
787
 
            ('unchanged', b'a\n'),
788
 
            ('killed-a', b'b\n'),
789
 
            ('killed-b', b'c\n'),
790
 
            ('new-a', b'e\n'),
791
 
            ('new-a', b'h\n'),
792
 
            ('new-a', b'g\n'),
793
 
            ('new-b', b'g\n')],
794
 
            list(plan))
 
786
                          ('new-b', 'f\n'),
 
787
                          ('unchanged', 'a\n'),
 
788
                          ('killed-a', 'b\n'),
 
789
                          ('killed-b', 'c\n'),
 
790
                          ('new-a', 'e\n'),
 
791
                          ('new-a', 'h\n'),
 
792
                          ('new-a', 'g\n'),
 
793
                          ('new-b', 'g\n')],
 
794
                         list(plan))
795
795
 
796
796
    def test_plan_merge_insert_order(self):
797
797
        """Weave merges are sensitive to the order of insertion.
801
801
        same ordering, then the lines match the parents, if they don't only
802
802
        *some* of the lines match.
803
803
        """
804
 
        self.add_rev(b'root', b'A', [], b'abcdef')
805
 
        self.add_rev(b'root', b'B', [b'A'], b'abwxcdef')
806
 
        self.add_rev(b'root', b'C', [b'A'], b'abyzcdef')
 
804
        self.add_rev('root', 'A', [], 'abcdef')
 
805
        self.add_rev('root', 'B', ['A'], 'abwxcdef')
 
806
        self.add_rev('root', 'C', ['A'], 'abyzcdef')
807
807
        # Merge, and resolve the conflict by adding *both* sets of lines
808
808
        # If we get the ordering wrong, these will look like new lines in D,
809
809
        # rather than carried over from B, C
810
 
        self.add_rev(b'root', b'D', [b'B', b'C'],
811
 
                     b'abwxyzcdef')
 
810
        self.add_rev('root', 'D', ['B', 'C'],
 
811
                         'abwxyzcdef')
812
812
        # Supersede the lines in B and delete the lines in C, which will
813
813
        # conflict if they are treated as being in D
814
 
        self.add_rev(b'root', b'E', [b'C', b'B'],
815
 
                     b'abnocdef')
 
814
        self.add_rev('root', 'E', ['C', 'B'],
 
815
                         'abnocdef')
816
816
        # Same thing for the lines in C
817
 
        self.add_rev(b'root', b'F', [b'C'], b'abpqcdef')
818
 
        plan = self.plan_merge_vf.plan_merge(b'D', b'E')
 
817
        self.add_rev('root', 'F', ['C'], 'abpqcdef')
 
818
        plan = self.plan_merge_vf.plan_merge('D', 'E')
819
819
        self.assertEqual([
820
 
            ('unchanged', b'a\n'),
821
 
            ('unchanged', b'b\n'),
822
 
            ('killed-b', b'w\n'),
823
 
            ('killed-b', b'x\n'),
824
 
            ('killed-b', b'y\n'),
825
 
            ('killed-b', b'z\n'),
826
 
            ('new-b', b'n\n'),
827
 
            ('new-b', b'o\n'),
828
 
            ('unchanged', b'c\n'),
829
 
            ('unchanged', b'd\n'),
830
 
            ('unchanged', b'e\n'),
831
 
            ('unchanged', b'f\n')],
832
 
            list(plan))
833
 
        plan = self.plan_merge_vf.plan_merge(b'E', b'D')
 
820
                          ('unchanged', 'a\n'),
 
821
                          ('unchanged', 'b\n'),
 
822
                          ('killed-b', 'w\n'),
 
823
                          ('killed-b', 'x\n'),
 
824
                          ('killed-b', 'y\n'),
 
825
                          ('killed-b', 'z\n'),
 
826
                          ('new-b', 'n\n'),
 
827
                          ('new-b', 'o\n'),
 
828
                          ('unchanged', 'c\n'),
 
829
                          ('unchanged', 'd\n'),
 
830
                          ('unchanged', 'e\n'),
 
831
                          ('unchanged', 'f\n')],
 
832
                         list(plan))
 
833
        plan = self.plan_merge_vf.plan_merge('E', 'D')
834
834
        # Going in the opposite direction shows the effect of the opposite plan
835
835
        self.assertEqual([
836
 
            ('unchanged', b'a\n'),
837
 
            ('unchanged', b'b\n'),
838
 
            ('new-b', b'w\n'),
839
 
            ('new-b', b'x\n'),
840
 
            ('killed-a', b'y\n'),
841
 
            ('killed-a', b'z\n'),
842
 
            ('killed-both', b'w\n'),
843
 
            ('killed-both', b'x\n'),
844
 
            ('new-a', b'n\n'),
845
 
            ('new-a', b'o\n'),
846
 
            ('unchanged', b'c\n'),
847
 
            ('unchanged', b'd\n'),
848
 
            ('unchanged', b'e\n'),
849
 
            ('unchanged', b'f\n')],
850
 
            list(plan))
 
836
                          ('unchanged', 'a\n'),
 
837
                          ('unchanged', 'b\n'),
 
838
                          ('new-b', 'w\n'),
 
839
                          ('new-b', 'x\n'),
 
840
                          ('killed-a', 'y\n'),
 
841
                          ('killed-a', 'z\n'),
 
842
                          ('killed-both', 'w\n'),
 
843
                          ('killed-both', 'x\n'),
 
844
                          ('new-a', 'n\n'),
 
845
                          ('new-a', 'o\n'),
 
846
                          ('unchanged', 'c\n'),
 
847
                          ('unchanged', 'd\n'),
 
848
                          ('unchanged', 'e\n'),
 
849
                          ('unchanged', 'f\n')],
 
850
                         list(plan))
851
851
 
852
852
    def test_plan_merge_criss_cross(self):
853
853
        # This is specificly trying to trigger problems when using limited
874
874
        #   'foo', it should appear as superseding the value in F (since it
875
875
        #   came from B), rather than conflict because of the resolution during
876
876
        #   C & D.
877
 
        self.add_rev(b'root', b'XX', [], b'qrs')
878
 
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
879
 
        self.add_rev(b'root', b'B', [b'A'], b'axcdef')
880
 
        self.add_rev(b'root', b'C', [b'B'], b'axcdefg')
881
 
        self.add_rev(b'root', b'D', [b'B'], b'haxcdef')
882
 
        self.add_rev(b'root', b'E', [b'A'], b'abcdyf')
 
877
        self.add_rev('root', 'XX', [], 'qrs')
 
878
        self.add_rev('root', 'A', ['XX'], 'abcdef')
 
879
        self.add_rev('root', 'B', ['A'], 'axcdef')
 
880
        self.add_rev('root', 'C', ['B'], 'axcdefg')
 
881
        self.add_rev('root', 'D', ['B'], 'haxcdef')
 
882
        self.add_rev('root', 'E', ['A'], 'abcdyf')
883
883
        # Simple combining of all texts
884
 
        self.add_rev(b'root', b'F', [b'C', b'D', b'E'], b'haxcdyfg')
 
884
        self.add_rev('root', 'F', ['C', 'D', 'E'], 'haxcdyfg')
885
885
        # combine and supersede 'x'
886
 
        self.add_rev(b'root', b'G', [b'C', b'D', b'E'], b'hazcdyfg')
887
 
        plan = self.plan_merge_vf.plan_merge(b'F', b'G')
 
886
        self.add_rev('root', 'G', ['C', 'D', 'E'], 'hazcdyfg')
 
887
        plan = self.plan_merge_vf.plan_merge('F', 'G')
888
888
        self.assertEqual([
889
 
            ('unchanged', b'h\n'),
890
 
            ('unchanged', b'a\n'),
891
 
            ('killed-base', b'b\n'),
892
 
            ('killed-b', b'x\n'),
893
 
            ('new-b', b'z\n'),
894
 
            ('unchanged', b'c\n'),
895
 
            ('unchanged', b'd\n'),
896
 
            ('killed-base', b'e\n'),
897
 
            ('unchanged', b'y\n'),
898
 
            ('unchanged', b'f\n'),
899
 
            ('unchanged', b'g\n')],
900
 
            list(plan))
901
 
        plan = self.plan_merge_vf.plan_lca_merge(b'F', b'G')
 
889
                          ('unchanged', 'h\n'),
 
890
                          ('unchanged', 'a\n'),
 
891
                          ('killed-base', 'b\n'),
 
892
                          ('killed-b', 'x\n'),
 
893
                          ('new-b', 'z\n'),
 
894
                          ('unchanged', 'c\n'),
 
895
                          ('unchanged', 'd\n'),
 
896
                          ('killed-base', 'e\n'),
 
897
                          ('unchanged', 'y\n'),
 
898
                          ('unchanged', 'f\n'),
 
899
                          ('unchanged', 'g\n')],
 
900
                         list(plan))
 
901
        plan = self.plan_merge_vf.plan_lca_merge('F', 'G')
902
902
        # This is one of the main differences between plan_merge and
903
903
        # plan_lca_merge. plan_lca_merge generates a conflict for 'x => z',
904
904
        # because 'x' was not present in one of the bases. However, in this
905
905
        # case it is spurious because 'x' does not exist in the global base A.
906
906
        self.assertEqual([
907
 
            ('unchanged', b'h\n'),
908
 
            ('unchanged', b'a\n'),
909
 
            ('conflicted-a', b'x\n'),
910
 
            ('new-b', b'z\n'),
911
 
            ('unchanged', b'c\n'),
912
 
            ('unchanged', b'd\n'),
913
 
            ('unchanged', b'y\n'),
914
 
            ('unchanged', b'f\n'),
915
 
            ('unchanged', b'g\n')],
916
 
            list(plan))
 
907
                          ('unchanged', 'h\n'),
 
908
                          ('unchanged', 'a\n'),
 
909
                          ('conflicted-a', 'x\n'),
 
910
                          ('new-b', 'z\n'),
 
911
                          ('unchanged', 'c\n'),
 
912
                          ('unchanged', 'd\n'),
 
913
                          ('unchanged', 'y\n'),
 
914
                          ('unchanged', 'f\n'),
 
915
                          ('unchanged', 'g\n')],
 
916
                         list(plan))
917
917
 
918
918
    def test_criss_cross_flip_flop(self):
919
919
        # This is specificly trying to trigger problems when using limited
921
921
        #       XX      unused ancestor, should not show up in the weave
922
922
        #       |
923
923
        #       A       Unique LCA
924
 
        #      / \
 
924
        #      / \  
925
925
        #     B   C     B & C both introduce a new line
926
 
        #     |\ /|
927
 
        #     | X |
928
 
        #     |/ \|
 
926
        #     |\ /|  
 
927
        #     | X |  
 
928
        #     |/ \| 
929
929
        #     D   E     B & C are both merged, so both are common ancestors
930
930
        #               In the process of merging, both sides order the new
931
931
        #               lines differently
932
932
        #
933
 
        self.add_rev(b'root', b'XX', [], b'qrs')
934
 
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
935
 
        self.add_rev(b'root', b'B', [b'A'], b'abcdgef')
936
 
        self.add_rev(b'root', b'C', [b'A'], b'abcdhef')
937
 
        self.add_rev(b'root', b'D', [b'B', b'C'], b'abcdghef')
938
 
        self.add_rev(b'root', b'E', [b'C', b'B'], b'abcdhgef')
939
 
        plan = list(self.plan_merge_vf.plan_merge(b'D', b'E'))
 
933
        self.add_rev('root', 'XX', [], 'qrs')
 
934
        self.add_rev('root', 'A', ['XX'], 'abcdef')
 
935
        self.add_rev('root', 'B', ['A'], 'abcdgef')
 
936
        self.add_rev('root', 'C', ['A'], 'abcdhef')
 
937
        self.add_rev('root', 'D', ['B', 'C'], 'abcdghef')
 
938
        self.add_rev('root', 'E', ['C', 'B'], 'abcdhgef')
 
939
        plan = list(self.plan_merge_vf.plan_merge('D', 'E'))
940
940
        self.assertEqual([
941
 
            ('unchanged', b'a\n'),
942
 
            ('unchanged', b'b\n'),
943
 
            ('unchanged', b'c\n'),
944
 
            ('unchanged', b'd\n'),
945
 
            ('new-b', b'h\n'),
946
 
            ('unchanged', b'g\n'),
947
 
            ('killed-b', b'h\n'),
948
 
            ('unchanged', b'e\n'),
949
 
            ('unchanged', b'f\n'),
950
 
            ], plan)
 
941
                          ('unchanged', 'a\n'),
 
942
                          ('unchanged', 'b\n'),
 
943
                          ('unchanged', 'c\n'),
 
944
                          ('unchanged', 'd\n'),
 
945
                          ('new-b', 'h\n'),
 
946
                          ('unchanged', 'g\n'),
 
947
                          ('killed-b', 'h\n'),
 
948
                          ('unchanged', 'e\n'),
 
949
                          ('unchanged', 'f\n'),
 
950
                         ], plan)
951
951
        pwm = versionedfile.PlanWeaveMerge(plan)
952
 
        self.assertEqualDiff(b'a\nb\nc\nd\ng\nh\ne\nf\n',
953
 
                             b''.join(pwm.base_from_plan()))
 
952
        self.assertEqualDiff('\n'.join('abcdghef') + '\n',
 
953
                             ''.join(pwm.base_from_plan()))
954
954
        # Reversing the order reverses the merge plan, and final order of 'hg'
955
955
        # => 'gh'
956
 
        plan = list(self.plan_merge_vf.plan_merge(b'E', b'D'))
 
956
        plan = list(self.plan_merge_vf.plan_merge('E', 'D'))
957
957
        self.assertEqual([
958
 
            ('unchanged', b'a\n'),
959
 
            ('unchanged', b'b\n'),
960
 
            ('unchanged', b'c\n'),
961
 
            ('unchanged', b'd\n'),
962
 
            ('new-b', b'g\n'),
963
 
            ('unchanged', b'h\n'),
964
 
            ('killed-b', b'g\n'),
965
 
            ('unchanged', b'e\n'),
966
 
            ('unchanged', b'f\n'),
967
 
            ], plan)
 
958
                          ('unchanged', 'a\n'),
 
959
                          ('unchanged', 'b\n'),
 
960
                          ('unchanged', 'c\n'),
 
961
                          ('unchanged', 'd\n'),
 
962
                          ('new-b', 'g\n'),
 
963
                          ('unchanged', 'h\n'),
 
964
                          ('killed-b', 'g\n'),
 
965
                          ('unchanged', 'e\n'),
 
966
                          ('unchanged', 'f\n'),
 
967
                         ], plan)
968
968
        pwm = versionedfile.PlanWeaveMerge(plan)
969
 
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ng\ne\nf\n',
970
 
                             b''.join(pwm.base_from_plan()))
 
969
        self.assertEqualDiff('\n'.join('abcdhgef') + '\n',
 
970
                             ''.join(pwm.base_from_plan()))
971
971
        # This is where lca differs, in that it (fairly correctly) determines
972
972
        # that there is a conflict because both sides resolved the merge
973
973
        # differently
974
 
        plan = list(self.plan_merge_vf.plan_lca_merge(b'D', b'E'))
 
974
        plan = list(self.plan_merge_vf.plan_lca_merge('D', 'E'))
975
975
        self.assertEqual([
976
 
            ('unchanged', b'a\n'),
977
 
            ('unchanged', b'b\n'),
978
 
            ('unchanged', b'c\n'),
979
 
            ('unchanged', b'd\n'),
980
 
            ('conflicted-b', b'h\n'),
981
 
            ('unchanged', b'g\n'),
982
 
            ('conflicted-a', b'h\n'),
983
 
            ('unchanged', b'e\n'),
984
 
            ('unchanged', b'f\n'),
985
 
            ], plan)
 
976
                          ('unchanged', 'a\n'),
 
977
                          ('unchanged', 'b\n'),
 
978
                          ('unchanged', 'c\n'),
 
979
                          ('unchanged', 'd\n'),
 
980
                          ('conflicted-b', 'h\n'),
 
981
                          ('unchanged', 'g\n'),
 
982
                          ('conflicted-a', 'h\n'),
 
983
                          ('unchanged', 'e\n'),
 
984
                          ('unchanged', 'f\n'),
 
985
                         ], plan)
986
986
        pwm = versionedfile.PlanWeaveMerge(plan)
987
 
        self.assertEqualDiff(b'a\nb\nc\nd\ng\ne\nf\n',
988
 
                             b''.join(pwm.base_from_plan()))
 
987
        self.assertEqualDiff('\n'.join('abcdgef') + '\n',
 
988
                             ''.join(pwm.base_from_plan()))
989
989
        # Reversing it changes what line is doubled, but still gives a
990
990
        # double-conflict
991
 
        plan = list(self.plan_merge_vf.plan_lca_merge(b'E', b'D'))
 
991
        plan = list(self.plan_merge_vf.plan_lca_merge('E', 'D'))
992
992
        self.assertEqual([
993
 
            ('unchanged', b'a\n'),
994
 
            ('unchanged', b'b\n'),
995
 
            ('unchanged', b'c\n'),
996
 
            ('unchanged', b'd\n'),
997
 
            ('conflicted-b', b'g\n'),
998
 
            ('unchanged', b'h\n'),
999
 
            ('conflicted-a', b'g\n'),
1000
 
            ('unchanged', b'e\n'),
1001
 
            ('unchanged', b'f\n'),
1002
 
            ], plan)
 
993
                          ('unchanged', 'a\n'),
 
994
                          ('unchanged', 'b\n'),
 
995
                          ('unchanged', 'c\n'),
 
996
                          ('unchanged', 'd\n'),
 
997
                          ('conflicted-b', 'g\n'),
 
998
                          ('unchanged', 'h\n'),
 
999
                          ('conflicted-a', 'g\n'),
 
1000
                          ('unchanged', 'e\n'),
 
1001
                          ('unchanged', 'f\n'),
 
1002
                         ], plan)
1003
1003
        pwm = versionedfile.PlanWeaveMerge(plan)
1004
 
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ne\nf\n',
1005
 
                             b''.join(pwm.base_from_plan()))
 
1004
        self.assertEqualDiff('\n'.join('abcdhef') + '\n',
 
1005
                             ''.join(pwm.base_from_plan()))
1006
1006
 
1007
1007
    def assertRemoveExternalReferences(self, filtered_parent_map,
1008
1008
                                       child_map, tails, parent_map):
1023
1023
    def test__remove_external_references(self):
1024
1024
        # First, nothing to remove
1025
1025
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1026
 
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
 
1026
            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
1027
1027
        # The reverse direction
1028
1028
        self.assertRemoveExternalReferences({1: [2], 2: [3], 3: []},
1029
 
                                            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
 
1029
            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
1030
1030
        # Extra references
1031
1031
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1032
 
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
 
1032
            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
1033
1033
        # Multiple tails
1034
1034
        self.assertRemoveExternalReferences(
1035
1035
            {4: [2, 3], 3: [], 2: [1], 1: []},
1045
1045
 
1046
1046
    def assertPruneTails(self, pruned_map, tails, parent_map):
1047
1047
        child_map = {}
1048
 
        for key, parent_keys in parent_map.items():
 
1048
        for key, parent_keys in parent_map.iteritems():
1049
1049
            child_map.setdefault(key, [])
1050
1050
            for pkey in parent_keys:
1051
1051
                child_map.setdefault(pkey, []).append(key)
1066
1066
        self.assertPruneTails({1: []}, [5],
1067
1067
                              {1: [], 2: [3, 4], 3: [5], 4: [5], 5: []})
1068
1068
        # Prune a partial chain
1069
 
        self.assertPruneTails({1: [6], 6: []}, [5],
 
1069
        self.assertPruneTails({1: [6], 6:[]}, [5],
1070
1070
                              {1: [2, 6], 2: [3, 4], 3: [5], 4: [5], 5: [],
1071
1071
                               6: []})
1072
1072
        # Prune a chain with multiple tips, that pulls out intermediates
1073
 
        self.assertPruneTails({1: [3], 3: []}, [4, 5],
1074
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
1075
 
        self.assertPruneTails({1: [3], 3: []}, [5, 4],
1076
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
 
1073
        self.assertPruneTails({1:[3], 3:[]}, [4, 5],
 
1074
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
 
1075
        self.assertPruneTails({1:[3], 3:[]}, [5, 4],
 
1076
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
1077
1077
 
1078
1078
    def test_subtract_plans(self):
1079
1079
        old_plan = [
1080
 
            ('unchanged', b'a\n'),
1081
 
            ('new-a', b'b\n'),
1082
 
            ('killed-a', b'c\n'),
1083
 
            ('new-b', b'd\n'),
1084
 
            ('new-b', b'e\n'),
1085
 
            ('killed-b', b'f\n'),
1086
 
            ('killed-b', b'g\n'),
 
1080
        ('unchanged', 'a\n'),
 
1081
        ('new-a', 'b\n'),
 
1082
        ('killed-a', 'c\n'),
 
1083
        ('new-b', 'd\n'),
 
1084
        ('new-b', 'e\n'),
 
1085
        ('killed-b', 'f\n'),
 
1086
        ('killed-b', 'g\n'),
1087
1087
        ]
1088
1088
        new_plan = [
1089
 
            ('unchanged', b'a\n'),
1090
 
            ('new-a', b'b\n'),
1091
 
            ('killed-a', b'c\n'),
1092
 
            ('new-b', b'd\n'),
1093
 
            ('new-b', b'h\n'),
1094
 
            ('killed-b', b'f\n'),
1095
 
            ('killed-b', b'i\n'),
 
1089
        ('unchanged', 'a\n'),
 
1090
        ('new-a', 'b\n'),
 
1091
        ('killed-a', 'c\n'),
 
1092
        ('new-b', 'd\n'),
 
1093
        ('new-b', 'h\n'),
 
1094
        ('killed-b', 'f\n'),
 
1095
        ('killed-b', 'i\n'),
1096
1096
        ]
1097
1097
        subtracted_plan = [
1098
 
            ('unchanged', b'a\n'),
1099
 
            ('new-a', b'b\n'),
1100
 
            ('killed-a', b'c\n'),
1101
 
            ('new-b', b'h\n'),
1102
 
            ('unchanged', b'f\n'),
1103
 
            ('killed-b', b'i\n'),
 
1098
        ('unchanged', 'a\n'),
 
1099
        ('new-a', 'b\n'),
 
1100
        ('killed-a', 'c\n'),
 
1101
        ('new-b', 'h\n'),
 
1102
        ('unchanged', 'f\n'),
 
1103
        ('killed-b', 'i\n'),
1104
1104
        ]
1105
1105
        self.assertEqual(subtracted_plan,
1106
 
                         list(_PlanMerge._subtract_plans(old_plan, new_plan)))
 
1106
            list(_PlanMerge._subtract_plans(old_plan, new_plan)))
1107
1107
 
1108
1108
    def setup_merge_with_base(self):
1109
 
        self.add_rev(b'root', b'COMMON', [], b'abc')
1110
 
        self.add_rev(b'root', b'THIS', [b'COMMON'], b'abcd')
1111
 
        self.add_rev(b'root', b'BASE', [b'COMMON'], b'eabc')
1112
 
        self.add_rev(b'root', b'OTHER', [b'BASE'], b'eafb')
 
1109
        self.add_rev('root', 'COMMON', [], 'abc')
 
1110
        self.add_rev('root', 'THIS', ['COMMON'], 'abcd')
 
1111
        self.add_rev('root', 'BASE', ['COMMON'], 'eabc')
 
1112
        self.add_rev('root', 'OTHER', ['BASE'], 'eafb')
1113
1113
 
1114
1114
    def test_plan_merge_with_base(self):
1115
1115
        self.setup_merge_with_base()
1116
 
        plan = self.plan_merge_vf.plan_merge(b'THIS', b'OTHER', b'BASE')
1117
 
        self.assertEqual([('unchanged', b'a\n'),
1118
 
                          ('new-b', b'f\n'),
1119
 
                          ('unchanged', b'b\n'),
1120
 
                          ('killed-b', b'c\n'),
1121
 
                          ('new-a', b'd\n')
1122
 
                          ], list(plan))
 
1116
        plan = self.plan_merge_vf.plan_merge('THIS', 'OTHER', 'BASE')
 
1117
        self.assertEqual([('unchanged', 'a\n'),
 
1118
                          ('new-b', 'f\n'),
 
1119
                          ('unchanged', 'b\n'),
 
1120
                          ('killed-b', 'c\n'),
 
1121
                          ('new-a', 'd\n')
 
1122
                         ], list(plan))
1123
1123
 
1124
1124
    def test_plan_lca_merge(self):
1125
1125
        self.setup_plan_merge()
1126
 
        plan = self.plan_merge_vf.plan_lca_merge(b'B', b'C')
 
1126
        plan = self.plan_merge_vf.plan_lca_merge('B', 'C')
1127
1127
        self.assertEqual([
1128
 
            ('new-b', b'f\n'),
1129
 
            ('unchanged', b'a\n'),
1130
 
            ('killed-b', b'c\n'),
1131
 
            ('new-a', b'e\n'),
1132
 
            ('new-a', b'h\n'),
1133
 
            ('killed-a', b'b\n'),
1134
 
            ('unchanged', b'g\n')],
1135
 
            list(plan))
 
1128
                          ('new-b', 'f\n'),
 
1129
                          ('unchanged', 'a\n'),
 
1130
                          ('killed-b', 'c\n'),
 
1131
                          ('new-a', 'e\n'),
 
1132
                          ('new-a', 'h\n'),
 
1133
                          ('killed-a', 'b\n'),
 
1134
                          ('unchanged', 'g\n')],
 
1135
                         list(plan))
1136
1136
 
1137
1137
    def test_plan_lca_merge_uncommitted_files(self):
1138
1138
        self.setup_plan_merge_uncommitted()
1139
 
        plan = self.plan_merge_vf.plan_lca_merge(b'B:', b'C:')
 
1139
        plan = self.plan_merge_vf.plan_lca_merge('B:', 'C:')
1140
1140
        self.assertEqual([
1141
 
            ('new-b', b'f\n'),
1142
 
            ('unchanged', b'a\n'),
1143
 
            ('killed-b', b'c\n'),
1144
 
            ('new-a', b'e\n'),
1145
 
            ('new-a', b'h\n'),
1146
 
            ('killed-a', b'b\n'),
1147
 
            ('unchanged', b'g\n')],
1148
 
            list(plan))
 
1141
                          ('new-b', 'f\n'),
 
1142
                          ('unchanged', 'a\n'),
 
1143
                          ('killed-b', 'c\n'),
 
1144
                          ('new-a', 'e\n'),
 
1145
                          ('new-a', 'h\n'),
 
1146
                          ('killed-a', 'b\n'),
 
1147
                          ('unchanged', 'g\n')],
 
1148
                         list(plan))
1149
1149
 
1150
1150
    def test_plan_lca_merge_with_base(self):
1151
1151
        self.setup_merge_with_base()
1152
 
        plan = self.plan_merge_vf.plan_lca_merge(b'THIS', b'OTHER', b'BASE')
1153
 
        self.assertEqual([('unchanged', b'a\n'),
1154
 
                          ('new-b', b'f\n'),
1155
 
                          ('unchanged', b'b\n'),
1156
 
                          ('killed-b', b'c\n'),
1157
 
                          ('new-a', b'd\n')
1158
 
                          ], list(plan))
 
1152
        plan = self.plan_merge_vf.plan_lca_merge('THIS', 'OTHER', 'BASE')
 
1153
        self.assertEqual([('unchanged', 'a\n'),
 
1154
                          ('new-b', 'f\n'),
 
1155
                          ('unchanged', 'b\n'),
 
1156
                          ('killed-b', 'c\n'),
 
1157
                          ('new-a', 'd\n')
 
1158
                         ], list(plan))
1159
1159
 
1160
1160
    def test_plan_lca_merge_with_criss_cross(self):
1161
 
        self.add_version((b'root', b'ROOT'), [], b'abc')
 
1161
        self.add_version(('root', 'ROOT'), [], 'abc')
1162
1162
        # each side makes a change
1163
 
        self.add_version((b'root', b'REV1'), [(b'root', b'ROOT')], b'abcd')
1164
 
        self.add_version((b'root', b'REV2'), [(b'root', b'ROOT')], b'abce')
 
1163
        self.add_version(('root', 'REV1'), [('root', 'ROOT')], 'abcd')
 
1164
        self.add_version(('root', 'REV2'), [('root', 'ROOT')], 'abce')
1165
1165
        # both sides merge, discarding others' changes
1166
 
        self.add_version((b'root', b'LCA1'),
1167
 
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'abcd')
1168
 
        self.add_version((b'root', b'LCA2'),
1169
 
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'fabce')
1170
 
        plan = self.plan_merge_vf.plan_lca_merge(b'LCA1', b'LCA2')
1171
 
        self.assertEqual([('new-b', b'f\n'),
1172
 
                          ('unchanged', b'a\n'),
1173
 
                          ('unchanged', b'b\n'),
1174
 
                          ('unchanged', b'c\n'),
1175
 
                          ('conflicted-a', b'd\n'),
1176
 
                          ('conflicted-b', b'e\n'),
1177
 
                          ], list(plan))
 
1166
        self.add_version(('root', 'LCA1'),
 
1167
            [('root', 'REV1'), ('root', 'REV2')], 'abcd')
 
1168
        self.add_version(('root', 'LCA2'),
 
1169
            [('root', 'REV1'), ('root', 'REV2')], 'fabce')
 
1170
        plan = self.plan_merge_vf.plan_lca_merge('LCA1', 'LCA2')
 
1171
        self.assertEqual([('new-b', 'f\n'),
 
1172
                          ('unchanged', 'a\n'),
 
1173
                          ('unchanged', 'b\n'),
 
1174
                          ('unchanged', 'c\n'),
 
1175
                          ('conflicted-a', 'd\n'),
 
1176
                          ('conflicted-b', 'e\n'),
 
1177
                         ], list(plan))
1178
1178
 
1179
1179
    def test_plan_lca_merge_with_null(self):
1180
 
        self.add_version((b'root', b'A'), [], b'ab')
1181
 
        self.add_version((b'root', b'B'), [], b'bc')
1182
 
        plan = self.plan_merge_vf.plan_lca_merge(b'A', b'B')
1183
 
        self.assertEqual([('new-a', b'a\n'),
1184
 
                          ('unchanged', b'b\n'),
1185
 
                          ('new-b', b'c\n'),
1186
 
                          ], list(plan))
 
1180
        self.add_version(('root', 'A'), [], 'ab')
 
1181
        self.add_version(('root', 'B'), [], 'bc')
 
1182
        plan = self.plan_merge_vf.plan_lca_merge('A', 'B')
 
1183
        self.assertEqual([('new-a', 'a\n'),
 
1184
                          ('unchanged', 'b\n'),
 
1185
                          ('new-b', 'c\n'),
 
1186
                         ], list(plan))
1187
1187
 
1188
1188
    def test_plan_merge_with_delete_and_change(self):
1189
 
        self.add_rev(b'root', b'C', [], b'a')
1190
 
        self.add_rev(b'root', b'A', [b'C'], b'b')
1191
 
        self.add_rev(b'root', b'B', [b'C'], b'')
1192
 
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
1193
 
        self.assertEqual([('killed-both', b'a\n'),
1194
 
                          ('new-a', b'b\n'),
1195
 
                          ], list(plan))
 
1189
        self.add_rev('root', 'C', [], 'a')
 
1190
        self.add_rev('root', 'A', ['C'], 'b')
 
1191
        self.add_rev('root', 'B', ['C'], '')
 
1192
        plan = self.plan_merge_vf.plan_merge('A', 'B')
 
1193
        self.assertEqual([('killed-both', 'a\n'),
 
1194
                          ('new-a', 'b\n'),
 
1195
                         ], list(plan))
1196
1196
 
1197
1197
    def test_plan_merge_with_move_and_change(self):
1198
 
        self.add_rev(b'root', b'C', [], b'abcd')
1199
 
        self.add_rev(b'root', b'A', [b'C'], b'acbd')
1200
 
        self.add_rev(b'root', b'B', [b'C'], b'aBcd')
1201
 
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
1202
 
        self.assertEqual([('unchanged', b'a\n'),
1203
 
                          ('new-a', b'c\n'),
1204
 
                          ('killed-b', b'b\n'),
1205
 
                          ('new-b', b'B\n'),
1206
 
                          ('killed-a', b'c\n'),
1207
 
                          ('unchanged', b'd\n'),
1208
 
                          ], list(plan))
 
1198
        self.add_rev('root', 'C', [], 'abcd')
 
1199
        self.add_rev('root', 'A', ['C'], 'acbd')
 
1200
        self.add_rev('root', 'B', ['C'], 'aBcd')
 
1201
        plan = self.plan_merge_vf.plan_merge('A', 'B')
 
1202
        self.assertEqual([('unchanged', 'a\n'),
 
1203
                          ('new-a', 'c\n'),
 
1204
                          ('killed-b', 'b\n'),
 
1205
                          ('new-b', 'B\n'),
 
1206
                          ('killed-a', 'c\n'),
 
1207
                          ('unchanged', 'd\n'),
 
1208
                         ], list(plan))
1209
1209
 
1210
1210
 
1211
1211
class LoggingMerger(object):
1241
1241
        #  B C
1242
1242
        #
1243
1243
        builder = self.get_builder()
1244
 
        builder.build_snapshot(None,
1245
 
                               [('add', ('', None, 'directory', None))],
1246
 
                               revision_id=b'A-id')
1247
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1248
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1244
        builder.build_snapshot('A-id', None,
 
1245
            [('add', ('', None, 'directory', None))])
 
1246
        builder.build_snapshot('C-id', ['A-id'], [])
 
1247
        builder.build_snapshot('B-id', ['A-id'], [])
1249
1248
        return builder
1250
1249
 
1251
1250
    def setup_criss_cross_graph(self):
1259
1258
        # |X|
1260
1259
        # D E
1261
1260
        builder = self.setup_simple_graph()
1262
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1263
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1261
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1262
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1264
1263
        return builder
1265
1264
 
1266
 
    def make_Merger(self, builder, other_revision_id, interesting_files=None):
 
1265
    def make_Merger(self, builder, other_revision_id,
 
1266
                    interesting_files=None, interesting_ids=None):
1267
1267
        """Make a Merger object from a branch builder"""
1268
1268
        mem_tree = memorytree.MemoryTree.create_on_branch(builder.get_branch())
1269
1269
        mem_tree.lock_write()
1270
1270
        self.addCleanup(mem_tree.unlock)
1271
 
        merger = _mod_merge.Merger.from_revision_ids(
 
1271
        merger = _mod_merge.Merger.from_revision_ids(None,
1272
1272
            mem_tree, other_revision_id)
1273
1273
        merger.set_interesting_files(interesting_files)
 
1274
        # It seems there is no matching function for set_interesting_ids
 
1275
        merger.interesting_ids = interesting_ids
1274
1276
        merger.merge_type = _mod_merge.Merge3Merger
1275
1277
        return merger
1276
1278
 
1278
1280
class TestMergerInMemory(TestMergerBase):
1279
1281
 
1280
1282
    def test_cache_trees_with_revision_ids_None(self):
1281
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1283
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1282
1284
        original_cache = dict(merger._cached_trees)
1283
1285
        merger.cache_trees_with_revision_ids([None])
1284
1286
        self.assertEqual(original_cache, merger._cached_trees)
1285
1287
 
1286
1288
    def test_cache_trees_with_revision_ids_no_revision_id(self):
1287
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1289
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1288
1290
        original_cache = dict(merger._cached_trees)
1289
1291
        tree = self.make_branch_and_memory_tree('tree')
1290
1292
        merger.cache_trees_with_revision_ids([tree])
1291
1293
        self.assertEqual(original_cache, merger._cached_trees)
1292
1294
 
1293
1295
    def test_cache_trees_with_revision_ids_having_revision_id(self):
1294
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1296
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1295
1297
        original_cache = dict(merger._cached_trees)
1296
 
        tree = merger.this_branch.repository.revision_tree(b'B-id')
1297
 
        original_cache[b'B-id'] = tree
 
1298
        tree = merger.this_branch.repository.revision_tree('B-id')
 
1299
        original_cache['B-id'] = tree
1298
1300
        merger.cache_trees_with_revision_ids([tree])
1299
1301
        self.assertEqual(original_cache, merger._cached_trees)
1300
1302
 
1301
1303
    def test_find_base(self):
1302
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1303
 
        self.assertEqual(b'A-id', merger.base_rev_id)
 
1304
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1305
        self.assertEqual('A-id', merger.base_rev_id)
1304
1306
        self.assertFalse(merger._is_criss_cross)
1305
1307
        self.assertIs(None, merger._lca_trees)
1306
1308
 
1307
1309
    def test_find_base_criss_cross(self):
1308
1310
        builder = self.setup_criss_cross_graph()
1309
 
        merger = self.make_Merger(builder, b'E-id')
1310
 
        self.assertEqual(b'A-id', merger.base_rev_id)
 
1311
        merger = self.make_Merger(builder, 'E-id')
 
1312
        self.assertEqual('A-id', merger.base_rev_id)
1311
1313
        self.assertTrue(merger._is_criss_cross)
1312
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1313
 
                                              for t in merger._lca_trees])
 
1314
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1315
                                            for t in merger._lca_trees])
1314
1316
        # If we swap the order, we should get a different lca order
1315
 
        builder.build_snapshot([b'E-id'], [], revision_id=b'F-id')
1316
 
        merger = self.make_Merger(builder, b'D-id')
1317
 
        self.assertEqual([b'C-id', b'B-id'], [t.get_revision_id()
1318
 
                                              for t in merger._lca_trees])
 
1317
        builder.build_snapshot('F-id', ['E-id'], [])
 
1318
        merger = self.make_Merger(builder, 'D-id')
 
1319
        self.assertEqual(['C-id', 'B-id'], [t.get_revision_id()
 
1320
                                            for t in merger._lca_trees])
1319
1321
 
1320
1322
    def test_find_base_triple_criss_cross(self):
1321
1323
        #       A-.
1328
1330
        #    \|   |/
1329
1331
        #     G   H
1330
1332
        builder = self.setup_criss_cross_graph()
1331
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'F-id')
1332
 
        builder.build_snapshot([b'E-id', b'F-id'], [], revision_id=b'H-id')
1333
 
        builder.build_snapshot([b'D-id', b'F-id'], [], revision_id=b'G-id')
1334
 
        merger = self.make_Merger(builder, b'H-id')
1335
 
        self.assertEqual([b'B-id', b'C-id', b'F-id'],
 
1333
        builder.build_snapshot('F-id', ['A-id'], [])
 
1334
        builder.build_snapshot('H-id', ['E-id', 'F-id'], [])
 
1335
        builder.build_snapshot('G-id', ['D-id', 'F-id'], [])
 
1336
        merger = self.make_Merger(builder, 'H-id')
 
1337
        self.assertEqual(['B-id', 'C-id', 'F-id'],
1336
1338
                         [t.get_revision_id() for t in merger._lca_trees])
1337
1339
 
1338
1340
    def test_find_base_new_root_criss_cross(self):
1341
1343
        # | X |
1342
1344
        # |/ \|
1343
1345
        # C   D
 
1346
        
1344
1347
        builder = self.get_builder()
1345
 
        builder.build_snapshot(None,
1346
 
                               [('add', ('', None, 'directory', None))],
1347
 
                               revision_id=b'A-id')
1348
 
        builder.build_snapshot([],
1349
 
                               [('add', ('', None, 'directory', None))],
1350
 
                               revision_id=b'B-id')
1351
 
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'D-id')
1352
 
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'C-id')
1353
 
        merger = self.make_Merger(builder, b'D-id')
1354
 
        self.assertEqual(b'A-id', merger.base_rev_id)
 
1348
        builder.build_snapshot('A-id', None,
 
1349
            [('add', ('', None, 'directory', None))])
 
1350
        builder.build_snapshot('B-id', [],
 
1351
            [('add', ('', None, 'directory', None))])
 
1352
        builder.build_snapshot('D-id', ['A-id', 'B-id'], [])
 
1353
        builder.build_snapshot('C-id', ['A-id', 'B-id'], [])
 
1354
        merger = self.make_Merger(builder, 'D-id')
 
1355
        self.assertEqual('A-id', merger.base_rev_id)
1355
1356
        self.assertTrue(merger._is_criss_cross)
1356
 
        self.assertEqual([b'A-id', b'B-id'], [t.get_revision_id()
1357
 
                                              for t in merger._lca_trees])
 
1357
        self.assertEqual(['A-id', 'B-id'], [t.get_revision_id()
 
1358
                                            for t in merger._lca_trees])
1358
1359
 
1359
1360
    def test_no_criss_cross_passed_to_merge_type(self):
1360
1361
        class LCATreesMerger(LoggingMerger):
1361
1362
            supports_lca_trees = True
1362
1363
 
1363
 
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1364
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1364
1365
        merger.merge_type = LCATreesMerger
1365
1366
        merge_obj = merger.make_merger()
1366
1367
        self.assertIsInstance(merge_obj, LCATreesMerger)
1367
1368
        self.assertFalse('lca_trees' in merge_obj.kwargs)
1368
1369
 
1369
1370
    def test_criss_cross_passed_to_merge_type(self):
1370
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1371
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1371
1372
        merger.merge_type = _mod_merge.Merge3Merger
1372
1373
        merge_obj = merger.make_merger()
1373
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1374
 
                                              for t in merger._lca_trees])
 
1374
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1375
                                            for t in merger._lca_trees])
1375
1376
 
1376
1377
    def test_criss_cross_not_supported_merge_type(self):
1377
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1378
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1378
1379
        # We explicitly do not define supports_lca_trees
1379
1380
        merger.merge_type = LoggingMerger
1380
1381
        merge_obj = merger.make_merger()
1385
1386
        class UnsupportedLCATreesMerger(LoggingMerger):
1386
1387
            supports_lca_trees = False
1387
1388
 
1388
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
 
1389
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
1389
1390
        merger.merge_type = UnsupportedLCATreesMerger
1390
1391
        merge_obj = merger.make_merger()
1391
1392
        self.assertIsInstance(merge_obj, UnsupportedLCATreesMerger)
1395
1396
class TestMergerEntriesLCA(TestMergerBase):
1396
1397
 
1397
1398
    def make_merge_obj(self, builder, other_revision_id,
1398
 
                       interesting_files=None):
 
1399
                       interesting_files=None, interesting_ids=None):
1399
1400
        merger = self.make_Merger(builder, other_revision_id,
1400
 
                                  interesting_files=interesting_files)
 
1401
            interesting_files=interesting_files,
 
1402
            interesting_ids=interesting_ids)
1401
1403
        return merger.make_merger()
1402
1404
 
1403
1405
    def test_simple(self):
1404
1406
        builder = self.get_builder()
1405
 
        builder.build_snapshot(None,
1406
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1407
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1408
 
                               revision_id=b'A-id')
1409
 
        builder.build_snapshot([b'A-id'],
1410
 
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
1411
 
                               revision_id=b'C-id')
1412
 
        builder.build_snapshot([b'A-id'],
1413
 
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
1414
 
                               revision_id=b'B-id')
1415
 
        builder.build_snapshot([b'C-id', b'B-id'],
1416
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
1417
 
                               revision_id=b'E-id')
1418
 
        builder.build_snapshot([b'B-id', b'C-id'],
1419
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\n'))],
1420
 
                               revision_id=b'D-id', )
1421
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1407
        builder.build_snapshot('A-id', None,
 
1408
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1409
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1410
        builder.build_snapshot('C-id', ['A-id'],
 
1411
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
 
1412
        builder.build_snapshot('B-id', ['A-id'],
 
1413
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
 
1414
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1415
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
 
1416
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1417
            [('modify', ('a-id', 'a\nB\nb\nC\nc\n'))])
 
1418
        merge_obj = self.make_merge_obj(builder, 'E-id')
1422
1419
 
1423
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1424
 
                                              for t in merge_obj._lca_trees])
1425
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1420
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1421
                                            for t in merge_obj._lca_trees])
 
1422
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1426
1423
        entries = list(merge_obj._entries_lca())
1427
1424
 
1428
1425
        # (file_id, changed, parents, names, executable)
1429
1426
        # BASE, lca1, lca2, OTHER, THIS
1430
 
        root_id = b'a-root-id'
1431
 
        self.assertEqual([(b'a-id', True,
1432
 
                           ((u'a', [u'a', u'a']), u'a', u'a'),
 
1427
        root_id = 'a-root-id'
 
1428
        self.assertEqual([('a-id', True,
1433
1429
                           ((root_id, [root_id, root_id]), root_id, root_id),
1434
1430
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1435
1431
                           ((False, [False, False]), False, False)),
1436
 
                          ], entries)
 
1432
                         ], entries)
1437
1433
 
1438
1434
    def test_not_in_base(self):
1439
1435
        # LCAs all have the same last-modified revision for the file, as do
1448
1444
        #            G modifies 'bar'
1449
1445
 
1450
1446
        builder = self.get_builder()
1451
 
        builder.build_snapshot(None,
1452
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1453
 
                               revision_id=b'A-id')
1454
 
        builder.build_snapshot([b'A-id'],
1455
 
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
1456
 
                               revision_id=b'B-id')
1457
 
        builder.build_snapshot([b'A-id'],
1458
 
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
1459
 
                               revision_id=b'C-id')
1460
 
        builder.build_snapshot([b'B-id', b'C-id'],
1461
 
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
1462
 
                               revision_id=b'D-id')
1463
 
        builder.build_snapshot([b'C-id', b'B-id'],
1464
 
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
1465
 
                               revision_id=b'E-id')
1466
 
        builder.build_snapshot([b'E-id', b'D-id'],
1467
 
                               [('modify', (u'bar', b'd\ne\nf\nG\n'))],
1468
 
                               revision_id=b'G-id')
1469
 
        builder.build_snapshot([b'D-id', b'E-id'], [], revision_id=b'F-id')
1470
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1447
        builder.build_snapshot('A-id', None,
 
1448
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1449
        builder.build_snapshot('B-id', ['A-id'],
 
1450
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
1451
        builder.build_snapshot('C-id', ['A-id'],
 
1452
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
 
1453
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1454
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
 
1455
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1456
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
1457
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1458
            [('modify', (u'bar-id', 'd\ne\nf\nG\n'))])
 
1459
        builder.build_snapshot('F-id', ['D-id', 'E-id'], [])
 
1460
        merge_obj = self.make_merge_obj(builder, 'G-id')
1471
1461
 
1472
 
        self.assertEqual([b'D-id', b'E-id'], [t.get_revision_id()
1473
 
                                              for t in merge_obj._lca_trees])
1474
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1462
        self.assertEqual(['D-id', 'E-id'], [t.get_revision_id()
 
1463
                                            for t in merge_obj._lca_trees])
 
1464
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1475
1465
        entries = list(merge_obj._entries_lca())
1476
 
        root_id = b'a-root-id'
1477
 
        self.assertEqual([(b'bar-id', True,
1478
 
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
 
1466
        root_id = 'a-root-id'
 
1467
        self.assertEqual([('bar-id', True,
1479
1468
                           ((None, [root_id, root_id]), root_id, root_id),
1480
1469
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
1481
1470
                           ((None, [False, False]), False, False)),
1482
 
                          ], entries)
 
1471
                         ], entries)
1483
1472
 
1484
1473
    def test_not_in_this(self):
1485
1474
        builder = self.get_builder()
1486
 
        builder.build_snapshot(None,
1487
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1488
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1489
 
                               revision_id=b'A-id')
1490
 
        builder.build_snapshot([b'A-id'],
1491
 
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
1492
 
                               revision_id=b'B-id')
1493
 
        builder.build_snapshot([b'A-id'],
1494
 
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
1495
 
                               revision_id=b'C-id')
1496
 
        builder.build_snapshot([b'C-id', b'B-id'],
1497
 
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
1498
 
                               revision_id=b'E-id')
1499
 
        builder.build_snapshot([b'B-id', b'C-id'],
1500
 
                               [('unversion', 'a')],
1501
 
                               revision_id=b'D-id')
1502
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1475
        builder.build_snapshot('A-id', None,
 
1476
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1477
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1478
        builder.build_snapshot('B-id', ['A-id'],
 
1479
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
 
1480
        builder.build_snapshot('C-id', ['A-id'],
 
1481
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
 
1482
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1483
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
 
1484
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1485
            [('unversion', 'a-id')])
 
1486
        merge_obj = self.make_merge_obj(builder, 'E-id')
1503
1487
 
1504
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1505
 
                                              for t in merge_obj._lca_trees])
1506
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1488
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1489
                                            for t in merge_obj._lca_trees])
 
1490
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1507
1491
 
1508
1492
        entries = list(merge_obj._entries_lca())
1509
 
        root_id = b'a-root-id'
1510
 
        self.assertEqual([(b'a-id', True,
1511
 
                           ((u'a', [u'a', u'a']), u'a', None),
 
1493
        root_id = 'a-root-id'
 
1494
        self.assertEqual([('a-id', True,
1512
1495
                           ((root_id, [root_id, root_id]), root_id, None),
1513
1496
                           ((u'a', [u'a', u'a']), u'a', None),
1514
1497
                           ((False, [False, False]), False, None)),
1515
 
                          ], entries)
 
1498
                         ], entries)
1516
1499
 
1517
1500
    def test_file_not_in_one_lca(self):
1518
1501
        #   A   # just root
1521
1504
        #   |X|
1522
1505
        #   D E # D and E both have the file, unchanged from C
1523
1506
        builder = self.get_builder()
1524
 
        builder.build_snapshot(None,
1525
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1526
 
                               revision_id=b'A-id')
1527
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1528
 
        builder.build_snapshot([b'A-id'],
1529
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1530
 
                               revision_id=b'C-id')
1531
 
        builder.build_snapshot([b'C-id', b'B-id'],
1532
 
                               [], revision_id=b'E-id')  # Inherited from C
1533
 
        builder.build_snapshot([b'B-id', b'C-id'],  # Merged from C
1534
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1535
 
                               revision_id=b'D-id')
1536
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1507
        builder.build_snapshot('A-id', None,
 
1508
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1509
        builder.build_snapshot('B-id', ['A-id'], [])
 
1510
        builder.build_snapshot('C-id', ['A-id'],
 
1511
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1512
        builder.build_snapshot('E-id', ['C-id', 'B-id'], []) # Inherited from C
 
1513
        builder.build_snapshot('D-id', ['B-id', 'C-id'], # Merged from C
 
1514
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1515
        merge_obj = self.make_merge_obj(builder, 'E-id')
1537
1516
 
1538
 
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
1539
 
                                              for t in merge_obj._lca_trees])
1540
 
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
 
1517
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
 
1518
                                            for t in merge_obj._lca_trees])
 
1519
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
1541
1520
 
1542
1521
        entries = list(merge_obj._entries_lca())
1543
1522
        self.assertEqual([], entries)
1544
1523
 
1545
1524
    def test_not_in_other(self):
1546
1525
        builder = self.get_builder()
1547
 
        builder.build_snapshot(None,
1548
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1549
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1550
 
                               revision_id=b'A-id')
1551
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1552
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1553
 
        builder.build_snapshot(
1554
 
            [b'C-id', b'B-id'],
1555
 
            [('unversion', 'a')], revision_id=b'E-id')
1556
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1557
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1526
        builder.build_snapshot('A-id', None,
 
1527
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1528
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1529
        builder.build_snapshot('B-id', ['A-id'], [])
 
1530
        builder.build_snapshot('C-id', ['A-id'], [])
 
1531
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1532
            [('unversion', 'a-id')])
 
1533
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1534
        merge_obj = self.make_merge_obj(builder, 'E-id')
1558
1535
 
1559
1536
        entries = list(merge_obj._entries_lca())
1560
 
        root_id = b'a-root-id'
1561
 
        self.assertEqual([(b'a-id', True,
1562
 
                           ((u'a', [u'a', u'a']), None, u'a'),
 
1537
        root_id = 'a-root-id'
 
1538
        self.assertEqual([('a-id', True,
1563
1539
                           ((root_id, [root_id, root_id]), None, root_id),
1564
1540
                           ((u'a', [u'a', u'a']), None, u'a'),
1565
1541
                           ((False, [False, False]), None, False)),
1566
 
                          ], entries)
 
1542
                         ], entries)
1567
1543
 
1568
1544
    def test_not_in_other_or_lca(self):
1569
1545
        #       A    base, introduces 'foo'
1578
1554
        #   C => E, no changes
1579
1555
        # D would then win 'cleanly' and no record would be given
1580
1556
        builder = self.get_builder()
1581
 
        builder.build_snapshot(None,
1582
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1583
 
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
1584
 
                               revision_id=b'A-id')
1585
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1586
 
        builder.build_snapshot([b'A-id'],
1587
 
                               [('unversion', 'foo')], revision_id=b'C-id')
1588
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1589
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1590
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1557
        builder.build_snapshot('A-id', None,
 
1558
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1559
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
 
1560
        builder.build_snapshot('B-id', ['A-id'], [])
 
1561
        builder.build_snapshot('C-id', ['A-id'],
 
1562
            [('unversion', 'foo-id')])
 
1563
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1564
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1565
        merge_obj = self.make_merge_obj(builder, 'E-id')
1591
1566
 
1592
1567
        entries = list(merge_obj._entries_lca())
1593
1568
        self.assertEqual([], entries)
1608
1583
        # In this case, we have a conflict of how the changes were resolved. E
1609
1584
        # picked C and D picked B, so we should issue a conflict
1610
1585
        builder = self.get_builder()
1611
 
        builder.build_snapshot(None,
1612
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1613
 
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
1614
 
                               revision_id=b'A-id')
1615
 
        builder.build_snapshot([b'A-id'], [
1616
 
            ('modify', ('foo', b'new-content\n'))],
1617
 
            revision_id=b'B-id')
1618
 
        builder.build_snapshot([b'A-id'],
1619
 
                               [('unversion', 'foo')],
1620
 
                               revision_id=b'C-id')
1621
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1622
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1623
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1586
        builder.build_snapshot('A-id', None,
 
1587
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1588
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
 
1589
        builder.build_snapshot('B-id', ['A-id'], [
 
1590
            ('modify', ('foo-id', 'new-content\n'))])
 
1591
        builder.build_snapshot('C-id', ['A-id'],
 
1592
            [('unversion', 'foo-id')])
 
1593
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1594
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1595
        merge_obj = self.make_merge_obj(builder, 'E-id')
1624
1596
 
1625
1597
        entries = list(merge_obj._entries_lca())
1626
 
        root_id = b'a-root-id'
1627
 
        self.assertEqual([(b'foo-id', True,
1628
 
                           ((u'foo', [u'foo', None]), None, u'foo'),
 
1598
        root_id = 'a-root-id'
 
1599
        self.assertEqual([('foo-id', True,
1629
1600
                           ((root_id, [root_id, None]), None, root_id),
1630
1601
                           ((u'foo', [u'foo', None]), None, 'foo'),
1631
1602
                           ((False, [False, None]), None, False)),
1632
 
                          ], entries)
 
1603
                         ], entries)
1633
1604
 
1634
1605
    def test_only_in_one_lca(self):
1635
1606
        #   A   add only root
1648
1619
        #   A => C, add file, thus C supersedes B
1649
1620
        #   w/ C=BASE, D=THIS, E=OTHER we have 'happy convergence'
1650
1621
        builder = self.get_builder()
1651
 
        builder.build_snapshot(None,
1652
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1653
 
                               revision_id=b'A-id')
1654
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1655
 
        builder.build_snapshot([b'A-id'],
1656
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1657
 
                               revision_id=b'C-id')
1658
 
        builder.build_snapshot([b'C-id', b'B-id'],
1659
 
                               [('unversion', 'a')],
1660
 
                               revision_id=b'E-id')
1661
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1662
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1622
        builder.build_snapshot('A-id', None,
 
1623
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1624
        builder.build_snapshot('B-id', ['A-id'], [])
 
1625
        builder.build_snapshot('C-id', ['A-id'],
 
1626
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1627
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1628
            [('unversion', 'a-id')])
 
1629
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1630
        merge_obj = self.make_merge_obj(builder, 'E-id')
1663
1631
 
1664
1632
        entries = list(merge_obj._entries_lca())
1665
1633
        self.assertEqual([], entries)
1666
1634
 
1667
1635
    def test_only_in_other(self):
1668
1636
        builder = self.get_builder()
1669
 
        builder.build_snapshot(None,
1670
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
1671
 
                               revision_id=b'A-id')
1672
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1673
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1674
 
        builder.build_snapshot([b'C-id', b'B-id'],
1675
 
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
1676
 
                               revision_id=b'E-id')
1677
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1678
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1637
        builder.build_snapshot('A-id', None,
 
1638
            [('add', (u'', 'a-root-id', 'directory', None))])
 
1639
        builder.build_snapshot('B-id', ['A-id'], [])
 
1640
        builder.build_snapshot('C-id', ['A-id'], [])
 
1641
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1642
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
1643
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1644
        merge_obj = self.make_merge_obj(builder, 'E-id')
1679
1645
 
1680
1646
        entries = list(merge_obj._entries_lca())
1681
 
        root_id = b'a-root-id'
1682
 
        self.assertEqual([(b'a-id', True,
1683
 
                           ((None, [None, None]), u'a', None),
 
1647
        root_id = 'a-root-id'
 
1648
        self.assertEqual([('a-id', True,
1684
1649
                           ((None, [None, None]), root_id, None),
1685
1650
                           ((None, [None, None]), u'a', None),
1686
1651
                           ((None, [None, None]), False, None)),
1687
 
                          ], entries)
 
1652
                         ], entries)
1688
1653
 
1689
1654
    def test_one_lca_supersedes(self):
1690
1655
        # One LCA supersedes the other LCAs last modified value, but the
1701
1666
        #   though its LCAs disagree. This is because the modification in E
1702
1667
        #   completely supersedes the value in D.
1703
1668
        builder = self.get_builder()
1704
 
        builder.build_snapshot(None,
1705
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1706
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1707
 
                               revision_id=b'A-id')
1708
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1709
 
        builder.build_snapshot([b'A-id'],
1710
 
                               [('modify', ('foo', b'B content\n'))],
1711
 
                               revision_id=b'B-id')
1712
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1713
 
        builder.build_snapshot([b'C-id', b'B-id'],
1714
 
                               [('modify', ('foo', b'E content\n'))],
1715
 
                               revision_id=b'E-id')
1716
 
        builder.build_snapshot([b'E-id', b'D-id'], [], revision_id=b'G-id')
1717
 
        builder.build_snapshot([b'D-id', b'E-id'],
1718
 
                               [('modify', ('foo', b'F content\n'))],
1719
 
                               revision_id=b'F-id')
1720
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1669
        builder.build_snapshot('A-id', None,
 
1670
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1671
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1672
        builder.build_snapshot('C-id', ['A-id'], [])
 
1673
        builder.build_snapshot('B-id', ['A-id'],
 
1674
            [('modify', ('foo-id', 'B content\n'))])
 
1675
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1676
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1677
            [('modify', ('foo-id', 'E content\n'))])
 
1678
        builder.build_snapshot('G-id', ['E-id', 'D-id'], [])
 
1679
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1680
            [('modify', ('foo-id', 'F content\n'))])
 
1681
        merge_obj = self.make_merge_obj(builder, 'G-id')
1721
1682
 
1722
1683
        self.assertEqual([], list(merge_obj._entries_lca()))
1723
1684
 
1751
1712
        # aren't supporting it yet.
1752
1713
        #
1753
1714
        builder = self.get_builder()
1754
 
        builder.build_snapshot(None,
1755
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1756
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1757
 
                               revision_id=b'A-id')
1758
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1759
 
        builder.build_snapshot([b'A-id'],
1760
 
                               [('rename', ('foo', 'bar'))],
1761
 
                               revision_id=b'B-id')
1762
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1763
 
        builder.build_snapshot([b'C-id', b'B-id'],
1764
 
                               [('rename', ('foo', 'bing'))],
1765
 
                               revision_id=b'E-id')  # override to bing
1766
 
        builder.build_snapshot([b'E-id', b'D-id'],
1767
 
                               [('rename', ('bing', 'barry'))],
1768
 
                               revision_id=b'G-id')  # override to barry
1769
 
        builder.build_snapshot([b'D-id', b'E-id'],
1770
 
                               [('rename', ('bar', 'bing'))],
1771
 
                               revision_id=b'F-id')  # Merge in E's change
1772
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1715
        builder.build_snapshot('A-id', None,
 
1716
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1717
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1718
        builder.build_snapshot('C-id', ['A-id'], [])
 
1719
        builder.build_snapshot('B-id', ['A-id'],
 
1720
            [('rename', ('foo', 'bar'))])
 
1721
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1722
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1723
            [('rename', ('foo', 'bing'))]) # override to bing
 
1724
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1725
            [('rename', ('bing', 'barry'))]) # override to barry
 
1726
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1727
            [('rename', ('bar', 'bing'))]) # Merge in E's change
 
1728
        merge_obj = self.make_merge_obj(builder, 'G-id')
1773
1729
 
1774
1730
        self.expectFailure("We don't do an actual heads() check on lca values,"
1775
 
                           " or use the per-attribute graph",
1776
 
                           self.assertEqual, [], list(merge_obj._entries_lca()))
 
1731
            " or use the per-attribute graph",
 
1732
            self.assertEqual, [], list(merge_obj._entries_lca()))
1777
1733
 
1778
1734
    def test_one_lca_accidentally_pruned(self):
1779
1735
        # Another incorrect resolution from the same basic flaw:
1789
1745
        # be pruned from the LCAs, even though it was newly introduced by E
1790
1746
        # (superseding B).
1791
1747
        builder = self.get_builder()
1792
 
        builder.build_snapshot(None,
1793
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1794
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1795
 
                               revision_id=b'A-id')
1796
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1797
 
        builder.build_snapshot([b'A-id'],
1798
 
                               [('rename', ('foo', 'bar'))],
1799
 
                               revision_id=b'B-id')
1800
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1801
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1802
 
        builder.build_snapshot([b'E-id', b'D-id'],
1803
 
                               [('rename', ('foo', 'bar'))],
1804
 
                               revision_id=b'G-id')
1805
 
        builder.build_snapshot([b'D-id', b'E-id'],
1806
 
                               [('rename', ('bar', 'bing'))],
1807
 
                               revision_id=b'F-id')  # should end up conflicting
1808
 
        merge_obj = self.make_merge_obj(builder, b'G-id')
 
1748
        builder.build_snapshot('A-id', None,
 
1749
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1750
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1751
        builder.build_snapshot('C-id', ['A-id'], [])
 
1752
        builder.build_snapshot('B-id', ['A-id'],
 
1753
            [('rename', ('foo', 'bar'))])
 
1754
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1755
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1756
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
 
1757
            [('rename', ('foo', 'bar'))])
 
1758
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
 
1759
            [('rename', ('bar', 'bing'))]) # should end up conflicting
 
1760
        merge_obj = self.make_merge_obj(builder, 'G-id')
1809
1761
 
1810
1762
        entries = list(merge_obj._entries_lca())
1811
 
        root_id = b'a-root-id'
 
1763
        root_id = 'a-root-id'
1812
1764
        self.expectFailure("We prune values from BASE even when relevant.",
1813
 
                           self.assertEqual,
1814
 
                           [(b'foo-id', False,
1815
 
                             ((root_id, [root_id, root_id]), root_id, root_id),
1816
 
                               ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
1817
 
                               ((False, [False, False]), False, False)),
1818
 
                            ], entries)
 
1765
            self.assertEqual,
 
1766
                [('foo-id', False,
 
1767
                  ((root_id, [root_id, root_id]), root_id, root_id),
 
1768
                  ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
 
1769
                  ((False, [False, False]), False, False)),
 
1770
                ], entries)
1819
1771
 
1820
1772
    def test_both_sides_revert(self):
1821
1773
        # Both sides of a criss-cross revert the text to the lca
1826
1778
        #       D E  D reverts to B, E reverts to C
1827
1779
        # This should conflict
1828
1780
        builder = self.get_builder()
1829
 
        builder.build_snapshot(None,
1830
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1831
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1832
 
                               revision_id=b'A-id')
1833
 
        builder.build_snapshot([b'A-id'],
1834
 
                               [('modify', ('foo', b'B content\n'))],
1835
 
                               revision_id=b'B-id')
1836
 
        builder.build_snapshot([b'A-id'],
1837
 
                               [('modify', ('foo', b'C content\n'))],
1838
 
                               revision_id=b'C-id')
1839
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1840
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1841
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1781
        builder.build_snapshot('A-id', None,
 
1782
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1783
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1784
        builder.build_snapshot('B-id', ['A-id'],
 
1785
            [('modify', ('foo-id', 'B content\n'))])
 
1786
        builder.build_snapshot('C-id', ['A-id'],
 
1787
            [('modify', ('foo-id', 'C content\n'))])
 
1788
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1789
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1790
        merge_obj = self.make_merge_obj(builder, 'E-id')
1842
1791
 
1843
1792
        entries = list(merge_obj._entries_lca())
1844
 
        root_id = b'a-root-id'
1845
 
        self.assertEqual([(b'foo-id', True,
1846
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
1793
        root_id = 'a-root-id'
 
1794
        self.assertEqual([('foo-id', True,
1847
1795
                           ((root_id, [root_id, root_id]), root_id, root_id),
1848
1796
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1849
1797
                           ((False, [False, False]), False, False)),
1850
 
                          ], entries)
 
1798
                         ], entries)
1851
1799
 
1852
1800
    def test_different_lca_resolve_one_side_updates_content(self):
1853
1801
        # Both sides converge, but then one side updates the text.
1861
1809
        # We need to emit an entry for 'foo', because D & E differed on the
1862
1810
        # merge resolution
1863
1811
        builder = self.get_builder()
1864
 
        builder.build_snapshot(None,
1865
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1866
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1867
 
                               revision_id=b'A-id')
1868
 
        builder.build_snapshot([b'A-id'],
1869
 
                               [('modify', ('foo', b'B content\n'))],
1870
 
                               revision_id=b'B-id')
1871
 
        builder.build_snapshot([b'A-id'],
1872
 
                               [('modify', ('foo', b'C content\n'))],
1873
 
                               revision_id=b'C-id', )
1874
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1875
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1876
 
        builder.build_snapshot([b'D-id'],
1877
 
                               [('modify', ('foo', b'F content\n'))],
1878
 
                               revision_id=b'F-id')
1879
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1812
        builder.build_snapshot('A-id', None,
 
1813
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1814
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1815
        builder.build_snapshot('B-id', ['A-id'],
 
1816
            [('modify', ('foo-id', 'B content\n'))])
 
1817
        builder.build_snapshot('C-id', ['A-id'],
 
1818
            [('modify', ('foo-id', 'C content\n'))])
 
1819
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1820
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1821
        builder.build_snapshot('F-id', ['D-id'],
 
1822
            [('modify', ('foo-id', 'F content\n'))])
 
1823
        merge_obj = self.make_merge_obj(builder, 'E-id')
1880
1824
 
1881
1825
        entries = list(merge_obj._entries_lca())
1882
 
        root_id = b'a-root-id'
1883
 
        self.assertEqual([(b'foo-id', True,
1884
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
1826
        root_id = 'a-root-id'
 
1827
        self.assertEqual([('foo-id', True,
1885
1828
                           ((root_id, [root_id, root_id]), root_id, root_id),
1886
1829
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1887
1830
                           ((False, [False, False]), False, False)),
1888
 
                          ], entries)
 
1831
                         ], entries)
1889
1832
 
1890
1833
    def test_same_lca_resolution_one_side_updates_content(self):
1891
1834
        # Both sides converge, but then one side updates the text.
1902
1845
        # We need to conflict.
1903
1846
 
1904
1847
        builder = self.get_builder()
1905
 
        builder.build_snapshot(None,
1906
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1907
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
1908
 
                               revision_id=b'A-id')
1909
 
        builder.build_snapshot([b'A-id'],
1910
 
                               [('modify', ('foo', b'B content\n'))],
1911
 
                               revision_id=b'B-id')
1912
 
        builder.build_snapshot([b'A-id'],
1913
 
                               [('modify', ('foo', b'C content\n'))],
1914
 
                               revision_id=b'C-id')
1915
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1916
 
        builder.build_snapshot([b'B-id', b'C-id'],
1917
 
                               [('modify', ('foo', b'C content\n'))],
1918
 
                               revision_id=b'D-id')  # Same as E
1919
 
        builder.build_snapshot([b'D-id'],
1920
 
                               [('modify', ('foo', b'F content\n'))],
1921
 
                               revision_id=b'F-id')
1922
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1848
        builder.build_snapshot('A-id', None,
 
1849
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1850
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
1851
        builder.build_snapshot('B-id', ['A-id'],
 
1852
            [('modify', ('foo-id', 'B content\n'))])
 
1853
        builder.build_snapshot('C-id', ['A-id'],
 
1854
            [('modify', ('foo-id', 'C content\n'))])
 
1855
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1856
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1857
            [('modify', ('foo-id', 'C content\n'))]) # Same as E
 
1858
        builder.build_snapshot('F-id', ['D-id'],
 
1859
            [('modify', ('foo-id', 'F content\n'))])
 
1860
        merge_obj = self.make_merge_obj(builder, 'E-id')
1923
1861
 
1924
1862
        entries = list(merge_obj._entries_lca())
1925
1863
        self.expectFailure("We don't detect that LCA resolution was the"
1926
1864
                           " same on both sides",
1927
 
                           self.assertEqual, [], entries)
 
1865
            self.assertEqual, [], entries)
1928
1866
 
1929
1867
    def test_only_path_changed(self):
1930
1868
        builder = self.get_builder()
1931
 
        builder.build_snapshot(None,
1932
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1933
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1934
 
                               revision_id=b'A-id')
1935
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1936
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1937
 
        builder.build_snapshot([b'C-id', b'B-id'],
1938
 
                               [('rename', (u'a', u'b'))],
1939
 
                               revision_id=b'E-id')
1940
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1941
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1869
        builder.build_snapshot('A-id', None,
 
1870
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1871
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1872
        builder.build_snapshot('B-id', ['A-id'], [])
 
1873
        builder.build_snapshot('C-id', ['A-id'], [])
 
1874
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1875
            [('rename', (u'a', u'b'))])
 
1876
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1877
        merge_obj = self.make_merge_obj(builder, 'E-id')
1942
1878
        entries = list(merge_obj._entries_lca())
1943
 
        root_id = b'a-root-id'
 
1879
        root_id = 'a-root-id'
1944
1880
        # The content was not changed, only the path
1945
 
        self.assertEqual([(b'a-id', False,
1946
 
                           ((u'a', [u'a', u'a']), u'b', u'a'),
 
1881
        self.assertEqual([('a-id', False,
1947
1882
                           ((root_id, [root_id, root_id]), root_id, root_id),
1948
1883
                           ((u'a', [u'a', u'a']), u'b', u'a'),
1949
1884
                           ((False, [False, False]), False, False)),
1950
 
                          ], entries)
 
1885
                         ], entries)
1951
1886
 
1952
1887
    def test_kind_changed(self):
1953
1888
        # Identical content, except 'D' changes a-id into a directory
1954
1889
        builder = self.get_builder()
1955
 
        builder.build_snapshot(None,
1956
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1957
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1958
 
                               revision_id=b'A-id')
1959
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1960
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1961
 
        builder.build_snapshot([b'C-id', b'B-id'],
1962
 
                               [('unversion', 'a'),
1963
 
                                ('flush', None),
1964
 
                                ('add', (u'a', b'a-id', 'directory', None))],
1965
 
                               revision_id=b'E-id')
1966
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1967
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1890
        builder.build_snapshot('A-id', None,
 
1891
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1892
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1893
        builder.build_snapshot('B-id', ['A-id'], [])
 
1894
        builder.build_snapshot('C-id', ['A-id'], [])
 
1895
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1896
            [('unversion', 'a-id'),
 
1897
             ('flush', None),
 
1898
             ('add', (u'a', 'a-id', 'directory', None))])
 
1899
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1900
        merge_obj = self.make_merge_obj(builder, 'E-id')
1968
1901
        entries = list(merge_obj._entries_lca())
1969
 
        root_id = b'a-root-id'
 
1902
        root_id = 'a-root-id'
1970
1903
        # Only the kind was changed (content)
1971
 
        self.assertEqual([(b'a-id', True,
1972
 
                           ((u'a', [u'a', u'a']), u'a', u'a'),
 
1904
        self.assertEqual([('a-id', True,
1973
1905
                           ((root_id, [root_id, root_id]), root_id, root_id),
1974
1906
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1975
1907
                           ((False, [False, False]), False, False)),
1976
 
                          ], entries)
 
1908
                         ], entries)
1977
1909
 
1978
1910
    def test_this_changed_kind(self):
1979
1911
        # Identical content, but THIS changes a file to a directory
1980
1912
        builder = self.get_builder()
1981
 
        builder.build_snapshot(None,
1982
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
1983
 
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
1984
 
                               revision_id=b'A-id')
1985
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1986
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
1987
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
1988
 
        builder.build_snapshot([b'B-id', b'C-id'],
1989
 
                               [('unversion', 'a'),
1990
 
                                ('flush', None),
1991
 
                                ('add', (u'a', b'a-id', 'directory', None))],
1992
 
                               revision_id=b'D-id')
1993
 
        merge_obj = self.make_merge_obj(builder, b'E-id')
 
1913
        builder.build_snapshot('A-id', None,
 
1914
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1915
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
 
1916
        builder.build_snapshot('B-id', ['A-id'], [])
 
1917
        builder.build_snapshot('C-id', ['A-id'], [])
 
1918
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
1919
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1920
            [('unversion', 'a-id'),
 
1921
             ('flush', None),
 
1922
             ('add', (u'a', 'a-id', 'directory', None))])
 
1923
        merge_obj = self.make_merge_obj(builder, 'E-id')
1994
1924
        entries = list(merge_obj._entries_lca())
1995
1925
        # Only the kind was changed (content)
1996
1926
        self.assertEqual([], entries)
1998
1928
    def test_interesting_files(self):
1999
1929
        # Two files modified, but we should filter one of them
2000
1930
        builder = self.get_builder()
2001
 
        builder.build_snapshot(None,
2002
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2003
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2004
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2005
 
                               revision_id=b'A-id')
2006
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2007
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2008
 
        builder.build_snapshot([b'C-id', b'B-id'],
2009
 
                               [('modify', ('a', b'new-content\n')),
2010
 
                                ('modify', ('b', b'new-content\n'))],
2011
 
                               revision_id=b'E-id')
2012
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2013
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1931
        builder.build_snapshot('A-id', None,
 
1932
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1933
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1934
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1935
        builder.build_snapshot('B-id', ['A-id'], [])
 
1936
        builder.build_snapshot('C-id', ['A-id'], [])
 
1937
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1938
            [('modify', ('a-id', 'new-content\n')),
 
1939
             ('modify', ('b-id', 'new-content\n'))])
 
1940
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1941
        merge_obj = self.make_merge_obj(builder, 'E-id',
2014
1942
                                        interesting_files=['b'])
2015
1943
        entries = list(merge_obj._entries_lca())
2016
 
        root_id = b'a-root-id'
2017
 
        self.assertEqual([(b'b-id', True,
2018
 
                           ((u'b', [u'b', u'b']), u'b', u'b'),
 
1944
        root_id = 'a-root-id'
 
1945
        self.assertEqual([('b-id', True,
2019
1946
                           ((root_id, [root_id, root_id]), root_id, root_id),
2020
1947
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2021
1948
                           ((False, [False, False]), False, False)),
2022
 
                          ], entries)
 
1949
                         ], entries)
2023
1950
 
2024
1951
    def test_interesting_file_in_this(self):
2025
1952
        # This renamed the file, but it should still match the entry in other
2026
1953
        builder = self.get_builder()
2027
 
        builder.build_snapshot(None,
2028
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2029
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2030
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2031
 
                               revision_id=b'A-id')
2032
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2033
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2034
 
        builder.build_snapshot([b'C-id', b'B-id'],
2035
 
                               [('modify', ('a', b'new-content\n')),
2036
 
                                ('modify', ('b', b'new-content\n'))],
2037
 
                               revision_id=b'E-id')
2038
 
        builder.build_snapshot([b'B-id', b'C-id'],
2039
 
                               [('rename', ('b', 'c'))],
2040
 
                               revision_id=b'D-id')
2041
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1954
        builder.build_snapshot('A-id', None,
 
1955
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1956
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1957
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
1958
        builder.build_snapshot('B-id', ['A-id'], [])
 
1959
        builder.build_snapshot('C-id', ['A-id'], [])
 
1960
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1961
            [('modify', ('a-id', 'new-content\n')),
 
1962
             ('modify', ('b-id', 'new-content\n'))])
 
1963
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
1964
            [('rename', ('b', 'c'))])
 
1965
        merge_obj = self.make_merge_obj(builder, 'E-id',
2042
1966
                                        interesting_files=['c'])
2043
1967
        entries = list(merge_obj._entries_lca())
2044
 
        root_id = b'a-root-id'
2045
 
        self.assertEqual([(b'b-id', True,
2046
 
                           ((u'b', [u'b', u'b']), u'b', u'c'),
 
1968
        root_id = 'a-root-id'
 
1969
        self.assertEqual([('b-id', True,
2047
1970
                           ((root_id, [root_id, root_id]), root_id, root_id),
2048
1971
                           ((u'b', [u'b', u'b']), u'b', u'c'),
2049
1972
                           ((False, [False, False]), False, False)),
2050
 
                          ], entries)
 
1973
                         ], entries)
2051
1974
 
2052
1975
    def test_interesting_file_in_base(self):
2053
1976
        # This renamed the file, but it should still match the entry in BASE
2054
1977
        builder = self.get_builder()
2055
 
        builder.build_snapshot(None,
2056
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2057
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2058
 
                                   ('add', (u'c', b'c-id', 'file', b'content\n'))],
2059
 
                               revision_id=b'A-id')
2060
 
        builder.build_snapshot([b'A-id'],
2061
 
                               [('rename', ('c', 'b'))],
2062
 
                               revision_id=b'B-id')
2063
 
        builder.build_snapshot([b'A-id'],
2064
 
                               [('rename', ('c', 'b'))],
2065
 
                               revision_id=b'C-id')
2066
 
        builder.build_snapshot([b'C-id', b'B-id'],
2067
 
                               [('modify', ('a', b'new-content\n')),
2068
 
                                ('modify', ('b', b'new-content\n'))],
2069
 
                               revision_id=b'E-id')
2070
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2071
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
1978
        builder.build_snapshot('A-id', None,
 
1979
            [('add', (u'', 'a-root-id', 'directory', None)),
 
1980
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
1981
             ('add', (u'c', 'c-id', 'file', 'content\n'))])
 
1982
        builder.build_snapshot('B-id', ['A-id'],
 
1983
            [('rename', ('c', 'b'))])
 
1984
        builder.build_snapshot('C-id', ['A-id'],
 
1985
            [('rename', ('c', 'b'))])
 
1986
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
1987
            [('modify', ('a-id', 'new-content\n')),
 
1988
             ('modify', ('c-id', 'new-content\n'))])
 
1989
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1990
        merge_obj = self.make_merge_obj(builder, 'E-id',
2072
1991
                                        interesting_files=['c'])
2073
1992
        entries = list(merge_obj._entries_lca())
2074
 
        root_id = b'a-root-id'
2075
 
        self.assertEqual([(b'c-id', True,
2076
 
                           ((u'c', [u'b', u'b']), u'b', u'b'),
 
1993
        root_id = 'a-root-id'
 
1994
        self.assertEqual([('c-id', True,
2077
1995
                           ((root_id, [root_id, root_id]), root_id, root_id),
2078
1996
                           ((u'c', [u'b', u'b']), u'b', u'b'),
2079
1997
                           ((False, [False, False]), False, False)),
2080
 
                          ], entries)
 
1998
                         ], entries)
2081
1999
 
2082
2000
    def test_interesting_file_in_lca(self):
2083
2001
        # This renamed the file, but it should still match the entry in LCA
2084
2002
        builder = self.get_builder()
2085
 
        builder.build_snapshot(None,
2086
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2087
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2088
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2089
 
                               revision_id=b'A-id')
2090
 
        builder.build_snapshot([b'A-id'],
2091
 
                               [('rename', ('b', 'c'))], revision_id=b'B-id')
2092
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2093
 
        builder.build_snapshot([b'C-id', b'B-id'],
2094
 
                               [('modify', ('a', b'new-content\n')),
2095
 
                                ('modify', ('b', b'new-content\n'))],
2096
 
                               revision_id=b'E-id')
2097
 
        builder.build_snapshot([b'B-id', b'C-id'],
2098
 
                               [('rename', ('c', 'b'))], revision_id=b'D-id')
2099
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
2003
        builder.build_snapshot('A-id', None,
 
2004
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2005
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
2006
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
2007
        builder.build_snapshot('B-id', ['A-id'],
 
2008
            [('rename', ('b', 'c'))])
 
2009
        builder.build_snapshot('C-id', ['A-id'], [])
 
2010
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2011
            [('modify', ('a-id', 'new-content\n')),
 
2012
             ('modify', ('b-id', 'new-content\n'))])
 
2013
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
2014
            [('rename', ('c', 'b'))])
 
2015
        merge_obj = self.make_merge_obj(builder, 'E-id',
2100
2016
                                        interesting_files=['c'])
2101
2017
        entries = list(merge_obj._entries_lca())
2102
 
        root_id = b'a-root-id'
2103
 
        self.assertEqual([(b'b-id', True,
2104
 
                           ((u'b', [u'c', u'b']), u'b', u'b'),
 
2018
        root_id = 'a-root-id'
 
2019
        self.assertEqual([('b-id', True,
2105
2020
                           ((root_id, [root_id, root_id]), root_id, root_id),
2106
2021
                           ((u'b', [u'c', u'b']), u'b', u'b'),
2107
2022
                           ((False, [False, False]), False, False)),
2108
 
                          ], entries)
 
2023
                         ], entries)
2109
2024
 
2110
 
    def test_interesting_files(self):
 
2025
    def test_interesting_ids(self):
2111
2026
        # Two files modified, but we should filter one of them
2112
2027
        builder = self.get_builder()
2113
 
        builder.build_snapshot(None,
2114
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2115
 
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
2116
 
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
2117
 
                               revision_id=b'A-id')
2118
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2119
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2120
 
        builder.build_snapshot([b'C-id', b'B-id'],
2121
 
                               [('modify', ('a', b'new-content\n')),
2122
 
                                ('modify', ('b', b'new-content\n'))], revision_id=b'E-id')
2123
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2124
 
        merge_obj = self.make_merge_obj(builder, b'E-id',
2125
 
                                        interesting_files=['b'])
 
2028
        builder.build_snapshot('A-id', None,
 
2029
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2030
             ('add', (u'a', 'a-id', 'file', 'content\n')),
 
2031
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
 
2032
        builder.build_snapshot('B-id', ['A-id'], [])
 
2033
        builder.build_snapshot('C-id', ['A-id'], [])
 
2034
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2035
            [('modify', ('a-id', 'new-content\n')),
 
2036
             ('modify', ('b-id', 'new-content\n'))])
 
2037
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2038
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
2039
                                        interesting_ids=['b-id'])
2126
2040
        entries = list(merge_obj._entries_lca())
2127
 
        root_id = b'a-root-id'
2128
 
        self.assertEqual([(b'b-id', True,
2129
 
                           ((u'b', [u'b', u'b']), u'b', u'b'),
 
2041
        root_id = 'a-root-id'
 
2042
        self.assertEqual([('b-id', True,
2130
2043
                           ((root_id, [root_id, root_id]), root_id, root_id),
2131
2044
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2132
2045
                           ((False, [False, False]), False, False)),
2133
 
                          ], entries)
 
2046
                         ], entries)
 
2047
 
2134
2048
 
2135
2049
 
2136
2050
class TestMergerEntriesLCAOnDisk(tests.TestCaseWithTransport):
2144
2058
    def get_wt_from_builder(self, builder):
2145
2059
        """Get a real WorkingTree from the builder."""
2146
2060
        the_branch = builder.get_branch()
2147
 
        wt = the_branch.controldir.create_workingtree()
 
2061
        wt = the_branch.bzrdir.create_workingtree()
2148
2062
        # Note: This is a little bit ugly, but we are holding the branch
2149
2063
        #       write-locked as part of the build process, and we would like to
2150
2064
        #       maintain that. So we just force the WT to re-use the same
2156
2070
 
2157
2071
    def do_merge(self, builder, other_revision_id):
2158
2072
        wt = self.get_wt_from_builder(builder)
2159
 
        merger = _mod_merge.Merger.from_revision_ids(
 
2073
        merger = _mod_merge.Merger.from_revision_ids(None,
2160
2074
            wt, other_revision_id)
2161
2075
        merger.merge_type = _mod_merge.Merge3Merger
2162
2076
        return wt, merger.do_merge()
2163
2077
 
2164
2078
    def test_simple_lca(self):
2165
2079
        builder = self.get_builder()
2166
 
        builder.build_snapshot(None,
2167
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2168
 
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
2169
 
                               revision_id=b'A-id')
2170
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2171
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2172
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
2173
 
        builder.build_snapshot([b'B-id', b'C-id'],
2174
 
                               [('modify', ('a', b'a\nb\nc\nd\ne\nf\n'))],
2175
 
                               revision_id=b'D-id')
2176
 
        wt, conflicts = self.do_merge(builder, b'E-id')
 
2080
        builder.build_snapshot('A-id', None,
 
2081
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2082
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
 
2083
        builder.build_snapshot('C-id', ['A-id'], [])
 
2084
        builder.build_snapshot('B-id', ['A-id'], [])
 
2085
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
2086
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
2087
            [('modify', ('a-id', 'a\nb\nc\nd\ne\nf\n'))])
 
2088
        wt, conflicts = self.do_merge(builder, 'E-id')
2177
2089
        self.assertEqual(0, conflicts)
2178
2090
        # The merge should have simply update the contents of 'a'
2179
 
        self.assertEqual(b'a\nb\nc\nd\ne\nf\n', wt.get_file_text('a'))
 
2091
        self.assertEqual('a\nb\nc\nd\ne\nf\n', wt.get_file_text('a-id'))
2180
2092
 
2181
2093
    def test_conflict_without_lca(self):
2182
2094
        # This test would cause a merge conflict, unless we use the lca trees
2191
2103
        #     |
2192
2104
        #     F     Path at 'baz' in F, which supersedes 'bar' and 'foo'
2193
2105
        builder = self.get_builder()
2194
 
        builder.build_snapshot(None,
2195
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2196
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2197
 
                               revision_id=b'A-id')
2198
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2199
 
        builder.build_snapshot([b'A-id'],
2200
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id', )
2201
 
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
2202
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
2203
 
        builder.build_snapshot([b'E-id'],
2204
 
                               [('rename', ('bar', 'baz'))], revision_id=b'F-id')
2205
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2206
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2106
        builder.build_snapshot('A-id', None,
 
2107
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2108
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2109
        builder.build_snapshot('C-id', ['A-id'], [])
 
2110
        builder.build_snapshot('B-id', ['A-id'],
 
2111
            [('rename', ('foo', 'bar'))])
 
2112
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
 
2113
            [('rename', ('foo', 'bar'))])
 
2114
        builder.build_snapshot('F-id', ['E-id'],
 
2115
            [('rename', ('bar', 'baz'))])
 
2116
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2117
        wt, conflicts = self.do_merge(builder, 'F-id')
2207
2118
        self.assertEqual(0, conflicts)
2208
2119
        # The merge should simply recognize that the final rename takes
2209
2120
        # precedence
2210
 
        self.assertEqual('baz', wt.id2path(b'foo-id'))
 
2121
        self.assertEqual('baz', wt.id2path('foo-id'))
2211
2122
 
2212
2123
    def test_other_deletes_lca_renames(self):
2213
2124
        # This test would cause a merge conflict, unless we use the lca trees
2222
2133
        #     |
2223
2134
        #     F     F deletes 'bar'
2224
2135
        builder = self.get_builder()
2225
 
        builder.build_snapshot(None,
2226
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2227
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2228
 
                               revision_id=b'A-id')
2229
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2230
 
        builder.build_snapshot([b'A-id'],
2231
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
2232
 
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
2233
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
2234
 
        builder.build_snapshot([b'E-id'],
2235
 
                               [('unversion', 'bar')], revision_id=b'F-id')
2236
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2237
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2136
        builder.build_snapshot('A-id', None,
 
2137
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2138
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2139
        builder.build_snapshot('C-id', ['A-id'], [])
 
2140
        builder.build_snapshot('B-id', ['A-id'],
 
2141
            [('rename', ('foo', 'bar'))])
 
2142
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
 
2143
            [('rename', ('foo', 'bar'))])
 
2144
        builder.build_snapshot('F-id', ['E-id'],
 
2145
            [('unversion', 'foo-id')])
 
2146
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2147
        wt, conflicts = self.do_merge(builder, 'F-id')
2238
2148
        self.assertEqual(0, conflicts)
2239
 
        self.assertRaises(errors.NoSuchId, wt.id2path, b'foo-id')
 
2149
        self.assertRaises(errors.NoSuchId, wt.id2path, 'foo-id')
2240
2150
 
2241
2151
    def test_executable_changes(self):
2242
2152
        #   A       Path at 'foo'
2249
2159
        #     |
2250
2160
        #     F     Executable bit changed
2251
2161
        builder = self.get_builder()
2252
 
        builder.build_snapshot(None,
2253
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2254
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2255
 
                               revision_id=b'A-id')
2256
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2257
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2258
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2259
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
2162
        builder.build_snapshot('A-id', None,
 
2163
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2164
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2165
        builder.build_snapshot('C-id', ['A-id'], [])
 
2166
        builder.build_snapshot('B-id', ['A-id'], [])
 
2167
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2168
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2260
2169
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2261
2170
        wt = self.get_wt_from_builder(builder)
2262
 
        with wt.get_transform() as tt:
2263
 
            tt.set_executability(True, tt.trans_id_tree_path('foo'))
 
2171
        tt = transform.TreeTransform(wt)
 
2172
        try:
 
2173
            tt.set_executability(True, tt.trans_id_tree_file_id('foo-id'))
2264
2174
            tt.apply()
2265
 
        self.assertTrue(wt.is_executable('foo'))
2266
 
        wt.commit('F-id', rev_id=b'F-id')
 
2175
        except:
 
2176
            tt.finalize()
 
2177
            raise
 
2178
        self.assertTrue(wt.is_executable('foo-id'))
 
2179
        wt.commit('F-id', rev_id='F-id')
2267
2180
        # Reset to D, so that we can merge F
2268
 
        wt.set_parent_ids([b'D-id'])
2269
 
        wt.branch.set_last_revision_info(3, b'D-id')
 
2181
        wt.set_parent_ids(['D-id'])
 
2182
        wt.branch.set_last_revision_info(3, 'D-id')
2270
2183
        wt.revert()
2271
 
        self.assertFalse(wt.is_executable('foo'))
2272
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2184
        self.assertFalse(wt.is_executable('foo-id'))
 
2185
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2273
2186
        self.assertEqual(0, conflicts)
2274
 
        self.assertTrue(wt.is_executable('foo'))
 
2187
        self.assertTrue(wt.is_executable('foo-id'))
2275
2188
 
2276
2189
    def test_create_symlink(self):
2277
2190
        self.requireFeature(features.SymlinkFeature)
2287
2200
        # Have to use a real WT, because BranchBuilder and MemoryTree don't
2288
2201
        # have symlink support
2289
2202
        builder = self.get_builder()
2290
 
        builder.build_snapshot(None,
2291
 
                               [('add', (u'', b'a-root-id', 'directory', None))],
2292
 
                               revision_id=b'A-id')
2293
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2294
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
2295
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2296
 
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
2203
        builder.build_snapshot('A-id', None,
 
2204
            [('add', (u'', 'a-root-id', 'directory', None))])
 
2205
        builder.build_snapshot('C-id', ['A-id'], [])
 
2206
        builder.build_snapshot('B-id', ['A-id'], [])
 
2207
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2208
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2297
2209
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2298
2210
        wt = self.get_wt_from_builder(builder)
2299
2211
        os.symlink('bar', 'path/foo')
2300
 
        wt.add(['foo'], [b'foo-id'])
2301
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
2302
 
        wt.commit('add symlink', rev_id=b'F-id')
 
2212
        wt.add(['foo'], ['foo-id'])
 
2213
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2214
        wt.commit('add symlink', rev_id='F-id')
2303
2215
        # Reset to D, so that we can merge F
2304
 
        wt.set_parent_ids([b'D-id'])
2305
 
        wt.branch.set_last_revision_info(3, b'D-id')
 
2216
        wt.set_parent_ids(['D-id'])
 
2217
        wt.branch.set_last_revision_info(3, 'D-id')
2306
2218
        wt.revert()
2307
 
        self.assertFalse(wt.is_versioned('foo'))
2308
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2219
        self.assertIs(None, wt.path2id('foo'))
 
2220
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2309
2221
        self.assertEqual(0, conflicts)
2310
 
        self.assertEqual(b'foo-id', wt.path2id('foo'))
2311
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
 
2222
        self.assertEqual('foo-id', wt.path2id('foo'))
 
2223
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2312
2224
 
2313
2225
    def test_both_sides_revert(self):
2314
2226
        # Both sides of a criss-cross revert the text to the lca
2321
2233
        # This must be done with a real WorkingTree, because normally their
2322
2234
        # inventory contains "None" rather than a real sha1
2323
2235
        builder = self.get_builder()
2324
 
        builder.build_snapshot(None,
2325
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2326
 
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
2327
 
                               revision_id=b'A-id')
2328
 
        builder.build_snapshot([b'A-id'],
2329
 
                               [('modify', ('foo', b'B content\n'))],
2330
 
                               revision_id=b'B-id')
2331
 
        builder.build_snapshot([b'A-id'],
2332
 
                               [('modify', ('foo', b'C content\n'))],
2333
 
                               revision_id=b'C-id')
2334
 
        builder.build_snapshot([b'C-id', b'B-id'], [],
2335
 
                               revision_id=b'E-id')
2336
 
        builder.build_snapshot([b'B-id', b'C-id'], [],
2337
 
                               revision_id=b'D-id')
2338
 
        wt, conflicts = self.do_merge(builder, b'E-id')
 
2236
        builder.build_snapshot('A-id', None,
 
2237
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2238
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
 
2239
        builder.build_snapshot('B-id', ['A-id'],
 
2240
            [('modify', ('foo-id', 'B content\n'))])
 
2241
        builder.build_snapshot('C-id', ['A-id'],
 
2242
            [('modify', ('foo-id', 'C content\n'))])
 
2243
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
2244
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2245
        wt, conflicts = self.do_merge(builder, 'E-id')
2339
2246
        self.assertEqual(1, conflicts)
2340
 
        self.assertEqualDiff(b'<<<<<<< TREE\n'
2341
 
                             b'B content\n'
2342
 
                             b'=======\n'
2343
 
                             b'C content\n'
2344
 
                             b'>>>>>>> MERGE-SOURCE\n',
2345
 
                             wt.get_file_text('foo'))
 
2247
        self.assertEqualDiff('<<<<<<< TREE\n'
 
2248
                             'B content\n'
 
2249
                             '=======\n'
 
2250
                             'C content\n'
 
2251
                             '>>>>>>> MERGE-SOURCE\n',
 
2252
                             wt.get_file_text('foo-id'))
2346
2253
 
2347
2254
    def test_modified_symlink(self):
2348
2255
        self.requireFeature(features.SymlinkFeature)
2365
2272
        wt.lock_write()
2366
2273
        self.addCleanup(wt.unlock)
2367
2274
        os.symlink('bar', 'path/foo')
2368
 
        wt.add(['foo'], [b'foo-id'])
2369
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2275
        wt.add(['foo'], ['foo-id'])
 
2276
        wt.commit('add symlink', rev_id='A-id')
2370
2277
        os.remove('path/foo')
2371
2278
        os.symlink('baz', 'path/foo')
2372
 
        wt.commit('foo => baz', rev_id=b'B-id')
2373
 
        wt.set_last_revision(b'A-id')
2374
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2279
        wt.commit('foo => baz', rev_id='B-id')
 
2280
        wt.set_last_revision('A-id')
 
2281
        wt.branch.set_last_revision_info(1, 'A-id')
2375
2282
        wt.revert()
2376
 
        wt.commit('C', rev_id=b'C-id')
2377
 
        wt.merge_from_branch(wt.branch, b'B-id')
2378
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2379
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2283
        wt.commit('C', rev_id='C-id')
 
2284
        wt.merge_from_branch(wt.branch, 'B-id')
 
2285
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2286
        wt.commit('E merges C & B', rev_id='E-id')
2380
2287
        os.remove('path/foo')
2381
2288
        os.symlink('bing', 'path/foo')
2382
 
        wt.commit('F foo => bing', rev_id=b'F-id')
2383
 
        wt.set_last_revision(b'B-id')
2384
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2289
        wt.commit('F foo => bing', rev_id='F-id')
 
2290
        wt.set_last_revision('B-id')
 
2291
        wt.branch.set_last_revision_info(2, 'B-id')
2385
2292
        wt.revert()
2386
 
        wt.merge_from_branch(wt.branch, b'C-id')
2387
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2388
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2293
        wt.merge_from_branch(wt.branch, 'C-id')
 
2294
        wt.commit('D merges B & C', rev_id='D-id')
 
2295
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2389
2296
        self.assertEqual(0, conflicts)
2390
 
        self.assertEqual('bing', wt.get_symlink_target('foo'))
 
2297
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2391
2298
 
2392
2299
    def test_renamed_symlink(self):
2393
2300
        self.requireFeature(features.SymlinkFeature)
2408
2315
        wt.lock_write()
2409
2316
        self.addCleanup(wt.unlock)
2410
2317
        os.symlink('bar', 'path/foo')
2411
 
        wt.add(['foo'], [b'foo-id'])
2412
 
        wt.commit('A add symlink', rev_id=b'A-id')
 
2318
        wt.add(['foo'], ['foo-id'])
 
2319
        wt.commit('A add symlink', rev_id='A-id')
2413
2320
        wt.rename_one('foo', 'barry')
2414
 
        wt.commit('B foo => barry', rev_id=b'B-id')
2415
 
        wt.set_last_revision(b'A-id')
2416
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2321
        wt.commit('B foo => barry', rev_id='B-id')
 
2322
        wt.set_last_revision('A-id')
 
2323
        wt.branch.set_last_revision_info(1, 'A-id')
2417
2324
        wt.revert()
2418
 
        wt.commit('C', rev_id=b'C-id')
2419
 
        wt.merge_from_branch(wt.branch, b'B-id')
2420
 
        self.assertEqual('barry', wt.id2path(b'foo-id'))
2421
 
        self.assertEqual('bar', wt.get_symlink_target('barry'))
2422
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2325
        wt.commit('C', rev_id='C-id')
 
2326
        wt.merge_from_branch(wt.branch, 'B-id')
 
2327
        self.assertEqual('barry', wt.id2path('foo-id'))
 
2328
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2329
        wt.commit('E merges C & B', rev_id='E-id')
2423
2330
        wt.rename_one('barry', 'blah')
2424
 
        wt.commit('F barry => blah', rev_id=b'F-id')
2425
 
        wt.set_last_revision(b'B-id')
2426
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2331
        wt.commit('F barry => blah', rev_id='F-id')
 
2332
        wt.set_last_revision('B-id')
 
2333
        wt.branch.set_last_revision_info(2, 'B-id')
2427
2334
        wt.revert()
2428
 
        wt.merge_from_branch(wt.branch, b'C-id')
2429
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2430
 
        self.assertEqual('barry', wt.id2path(b'foo-id'))
 
2335
        wt.merge_from_branch(wt.branch, 'C-id')
 
2336
        wt.commit('D merges B & C', rev_id='D-id')
 
2337
        self.assertEqual('barry', wt.id2path('foo-id'))
2431
2338
        # Check the output of the Merger object directly
2432
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'F-id')
 
2339
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2340
            wt, 'F-id')
2433
2341
        merger.merge_type = _mod_merge.Merge3Merger
2434
2342
        merge_obj = merger.make_merger()
2435
2343
        root_id = wt.path2id('')
2436
2344
        entries = list(merge_obj._entries_lca())
2437
2345
        # No content change, just a path change
2438
 
        self.assertEqual([(b'foo-id', False,
2439
 
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
 
2346
        self.assertEqual([('foo-id', False,
2440
2347
                           ((root_id, [root_id, root_id]), root_id, root_id),
2441
2348
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
2442
2349
                           ((False, [False, False]), False, False)),
2443
 
                          ], entries)
2444
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
 
2350
                         ], entries)
 
2351
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
2445
2352
        self.assertEqual(0, conflicts)
2446
 
        self.assertEqual('blah', wt.id2path(b'foo-id'))
 
2353
        self.assertEqual('blah', wt.id2path('foo-id'))
2447
2354
 
2448
2355
    def test_symlink_no_content_change(self):
2449
2356
        self.requireFeature(features.SymlinkFeature)
2463
2370
        wt.lock_write()
2464
2371
        self.addCleanup(wt.unlock)
2465
2372
        os.symlink('bar', 'path/foo')
2466
 
        wt.add(['foo'], [b'foo-id'])
2467
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2373
        wt.add(['foo'], ['foo-id'])
 
2374
        wt.commit('add symlink', rev_id='A-id')
2468
2375
        os.remove('path/foo')
2469
2376
        os.symlink('baz', 'path/foo')
2470
 
        wt.commit('foo => baz', rev_id=b'B-id')
2471
 
        wt.set_last_revision(b'A-id')
2472
 
        wt.branch.set_last_revision_info(1, b'A-id')
2473
 
        wt.revert()
2474
 
        wt.commit('C', rev_id=b'C-id')
2475
 
        wt.merge_from_branch(wt.branch, b'B-id')
2476
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2477
 
        wt.commit('E merges C & B', rev_id=b'E-id')
2478
 
        wt.set_last_revision(b'B-id')
2479
 
        wt.branch.set_last_revision_info(2, b'B-id')
2480
 
        wt.revert()
2481
 
        wt.merge_from_branch(wt.branch, b'C-id')
2482
 
        wt.commit('D merges B & C', rev_id=b'D-id')
 
2377
        wt.commit('foo => baz', rev_id='B-id')
 
2378
        wt.set_last_revision('A-id')
 
2379
        wt.branch.set_last_revision_info(1, 'A-id')
 
2380
        wt.revert()
 
2381
        wt.commit('C', rev_id='C-id')
 
2382
        wt.merge_from_branch(wt.branch, 'B-id')
 
2383
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2384
        wt.commit('E merges C & B', rev_id='E-id')
 
2385
        wt.set_last_revision('B-id')
 
2386
        wt.branch.set_last_revision_info(2, 'B-id')
 
2387
        wt.revert()
 
2388
        wt.merge_from_branch(wt.branch, 'C-id')
 
2389
        wt.commit('D merges B & C', rev_id='D-id')
2483
2390
        os.remove('path/foo')
2484
2391
        os.symlink('bing', 'path/foo')
2485
 
        wt.commit('F foo => bing', rev_id=b'F-id')
 
2392
        wt.commit('F foo => bing', rev_id='F-id')
2486
2393
 
2487
2394
        # Check the output of the Merger object directly
2488
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2395
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2396
            wt, 'E-id')
2489
2397
        merger.merge_type = _mod_merge.Merge3Merger
2490
2398
        merge_obj = merger.make_merger()
2491
2399
        # Nothing interesting happened in OTHER relative to BASE
2492
2400
        self.assertEqual([], list(merge_obj._entries_lca()))
2493
2401
        # Now do a real merge, just to test the rest of the stack
2494
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'E-id')
 
2402
        conflicts = wt.merge_from_branch(wt.branch, to_revision='E-id')
2495
2403
        self.assertEqual(0, conflicts)
2496
 
        self.assertEqual('bing', wt.get_symlink_target('foo'))
 
2404
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
2497
2405
 
2498
2406
    def test_symlink_this_changed_kind(self):
2499
2407
        self.requireFeature(features.SymlinkFeature)
2510
2418
        wt = self.make_branch_and_tree('path')
2511
2419
        wt.lock_write()
2512
2420
        self.addCleanup(wt.unlock)
2513
 
        wt.commit('base', rev_id=b'A-id')
 
2421
        wt.commit('base', rev_id='A-id')
2514
2422
        os.symlink('bar', 'path/foo')
2515
 
        wt.add(['foo'], [b'foo-id'])
2516
 
        wt.commit('add symlink foo => bar', rev_id=b'B-id')
2517
 
        wt.set_last_revision(b'A-id')
2518
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2423
        wt.add(['foo'], ['foo-id'])
 
2424
        wt.commit('add symlink foo => bar', rev_id='B-id')
 
2425
        wt.set_last_revision('A-id')
 
2426
        wt.branch.set_last_revision_info(1, 'A-id')
2519
2427
        wt.revert()
2520
 
        wt.commit('C', rev_id=b'C-id')
2521
 
        wt.merge_from_branch(wt.branch, b'B-id')
2522
 
        self.assertEqual('bar', wt.get_symlink_target('foo'))
 
2428
        wt.commit('C', rev_id='C-id')
 
2429
        wt.merge_from_branch(wt.branch, 'B-id')
 
2430
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2523
2431
        os.remove('path/foo')
2524
2432
        # We have to change the link in E, or it won't try to do a comparison
2525
2433
        os.symlink('bing', 'path/foo')
2526
 
        wt.commit('E merges C & B, overrides to bing', rev_id=b'E-id')
2527
 
        wt.set_last_revision(b'B-id')
2528
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2434
        wt.commit('E merges C & B, overrides to bing', rev_id='E-id')
 
2435
        wt.set_last_revision('B-id')
 
2436
        wt.branch.set_last_revision_info(2, 'B-id')
2529
2437
        wt.revert()
2530
 
        wt.merge_from_branch(wt.branch, b'C-id')
 
2438
        wt.merge_from_branch(wt.branch, 'C-id')
2531
2439
        os.remove('path/foo')
2532
 
        self.build_tree_contents([('path/foo', b'file content\n')])
 
2440
        self.build_tree_contents([('path/foo', 'file content\n')])
2533
2441
        # XXX: workaround, WT doesn't detect kind changes unless you do
2534
2442
        # iter_changes()
2535
2443
        list(wt.iter_changes(wt.basis_tree()))
2536
 
        wt.commit('D merges B & C, makes it a file', rev_id=b'D-id')
 
2444
        wt.commit('D merges B & C, makes it a file', rev_id='D-id')
2537
2445
 
2538
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2446
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2447
            wt, 'E-id')
2539
2448
        merger.merge_type = _mod_merge.Merge3Merger
2540
2449
        merge_obj = merger.make_merger()
2541
2450
        entries = list(merge_obj._entries_lca())
2542
2451
        root_id = wt.path2id('')
2543
 
        self.assertEqual([(b'foo-id', True,
2544
 
                           ((None, [u'foo', None]), u'foo', u'foo'),
 
2452
        self.assertEqual([('foo-id', True,
2545
2453
                           ((None, [root_id, None]), root_id, root_id),
2546
2454
                           ((None, [u'foo', None]), u'foo', u'foo'),
2547
2455
                           ((None, [False, None]), False, False)),
2548
 
                          ], entries)
 
2456
                         ], entries)
2549
2457
 
2550
2458
    def test_symlink_all_wt(self):
2551
2459
        """Check behavior if all trees are Working Trees."""
2566
2474
        wt.lock_write()
2567
2475
        self.addCleanup(wt.unlock)
2568
2476
        os.symlink('bar', 'path/foo')
2569
 
        wt.add(['foo'], [b'foo-id'])
2570
 
        wt.commit('add symlink', rev_id=b'A-id')
 
2477
        wt.add(['foo'], ['foo-id'])
 
2478
        wt.commit('add symlink', rev_id='A-id')
2571
2479
        os.remove('path/foo')
2572
2480
        os.symlink('baz', 'path/foo')
2573
 
        wt.commit('foo => baz', rev_id=b'B-id')
2574
 
        wt.set_last_revision(b'A-id')
2575
 
        wt.branch.set_last_revision_info(1, b'A-id')
 
2481
        wt.commit('foo => baz', rev_id='B-id')
 
2482
        wt.set_last_revision('A-id')
 
2483
        wt.branch.set_last_revision_info(1, 'A-id')
2576
2484
        wt.revert()
2577
 
        wt.commit('C', rev_id=b'C-id')
2578
 
        wt.merge_from_branch(wt.branch, b'B-id')
2579
 
        self.assertEqual('baz', wt.get_symlink_target('foo'))
2580
 
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2485
        wt.commit('C', rev_id='C-id')
 
2486
        wt.merge_from_branch(wt.branch, 'B-id')
 
2487
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
 
2488
        wt.commit('E merges C & B', rev_id='E-id')
2581
2489
        os.remove('path/foo')
2582
2490
        os.symlink('bing', 'path/foo')
2583
 
        wt.commit('F foo => bing', rev_id=b'F-id')
2584
 
        wt.set_last_revision(b'B-id')
2585
 
        wt.branch.set_last_revision_info(2, b'B-id')
 
2491
        wt.commit('F foo => bing', rev_id='F-id')
 
2492
        wt.set_last_revision('B-id')
 
2493
        wt.branch.set_last_revision_info(2, 'B-id')
2586
2494
        wt.revert()
2587
 
        wt.merge_from_branch(wt.branch, b'C-id')
2588
 
        wt.commit('D merges B & C', rev_id=b'D-id')
2589
 
        wt_base = wt.controldir.sprout('base', b'A-id').open_workingtree()
 
2495
        wt.merge_from_branch(wt.branch, 'C-id')
 
2496
        wt.commit('D merges B & C', rev_id='D-id')
 
2497
        wt_base = wt.bzrdir.sprout('base', 'A-id').open_workingtree()
2590
2498
        wt_base.lock_read()
2591
2499
        self.addCleanup(wt_base.unlock)
2592
 
        wt_lca1 = wt.controldir.sprout('b-tree', b'B-id').open_workingtree()
 
2500
        wt_lca1 = wt.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
2593
2501
        wt_lca1.lock_read()
2594
2502
        self.addCleanup(wt_lca1.unlock)
2595
 
        wt_lca2 = wt.controldir.sprout('c-tree', b'C-id').open_workingtree()
 
2503
        wt_lca2 = wt.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
2596
2504
        wt_lca2.lock_read()
2597
2505
        self.addCleanup(wt_lca2.unlock)
2598
 
        wt_other = wt.controldir.sprout('other', b'F-id').open_workingtree()
 
2506
        wt_other = wt.bzrdir.sprout('other', 'F-id').open_workingtree()
2599
2507
        wt_other.lock_read()
2600
2508
        self.addCleanup(wt_other.unlock)
2601
2509
        merge_obj = _mod_merge.Merge3Merger(wt, wt, wt_base,
2602
 
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2510
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2603
2511
        entries = list(merge_obj._entries_lca())
2604
2512
        root_id = wt.path2id('')
2605
 
        self.assertEqual([(b'foo-id', True,
2606
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2513
        self.assertEqual([('foo-id', True,
2607
2514
                           ((root_id, [root_id, root_id]), root_id, root_id),
2608
2515
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2609
2516
                           ((False, [False, False]), False, False)),
2610
 
                          ], entries)
 
2517
                         ], entries)
2611
2518
 
2612
2519
    def test_other_reverted_path_to_base(self):
2613
2520
        #   A       Path at 'foo'
2620
2527
        #     |
2621
2528
        #     F     Path at 'foo'
2622
2529
        builder = self.get_builder()
2623
 
        builder.build_snapshot(None,
2624
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2625
 
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
2626
 
                               revision_id=b'A-id')
2627
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2628
 
        builder.build_snapshot([b'A-id'],
2629
 
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
2630
 
        builder.build_snapshot([b'C-id', b'B-id'],
2631
 
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')  # merge the rename
2632
 
        builder.build_snapshot([b'E-id'],
2633
 
                               [('rename', ('bar', 'foo'))], revision_id=b'F-id')  # Rename back to BASE
2634
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2635
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2530
        builder.build_snapshot('A-id', None,
 
2531
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2532
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
 
2533
        builder.build_snapshot('C-id', ['A-id'], [])
 
2534
        builder.build_snapshot('B-id', ['A-id'],
 
2535
            [('rename', ('foo', 'bar'))])
 
2536
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2537
            [('rename', ('foo', 'bar'))]) # merge the rename
 
2538
        builder.build_snapshot('F-id', ['E-id'],
 
2539
            [('rename', ('bar', 'foo'))]) # Rename back to BASE
 
2540
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2541
        wt, conflicts = self.do_merge(builder, 'F-id')
2636
2542
        self.assertEqual(0, conflicts)
2637
 
        self.assertEqual('foo', wt.id2path(b'foo-id'))
 
2543
        self.assertEqual('foo', wt.id2path('foo-id'))
2638
2544
 
2639
2545
    def test_other_reverted_content_to_base(self):
2640
2546
        builder = self.get_builder()
2641
 
        builder.build_snapshot(None,
2642
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2643
 
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2644
 
                               revision_id=b'A-id')
2645
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2646
 
        builder.build_snapshot([b'A-id'],
2647
 
                               [('modify', ('foo', b'B content\n'))],
2648
 
                               revision_id=b'B-id')
2649
 
        builder.build_snapshot([b'C-id', b'B-id'],
2650
 
                               [('modify', ('foo', b'B content\n'))],
2651
 
                               revision_id=b'E-id')  # merge the content
2652
 
        builder.build_snapshot([b'E-id'],
2653
 
                               [('modify', ('foo', b'base content\n'))],
2654
 
                               revision_id=b'F-id')  # Revert back to BASE
2655
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2656
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2547
        builder.build_snapshot('A-id', None,
 
2548
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2549
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2550
        builder.build_snapshot('C-id', ['A-id'], [])
 
2551
        builder.build_snapshot('B-id', ['A-id'],
 
2552
            [('modify', ('foo-id', 'B content\n'))])
 
2553
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2554
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
 
2555
        builder.build_snapshot('F-id', ['E-id'],
 
2556
            [('modify', ('foo-id', 'base content\n'))]) # Revert back to BASE
 
2557
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2558
        wt, conflicts = self.do_merge(builder, 'F-id')
2657
2559
        self.assertEqual(0, conflicts)
2658
2560
        # TODO: We need to use the per-file graph to properly select a BASE
2659
2561
        #       before this will work. Or at least use the LCA trees to find
2660
2562
        #       the appropriate content base. (which is B, not A).
2661
 
        self.assertEqual(b'base content\n', wt.get_file_text('foo'))
 
2563
        self.assertEqual('base content\n', wt.get_file_text('foo-id'))
2662
2564
 
2663
2565
    def test_other_modified_content(self):
2664
2566
        builder = self.get_builder()
2665
 
        builder.build_snapshot(None,
2666
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2667
 
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2668
 
                               revision_id=b'A-id')
2669
 
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
2670
 
        builder.build_snapshot([b'A-id'],
2671
 
                               [('modify', ('foo', b'B content\n'))],
2672
 
                               revision_id=b'B-id')
2673
 
        builder.build_snapshot([b'C-id', b'B-id'],
2674
 
                               [('modify', ('foo', b'B content\n'))],
2675
 
                               revision_id=b'E-id')  # merge the content
2676
 
        builder.build_snapshot([b'E-id'],
2677
 
                               [('modify', ('foo', b'F content\n'))],
2678
 
                               revision_id=b'F-id')  # Override B content
2679
 
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
2680
 
        wt, conflicts = self.do_merge(builder, b'F-id')
 
2567
        builder.build_snapshot('A-id', None,
 
2568
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2569
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2570
        builder.build_snapshot('C-id', ['A-id'], [])
 
2571
        builder.build_snapshot('B-id', ['A-id'],
 
2572
            [('modify', ('foo-id', 'B content\n'))])
 
2573
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2574
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
 
2575
        builder.build_snapshot('F-id', ['E-id'],
 
2576
            [('modify', ('foo-id', 'F content\n'))]) # Override B content
 
2577
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
2578
        wt, conflicts = self.do_merge(builder, 'F-id')
2681
2579
        self.assertEqual(0, conflicts)
2682
 
        self.assertEqual(b'F content\n', wt.get_file_text('foo'))
 
2580
        self.assertEqual('F content\n', wt.get_file_text('foo-id'))
2683
2581
 
2684
2582
    def test_all_wt(self):
2685
2583
        """Check behavior if all trees are Working Trees."""
2692
2590
        #   |X|
2693
2591
        #   D E E updates content, renames 'b' => 'c'
2694
2592
        builder = self.get_builder()
2695
 
        builder.build_snapshot(None,
2696
 
                               [('add', (u'', b'a-root-id', 'directory', None)),
2697
 
                                ('add', (u'a', b'a-id', 'file', b'base content\n')),
2698
 
                                   ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
2699
 
                               revision_id=b'A-id')
2700
 
        builder.build_snapshot([b'A-id'],
2701
 
                               [('modify', ('foo', b'B content\n'))],
2702
 
                               revision_id=b'B-id')
2703
 
        builder.build_snapshot([b'A-id'],
2704
 
                               [('rename', ('a', 'b'))],
2705
 
                               revision_id=b'C-id')
2706
 
        builder.build_snapshot([b'C-id', b'B-id'],
2707
 
                               [('rename', ('b', 'c')),
2708
 
                                ('modify', ('foo', b'E content\n'))],
2709
 
                               revision_id=b'E-id')
2710
 
        builder.build_snapshot([b'B-id', b'C-id'],
2711
 
                               [('rename', ('a', 'b'))], revision_id=b'D-id')  # merged change
 
2593
        builder.build_snapshot('A-id', None,
 
2594
            [('add', (u'', 'a-root-id', 'directory', None)),
 
2595
             ('add', (u'a', 'a-id', 'file', 'base content\n')),
 
2596
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
 
2597
        builder.build_snapshot('B-id', ['A-id'],
 
2598
            [('modify', ('foo-id', 'B content\n'))])
 
2599
        builder.build_snapshot('C-id', ['A-id'],
 
2600
            [('rename', ('a', 'b'))])
 
2601
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
 
2602
            [('rename', ('b', 'c')),
 
2603
             ('modify', ('foo-id', 'E content\n'))])
 
2604
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
 
2605
            [('rename', ('a', 'b'))]) # merged change
2712
2606
        wt_this = self.get_wt_from_builder(builder)
2713
 
        wt_base = wt_this.controldir.sprout('base', b'A-id').open_workingtree()
 
2607
        wt_base = wt_this.bzrdir.sprout('base', 'A-id').open_workingtree()
2714
2608
        wt_base.lock_read()
2715
2609
        self.addCleanup(wt_base.unlock)
2716
 
        wt_lca1 = wt_this.controldir.sprout(
2717
 
            'b-tree', b'B-id').open_workingtree()
 
2610
        wt_lca1 = wt_this.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
2718
2611
        wt_lca1.lock_read()
2719
2612
        self.addCleanup(wt_lca1.unlock)
2720
 
        wt_lca2 = wt_this.controldir.sprout(
2721
 
            'c-tree', b'C-id').open_workingtree()
 
2613
        wt_lca2 = wt_this.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
2722
2614
        wt_lca2.lock_read()
2723
2615
        self.addCleanup(wt_lca2.unlock)
2724
 
        wt_other = wt_this.controldir.sprout(
2725
 
            'other', b'E-id').open_workingtree()
 
2616
        wt_other = wt_this.bzrdir.sprout('other', 'E-id').open_workingtree()
2726
2617
        wt_other.lock_read()
2727
2618
        self.addCleanup(wt_other.unlock)
2728
2619
        merge_obj = _mod_merge.Merge3Merger(wt_this, wt_this, wt_base,
2729
 
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2620
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2730
2621
        entries = list(merge_obj._entries_lca())
2731
 
        root_id = b'a-root-id'
2732
 
        self.assertEqual([(b'a-id', False,
2733
 
                           ((u'a', [u'a', u'b']), u'c', u'b'),
2734
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2735
 
                           ((u'a', [u'a', u'b']), u'c', u'b'),
2736
 
                           ((False, [False, False]), False, False)),
2737
 
                          (b'foo-id', True,
2738
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2739
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2740
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2741
 
                           ((False, [False, False]), False, False)),
2742
 
                          ], entries)
 
2622
        root_id = 'a-root-id'
 
2623
        self.assertEqual([('a-id', False,
 
2624
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2625
                           ((u'a', [u'a', u'b']), u'c', u'b'),
 
2626
                           ((False, [False, False]), False, False)),
 
2627
                          ('foo-id', True,
 
2628
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2629
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2630
                           ((False, [False, False]), False, False)),
 
2631
                         ], entries)
2743
2632
 
2744
2633
    def test_nested_tree_unmodified(self):
2745
2634
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2746
2635
        # 'tree-reference'
2747
2636
        wt = self.make_branch_and_tree('tree',
2748
 
                                       format='development-subtree')
 
2637
            format='development-subtree')
2749
2638
        wt.lock_write()
2750
2639
        self.addCleanup(wt.unlock)
2751
2640
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
2752
 
                                             format='development-subtree')
2753
 
        wt.set_root_id(b'a-root-id')
2754
 
        sub_tree.set_root_id(b'sub-tree-root')
2755
 
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
 
2641
            format='development-subtree')
 
2642
        wt.set_root_id('a-root-id')
 
2643
        sub_tree.set_root_id('sub-tree-root')
 
2644
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
2756
2645
        sub_tree.add('file')
2757
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2646
        sub_tree.commit('foo', rev_id='sub-A-id')
2758
2647
        wt.add_reference(sub_tree)
2759
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2648
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2760
2649
        # Now create a criss-cross merge in the parent, without modifying the
2761
2650
        # subtree
2762
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2763
 
        wt.set_last_revision(b'A-id')
2764
 
        wt.branch.set_last_revision_info(1, b'A-id')
2765
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2766
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2767
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2768
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2769
 
        wt.branch.set_last_revision_info(2, b'B-id')
2770
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2651
        wt.commit('B', rev_id='B-id', recursive=None)
 
2652
        wt.set_last_revision('A-id')
 
2653
        wt.branch.set_last_revision_info(1, 'A-id')
 
2654
        wt.commit('C', rev_id='C-id', recursive=None)
 
2655
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2656
        wt.commit('E', rev_id='E-id', recursive=None)
 
2657
        wt.set_parent_ids(['B-id', 'C-id'])
 
2658
        wt.branch.set_last_revision_info(2, 'B-id')
 
2659
        wt.commit('D', rev_id='D-id', recursive=None)
2771
2660
 
2772
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2661
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2662
            wt, 'E-id')
2773
2663
        merger.merge_type = _mod_merge.Merge3Merger
2774
2664
        merge_obj = merger.make_merger()
2775
2665
        entries = list(merge_obj._entries_lca())
2779
2669
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2780
2670
        # 'tree-reference'
2781
2671
        wt = self.make_branch_and_tree('tree',
2782
 
                                       format='development-subtree')
 
2672
            format='development-subtree')
2783
2673
        wt.lock_write()
2784
2674
        self.addCleanup(wt.unlock)
2785
2675
        sub_tree = self.make_branch_and_tree('tree/sub',
2786
 
                                             format='development-subtree')
2787
 
        wt.set_root_id(b'a-root-id')
2788
 
        sub_tree.set_root_id(b'sub-tree-root')
2789
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2676
            format='development-subtree')
 
2677
        wt.set_root_id('a-root-id')
 
2678
        sub_tree.set_root_id('sub-tree-root')
 
2679
        self.build_tree_contents([('tree/sub/file', 'text1')])
2790
2680
        sub_tree.add('file')
2791
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2681
        sub_tree.commit('foo', rev_id='sub-A-id')
2792
2682
        wt.add_reference(sub_tree)
2793
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2683
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2794
2684
        # Now create a criss-cross merge in the parent, without modifying the
2795
2685
        # subtree
2796
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2797
 
        wt.set_last_revision(b'A-id')
2798
 
        wt.branch.set_last_revision_info(1, b'A-id')
2799
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2800
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2801
 
        self.build_tree_contents([('tree/sub/file', b'text2')])
2802
 
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
2803
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2804
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2805
 
        wt.branch.set_last_revision_info(2, b'B-id')
2806
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2686
        wt.commit('B', rev_id='B-id', recursive=None)
 
2687
        wt.set_last_revision('A-id')
 
2688
        wt.branch.set_last_revision_info(1, 'A-id')
 
2689
        wt.commit('C', rev_id='C-id', recursive=None)
 
2690
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2691
        self.build_tree_contents([('tree/sub/file', 'text2')])
 
2692
        sub_tree.commit('modify contents', rev_id='sub-B-id')
 
2693
        wt.commit('E', rev_id='E-id', recursive=None)
 
2694
        wt.set_parent_ids(['B-id', 'C-id'])
 
2695
        wt.branch.set_last_revision_info(2, 'B-id')
 
2696
        wt.commit('D', rev_id='D-id', recursive=None)
2807
2697
 
2808
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2698
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2699
            wt, 'E-id')
2809
2700
        merger.merge_type = _mod_merge.Merge3Merger
2810
2701
        merge_obj = merger.make_merger()
2811
2702
        entries = list(merge_obj._entries_lca())
2817
2708
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2818
2709
        # 'tree-reference'
2819
2710
        wt = self.make_branch_and_tree('tree',
2820
 
                                       format='development-subtree')
 
2711
            format='development-subtree')
2821
2712
        wt.lock_write()
2822
2713
        self.addCleanup(wt.unlock)
2823
2714
        sub_tree = self.make_branch_and_tree('tree/sub',
2824
 
                                             format='development-subtree')
2825
 
        wt.set_root_id(b'a-root-id')
2826
 
        sub_tree.set_root_id(b'sub-tree-root')
2827
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2715
            format='development-subtree')
 
2716
        wt.set_root_id('a-root-id')
 
2717
        sub_tree.set_root_id('sub-tree-root')
 
2718
        self.build_tree_contents([('tree/sub/file', 'text1')])
2828
2719
        sub_tree.add('file')
2829
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2720
        sub_tree.commit('foo', rev_id='sub-A-id')
2830
2721
        wt.add_reference(sub_tree)
2831
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2722
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2832
2723
        # Now create a criss-cross merge in the parent, without modifying the
2833
2724
        # subtree
2834
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2835
 
        wt.set_last_revision(b'A-id')
2836
 
        wt.branch.set_last_revision_info(1, b'A-id')
2837
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2838
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
 
2725
        wt.commit('B', rev_id='B-id', recursive=None)
 
2726
        wt.set_last_revision('A-id')
 
2727
        wt.branch.set_last_revision_info(1, 'A-id')
 
2728
        wt.commit('C', rev_id='C-id', recursive=None)
 
2729
        wt.merge_from_branch(wt.branch, to_revision='B-id')
2839
2730
        wt.rename_one('sub', 'alt_sub')
2840
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2841
 
        wt.set_last_revision(b'B-id')
 
2731
        wt.commit('E', rev_id='E-id', recursive=None)
 
2732
        wt.set_last_revision('B-id')
2842
2733
        wt.revert()
2843
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2844
 
        wt.branch.set_last_revision_info(2, b'B-id')
2845
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2734
        wt.set_parent_ids(['B-id', 'C-id'])
 
2735
        wt.branch.set_last_revision_info(2, 'B-id')
 
2736
        wt.commit('D', rev_id='D-id', recursive=None)
2846
2737
 
2847
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2738
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2739
            wt, 'E-id')
2848
2740
        merger.merge_type = _mod_merge.Merge3Merger
2849
2741
        merge_obj = merger.make_merger()
2850
2742
        entries = list(merge_obj._entries_lca())
2851
 
        root_id = b'a-root-id'
2852
 
        self.assertEqual([(b'sub-tree-root', False,
2853
 
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
 
2743
        root_id = 'a-root-id'
 
2744
        self.assertEqual([('sub-tree-root', False,
2854
2745
                           ((root_id, [root_id, root_id]), root_id, root_id),
2855
2746
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2856
2747
                           ((False, [False, False]), False, False)),
2857
 
                          ], entries)
 
2748
                         ], entries)
2858
2749
 
2859
2750
    def test_nested_tree_subtree_renamed_and_modified(self):
2860
2751
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2861
2752
        # 'tree-reference'
2862
2753
        wt = self.make_branch_and_tree('tree',
2863
 
                                       format='development-subtree')
 
2754
            format='development-subtree')
2864
2755
        wt.lock_write()
2865
2756
        self.addCleanup(wt.unlock)
2866
2757
        sub_tree = self.make_branch_and_tree('tree/sub',
2867
 
                                             format='development-subtree')
2868
 
        wt.set_root_id(b'a-root-id')
2869
 
        sub_tree.set_root_id(b'sub-tree-root')
2870
 
        self.build_tree_contents([('tree/sub/file', b'text1')])
 
2758
            format='development-subtree')
 
2759
        wt.set_root_id('a-root-id')
 
2760
        sub_tree.set_root_id('sub-tree-root')
 
2761
        self.build_tree_contents([('tree/sub/file', 'text1')])
2871
2762
        sub_tree.add('file')
2872
 
        sub_tree.commit('foo', rev_id=b'sub-A-id')
 
2763
        sub_tree.commit('foo', rev_id='sub-A-id')
2873
2764
        wt.add_reference(sub_tree)
2874
 
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
 
2765
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
2875
2766
        # Now create a criss-cross merge in the parent, without modifying the
2876
2767
        # subtree
2877
 
        wt.commit('B', rev_id=b'B-id', recursive=None)
2878
 
        wt.set_last_revision(b'A-id')
2879
 
        wt.branch.set_last_revision_info(1, b'A-id')
2880
 
        wt.commit('C', rev_id=b'C-id', recursive=None)
2881
 
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2882
 
        self.build_tree_contents([('tree/sub/file', b'text2')])
2883
 
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
 
2768
        wt.commit('B', rev_id='B-id', recursive=None)
 
2769
        wt.set_last_revision('A-id')
 
2770
        wt.branch.set_last_revision_info(1, 'A-id')
 
2771
        wt.commit('C', rev_id='C-id', recursive=None)
 
2772
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2773
        self.build_tree_contents([('tree/sub/file', 'text2')])
 
2774
        sub_tree.commit('modify contents', rev_id='sub-B-id')
2884
2775
        wt.rename_one('sub', 'alt_sub')
2885
 
        wt.commit('E', rev_id=b'E-id', recursive=None)
2886
 
        wt.set_last_revision(b'B-id')
 
2776
        wt.commit('E', rev_id='E-id', recursive=None)
 
2777
        wt.set_last_revision('B-id')
2887
2778
        wt.revert()
2888
 
        wt.set_parent_ids([b'B-id', b'C-id'])
2889
 
        wt.branch.set_last_revision_info(2, b'B-id')
2890
 
        wt.commit('D', rev_id=b'D-id', recursive=None)
 
2779
        wt.set_parent_ids(['B-id', 'C-id'])
 
2780
        wt.branch.set_last_revision_info(2, 'B-id')
 
2781
        wt.commit('D', rev_id='D-id', recursive=None)
2891
2782
 
2892
 
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
 
2783
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2784
            wt, 'E-id')
2893
2785
        merger.merge_type = _mod_merge.Merge3Merger
2894
2786
        merge_obj = merger.make_merger()
2895
2787
        entries = list(merge_obj._entries_lca())
2896
 
        root_id = b'a-root-id'
2897
 
        self.assertEqual([(b'sub-tree-root', False,
2898
 
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
 
2788
        root_id = 'a-root-id'
 
2789
        self.assertEqual([('sub-tree-root', False,
2899
2790
                           ((root_id, [root_id, root_id]), root_id, root_id),
2900
2791
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2901
2792
                           ((False, [False, False]), False, False)),
2902
 
                          ], entries)
 
2793
                         ], entries)
2903
2794
 
2904
2795
 
2905
2796
class TestLCAMultiWay(tests.TestCase):
2907
2798
    def assertLCAMultiWay(self, expected, base, lcas, other, this,
2908
2799
                          allow_overriding_lca=True):
2909
2800
        self.assertEqual(expected, _mod_merge.Merge3Merger._lca_multi_way(
2910
 
            (base, lcas), other, this,
2911
 
            allow_overriding_lca=allow_overriding_lca))
 
2801
                                (base, lcas), other, this,
 
2802
                                allow_overriding_lca=allow_overriding_lca))
2912
2803
 
2913
2804
    def test_other_equal_equal_lcas(self):
2914
2805
        """Test when OTHER=LCA and all LCAs are identical."""
2915
2806
        self.assertLCAMultiWay('this',
2916
 
                               'bval', ['bval', 'bval'], 'bval', 'bval')
2917
 
        self.assertLCAMultiWay('this',
2918
 
                               'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
2919
 
        self.assertLCAMultiWay('this',
2920
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
2921
 
        self.assertLCAMultiWay('this',
2922
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
2923
 
        self.assertLCAMultiWay('this',
2924
 
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
 
2807
            'bval', ['bval', 'bval'], 'bval', 'bval')
 
2808
        self.assertLCAMultiWay('this',
 
2809
            'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
 
2810
        self.assertLCAMultiWay('this',
 
2811
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
 
2812
        self.assertLCAMultiWay('this',
 
2813
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
 
2814
        self.assertLCAMultiWay('this',
 
2815
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
2925
2816
 
2926
2817
    def test_other_equal_this(self):
2927
2818
        """Test when other and this are identical."""
2928
2819
        self.assertLCAMultiWay('this',
2929
 
                               'bval', ['bval', 'bval'], 'oval', 'oval')
2930
 
        self.assertLCAMultiWay('this',
2931
 
                               'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
2932
 
        self.assertLCAMultiWay('this',
2933
 
                               'bval', ['cval', 'dval'], 'oval', 'oval')
2934
 
        self.assertLCAMultiWay('this',
2935
 
                               'bval', [None, 'lcaval'], 'oval', 'oval')
2936
 
        self.assertLCAMultiWay('this',
2937
 
                               None, [None, 'lcaval'], 'oval', 'oval')
2938
 
        self.assertLCAMultiWay('this',
2939
 
                               None, ['lcaval', 'lcaval'], 'oval', 'oval')
2940
 
        self.assertLCAMultiWay('this',
2941
 
                               None, ['cval', 'dval'], 'oval', 'oval')
2942
 
        self.assertLCAMultiWay('this',
2943
 
                               None, ['cval', 'dval'], None, None)
2944
 
        self.assertLCAMultiWay('this',
2945
 
                               None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
 
2820
            'bval', ['bval', 'bval'], 'oval', 'oval')
 
2821
        self.assertLCAMultiWay('this',
 
2822
            'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
 
2823
        self.assertLCAMultiWay('this',
 
2824
            'bval', ['cval', 'dval'], 'oval', 'oval')
 
2825
        self.assertLCAMultiWay('this',
 
2826
            'bval', [None, 'lcaval'], 'oval', 'oval')
 
2827
        self.assertLCAMultiWay('this',
 
2828
            None, [None, 'lcaval'], 'oval', 'oval')
 
2829
        self.assertLCAMultiWay('this',
 
2830
            None, ['lcaval', 'lcaval'], 'oval', 'oval')
 
2831
        self.assertLCAMultiWay('this',
 
2832
            None, ['cval', 'dval'], 'oval', 'oval')
 
2833
        self.assertLCAMultiWay('this',
 
2834
            None, ['cval', 'dval'], None, None)
 
2835
        self.assertLCAMultiWay('this',
 
2836
            None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
2946
2837
 
2947
2838
    def test_no_lcas(self):
2948
2839
        self.assertLCAMultiWay('this',
2949
 
                               'bval', [], 'bval', 'tval')
 
2840
            'bval', [], 'bval', 'tval')
2950
2841
        self.assertLCAMultiWay('other',
2951
 
                               'bval', [], 'oval', 'bval')
 
2842
            'bval', [], 'oval', 'bval')
2952
2843
        self.assertLCAMultiWay('conflict',
2953
 
                               'bval', [], 'oval', 'tval')
 
2844
            'bval', [], 'oval', 'tval')
2954
2845
        self.assertLCAMultiWay('this',
2955
 
                               'bval', [], 'oval', 'oval')
 
2846
            'bval', [], 'oval', 'oval')
2956
2847
 
2957
2848
    def test_lca_supersedes_other_lca(self):
2958
2849
        """If one lca == base, the other lca takes precedence"""
2959
2850
        self.assertLCAMultiWay('this',
2960
 
                               'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
 
2851
            'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
2961
2852
        self.assertLCAMultiWay('this',
2962
 
                               'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
 
2853
            'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
2963
2854
        # This is actually considered a 'revert' because the 'lcaval' in LCAS
2964
2855
        # supersedes the BASE val (in the other LCA) but then OTHER reverts it
2965
2856
        # back to bval.
2966
2857
        self.assertLCAMultiWay('other',
2967
 
                               'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
 
2858
            'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
2968
2859
        self.assertLCAMultiWay('conflict',
2969
 
                               'bval', ['bval', 'lcaval'], 'bval', 'tval')
 
2860
            'bval', ['bval', 'lcaval'], 'bval', 'tval')
2970
2861
 
2971
2862
    def test_other_and_this_pick_different_lca(self):
2972
2863
        # OTHER and THIS resolve the lca conflict in different ways
2973
2864
        self.assertLCAMultiWay('conflict',
2974
 
                               'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
2975
 
        self.assertLCAMultiWay('conflict',
2976
 
                               'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
2977
 
        self.assertLCAMultiWay('conflict',
2978
 
                               'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
 
2865
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
 
2866
        self.assertLCAMultiWay('conflict',
 
2867
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
 
2868
        self.assertLCAMultiWay('conflict',
 
2869
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
2979
2870
 
2980
2871
    def test_other_in_lca(self):
2981
2872
        # OTHER takes a value of one of the LCAs, THIS takes a new value, which
2982
2873
        # theoretically supersedes both LCA values and 'wins'
2983
 
        self.assertLCAMultiWay(
2984
 
            'this', 'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
2985
 
        self.assertLCAMultiWay(
2986
 
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
2987
 
            'newval')
2988
 
        self.assertLCAMultiWay('conflict',
2989
 
                               'bval', ['lca1val',
2990
 
                                        'lca2val'], 'lca1val', 'newval',
2991
 
                               allow_overriding_lca=False)
2992
 
        self.assertLCAMultiWay('conflict',
2993
 
                               'bval', ['lca1val', 'lca2val',
2994
 
                                        'lca3val'], 'lca1val', 'newval',
2995
 
                               allow_overriding_lca=False)
 
2874
        self.assertLCAMultiWay('this',
 
2875
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
 
2876
        self.assertLCAMultiWay('this',
 
2877
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval')
 
2878
        self.assertLCAMultiWay('conflict',
 
2879
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval',
 
2880
            allow_overriding_lca=False)
 
2881
        self.assertLCAMultiWay('conflict',
 
2882
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval',
 
2883
            allow_overriding_lca=False)
2996
2884
        # THIS reverted back to BASE, but that is an explicit supersede of all
2997
2885
        # LCAs
2998
 
        self.assertLCAMultiWay(
2999
 
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
3000
 
            'bval')
3001
 
        self.assertLCAMultiWay(
3002
 
            'this', 'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
3003
 
        self.assertLCAMultiWay('conflict',
3004
 
                               'bval', ['lca1val', 'lca2val',
3005
 
                                        'lca3val'], 'lca1val', 'bval',
3006
 
                               allow_overriding_lca=False)
3007
 
        self.assertLCAMultiWay('conflict',
3008
 
                               'bval', ['lca1val', 'lca2val',
3009
 
                                        'bval'], 'lca1val', 'bval',
3010
 
                               allow_overriding_lca=False)
 
2886
        self.assertLCAMultiWay('this',
 
2887
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval')
 
2888
        self.assertLCAMultiWay('this',
 
2889
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
 
2890
        self.assertLCAMultiWay('conflict',
 
2891
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval',
 
2892
            allow_overriding_lca=False)
 
2893
        self.assertLCAMultiWay('conflict',
 
2894
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval',
 
2895
            allow_overriding_lca=False)
3011
2896
 
3012
2897
    def test_this_in_lca(self):
3013
2898
        # THIS takes a value of one of the LCAs, OTHER takes a new value, which
3014
2899
        # theoretically supersedes both LCA values and 'wins'
3015
 
        self.assertLCAMultiWay(
3016
 
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
3017
 
        self.assertLCAMultiWay(
3018
 
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
3019
 
        self.assertLCAMultiWay('conflict',
3020
 
                               'bval', ['lca1val',
3021
 
                                        'lca2val'], 'oval', 'lca1val',
3022
 
                               allow_overriding_lca=False)
3023
 
        self.assertLCAMultiWay('conflict',
3024
 
                               'bval', ['lca1val',
3025
 
                                        'lca2val'], 'oval', 'lca2val',
3026
 
                               allow_overriding_lca=False)
 
2900
        self.assertLCAMultiWay('other',
 
2901
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
 
2902
        self.assertLCAMultiWay('other',
 
2903
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
 
2904
        self.assertLCAMultiWay('conflict',
 
2905
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val',
 
2906
            allow_overriding_lca=False)
 
2907
        self.assertLCAMultiWay('conflict',
 
2908
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val',
 
2909
            allow_overriding_lca=False)
3027
2910
        # OTHER reverted back to BASE, but that is an explicit supersede of all
3028
2911
        # LCAs
3029
 
        self.assertLCAMultiWay(
3030
 
            'other', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval',
3031
 
            'lca3val')
3032
 
        self.assertLCAMultiWay(
3033
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'],
3034
 
            'bval', 'lca3val', allow_overriding_lca=False)
 
2912
        self.assertLCAMultiWay('other',
 
2913
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val')
 
2914
        self.assertLCAMultiWay('conflict',
 
2915
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val',
 
2916
            allow_overriding_lca=False)
3035
2917
 
3036
2918
    def test_all_differ(self):
3037
 
        self.assertLCAMultiWay(
3038
 
            'conflict', 'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
3039
 
        self.assertLCAMultiWay(
3040
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval',
3041
 
            'tval')
3042
 
        self.assertLCAMultiWay(
3043
 
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval',
3044
 
            'tval')
 
2919
        self.assertLCAMultiWay('conflict',
 
2920
            'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
 
2921
        self.assertLCAMultiWay('conflict',
 
2922
            'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval', 'tval')
 
2923
        self.assertLCAMultiWay('conflict',
 
2924
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval', 'tval')
3045
2925
 
3046
2926
 
3047
2927
class TestConfigurableFileMerger(tests.TestCaseWithTransport):
3085
2965
        factory = self.get_merger_factory()
3086
2966
        self._install_hook(factory)
3087
2967
        builder = self.make_builder()
3088
 
        builder.add_file(b'bar-id', builder.tree_root,
3089
 
                         file_name, b'text1', True)
3090
 
        builder.change_contents(b'bar-id', other=b'text4', this=b'text3')
 
2968
        builder.add_file('bar-id', builder.tree_root, file_name, 'text1', True)
 
2969
        builder.change_contents('bar-id', other='text4', this='text3')
3091
2970
        return builder
3092
2971
 
3093
2972
    def make_kind_change(self):
3094
2973
        factory = self.get_merger_factory()
3095
2974
        self._install_hook(factory)
3096
2975
        builder = self.make_builder()
3097
 
        builder.add_file(b'bar-id', builder.tree_root, 'bar', b'text1', True,
 
2976
        builder.add_file('bar-id', builder.tree_root, 'bar', 'text1', True,
3098
2977
                         this=False)
3099
 
        builder.add_dir(b'bar-dir', builder.tree_root, 'bar-id',
 
2978
        builder.add_dir('bar-dir', builder.tree_root, 'bar-id',
3100
2979
                        base=False, other=False)
3101
2980
        return builder
3102
2981
 
3103
2982
    def test_uses_this_branch(self):
3104
2983
        builder = self.make_text_conflict()
3105
 
        with builder.make_preview_transform() as tt:
3106
 
            pass
 
2984
        tt = builder.make_preview_transform()
 
2985
        self.addCleanup(tt.finalize)
3107
2986
 
3108
2987
    def test_affected_files_cached(self):
3109
2988
        """Ensures that the config variable is cached"""
3115
2994
 
3116
2995
    def test_hook_called_for_text_conflicts(self):
3117
2996
        builder = self.make_text_conflict()
3118
 
        builder.merge()
 
2997
        conflicts = builder.merge()
3119
2998
        # The hook should call the merge_text() method
3120
2999
        self.assertEqual(['merge_text'], self.calls)
3121
3000
 
3122
3001
    def test_hook_not_called_for_kind_change(self):
3123
3002
        builder = self.make_kind_change()
3124
 
        builder.merge()
 
3003
        conflicts = builder.merge()
3125
3004
        # The hook should not call the merge_text() method
3126
3005
        self.assertEqual([], self.calls)
3127
3006
 
3128
3007
    def test_hook_not_called_for_other_files(self):
3129
3008
        builder = self.make_text_conflict('foobar')
3130
 
        builder.merge()
 
3009
        conflicts = builder.merge()
3131
3010
        # The hook should not call the merge_text() method
3132
3011
        self.assertEqual([], self.calls)
3133
3012
 
3136
3015
 
3137
3016
    def setup_simple_branch(self, relpath, shape=None, root_id=None):
3138
3017
        """One commit, containing tree specified by optional shape.
3139
 
 
 
3018
        
3140
3019
        Default is empty tree (just root entry).
3141
3020
        """
3142
3021
        if root_id is None:
3143
 
            root_id = b'%s-root-id' % (relpath.encode('ascii'),)
 
3022
            root_id = '%s-root-id' % (relpath,)
3144
3023
        wt = self.make_branch_and_tree(relpath)
3145
3024
        wt.set_root_id(root_id)
3146
3025
        if shape is not None:
3147
3026
            adjusted_shape = [relpath + '/' + elem for elem in shape]
3148
3027
            self.build_tree(adjusted_shape)
3149
 
            ids = [
3150
 
                (b'%s-%s-id' % (relpath.encode('utf-8'),
3151
 
                                basename(elem.rstrip('/')).encode('ascii')))
3152
 
                for elem in shape]
 
3028
            ids = ['%s-%s-id' % (relpath, basename(elem.rstrip('/')))
 
3029
                   for elem in shape]
3153
3030
            wt.add(shape, ids=ids)
3154
 
        rev_id = b'r1-%s' % (relpath.encode('utf-8'),)
 
3031
        rev_id = 'r1-%s' % (relpath,)
3155
3032
        wt.commit("Initial commit of %s" % (relpath,), rev_id=rev_id)
3156
3033
        self.assertEqual(root_id, wt.path2id(''))
3157
3034
        return wt
3172
3049
 
3173
3050
    def do_merge_into(self, location, merge_as):
3174
3051
        """Helper for using MergeIntoMerger.
3175
 
 
 
3052
        
3176
3053
        :param location: location of directory to merge from, either the
3177
3054
            location of a branch or of a path inside a branch.
3178
3055
        :param merge_as: the path in a tree to add the new directory as.
3179
3056
        :returns: the conflicts from 'do_merge'.
3180
3057
        """
3181
 
        with contextlib.ExitStack() as stack:
3182
 
            # Open and lock the various tree and branch objects
3183
 
            wt, subdir_relpath = WorkingTree.open_containing(merge_as)
3184
 
            stack.enter_context(wt.lock_write())
3185
 
            branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
3186
 
                location)
3187
 
            stack.enter_context(branch_to_merge.lock_read())
3188
 
            other_tree = branch_to_merge.basis_tree()
3189
 
            stack.enter_context(other_tree.lock_read())
3190
 
            # Perform the merge
3191
 
            merger = _mod_merge.MergeIntoMerger(
3192
 
                this_tree=wt, other_tree=other_tree, other_branch=branch_to_merge,
3193
 
                target_subdir=subdir_relpath, source_subpath=subdir_to_merge)
3194
 
            merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
3195
 
            conflicts = merger.do_merge()
3196
 
            merger.set_pending()
3197
 
            return conflicts
 
3058
        operation = cleanup.OperationWithCleanups(self._merge_into)
 
3059
        return operation.run(location, merge_as)
 
3060
 
 
3061
    def _merge_into(self, op, location, merge_as):
 
3062
        # Open and lock the various tree and branch objects
 
3063
        wt, subdir_relpath = WorkingTree.open_containing(merge_as)
 
3064
        op.add_cleanup(wt.lock_write().unlock)
 
3065
        branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
 
3066
            location)
 
3067
        op.add_cleanup(branch_to_merge.lock_read().unlock)
 
3068
        other_tree = branch_to_merge.basis_tree()
 
3069
        op.add_cleanup(other_tree.lock_read().unlock)
 
3070
        # Perform the merge
 
3071
        merger = _mod_merge.MergeIntoMerger(this_tree=wt, other_tree=other_tree,
 
3072
            other_branch=branch_to_merge, target_subdir=subdir_relpath,
 
3073
            source_subpath=subdir_to_merge)
 
3074
        merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
 
3075
        conflicts = merger.do_merge()
 
3076
        merger.set_pending()
 
3077
        return conflicts
3198
3078
 
3199
3079
    def assertTreeEntriesEqual(self, expected_entries, tree):
3200
3080
        """Assert that 'tree' contains the expected inventory entries.
3214
3094
        project_wt.lock_read()
3215
3095
        self.addCleanup(project_wt.unlock)
3216
3096
        # The r1-lib1 revision should be merged into this one
3217
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3218
 
                         project_wt.get_parent_ids())
 
3097
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3219
3098
        self.assertTreeEntriesEqual(
3220
 
            [('', b'project-root-id'),
3221
 
             ('README', b'project-README-id'),
3222
 
             ('dir', b'project-dir-id'),
3223
 
             ('lib1', b'lib1-root-id'),
3224
 
             ('dir/file.c', b'project-file.c-id'),
3225
 
             ('lib1/Makefile', b'lib1-Makefile-id'),
3226
 
             ('lib1/README', b'lib1-README-id'),
3227
 
             ('lib1/foo.c', b'lib1-foo.c-id'),
3228
 
             ], project_wt)
 
3099
            [('', 'project-root-id'),
 
3100
             ('README', 'project-README-id'),
 
3101
             ('dir', 'project-dir-id'),
 
3102
             ('lib1', 'lib1-root-id'),
 
3103
             ('dir/file.c', 'project-file.c-id'),
 
3104
             ('lib1/Makefile', 'lib1-Makefile-id'),
 
3105
             ('lib1/README', 'lib1-README-id'),
 
3106
             ('lib1/foo.c', 'lib1-foo.c-id'),
 
3107
            ], project_wt)
3229
3108
 
3230
3109
    def test_subdir(self):
3231
3110
        """Merge a branch into a subdirectory of an existing directory."""
3234
3113
        project_wt.lock_read()
3235
3114
        self.addCleanup(project_wt.unlock)
3236
3115
        # The r1-lib1 revision should be merged into this one
3237
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3238
 
                         project_wt.get_parent_ids())
 
3116
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3239
3117
        self.assertTreeEntriesEqual(
3240
 
            [('', b'project-root-id'),
3241
 
             ('README', b'project-README-id'),
3242
 
             ('dir', b'project-dir-id'),
3243
 
             ('dir/file.c', b'project-file.c-id'),
3244
 
             ('dir/lib1', b'lib1-root-id'),
3245
 
             ('dir/lib1/Makefile', b'lib1-Makefile-id'),
3246
 
             ('dir/lib1/README', b'lib1-README-id'),
3247
 
             ('dir/lib1/foo.c', b'lib1-foo.c-id'),
3248
 
             ], project_wt)
 
3118
            [('', 'project-root-id'),
 
3119
             ('README', 'project-README-id'),
 
3120
             ('dir', 'project-dir-id'),
 
3121
             ('dir/file.c', 'project-file.c-id'),
 
3122
             ('dir/lib1', 'lib1-root-id'),
 
3123
             ('dir/lib1/Makefile', 'lib1-Makefile-id'),
 
3124
             ('dir/lib1/README', 'lib1-README-id'),
 
3125
             ('dir/lib1/foo.c', 'lib1-foo.c-id'),
 
3126
            ], project_wt)
3249
3127
 
3250
3128
    def test_newdir_with_repeat_roots(self):
3251
3129
        """If the file-id of the dir to be merged already exists a new ID will
3257
3135
        project_wt.lock_read()
3258
3136
        self.addCleanup(project_wt.unlock)
3259
3137
        # The r1-lib1 revision should be merged into this one
3260
 
        self.assertEqual([b'r1-project', b'r1-lib1'],
3261
 
                         project_wt.get_parent_ids())
 
3138
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
3262
3139
        new_lib1_id = project_wt.path2id('lib1')
3263
3140
        self.assertNotEqual(None, new_lib1_id)
3264
3141
        self.assertTreeEntriesEqual(
3265
3142
            [('', root_id),
3266
 
             ('README', b'project-README-id'),
3267
 
             ('dir', b'project-dir-id'),
 
3143
             ('README', 'project-README-id'),
 
3144
             ('dir', 'project-dir-id'),
3268
3145
             ('lib1', new_lib1_id),
3269
 
             ('dir/file.c', b'project-file.c-id'),
3270
 
             ('lib1/Makefile', b'lib1-Makefile-id'),
3271
 
             ('lib1/README', b'lib1-README-id'),
3272
 
             ('lib1/foo.c', b'lib1-foo.c-id'),
3273
 
             ], project_wt)
 
3146
             ('dir/file.c', 'project-file.c-id'),
 
3147
             ('lib1/Makefile', 'lib1-Makefile-id'),
 
3148
             ('lib1/README', 'lib1-README-id'),
 
3149
             ('lib1/foo.c', 'lib1-foo.c-id'),
 
3150
            ], project_wt)
3274
3151
 
3275
3152
    def test_name_conflict(self):
3276
3153
        """When the target directory name already exists a conflict is
3277
3154
        generated and the original directory is renamed to foo.moved.
3278
3155
        """
3279
3156
        dest_wt = self.setup_simple_branch('dest', ['dir/', 'dir/file.txt'])
3280
 
        self.setup_simple_branch('src', ['README'])
 
3157
        src_wt = self.setup_simple_branch('src', ['README'])
3281
3158
        conflicts = self.do_merge_into('src', 'dest/dir')
3282
3159
        self.assertEqual(1, conflicts)
3283
3160
        dest_wt.lock_read()
3284
3161
        self.addCleanup(dest_wt.unlock)
3285
3162
        # The r1-lib1 revision should be merged into this one
3286
 
        self.assertEqual([b'r1-dest', b'r1-src'], dest_wt.get_parent_ids())
 
3163
        self.assertEqual(['r1-dest', 'r1-src'], dest_wt.get_parent_ids())
3287
3164
        self.assertTreeEntriesEqual(
3288
 
            [('', b'dest-root-id'),
3289
 
             ('dir', b'src-root-id'),
3290
 
             ('dir.moved', b'dest-dir-id'),
3291
 
             ('dir/README', b'src-README-id'),
3292
 
             ('dir.moved/file.txt', b'dest-file.txt-id'),
3293
 
             ], dest_wt)
 
3165
            [('', 'dest-root-id'),
 
3166
             ('dir', 'src-root-id'),
 
3167
             ('dir.moved', 'dest-dir-id'),
 
3168
             ('dir/README', 'src-README-id'),
 
3169
             ('dir.moved/file.txt', 'dest-file.txt-id'),
 
3170
            ], dest_wt)
3294
3171
 
3295
3172
    def test_file_id_conflict(self):
3296
3173
        """A conflict is generated if the merge-into adds a file (or other
3297
3174
        inventory entry) with a file-id that already exists in the target tree.
3298
3175
        """
3299
 
        self.setup_simple_branch('dest', ['file.txt'])
 
3176
        dest_wt = self.setup_simple_branch('dest', ['file.txt'])
3300
3177
        # Make a second tree with a file-id that will clash with file.txt in
3301
3178
        # dest.
3302
3179
        src_wt = self.make_branch_and_tree('src')
3303
3180
        self.build_tree(['src/README'])
3304
 
        src_wt.add(['README'], ids=[b'dest-file.txt-id'])
3305
 
        src_wt.commit("Rev 1 of src.", rev_id=b'r1-src')
 
3181
        src_wt.add(['README'], ids=['dest-file.txt-id'])
 
3182
        src_wt.commit("Rev 1 of src.", rev_id='r1-src')
3306
3183
        conflicts = self.do_merge_into('src', 'dest/dir')
3307
3184
        # This is an edge case that shouldn't happen to users very often.  So
3308
3185
        # we don't care really about the exact presentation of the conflict,
3314
3191
        subtree.
3315
3192
        """
3316
3193
        dest_wt = self.setup_simple_branch('dest')
3317
 
        self.setup_simple_branch('src', ['hello.txt', 'dir/', 'dir/foo.c'])
3318
 
        self.do_merge_into('src/dir', 'dest/dir')
 
3194
        src_wt = self.setup_simple_branch(
 
3195
            'src', ['hello.txt', 'dir/', 'dir/foo.c'])
 
3196
        conflicts = self.do_merge_into('src/dir', 'dest/dir')
3319
3197
        dest_wt.lock_read()
3320
3198
        self.addCleanup(dest_wt.unlock)
3321
3199
        # The r1-lib1 revision should NOT be merged into this one (this is a
3322
3200
        # partial merge).
3323
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
 
3201
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3324
3202
        self.assertTreeEntriesEqual(
3325
 
            [('', b'dest-root-id'),
3326
 
             ('dir', b'src-dir-id'),
3327
 
             ('dir/foo.c', b'src-foo.c-id'),
3328
 
             ], dest_wt)
 
3203
            [('', 'dest-root-id'),
 
3204
             ('dir', 'src-dir-id'),
 
3205
             ('dir/foo.c', 'src-foo.c-id'),
 
3206
            ], dest_wt)
3329
3207
 
3330
3208
    def test_only_file(self):
3331
3209
        """An edge case: merge just one file, not a whole dir."""
3332
3210
        dest_wt = self.setup_simple_branch('dest')
3333
 
        self.setup_simple_branch('two-file', ['file1.txt', 'file2.txt'])
3334
 
        self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
 
3211
        two_file_wt = self.setup_simple_branch(
 
3212
            'two-file', ['file1.txt', 'file2.txt'])
 
3213
        conflicts = self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
3335
3214
        dest_wt.lock_read()
3336
3215
        self.addCleanup(dest_wt.unlock)
3337
3216
        # The r1-lib1 revision should NOT be merged into this one
3338
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
 
3217
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3339
3218
        self.assertTreeEntriesEqual(
3340
 
            [('', b'dest-root-id'), ('file1.txt', b'two-file-file1.txt-id')],
 
3219
            [('', 'dest-root-id'), ('file1.txt', 'two-file-file1.txt-id')],
3341
3220
            dest_wt)
3342
3221
 
3343
3222
    def test_no_such_source_path(self):
3345
3224
        does not exist.
3346
3225
        """
3347
3226
        dest_wt = self.setup_simple_branch('dest')
3348
 
        self.setup_simple_branch('src', ['dir/'])
 
3227
        two_file_wt = self.setup_simple_branch('src', ['dir/'])
3349
3228
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3350
 
                          'src/no-such-dir', 'dest/foo')
 
3229
            'src/no-such-dir', 'dest/foo')
3351
3230
        dest_wt.lock_read()
3352
3231
        self.addCleanup(dest_wt.unlock)
3353
3232
        # The dest tree is unmodified.
3354
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3355
 
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
 
3233
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
 
3234
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
3356
3235
 
3357
3236
    def test_no_such_target_path(self):
3358
3237
        """PathNotInTree is also raised if the specified path in the target
3359
3238
        tree does not exist.
3360
3239
        """
3361
3240
        dest_wt = self.setup_simple_branch('dest')
3362
 
        self.setup_simple_branch('src', ['file.txt'])
 
3241
        two_file_wt = self.setup_simple_branch('src', ['file.txt'])
3363
3242
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3364
 
                          'src', 'dest/no-such-dir/foo')
 
3243
            'src', 'dest/no-such-dir/foo')
3365
3244
        dest_wt.lock_read()
3366
3245
        self.addCleanup(dest_wt.unlock)
3367
3246
        # The dest tree is unmodified.
3368
 
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3369
 
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
 
3247
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
 
3248
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
3370
3249
 
3371
3250
 
3372
3251
class TestMergeHooks(TestCaseWithTransport):
3374
3253
    def setUp(self):
3375
3254
        super(TestMergeHooks, self).setUp()
3376
3255
        self.tree_a = self.make_branch_and_tree('tree_a')
3377
 
        self.build_tree_contents([('tree_a/file', b'content_1')])
3378
 
        self.tree_a.add('file', b'file-id')
 
3256
        self.build_tree_contents([('tree_a/file', 'content_1')])
 
3257
        self.tree_a.add('file', 'file-id')
3379
3258
        self.tree_a.commit('added file')
3380
3259
 
3381
 
        self.tree_b = self.tree_a.controldir.sprout(
3382
 
            'tree_b').open_workingtree()
3383
 
        self.build_tree_contents([('tree_b/file', b'content_2')])
 
3260
        self.tree_b = self.tree_a.bzrdir.sprout('tree_b').open_workingtree()
 
3261
        self.build_tree_contents([('tree_b/file', 'content_2')])
3384
3262
        self.tree_b.commit('modify file')
3385
3263
 
3386
3264
    def test_pre_merge_hook_inject_different_tree(self):
3387
 
        tree_c = self.tree_b.controldir.sprout('tree_c').open_workingtree()
3388
 
        self.build_tree_contents([('tree_c/file', b'content_3')])
 
3265
        tree_c = self.tree_b.bzrdir.sprout('tree_c').open_workingtree()
 
3266
        self.build_tree_contents([('tree_c/file', 'content_3')])
3389
3267
        tree_c.commit("more content")
3390
3268
        calls = []
3391
 
 
3392
3269
        def factory(merger):
3393
3270
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3394
3271
            merger.other_tree = tree_c
3397
3274
                                                   factory, 'test factory')
3398
3275
        self.tree_a.merge_from_branch(self.tree_b.branch)
3399
3276
 
3400
 
        self.assertFileEqual(b"content_3", 'tree_a/file')
 
3277
        self.assertFileEqual("content_3", 'tree_a/file')
3401
3278
        self.assertLength(1, calls)
3402
3279
 
3403
3280
    def test_post_merge_hook_called(self):
3404
3281
        calls = []
3405
 
 
3406
3282
        def factory(merger):
3407
3283
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3408
3284
            calls.append(merger)
3411
3287
 
3412
3288
        self.tree_a.merge_from_branch(self.tree_b.branch)
3413
3289
 
3414
 
        self.assertFileEqual(b"content_2", 'tree_a/file')
 
3290
        self.assertFileEqual("content_2", 'tree_a/file')
3415
3291
        self.assertLength(1, calls)