/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to breezy/tests/test_bundle.py

  • Committer: Jelmer Vernooij
  • Date: 2017-08-27 13:57:26 UTC
  • mto: This revision was merged to the branch mainline in revision 6773.
  • Revision ID: jelmer@jelmer.uk-20170827135726-o6k0a4j205zdh8k0
Fix some tests.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2013, 2016 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from cStringIO import StringIO
18
17
import os
19
 
import socket
 
18
try:
 
19
    import socketserver
 
20
except ImportError:
 
21
    import SocketServer as socketserver
20
22
import sys
21
 
import threading
22
23
 
23
 
from bzrlib import (
24
 
    bzrdir,
 
24
from .. import (
25
25
    diff,
26
26
    errors,
27
 
    inventory,
28
27
    merge,
29
28
    osutils,
30
 
    repository,
31
29
    revision as _mod_revision,
32
30
    tests,
33
31
    treebuilder,
34
32
    )
35
 
from bzrlib.bundle import read_mergeable_from_url
36
 
from bzrlib.bundle.apply_bundle import install_bundle, merge_bundle
37
 
from bzrlib.bundle.bundle_data import BundleTree
38
 
from bzrlib.bzrdir import BzrDir
39
 
from bzrlib.directory_service import directories
40
 
from bzrlib.bundle.serializer import write_bundle, read_bundle, v09, v4
41
 
from bzrlib.bundle.serializer.v08 import BundleSerializerV08
42
 
from bzrlib.bundle.serializer.v09 import BundleSerializerV09
43
 
from bzrlib.bundle.serializer.v4 import BundleSerializerV4
44
 
from bzrlib.branch import Branch
45
 
from bzrlib.repofmt import knitrepo
46
 
from bzrlib.tests import (
 
33
from ..bzr import (
 
34
    bzrdir,
 
35
    inventory,
 
36
    )
 
37
from ..bundle import read_mergeable_from_url
 
38
from ..bundle.apply_bundle import install_bundle, merge_bundle
 
39
from ..bundle.bundle_data import BundleTree
 
40
from ..directory_service import directories
 
41
from ..bundle.serializer import write_bundle, read_bundle, v09, v4
 
42
from ..bundle.serializer.v08 import BundleSerializerV08
 
43
from ..bundle.serializer.v09 import BundleSerializerV09
 
44
from ..bundle.serializer.v4 import BundleSerializerV4
 
45
from ..bzr import knitrepo
 
46
from ..sixish import (
 
47
    BytesIO,
 
48
    )
 
49
from . import (
 
50
    features,
 
51
    test_commit,
47
52
    test_read_bundle,
48
 
    test_commit,
 
53
    test_server,
49
54
    )
50
 
from bzrlib.transform import TreeTransform
 
55
from ..transform import TreeTransform
51
56
 
52
57
 
53
58
def get_text(vf, key):
54
59
    """Get the fulltext for a given revision id that is present in the vf"""
55
60
    stream = vf.get_record_stream([key], 'unordered', True)
56
 
    record = stream.next()
 
61
    record = next(stream)
57
62
    return record.get_bytes_as('fulltext')
58
63
 
59
64
 
67
72
 
68
73
 
69
74
class MockTree(object):
 
75
 
70
76
    def __init__(self):
71
 
        from bzrlib.inventory import InventoryDirectory, ROOT_ID
 
77
        from ..bzr.inventory import InventoryDirectory, ROOT_ID
72
78
        object.__init__(self)
73
79
        self.paths = {ROOT_ID: ""}
74
80
        self.ids = {"": ROOT_ID}
76
82
        self.root = InventoryDirectory(ROOT_ID, '', None)
77
83
 
78
84
    inventory = property(lambda x:x)
79
 
 
80
 
    def __iter__(self):
81
 
        return self.paths.iterkeys()
 
85
    root_inventory = property(lambda x:x)
 
86
 
 
87
    def get_root_id(self):
 
88
        return self.root.file_id
 
89
 
 
90
    def all_file_ids(self):
 
91
        return set(self.paths.keys())
 
92
 
 
93
    def is_executable(self, file_id):
 
94
        # Not all the files are executable.
 
95
        return False
82
96
 
83
97
    def __getitem__(self, file_id):
84
98
        if file_id == self.root.file_id:
93
107
        return self.ids[parent_dir]
94
108
 
95
109
    def iter_entries(self):
96
 
        for path, file_id in self.ids.iteritems():
 
110
        for path, file_id in self.ids.items():
97
111
            yield path, self[file_id]
98
112
 
99
 
    def get_file_kind(self, file_id):
 
113
    def kind(self, file_id):
100
114
        if file_id in self.contents:
101
115
            kind = 'file'
102
116
        else:
104
118
        return kind
105
119
 
106
120
    def make_entry(self, file_id, path):
107
 
        from bzrlib.inventory import (InventoryEntry, InventoryFile
108
 
                                    , InventoryDirectory, InventoryLink)
 
121
        from ..bzr.inventory import (InventoryFile , InventoryDirectory,
 
122
            InventoryLink)
109
123
        name = os.path.basename(path)
110
 
        kind = self.get_file_kind(file_id)
 
124
        kind = self.kind(file_id)
111
125
        parent_id = self.parent_id(file_id)
112
126
        text_sha_1, text_size = self.contents_stats(file_id)
113
127
        if kind == 'directory':
114
128
            ie = InventoryDirectory(file_id, name, parent_id)
115
129
        elif kind == 'file':
116
130
            ie = InventoryFile(file_id, name, parent_id)
 
131
            ie.text_sha1 = text_sha_1
 
132
            ie.text_size = text_size
117
133
        elif kind == 'symlink':
118
134
            ie = InventoryLink(file_id, name, parent_id)
119
135
        else:
120
136
            raise errors.BzrError('unknown kind %r' % kind)
121
 
        ie.text_sha1 = text_sha_1
122
 
        ie.text_size = text_size
123
137
        return ie
124
138
 
125
139
    def add_dir(self, file_id, path):
140
154
        return self.id2path(file_id) is not None
141
155
 
142
156
    def get_file(self, file_id):
143
 
        result = StringIO()
 
157
        result = BytesIO()
144
158
        result.write(self.contents[file_id])
145
159
        result.seek(0,0)
146
160
        return result
147
161
 
 
162
    def get_file_revision(self, file_id):
 
163
        return self.inventory[file_id].revision
 
164
 
 
165
    def get_file_size(self, file_id):
 
166
        return self.inventory[file_id].text_size
 
167
 
 
168
    def get_file_sha1(self, file_id):
 
169
        return self.inventory[file_id].text_sha1
 
170
 
148
171
    def contents_stats(self, file_id):
149
172
        if file_id not in self.contents:
150
173
            return None, None
235
258
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
236
259
 
237
260
    def unified_diff(self, old, new):
238
 
        out = StringIO()
 
261
        out = BytesIO()
239
262
        diff.internal_diff("old", old, "new", new, out)
240
263
        out.seek(0,0)
241
264
        return out.read()
313
336
        self.assertTrue(btree.path2id("grandparent/parent/file") is None)
314
337
 
315
338
    def sorted_ids(self, tree):
316
 
        ids = list(tree)
317
 
        ids.sort()
 
339
        ids = sorted(tree.all_file_ids())
318
340
        return ids
319
341
 
320
342
    def test_iteration(self):
338
360
        serializer = BundleSerializerV08('0.8')
339
361
        b = self.make_branch('.', format=format)
340
362
        self.assertRaises(errors.IncompatibleBundleFormat, serializer.write,
341
 
                          b.repository, [], {}, StringIO())
 
363
                          b.repository, [], {}, BytesIO())
342
364
 
343
365
    def test_matched_bundle(self):
344
366
        """Don't raise IncompatibleBundleFormat for knit2 and bundle0.9"""
346
368
        format.repository_format = knitrepo.RepositoryFormatKnit3()
347
369
        serializer = BundleSerializerV09('0.9')
348
370
        b = self.make_branch('.', format=format)
349
 
        serializer.write(b.repository, [], {}, StringIO())
 
371
        serializer.write(b.repository, [], {}, BytesIO())
350
372
 
351
373
    def test_mismatched_model(self):
352
374
        """Try copying a bundle from knit2 to knit1"""
355
377
        source = self.make_branch_and_tree('source', format=format)
356
378
        source.commit('one', rev_id='one-id')
357
379
        source.commit('two', rev_id='two-id')
358
 
        text = StringIO()
 
380
        text = BytesIO()
359
381
        write_bundle(source.branch.repository, 'two-id', 'null:', text,
360
382
                     format='0.9')
361
383
        text.seek(0)
386
408
        return tests.TestCaseWithTransport.make_branch(self, path, format)
387
409
 
388
410
    def create_bundle_text(self, base_rev_id, rev_id):
389
 
        bundle_txt = StringIO()
 
411
        bundle_txt = BytesIO()
390
412
        rev_ids = write_bundle(self.b1.repository, rev_id, base_rev_id,
391
413
                               bundle_txt, format=self.format)
392
414
        bundle_txt.seek(0)
441
463
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
442
464
        new_text = bundle_txt.getvalue().replace('executable:no',
443
465
                                               'executable:yes')
444
 
        bundle_txt = StringIO(new_text)
 
466
        bundle_txt = BytesIO(new_text)
445
467
        bundle = read_bundle(bundle_txt)
446
468
        self.valid_apply_bundle(base_rev_id, bundle)
447
469
        return bundle
448
470
 
449
471
    def test_non_bundle(self):
450
472
        self.assertRaises(errors.NotABundle,
451
 
                          read_bundle, StringIO('#!/bin/sh\n'))
 
473
                          read_bundle, BytesIO(b'#!/bin/sh\n'))
452
474
 
453
475
    def test_malformed(self):
454
476
        self.assertRaises(errors.BadBundle, read_bundle,
455
 
                          StringIO('# Bazaar revision bundle v'))
 
477
                          BytesIO(b'# Bazaar revision bundle v'))
456
478
 
457
479
    def test_crlf_bundle(self):
458
480
        try:
459
 
            read_bundle(StringIO('# Bazaar revision bundle v0.8\r\n'))
 
481
            read_bundle(BytesIO(b'# Bazaar revision bundle v0.8\r\n'))
460
482
        except errors.BadBundle:
461
483
            # It is currently permitted for bundles with crlf line endings to
462
484
            # make read_bundle raise a BadBundle, but this should be fixed.
473
495
            if not os.path.exists(checkout_dir):
474
496
                os.mkdir(checkout_dir)
475
497
        tree = self.make_branch_and_tree(checkout_dir)
476
 
        s = StringIO()
 
498
        s = BytesIO()
477
499
        ancestors = write_bundle(self.b1.repository, rev_id, 'null:', s,
478
500
                                 format=self.format)
479
501
        s.seek(0)
492
514
                                 % (ancestor,))
493
515
 
494
516
                # Now check that the file contents are all correct
495
 
                for inventory_id in old:
 
517
                for inventory_id in old.all_file_ids():
496
518
                    try:
497
519
                        old_file = old.get_file(inventory_id)
498
520
                    except errors.NoSuchFile:
505
527
                new.unlock()
506
528
                old.unlock()
507
529
        if not _mod_revision.is_null(rev_id):
508
 
            rh = self.b1.revision_history()
509
 
            tree.branch.set_revision_history(rh[:rh.index(rev_id)+1])
 
530
            tree.branch.generate_revision_history(rev_id)
510
531
            tree.update()
511
532
            delta = tree.changes_from(self.b1.repository.revision_tree(rev_id))
512
533
            self.assertFalse(delta.has_changed(),
530
551
        original_parents = to_tree.get_parent_ids()
531
552
        self.assertIs(repository.has_revision(base_rev_id), True)
532
553
        for rev in info.real_revisions:
533
 
            self.assert_(not repository.has_revision(rev.revision_id),
534
 
                'Revision {%s} present before applying bundle'
535
 
                % rev.revision_id)
 
554
            self.assertTrue(not repository.has_revision(rev.revision_id),
 
555
                            'Revision {%s} present before applying bundle'
 
556
                            % rev.revision_id)
536
557
        merge_bundle(info, to_tree, True, merge.Merge3Merger, False, False)
537
558
 
538
559
        for rev in info.real_revisions:
539
 
            self.assert_(repository.has_revision(rev.revision_id),
540
 
                'Missing revision {%s} after applying bundle'
541
 
                % rev.revision_id)
 
560
            self.assertTrue(repository.has_revision(rev.revision_id),
 
561
                            'Missing revision {%s} after applying bundle'
 
562
                            % rev.revision_id)
542
563
 
543
 
        self.assert_(to_tree.branch.repository.has_revision(info.target))
 
564
        self.assertTrue(to_tree.branch.repository.has_revision(info.target))
544
565
        # Do we also want to verify that all the texts have been added?
545
566
 
546
567
        self.assertEqual(original_parents + [info.target],
547
 
            to_tree.get_parent_ids())
 
568
                         to_tree.get_parent_ids())
548
569
 
549
570
        rev = info.real_revisions[-1]
550
571
        base_tree = self.b1.repository.revision_tree(rev.revision_id)
648
669
        bundle = self.get_valid_bundle('null:', 'a@cset-0-4')
649
670
 
650
671
        # Modified files
651
 
        open('b1/sub/dir/WithCaps.txt', 'ab').write('\nAdding some text\n')
652
 
        open('b1/sub/dir/ pre space', 'ab').write(
 
672
        with open('b1/sub/dir/WithCaps.txt', 'ab') as f: f.write('\nAdding some text\n')
 
673
        with open('b1/sub/dir/ pre space', 'ab') as f: f.write(
653
674
             '\r\nAdding some\r\nDOS format lines\r\n')
654
 
        open('b1/sub/dir/nolastnewline.txt', 'ab').write('\n')
 
675
        with open('b1/sub/dir/nolastnewline.txt', 'ab') as f: f.write('\n')
655
676
        self.tree1.rename_one('sub/dir/ pre space',
656
677
                              'sub/ start space')
657
678
        self.tree1.commit('Modified files', rev_id='a@cset-0-5')
679
700
    def _test_symlink_bundle(self, link_name, link_target, new_link_target):
680
701
        link_id = 'link-1'
681
702
 
682
 
        self.requireFeature(tests.SymlinkFeature)
 
703
        self.requireFeature(features.SymlinkFeature)
683
704
        self.tree1 = self.make_branch_and_tree('b1')
684
705
        self.b1 = self.tree1.branch
685
706
 
726
747
        self._test_symlink_bundle('link', 'bar/foo', 'mars')
727
748
 
728
749
    def test_unicode_symlink_bundle(self):
729
 
        self.requireFeature(tests.UnicodeFilenameFeature)
 
750
        self.requireFeature(features.UnicodeFilenameFeature)
730
751
        self._test_symlink_bundle(u'\N{Euro Sign}link',
731
752
                                  u'bar/\N{Euro Sign}foo',
732
753
                                  u'mars\N{Euro Sign}')
806
827
        self.tree1 = self.make_branch_and_tree('b1')
807
828
        self.b1 = self.tree1.branch
808
829
 
809
 
        open('b1/one', 'wb').write('one\n')
 
830
        with open('b1/one', 'wb') as f: f.write('one\n')
810
831
        self.tree1.add('one')
811
832
        self.tree1.commit('add file', rev_id='a@cset-0-1')
812
 
        open('b1/one', 'wb').write('two\n')
 
833
        with open('b1/one', 'wb') as f: f.write('two\n')
813
834
        self.tree1.commit('modify', rev_id='a@cset-0-2')
814
 
        open('b1/one', 'wb').write('three\n')
 
835
        with open('b1/one', 'wb') as f: f.write('three\n')
815
836
        self.tree1.commit('modify', rev_id='a@cset-0-3')
816
 
        bundle_file = StringIO()
 
837
        bundle_file = BytesIO()
817
838
        rev_ids = write_bundle(self.tree1.branch.repository, 'a@cset-0-3',
818
839
                               'a@cset-0-1', bundle_file, format=self.format)
819
840
        self.assertNotContainsRe(bundle_file.getvalue(), '\btwo\b')
824
845
        """Ensure using the basis as the target doesn't cause an error"""
825
846
        self.tree1 = self.make_branch_and_tree('b1')
826
847
        self.tree1.commit('add file', rev_id='a@cset-0-1')
827
 
        bundle_file = StringIO()
 
848
        bundle_file = BytesIO()
828
849
        rev_ids = write_bundle(self.tree1.branch.repository, 'a@cset-0-1',
829
850
                               'a@cset-0-1', bundle_file)
830
851
 
833
854
        return bundle_file.getvalue()
834
855
 
835
856
    def test_unicode_bundle(self):
836
 
        self.requireFeature(tests.UnicodeFilenameFeature)
 
857
        self.requireFeature(features.UnicodeFilenameFeature)
837
858
        # Handle international characters
838
859
        os.mkdir('b1')
839
860
        f = open(u'b1/with Dod\N{Euro Sign}', 'wb')
896
917
        bundle = self.get_valid_bundle('null:', 'white-1')
897
918
 
898
919
        # Modified
899
 
        open('b1/trailing space ', 'ab').write('add some text\n')
 
920
        with open('b1/trailing space ', 'ab') as f: f.write('add some text\n')
900
921
        self.tree1.commit('add text', rev_id='white-2')
901
922
 
902
923
        bundle = self.get_valid_bundle('white-1', 'white-2')
944
965
        self.tree1.commit('message', rev_id='revid1')
945
966
        bundle = self.get_valid_bundle('null:', 'revid1')
946
967
        tree = self.get_bundle_tree(bundle, 'revid1')
947
 
        self.assertEqual('revid1', tree.inventory.root.revision)
 
968
        root_revision = tree.get_file_revision(tree.get_root_id())
 
969
        self.assertEqual('revid1', root_revision)
948
970
 
949
971
    def test_install_revisions(self):
950
972
        self.tree1 = self.make_branch_and_tree('b1')
1136
1158
        self.tree1.add('file3', 'file3-id')
1137
1159
        self.tree1.commit('rev2')
1138
1160
        # Updating file2 should not cause an attempt to add to file1's vf
1139
 
        target = self.tree1.bzrdir.sprout('target').open_workingtree()
 
1161
        target = self.tree1.controldir.sprout('target').open_workingtree()
1140
1162
        self.build_tree_contents([('tree/file2', 'contents3')])
1141
1163
        self.tree1.commit('rev3', rev_id='rev3')
1142
1164
        bundle = self.get_valid_bundle('reva', 'rev3')
1198
1220
        txt = bundle_sio.getvalue()
1199
1221
        loc = txt.find('#   empty: ') + len('#   empty:')
1200
1222
        # Create a new bundle, which strips the trailing space after empty
1201
 
        bundle_sio = StringIO(txt[:loc] + txt[loc+1:])
 
1223
        bundle_sio = BytesIO(txt[:loc] + txt[loc+1:])
1202
1224
 
1203
1225
        self.assertContainsRe(bundle_sio.getvalue(),
1204
1226
                              '# properties:\n'
1319
1341
            self.assertEqual(len(branch_rev.parent_ids),
1320
1342
                             len(bundle_rev.parent_ids))
1321
1343
        self.assertEqual(set(rev_ids),
1322
 
                         set([r.revision_id for r in bundle.real_revisions]))
 
1344
                         {r.revision_id for r in bundle.real_revisions})
1323
1345
        self.valid_apply_bundle(base_rev_id, bundle,
1324
1346
                                   checkout_dir=checkout_dir)
1325
1347
 
1331
1353
 
1332
1354
        :return: The in-memory bundle
1333
1355
        """
1334
 
        from bzrlib.bundle import serializer
 
1356
        from ..bundle import serializer
1335
1357
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
1336
 
        new_text = self.get_raw(StringIO(''.join(bundle_txt)))
 
1358
        new_text = self.get_raw(BytesIO(b''.join(bundle_txt)))
1337
1359
        new_text = new_text.replace('<file file_id="exe-1"',
1338
1360
                                    '<file executable="y" file_id="exe-1"')
1339
1361
        new_text = new_text.replace('B260', 'B275')
1340
 
        bundle_txt = StringIO()
 
1362
        bundle_txt = BytesIO()
1341
1363
        bundle_txt.write(serializer._get_bundle_header('4'))
1342
1364
        bundle_txt.write('\n')
1343
1365
        bundle_txt.write(new_text.encode('bz2'))
1347
1369
        return bundle
1348
1370
 
1349
1371
    def create_bundle_text(self, base_rev_id, rev_id):
1350
 
        bundle_txt = StringIO()
 
1372
        bundle_txt = BytesIO()
1351
1373
        rev_ids = write_bundle(self.b1.repository, rev_id, base_rev_id,
1352
1374
                               bundle_txt, format=self.format)
1353
1375
        bundle_txt.seek(0)
1370
1392
        tree.commit('added file', rev_id='rev1')
1371
1393
        self.build_tree_contents([('tree/file', 'contents2\nstatic\n')])
1372
1394
        tree.commit('changed file', rev_id='rev2')
1373
 
        s = StringIO()
 
1395
        s = BytesIO()
1374
1396
        serializer = BundleSerializerV4('1.0')
1375
1397
        serializer.write(tree.branch.repository, ['rev1', 'rev2'], {}, s)
1376
1398
        s.seek(0)
1406
1428
 
1407
1429
    def test_copy_signatures(self):
1408
1430
        tree_a = self.make_branch_and_tree('tree_a')
1409
 
        import bzrlib.gpg
1410
 
        import bzrlib.commit as commit
1411
 
        oldstrategy = bzrlib.gpg.GPGStrategy
 
1431
        import breezy.gpg
 
1432
        import breezy.commit as commit
 
1433
        oldstrategy = breezy.gpg.GPGStrategy
1412
1434
        branch = tree_a.branch
1413
1435
        repo_a = branch.repository
1414
1436
        tree_a.commit("base", allow_pointless=True, rev_id='A')
1415
 
        self.failIf(branch.repository.has_signature_for_revision_id('A'))
 
1437
        self.assertFalse(branch.repository.has_signature_for_revision_id('A'))
1416
1438
        try:
1417
 
            from bzrlib.testament import Testament
 
1439
            from ..testament import Testament
1418
1440
            # monkey patch gpg signing mechanism
1419
 
            bzrlib.gpg.GPGStrategy = bzrlib.gpg.LoopbackGPGStrategy
1420
 
            new_config = test_commit.MustSignConfig(branch)
1421
 
            commit.Commit(config=new_config).commit(message="base",
 
1441
            breezy.gpg.GPGStrategy = breezy.gpg.LoopbackGPGStrategy
 
1442
            new_config = test_commit.MustSignConfig()
 
1443
            commit.Commit(config_stack=new_config).commit(message="base",
1422
1444
                                                    allow_pointless=True,
1423
1445
                                                    rev_id='B',
1424
1446
                                                    working_tree=tree_a)
1425
1447
            def sign(text):
1426
 
                return bzrlib.gpg.LoopbackGPGStrategy(None).sign(text)
 
1448
                return breezy.gpg.LoopbackGPGStrategy(None).sign(text)
1427
1449
            self.assertTrue(repo_a.has_signature_for_revision_id('B'))
1428
1450
        finally:
1429
 
            bzrlib.gpg.GPGStrategy = oldstrategy
 
1451
            breezy.gpg.GPGStrategy = oldstrategy
1430
1452
        tree_b = self.make_branch_and_tree('tree_b')
1431
1453
        repo_b = tree_b.branch.repository
1432
 
        s = StringIO()
 
1454
        s = BytesIO()
1433
1455
        serializer = BundleSerializerV4('4')
1434
1456
        serializer.write(tree_a.branch.repository, ['A', 'B'], {}, s)
1435
1457
        s.seek(0)
1442
1464
        install_bundle(repo_b, serializer.read(s))
1443
1465
 
1444
1466
 
1445
 
class V4WeaveBundleTester(V4BundleTester):
1446
 
 
1447
 
    def bzrdir_format(self):
1448
 
        return 'metaweave'
1449
 
 
1450
 
 
1451
1467
class V4_2aBundleTester(V4BundleTester):
1452
1468
 
1453
1469
    def bzrdir_format(self):
1459
1475
 
1460
1476
        :return: The in-memory bundle
1461
1477
        """
1462
 
        from bzrlib.bundle import serializer
 
1478
        from ..bundle import serializer
1463
1479
        bundle_txt, rev_ids = self.create_bundle_text(base_rev_id, rev_id)
1464
 
        new_text = self.get_raw(StringIO(''.join(bundle_txt)))
 
1480
        new_text = self.get_raw(BytesIO(b''.join(bundle_txt)))
1465
1481
        # We are going to be replacing some text to set the executable bit on a
1466
1482
        # file. Make sure the text replacement actually works correctly.
1467
1483
        self.assertContainsRe(new_text, '(?m)B244\n\ni 1\n<inventory')
1468
1484
        new_text = new_text.replace('<file file_id="exe-1"',
1469
1485
                                    '<file executable="y" file_id="exe-1"')
1470
1486
        new_text = new_text.replace('B244', 'B259')
1471
 
        bundle_txt = StringIO()
 
1487
        bundle_txt = BytesIO()
1472
1488
        bundle_txt.write(serializer._get_bundle_header('4'))
1473
1489
        bundle_txt.write('\n')
1474
1490
        bundle_txt.write(new_text.encode('bz2'))
1501
1517
    def make_bundle_just_inventories(self, base_revision_id,
1502
1518
                                     target_revision_id,
1503
1519
                                     revision_ids):
1504
 
        sio = StringIO()
 
1520
        sio = BytesIO()
1505
1521
        writer = v4.BundleWriteOperation(base_revision_id, target_revision_id,
1506
1522
                                         self.b1.repository, sio)
1507
1523
        writer.bundle.begin()
1624
1640
 
1625
1641
    def test_creating_bundle_preserves_chk_pages(self):
1626
1642
        self.make_merged_branch()
1627
 
        target = self.b1.bzrdir.sprout('target',
 
1643
        target = self.b1.controldir.sprout('target',
1628
1644
                                       revision_id='a@cset-0-2a').open_branch()
1629
1645
        bundle_txt, rev_ids = self.create_bundle_text('a@cset-0-2a',
1630
1646
                                                      'a@cset-0-3')
1655
1671
        wt.commit('add two', rev_id='a@cset-0-2',
1656
1672
                  revprops={'branch-nick':'test'})
1657
1673
 
1658
 
        bundle_txt = StringIO()
 
1674
        bundle_txt = BytesIO()
1659
1675
        rev_ids = write_bundle(wt.branch.repository, 'a@cset-0-2',
1660
1676
                               'a@cset-0-1', bundle_txt, self.format)
1661
 
        self.assertEqual(set(['a@cset-0-2']), set(rev_ids))
 
1677
        self.assertEqual({'a@cset-0-2'}, set(rev_ids))
1662
1678
        bundle_txt.seek(0, 0)
1663
1679
        return bundle_txt
1664
1680
 
1708
1724
        # creates a blank line at the end, and fails if that
1709
1725
        # line is stripped
1710
1726
        self.assertEqual('\n\n', raw[-2:])
1711
 
        bundle_txt = StringIO(raw[:-1])
 
1727
        bundle_txt = BytesIO(raw[:-1])
1712
1728
 
1713
1729
        bundle = read_bundle(bundle_txt)
1714
1730
        self.check_valid(bundle)
1716
1732
    def test_opening_text(self):
1717
1733
        bundle_txt = self.build_test_bundle()
1718
1734
 
1719
 
        bundle_txt = StringIO("Some random\nemail comments\n"
1720
 
                              + bundle_txt.getvalue())
 
1735
        bundle_txt = BytesIO(
 
1736
            b"Some random\nemail comments\n" + bundle_txt.getvalue())
1721
1737
 
1722
1738
        bundle = read_bundle(bundle_txt)
1723
1739
        self.check_valid(bundle)
1725
1741
    def test_trailing_text(self):
1726
1742
        bundle_txt = self.build_test_bundle()
1727
1743
 
1728
 
        bundle_txt = StringIO(bundle_txt.getvalue() +
1729
 
                              "Some trailing\nrandom\ntext\n")
 
1744
        bundle_txt = BytesIO(
 
1745
            bundle_txt.getvalue() + b"Some trailing\nrandom\ntext\n")
1730
1746
 
1731
1747
        bundle = read_bundle(bundle_txt)
1732
1748
        self.check_valid(bundle)
1740
1756
class TestBundleWriterReader(tests.TestCase):
1741
1757
 
1742
1758
    def test_roundtrip_record(self):
1743
 
        fileobj = StringIO()
 
1759
        fileobj = BytesIO()
1744
1760
        writer = v4.BundleWriter(fileobj)
1745
1761
        writer.begin()
1746
1762
        writer.add_info_record(foo='bar')
1750
1766
        fileobj.seek(0)
1751
1767
        reader = v4.BundleReader(fileobj, stream_input=True)
1752
1768
        record_iter = reader.iter_records()
1753
 
        record = record_iter.next()
 
1769
        record = next(record_iter)
1754
1770
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
1755
1771
            'info', None, None), record)
1756
 
        record = record_iter.next()
 
1772
        record = next(record_iter)
1757
1773
        self.assertEqual(("Record body", {'storage_kind': 'fulltext',
1758
1774
                          'parents': ['1', '3']}, 'file', 'revid', 'fileid'),
1759
1775
                          record)
1760
1776
 
1761
1777
    def test_roundtrip_record_memory_hungry(self):
1762
 
        fileobj = StringIO()
 
1778
        fileobj = BytesIO()
1763
1779
        writer = v4.BundleWriter(fileobj)
1764
1780
        writer.begin()
1765
1781
        writer.add_info_record(foo='bar')
1769
1785
        fileobj.seek(0)
1770
1786
        reader = v4.BundleReader(fileobj, stream_input=False)
1771
1787
        record_iter = reader.iter_records()
1772
 
        record = record_iter.next()
 
1788
        record = next(record_iter)
1773
1789
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
1774
1790
            'info', None, None), record)
1775
 
        record = record_iter.next()
 
1791
        record = next(record_iter)
1776
1792
        self.assertEqual(("Record body", {'storage_kind': 'fulltext',
1777
1793
                          'parents': ['1', '3']}, 'file', 'revid', 'fileid'),
1778
1794
                          record)
1794
1810
                         v4.BundleReader.decode_name('info'))
1795
1811
 
1796
1812
    def test_too_many_names(self):
1797
 
        fileobj = StringIO()
 
1813
        fileobj = BytesIO()
1798
1814
        writer = v4.BundleWriter(fileobj)
1799
1815
        writer.begin()
1800
1816
        writer.add_info_record(foo='bar')
1802
1818
        writer.end()
1803
1819
        fileobj.seek(0)
1804
1820
        record_iter = v4.BundleReader(fileobj).iter_records()
1805
 
        record = record_iter.next()
 
1821
        record = next(record_iter)
1806
1822
        self.assertEqual((None, {'foo': 'bar', 'storage_kind': 'header'},
1807
1823
            'info', None, None), record)
1808
 
        self.assertRaises(errors.BadBundle, record_iter.next)
 
1824
        self.assertRaises(errors.BadBundle, next, record_iter)
1809
1825
 
1810
1826
 
1811
1827
class TestReadMergeableFromUrl(tests.TestCaseWithTransport):
1828
1844
    def test_infinite_redirects_are_not_a_bundle(self):
1829
1845
        """If a URL causes TooManyRedirections then NotABundle is raised.
1830
1846
        """
1831
 
        from bzrlib.tests.blackbox.test_push import RedirectingMemoryServer
 
1847
        from .blackbox.test_push import RedirectingMemoryServer
1832
1848
        server = RedirectingMemoryServer()
1833
1849
        self.start_server(server)
1834
1850
        url = server.get_url() + 'infinite-loop'
1839
1855
        bundle, then the ConnectionReset error should be propagated.
1840
1856
        """
1841
1857
        # Instantiate a server that will provoke a ConnectionReset
1842
 
        sock_server = _DisconnectingTCPServer()
 
1858
        sock_server = DisconnectingServer()
1843
1859
        self.start_server(sock_server)
1844
1860
        # We don't really care what the url is since the server will close the
1845
1861
        # connection without interpreting it
1847
1863
        self.assertRaises(errors.ConnectionReset, read_mergeable_from_url, url)
1848
1864
 
1849
1865
 
1850
 
class _DisconnectingTCPServer(object):
1851
 
    """A TCP server that immediately closes any connection made to it."""
1852
 
 
1853
 
    def start_server(self):
1854
 
        self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
1855
 
        self.sock.bind(('127.0.0.1', 0))
1856
 
        self.sock.listen(1)
1857
 
        self.port = self.sock.getsockname()[1]
1858
 
        self.thread = threading.Thread(
1859
 
            name='%s (port %d)' % (self.__class__.__name__, self.port),
1860
 
            target=self.accept_and_close)
1861
 
        self.thread.start()
1862
 
 
1863
 
    def accept_and_close(self):
1864
 
        conn, addr = self.sock.accept()
1865
 
        conn.shutdown(socket.SHUT_RDWR)
1866
 
        conn.close()
 
1866
class DisconnectingHandler(socketserver.BaseRequestHandler):
 
1867
    """A request handler that immediately closes any connection made to it."""
 
1868
 
 
1869
    def handle(self):
 
1870
        self.request.close()
 
1871
 
 
1872
 
 
1873
class DisconnectingServer(test_server.TestingTCPServerInAThread):
 
1874
 
 
1875
    def __init__(self):
 
1876
        super(DisconnectingServer, self).__init__(
 
1877
            ('127.0.0.1', 0),
 
1878
            test_server.TestingTCPServer,
 
1879
            DisconnectingHandler)
1867
1880
 
1868
1881
    def get_url(self):
1869
 
        return 'bzr://127.0.0.1:%d/' % (self.port,)
1870
 
 
1871
 
    def stop_server(self):
1872
 
        try:
1873
 
            # make sure the thread dies by connecting to the listening socket,
1874
 
            # just in case the test failed to do so.
1875
 
            conn = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
1876
 
            conn.connect(self.sock.getsockname())
1877
 
            conn.close()
1878
 
        except socket.error:
1879
 
            pass
1880
 
        self.sock.close()
1881
 
        self.thread.join()
 
1882
        """Return the url of the server"""
 
1883
        return "bzr://%s:%d/" % self.server.server_address