1
# Copyright (C) 2005-2012, 2016 Canonical Ltd
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11
# GNU General Public License for more details.
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
17
"""Test commit message editor.
31
from ..msgeditor import (
32
make_commit_message_template_encoded,
33
edit_commit_message_encoded
38
TestCaseWithTransport,
42
probe_unicode_in_user_encoding,
45
from .EncodingAdapter import encoding_scenarios
46
from ..trace import mutter
49
def load_tests(loader, standard_tests, pattern):
50
"""Parameterize the test for tempfile creation with different encodings."""
51
to_adapt, result = split_suite_by_re(standard_tests,
52
"test__create_temp_file_with_commit_template_in_unicode_dir")
53
return multiply_tests(to_adapt, encoding_scenarios, result)
56
class MsgEditorTest(TestCaseWithTransport):
58
def make_uncommitted_tree(self):
59
"""Build a branch with uncommitted unicode named changes in the cwd."""
60
working_tree = self.make_branch_and_tree('.')
61
b = working_tree.branch
62
filename = u'hell\u00d8'
64
self.build_tree_contents([(filename, b'contents of hello')])
65
except UnicodeEncodeError:
66
self.skipTest("can't build unicode working tree in "
67
"filesystem encoding %s" % sys.getfilesystemencoding())
68
working_tree.add(filename)
71
def test_commit_template(self):
72
"""Test building a commit message template"""
73
working_tree = self.make_uncommitted_tree()
74
template = msgeditor.make_commit_message_template(working_tree,
76
self.assertEqualDiff(template,
82
def make_multiple_pending_tree(self):
83
config.GlobalStack().set('email', 'Bilbo Baggins <bb@hobbit.net>')
84
tree = self.make_branch_and_tree('a')
85
tree.commit('Initial checkin.', timestamp=1230912900, timezone=0)
86
tree2 = tree.controldir.clone('b').open_workingtree()
87
tree.commit('Minor tweak.', timestamp=1231977840, timezone=0)
88
tree2.commit('Feature X work.', timestamp=1233186240, timezone=0)
89
tree3 = tree2.controldir.clone('c').open_workingtree()
90
tree2.commit('Feature X finished.', timestamp=1233187680, timezone=0)
91
tree3.commit('Feature Y, based on initial X work.',
92
timestamp=1233285960, timezone=0)
93
tree.merge_from_branch(tree2.branch)
94
tree.merge_from_branch(tree3.branch, force=True)
97
def test_commit_template_pending_merges(self):
98
"""Test building a commit message template when there are pending
99
merges. The commit message should show all pending merge revisions,
100
as does 'status -v', not only the merge tips.
102
working_tree = self.make_multiple_pending_tree()
103
template = msgeditor.make_commit_message_template(working_tree, None)
104
self.assertEqualDiff(template,
107
Bilbo Baggins 2009-01-29 Feature X finished.
108
Bilbo Baggins 2009-01-28 Feature X work.
109
Bilbo Baggins 2009-01-30 Feature Y, based on initial X work.
112
def test_commit_template_encoded(self):
113
"""Test building a commit message template"""
114
working_tree = self.make_uncommitted_tree()
115
template = make_commit_message_template_encoded(working_tree,
117
output_encoding='utf8')
118
self.assertEqualDiff(template,
125
def test_commit_template_and_diff(self):
126
"""Test building a commit message template"""
127
working_tree = self.make_uncommitted_tree()
128
template = make_commit_message_template_encoded(working_tree,
131
output_encoding='utf8')
137
self.assertTrue(u"""\
140
""".encode('utf8') in template)
142
def make_do_nothing_editor(self, basename='fed'):
143
if sys.platform == "win32":
144
name = basename + '.bat'
146
f.write('@rem dummy fed')
150
name = basename + '.sh'
152
f.write('#!/bin/sh\n')
154
os.chmod(name, 0o755)
157
def test_run_editor(self):
158
self.overrideEnv('BRZ_EDITOR', self.make_do_nothing_editor())
159
self.assertEqual(True, msgeditor._run_editor(''),
160
'Unable to run dummy fake editor')
162
def test_parse_editor_name(self):
163
"""Correctly interpret names with spaces.
165
See <https://bugs.launchpad.net/bzr/+bug/220331>
167
self.overrideEnv('BRZ_EDITOR',
168
'"%s"' % self.make_do_nothing_editor('name with spaces'))
169
self.assertEqual(True, msgeditor._run_editor('a_filename'))
171
def make_fake_editor(self, message='test message from fed\\n'):
172
"""Set up environment so that an editor will be a known script.
174
Sets up BRZ_EDITOR so that if an editor is spawned it will run a
175
script that just adds a known message to the start of the file.
177
f = file('fed.py', 'wb')
178
f.write('#!%s\n' % sys.executable)
182
if len(sys.argv) == 2:
193
if sys.platform == "win32":
194
# [win32] make batch file and set BRZ_EDITOR
195
f = file('fed.bat', 'w')
199
""" % sys.executable)
201
self.overrideEnv('BRZ_EDITOR', 'fed.bat')
203
# [non-win32] make python script executable and set BRZ_EDITOR
204
os.chmod('fed.py', 0o755)
205
self.overrideEnv('BRZ_EDITOR', './fed.py')
207
def test_edit_commit_message_without_infotext(self):
208
working_tree = self.make_uncommitted_tree()
209
self.make_fake_editor()
211
mutter('edit_commit_message without infotext')
212
self.assertEqual('test message from fed\n',
213
msgeditor.edit_commit_message(''))
215
def test_edit_commit_message_with_ascii_infotext(self):
216
working_tree = self.make_uncommitted_tree()
217
self.make_fake_editor()
219
mutter('edit_commit_message with ascii string infotext')
220
self.assertEqual('test message from fed\n',
221
msgeditor.edit_commit_message('spam'))
223
def test_edit_commit_message_with_unicode_infotext(self):
224
working_tree = self.make_uncommitted_tree()
225
self.make_fake_editor()
227
mutter('edit_commit_message with unicode infotext')
228
uni_val, ue_val = probe_unicode_in_user_encoding()
231
'Cannot find a unicode character that works in encoding %s'
232
% (osutils.get_user_encoding(),))
234
self.assertEqual('test message from fed\n',
235
msgeditor.edit_commit_message(uni_val))
237
tmpl = edit_commit_message_encoded(u'\u1234'.encode("utf8"))
238
self.assertEqual('test message from fed\n', tmpl)
240
def test_start_message(self):
241
self.make_uncommitted_tree()
242
self.make_fake_editor()
243
self.assertEqual('test message from fed\nstart message\n',
244
msgeditor.edit_commit_message('',
245
start_message='start message\n'))
246
self.assertEqual('test message from fed\n',
247
msgeditor.edit_commit_message('',
250
def test_deleted_commit_message(self):
251
working_tree = self.make_uncommitted_tree()
253
if sys.platform == 'win32':
254
editor = 'cmd.exe /c del'
257
self.overrideEnv('BRZ_EDITOR', editor)
259
self.assertRaises((IOError, OSError), msgeditor.edit_commit_message, '')
261
def test__get_editor(self):
262
self.overrideEnv('BRZ_EDITOR', 'bzr_editor')
263
self.overrideEnv('VISUAL', 'visual')
264
self.overrideEnv('EDITOR', 'editor')
266
conf = config.GlobalStack()
267
conf.store._load_from_string('[DEFAULT]\neditor = config_editor\n')
269
editors = list(msgeditor._get_editor())
270
editors = [editor for (editor, cfg_src) in editors]
272
self.assertEqual(['bzr_editor', 'config_editor', 'visual', 'editor'],
275
if sys.platform == 'win32':
276
self.assertEqual(['wordpad.exe', 'notepad.exe'], editors[4:])
278
self.assertEqual(['/usr/bin/editor', 'vi', 'pico', 'nano', 'joe'],
282
def test__run_editor_EACCES(self):
283
"""If running a configured editor raises EACESS, the user is warned."""
284
self.overrideEnv('BRZ_EDITOR', 'eacces.py')
285
f = file('eacces.py', 'wb')
286
f.write('# Not a real editor')
288
# Make the fake editor unreadable (and unexecutable)
289
os.chmod('eacces.py', 0)
290
# Set $EDITOR so that _run_editor will terminate before trying real
292
self.overrideEnv('EDITOR', self.make_do_nothing_editor())
293
# Call _run_editor, capturing mutter.warning calls.
297
warnings.append(args[0] % args[1:])
299
warnings.append(args[0])
300
_warning = trace.warning
301
trace.warning = warning
303
msgeditor._run_editor('')
305
trace.warning = _warning
306
self.assertStartsWith(warnings[0], 'Could not start editor "eacces.py"')
308
def test__create_temp_file_with_commit_template(self):
309
# check that commit template written properly
310
# and has platform native line-endings (CRLF on win32)
311
create_file = msgeditor._create_temp_file_with_commit_template
312
msgfilename, hasinfo = create_file('infotext', '----', 'start message')
313
self.assertNotEqual(None, msgfilename)
314
self.assertTrue(hasinfo)
315
expected = os.linesep.join(['start message',
321
self.assertFileEqual(expected, msgfilename)
323
def test__create_temp_file_with_commit_template_in_unicode_dir(self):
324
self.requireFeature(features.UnicodeFilenameFeature)
325
if hasattr(self, 'info'):
326
tmpdir = self.info['directory']
328
# Force the creation of temp file in a directory whose name
329
# requires some encoding support
330
msgeditor._create_temp_file_with_commit_template('infotext',
333
raise TestNotApplicable('Test run elsewhere with non-ascii data.')
335
def test__create_temp_file_with_empty_commit_template(self):
337
create_file = msgeditor._create_temp_file_with_commit_template
338
msgfilename, hasinfo = create_file('')
339
self.assertNotEqual(None, msgfilename)
340
self.assertFalse(hasinfo)
341
self.assertFileEqual('', msgfilename)
343
def test_unsupported_encoding_commit_message(self):
344
self.overrideEnv('LANG', 'C')
345
# LANG env variable has no effect on Windows
346
# but some characters anyway cannot be represented
347
# in default user encoding
348
char = probe_bad_non_ascii(osutils.get_user_encoding())
350
self.skipTest('Cannot find suitable non-ascii character '
351
'for user_encoding (%s)' % osutils.get_user_encoding())
353
self.make_fake_editor(message=char)
355
working_tree = self.make_uncommitted_tree()
356
self.assertRaises(msgeditor.BadCommitMessageEncoding,
357
msgeditor.edit_commit_message, '')
359
def test_set_commit_message_no_hooks(self):
360
commit_obj = commit.Commit()
362
msgeditor.set_commit_message(commit_obj))
364
def test_set_commit_message_hook(self):
365
msgeditor.hooks.install_named_hook("set_commit_message",
366
lambda commit_obj, existing_message: "save me some typing\n", None)
367
commit_obj = commit.Commit()
368
self.assertEqual("save me some typing\n",
369
msgeditor.set_commit_message(commit_obj))
371
def test_generate_commit_message_template_no_hooks(self):
372
commit_obj = commit.Commit()
374
msgeditor.generate_commit_message_template(commit_obj))
376
def test_generate_commit_message_template_hook(self):
377
msgeditor.hooks.install_named_hook("commit_message_template",
378
lambda commit_obj, msg: "save me some typing\n", None)
379
commit_obj = commit.Commit()
380
self.assertEqual("save me some typing\n",
381
msgeditor.generate_commit_message_template(commit_obj))
384
# GZ 2009-11-17: This wants moving to osutils when the errno checking code is
385
class TestPlatformErrnoWorkarounds(TestCaseInTempDir):
386
"""Ensuring workarounds enshrined in code actually serve a purpose"""
388
def test_subprocess_call_bad_file(self):
389
if sys.platform != "win32":
390
raise TestNotApplicable("Workarounds for windows only")
391
import subprocess, errno
392
ERROR_BAD_EXE_FORMAT = 193
393
file("textfile.txt", "w").close()
394
e = self.assertRaises(WindowsError, subprocess.call, "textfile.txt")
395
self.assertEqual(e.errno, errno.ENOEXEC)
396
self.assertEqual(e.winerror, ERROR_BAD_EXE_FORMAT)