/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to breezy/tests/test_transform.py

  • Committer: Jelmer Vernooij
  • Date: 2019-06-03 21:25:01 UTC
  • mto: This revision was merged to the branch mainline in revision 7318.
  • Revision ID: jelmer@jelmer.uk-20190603212501-zgt2czrlc6oqoi7a
Fix tests on python 2.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2010 Canonical Ltd
 
1
# Copyright (C) 2006-2012, 2016 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
 
17
import codecs
 
18
import errno
 
19
from io import BytesIO, StringIO
17
20
import os
18
 
from StringIO import StringIO
19
21
import sys
20
22
import time
21
23
 
22
 
from bzrlib import (
 
24
from .. import (
23
25
    bencode,
24
26
    errors,
25
27
    filters,
26
 
    generate_ids,
27
28
    osutils,
28
 
    progress,
29
29
    revision as _mod_revision,
30
30
    rules,
31
31
    tests,
 
32
    trace,
 
33
    transform,
32
34
    urlutils,
33
35
    )
34
 
from bzrlib.bzrdir import BzrDir
35
 
from bzrlib.conflicts import (DuplicateEntry, DuplicateID, MissingParent,
36
 
                              UnversionedParent, ParentLoop, DeletingParent,
37
 
                              NonDirectoryParent)
38
 
from bzrlib.diff import show_diff_trees
39
 
from bzrlib.errors import (DuplicateKey, MalformedTransform, NoSuchFile,
40
 
                           ReusingTransform, CantMoveRoot,
41
 
                           PathsNotVersionedError, ExistingLimbo,
42
 
                           ExistingPendingDeletion, ImmortalLimbo,
43
 
                           ImmortalPendingDeletion, LockError)
44
 
from bzrlib.osutils import file_kind, pathjoin
45
 
from bzrlib.merge import Merge3Merger, Merger
46
 
from bzrlib.tests import (
 
36
from ..bzr import (
 
37
    generate_ids,
 
38
    )
 
39
from ..conflicts import (
 
40
    DeletingParent,
 
41
    DuplicateEntry,
 
42
    DuplicateID,
 
43
    MissingParent,
 
44
    NonDirectoryParent,
 
45
    ParentLoop,
 
46
    UnversionedParent,
 
47
)
 
48
from ..controldir import ControlDir
 
49
from ..diff import show_diff_trees
 
50
from ..errors import (
 
51
    DuplicateKey,
 
52
    ExistingLimbo,
 
53
    ExistingPendingDeletion,
 
54
    ImmortalLimbo,
 
55
    ImmortalPendingDeletion,
 
56
    LockError,
 
57
    MalformedTransform,
 
58
    ReusingTransform,
 
59
)
 
60
from ..osutils import (
 
61
    file_kind,
 
62
    pathjoin,
 
63
)
 
64
from ..merge import Merge3Merger, Merger
 
65
from ..mutabletree import MutableTree
 
66
from ..sixish import (
 
67
    BytesIO,
 
68
    PY3,
 
69
    text_type,
 
70
    )
 
71
from . import (
 
72
    features,
 
73
    TestCaseInTempDir,
 
74
    TestSkipped,
 
75
    )
 
76
from .features import (
47
77
    HardlinkFeature,
48
78
    SymlinkFeature,
49
 
    TestCase,
50
 
    TestCaseInTempDir,
51
 
    TestSkipped,
52
79
    )
53
 
from bzrlib.transform import (TreeTransform, ROOT_PARENT, FinalPaths,
54
 
                              resolve_conflicts, cook_conflicts,
55
 
                              build_tree, get_backup_name,
56
 
                              _FileMover, resolve_checkout,
57
 
                              TransformPreview, create_from_tree)
 
80
from ..transform import (
 
81
    build_tree,
 
82
    create_from_tree,
 
83
    cook_conflicts,
 
84
    _FileMover,
 
85
    FinalPaths,
 
86
    resolve_conflicts,
 
87
    resolve_checkout,
 
88
    ROOT_PARENT,
 
89
    TransformPreview,
 
90
    TreeTransform,
 
91
)
58
92
 
59
93
 
60
94
class TestTreeTransform(tests.TestCaseWithTransport):
61
95
 
62
96
    def setUp(self):
63
97
        super(TestTreeTransform, self).setUp()
64
 
        self.wt = self.make_branch_and_tree('.', format='dirstate-with-subtree')
 
98
        self.wt = self.make_branch_and_tree('.', format='development-subtree')
65
99
        os.chdir('..')
66
100
 
67
101
    def get_transform(self):
69
103
        self.addCleanup(transform.finalize)
70
104
        return transform, transform.root
71
105
 
 
106
    def get_transform_for_sha1_test(self):
 
107
        trans, root = self.get_transform()
 
108
        self.wt.lock_tree_write()
 
109
        self.addCleanup(self.wt.unlock)
 
110
        contents = [b'just some content\n']
 
111
        sha1 = osutils.sha_strings(contents)
 
112
        # Roll back the clock
 
113
        trans._creation_mtime = time.time() - 20.0
 
114
        return trans, root, contents, sha1
 
115
 
72
116
    def test_existing_limbo(self):
73
117
        transform, root = self.get_transform()
74
118
        limbo_name = transform._limbodir
101
145
        imaginary_id = transform.trans_id_tree_path('imaginary')
102
146
        imaginary_id2 = transform.trans_id_tree_path('imaginary/')
103
147
        self.assertEqual(imaginary_id, imaginary_id2)
104
 
        self.assertEqual(transform.get_tree_parent(imaginary_id), root)
105
 
        self.assertEqual(transform.final_kind(root), 'directory')
106
 
        self.assertEqual(transform.final_file_id(root), self.wt.get_root_id())
 
148
        self.assertEqual(root, transform.get_tree_parent(imaginary_id))
 
149
        self.assertEqual('directory', transform.final_kind(root))
 
150
        self.assertEqual(self.wt.get_root_id(), transform.final_file_id(root))
107
151
        trans_id = transform.create_path('name', root)
108
152
        self.assertIs(transform.final_file_id(trans_id), None)
109
 
        self.assertRaises(NoSuchFile, transform.final_kind, trans_id)
110
 
        transform.create_file('contents', trans_id)
 
153
        self.assertIs(None, transform.final_kind(trans_id))
 
154
        transform.create_file([b'contents'], trans_id)
111
155
        transform.set_executability(True, trans_id)
112
 
        transform.version_file('my_pretties', trans_id)
 
156
        transform.version_file(b'my_pretties', trans_id)
113
157
        self.assertRaises(DuplicateKey, transform.version_file,
114
 
                          'my_pretties', trans_id)
115
 
        self.assertEqual(transform.final_file_id(trans_id), 'my_pretties')
 
158
                          b'my_pretties', trans_id)
 
159
        self.assertEqual(transform.final_file_id(trans_id), b'my_pretties')
116
160
        self.assertEqual(transform.final_parent(trans_id), root)
117
161
        self.assertIs(transform.final_parent(root), ROOT_PARENT)
118
162
        self.assertIs(transform.get_tree_parent(root), ROOT_PARENT)
119
163
        oz_id = transform.create_path('oz', root)
120
164
        transform.create_directory(oz_id)
121
 
        transform.version_file('ozzie', oz_id)
 
165
        transform.version_file(b'ozzie', oz_id)
122
166
        trans_id2 = transform.create_path('name2', root)
123
 
        transform.create_file('contents', trans_id2)
 
167
        transform.create_file([b'contents'], trans_id2)
124
168
        transform.set_executability(False, trans_id2)
125
 
        transform.version_file('my_pretties2', trans_id2)
 
169
        transform.version_file(b'my_pretties2', trans_id2)
126
170
        modified_paths = transform.apply().modified_paths
127
 
        self.assertEqual('contents', self.wt.get_file_byname('name').read())
128
 
        self.assertEqual(self.wt.path2id('name'), 'my_pretties')
129
 
        self.assertIs(self.wt.is_executable('my_pretties'), True)
130
 
        self.assertIs(self.wt.is_executable('my_pretties2'), False)
 
171
        with self.wt.get_file('name') as f:
 
172
            self.assertEqual(b'contents', f.read())
 
173
        self.assertEqual(self.wt.path2id('name'), b'my_pretties')
 
174
        self.assertIs(self.wt.is_executable('name'), True)
 
175
        self.assertIs(self.wt.is_executable('name2'), False)
131
176
        self.assertEqual('directory', file_kind(self.wt.abspath('oz')))
132
177
        self.assertEqual(len(modified_paths), 3)
133
 
        tree_mod_paths = [self.wt.id2abspath(f) for f in
134
 
                          ('ozzie', 'my_pretties', 'my_pretties2')]
 
178
        tree_mod_paths = [self.wt.abspath(self.wt.id2path(f)) for f in
 
179
                          (b'ozzie', b'my_pretties', b'my_pretties2')]
135
180
        self.assertSubset(tree_mod_paths, modified_paths)
136
181
        # is it safe to finalize repeatedly?
137
182
        transform.finalize()
138
183
        transform.finalize()
139
184
 
 
185
    def test_apply_informs_tree_of_observed_sha1(self):
 
186
        trans, root, contents, sha1 = self.get_transform_for_sha1_test()
 
187
        trans_id = trans.new_file('file1', root, contents, file_id=b'file1-id',
 
188
                                  sha1=sha1)
 
189
        calls = []
 
190
        orig = self.wt._observed_sha1
 
191
 
 
192
        def _observed_sha1(*args):
 
193
            calls.append(args)
 
194
            orig(*args)
 
195
        self.wt._observed_sha1 = _observed_sha1
 
196
        trans.apply()
 
197
        self.assertEqual([('file1', trans._observed_sha1s[trans_id])],
 
198
                         calls)
 
199
 
 
200
    def test_create_file_caches_sha1(self):
 
201
        trans, root, contents, sha1 = self.get_transform_for_sha1_test()
 
202
        trans_id = trans.create_path('file1', root)
 
203
        trans.create_file(contents, trans_id, sha1=sha1)
 
204
        st_val = osutils.lstat(trans._limbo_name(trans_id))
 
205
        o_sha1, o_st_val = trans._observed_sha1s[trans_id]
 
206
        self.assertEqual(o_sha1, sha1)
 
207
        self.assertEqualStat(o_st_val, st_val)
 
208
 
 
209
    def test__apply_insertions_updates_sha1(self):
 
210
        trans, root, contents, sha1 = self.get_transform_for_sha1_test()
 
211
        trans_id = trans.create_path('file1', root)
 
212
        trans.create_file(contents, trans_id, sha1=sha1)
 
213
        st_val = osutils.lstat(trans._limbo_name(trans_id))
 
214
        o_sha1, o_st_val = trans._observed_sha1s[trans_id]
 
215
        self.assertEqual(o_sha1, sha1)
 
216
        self.assertEqualStat(o_st_val, st_val)
 
217
        creation_mtime = trans._creation_mtime + 10.0
 
218
        # We fake a time difference from when the file was created until now it
 
219
        # is being renamed by using os.utime. Note that the change we actually
 
220
        # want to see is the real ctime change from 'os.rename()', but as long
 
221
        # as we observe a new stat value, we should be fine.
 
222
        os.utime(trans._limbo_name(trans_id), (creation_mtime, creation_mtime))
 
223
        trans.apply()
 
224
        new_st_val = osutils.lstat(self.wt.abspath('file1'))
 
225
        o_sha1, o_st_val = trans._observed_sha1s[trans_id]
 
226
        self.assertEqual(o_sha1, sha1)
 
227
        self.assertEqualStat(o_st_val, new_st_val)
 
228
        self.assertNotEqual(st_val.st_mtime, new_st_val.st_mtime)
 
229
 
 
230
    def test_new_file_caches_sha1(self):
 
231
        trans, root, contents, sha1 = self.get_transform_for_sha1_test()
 
232
        trans_id = trans.new_file('file1', root, contents, file_id=b'file1-id',
 
233
                                  sha1=sha1)
 
234
        st_val = osutils.lstat(trans._limbo_name(trans_id))
 
235
        o_sha1, o_st_val = trans._observed_sha1s[trans_id]
 
236
        self.assertEqual(o_sha1, sha1)
 
237
        self.assertEqualStat(o_st_val, st_val)
 
238
 
 
239
    def test_cancel_creation_removes_observed_sha1(self):
 
240
        trans, root, contents, sha1 = self.get_transform_for_sha1_test()
 
241
        trans_id = trans.new_file('file1', root, contents, file_id=b'file1-id',
 
242
                                  sha1=sha1)
 
243
        self.assertTrue(trans_id in trans._observed_sha1s)
 
244
        trans.cancel_creation(trans_id)
 
245
        self.assertFalse(trans_id in trans._observed_sha1s)
 
246
 
140
247
    def test_create_files_same_timestamp(self):
141
248
        transform, root = self.get_transform()
142
249
        self.wt.lock_tree_write()
144
251
        # Roll back the clock, so that we know everything is being set to the
145
252
        # exact time
146
253
        transform._creation_mtime = creation_mtime = time.time() - 20.0
147
 
        transform.create_file('content-one',
 
254
        transform.create_file([b'content-one'],
148
255
                              transform.create_path('one', root))
149
 
        time.sleep(1) # *ugly*
150
 
        transform.create_file('content-two',
 
256
        time.sleep(1)  # *ugly*
 
257
        transform.create_file([b'content-two'],
151
258
                              transform.create_path('two', root))
152
259
        transform.apply()
153
 
        fo, st1 = self.wt.get_file_with_stat(None, path='one', filtered=False)
 
260
        fo, st1 = self.wt.get_file_with_stat('one', filtered=False)
154
261
        fo.close()
155
 
        fo, st2 = self.wt.get_file_with_stat(None, path='two', filtered=False)
 
262
        fo, st2 = self.wt.get_file_with_stat('two', filtered=False)
156
263
        fo.close()
157
264
        # We only guarantee 2s resolution
158
 
        self.assertTrue(abs(creation_mtime - st1.st_mtime) < 2.0,
 
265
        self.assertTrue(
 
266
            abs(creation_mtime - st1.st_mtime) < 2.0,
159
267
            "%s != %s within 2 seconds" % (creation_mtime, st1.st_mtime))
160
268
        # But if we have more than that, all files should get the same result
161
269
        self.assertEqual(st1.st_mtime, st2.st_mtime)
162
270
 
163
271
    def test_change_root_id(self):
164
272
        transform, root = self.get_transform()
165
 
        self.assertNotEqual('new-root-id', self.wt.get_root_id())
166
 
        transform.new_directory('', ROOT_PARENT, 'new-root-id')
 
273
        self.assertNotEqual(b'new-root-id', self.wt.get_root_id())
 
274
        transform.new_directory('', ROOT_PARENT, b'new-root-id')
167
275
        transform.delete_contents(root)
168
276
        transform.unversion_file(root)
169
277
        transform.fixup_new_roots()
170
278
        transform.apply()
171
 
        self.assertEqual('new-root-id', self.wt.get_root_id())
 
279
        self.assertEqual(b'new-root-id', self.wt.get_root_id())
172
280
 
173
281
    def test_change_root_id_add_files(self):
174
282
        transform, root = self.get_transform()
175
 
        self.assertNotEqual('new-root-id', self.wt.get_root_id())
176
 
        new_trans_id = transform.new_directory('', ROOT_PARENT, 'new-root-id')
177
 
        transform.new_file('file', new_trans_id, ['new-contents\n'],
178
 
                           'new-file-id')
 
283
        self.assertNotEqual(b'new-root-id', self.wt.get_root_id())
 
284
        new_trans_id = transform.new_directory('', ROOT_PARENT, b'new-root-id')
 
285
        transform.new_file('file', new_trans_id, [b'new-contents\n'],
 
286
                           b'new-file-id')
179
287
        transform.delete_contents(root)
180
288
        transform.unversion_file(root)
181
289
        transform.fixup_new_roots()
182
290
        transform.apply()
183
 
        self.assertEqual('new-root-id', self.wt.get_root_id())
184
 
        self.assertEqual('new-file-id', self.wt.path2id('file'))
185
 
        self.assertFileEqual('new-contents\n', self.wt.abspath('file'))
 
291
        self.assertEqual(b'new-root-id', self.wt.get_root_id())
 
292
        self.assertEqual(b'new-file-id', self.wt.path2id('file'))
 
293
        self.assertFileEqual(b'new-contents\n', self.wt.abspath('file'))
186
294
 
187
295
    def test_add_two_roots(self):
188
296
        transform, root = self.get_transform()
189
 
        new_trans_id = transform.new_directory('', ROOT_PARENT, 'new-root-id')
190
 
        new_trans_id = transform.new_directory('', ROOT_PARENT, 'alt-root-id')
191
 
        self.assertRaises(ValueError, transform.fixup_new_roots)
 
297
        transform.new_directory('', ROOT_PARENT, b'new-root-id')
 
298
        transform.new_directory('', ROOT_PARENT, b'alt-root-id')
 
299
        self.assertRaises(ValueError, transform.fixup_new_roots)
 
300
 
 
301
    def test_retain_existing_root(self):
 
302
        tt, root = self.get_transform()
 
303
        with tt:
 
304
            tt.new_directory('', ROOT_PARENT, b'new-root-id')
 
305
            tt.fixup_new_roots()
 
306
            self.assertNotEqual(b'new-root-id', tt.final_file_id(tt.root))
 
307
 
 
308
    def test_retain_existing_root_added_file(self):
 
309
        tt, root = self.get_transform()
 
310
        new_trans_id = tt.new_directory('', ROOT_PARENT, b'new-root-id')
 
311
        child = tt.new_directory('child', new_trans_id, b'child-id')
 
312
        tt.fixup_new_roots()
 
313
        self.assertEqual(tt.root, tt.final_parent(child))
 
314
 
 
315
    def test_add_unversioned_root(self):
 
316
        transform, root = self.get_transform()
 
317
        transform.new_directory('', ROOT_PARENT, None)
 
318
        transform.delete_contents(transform.root)
 
319
        transform.fixup_new_roots()
 
320
        self.assertNotIn(transform.root, transform._new_id)
 
321
 
 
322
    def test_remove_root_fixup(self):
 
323
        transform, root = self.get_transform()
 
324
        old_root_id = self.wt.get_root_id()
 
325
        self.assertNotEqual(b'new-root-id', old_root_id)
 
326
        transform.delete_contents(root)
 
327
        transform.unversion_file(root)
 
328
        transform.fixup_new_roots()
 
329
        transform.apply()
 
330
        self.assertEqual(old_root_id, self.wt.get_root_id())
 
331
 
 
332
        transform, root = self.get_transform()
 
333
        transform.new_directory('', ROOT_PARENT, b'new-root-id')
 
334
        transform.new_directory('', ROOT_PARENT, b'alt-root-id')
 
335
        self.assertRaises(ValueError, transform.fixup_new_roots)
 
336
 
 
337
    def test_fixup_new_roots_permits_empty_tree(self):
 
338
        transform, root = self.get_transform()
 
339
        transform.delete_contents(root)
 
340
        transform.unversion_file(root)
 
341
        transform.fixup_new_roots()
 
342
        self.assertIs(None, transform.final_kind(root))
 
343
        self.assertIs(None, transform.final_file_id(root))
 
344
 
 
345
    def test_apply_retains_root_directory(self):
 
346
        # Do not attempt to delete the physical root directory, because that
 
347
        # is impossible.
 
348
        transform, root = self.get_transform()
 
349
        with transform:
 
350
            transform.delete_contents(root)
 
351
            e = self.assertRaises(AssertionError, self.assertRaises,
 
352
                                  errors.TransformRenameFailed,
 
353
                                  transform.apply)
 
354
        self.assertContainsRe('TransformRenameFailed not raised', str(e))
 
355
 
 
356
    def test_apply_retains_file_id(self):
 
357
        transform, root = self.get_transform()
 
358
        old_root_id = transform.tree_file_id(root)
 
359
        transform.unversion_file(root)
 
360
        transform.apply()
 
361
        self.assertEqual(old_root_id, self.wt.get_root_id())
192
362
 
193
363
    def test_hardlink(self):
194
364
        self.requireFeature(HardlinkFeature)
195
365
        transform, root = self.get_transform()
196
 
        transform.new_file('file1', root, 'contents')
 
366
        transform.new_file('file1', root, [b'contents'])
197
367
        transform.apply()
198
368
        target = self.make_branch_and_tree('target')
199
369
        target_transform = TreeTransform(target)
200
370
        trans_id = target_transform.create_path('file1', target_transform.root)
201
371
        target_transform.create_hardlink(self.wt.abspath('file1'), trans_id)
202
372
        target_transform.apply()
203
 
        self.failUnlessExists('target/file1')
 
373
        self.assertPathExists('target/file1')
204
374
        source_stat = os.stat(self.wt.abspath('file1'))
205
375
        target_stat = os.stat('target/file1')
206
376
        self.assertEqual(source_stat, target_stat)
209
379
        transform, root = self.get_transform()
210
380
        self.wt.lock_tree_write()
211
381
        self.addCleanup(self.wt.unlock)
212
 
        trans_id = transform.new_file('name', root, 'contents',
213
 
                                      'my_pretties', True)
214
 
        oz = transform.new_directory('oz', root, 'oz-id')
215
 
        dorothy = transform.new_directory('dorothy', oz, 'dorothy-id')
216
 
        toto = transform.new_file('toto', dorothy, 'toto-contents',
217
 
                                  'toto-id', False)
 
382
        transform.new_file('name', root, [b'contents'], b'my_pretties', True)
 
383
        oz = transform.new_directory('oz', root, b'oz-id')
 
384
        dorothy = transform.new_directory('dorothy', oz, b'dorothy-id')
 
385
        transform.new_file('toto', dorothy, [b'toto-contents'], b'toto-id',
 
386
                           False)
218
387
 
219
388
        self.assertEqual(len(transform.find_conflicts()), 0)
220
389
        transform.apply()
221
390
        self.assertRaises(ReusingTransform, transform.find_conflicts)
222
 
        self.assertEqual('contents', file(self.wt.abspath('name')).read())
223
 
        self.assertEqual(self.wt.path2id('name'), 'my_pretties')
224
 
        self.assertIs(self.wt.is_executable('my_pretties'), True)
225
 
        self.assertEqual(self.wt.path2id('oz'), 'oz-id')
226
 
        self.assertEqual(self.wt.path2id('oz/dorothy'), 'dorothy-id')
227
 
        self.assertEqual(self.wt.path2id('oz/dorothy/toto'), 'toto-id')
 
391
        with open(self.wt.abspath('name'), 'r') as f:
 
392
            self.assertEqual('contents', f.read())
 
393
        self.assertEqual(self.wt.path2id('name'), b'my_pretties')
 
394
        self.assertIs(self.wt.is_executable('name'), True)
 
395
        self.assertEqual(self.wt.path2id('oz'), b'oz-id')
 
396
        self.assertEqual(self.wt.path2id('oz/dorothy'), b'dorothy-id')
 
397
        self.assertEqual(self.wt.path2id('oz/dorothy/toto'), b'toto-id')
228
398
 
229
 
        self.assertEqual('toto-contents',
230
 
                         self.wt.get_file_byname('oz/dorothy/toto').read())
231
 
        self.assertIs(self.wt.is_executable('toto-id'), False)
 
399
        self.assertEqual(b'toto-contents',
 
400
                         self.wt.get_file('oz/dorothy/toto').read())
 
401
        self.assertIs(self.wt.is_executable('oz/dorothy/toto'), False)
232
402
 
233
403
    def test_tree_reference(self):
234
404
        transform, root = self.get_transform()
235
405
        tree = transform._tree
236
 
        trans_id = transform.new_directory('reference', root, 'subtree-id')
237
 
        transform.set_tree_reference('subtree-revision', trans_id)
 
406
        trans_id = transform.new_directory('reference', root, b'subtree-id')
 
407
        transform.set_tree_reference(b'subtree-revision', trans_id)
238
408
        transform.apply()
239
409
        tree.lock_read()
240
410
        self.addCleanup(tree.unlock)
241
 
        self.assertEqual('subtree-revision',
242
 
                         tree.inventory['subtree-id'].reference_revision)
 
411
        self.assertEqual(
 
412
            b'subtree-revision',
 
413
            tree.root_inventory.get_entry(b'subtree-id').reference_revision)
243
414
 
244
415
    def test_conflicts(self):
245
416
        transform, root = self.get_transform()
246
 
        trans_id = transform.new_file('name', root, 'contents',
247
 
                                      'my_pretties')
 
417
        trans_id = transform.new_file('name', root, [b'contents'],
 
418
                                      b'my_pretties')
248
419
        self.assertEqual(len(transform.find_conflicts()), 0)
249
 
        trans_id2 = transform.new_file('name', root, 'Crontents', 'toto')
 
420
        trans_id2 = transform.new_file('name', root, [b'Crontents'], b'toto')
250
421
        self.assertEqual(transform.find_conflicts(),
251
422
                         [('duplicate', trans_id, trans_id2, 'name')])
252
423
        self.assertRaises(MalformedTransform, transform.apply)
266
437
        self.assertEqual(transform.find_conflicts(),
267
438
                         [('unversioned parent', lion_id),
268
439
                          ('missing parent', lion_id)])
269
 
        transform.version_file("Courage", lion_id)
 
440
        transform.version_file(b"Courage", lion_id)
270
441
        self.assertEqual(transform.find_conflicts(),
271
442
                         [('missing parent', lion_id),
272
443
                          ('versioning no contents', lion_id)])
273
444
        transform.adjust_path('name2', root, trans_id2)
274
445
        self.assertEqual(transform.find_conflicts(),
275
446
                         [('versioning no contents', lion_id)])
276
 
        transform.create_file('Contents, okay?', lion_id)
 
447
        transform.create_file([b'Contents, okay?'], lion_id)
277
448
        transform.adjust_path('name2', trans_id2, trans_id2)
278
449
        self.assertEqual(transform.find_conflicts(),
279
450
                         [('parent loop', trans_id2),
283
454
        transform.set_executability(True, oz_id)
284
455
        self.assertEqual(transform.find_conflicts(),
285
456
                         [('unversioned executability', oz_id)])
286
 
        transform.version_file('oz-id', oz_id)
 
457
        transform.version_file(b'oz-id', oz_id)
287
458
        self.assertEqual(transform.find_conflicts(),
288
459
                         [('non-file executability', oz_id)])
289
460
        transform.set_executability(None, oz_id)
290
 
        tip_id = transform.new_file('tip', oz_id, 'ozma', 'tip-id')
 
461
        tip_id = transform.new_file('tip', oz_id, [b'ozma'], b'tip-id')
291
462
        transform.apply()
292
 
        self.assertEqual(self.wt.path2id('name'), 'my_pretties')
293
 
        self.assertEqual('contents', file(self.wt.abspath('name')).read())
 
463
        self.assertEqual(self.wt.path2id('name'), b'my_pretties')
 
464
        with open(self.wt.abspath('name'), 'rb') as f:
 
465
            self.assertEqual(b'contents', f.read())
294
466
        transform2, root = self.get_transform()
295
 
        oz_id = transform2.trans_id_tree_file_id('oz-id')
296
 
        newtip = transform2.new_file('tip', oz_id, 'other', 'tip-id')
 
467
        oz_id = transform2.trans_id_tree_path('oz')
 
468
        newtip = transform2.new_file('tip', oz_id, [b'other'], b'tip-id')
297
469
        result = transform2.find_conflicts()
298
470
        fp = FinalPaths(transform2)
299
 
        self.assert_('oz/tip' in transform2._tree_path_ids)
 
471
        self.assertTrue('oz/tip' in transform2._tree_path_ids)
300
472
        self.assertEqual(fp.get_path(newtip), pathjoin('oz', 'tip'))
301
473
        self.assertEqual(len(result), 2)
302
474
        self.assertEqual((result[0][0], result[0][1]),
306
478
        transform2.finalize()
307
479
        transform3 = TreeTransform(self.wt)
308
480
        self.addCleanup(transform3.finalize)
309
 
        oz_id = transform3.trans_id_tree_file_id('oz-id')
 
481
        oz_id = transform3.trans_id_tree_path('oz')
310
482
        transform3.delete_contents(oz_id)
311
483
        self.assertEqual(transform3.find_conflicts(),
312
484
                         [('missing parent', oz_id)])
313
485
        root_id = transform3.root
314
 
        tip_id = transform3.trans_id_tree_file_id('tip-id')
 
486
        tip_id = transform3.trans_id_tree_path('oz/tip')
315
487
        transform3.adjust_path('tip', root_id, tip_id)
316
488
        transform3.apply()
317
489
 
323
495
        tree.case_sensitive = True
324
496
        transform = TreeTransform(tree)
325
497
        self.addCleanup(transform.finalize)
326
 
        transform.new_file('file', transform.root, 'content')
327
 
        transform.new_file('FiLe', transform.root, 'content')
 
498
        transform.new_file('file', transform.root, [b'content'])
 
499
        transform.new_file('FiLe', transform.root, [b'content'])
328
500
        result = transform.find_conflicts()
329
501
        self.assertEqual([], result)
330
502
        transform.finalize()
333
505
        tree.case_sensitive = False
334
506
        transform = TreeTransform(tree)
335
507
        self.addCleanup(transform.finalize)
336
 
        transform.new_file('file', transform.root, 'content')
337
 
        transform.new_file('FiLe', transform.root, 'content')
 
508
        transform.new_file('file', transform.root, [b'content'])
 
509
        transform.new_file('FiLe', transform.root, [b'content'])
338
510
        result = transform.find_conflicts()
339
511
        self.assertEqual([('duplicate', 'new-1', 'new-2', 'file')], result)
340
512
 
347
519
        tree.case_sensitive = True
348
520
        transform = TreeTransform(tree)
349
521
        self.addCleanup(transform.finalize)
350
 
        transform.new_file('file', transform.root, 'content')
 
522
        transform.new_file('file', transform.root, [b'content'])
351
523
        result = transform.find_conflicts()
352
524
        self.assertEqual([], result)
353
525
        transform.finalize()
356
528
        tree.case_sensitive = False
357
529
        transform = TreeTransform(tree)
358
530
        self.addCleanup(transform.finalize)
359
 
        transform.new_file('file', transform.root, 'content')
 
531
        transform.new_file('file', transform.root, [b'content'])
360
532
        result = transform.find_conflicts()
361
533
        self.assertEqual([('duplicate', 'new-1', 'new-2', 'file')], result)
362
534
 
368
540
        tree.case_sensitive = False
369
541
        transform = TreeTransform(tree)
370
542
        self.addCleanup(transform.finalize)
371
 
        transform.new_file('file', transform.root, 'content')
372
 
        transform.new_file('FiLe', transform.root, 'content')
 
543
        transform.new_file('file', transform.root, [b'content'])
 
544
        transform.new_file('FiLe', transform.root, [b'content'])
373
545
        resolve_conflicts(transform)
374
546
        transform.apply()
375
 
        self.failUnlessExists('tree/file')
376
 
        self.failUnlessExists('tree/FiLe.moved')
 
547
        self.assertPathExists('tree/file')
 
548
        self.assertPathExists('tree/FiLe.moved')
377
549
 
378
550
    def test_resolve_checkout_case_conflict(self):
379
551
        tree = self.make_branch_and_tree('tree')
383
555
        tree.case_sensitive = False
384
556
        transform = TreeTransform(tree)
385
557
        self.addCleanup(transform.finalize)
386
 
        transform.new_file('file', transform.root, 'content')
387
 
        transform.new_file('FiLe', transform.root, 'content')
 
558
        transform.new_file('file', transform.root, [b'content'])
 
559
        transform.new_file('FiLe', transform.root, [b'content'])
388
560
        resolve_conflicts(transform,
389
561
                          pass_func=lambda t, c: resolve_checkout(t, c, []))
390
562
        transform.apply()
391
 
        self.failUnlessExists('tree/file')
392
 
        self.failUnlessExists('tree/FiLe.moved')
 
563
        self.assertPathExists('tree/file')
 
564
        self.assertPathExists('tree/FiLe.moved')
393
565
 
394
566
    def test_apply_case_conflict(self):
395
567
        """Ensure that a transform with case conflicts can always be applied"""
396
568
        tree = self.make_branch_and_tree('tree')
397
569
        transform = TreeTransform(tree)
398
570
        self.addCleanup(transform.finalize)
399
 
        transform.new_file('file', transform.root, 'content')
400
 
        transform.new_file('FiLe', transform.root, 'content')
 
571
        transform.new_file('file', transform.root, [b'content'])
 
572
        transform.new_file('FiLe', transform.root, [b'content'])
401
573
        dir = transform.new_directory('dir', transform.root)
402
 
        transform.new_file('dirfile', dir, 'content')
403
 
        transform.new_file('dirFiLe', dir, 'content')
 
574
        transform.new_file('dirfile', dir, [b'content'])
 
575
        transform.new_file('dirFiLe', dir, [b'content'])
404
576
        resolve_conflicts(transform)
405
577
        transform.apply()
406
 
        self.failUnlessExists('tree/file')
 
578
        self.assertPathExists('tree/file')
407
579
        if not os.path.exists('tree/FiLe.moved'):
408
 
            self.failUnlessExists('tree/FiLe')
409
 
        self.failUnlessExists('tree/dir/dirfile')
 
580
            self.assertPathExists('tree/FiLe')
 
581
        self.assertPathExists('tree/dir/dirfile')
410
582
        if not os.path.exists('tree/dir/dirFiLe.moved'):
411
 
            self.failUnlessExists('tree/dir/dirFiLe')
 
583
            self.assertPathExists('tree/dir/dirFiLe')
412
584
 
413
585
    def test_case_insensitive_limbo(self):
414
586
        tree = self.make_branch_and_tree('tree')
418
590
        transform = TreeTransform(tree)
419
591
        self.addCleanup(transform.finalize)
420
592
        dir = transform.new_directory('dir', transform.root)
421
 
        first = transform.new_file('file', dir, 'content')
422
 
        second = transform.new_file('FiLe', dir, 'content')
 
593
        first = transform.new_file('file', dir, [b'content'])
 
594
        second = transform.new_file('FiLe', dir, [b'content'])
423
595
        self.assertContainsRe(transform._limbo_name(first), 'new-1/file')
424
596
        self.assertNotContainsRe(transform._limbo_name(second), 'new-1/FiLe')
425
597
 
437
609
 
438
610
    def test_add_del(self):
439
611
        start, root = self.get_transform()
440
 
        start.new_directory('a', root, 'a')
 
612
        start.new_directory('a', root, b'a')
441
613
        start.apply()
442
614
        transform, root = self.get_transform()
443
 
        transform.delete_versioned(transform.trans_id_tree_file_id('a'))
444
 
        transform.new_directory('a', root, 'a')
 
615
        transform.delete_versioned(transform.trans_id_tree_path('a'))
 
616
        transform.new_directory('a', root, b'a')
445
617
        transform.apply()
446
618
 
447
619
    def test_unversioning(self):
448
620
        create_tree, root = self.get_transform()
449
 
        parent_id = create_tree.new_directory('parent', root, 'parent-id')
450
 
        create_tree.new_file('child', parent_id, 'child', 'child-id')
 
621
        parent_id = create_tree.new_directory('parent', root, b'parent-id')
 
622
        create_tree.new_file('child', parent_id, [b'child'], b'child-id')
451
623
        create_tree.apply()
452
624
        unversion = TreeTransform(self.wt)
453
625
        self.addCleanup(unversion.finalize)
455
627
        unversion.unversion_file(parent)
456
628
        self.assertEqual(unversion.find_conflicts(),
457
629
                         [('unversioned parent', parent_id)])
458
 
        file_id = unversion.trans_id_tree_file_id('child-id')
 
630
        file_id = unversion.trans_id_tree_path('parent/child')
459
631
        unversion.unversion_file(file_id)
460
632
        unversion.apply()
461
633
 
463
635
        create_tree, root = self.get_transform()
464
636
        # prepare tree
465
637
        root = create_tree.root
466
 
        create_tree.new_file('name1', root, 'hello1', 'name1')
467
 
        create_tree.new_file('name2', root, 'hello2', 'name2')
468
 
        ddir = create_tree.new_directory('dying_directory', root, 'ddir')
469
 
        create_tree.new_file('dying_file', ddir, 'goodbye1', 'dfile')
470
 
        create_tree.new_file('moving_file', ddir, 'later1', 'mfile')
471
 
        create_tree.new_file('moving_file2', root, 'later2', 'mfile2')
 
638
        create_tree.new_file('name1', root, [b'hello1'], b'name1')
 
639
        create_tree.new_file('name2', root, [b'hello2'], b'name2')
 
640
        ddir = create_tree.new_directory('dying_directory', root, b'ddir')
 
641
        create_tree.new_file('dying_file', ddir, [b'goodbye1'], b'dfile')
 
642
        create_tree.new_file('moving_file', ddir, [b'later1'], b'mfile')
 
643
        create_tree.new_file('moving_file2', root, [b'later2'], b'mfile2')
472
644
        create_tree.apply()
473
645
 
474
 
        mangle_tree,root = self.get_transform()
 
646
        mangle_tree, root = self.get_transform()
475
647
        root = mangle_tree.root
476
 
        #swap names
477
 
        name1 = mangle_tree.trans_id_tree_file_id('name1')
478
 
        name2 = mangle_tree.trans_id_tree_file_id('name2')
 
648
        # swap names
 
649
        name1 = mangle_tree.trans_id_tree_path('name1')
 
650
        name2 = mangle_tree.trans_id_tree_path('name2')
479
651
        mangle_tree.adjust_path('name2', root, name1)
480
652
        mangle_tree.adjust_path('name1', root, name2)
481
653
 
482
 
        #tests for deleting parent directories
483
 
        ddir = mangle_tree.trans_id_tree_file_id('ddir')
 
654
        # tests for deleting parent directories
 
655
        ddir = mangle_tree.trans_id_tree_path('dying_directory')
484
656
        mangle_tree.delete_contents(ddir)
485
 
        dfile = mangle_tree.trans_id_tree_file_id('dfile')
 
657
        dfile = mangle_tree.trans_id_tree_path('dying_directory/dying_file')
486
658
        mangle_tree.delete_versioned(dfile)
487
659
        mangle_tree.unversion_file(dfile)
488
 
        mfile = mangle_tree.trans_id_tree_file_id('mfile')
 
660
        mfile = mangle_tree.trans_id_tree_path('dying_directory/moving_file')
489
661
        mangle_tree.adjust_path('mfile', root, mfile)
490
662
 
491
 
        #tests for adding parent directories
492
 
        newdir = mangle_tree.new_directory('new_directory', root, 'newdir')
493
 
        mfile2 = mangle_tree.trans_id_tree_file_id('mfile2')
 
663
        # tests for adding parent directories
 
664
        newdir = mangle_tree.new_directory('new_directory', root, b'newdir')
 
665
        mfile2 = mangle_tree.trans_id_tree_path('moving_file2')
494
666
        mangle_tree.adjust_path('mfile2', newdir, mfile2)
495
 
        mangle_tree.new_file('newfile', newdir, 'hello3', 'dfile')
496
 
        self.assertEqual(mangle_tree.final_file_id(mfile2), 'mfile2')
 
667
        mangle_tree.new_file('newfile', newdir, [b'hello3'], b'dfile')
 
668
        self.assertEqual(mangle_tree.final_file_id(mfile2), b'mfile2')
497
669
        self.assertEqual(mangle_tree.final_parent(mfile2), newdir)
498
 
        self.assertEqual(mangle_tree.final_file_id(mfile2), 'mfile2')
 
670
        self.assertEqual(mangle_tree.final_file_id(mfile2), b'mfile2')
499
671
        mangle_tree.apply()
500
 
        self.assertEqual(file(self.wt.abspath('name1')).read(), 'hello2')
501
 
        self.assertEqual(file(self.wt.abspath('name2')).read(), 'hello1')
502
 
        mfile2_path = self.wt.abspath(pathjoin('new_directory','mfile2'))
 
672
        with open(self.wt.abspath('name1'), 'r') as f:
 
673
            self.assertEqual(f.read(), 'hello2')
 
674
        with open(self.wt.abspath('name2'), 'r') as f:
 
675
            self.assertEqual(f.read(), 'hello1')
 
676
        mfile2_path = self.wt.abspath(pathjoin('new_directory', 'mfile2'))
503
677
        self.assertEqual(mangle_tree.final_parent(mfile2), newdir)
504
 
        self.assertEqual(file(mfile2_path).read(), 'later2')
505
 
        self.assertEqual(self.wt.id2path('mfile2'), 'new_directory/mfile2')
506
 
        self.assertEqual(self.wt.path2id('new_directory/mfile2'), 'mfile2')
507
 
        newfile_path = self.wt.abspath(pathjoin('new_directory','newfile'))
508
 
        self.assertEqual(file(newfile_path).read(), 'hello3')
509
 
        self.assertEqual(self.wt.path2id('dying_directory'), 'ddir')
 
678
        with open(mfile2_path, 'r') as f:
 
679
            self.assertEqual(f.read(), 'later2')
 
680
        self.assertEqual(self.wt.id2path(b'mfile2'), 'new_directory/mfile2')
 
681
        self.assertEqual(self.wt.path2id('new_directory/mfile2'), b'mfile2')
 
682
        newfile_path = self.wt.abspath(pathjoin('new_directory', 'newfile'))
 
683
        with open(newfile_path, 'r') as f:
 
684
            self.assertEqual(f.read(), 'hello3')
 
685
        self.assertEqual(self.wt.path2id('dying_directory'), b'ddir')
510
686
        self.assertIs(self.wt.path2id('dying_directory/dying_file'), None)
511
 
        mfile2_path = self.wt.abspath(pathjoin('new_directory','mfile2'))
 
687
        mfile2_path = self.wt.abspath(pathjoin('new_directory', 'mfile2'))
512
688
 
513
689
    def test_both_rename(self):
514
 
        create_tree,root = self.get_transform()
515
 
        newdir = create_tree.new_directory('selftest', root, 'selftest-id')
516
 
        create_tree.new_file('blackbox.py', newdir, 'hello1', 'blackbox-id')
 
690
        create_tree, root = self.get_transform()
 
691
        newdir = create_tree.new_directory('selftest', root, b'selftest-id')
 
692
        create_tree.new_file('blackbox.py', newdir, [
 
693
                             b'hello1'], b'blackbox-id')
517
694
        create_tree.apply()
518
 
        mangle_tree,root = self.get_transform()
519
 
        selftest = mangle_tree.trans_id_tree_file_id('selftest-id')
520
 
        blackbox = mangle_tree.trans_id_tree_file_id('blackbox-id')
 
695
        mangle_tree, root = self.get_transform()
 
696
        selftest = mangle_tree.trans_id_tree_path('selftest')
 
697
        blackbox = mangle_tree.trans_id_tree_path('selftest/blackbox.py')
521
698
        mangle_tree.adjust_path('test', root, selftest)
522
699
        mangle_tree.adjust_path('test_too_much', root, selftest)
523
700
        mangle_tree.set_executability(True, blackbox)
524
701
        mangle_tree.apply()
525
702
 
526
703
    def test_both_rename2(self):
527
 
        create_tree,root = self.get_transform()
528
 
        bzrlib = create_tree.new_directory('bzrlib', root, 'bzrlib-id')
529
 
        tests = create_tree.new_directory('tests', bzrlib, 'tests-id')
530
 
        blackbox = create_tree.new_directory('blackbox', tests, 'blackbox-id')
531
 
        create_tree.new_file('test_too_much.py', blackbox, 'hello1',
532
 
                             'test_too_much-id')
 
704
        create_tree, root = self.get_transform()
 
705
        breezy = create_tree.new_directory('breezy', root, b'breezy-id')
 
706
        tests = create_tree.new_directory('tests', breezy, b'tests-id')
 
707
        blackbox = create_tree.new_directory('blackbox', tests, b'blackbox-id')
 
708
        create_tree.new_file('test_too_much.py', blackbox, [b'hello1'],
 
709
                             b'test_too_much-id')
533
710
        create_tree.apply()
534
 
        mangle_tree,root = self.get_transform()
535
 
        bzrlib = mangle_tree.trans_id_tree_file_id('bzrlib-id')
536
 
        tests = mangle_tree.trans_id_tree_file_id('tests-id')
537
 
        test_too_much = mangle_tree.trans_id_tree_file_id('test_too_much-id')
538
 
        mangle_tree.adjust_path('selftest', bzrlib, tests)
 
711
        mangle_tree, root = self.get_transform()
 
712
        breezy = mangle_tree.trans_id_tree_path('breezy')
 
713
        tests = mangle_tree.trans_id_tree_path('breezy/tests')
 
714
        test_too_much = mangle_tree.trans_id_tree_path(
 
715
            'breezy/tests/blackbox/test_too_much.py')
 
716
        mangle_tree.adjust_path('selftest', breezy, tests)
539
717
        mangle_tree.adjust_path('blackbox.py', tests, test_too_much)
540
718
        mangle_tree.set_executability(True, test_too_much)
541
719
        mangle_tree.apply()
542
720
 
543
721
    def test_both_rename3(self):
544
 
        create_tree,root = self.get_transform()
545
 
        tests = create_tree.new_directory('tests', root, 'tests-id')
546
 
        create_tree.new_file('test_too_much.py', tests, 'hello1',
547
 
                             'test_too_much-id')
 
722
        create_tree, root = self.get_transform()
 
723
        tests = create_tree.new_directory('tests', root, b'tests-id')
 
724
        create_tree.new_file('test_too_much.py', tests, [b'hello1'],
 
725
                             b'test_too_much-id')
548
726
        create_tree.apply()
549
 
        mangle_tree,root = self.get_transform()
550
 
        tests = mangle_tree.trans_id_tree_file_id('tests-id')
551
 
        test_too_much = mangle_tree.trans_id_tree_file_id('test_too_much-id')
 
727
        mangle_tree, root = self.get_transform()
 
728
        tests = mangle_tree.trans_id_tree_path('tests')
 
729
        test_too_much = mangle_tree.trans_id_tree_path(
 
730
            'tests/test_too_much.py')
552
731
        mangle_tree.adjust_path('selftest', root, tests)
553
732
        mangle_tree.adjust_path('blackbox.py', tests, test_too_much)
554
733
        mangle_tree.set_executability(True, test_too_much)
558
737
        create_tree, root = self.get_transform()
559
738
        # prepare tree
560
739
        root = create_tree.root
561
 
        create_tree.new_file('name1', root, 'hello1', 'name1')
 
740
        create_tree.new_file('name1', root, [b'hello1'], b'name1')
562
741
        create_tree.apply()
563
742
        delete_contents, root = self.get_transform()
564
 
        file = delete_contents.trans_id_tree_file_id('name1')
 
743
        file = delete_contents.trans_id_tree_path('name1')
565
744
        delete_contents.delete_contents(file)
566
745
        delete_contents.apply()
567
746
        move_id, root = self.get_transform()
568
 
        name1 = move_id.trans_id_tree_file_id('name1')
569
 
        newdir = move_id.new_directory('dir', root, 'newdir')
 
747
        name1 = move_id.trans_id_tree_path('name1')
 
748
        newdir = move_id.new_directory('dir', root, b'newdir')
570
749
        move_id.adjust_path('name2', newdir, name1)
571
750
        move_id.apply()
572
751
 
574
753
        create_tree, root = self.get_transform()
575
754
        # prepare tree
576
755
        root = create_tree.root
577
 
        create_tree.new_file('name1', root, 'hello1', 'name1')
 
756
        create_tree.new_file('name1', root, [b'hello1'], b'name1')
578
757
        create_tree.apply()
579
758
        delete_contents = TreeTransform(self.wt)
580
759
        self.addCleanup(delete_contents.finalize)
581
 
        file = delete_contents.trans_id_tree_file_id('name1')
 
760
        file = delete_contents.trans_id_tree_path('name1')
582
761
        delete_contents.delete_contents(file)
583
762
        delete_contents.apply()
584
763
        delete_contents.finalize()
585
764
        replace = TreeTransform(self.wt)
586
765
        self.addCleanup(replace.finalize)
587
 
        name2 = replace.new_file('name2', root, 'hello2', 'name1')
 
766
        name2 = replace.new_file('name2', root, [b'hello2'], b'name1')
588
767
        conflicts = replace.find_conflicts()
589
 
        name1 = replace.trans_id_tree_file_id('name1')
 
768
        name1 = replace.trans_id_tree_path('name1')
590
769
        self.assertEqual(conflicts, [('duplicate id', name1, name2)])
591
770
        resolve_conflicts(replace)
592
771
        replace.apply()
593
772
 
594
 
    def _test_symlinks(self, link_name1,link_target1,
 
773
    def _test_symlinks(self, link_name1, link_target1,
595
774
                       link_name2, link_target2):
596
775
 
597
 
        def ozpath(p): return 'oz/' + p
 
776
        def ozpath(p):
 
777
            return 'oz/' + p
598
778
 
599
779
        self.requireFeature(SymlinkFeature)
600
780
        transform, root = self.get_transform()
601
 
        oz_id = transform.new_directory('oz', root, 'oz-id')
602
 
        wizard = transform.new_symlink(link_name1, oz_id, link_target1,
603
 
                                       'wizard-id')
 
781
        oz_id = transform.new_directory('oz', root, b'oz-id')
 
782
        transform.new_symlink(link_name1, oz_id, link_target1, b'wizard-id')
604
783
        wiz_id = transform.create_path(link_name2, oz_id)
605
784
        transform.create_symlink(link_target2, wiz_id)
606
 
        transform.version_file('wiz-id2', wiz_id)
 
785
        transform.version_file(b'wiz-id2', wiz_id)
607
786
        transform.set_executability(True, wiz_id)
608
787
        self.assertEqual(transform.find_conflicts(),
609
788
                         [('non-file executability', wiz_id)])
610
789
        transform.set_executability(None, wiz_id)
611
790
        transform.apply()
612
 
        self.assertEqual(self.wt.path2id(ozpath(link_name1)), 'wizard-id')
 
791
        self.assertEqual(self.wt.path2id(ozpath(link_name1)), b'wizard-id')
613
792
        self.assertEqual('symlink',
614
793
                         file_kind(self.wt.abspath(ozpath(link_name1))))
615
794
        self.assertEqual(link_target2,
622
801
                            'wizard2', 'behind_curtain')
623
802
 
624
803
    def test_symlinks_unicode(self):
625
 
        self.requireFeature(tests.UnicodeFilenameFeature)
 
804
        self.requireFeature(features.UnicodeFilenameFeature)
626
805
        self._test_symlinks(u'\N{Euro Sign}wizard',
627
806
                            u'wizard-targ\N{Euro Sign}t',
628
807
                            u'\N{Euro Sign}wizard2',
629
808
                            u'b\N{Euro Sign}hind_curtain')
630
809
 
631
 
    def test_unable_create_symlink(self):
 
810
    def test_unsupported_symlink_no_conflict(self):
632
811
        def tt_helper():
633
812
            wt = self.make_branch_and_tree('.')
634
 
            tt = TreeTransform(wt)  # TreeTransform obtains write lock
635
 
            try:
636
 
                tt.new_symlink('foo', tt.root, 'bar')
637
 
                tt.apply()
638
 
            finally:
639
 
                wt.unlock()
 
813
            tt = TreeTransform(wt)
 
814
            self.addCleanup(tt.finalize)
 
815
            tt.new_symlink('foo', tt.root, 'bar')
 
816
            result = tt.find_conflicts()
 
817
            self.assertEqual([], result)
640
818
        os_symlink = getattr(os, 'symlink', None)
641
819
        os.symlink = None
642
820
        try:
643
 
            err = self.assertRaises(errors.UnableCreateSymlink, tt_helper)
644
 
            self.assertEquals(
645
 
                "Unable to create symlink 'foo' on this platform",
646
 
                str(err))
 
821
            tt_helper()
647
822
        finally:
648
823
            if os_symlink:
649
824
                os.symlink = os_symlink
650
825
 
651
826
    def get_conflicted(self):
652
 
        create,root = self.get_transform()
653
 
        create.new_file('dorothy', root, 'dorothy', 'dorothy-id')
654
 
        oz = create.new_directory('oz', root, 'oz-id')
655
 
        create.new_directory('emeraldcity', oz, 'emerald-id')
 
827
        create, root = self.get_transform()
 
828
        create.new_file('dorothy', root, [b'dorothy'], b'dorothy-id')
 
829
        oz = create.new_directory('oz', root, b'oz-id')
 
830
        create.new_directory('emeraldcity', oz, b'emerald-id')
656
831
        create.apply()
657
 
        conflicts,root = self.get_transform()
 
832
        conflicts, root = self.get_transform()
658
833
        # set up duplicate entry, duplicate id
659
 
        new_dorothy = conflicts.new_file('dorothy', root, 'dorothy',
660
 
                                         'dorothy-id')
661
 
        old_dorothy = conflicts.trans_id_tree_file_id('dorothy-id')
662
 
        oz = conflicts.trans_id_tree_file_id('oz-id')
 
834
        new_dorothy = conflicts.new_file('dorothy', root, [b'dorothy'],
 
835
                                         b'dorothy-id')
 
836
        old_dorothy = conflicts.trans_id_tree_path('dorothy')
 
837
        oz = conflicts.trans_id_tree_path('oz')
663
838
        # set up DeletedParent parent conflict
664
839
        conflicts.delete_versioned(oz)
665
 
        emerald = conflicts.trans_id_tree_file_id('emerald-id')
 
840
        emerald = conflicts.trans_id_tree_path('oz/emeraldcity')
666
841
        # set up MissingParent conflict
667
 
        munchkincity = conflicts.trans_id_file_id('munchkincity-id')
 
842
        munchkincity = conflicts.trans_id_file_id(b'munchkincity-id')
668
843
        conflicts.adjust_path('munchkincity', root, munchkincity)
669
 
        conflicts.new_directory('auntem', munchkincity, 'auntem-id')
 
844
        conflicts.new_directory('auntem', munchkincity, b'auntem-id')
670
845
        # set up parent loop
671
846
        conflicts.adjust_path('emeraldcity', emerald, emerald)
672
847
        return conflicts, emerald, oz, old_dorothy, new_dorothy
678
853
        self.assertEqual(conflicts.final_name(old_dorothy), 'dorothy.moved')
679
854
        self.assertIs(conflicts.final_file_id(old_dorothy), None)
680
855
        self.assertEqual(conflicts.final_name(new_dorothy), 'dorothy')
681
 
        self.assertEqual(conflicts.final_file_id(new_dorothy), 'dorothy-id')
 
856
        self.assertEqual(conflicts.final_file_id(new_dorothy), b'dorothy-id')
682
857
        self.assertEqual(conflicts.final_parent(emerald), oz)
683
858
        conflicts.apply()
684
859
 
687
862
        raw_conflicts = resolve_conflicts(tt)
688
863
        cooked_conflicts = cook_conflicts(raw_conflicts, tt)
689
864
        duplicate = DuplicateEntry('Moved existing file to', 'dorothy.moved',
690
 
                                   'dorothy', None, 'dorothy-id')
 
865
                                   'dorothy', None, b'dorothy-id')
691
866
        self.assertEqual(cooked_conflicts[0], duplicate)
692
867
        duplicate_id = DuplicateID('Unversioned existing file',
693
868
                                   'dorothy.moved', 'dorothy', None,
694
 
                                   'dorothy-id')
 
869
                                   b'dorothy-id')
695
870
        self.assertEqual(cooked_conflicts[1], duplicate_id)
696
871
        missing_parent = MissingParent('Created directory', 'munchkincity',
697
 
                                       'munchkincity-id')
698
 
        deleted_parent = DeletingParent('Not deleting', 'oz', 'oz-id')
 
872
                                       b'munchkincity-id')
 
873
        deleted_parent = DeletingParent('Not deleting', 'oz', b'oz-id')
699
874
        self.assertEqual(cooked_conflicts[2], missing_parent)
700
875
        unversioned_parent = UnversionedParent('Versioned directory',
701
876
                                               'munchkincity',
702
 
                                               'munchkincity-id')
 
877
                                               b'munchkincity-id')
703
878
        unversioned_parent2 = UnversionedParent('Versioned directory', 'oz',
704
 
                                               'oz-id')
 
879
                                                b'oz-id')
705
880
        self.assertEqual(cooked_conflicts[3], unversioned_parent)
706
 
        parent_loop = ParentLoop('Cancelled move', 'oz/emeraldcity',
707
 
                                 'oz/emeraldcity', 'emerald-id', 'emerald-id')
 
881
        parent_loop = ParentLoop(
 
882
            'Cancelled move', 'oz/emeraldcity',
 
883
            'oz/emeraldcity', b'emerald-id', b'emerald-id')
708
884
        self.assertEqual(cooked_conflicts[4], deleted_parent)
709
885
        self.assertEqual(cooked_conflicts[5], unversioned_parent2)
710
886
        self.assertEqual(cooked_conflicts[6], parent_loop)
716
892
        raw_conflicts = resolve_conflicts(tt)
717
893
        cooked_conflicts = cook_conflicts(raw_conflicts, tt)
718
894
        tt.finalize()
719
 
        conflicts_s = [str(c) for c in cooked_conflicts]
 
895
        conflicts_s = [text_type(c) for c in cooked_conflicts]
720
896
        self.assertEqual(len(cooked_conflicts), len(conflicts_s))
721
897
        self.assertEqual(conflicts_s[0], 'Conflict adding file dorothy.  '
722
898
                                         'Moved existing file to '
729
905
        self.assertEqual(conflicts_s[3], 'Conflict because munchkincity is not'
730
906
                                         ' versioned, but has versioned'
731
907
                                         ' children.  Versioned directory.')
732
 
        self.assertEqualDiff(conflicts_s[4], "Conflict: can't delete oz because it"
733
 
                                         " is not empty.  Not deleting.")
 
908
        self.assertEqualDiff(
 
909
            conflicts_s[4], "Conflict: can't delete oz because it"
 
910
                            " is not empty.  Not deleting.")
734
911
        self.assertEqual(conflicts_s[5], 'Conflict because oz is not'
735
912
                                         ' versioned, but has versioned'
736
913
                                         ' children.  Versioned directory.')
739
916
 
740
917
    def prepare_wrong_parent_kind(self):
741
918
        tt, root = self.get_transform()
742
 
        tt.new_file('parent', root, 'contents', 'parent-id')
 
919
        tt.new_file('parent', root, [b'contents'], b'parent-id')
743
920
        tt.apply()
744
921
        tt, root = self.get_transform()
745
 
        parent_id = tt.trans_id_file_id('parent-id')
746
 
        tt.new_file('child,', parent_id, 'contents2', 'file-id')
 
922
        parent_id = tt.trans_id_file_id(b'parent-id')
 
923
        tt.new_file('child,', parent_id, [b'contents2'], b'file-id')
747
924
        return tt
748
925
 
749
926
    def test_find_conflicts_wrong_parent_kind(self):
753
930
    def test_resolve_conflicts_wrong_existing_parent_kind(self):
754
931
        tt = self.prepare_wrong_parent_kind()
755
932
        raw_conflicts = resolve_conflicts(tt)
756
 
        self.assertEqual(set([('non-directory parent', 'Created directory',
757
 
                         'new-3')]), raw_conflicts)
 
933
        self.assertEqual({('non-directory parent', 'Created directory',
 
934
                           'new-3')}, raw_conflicts)
758
935
        cooked_conflicts = cook_conflicts(raw_conflicts, tt)
759
936
        self.assertEqual([NonDirectoryParent('Created directory', 'parent.new',
760
 
        'parent-id')], cooked_conflicts)
 
937
                                             b'parent-id')], cooked_conflicts)
761
938
        tt.apply()
762
 
        self.assertEqual(None, self.wt.path2id('parent'))
763
 
        self.assertEqual('parent-id', self.wt.path2id('parent.new'))
 
939
        self.assertFalse(self.wt.is_versioned('parent'))
 
940
        self.assertEqual(b'parent-id', self.wt.path2id('parent.new'))
764
941
 
765
942
    def test_resolve_conflicts_wrong_new_parent_kind(self):
766
943
        tt, root = self.get_transform()
767
 
        parent_id = tt.new_directory('parent', root, 'parent-id')
768
 
        tt.new_file('child,', parent_id, 'contents2', 'file-id')
 
944
        parent_id = tt.new_directory('parent', root, b'parent-id')
 
945
        tt.new_file('child,', parent_id, [b'contents2'], b'file-id')
769
946
        tt.apply()
770
947
        tt, root = self.get_transform()
771
 
        parent_id = tt.trans_id_file_id('parent-id')
 
948
        parent_id = tt.trans_id_file_id(b'parent-id')
772
949
        tt.delete_contents(parent_id)
773
 
        tt.create_file('contents', parent_id)
 
950
        tt.create_file([b'contents'], parent_id)
774
951
        raw_conflicts = resolve_conflicts(tt)
775
 
        self.assertEqual(set([('non-directory parent', 'Created directory',
776
 
                         'new-3')]), raw_conflicts)
 
952
        self.assertEqual({('non-directory parent', 'Created directory',
 
953
                           'new-3')}, raw_conflicts)
777
954
        tt.apply()
778
 
        self.assertEqual(None, self.wt.path2id('parent'))
779
 
        self.assertEqual('parent-id', self.wt.path2id('parent.new'))
 
955
        self.assertFalse(self.wt.is_versioned('parent'))
 
956
        self.assertEqual(b'parent-id', self.wt.path2id('parent.new'))
780
957
 
781
958
    def test_resolve_conflicts_wrong_parent_kind_unversioned(self):
782
959
        tt, root = self.get_transform()
783
960
        parent_id = tt.new_directory('parent', root)
784
 
        tt.new_file('child,', parent_id, 'contents2')
 
961
        tt.new_file('child,', parent_id, [b'contents2'])
785
962
        tt.apply()
786
963
        tt, root = self.get_transform()
787
964
        parent_id = tt.trans_id_tree_path('parent')
788
965
        tt.delete_contents(parent_id)
789
 
        tt.create_file('contents', parent_id)
 
966
        tt.create_file([b'contents'], parent_id)
790
967
        resolve_conflicts(tt)
791
968
        tt.apply()
792
 
        self.assertIs(None, self.wt.path2id('parent'))
793
 
        self.assertIs(None, self.wt.path2id('parent.new'))
 
969
        self.assertFalse(self.wt.is_versioned('parent'))
 
970
        self.assertFalse(self.wt.is_versioned('parent.new'))
 
971
 
 
972
    def test_resolve_conflicts_missing_parent(self):
 
973
        wt = self.make_branch_and_tree('.')
 
974
        tt = TreeTransform(wt)
 
975
        self.addCleanup(tt.finalize)
 
976
        parent = tt.trans_id_file_id(b'parent-id')
 
977
        tt.new_file('file', parent, [b'Contents'])
 
978
        raw_conflicts = resolve_conflicts(tt)
 
979
        # Since the directory doesn't exist it's seen as 'missing'.  So
 
980
        # 'resolve_conflicts' create a conflict asking for it to be created.
 
981
        self.assertLength(1, raw_conflicts)
 
982
        self.assertEqual(('missing parent', 'Created directory', 'new-1'),
 
983
                         raw_conflicts.pop())
 
984
        # apply fail since the missing directory doesn't exist
 
985
        self.assertRaises(errors.NoFinalPath, tt.apply)
794
986
 
795
987
    def test_moving_versioned_directories(self):
796
988
        create, root = self.get_transform()
797
 
        kansas = create.new_directory('kansas', root, 'kansas-id')
798
 
        create.new_directory('house', kansas, 'house-id')
799
 
        create.new_directory('oz', root, 'oz-id')
 
989
        kansas = create.new_directory('kansas', root, b'kansas-id')
 
990
        create.new_directory('house', kansas, b'house-id')
 
991
        create.new_directory('oz', root, b'oz-id')
800
992
        create.apply()
801
993
        cyclone, root = self.get_transform()
802
 
        oz = cyclone.trans_id_tree_file_id('oz-id')
803
 
        house = cyclone.trans_id_tree_file_id('house-id')
 
994
        oz = cyclone.trans_id_tree_path('oz')
 
995
        house = cyclone.trans_id_tree_path('house')
804
996
        cyclone.adjust_path('house', oz, house)
805
997
        cyclone.apply()
806
998
 
807
999
    def test_moving_root(self):
808
1000
        create, root = self.get_transform()
809
 
        fun = create.new_directory('fun', root, 'fun-id')
810
 
        create.new_directory('sun', root, 'sun-id')
811
 
        create.new_directory('moon', root, 'moon')
 
1001
        fun = create.new_directory('fun', root, b'fun-id')
 
1002
        create.new_directory('sun', root, b'sun-id')
 
1003
        create.new_directory('moon', root, b'moon')
812
1004
        create.apply()
813
1005
        transform, root = self.get_transform()
814
1006
        transform.adjust_root_path('oldroot', fun)
815
1007
        new_root = transform.trans_id_tree_path('')
816
 
        transform.version_file('new-root', new_root)
 
1008
        transform.version_file(b'new-root', new_root)
817
1009
        transform.apply()
818
1010
 
819
1011
    def test_renames(self):
820
1012
        create, root = self.get_transform()
821
 
        old = create.new_directory('old-parent', root, 'old-id')
822
 
        intermediate = create.new_directory('intermediate', old, 'im-id')
823
 
        myfile = create.new_file('myfile', intermediate, 'myfile-text',
824
 
                                 'myfile-id')
 
1013
        old = create.new_directory('old-parent', root, b'old-id')
 
1014
        intermediate = create.new_directory('intermediate', old, b'im-id')
 
1015
        myfile = create.new_file('myfile', intermediate, [b'myfile-text'],
 
1016
                                 b'myfile-id')
825
1017
        create.apply()
826
1018
        rename, root = self.get_transform()
827
 
        old = rename.trans_id_file_id('old-id')
 
1019
        old = rename.trans_id_file_id(b'old-id')
828
1020
        rename.adjust_path('new', root, old)
829
 
        myfile = rename.trans_id_file_id('myfile-id')
 
1021
        myfile = rename.trans_id_file_id(b'myfile-id')
830
1022
        rename.set_executability(True, myfile)
831
1023
        rename.apply()
832
1024
 
 
1025
    def test_rename_fails(self):
 
1026
        self.requireFeature(features.not_running_as_root)
 
1027
        # see https://bugs.launchpad.net/bzr/+bug/491763
 
1028
        create, root_id = self.get_transform()
 
1029
        create.new_directory('first-dir', root_id, b'first-id')
 
1030
        create.new_file('myfile', root_id, [b'myfile-text'], b'myfile-id')
 
1031
        create.apply()
 
1032
        if os.name == "posix" and sys.platform != "cygwin":
 
1033
            # posix filesystems fail on renaming if the readonly bit is set
 
1034
            osutils.make_readonly(self.wt.abspath('first-dir'))
 
1035
        elif os.name == "nt":
 
1036
            # windows filesystems fail on renaming open files
 
1037
            self.addCleanup(open(self.wt.abspath('myfile')).close)
 
1038
        else:
 
1039
            self.skipTest("Can't force a permissions error on rename")
 
1040
        # now transform to rename
 
1041
        rename_transform, root_id = self.get_transform()
 
1042
        file_trans_id = rename_transform.trans_id_file_id(b'myfile-id')
 
1043
        dir_id = rename_transform.trans_id_file_id(b'first-id')
 
1044
        rename_transform.adjust_path('newname', dir_id, file_trans_id)
 
1045
        e = self.assertRaises(errors.TransformRenameFailed,
 
1046
                              rename_transform.apply)
 
1047
        # On nix looks like:
 
1048
        # "Failed to rename .../work/.bzr/checkout/limbo/new-1
 
1049
        # to .../first-dir/newname: [Errno 13] Permission denied"
 
1050
        # On windows looks like:
 
1051
        # "Failed to rename .../work/myfile to
 
1052
        # .../work/.bzr/checkout/limbo/new-1: [Errno 13] Permission denied"
 
1053
        # This test isn't concerned with exactly what the error looks like,
 
1054
        # and the strerror will vary across OS and locales, but the assert
 
1055
        # that the exeception attributes are what we expect
 
1056
        self.assertEqual(e.errno, errno.EACCES)
 
1057
        if os.name == "posix":
 
1058
            self.assertEndsWith(e.to_path, "/first-dir/newname")
 
1059
        else:
 
1060
            self.assertEqual(os.path.basename(e.from_path), "myfile")
 
1061
 
833
1062
    def test_set_executability_order(self):
834
1063
        """Ensure that executability behaves the same, no matter what order.
835
1064
 
836
1065
        - create file and set executability simultaneously
837
1066
        - create file and set executability afterward
838
 
        - unsetting the executability of a file whose executability has not been
 
1067
        - unsetting the executability of a file whose executability has not
 
1068
          been
839
1069
        declared should throw an exception (this may happen when a
840
1070
        merge attempts to create a file with a duplicate ID)
841
1071
        """
843
1073
        wt = transform._tree
844
1074
        wt.lock_read()
845
1075
        self.addCleanup(wt.unlock)
846
 
        transform.new_file('set_on_creation', root, 'Set on creation', 'soc',
847
 
                           True)
 
1076
        transform.new_file('set_on_creation', root, [b'Set on creation'],
 
1077
                           b'soc', True)
848
1078
        sac = transform.new_file('set_after_creation', root,
849
 
                                 'Set after creation', 'sac')
 
1079
                                 [b'Set after creation'], b'sac')
850
1080
        transform.set_executability(True, sac)
851
 
        uws = transform.new_file('unset_without_set', root, 'Unset badly',
852
 
                                 'uws')
 
1081
        uws = transform.new_file('unset_without_set', root, [b'Unset badly'],
 
1082
                                 b'uws')
853
1083
        self.assertRaises(KeyError, transform.set_executability, None, uws)
854
1084
        transform.apply()
855
 
        self.assertTrue(wt.is_executable('soc'))
856
 
        self.assertTrue(wt.is_executable('sac'))
 
1085
        self.assertTrue(wt.is_executable('set_on_creation'))
 
1086
        self.assertTrue(wt.is_executable('set_after_creation'))
857
1087
 
858
1088
    def test_preserve_mode(self):
859
1089
        """File mode is preserved when replacing content"""
860
1090
        if sys.platform == 'win32':
861
1091
            raise TestSkipped('chmod has no effect on win32')
862
1092
        transform, root = self.get_transform()
863
 
        transform.new_file('file1', root, 'contents', 'file1-id', True)
 
1093
        transform.new_file('file1', root, [b'contents'], b'file1-id', True)
864
1094
        transform.apply()
865
1095
        self.wt.lock_write()
866
1096
        self.addCleanup(self.wt.unlock)
867
 
        self.assertTrue(self.wt.is_executable('file1-id'))
 
1097
        self.assertTrue(self.wt.is_executable('file1'))
868
1098
        transform, root = self.get_transform()
869
 
        file1_id = transform.trans_id_tree_file_id('file1-id')
 
1099
        file1_id = transform.trans_id_tree_path('file1')
870
1100
        transform.delete_contents(file1_id)
871
 
        transform.create_file('contents2', file1_id)
 
1101
        transform.create_file([b'contents2'], file1_id)
872
1102
        transform.apply()
873
 
        self.assertTrue(self.wt.is_executable('file1-id'))
 
1103
        self.assertTrue(self.wt.is_executable('file1'))
874
1104
 
875
1105
    def test__set_mode_stats_correctly(self):
876
1106
        """_set_mode stats to determine file mode."""
879
1109
 
880
1110
        stat_paths = []
881
1111
        real_stat = os.stat
 
1112
 
882
1113
        def instrumented_stat(path):
883
1114
            stat_paths.append(path)
884
1115
            return real_stat(path)
885
1116
 
886
1117
        transform, root = self.get_transform()
887
1118
 
888
 
        bar1_id = transform.new_file('bar', root, 'bar contents 1\n',
889
 
                                     file_id='bar-id-1', executable=False)
 
1119
        bar1_id = transform.new_file('bar', root, [b'bar contents 1\n'],
 
1120
                                     file_id=b'bar-id-1', executable=False)
890
1121
        transform.apply()
891
1122
 
892
1123
        transform, root = self.get_transform()
894
1125
        bar2_id = transform.trans_id_tree_path('bar2')
895
1126
        try:
896
1127
            os.stat = instrumented_stat
897
 
            transform.create_file('bar2 contents\n', bar2_id, mode_id=bar1_id)
 
1128
            transform.create_file([b'bar2 contents\n'],
 
1129
                                  bar2_id, mode_id=bar1_id)
898
1130
        finally:
899
1131
            os.stat = real_stat
900
1132
            transform.finalize()
903
1135
        self.assertEqual([bar1_abspath], stat_paths)
904
1136
 
905
1137
    def test_iter_changes(self):
906
 
        self.wt.set_root_id('eert_toor')
 
1138
        self.wt.set_root_id(b'eert_toor')
907
1139
        transform, root = self.get_transform()
908
 
        transform.new_file('old', root, 'blah', 'id-1', True)
 
1140
        transform.new_file('old', root, [b'blah'], b'id-1', True)
909
1141
        transform.apply()
910
1142
        transform, root = self.get_transform()
911
1143
        try:
912
1144
            self.assertEqual([], list(transform.iter_changes()))
913
 
            old = transform.trans_id_tree_file_id('id-1')
 
1145
            old = transform.trans_id_tree_path('old')
914
1146
            transform.unversion_file(old)
915
 
            self.assertEqual([('id-1', ('old', None), False, (True, False),
916
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
917
 
                (True, True))], list(transform.iter_changes()))
918
 
            transform.new_directory('new', root, 'id-1')
919
 
            self.assertEqual([('id-1', ('old', 'new'), True, (True, True),
920
 
                ('eert_toor', 'eert_toor'), ('old', 'new'),
921
 
                ('file', 'directory'),
922
 
                (True, False))], list(transform.iter_changes()))
 
1147
            self.assertEqual([(b'id-1', ('old', None), False, (True, False),
 
1148
                               (b'eert_toor', b'eert_toor'),
 
1149
                               ('old', 'old'), ('file', 'file'),
 
1150
                               (True, True))], list(transform.iter_changes()))
 
1151
            transform.new_directory('new', root, b'id-1')
 
1152
            self.assertEqual([(b'id-1', ('old', 'new'), True, (True, True),
 
1153
                               (b'eert_toor', b'eert_toor'), ('old', 'new'),
 
1154
                               ('file', 'directory'),
 
1155
                               (True, False))], list(transform.iter_changes()))
923
1156
        finally:
924
1157
            transform.finalize()
925
1158
 
926
1159
    def test_iter_changes_new(self):
927
 
        self.wt.set_root_id('eert_toor')
 
1160
        self.wt.set_root_id(b'eert_toor')
928
1161
        transform, root = self.get_transform()
929
 
        transform.new_file('old', root, 'blah')
 
1162
        transform.new_file('old', root, [b'blah'])
930
1163
        transform.apply()
931
1164
        transform, root = self.get_transform()
932
1165
        try:
933
1166
            old = transform.trans_id_tree_path('old')
934
 
            transform.version_file('id-1', old)
935
 
            self.assertEqual([('id-1', (None, 'old'), False, (False, True),
936
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
937
 
                (False, False))], list(transform.iter_changes()))
 
1167
            transform.version_file(b'id-1', old)
 
1168
            self.assertEqual([(b'id-1', (None, 'old'), False, (False, True),
 
1169
                               (b'eert_toor', b'eert_toor'),
 
1170
                               ('old', 'old'), ('file', 'file'),
 
1171
                               (False, False))],
 
1172
                             list(transform.iter_changes()))
938
1173
        finally:
939
1174
            transform.finalize()
940
1175
 
941
1176
    def test_iter_changes_modifications(self):
942
 
        self.wt.set_root_id('eert_toor')
 
1177
        self.wt.set_root_id(b'eert_toor')
943
1178
        transform, root = self.get_transform()
944
 
        transform.new_file('old', root, 'blah', 'id-1')
945
 
        transform.new_file('new', root, 'blah')
946
 
        transform.new_directory('subdir', root, 'subdir-id')
 
1179
        transform.new_file('old', root, [b'blah'], b'id-1')
 
1180
        transform.new_file('new', root, [b'blah'])
 
1181
        transform.new_directory('subdir', root, b'subdir-id')
947
1182
        transform.apply()
948
1183
        transform, root = self.get_transform()
949
1184
        try:
950
1185
            old = transform.trans_id_tree_path('old')
951
 
            subdir = transform.trans_id_tree_file_id('subdir-id')
 
1186
            subdir = transform.trans_id_tree_path('subdir')
952
1187
            new = transform.trans_id_tree_path('new')
953
1188
            self.assertEqual([], list(transform.iter_changes()))
954
1189
 
955
 
            #content deletion
 
1190
            # content deletion
956
1191
            transform.delete_contents(old)
957
 
            self.assertEqual([('id-1', ('old', 'old'), True, (True, True),
958
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', None),
959
 
                (False, False))], list(transform.iter_changes()))
 
1192
            self.assertEqual([(b'id-1', ('old', 'old'), True, (True, True),
 
1193
                               (b'eert_toor', b'eert_toor'),
 
1194
                               ('old', 'old'), ('file', None),
 
1195
                               (False, False))],
 
1196
                             list(transform.iter_changes()))
960
1197
 
961
 
            #content change
962
 
            transform.create_file('blah', old)
963
 
            self.assertEqual([('id-1', ('old', 'old'), True, (True, True),
964
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
965
 
                (False, False))], list(transform.iter_changes()))
 
1198
            # content change
 
1199
            transform.create_file([b'blah'], old)
 
1200
            self.assertEqual([(b'id-1', ('old', 'old'), True, (True, True),
 
1201
                               (b'eert_toor', b'eert_toor'),
 
1202
                               ('old', 'old'), ('file', 'file'),
 
1203
                               (False, False))],
 
1204
                             list(transform.iter_changes()))
966
1205
            transform.cancel_deletion(old)
967
 
            self.assertEqual([('id-1', ('old', 'old'), True, (True, True),
968
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
969
 
                (False, False))], list(transform.iter_changes()))
 
1206
            self.assertEqual([(b'id-1', ('old', 'old'), True, (True, True),
 
1207
                               (b'eert_toor', b'eert_toor'),
 
1208
                               ('old', 'old'), ('file', 'file'),
 
1209
                               (False, False))],
 
1210
                             list(transform.iter_changes()))
970
1211
            transform.cancel_creation(old)
971
1212
 
972
1213
            # move file_id to a different file
973
1214
            self.assertEqual([], list(transform.iter_changes()))
974
1215
            transform.unversion_file(old)
975
 
            transform.version_file('id-1', new)
 
1216
            transform.version_file(b'id-1', new)
976
1217
            transform.adjust_path('old', root, new)
977
 
            self.assertEqual([('id-1', ('old', 'old'), True, (True, True),
978
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
979
 
                (False, False))], list(transform.iter_changes()))
 
1218
            self.assertEqual([(b'id-1', ('old', 'old'), True, (True, True),
 
1219
                               (b'eert_toor', b'eert_toor'),
 
1220
                               ('old', 'old'), ('file', 'file'),
 
1221
                               (False, False))],
 
1222
                             list(transform.iter_changes()))
980
1223
            transform.cancel_versioning(new)
981
1224
            transform._removed_id = set()
982
1225
 
983
 
            #execute bit
 
1226
            # execute bit
984
1227
            self.assertEqual([], list(transform.iter_changes()))
985
1228
            transform.set_executability(True, old)
986
 
            self.assertEqual([('id-1', ('old', 'old'), False, (True, True),
987
 
                ('eert_toor', 'eert_toor'), ('old', 'old'), ('file', 'file'),
988
 
                (False, True))], list(transform.iter_changes()))
 
1229
            self.assertEqual([(b'id-1', ('old', 'old'), False, (True, True),
 
1230
                               (b'eert_toor', b'eert_toor'),
 
1231
                               ('old', 'old'), ('file', 'file'),
 
1232
                               (False, True))],
 
1233
                             list(transform.iter_changes()))
989
1234
            transform.set_executability(None, old)
990
1235
 
991
1236
            # filename
992
1237
            self.assertEqual([], list(transform.iter_changes()))
993
1238
            transform.adjust_path('new', root, old)
994
1239
            transform._new_parent = {}
995
 
            self.assertEqual([('id-1', ('old', 'new'), False, (True, True),
996
 
                ('eert_toor', 'eert_toor'), ('old', 'new'), ('file', 'file'),
997
 
                (False, False))], list(transform.iter_changes()))
 
1240
            self.assertEqual([(b'id-1', ('old', 'new'), False, (True, True),
 
1241
                               (b'eert_toor', b'eert_toor'),
 
1242
                               ('old', 'new'), ('file', 'file'),
 
1243
                               (False, False))],
 
1244
                             list(transform.iter_changes()))
998
1245
            transform._new_name = {}
999
1246
 
1000
1247
            # parent directory
1001
1248
            self.assertEqual([], list(transform.iter_changes()))
1002
1249
            transform.adjust_path('new', subdir, old)
1003
1250
            transform._new_name = {}
1004
 
            self.assertEqual([('id-1', ('old', 'subdir/old'), False,
1005
 
                (True, True), ('eert_toor', 'subdir-id'), ('old', 'old'),
1006
 
                ('file', 'file'), (False, False))],
1007
 
                list(transform.iter_changes()))
 
1251
            self.assertEqual([(b'id-1', ('old', 'subdir/old'), False,
 
1252
                               (True, True), (b'eert_toor',
 
1253
                                              b'subdir-id'), ('old', 'old'),
 
1254
                               ('file', 'file'), (False, False))],
 
1255
                             list(transform.iter_changes()))
1008
1256
            transform._new_path = {}
1009
1257
 
1010
1258
        finally:
1011
1259
            transform.finalize()
1012
1260
 
1013
1261
    def test_iter_changes_modified_bleed(self):
1014
 
        self.wt.set_root_id('eert_toor')
 
1262
        self.wt.set_root_id(b'eert_toor')
1015
1263
        """Modified flag should not bleed from one change to another"""
1016
1264
        # unfortunately, we have no guarantee that file1 (which is modified)
1017
1265
        # will be applied before file2.  And if it's applied after file2, it
1018
1266
        # obviously can't bleed into file2's change output.  But for now, it
1019
1267
        # works.
1020
1268
        transform, root = self.get_transform()
1021
 
        transform.new_file('file1', root, 'blah', 'id-1')
1022
 
        transform.new_file('file2', root, 'blah', 'id-2')
 
1269
        transform.new_file('file1', root, [b'blah'], b'id-1')
 
1270
        transform.new_file('file2', root, [b'blah'], b'id-2')
1023
1271
        transform.apply()
1024
1272
        transform, root = self.get_transform()
1025
1273
        try:
1026
 
            transform.delete_contents(transform.trans_id_file_id('id-1'))
 
1274
            transform.delete_contents(transform.trans_id_file_id(b'id-1'))
1027
1275
            transform.set_executability(True,
1028
 
            transform.trans_id_file_id('id-2'))
1029
 
            self.assertEqual([('id-1', (u'file1', u'file1'), True, (True, True),
1030
 
                ('eert_toor', 'eert_toor'), ('file1', u'file1'),
1031
 
                ('file', None), (False, False)),
1032
 
                ('id-2', (u'file2', u'file2'), False, (True, True),
1033
 
                ('eert_toor', 'eert_toor'), ('file2', u'file2'),
1034
 
                ('file', 'file'), (False, True))],
 
1276
                                        transform.trans_id_file_id(b'id-2'))
 
1277
            self.assertEqual(
 
1278
                [(b'id-1', (u'file1', u'file1'), True, (True, True),
 
1279
                 (b'eert_toor', b'eert_toor'), ('file1', u'file1'),
 
1280
                 ('file', None), (False, False)),
 
1281
                 (b'id-2', (u'file2', u'file2'), False, (True, True),
 
1282
                 (b'eert_toor', b'eert_toor'), ('file2', u'file2'),
 
1283
                 ('file', 'file'), (False, True))],
1035
1284
                list(transform.iter_changes()))
1036
1285
        finally:
1037
1286
            transform.finalize()
1038
1287
 
1039
1288
    def test_iter_changes_move_missing(self):
1040
1289
        """Test moving ids with no files around"""
1041
 
        self.wt.set_root_id('toor_eert')
 
1290
        self.wt.set_root_id(b'toor_eert')
1042
1291
        # Need two steps because versioning a non-existant file is a conflict.
1043
1292
        transform, root = self.get_transform()
1044
 
        transform.new_directory('floater', root, 'floater-id')
 
1293
        transform.new_directory('floater', root, b'floater-id')
1045
1294
        transform.apply()
1046
1295
        transform, root = self.get_transform()
1047
1296
        transform.delete_contents(transform.trans_id_tree_path('floater'))
1050
1299
        floater = transform.trans_id_tree_path('floater')
1051
1300
        try:
1052
1301
            transform.adjust_path('flitter', root, floater)
1053
 
            self.assertEqual([('floater-id', ('floater', 'flitter'), False,
1054
 
            (True, True), ('toor_eert', 'toor_eert'), ('floater', 'flitter'),
1055
 
            (None, None), (False, False))], list(transform.iter_changes()))
 
1302
            self.assertEqual([(b'floater-id', ('floater', 'flitter'), False,
 
1303
                               (True, True),
 
1304
                               (b'toor_eert', b'toor_eert'),
 
1305
                               ('floater', 'flitter'),
 
1306
                               (None, None), (False, False))],
 
1307
                             list(transform.iter_changes()))
1056
1308
        finally:
1057
1309
            transform.finalize()
1058
1310
 
1059
1311
    def test_iter_changes_pointless(self):
1060
1312
        """Ensure that no-ops are not treated as modifications"""
1061
 
        self.wt.set_root_id('eert_toor')
 
1313
        self.wt.set_root_id(b'eert_toor')
1062
1314
        transform, root = self.get_transform()
1063
 
        transform.new_file('old', root, 'blah', 'id-1')
1064
 
        transform.new_directory('subdir', root, 'subdir-id')
 
1315
        transform.new_file('old', root, [b'blah'], b'id-1')
 
1316
        transform.new_directory('subdir', root, b'subdir-id')
1065
1317
        transform.apply()
1066
1318
        transform, root = self.get_transform()
1067
1319
        try:
1068
1320
            old = transform.trans_id_tree_path('old')
1069
 
            subdir = transform.trans_id_tree_file_id('subdir-id')
 
1321
            subdir = transform.trans_id_tree_path('subdir')
1070
1322
            self.assertEqual([], list(transform.iter_changes()))
1071
1323
            transform.delete_contents(subdir)
1072
1324
            transform.create_directory(subdir)
1073
1325
            transform.set_executability(False, old)
1074
1326
            transform.unversion_file(old)
1075
 
            transform.version_file('id-1', old)
 
1327
            transform.version_file(b'id-1', old)
1076
1328
            transform.adjust_path('old', root, old)
1077
1329
            self.assertEqual([], list(transform.iter_changes()))
1078
1330
        finally:
1080
1332
 
1081
1333
    def test_rename_count(self):
1082
1334
        transform, root = self.get_transform()
1083
 
        transform.new_file('name1', root, 'contents')
 
1335
        transform.new_file('name1', root, [b'contents'])
1084
1336
        self.assertEqual(transform.rename_count, 0)
1085
1337
        transform.apply()
1086
1338
        self.assertEqual(transform.rename_count, 1)
1103
1355
        """
1104
1356
        transform, root = self.get_transform()
1105
1357
        parent1 = transform.new_directory('parent1', root)
1106
 
        child1 = transform.new_file('child1', parent1, 'contents')
 
1358
        child1 = transform.new_file('child1', parent1, [b'contents'])
1107
1359
        parent2 = transform.new_directory('parent2', root)
1108
1360
        transform.adjust_path('child1', parent2, child1)
1109
1361
        transform.apply()
1110
 
        self.failIfExists(self.wt.abspath('parent1/child1'))
1111
 
        self.failUnlessExists(self.wt.abspath('parent2/child1'))
 
1362
        self.assertPathDoesNotExist(self.wt.abspath('parent1/child1'))
 
1363
        self.assertPathExists(self.wt.abspath('parent2/child1'))
1112
1364
        # rename limbo/new-1 => parent1, rename limbo/new-3 => parent2
1113
1365
        # no rename for child1 (counting only renames during apply)
1114
 
        self.failUnlessEqual(2, transform.rename_count)
 
1366
        self.assertEqual(2, transform.rename_count)
1115
1367
 
1116
1368
    def test_cancel_parent(self):
1117
1369
        """Cancelling a parent doesn't cause deletion of a non-empty directory
1122
1374
        """
1123
1375
        transform, root = self.get_transform()
1124
1376
        parent1 = transform.new_directory('parent1', root)
1125
 
        child1 = transform.new_file('child1', parent1, 'contents')
1126
 
        child2 = transform.new_file('child2', parent1, 'contents')
 
1377
        child1 = transform.new_file('child1', parent1, [b'contents'])
 
1378
        child2 = transform.new_file('child2', parent1, [b'contents'])
1127
1379
        try:
1128
1380
            transform.cancel_creation(parent1)
1129
1381
        except OSError:
1140
1392
        parent2 = transform.new_directory('parent2', root)
1141
1393
        transform.adjust_path('child1', parent2, child1)
1142
1394
        transform.apply()
1143
 
        self.failIfExists(self.wt.abspath('parent1'))
1144
 
        self.failUnlessExists(self.wt.abspath('parent2/child1'))
 
1395
        self.assertPathDoesNotExist(self.wt.abspath('parent1'))
 
1396
        self.assertPathExists(self.wt.abspath('parent2/child1'))
1145
1397
        # rename limbo/new-3 => parent2, rename limbo/new-2 => child1
1146
 
        self.failUnlessEqual(2, transform.rename_count)
 
1398
        self.assertEqual(2, transform.rename_count)
1147
1399
 
1148
1400
    def test_adjust_and_cancel(self):
1149
1401
        """Make sure adjust_path keeps track of limbo children properly"""
1150
1402
        transform, root = self.get_transform()
1151
1403
        parent1 = transform.new_directory('parent1', root)
1152
 
        child1 = transform.new_file('child1', parent1, 'contents')
 
1404
        child1 = transform.new_file('child1', parent1, [b'contents'])
1153
1405
        parent2 = transform.new_directory('parent2', root)
1154
1406
        transform.adjust_path('child1', parent2, child1)
1155
1407
        transform.cancel_creation(child1)
1164
1416
    def test_noname_contents(self):
1165
1417
        """TreeTransform should permit deferring naming files."""
1166
1418
        transform, root = self.get_transform()
1167
 
        parent = transform.trans_id_file_id('parent-id')
 
1419
        parent = transform.trans_id_file_id(b'parent-id')
1168
1420
        try:
1169
1421
            transform.create_directory(parent)
1170
1422
        except KeyError:
1174
1426
    def test_noname_contents_nested(self):
1175
1427
        """TreeTransform should permit deferring naming files."""
1176
1428
        transform, root = self.get_transform()
1177
 
        parent = transform.trans_id_file_id('parent-id')
 
1429
        parent = transform.trans_id_file_id(b'parent-id')
1178
1430
        try:
1179
1431
            transform.create_directory(parent)
1180
1432
        except KeyError:
1181
1433
            self.fail("Can't handle contents with no name")
1182
 
        child = transform.new_directory('child', parent)
 
1434
        transform.new_directory('child', parent)
1183
1435
        transform.adjust_path('parent', root, parent)
1184
1436
        transform.apply()
1185
 
        self.failUnlessExists(self.wt.abspath('parent/child'))
 
1437
        self.assertPathExists(self.wt.abspath('parent/child'))
1186
1438
        self.assertEqual(1, transform.rename_count)
1187
1439
 
1188
1440
    def test_reuse_name(self):
1189
1441
        """Avoid reusing the same limbo name for different files"""
1190
1442
        transform, root = self.get_transform()
1191
1443
        parent = transform.new_directory('parent', root)
1192
 
        child1 = transform.new_directory('child', parent)
 
1444
        transform.new_directory('child', parent)
1193
1445
        try:
1194
1446
            child2 = transform.new_directory('child', parent)
1195
1447
        except OSError:
1209
1461
        parent = transform.new_directory('parent', root)
1210
1462
        child1 = transform.new_directory('child', parent)
1211
1463
        transform.adjust_path('child1', parent, child1)
1212
 
        child2 = transform.new_directory('child', parent)
 
1464
        transform.new_directory('child', parent)
1213
1465
        transform.apply()
1214
1466
        # limbo/new-1 => parent
1215
1467
        self.assertEqual(1, transform.rename_count)
1221
1473
        child1 = transform.new_directory('child1', parent2)
1222
1474
        transform.cancel_creation(parent2)
1223
1475
        transform.create_directory(parent2)
1224
 
        child2 = transform.new_directory('child1', parent2)
 
1476
        transform.new_directory('child1', parent2)
1225
1477
        transform.adjust_path('child2', parent2, child1)
1226
1478
        transform.apply()
1227
1479
        # limbo/new-1 => parent2, limbo/new-2 => parent2/child1
1231
1483
        """Finalize must be done in child-to-parent order"""
1232
1484
        transform, root = self.get_transform()
1233
1485
        parent = transform.new_directory('parent', root)
1234
 
        child = transform.new_directory('child', parent)
 
1486
        transform.new_directory('child', parent)
1235
1487
        try:
1236
1488
            transform.finalize()
1237
1489
        except OSError:
1251
1503
            tt = TreeTransform(wt)  # TreeTransform obtains write lock
1252
1504
            try:
1253
1505
                foo = tt.new_directory('foo', tt.root)
1254
 
                tt.new_file('bar', foo, 'foobar')
 
1506
                tt.new_file('bar', foo, [b'foobar'])
1255
1507
                baz = tt.new_directory('baz', tt.root)
1256
 
                tt.new_file('qux', baz, 'quux')
 
1508
                tt.new_file('qux', baz, [b'quux'])
1257
1509
                # Ask for a rename 'foo' -> 'baz'
1258
1510
                tt.adjust_path('baz', tt.root, foo)
1259
1511
                # Lie to tt that we've already resolved all conflicts.
1260
1512
                tt.apply(no_conflicts=True)
1261
 
            except:
 
1513
            except BaseException:
1262
1514
                wt.unlock()
1263
1515
                raise
1264
1516
        # The rename will fail because the target directory is not empty (but
1265
1517
        # raises FileExists anyway).
1266
1518
        err = self.assertRaises(errors.FileExists, tt_helper)
1267
 
        self.assertContainsRe(str(err),
1268
 
            "^File exists: .+/baz")
 
1519
        self.assertEndsWith(err.path, "/baz")
1269
1520
 
1270
1521
    def test_two_directories_clash(self):
1271
1522
        def tt_helper():
1279
1530
                tt.new_directory('baz', foo_2)
1280
1531
                # Lie to tt that we've already resolved all conflicts.
1281
1532
                tt.apply(no_conflicts=True)
1282
 
            except:
 
1533
            except BaseException:
1283
1534
                wt.unlock()
1284
1535
                raise
1285
1536
        err = self.assertRaises(errors.FileExists, tt_helper)
1286
 
        self.assertContainsRe(str(err),
1287
 
            "^File exists: .+/foo")
 
1537
        self.assertEndsWith(err.path, "/foo")
1288
1538
 
1289
1539
    def test_two_directories_clash_finalize(self):
1290
1540
        def tt_helper():
1298
1548
                tt.new_directory('baz', foo_2)
1299
1549
                # Lie to tt that we've already resolved all conflicts.
1300
1550
                tt.apply(no_conflicts=True)
1301
 
            except:
 
1551
            except BaseException:
1302
1552
                tt.finalize()
1303
1553
                raise
1304
1554
        err = self.assertRaises(errors.FileExists, tt_helper)
1305
 
        self.assertContainsRe(str(err),
1306
 
            "^File exists: .+/foo")
 
1555
        self.assertEndsWith(err.path, "/foo")
1307
1556
 
1308
1557
    def test_file_to_directory(self):
1309
1558
        wt = self.make_branch_and_tree('.')
1316
1565
        tt.delete_contents(foo_trans_id)
1317
1566
        tt.create_directory(foo_trans_id)
1318
1567
        bar_trans_id = tt.trans_id_tree_path("foo/bar")
1319
 
        tt.create_file(["aa\n"], bar_trans_id)
1320
 
        tt.version_file("bar-1", bar_trans_id)
 
1568
        tt.create_file([b"aa\n"], bar_trans_id)
 
1569
        tt.version_file(b"bar-1", bar_trans_id)
1321
1570
        tt.apply()
1322
 
        self.failUnlessExists("foo/bar")
 
1571
        self.assertPathExists("foo/bar")
1323
1572
        wt.lock_read()
1324
1573
        try:
1325
 
            self.assertEqual(wt.inventory.get_file_kind(wt.path2id("foo")),
1326
 
                    "directory")
 
1574
            self.assertEqual(wt.kind("foo"), "directory")
1327
1575
        finally:
1328
1576
            wt.unlock()
1329
1577
        wt.commit("two")
1342
1590
        tt.delete_contents(foo_trans_id)
1343
1591
        tt.create_symlink("bar", foo_trans_id)
1344
1592
        tt.apply()
1345
 
        self.failUnlessExists("foo")
 
1593
        self.assertPathExists("foo")
1346
1594
        wt.lock_read()
1347
1595
        self.addCleanup(wt.unlock)
1348
 
        self.assertEqual(wt.inventory.get_file_kind(wt.path2id("foo")),
1349
 
                "symlink")
 
1596
        self.assertEqual(wt.kind("foo"), "symlink")
 
1597
 
 
1598
    def test_file_to_symlink_unsupported(self):
 
1599
        wt = self.make_branch_and_tree('.')
 
1600
        self.build_tree(['foo'])
 
1601
        wt.add(['foo'])
 
1602
        wt.commit("one")
 
1603
        self.overrideAttr(osutils, 'supports_symlinks', lambda p: False)
 
1604
        tt = TreeTransform(wt)
 
1605
        self.addCleanup(tt.finalize)
 
1606
        foo_trans_id = tt.trans_id_tree_path("foo")
 
1607
        tt.delete_contents(foo_trans_id)
 
1608
        log = BytesIO()
 
1609
        trace.push_log_file(log)
 
1610
        tt.create_symlink("bar", foo_trans_id)
 
1611
        tt.apply()
 
1612
        self.assertContainsRe(
 
1613
            log.getvalue(),
 
1614
            'Unable to create symlink "foo" on this filesystem')
1350
1615
 
1351
1616
    def test_dir_to_file(self):
1352
1617
        wt = self.make_branch_and_tree('.')
1359
1624
        bar_trans_id = tt.trans_id_tree_path("foo/bar")
1360
1625
        tt.delete_contents(foo_trans_id)
1361
1626
        tt.delete_versioned(bar_trans_id)
1362
 
        tt.create_file(["aa\n"], foo_trans_id)
 
1627
        tt.create_file([b"aa\n"], foo_trans_id)
1363
1628
        tt.apply()
1364
 
        self.failUnlessExists("foo")
 
1629
        self.assertPathExists("foo")
1365
1630
        wt.lock_read()
1366
1631
        self.addCleanup(wt.unlock)
1367
 
        self.assertEqual(wt.inventory.get_file_kind(wt.path2id("foo")),
1368
 
                "file")
 
1632
        self.assertEqual(wt.kind("foo"), "file")
1369
1633
 
1370
1634
    def test_dir_to_hardlink(self):
1371
1635
        self.requireFeature(HardlinkFeature)
1382
1646
        self.build_tree(['baz'])
1383
1647
        tt.create_hardlink("baz", foo_trans_id)
1384
1648
        tt.apply()
1385
 
        self.failUnlessExists("foo")
1386
 
        self.failUnlessExists("baz")
 
1649
        self.assertPathExists("foo")
 
1650
        self.assertPathExists("baz")
1387
1651
        wt.lock_read()
1388
1652
        self.addCleanup(wt.unlock)
1389
 
        self.assertEqual(wt.inventory.get_file_kind(wt.path2id("foo")),
1390
 
                "file")
 
1653
        self.assertEqual(wt.kind("foo"), "file")
1391
1654
 
1392
1655
    def test_no_final_path(self):
1393
1656
        transform, root = self.get_transform()
1394
 
        trans_id = transform.trans_id_file_id('foo')
1395
 
        transform.create_file('bar', trans_id)
 
1657
        trans_id = transform.trans_id_file_id(b'foo')
 
1658
        transform.create_file([b'bar'], trans_id)
1396
1659
        transform.cancel_creation(trans_id)
1397
1660
        transform.apply()
1398
1661
 
1399
1662
    def test_create_from_tree(self):
1400
1663
        tree1 = self.make_branch_and_tree('tree1')
1401
 
        self.build_tree_contents([('tree1/foo/',), ('tree1/bar', 'baz')])
1402
 
        tree1.add(['foo', 'bar'], ['foo-id', 'bar-id'])
 
1664
        self.build_tree_contents([('tree1/foo/',), ('tree1/bar', b'baz')])
 
1665
        tree1.add(['foo', 'bar'], [b'foo-id', b'bar-id'])
1403
1666
        tree2 = self.make_branch_and_tree('tree2')
1404
1667
        tt = TreeTransform(tree2)
1405
1668
        foo_trans_id = tt.create_path('foo', tt.root)
1406
 
        create_from_tree(tt, foo_trans_id, tree1, 'foo-id')
 
1669
        create_from_tree(tt, foo_trans_id, tree1, 'foo', file_id=b'foo-id')
1407
1670
        bar_trans_id = tt.create_path('bar', tt.root)
1408
 
        create_from_tree(tt, bar_trans_id, tree1, 'bar-id')
 
1671
        create_from_tree(tt, bar_trans_id, tree1, 'bar', file_id=b'bar-id')
1409
1672
        tt.apply()
1410
1673
        self.assertEqual('directory', osutils.file_kind('tree2/foo'))
1411
 
        self.assertFileEqual('baz', 'tree2/bar')
 
1674
        self.assertFileEqual(b'baz', 'tree2/bar')
1412
1675
 
1413
1676
    def test_create_from_tree_bytes(self):
1414
1677
        """Provided lines are used instead of tree content."""
1415
1678
        tree1 = self.make_branch_and_tree('tree1')
1416
 
        self.build_tree_contents([('tree1/foo', 'bar'),])
1417
 
        tree1.add('foo', 'foo-id')
 
1679
        self.build_tree_contents([('tree1/foo', b'bar'), ])
 
1680
        tree1.add('foo', b'foo-id')
1418
1681
        tree2 = self.make_branch_and_tree('tree2')
1419
1682
        tt = TreeTransform(tree2)
1420
1683
        foo_trans_id = tt.create_path('foo', tt.root)
1421
 
        create_from_tree(tt, foo_trans_id, tree1, 'foo-id', bytes='qux')
 
1684
        create_from_tree(tt, foo_trans_id, tree1, 'foo', file_id=b'foo-id',
 
1685
                         chunks=[b'qux'])
1422
1686
        tt.apply()
1423
 
        self.assertFileEqual('qux', 'tree2/foo')
 
1687
        self.assertFileEqual(b'qux', 'tree2/foo')
1424
1688
 
1425
1689
    def test_create_from_tree_symlink(self):
1426
1690
        self.requireFeature(SymlinkFeature)
1427
1691
        tree1 = self.make_branch_and_tree('tree1')
1428
1692
        os.symlink('bar', 'tree1/foo')
1429
 
        tree1.add('foo', 'foo-id')
 
1693
        tree1.add('foo', b'foo-id')
1430
1694
        tt = TreeTransform(self.make_branch_and_tree('tree2'))
1431
1695
        foo_trans_id = tt.create_path('foo', tt.root)
1432
 
        create_from_tree(tt, foo_trans_id, tree1, 'foo-id')
 
1696
        create_from_tree(tt, foo_trans_id, tree1, 'foo', file_id=b'foo-id')
1433
1697
        tt.apply()
1434
1698
        self.assertEqual('bar', os.readlink('tree2/foo'))
1435
1699
 
1439
1703
    def __init__(self, dirname, root_id):
1440
1704
        self.name = dirname
1441
1705
        os.mkdir(dirname)
1442
 
        self.wt = BzrDir.create_standalone_workingtree(dirname)
 
1706
        self.wt = ControlDir.create_standalone_workingtree(dirname)
1443
1707
        self.wt.set_root_id(root_id)
1444
1708
        self.b = self.wt.branch
1445
1709
        self.tt = TreeTransform(self.wt)
1446
 
        self.root = self.tt.trans_id_tree_file_id(self.wt.get_root_id())
 
1710
        self.root = self.tt.trans_id_tree_path('')
1447
1711
 
1448
1712
 
1449
1713
def conflict_text(tree, merge):
1450
 
    template = '%s TREE\n%s%s\n%s%s MERGE-SOURCE\n'
1451
 
    return template % ('<' * 7, tree, '=' * 7, merge, '>' * 7)
 
1714
    template = b'%s TREE\n%s%s\n%s%s MERGE-SOURCE\n'
 
1715
    return template % (b'<' * 7, tree, b'=' * 7, merge, b'>' * 7)
 
1716
 
 
1717
 
 
1718
class TestInventoryAltered(tests.TestCaseWithTransport):
 
1719
 
 
1720
    def test_inventory_altered_unchanged(self):
 
1721
        tree = self.make_branch_and_tree('tree')
 
1722
        self.build_tree(['tree/foo'])
 
1723
        tree.add('foo', b'foo-id')
 
1724
        with TransformPreview(tree) as tt:
 
1725
            self.assertEqual([], tt._inventory_altered())
 
1726
 
 
1727
    def test_inventory_altered_changed_parent_id(self):
 
1728
        tree = self.make_branch_and_tree('tree')
 
1729
        self.build_tree(['tree/foo'])
 
1730
        tree.add('foo', b'foo-id')
 
1731
        with TransformPreview(tree) as tt:
 
1732
            tt.unversion_file(tt.root)
 
1733
            tt.version_file(b'new-id', tt.root)
 
1734
            foo_trans_id = tt.trans_id_tree_path('foo')
 
1735
            foo_tuple = ('foo', foo_trans_id)
 
1736
            root_tuple = ('', tt.root)
 
1737
            self.assertEqual([root_tuple, foo_tuple], tt._inventory_altered())
 
1738
 
 
1739
    def test_inventory_altered_noop_changed_parent_id(self):
 
1740
        tree = self.make_branch_and_tree('tree')
 
1741
        self.build_tree(['tree/foo'])
 
1742
        tree.add('foo', b'foo-id')
 
1743
        with TransformPreview(tree) as tt:
 
1744
            tt.unversion_file(tt.root)
 
1745
            tt.version_file(tree.get_root_id(), tt.root)
 
1746
            tt.trans_id_tree_path('foo')
 
1747
            self.assertEqual([], tt._inventory_altered())
1452
1748
 
1453
1749
 
1454
1750
class TestTransformMerge(TestCaseInTempDir):
1456
1752
    def test_text_merge(self):
1457
1753
        root_id = generate_ids.gen_root_id()
1458
1754
        base = TransformGroup("base", root_id)
1459
 
        base.tt.new_file('a', base.root, 'a\nb\nc\nd\be\n', 'a')
1460
 
        base.tt.new_file('b', base.root, 'b1', 'b')
1461
 
        base.tt.new_file('c', base.root, 'c', 'c')
1462
 
        base.tt.new_file('d', base.root, 'd', 'd')
1463
 
        base.tt.new_file('e', base.root, 'e', 'e')
1464
 
        base.tt.new_file('f', base.root, 'f', 'f')
1465
 
        base.tt.new_directory('g', base.root, 'g')
1466
 
        base.tt.new_directory('h', base.root, 'h')
 
1755
        base.tt.new_file('a', base.root, [b'a\nb\nc\nd\be\n'], b'a')
 
1756
        base.tt.new_file('b', base.root, [b'b1'], b'b')
 
1757
        base.tt.new_file('c', base.root, [b'c'], b'c')
 
1758
        base.tt.new_file('d', base.root, [b'd'], b'd')
 
1759
        base.tt.new_file('e', base.root, [b'e'], b'e')
 
1760
        base.tt.new_file('f', base.root, [b'f'], b'f')
 
1761
        base.tt.new_directory('g', base.root, b'g')
 
1762
        base.tt.new_directory('h', base.root, b'h')
1467
1763
        base.tt.apply()
1468
1764
        other = TransformGroup("other", root_id)
1469
 
        other.tt.new_file('a', other.root, 'y\nb\nc\nd\be\n', 'a')
1470
 
        other.tt.new_file('b', other.root, 'b2', 'b')
1471
 
        other.tt.new_file('c', other.root, 'c2', 'c')
1472
 
        other.tt.new_file('d', other.root, 'd', 'd')
1473
 
        other.tt.new_file('e', other.root, 'e2', 'e')
1474
 
        other.tt.new_file('f', other.root, 'f', 'f')
1475
 
        other.tt.new_file('g', other.root, 'g', 'g')
1476
 
        other.tt.new_file('h', other.root, 'h\ni\nj\nk\n', 'h')
1477
 
        other.tt.new_file('i', other.root, 'h\ni\nj\nk\n', 'i')
 
1765
        other.tt.new_file('a', other.root, [b'y\nb\nc\nd\be\n'], b'a')
 
1766
        other.tt.new_file('b', other.root, [b'b2'], b'b')
 
1767
        other.tt.new_file('c', other.root, [b'c2'], b'c')
 
1768
        other.tt.new_file('d', other.root, [b'd'], b'd')
 
1769
        other.tt.new_file('e', other.root, [b'e2'], b'e')
 
1770
        other.tt.new_file('f', other.root, [b'f'], b'f')
 
1771
        other.tt.new_file('g', other.root, [b'g'], b'g')
 
1772
        other.tt.new_file('h', other.root, [b'h\ni\nj\nk\n'], b'h')
 
1773
        other.tt.new_file('i', other.root, [b'h\ni\nj\nk\n'], b'i')
1478
1774
        other.tt.apply()
1479
1775
        this = TransformGroup("this", root_id)
1480
 
        this.tt.new_file('a', this.root, 'a\nb\nc\nd\bz\n', 'a')
1481
 
        this.tt.new_file('b', this.root, 'b', 'b')
1482
 
        this.tt.new_file('c', this.root, 'c', 'c')
1483
 
        this.tt.new_file('d', this.root, 'd2', 'd')
1484
 
        this.tt.new_file('e', this.root, 'e2', 'e')
1485
 
        this.tt.new_file('f', this.root, 'f', 'f')
1486
 
        this.tt.new_file('g', this.root, 'g', 'g')
1487
 
        this.tt.new_file('h', this.root, '1\n2\n3\n4\n', 'h')
1488
 
        this.tt.new_file('i', this.root, '1\n2\n3\n4\n', 'i')
 
1776
        this.tt.new_file('a', this.root, [b'a\nb\nc\nd\bz\n'], b'a')
 
1777
        this.tt.new_file('b', this.root, [b'b'], b'b')
 
1778
        this.tt.new_file('c', this.root, [b'c'], b'c')
 
1779
        this.tt.new_file('d', this.root, [b'd2'], b'd')
 
1780
        this.tt.new_file('e', this.root, [b'e2'], b'e')
 
1781
        this.tt.new_file('f', this.root, [b'f'], b'f')
 
1782
        this.tt.new_file('g', this.root, [b'g'], b'g')
 
1783
        this.tt.new_file('h', this.root, [b'1\n2\n3\n4\n'], b'h')
 
1784
        this.tt.new_file('i', this.root, [b'1\n2\n3\n4\n'], b'i')
1489
1785
        this.tt.apply()
1490
1786
        Merge3Merger(this.wt, this.wt, base.wt, other.wt)
1491
1787
 
1492
1788
        # textual merge
1493
 
        self.assertEqual(this.wt.get_file('a').read(), 'y\nb\nc\nd\bz\n')
 
1789
        with this.wt.get_file(this.wt.id2path(b'a')) as f:
 
1790
            self.assertEqual(f.read(), b'y\nb\nc\nd\bz\n')
1494
1791
        # three-way text conflict
1495
 
        self.assertEqual(this.wt.get_file('b').read(),
1496
 
                         conflict_text('b', 'b2'))
 
1792
        with this.wt.get_file(this.wt.id2path(b'b')) as f:
 
1793
            self.assertEqual(f.read(), conflict_text(b'b', b'b2'))
1497
1794
        # OTHER wins
1498
 
        self.assertEqual(this.wt.get_file('c').read(), 'c2')
 
1795
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'c')).read(), b'c2')
1499
1796
        # THIS wins
1500
 
        self.assertEqual(this.wt.get_file('d').read(), 'd2')
 
1797
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'd')).read(), b'd2')
1501
1798
        # Ambigious clean merge
1502
 
        self.assertEqual(this.wt.get_file('e').read(), 'e2')
 
1799
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'e')).read(), b'e2')
1503
1800
        # No change
1504
 
        self.assertEqual(this.wt.get_file('f').read(), 'f')
 
1801
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'f')).read(), b'f')
1505
1802
        # Correct correct results when THIS == OTHER
1506
 
        self.assertEqual(this.wt.get_file('g').read(), 'g')
 
1803
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'g')).read(), b'g')
1507
1804
        # Text conflict when THIS & OTHER are text and BASE is dir
1508
 
        self.assertEqual(this.wt.get_file('h').read(),
1509
 
                         conflict_text('1\n2\n3\n4\n', 'h\ni\nj\nk\n'))
1510
 
        self.assertEqual(this.wt.get_file_byname('h.THIS').read(),
1511
 
                         '1\n2\n3\n4\n')
1512
 
        self.assertEqual(this.wt.get_file_byname('h.OTHER').read(),
1513
 
                         'h\ni\nj\nk\n')
 
1805
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'h')).read(),
 
1806
                         conflict_text(b'1\n2\n3\n4\n', b'h\ni\nj\nk\n'))
 
1807
        self.assertEqual(this.wt.get_file('h.THIS').read(),
 
1808
                         b'1\n2\n3\n4\n')
 
1809
        self.assertEqual(this.wt.get_file('h.OTHER').read(),
 
1810
                         b'h\ni\nj\nk\n')
1514
1811
        self.assertEqual(file_kind(this.wt.abspath('h.BASE')), 'directory')
1515
 
        self.assertEqual(this.wt.get_file('i').read(),
1516
 
                         conflict_text('1\n2\n3\n4\n', 'h\ni\nj\nk\n'))
1517
 
        self.assertEqual(this.wt.get_file_byname('i.THIS').read(),
1518
 
                         '1\n2\n3\n4\n')
1519
 
        self.assertEqual(this.wt.get_file_byname('i.OTHER').read(),
1520
 
                         'h\ni\nj\nk\n')
 
1812
        self.assertEqual(this.wt.get_file(this.wt.id2path(b'i')).read(),
 
1813
                         conflict_text(b'1\n2\n3\n4\n', b'h\ni\nj\nk\n'))
 
1814
        self.assertEqual(this.wt.get_file('i.THIS').read(),
 
1815
                         b'1\n2\n3\n4\n')
 
1816
        self.assertEqual(this.wt.get_file('i.OTHER').read(),
 
1817
                         b'h\ni\nj\nk\n')
1521
1818
        self.assertEqual(os.path.exists(this.wt.abspath('i.BASE')), False)
1522
 
        modified = ['a', 'b', 'c', 'h', 'i']
 
1819
        modified = [b'a', b'b', b'c', b'h', b'i']
1523
1820
        merge_modified = this.wt.merge_modified()
1524
1821
        self.assertSubset(merge_modified, modified)
1525
1822
        self.assertEqual(len(merge_modified), len(modified))
1526
 
        file(this.wt.id2abspath('a'), 'wb').write('booga')
 
1823
        with open(this.wt.abspath(this.wt.id2path(b'a')), 'wb') as f:
 
1824
            f.write(b'booga')
1527
1825
        modified.pop(0)
1528
1826
        merge_modified = this.wt.merge_modified()
1529
1827
        self.assertSubset(merge_modified, modified)
1538
1836
        this = TransformGroup("THIS", root_id)
1539
1837
        other = TransformGroup("OTHER", root_id)
1540
1838
        for tg in this, base, other:
1541
 
            tg.tt.new_directory('a', tg.root, 'a')
1542
 
            tg.tt.new_symlink('b', tg.root, 'b', 'b')
1543
 
            tg.tt.new_file('c', tg.root, 'c', 'c')
1544
 
            tg.tt.new_symlink('d', tg.root, tg.name, 'd')
 
1839
            tg.tt.new_directory('a', tg.root, b'a')
 
1840
            tg.tt.new_symlink('b', tg.root, 'b', b'b')
 
1841
            tg.tt.new_file('c', tg.root, [b'c'], b'c')
 
1842
            tg.tt.new_symlink('d', tg.root, tg.name, b'd')
1545
1843
        targets = ((base, 'base-e', 'base-f', None, None),
1546
1844
                   (this, 'other-e', 'this-f', 'other-g', 'this-h'),
1547
1845
                   (other, 'other-e', None, 'other-g', 'other-h'))
1549
1847
            for link, target in (('e', e_target), ('f', f_target),
1550
1848
                                 ('g', g_target), ('h', h_target)):
1551
1849
                if target is not None:
1552
 
                    tg.tt.new_symlink(link, tg.root, target, link)
 
1850
                    tg.tt.new_symlink(link, tg.root, target,
 
1851
                                      link.encode('ascii'))
1553
1852
 
1554
1853
        for tg in this, base, other:
1555
1854
            tg.tt.apply()
1558
1857
        self.assertIs(os.path.islink(this.wt.abspath('b')), True)
1559
1858
        self.assertIs(os.path.isfile(this.wt.abspath('c')), True)
1560
1859
        for suffix in ('THIS', 'BASE', 'OTHER'):
1561
 
            self.assertEqual(os.readlink(this.wt.abspath('d.'+suffix)), suffix)
 
1860
            self.assertEqual(os.readlink(
 
1861
                this.wt.abspath('d.' + suffix)), suffix)
1562
1862
        self.assertIs(os.path.lexists(this.wt.abspath('d')), False)
1563
 
        self.assertEqual(this.wt.id2path('d'), 'd.OTHER')
1564
 
        self.assertEqual(this.wt.id2path('f'), 'f.THIS')
 
1863
        self.assertEqual(this.wt.id2path(b'd'), 'd.OTHER')
 
1864
        self.assertEqual(this.wt.id2path(b'f'), 'f.THIS')
1565
1865
        self.assertEqual(os.readlink(this.wt.abspath('e')), 'other-e')
1566
1866
        self.assertIs(os.path.lexists(this.wt.abspath('e.THIS')), False)
1567
1867
        self.assertIs(os.path.lexists(this.wt.abspath('e.OTHER')), False)
1578
1878
        base = TransformGroup("BASE", root_id)
1579
1879
        this = TransformGroup("THIS", root_id)
1580
1880
        other = TransformGroup("OTHER", root_id)
1581
 
        base_a, this_a, other_a = [t.tt.new_directory('a', t.root, 'a')
1582
 
                                   for t in [base, this, other]]
1583
 
        base_b, this_b, other_b = [t.tt.new_directory('b', t.root, 'b')
1584
 
                                   for t in [base, this, other]]
1585
 
        base.tt.new_directory('c', base_a, 'c')
1586
 
        this.tt.new_directory('c1', this_a, 'c')
1587
 
        other.tt.new_directory('c', other_b, 'c')
1588
 
 
1589
 
        base.tt.new_directory('d', base_a, 'd')
1590
 
        this.tt.new_directory('d1', this_b, 'd')
1591
 
        other.tt.new_directory('d', other_a, 'd')
1592
 
 
1593
 
        base.tt.new_directory('e', base_a, 'e')
1594
 
        this.tt.new_directory('e', this_a, 'e')
1595
 
        other.tt.new_directory('e1', other_b, 'e')
1596
 
 
1597
 
        base.tt.new_directory('f', base_a, 'f')
1598
 
        this.tt.new_directory('f1', this_b, 'f')
1599
 
        other.tt.new_directory('f1', other_b, 'f')
 
1881
        base_a, this_a, other_a = [t.tt.new_directory('a', t.root, b'a')
 
1882
                                   for t in [base, this, other]]
 
1883
        base_b, this_b, other_b = [t.tt.new_directory('b', t.root, b'b')
 
1884
                                   for t in [base, this, other]]
 
1885
        base.tt.new_directory('c', base_a, b'c')
 
1886
        this.tt.new_directory('c1', this_a, b'c')
 
1887
        other.tt.new_directory('c', other_b, b'c')
 
1888
 
 
1889
        base.tt.new_directory('d', base_a, b'd')
 
1890
        this.tt.new_directory('d1', this_b, b'd')
 
1891
        other.tt.new_directory('d', other_a, b'd')
 
1892
 
 
1893
        base.tt.new_directory('e', base_a, b'e')
 
1894
        this.tt.new_directory('e', this_a, b'e')
 
1895
        other.tt.new_directory('e1', other_b, b'e')
 
1896
 
 
1897
        base.tt.new_directory('f', base_a, b'f')
 
1898
        this.tt.new_directory('f1', this_b, b'f')
 
1899
        other.tt.new_directory('f1', other_b, b'f')
1600
1900
 
1601
1901
        for tg in [this, base, other]:
1602
1902
            tg.tt.apply()
1603
1903
        Merge3Merger(this.wt, this.wt, base.wt, other.wt)
1604
 
        self.assertEqual(this.wt.id2path('c'), pathjoin('b/c1'))
1605
 
        self.assertEqual(this.wt.id2path('d'), pathjoin('b/d1'))
1606
 
        self.assertEqual(this.wt.id2path('e'), pathjoin('b/e1'))
1607
 
        self.assertEqual(this.wt.id2path('f'), pathjoin('b/f1'))
 
1904
        self.assertEqual(this.wt.id2path(b'c'), pathjoin('b/c1'))
 
1905
        self.assertEqual(this.wt.id2path(b'd'), pathjoin('b/d1'))
 
1906
        self.assertEqual(this.wt.id2path(b'e'), pathjoin('b/e1'))
 
1907
        self.assertEqual(this.wt.id2path(b'f'), pathjoin('b/f1'))
1608
1908
 
1609
1909
    def test_filename_merge_conflicts(self):
1610
1910
        root_id = generate_ids.gen_root_id()
1611
1911
        base = TransformGroup("BASE", root_id)
1612
1912
        this = TransformGroup("THIS", root_id)
1613
1913
        other = TransformGroup("OTHER", root_id)
1614
 
        base_a, this_a, other_a = [t.tt.new_directory('a', t.root, 'a')
1615
 
                                   for t in [base, this, other]]
1616
 
        base_b, this_b, other_b = [t.tt.new_directory('b', t.root, 'b')
1617
 
                                   for t in [base, this, other]]
1618
 
 
1619
 
        base.tt.new_file('g', base_a, 'g', 'g')
1620
 
        other.tt.new_file('g1', other_b, 'g1', 'g')
1621
 
 
1622
 
        base.tt.new_file('h', base_a, 'h', 'h')
1623
 
        this.tt.new_file('h1', this_b, 'h1', 'h')
1624
 
 
1625
 
        base.tt.new_file('i', base.root, 'i', 'i')
1626
 
        other.tt.new_directory('i1', this_b, 'i')
 
1914
        base_a, this_a, other_a = [t.tt.new_directory('a', t.root, b'a')
 
1915
                                   for t in [base, this, other]]
 
1916
        base_b, this_b, other_b = [t.tt.new_directory('b', t.root, b'b')
 
1917
                                   for t in [base, this, other]]
 
1918
 
 
1919
        base.tt.new_file('g', base_a, [b'g'], b'g')
 
1920
        other.tt.new_file('g1', other_b, [b'g1'], b'g')
 
1921
 
 
1922
        base.tt.new_file('h', base_a, [b'h'], b'h')
 
1923
        this.tt.new_file('h1', this_b, [b'h1'], b'h')
 
1924
 
 
1925
        base.tt.new_file('i', base.root, [b'i'], b'i')
 
1926
        other.tt.new_directory('i1', this_b, b'i')
1627
1927
 
1628
1928
        for tg in [this, base, other]:
1629
1929
            tg.tt.apply()
1630
1930
        Merge3Merger(this.wt, this.wt, base.wt, other.wt)
1631
1931
 
1632
 
        self.assertEqual(this.wt.id2path('g'), pathjoin('b/g1.OTHER'))
 
1932
        self.assertEqual(this.wt.id2path(b'g'), pathjoin('b/g1.OTHER'))
1633
1933
        self.assertIs(os.path.lexists(this.wt.abspath('b/g1.BASE')), True)
1634
1934
        self.assertIs(os.path.lexists(this.wt.abspath('b/g1.THIS')), False)
1635
 
        self.assertEqual(this.wt.id2path('h'), pathjoin('b/h1.THIS'))
 
1935
        self.assertEqual(this.wt.id2path(b'h'), pathjoin('b/h1.THIS'))
1636
1936
        self.assertIs(os.path.lexists(this.wt.abspath('b/h1.BASE')), True)
1637
1937
        self.assertIs(os.path.lexists(this.wt.abspath('b/h1.OTHER')), False)
1638
 
        self.assertEqual(this.wt.id2path('i'), pathjoin('b/i1.OTHER'))
 
1938
        self.assertEqual(this.wt.id2path(b'i'), pathjoin('b/i1.OTHER'))
1639
1939
 
1640
1940
 
1641
1941
class TestBuildTree(tests.TestCaseWithTransport):
1643
1943
    def test_build_tree_with_symlinks(self):
1644
1944
        self.requireFeature(SymlinkFeature)
1645
1945
        os.mkdir('a')
1646
 
        a = BzrDir.create_standalone_workingtree('a')
 
1946
        a = ControlDir.create_standalone_workingtree('a')
1647
1947
        os.mkdir('a/foo')
1648
 
        file('a/foo/bar', 'wb').write('contents')
 
1948
        with open('a/foo/bar', 'wb') as f:
 
1949
            f.write(b'contents')
1649
1950
        os.symlink('a/foo/bar', 'a/foo/baz')
1650
1951
        a.add(['foo', 'foo/bar', 'foo/baz'])
1651
1952
        a.commit('initial commit')
1652
 
        b = BzrDir.create_standalone_workingtree('b')
 
1953
        b = ControlDir.create_standalone_workingtree('b')
1653
1954
        basis = a.basis_tree()
1654
1955
        basis.lock_read()
1655
1956
        self.addCleanup(basis.unlock)
1656
1957
        build_tree(basis, b)
1657
1958
        self.assertIs(os.path.isdir('b/foo'), True)
1658
 
        self.assertEqual(file('b/foo/bar', 'rb').read(), "contents")
 
1959
        with open('b/foo/bar', 'rb') as f:
 
1960
            self.assertEqual(f.read(), b"contents")
1659
1961
        self.assertEqual(os.readlink('b/foo/baz'), 'a/foo/bar')
1660
1962
 
1661
1963
    def test_build_with_references(self):
1662
1964
        tree = self.make_branch_and_tree('source',
1663
 
            format='dirstate-with-subtree')
 
1965
                                         format='development-subtree')
1664
1966
        subtree = self.make_branch_and_tree('source/subtree',
1665
 
            format='dirstate-with-subtree')
 
1967
                                            format='development-subtree')
1666
1968
        tree.add_reference(subtree)
1667
1969
        tree.commit('a revision')
1668
1970
        tree.branch.create_checkout('target')
1669
 
        self.failUnlessExists('target')
1670
 
        self.failUnlessExists('target/subtree')
 
1971
        self.assertPathExists('target')
 
1972
        self.assertPathExists('target/subtree')
1671
1973
 
1672
1974
    def test_file_conflict_handling(self):
1673
1975
        """Ensure that when building trees, conflict handling is done"""
1674
1976
        source = self.make_branch_and_tree('source')
1675
1977
        target = self.make_branch_and_tree('target')
1676
1978
        self.build_tree(['source/file', 'target/file'])
1677
 
        source.add('file', 'new-file')
 
1979
        source.add('file', b'new-file')
1678
1980
        source.commit('added file')
1679
1981
        build_tree(source.basis_tree(), target)
1680
 
        self.assertEqual([DuplicateEntry('Moved existing file to',
1681
 
                          'file.moved', 'file', None, 'new-file')],
1682
 
                         target.conflicts())
 
1982
        self.assertEqual(
 
1983
            [DuplicateEntry('Moved existing file to', 'file.moved',
 
1984
                            'file', None, 'new-file')],
 
1985
            target.conflicts())
1683
1986
        target2 = self.make_branch_and_tree('target2')
1684
 
        target_file = file('target2/file', 'wb')
1685
 
        try:
1686
 
            source_file = file('source/file', 'rb')
1687
 
            try:
1688
 
                target_file.write(source_file.read())
1689
 
            finally:
1690
 
                source_file.close()
1691
 
        finally:
1692
 
            target_file.close()
 
1987
        with open('target2/file', 'wb') as target_file, \
 
1988
                open('source/file', 'rb') as source_file:
 
1989
            target_file.write(source_file.read())
1693
1990
        build_tree(source.basis_tree(), target2)
1694
1991
        self.assertEqual([], target2.conflicts())
1695
1992
 
1698
1995
        self.requireFeature(SymlinkFeature)
1699
1996
        source = self.make_branch_and_tree('source')
1700
1997
        os.symlink('foo', 'source/symlink')
1701
 
        source.add('symlink', 'new-symlink')
 
1998
        source.add('symlink', b'new-symlink')
1702
1999
        source.commit('added file')
1703
2000
        target = self.make_branch_and_tree('target')
1704
2001
        os.symlink('bar', 'target/symlink')
1705
2002
        build_tree(source.basis_tree(), target)
1706
 
        self.assertEqual([DuplicateEntry('Moved existing file to',
1707
 
            'symlink.moved', 'symlink', None, 'new-symlink')],
 
2003
        self.assertEqual(
 
2004
            [DuplicateEntry('Moved existing file to', 'symlink.moved',
 
2005
                            'symlink', None, 'new-symlink')],
1708
2006
            target.conflicts())
1709
2007
        target = self.make_branch_and_tree('target2')
1710
2008
        os.symlink('foo', 'target2/symlink')
1716
2014
        source = self.make_branch_and_tree('source')
1717
2015
        target = self.make_branch_and_tree('target')
1718
2016
        self.build_tree(['source/dir1/', 'source/dir1/file', 'target/dir1/'])
1719
 
        source.add(['dir1', 'dir1/file'], ['new-dir1', 'new-file'])
 
2017
        source.add(['dir1', 'dir1/file'], [b'new-dir1', b'new-file'])
1720
2018
        source.commit('added file')
1721
2019
        build_tree(source.basis_tree(), target)
1722
2020
        self.assertEqual([], target.conflicts())
1723
 
        self.failUnlessExists('target/dir1/file')
 
2021
        self.assertPathExists('target/dir1/file')
1724
2022
 
1725
2023
        # Ensure contents are merged
1726
2024
        target = self.make_branch_and_tree('target2')
1727
2025
        self.build_tree(['target2/dir1/', 'target2/dir1/file2'])
1728
2026
        build_tree(source.basis_tree(), target)
1729
2027
        self.assertEqual([], target.conflicts())
1730
 
        self.failUnlessExists('target2/dir1/file2')
1731
 
        self.failUnlessExists('target2/dir1/file')
 
2028
        self.assertPathExists('target2/dir1/file2')
 
2029
        self.assertPathExists('target2/dir1/file')
1732
2030
 
1733
2031
        # Ensure new contents are suppressed for existing branches
1734
2032
        target = self.make_branch_and_tree('target3')
1735
2033
        self.make_branch('target3/dir1')
1736
2034
        self.build_tree(['target3/dir1/file2'])
1737
2035
        build_tree(source.basis_tree(), target)
1738
 
        self.failIfExists('target3/dir1/file')
1739
 
        self.failUnlessExists('target3/dir1/file2')
1740
 
        self.failUnlessExists('target3/dir1.diverted/file')
1741
 
        self.assertEqual([DuplicateEntry('Diverted to',
1742
 
            'dir1.diverted', 'dir1', 'new-dir1', None)],
 
2036
        self.assertPathDoesNotExist('target3/dir1/file')
 
2037
        self.assertPathExists('target3/dir1/file2')
 
2038
        self.assertPathExists('target3/dir1.diverted/file')
 
2039
        self.assertEqual(
 
2040
            [DuplicateEntry('Diverted to', 'dir1.diverted',
 
2041
                            'dir1', 'new-dir1', None)],
1743
2042
            target.conflicts())
1744
2043
 
1745
2044
        target = self.make_branch_and_tree('target4')
1746
2045
        self.build_tree(['target4/dir1/'])
1747
2046
        self.make_branch('target4/dir1/file')
1748
2047
        build_tree(source.basis_tree(), target)
1749
 
        self.failUnlessExists('target4/dir1/file')
 
2048
        self.assertPathExists('target4/dir1/file')
1750
2049
        self.assertEqual('directory', file_kind('target4/dir1/file'))
1751
 
        self.failUnlessExists('target4/dir1/file.diverted')
1752
 
        self.assertEqual([DuplicateEntry('Diverted to',
1753
 
            'dir1/file.diverted', 'dir1/file', 'new-file', None)],
 
2050
        self.assertPathExists('target4/dir1/file.diverted')
 
2051
        self.assertEqual(
 
2052
            [DuplicateEntry('Diverted to', 'dir1/file.diverted',
 
2053
                            'dir1/file', 'new-file', None)],
1754
2054
            target.conflicts())
1755
2055
 
1756
2056
    def test_mixed_conflict_handling(self):
1758
2058
        source = self.make_branch_and_tree('source')
1759
2059
        target = self.make_branch_and_tree('target')
1760
2060
        self.build_tree(['source/name', 'target/name/'])
1761
 
        source.add('name', 'new-name')
 
2061
        source.add('name', b'new-name')
1762
2062
        source.commit('added file')
1763
2063
        build_tree(source.basis_tree(), target)
1764
 
        self.assertEqual([DuplicateEntry('Moved existing file to',
1765
 
            'name.moved', 'name', None, 'new-name')], target.conflicts())
 
2064
        self.assertEqual(
 
2065
            [DuplicateEntry('Moved existing file to',
 
2066
                            'name.moved', 'name', None, 'new-name')],
 
2067
            target.conflicts())
1766
2068
 
1767
2069
    def test_raises_in_populated(self):
1768
2070
        source = self.make_branch_and_tree('source')
1773
2075
        self.build_tree(['target/name'])
1774
2076
        target.add('name')
1775
2077
        self.assertRaises(errors.WorkingTreeAlreadyPopulated,
1776
 
            build_tree, source.basis_tree(), target)
 
2078
                          build_tree, source.basis_tree(), target)
1777
2079
 
1778
2080
    def test_build_tree_rename_count(self):
1779
2081
        source = self.make_branch_and_tree('source')
1795
2097
    def create_ab_tree(self):
1796
2098
        """Create a committed test tree with two files"""
1797
2099
        source = self.make_branch_and_tree('source')
1798
 
        self.build_tree_contents([('source/file1', 'A')])
1799
 
        self.build_tree_contents([('source/file2', 'B')])
1800
 
        source.add(['file1', 'file2'], ['file1-id', 'file2-id'])
 
2100
        self.build_tree_contents([('source/file1', b'A')])
 
2101
        self.build_tree_contents([('source/file2', b'B')])
 
2102
        source.add(['file1', 'file2'], [b'file1-id', b'file2-id'])
1801
2103
        source.commit('commit files')
1802
2104
        source.lock_write()
1803
2105
        self.addCleanup(source.unlock)
1805
2107
 
1806
2108
    def test_build_tree_accelerator_tree(self):
1807
2109
        source = self.create_ab_tree()
1808
 
        self.build_tree_contents([('source/file2', 'C')])
 
2110
        self.build_tree_contents([('source/file2', b'C')])
1809
2111
        calls = []
1810
2112
        real_source_get_file = source.get_file
1811
 
        def get_file(file_id, path=None):
1812
 
            calls.append(file_id)
1813
 
            return real_source_get_file(file_id, path)
 
2113
 
 
2114
        def get_file(path):
 
2115
            calls.append(path)
 
2116
            return real_source_get_file(path)
1814
2117
        source.get_file = get_file
1815
2118
        target = self.make_branch_and_tree('target')
1816
2119
        revision_tree = source.basis_tree()
1817
2120
        revision_tree.lock_read()
1818
2121
        self.addCleanup(revision_tree.unlock)
1819
2122
        build_tree(revision_tree, target, source)
1820
 
        self.assertEqual(['file1-id'], calls)
 
2123
        self.assertEqual(['file1'], calls)
1821
2124
        target.lock_read()
1822
2125
        self.addCleanup(target.unlock)
1823
2126
        self.assertEqual([], list(target.iter_changes(revision_tree)))
1824
2127
 
 
2128
    def test_build_tree_accelerator_tree_observes_sha1(self):
 
2129
        source = self.create_ab_tree()
 
2130
        sha1 = osutils.sha_string(b'A')
 
2131
        target = self.make_branch_and_tree('target')
 
2132
        target.lock_write()
 
2133
        self.addCleanup(target.unlock)
 
2134
        state = target.current_dirstate()
 
2135
        state._cutoff_time = time.time() + 60
 
2136
        build_tree(source.basis_tree(), target, source)
 
2137
        entry = state._get_entry(0, path_utf8=b'file1')
 
2138
        self.assertEqual(sha1, entry[1][0][1])
 
2139
 
1825
2140
    def test_build_tree_accelerator_tree_missing_file(self):
1826
2141
        source = self.create_ab_tree()
1827
2142
        os.unlink('source/file1')
1838
2153
    def test_build_tree_accelerator_wrong_kind(self):
1839
2154
        self.requireFeature(SymlinkFeature)
1840
2155
        source = self.make_branch_and_tree('source')
1841
 
        self.build_tree_contents([('source/file1', '')])
1842
 
        self.build_tree_contents([('source/file2', '')])
1843
 
        source.add(['file1', 'file2'], ['file1-id', 'file2-id'])
 
2156
        self.build_tree_contents([('source/file1', b'')])
 
2157
        self.build_tree_contents([('source/file2', b'')])
 
2158
        source.add(['file1', 'file2'], [b'file1-id', b'file2-id'])
1844
2159
        source.commit('commit files')
1845
2160
        os.unlink('source/file2')
1846
 
        self.build_tree_contents([('source/file2/', 'C')])
 
2161
        self.build_tree_contents([('source/file2/', b'C')])
1847
2162
        os.unlink('source/file1')
1848
2163
        os.symlink('file2', 'source/file1')
1849
2164
        calls = []
1850
2165
        real_source_get_file = source.get_file
1851
 
        def get_file(file_id, path=None):
1852
 
            calls.append(file_id)
1853
 
            return real_source_get_file(file_id, path)
 
2166
 
 
2167
        def get_file(path):
 
2168
            calls.append(path)
 
2169
            return real_source_get_file(path)
1854
2170
        source.get_file = get_file
1855
2171
        target = self.make_branch_and_tree('target')
1856
2172
        revision_tree = source.basis_tree()
1889
2205
 
1890
2206
    def test_build_tree_accelerator_tree_moved(self):
1891
2207
        source = self.make_branch_and_tree('source')
1892
 
        self.build_tree_contents([('source/file1', 'A')])
1893
 
        source.add(['file1'], ['file1-id'])
 
2208
        self.build_tree_contents([('source/file1', b'A')])
 
2209
        source.add(['file1'], [b'file1-id'])
1894
2210
        source.commit('commit files')
1895
2211
        source.rename_one('file1', 'file2')
1896
2212
        source.lock_read()
1908
2224
        self.requireFeature(HardlinkFeature)
1909
2225
        source = self.create_ab_tree()
1910
2226
        tt = TreeTransform(source)
1911
 
        trans_id = tt.trans_id_tree_file_id('file1-id')
 
2227
        trans_id = tt.trans_id_tree_path('file1')
1912
2228
        tt.set_executability(True, trans_id)
1913
2229
        tt.apply()
1914
 
        self.assertTrue(source.is_executable('file1-id'))
 
2230
        self.assertTrue(source.is_executable('file1'))
1915
2231
        target = self.make_branch_and_tree('target')
1916
2232
        revision_tree = source.basis_tree()
1917
2233
        revision_tree.lock_read()
1920
2236
        target.lock_read()
1921
2237
        self.addCleanup(target.unlock)
1922
2238
        self.assertEqual([], list(target.iter_changes(revision_tree)))
1923
 
        self.assertTrue(source.is_executable('file1-id'))
 
2239
        self.assertTrue(source.is_executable('file1'))
1924
2240
 
1925
2241
    def install_rot13_content_filter(self, pattern):
1926
2242
        # We could use
1928
2244
        # below, but that looks a bit... hard to read even if it's exactly
1929
2245
        # the same thing.
1930
2246
        original_registry = filters._reset_registry()
 
2247
 
1931
2248
        def restore_registry():
1932
2249
            filters._reset_registry(original_registry)
1933
2250
        self.addCleanup(restore_registry)
 
2251
 
1934
2252
        def rot13(chunks, context=None):
1935
 
            return [''.join(chunks).encode('rot13')]
 
2253
            return [
 
2254
                codecs.encode(chunk.decode('ascii'), 'rot13').encode('ascii')
 
2255
                for chunk in chunks]
1936
2256
        rot13filter = filters.ContentFilter(rot13, rot13)
1937
 
        filters.register_filter_stack_map('rot13', {'yes': [rot13filter]}.get)
 
2257
        filters.filter_stacks_registry.register(
 
2258
            'rot13', {'yes': [rot13filter]}.get)
1938
2259
        os.mkdir(self.test_home_dir + '/.bazaar')
1939
2260
        rules_filename = self.test_home_dir + '/.bazaar/rules'
1940
 
        f = open(rules_filename, 'wb')
1941
 
        f.write('[name %s]\nrot13=yes\n' % (pattern,))
1942
 
        f.close()
 
2261
        with open(rules_filename, 'wb') as f:
 
2262
            f.write(b'[name %s]\nrot13=yes\n' % (pattern,))
 
2263
 
1943
2264
        def uninstall_rules():
1944
2265
            os.remove(rules_filename)
1945
2266
            rules.reset_rules()
1952
2273
        if it can).
1953
2274
        """
1954
2275
        self.requireFeature(HardlinkFeature)
1955
 
        self.install_rot13_content_filter('file1')
 
2276
        self.install_rot13_content_filter(b'file1')
1956
2277
        source = self.create_ab_tree()
1957
2278
        target = self.make_branch_and_tree('target')
1958
2279
        revision_tree = source.basis_tree()
1970
2291
        self.assertEqualStat(source_stat, target_stat)
1971
2292
 
1972
2293
    def test_case_insensitive_build_tree_inventory(self):
1973
 
        if (tests.CaseInsensitiveFilesystemFeature.available()
1974
 
            or tests.CaseInsCasePresFilenameFeature.available()):
 
2294
        if (features.CaseInsensitiveFilesystemFeature.available()
 
2295
                or features.CaseInsCasePresFilenameFeature.available()):
1975
2296
            raise tests.UnavailableFeature('Fully case sensitive filesystem')
1976
2297
        source = self.make_branch_and_tree('source')
1977
2298
        self.build_tree(['source/file', 'source/FILE'])
1978
 
        source.add(['file', 'FILE'], ['lower-id', 'upper-id'])
 
2299
        source.add(['file', 'FILE'], [b'lower-id', b'upper-id'])
1979
2300
        source.commit('added files')
1980
2301
        # Don't try this at home, kids!
1981
2302
        # Force the tree to report that it is case insensitive
1982
2303
        target = self.make_branch_and_tree('target')
1983
2304
        target.case_sensitive = False
1984
2305
        build_tree(source.basis_tree(), target, source, delta_from_tree=True)
1985
 
        self.assertEqual('file.moved', target.id2path('lower-id'))
1986
 
        self.assertEqual('FILE', target.id2path('upper-id'))
 
2306
        self.assertEqual('file.moved', target.id2path(b'lower-id'))
 
2307
        self.assertEqual('FILE', target.id2path(b'upper-id'))
 
2308
 
 
2309
    def test_build_tree_observes_sha(self):
 
2310
        source = self.make_branch_and_tree('source')
 
2311
        self.build_tree(['source/file1', 'source/dir/', 'source/dir/file2'])
 
2312
        source.add(['file1', 'dir', 'dir/file2'],
 
2313
                   [b'file1-id', b'dir-id', b'file2-id'])
 
2314
        source.commit('new files')
 
2315
        target = self.make_branch_and_tree('target')
 
2316
        target.lock_write()
 
2317
        self.addCleanup(target.unlock)
 
2318
        # We make use of the fact that DirState caches its cutoff time. So we
 
2319
        # set the 'safe' time to one minute in the future.
 
2320
        state = target.current_dirstate()
 
2321
        state._cutoff_time = time.time() + 60
 
2322
        build_tree(source.basis_tree(), target)
 
2323
        entry1_sha = osutils.sha_file_by_name('source/file1')
 
2324
        entry2_sha = osutils.sha_file_by_name('source/dir/file2')
 
2325
        # entry[1] is the state information, entry[1][0] is the state of the
 
2326
        # working tree, entry[1][0][1] is the sha value for the current working
 
2327
        # tree
 
2328
        entry1 = state._get_entry(0, path_utf8=b'file1')
 
2329
        self.assertEqual(entry1_sha, entry1[1][0][1])
 
2330
        # The 'size' field must also be set.
 
2331
        self.assertEqual(25, entry1[1][0][2])
 
2332
        entry1_state = entry1[1][0]
 
2333
        entry2 = state._get_entry(0, path_utf8=b'dir/file2')
 
2334
        self.assertEqual(entry2_sha, entry2[1][0][1])
 
2335
        self.assertEqual(29, entry2[1][0][2])
 
2336
        entry2_state = entry2[1][0]
 
2337
        # Now, make sure that we don't have to re-read the content. The
 
2338
        # packed_stat should match exactly.
 
2339
        self.assertEqual(entry1_sha, target.get_file_sha1('file1'))
 
2340
        self.assertEqual(entry2_sha, target.get_file_sha1('dir/file2'))
 
2341
        self.assertEqual(entry1_state, entry1[1][0])
 
2342
        self.assertEqual(entry2_state, entry2[1][0])
1987
2343
 
1988
2344
 
1989
2345
class TestCommitTransform(tests.TestCaseWithTransport):
2020
2376
 
2021
2377
    def test_merge_parents(self):
2022
2378
        branch, tt = self.get_branch_and_transform()
2023
 
        rev = tt.commit(branch, 'my message', ['rev1b', 'rev1c'])
2024
 
        self.assertEqual(['rev1b', 'rev1c'],
 
2379
        tt.commit(branch, 'my message', [b'rev1b', b'rev1c'])
 
2380
        self.assertEqual([b'rev1b', b'rev1c'],
2025
2381
                         branch.basis_tree().get_parent_ids()[1:])
2026
2382
 
2027
2383
    def test_first_commit(self):
2030
2386
        self.addCleanup(branch.unlock)
2031
2387
        tt = TransformPreview(branch.basis_tree())
2032
2388
        self.addCleanup(tt.finalize)
2033
 
        tt.new_directory('', ROOT_PARENT, 'TREE_ROOT')
2034
 
        rev = tt.commit(branch, 'my message')
 
2389
        tt.new_directory('', ROOT_PARENT, b'TREE_ROOT')
 
2390
        tt.commit(branch, 'my message')
2035
2391
        self.assertEqual([], branch.basis_tree().get_parent_ids())
2036
2392
        self.assertNotEqual(_mod_revision.NULL_REVISION,
2037
2393
                            branch.last_revision())
2043
2399
        tt = TransformPreview(branch.basis_tree())
2044
2400
        self.addCleanup(tt.finalize)
2045
2401
        e = self.assertRaises(ValueError, tt.commit, branch,
2046
 
                          'my message', ['rev1b-id'])
 
2402
                              'my message', [b'rev1b-id'])
2047
2403
        self.assertEqual('Cannot supply merge parents for first commit.',
2048
2404
                         str(e))
2049
2405
        self.assertEqual(_mod_revision.NULL_REVISION, branch.last_revision())
2050
2406
 
2051
2407
    def test_add_files(self):
2052
2408
        branch, tt = self.get_branch_and_transform()
2053
 
        tt.new_file('file', tt.root, 'contents', 'file-id')
2054
 
        trans_id = tt.new_directory('dir', tt.root, 'dir-id')
 
2409
        tt.new_file('file', tt.root, [b'contents'], b'file-id')
 
2410
        trans_id = tt.new_directory('dir', tt.root, b'dir-id')
2055
2411
        if SymlinkFeature.available():
2056
 
            tt.new_symlink('symlink', trans_id, 'target', 'symlink-id')
2057
 
        rev = tt.commit(branch, 'message')
 
2412
            tt.new_symlink('symlink', trans_id, 'target', b'symlink-id')
 
2413
        tt.commit(branch, 'message')
2058
2414
        tree = branch.basis_tree()
2059
 
        self.assertEqual('file', tree.id2path('file-id'))
2060
 
        self.assertEqual('contents', tree.get_file_text('file-id'))
2061
 
        self.assertEqual('dir', tree.id2path('dir-id'))
 
2415
        self.assertEqual('file', tree.id2path(b'file-id'))
 
2416
        self.assertEqual(b'contents', tree.get_file_text('file'))
 
2417
        self.assertEqual('dir', tree.id2path(b'dir-id'))
2062
2418
        if SymlinkFeature.available():
2063
 
            self.assertEqual('dir/symlink', tree.id2path('symlink-id'))
2064
 
            self.assertEqual('target', tree.get_symlink_target('symlink-id'))
 
2419
            self.assertEqual('dir/symlink', tree.id2path(b'symlink-id'))
 
2420
            self.assertEqual('target', tree.get_symlink_target('dir/symlink'))
2065
2421
 
2066
2422
    def test_add_unversioned(self):
2067
2423
        branch, tt = self.get_branch_and_transform()
2068
 
        tt.new_file('file', tt.root, 'contents')
 
2424
        tt.new_file('file', tt.root, [b'contents'])
2069
2425
        self.assertRaises(errors.StrictCommitFailed, tt.commit, branch,
2070
2426
                          'message', strict=True)
2071
2427
 
2072
2428
    def test_modify_strict(self):
2073
2429
        branch, tt = self.get_branch_and_transform()
2074
 
        tt.new_file('file', tt.root, 'contents', 'file-id')
 
2430
        tt.new_file('file', tt.root, [b'contents'], b'file-id')
2075
2431
        tt.commit(branch, 'message', strict=True)
2076
2432
        tt = TransformPreview(branch.basis_tree())
2077
2433
        self.addCleanup(tt.finalize)
2078
 
        trans_id = tt.trans_id_file_id('file-id')
 
2434
        trans_id = tt.trans_id_file_id(b'file-id')
2079
2435
        tt.delete_contents(trans_id)
2080
 
        tt.create_file('contents', trans_id)
 
2436
        tt.create_file([b'contents'], trans_id)
2081
2437
        tt.commit(branch, 'message', strict=True)
2082
2438
 
2083
2439
    def test_commit_malformed(self):
2086
2442
        In this case, we are adding a file without adding its parent.
2087
2443
        """
2088
2444
        branch, tt = self.get_branch_and_transform()
2089
 
        parent_id = tt.trans_id_file_id('parent-id')
2090
 
        tt.new_file('file', parent_id, 'contents', 'file-id')
 
2445
        parent_id = tt.trans_id_file_id(b'parent-id')
 
2446
        tt.new_file('file', parent_id, [b'contents'], b'file-id')
2091
2447
        self.assertRaises(errors.MalformedTransform, tt.commit, branch,
2092
2448
                          'message')
2093
2449
 
2094
 
 
2095
 
class MockTransform(object):
2096
 
 
2097
 
    def has_named_child(self, by_parent, parent_id, name):
2098
 
        for child_id in by_parent[parent_id]:
2099
 
            if child_id == '0':
2100
 
                if name == "name~":
2101
 
                    return True
2102
 
            elif name == "name.~%s~" % child_id:
2103
 
                return True
2104
 
        return False
2105
 
 
2106
 
 
2107
 
class MockEntry(object):
2108
 
    def __init__(self):
2109
 
        object.__init__(self)
2110
 
        self.name = "name"
2111
 
 
2112
 
 
2113
 
class TestGetBackupName(TestCase):
2114
 
    def test_get_backup_name(self):
2115
 
        tt = MockTransform()
2116
 
        name = get_backup_name(MockEntry(), {'a':[]}, 'a', tt)
2117
 
        self.assertEqual(name, 'name.~1~')
2118
 
        name = get_backup_name(MockEntry(), {'a':['1']}, 'a', tt)
2119
 
        self.assertEqual(name, 'name.~2~')
2120
 
        name = get_backup_name(MockEntry(), {'a':['2']}, 'a', tt)
2121
 
        self.assertEqual(name, 'name.~1~')
2122
 
        name = get_backup_name(MockEntry(), {'a':['2'], 'b':[]}, 'b', tt)
2123
 
        self.assertEqual(name, 'name.~1~')
2124
 
        name = get_backup_name(MockEntry(), {'a':['1', '2', '3']}, 'a', tt)
2125
 
        self.assertEqual(name, 'name.~4~')
 
2450
    def test_commit_rich_revision_data(self):
 
2451
        branch, tt = self.get_branch_and_transform()
 
2452
        rev_id = tt.commit(branch, 'message', timestamp=1, timezone=43201,
 
2453
                           committer='me <me@example.com>',
 
2454
                           revprops={u'foo': 'bar'}, revision_id=b'revid-1',
 
2455
                           authors=['Author1 <author1@example.com>',
 
2456
                                    'Author2 <author2@example.com>',
 
2457
                                    ])
 
2458
        self.assertEqual(b'revid-1', rev_id)
 
2459
        revision = branch.repository.get_revision(rev_id)
 
2460
        self.assertEqual(1, revision.timestamp)
 
2461
        self.assertEqual(43201, revision.timezone)
 
2462
        self.assertEqual('me <me@example.com>', revision.committer)
 
2463
        self.assertEqual(['Author1 <author1@example.com>',
 
2464
                          'Author2 <author2@example.com>'],
 
2465
                         revision.get_apparent_authors())
 
2466
        del revision.properties['authors']
 
2467
        self.assertEqual({'foo': 'bar',
 
2468
                          'branch-nick': 'tree'},
 
2469
                         revision.properties)
 
2470
 
 
2471
    def test_no_explicit_revprops(self):
 
2472
        branch, tt = self.get_branch_and_transform()
 
2473
        rev_id = tt.commit(branch, 'message', authors=[
 
2474
            'Author1 <author1@example.com>',
 
2475
            'Author2 <author2@example.com>', ])
 
2476
        revision = branch.repository.get_revision(rev_id)
 
2477
        self.assertEqual(['Author1 <author1@example.com>',
 
2478
                          'Author2 <author2@example.com>'],
 
2479
                         revision.get_apparent_authors())
 
2480
        self.assertEqual('tree', revision.properties['branch-nick'])
2126
2481
 
2127
2482
 
2128
2483
class TestFileMover(tests.TestCaseWithTransport):
2131
2486
        self.build_tree(['a/', 'a/b', 'c/', 'c/d'])
2132
2487
        mover = _FileMover()
2133
2488
        mover.rename('a', 'q')
2134
 
        self.failUnlessExists('q')
2135
 
        self.failIfExists('a')
2136
 
        self.failUnlessExists('q/b')
2137
 
        self.failUnlessExists('c')
2138
 
        self.failUnlessExists('c/d')
 
2489
        self.assertPathExists('q')
 
2490
        self.assertPathDoesNotExist('a')
 
2491
        self.assertPathExists('q/b')
 
2492
        self.assertPathExists('c')
 
2493
        self.assertPathExists('c/d')
2139
2494
 
2140
2495
    def test_pre_delete_rollback(self):
2141
2496
        self.build_tree(['a/'])
2142
2497
        mover = _FileMover()
2143
2498
        mover.pre_delete('a', 'q')
2144
 
        self.failUnlessExists('q')
2145
 
        self.failIfExists('a')
 
2499
        self.assertPathExists('q')
 
2500
        self.assertPathDoesNotExist('a')
2146
2501
        mover.rollback()
2147
 
        self.failIfExists('q')
2148
 
        self.failUnlessExists('a')
 
2502
        self.assertPathDoesNotExist('q')
 
2503
        self.assertPathExists('a')
2149
2504
 
2150
2505
    def test_apply_deletions(self):
2151
2506
        self.build_tree(['a/', 'b/'])
2152
2507
        mover = _FileMover()
2153
2508
        mover.pre_delete('a', 'q')
2154
2509
        mover.pre_delete('b', 'r')
2155
 
        self.failUnlessExists('q')
2156
 
        self.failUnlessExists('r')
2157
 
        self.failIfExists('a')
2158
 
        self.failIfExists('b')
 
2510
        self.assertPathExists('q')
 
2511
        self.assertPathExists('r')
 
2512
        self.assertPathDoesNotExist('a')
 
2513
        self.assertPathDoesNotExist('b')
2159
2514
        mover.apply_deletions()
2160
 
        self.failIfExists('q')
2161
 
        self.failIfExists('r')
2162
 
        self.failIfExists('a')
2163
 
        self.failIfExists('b')
 
2515
        self.assertPathDoesNotExist('q')
 
2516
        self.assertPathDoesNotExist('r')
 
2517
        self.assertPathDoesNotExist('a')
 
2518
        self.assertPathDoesNotExist('b')
2164
2519
 
2165
2520
    def test_file_mover_rollback(self):
2166
2521
        self.build_tree(['a/', 'a/b', 'c/', 'c/d/', 'c/e/'])
2169
2524
        mover.rename('c/e', 'c/d')
2170
2525
        try:
2171
2526
            mover.rename('a', 'c')
2172
 
        except errors.FileExists, e:
 
2527
        except errors.FileExists:
2173
2528
            mover.rollback()
2174
 
        self.failUnlessExists('a')
2175
 
        self.failUnlessExists('c/d')
 
2529
        self.assertPathExists('a')
 
2530
        self.assertPathExists('c/d')
2176
2531
 
2177
2532
 
2178
2533
class Bogus(Exception):
2190
2545
 
2191
2546
        def rename(self, source, target):
2192
2547
            if (self.bad_source is not None and
2193
 
                source.endswith(self.bad_source)):
 
2548
                    source.endswith(self.bad_source)):
2194
2549
                raise Bogus
2195
2550
            elif (self.bad_target is not None and
2196
 
                target.endswith(self.bad_target)):
 
2551
                  target.endswith(self.bad_target)):
2197
2552
                raise Bogus
2198
2553
            else:
2199
2554
                _FileMover.rename(self, source, target)
2208
2563
        tt.adjust_path('d', a_id, tt.trans_id_tree_path('a/b'))
2209
2564
        self.assertRaises(Bogus, tt.apply,
2210
2565
                          _mover=self.ExceptionFileMover(bad_source='a'))
2211
 
        self.failUnlessExists('a')
2212
 
        self.failUnlessExists('a/b')
 
2566
        self.assertPathExists('a')
 
2567
        self.assertPathExists('a/b')
2213
2568
        tt.apply()
2214
 
        self.failUnlessExists('c')
2215
 
        self.failUnlessExists('c/d')
 
2569
        self.assertPathExists('c')
 
2570
        self.assertPathExists('c/d')
2216
2571
 
2217
2572
    def test_rollback_rename_into_place(self):
2218
2573
        tree = self.make_branch_and_tree('.')
2224
2579
        tt.adjust_path('d', a_id, tt.trans_id_tree_path('a/b'))
2225
2580
        self.assertRaises(Bogus, tt.apply,
2226
2581
                          _mover=self.ExceptionFileMover(bad_target='c/d'))
2227
 
        self.failUnlessExists('a')
2228
 
        self.failUnlessExists('a/b')
 
2582
        self.assertPathExists('a')
 
2583
        self.assertPathExists('a/b')
2229
2584
        tt.apply()
2230
 
        self.failUnlessExists('c')
2231
 
        self.failUnlessExists('c/d')
 
2585
        self.assertPathExists('c')
 
2586
        self.assertPathExists('c/d')
2232
2587
 
2233
2588
    def test_rollback_deletion(self):
2234
2589
        tree = self.make_branch_and_tree('.')
2240
2595
        tt.adjust_path('d', tt.root, tt.trans_id_tree_path('a/b'))
2241
2596
        self.assertRaises(Bogus, tt.apply,
2242
2597
                          _mover=self.ExceptionFileMover(bad_target='d'))
2243
 
        self.failUnlessExists('a')
2244
 
        self.failUnlessExists('a/b')
2245
 
 
2246
 
    def test_resolve_no_parent(self):
 
2598
        self.assertPathExists('a')
 
2599
        self.assertPathExists('a/b')
 
2600
 
 
2601
 
 
2602
class TestFinalizeRobustness(tests.TestCaseWithTransport):
 
2603
    """Ensure treetransform creation errors can be safely cleaned up after"""
 
2604
 
 
2605
    def _override_globals_in_method(self, instance, method_name, globals):
 
2606
        """Replace method on instance with one with updated globals"""
 
2607
        import types
 
2608
        func = getattr(instance, method_name).__func__
 
2609
        new_globals = dict(func.__globals__)
 
2610
        new_globals.update(globals)
 
2611
        new_func = types.FunctionType(func.__code__, new_globals,
 
2612
                                      func.__name__, func.__defaults__)
 
2613
        if PY3:
 
2614
            setattr(instance, method_name,
 
2615
                    types.MethodType(new_func, instance))
 
2616
        else:
 
2617
            setattr(instance, method_name,
 
2618
                    types.MethodType(new_func, instance, instance.__class__))
 
2619
        self.addCleanup(delattr, instance, method_name)
 
2620
 
 
2621
    @staticmethod
 
2622
    def _fake_open_raises_before(name, mode):
 
2623
        """Like open() but raises before doing anything"""
 
2624
        raise RuntimeError
 
2625
 
 
2626
    @staticmethod
 
2627
    def _fake_open_raises_after(name, mode):
 
2628
        """Like open() but raises after creating file without returning"""
 
2629
        open(name, mode).close()
 
2630
        raise RuntimeError
 
2631
 
 
2632
    def create_transform_and_root_trans_id(self):
 
2633
        """Setup a transform creating a file in limbo"""
 
2634
        tree = self.make_branch_and_tree('.')
 
2635
        tt = TreeTransform(tree)
 
2636
        return tt, tt.create_path("a", tt.root)
 
2637
 
 
2638
    def create_transform_and_subdir_trans_id(self):
 
2639
        """Setup a transform creating a directory containing a file in limbo"""
 
2640
        tree = self.make_branch_and_tree('.')
 
2641
        tt = TreeTransform(tree)
 
2642
        d_trans_id = tt.create_path("d", tt.root)
 
2643
        tt.create_directory(d_trans_id)
 
2644
        f_trans_id = tt.create_path("a", d_trans_id)
 
2645
        tt.adjust_path("a", d_trans_id, f_trans_id)
 
2646
        return tt, f_trans_id
 
2647
 
 
2648
    def test_root_create_file_open_raises_before_creation(self):
 
2649
        tt, trans_id = self.create_transform_and_root_trans_id()
 
2650
        self._override_globals_in_method(
 
2651
            tt, "create_file", {"open": self._fake_open_raises_before})
 
2652
        self.assertRaises(RuntimeError, tt.create_file,
 
2653
                          [b"contents"], trans_id)
 
2654
        path = tt._limbo_name(trans_id)
 
2655
        self.assertPathDoesNotExist(path)
 
2656
        tt.finalize()
 
2657
        self.assertPathDoesNotExist(tt._limbodir)
 
2658
 
 
2659
    def test_root_create_file_open_raises_after_creation(self):
 
2660
        tt, trans_id = self.create_transform_and_root_trans_id()
 
2661
        self._override_globals_in_method(
 
2662
            tt, "create_file", {"open": self._fake_open_raises_after})
 
2663
        self.assertRaises(RuntimeError, tt.create_file,
 
2664
                          [b"contents"], trans_id)
 
2665
        path = tt._limbo_name(trans_id)
 
2666
        self.assertPathExists(path)
 
2667
        tt.finalize()
 
2668
        self.assertPathDoesNotExist(path)
 
2669
        self.assertPathDoesNotExist(tt._limbodir)
 
2670
 
 
2671
    def test_subdir_create_file_open_raises_before_creation(self):
 
2672
        tt, trans_id = self.create_transform_and_subdir_trans_id()
 
2673
        self._override_globals_in_method(
 
2674
            tt, "create_file", {"open": self._fake_open_raises_before})
 
2675
        self.assertRaises(RuntimeError, tt.create_file,
 
2676
                          [b"contents"], trans_id)
 
2677
        path = tt._limbo_name(trans_id)
 
2678
        self.assertPathDoesNotExist(path)
 
2679
        tt.finalize()
 
2680
        self.assertPathDoesNotExist(tt._limbodir)
 
2681
 
 
2682
    def test_subdir_create_file_open_raises_after_creation(self):
 
2683
        tt, trans_id = self.create_transform_and_subdir_trans_id()
 
2684
        self._override_globals_in_method(
 
2685
            tt, "create_file", {"open": self._fake_open_raises_after})
 
2686
        self.assertRaises(RuntimeError, tt.create_file,
 
2687
                          [b"contents"], trans_id)
 
2688
        path = tt._limbo_name(trans_id)
 
2689
        self.assertPathExists(path)
 
2690
        tt.finalize()
 
2691
        self.assertPathDoesNotExist(path)
 
2692
        self.assertPathDoesNotExist(tt._limbodir)
 
2693
 
 
2694
    def test_rename_in_limbo_rename_raises_after_rename(self):
 
2695
        tt, trans_id = self.create_transform_and_root_trans_id()
 
2696
        parent1 = tt.new_directory('parent1', tt.root)
 
2697
        child1 = tt.new_file('child1', parent1, [b'contents'])
 
2698
        parent2 = tt.new_directory('parent2', tt.root)
 
2699
 
 
2700
        class FakeOSModule(object):
 
2701
            def rename(self, old, new):
 
2702
                os.rename(old, new)
 
2703
                raise RuntimeError
 
2704
        self._override_globals_in_method(tt, "_rename_in_limbo",
 
2705
                                         {"os": FakeOSModule()})
 
2706
        self.assertRaises(
 
2707
            RuntimeError, tt.adjust_path, "child1", parent2, child1)
 
2708
        path = osutils.pathjoin(tt._limbo_name(parent2), "child1")
 
2709
        self.assertPathExists(path)
 
2710
        tt.finalize()
 
2711
        self.assertPathDoesNotExist(path)
 
2712
        self.assertPathDoesNotExist(tt._limbodir)
 
2713
 
 
2714
    def test_rename_in_limbo_rename_raises_before_rename(self):
 
2715
        tt, trans_id = self.create_transform_and_root_trans_id()
 
2716
        parent1 = tt.new_directory('parent1', tt.root)
 
2717
        child1 = tt.new_file('child1', parent1, [b'contents'])
 
2718
        parent2 = tt.new_directory('parent2', tt.root)
 
2719
 
 
2720
        class FakeOSModule(object):
 
2721
            def rename(self, old, new):
 
2722
                raise RuntimeError
 
2723
        self._override_globals_in_method(tt, "_rename_in_limbo",
 
2724
                                         {"os": FakeOSModule()})
 
2725
        self.assertRaises(
 
2726
            RuntimeError, tt.adjust_path, "child1", parent2, child1)
 
2727
        path = osutils.pathjoin(tt._limbo_name(parent1), "child1")
 
2728
        self.assertPathExists(path)
 
2729
        tt.finalize()
 
2730
        self.assertPathDoesNotExist(path)
 
2731
        self.assertPathDoesNotExist(tt._limbodir)
 
2732
 
 
2733
 
 
2734
class TestTransformMissingParent(tests.TestCaseWithTransport):
 
2735
 
 
2736
    def make_tt_with_versioned_dir(self):
2247
2737
        wt = self.make_branch_and_tree('.')
 
2738
        self.build_tree(['dir/', ])
 
2739
        wt.add(['dir'], [b'dir-id'])
 
2740
        wt.commit('Create dir')
2248
2741
        tt = TreeTransform(wt)
2249
2742
        self.addCleanup(tt.finalize)
2250
 
        parent = tt.trans_id_file_id('parent-id')
2251
 
        tt.new_file('file', parent, 'Contents')
2252
 
        resolve_conflicts(tt)
2253
 
 
2254
 
 
2255
 
A_ENTRY = ('a-id', ('a', 'a'), True, (True, True),
2256
 
                  ('TREE_ROOT', 'TREE_ROOT'), ('a', 'a'), ('file', 'file'),
2257
 
                  (False, False))
2258
 
ROOT_ENTRY = ('TREE_ROOT', ('', ''), False, (True, True), (None, None),
2259
 
              ('', ''), ('directory', 'directory'), (False, None))
 
2743
        return wt, tt
 
2744
 
 
2745
    def test_resolve_create_parent_for_versioned_file(self):
 
2746
        wt, tt = self.make_tt_with_versioned_dir()
 
2747
        dir_tid = tt.trans_id_tree_path('dir')
 
2748
        tt.new_file('file', dir_tid, [b'Contents'], file_id=b'file-id')
 
2749
        tt.delete_contents(dir_tid)
 
2750
        tt.unversion_file(dir_tid)
 
2751
        conflicts = resolve_conflicts(tt)
 
2752
        # one conflict for the missing directory, one for the unversioned
 
2753
        # parent
 
2754
        self.assertLength(2, conflicts)
 
2755
 
 
2756
    def test_non_versioned_file_create_conflict(self):
 
2757
        wt, tt = self.make_tt_with_versioned_dir()
 
2758
        dir_tid = tt.trans_id_tree_path('dir')
 
2759
        tt.new_file('file', dir_tid, [b'Contents'])
 
2760
        tt.delete_contents(dir_tid)
 
2761
        tt.unversion_file(dir_tid)
 
2762
        conflicts = resolve_conflicts(tt)
 
2763
        # no conflicts or rather: orphaning 'file' resolve the 'dir' conflict
 
2764
        self.assertLength(1, conflicts)
 
2765
        self.assertEqual(('deleting parent', 'Not deleting', 'new-1'),
 
2766
                         conflicts.pop())
 
2767
 
 
2768
 
 
2769
A_ENTRY = (b'a-id', ('a', 'a'), True, (True, True),
 
2770
           (b'TREE_ROOT', b'TREE_ROOT'), ('a', 'a'), ('file', 'file'),
 
2771
           (False, False))
 
2772
ROOT_ENTRY = (b'TREE_ROOT', ('', ''), False, (True, True), (None, None),
 
2773
              ('', ''), ('directory', 'directory'), (False, False))
2260
2774
 
2261
2775
 
2262
2776
class TestTransformPreview(tests.TestCaseWithTransport):
2263
2777
 
2264
2778
    def create_tree(self):
2265
2779
        tree = self.make_branch_and_tree('.')
2266
 
        self.build_tree_contents([('a', 'content 1')])
2267
 
        tree.set_root_id('TREE_ROOT')
2268
 
        tree.add('a', 'a-id')
2269
 
        tree.commit('rev1', rev_id='rev1')
2270
 
        return tree.branch.repository.revision_tree('rev1')
 
2780
        self.build_tree_contents([('a', b'content 1')])
 
2781
        tree.set_root_id(b'TREE_ROOT')
 
2782
        tree.add('a', b'a-id')
 
2783
        tree.commit('rev1', rev_id=b'rev1')
 
2784
        return tree.branch.repository.revision_tree(b'rev1')
2271
2785
 
2272
2786
    def get_empty_preview(self):
2273
2787
        repository = self.make_repository('repo')
2291
2805
        revision_tree = self.create_tree()
2292
2806
        preview = TransformPreview(revision_tree)
2293
2807
        self.addCleanup(preview.finalize)
2294
 
        preview.new_file('file2', preview.root, 'content B\n', 'file2-id')
 
2808
        preview.new_file('file2', preview.root, [b'content B\n'], b'file2-id')
2295
2809
        preview_tree = preview.get_preview_tree()
2296
 
        self.assertEqual(preview_tree.kind('file2-id'), 'file')
2297
 
        self.assertEqual(
2298
 
            preview_tree.get_file('file2-id').read(), 'content B\n')
 
2810
        self.assertEqual(preview_tree.kind('file2'), 'file')
 
2811
        with preview_tree.get_file('file2') as f:
 
2812
            self.assertEqual(f.read(), b'content B\n')
2299
2813
 
2300
2814
    def test_diff_preview_tree(self):
2301
2815
        revision_tree = self.create_tree()
2302
2816
        preview = TransformPreview(revision_tree)
2303
2817
        self.addCleanup(preview.finalize)
2304
 
        preview.new_file('file2', preview.root, 'content B\n', 'file2-id')
 
2818
        preview.new_file('file2', preview.root, [b'content B\n'], b'file2-id')
2305
2819
        preview_tree = preview.get_preview_tree()
2306
 
        out = StringIO()
 
2820
        out = BytesIO()
2307
2821
        show_diff_trees(revision_tree, preview_tree, out)
2308
2822
        lines = out.getvalue().splitlines()
2309
 
        self.assertEqual(lines[0], "=== added file 'file2'")
 
2823
        self.assertEqual(lines[0], b"=== added file 'file2'")
2310
2824
        # 3 lines of diff administrivia
2311
 
        self.assertEqual(lines[4], "+content B")
 
2825
        self.assertEqual(lines[4], b"+content B")
 
2826
 
 
2827
    def test_unsupported_symlink_diff(self):
 
2828
        self.requireFeature(SymlinkFeature)
 
2829
        tree = self.make_branch_and_tree('.')
 
2830
        self.build_tree_contents([('a', 'content 1')])
 
2831
        tree.set_root_id('TREE_ROOT')
 
2832
        tree.add('a', 'a-id')
 
2833
        os.symlink('a', 'foo')
 
2834
        tree.add('foo', 'foo-id')
 
2835
        tree.commit('rev1', rev_id='rev1')
 
2836
        revision_tree = tree.branch.repository.revision_tree('rev1')
 
2837
        preview = TransformPreview(revision_tree)
 
2838
        self.addCleanup(preview.finalize)
 
2839
        preview.delete_versioned(preview.trans_id_tree_path('foo'))
 
2840
        preview_tree = preview.get_preview_tree()
 
2841
        out = StringIO()
 
2842
        log = BytesIO()
 
2843
        trace.push_log_file(log)
 
2844
        os_symlink = getattr(os, 'symlink', None)
 
2845
        os.symlink = None
 
2846
        try:
 
2847
            show_diff_trees(revision_tree, preview_tree, out)
 
2848
            lines = out.getvalue().splitlines()
 
2849
        finally:
 
2850
            if os_symlink:
 
2851
                os.symlink = os_symlink
 
2852
        self.assertContainsRe(
 
2853
            log.getvalue(),
 
2854
            'Ignoring "foo" as symlinks are not supported on this filesystem')
2312
2855
 
2313
2856
    def test_transform_conflicts(self):
2314
2857
        revision_tree = self.create_tree()
2315
2858
        preview = TransformPreview(revision_tree)
2316
2859
        self.addCleanup(preview.finalize)
2317
 
        preview.new_file('a', preview.root, 'content 2')
 
2860
        preview.new_file('a', preview.root, [b'content 2'])
2318
2861
        resolve_conflicts(preview)
2319
 
        trans_id = preview.trans_id_file_id('a-id')
 
2862
        trans_id = preview.trans_id_file_id(b'a-id')
2320
2863
        self.assertEqual('a.moved', preview.final_name(trans_id))
2321
2864
 
2322
2865
    def get_tree_and_preview_tree(self):
2323
2866
        revision_tree = self.create_tree()
2324
2867
        preview = TransformPreview(revision_tree)
2325
2868
        self.addCleanup(preview.finalize)
2326
 
        a_trans_id = preview.trans_id_file_id('a-id')
 
2869
        a_trans_id = preview.trans_id_file_id(b'a-id')
2327
2870
        preview.delete_contents(a_trans_id)
2328
 
        preview.create_file('b content', a_trans_id)
 
2871
        preview.create_file([b'b content'], a_trans_id)
2329
2872
        preview_tree = preview.get_preview_tree()
2330
2873
        return revision_tree, preview_tree
2331
2874
 
2332
2875
    def test_iter_changes(self):
2333
2876
        revision_tree, preview_tree = self.get_tree_and_preview_tree()
2334
 
        root = revision_tree.inventory.root.file_id
2335
 
        self.assertEqual([('a-id', ('a', 'a'), True, (True, True),
2336
 
                          (root, root), ('a', 'a'), ('file', 'file'),
2337
 
                          (False, False))],
2338
 
                          list(preview_tree.iter_changes(revision_tree)))
 
2877
        root = revision_tree.get_root_id()
 
2878
        self.assertEqual([(b'a-id', ('a', 'a'), True, (True, True),
 
2879
                           (root, root), ('a', 'a'), ('file', 'file'),
 
2880
                           (False, False))],
 
2881
                         list(preview_tree.iter_changes(revision_tree)))
2339
2882
 
2340
2883
    def test_include_unchanged_succeeds(self):
2341
2884
        revision_tree, preview_tree = self.get_tree_and_preview_tree()
2342
2885
        changes = preview_tree.iter_changes(revision_tree,
2343
2886
                                            include_unchanged=True)
2344
 
        root = revision_tree.inventory.root.file_id
2345
 
 
2346
2887
        self.assertEqual([ROOT_ENTRY, A_ENTRY], list(changes))
2347
2888
 
2348
2889
    def test_specific_files(self):
2349
2890
        revision_tree, preview_tree = self.get_tree_and_preview_tree()
2350
2891
        changes = preview_tree.iter_changes(revision_tree,
2351
2892
                                            specific_files=[''])
2352
 
        self.assertEqual([ROOT_ENTRY, A_ENTRY], list(changes))
 
2893
        self.assertEqual([A_ENTRY], list(changes))
2353
2894
 
2354
2895
    def test_want_unversioned(self):
2355
2896
        revision_tree, preview_tree = self.get_tree_and_preview_tree()
2356
2897
        changes = preview_tree.iter_changes(revision_tree,
2357
2898
                                            want_unversioned=True)
2358
 
        self.assertEqual([ROOT_ENTRY, A_ENTRY], list(changes))
 
2899
        self.assertEqual([A_ENTRY], list(changes))
2359
2900
 
2360
2901
    def test_ignore_extra_trees_no_specific_files(self):
2361
2902
        # extra_trees is harmless without specific_files, so we'll silently
2377
2918
        revision_tree = self.create_tree()
2378
2919
        preview = TransformPreview(revision_tree)
2379
2920
        self.addCleanup(preview.finalize)
2380
 
        preview.new_file('file', preview.root, 'contents', 'file-id')
2381
 
        preview.new_directory('directory', preview.root, 'dir-id')
 
2921
        preview.new_file('file', preview.root, [b'contents'], b'file-id')
 
2922
        preview.new_directory('directory', preview.root, b'dir-id')
2382
2923
        preview_tree = preview.get_preview_tree()
2383
 
        self.assertEqual('file', preview_tree.kind('file-id'))
2384
 
        self.assertEqual('directory', preview_tree.kind('dir-id'))
 
2924
        self.assertEqual('file', preview_tree.kind('file'))
 
2925
        self.assertEqual('directory', preview_tree.kind('directory'))
2385
2926
 
2386
2927
    def test_get_file_mtime(self):
2387
2928
        preview = self.get_empty_preview()
2388
 
        file_trans_id = preview.new_file('file', preview.root, 'contents',
2389
 
                                         'file-id')
 
2929
        file_trans_id = preview.new_file('file', preview.root, [b'contents'],
 
2930
                                         b'file-id')
2390
2931
        limbo_path = preview._limbo_name(file_trans_id)
2391
2932
        preview_tree = preview.get_preview_tree()
2392
2933
        self.assertEqual(os.stat(limbo_path).st_mtime,
2393
 
                         preview_tree.get_file_mtime('file-id'))
 
2934
                         preview_tree.get_file_mtime('file'))
2394
2935
 
2395
2936
    def test_get_file_mtime_renamed(self):
2396
2937
        work_tree = self.make_branch_and_tree('tree')
2397
2938
        self.build_tree(['tree/file'])
2398
 
        work_tree.add('file', 'file-id')
 
2939
        work_tree.add('file', b'file-id')
2399
2940
        preview = TransformPreview(work_tree)
2400
2941
        self.addCleanup(preview.finalize)
2401
 
        file_trans_id = preview.trans_id_tree_file_id('file-id')
 
2942
        file_trans_id = preview.trans_id_tree_path('file')
2402
2943
        preview.adjust_path('renamed', preview.root, file_trans_id)
2403
2944
        preview_tree = preview.get_preview_tree()
2404
 
        preview_mtime = preview_tree.get_file_mtime('file-id', 'renamed')
2405
 
        work_mtime = work_tree.get_file_mtime('file-id', 'file')
 
2945
        preview_mtime = preview_tree.get_file_mtime('renamed')
 
2946
        work_mtime = work_tree.get_file_mtime('file')
 
2947
 
 
2948
    def test_get_file_size(self):
 
2949
        work_tree = self.make_branch_and_tree('tree')
 
2950
        self.build_tree_contents([('tree/old', b'old')])
 
2951
        work_tree.add('old', b'old-id')
 
2952
        preview = TransformPreview(work_tree)
 
2953
        self.addCleanup(preview.finalize)
 
2954
        preview.new_file('name', preview.root, [b'contents'], b'new-id',
 
2955
                         'executable')
 
2956
        tree = preview.get_preview_tree()
 
2957
        self.assertEqual(len('old'), tree.get_file_size('old'))
 
2958
        self.assertEqual(len('contents'), tree.get_file_size('name'))
2406
2959
 
2407
2960
    def test_get_file(self):
2408
2961
        preview = self.get_empty_preview()
2409
 
        preview.new_file('file', preview.root, 'contents', 'file-id')
 
2962
        preview.new_file('file', preview.root, [b'contents'], b'file-id')
2410
2963
        preview_tree = preview.get_preview_tree()
2411
 
        tree_file = preview_tree.get_file('file-id')
2412
 
        try:
2413
 
            self.assertEqual('contents', tree_file.read())
2414
 
        finally:
2415
 
            tree_file.close()
 
2964
        with preview_tree.get_file('file') as tree_file:
 
2965
            self.assertEqual(b'contents', tree_file.read())
2416
2966
 
2417
2967
    def test_get_symlink_target(self):
2418
2968
        self.requireFeature(SymlinkFeature)
2419
2969
        preview = self.get_empty_preview()
2420
 
        preview.new_symlink('symlink', preview.root, 'target', 'symlink-id')
 
2970
        preview.new_symlink('symlink', preview.root, 'target', b'symlink-id')
2421
2971
        preview_tree = preview.get_preview_tree()
2422
2972
        self.assertEqual('target',
2423
 
                         preview_tree.get_symlink_target('symlink-id'))
 
2973
                         preview_tree.get_symlink_target('symlink'))
2424
2974
 
2425
2975
    def test_all_file_ids(self):
2426
2976
        tree = self.make_branch_and_tree('tree')
2427
2977
        self.build_tree(['tree/a', 'tree/b', 'tree/c'])
2428
 
        tree.add(['a', 'b', 'c'], ['a-id', 'b-id', 'c-id'])
 
2978
        tree.add(['a', 'b', 'c'], [b'a-id', b'b-id', b'c-id'])
2429
2979
        preview = TransformPreview(tree)
2430
2980
        self.addCleanup(preview.finalize)
2431
 
        preview.unversion_file(preview.trans_id_file_id('b-id'))
2432
 
        c_trans_id = preview.trans_id_file_id('c-id')
 
2981
        preview.unversion_file(preview.trans_id_file_id(b'b-id'))
 
2982
        c_trans_id = preview.trans_id_file_id(b'c-id')
2433
2983
        preview.unversion_file(c_trans_id)
2434
 
        preview.version_file('c-id', c_trans_id)
 
2984
        preview.version_file(b'c-id', c_trans_id)
2435
2985
        preview_tree = preview.get_preview_tree()
2436
 
        self.assertEqual(set(['a-id', 'c-id', tree.get_root_id()]),
 
2986
        self.assertEqual({b'a-id', b'c-id', tree.get_root_id()},
2437
2987
                         preview_tree.all_file_ids())
2438
2988
 
2439
2989
    def test_path2id_deleted_unchanged(self):
2440
2990
        tree = self.make_branch_and_tree('tree')
2441
2991
        self.build_tree(['tree/unchanged', 'tree/deleted'])
2442
 
        tree.add(['unchanged', 'deleted'], ['unchanged-id', 'deleted-id'])
 
2992
        tree.add(['unchanged', 'deleted'], [b'unchanged-id', b'deleted-id'])
2443
2993
        preview = TransformPreview(tree)
2444
2994
        self.addCleanup(preview.finalize)
2445
 
        preview.unversion_file(preview.trans_id_file_id('deleted-id'))
 
2995
        preview.unversion_file(preview.trans_id_file_id(b'deleted-id'))
2446
2996
        preview_tree = preview.get_preview_tree()
2447
 
        self.assertEqual('unchanged-id', preview_tree.path2id('unchanged'))
2448
 
        self.assertIs(None, preview_tree.path2id('deleted'))
 
2997
        self.assertEqual(b'unchanged-id', preview_tree.path2id('unchanged'))
 
2998
        self.assertFalse(preview_tree.is_versioned('deleted'))
2449
2999
 
2450
3000
    def test_path2id_created(self):
2451
3001
        tree = self.make_branch_and_tree('tree')
2452
3002
        self.build_tree(['tree/unchanged'])
2453
 
        tree.add(['unchanged'], ['unchanged-id'])
 
3003
        tree.add(['unchanged'], [b'unchanged-id'])
2454
3004
        preview = TransformPreview(tree)
2455
3005
        self.addCleanup(preview.finalize)
2456
 
        preview.new_file('new', preview.trans_id_file_id('unchanged-id'),
2457
 
            'contents', 'new-id')
 
3006
        preview.new_file('new', preview.trans_id_file_id(b'unchanged-id'),
 
3007
                         [b'contents'], b'new-id')
2458
3008
        preview_tree = preview.get_preview_tree()
2459
 
        self.assertEqual('new-id', preview_tree.path2id('unchanged/new'))
 
3009
        self.assertEqual(b'new-id', preview_tree.path2id('unchanged/new'))
2460
3010
 
2461
3011
    def test_path2id_moved(self):
2462
3012
        tree = self.make_branch_and_tree('tree')
2463
3013
        self.build_tree(['tree/old_parent/', 'tree/old_parent/child'])
2464
3014
        tree.add(['old_parent', 'old_parent/child'],
2465
 
                 ['old_parent-id', 'child-id'])
 
3015
                 [b'old_parent-id', b'child-id'])
2466
3016
        preview = TransformPreview(tree)
2467
3017
        self.addCleanup(preview.finalize)
2468
3018
        new_parent = preview.new_directory('new_parent', preview.root,
2469
 
                                           'new_parent-id')
 
3019
                                           b'new_parent-id')
2470
3020
        preview.adjust_path('child', new_parent,
2471
 
                            preview.trans_id_file_id('child-id'))
 
3021
                            preview.trans_id_file_id(b'child-id'))
2472
3022
        preview_tree = preview.get_preview_tree()
2473
 
        self.assertIs(None, preview_tree.path2id('old_parent/child'))
2474
 
        self.assertEqual('child-id', preview_tree.path2id('new_parent/child'))
 
3023
        self.assertFalse(preview_tree.is_versioned('old_parent/child'))
 
3024
        self.assertEqual(b'child-id', preview_tree.path2id('new_parent/child'))
2475
3025
 
2476
3026
    def test_path2id_renamed_parent(self):
2477
3027
        tree = self.make_branch_and_tree('tree')
2478
3028
        self.build_tree(['tree/old_name/', 'tree/old_name/child'])
2479
3029
        tree.add(['old_name', 'old_name/child'],
2480
 
                 ['parent-id', 'child-id'])
 
3030
                 [b'parent-id', b'child-id'])
2481
3031
        preview = TransformPreview(tree)
2482
3032
        self.addCleanup(preview.finalize)
2483
3033
        preview.adjust_path('new_name', preview.root,
2484
 
                            preview.trans_id_file_id('parent-id'))
 
3034
                            preview.trans_id_file_id(b'parent-id'))
2485
3035
        preview_tree = preview.get_preview_tree()
2486
 
        self.assertIs(None, preview_tree.path2id('old_name/child'))
2487
 
        self.assertEqual('child-id', preview_tree.path2id('new_name/child'))
 
3036
        self.assertFalse(preview_tree.is_versioned('old_name/child'))
 
3037
        self.assertEqual(b'child-id', preview_tree.path2id('new_name/child'))
2488
3038
 
2489
 
    def assertMatchingIterEntries(self, tt, specific_file_ids=None):
 
3039
    def assertMatchingIterEntries(self, tt, specific_files=None):
2490
3040
        preview_tree = tt.get_preview_tree()
2491
3041
        preview_result = list(preview_tree.iter_entries_by_dir(
2492
 
                              specific_file_ids))
 
3042
                              specific_files=specific_files))
2493
3043
        tree = tt._tree
2494
3044
        tt.apply()
2495
 
        actual_result = list(tree.iter_entries_by_dir(specific_file_ids))
 
3045
        actual_result = list(tree.iter_entries_by_dir(
 
3046
            specific_files=specific_files))
2496
3047
        self.assertEqual(actual_result, preview_result)
2497
3048
 
2498
3049
    def test_iter_entries_by_dir_new(self):
2499
3050
        tree = self.make_branch_and_tree('tree')
2500
3051
        tt = TreeTransform(tree)
2501
 
        tt.new_file('new', tt.root, 'contents', 'new-id')
 
3052
        tt.new_file('new', tt.root, [b'contents'], b'new-id')
2502
3053
        self.assertMatchingIterEntries(tt)
2503
3054
 
2504
3055
    def test_iter_entries_by_dir_deleted(self):
2505
3056
        tree = self.make_branch_and_tree('tree')
2506
3057
        self.build_tree(['tree/deleted'])
2507
 
        tree.add('deleted', 'deleted-id')
 
3058
        tree.add('deleted', b'deleted-id')
2508
3059
        tt = TreeTransform(tree)
2509
 
        tt.delete_contents(tt.trans_id_file_id('deleted-id'))
 
3060
        tt.delete_contents(tt.trans_id_file_id(b'deleted-id'))
2510
3061
        self.assertMatchingIterEntries(tt)
2511
3062
 
2512
3063
    def test_iter_entries_by_dir_unversioned(self):
2513
3064
        tree = self.make_branch_and_tree('tree')
2514
3065
        self.build_tree(['tree/removed'])
2515
 
        tree.add('removed', 'removed-id')
 
3066
        tree.add('removed', b'removed-id')
2516
3067
        tt = TreeTransform(tree)
2517
 
        tt.unversion_file(tt.trans_id_file_id('removed-id'))
 
3068
        tt.unversion_file(tt.trans_id_file_id(b'removed-id'))
2518
3069
        self.assertMatchingIterEntries(tt)
2519
3070
 
2520
3071
    def test_iter_entries_by_dir_moved(self):
2521
3072
        tree = self.make_branch_and_tree('tree')
2522
3073
        self.build_tree(['tree/moved', 'tree/new_parent/'])
2523
 
        tree.add(['moved', 'new_parent'], ['moved-id', 'new_parent-id'])
 
3074
        tree.add(['moved', 'new_parent'], [b'moved-id', b'new_parent-id'])
2524
3075
        tt = TreeTransform(tree)
2525
 
        tt.adjust_path('moved', tt.trans_id_file_id('new_parent-id'),
2526
 
                       tt.trans_id_file_id('moved-id'))
 
3076
        tt.adjust_path('moved', tt.trans_id_file_id(b'new_parent-id'),
 
3077
                       tt.trans_id_file_id(b'moved-id'))
2527
3078
        self.assertMatchingIterEntries(tt)
2528
3079
 
2529
 
    def test_iter_entries_by_dir_specific_file_ids(self):
 
3080
    def test_iter_entries_by_dir_specific_files(self):
2530
3081
        tree = self.make_branch_and_tree('tree')
2531
 
        tree.set_root_id('tree-root-id')
 
3082
        tree.set_root_id(b'tree-root-id')
2532
3083
        self.build_tree(['tree/parent/', 'tree/parent/child'])
2533
 
        tree.add(['parent', 'parent/child'], ['parent-id', 'child-id'])
 
3084
        tree.add(['parent', 'parent/child'], [b'parent-id', b'child-id'])
2534
3085
        tt = TreeTransform(tree)
2535
 
        self.assertMatchingIterEntries(tt, ['tree-root-id', 'child-id'])
 
3086
        self.assertMatchingIterEntries(tt, ['', 'parent/child'])
2536
3087
 
2537
3088
    def test_symlink_content_summary(self):
2538
3089
        self.requireFeature(SymlinkFeature)
2539
3090
        preview = self.get_empty_preview()
2540
 
        preview.new_symlink('path', preview.root, 'target', 'path-id')
 
3091
        preview.new_symlink('path', preview.root, 'target', b'path-id')
2541
3092
        summary = preview.get_preview_tree().path_content_summary('path')
2542
3093
        self.assertEqual(('symlink', None, None, 'target'), summary)
2543
3094
 
2558
3109
 
2559
3110
    def test_file_content_summary_executable(self):
2560
3111
        preview = self.get_empty_preview()
2561
 
        path_id = preview.new_file('path', preview.root, 'contents', 'path-id')
 
3112
        path_id = preview.new_file('path', preview.root, [
 
3113
                                   b'contents'], b'path-id')
2562
3114
        preview.set_executability(True, path_id)
2563
3115
        summary = preview.get_preview_tree().path_content_summary('path')
2564
3116
        self.assertEqual(4, len(summary))
2583
3135
 
2584
3136
    def test_file_content_summary_non_exec(self):
2585
3137
        preview = self.get_empty_preview()
2586
 
        preview.new_file('path', preview.root, 'contents', 'path-id')
 
3138
        preview.new_file('path', preview.root, [b'contents'], b'path-id')
2587
3139
        summary = preview.get_preview_tree().path_content_summary('path')
2588
3140
        self.assertEqual(4, len(summary))
2589
3141
        self.assertEqual('file', summary[0])
2596
3148
 
2597
3149
    def test_dir_content_summary(self):
2598
3150
        preview = self.get_empty_preview()
2599
 
        preview.new_directory('path', preview.root, 'path-id')
 
3151
        preview.new_directory('path', preview.root, b'path-id')
2600
3152
        summary = preview.get_preview_tree().path_content_summary('path')
2601
3153
        self.assertEqual(('directory', None, None, None), summary)
2602
3154
 
2603
3155
    def test_tree_content_summary(self):
2604
3156
        preview = self.get_empty_preview()
2605
 
        path = preview.new_directory('path', preview.root, 'path-id')
2606
 
        preview.set_tree_reference('rev-1', path)
 
3157
        path = preview.new_directory('path', preview.root, b'path-id')
 
3158
        preview.set_tree_reference(b'rev-1', path)
2607
3159
        summary = preview.get_preview_tree().path_content_summary('path')
2608
3160
        self.assertEqual(4, len(summary))
2609
3161
        self.assertEqual('tree-reference', summary[0])
2610
3162
 
2611
3163
    def test_annotate(self):
2612
3164
        tree = self.make_branch_and_tree('tree')
2613
 
        self.build_tree_contents([('tree/file', 'a\n')])
2614
 
        tree.add('file', 'file-id')
2615
 
        tree.commit('a', rev_id='one')
2616
 
        self.build_tree_contents([('tree/file', 'a\nb\n')])
 
3165
        self.build_tree_contents([('tree/file', b'a\n')])
 
3166
        tree.add('file', b'file-id')
 
3167
        tree.commit('a', rev_id=b'one')
 
3168
        self.build_tree_contents([('tree/file', b'a\nb\n')])
2617
3169
        preview = TransformPreview(tree)
2618
3170
        self.addCleanup(preview.finalize)
2619
 
        file_trans_id = preview.trans_id_file_id('file-id')
 
3171
        file_trans_id = preview.trans_id_file_id(b'file-id')
2620
3172
        preview.delete_contents(file_trans_id)
2621
 
        preview.create_file('a\nb\nc\n', file_trans_id)
 
3173
        preview.create_file([b'a\nb\nc\n'], file_trans_id)
2622
3174
        preview_tree = preview.get_preview_tree()
2623
3175
        expected = [
2624
 
            ('one', 'a\n'),
2625
 
            ('me:', 'b\n'),
2626
 
            ('me:', 'c\n'),
 
3176
            (b'one', b'a\n'),
 
3177
            (b'me:', b'b\n'),
 
3178
            (b'me:', b'c\n'),
2627
3179
        ]
2628
 
        annotation = preview_tree.annotate_iter('file-id', 'me:')
 
3180
        annotation = preview_tree.annotate_iter(
 
3181
            'file', default_revision=b'me:')
2629
3182
        self.assertEqual(expected, annotation)
2630
3183
 
2631
3184
    def test_annotate_missing(self):
2632
3185
        preview = self.get_empty_preview()
2633
 
        preview.new_file('file', preview.root, 'a\nb\nc\n', 'file-id')
 
3186
        preview.new_file('file', preview.root, [b'a\nb\nc\n'], b'file-id')
2634
3187
        preview_tree = preview.get_preview_tree()
2635
3188
        expected = [
2636
 
            ('me:', 'a\n'),
2637
 
            ('me:', 'b\n'),
2638
 
            ('me:', 'c\n'),
2639
 
         ]
2640
 
        annotation = preview_tree.annotate_iter('file-id', 'me:')
 
3189
            (b'me:', b'a\n'),
 
3190
            (b'me:', b'b\n'),
 
3191
            (b'me:', b'c\n'),
 
3192
            ]
 
3193
        annotation = preview_tree.annotate_iter(
 
3194
            'file', default_revision=b'me:')
2641
3195
        self.assertEqual(expected, annotation)
2642
3196
 
2643
3197
    def test_annotate_rename(self):
2644
3198
        tree = self.make_branch_and_tree('tree')
2645
 
        self.build_tree_contents([('tree/file', 'a\n')])
2646
 
        tree.add('file', 'file-id')
2647
 
        tree.commit('a', rev_id='one')
 
3199
        self.build_tree_contents([('tree/file', b'a\n')])
 
3200
        tree.add('file', b'file-id')
 
3201
        tree.commit('a', rev_id=b'one')
2648
3202
        preview = TransformPreview(tree)
2649
3203
        self.addCleanup(preview.finalize)
2650
 
        file_trans_id = preview.trans_id_file_id('file-id')
 
3204
        file_trans_id = preview.trans_id_file_id(b'file-id')
2651
3205
        preview.adjust_path('newname', preview.root, file_trans_id)
2652
3206
        preview_tree = preview.get_preview_tree()
2653
3207
        expected = [
2654
 
            ('one', 'a\n'),
 
3208
            (b'one', b'a\n'),
2655
3209
        ]
2656
 
        annotation = preview_tree.annotate_iter('file-id', 'me:')
 
3210
        annotation = preview_tree.annotate_iter(
 
3211
            'file', default_revision=b'me:')
2657
3212
        self.assertEqual(expected, annotation)
2658
3213
 
2659
3214
    def test_annotate_deleted(self):
2660
3215
        tree = self.make_branch_and_tree('tree')
2661
 
        self.build_tree_contents([('tree/file', 'a\n')])
2662
 
        tree.add('file', 'file-id')
2663
 
        tree.commit('a', rev_id='one')
2664
 
        self.build_tree_contents([('tree/file', 'a\nb\n')])
 
3216
        self.build_tree_contents([('tree/file', b'a\n')])
 
3217
        tree.add('file', b'file-id')
 
3218
        tree.commit('a', rev_id=b'one')
 
3219
        self.build_tree_contents([('tree/file', b'a\nb\n')])
2665
3220
        preview = TransformPreview(tree)
2666
3221
        self.addCleanup(preview.finalize)
2667
 
        file_trans_id = preview.trans_id_file_id('file-id')
 
3222
        file_trans_id = preview.trans_id_file_id(b'file-id')
2668
3223
        preview.delete_contents(file_trans_id)
2669
3224
        preview_tree = preview.get_preview_tree()
2670
 
        annotation = preview_tree.annotate_iter('file-id', 'me:')
 
3225
        annotation = preview_tree.annotate_iter(
 
3226
            'file', default_revision=b'me:')
2671
3227
        self.assertIs(None, annotation)
2672
3228
 
2673
3229
    def test_stored_kind(self):
2674
3230
        preview = self.get_empty_preview()
2675
 
        preview.new_file('file', preview.root, 'a\nb\nc\n', 'file-id')
 
3231
        preview.new_file('file', preview.root, [b'a\nb\nc\n'], b'file-id')
2676
3232
        preview_tree = preview.get_preview_tree()
2677
 
        self.assertEqual('file', preview_tree.stored_kind('file-id'))
 
3233
        self.assertEqual('file', preview_tree.stored_kind('file'))
2678
3234
 
2679
3235
    def test_is_executable(self):
2680
3236
        preview = self.get_empty_preview()
2681
 
        preview.new_file('file', preview.root, 'a\nb\nc\n', 'file-id')
2682
 
        preview.set_executability(True, preview.trans_id_file_id('file-id'))
 
3237
        preview.new_file('file', preview.root, [b'a\nb\nc\n'], b'file-id')
 
3238
        preview.set_executability(True, preview.trans_id_file_id(b'file-id'))
2683
3239
        preview_tree = preview.get_preview_tree()
2684
 
        self.assertEqual(True, preview_tree.is_executable('file-id'))
 
3240
        self.assertEqual(True, preview_tree.is_executable('file'))
2685
3241
 
2686
3242
    def test_get_set_parent_ids(self):
2687
3243
        revision_tree, preview_tree = self.get_tree_and_preview_tree()
2688
3244
        self.assertEqual([], preview_tree.get_parent_ids())
2689
 
        preview_tree.set_parent_ids(['rev-1'])
2690
 
        self.assertEqual(['rev-1'], preview_tree.get_parent_ids())
 
3245
        preview_tree.set_parent_ids([b'rev-1'])
 
3246
        self.assertEqual([b'rev-1'], preview_tree.get_parent_ids())
2691
3247
 
2692
3248
    def test_plan_file_merge(self):
2693
3249
        work_a = self.make_branch_and_tree('wta')
2694
 
        self.build_tree_contents([('wta/file', 'a\nb\nc\nd\n')])
2695
 
        work_a.add('file', 'file-id')
 
3250
        self.build_tree_contents([('wta/file', b'a\nb\nc\nd\n')])
 
3251
        work_a.add('file', b'file-id')
2696
3252
        base_id = work_a.commit('base version')
2697
 
        tree_b = work_a.bzrdir.sprout('wtb').open_workingtree()
 
3253
        tree_b = work_a.controldir.sprout('wtb').open_workingtree()
2698
3254
        preview = TransformPreview(work_a)
2699
3255
        self.addCleanup(preview.finalize)
2700
 
        trans_id = preview.trans_id_file_id('file-id')
 
3256
        trans_id = preview.trans_id_file_id(b'file-id')
2701
3257
        preview.delete_contents(trans_id)
2702
 
        preview.create_file('b\nc\nd\ne\n', trans_id)
2703
 
        self.build_tree_contents([('wtb/file', 'a\nc\nd\nf\n')])
 
3258
        preview.create_file([b'b\nc\nd\ne\n'], trans_id)
 
3259
        self.build_tree_contents([('wtb/file', b'a\nc\nd\nf\n')])
2704
3260
        tree_a = preview.get_preview_tree()
2705
3261
        tree_a.set_parent_ids([base_id])
2706
3262
        self.assertEqual([
2707
 
            ('killed-a', 'a\n'),
2708
 
            ('killed-b', 'b\n'),
2709
 
            ('unchanged', 'c\n'),
2710
 
            ('unchanged', 'd\n'),
2711
 
            ('new-a', 'e\n'),
2712
 
            ('new-b', 'f\n'),
2713
 
        ], list(tree_a.plan_file_merge('file-id', tree_b)))
 
3263
            ('killed-a', b'a\n'),
 
3264
            ('killed-b', b'b\n'),
 
3265
            ('unchanged', b'c\n'),
 
3266
            ('unchanged', b'd\n'),
 
3267
            ('new-a', b'e\n'),
 
3268
            ('new-b', b'f\n'),
 
3269
        ], list(tree_a.plan_file_merge(b'file-id', tree_b)))
2714
3270
 
2715
3271
    def test_plan_file_merge_revision_tree(self):
2716
3272
        work_a = self.make_branch_and_tree('wta')
2717
 
        self.build_tree_contents([('wta/file', 'a\nb\nc\nd\n')])
2718
 
        work_a.add('file', 'file-id')
 
3273
        self.build_tree_contents([('wta/file', b'a\nb\nc\nd\n')])
 
3274
        work_a.add('file', b'file-id')
2719
3275
        base_id = work_a.commit('base version')
2720
 
        tree_b = work_a.bzrdir.sprout('wtb').open_workingtree()
 
3276
        tree_b = work_a.controldir.sprout('wtb').open_workingtree()
2721
3277
        preview = TransformPreview(work_a.basis_tree())
2722
3278
        self.addCleanup(preview.finalize)
2723
 
        trans_id = preview.trans_id_file_id('file-id')
 
3279
        trans_id = preview.trans_id_file_id(b'file-id')
2724
3280
        preview.delete_contents(trans_id)
2725
 
        preview.create_file('b\nc\nd\ne\n', trans_id)
2726
 
        self.build_tree_contents([('wtb/file', 'a\nc\nd\nf\n')])
 
3281
        preview.create_file([b'b\nc\nd\ne\n'], trans_id)
 
3282
        self.build_tree_contents([('wtb/file', b'a\nc\nd\nf\n')])
2727
3283
        tree_a = preview.get_preview_tree()
2728
3284
        tree_a.set_parent_ids([base_id])
2729
3285
        self.assertEqual([
2730
 
            ('killed-a', 'a\n'),
2731
 
            ('killed-b', 'b\n'),
2732
 
            ('unchanged', 'c\n'),
2733
 
            ('unchanged', 'd\n'),
2734
 
            ('new-a', 'e\n'),
2735
 
            ('new-b', 'f\n'),
2736
 
        ], list(tree_a.plan_file_merge('file-id', tree_b)))
 
3286
            ('killed-a', b'a\n'),
 
3287
            ('killed-b', b'b\n'),
 
3288
            ('unchanged', b'c\n'),
 
3289
            ('unchanged', b'd\n'),
 
3290
            ('new-a', b'e\n'),
 
3291
            ('new-b', b'f\n'),
 
3292
        ], list(tree_a.plan_file_merge(b'file-id', tree_b)))
2737
3293
 
2738
3294
    def test_walkdirs(self):
2739
3295
        preview = self.get_empty_preview()
2740
 
        root = preview.new_directory('', ROOT_PARENT, 'tree-root')
 
3296
        preview.new_directory('', ROOT_PARENT, b'tree-root')
2741
3297
        # FIXME: new_directory should mark root.
2742
3298
        preview.fixup_new_roots()
2743
3299
        preview_tree = preview.get_preview_tree()
2744
 
        file_trans_id = preview.new_file('a', preview.root, 'contents',
2745
 
                                         'a-id')
2746
 
        expected = [(('', 'tree-root'),
2747
 
                    [('a', 'a', 'file', None, 'a-id', 'file')])]
 
3300
        preview.new_file('a', preview.root, [b'contents'], b'a-id')
 
3301
        expected = [(('', b'tree-root'),
 
3302
                     [('a', 'a', 'file', None, b'a-id', 'file')])]
2748
3303
        self.assertEqual(expected, list(preview_tree.walkdirs()))
2749
3304
 
2750
3305
    def test_extras(self):
2754
3309
        work_tree.add(['removed-file', 'not-removed-file'])
2755
3310
        preview = TransformPreview(work_tree)
2756
3311
        self.addCleanup(preview.finalize)
2757
 
        preview.new_file('new-file', preview.root, 'contents')
2758
 
        preview.new_file('new-versioned-file', preview.root, 'contents',
2759
 
                         'new-versioned-id')
 
3312
        preview.new_file('new-file', preview.root, [b'contents'])
 
3313
        preview.new_file('new-versioned-file', preview.root, [b'contents'],
 
3314
                         b'new-versioned-id')
2760
3315
        tree = preview.get_preview_tree()
2761
3316
        preview.unversion_file(preview.trans_id_tree_path('removed-file'))
2762
 
        self.assertEqual(set(['new-file', 'removed-file', 'existing-file']),
 
3317
        self.assertEqual({'new-file', 'removed-file', 'existing-file'},
2763
3318
                         set(tree.extras()))
2764
3319
 
2765
3320
    def test_merge_into_preview(self):
2766
3321
        work_tree = self.make_branch_and_tree('tree')
2767
 
        self.build_tree_contents([('tree/file','b\n')])
2768
 
        work_tree.add('file', 'file-id')
 
3322
        self.build_tree_contents([('tree/file', b'b\n')])
 
3323
        work_tree.add('file', b'file-id')
2769
3324
        work_tree.commit('first commit')
2770
 
        child_tree = work_tree.bzrdir.sprout('child').open_workingtree()
2771
 
        self.build_tree_contents([('child/file','b\nc\n')])
 
3325
        child_tree = work_tree.controldir.sprout('child').open_workingtree()
 
3326
        self.build_tree_contents([('child/file', b'b\nc\n')])
2772
3327
        child_tree.commit('child commit')
2773
3328
        child_tree.lock_write()
2774
3329
        self.addCleanup(child_tree.unlock)
2776
3331
        self.addCleanup(work_tree.unlock)
2777
3332
        preview = TransformPreview(work_tree)
2778
3333
        self.addCleanup(preview.finalize)
2779
 
        file_trans_id = preview.trans_id_file_id('file-id')
 
3334
        file_trans_id = preview.trans_id_file_id(b'file-id')
2780
3335
        preview.delete_contents(file_trans_id)
2781
 
        preview.create_file('a\nb\n', file_trans_id)
 
3336
        preview.create_file([b'a\nb\n'], file_trans_id)
2782
3337
        preview_tree = preview.get_preview_tree()
2783
 
        merger = Merger.from_revision_ids(None, preview_tree,
 
3338
        merger = Merger.from_revision_ids(preview_tree,
2784
3339
                                          child_tree.branch.last_revision(),
2785
3340
                                          other_branch=child_tree.branch,
2786
3341
                                          tree_branch=work_tree.branch)
2788
3343
        tt = merger.make_merger().make_preview_transform()
2789
3344
        self.addCleanup(tt.finalize)
2790
3345
        final_tree = tt.get_preview_tree()
2791
 
        self.assertEqual('a\nb\nc\n', final_tree.get_file_text('file-id'))
 
3346
        self.assertEqual(
 
3347
            b'a\nb\nc\n',
 
3348
            final_tree.get_file_text(final_tree.id2path(b'file-id')))
2792
3349
 
2793
3350
    def test_merge_preview_into_workingtree(self):
2794
3351
        tree = self.make_branch_and_tree('tree')
2795
 
        tree.set_root_id('TREE_ROOT')
 
3352
        tree.set_root_id(b'TREE_ROOT')
2796
3353
        tt = TransformPreview(tree)
2797
3354
        self.addCleanup(tt.finalize)
2798
 
        tt.new_file('name', tt.root, 'content', 'file-id')
 
3355
        tt.new_file('name', tt.root, [b'content'], b'file-id')
2799
3356
        tree2 = self.make_branch_and_tree('tree2')
2800
 
        tree2.set_root_id('TREE_ROOT')
 
3357
        tree2.set_root_id(b'TREE_ROOT')
2801
3358
        merger = Merger.from_uncommitted(tree2, tt.get_preview_tree(),
2802
 
                                         None, tree.basis_tree())
 
3359
                                         tree.basis_tree())
2803
3360
        merger.merge_type = Merge3Merger
2804
3361
        merger.do_merge()
2805
3362
 
2806
3363
    def test_merge_preview_into_workingtree_handles_conflicts(self):
2807
3364
        tree = self.make_branch_and_tree('tree')
2808
 
        self.build_tree_contents([('tree/foo', 'bar')])
2809
 
        tree.add('foo', 'foo-id')
 
3365
        self.build_tree_contents([('tree/foo', b'bar')])
 
3366
        tree.add('foo', b'foo-id')
2810
3367
        tree.commit('foo')
2811
3368
        tt = TransformPreview(tree)
2812
3369
        self.addCleanup(tt.finalize)
2813
 
        trans_id = tt.trans_id_file_id('foo-id')
 
3370
        trans_id = tt.trans_id_file_id(b'foo-id')
2814
3371
        tt.delete_contents(trans_id)
2815
 
        tt.create_file('baz', trans_id)
2816
 
        tree2 = tree.bzrdir.sprout('tree2').open_workingtree()
2817
 
        self.build_tree_contents([('tree2/foo', 'qux')])
2818
 
        pb = None
 
3372
        tt.create_file([b'baz'], trans_id)
 
3373
        tree2 = tree.controldir.sprout('tree2').open_workingtree()
 
3374
        self.build_tree_contents([('tree2/foo', b'qux')])
2819
3375
        merger = Merger.from_uncommitted(tree2, tt.get_preview_tree(),
2820
 
                                         pb, tree.basis_tree())
 
3376
                                         tree.basis_tree())
2821
3377
        merger.merge_type = Merge3Merger
2822
3378
        merger.do_merge()
2823
3379
 
 
3380
    def test_has_filename(self):
 
3381
        wt = self.make_branch_and_tree('tree')
 
3382
        self.build_tree(['tree/unmodified', 'tree/removed', 'tree/modified'])
 
3383
        tt = TransformPreview(wt)
 
3384
        removed_id = tt.trans_id_tree_path('removed')
 
3385
        tt.delete_contents(removed_id)
 
3386
        tt.new_file('new', tt.root, [b'contents'])
 
3387
        modified_id = tt.trans_id_tree_path('modified')
 
3388
        tt.delete_contents(modified_id)
 
3389
        tt.create_file([b'modified-contents'], modified_id)
 
3390
        self.addCleanup(tt.finalize)
 
3391
        tree = tt.get_preview_tree()
 
3392
        self.assertTrue(tree.has_filename('unmodified'))
 
3393
        self.assertFalse(tree.has_filename('not-present'))
 
3394
        self.assertFalse(tree.has_filename('removed'))
 
3395
        self.assertTrue(tree.has_filename('new'))
 
3396
        self.assertTrue(tree.has_filename('modified'))
 
3397
 
2824
3398
    def test_is_executable(self):
2825
3399
        tree = self.make_branch_and_tree('tree')
2826
3400
        preview = TransformPreview(tree)
2827
3401
        self.addCleanup(preview.finalize)
2828
 
        preview.new_file('foo', preview.root, 'bar', 'baz-id')
 
3402
        preview.new_file('foo', preview.root, [b'bar'], b'baz-id')
2829
3403
        preview_tree = preview.get_preview_tree()
2830
 
        self.assertEqual(False, preview_tree.is_executable('baz-id',
2831
 
                                                           'tree/foo'))
2832
 
        self.assertEqual(False, preview_tree.is_executable('baz-id'))
 
3404
        self.assertEqual(False, preview_tree.is_executable('tree/foo'))
2833
3405
 
2834
3406
    def test_commit_preview_tree(self):
2835
3407
        tree = self.make_branch_and_tree('tree')
2837
3409
        tree.branch.lock_write()
2838
3410
        self.addCleanup(tree.branch.unlock)
2839
3411
        tt = TransformPreview(tree)
2840
 
        tt.new_file('file', tt.root, 'contents', 'file_id')
 
3412
        tt.new_file('file', tt.root, [b'contents'], b'file_id')
2841
3413
        self.addCleanup(tt.finalize)
2842
3414
        preview = tt.get_preview_tree()
2843
3415
        preview.set_parent_ids([rev_id])
2846
3418
        builder.finish_inventory()
2847
3419
        rev2_id = builder.commit('rev2')
2848
3420
        rev2_tree = tree.branch.repository.revision_tree(rev2_id)
2849
 
        self.assertEqual('contents', rev2_tree.get_file_text('file_id'))
 
3421
        self.assertEqual(b'contents', rev2_tree.get_file_text('file'))
2850
3422
 
2851
3423
    def test_ascii_limbo_paths(self):
2852
 
        self.requireFeature(tests.UnicodeFilenameFeature)
 
3424
        self.requireFeature(features.UnicodeFilenameFeature)
2853
3425
        branch = self.make_branch('any')
2854
3426
        tree = branch.repository.revision_tree(_mod_revision.NULL_REVISION)
2855
3427
        tt = TransformPreview(tree)
2856
3428
        self.addCleanup(tt.finalize)
2857
3429
        foo_id = tt.new_directory('', ROOT_PARENT)
2858
 
        bar_id = tt.new_file(u'\u1234bar', foo_id, 'contents')
 
3430
        bar_id = tt.new_file(u'\u1234bar', foo_id, [b'contents'])
2859
3431
        limbo_path = tt._limbo_name(bar_id)
2860
 
        self.assertEqual(limbo_path.encode('ascii', 'replace'), limbo_path)
 
3432
        self.assertEqual(limbo_path, limbo_path)
2861
3433
 
2862
3434
 
2863
3435
class FakeSerializer(object):
2872
3444
 
2873
3445
class TestSerializeTransform(tests.TestCaseWithTransport):
2874
3446
 
2875
 
    _test_needs_features = [tests.UnicodeFilenameFeature]
 
3447
    _test_needs_features = [features.UnicodeFilenameFeature]
2876
3448
 
2877
3449
    def get_preview(self, tree=None):
2878
3450
        if tree is None:
2888
3460
    @staticmethod
2889
3461
    def default_attribs():
2890
3462
        return {
2891
 
            '_id_number': 1,
2892
 
            '_new_name': {},
2893
 
            '_new_parent': {},
2894
 
            '_new_executability': {},
2895
 
            '_new_id': {},
2896
 
            '_tree_path_ids': {'': 'new-0'},
2897
 
            '_removed_id': [],
2898
 
            '_removed_contents': [],
2899
 
            '_non_present_ids': {},
 
3463
            b'_id_number': 1,
 
3464
            b'_new_name': {},
 
3465
            b'_new_parent': {},
 
3466
            b'_new_executability': {},
 
3467
            b'_new_id': {},
 
3468
            b'_tree_path_ids': {b'': b'new-0'},
 
3469
            b'_removed_id': [],
 
3470
            b'_removed_contents': [],
 
3471
            b'_non_present_ids': {},
2900
3472
            }
2901
3473
 
2902
3474
    def make_records(self, attribs, contents):
2903
3475
        records = [
2904
 
            (((('attribs'),),), bencode.bencode(attribs))]
 
3476
            ((((b'attribs'),),), bencode.bencode(attribs))]
2905
3477
        records.extend([(((n, k),), c) for n, k, c in contents])
2906
3478
        return records
2907
3479
 
2908
3480
    def creation_records(self):
2909
3481
        attribs = self.default_attribs()
2910
 
        attribs['_id_number'] = 3
2911
 
        attribs['_new_name'] = {
2912
 
            'new-1': u'foo\u1234'.encode('utf-8'), 'new-2': 'qux'}
2913
 
        attribs['_new_id'] = {'new-1': 'baz', 'new-2': 'quxx'}
2914
 
        attribs['_new_parent'] = {'new-1': 'new-0', 'new-2': 'new-0'}
2915
 
        attribs['_new_executability'] = {'new-1': 1}
 
3482
        attribs[b'_id_number'] = 3
 
3483
        attribs[b'_new_name'] = {
 
3484
            b'new-1': u'foo\u1234'.encode('utf-8'), b'new-2': b'qux'}
 
3485
        attribs[b'_new_id'] = {b'new-1': b'baz', b'new-2': b'quxx'}
 
3486
        attribs[b'_new_parent'] = {b'new-1': b'new-0', b'new-2': b'new-0'}
 
3487
        attribs[b'_new_executability'] = {b'new-1': 1}
2916
3488
        contents = [
2917
 
            ('new-1', 'file', 'i 1\nbar\n'),
2918
 
            ('new-2', 'directory', ''),
 
3489
            (b'new-1', b'file', b'i 1\nbar\n'),
 
3490
            (b'new-2', b'directory', b''),
2919
3491
            ]
2920
3492
        return self.make_records(attribs, contents)
2921
3493
 
2922
3494
    def test_serialize_creation(self):
2923
3495
        tt = self.get_preview()
2924
 
        tt.new_file(u'foo\u1234', tt.root, 'bar', 'baz', True)
2925
 
        tt.new_directory('qux', tt.root, 'quxx')
 
3496
        tt.new_file(u'foo\u1234', tt.root, [b'bar'], b'baz', True)
 
3497
        tt.new_directory('qux', tt.root, b'quxx')
2926
3498
        self.assertSerializesTo(self.creation_records(), tt)
2927
3499
 
2928
3500
    def test_deserialize_creation(self):
2931
3503
        self.assertEqual(3, tt._id_number)
2932
3504
        self.assertEqual({'new-1': u'foo\u1234',
2933
3505
                          'new-2': 'qux'}, tt._new_name)
2934
 
        self.assertEqual({'new-1': 'baz', 'new-2': 'quxx'}, tt._new_id)
 
3506
        self.assertEqual({'new-1': b'baz', 'new-2': b'quxx'}, tt._new_id)
2935
3507
        self.assertEqual({'new-1': tt.root, 'new-2': tt.root}, tt._new_parent)
2936
 
        self.assertEqual({'baz': 'new-1', 'quxx': 'new-2'}, tt._r_new_id)
 
3508
        self.assertEqual({b'baz': 'new-1', b'quxx': 'new-2'}, tt._r_new_id)
2937
3509
        self.assertEqual({'new-1': True}, tt._new_executability)
2938
3510
        self.assertEqual({'new-1': 'file',
2939
3511
                          'new-2': 'directory'}, tt._new_contents)
2942
3514
            foo_content = foo_limbo.read()
2943
3515
        finally:
2944
3516
            foo_limbo.close()
2945
 
        self.assertEqual('bar', foo_content)
 
3517
        self.assertEqual(b'bar', foo_content)
2946
3518
 
2947
3519
    def symlink_creation_records(self):
2948
3520
        attribs = self.default_attribs()
2949
 
        attribs['_id_number'] = 2
2950
 
        attribs['_new_name'] = {'new-1': u'foo\u1234'.encode('utf-8')}
2951
 
        attribs['_new_parent'] = {'new-1': 'new-0'}
2952
 
        contents = [('new-1', 'symlink', u'bar\u1234'.encode('utf-8'))]
 
3521
        attribs[b'_id_number'] = 2
 
3522
        attribs[b'_new_name'] = {b'new-1': u'foo\u1234'.encode('utf-8')}
 
3523
        attribs[b'_new_parent'] = {b'new-1': b'new-0'}
 
3524
        contents = [(b'new-1', b'symlink', u'bar\u1234'.encode('utf-8'))]
2953
3525
        return self.make_records(attribs, contents)
2954
3526
 
2955
3527
    def test_serialize_symlink_creation(self):
2956
 
        self.requireFeature(tests.SymlinkFeature)
 
3528
        self.requireFeature(features.SymlinkFeature)
2957
3529
        tt = self.get_preview()
2958
3530
        tt.new_symlink(u'foo\u1234', tt.root, u'bar\u1234')
2959
3531
        self.assertSerializesTo(self.symlink_creation_records(), tt)
2960
3532
 
2961
3533
    def test_deserialize_symlink_creation(self):
2962
 
        self.requireFeature(tests.SymlinkFeature)
 
3534
        self.requireFeature(features.SymlinkFeature)
2963
3535
        tt = self.get_preview()
2964
3536
        tt.deserialize(iter(self.symlink_creation_records()))
2965
3537
        abspath = tt._limbo_name('new-1')
2969
3541
    def make_destruction_preview(self):
2970
3542
        tree = self.make_branch_and_tree('.')
2971
3543
        self.build_tree([u'foo\u1234', 'bar'])
2972
 
        tree.add([u'foo\u1234', 'bar'], ['foo-id', 'bar-id'])
 
3544
        tree.add([u'foo\u1234', 'bar'], [b'foo-id', b'bar-id'])
2973
3545
        return self.get_preview(tree)
2974
3546
 
2975
3547
    def destruction_records(self):
2976
3548
        attribs = self.default_attribs()
2977
 
        attribs['_id_number'] = 3
2978
 
        attribs['_removed_id'] = ['new-1']
2979
 
        attribs['_removed_contents'] = ['new-2']
2980
 
        attribs['_tree_path_ids'] = {
2981
 
            '': 'new-0',
2982
 
            u'foo\u1234'.encode('utf-8'): 'new-1',
2983
 
            'bar': 'new-2',
 
3549
        attribs[b'_id_number'] = 3
 
3550
        attribs[b'_removed_id'] = [b'new-1']
 
3551
        attribs[b'_removed_contents'] = [b'new-2']
 
3552
        attribs[b'_tree_path_ids'] = {
 
3553
            b'': b'new-0',
 
3554
            u'foo\u1234'.encode('utf-8'): b'new-1',
 
3555
            b'bar': b'new-2',
2984
3556
            }
2985
3557
        return self.make_records(attribs, [])
2986
3558
 
2987
3559
    def test_serialize_destruction(self):
2988
3560
        tt = self.make_destruction_preview()
2989
 
        foo_trans_id = tt.trans_id_tree_file_id('foo-id')
 
3561
        foo_trans_id = tt.trans_id_tree_path(u'foo\u1234')
2990
3562
        tt.unversion_file(foo_trans_id)
2991
 
        bar_trans_id = tt.trans_id_tree_file_id('bar-id')
 
3563
        bar_trans_id = tt.trans_id_tree_path('bar')
2992
3564
        tt.delete_contents(bar_trans_id)
2993
3565
        self.assertSerializesTo(self.destruction_records(), tt)
2994
3566
 
3001
3573
        self.assertEqual({'new-1': u'foo\u1234',
3002
3574
                          'new-2': 'bar',
3003
3575
                          tt.root: ''}, tt._tree_id_paths)
3004
 
        self.assertEqual(set(['new-1']), tt._removed_id)
3005
 
        self.assertEqual(set(['new-2']), tt._removed_contents)
 
3576
        self.assertEqual({'new-1'}, tt._removed_id)
 
3577
        self.assertEqual({'new-2'}, tt._removed_contents)
3006
3578
 
3007
3579
    def missing_records(self):
3008
3580
        attribs = self.default_attribs()
3009
 
        attribs['_id_number'] = 2
3010
 
        attribs['_non_present_ids'] = {
3011
 
            'boo': 'new-1',}
 
3581
        attribs[b'_id_number'] = 2
 
3582
        attribs[b'_non_present_ids'] = {
 
3583
            b'boo': b'new-1', }
3012
3584
        return self.make_records(attribs, [])
3013
3585
 
3014
3586
    def test_serialize_missing(self):
3015
3587
        tt = self.get_preview()
3016
 
        boo_trans_id = tt.trans_id_file_id('boo')
 
3588
        tt.trans_id_file_id(b'boo')
3017
3589
        self.assertSerializesTo(self.missing_records(), tt)
3018
3590
 
3019
3591
    def test_deserialize_missing(self):
3020
3592
        tt = self.get_preview()
3021
3593
        tt.deserialize(iter(self.missing_records()))
3022
 
        self.assertEqual({'boo': 'new-1'}, tt._non_present_ids)
 
3594
        self.assertEqual({b'boo': 'new-1'}, tt._non_present_ids)
3023
3595
 
3024
3596
    def make_modification_preview(self):
3025
 
        LINES_ONE = 'aa\nbb\ncc\ndd\n'
3026
 
        LINES_TWO = 'z\nbb\nx\ndd\n'
 
3597
        LINES_ONE = b'aa\nbb\ncc\ndd\n'
 
3598
        LINES_TWO = b'z\nbb\nx\ndd\n'
3027
3599
        tree = self.make_branch_and_tree('tree')
3028
3600
        self.build_tree_contents([('tree/file', LINES_ONE)])
3029
 
        tree.add('file', 'file-id')
3030
 
        return self.get_preview(tree), LINES_TWO
 
3601
        tree.add('file', b'file-id')
 
3602
        return self.get_preview(tree), [LINES_TWO]
3031
3603
 
3032
3604
    def modification_records(self):
3033
3605
        attribs = self.default_attribs()
3034
 
        attribs['_id_number'] = 2
3035
 
        attribs['_tree_path_ids'] = {
3036
 
            'file': 'new-1',
3037
 
            '': 'new-0',}
3038
 
        attribs['_removed_contents'] = ['new-1']
3039
 
        contents = [('new-1', 'file',
3040
 
                     'i 1\nz\n\nc 0 1 1 1\ni 1\nx\n\nc 0 3 3 1\n')]
 
3606
        attribs[b'_id_number'] = 2
 
3607
        attribs[b'_tree_path_ids'] = {
 
3608
            b'file': b'new-1',
 
3609
            b'': b'new-0', }
 
3610
        attribs[b'_removed_contents'] = [b'new-1']
 
3611
        contents = [(b'new-1', b'file',
 
3612
                     b'i 1\nz\n\nc 0 1 1 1\ni 1\nx\n\nc 0 3 3 1\n')]
3041
3613
        return self.make_records(attribs, contents)
3042
3614
 
3043
3615
    def test_serialize_modification(self):
3044
3616
        tt, LINES = self.make_modification_preview()
3045
 
        trans_id = tt.trans_id_file_id('file-id')
 
3617
        trans_id = tt.trans_id_file_id(b'file-id')
3046
3618
        tt.delete_contents(trans_id)
3047
3619
        tt.create_file(LINES, trans_id)
3048
3620
        self.assertSerializesTo(self.modification_records(), tt)
3050
3622
    def test_deserialize_modification(self):
3051
3623
        tt, LINES = self.make_modification_preview()
3052
3624
        tt.deserialize(iter(self.modification_records()))
3053
 
        self.assertFileEqual(LINES, tt._limbo_name('new-1'))
 
3625
        self.assertFileEqual(b''.join(LINES), tt._limbo_name('new-1'))
3054
3626
 
3055
3627
    def make_kind_change_preview(self):
3056
 
        LINES = 'a\nb\nc\nd\n'
 
3628
        LINES = b'a\nb\nc\nd\n'
3057
3629
        tree = self.make_branch_and_tree('tree')
3058
3630
        self.build_tree(['tree/foo/'])
3059
 
        tree.add('foo', 'foo-id')
3060
 
        return self.get_preview(tree), LINES
 
3631
        tree.add('foo', b'foo-id')
 
3632
        return self.get_preview(tree), [LINES]
3061
3633
 
3062
3634
    def kind_change_records(self):
3063
3635
        attribs = self.default_attribs()
3064
 
        attribs['_id_number'] = 2
3065
 
        attribs['_tree_path_ids'] = {
3066
 
            'foo': 'new-1',
3067
 
            '': 'new-0',}
3068
 
        attribs['_removed_contents'] = ['new-1']
3069
 
        contents = [('new-1', 'file',
3070
 
                     'i 4\na\nb\nc\nd\n\n')]
 
3636
        attribs[b'_id_number'] = 2
 
3637
        attribs[b'_tree_path_ids'] = {
 
3638
            b'foo': b'new-1',
 
3639
            b'': b'new-0', }
 
3640
        attribs[b'_removed_contents'] = [b'new-1']
 
3641
        contents = [(b'new-1', b'file',
 
3642
                     b'i 4\na\nb\nc\nd\n\n')]
3071
3643
        return self.make_records(attribs, contents)
3072
3644
 
3073
3645
    def test_serialize_kind_change(self):
3074
3646
        tt, LINES = self.make_kind_change_preview()
3075
 
        trans_id = tt.trans_id_file_id('foo-id')
 
3647
        trans_id = tt.trans_id_file_id(b'foo-id')
3076
3648
        tt.delete_contents(trans_id)
3077
3649
        tt.create_file(LINES, trans_id)
3078
3650
        self.assertSerializesTo(self.kind_change_records(), tt)
3080
3652
    def test_deserialize_kind_change(self):
3081
3653
        tt, LINES = self.make_kind_change_preview()
3082
3654
        tt.deserialize(iter(self.kind_change_records()))
3083
 
        self.assertFileEqual(LINES, tt._limbo_name('new-1'))
 
3655
        self.assertFileEqual(b''.join(LINES), tt._limbo_name('new-1'))
3084
3656
 
3085
3657
    def make_add_contents_preview(self):
3086
 
        LINES = 'a\nb\nc\nd\n'
 
3658
        LINES = b'a\nb\nc\nd\n'
3087
3659
        tree = self.make_branch_and_tree('tree')
3088
3660
        self.build_tree(['tree/foo'])
3089
3661
        tree.add('foo')
3092
3664
 
3093
3665
    def add_contents_records(self):
3094
3666
        attribs = self.default_attribs()
3095
 
        attribs['_id_number'] = 2
3096
 
        attribs['_tree_path_ids'] = {
3097
 
            'foo': 'new-1',
3098
 
            '': 'new-0',}
3099
 
        contents = [('new-1', 'file',
3100
 
                     'i 4\na\nb\nc\nd\n\n')]
 
3667
        attribs[b'_id_number'] = 2
 
3668
        attribs[b'_tree_path_ids'] = {
 
3669
            b'foo': b'new-1',
 
3670
            b'': b'new-0', }
 
3671
        contents = [(b'new-1', b'file',
 
3672
                     b'i 4\na\nb\nc\nd\n\n')]
3101
3673
        return self.make_records(attribs, contents)
3102
3674
 
3103
3675
    def test_serialize_add_contents(self):
3104
3676
        tt, LINES = self.make_add_contents_preview()
3105
3677
        trans_id = tt.trans_id_tree_path('foo')
3106
 
        tt.create_file(LINES, trans_id)
 
3678
        tt.create_file([LINES], trans_id)
3107
3679
        self.assertSerializesTo(self.add_contents_records(), tt)
3108
3680
 
3109
3681
    def test_deserialize_add_contents(self):
3112
3684
        self.assertFileEqual(LINES, tt._limbo_name('new-1'))
3113
3685
 
3114
3686
    def test_get_parents_lines(self):
3115
 
        LINES_ONE = 'aa\nbb\ncc\ndd\n'
3116
 
        LINES_TWO = 'z\nbb\nx\ndd\n'
 
3687
        LINES_ONE = b'aa\nbb\ncc\ndd\n'
3117
3688
        tree = self.make_branch_and_tree('tree')
3118
3689
        self.build_tree_contents([('tree/file', LINES_ONE)])
3119
 
        tree.add('file', 'file-id')
 
3690
        tree.add('file', b'file-id')
3120
3691
        tt = self.get_preview(tree)
3121
3692
        trans_id = tt.trans_id_tree_path('file')
3122
 
        self.assertEqual((['aa\n', 'bb\n', 'cc\n', 'dd\n'],),
3123
 
            tt._get_parents_lines(trans_id))
 
3693
        self.assertEqual(([b'aa\n', b'bb\n', b'cc\n', b'dd\n'],),
 
3694
                         tt._get_parents_lines(trans_id))
3124
3695
 
3125
3696
    def test_get_parents_texts(self):
3126
 
        LINES_ONE = 'aa\nbb\ncc\ndd\n'
3127
 
        LINES_TWO = 'z\nbb\nx\ndd\n'
 
3697
        LINES_ONE = b'aa\nbb\ncc\ndd\n'
3128
3698
        tree = self.make_branch_and_tree('tree')
3129
3699
        self.build_tree_contents([('tree/file', LINES_ONE)])
3130
 
        tree.add('file', 'file-id')
 
3700
        tree.add('file', b'file-id')
3131
3701
        tt = self.get_preview(tree)
3132
3702
        trans_id = tt.trans_id_tree_path('file')
3133
3703
        self.assertEqual((LINES_ONE,),
3134
 
            tt._get_parents_texts(trans_id))
 
3704
                         tt._get_parents_texts(trans_id))
 
3705
 
 
3706
 
 
3707
class TestOrphan(tests.TestCaseWithTransport):
 
3708
 
 
3709
    def test_no_orphan_for_transform_preview(self):
 
3710
        tree = self.make_branch_and_tree('tree')
 
3711
        tt = transform.TransformPreview(tree)
 
3712
        self.addCleanup(tt.finalize)
 
3713
        self.assertRaises(NotImplementedError, tt.new_orphan, 'foo', 'bar')
 
3714
 
 
3715
    def _set_orphan_policy(self, wt, policy):
 
3716
        wt.branch.get_config_stack().set('transform.orphan_policy',
 
3717
                                         policy)
 
3718
 
 
3719
    def _prepare_orphan(self, wt):
 
3720
        self.build_tree(['dir/', 'dir/file', 'dir/foo'])
 
3721
        wt.add(['dir', 'dir/file'], [b'dir-id', b'file-id'])
 
3722
        wt.commit('add dir and file ignoring foo')
 
3723
        tt = transform.TreeTransform(wt)
 
3724
        self.addCleanup(tt.finalize)
 
3725
        # dir and bar are deleted
 
3726
        dir_tid = tt.trans_id_tree_path('dir')
 
3727
        file_tid = tt.trans_id_tree_path('dir/file')
 
3728
        orphan_tid = tt.trans_id_tree_path('dir/foo')
 
3729
        tt.delete_contents(file_tid)
 
3730
        tt.unversion_file(file_tid)
 
3731
        tt.delete_contents(dir_tid)
 
3732
        tt.unversion_file(dir_tid)
 
3733
        # There should be a conflict because dir still contain foo
 
3734
        raw_conflicts = tt.find_conflicts()
 
3735
        self.assertLength(1, raw_conflicts)
 
3736
        self.assertEqual(('missing parent', 'new-1'), raw_conflicts[0])
 
3737
        return tt, orphan_tid
 
3738
 
 
3739
    def test_new_orphan_created(self):
 
3740
        wt = self.make_branch_and_tree('.')
 
3741
        self._set_orphan_policy(wt, 'move')
 
3742
        tt, orphan_tid = self._prepare_orphan(wt)
 
3743
        warnings = []
 
3744
 
 
3745
        def warning(*args):
 
3746
            warnings.append(args[0] % args[1:])
 
3747
        self.overrideAttr(trace, 'warning', warning)
 
3748
        remaining_conflicts = resolve_conflicts(tt)
 
3749
        self.assertEqual(['dir/foo has been orphaned in brz-orphans'],
 
3750
                         warnings)
 
3751
        # Yeah for resolved conflicts !
 
3752
        self.assertLength(0, remaining_conflicts)
 
3753
        # We have a new orphan
 
3754
        self.assertEqual('foo.~1~', tt.final_name(orphan_tid))
 
3755
        self.assertEqual('brz-orphans',
 
3756
                         tt.final_name(tt.final_parent(orphan_tid)))
 
3757
 
 
3758
    def test_never_orphan(self):
 
3759
        wt = self.make_branch_and_tree('.')
 
3760
        self._set_orphan_policy(wt, 'conflict')
 
3761
        tt, orphan_tid = self._prepare_orphan(wt)
 
3762
        remaining_conflicts = resolve_conflicts(tt)
 
3763
        self.assertLength(1, remaining_conflicts)
 
3764
        self.assertEqual(('deleting parent', 'Not deleting', 'new-1'),
 
3765
                         remaining_conflicts.pop())
 
3766
 
 
3767
    def test_orphan_error(self):
 
3768
        def bogus_orphan(tt, orphan_id, parent_id):
 
3769
            raise transform.OrphaningError(tt.final_name(orphan_id),
 
3770
                                           tt.final_name(parent_id))
 
3771
        transform.orphaning_registry.register('bogus', bogus_orphan,
 
3772
                                              'Raise an error when orphaning')
 
3773
        wt = self.make_branch_and_tree('.')
 
3774
        self._set_orphan_policy(wt, 'bogus')
 
3775
        tt, orphan_tid = self._prepare_orphan(wt)
 
3776
        remaining_conflicts = resolve_conflicts(tt)
 
3777
        self.assertLength(1, remaining_conflicts)
 
3778
        self.assertEqual(('deleting parent', 'Not deleting', 'new-1'),
 
3779
                         remaining_conflicts.pop())
 
3780
 
 
3781
    def test_unknown_orphan_policy(self):
 
3782
        wt = self.make_branch_and_tree('.')
 
3783
        # Set a fictional policy nobody ever implemented
 
3784
        self._set_orphan_policy(wt, 'donttouchmypreciouuus')
 
3785
        tt, orphan_tid = self._prepare_orphan(wt)
 
3786
        warnings = []
 
3787
 
 
3788
        def warning(*args):
 
3789
            warnings.append(args[0] % args[1:])
 
3790
        self.overrideAttr(trace, 'warning', warning)
 
3791
        remaining_conflicts = resolve_conflicts(tt)
 
3792
        # We fallback to the default policy which create a conflict
 
3793
        self.assertLength(1, remaining_conflicts)
 
3794
        self.assertEqual(('deleting parent', 'Not deleting', 'new-1'),
 
3795
                         remaining_conflicts.pop())
 
3796
        self.assertLength(1, warnings)
 
3797
        self.assertStartsWith(warnings[0], 'Value "donttouchmypreciouuus" ')
 
3798
 
 
3799
 
 
3800
class TestTransformHooks(tests.TestCaseWithTransport):
 
3801
 
 
3802
    def setUp(self):
 
3803
        super(TestTransformHooks, self).setUp()
 
3804
        self.wt = self.make_branch_and_tree('.')
 
3805
        os.chdir('..')
 
3806
 
 
3807
    def get_transform(self):
 
3808
        transform = TreeTransform(self.wt)
 
3809
        self.addCleanup(transform.finalize)
 
3810
        return transform, transform.root
 
3811
 
 
3812
    def test_pre_commit_hooks(self):
 
3813
        calls = []
 
3814
 
 
3815
        def record_pre_transform(tree, tt):
 
3816
            calls.append((tree, tt))
 
3817
        MutableTree.hooks.install_named_hook(
 
3818
            'pre_transform', record_pre_transform, "Pre transform")
 
3819
        transform, root = self.get_transform()
 
3820
        old_root_id = transform.tree_file_id(root)
 
3821
        transform.apply()
 
3822
        self.assertEqual(old_root_id, self.wt.get_root_id())
 
3823
        self.assertEqual([(self.wt, transform)], calls)
 
3824
 
 
3825
    def test_post_commit_hooks(self):
 
3826
        calls = []
 
3827
 
 
3828
        def record_post_transform(tree, tt):
 
3829
            calls.append((tree, tt))
 
3830
        MutableTree.hooks.install_named_hook(
 
3831
            'post_transform', record_post_transform, "Post transform")
 
3832
        transform, root = self.get_transform()
 
3833
        old_root_id = transform.tree_file_id(root)
 
3834
        transform.apply()
 
3835
        self.assertEqual(old_root_id, self.wt.get_root_id())
 
3836
        self.assertEqual([(self.wt, transform)], calls)
 
3837
 
 
3838
 
 
3839
class TestLinkTree(tests.TestCaseWithTransport):
 
3840
 
 
3841
    _test_needs_features = [HardlinkFeature]
 
3842
 
 
3843
    def setUp(self):
 
3844
        tests.TestCaseWithTransport.setUp(self)
 
3845
        self.parent_tree = self.make_branch_and_tree('parent')
 
3846
        self.parent_tree.lock_write()
 
3847
        self.addCleanup(self.parent_tree.unlock)
 
3848
        self.build_tree_contents([('parent/foo', b'bar')])
 
3849
        self.parent_tree.add('foo')
 
3850
        self.parent_tree.commit('added foo')
 
3851
        child_controldir = self.parent_tree.controldir.sprout('child')
 
3852
        self.child_tree = child_controldir.open_workingtree()
 
3853
 
 
3854
    def hardlinked(self):
 
3855
        parent_stat = os.lstat(self.parent_tree.abspath('foo'))
 
3856
        child_stat = os.lstat(self.child_tree.abspath('foo'))
 
3857
        return parent_stat.st_ino == child_stat.st_ino
 
3858
 
 
3859
    def test_link_fails_if_modified(self):
 
3860
        """If the file to be linked has modified text, don't link."""
 
3861
        self.build_tree_contents([('child/foo', b'baz')])
 
3862
        transform.link_tree(self.child_tree, self.parent_tree)
 
3863
        self.assertFalse(self.hardlinked())
 
3864
 
 
3865
    def test_link_fails_if_execute_bit_changed(self):
 
3866
        """If the file to be linked has modified execute bit, don't link."""
 
3867
        tt = TreeTransform(self.child_tree)
 
3868
        try:
 
3869
            trans_id = tt.trans_id_tree_path('foo')
 
3870
            tt.set_executability(True, trans_id)
 
3871
            tt.apply()
 
3872
        finally:
 
3873
            tt.finalize()
 
3874
        transform.link_tree(self.child_tree, self.parent_tree)
 
3875
        self.assertFalse(self.hardlinked())
 
3876
 
 
3877
    def test_link_succeeds_if_unmodified(self):
 
3878
        """If the file to be linked is unmodified, link"""
 
3879
        transform.link_tree(self.child_tree, self.parent_tree)
 
3880
        self.assertTrue(self.hardlinked())