/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to breezy/tests/test_symbol_versioning.py

  • Committer: Breezy landing bot
  • Author(s): Jelmer Vernooij
  • Date: 2018-11-16 18:26:22 UTC
  • mfrom: (7167.1.4 run-flake8)
  • Revision ID: breezy.the.bot@gmail.com-20181116182622-qw3gan3hz78a2imw
Add a flake8 test.

Merged from https://code.launchpad.net/~jelmer/brz/run-flake8/+merge/358902

Show diffs side-by-side

added added

removed removed

Lines of Context:
breezy/tests/test_symbol_versioning.py
 
1
# Copyright (C) 2006-2011 Canonical Ltd
 
2
#
 
3
# This program is free software; you can redistribute it and/or modify
 
4
# it under the terms of the GNU General Public License as published by
 
5
# the Free Software Foundation; either version 2 of the License, or
 
6
# (at your option) any later version.
 
7
#
 
8
# This program is distributed in the hope that it will be useful,
 
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 
11
# GNU General Public License for more details.
 
12
#
 
13
# You should have received a copy of the GNU General Public License
 
14
# along with this program; if not, write to the Free Software
 
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
16
 
 
17
"""Symbol versioning tests."""
 
18
 
 
19
import warnings
 
20
 
 
21
from breezy import symbol_versioning
 
22
from breezy.sixish import PY3
 
23
from breezy.symbol_versioning import (
 
24
    deprecated_function,
 
25
    deprecated_in,
 
26
    deprecated_method,
 
27
    )
 
28
from breezy.tests import TestCase
 
29
 
 
30
 
 
31
@deprecated_function(deprecated_in((0, 7, 0)))
 
32
def sample_deprecated_function():
 
33
    """Deprecated function docstring."""
 
34
    return 1
 
35
 
 
36
 
 
37
a_deprecated_list = symbol_versioning.deprecated_list(deprecated_in((0, 9, 0)),
 
38
    'a_deprecated_list', ['one'], extra="Don't use me")
 
39
 
 
40
 
 
41
a_deprecated_dict = symbol_versioning.DeprecatedDict(
 
42
    deprecated_in((0, 14, 0)),
 
43
    'a_deprecated_dict',
 
44
    dict(a=42),
 
45
    advice='Pull the other one!',
 
46
    )
 
47
 
 
48
 
 
49
class TestDeprecationWarnings(TestCase):
 
50
 
 
51
    def capture_warning(self, message, category, stacklevel=None):
 
52
        self._warnings.append((message, category, stacklevel))
 
53
 
 
54
    def setUp(self):
 
55
        super(TestDeprecationWarnings, self).setUp()
 
56
        self._warnings = []
 
57
    
 
58
    @deprecated_method(deprecated_in((0, 7, 0)))
 
59
    def deprecated_method(self):
 
60
        """Deprecated method docstring.
 
61
 
 
62
        This might explain stuff.
 
63
        """
 
64
        return 1
 
65
 
 
66
    @staticmethod
 
67
    @deprecated_function(deprecated_in((0, 7, 0)))
 
68
    def deprecated_static():
 
69
        """Deprecated static."""
 
70
        return 1
 
71
 
 
72
    def test_deprecated_static(self):
 
73
        if PY3:
 
74
            expected_warning = (
 
75
                "breezy.tests.test_symbol_versioning.TestDeprecationWarnings."
 
76
                "deprecated_static "
 
77
                "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
78
        else:
 
79
            # XXX: The results are not quite right because the class name is not
 
80
            # shown on Python 2- however it is enough to give people a good indication of
 
81
            # where the problem is.
 
82
            expected_warning = (
 
83
                "breezy.tests.test_symbol_versioning."
 
84
                "deprecated_static "
 
85
                "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
86
        expected_docstring = (
 
87
            'Deprecated static.\n'
 
88
            '\n'
 
89
            'This function was deprecated in version 0.7.0.\n'
 
90
            )
 
91
        self.check_deprecated_callable(
 
92
            expected_warning, expected_docstring,
 
93
            "deprecated_static",
 
94
            "breezy.tests.test_symbol_versioning",
 
95
            self.deprecated_static)
 
96
 
 
97
    def test_deprecated_method(self):
 
98
        expected_warning = (
 
99
            "breezy.tests.test_symbol_versioning."
 
100
            "TestDeprecationWarnings.deprecated_method "
 
101
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
102
        expected_docstring = (
 
103
            'Deprecated method docstring.\n'
 
104
            '\n'
 
105
            '        This might explain stuff.\n'
 
106
            '        \n'
 
107
            '        This method was deprecated in version 0.7.0.\n'
 
108
            '        ')
 
109
        self.check_deprecated_callable(expected_warning, expected_docstring,
 
110
                                       "deprecated_method",
 
111
                                       "breezy.tests.test_symbol_versioning",
 
112
                                       self.deprecated_method)
 
113
 
 
114
    def test_deprecated_function(self):
 
115
        expected_warning = (
 
116
            "breezy.tests.test_symbol_versioning.sample_deprecated_function "
 
117
            "was deprecated in version 0.7.0.", DeprecationWarning, 2)
 
118
        expected_docstring = ('Deprecated function docstring.\n'
 
119
                              '\n'
 
120
                              'This function was deprecated in version 0.7.0.\n'
 
121
                              )
 
122
        self.check_deprecated_callable(expected_warning, expected_docstring,
 
123
                                       "sample_deprecated_function",
 
124
                                       "breezy.tests.test_symbol_versioning",
 
125
                                       sample_deprecated_function)
 
126
 
 
127
    def test_deprecated_list(self):
 
128
        expected_warning = (
 
129
            "Modifying a_deprecated_list was deprecated in version 0.9.0."
 
130
            " Don't use me", DeprecationWarning, 3)
 
131
        old_warning_method = symbol_versioning.warn
 
132
        try:
 
133
            symbol_versioning.set_warning_method(self.capture_warning)
 
134
            self.assertEqual(['one'], a_deprecated_list)
 
135
            self.assertEqual([], self._warnings)
 
136
 
 
137
            a_deprecated_list.append('foo')
 
138
            self.assertEqual([expected_warning], self._warnings)
 
139
            self.assertEqual(['one', 'foo'], a_deprecated_list)
 
140
 
 
141
            a_deprecated_list.extend(['bar', 'baz'])
 
142
            self.assertEqual([expected_warning]*2, self._warnings)
 
143
            self.assertEqual(['one', 'foo', 'bar', 'baz'], a_deprecated_list)
 
144
 
 
145
            a_deprecated_list.insert(1, 'xxx')
 
146
            self.assertEqual([expected_warning]*3, self._warnings)
 
147
            self.assertEqual(['one', 'xxx', 'foo', 'bar', 'baz'], a_deprecated_list)
 
148
 
 
149
            a_deprecated_list.remove('foo')
 
150
            self.assertEqual([expected_warning]*4, self._warnings)
 
151
            self.assertEqual(['one', 'xxx', 'bar', 'baz'], a_deprecated_list)
 
152
 
 
153
            val = a_deprecated_list.pop()
 
154
            self.assertEqual([expected_warning]*5, self._warnings)
 
155
            self.assertEqual('baz', val)
 
156
            self.assertEqual(['one', 'xxx', 'bar'], a_deprecated_list)
 
157
 
 
158
            val = a_deprecated_list.pop(1)
 
159
            self.assertEqual([expected_warning]*6, self._warnings)
 
160
            self.assertEqual('xxx', val)
 
161
            self.assertEqual(['one', 'bar'], a_deprecated_list)
 
162
        finally:
 
163
            symbol_versioning.set_warning_method(old_warning_method)
 
164
 
 
165
    def test_deprecated_dict(self):
 
166
        expected_warning = (
 
167
            "access to a_deprecated_dict was deprecated in version 0.14.0."
 
168
            " Pull the other one!", DeprecationWarning, 2)
 
169
        old_warning_method = symbol_versioning.warn
 
170
        try:
 
171
            symbol_versioning.set_warning_method(self.capture_warning)
 
172
            self.assertEqual(len(a_deprecated_dict), 1)
 
173
            self.assertEqual([expected_warning], self._warnings)
 
174
 
 
175
            a_deprecated_dict['b'] = 42
 
176
            self.assertEqual(a_deprecated_dict['b'], 42)
 
177
            self.assertTrue('b' in a_deprecated_dict)
 
178
            del a_deprecated_dict['b']
 
179
            self.assertFalse('b' in a_deprecated_dict)
 
180
            self.assertEqual([expected_warning] * 6, self._warnings)
 
181
        finally:
 
182
            symbol_versioning.set_warning_method(old_warning_method)
 
183
 
 
184
 
 
185
    def check_deprecated_callable(self, expected_warning, expected_docstring,
 
186
                                  expected_name, expected_module,
 
187
                                  deprecated_callable):
 
188
        if __doc__ is None:
 
189
            # With -OO the docstring should just be the deprecated version
 
190
            expected_docstring = expected_docstring.split('\n')[-2].lstrip()
 
191
        old_warning_method = symbol_versioning.warn
 
192
        try:
 
193
            symbol_versioning.set_warning_method(self.capture_warning)
 
194
            self.assertEqual(1, deprecated_callable())
 
195
            self.assertEqual([expected_warning], self._warnings)
 
196
            deprecated_callable()
 
197
            self.assertEqual([expected_warning, expected_warning],
 
198
                             self._warnings)
 
199
            self.assertEqualDiff(expected_docstring, deprecated_callable.__doc__)
 
200
            self.assertEqualDiff(expected_name, deprecated_callable.__name__)
 
201
            self.assertEqualDiff(expected_module, deprecated_callable.__module__)
 
202
            self.assertTrue(deprecated_callable.is_deprecated)
 
203
        finally:
 
204
            symbol_versioning.set_warning_method(old_warning_method)
 
205
 
 
206
    def test_deprecated_passed(self):
 
207
        self.assertEqual(True, symbol_versioning.deprecated_passed(None))
 
208
        self.assertEqual(True, symbol_versioning.deprecated_passed(True))
 
209
        self.assertEqual(True, symbol_versioning.deprecated_passed(False))
 
210
        self.assertEqual(False,
 
211
                         symbol_versioning.deprecated_passed(
 
212
                            symbol_versioning.DEPRECATED_PARAMETER))
 
213
 
 
214
    def test_deprecation_string(self):
 
215
        """We can get a deprecation string for a method or function."""
 
216
        err_message = symbol_versioning.deprecation_string(
 
217
            self.test_deprecation_string,
 
218
            deprecated_in((0, 11, 0)))
 
219
        self.assertEqual(err_message,
 
220
                 'breezy.tests.test_symbol_versioning.TestDeprecationWarnings.'
 
221
                 'test_deprecation_string was deprecated in '
 
222
                 'version 0.11.0.')
 
223
 
 
224
        self.assertEqual('breezy.symbol_versioning.deprecated_function was '
 
225
            'deprecated in version 0.11.0.',
 
226
            symbol_versioning.deprecation_string(
 
227
                symbol_versioning.deprecated_function,
 
228
                deprecated_in((0, 11, 0))))
 
229
 
 
230
 
 
231
class TestSuppressAndActivate(TestCase):
 
232
 
 
233
    def setUp(self):
 
234
        super(TestSuppressAndActivate, self).setUp()
 
235
        existing_filters = list(warnings.filters)
 
236
        def restore():
 
237
            warnings.filters[:] = existing_filters
 
238
        self.addCleanup(restore)
 
239
        # Clean out the filters so we have a clean slate.
 
240
        warnings.resetwarnings()
 
241
 
 
242
    def assertFirstWarning(self, action, category):
 
243
        """Test the first warning in the filters is correct"""
 
244
        first = warnings.filters[0]
 
245
        self.assertEqual((action, category), (first[0], first[2]))
 
246
 
 
247
    def test_suppress_deprecation_warnings(self):
 
248
        """suppress_deprecation_warnings sets DeprecationWarning to ignored."""
 
249
        symbol_versioning.suppress_deprecation_warnings()
 
250
        self.assertFirstWarning('ignore', DeprecationWarning)
 
251
 
 
252
    def test_set_restore_filters(self):
 
253
        original_filters = warnings.filters[:]
 
254
        symbol_versioning.suppress_deprecation_warnings()()
 
255
        self.assertEqual(original_filters, warnings.filters)
 
256
 
 
257
    def test_suppress_deprecation_with_warning_filter(self):
 
258
        """don't suppress if we already have a filter"""
 
259
        warnings.filterwarnings('error', category=Warning)
 
260
        self.assertFirstWarning('error', Warning)
 
261
        self.assertEqual(1, len(warnings.filters))
 
262
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
263
        self.assertFirstWarning('error', Warning)
 
264
        self.assertEqual(1, len(warnings.filters))
 
265
 
 
266
    def test_suppress_deprecation_with_filter(self):
 
267
        """don't suppress if we already have a filter"""
 
268
        warnings.filterwarnings('error', category=DeprecationWarning)
 
269
        self.assertFirstWarning('error', DeprecationWarning)
 
270
        self.assertEqual(1, len(warnings.filters))
 
271
        symbol_versioning.suppress_deprecation_warnings(override=False)
 
272
        self.assertFirstWarning('error', DeprecationWarning)
 
273
        self.assertEqual(1, len(warnings.filters))
 
274
        symbol_versioning.suppress_deprecation_warnings(override=True)
 
275
        self.assertFirstWarning('ignore', DeprecationWarning)
 
276
        self.assertEqual(2, len(warnings.filters))
 
277
 
 
278
    def test_activate_deprecation_no_error(self):
 
279
        # First nuke the filters, so we know it is clean
 
280
        symbol_versioning.activate_deprecation_warnings()
 
281
        self.assertFirstWarning('default', DeprecationWarning)
 
282
 
 
283
    def test_activate_deprecation_with_error(self):
 
284
        # First nuke the filters, so we know it is clean
 
285
        # Add a warning == error rule
 
286
        warnings.filterwarnings('error', category=Warning)
 
287
        self.assertFirstWarning('error', Warning)
 
288
        self.assertEqual(1, len(warnings.filters))
 
289
        symbol_versioning.activate_deprecation_warnings(override=False)
 
290
        # There should not be a new warning
 
291
        self.assertFirstWarning('error', Warning)
 
292
        self.assertEqual(1, len(warnings.filters))
 
293
 
 
294
    def test_activate_deprecation_with_DW_error(self):
 
295
        # First nuke the filters, so we know it is clean
 
296
        # Add a warning == error rule
 
297
        warnings.filterwarnings('error', category=DeprecationWarning)
 
298
        self.assertFirstWarning('error', DeprecationWarning)
 
299
        self.assertEqual(1, len(warnings.filters))
 
300
        symbol_versioning.activate_deprecation_warnings(override=False)
 
301
        # There should not be a new warning
 
302
        self.assertFirstWarning('error', DeprecationWarning)
 
303
        self.assertEqual(1, len(warnings.filters))
 
304
        symbol_versioning.activate_deprecation_warnings(override=True)
 
305
        self.assertFirstWarning('default', DeprecationWarning)
 
306
        self.assertEqual(2, len(warnings.filters))