/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to breezy/commit.py

Support user.signingkey configuration variable in .git/config.

Merged from https://code.launchpad.net/~jelmer/brz/local-git-key/+merge/381000

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005-2011 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
 
17
from __future__ import absolute_import
17
18
 
18
19
# The newly committed revision is going to have a shape corresponding
19
20
# to that of the working tree.  Files that are not in the
49
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
51
# the rest of the code; add a deprecation of the old name.
51
52
 
52
 
from bzrlib import (
 
53
from . import (
53
54
    debug,
54
55
    errors,
55
 
    revision,
56
56
    trace,
57
 
    tree,
 
57
    ui,
58
58
    )
59
 
from bzrlib.branch import Branch
60
 
from bzrlib.cleanup import OperationWithCleanups
61
 
import bzrlib.config
62
 
from bzrlib.errors import (BzrError, PointlessCommit,
63
 
                           ConflictsInTree,
64
 
                           StrictCommitFailed
65
 
                           )
66
 
from bzrlib.osutils import (get_user_encoding,
67
 
                            is_inside_any,
68
 
                            minimum_path_selection,
69
 
                            splitpath,
70
 
                            )
71
 
from bzrlib.trace import mutter, note, is_quiet
72
 
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
73
 
from bzrlib import symbol_versioning
74
 
from bzrlib.urlutils import unescape_for_display
75
 
import bzrlib.ui
 
59
from .branch import Branch
 
60
from .cleanup import ExitStack
 
61
import breezy.config
 
62
from .errors import (BzrError,
 
63
                     ConflictsInTree,
 
64
                     StrictCommitFailed
 
65
                     )
 
66
from .osutils import (get_user_encoding,
 
67
                      has_symlinks,
 
68
                      is_inside_any,
 
69
                      minimum_path_selection,
 
70
                      )
 
71
from .trace import mutter, note, is_quiet
 
72
from .tree import TreeChange
 
73
from .urlutils import unescape_for_display
 
74
from .i18n import gettext
 
75
 
 
76
 
 
77
class PointlessCommit(BzrError):
 
78
 
 
79
    _fmt = "No changes to commit"
 
80
 
 
81
 
 
82
class CannotCommitSelectedFileMerge(BzrError):
 
83
 
 
84
    _fmt = 'Selected-file commit of merges is not supported yet:'\
 
85
        ' files %(files_str)s'
 
86
 
 
87
    def __init__(self, files):
 
88
        files_str = ', '.join(files)
 
89
        BzrError.__init__(self, files=files, files_str=files_str)
 
90
 
 
91
 
 
92
def filter_excluded(iter_changes, exclude):
 
93
    """Filter exclude filenames.
 
94
 
 
95
    :param iter_changes: iter_changes function
 
96
    :param exclude: List of paths to exclude
 
97
    :return: iter_changes function
 
98
    """
 
99
    for change in iter_changes:
 
100
        new_excluded = (change.path[1] is not None and
 
101
                        is_inside_any(exclude, change.path[1]))
 
102
 
 
103
        old_excluded = (change.path[0] is not None and
 
104
                        is_inside_any(exclude, change.path[0]))
 
105
 
 
106
        if old_excluded and new_excluded:
 
107
            continue
 
108
 
 
109
        if old_excluded or new_excluded:
 
110
            # TODO(jelmer): Perhaps raise an error here instead?
 
111
            continue
 
112
 
 
113
        yield change
76
114
 
77
115
 
78
116
class NullCommitReporter(object):
79
117
    """I report on progress of a commit."""
80
118
 
81
 
    def started(self, revno, revid, location=None):
82
 
        if location is None:
83
 
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
84
 
                                   "to started.", DeprecationWarning,
85
 
                                   stacklevel=2)
 
119
    def started(self, revno, revid, location):
86
120
        pass
87
121
 
88
122
    def snapshot_change(self, change, path):
114
148
        note(format, *args)
115
149
 
116
150
    def snapshot_change(self, change, path):
117
 
        if path == '' and change in ('added', 'modified'):
 
151
        if path == '' and change in (gettext('added'), gettext('modified')):
118
152
            return
119
153
        self._note("%s %s", change, path)
120
154
 
121
 
    def started(self, revno, rev_id, location=None):
122
 
        if location is not None:
123
 
            location = ' to: ' + unescape_for_display(location, 'utf-8')
 
155
    def started(self, revno, rev_id, location):
 
156
        self._note(
 
157
            gettext('Committing to: %s'),
 
158
            unescape_for_display(location, 'utf-8'))
 
159
 
 
160
    def completed(self, revno, rev_id):
 
161
        if revno is not None:
 
162
            self._note(gettext('Committed revision %d.'), revno)
 
163
            # self._note goes to the console too; so while we want to log the
 
164
            # rev_id, we can't trivially only log it. (See bug 526425). Long
 
165
            # term we should rearrange the reporting structure, but for now
 
166
            # we just mutter seperately. We mutter the revid and revno together
 
167
            # so that concurrent bzr invocations won't lead to confusion.
 
168
            mutter('Committed revid %s as revno %d.', rev_id, revno)
124
169
        else:
125
 
            # When started was added, location was only made optional by
126
 
            # accident.  Matt Nordhoff 20071129
127
 
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
128
 
                                   "to started.", DeprecationWarning,
129
 
                                   stacklevel=2)
130
 
            location = ''
131
 
        self._note('Committing%s', location)
132
 
 
133
 
    def completed(self, revno, rev_id):
134
 
        self._note('Committed revision %d.', revno)
135
 
        # self._note goes to the console too; so while we want to log the
136
 
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
 
        # term we should rearrange the reporting structure, but for now
138
 
        # we just mutter seperately. We mutter the revid and revno together
139
 
        # so that concurrent bzr invocations won't lead to confusion.
140
 
        mutter('Committed revid %s as revno %d.', rev_id, revno)
 
170
            self._note(gettext('Committed revid %s.'), rev_id)
141
171
 
142
172
    def deleted(self, path):
143
 
        self._note('deleted %s', path)
 
173
        self._note(gettext('deleted %s'), path)
144
174
 
145
175
    def missing(self, path):
146
 
        self._note('missing %s', path)
 
176
        self._note(gettext('missing %s'), path)
147
177
 
148
178
    def renamed(self, change, old_path, new_path):
149
179
        self._note('%s %s => %s', change, old_path, new_path)
164
194
            the working directory; these should be removed from the
165
195
            working inventory.
166
196
    """
 
197
 
167
198
    def __init__(self,
168
199
                 reporter=None,
169
 
                 config=None):
 
200
                 config_stack=None):
170
201
        """Create a Commit object.
171
202
 
172
203
        :param reporter: the default reporter to use or None to decide later
173
204
        """
174
205
        self.reporter = reporter
175
 
        self.config = config
 
206
        self.config_stack = config_stack
176
207
 
177
208
    @staticmethod
178
 
    def update_revprops(revprops, branch, authors=None, author=None,
 
209
    def update_revprops(revprops, branch, authors=None,
179
210
                        local=False, possible_master_transports=None):
180
211
        if revprops is None:
181
212
            revprops = {}
182
213
        if possible_master_transports is None:
183
214
            possible_master_transports = []
184
 
        if not 'branch-nick' in revprops:
185
 
            revprops['branch-nick'] = branch._get_nick(
 
215
        if (u'branch-nick' not in revprops and
 
216
                branch.repository._format.supports_storing_branch_nick):
 
217
            revprops[u'branch-nick'] = branch._get_nick(
186
218
                local,
187
219
                possible_master_transports)
188
220
        if authors is not None:
189
 
            if author is not None:
190
 
                raise AssertionError('Specifying both author and authors '
191
 
                        'is not allowed. Specify just authors instead')
192
 
            if 'author' in revprops or 'authors' in revprops:
 
221
            if u'author' in revprops or u'authors' in revprops:
193
222
                # XXX: maybe we should just accept one of them?
194
223
                raise AssertionError('author property given twice')
195
224
            if authors:
196
225
                for individual in authors:
197
226
                    if '\n' in individual:
198
227
                        raise AssertionError('\\n is not a valid character '
199
 
                                'in an author identity')
200
 
                revprops['authors'] = '\n'.join(authors)
201
 
        if author is not None:
202
 
            symbol_versioning.warn('The parameter author was deprecated'
203
 
                   ' in version 1.13. Use authors instead',
204
 
                   DeprecationWarning)
205
 
            if 'author' in revprops or 'authors' in revprops:
206
 
                # XXX: maybe we should just accept one of them?
207
 
                raise AssertionError('author property given twice')
208
 
            if '\n' in author:
209
 
                raise AssertionError('\\n is not a valid character '
210
 
                        'in an author identity')
211
 
            revprops['authors'] = author
 
228
                                             'in an author identity')
 
229
                revprops[u'authors'] = '\n'.join(authors)
212
230
        return revprops
213
231
 
214
232
    def commit(self,
229
247
               message_callback=None,
230
248
               recursive='down',
231
249
               exclude=None,
232
 
               possible_master_transports=None):
 
250
               possible_master_transports=None,
 
251
               lossy=False):
233
252
        """Commit working copy as a new revision.
234
253
 
235
254
        :param message: the commit message (it or message_callback is required)
236
 
        :param message_callback: A callback: message = message_callback(cmt_obj)
 
255
        :param message_callback: A callback: message =
 
256
            message_callback(cmt_obj)
237
257
 
238
258
        :param timestamp: if not None, seconds-since-epoch for a
239
259
            postdated/predated commit.
262
282
        :param exclude: None or a list of relative paths to exclude from the
263
283
            commit. Pending changes to excluded files will be ignored by the
264
284
            commit.
265
 
        """
266
 
        operation = OperationWithCleanups(self._commit)
267
 
        self.revprops = revprops or {}
268
 
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
269
 
        self.config = config or self.config
270
 
        return operation.run(
271
 
               message=message,
272
 
               timestamp=timestamp,
273
 
               timezone=timezone,
274
 
               committer=committer,
275
 
               specific_files=specific_files,
276
 
               rev_id=rev_id,
277
 
               allow_pointless=allow_pointless,
278
 
               strict=strict,
279
 
               verbose=verbose,
280
 
               working_tree=working_tree,
281
 
               local=local,
282
 
               reporter=reporter,
283
 
               message_callback=message_callback,
284
 
               recursive=recursive,
285
 
               exclude=exclude,
286
 
               possible_master_transports=possible_master_transports)
287
 
 
288
 
    def _commit(self, operation, message, timestamp, timezone, committer,
289
 
            specific_files, rev_id, allow_pointless, strict, verbose,
290
 
            working_tree, local, reporter, message_callback, recursive,
291
 
            exclude, possible_master_transports):
292
 
        mutter('preparing to commit')
293
 
 
294
 
        if working_tree is None:
295
 
            raise BzrError("working_tree must be passed into commit().")
296
 
        else:
297
 
            self.work_tree = working_tree
298
 
            self.branch = self.work_tree.branch
299
 
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
300
 
                if not self.branch.repository.supports_rich_root():
301
 
                    raise errors.RootNotRich()
302
 
        if message_callback is None:
303
 
            if message is not None:
304
 
                if isinstance(message, str):
305
 
                    message = message.decode(get_user_encoding())
306
 
                message_callback = lambda x: message
307
 
            else:
308
 
                raise BzrError("The message or message_callback keyword"
309
 
                               " parameter is required for commit().")
310
 
 
311
 
        self.bound_branch = None
312
 
        self.any_entries_deleted = False
313
 
        if exclude is not None:
314
 
            self.exclude = sorted(
315
 
                minimum_path_selection(exclude))
316
 
        else:
317
 
            self.exclude = []
318
 
        self.local = local
319
 
        self.master_branch = None
320
 
        self.recursive = recursive
321
 
        self.rev_id = None
322
 
        # self.specific_files is None to indicate no filter, or any iterable to
323
 
        # indicate a filter - [] means no files at all, as per iter_changes.
324
 
        if specific_files is not None:
325
 
            self.specific_files = sorted(
326
 
                minimum_path_selection(specific_files))
327
 
        else:
328
 
            self.specific_files = None
329
 
            
330
 
        self.allow_pointless = allow_pointless
331
 
        self.message_callback = message_callback
332
 
        self.timestamp = timestamp
333
 
        self.timezone = timezone
334
 
        self.committer = committer
335
 
        self.strict = strict
336
 
        self.verbose = verbose
337
 
 
338
 
        self.work_tree.lock_write()
339
 
        operation.add_cleanup(self.work_tree.unlock)
340
 
        self.parents = self.work_tree.get_parent_ids()
341
 
        # We can use record_iter_changes IFF iter_changes is compatible with
342
 
        # the command line parameters, and the repository has fast delta
343
 
        # generation. See bug 347649.
344
 
        self.use_record_iter_changes = (
345
 
            not self.exclude and 
346
 
            not self.branch.repository._format.supports_tree_reference and
347
 
            (self.branch.repository._format.fast_deltas or
348
 
             len(self.parents) < 2))
349
 
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
350
 
        operation.add_cleanup(self.pb.finished)
351
 
        self.basis_revid = self.work_tree.last_revision()
352
 
        self.basis_tree = self.work_tree.basis_tree()
353
 
        self.basis_tree.lock_read()
354
 
        operation.add_cleanup(self.basis_tree.unlock)
355
 
        # Cannot commit with conflicts present.
356
 
        if len(self.work_tree.conflicts()) > 0:
357
 
            raise ConflictsInTree
358
 
 
359
 
        # Setup the bound branch variables as needed.
360
 
        self._check_bound_branch(operation, possible_master_transports)
361
 
 
362
 
        # Check that the working tree is up to date
363
 
        old_revno, new_revno = self._check_out_of_date_tree()
364
 
 
365
 
        # Complete configuration setup
366
 
        if reporter is not None:
367
 
            self.reporter = reporter
368
 
        elif self.reporter is None:
369
 
            self.reporter = self._select_reporter()
370
 
        if self.config is None:
371
 
            self.config = self.branch.get_config()
372
 
 
373
 
        self._set_specific_file_ids()
374
 
 
375
 
        # Setup the progress bar. As the number of files that need to be
376
 
        # committed in unknown, progress is reported as stages.
377
 
        # We keep track of entries separately though and include that
378
 
        # information in the progress bar during the relevant stages.
379
 
        self.pb_stage_name = ""
380
 
        self.pb_stage_count = 0
381
 
        self.pb_stage_total = 5
382
 
        if self.bound_branch:
383
 
            self.pb_stage_total += 1
384
 
        self.pb.show_pct = False
385
 
        self.pb.show_spinner = False
386
 
        self.pb.show_eta = False
387
 
        self.pb.show_count = True
388
 
        self.pb.show_bar = True
389
 
 
390
 
        self._gather_parents()
391
 
        # After a merge, a selected file commit is not supported.
392
 
        # See 'bzr help merge' for an explanation as to why.
393
 
        if len(self.parents) > 1 and self.specific_files is not None:
394
 
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
395
 
        # Excludes are a form of selected file commit.
396
 
        if len(self.parents) > 1 and self.exclude:
397
 
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
398
 
 
399
 
        # Collect the changes
400
 
        self._set_progress_stage("Collecting changes", counter=True)
401
 
        self.builder = self.branch.get_commit_builder(self.parents,
402
 
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
403
 
 
404
 
        try:
405
 
            self.builder.will_record_deletes()
406
 
            # find the location being committed to
407
 
            if self.bound_branch:
408
 
                master_location = self.master_branch.base
409
 
            else:
410
 
                master_location = self.branch.base
411
 
 
412
 
            # report the start of the commit
413
 
            self.reporter.started(new_revno, self.rev_id, master_location)
414
 
 
415
 
            self._update_builder_with_changes()
416
 
            self._check_pointless()
417
 
 
418
 
            # TODO: Now the new inventory is known, check for conflicts.
419
 
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
420
 
            # weave lines, because nothing should be recorded until it is known
421
 
            # that commit will succeed.
422
 
            self._set_progress_stage("Saving data locally")
423
 
            self.builder.finish_inventory()
424
 
 
425
 
            # Prompt the user for a commit message if none provided
426
 
            message = message_callback(self)
427
 
            self.message = message
428
 
 
429
 
            # Add revision data to the local branch
430
 
            self.rev_id = self.builder.commit(self.message)
431
 
 
432
 
        except Exception, e:
433
 
            mutter("aborting commit write group because of exception:")
434
 
            trace.log_exception_quietly()
435
 
            note("aborting commit write group: %r" % (e,))
436
 
            self.builder.abort()
437
 
            raise
438
 
 
439
 
        self._process_pre_hooks(old_revno, new_revno)
440
 
 
441
 
        # Upload revision data to the master.
442
 
        # this will propagate merged revisions too if needed.
443
 
        if self.bound_branch:
444
 
            self._set_progress_stage("Uploading data to master branch")
445
 
            # 'commit' to the master first so a timeout here causes the
446
 
            # local branch to be out of date
447
 
            self.master_branch.import_last_revision_info(
448
 
                self.branch.repository, new_revno, self.rev_id)
449
 
 
450
 
        # and now do the commit locally.
451
 
        self.branch.set_last_revision_info(new_revno, self.rev_id)
452
 
 
453
 
        # Make the working tree be up to date with the branch. This
454
 
        # includes automatic changes scheduled to be made to the tree, such
455
 
        # as updating its basis and unversioning paths that were missing.
456
 
        self.work_tree.unversion(self.deleted_ids)
457
 
        self._set_progress_stage("Updating the working tree")
458
 
        self.work_tree.update_basis_by_delta(self.rev_id,
459
 
             self.builder.get_basis_delta())
460
 
        self.reporter.completed(new_revno, self.rev_id)
461
 
        self._process_post_hooks(old_revno, new_revno)
462
 
        return self.rev_id
 
285
        :param lossy: When committing to a foreign VCS, ignore any
 
286
            data that can not be natively represented.
 
287
        """
 
288
        with ExitStack() as stack:
 
289
            self.revprops = revprops or {}
 
290
            # XXX: Can be set on __init__ or passed in - this is a bit ugly.
 
291
            self.config_stack = config or self.config_stack
 
292
            mutter('preparing to commit')
 
293
 
 
294
            if working_tree is None:
 
295
                raise BzrError("working_tree must be passed into commit().")
 
296
            else:
 
297
                self.work_tree = working_tree
 
298
                self.branch = self.work_tree.branch
 
299
                if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
 
300
                    if not self.branch.repository.supports_rich_root():
 
301
                        raise errors.RootNotRich()
 
302
            if message_callback is None:
 
303
                if message is not None:
 
304
                    if isinstance(message, bytes):
 
305
                        message = message.decode(get_user_encoding())
 
306
 
 
307
                    def message_callback(x):
 
308
                        return message
 
309
                else:
 
310
                    raise BzrError("The message or message_callback keyword"
 
311
                                   " parameter is required for commit().")
 
312
 
 
313
            self.bound_branch = None
 
314
            self.any_entries_deleted = False
 
315
            if exclude is not None:
 
316
                self.exclude = sorted(
 
317
                    minimum_path_selection(exclude))
 
318
            else:
 
319
                self.exclude = []
 
320
            self.local = local
 
321
            self.master_branch = None
 
322
            self.recursive = recursive
 
323
            self.rev_id = None
 
324
            # self.specific_files is None to indicate no filter, or any iterable to
 
325
            # indicate a filter - [] means no files at all, as per iter_changes.
 
326
            if specific_files is not None:
 
327
                self.specific_files = sorted(
 
328
                    minimum_path_selection(specific_files))
 
329
            else:
 
330
                self.specific_files = None
 
331
 
 
332
            self.allow_pointless = allow_pointless
 
333
            self.message_callback = message_callback
 
334
            self.timestamp = timestamp
 
335
            self.timezone = timezone
 
336
            self.committer = committer
 
337
            self.strict = strict
 
338
            self.verbose = verbose
 
339
 
 
340
            stack.enter_context(self.work_tree.lock_write())
 
341
            self.parents = self.work_tree.get_parent_ids()
 
342
            self.pb = ui.ui_factory.nested_progress_bar()
 
343
            stack.callback(self.pb.finished)
 
344
            self.basis_revid = self.work_tree.last_revision()
 
345
            self.basis_tree = self.work_tree.basis_tree()
 
346
            stack.enter_context(self.basis_tree.lock_read())
 
347
            # Cannot commit with conflicts present.
 
348
            if len(self.work_tree.conflicts()) > 0:
 
349
                raise ConflictsInTree
 
350
 
 
351
            # Setup the bound branch variables as needed.
 
352
            self._check_bound_branch(stack, possible_master_transports)
 
353
            if self.config_stack is None:
 
354
                self.config_stack = self.work_tree.get_config_stack()
 
355
 
 
356
            # Check that the working tree is up to date
 
357
            old_revno, old_revid, new_revno = self._check_out_of_date_tree()
 
358
 
 
359
            # Complete configuration setup
 
360
            if reporter is not None:
 
361
                self.reporter = reporter
 
362
            elif self.reporter is None:
 
363
                self.reporter = self._select_reporter()
 
364
 
 
365
            # Setup the progress bar. As the number of files that need to be
 
366
            # committed in unknown, progress is reported as stages.
 
367
            # We keep track of entries separately though and include that
 
368
            # information in the progress bar during the relevant stages.
 
369
            self.pb_stage_name = ""
 
370
            self.pb_stage_count = 0
 
371
            self.pb_stage_total = 5
 
372
            if self.bound_branch:
 
373
                # 2 extra stages: "Uploading data to master branch" and "Merging
 
374
                # tags to master branch"
 
375
                self.pb_stage_total += 2
 
376
            self.pb.show_pct = False
 
377
            self.pb.show_spinner = False
 
378
            self.pb.show_eta = False
 
379
            self.pb.show_count = True
 
380
            self.pb.show_bar = True
 
381
 
 
382
            # After a merge, a selected file commit is not supported.
 
383
            # See 'bzr help merge' for an explanation as to why.
 
384
            if len(self.parents) > 1 and self.specific_files is not None:
 
385
                raise CannotCommitSelectedFileMerge(self.specific_files)
 
386
            # Excludes are a form of selected file commit.
 
387
            if len(self.parents) > 1 and self.exclude:
 
388
                raise CannotCommitSelectedFileMerge(self.exclude)
 
389
 
 
390
            # Collect the changes
 
391
            self._set_progress_stage("Collecting changes", counter=True)
 
392
            self._lossy = lossy
 
393
            self.builder = self.branch.get_commit_builder(
 
394
                self.parents, self.config_stack, timestamp, timezone, committer,
 
395
                self.revprops, rev_id, lossy=lossy)
 
396
 
 
397
            if self.builder.updates_branch and self.bound_branch:
 
398
                self.builder.abort()
 
399
                raise AssertionError(
 
400
                    "bound branches not supported for commit builders "
 
401
                    "that update the branch")
 
402
 
 
403
            try:
 
404
                # find the location being committed to
 
405
                if self.bound_branch:
 
406
                    master_location = self.master_branch.base
 
407
                else:
 
408
                    master_location = self.branch.base
 
409
 
 
410
                # report the start of the commit
 
411
                self.reporter.started(new_revno, self.rev_id, master_location)
 
412
 
 
413
                self._update_builder_with_changes()
 
414
                self._check_pointless()
 
415
 
 
416
                # TODO: Now the new inventory is known, check for conflicts.
 
417
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
 
418
                # weave lines, because nothing should be recorded until it is known
 
419
                # that commit will succeed.
 
420
                self._set_progress_stage("Saving data locally")
 
421
                self.builder.finish_inventory()
 
422
 
 
423
                # Prompt the user for a commit message if none provided
 
424
                message = message_callback(self)
 
425
                self.message = message
 
426
 
 
427
                # Add revision data to the local branch
 
428
                self.rev_id = self.builder.commit(self.message)
 
429
 
 
430
            except Exception:
 
431
                mutter("aborting commit write group because of exception:")
 
432
                trace.log_exception_quietly()
 
433
                self.builder.abort()
 
434
                raise
 
435
 
 
436
            self._update_branches(old_revno, old_revid, new_revno)
 
437
 
 
438
            # Make the working tree be up to date with the branch. This
 
439
            # includes automatic changes scheduled to be made to the tree, such
 
440
            # as updating its basis and unversioning paths that were missing.
 
441
            self.work_tree.unversion(self.deleted_paths)
 
442
            self._set_progress_stage("Updating the working tree")
 
443
            self.work_tree.update_basis_by_delta(self.rev_id,
 
444
                                                 self.builder.get_basis_delta())
 
445
            self.reporter.completed(new_revno, self.rev_id)
 
446
            self._process_post_hooks(old_revno, new_revno)
 
447
            return self.rev_id
 
448
 
 
449
    def _update_branches(self, old_revno, old_revid, new_revno):
 
450
        """Update the master and local branch to the new revision.
 
451
 
 
452
        This will try to make sure that the master branch is updated
 
453
        before the local branch.
 
454
 
 
455
        :param old_revno: Revision number of master branch before the
 
456
            commit
 
457
        :param old_revid: Tip of master branch before the commit
 
458
        :param new_revno: Revision number of the new commit
 
459
        """
 
460
        if not self.builder.updates_branch:
 
461
            self._process_pre_hooks(old_revno, new_revno)
 
462
 
 
463
            # Upload revision data to the master.
 
464
            # this will propagate merged revisions too if needed.
 
465
            if self.bound_branch:
 
466
                self._set_progress_stage("Uploading data to master branch")
 
467
                # 'commit' to the master first so a timeout here causes the
 
468
                # local branch to be out of date
 
469
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
 
470
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
 
471
                if self._lossy:
 
472
                    self.branch.fetch(self.master_branch, self.rev_id)
 
473
 
 
474
            # and now do the commit locally.
 
475
            if new_revno is None:
 
476
                # Keep existing behaviour around ghosts
 
477
                new_revno = 1
 
478
            self.branch.set_last_revision_info(new_revno, self.rev_id)
 
479
        else:
 
480
            try:
 
481
                self._process_pre_hooks(old_revno, new_revno)
 
482
            except BaseException:
 
483
                # The commit builder will already have updated the branch,
 
484
                # revert it.
 
485
                self.branch.set_last_revision_info(old_revno, old_revid)
 
486
                raise
 
487
 
 
488
        # Merge local tags to remote
 
489
        if self.bound_branch:
 
490
            self._set_progress_stage("Merging tags to master branch")
 
491
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
 
492
                self.master_branch.tags)
 
493
            if tag_conflicts:
 
494
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
 
495
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
 
496
                    "\n".join(warning_lines))))
463
497
 
464
498
    def _select_reporter(self):
465
499
        """Select the CommitReporter to use."""
473
507
        # A merge with no effect on files
474
508
        if len(self.parents) > 1:
475
509
            return
476
 
        # TODO: we could simplify this by using self.builder.basis_delta.
477
 
 
478
 
        # The initial commit adds a root directory, but this in itself is not
479
 
        # a worthwhile commit.
480
 
        if (self.basis_revid == revision.NULL_REVISION and
481
 
            ((self.builder.new_inventory is not None and
482
 
             len(self.builder.new_inventory) == 1) or
483
 
            len(self.builder._basis_delta) == 1)):
484
 
            raise PointlessCommit()
485
510
        if self.builder.any_changes():
486
511
            return
487
512
        raise PointlessCommit()
488
513
 
489
 
    def _check_bound_branch(self, operation, possible_master_transports=None):
 
514
    def _check_bound_branch(self, stack, possible_master_transports=None):
490
515
        """Check to see if the local branch is bound.
491
516
 
492
517
        If it is bound, then most of the commit will actually be
508
533
        # If the master branch is bound, we must fail
509
534
        master_bound_location = self.master_branch.get_bound_location()
510
535
        if master_bound_location:
511
 
            raise errors.CommitToDoubleBoundBranch(self.branch,
512
 
                    self.master_branch, master_bound_location)
 
536
            raise errors.CommitToDoubleBoundBranch(
 
537
                self.branch, self.master_branch, master_bound_location)
513
538
 
514
539
        # TODO: jam 20051230 We could automatically push local
515
540
        #       commits to the remote branch if they would fit.
517
542
        #       to local.
518
543
 
519
544
        # Make sure the local branch is identical to the master
520
 
        master_info = self.master_branch.last_revision_info()
521
 
        local_info = self.branch.last_revision_info()
522
 
        if local_info != master_info:
 
545
        master_revid = self.master_branch.last_revision()
 
546
        local_revid = self.branch.last_revision()
 
547
        if local_revid != master_revid:
523
548
            raise errors.BoundBranchOutOfDate(self.branch,
524
 
                    self.master_branch)
 
549
                                              self.master_branch)
525
550
 
526
551
        # Now things are ready to change the master branch
527
552
        # so grab the lock
528
553
        self.bound_branch = self.branch
529
 
        self.master_branch.lock_write()
530
 
        operation.add_cleanup(self.master_branch.unlock)
 
554
        stack.enter_context(self.master_branch.lock_write())
531
555
 
532
556
    def _check_out_of_date_tree(self):
533
557
        """Check that the working tree is up to date.
534
558
 
535
 
        :return: old_revision_number,new_revision_number tuple
 
559
        :return: old_revision_number, old_revision_id, new_revision_number
 
560
            tuple
536
561
        """
537
562
        try:
538
563
            first_tree_parent = self.work_tree.get_parent_ids()[0]
541
566
            # this is so that we still consider the master branch
542
567
            # - in a checkout scenario the tree may have no
543
568
            # parents but the branch may do.
544
 
            first_tree_parent = bzrlib.revision.NULL_REVISION
545
 
        old_revno, master_last = self.master_branch.last_revision_info()
 
569
            first_tree_parent = breezy.revision.NULL_REVISION
 
570
        if (self.master_branch._format.stores_revno() or
 
571
                self.config_stack.get('calculate_revnos')):
 
572
            try:
 
573
                old_revno, master_last = self.master_branch.last_revision_info()
 
574
            except errors.UnsupportedOperation:
 
575
                master_last = self.master_branch.last_revision()
 
576
                old_revno = self.branch.revision_id_to_revno(master_last)
 
577
        else:
 
578
            master_last = self.master_branch.last_revision()
 
579
            old_revno = None
546
580
        if master_last != first_tree_parent:
547
 
            if master_last != bzrlib.revision.NULL_REVISION:
 
581
            if master_last != breezy.revision.NULL_REVISION:
548
582
                raise errors.OutOfDateTree(self.work_tree)
549
 
        if self.branch.repository.has_revision(first_tree_parent):
 
583
        if (old_revno is not None and
 
584
                self.branch.repository.has_revision(first_tree_parent)):
550
585
            new_revno = old_revno + 1
551
586
        else:
552
587
            # ghost parents never appear in revision history.
553
 
            new_revno = 1
554
 
        return old_revno,new_revno
 
588
            new_revno = None
 
589
        return old_revno, master_last, new_revno
555
590
 
556
591
    def _process_pre_hooks(self, old_revno, new_revno):
557
592
        """Process any registered pre commit hooks."""
563
598
        # Process the post commit hooks, if any
564
599
        self._set_progress_stage("Running post_commit hooks")
565
600
        # old style commit hooks - should be deprecated ? (obsoleted in
566
 
        # 0.15)
567
 
        if self.config.post_commit() is not None:
568
 
            hooks = self.config.post_commit().split(' ')
 
601
        # 0.15^H^H^H^H 2.5.0)
 
602
        post_commit = self.config_stack.get('post_commit')
 
603
        if post_commit is not None:
 
604
            hooks = post_commit.split(' ')
569
605
            # this would be nicer with twisted.python.reflect.namedAny
570
606
            for hook in hooks:
571
607
                result = eval(hook + '(branch, rev_id)',
572
 
                              {'branch':self.branch,
573
 
                               'bzrlib':bzrlib,
574
 
                               'rev_id':self.rev_id})
 
608
                              {'branch': self.branch,
 
609
                               'breezy': breezy,
 
610
                               'rev_id': self.rev_id})
575
611
        # process new style post commit hooks
576
612
        self._process_hooks("post_commit", old_revno, new_revno)
577
613
 
592
628
        if self.parents:
593
629
            old_revid = self.parents[0]
594
630
        else:
595
 
            old_revid = bzrlib.revision.NULL_REVISION
 
631
            old_revid = breezy.revision.NULL_REVISION
596
632
 
597
633
        if hook_name == "pre_commit":
598
634
            future_tree = self.builder.revision_tree()
599
635
            tree_delta = future_tree.changes_from(self.basis_tree,
600
 
                                             include_root=True)
 
636
                                                  include_root=True)
601
637
 
602
638
        for hook in Branch.hooks[hook_name]:
603
639
            # show the running hook in the progress bar. As hooks may
618
654
                     old_revno, old_revid, new_revno, self.rev_id,
619
655
                     tree_delta, future_tree)
620
656
 
621
 
    def _gather_parents(self):
622
 
        """Record the parents of a merge for merge detection."""
623
 
        # TODO: Make sure that this list doesn't contain duplicate
624
 
        # entries and the order is preserved when doing this.
625
 
        if self.use_record_iter_changes:
626
 
            return
627
 
        self.basis_inv = self.basis_tree.inventory
628
 
        self.parent_invs = [self.basis_inv]
629
 
        for revision in self.parents[1:]:
630
 
            if self.branch.repository.has_revision(revision):
631
 
                mutter('commit parent revision {%s}', revision)
632
 
                inventory = self.branch.repository.get_inventory(revision)
633
 
                self.parent_invs.append(inventory)
634
 
            else:
635
 
                mutter('commit parent ghost revision {%s}', revision)
636
 
 
637
657
    def _update_builder_with_changes(self):
638
658
        """Update the commit builder with the data about what has changed.
639
659
        """
640
 
        exclude = self.exclude
641
660
        specific_files = self.specific_files
642
 
        mutter("Selecting files for commit with filter %s", specific_files)
 
661
        mutter("Selecting files for commit with filter %r", specific_files)
643
662
 
644
663
        self._check_strict()
645
 
        if self.use_record_iter_changes:
646
 
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
647
 
                specific_files=specific_files)
648
 
            iter_changes = self._filter_iter_changes(iter_changes)
649
 
            for file_id, path, fs_hash in self.builder.record_iter_changes(
 
664
        iter_changes = self.work_tree.iter_changes(
 
665
            self.basis_tree, specific_files=specific_files)
 
666
        if self.exclude:
 
667
            iter_changes = filter_excluded(iter_changes, self.exclude)
 
668
        iter_changes = self._filter_iter_changes(iter_changes)
 
669
        for path, fs_hash in self.builder.record_iter_changes(
650
670
                self.work_tree, self.basis_revid, iter_changes):
651
 
                self.work_tree._observed_sha1(file_id, path, fs_hash)
652
 
        else:
653
 
            # Build the new inventory
654
 
            self._populate_from_inventory()
655
 
            self._record_unselected()
656
 
            self._report_and_accumulate_deletes()
 
671
            self.work_tree._observed_sha1(path, fs_hash)
657
672
 
658
673
    def _filter_iter_changes(self, iter_changes):
659
674
        """Process iter_changes.
660
675
 
661
 
        This method reports on the changes in iter_changes to the user, and 
 
676
        This method reports on the changes in iter_changes to the user, and
662
677
        converts 'missing' entries in the iter_changes iterator to 'deleted'
663
678
        entries. 'missing' entries have their
664
679
 
667
682
        """
668
683
        reporter = self.reporter
669
684
        report_changes = reporter.is_verbose()
670
 
        deleted_ids = []
 
685
        deleted_paths = []
671
686
        for change in iter_changes:
672
687
            if report_changes:
673
 
                old_path = change[1][0]
674
 
                new_path = change[1][1]
675
 
                versioned = change[3][1]
676
 
            kind = change[6][1]
677
 
            versioned = change[3][1]
 
688
                old_path = change.path[0]
 
689
                new_path = change.path[1]
 
690
                versioned = change.versioned[1]
 
691
            kind = change.kind[1]
 
692
            versioned = change.versioned[1]
678
693
            if kind is None and versioned:
679
694
                # 'missing' path
680
695
                if report_changes:
681
696
                    reporter.missing(new_path)
682
 
                deleted_ids.append(change[0])
 
697
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
 
698
                    trace.warning('Ignoring "%s" as symlinks are not '
 
699
                                  'supported on this filesystem.' % (change.path[0],))
 
700
                    continue
 
701
                deleted_paths.append(change.path[1])
683
702
                # Reset the new path (None) and new versioned flag (False)
684
 
                change = (change[0], (change[1][0], None), change[2],
685
 
                    (change[3][0], False)) + change[4:]
 
703
                change = change.discard_new()
 
704
                new_path = change.path[1]
 
705
                versioned = False
686
706
            elif kind == 'tree-reference':
687
707
                if self.recursive == 'down':
688
 
                    self._commit_nested_tree(change[0], change[1][1])
689
 
            if change[3][0] or change[3][1]:
 
708
                    self._commit_nested_tree(change.path[1])
 
709
            if change.versioned[0] or change.versioned[1]:
690
710
                yield change
691
711
                if report_changes:
692
712
                    if new_path is None:
693
713
                        reporter.deleted(old_path)
694
714
                    elif old_path is None:
695
 
                        reporter.snapshot_change('added', new_path)
 
715
                        reporter.snapshot_change(gettext('added'), new_path)
696
716
                    elif old_path != new_path:
697
 
                        reporter.renamed('renamed', old_path, new_path)
 
717
                        reporter.renamed(gettext('renamed'),
 
718
                                         old_path, new_path)
698
719
                    else:
699
 
                        if (new_path or 
700
 
                            self.work_tree.branch.repository._format.rich_root_data):
 
720
                        if (new_path
 
721
                                or self.work_tree.branch.repository._format.rich_root_data):
701
722
                            # Don't report on changes to '' in non rich root
702
723
                            # repositories.
703
 
                            reporter.snapshot_change('modified', new_path)
 
724
                            reporter.snapshot_change(
 
725
                                gettext('modified'), new_path)
704
726
            self._next_progress_entry()
705
 
        # Unversion IDs that were found to be deleted
706
 
        self.deleted_ids = deleted_ids
707
 
 
708
 
    def _record_unselected(self):
709
 
        # If specific files are selected, then all un-selected files must be
710
 
        # recorded in their previous state. For more details, see
711
 
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
712
 
        if self.specific_files or self.exclude:
713
 
            specific_files = self.specific_files or []
714
 
            for path, old_ie in self.basis_inv.iter_entries():
715
 
                if old_ie.file_id in self.builder.new_inventory:
716
 
                    # already added - skip.
717
 
                    continue
718
 
                if (is_inside_any(specific_files, path)
719
 
                    and not is_inside_any(self.exclude, path)):
720
 
                    # was inside the selected path, and not excluded - if not
721
 
                    # present it has been deleted so skip.
722
 
                    continue
723
 
                # From here down it was either not selected, or was excluded:
724
 
                # We preserve the entry unaltered.
725
 
                ie = old_ie.copy()
726
 
                # Note: specific file commits after a merge are currently
727
 
                # prohibited. This test is for sanity/safety in case it's
728
 
                # required after that changes.
729
 
                if len(self.parents) > 1:
730
 
                    ie.revision = None
731
 
                self.builder.record_entry_contents(ie, self.parent_invs, path,
732
 
                    self.basis_tree, None)
733
 
 
734
 
    def _report_and_accumulate_deletes(self):
735
 
        if (isinstance(self.basis_inv, Inventory)
736
 
            and isinstance(self.builder.new_inventory, Inventory)):
737
 
            # the older Inventory classes provide a _byid dict, and building a
738
 
            # set from the keys of this dict is substantially faster than even
739
 
            # getting a set of ids from the inventory
740
 
            #
741
 
            # <lifeless> set(dict) is roughly the same speed as
742
 
            # set(iter(dict)) and both are significantly slower than
743
 
            # set(dict.keys())
744
 
            deleted_ids = set(self.basis_inv._byid.keys()) - \
745
 
               set(self.builder.new_inventory._byid.keys())
746
 
        else:
747
 
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
748
 
        if deleted_ids:
749
 
            self.any_entries_deleted = True
750
 
            deleted = [(self.basis_tree.id2path(file_id), file_id)
751
 
                for file_id in deleted_ids]
752
 
            deleted.sort()
753
 
            # XXX: this is not quite directory-order sorting
754
 
            for path, file_id in deleted:
755
 
                self.builder.record_delete(path, file_id)
756
 
                self.reporter.deleted(path)
 
727
        # Unversion files that were found to be deleted
 
728
        self.deleted_paths = deleted_paths
757
729
 
758
730
    def _check_strict(self):
759
731
        # XXX: when we use iter_changes this would likely be faster if
764
736
            for unknown in self.work_tree.unknowns():
765
737
                raise StrictCommitFailed()
766
738
 
767
 
    def _populate_from_inventory(self):
768
 
        """Populate the CommitBuilder by walking the working tree inventory."""
769
 
        # Build the revision inventory.
770
 
        #
771
 
        # This starts by creating a new empty inventory. Depending on
772
 
        # which files are selected for commit, and what is present in the
773
 
        # current tree, the new inventory is populated. inventory entries
774
 
        # which are candidates for modification have their revision set to
775
 
        # None; inventory entries that are carried over untouched have their
776
 
        # revision set to their prior value.
777
 
        #
778
 
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
779
 
        # results to create a new inventory at the same time, which results
780
 
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
781
 
        # ADHB 11-07-2006
782
 
 
783
 
        specific_files = self.specific_files
784
 
        exclude = self.exclude
785
 
        report_changes = self.reporter.is_verbose()
786
 
        deleted_ids = []
787
 
        # A tree of paths that have been deleted. E.g. if foo/bar has been
788
 
        # deleted, then we have {'foo':{'bar':{}}}
789
 
        deleted_paths = {}
790
 
        # XXX: Note that entries may have the wrong kind because the entry does
791
 
        # not reflect the status on disk.
792
 
        work_inv = self.work_tree.inventory
793
 
        # NB: entries will include entries within the excluded ids/paths
794
 
        # because iter_entries_by_dir has no 'exclude' facility today.
795
 
        entries = work_inv.iter_entries_by_dir(
796
 
            specific_file_ids=self.specific_file_ids, yield_parents=True)
797
 
        for path, existing_ie in entries:
798
 
            file_id = existing_ie.file_id
799
 
            name = existing_ie.name
800
 
            parent_id = existing_ie.parent_id
801
 
            kind = existing_ie.kind
802
 
            # Skip files that have been deleted from the working tree.
803
 
            # The deleted path ids are also recorded so they can be explicitly
804
 
            # unversioned later.
805
 
            if deleted_paths:
806
 
                path_segments = splitpath(path)
807
 
                deleted_dict = deleted_paths
808
 
                for segment in path_segments:
809
 
                    deleted_dict = deleted_dict.get(segment, None)
810
 
                    if not deleted_dict:
811
 
                        # We either took a path not present in the dict
812
 
                        # (deleted_dict was None), or we've reached an empty
813
 
                        # child dir in the dict, so are now a sub-path.
814
 
                        break
815
 
                else:
816
 
                    deleted_dict = None
817
 
                if deleted_dict is not None:
818
 
                    # the path has a deleted parent, do not add it.
819
 
                    continue
820
 
            if exclude and is_inside_any(exclude, path):
821
 
                # Skip excluded paths. Excluded paths are processed by
822
 
                # _update_builder_with_changes.
823
 
                continue
824
 
            content_summary = self.work_tree.path_content_summary(path)
825
 
            kind = content_summary[0]
826
 
            # Note that when a filter of specific files is given, we must only
827
 
            # skip/record deleted files matching that filter.
828
 
            if not specific_files or is_inside_any(specific_files, path):
829
 
                if kind == 'missing':
830
 
                    if not deleted_paths:
831
 
                        # path won't have been split yet.
832
 
                        path_segments = splitpath(path)
833
 
                    deleted_dict = deleted_paths
834
 
                    for segment in path_segments:
835
 
                        deleted_dict = deleted_dict.setdefault(segment, {})
836
 
                    self.reporter.missing(path)
837
 
                    self._next_progress_entry()
838
 
                    deleted_ids.append(file_id)
839
 
                    continue
840
 
            # TODO: have the builder do the nested commit just-in-time IF and
841
 
            # only if needed.
842
 
            if kind == 'tree-reference':
843
 
                # enforce repository nested tree policy.
844
 
                if (not self.work_tree.supports_tree_reference() or
845
 
                    # repository does not support it either.
846
 
                    not self.branch.repository._format.supports_tree_reference):
847
 
                    kind = 'directory'
848
 
                    content_summary = (kind, None, None, None)
849
 
                elif self.recursive == 'down':
850
 
                    nested_revision_id = self._commit_nested_tree(
851
 
                        file_id, path)
852
 
                    content_summary = (kind, None, None, nested_revision_id)
853
 
                else:
854
 
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
855
 
                    content_summary = (kind, None, None, nested_revision_id)
856
 
 
857
 
            # Record an entry for this item
858
 
            # Note: I don't particularly want to have the existing_ie
859
 
            # parameter but the test suite currently (28-Jun-07) breaks
860
 
            # without it thanks to a unicode normalisation issue. :-(
861
 
            definitely_changed = kind != existing_ie.kind
862
 
            self._record_entry(path, file_id, specific_files, kind, name,
863
 
                parent_id, definitely_changed, existing_ie, report_changes,
864
 
                content_summary)
865
 
 
866
 
        # Unversion IDs that were found to be deleted
867
 
        self.deleted_ids = deleted_ids
868
 
 
869
 
    def _commit_nested_tree(self, file_id, path):
 
739
    def _commit_nested_tree(self, path):
870
740
        "Commit a nested tree."
871
 
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
 
741
        sub_tree = self.work_tree.get_nested_tree(path)
872
742
        # FIXME: be more comprehensive here:
873
743
        # this works when both trees are in --trees repository,
874
744
        # but when both are bound to a different repository,
876
746
        # finally implement the explicit-caches approach design
877
747
        # a while back - RBC 20070306.
878
748
        if sub_tree.branch.repository.has_same_location(
879
 
            self.work_tree.branch.repository):
 
749
                self.work_tree.branch.repository):
880
750
            sub_tree.branch.repository = \
881
751
                self.work_tree.branch.repository
882
752
        try:
883
753
            return sub_tree.commit(message=None, revprops=self.revprops,
884
 
                recursive=self.recursive,
885
 
                message_callback=self.message_callback,
886
 
                timestamp=self.timestamp, timezone=self.timezone,
887
 
                committer=self.committer,
888
 
                allow_pointless=self.allow_pointless,
889
 
                strict=self.strict, verbose=self.verbose,
890
 
                local=self.local, reporter=self.reporter)
891
 
        except errors.PointlessCommit:
892
 
            return self.work_tree.get_reference_revision(file_id)
893
 
 
894
 
    def _record_entry(self, path, file_id, specific_files, kind, name,
895
 
        parent_id, definitely_changed, existing_ie, report_changes,
896
 
        content_summary):
897
 
        "Record the new inventory entry for a path if any."
898
 
        # mutter('check %s {%s}', path, file_id)
899
 
        # mutter('%s selected for commit', path)
900
 
        if definitely_changed or existing_ie is None:
901
 
            ie = make_entry(kind, name, parent_id, file_id)
902
 
        else:
903
 
            ie = existing_ie.copy()
904
 
            ie.revision = None
905
 
        # For carried over entries we don't care about the fs hash - the repo
906
 
        # isn't generating a sha, so we're not saving computation time.
907
 
        _, _, fs_hash = self.builder.record_entry_contents(
908
 
            ie, self.parent_invs, path, self.work_tree, content_summary)
909
 
        if report_changes:
910
 
            self._report_change(ie, path)
911
 
        if fs_hash:
912
 
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
913
 
        return ie
914
 
 
915
 
    def _report_change(self, ie, path):
916
 
        """Report a change to the user.
917
 
 
918
 
        The change that has occurred is described relative to the basis
919
 
        inventory.
920
 
        """
921
 
        if (self.basis_inv.has_id(ie.file_id)):
922
 
            basis_ie = self.basis_inv[ie.file_id]
923
 
        else:
924
 
            basis_ie = None
925
 
        change = ie.describe_change(basis_ie, ie)
926
 
        if change in (InventoryEntry.RENAMED,
927
 
            InventoryEntry.MODIFIED_AND_RENAMED):
928
 
            old_path = self.basis_inv.id2path(ie.file_id)
929
 
            self.reporter.renamed(change, old_path, path)
930
 
            self._next_progress_entry()
931
 
        else:
932
 
            if change == 'unchanged':
933
 
                return
934
 
            self.reporter.snapshot_change(change, path)
935
 
            self._next_progress_entry()
 
754
                                   recursive=self.recursive,
 
755
                                   message_callback=self.message_callback,
 
756
                                   timestamp=self.timestamp,
 
757
                                   timezone=self.timezone,
 
758
                                   committer=self.committer,
 
759
                                   allow_pointless=self.allow_pointless,
 
760
                                   strict=self.strict, verbose=self.verbose,
 
761
                                   local=self.local, reporter=self.reporter)
 
762
        except PointlessCommit:
 
763
            return self.work_tree.get_reference_revision(path)
936
764
 
937
765
    def _set_progress_stage(self, name, counter=False):
938
766
        """Set the progress stage and emit an update to the progress bar."""
951
779
 
952
780
    def _emit_progress(self):
953
781
        if self.pb_entries_count is not None:
954
 
            text = "%s [%d] - Stage" % (self.pb_stage_name,
955
 
                self.pb_entries_count)
 
782
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
 
783
                                                       self.pb_entries_count)
956
784
        else:
957
 
            text = "%s - Stage" % (self.pb_stage_name, )
 
785
            text = gettext("%s - Stage") % (self.pb_stage_name, )
958
786
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
959
 
 
960
 
    def _set_specific_file_ids(self):
961
 
        """populate self.specific_file_ids if we will use it."""
962
 
        if not self.use_record_iter_changes:
963
 
            # If provided, ensure the specified files are versioned
964
 
            if self.specific_files is not None:
965
 
                # Note: This routine is being called because it raises
966
 
                # PathNotVersionedError as a side effect of finding the IDs. We
967
 
                # later use the ids we found as input to the working tree
968
 
                # inventory iterator, so we only consider those ids rather than
969
 
                # examining the whole tree again.
970
 
                # XXX: Dont we have filter_unversioned to do this more
971
 
                # cheaply?
972
 
                self.specific_file_ids = tree.find_ids_across_trees(
973
 
                    self.specific_files, [self.basis_tree, self.work_tree])
974
 
            else:
975
 
                self.specific_file_ids = None