/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to breezy/tests/test_merge.py

  • Committer: Breezy landing bot
  • Author(s): Colin Watson
  • Date: 2020-11-16 21:47:08 UTC
  • mfrom: (7521.1.1 remove-lp-workaround)
  • Revision ID: breezy.the.bot@gmail.com-20201116214708-jos209mgxi41oy15
Remove breezy.git workaround for bazaar.launchpad.net.

Merged from https://code.launchpad.net/~cjwatson/brz/remove-lp-workaround/+merge/393710

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2012 Canonical Ltd
 
1
# Copyright (C) 2005-2012, 2016 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
 
17
import contextlib
17
18
import os
18
 
from StringIO import StringIO
19
19
 
20
 
from bzrlib import (
 
20
from .. import (
21
21
    branch as _mod_branch,
22
 
    cleanup,
23
22
    conflicts,
24
23
    errors,
25
 
    inventory,
26
 
    knit,
27
24
    memorytree,
28
25
    merge as _mod_merge,
29
26
    option,
30
27
    revision as _mod_revision,
31
28
    tests,
32
29
    transform,
 
30
    )
 
31
from ..bzr import (
 
32
    inventory,
 
33
    knit,
33
34
    versionedfile,
34
35
    )
35
 
from bzrlib.conflicts import ConflictList, TextConflict
36
 
from bzrlib.errors import UnrelatedBranches, NoCommits
37
 
from bzrlib.merge import transform_tree, merge_inner, _PlanMerge
38
 
from bzrlib.osutils import basename, pathjoin, file_kind
39
 
from bzrlib.tests import (
 
36
from ..conflicts import ConflictList
 
37
from ..bzr.conflicts import TextConflict, MissingParent, UnversionedParent, DeletingParent, ContentsConflict
 
38
from ..errors import UnrelatedBranches, NoCommits
 
39
from ..merge import transform_tree, merge_inner, _PlanMerge
 
40
from ..osutils import basename, pathjoin, file_kind
 
41
from . import (
40
42
    features,
41
43
    TestCaseWithMemoryTransport,
42
44
    TestCaseWithTransport,
43
45
    test_merge_core,
44
46
    )
45
 
from bzrlib.workingtree import WorkingTree
 
47
from ..workingtree import WorkingTree
46
48
 
47
49
 
48
50
class TestMerge(TestCaseWithTransport):
83
85
        tip = wt1.commit('empty commit')
84
86
        wt2 = self.make_branch_and_tree('branch2')
85
87
        wt2.pull(wt1.branch)
86
 
        with file('branch1/foo', 'wb') as f:
87
 
            f.write('foo')
88
 
        with file('branch1/bar', 'wb') as f:
89
 
            f.write('bar')
 
88
        with open('branch1/foo', 'wb') as f:
 
89
            f.write(b'foo')
 
90
        with open('branch1/bar', 'wb') as f:
 
91
            f.write(b'bar')
90
92
        wt1.add('foo')
91
93
        wt1.add('bar')
92
94
        wt1.commit('add foobar')
105
107
        br1.fetch(wt2.branch)
106
108
        # merge all of branch 2 into branch 1 even though they
107
109
        # are not related.
108
 
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), 'null:')
 
110
        wt1.merge_from_branch(wt2.branch, wt2.last_revision(), b'null:')
109
111
        self.assertEqual([br1.last_revision(), wt2.branch.last_revision()],
110
 
            wt1.get_parent_ids())
 
112
                         wt1.get_parent_ids())
111
113
        return (wt1, wt2.branch)
112
114
 
113
115
    def test_two_roots(self):
133
135
                                         this_branch=wt.branch,
134
136
                                         do_merge=False)
135
137
        with merger.make_preview_transform() as tt:
136
 
            self.assertEqual([], tt.find_conflicts())
 
138
            self.assertEqual([], tt.find_raw_conflicts())
137
139
            preview = tt.get_preview_tree()
138
 
            self.assertEqual(wt.get_root_id(), preview.get_root_id())
 
140
            self.assertEqual(wt.path2id(''), preview.path2id(''))
139
141
 
140
142
    def test_merge_unrelated_retains_root(self):
141
143
        wt = self.make_branch_and_tree('tree')
144
146
        merger = _mod_merge.Merge3Merger(wt, wt, wt.basis_tree(), other_tree,
145
147
                                         this_branch=wt.branch,
146
148
                                         do_merge=False)
147
 
        with transform.TransformPreview(wt) as merger.tt:
 
149
        with wt.preview_transform() as merger.tt:
148
150
            merger._compute_transform()
149
151
            new_root_id = merger.tt.final_file_id(merger.tt.root)
150
 
            self.assertEqual(wt.get_root_id(), new_root_id)
 
152
            self.assertEqual(wt.path2id(''), new_root_id)
151
153
 
152
154
    def test_create_rename(self):
153
155
        """Rename an inventory entry while creating the file"""
154
 
        tree =self.make_branch_and_tree('.')
155
 
        with file('name1', 'wb') as f: f.write('Hello')
 
156
        tree = self.make_branch_and_tree('.')
 
157
        with open('name1', 'wb') as f:
 
158
            f.write(b'Hello')
156
159
        tree.add('name1')
157
160
        tree.commit(message="hello")
158
161
        tree.rename_one('name1', 'name2')
161
164
 
162
165
    def test_layered_rename(self):
163
166
        """Rename both child and parent at same time"""
164
 
        tree =self.make_branch_and_tree('.')
 
167
        tree = self.make_branch_and_tree('.')
165
168
        os.mkdir('dirname1')
166
169
        tree.add('dirname1')
167
170
        filename = pathjoin('dirname1', 'name1')
168
 
        with file(filename, 'wb') as f: f.write('Hello')
 
171
        with open(filename, 'wb') as f:
 
172
            f.write(b'Hello')
169
173
        tree.add(filename)
170
174
        tree.commit(message="hello")
171
175
        filename2 = pathjoin('dirname1', 'name2')
175
179
 
176
180
    def test_ignore_zero_merge_inner(self):
177
181
        # Test that merge_inner's ignore zero parameter is effective
178
 
        tree_a =self.make_branch_and_tree('a')
 
182
        tree_a = self.make_branch_and_tree('a')
179
183
        tree_a.commit(message="hello")
180
 
        dir_b = tree_a.bzrdir.sprout('b')
 
184
        dir_b = tree_a.controldir.sprout('b')
181
185
        tree_b = dir_b.open_workingtree()
182
186
        tree_b.lock_write()
183
187
        self.addCleanup(tree_b.unlock)
184
188
        tree_a.commit(message="hello again")
185
 
        log = StringIO()
186
189
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
187
190
                    this_tree=tree_b, ignore_zero=True)
188
191
        self.assertTrue('All changes applied successfully.\n' not in
189
 
            self.get_log())
 
192
                        self.get_log())
190
193
        tree_b.revert()
191
194
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
192
195
                    this_tree=tree_b, ignore_zero=False)
193
 
        self.assertTrue('All changes applied successfully.\n' in self.get_log())
 
196
        self.assertTrue(
 
197
            'All changes applied successfully.\n' in self.get_log())
194
198
 
195
199
    def test_merge_inner_conflicts(self):
196
200
        tree_a = self.make_branch_and_tree('a')
197
 
        tree_a.set_conflicts(ConflictList([TextConflict('patha')]))
 
201
        tree_a.set_conflicts([TextConflict('patha')])
198
202
        merge_inner(tree_a.branch, tree_a, tree_a, this_tree=tree_a)
199
203
        self.assertEqual(1, len(tree_a.conflicts()))
200
204
 
201
205
    def test_rmdir_conflict(self):
202
206
        tree_a = self.make_branch_and_tree('a')
203
207
        self.build_tree(['a/b/'])
204
 
        tree_a.add('b', 'b-id')
 
208
        tree_a.add('b', b'b-id')
205
209
        tree_a.commit('added b')
206
210
        # basis_tree() is only guaranteed to be valid as long as it is actually
207
211
        # the basis tree. This mutates the tree after grabbing basis, so go to
208
212
        # the repository.
209
 
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
210
 
        tree_z = tree_a.bzrdir.sprout('z').open_workingtree()
 
213
        base_tree = tree_a.branch.repository.revision_tree(
 
214
            tree_a.last_revision())
 
215
        tree_z = tree_a.controldir.sprout('z').open_workingtree()
211
216
        self.build_tree(['a/b/c'])
212
217
        tree_a.add('b/c')
213
218
        tree_a.commit('added c')
215
220
        tree_z.commit('removed b')
216
221
        merge_inner(tree_z.branch, tree_a, base_tree, this_tree=tree_z)
217
222
        self.assertEqual([
218
 
            conflicts.MissingParent('Created directory', 'b', 'b-id'),
219
 
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
 
223
            MissingParent('Created directory', 'b', b'b-id'),
 
224
            UnversionedParent('Versioned directory', 'b', b'b-id')],
220
225
            tree_z.conflicts())
221
226
        merge_inner(tree_a.branch, tree_z.basis_tree(), base_tree,
222
227
                    this_tree=tree_a)
223
228
        self.assertEqual([
224
 
            conflicts.DeletingParent('Not deleting', 'b', 'b-id'),
225
 
            conflicts.UnversionedParent('Versioned directory', 'b', 'b-id')],
 
229
            DeletingParent('Not deleting', 'b', b'b-id'),
 
230
            UnversionedParent('Versioned directory', 'b', b'b-id')],
226
231
            tree_a.conflicts())
227
232
 
228
233
    def test_nested_merge(self):
 
234
        self.knownFailure(
 
235
            'iter_changes doesn\'t work with changes in nested trees')
229
236
        tree = self.make_branch_and_tree('tree',
230
 
            format='development-subtree')
 
237
                                         format='development-subtree')
231
238
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
232
 
            format='development-subtree')
233
 
        sub_tree.set_root_id('sub-tree-root')
234
 
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
 
239
                                             format='development-subtree')
 
240
        sub_tree.set_root_id(b'sub-tree-root')
 
241
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
235
242
        sub_tree.add('file')
236
243
        sub_tree.commit('foo')
237
244
        tree.add_reference(sub_tree)
238
245
        tree.commit('set text to 1')
239
 
        tree2 = tree.bzrdir.sprout('tree2').open_workingtree()
 
246
        tree2 = tree.controldir.sprout('tree2').open_workingtree()
240
247
        # modify the file in the subtree
241
 
        self.build_tree_contents([('tree2/sub-tree/file', 'text2')])
 
248
        self.build_tree_contents([('tree2/sub-tree/file', b'text2')])
242
249
        # and merge the changes from the diverged subtree into the containing
243
250
        # tree
244
251
        tree2.commit('changed file text')
245
252
        tree.merge_from_branch(tree2.branch)
246
 
        self.assertFileEqual('text2', 'tree/sub-tree/file')
 
253
        self.assertFileEqual(b'text2', 'tree/sub-tree/file')
247
254
 
248
255
    def test_merge_with_missing(self):
249
256
        tree_a = self.make_branch_and_tree('tree_a')
250
 
        self.build_tree_contents([('tree_a/file', 'content_1')])
 
257
        self.build_tree_contents([('tree_a/file', b'content_1')])
251
258
        tree_a.add('file')
252
259
        tree_a.commit('commit base')
253
260
        # basis_tree() is only guaranteed to be valid as long as it is actually
254
261
        # the basis tree. This test commits to the tree after grabbing basis,
255
262
        # so we go to the repository.
256
 
        base_tree = tree_a.branch.repository.revision_tree(tree_a.last_revision())
257
 
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
258
 
        self.build_tree_contents([('tree_a/file', 'content_2')])
 
263
        base_tree = tree_a.branch.repository.revision_tree(
 
264
            tree_a.last_revision())
 
265
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
 
266
        self.build_tree_contents([('tree_a/file', b'content_2')])
259
267
        tree_a.commit('commit other')
260
268
        other_tree = tree_a.basis_tree()
261
269
        # 'file' is now missing but isn't altered in any commit in b so no
265
273
 
266
274
    def test_merge_kind_change(self):
267
275
        tree_a = self.make_branch_and_tree('tree_a')
268
 
        self.build_tree_contents([('tree_a/file', 'content_1')])
269
 
        tree_a.add('file', 'file-id')
 
276
        self.build_tree_contents([('tree_a/file', b'content_1')])
 
277
        tree_a.add('file', b'file-id')
270
278
        tree_a.commit('added file')
271
 
        tree_b = tree_a.bzrdir.sprout('tree_b').open_workingtree()
 
279
        tree_b = tree_a.controldir.sprout('tree_b').open_workingtree()
272
280
        os.unlink('tree_a/file')
273
281
        self.build_tree(['tree_a/file/'])
274
282
        tree_a.commit('changed file to directory')
276
284
        self.assertEqual('directory', file_kind('tree_b/file'))
277
285
        tree_b.revert()
278
286
        self.assertEqual('file', file_kind('tree_b/file'))
279
 
        self.build_tree_contents([('tree_b/file', 'content_2')])
 
287
        self.build_tree_contents([('tree_b/file', b'content_2')])
280
288
        tree_b.commit('content change')
281
289
        tree_b.merge_from_branch(tree_a.branch)
282
290
        self.assertEqual(tree_b.conflicts(),
283
 
                         [conflicts.ContentsConflict('file',
284
 
                          file_id='file-id')])
 
291
                         [ContentsConflict('file', file_id=b'file-id')])
285
292
 
286
293
    def test_merge_type_registry(self):
287
294
        merge_type_option = option.Option.OPTIONS['merge-type']
288
295
        self.assertFalse('merge4' in [x[0] for x in
289
 
                        merge_type_option.iter_switches()])
 
296
                                      merge_type_option.iter_switches()])
290
297
        registry = _mod_merge.get_merge_type_registry()
291
 
        registry.register_lazy('merge4', 'bzrlib.merge', 'Merge4Merger',
 
298
        registry.register_lazy('merge4', 'breezy.merge', 'Merge4Merger',
292
299
                               'time-travelling merge')
293
300
        self.assertTrue('merge4' in [x[0] for x in
294
 
                        merge_type_option.iter_switches()])
 
301
                                     merge_type_option.iter_switches()])
295
302
        registry.remove('merge4')
296
303
        self.assertFalse('merge4' in [x[0] for x in
297
 
                        merge_type_option.iter_switches()])
 
304
                                      merge_type_option.iter_switches()])
298
305
 
299
306
    def test_merge_other_moves_we_deleted(self):
300
307
        tree_a = self.make_branch_and_tree('A')
302
309
        self.addCleanup(tree_a.unlock)
303
310
        self.build_tree(['A/a'])
304
311
        tree_a.add('a')
305
 
        tree_a.commit('1', rev_id='rev-1')
 
312
        tree_a.commit('1', rev_id=b'rev-1')
306
313
        tree_a.flush()
307
314
        tree_a.rename_one('a', 'b')
308
315
        tree_a.commit('2')
309
 
        bzrdir_b = tree_a.bzrdir.sprout('B', revision_id='rev-1')
 
316
        bzrdir_b = tree_a.controldir.sprout('B', revision_id=b'rev-1')
310
317
        tree_b = bzrdir_b.open_workingtree()
311
318
        tree_b.lock_write()
312
319
        self.addCleanup(tree_b.unlock)
324
331
        tree_a.commit('commit 1')
325
332
        tree_a.add(['file_2'])
326
333
        tree_a.commit('commit 2')
327
 
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
 
334
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
328
335
        tree_b.rename_one('file_1', 'renamed')
329
336
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
330
337
        merger.merge_type = _mod_merge.Merge3Merger
338
345
        tree_a.commit('commit 1')
339
346
        tree_a.add(['file_2'])
340
347
        tree_a.commit('commit 2')
341
 
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
 
348
        tree_b = tree_a.controldir.sprout('b').open_workingtree()
342
349
        tree_b.rename_one('file_1', 'renamed')
343
350
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
344
351
        merger.merge_type = _mod_merge.WeaveMerger
357
364
        'c', but not 'b'.
358
365
        """
359
366
        this_tree = self.make_branch_and_tree('this')
360
 
        self.build_tree_contents([('this/file', "a\n")])
 
367
        self.build_tree_contents([('this/file', b"a\n")])
361
368
        this_tree.add('file')
362
369
        this_tree.commit('rev1')
363
 
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
364
 
        self.build_tree_contents([('other/file', "a\nb\n")])
365
 
        other_tree.commit('rev2b', rev_id='rev2b')
366
 
        self.build_tree_contents([('other/file', "c\na\nb\n")])
367
 
        other_tree.commit('rev3b', rev_id='rev3b')
 
370
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
 
371
        self.build_tree_contents([('other/file', b"a\nb\n")])
 
372
        other_tree.commit('rev2b', rev_id=b'rev2b')
 
373
        self.build_tree_contents([('other/file', b"c\na\nb\n")])
 
374
        other_tree.commit('rev3b', rev_id=b'rev3b')
368
375
        this_tree.lock_write()
369
376
        self.addCleanup(this_tree.unlock)
370
377
        return this_tree, other_tree
371
378
 
372
379
    def test_weave_cherrypick(self):
373
380
        this_tree, other_tree = self.prepare_cherrypick()
374
 
        merger = _mod_merge.Merger.from_revision_ids(None,
375
 
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
 
381
        merger = _mod_merge.Merger.from_revision_ids(
 
382
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
376
383
        merger.merge_type = _mod_merge.WeaveMerger
377
384
        merger.do_merge()
378
 
        self.assertFileEqual('c\na\n', 'this/file')
 
385
        self.assertFileEqual(b'c\na\n', 'this/file')
379
386
 
380
387
    def test_weave_cannot_reverse_cherrypick(self):
381
388
        this_tree, other_tree = self.prepare_cherrypick()
382
 
        merger = _mod_merge.Merger.from_revision_ids(None,
383
 
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
 
389
        merger = _mod_merge.Merger.from_revision_ids(
 
390
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
384
391
        merger.merge_type = _mod_merge.WeaveMerger
385
392
        self.assertRaises(errors.CannotReverseCherrypick, merger.do_merge)
386
393
 
387
394
    def test_merge3_can_reverse_cherrypick(self):
388
395
        this_tree, other_tree = self.prepare_cherrypick()
389
 
        merger = _mod_merge.Merger.from_revision_ids(None,
390
 
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
 
396
        merger = _mod_merge.Merger.from_revision_ids(
 
397
            this_tree, b'rev2b', b'rev3b', other_tree.branch)
391
398
        merger.merge_type = _mod_merge.Merge3Merger
392
399
        merger.do_merge()
393
400
 
394
401
    def test_merge3_will_detect_cherrypick(self):
395
402
        this_tree = self.make_branch_and_tree('this')
396
 
        self.build_tree_contents([('this/file', "a\n")])
 
403
        self.build_tree_contents([('this/file', b"a\n")])
397
404
        this_tree.add('file')
398
405
        this_tree.commit('rev1')
399
 
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
400
 
        self.build_tree_contents([('other/file', "a\nb\n")])
401
 
        other_tree.commit('rev2b', rev_id='rev2b')
402
 
        self.build_tree_contents([('other/file', "a\nb\nc\n")])
403
 
        other_tree.commit('rev3b', rev_id='rev3b')
 
406
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
 
407
        self.build_tree_contents([('other/file', b"a\nb\n")])
 
408
        other_tree.commit('rev2b', rev_id=b'rev2b')
 
409
        self.build_tree_contents([('other/file', b"a\nb\nc\n")])
 
410
        other_tree.commit('rev3b', rev_id=b'rev3b')
404
411
        this_tree.lock_write()
405
412
        self.addCleanup(this_tree.unlock)
406
413
 
407
 
        merger = _mod_merge.Merger.from_revision_ids(None,
408
 
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
 
414
        merger = _mod_merge.Merger.from_revision_ids(
 
415
            this_tree, b'rev3b', b'rev2b', other_tree.branch)
409
416
        merger.merge_type = _mod_merge.Merge3Merger
410
417
        merger.do_merge()
411
 
        self.assertFileEqual('a\n'
412
 
                             '<<<<<<< TREE\n'
413
 
                             '=======\n'
414
 
                             'c\n'
415
 
                             '>>>>>>> MERGE-SOURCE\n',
 
418
        self.assertFileEqual(b'a\n'
 
419
                             b'<<<<<<< TREE\n'
 
420
                             b'=======\n'
 
421
                             b'c\n'
 
422
                             b'>>>>>>> MERGE-SOURCE\n',
416
423
                             'this/file')
417
424
 
418
425
    def test_merge_reverse_revision_range(self):
422
429
        self.build_tree(['a'])
423
430
        tree.add('a')
424
431
        first_rev = tree.commit("added a")
425
 
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
426
 
                                          _mod_revision.NULL_REVISION,
427
 
                                          first_rev)
 
432
        merger = _mod_merge.Merger.from_revision_ids(tree,
 
433
                                                     _mod_revision.NULL_REVISION,
 
434
                                                     first_rev)
428
435
        merger.merge_type = _mod_merge.Merge3Merger
429
436
        merger.interesting_files = 'a'
430
437
        conflict_count = merger.do_merge()
436
443
 
437
444
    def test_make_merger(self):
438
445
        this_tree = self.make_branch_and_tree('this')
439
 
        this_tree.commit('rev1', rev_id='rev1')
440
 
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
441
 
        this_tree.commit('rev2', rev_id='rev2a')
442
 
        other_tree.commit('rev2', rev_id='rev2b')
 
446
        this_tree.commit('rev1', rev_id=b'rev1')
 
447
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
 
448
        this_tree.commit('rev2', rev_id=b'rev2a')
 
449
        other_tree.commit('rev2', rev_id=b'rev2b')
443
450
        this_tree.lock_write()
444
451
        self.addCleanup(this_tree.unlock)
445
 
        merger = _mod_merge.Merger.from_revision_ids(None,
446
 
            this_tree, 'rev2b', other_branch=other_tree.branch)
 
452
        merger = _mod_merge.Merger.from_revision_ids(
 
453
            this_tree, b'rev2b', other_branch=other_tree.branch)
447
454
        merger.merge_type = _mod_merge.Merge3Merger
448
455
        tree_merger = merger.make_merger()
449
456
        self.assertIs(_mod_merge.Merge3Merger, tree_merger.__class__)
450
 
        self.assertEqual('rev2b',
451
 
            tree_merger.other_tree.get_revision_id())
452
 
        self.assertEqual('rev1',
453
 
            tree_merger.base_tree.get_revision_id())
 
457
        self.assertEqual(b'rev2b',
 
458
                         tree_merger.other_tree.get_revision_id())
 
459
        self.assertEqual(b'rev1',
 
460
                         tree_merger.base_tree.get_revision_id())
454
461
        self.assertEqual(other_tree.branch, tree_merger.other_branch)
455
462
 
456
463
    def test_make_preview_transform(self):
457
464
        this_tree = self.make_branch_and_tree('this')
458
 
        self.build_tree_contents([('this/file', '1\n')])
459
 
        this_tree.add('file', 'file-id')
460
 
        this_tree.commit('rev1', rev_id='rev1')
461
 
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
462
 
        self.build_tree_contents([('this/file', '1\n2a\n')])
463
 
        this_tree.commit('rev2', rev_id='rev2a')
464
 
        self.build_tree_contents([('other/file', '2b\n1\n')])
465
 
        other_tree.commit('rev2', rev_id='rev2b')
 
465
        self.build_tree_contents([('this/file', b'1\n')])
 
466
        this_tree.add('file', b'file-id')
 
467
        this_tree.commit('rev1', rev_id=b'rev1')
 
468
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
 
469
        self.build_tree_contents([('this/file', b'1\n2a\n')])
 
470
        this_tree.commit('rev2', rev_id=b'rev2a')
 
471
        self.build_tree_contents([('other/file', b'2b\n1\n')])
 
472
        other_tree.commit('rev2', rev_id=b'rev2b')
466
473
        this_tree.lock_write()
467
474
        self.addCleanup(this_tree.unlock)
468
 
        merger = _mod_merge.Merger.from_revision_ids(None,
469
 
            this_tree, 'rev2b', other_branch=other_tree.branch)
 
475
        merger = _mod_merge.Merger.from_revision_ids(
 
476
            this_tree, b'rev2b', other_branch=other_tree.branch)
470
477
        merger.merge_type = _mod_merge.Merge3Merger
471
478
        tree_merger = merger.make_merger()
472
 
        tt = tree_merger.make_preview_transform()
473
 
        self.addCleanup(tt.finalize)
474
 
        preview_tree = tt.get_preview_tree()
475
 
        tree_file = this_tree.get_file('file-id')
476
 
        try:
477
 
            self.assertEqual('1\n2a\n', tree_file.read())
478
 
        finally:
479
 
            tree_file.close()
480
 
        preview_file = preview_tree.get_file('file-id')
481
 
        try:
482
 
            self.assertEqual('2b\n1\n2a\n', preview_file.read())
483
 
        finally:
484
 
            preview_file.close()
 
479
        with tree_merger.make_preview_transform() as tt:
 
480
            preview_tree = tt.get_preview_tree()
 
481
            with this_tree.get_file('file') as tree_file:
 
482
                self.assertEqual(b'1\n2a\n', tree_file.read())
 
483
            with preview_tree.get_file('file') as preview_file:
 
484
                self.assertEqual(b'2b\n1\n2a\n', preview_file.read())
485
485
 
486
486
    def test_do_merge(self):
487
487
        this_tree = self.make_branch_and_tree('this')
488
 
        self.build_tree_contents([('this/file', '1\n')])
489
 
        this_tree.add('file', 'file-id')
490
 
        this_tree.commit('rev1', rev_id='rev1')
491
 
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
492
 
        self.build_tree_contents([('this/file', '1\n2a\n')])
493
 
        this_tree.commit('rev2', rev_id='rev2a')
494
 
        self.build_tree_contents([('other/file', '2b\n1\n')])
495
 
        other_tree.commit('rev2', rev_id='rev2b')
 
488
        self.build_tree_contents([('this/file', b'1\n')])
 
489
        this_tree.add('file', b'file-id')
 
490
        this_tree.commit('rev1', rev_id=b'rev1')
 
491
        other_tree = this_tree.controldir.sprout('other').open_workingtree()
 
492
        self.build_tree_contents([('this/file', b'1\n2a\n')])
 
493
        this_tree.commit('rev2', rev_id=b'rev2a')
 
494
        self.build_tree_contents([('other/file', b'2b\n1\n')])
 
495
        other_tree.commit('rev2', rev_id=b'rev2b')
496
496
        this_tree.lock_write()
497
497
        self.addCleanup(this_tree.unlock)
498
 
        merger = _mod_merge.Merger.from_revision_ids(None,
499
 
            this_tree, 'rev2b', other_branch=other_tree.branch)
 
498
        merger = _mod_merge.Merger.from_revision_ids(
 
499
            this_tree, b'rev2b', other_branch=other_tree.branch)
500
500
        merger.merge_type = _mod_merge.Merge3Merger
501
501
        tree_merger = merger.make_merger()
502
502
        tt = tree_merger.do_merge()
503
 
        tree_file = this_tree.get_file('file-id')
504
 
        try:
505
 
            self.assertEqual('2b\n1\n2a\n', tree_file.read())
506
 
        finally:
507
 
            tree_file.close()
 
503
        with this_tree.get_file('file') as tree_file:
 
504
            self.assertEqual(b'2b\n1\n2a\n', tree_file.read())
508
505
 
509
506
    def test_merge_require_tree_root(self):
510
507
        tree = self.make_branch_and_tree(".")
513
510
        self.build_tree(['a'])
514
511
        tree.add('a')
515
512
        first_rev = tree.commit("added a")
516
 
        old_root_id = tree.get_root_id()
517
 
        merger = _mod_merge.Merger.from_revision_ids(None, tree,
518
 
                                          _mod_revision.NULL_REVISION,
519
 
                                          first_rev)
 
513
        old_root_id = tree.path2id('')
 
514
        merger = _mod_merge.Merger.from_revision_ids(tree,
 
515
                                                     _mod_revision.NULL_REVISION,
 
516
                                                     first_rev)
520
517
        merger.merge_type = _mod_merge.Merge3Merger
521
518
        conflict_count = merger.do_merge()
522
519
        self.assertEqual(0, conflict_count)
523
 
        self.assertEquals(set([old_root_id]), tree.all_file_ids())
 
520
        self.assertEqual({''}, set(tree.all_versioned_paths()))
524
521
        tree.set_parent_ids([])
525
522
 
526
523
    def test_merge_add_into_deleted_root(self):
527
524
        # Yes, people actually do this.  And report bugs if it breaks.
528
525
        source = self.make_branch_and_tree('source', format='rich-root-pack')
529
526
        self.build_tree(['source/foo/'])
530
 
        source.add('foo', 'foo-id')
 
527
        source.add('foo', b'foo-id')
531
528
        source.commit('Add foo')
532
 
        target = source.bzrdir.sprout('target').open_workingtree()
533
 
        subtree = target.extract('foo-id')
 
529
        target = source.controldir.sprout('target').open_workingtree()
 
530
        subtree = target.extract('foo')
534
531
        subtree.commit('Delete root')
535
532
        self.build_tree(['source/bar'])
536
 
        source.add('bar', 'bar-id')
 
533
        source.add('bar', b'bar-id')
537
534
        source.commit('Add bar')
538
535
        subtree.merge_from_branch(source.branch)
539
536
 
546
543
        self.build_tree(['target/bla'])
547
544
        target.add('bla')
548
545
        target.commit('Add bla')
549
 
        nested = source.bzrdir.sprout('target/subtree').open_workingtree()
 
546
        nested = source.controldir.sprout('target/subtree').open_workingtree()
550
547
        target.subsume(nested)
551
548
        target.commit('Join nested')
552
549
        self.build_tree(['source/bar'])
563
560
        mapper = versionedfile.PrefixMapper()
564
561
        factory = knit.make_file_factory(True, mapper)
565
562
        self.vf = factory(self.get_transport())
566
 
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile('root')
 
563
        self.plan_merge_vf = versionedfile._PlanMergeVersionedFile(b'root')
567
564
        self.plan_merge_vf.fallback_versionedfiles.append(self.vf)
568
565
 
569
566
    def add_version(self, key, parents, text):
570
 
        self.vf.add_lines(key, parents, [c+'\n' for c in text])
 
567
        self.vf.add_lines(
 
568
            key, parents, [bytes([c]) + b'\n' for c in bytearray(text)])
571
569
 
572
570
    def add_rev(self, prefix, revision_id, parents, text):
573
571
        self.add_version((prefix, revision_id), [(prefix, p) for p in parents],
575
573
 
576
574
    def add_uncommitted_version(self, key, parents, text):
577
575
        self.plan_merge_vf.add_lines(key, parents,
578
 
                                     [c+'\n' for c in text])
 
576
                                     [bytes([c]) + b'\n' for c in bytearray(text)])
579
577
 
580
578
    def setup_plan_merge(self):
581
 
        self.add_rev('root', 'A', [], 'abc')
582
 
        self.add_rev('root', 'B', ['A'], 'acehg')
583
 
        self.add_rev('root', 'C', ['A'], 'fabg')
584
 
        return _PlanMerge('B', 'C', self.plan_merge_vf, ('root',))
 
579
        self.add_rev(b'root', b'A', [], b'abc')
 
580
        self.add_rev(b'root', b'B', [b'A'], b'acehg')
 
581
        self.add_rev(b'root', b'C', [b'A'], b'fabg')
 
582
        return _PlanMerge(b'B', b'C', self.plan_merge_vf, (b'root',))
585
583
 
586
584
    def setup_plan_merge_uncommitted(self):
587
 
        self.add_version(('root', 'A'), [], 'abc')
588
 
        self.add_uncommitted_version(('root', 'B:'), [('root', 'A')], 'acehg')
589
 
        self.add_uncommitted_version(('root', 'C:'), [('root', 'A')], 'fabg')
590
 
        return _PlanMerge('B:', 'C:', self.plan_merge_vf, ('root',))
 
585
        self.add_version((b'root', b'A'), [], b'abc')
 
586
        self.add_uncommitted_version(
 
587
            (b'root', b'B:'), [(b'root', b'A')], b'acehg')
 
588
        self.add_uncommitted_version(
 
589
            (b'root', b'C:'), [(b'root', b'A')], b'fabg')
 
590
        return _PlanMerge(b'B:', b'C:', self.plan_merge_vf, (b'root',))
591
591
 
592
592
    def test_base_from_plan(self):
593
593
        self.setup_plan_merge()
594
 
        plan = self.plan_merge_vf.plan_merge('B', 'C')
 
594
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
595
595
        pwm = versionedfile.PlanWeaveMerge(plan)
596
 
        self.assertEqual(['a\n', 'b\n', 'c\n'], pwm.base_from_plan())
 
596
        self.assertEqual([b'a\n', b'b\n', b'c\n'], pwm.base_from_plan())
597
597
 
598
598
    def test_unique_lines(self):
599
599
        plan = self.setup_plan_merge()
600
600
        self.assertEqual(plan._unique_lines(
601
 
            plan._get_matching_blocks('B', 'C')),
 
601
            plan._get_matching_blocks(b'B', b'C')),
602
602
            ([1, 2, 3], [0, 2]))
603
603
 
604
604
    def test_plan_merge(self):
605
605
        self.setup_plan_merge()
606
 
        plan = self.plan_merge_vf.plan_merge('B', 'C')
 
606
        plan = self.plan_merge_vf.plan_merge(b'B', b'C')
607
607
        self.assertEqual([
608
 
                          ('new-b', 'f\n'),
609
 
                          ('unchanged', 'a\n'),
610
 
                          ('killed-a', 'b\n'),
611
 
                          ('killed-b', 'c\n'),
612
 
                          ('new-a', 'e\n'),
613
 
                          ('new-a', 'h\n'),
614
 
                          ('new-a', 'g\n'),
615
 
                          ('new-b', 'g\n')],
616
 
                         list(plan))
 
608
            ('new-b', b'f\n'),
 
609
            ('unchanged', b'a\n'),
 
610
            ('killed-a', b'b\n'),
 
611
            ('killed-b', b'c\n'),
 
612
            ('new-a', b'e\n'),
 
613
            ('new-a', b'h\n'),
 
614
            ('new-a', b'g\n'),
 
615
            ('new-b', b'g\n')],
 
616
            list(plan))
617
617
 
618
618
    def test_plan_merge_cherrypick(self):
619
 
        self.add_rev('root', 'A', [], 'abc')
620
 
        self.add_rev('root', 'B', ['A'], 'abcde')
621
 
        self.add_rev('root', 'C', ['A'], 'abcefg')
622
 
        self.add_rev('root', 'D', ['A', 'B', 'C'], 'abcdegh')
623
 
        my_plan = _PlanMerge('B', 'D', self.plan_merge_vf, ('root',))
 
619
        self.add_rev(b'root', b'A', [], b'abc')
 
620
        self.add_rev(b'root', b'B', [b'A'], b'abcde')
 
621
        self.add_rev(b'root', b'C', [b'A'], b'abcefg')
 
622
        self.add_rev(b'root', b'D', [b'A', b'B', b'C'], b'abcdegh')
 
623
        my_plan = _PlanMerge(b'B', b'D', self.plan_merge_vf, (b'root',))
624
624
        # We shortcut when one text supersedes the other in the per-file graph.
625
625
        # We don't actually need to compare the texts at this point.
626
626
        self.assertEqual([
627
 
                          ('new-b', 'a\n'),
628
 
                          ('new-b', 'b\n'),
629
 
                          ('new-b', 'c\n'),
630
 
                          ('new-b', 'd\n'),
631
 
                          ('new-b', 'e\n'),
632
 
                          ('new-b', 'g\n'),
633
 
                          ('new-b', 'h\n')],
634
 
                          list(my_plan.plan_merge()))
 
627
            ('new-b', b'a\n'),
 
628
            ('new-b', b'b\n'),
 
629
            ('new-b', b'c\n'),
 
630
            ('new-b', b'd\n'),
 
631
            ('new-b', b'e\n'),
 
632
            ('new-b', b'g\n'),
 
633
            ('new-b', b'h\n')],
 
634
            list(my_plan.plan_merge()))
635
635
 
636
636
    def test_plan_merge_no_common_ancestor(self):
637
 
        self.add_rev('root', 'A', [], 'abc')
638
 
        self.add_rev('root', 'B', [], 'xyz')
639
 
        my_plan = _PlanMerge('A', 'B', self.plan_merge_vf, ('root',))
 
637
        self.add_rev(b'root', b'A', [], b'abc')
 
638
        self.add_rev(b'root', b'B', [], b'xyz')
 
639
        my_plan = _PlanMerge(b'A', b'B', self.plan_merge_vf, (b'root',))
640
640
        self.assertEqual([
641
 
                          ('new-a', 'a\n'),
642
 
                          ('new-a', 'b\n'),
643
 
                          ('new-a', 'c\n'),
644
 
                          ('new-b', 'x\n'),
645
 
                          ('new-b', 'y\n'),
646
 
                          ('new-b', 'z\n')],
647
 
                          list(my_plan.plan_merge()))
 
641
            ('new-a', b'a\n'),
 
642
            ('new-a', b'b\n'),
 
643
            ('new-a', b'c\n'),
 
644
            ('new-b', b'x\n'),
 
645
            ('new-b', b'y\n'),
 
646
            ('new-b', b'z\n')],
 
647
            list(my_plan.plan_merge()))
648
648
 
649
649
    def test_plan_merge_tail_ancestors(self):
650
650
        # The graph looks like this:
666
666
        # are already present in E
667
667
 
668
668
        # Introduce the base text
669
 
        self.add_rev('root', 'A', [], 'abc')
 
669
        self.add_rev(b'root', b'A', [], b'abc')
670
670
        # Introduces a new line B
671
 
        self.add_rev('root', 'B', ['A'], 'aBbc')
 
671
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
672
672
        # Introduces a new line C
673
 
        self.add_rev('root', 'C', ['A'], 'abCc')
 
673
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
674
674
        # Introduce new line D
675
 
        self.add_rev('root', 'D', ['B'], 'DaBbc')
 
675
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
676
676
        # Merges B and C by just incorporating both
677
 
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
 
677
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
678
678
        # Introduce new line F
679
 
        self.add_rev('root', 'F', ['C'], 'abCcF')
 
679
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
680
680
        # Merge D & E by just combining the texts
681
 
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
 
681
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
682
682
        # Merge F & E by just combining the texts
683
 
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
 
683
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
684
684
        # Merge G & H by just combining texts
685
 
        self.add_rev('root', 'I', ['G', 'H'], 'DaBbCcF')
 
685
        self.add_rev(b'root', b'I', [b'G', b'H'], b'DaBbCcF')
686
686
        # Merge G & H but supersede an old line in B
687
 
        self.add_rev('root', 'J', ['H', 'G'], 'DaJbCcF')
688
 
        plan = self.plan_merge_vf.plan_merge('I', 'J')
 
687
        self.add_rev(b'root', b'J', [b'H', b'G'], b'DaJbCcF')
 
688
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
689
689
        self.assertEqual([
690
 
                          ('unchanged', 'D\n'),
691
 
                          ('unchanged', 'a\n'),
692
 
                          ('killed-b', 'B\n'),
693
 
                          ('new-b', 'J\n'),
694
 
                          ('unchanged', 'b\n'),
695
 
                          ('unchanged', 'C\n'),
696
 
                          ('unchanged', 'c\n'),
697
 
                          ('unchanged', 'F\n')],
698
 
                         list(plan))
 
690
            ('unchanged', b'D\n'),
 
691
            ('unchanged', b'a\n'),
 
692
            ('killed-b', b'B\n'),
 
693
            ('new-b', b'J\n'),
 
694
            ('unchanged', b'b\n'),
 
695
            ('unchanged', b'C\n'),
 
696
            ('unchanged', b'c\n'),
 
697
            ('unchanged', b'F\n')],
 
698
            list(plan))
699
699
 
700
700
    def test_plan_merge_tail_triple_ancestors(self):
701
701
        # The graph looks like this:
715
715
        # a third LCA that doesn't add new lines, but will trigger our more
716
716
        # involved ancestry logic
717
717
 
718
 
        self.add_rev('root', 'A', [], 'abc')
719
 
        self.add_rev('root', 'B', ['A'], 'aBbc')
720
 
        self.add_rev('root', 'C', ['A'], 'abCc')
721
 
        self.add_rev('root', 'D', ['B'], 'DaBbc')
722
 
        self.add_rev('root', 'E', ['B', 'C'], 'aBbCc')
723
 
        self.add_rev('root', 'F', ['C'], 'abCcF')
724
 
        self.add_rev('root', 'G', ['D', 'E'], 'DaBbCc')
725
 
        self.add_rev('root', 'H', ['F', 'E'], 'aBbCcF')
726
 
        self.add_rev('root', 'Q', ['E'], 'aBbCc')
727
 
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DaBbCcF')
 
718
        self.add_rev(b'root', b'A', [], b'abc')
 
719
        self.add_rev(b'root', b'B', [b'A'], b'aBbc')
 
720
        self.add_rev(b'root', b'C', [b'A'], b'abCc')
 
721
        self.add_rev(b'root', b'D', [b'B'], b'DaBbc')
 
722
        self.add_rev(b'root', b'E', [b'B', b'C'], b'aBbCc')
 
723
        self.add_rev(b'root', b'F', [b'C'], b'abCcF')
 
724
        self.add_rev(b'root', b'G', [b'D', b'E'], b'DaBbCc')
 
725
        self.add_rev(b'root', b'H', [b'F', b'E'], b'aBbCcF')
 
726
        self.add_rev(b'root', b'Q', [b'E'], b'aBbCc')
 
727
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DaBbCcF')
728
728
        # Merge G & H but supersede an old line in B
729
 
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DaJbCcF')
730
 
        plan = self.plan_merge_vf.plan_merge('I', 'J')
 
729
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DaJbCcF')
 
730
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
731
731
        self.assertEqual([
732
 
                          ('unchanged', 'D\n'),
733
 
                          ('unchanged', 'a\n'),
734
 
                          ('killed-b', 'B\n'),
735
 
                          ('new-b', 'J\n'),
736
 
                          ('unchanged', 'b\n'),
737
 
                          ('unchanged', 'C\n'),
738
 
                          ('unchanged', 'c\n'),
739
 
                          ('unchanged', 'F\n')],
740
 
                         list(plan))
 
732
            ('unchanged', b'D\n'),
 
733
            ('unchanged', b'a\n'),
 
734
            ('killed-b', b'B\n'),
 
735
            ('new-b', b'J\n'),
 
736
            ('unchanged', b'b\n'),
 
737
            ('unchanged', b'C\n'),
 
738
            ('unchanged', b'c\n'),
 
739
            ('unchanged', b'F\n')],
 
740
            list(plan))
741
741
 
742
742
    def test_plan_merge_2_tail_triple_ancestors(self):
743
743
        # The graph looks like this:
755
755
        # This is meant to test after hitting a 3-way LCA, and multiple tail
756
756
        # ancestors (only have NULL_REVISION in common)
757
757
 
758
 
        self.add_rev('root', 'A', [], 'abc')
759
 
        self.add_rev('root', 'B', [], 'def')
760
 
        self.add_rev('root', 'D', ['A'], 'Dabc')
761
 
        self.add_rev('root', 'E', ['A', 'B'], 'abcdef')
762
 
        self.add_rev('root', 'F', ['B'], 'defF')
763
 
        self.add_rev('root', 'G', ['D', 'E'], 'Dabcdef')
764
 
        self.add_rev('root', 'H', ['F', 'E'], 'abcdefF')
765
 
        self.add_rev('root', 'Q', ['E'], 'abcdef')
766
 
        self.add_rev('root', 'I', ['G', 'Q', 'H'], 'DabcdefF')
 
758
        self.add_rev(b'root', b'A', [], b'abc')
 
759
        self.add_rev(b'root', b'B', [], b'def')
 
760
        self.add_rev(b'root', b'D', [b'A'], b'Dabc')
 
761
        self.add_rev(b'root', b'E', [b'A', b'B'], b'abcdef')
 
762
        self.add_rev(b'root', b'F', [b'B'], b'defF')
 
763
        self.add_rev(b'root', b'G', [b'D', b'E'], b'Dabcdef')
 
764
        self.add_rev(b'root', b'H', [b'F', b'E'], b'abcdefF')
 
765
        self.add_rev(b'root', b'Q', [b'E'], b'abcdef')
 
766
        self.add_rev(b'root', b'I', [b'G', b'Q', b'H'], b'DabcdefF')
767
767
        # Merge G & H but supersede an old line in B
768
 
        self.add_rev('root', 'J', ['H', 'Q', 'G'], 'DabcdJfF')
769
 
        plan = self.plan_merge_vf.plan_merge('I', 'J')
 
768
        self.add_rev(b'root', b'J', [b'H', b'Q', b'G'], b'DabcdJfF')
 
769
        plan = self.plan_merge_vf.plan_merge(b'I', b'J')
770
770
        self.assertEqual([
771
 
                          ('unchanged', 'D\n'),
772
 
                          ('unchanged', 'a\n'),
773
 
                          ('unchanged', 'b\n'),
774
 
                          ('unchanged', 'c\n'),
775
 
                          ('unchanged', 'd\n'),
776
 
                          ('killed-b', 'e\n'),
777
 
                          ('new-b', 'J\n'),
778
 
                          ('unchanged', 'f\n'),
779
 
                          ('unchanged', 'F\n')],
780
 
                         list(plan))
 
771
            ('unchanged', b'D\n'),
 
772
            ('unchanged', b'a\n'),
 
773
            ('unchanged', b'b\n'),
 
774
            ('unchanged', b'c\n'),
 
775
            ('unchanged', b'd\n'),
 
776
            ('killed-b', b'e\n'),
 
777
            ('new-b', b'J\n'),
 
778
            ('unchanged', b'f\n'),
 
779
            ('unchanged', b'F\n')],
 
780
            list(plan))
781
781
 
782
782
    def test_plan_merge_uncommitted_files(self):
783
783
        self.setup_plan_merge_uncommitted()
784
 
        plan = self.plan_merge_vf.plan_merge('B:', 'C:')
 
784
        plan = self.plan_merge_vf.plan_merge(b'B:', b'C:')
785
785
        self.assertEqual([
786
 
                          ('new-b', 'f\n'),
787
 
                          ('unchanged', 'a\n'),
788
 
                          ('killed-a', 'b\n'),
789
 
                          ('killed-b', 'c\n'),
790
 
                          ('new-a', 'e\n'),
791
 
                          ('new-a', 'h\n'),
792
 
                          ('new-a', 'g\n'),
793
 
                          ('new-b', 'g\n')],
794
 
                         list(plan))
 
786
            ('new-b', b'f\n'),
 
787
            ('unchanged', b'a\n'),
 
788
            ('killed-a', b'b\n'),
 
789
            ('killed-b', b'c\n'),
 
790
            ('new-a', b'e\n'),
 
791
            ('new-a', b'h\n'),
 
792
            ('new-a', b'g\n'),
 
793
            ('new-b', b'g\n')],
 
794
            list(plan))
795
795
 
796
796
    def test_plan_merge_insert_order(self):
797
797
        """Weave merges are sensitive to the order of insertion.
801
801
        same ordering, then the lines match the parents, if they don't only
802
802
        *some* of the lines match.
803
803
        """
804
 
        self.add_rev('root', 'A', [], 'abcdef')
805
 
        self.add_rev('root', 'B', ['A'], 'abwxcdef')
806
 
        self.add_rev('root', 'C', ['A'], 'abyzcdef')
 
804
        self.add_rev(b'root', b'A', [], b'abcdef')
 
805
        self.add_rev(b'root', b'B', [b'A'], b'abwxcdef')
 
806
        self.add_rev(b'root', b'C', [b'A'], b'abyzcdef')
807
807
        # Merge, and resolve the conflict by adding *both* sets of lines
808
808
        # If we get the ordering wrong, these will look like new lines in D,
809
809
        # rather than carried over from B, C
810
 
        self.add_rev('root', 'D', ['B', 'C'],
811
 
                         'abwxyzcdef')
 
810
        self.add_rev(b'root', b'D', [b'B', b'C'],
 
811
                     b'abwxyzcdef')
812
812
        # Supersede the lines in B and delete the lines in C, which will
813
813
        # conflict if they are treated as being in D
814
 
        self.add_rev('root', 'E', ['C', 'B'],
815
 
                         'abnocdef')
 
814
        self.add_rev(b'root', b'E', [b'C', b'B'],
 
815
                     b'abnocdef')
816
816
        # Same thing for the lines in C
817
 
        self.add_rev('root', 'F', ['C'], 'abpqcdef')
818
 
        plan = self.plan_merge_vf.plan_merge('D', 'E')
 
817
        self.add_rev(b'root', b'F', [b'C'], b'abpqcdef')
 
818
        plan = self.plan_merge_vf.plan_merge(b'D', b'E')
819
819
        self.assertEqual([
820
 
                          ('unchanged', 'a\n'),
821
 
                          ('unchanged', 'b\n'),
822
 
                          ('killed-b', 'w\n'),
823
 
                          ('killed-b', 'x\n'),
824
 
                          ('killed-b', 'y\n'),
825
 
                          ('killed-b', 'z\n'),
826
 
                          ('new-b', 'n\n'),
827
 
                          ('new-b', 'o\n'),
828
 
                          ('unchanged', 'c\n'),
829
 
                          ('unchanged', 'd\n'),
830
 
                          ('unchanged', 'e\n'),
831
 
                          ('unchanged', 'f\n')],
832
 
                         list(plan))
833
 
        plan = self.plan_merge_vf.plan_merge('E', 'D')
 
820
            ('unchanged', b'a\n'),
 
821
            ('unchanged', b'b\n'),
 
822
            ('killed-b', b'w\n'),
 
823
            ('killed-b', b'x\n'),
 
824
            ('killed-b', b'y\n'),
 
825
            ('killed-b', b'z\n'),
 
826
            ('new-b', b'n\n'),
 
827
            ('new-b', b'o\n'),
 
828
            ('unchanged', b'c\n'),
 
829
            ('unchanged', b'd\n'),
 
830
            ('unchanged', b'e\n'),
 
831
            ('unchanged', b'f\n')],
 
832
            list(plan))
 
833
        plan = self.plan_merge_vf.plan_merge(b'E', b'D')
834
834
        # Going in the opposite direction shows the effect of the opposite plan
835
835
        self.assertEqual([
836
 
                          ('unchanged', 'a\n'),
837
 
                          ('unchanged', 'b\n'),
838
 
                          ('new-b', 'w\n'),
839
 
                          ('new-b', 'x\n'),
840
 
                          ('killed-a', 'y\n'),
841
 
                          ('killed-a', 'z\n'),
842
 
                          ('killed-both', 'w\n'),
843
 
                          ('killed-both', 'x\n'),
844
 
                          ('new-a', 'n\n'),
845
 
                          ('new-a', 'o\n'),
846
 
                          ('unchanged', 'c\n'),
847
 
                          ('unchanged', 'd\n'),
848
 
                          ('unchanged', 'e\n'),
849
 
                          ('unchanged', 'f\n')],
850
 
                         list(plan))
 
836
            ('unchanged', b'a\n'),
 
837
            ('unchanged', b'b\n'),
 
838
            ('new-b', b'w\n'),
 
839
            ('new-b', b'x\n'),
 
840
            ('killed-a', b'y\n'),
 
841
            ('killed-a', b'z\n'),
 
842
            ('killed-both', b'w\n'),
 
843
            ('killed-both', b'x\n'),
 
844
            ('new-a', b'n\n'),
 
845
            ('new-a', b'o\n'),
 
846
            ('unchanged', b'c\n'),
 
847
            ('unchanged', b'd\n'),
 
848
            ('unchanged', b'e\n'),
 
849
            ('unchanged', b'f\n')],
 
850
            list(plan))
851
851
 
852
852
    def test_plan_merge_criss_cross(self):
853
853
        # This is specificly trying to trigger problems when using limited
874
874
        #   'foo', it should appear as superseding the value in F (since it
875
875
        #   came from B), rather than conflict because of the resolution during
876
876
        #   C & D.
877
 
        self.add_rev('root', 'XX', [], 'qrs')
878
 
        self.add_rev('root', 'A', ['XX'], 'abcdef')
879
 
        self.add_rev('root', 'B', ['A'], 'axcdef')
880
 
        self.add_rev('root', 'C', ['B'], 'axcdefg')
881
 
        self.add_rev('root', 'D', ['B'], 'haxcdef')
882
 
        self.add_rev('root', 'E', ['A'], 'abcdyf')
 
877
        self.add_rev(b'root', b'XX', [], b'qrs')
 
878
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
 
879
        self.add_rev(b'root', b'B', [b'A'], b'axcdef')
 
880
        self.add_rev(b'root', b'C', [b'B'], b'axcdefg')
 
881
        self.add_rev(b'root', b'D', [b'B'], b'haxcdef')
 
882
        self.add_rev(b'root', b'E', [b'A'], b'abcdyf')
883
883
        # Simple combining of all texts
884
 
        self.add_rev('root', 'F', ['C', 'D', 'E'], 'haxcdyfg')
 
884
        self.add_rev(b'root', b'F', [b'C', b'D', b'E'], b'haxcdyfg')
885
885
        # combine and supersede 'x'
886
 
        self.add_rev('root', 'G', ['C', 'D', 'E'], 'hazcdyfg')
887
 
        plan = self.plan_merge_vf.plan_merge('F', 'G')
 
886
        self.add_rev(b'root', b'G', [b'C', b'D', b'E'], b'hazcdyfg')
 
887
        plan = self.plan_merge_vf.plan_merge(b'F', b'G')
888
888
        self.assertEqual([
889
 
                          ('unchanged', 'h\n'),
890
 
                          ('unchanged', 'a\n'),
891
 
                          ('killed-base', 'b\n'),
892
 
                          ('killed-b', 'x\n'),
893
 
                          ('new-b', 'z\n'),
894
 
                          ('unchanged', 'c\n'),
895
 
                          ('unchanged', 'd\n'),
896
 
                          ('killed-base', 'e\n'),
897
 
                          ('unchanged', 'y\n'),
898
 
                          ('unchanged', 'f\n'),
899
 
                          ('unchanged', 'g\n')],
900
 
                         list(plan))
901
 
        plan = self.plan_merge_vf.plan_lca_merge('F', 'G')
 
889
            ('unchanged', b'h\n'),
 
890
            ('unchanged', b'a\n'),
 
891
            ('killed-base', b'b\n'),
 
892
            ('killed-b', b'x\n'),
 
893
            ('new-b', b'z\n'),
 
894
            ('unchanged', b'c\n'),
 
895
            ('unchanged', b'd\n'),
 
896
            ('killed-base', b'e\n'),
 
897
            ('unchanged', b'y\n'),
 
898
            ('unchanged', b'f\n'),
 
899
            ('unchanged', b'g\n')],
 
900
            list(plan))
 
901
        plan = self.plan_merge_vf.plan_lca_merge(b'F', b'G')
902
902
        # This is one of the main differences between plan_merge and
903
903
        # plan_lca_merge. plan_lca_merge generates a conflict for 'x => z',
904
904
        # because 'x' was not present in one of the bases. However, in this
905
905
        # case it is spurious because 'x' does not exist in the global base A.
906
906
        self.assertEqual([
907
 
                          ('unchanged', 'h\n'),
908
 
                          ('unchanged', 'a\n'),
909
 
                          ('conflicted-a', 'x\n'),
910
 
                          ('new-b', 'z\n'),
911
 
                          ('unchanged', 'c\n'),
912
 
                          ('unchanged', 'd\n'),
913
 
                          ('unchanged', 'y\n'),
914
 
                          ('unchanged', 'f\n'),
915
 
                          ('unchanged', 'g\n')],
916
 
                         list(plan))
 
907
            ('unchanged', b'h\n'),
 
908
            ('unchanged', b'a\n'),
 
909
            ('conflicted-a', b'x\n'),
 
910
            ('new-b', b'z\n'),
 
911
            ('unchanged', b'c\n'),
 
912
            ('unchanged', b'd\n'),
 
913
            ('unchanged', b'y\n'),
 
914
            ('unchanged', b'f\n'),
 
915
            ('unchanged', b'g\n')],
 
916
            list(plan))
917
917
 
918
918
    def test_criss_cross_flip_flop(self):
919
919
        # This is specificly trying to trigger problems when using limited
921
921
        #       XX      unused ancestor, should not show up in the weave
922
922
        #       |
923
923
        #       A       Unique LCA
924
 
        #      / \  
 
924
        #      / \
925
925
        #     B   C     B & C both introduce a new line
926
 
        #     |\ /|  
927
 
        #     | X |  
928
 
        #     |/ \| 
 
926
        #     |\ /|
 
927
        #     | X |
 
928
        #     |/ \|
929
929
        #     D   E     B & C are both merged, so both are common ancestors
930
930
        #               In the process of merging, both sides order the new
931
931
        #               lines differently
932
932
        #
933
 
        self.add_rev('root', 'XX', [], 'qrs')
934
 
        self.add_rev('root', 'A', ['XX'], 'abcdef')
935
 
        self.add_rev('root', 'B', ['A'], 'abcdgef')
936
 
        self.add_rev('root', 'C', ['A'], 'abcdhef')
937
 
        self.add_rev('root', 'D', ['B', 'C'], 'abcdghef')
938
 
        self.add_rev('root', 'E', ['C', 'B'], 'abcdhgef')
939
 
        plan = list(self.plan_merge_vf.plan_merge('D', 'E'))
 
933
        self.add_rev(b'root', b'XX', [], b'qrs')
 
934
        self.add_rev(b'root', b'A', [b'XX'], b'abcdef')
 
935
        self.add_rev(b'root', b'B', [b'A'], b'abcdgef')
 
936
        self.add_rev(b'root', b'C', [b'A'], b'abcdhef')
 
937
        self.add_rev(b'root', b'D', [b'B', b'C'], b'abcdghef')
 
938
        self.add_rev(b'root', b'E', [b'C', b'B'], b'abcdhgef')
 
939
        plan = list(self.plan_merge_vf.plan_merge(b'D', b'E'))
940
940
        self.assertEqual([
941
 
                          ('unchanged', 'a\n'),
942
 
                          ('unchanged', 'b\n'),
943
 
                          ('unchanged', 'c\n'),
944
 
                          ('unchanged', 'd\n'),
945
 
                          ('new-b', 'h\n'),
946
 
                          ('unchanged', 'g\n'),
947
 
                          ('killed-b', 'h\n'),
948
 
                          ('unchanged', 'e\n'),
949
 
                          ('unchanged', 'f\n'),
950
 
                         ], plan)
 
941
            ('unchanged', b'a\n'),
 
942
            ('unchanged', b'b\n'),
 
943
            ('unchanged', b'c\n'),
 
944
            ('unchanged', b'd\n'),
 
945
            ('new-b', b'h\n'),
 
946
            ('unchanged', b'g\n'),
 
947
            ('killed-b', b'h\n'),
 
948
            ('unchanged', b'e\n'),
 
949
            ('unchanged', b'f\n'),
 
950
            ], plan)
951
951
        pwm = versionedfile.PlanWeaveMerge(plan)
952
 
        self.assertEqualDiff('\n'.join('abcdghef') + '\n',
953
 
                             ''.join(pwm.base_from_plan()))
 
952
        self.assertEqualDiff(b'a\nb\nc\nd\ng\nh\ne\nf\n',
 
953
                             b''.join(pwm.base_from_plan()))
954
954
        # Reversing the order reverses the merge plan, and final order of 'hg'
955
955
        # => 'gh'
956
 
        plan = list(self.plan_merge_vf.plan_merge('E', 'D'))
 
956
        plan = list(self.plan_merge_vf.plan_merge(b'E', b'D'))
957
957
        self.assertEqual([
958
 
                          ('unchanged', 'a\n'),
959
 
                          ('unchanged', 'b\n'),
960
 
                          ('unchanged', 'c\n'),
961
 
                          ('unchanged', 'd\n'),
962
 
                          ('new-b', 'g\n'),
963
 
                          ('unchanged', 'h\n'),
964
 
                          ('killed-b', 'g\n'),
965
 
                          ('unchanged', 'e\n'),
966
 
                          ('unchanged', 'f\n'),
967
 
                         ], plan)
 
958
            ('unchanged', b'a\n'),
 
959
            ('unchanged', b'b\n'),
 
960
            ('unchanged', b'c\n'),
 
961
            ('unchanged', b'd\n'),
 
962
            ('new-b', b'g\n'),
 
963
            ('unchanged', b'h\n'),
 
964
            ('killed-b', b'g\n'),
 
965
            ('unchanged', b'e\n'),
 
966
            ('unchanged', b'f\n'),
 
967
            ], plan)
968
968
        pwm = versionedfile.PlanWeaveMerge(plan)
969
 
        self.assertEqualDiff('\n'.join('abcdhgef') + '\n',
970
 
                             ''.join(pwm.base_from_plan()))
 
969
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ng\ne\nf\n',
 
970
                             b''.join(pwm.base_from_plan()))
971
971
        # This is where lca differs, in that it (fairly correctly) determines
972
972
        # that there is a conflict because both sides resolved the merge
973
973
        # differently
974
 
        plan = list(self.plan_merge_vf.plan_lca_merge('D', 'E'))
 
974
        plan = list(self.plan_merge_vf.plan_lca_merge(b'D', b'E'))
975
975
        self.assertEqual([
976
 
                          ('unchanged', 'a\n'),
977
 
                          ('unchanged', 'b\n'),
978
 
                          ('unchanged', 'c\n'),
979
 
                          ('unchanged', 'd\n'),
980
 
                          ('conflicted-b', 'h\n'),
981
 
                          ('unchanged', 'g\n'),
982
 
                          ('conflicted-a', 'h\n'),
983
 
                          ('unchanged', 'e\n'),
984
 
                          ('unchanged', 'f\n'),
985
 
                         ], plan)
 
976
            ('unchanged', b'a\n'),
 
977
            ('unchanged', b'b\n'),
 
978
            ('unchanged', b'c\n'),
 
979
            ('unchanged', b'd\n'),
 
980
            ('conflicted-b', b'h\n'),
 
981
            ('unchanged', b'g\n'),
 
982
            ('conflicted-a', b'h\n'),
 
983
            ('unchanged', b'e\n'),
 
984
            ('unchanged', b'f\n'),
 
985
            ], plan)
986
986
        pwm = versionedfile.PlanWeaveMerge(plan)
987
 
        self.assertEqualDiff('\n'.join('abcdgef') + '\n',
988
 
                             ''.join(pwm.base_from_plan()))
 
987
        self.assertEqualDiff(b'a\nb\nc\nd\ng\ne\nf\n',
 
988
                             b''.join(pwm.base_from_plan()))
989
989
        # Reversing it changes what line is doubled, but still gives a
990
990
        # double-conflict
991
 
        plan = list(self.plan_merge_vf.plan_lca_merge('E', 'D'))
 
991
        plan = list(self.plan_merge_vf.plan_lca_merge(b'E', b'D'))
992
992
        self.assertEqual([
993
 
                          ('unchanged', 'a\n'),
994
 
                          ('unchanged', 'b\n'),
995
 
                          ('unchanged', 'c\n'),
996
 
                          ('unchanged', 'd\n'),
997
 
                          ('conflicted-b', 'g\n'),
998
 
                          ('unchanged', 'h\n'),
999
 
                          ('conflicted-a', 'g\n'),
1000
 
                          ('unchanged', 'e\n'),
1001
 
                          ('unchanged', 'f\n'),
1002
 
                         ], plan)
 
993
            ('unchanged', b'a\n'),
 
994
            ('unchanged', b'b\n'),
 
995
            ('unchanged', b'c\n'),
 
996
            ('unchanged', b'd\n'),
 
997
            ('conflicted-b', b'g\n'),
 
998
            ('unchanged', b'h\n'),
 
999
            ('conflicted-a', b'g\n'),
 
1000
            ('unchanged', b'e\n'),
 
1001
            ('unchanged', b'f\n'),
 
1002
            ], plan)
1003
1003
        pwm = versionedfile.PlanWeaveMerge(plan)
1004
 
        self.assertEqualDiff('\n'.join('abcdhef') + '\n',
1005
 
                             ''.join(pwm.base_from_plan()))
 
1004
        self.assertEqualDiff(b'a\nb\nc\nd\nh\ne\nf\n',
 
1005
                             b''.join(pwm.base_from_plan()))
1006
1006
 
1007
1007
    def assertRemoveExternalReferences(self, filtered_parent_map,
1008
1008
                                       child_map, tails, parent_map):
1023
1023
    def test__remove_external_references(self):
1024
1024
        # First, nothing to remove
1025
1025
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1026
 
            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
 
1026
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2], 2: [1], 1: []})
1027
1027
        # The reverse direction
1028
1028
        self.assertRemoveExternalReferences({1: [2], 2: [3], 3: []},
1029
 
            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
 
1029
                                            {3: [2], 2: [1], 1: []}, [3], {1: [2], 2: [3], 3: []})
1030
1030
        # Extra references
1031
1031
        self.assertRemoveExternalReferences({3: [2], 2: [1], 1: []},
1032
 
            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
 
1032
                                            {1: [2], 2: [3], 3: []}, [1], {3: [2, 4], 2: [1, 5], 1: [6]})
1033
1033
        # Multiple tails
1034
1034
        self.assertRemoveExternalReferences(
1035
1035
            {4: [2, 3], 3: [], 2: [1], 1: []},
1045
1045
 
1046
1046
    def assertPruneTails(self, pruned_map, tails, parent_map):
1047
1047
        child_map = {}
1048
 
        for key, parent_keys in parent_map.iteritems():
 
1048
        for key, parent_keys in parent_map.items():
1049
1049
            child_map.setdefault(key, [])
1050
1050
            for pkey in parent_keys:
1051
1051
                child_map.setdefault(pkey, []).append(key)
1066
1066
        self.assertPruneTails({1: []}, [5],
1067
1067
                              {1: [], 2: [3, 4], 3: [5], 4: [5], 5: []})
1068
1068
        # Prune a partial chain
1069
 
        self.assertPruneTails({1: [6], 6:[]}, [5],
 
1069
        self.assertPruneTails({1: [6], 6: []}, [5],
1070
1070
                              {1: [2, 6], 2: [3, 4], 3: [5], 4: [5], 5: [],
1071
1071
                               6: []})
1072
1072
        # Prune a chain with multiple tips, that pulls out intermediates
1073
 
        self.assertPruneTails({1:[3], 3:[]}, [4, 5],
1074
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
1075
 
        self.assertPruneTails({1:[3], 3:[]}, [5, 4],
1076
 
                              {1: [2, 3], 2: [4, 5], 3: [], 4:[], 5:[]})
 
1073
        self.assertPruneTails({1: [3], 3: []}, [4, 5],
 
1074
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
 
1075
        self.assertPruneTails({1: [3], 3: []}, [5, 4],
 
1076
                              {1: [2, 3], 2: [4, 5], 3: [], 4: [], 5: []})
1077
1077
 
1078
1078
    def test_subtract_plans(self):
1079
1079
        old_plan = [
1080
 
        ('unchanged', 'a\n'),
1081
 
        ('new-a', 'b\n'),
1082
 
        ('killed-a', 'c\n'),
1083
 
        ('new-b', 'd\n'),
1084
 
        ('new-b', 'e\n'),
1085
 
        ('killed-b', 'f\n'),
1086
 
        ('killed-b', 'g\n'),
 
1080
            ('unchanged', b'a\n'),
 
1081
            ('new-a', b'b\n'),
 
1082
            ('killed-a', b'c\n'),
 
1083
            ('new-b', b'd\n'),
 
1084
            ('new-b', b'e\n'),
 
1085
            ('killed-b', b'f\n'),
 
1086
            ('killed-b', b'g\n'),
1087
1087
        ]
1088
1088
        new_plan = [
1089
 
        ('unchanged', 'a\n'),
1090
 
        ('new-a', 'b\n'),
1091
 
        ('killed-a', 'c\n'),
1092
 
        ('new-b', 'd\n'),
1093
 
        ('new-b', 'h\n'),
1094
 
        ('killed-b', 'f\n'),
1095
 
        ('killed-b', 'i\n'),
 
1089
            ('unchanged', b'a\n'),
 
1090
            ('new-a', b'b\n'),
 
1091
            ('killed-a', b'c\n'),
 
1092
            ('new-b', b'd\n'),
 
1093
            ('new-b', b'h\n'),
 
1094
            ('killed-b', b'f\n'),
 
1095
            ('killed-b', b'i\n'),
1096
1096
        ]
1097
1097
        subtracted_plan = [
1098
 
        ('unchanged', 'a\n'),
1099
 
        ('new-a', 'b\n'),
1100
 
        ('killed-a', 'c\n'),
1101
 
        ('new-b', 'h\n'),
1102
 
        ('unchanged', 'f\n'),
1103
 
        ('killed-b', 'i\n'),
 
1098
            ('unchanged', b'a\n'),
 
1099
            ('new-a', b'b\n'),
 
1100
            ('killed-a', b'c\n'),
 
1101
            ('new-b', b'h\n'),
 
1102
            ('unchanged', b'f\n'),
 
1103
            ('killed-b', b'i\n'),
1104
1104
        ]
1105
1105
        self.assertEqual(subtracted_plan,
1106
 
            list(_PlanMerge._subtract_plans(old_plan, new_plan)))
 
1106
                         list(_PlanMerge._subtract_plans(old_plan, new_plan)))
1107
1107
 
1108
1108
    def setup_merge_with_base(self):
1109
 
        self.add_rev('root', 'COMMON', [], 'abc')
1110
 
        self.add_rev('root', 'THIS', ['COMMON'], 'abcd')
1111
 
        self.add_rev('root', 'BASE', ['COMMON'], 'eabc')
1112
 
        self.add_rev('root', 'OTHER', ['BASE'], 'eafb')
 
1109
        self.add_rev(b'root', b'COMMON', [], b'abc')
 
1110
        self.add_rev(b'root', b'THIS', [b'COMMON'], b'abcd')
 
1111
        self.add_rev(b'root', b'BASE', [b'COMMON'], b'eabc')
 
1112
        self.add_rev(b'root', b'OTHER', [b'BASE'], b'eafb')
1113
1113
 
1114
1114
    def test_plan_merge_with_base(self):
1115
1115
        self.setup_merge_with_base()
1116
 
        plan = self.plan_merge_vf.plan_merge('THIS', 'OTHER', 'BASE')
1117
 
        self.assertEqual([('unchanged', 'a\n'),
1118
 
                          ('new-b', 'f\n'),
1119
 
                          ('unchanged', 'b\n'),
1120
 
                          ('killed-b', 'c\n'),
1121
 
                          ('new-a', 'd\n')
1122
 
                         ], list(plan))
 
1116
        plan = self.plan_merge_vf.plan_merge(b'THIS', b'OTHER', b'BASE')
 
1117
        self.assertEqual([('unchanged', b'a\n'),
 
1118
                          ('new-b', b'f\n'),
 
1119
                          ('unchanged', b'b\n'),
 
1120
                          ('killed-b', b'c\n'),
 
1121
                          ('new-a', b'd\n')
 
1122
                          ], list(plan))
1123
1123
 
1124
1124
    def test_plan_lca_merge(self):
1125
1125
        self.setup_plan_merge()
1126
 
        plan = self.plan_merge_vf.plan_lca_merge('B', 'C')
 
1126
        plan = self.plan_merge_vf.plan_lca_merge(b'B', b'C')
1127
1127
        self.assertEqual([
1128
 
                          ('new-b', 'f\n'),
1129
 
                          ('unchanged', 'a\n'),
1130
 
                          ('killed-b', 'c\n'),
1131
 
                          ('new-a', 'e\n'),
1132
 
                          ('new-a', 'h\n'),
1133
 
                          ('killed-a', 'b\n'),
1134
 
                          ('unchanged', 'g\n')],
1135
 
                         list(plan))
 
1128
            ('new-b', b'f\n'),
 
1129
            ('unchanged', b'a\n'),
 
1130
            ('killed-b', b'c\n'),
 
1131
            ('new-a', b'e\n'),
 
1132
            ('new-a', b'h\n'),
 
1133
            ('killed-a', b'b\n'),
 
1134
            ('unchanged', b'g\n')],
 
1135
            list(plan))
1136
1136
 
1137
1137
    def test_plan_lca_merge_uncommitted_files(self):
1138
1138
        self.setup_plan_merge_uncommitted()
1139
 
        plan = self.plan_merge_vf.plan_lca_merge('B:', 'C:')
 
1139
        plan = self.plan_merge_vf.plan_lca_merge(b'B:', b'C:')
1140
1140
        self.assertEqual([
1141
 
                          ('new-b', 'f\n'),
1142
 
                          ('unchanged', 'a\n'),
1143
 
                          ('killed-b', 'c\n'),
1144
 
                          ('new-a', 'e\n'),
1145
 
                          ('new-a', 'h\n'),
1146
 
                          ('killed-a', 'b\n'),
1147
 
                          ('unchanged', 'g\n')],
1148
 
                         list(plan))
 
1141
            ('new-b', b'f\n'),
 
1142
            ('unchanged', b'a\n'),
 
1143
            ('killed-b', b'c\n'),
 
1144
            ('new-a', b'e\n'),
 
1145
            ('new-a', b'h\n'),
 
1146
            ('killed-a', b'b\n'),
 
1147
            ('unchanged', b'g\n')],
 
1148
            list(plan))
1149
1149
 
1150
1150
    def test_plan_lca_merge_with_base(self):
1151
1151
        self.setup_merge_with_base()
1152
 
        plan = self.plan_merge_vf.plan_lca_merge('THIS', 'OTHER', 'BASE')
1153
 
        self.assertEqual([('unchanged', 'a\n'),
1154
 
                          ('new-b', 'f\n'),
1155
 
                          ('unchanged', 'b\n'),
1156
 
                          ('killed-b', 'c\n'),
1157
 
                          ('new-a', 'd\n')
1158
 
                         ], list(plan))
 
1152
        plan = self.plan_merge_vf.plan_lca_merge(b'THIS', b'OTHER', b'BASE')
 
1153
        self.assertEqual([('unchanged', b'a\n'),
 
1154
                          ('new-b', b'f\n'),
 
1155
                          ('unchanged', b'b\n'),
 
1156
                          ('killed-b', b'c\n'),
 
1157
                          ('new-a', b'd\n')
 
1158
                          ], list(plan))
1159
1159
 
1160
1160
    def test_plan_lca_merge_with_criss_cross(self):
1161
 
        self.add_version(('root', 'ROOT'), [], 'abc')
 
1161
        self.add_version((b'root', b'ROOT'), [], b'abc')
1162
1162
        # each side makes a change
1163
 
        self.add_version(('root', 'REV1'), [('root', 'ROOT')], 'abcd')
1164
 
        self.add_version(('root', 'REV2'), [('root', 'ROOT')], 'abce')
 
1163
        self.add_version((b'root', b'REV1'), [(b'root', b'ROOT')], b'abcd')
 
1164
        self.add_version((b'root', b'REV2'), [(b'root', b'ROOT')], b'abce')
1165
1165
        # both sides merge, discarding others' changes
1166
 
        self.add_version(('root', 'LCA1'),
1167
 
            [('root', 'REV1'), ('root', 'REV2')], 'abcd')
1168
 
        self.add_version(('root', 'LCA2'),
1169
 
            [('root', 'REV1'), ('root', 'REV2')], 'fabce')
1170
 
        plan = self.plan_merge_vf.plan_lca_merge('LCA1', 'LCA2')
1171
 
        self.assertEqual([('new-b', 'f\n'),
1172
 
                          ('unchanged', 'a\n'),
1173
 
                          ('unchanged', 'b\n'),
1174
 
                          ('unchanged', 'c\n'),
1175
 
                          ('conflicted-a', 'd\n'),
1176
 
                          ('conflicted-b', 'e\n'),
1177
 
                         ], list(plan))
 
1166
        self.add_version((b'root', b'LCA1'),
 
1167
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'abcd')
 
1168
        self.add_version((b'root', b'LCA2'),
 
1169
                         [(b'root', b'REV1'), (b'root', b'REV2')], b'fabce')
 
1170
        plan = self.plan_merge_vf.plan_lca_merge(b'LCA1', b'LCA2')
 
1171
        self.assertEqual([('new-b', b'f\n'),
 
1172
                          ('unchanged', b'a\n'),
 
1173
                          ('unchanged', b'b\n'),
 
1174
                          ('unchanged', b'c\n'),
 
1175
                          ('conflicted-a', b'd\n'),
 
1176
                          ('conflicted-b', b'e\n'),
 
1177
                          ], list(plan))
1178
1178
 
1179
1179
    def test_plan_lca_merge_with_null(self):
1180
 
        self.add_version(('root', 'A'), [], 'ab')
1181
 
        self.add_version(('root', 'B'), [], 'bc')
1182
 
        plan = self.plan_merge_vf.plan_lca_merge('A', 'B')
1183
 
        self.assertEqual([('new-a', 'a\n'),
1184
 
                          ('unchanged', 'b\n'),
1185
 
                          ('new-b', 'c\n'),
1186
 
                         ], list(plan))
 
1180
        self.add_version((b'root', b'A'), [], b'ab')
 
1181
        self.add_version((b'root', b'B'), [], b'bc')
 
1182
        plan = self.plan_merge_vf.plan_lca_merge(b'A', b'B')
 
1183
        self.assertEqual([('new-a', b'a\n'),
 
1184
                          ('unchanged', b'b\n'),
 
1185
                          ('new-b', b'c\n'),
 
1186
                          ], list(plan))
1187
1187
 
1188
1188
    def test_plan_merge_with_delete_and_change(self):
1189
 
        self.add_rev('root', 'C', [], 'a')
1190
 
        self.add_rev('root', 'A', ['C'], 'b')
1191
 
        self.add_rev('root', 'B', ['C'], '')
1192
 
        plan = self.plan_merge_vf.plan_merge('A', 'B')
1193
 
        self.assertEqual([('killed-both', 'a\n'),
1194
 
                          ('new-a', 'b\n'),
1195
 
                         ], list(plan))
 
1189
        self.add_rev(b'root', b'C', [], b'a')
 
1190
        self.add_rev(b'root', b'A', [b'C'], b'b')
 
1191
        self.add_rev(b'root', b'B', [b'C'], b'')
 
1192
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
 
1193
        self.assertEqual([('killed-both', b'a\n'),
 
1194
                          ('new-a', b'b\n'),
 
1195
                          ], list(plan))
1196
1196
 
1197
1197
    def test_plan_merge_with_move_and_change(self):
1198
 
        self.add_rev('root', 'C', [], 'abcd')
1199
 
        self.add_rev('root', 'A', ['C'], 'acbd')
1200
 
        self.add_rev('root', 'B', ['C'], 'aBcd')
1201
 
        plan = self.plan_merge_vf.plan_merge('A', 'B')
1202
 
        self.assertEqual([('unchanged', 'a\n'),
1203
 
                          ('new-a', 'c\n'),
1204
 
                          ('killed-b', 'b\n'),
1205
 
                          ('new-b', 'B\n'),
1206
 
                          ('killed-a', 'c\n'),
1207
 
                          ('unchanged', 'd\n'),
1208
 
                         ], list(plan))
 
1198
        self.add_rev(b'root', b'C', [], b'abcd')
 
1199
        self.add_rev(b'root', b'A', [b'C'], b'acbd')
 
1200
        self.add_rev(b'root', b'B', [b'C'], b'aBcd')
 
1201
        plan = self.plan_merge_vf.plan_merge(b'A', b'B')
 
1202
        self.assertEqual([('unchanged', b'a\n'),
 
1203
                          ('new-a', b'c\n'),
 
1204
                          ('killed-b', b'b\n'),
 
1205
                          ('new-b', b'B\n'),
 
1206
                          ('killed-a', b'c\n'),
 
1207
                          ('unchanged', b'd\n'),
 
1208
                          ], list(plan))
1209
1209
 
1210
1210
 
1211
1211
class LoggingMerger(object):
1241
1241
        #  B C
1242
1242
        #
1243
1243
        builder = self.get_builder()
1244
 
        builder.build_snapshot('A-id', None,
1245
 
            [('add', ('', None, 'directory', None))])
1246
 
        builder.build_snapshot('C-id', ['A-id'], [])
1247
 
        builder.build_snapshot('B-id', ['A-id'], [])
 
1244
        builder.build_snapshot(None,
 
1245
                               [('add', ('', None, 'directory', None))],
 
1246
                               revision_id=b'A-id')
 
1247
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1248
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
1248
1249
        return builder
1249
1250
 
1250
1251
    def setup_criss_cross_graph(self):
1258
1259
        # |X|
1259
1260
        # D E
1260
1261
        builder = self.setup_simple_graph()
1261
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1262
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
 
1262
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1263
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
1263
1264
        return builder
1264
1265
 
1265
 
    def make_Merger(self, builder, other_revision_id,
1266
 
                    interesting_files=None, interesting_ids=None):
 
1266
    def make_Merger(self, builder, other_revision_id, interesting_files=None):
1267
1267
        """Make a Merger object from a branch builder"""
1268
1268
        mem_tree = memorytree.MemoryTree.create_on_branch(builder.get_branch())
1269
1269
        mem_tree.lock_write()
1270
1270
        self.addCleanup(mem_tree.unlock)
1271
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
1271
        merger = _mod_merge.Merger.from_revision_ids(
1272
1272
            mem_tree, other_revision_id)
1273
1273
        merger.set_interesting_files(interesting_files)
1274
 
        # It seems there is no matching function for set_interesting_ids
1275
 
        merger.interesting_ids = interesting_ids
1276
1274
        merger.merge_type = _mod_merge.Merge3Merger
1277
1275
        return merger
1278
1276
 
1280
1278
class TestMergerInMemory(TestMergerBase):
1281
1279
 
1282
1280
    def test_cache_trees_with_revision_ids_None(self):
1283
 
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1281
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1284
1282
        original_cache = dict(merger._cached_trees)
1285
1283
        merger.cache_trees_with_revision_ids([None])
1286
1284
        self.assertEqual(original_cache, merger._cached_trees)
1287
1285
 
1288
1286
    def test_cache_trees_with_revision_ids_no_revision_id(self):
1289
 
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1287
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1290
1288
        original_cache = dict(merger._cached_trees)
1291
1289
        tree = self.make_branch_and_memory_tree('tree')
1292
1290
        merger.cache_trees_with_revision_ids([tree])
1293
1291
        self.assertEqual(original_cache, merger._cached_trees)
1294
1292
 
1295
1293
    def test_cache_trees_with_revision_ids_having_revision_id(self):
1296
 
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1294
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1297
1295
        original_cache = dict(merger._cached_trees)
1298
 
        tree = merger.this_branch.repository.revision_tree('B-id')
1299
 
        original_cache['B-id'] = tree
 
1296
        tree = merger.this_branch.repository.revision_tree(b'B-id')
 
1297
        original_cache[b'B-id'] = tree
1300
1298
        merger.cache_trees_with_revision_ids([tree])
1301
1299
        self.assertEqual(original_cache, merger._cached_trees)
1302
1300
 
1303
1301
    def test_find_base(self):
1304
 
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
1305
 
        self.assertEqual('A-id', merger.base_rev_id)
 
1302
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
 
1303
        self.assertEqual(b'A-id', merger.base_rev_id)
1306
1304
        self.assertFalse(merger._is_criss_cross)
1307
1305
        self.assertIs(None, merger._lca_trees)
1308
1306
 
1309
1307
    def test_find_base_criss_cross(self):
1310
1308
        builder = self.setup_criss_cross_graph()
1311
 
        merger = self.make_Merger(builder, 'E-id')
1312
 
        self.assertEqual('A-id', merger.base_rev_id)
 
1309
        merger = self.make_Merger(builder, b'E-id')
 
1310
        self.assertEqual(b'A-id', merger.base_rev_id)
1313
1311
        self.assertTrue(merger._is_criss_cross)
1314
 
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
1315
 
                                            for t in merger._lca_trees])
 
1312
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
 
1313
                                              for t in merger._lca_trees])
1316
1314
        # If we swap the order, we should get a different lca order
1317
 
        builder.build_snapshot('F-id', ['E-id'], [])
1318
 
        merger = self.make_Merger(builder, 'D-id')
1319
 
        self.assertEqual(['C-id', 'B-id'], [t.get_revision_id()
1320
 
                                            for t in merger._lca_trees])
 
1315
        builder.build_snapshot([b'E-id'], [], revision_id=b'F-id')
 
1316
        merger = self.make_Merger(builder, b'D-id')
 
1317
        self.assertEqual([b'C-id', b'B-id'], [t.get_revision_id()
 
1318
                                              for t in merger._lca_trees])
1321
1319
 
1322
1320
    def test_find_base_triple_criss_cross(self):
1323
1321
        #       A-.
1330
1328
        #    \|   |/
1331
1329
        #     G   H
1332
1330
        builder = self.setup_criss_cross_graph()
1333
 
        builder.build_snapshot('F-id', ['A-id'], [])
1334
 
        builder.build_snapshot('H-id', ['E-id', 'F-id'], [])
1335
 
        builder.build_snapshot('G-id', ['D-id', 'F-id'], [])
1336
 
        merger = self.make_Merger(builder, 'H-id')
1337
 
        self.assertEqual(['B-id', 'C-id', 'F-id'],
 
1331
        builder.build_snapshot([b'A-id'], [], revision_id=b'F-id')
 
1332
        builder.build_snapshot([b'E-id', b'F-id'], [], revision_id=b'H-id')
 
1333
        builder.build_snapshot([b'D-id', b'F-id'], [], revision_id=b'G-id')
 
1334
        merger = self.make_Merger(builder, b'H-id')
 
1335
        self.assertEqual([b'B-id', b'C-id', b'F-id'],
1338
1336
                         [t.get_revision_id() for t in merger._lca_trees])
1339
1337
 
1340
1338
    def test_find_base_new_root_criss_cross(self):
1343
1341
        # | X |
1344
1342
        # |/ \|
1345
1343
        # C   D
1346
 
        
1347
1344
        builder = self.get_builder()
1348
 
        builder.build_snapshot('A-id', None,
1349
 
            [('add', ('', None, 'directory', None))])
1350
 
        builder.build_snapshot('B-id', [],
1351
 
            [('add', ('', None, 'directory', None))])
1352
 
        builder.build_snapshot('D-id', ['A-id', 'B-id'], [])
1353
 
        builder.build_snapshot('C-id', ['A-id', 'B-id'], [])
1354
 
        merger = self.make_Merger(builder, 'D-id')
1355
 
        self.assertEqual('A-id', merger.base_rev_id)
 
1345
        builder.build_snapshot(None,
 
1346
                               [('add', ('', None, 'directory', None))],
 
1347
                               revision_id=b'A-id')
 
1348
        builder.build_snapshot([],
 
1349
                               [('add', ('', None, 'directory', None))],
 
1350
                               revision_id=b'B-id')
 
1351
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'D-id')
 
1352
        builder.build_snapshot([b'A-id', b'B-id'], [], revision_id=b'C-id')
 
1353
        merger = self.make_Merger(builder, b'D-id')
 
1354
        self.assertEqual(b'A-id', merger.base_rev_id)
1356
1355
        self.assertTrue(merger._is_criss_cross)
1357
 
        self.assertEqual(['A-id', 'B-id'], [t.get_revision_id()
1358
 
                                            for t in merger._lca_trees])
 
1356
        self.assertEqual([b'A-id', b'B-id'], [t.get_revision_id()
 
1357
                                              for t in merger._lca_trees])
1359
1358
 
1360
1359
    def test_no_criss_cross_passed_to_merge_type(self):
1361
1360
        class LCATreesMerger(LoggingMerger):
1362
1361
            supports_lca_trees = True
1363
1362
 
1364
 
        merger = self.make_Merger(self.setup_simple_graph(), 'C-id')
 
1363
        merger = self.make_Merger(self.setup_simple_graph(), b'C-id')
1365
1364
        merger.merge_type = LCATreesMerger
1366
1365
        merge_obj = merger.make_merger()
1367
1366
        self.assertIsInstance(merge_obj, LCATreesMerger)
1368
1367
        self.assertFalse('lca_trees' in merge_obj.kwargs)
1369
1368
 
1370
1369
    def test_criss_cross_passed_to_merge_type(self):
1371
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
 
1370
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
1372
1371
        merger.merge_type = _mod_merge.Merge3Merger
1373
1372
        merge_obj = merger.make_merger()
1374
 
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
1375
 
                                            for t in merger._lca_trees])
 
1373
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
 
1374
                                              for t in merger._lca_trees])
1376
1375
 
1377
1376
    def test_criss_cross_not_supported_merge_type(self):
1378
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
 
1377
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
1379
1378
        # We explicitly do not define supports_lca_trees
1380
1379
        merger.merge_type = LoggingMerger
1381
1380
        merge_obj = merger.make_merger()
1386
1385
        class UnsupportedLCATreesMerger(LoggingMerger):
1387
1386
            supports_lca_trees = False
1388
1387
 
1389
 
        merger = self.make_Merger(self.setup_criss_cross_graph(), 'E-id')
 
1388
        merger = self.make_Merger(self.setup_criss_cross_graph(), b'E-id')
1390
1389
        merger.merge_type = UnsupportedLCATreesMerger
1391
1390
        merge_obj = merger.make_merger()
1392
1391
        self.assertIsInstance(merge_obj, UnsupportedLCATreesMerger)
1396
1395
class TestMergerEntriesLCA(TestMergerBase):
1397
1396
 
1398
1397
    def make_merge_obj(self, builder, other_revision_id,
1399
 
                       interesting_files=None, interesting_ids=None):
 
1398
                       interesting_files=None):
1400
1399
        merger = self.make_Merger(builder, other_revision_id,
1401
 
            interesting_files=interesting_files,
1402
 
            interesting_ids=interesting_ids)
 
1400
                                  interesting_files=interesting_files)
1403
1401
        return merger.make_merger()
1404
1402
 
1405
1403
    def test_simple(self):
1406
1404
        builder = self.get_builder()
1407
 
        builder.build_snapshot('A-id', None,
1408
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1409
 
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1410
 
        builder.build_snapshot('C-id', ['A-id'],
1411
 
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
1412
 
        builder.build_snapshot('B-id', ['A-id'],
1413
 
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
1414
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1415
 
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
1416
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1417
 
            [('modify', ('a-id', 'a\nB\nb\nC\nc\n'))])
1418
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1405
        builder.build_snapshot(None,
 
1406
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1407
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1408
                               revision_id=b'A-id')
 
1409
        builder.build_snapshot([b'A-id'],
 
1410
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
 
1411
                               revision_id=b'C-id')
 
1412
        builder.build_snapshot([b'A-id'],
 
1413
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
 
1414
                               revision_id=b'B-id')
 
1415
        builder.build_snapshot([b'C-id', b'B-id'],
 
1416
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
 
1417
                               revision_id=b'E-id')
 
1418
        builder.build_snapshot([b'B-id', b'C-id'],
 
1419
                               [('modify', ('a', b'a\nB\nb\nC\nc\n'))],
 
1420
                               revision_id=b'D-id', )
 
1421
        merge_obj = self.make_merge_obj(builder, b'E-id')
1419
1422
 
1420
 
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
1421
 
                                            for t in merge_obj._lca_trees])
1422
 
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
 
1423
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
 
1424
                                              for t in merge_obj._lca_trees])
 
1425
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
1423
1426
        entries = list(merge_obj._entries_lca())
1424
1427
 
1425
1428
        # (file_id, changed, parents, names, executable)
1426
1429
        # BASE, lca1, lca2, OTHER, THIS
1427
 
        root_id = 'a-root-id'
1428
 
        self.assertEqual([('a-id', True,
 
1430
        root_id = b'a-root-id'
 
1431
        self.assertEqual([(b'a-id', True,
 
1432
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1429
1433
                           ((root_id, [root_id, root_id]), root_id, root_id),
1430
1434
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1431
 
                           ((False, [False, False]), False, False)),
1432
 
                         ], entries)
 
1435
                           ((False, [False, False]), False, False),
 
1436
                           False),
 
1437
                          ], entries)
1433
1438
 
1434
1439
    def test_not_in_base(self):
1435
1440
        # LCAs all have the same last-modified revision for the file, as do
1444
1449
        #            G modifies 'bar'
1445
1450
 
1446
1451
        builder = self.get_builder()
1447
 
        builder.build_snapshot('A-id', None,
1448
 
            [('add', (u'', 'a-root-id', 'directory', None))])
1449
 
        builder.build_snapshot('B-id', ['A-id'],
1450
 
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
1451
 
        builder.build_snapshot('C-id', ['A-id'],
1452
 
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
1453
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1454
 
            [('add', (u'bar', 'bar-id', 'file', 'd\ne\nf\n'))])
1455
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1456
 
            [('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
1457
 
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
1458
 
            [('modify', (u'bar-id', 'd\ne\nf\nG\n'))])
1459
 
        builder.build_snapshot('F-id', ['D-id', 'E-id'], [])
1460
 
        merge_obj = self.make_merge_obj(builder, 'G-id')
 
1452
        builder.build_snapshot(None,
 
1453
                               [('add', (u'', b'a-root-id', 'directory', None))],
 
1454
                               revision_id=b'A-id')
 
1455
        builder.build_snapshot([b'A-id'],
 
1456
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
1457
                               revision_id=b'B-id')
 
1458
        builder.build_snapshot([b'A-id'],
 
1459
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
 
1460
                               revision_id=b'C-id')
 
1461
        builder.build_snapshot([b'B-id', b'C-id'],
 
1462
                               [('add', (u'bar', b'bar-id', 'file', b'd\ne\nf\n'))],
 
1463
                               revision_id=b'D-id')
 
1464
        builder.build_snapshot([b'C-id', b'B-id'],
 
1465
                               [('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
1466
                               revision_id=b'E-id')
 
1467
        builder.build_snapshot([b'E-id', b'D-id'],
 
1468
                               [('modify', (u'bar', b'd\ne\nf\nG\n'))],
 
1469
                               revision_id=b'G-id')
 
1470
        builder.build_snapshot([b'D-id', b'E-id'], [], revision_id=b'F-id')
 
1471
        merge_obj = self.make_merge_obj(builder, b'G-id')
1461
1472
 
1462
 
        self.assertEqual(['D-id', 'E-id'], [t.get_revision_id()
1463
 
                                            for t in merge_obj._lca_trees])
1464
 
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
 
1473
        self.assertEqual([b'D-id', b'E-id'], [t.get_revision_id()
 
1474
                                              for t in merge_obj._lca_trees])
 
1475
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
1465
1476
        entries = list(merge_obj._entries_lca())
1466
 
        root_id = 'a-root-id'
1467
 
        self.assertEqual([('bar-id', True,
 
1477
        root_id = b'a-root-id'
 
1478
        self.assertEqual([(b'bar-id', True,
 
1479
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
1468
1480
                           ((None, [root_id, root_id]), root_id, root_id),
1469
1481
                           ((None, [u'bar', u'bar']), u'bar', u'bar'),
1470
 
                           ((None, [False, False]), False, False)),
1471
 
                         ], entries)
 
1482
                           ((None, [False, False]), False, False),
 
1483
                           False),
 
1484
                          ], entries)
1472
1485
 
1473
1486
    def test_not_in_this(self):
1474
1487
        builder = self.get_builder()
1475
 
        builder.build_snapshot('A-id', None,
1476
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1477
 
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1478
 
        builder.build_snapshot('B-id', ['A-id'],
1479
 
            [('modify', ('a-id', 'a\nB\nb\nc\n'))])
1480
 
        builder.build_snapshot('C-id', ['A-id'],
1481
 
            [('modify', ('a-id', 'a\nb\nC\nc\n'))])
1482
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1483
 
            [('modify', ('a-id', 'a\nB\nb\nC\nc\nE\n'))])
1484
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1485
 
            [('unversion', 'a-id')])
1486
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1488
        builder.build_snapshot(None,
 
1489
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1490
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1491
                               revision_id=b'A-id')
 
1492
        builder.build_snapshot([b'A-id'],
 
1493
                               [('modify', ('a', b'a\nB\nb\nc\n'))],
 
1494
                               revision_id=b'B-id')
 
1495
        builder.build_snapshot([b'A-id'],
 
1496
                               [('modify', ('a', b'a\nb\nC\nc\n'))],
 
1497
                               revision_id=b'C-id')
 
1498
        builder.build_snapshot([b'C-id', b'B-id'],
 
1499
                               [('modify', ('a', b'a\nB\nb\nC\nc\nE\n'))],
 
1500
                               revision_id=b'E-id')
 
1501
        builder.build_snapshot([b'B-id', b'C-id'],
 
1502
                               [('unversion', 'a')],
 
1503
                               revision_id=b'D-id')
 
1504
        merge_obj = self.make_merge_obj(builder, b'E-id')
1487
1505
 
1488
 
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
1489
 
                                            for t in merge_obj._lca_trees])
1490
 
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
 
1506
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
 
1507
                                              for t in merge_obj._lca_trees])
 
1508
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
1491
1509
 
1492
1510
        entries = list(merge_obj._entries_lca())
1493
 
        root_id = 'a-root-id'
1494
 
        self.assertEqual([('a-id', True,
 
1511
        root_id = b'a-root-id'
 
1512
        self.assertEqual([(b'a-id', True,
 
1513
                           ((u'a', [u'a', u'a']), u'a', None),
1495
1514
                           ((root_id, [root_id, root_id]), root_id, None),
1496
1515
                           ((u'a', [u'a', u'a']), u'a', None),
1497
 
                           ((False, [False, False]), False, None)),
1498
 
                         ], entries)
 
1516
                           ((False, [False, False]), False, None),
 
1517
                           False),
 
1518
                          ], entries)
1499
1519
 
1500
1520
    def test_file_not_in_one_lca(self):
1501
1521
        #   A   # just root
1504
1524
        #   |X|
1505
1525
        #   D E # D and E both have the file, unchanged from C
1506
1526
        builder = self.get_builder()
1507
 
        builder.build_snapshot('A-id', None,
1508
 
            [('add', (u'', 'a-root-id', 'directory', None))])
1509
 
        builder.build_snapshot('B-id', ['A-id'], [])
1510
 
        builder.build_snapshot('C-id', ['A-id'],
1511
 
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1512
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], []) # Inherited from C
1513
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], # Merged from C
1514
 
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1515
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1527
        builder.build_snapshot(None,
 
1528
                               [('add', (u'', b'a-root-id', 'directory', None))],
 
1529
                               revision_id=b'A-id')
 
1530
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1531
        builder.build_snapshot([b'A-id'],
 
1532
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1533
                               revision_id=b'C-id')
 
1534
        builder.build_snapshot([b'C-id', b'B-id'],
 
1535
                               [], revision_id=b'E-id')  # Inherited from C
 
1536
        builder.build_snapshot([b'B-id', b'C-id'],  # Merged from C
 
1537
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1538
                               revision_id=b'D-id')
 
1539
        merge_obj = self.make_merge_obj(builder, b'E-id')
1516
1540
 
1517
 
        self.assertEqual(['B-id', 'C-id'], [t.get_revision_id()
1518
 
                                            for t in merge_obj._lca_trees])
1519
 
        self.assertEqual('A-id', merge_obj.base_tree.get_revision_id())
 
1541
        self.assertEqual([b'B-id', b'C-id'], [t.get_revision_id()
 
1542
                                              for t in merge_obj._lca_trees])
 
1543
        self.assertEqual(b'A-id', merge_obj.base_tree.get_revision_id())
1520
1544
 
1521
1545
        entries = list(merge_obj._entries_lca())
1522
1546
        self.assertEqual([], entries)
1523
1547
 
1524
1548
    def test_not_in_other(self):
1525
1549
        builder = self.get_builder()
1526
 
        builder.build_snapshot('A-id', None,
1527
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1528
 
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1529
 
        builder.build_snapshot('B-id', ['A-id'], [])
1530
 
        builder.build_snapshot('C-id', ['A-id'], [])
1531
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1532
 
            [('unversion', 'a-id')])
1533
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1534
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1550
        builder.build_snapshot(None,
 
1551
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1552
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1553
                               revision_id=b'A-id')
 
1554
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1555
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1556
        builder.build_snapshot(
 
1557
            [b'C-id', b'B-id'],
 
1558
            [('unversion', 'a')], revision_id=b'E-id')
 
1559
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1560
        merge_obj = self.make_merge_obj(builder, b'E-id')
1535
1561
 
1536
1562
        entries = list(merge_obj._entries_lca())
1537
 
        root_id = 'a-root-id'
1538
 
        self.assertEqual([('a-id', True,
 
1563
        root_id = b'a-root-id'
 
1564
        self.assertEqual([(b'a-id', True,
 
1565
                           ((u'a', [u'a', u'a']), None, u'a'),
1539
1566
                           ((root_id, [root_id, root_id]), None, root_id),
1540
1567
                           ((u'a', [u'a', u'a']), None, u'a'),
1541
 
                           ((False, [False, False]), None, False)),
1542
 
                         ], entries)
 
1568
                           ((False, [False, False]), None, False),
 
1569
                           False),
 
1570
                          ], entries)
1543
1571
 
1544
1572
    def test_not_in_other_or_lca(self):
1545
1573
        #       A    base, introduces 'foo'
1554
1582
        #   C => E, no changes
1555
1583
        # D would then win 'cleanly' and no record would be given
1556
1584
        builder = self.get_builder()
1557
 
        builder.build_snapshot('A-id', None,
1558
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1559
 
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
1560
 
        builder.build_snapshot('B-id', ['A-id'], [])
1561
 
        builder.build_snapshot('C-id', ['A-id'],
1562
 
            [('unversion', 'foo-id')])
1563
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1564
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1565
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1585
        builder.build_snapshot(None,
 
1586
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1587
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
 
1588
                               revision_id=b'A-id')
 
1589
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1590
        builder.build_snapshot([b'A-id'],
 
1591
                               [('unversion', 'foo')], revision_id=b'C-id')
 
1592
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1593
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1594
        merge_obj = self.make_merge_obj(builder, b'E-id')
1566
1595
 
1567
1596
        entries = list(merge_obj._entries_lca())
1568
1597
        self.assertEqual([], entries)
1583
1612
        # In this case, we have a conflict of how the changes were resolved. E
1584
1613
        # picked C and D picked B, so we should issue a conflict
1585
1614
        builder = self.get_builder()
1586
 
        builder.build_snapshot('A-id', None,
1587
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1588
 
             ('add', (u'foo', 'foo-id', 'file', 'content\n'))])
1589
 
        builder.build_snapshot('B-id', ['A-id'], [
1590
 
            ('modify', ('foo-id', 'new-content\n'))])
1591
 
        builder.build_snapshot('C-id', ['A-id'],
1592
 
            [('unversion', 'foo-id')])
1593
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1594
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1595
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1615
        builder.build_snapshot(None,
 
1616
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1617
                                ('add', (u'foo', b'foo-id', 'file', b'content\n'))],
 
1618
                               revision_id=b'A-id')
 
1619
        builder.build_snapshot([b'A-id'], [
 
1620
            ('modify', ('foo', b'new-content\n'))],
 
1621
            revision_id=b'B-id')
 
1622
        builder.build_snapshot([b'A-id'],
 
1623
                               [('unversion', 'foo')],
 
1624
                               revision_id=b'C-id')
 
1625
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1626
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1627
        merge_obj = self.make_merge_obj(builder, b'E-id')
1596
1628
 
1597
1629
        entries = list(merge_obj._entries_lca())
1598
 
        root_id = 'a-root-id'
1599
 
        self.assertEqual([('foo-id', True,
 
1630
        root_id = b'a-root-id'
 
1631
        self.assertEqual([(b'foo-id', True,
 
1632
                           ((u'foo', [u'foo', None]), None, u'foo'),
1600
1633
                           ((root_id, [root_id, None]), None, root_id),
1601
1634
                           ((u'foo', [u'foo', None]), None, 'foo'),
1602
 
                           ((False, [False, None]), None, False)),
1603
 
                         ], entries)
 
1635
                           ((False, [False, None]), None, False),
 
1636
                           False),
 
1637
                          ], entries)
1604
1638
 
1605
1639
    def test_only_in_one_lca(self):
1606
1640
        #   A   add only root
1619
1653
        #   A => C, add file, thus C supersedes B
1620
1654
        #   w/ C=BASE, D=THIS, E=OTHER we have 'happy convergence'
1621
1655
        builder = self.get_builder()
1622
 
        builder.build_snapshot('A-id', None,
1623
 
            [('add', (u'', 'a-root-id', 'directory', None))])
1624
 
        builder.build_snapshot('B-id', ['A-id'], [])
1625
 
        builder.build_snapshot('C-id', ['A-id'],
1626
 
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1627
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1628
 
            [('unversion', 'a-id')])
1629
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1630
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1656
        builder.build_snapshot(None,
 
1657
                               [('add', (u'', b'a-root-id', 'directory', None))],
 
1658
                               revision_id=b'A-id')
 
1659
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1660
        builder.build_snapshot([b'A-id'],
 
1661
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1662
                               revision_id=b'C-id')
 
1663
        builder.build_snapshot([b'C-id', b'B-id'],
 
1664
                               [('unversion', 'a')],
 
1665
                               revision_id=b'E-id')
 
1666
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1667
        merge_obj = self.make_merge_obj(builder, b'E-id')
1631
1668
 
1632
1669
        entries = list(merge_obj._entries_lca())
1633
1670
        self.assertEqual([], entries)
1634
1671
 
1635
1672
    def test_only_in_other(self):
1636
1673
        builder = self.get_builder()
1637
 
        builder.build_snapshot('A-id', None,
1638
 
            [('add', (u'', 'a-root-id', 'directory', None))])
1639
 
        builder.build_snapshot('B-id', ['A-id'], [])
1640
 
        builder.build_snapshot('C-id', ['A-id'], [])
1641
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1642
 
            [('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
1643
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1644
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1674
        builder.build_snapshot(None,
 
1675
                               [('add', (u'', b'a-root-id', 'directory', None))],
 
1676
                               revision_id=b'A-id')
 
1677
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1678
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1679
        builder.build_snapshot([b'C-id', b'B-id'],
 
1680
                               [('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
1681
                               revision_id=b'E-id')
 
1682
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1683
        merge_obj = self.make_merge_obj(builder, b'E-id')
1645
1684
 
1646
1685
        entries = list(merge_obj._entries_lca())
1647
 
        root_id = 'a-root-id'
1648
 
        self.assertEqual([('a-id', True,
 
1686
        root_id = b'a-root-id'
 
1687
        self.assertEqual([(b'a-id', True,
 
1688
                           ((None, [None, None]), u'a', None),
1649
1689
                           ((None, [None, None]), root_id, None),
1650
1690
                           ((None, [None, None]), u'a', None),
1651
 
                           ((None, [None, None]), False, None)),
1652
 
                         ], entries)
 
1691
                           ((None, [None, None]), False, None),
 
1692
                           False),
 
1693
                          ], entries)
1653
1694
 
1654
1695
    def test_one_lca_supersedes(self):
1655
1696
        # One LCA supersedes the other LCAs last modified value, but the
1666
1707
        #   though its LCAs disagree. This is because the modification in E
1667
1708
        #   completely supersedes the value in D.
1668
1709
        builder = self.get_builder()
1669
 
        builder.build_snapshot('A-id', None,
1670
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1671
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1672
 
        builder.build_snapshot('C-id', ['A-id'], [])
1673
 
        builder.build_snapshot('B-id', ['A-id'],
1674
 
            [('modify', ('foo-id', 'B content\n'))])
1675
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1676
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1677
 
            [('modify', ('foo-id', 'E content\n'))])
1678
 
        builder.build_snapshot('G-id', ['E-id', 'D-id'], [])
1679
 
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
1680
 
            [('modify', ('foo-id', 'F content\n'))])
1681
 
        merge_obj = self.make_merge_obj(builder, 'G-id')
 
1710
        builder.build_snapshot(None,
 
1711
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1712
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1713
                               revision_id=b'A-id')
 
1714
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1715
        builder.build_snapshot([b'A-id'],
 
1716
                               [('modify', ('foo', b'B content\n'))],
 
1717
                               revision_id=b'B-id')
 
1718
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1719
        builder.build_snapshot([b'C-id', b'B-id'],
 
1720
                               [('modify', ('foo', b'E content\n'))],
 
1721
                               revision_id=b'E-id')
 
1722
        builder.build_snapshot([b'E-id', b'D-id'], [], revision_id=b'G-id')
 
1723
        builder.build_snapshot([b'D-id', b'E-id'],
 
1724
                               [('modify', ('foo', b'F content\n'))],
 
1725
                               revision_id=b'F-id')
 
1726
        merge_obj = self.make_merge_obj(builder, b'G-id')
1682
1727
 
1683
1728
        self.assertEqual([], list(merge_obj._entries_lca()))
1684
1729
 
1712
1757
        # aren't supporting it yet.
1713
1758
        #
1714
1759
        builder = self.get_builder()
1715
 
        builder.build_snapshot('A-id', None,
1716
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1717
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1718
 
        builder.build_snapshot('C-id', ['A-id'], [])
1719
 
        builder.build_snapshot('B-id', ['A-id'],
1720
 
            [('rename', ('foo', 'bar'))])
1721
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1722
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1723
 
            [('rename', ('foo', 'bing'))]) # override to bing
1724
 
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
1725
 
            [('rename', ('bing', 'barry'))]) # override to barry
1726
 
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
1727
 
            [('rename', ('bar', 'bing'))]) # Merge in E's change
1728
 
        merge_obj = self.make_merge_obj(builder, 'G-id')
 
1760
        builder.build_snapshot(None,
 
1761
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1762
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1763
                               revision_id=b'A-id')
 
1764
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1765
        builder.build_snapshot([b'A-id'],
 
1766
                               [('rename', ('foo', 'bar'))],
 
1767
                               revision_id=b'B-id')
 
1768
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1769
        builder.build_snapshot([b'C-id', b'B-id'],
 
1770
                               [('rename', ('foo', 'bing'))],
 
1771
                               revision_id=b'E-id')  # override to bing
 
1772
        builder.build_snapshot([b'E-id', b'D-id'],
 
1773
                               [('rename', ('bing', 'barry'))],
 
1774
                               revision_id=b'G-id')  # override to barry
 
1775
        builder.build_snapshot([b'D-id', b'E-id'],
 
1776
                               [('rename', ('bar', 'bing'))],
 
1777
                               revision_id=b'F-id')  # Merge in E's change
 
1778
        merge_obj = self.make_merge_obj(builder, b'G-id')
1729
1779
 
1730
1780
        self.expectFailure("We don't do an actual heads() check on lca values,"
1731
 
            " or use the per-attribute graph",
1732
 
            self.assertEqual, [], list(merge_obj._entries_lca()))
 
1781
                           " or use the per-attribute graph",
 
1782
                           self.assertEqual, [], list(merge_obj._entries_lca()))
1733
1783
 
1734
1784
    def test_one_lca_accidentally_pruned(self):
1735
1785
        # Another incorrect resolution from the same basic flaw:
1745
1795
        # be pruned from the LCAs, even though it was newly introduced by E
1746
1796
        # (superseding B).
1747
1797
        builder = self.get_builder()
1748
 
        builder.build_snapshot('A-id', None,
1749
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1750
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1751
 
        builder.build_snapshot('C-id', ['A-id'], [])
1752
 
        builder.build_snapshot('B-id', ['A-id'],
1753
 
            [('rename', ('foo', 'bar'))])
1754
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1755
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1756
 
        builder.build_snapshot('G-id', ['E-id', 'D-id'],
1757
 
            [('rename', ('foo', 'bar'))])
1758
 
        builder.build_snapshot('F-id', ['D-id', 'E-id'],
1759
 
            [('rename', ('bar', 'bing'))]) # should end up conflicting
1760
 
        merge_obj = self.make_merge_obj(builder, 'G-id')
 
1798
        builder.build_snapshot(None,
 
1799
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1800
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1801
                               revision_id=b'A-id')
 
1802
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1803
        builder.build_snapshot([b'A-id'],
 
1804
                               [('rename', ('foo', 'bar'))],
 
1805
                               revision_id=b'B-id')
 
1806
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1807
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1808
        builder.build_snapshot([b'E-id', b'D-id'],
 
1809
                               [('rename', ('foo', 'bar'))],
 
1810
                               revision_id=b'G-id')
 
1811
        builder.build_snapshot([b'D-id', b'E-id'],
 
1812
                               [('rename', ('bar', 'bing'))],
 
1813
                               revision_id=b'F-id')  # should end up conflicting
 
1814
        merge_obj = self.make_merge_obj(builder, b'G-id')
1761
1815
 
1762
1816
        entries = list(merge_obj._entries_lca())
1763
 
        root_id = 'a-root-id'
 
1817
        root_id = b'a-root-id'
1764
1818
        self.expectFailure("We prune values from BASE even when relevant.",
1765
 
            self.assertEqual,
1766
 
                [('foo-id', False,
1767
 
                  ((root_id, [root_id, root_id]), root_id, root_id),
1768
 
                  ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
1769
 
                  ((False, [False, False]), False, False)),
1770
 
                ], entries)
 
1819
                           self.assertEqual,
 
1820
                           [(b'foo-id', False,
 
1821
                             ((root_id, [root_id, root_id]), root_id, root_id),
 
1822
                               ((u'foo', [u'bar', u'foo']), u'bar', u'bing'),
 
1823
                               ((False, [False, False]), False, False),
 
1824
                             False),
 
1825
                            ], entries)
1771
1826
 
1772
1827
    def test_both_sides_revert(self):
1773
1828
        # Both sides of a criss-cross revert the text to the lca
1778
1833
        #       D E  D reverts to B, E reverts to C
1779
1834
        # This should conflict
1780
1835
        builder = self.get_builder()
1781
 
        builder.build_snapshot('A-id', None,
1782
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1783
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1784
 
        builder.build_snapshot('B-id', ['A-id'],
1785
 
            [('modify', ('foo-id', 'B content\n'))])
1786
 
        builder.build_snapshot('C-id', ['A-id'],
1787
 
            [('modify', ('foo-id', 'C content\n'))])
1788
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1789
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1790
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1836
        builder.build_snapshot(None,
 
1837
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1838
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1839
                               revision_id=b'A-id')
 
1840
        builder.build_snapshot([b'A-id'],
 
1841
                               [('modify', ('foo', b'B content\n'))],
 
1842
                               revision_id=b'B-id')
 
1843
        builder.build_snapshot([b'A-id'],
 
1844
                               [('modify', ('foo', b'C content\n'))],
 
1845
                               revision_id=b'C-id')
 
1846
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1847
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1848
        merge_obj = self.make_merge_obj(builder, b'E-id')
1791
1849
 
1792
1850
        entries = list(merge_obj._entries_lca())
1793
 
        root_id = 'a-root-id'
1794
 
        self.assertEqual([('foo-id', True,
 
1851
        root_id = b'a-root-id'
 
1852
        self.assertEqual([(b'foo-id', True,
 
1853
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1795
1854
                           ((root_id, [root_id, root_id]), root_id, root_id),
1796
1855
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1797
 
                           ((False, [False, False]), False, False)),
1798
 
                         ], entries)
 
1856
                           ((False, [False, False]), False, False),
 
1857
                           False),
 
1858
                          ], entries)
1799
1859
 
1800
1860
    def test_different_lca_resolve_one_side_updates_content(self):
1801
1861
        # Both sides converge, but then one side updates the text.
1809
1869
        # We need to emit an entry for 'foo', because D & E differed on the
1810
1870
        # merge resolution
1811
1871
        builder = self.get_builder()
1812
 
        builder.build_snapshot('A-id', None,
1813
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1814
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1815
 
        builder.build_snapshot('B-id', ['A-id'],
1816
 
            [('modify', ('foo-id', 'B content\n'))])
1817
 
        builder.build_snapshot('C-id', ['A-id'],
1818
 
            [('modify', ('foo-id', 'C content\n'))])
1819
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1820
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1821
 
        builder.build_snapshot('F-id', ['D-id'],
1822
 
            [('modify', ('foo-id', 'F content\n'))])
1823
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1872
        builder.build_snapshot(None,
 
1873
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1874
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1875
                               revision_id=b'A-id')
 
1876
        builder.build_snapshot([b'A-id'],
 
1877
                               [('modify', ('foo', b'B content\n'))],
 
1878
                               revision_id=b'B-id')
 
1879
        builder.build_snapshot([b'A-id'],
 
1880
                               [('modify', ('foo', b'C content\n'))],
 
1881
                               revision_id=b'C-id', )
 
1882
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1883
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1884
        builder.build_snapshot([b'D-id'],
 
1885
                               [('modify', ('foo', b'F content\n'))],
 
1886
                               revision_id=b'F-id')
 
1887
        merge_obj = self.make_merge_obj(builder, b'E-id')
1824
1888
 
1825
1889
        entries = list(merge_obj._entries_lca())
1826
 
        root_id = 'a-root-id'
1827
 
        self.assertEqual([('foo-id', True,
 
1890
        root_id = b'a-root-id'
 
1891
        self.assertEqual([(b'foo-id', True,
 
1892
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1828
1893
                           ((root_id, [root_id, root_id]), root_id, root_id),
1829
1894
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
1830
 
                           ((False, [False, False]), False, False)),
1831
 
                         ], entries)
 
1895
                           ((False, [False, False]), False, False),
 
1896
                           False),
 
1897
                          ], entries)
1832
1898
 
1833
1899
    def test_same_lca_resolution_one_side_updates_content(self):
1834
1900
        # Both sides converge, but then one side updates the text.
1845
1911
        # We need to conflict.
1846
1912
 
1847
1913
        builder = self.get_builder()
1848
 
        builder.build_snapshot('A-id', None,
1849
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1850
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
1851
 
        builder.build_snapshot('B-id', ['A-id'],
1852
 
            [('modify', ('foo-id', 'B content\n'))])
1853
 
        builder.build_snapshot('C-id', ['A-id'],
1854
 
            [('modify', ('foo-id', 'C content\n'))])
1855
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1856
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1857
 
            [('modify', ('foo-id', 'C content\n'))]) # Same as E
1858
 
        builder.build_snapshot('F-id', ['D-id'],
1859
 
            [('modify', ('foo-id', 'F content\n'))])
1860
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1914
        builder.build_snapshot(None,
 
1915
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1916
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
1917
                               revision_id=b'A-id')
 
1918
        builder.build_snapshot([b'A-id'],
 
1919
                               [('modify', ('foo', b'B content\n'))],
 
1920
                               revision_id=b'B-id')
 
1921
        builder.build_snapshot([b'A-id'],
 
1922
                               [('modify', ('foo', b'C content\n'))],
 
1923
                               revision_id=b'C-id')
 
1924
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1925
        builder.build_snapshot([b'B-id', b'C-id'],
 
1926
                               [('modify', ('foo', b'C content\n'))],
 
1927
                               revision_id=b'D-id')  # Same as E
 
1928
        builder.build_snapshot([b'D-id'],
 
1929
                               [('modify', ('foo', b'F content\n'))],
 
1930
                               revision_id=b'F-id')
 
1931
        merge_obj = self.make_merge_obj(builder, b'E-id')
1861
1932
 
1862
1933
        entries = list(merge_obj._entries_lca())
1863
1934
        self.expectFailure("We don't detect that LCA resolution was the"
1864
1935
                           " same on both sides",
1865
 
            self.assertEqual, [], entries)
 
1936
                           self.assertEqual, [], entries)
1866
1937
 
1867
1938
    def test_only_path_changed(self):
1868
1939
        builder = self.get_builder()
1869
 
        builder.build_snapshot('A-id', None,
1870
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1871
 
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
1872
 
        builder.build_snapshot('B-id', ['A-id'], [])
1873
 
        builder.build_snapshot('C-id', ['A-id'], [])
1874
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1875
 
            [('rename', (u'a', u'b'))])
1876
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1877
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1940
        builder.build_snapshot(None,
 
1941
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1942
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
 
1943
                               revision_id=b'A-id')
 
1944
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1945
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1946
        builder.build_snapshot([b'C-id', b'B-id'],
 
1947
                               [('rename', (u'a', u'b'))],
 
1948
                               revision_id=b'E-id')
 
1949
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1950
        merge_obj = self.make_merge_obj(builder, b'E-id')
1878
1951
        entries = list(merge_obj._entries_lca())
1879
 
        root_id = 'a-root-id'
 
1952
        root_id = b'a-root-id'
1880
1953
        # The content was not changed, only the path
1881
 
        self.assertEqual([('a-id', False,
 
1954
        self.assertEqual([(b'a-id', False,
 
1955
                           ((u'a', [u'a', u'a']), u'b', u'a'),
1882
1956
                           ((root_id, [root_id, root_id]), root_id, root_id),
1883
1957
                           ((u'a', [u'a', u'a']), u'b', u'a'),
1884
 
                           ((False, [False, False]), False, False)),
1885
 
                         ], entries)
 
1958
                           ((False, [False, False]), False, False),
 
1959
                           False),
 
1960
                          ], entries)
1886
1961
 
1887
1962
    def test_kind_changed(self):
1888
1963
        # Identical content, except 'D' changes a-id into a directory
1889
1964
        builder = self.get_builder()
1890
 
        builder.build_snapshot('A-id', None,
1891
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1892
 
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
1893
 
        builder.build_snapshot('B-id', ['A-id'], [])
1894
 
        builder.build_snapshot('C-id', ['A-id'], [])
1895
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1896
 
            [('unversion', 'a-id'),
1897
 
             ('flush', None),
1898
 
             ('add', (u'a', 'a-id', 'directory', None))])
1899
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1900
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1965
        builder.build_snapshot(None,
 
1966
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1967
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
 
1968
                               revision_id=b'A-id')
 
1969
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1970
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1971
        builder.build_snapshot([b'C-id', b'B-id'],
 
1972
                               [('unversion', 'a'),
 
1973
                                ('flush', None),
 
1974
                                ('add', (u'a', b'a-id', 'directory', None))],
 
1975
                               revision_id=b'E-id')
 
1976
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
1977
        merge_obj = self.make_merge_obj(builder, b'E-id')
1901
1978
        entries = list(merge_obj._entries_lca())
1902
 
        root_id = 'a-root-id'
 
1979
        root_id = b'a-root-id'
1903
1980
        # Only the kind was changed (content)
1904
 
        self.assertEqual([('a-id', True,
 
1981
        self.assertEqual([(b'a-id', True,
 
1982
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1905
1983
                           ((root_id, [root_id, root_id]), root_id, root_id),
1906
1984
                           ((u'a', [u'a', u'a']), u'a', u'a'),
1907
 
                           ((False, [False, False]), False, False)),
1908
 
                         ], entries)
 
1985
                           ((False, [False, False]), False, False),
 
1986
                           False),
 
1987
                          ], entries)
1909
1988
 
1910
1989
    def test_this_changed_kind(self):
1911
1990
        # Identical content, but THIS changes a file to a directory
1912
1991
        builder = self.get_builder()
1913
 
        builder.build_snapshot('A-id', None,
1914
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1915
 
             ('add', (u'a', 'a-id', 'file', 'content\n'))])
1916
 
        builder.build_snapshot('B-id', ['A-id'], [])
1917
 
        builder.build_snapshot('C-id', ['A-id'], [])
1918
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
1919
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1920
 
            [('unversion', 'a-id'),
1921
 
             ('flush', None),
1922
 
             ('add', (u'a', 'a-id', 'directory', None))])
1923
 
        merge_obj = self.make_merge_obj(builder, 'E-id')
 
1992
        builder.build_snapshot(None,
 
1993
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
1994
                                ('add', (u'a', b'a-id', 'file', b'content\n'))],
 
1995
                               revision_id=b'A-id')
 
1996
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
1997
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
1998
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
1999
        builder.build_snapshot([b'B-id', b'C-id'],
 
2000
                               [('unversion', 'a'),
 
2001
                                ('flush', None),
 
2002
                                ('add', (u'a', b'a-id', 'directory', None))],
 
2003
                               revision_id=b'D-id')
 
2004
        merge_obj = self.make_merge_obj(builder, b'E-id')
1924
2005
        entries = list(merge_obj._entries_lca())
1925
2006
        # Only the kind was changed (content)
1926
2007
        self.assertEqual([], entries)
1928
2009
    def test_interesting_files(self):
1929
2010
        # Two files modified, but we should filter one of them
1930
2011
        builder = self.get_builder()
1931
 
        builder.build_snapshot('A-id', None,
1932
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1933
 
             ('add', (u'a', 'a-id', 'file', 'content\n')),
1934
 
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
1935
 
        builder.build_snapshot('B-id', ['A-id'], [])
1936
 
        builder.build_snapshot('C-id', ['A-id'], [])
1937
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1938
 
            [('modify', ('a-id', 'new-content\n')),
1939
 
             ('modify', ('b-id', 'new-content\n'))])
1940
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1941
 
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
2012
        builder.build_snapshot(None,
 
2013
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2014
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
 
2015
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
 
2016
                               revision_id=b'A-id')
 
2017
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2018
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2019
        builder.build_snapshot([b'C-id', b'B-id'],
 
2020
                               [('modify', ('a', b'new-content\n')),
 
2021
                                ('modify', ('b', b'new-content\n'))],
 
2022
                               revision_id=b'E-id')
 
2023
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2024
        merge_obj = self.make_merge_obj(builder, b'E-id',
1942
2025
                                        interesting_files=['b'])
1943
2026
        entries = list(merge_obj._entries_lca())
1944
 
        root_id = 'a-root-id'
1945
 
        self.assertEqual([('b-id', True,
 
2027
        root_id = b'a-root-id'
 
2028
        self.assertEqual([(b'b-id', True,
 
2029
                           ((u'b', [u'b', u'b']), u'b', u'b'),
1946
2030
                           ((root_id, [root_id, root_id]), root_id, root_id),
1947
2031
                           ((u'b', [u'b', u'b']), u'b', u'b'),
1948
 
                           ((False, [False, False]), False, False)),
1949
 
                         ], entries)
 
2032
                           ((False, [False, False]), False, False),
 
2033
                           False),
 
2034
                          ], entries)
1950
2035
 
1951
2036
    def test_interesting_file_in_this(self):
1952
2037
        # This renamed the file, but it should still match the entry in other
1953
2038
        builder = self.get_builder()
1954
 
        builder.build_snapshot('A-id', None,
1955
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1956
 
             ('add', (u'a', 'a-id', 'file', 'content\n')),
1957
 
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
1958
 
        builder.build_snapshot('B-id', ['A-id'], [])
1959
 
        builder.build_snapshot('C-id', ['A-id'], [])
1960
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1961
 
            [('modify', ('a-id', 'new-content\n')),
1962
 
             ('modify', ('b-id', 'new-content\n'))])
1963
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
1964
 
            [('rename', ('b', 'c'))])
1965
 
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
2039
        builder.build_snapshot(None,
 
2040
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2041
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
 
2042
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
 
2043
                               revision_id=b'A-id')
 
2044
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2045
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2046
        builder.build_snapshot([b'C-id', b'B-id'],
 
2047
                               [('modify', ('a', b'new-content\n')),
 
2048
                                ('modify', ('b', b'new-content\n'))],
 
2049
                               revision_id=b'E-id')
 
2050
        builder.build_snapshot([b'B-id', b'C-id'],
 
2051
                               [('rename', ('b', 'c'))],
 
2052
                               revision_id=b'D-id')
 
2053
        merge_obj = self.make_merge_obj(builder, b'E-id',
1966
2054
                                        interesting_files=['c'])
1967
2055
        entries = list(merge_obj._entries_lca())
1968
 
        root_id = 'a-root-id'
1969
 
        self.assertEqual([('b-id', True,
 
2056
        root_id = b'a-root-id'
 
2057
        self.assertEqual([(b'b-id', True,
 
2058
                           ((u'b', [u'b', u'b']), u'b', u'c'),
1970
2059
                           ((root_id, [root_id, root_id]), root_id, root_id),
1971
2060
                           ((u'b', [u'b', u'b']), u'b', u'c'),
1972
 
                           ((False, [False, False]), False, False)),
1973
 
                         ], entries)
 
2061
                           ((False, [False, False]), False, False),
 
2062
                           False),
 
2063
                          ], entries)
1974
2064
 
1975
2065
    def test_interesting_file_in_base(self):
1976
2066
        # This renamed the file, but it should still match the entry in BASE
1977
2067
        builder = self.get_builder()
1978
 
        builder.build_snapshot('A-id', None,
1979
 
            [('add', (u'', 'a-root-id', 'directory', None)),
1980
 
             ('add', (u'a', 'a-id', 'file', 'content\n')),
1981
 
             ('add', (u'c', 'c-id', 'file', 'content\n'))])
1982
 
        builder.build_snapshot('B-id', ['A-id'],
1983
 
            [('rename', ('c', 'b'))])
1984
 
        builder.build_snapshot('C-id', ['A-id'],
1985
 
            [('rename', ('c', 'b'))])
1986
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
1987
 
            [('modify', ('a-id', 'new-content\n')),
1988
 
             ('modify', ('c-id', 'new-content\n'))])
1989
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
1990
 
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
2068
        builder.build_snapshot(None,
 
2069
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2070
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
 
2071
                                   ('add', (u'c', b'c-id', 'file', b'content\n'))],
 
2072
                               revision_id=b'A-id')
 
2073
        builder.build_snapshot([b'A-id'],
 
2074
                               [('rename', ('c', 'b'))],
 
2075
                               revision_id=b'B-id')
 
2076
        builder.build_snapshot([b'A-id'],
 
2077
                               [('rename', ('c', 'b'))],
 
2078
                               revision_id=b'C-id')
 
2079
        builder.build_snapshot([b'C-id', b'B-id'],
 
2080
                               [('modify', ('a', b'new-content\n')),
 
2081
                                ('modify', ('b', b'new-content\n'))],
 
2082
                               revision_id=b'E-id')
 
2083
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2084
        merge_obj = self.make_merge_obj(builder, b'E-id',
1991
2085
                                        interesting_files=['c'])
1992
2086
        entries = list(merge_obj._entries_lca())
1993
 
        root_id = 'a-root-id'
1994
 
        self.assertEqual([('c-id', True,
 
2087
        root_id = b'a-root-id'
 
2088
        self.assertEqual([(b'c-id', True,
 
2089
                           ((u'c', [u'b', u'b']), u'b', u'b'),
1995
2090
                           ((root_id, [root_id, root_id]), root_id, root_id),
1996
2091
                           ((u'c', [u'b', u'b']), u'b', u'b'),
1997
 
                           ((False, [False, False]), False, False)),
1998
 
                         ], entries)
 
2092
                           ((False, [False, False]), False, False),
 
2093
                           False),
 
2094
                          ], entries)
1999
2095
 
2000
2096
    def test_interesting_file_in_lca(self):
2001
2097
        # This renamed the file, but it should still match the entry in LCA
2002
2098
        builder = self.get_builder()
2003
 
        builder.build_snapshot('A-id', None,
2004
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2005
 
             ('add', (u'a', 'a-id', 'file', 'content\n')),
2006
 
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
2007
 
        builder.build_snapshot('B-id', ['A-id'],
2008
 
            [('rename', ('b', 'c'))])
2009
 
        builder.build_snapshot('C-id', ['A-id'], [])
2010
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2011
 
            [('modify', ('a-id', 'new-content\n')),
2012
 
             ('modify', ('b-id', 'new-content\n'))])
2013
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
2014
 
            [('rename', ('c', 'b'))])
2015
 
        merge_obj = self.make_merge_obj(builder, 'E-id',
 
2099
        builder.build_snapshot(None,
 
2100
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2101
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
 
2102
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
 
2103
                               revision_id=b'A-id')
 
2104
        builder.build_snapshot([b'A-id'],
 
2105
                               [('rename', ('b', 'c'))], revision_id=b'B-id')
 
2106
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2107
        builder.build_snapshot([b'C-id', b'B-id'],
 
2108
                               [('modify', ('a', b'new-content\n')),
 
2109
                                ('modify', ('b', b'new-content\n'))],
 
2110
                               revision_id=b'E-id')
 
2111
        builder.build_snapshot([b'B-id', b'C-id'],
 
2112
                               [('rename', ('c', 'b'))], revision_id=b'D-id')
 
2113
        merge_obj = self.make_merge_obj(builder, b'E-id',
2016
2114
                                        interesting_files=['c'])
2017
2115
        entries = list(merge_obj._entries_lca())
2018
 
        root_id = 'a-root-id'
2019
 
        self.assertEqual([('b-id', True,
 
2116
        root_id = b'a-root-id'
 
2117
        self.assertEqual([(b'b-id', True,
 
2118
                           ((u'b', [u'c', u'b']), u'b', u'b'),
2020
2119
                           ((root_id, [root_id, root_id]), root_id, root_id),
2021
2120
                           ((u'b', [u'c', u'b']), u'b', u'b'),
2022
 
                           ((False, [False, False]), False, False)),
2023
 
                         ], entries)
 
2121
                           ((False, [False, False]), False, False),
 
2122
                           False),
 
2123
                          ], entries)
2024
2124
 
2025
 
    def test_interesting_ids(self):
 
2125
    def test_interesting_files(self):
2026
2126
        # Two files modified, but we should filter one of them
2027
2127
        builder = self.get_builder()
2028
 
        builder.build_snapshot('A-id', None,
2029
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2030
 
             ('add', (u'a', 'a-id', 'file', 'content\n')),
2031
 
             ('add', (u'b', 'b-id', 'file', 'content\n'))])
2032
 
        builder.build_snapshot('B-id', ['A-id'], [])
2033
 
        builder.build_snapshot('C-id', ['A-id'], [])
2034
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2035
 
            [('modify', ('a-id', 'new-content\n')),
2036
 
             ('modify', ('b-id', 'new-content\n'))])
2037
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2038
 
        merge_obj = self.make_merge_obj(builder, 'E-id',
2039
 
                                        interesting_ids=['b-id'])
 
2128
        builder.build_snapshot(None,
 
2129
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2130
                                ('add', (u'a', b'a-id', 'file', b'content\n')),
 
2131
                                   ('add', (u'b', b'b-id', 'file', b'content\n'))],
 
2132
                               revision_id=b'A-id')
 
2133
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2134
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2135
        builder.build_snapshot([b'C-id', b'B-id'],
 
2136
                               [('modify', ('a', b'new-content\n')),
 
2137
                                ('modify', ('b', b'new-content\n'))], revision_id=b'E-id')
 
2138
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2139
        merge_obj = self.make_merge_obj(builder, b'E-id',
 
2140
                                        interesting_files=['b'])
2040
2141
        entries = list(merge_obj._entries_lca())
2041
 
        root_id = 'a-root-id'
2042
 
        self.assertEqual([('b-id', True,
 
2142
        root_id = b'a-root-id'
 
2143
        self.assertEqual([(b'b-id', True,
 
2144
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2043
2145
                           ((root_id, [root_id, root_id]), root_id, root_id),
2044
2146
                           ((u'b', [u'b', u'b']), u'b', u'b'),
2045
 
                           ((False, [False, False]), False, False)),
2046
 
                         ], entries)
2047
 
 
 
2147
                           ((False, [False, False]), False, False),
 
2148
                           False),
 
2149
                          ], entries)
2048
2150
 
2049
2151
 
2050
2152
class TestMergerEntriesLCAOnDisk(tests.TestCaseWithTransport):
2058
2160
    def get_wt_from_builder(self, builder):
2059
2161
        """Get a real WorkingTree from the builder."""
2060
2162
        the_branch = builder.get_branch()
2061
 
        wt = the_branch.bzrdir.create_workingtree()
 
2163
        wt = the_branch.controldir.create_workingtree()
2062
2164
        # Note: This is a little bit ugly, but we are holding the branch
2063
2165
        #       write-locked as part of the build process, and we would like to
2064
2166
        #       maintain that. So we just force the WT to re-use the same
2070
2172
 
2071
2173
    def do_merge(self, builder, other_revision_id):
2072
2174
        wt = self.get_wt_from_builder(builder)
2073
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2175
        merger = _mod_merge.Merger.from_revision_ids(
2074
2176
            wt, other_revision_id)
2075
2177
        merger.merge_type = _mod_merge.Merge3Merger
2076
2178
        return wt, merger.do_merge()
2077
2179
 
2078
2180
    def test_simple_lca(self):
2079
2181
        builder = self.get_builder()
2080
 
        builder.build_snapshot('A-id', None,
2081
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2082
 
             ('add', (u'a', 'a-id', 'file', 'a\nb\nc\n'))])
2083
 
        builder.build_snapshot('C-id', ['A-id'], [])
2084
 
        builder.build_snapshot('B-id', ['A-id'], [])
2085
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2086
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
2087
 
            [('modify', ('a-id', 'a\nb\nc\nd\ne\nf\n'))])
2088
 
        wt, conflicts = self.do_merge(builder, 'E-id')
 
2182
        builder.build_snapshot(None,
 
2183
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2184
                                ('add', (u'a', b'a-id', 'file', b'a\nb\nc\n'))],
 
2185
                               revision_id=b'A-id')
 
2186
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2187
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2188
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
 
2189
        builder.build_snapshot([b'B-id', b'C-id'],
 
2190
                               [('modify', ('a', b'a\nb\nc\nd\ne\nf\n'))],
 
2191
                               revision_id=b'D-id')
 
2192
        wt, conflicts = self.do_merge(builder, b'E-id')
2089
2193
        self.assertEqual(0, conflicts)
2090
2194
        # The merge should have simply update the contents of 'a'
2091
 
        self.assertEqual('a\nb\nc\nd\ne\nf\n', wt.get_file_text('a-id'))
 
2195
        self.assertEqual(b'a\nb\nc\nd\ne\nf\n', wt.get_file_text('a'))
2092
2196
 
2093
2197
    def test_conflict_without_lca(self):
2094
2198
        # This test would cause a merge conflict, unless we use the lca trees
2103
2207
        #     |
2104
2208
        #     F     Path at 'baz' in F, which supersedes 'bar' and 'foo'
2105
2209
        builder = self.get_builder()
2106
 
        builder.build_snapshot('A-id', None,
2107
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2108
 
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
2109
 
        builder.build_snapshot('C-id', ['A-id'], [])
2110
 
        builder.build_snapshot('B-id', ['A-id'],
2111
 
            [('rename', ('foo', 'bar'))])
2112
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
2113
 
            [('rename', ('foo', 'bar'))])
2114
 
        builder.build_snapshot('F-id', ['E-id'],
2115
 
            [('rename', ('bar', 'baz'))])
2116
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2117
 
        wt, conflicts = self.do_merge(builder, 'F-id')
 
2210
        builder.build_snapshot(None,
 
2211
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2212
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
2213
                               revision_id=b'A-id')
 
2214
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2215
        builder.build_snapshot([b'A-id'],
 
2216
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id', )
 
2217
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
 
2218
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
 
2219
        builder.build_snapshot([b'E-id'],
 
2220
                               [('rename', ('bar', 'baz'))], revision_id=b'F-id')
 
2221
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2222
        wt, conflicts = self.do_merge(builder, b'F-id')
2118
2223
        self.assertEqual(0, conflicts)
2119
2224
        # The merge should simply recognize that the final rename takes
2120
2225
        # precedence
2121
 
        self.assertEqual('baz', wt.id2path('foo-id'))
 
2226
        self.assertEqual('baz', wt.id2path(b'foo-id'))
2122
2227
 
2123
2228
    def test_other_deletes_lca_renames(self):
2124
2229
        # This test would cause a merge conflict, unless we use the lca trees
2133
2238
        #     |
2134
2239
        #     F     F deletes 'bar'
2135
2240
        builder = self.get_builder()
2136
 
        builder.build_snapshot('A-id', None,
2137
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2138
 
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
2139
 
        builder.build_snapshot('C-id', ['A-id'], [])
2140
 
        builder.build_snapshot('B-id', ['A-id'],
2141
 
            [('rename', ('foo', 'bar'))])
2142
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], # merge the rename
2143
 
            [('rename', ('foo', 'bar'))])
2144
 
        builder.build_snapshot('F-id', ['E-id'],
2145
 
            [('unversion', 'foo-id')])
2146
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2147
 
        wt, conflicts = self.do_merge(builder, 'F-id')
 
2241
        builder.build_snapshot(None,
 
2242
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2243
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
2244
                               revision_id=b'A-id')
 
2245
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2246
        builder.build_snapshot([b'A-id'],
 
2247
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
 
2248
        builder.build_snapshot([b'C-id', b'B-id'],  # merge the rename
 
2249
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')
 
2250
        builder.build_snapshot([b'E-id'],
 
2251
                               [('unversion', 'bar')], revision_id=b'F-id')
 
2252
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2253
        wt, conflicts = self.do_merge(builder, b'F-id')
2148
2254
        self.assertEqual(0, conflicts)
2149
 
        self.assertRaises(errors.NoSuchId, wt.id2path, 'foo-id')
 
2255
        self.assertRaises(errors.NoSuchId, wt.id2path, b'foo-id')
2150
2256
 
2151
2257
    def test_executable_changes(self):
2152
2258
        #   A       Path at 'foo'
2159
2265
        #     |
2160
2266
        #     F     Executable bit changed
2161
2267
        builder = self.get_builder()
2162
 
        builder.build_snapshot('A-id', None,
2163
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2164
 
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
2165
 
        builder.build_snapshot('C-id', ['A-id'], [])
2166
 
        builder.build_snapshot('B-id', ['A-id'], [])
2167
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2168
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
2268
        builder.build_snapshot(None,
 
2269
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2270
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
2271
                               revision_id=b'A-id')
 
2272
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2273
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2274
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2275
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
2169
2276
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2170
2277
        wt = self.get_wt_from_builder(builder)
2171
 
        tt = transform.TreeTransform(wt)
2172
 
        try:
2173
 
            tt.set_executability(True, tt.trans_id_tree_file_id('foo-id'))
 
2278
        with wt.transform() as tt:
 
2279
            tt.set_executability(True, tt.trans_id_tree_path('foo'))
2174
2280
            tt.apply()
2175
 
        except:
2176
 
            tt.finalize()
2177
 
            raise
2178
 
        self.assertTrue(wt.is_executable('foo-id'))
2179
 
        wt.commit('F-id', rev_id='F-id')
 
2281
        self.assertTrue(wt.is_executable('foo'))
 
2282
        wt.commit('F-id', rev_id=b'F-id')
2180
2283
        # Reset to D, so that we can merge F
2181
 
        wt.set_parent_ids(['D-id'])
2182
 
        wt.branch.set_last_revision_info(3, 'D-id')
 
2284
        wt.set_parent_ids([b'D-id'])
 
2285
        wt.branch.set_last_revision_info(3, b'D-id')
2183
2286
        wt.revert()
2184
 
        self.assertFalse(wt.is_executable('foo-id'))
2185
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
 
2287
        self.assertFalse(wt.is_executable('foo'))
 
2288
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
2186
2289
        self.assertEqual(0, conflicts)
2187
 
        self.assertTrue(wt.is_executable('foo-id'))
 
2290
        self.assertTrue(wt.is_executable('foo'))
2188
2291
 
2189
2292
    def test_create_symlink(self):
2190
2293
        self.requireFeature(features.SymlinkFeature)
2200
2303
        # Have to use a real WT, because BranchBuilder and MemoryTree don't
2201
2304
        # have symlink support
2202
2305
        builder = self.get_builder()
2203
 
        builder.build_snapshot('A-id', None,
2204
 
            [('add', (u'', 'a-root-id', 'directory', None))])
2205
 
        builder.build_snapshot('C-id', ['A-id'], [])
2206
 
        builder.build_snapshot('B-id', ['A-id'], [])
2207
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2208
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
 
2306
        builder.build_snapshot(None,
 
2307
                               [('add', (u'', b'a-root-id', 'directory', None))],
 
2308
                               revision_id=b'A-id')
 
2309
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2310
        builder.build_snapshot([b'A-id'], [], revision_id=b'B-id')
 
2311
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2312
        builder.build_snapshot([b'C-id', b'B-id'], [], revision_id=b'E-id')
2209
2313
        # Have to use a real WT, because BranchBuilder doesn't support exec bit
2210
2314
        wt = self.get_wt_from_builder(builder)
2211
2315
        os.symlink('bar', 'path/foo')
2212
 
        wt.add(['foo'], ['foo-id'])
2213
 
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2214
 
        wt.commit('add symlink', rev_id='F-id')
 
2316
        wt.add(['foo'], [b'foo-id'])
 
2317
        self.assertEqual('bar', wt.get_symlink_target('foo'))
 
2318
        wt.commit('add symlink', rev_id=b'F-id')
2215
2319
        # Reset to D, so that we can merge F
2216
 
        wt.set_parent_ids(['D-id'])
2217
 
        wt.branch.set_last_revision_info(3, 'D-id')
 
2320
        wt.set_parent_ids([b'D-id'])
 
2321
        wt.branch.set_last_revision_info(3, b'D-id')
2218
2322
        wt.revert()
2219
 
        self.assertIs(None, wt.path2id('foo'))
2220
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
 
2323
        self.assertFalse(wt.is_versioned('foo'))
 
2324
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
2221
2325
        self.assertEqual(0, conflicts)
2222
 
        self.assertEqual('foo-id', wt.path2id('foo'))
2223
 
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2326
        self.assertEqual(b'foo-id', wt.path2id('foo'))
 
2327
        self.assertEqual('bar', wt.get_symlink_target('foo'))
2224
2328
 
2225
2329
    def test_both_sides_revert(self):
2226
2330
        # Both sides of a criss-cross revert the text to the lca
2233
2337
        # This must be done with a real WorkingTree, because normally their
2234
2338
        # inventory contains "None" rather than a real sha1
2235
2339
        builder = self.get_builder()
2236
 
        builder.build_snapshot('A-id', None,
2237
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2238
 
             ('add', (u'foo', 'foo-id', 'file', 'A content\n'))])
2239
 
        builder.build_snapshot('B-id', ['A-id'],
2240
 
            [('modify', ('foo-id', 'B content\n'))])
2241
 
        builder.build_snapshot('C-id', ['A-id'],
2242
 
            [('modify', ('foo-id', 'C content\n'))])
2243
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'], [])
2244
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2245
 
        wt, conflicts = self.do_merge(builder, 'E-id')
 
2340
        builder.build_snapshot(None,
 
2341
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2342
                                ('add', (u'foo', b'foo-id', 'file', b'A content\n'))],
 
2343
                               revision_id=b'A-id')
 
2344
        builder.build_snapshot([b'A-id'],
 
2345
                               [('modify', ('foo', b'B content\n'))],
 
2346
                               revision_id=b'B-id')
 
2347
        builder.build_snapshot([b'A-id'],
 
2348
                               [('modify', ('foo', b'C content\n'))],
 
2349
                               revision_id=b'C-id')
 
2350
        builder.build_snapshot([b'C-id', b'B-id'], [],
 
2351
                               revision_id=b'E-id')
 
2352
        builder.build_snapshot([b'B-id', b'C-id'], [],
 
2353
                               revision_id=b'D-id')
 
2354
        wt, conflicts = self.do_merge(builder, b'E-id')
2246
2355
        self.assertEqual(1, conflicts)
2247
 
        self.assertEqualDiff('<<<<<<< TREE\n'
2248
 
                             'B content\n'
2249
 
                             '=======\n'
2250
 
                             'C content\n'
2251
 
                             '>>>>>>> MERGE-SOURCE\n',
2252
 
                             wt.get_file_text('foo-id'))
 
2356
        self.assertEqualDiff(b'<<<<<<< TREE\n'
 
2357
                             b'B content\n'
 
2358
                             b'=======\n'
 
2359
                             b'C content\n'
 
2360
                             b'>>>>>>> MERGE-SOURCE\n',
 
2361
                             wt.get_file_text('foo'))
2253
2362
 
2254
2363
    def test_modified_symlink(self):
2255
2364
        self.requireFeature(features.SymlinkFeature)
2272
2381
        wt.lock_write()
2273
2382
        self.addCleanup(wt.unlock)
2274
2383
        os.symlink('bar', 'path/foo')
2275
 
        wt.add(['foo'], ['foo-id'])
2276
 
        wt.commit('add symlink', rev_id='A-id')
 
2384
        wt.add(['foo'], [b'foo-id'])
 
2385
        wt.commit('add symlink', rev_id=b'A-id')
2277
2386
        os.remove('path/foo')
2278
2387
        os.symlink('baz', 'path/foo')
2279
 
        wt.commit('foo => baz', rev_id='B-id')
2280
 
        wt.set_last_revision('A-id')
2281
 
        wt.branch.set_last_revision_info(1, 'A-id')
 
2388
        wt.commit('foo => baz', rev_id=b'B-id')
 
2389
        wt.set_last_revision(b'A-id')
 
2390
        wt.branch.set_last_revision_info(1, b'A-id')
2282
2391
        wt.revert()
2283
 
        wt.commit('C', rev_id='C-id')
2284
 
        wt.merge_from_branch(wt.branch, 'B-id')
2285
 
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
2286
 
        wt.commit('E merges C & B', rev_id='E-id')
 
2392
        wt.commit('C', rev_id=b'C-id')
 
2393
        wt.merge_from_branch(wt.branch, b'B-id')
 
2394
        self.assertEqual('baz', wt.get_symlink_target('foo'))
 
2395
        wt.commit('E merges C & B', rev_id=b'E-id')
2287
2396
        os.remove('path/foo')
2288
2397
        os.symlink('bing', 'path/foo')
2289
 
        wt.commit('F foo => bing', rev_id='F-id')
2290
 
        wt.set_last_revision('B-id')
2291
 
        wt.branch.set_last_revision_info(2, 'B-id')
 
2398
        wt.commit('F foo => bing', rev_id=b'F-id')
 
2399
        wt.set_last_revision(b'B-id')
 
2400
        wt.branch.set_last_revision_info(2, b'B-id')
2292
2401
        wt.revert()
2293
 
        wt.merge_from_branch(wt.branch, 'C-id')
2294
 
        wt.commit('D merges B & C', rev_id='D-id')
2295
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
 
2402
        wt.merge_from_branch(wt.branch, b'C-id')
 
2403
        wt.commit('D merges B & C', rev_id=b'D-id')
 
2404
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
2296
2405
        self.assertEqual(0, conflicts)
2297
 
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
 
2406
        self.assertEqual('bing', wt.get_symlink_target('foo'))
2298
2407
 
2299
2408
    def test_renamed_symlink(self):
2300
2409
        self.requireFeature(features.SymlinkFeature)
2315
2424
        wt.lock_write()
2316
2425
        self.addCleanup(wt.unlock)
2317
2426
        os.symlink('bar', 'path/foo')
2318
 
        wt.add(['foo'], ['foo-id'])
2319
 
        wt.commit('A add symlink', rev_id='A-id')
 
2427
        wt.add(['foo'], [b'foo-id'])
 
2428
        wt.commit('A add symlink', rev_id=b'A-id')
2320
2429
        wt.rename_one('foo', 'barry')
2321
 
        wt.commit('B foo => barry', rev_id='B-id')
2322
 
        wt.set_last_revision('A-id')
2323
 
        wt.branch.set_last_revision_info(1, 'A-id')
 
2430
        wt.commit('B foo => barry', rev_id=b'B-id')
 
2431
        wt.set_last_revision(b'A-id')
 
2432
        wt.branch.set_last_revision_info(1, b'A-id')
2324
2433
        wt.revert()
2325
 
        wt.commit('C', rev_id='C-id')
2326
 
        wt.merge_from_branch(wt.branch, 'B-id')
2327
 
        self.assertEqual('barry', wt.id2path('foo-id'))
2328
 
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
2329
 
        wt.commit('E merges C & B', rev_id='E-id')
 
2434
        wt.commit('C', rev_id=b'C-id')
 
2435
        wt.merge_from_branch(wt.branch, b'B-id')
 
2436
        self.assertEqual('barry', wt.id2path(b'foo-id'))
 
2437
        self.assertEqual('bar', wt.get_symlink_target('barry'))
 
2438
        wt.commit('E merges C & B', rev_id=b'E-id')
2330
2439
        wt.rename_one('barry', 'blah')
2331
 
        wt.commit('F barry => blah', rev_id='F-id')
2332
 
        wt.set_last_revision('B-id')
2333
 
        wt.branch.set_last_revision_info(2, 'B-id')
 
2440
        wt.commit('F barry => blah', rev_id=b'F-id')
 
2441
        wt.set_last_revision(b'B-id')
 
2442
        wt.branch.set_last_revision_info(2, b'B-id')
2334
2443
        wt.revert()
2335
 
        wt.merge_from_branch(wt.branch, 'C-id')
2336
 
        wt.commit('D merges B & C', rev_id='D-id')
2337
 
        self.assertEqual('barry', wt.id2path('foo-id'))
 
2444
        wt.merge_from_branch(wt.branch, b'C-id')
 
2445
        wt.commit('D merges B & C', rev_id=b'D-id')
 
2446
        self.assertEqual('barry', wt.id2path(b'foo-id'))
2338
2447
        # Check the output of the Merger object directly
2339
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2340
 
            wt, 'F-id')
 
2448
        merger = _mod_merge.Merger.from_revision_ids(wt, b'F-id')
2341
2449
        merger.merge_type = _mod_merge.Merge3Merger
2342
2450
        merge_obj = merger.make_merger()
2343
2451
        root_id = wt.path2id('')
2344
2452
        entries = list(merge_obj._entries_lca())
2345
2453
        # No content change, just a path change
2346
 
        self.assertEqual([('foo-id', False,
 
2454
        self.assertEqual([(b'foo-id', False,
 
2455
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
2347
2456
                           ((root_id, [root_id, root_id]), root_id, root_id),
2348
2457
                           ((u'foo', [u'barry', u'foo']), u'blah', u'barry'),
2349
 
                           ((False, [False, False]), False, False)),
2350
 
                         ], entries)
2351
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision='F-id')
 
2458
                           ((False, [False, False]), False, False),
 
2459
                           False),
 
2460
                          ], entries)
 
2461
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'F-id')
2352
2462
        self.assertEqual(0, conflicts)
2353
 
        self.assertEqual('blah', wt.id2path('foo-id'))
 
2463
        self.assertEqual('blah', wt.id2path(b'foo-id'))
2354
2464
 
2355
2465
    def test_symlink_no_content_change(self):
2356
2466
        self.requireFeature(features.SymlinkFeature)
2370
2480
        wt.lock_write()
2371
2481
        self.addCleanup(wt.unlock)
2372
2482
        os.symlink('bar', 'path/foo')
2373
 
        wt.add(['foo'], ['foo-id'])
2374
 
        wt.commit('add symlink', rev_id='A-id')
 
2483
        wt.add(['foo'], [b'foo-id'])
 
2484
        wt.commit('add symlink', rev_id=b'A-id')
2375
2485
        os.remove('path/foo')
2376
2486
        os.symlink('baz', 'path/foo')
2377
 
        wt.commit('foo => baz', rev_id='B-id')
2378
 
        wt.set_last_revision('A-id')
2379
 
        wt.branch.set_last_revision_info(1, 'A-id')
2380
 
        wt.revert()
2381
 
        wt.commit('C', rev_id='C-id')
2382
 
        wt.merge_from_branch(wt.branch, 'B-id')
2383
 
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
2384
 
        wt.commit('E merges C & B', rev_id='E-id')
2385
 
        wt.set_last_revision('B-id')
2386
 
        wt.branch.set_last_revision_info(2, 'B-id')
2387
 
        wt.revert()
2388
 
        wt.merge_from_branch(wt.branch, 'C-id')
2389
 
        wt.commit('D merges B & C', rev_id='D-id')
 
2487
        wt.commit('foo => baz', rev_id=b'B-id')
 
2488
        wt.set_last_revision(b'A-id')
 
2489
        wt.branch.set_last_revision_info(1, b'A-id')
 
2490
        wt.revert()
 
2491
        wt.commit('C', rev_id=b'C-id')
 
2492
        wt.merge_from_branch(wt.branch, b'B-id')
 
2493
        self.assertEqual('baz', wt.get_symlink_target('foo'))
 
2494
        wt.commit('E merges C & B', rev_id=b'E-id')
 
2495
        wt.set_last_revision(b'B-id')
 
2496
        wt.branch.set_last_revision_info(2, b'B-id')
 
2497
        wt.revert()
 
2498
        wt.merge_from_branch(wt.branch, b'C-id')
 
2499
        wt.commit('D merges B & C', rev_id=b'D-id')
2390
2500
        os.remove('path/foo')
2391
2501
        os.symlink('bing', 'path/foo')
2392
 
        wt.commit('F foo => bing', rev_id='F-id')
 
2502
        wt.commit('F foo => bing', rev_id=b'F-id')
2393
2503
 
2394
2504
        # Check the output of the Merger object directly
2395
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2396
 
            wt, 'E-id')
 
2505
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2397
2506
        merger.merge_type = _mod_merge.Merge3Merger
2398
2507
        merge_obj = merger.make_merger()
2399
2508
        # Nothing interesting happened in OTHER relative to BASE
2400
2509
        self.assertEqual([], list(merge_obj._entries_lca()))
2401
2510
        # Now do a real merge, just to test the rest of the stack
2402
 
        conflicts = wt.merge_from_branch(wt.branch, to_revision='E-id')
 
2511
        conflicts = wt.merge_from_branch(wt.branch, to_revision=b'E-id')
2403
2512
        self.assertEqual(0, conflicts)
2404
 
        self.assertEqual('bing', wt.get_symlink_target('foo-id'))
 
2513
        self.assertEqual('bing', wt.get_symlink_target('foo'))
2405
2514
 
2406
2515
    def test_symlink_this_changed_kind(self):
2407
2516
        self.requireFeature(features.SymlinkFeature)
2418
2527
        wt = self.make_branch_and_tree('path')
2419
2528
        wt.lock_write()
2420
2529
        self.addCleanup(wt.unlock)
2421
 
        wt.commit('base', rev_id='A-id')
 
2530
        wt.commit('base', rev_id=b'A-id')
2422
2531
        os.symlink('bar', 'path/foo')
2423
 
        wt.add(['foo'], ['foo-id'])
2424
 
        wt.commit('add symlink foo => bar', rev_id='B-id')
2425
 
        wt.set_last_revision('A-id')
2426
 
        wt.branch.set_last_revision_info(1, 'A-id')
 
2532
        wt.add(['foo'], [b'foo-id'])
 
2533
        wt.commit('add symlink foo => bar', rev_id=b'B-id')
 
2534
        wt.set_last_revision(b'A-id')
 
2535
        wt.branch.set_last_revision_info(1, b'A-id')
2427
2536
        wt.revert()
2428
 
        wt.commit('C', rev_id='C-id')
2429
 
        wt.merge_from_branch(wt.branch, 'B-id')
2430
 
        self.assertEqual('bar', wt.get_symlink_target('foo-id'))
 
2537
        wt.commit('C', rev_id=b'C-id')
 
2538
        wt.merge_from_branch(wt.branch, b'B-id')
 
2539
        self.assertEqual('bar', wt.get_symlink_target('foo'))
2431
2540
        os.remove('path/foo')
2432
2541
        # We have to change the link in E, or it won't try to do a comparison
2433
2542
        os.symlink('bing', 'path/foo')
2434
 
        wt.commit('E merges C & B, overrides to bing', rev_id='E-id')
2435
 
        wt.set_last_revision('B-id')
2436
 
        wt.branch.set_last_revision_info(2, 'B-id')
 
2543
        wt.commit('E merges C & B, overrides to bing', rev_id=b'E-id')
 
2544
        wt.set_last_revision(b'B-id')
 
2545
        wt.branch.set_last_revision_info(2, b'B-id')
2437
2546
        wt.revert()
2438
 
        wt.merge_from_branch(wt.branch, 'C-id')
 
2547
        wt.merge_from_branch(wt.branch, b'C-id')
2439
2548
        os.remove('path/foo')
2440
 
        self.build_tree_contents([('path/foo', 'file content\n')])
 
2549
        self.build_tree_contents([('path/foo', b'file content\n')])
2441
2550
        # XXX: workaround, WT doesn't detect kind changes unless you do
2442
2551
        # iter_changes()
2443
2552
        list(wt.iter_changes(wt.basis_tree()))
2444
 
        wt.commit('D merges B & C, makes it a file', rev_id='D-id')
 
2553
        wt.commit('D merges B & C, makes it a file', rev_id=b'D-id')
2445
2554
 
2446
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2447
 
            wt, 'E-id')
 
2555
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2448
2556
        merger.merge_type = _mod_merge.Merge3Merger
2449
2557
        merge_obj = merger.make_merger()
2450
2558
        entries = list(merge_obj._entries_lca())
2451
2559
        root_id = wt.path2id('')
2452
 
        self.assertEqual([('foo-id', True,
 
2560
        self.assertEqual([(b'foo-id', True,
 
2561
                           ((None, [u'foo', None]), u'foo', u'foo'),
2453
2562
                           ((None, [root_id, None]), root_id, root_id),
2454
2563
                           ((None, [u'foo', None]), u'foo', u'foo'),
2455
 
                           ((None, [False, None]), False, False)),
2456
 
                         ], entries)
 
2564
                           ((None, [False, None]), False, False),
 
2565
                           False),
 
2566
                          ], entries)
2457
2567
 
2458
2568
    def test_symlink_all_wt(self):
2459
2569
        """Check behavior if all trees are Working Trees."""
2474
2584
        wt.lock_write()
2475
2585
        self.addCleanup(wt.unlock)
2476
2586
        os.symlink('bar', 'path/foo')
2477
 
        wt.add(['foo'], ['foo-id'])
2478
 
        wt.commit('add symlink', rev_id='A-id')
 
2587
        wt.add(['foo'], [b'foo-id'])
 
2588
        wt.commit('add symlink', rev_id=b'A-id')
2479
2589
        os.remove('path/foo')
2480
2590
        os.symlink('baz', 'path/foo')
2481
 
        wt.commit('foo => baz', rev_id='B-id')
2482
 
        wt.set_last_revision('A-id')
2483
 
        wt.branch.set_last_revision_info(1, 'A-id')
 
2591
        wt.commit('foo => baz', rev_id=b'B-id')
 
2592
        wt.set_last_revision(b'A-id')
 
2593
        wt.branch.set_last_revision_info(1, b'A-id')
2484
2594
        wt.revert()
2485
 
        wt.commit('C', rev_id='C-id')
2486
 
        wt.merge_from_branch(wt.branch, 'B-id')
2487
 
        self.assertEqual('baz', wt.get_symlink_target('foo-id'))
2488
 
        wt.commit('E merges C & B', rev_id='E-id')
 
2595
        wt.commit('C', rev_id=b'C-id')
 
2596
        wt.merge_from_branch(wt.branch, b'B-id')
 
2597
        self.assertEqual('baz', wt.get_symlink_target('foo'))
 
2598
        wt.commit('E merges C & B', rev_id=b'E-id')
2489
2599
        os.remove('path/foo')
2490
2600
        os.symlink('bing', 'path/foo')
2491
 
        wt.commit('F foo => bing', rev_id='F-id')
2492
 
        wt.set_last_revision('B-id')
2493
 
        wt.branch.set_last_revision_info(2, 'B-id')
 
2601
        wt.commit('F foo => bing', rev_id=b'F-id')
 
2602
        wt.set_last_revision(b'B-id')
 
2603
        wt.branch.set_last_revision_info(2, b'B-id')
2494
2604
        wt.revert()
2495
 
        wt.merge_from_branch(wt.branch, 'C-id')
2496
 
        wt.commit('D merges B & C', rev_id='D-id')
2497
 
        wt_base = wt.bzrdir.sprout('base', 'A-id').open_workingtree()
 
2605
        wt.merge_from_branch(wt.branch, b'C-id')
 
2606
        wt.commit('D merges B & C', rev_id=b'D-id')
 
2607
        wt_base = wt.controldir.sprout('base', b'A-id').open_workingtree()
2498
2608
        wt_base.lock_read()
2499
2609
        self.addCleanup(wt_base.unlock)
2500
 
        wt_lca1 = wt.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
 
2610
        wt_lca1 = wt.controldir.sprout('b-tree', b'B-id').open_workingtree()
2501
2611
        wt_lca1.lock_read()
2502
2612
        self.addCleanup(wt_lca1.unlock)
2503
 
        wt_lca2 = wt.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
 
2613
        wt_lca2 = wt.controldir.sprout('c-tree', b'C-id').open_workingtree()
2504
2614
        wt_lca2.lock_read()
2505
2615
        self.addCleanup(wt_lca2.unlock)
2506
 
        wt_other = wt.bzrdir.sprout('other', 'F-id').open_workingtree()
 
2616
        wt_other = wt.controldir.sprout('other', b'F-id').open_workingtree()
2507
2617
        wt_other.lock_read()
2508
2618
        self.addCleanup(wt_other.unlock)
2509
2619
        merge_obj = _mod_merge.Merge3Merger(wt, wt, wt_base,
2510
 
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2620
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2511
2621
        entries = list(merge_obj._entries_lca())
2512
2622
        root_id = wt.path2id('')
2513
 
        self.assertEqual([('foo-id', True,
 
2623
        self.assertEqual([(b'foo-id', True,
 
2624
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2514
2625
                           ((root_id, [root_id, root_id]), root_id, root_id),
2515
2626
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2516
 
                           ((False, [False, False]), False, False)),
2517
 
                         ], entries)
 
2627
                           ((False, [False, False]), False, False),
 
2628
                           False),
 
2629
                          ], entries)
2518
2630
 
2519
2631
    def test_other_reverted_path_to_base(self):
2520
2632
        #   A       Path at 'foo'
2527
2639
        #     |
2528
2640
        #     F     Path at 'foo'
2529
2641
        builder = self.get_builder()
2530
 
        builder.build_snapshot('A-id', None,
2531
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2532
 
             ('add', (u'foo', 'foo-id', 'file', 'a\nb\nc\n'))])
2533
 
        builder.build_snapshot('C-id', ['A-id'], [])
2534
 
        builder.build_snapshot('B-id', ['A-id'],
2535
 
            [('rename', ('foo', 'bar'))])
2536
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2537
 
            [('rename', ('foo', 'bar'))]) # merge the rename
2538
 
        builder.build_snapshot('F-id', ['E-id'],
2539
 
            [('rename', ('bar', 'foo'))]) # Rename back to BASE
2540
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2541
 
        wt, conflicts = self.do_merge(builder, 'F-id')
 
2642
        builder.build_snapshot(None,
 
2643
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2644
                                ('add', (u'foo', b'foo-id', 'file', b'a\nb\nc\n'))],
 
2645
                               revision_id=b'A-id')
 
2646
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2647
        builder.build_snapshot([b'A-id'],
 
2648
                               [('rename', ('foo', 'bar'))], revision_id=b'B-id')
 
2649
        builder.build_snapshot([b'C-id', b'B-id'],
 
2650
                               [('rename', ('foo', 'bar'))], revision_id=b'E-id')  # merge the rename
 
2651
        builder.build_snapshot([b'E-id'],
 
2652
                               [('rename', ('bar', 'foo'))], revision_id=b'F-id')  # Rename back to BASE
 
2653
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2654
        wt, conflicts = self.do_merge(builder, b'F-id')
2542
2655
        self.assertEqual(0, conflicts)
2543
 
        self.assertEqual('foo', wt.id2path('foo-id'))
 
2656
        self.assertEqual('foo', wt.id2path(b'foo-id'))
2544
2657
 
2545
2658
    def test_other_reverted_content_to_base(self):
2546
2659
        builder = self.get_builder()
2547
 
        builder.build_snapshot('A-id', None,
2548
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2549
 
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
2550
 
        builder.build_snapshot('C-id', ['A-id'], [])
2551
 
        builder.build_snapshot('B-id', ['A-id'],
2552
 
            [('modify', ('foo-id', 'B content\n'))])
2553
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2554
 
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
2555
 
        builder.build_snapshot('F-id', ['E-id'],
2556
 
            [('modify', ('foo-id', 'base content\n'))]) # Revert back to BASE
2557
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2558
 
        wt, conflicts = self.do_merge(builder, 'F-id')
 
2660
        builder.build_snapshot(None,
 
2661
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2662
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
 
2663
                               revision_id=b'A-id')
 
2664
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2665
        builder.build_snapshot([b'A-id'],
 
2666
                               [('modify', ('foo', b'B content\n'))],
 
2667
                               revision_id=b'B-id')
 
2668
        builder.build_snapshot([b'C-id', b'B-id'],
 
2669
                               [('modify', ('foo', b'B content\n'))],
 
2670
                               revision_id=b'E-id')  # merge the content
 
2671
        builder.build_snapshot([b'E-id'],
 
2672
                               [('modify', ('foo', b'base content\n'))],
 
2673
                               revision_id=b'F-id')  # Revert back to BASE
 
2674
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2675
        wt, conflicts = self.do_merge(builder, b'F-id')
2559
2676
        self.assertEqual(0, conflicts)
2560
2677
        # TODO: We need to use the per-file graph to properly select a BASE
2561
2678
        #       before this will work. Or at least use the LCA trees to find
2562
2679
        #       the appropriate content base. (which is B, not A).
2563
 
        self.assertEqual('base content\n', wt.get_file_text('foo-id'))
 
2680
        self.assertEqual(b'base content\n', wt.get_file_text('foo'))
2564
2681
 
2565
2682
    def test_other_modified_content(self):
2566
2683
        builder = self.get_builder()
2567
 
        builder.build_snapshot('A-id', None,
2568
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2569
 
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
2570
 
        builder.build_snapshot('C-id', ['A-id'], [])
2571
 
        builder.build_snapshot('B-id', ['A-id'],
2572
 
            [('modify', ('foo-id', 'B content\n'))])
2573
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2574
 
            [('modify', ('foo-id', 'B content\n'))]) # merge the content
2575
 
        builder.build_snapshot('F-id', ['E-id'],
2576
 
            [('modify', ('foo-id', 'F content\n'))]) # Override B content
2577
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'], [])
2578
 
        wt, conflicts = self.do_merge(builder, 'F-id')
 
2684
        builder.build_snapshot(None,
 
2685
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2686
                                ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
 
2687
                               revision_id=b'A-id')
 
2688
        builder.build_snapshot([b'A-id'], [], revision_id=b'C-id')
 
2689
        builder.build_snapshot([b'A-id'],
 
2690
                               [('modify', ('foo', b'B content\n'))],
 
2691
                               revision_id=b'B-id')
 
2692
        builder.build_snapshot([b'C-id', b'B-id'],
 
2693
                               [('modify', ('foo', b'B content\n'))],
 
2694
                               revision_id=b'E-id')  # merge the content
 
2695
        builder.build_snapshot([b'E-id'],
 
2696
                               [('modify', ('foo', b'F content\n'))],
 
2697
                               revision_id=b'F-id')  # Override B content
 
2698
        builder.build_snapshot([b'B-id', b'C-id'], [], revision_id=b'D-id')
 
2699
        wt, conflicts = self.do_merge(builder, b'F-id')
2579
2700
        self.assertEqual(0, conflicts)
2580
 
        self.assertEqual('F content\n', wt.get_file_text('foo-id'))
 
2701
        self.assertEqual(b'F content\n', wt.get_file_text('foo'))
2581
2702
 
2582
2703
    def test_all_wt(self):
2583
2704
        """Check behavior if all trees are Working Trees."""
2590
2711
        #   |X|
2591
2712
        #   D E E updates content, renames 'b' => 'c'
2592
2713
        builder = self.get_builder()
2593
 
        builder.build_snapshot('A-id', None,
2594
 
            [('add', (u'', 'a-root-id', 'directory', None)),
2595
 
             ('add', (u'a', 'a-id', 'file', 'base content\n')),
2596
 
             ('add', (u'foo', 'foo-id', 'file', 'base content\n'))])
2597
 
        builder.build_snapshot('B-id', ['A-id'],
2598
 
            [('modify', ('foo-id', 'B content\n'))])
2599
 
        builder.build_snapshot('C-id', ['A-id'],
2600
 
            [('rename', ('a', 'b'))])
2601
 
        builder.build_snapshot('E-id', ['C-id', 'B-id'],
2602
 
            [('rename', ('b', 'c')),
2603
 
             ('modify', ('foo-id', 'E content\n'))])
2604
 
        builder.build_snapshot('D-id', ['B-id', 'C-id'],
2605
 
            [('rename', ('a', 'b'))]) # merged change
 
2714
        builder.build_snapshot(None,
 
2715
                               [('add', (u'', b'a-root-id', 'directory', None)),
 
2716
                                ('add', (u'a', b'a-id', 'file', b'base content\n')),
 
2717
                                   ('add', (u'foo', b'foo-id', 'file', b'base content\n'))],
 
2718
                               revision_id=b'A-id')
 
2719
        builder.build_snapshot([b'A-id'],
 
2720
                               [('modify', ('foo', b'B content\n'))],
 
2721
                               revision_id=b'B-id')
 
2722
        builder.build_snapshot([b'A-id'],
 
2723
                               [('rename', ('a', 'b'))],
 
2724
                               revision_id=b'C-id')
 
2725
        builder.build_snapshot([b'C-id', b'B-id'],
 
2726
                               [('rename', ('b', 'c')),
 
2727
                                ('modify', ('foo', b'E content\n'))],
 
2728
                               revision_id=b'E-id')
 
2729
        builder.build_snapshot([b'B-id', b'C-id'],
 
2730
                               [('rename', ('a', 'b'))], revision_id=b'D-id')  # merged change
2606
2731
        wt_this = self.get_wt_from_builder(builder)
2607
 
        wt_base = wt_this.bzrdir.sprout('base', 'A-id').open_workingtree()
 
2732
        wt_base = wt_this.controldir.sprout('base', b'A-id').open_workingtree()
2608
2733
        wt_base.lock_read()
2609
2734
        self.addCleanup(wt_base.unlock)
2610
 
        wt_lca1 = wt_this.bzrdir.sprout('b-tree', 'B-id').open_workingtree()
 
2735
        wt_lca1 = wt_this.controldir.sprout(
 
2736
            'b-tree', b'B-id').open_workingtree()
2611
2737
        wt_lca1.lock_read()
2612
2738
        self.addCleanup(wt_lca1.unlock)
2613
 
        wt_lca2 = wt_this.bzrdir.sprout('c-tree', 'C-id').open_workingtree()
 
2739
        wt_lca2 = wt_this.controldir.sprout(
 
2740
            'c-tree', b'C-id').open_workingtree()
2614
2741
        wt_lca2.lock_read()
2615
2742
        self.addCleanup(wt_lca2.unlock)
2616
 
        wt_other = wt_this.bzrdir.sprout('other', 'E-id').open_workingtree()
 
2743
        wt_other = wt_this.controldir.sprout(
 
2744
            'other', b'E-id').open_workingtree()
2617
2745
        wt_other.lock_read()
2618
2746
        self.addCleanup(wt_other.unlock)
2619
2747
        merge_obj = _mod_merge.Merge3Merger(wt_this, wt_this, wt_base,
2620
 
            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
 
2748
                                            wt_other, lca_trees=[wt_lca1, wt_lca2], do_merge=False)
2621
2749
        entries = list(merge_obj._entries_lca())
2622
 
        root_id = 'a-root-id'
2623
 
        self.assertEqual([('a-id', False,
2624
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2625
 
                           ((u'a', [u'a', u'b']), u'c', u'b'),
2626
 
                           ((False, [False, False]), False, False)),
2627
 
                          ('foo-id', True,
2628
 
                           ((root_id, [root_id, root_id]), root_id, root_id),
2629
 
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
2630
 
                           ((False, [False, False]), False, False)),
2631
 
                         ], entries)
 
2750
        root_id = b'a-root-id'
 
2751
        self.assertEqual([(b'a-id', False,
 
2752
                           ((u'a', [u'a', u'b']), u'c', u'b'),
 
2753
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2754
                           ((u'a', [u'a', u'b']), u'c', u'b'),
 
2755
                           ((False, [False, False]), False, False),
 
2756
                           False),
 
2757
                          (b'foo-id', True,
 
2758
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2759
                           ((root_id, [root_id, root_id]), root_id, root_id),
 
2760
                           ((u'foo', [u'foo', u'foo']), u'foo', u'foo'),
 
2761
                           ((False, [False, False]), False, False),
 
2762
                           False),
 
2763
                          ], entries)
2632
2764
 
2633
2765
    def test_nested_tree_unmodified(self):
2634
2766
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2635
2767
        # 'tree-reference'
2636
2768
        wt = self.make_branch_and_tree('tree',
2637
 
            format='development-subtree')
 
2769
                                       format='development-subtree')
2638
2770
        wt.lock_write()
2639
2771
        self.addCleanup(wt.unlock)
2640
2772
        sub_tree = self.make_branch_and_tree('tree/sub-tree',
2641
 
            format='development-subtree')
2642
 
        wt.set_root_id('a-root-id')
2643
 
        sub_tree.set_root_id('sub-tree-root')
2644
 
        self.build_tree_contents([('tree/sub-tree/file', 'text1')])
 
2773
                                             format='development-subtree')
 
2774
        wt.set_root_id(b'a-root-id')
 
2775
        sub_tree.set_root_id(b'sub-tree-root')
 
2776
        self.build_tree_contents([('tree/sub-tree/file', b'text1')])
2645
2777
        sub_tree.add('file')
2646
 
        sub_tree.commit('foo', rev_id='sub-A-id')
 
2778
        sub_tree.commit('foo', rev_id=b'sub-A-id')
2647
2779
        wt.add_reference(sub_tree)
2648
 
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
 
2780
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
2649
2781
        # Now create a criss-cross merge in the parent, without modifying the
2650
2782
        # subtree
2651
 
        wt.commit('B', rev_id='B-id', recursive=None)
2652
 
        wt.set_last_revision('A-id')
2653
 
        wt.branch.set_last_revision_info(1, 'A-id')
2654
 
        wt.commit('C', rev_id='C-id', recursive=None)
2655
 
        wt.merge_from_branch(wt.branch, to_revision='B-id')
2656
 
        wt.commit('E', rev_id='E-id', recursive=None)
2657
 
        wt.set_parent_ids(['B-id', 'C-id'])
2658
 
        wt.branch.set_last_revision_info(2, 'B-id')
2659
 
        wt.commit('D', rev_id='D-id', recursive=None)
 
2783
        wt.commit('B', rev_id=b'B-id', recursive=None)
 
2784
        wt.set_last_revision(b'A-id')
 
2785
        wt.branch.set_last_revision_info(1, b'A-id')
 
2786
        wt.commit('C', rev_id=b'C-id', recursive=None)
 
2787
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
 
2788
        wt.commit('E', rev_id=b'E-id', recursive=None)
 
2789
        wt.set_parent_ids([b'B-id', b'C-id'])
 
2790
        wt.branch.set_last_revision_info(2, b'B-id')
 
2791
        wt.commit('D', rev_id=b'D-id', recursive=None)
2660
2792
 
2661
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2662
 
            wt, 'E-id')
 
2793
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2663
2794
        merger.merge_type = _mod_merge.Merge3Merger
2664
2795
        merge_obj = merger.make_merger()
2665
2796
        entries = list(merge_obj._entries_lca())
2669
2800
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2670
2801
        # 'tree-reference'
2671
2802
        wt = self.make_branch_and_tree('tree',
2672
 
            format='development-subtree')
 
2803
                                       format='development-subtree')
2673
2804
        wt.lock_write()
2674
2805
        self.addCleanup(wt.unlock)
2675
2806
        sub_tree = self.make_branch_and_tree('tree/sub',
2676
 
            format='development-subtree')
2677
 
        wt.set_root_id('a-root-id')
2678
 
        sub_tree.set_root_id('sub-tree-root')
2679
 
        self.build_tree_contents([('tree/sub/file', 'text1')])
 
2807
                                             format='development-subtree')
 
2808
        wt.set_root_id(b'a-root-id')
 
2809
        sub_tree.set_root_id(b'sub-tree-root')
 
2810
        self.build_tree_contents([('tree/sub/file', b'text1')])
2680
2811
        sub_tree.add('file')
2681
 
        sub_tree.commit('foo', rev_id='sub-A-id')
 
2812
        sub_tree.commit('foo', rev_id=b'sub-A-id')
2682
2813
        wt.add_reference(sub_tree)
2683
 
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
 
2814
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
2684
2815
        # Now create a criss-cross merge in the parent, without modifying the
2685
2816
        # subtree
2686
 
        wt.commit('B', rev_id='B-id', recursive=None)
2687
 
        wt.set_last_revision('A-id')
2688
 
        wt.branch.set_last_revision_info(1, 'A-id')
2689
 
        wt.commit('C', rev_id='C-id', recursive=None)
2690
 
        wt.merge_from_branch(wt.branch, to_revision='B-id')
2691
 
        self.build_tree_contents([('tree/sub/file', 'text2')])
2692
 
        sub_tree.commit('modify contents', rev_id='sub-B-id')
2693
 
        wt.commit('E', rev_id='E-id', recursive=None)
2694
 
        wt.set_parent_ids(['B-id', 'C-id'])
2695
 
        wt.branch.set_last_revision_info(2, 'B-id')
2696
 
        wt.commit('D', rev_id='D-id', recursive=None)
 
2817
        wt.commit('B', rev_id=b'B-id', recursive=None)
 
2818
        wt.set_last_revision(b'A-id')
 
2819
        wt.branch.set_last_revision_info(1, b'A-id')
 
2820
        wt.commit('C', rev_id=b'C-id', recursive=None)
 
2821
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
 
2822
        self.build_tree_contents([('tree/sub/file', b'text2')])
 
2823
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
 
2824
        wt.commit('E', rev_id=b'E-id', recursive=None)
 
2825
        wt.set_parent_ids([b'B-id', b'C-id'])
 
2826
        wt.branch.set_last_revision_info(2, b'B-id')
 
2827
        wt.commit('D', rev_id=b'D-id', recursive=None)
2697
2828
 
2698
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2699
 
            wt, 'E-id')
 
2829
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2700
2830
        merger.merge_type = _mod_merge.Merge3Merger
2701
2831
        merge_obj = merger.make_merger()
2702
2832
        entries = list(merge_obj._entries_lca())
2708
2838
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2709
2839
        # 'tree-reference'
2710
2840
        wt = self.make_branch_and_tree('tree',
2711
 
            format='development-subtree')
 
2841
                                       format='development-subtree')
2712
2842
        wt.lock_write()
2713
2843
        self.addCleanup(wt.unlock)
2714
2844
        sub_tree = self.make_branch_and_tree('tree/sub',
2715
 
            format='development-subtree')
2716
 
        wt.set_root_id('a-root-id')
2717
 
        sub_tree.set_root_id('sub-tree-root')
2718
 
        self.build_tree_contents([('tree/sub/file', 'text1')])
 
2845
                                             format='development-subtree')
 
2846
        wt.set_root_id(b'a-root-id')
 
2847
        sub_tree.set_root_id(b'sub-tree-root')
 
2848
        self.build_tree_contents([('tree/sub/file', b'text1')])
2719
2849
        sub_tree.add('file')
2720
 
        sub_tree.commit('foo', rev_id='sub-A-id')
 
2850
        sub_tree.commit('foo', rev_id=b'sub-A-id')
2721
2851
        wt.add_reference(sub_tree)
2722
 
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
 
2852
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
2723
2853
        # Now create a criss-cross merge in the parent, without modifying the
2724
2854
        # subtree
2725
 
        wt.commit('B', rev_id='B-id', recursive=None)
2726
 
        wt.set_last_revision('A-id')
2727
 
        wt.branch.set_last_revision_info(1, 'A-id')
2728
 
        wt.commit('C', rev_id='C-id', recursive=None)
2729
 
        wt.merge_from_branch(wt.branch, to_revision='B-id')
 
2855
        wt.commit('B', rev_id=b'B-id', recursive=None)
 
2856
        wt.set_last_revision(b'A-id')
 
2857
        wt.branch.set_last_revision_info(1, b'A-id')
 
2858
        wt.commit('C', rev_id=b'C-id', recursive=None)
 
2859
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
2730
2860
        wt.rename_one('sub', 'alt_sub')
2731
 
        wt.commit('E', rev_id='E-id', recursive=None)
2732
 
        wt.set_last_revision('B-id')
 
2861
        wt.commit('E', rev_id=b'E-id', recursive=None)
 
2862
        wt.set_last_revision(b'B-id')
2733
2863
        wt.revert()
2734
 
        wt.set_parent_ids(['B-id', 'C-id'])
2735
 
        wt.branch.set_last_revision_info(2, 'B-id')
2736
 
        wt.commit('D', rev_id='D-id', recursive=None)
 
2864
        wt.set_parent_ids([b'B-id', b'C-id'])
 
2865
        wt.branch.set_last_revision_info(2, b'B-id')
 
2866
        wt.commit('D', rev_id=b'D-id', recursive=None)
2737
2867
 
2738
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2739
 
            wt, 'E-id')
 
2868
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2740
2869
        merger.merge_type = _mod_merge.Merge3Merger
2741
2870
        merge_obj = merger.make_merger()
2742
2871
        entries = list(merge_obj._entries_lca())
2743
 
        root_id = 'a-root-id'
2744
 
        self.assertEqual([('sub-tree-root', False,
 
2872
        root_id = b'a-root-id'
 
2873
        self.assertEqual([(b'sub-tree-root', False,
 
2874
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2745
2875
                           ((root_id, [root_id, root_id]), root_id, root_id),
2746
2876
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2747
 
                           ((False, [False, False]), False, False)),
2748
 
                         ], entries)
 
2877
                           ((False, [False, False]), False, False),
 
2878
                           False),
 
2879
                          ], entries)
2749
2880
 
2750
2881
    def test_nested_tree_subtree_renamed_and_modified(self):
2751
2882
        # Tested with a real WT, because BranchBuilder/MemoryTree don't handle
2752
2883
        # 'tree-reference'
2753
2884
        wt = self.make_branch_and_tree('tree',
2754
 
            format='development-subtree')
 
2885
                                       format='development-subtree')
2755
2886
        wt.lock_write()
2756
2887
        self.addCleanup(wt.unlock)
2757
2888
        sub_tree = self.make_branch_and_tree('tree/sub',
2758
 
            format='development-subtree')
2759
 
        wt.set_root_id('a-root-id')
2760
 
        sub_tree.set_root_id('sub-tree-root')
2761
 
        self.build_tree_contents([('tree/sub/file', 'text1')])
 
2889
                                             format='development-subtree')
 
2890
        wt.set_root_id(b'a-root-id')
 
2891
        sub_tree.set_root_id(b'sub-tree-root')
 
2892
        self.build_tree_contents([('tree/sub/file', b'text1')])
2762
2893
        sub_tree.add('file')
2763
 
        sub_tree.commit('foo', rev_id='sub-A-id')
 
2894
        sub_tree.commit('foo', rev_id=b'sub-A-id')
2764
2895
        wt.add_reference(sub_tree)
2765
 
        wt.commit('set text to 1', rev_id='A-id', recursive=None)
 
2896
        wt.commit('set text to 1', rev_id=b'A-id', recursive=None)
2766
2897
        # Now create a criss-cross merge in the parent, without modifying the
2767
2898
        # subtree
2768
 
        wt.commit('B', rev_id='B-id', recursive=None)
2769
 
        wt.set_last_revision('A-id')
2770
 
        wt.branch.set_last_revision_info(1, 'A-id')
2771
 
        wt.commit('C', rev_id='C-id', recursive=None)
2772
 
        wt.merge_from_branch(wt.branch, to_revision='B-id')
2773
 
        self.build_tree_contents([('tree/sub/file', 'text2')])
2774
 
        sub_tree.commit('modify contents', rev_id='sub-B-id')
 
2899
        wt.commit('B', rev_id=b'B-id', recursive=None)
 
2900
        wt.set_last_revision(b'A-id')
 
2901
        wt.branch.set_last_revision_info(1, b'A-id')
 
2902
        wt.commit('C', rev_id=b'C-id', recursive=None)
 
2903
        wt.merge_from_branch(wt.branch, to_revision=b'B-id')
 
2904
        self.build_tree_contents([('tree/sub/file', b'text2')])
 
2905
        sub_tree.commit('modify contents', rev_id=b'sub-B-id')
2775
2906
        wt.rename_one('sub', 'alt_sub')
2776
 
        wt.commit('E', rev_id='E-id', recursive=None)
2777
 
        wt.set_last_revision('B-id')
 
2907
        wt.commit('E', rev_id=b'E-id', recursive=None)
 
2908
        wt.set_last_revision(b'B-id')
2778
2909
        wt.revert()
2779
 
        wt.set_parent_ids(['B-id', 'C-id'])
2780
 
        wt.branch.set_last_revision_info(2, 'B-id')
2781
 
        wt.commit('D', rev_id='D-id', recursive=None)
 
2910
        wt.set_parent_ids([b'B-id', b'C-id'])
 
2911
        wt.branch.set_last_revision_info(2, b'B-id')
 
2912
        wt.commit('D', rev_id=b'D-id', recursive=None)
2782
2913
 
2783
 
        merger = _mod_merge.Merger.from_revision_ids(None,
2784
 
            wt, 'E-id')
 
2914
        merger = _mod_merge.Merger.from_revision_ids(wt, b'E-id')
2785
2915
        merger.merge_type = _mod_merge.Merge3Merger
2786
2916
        merge_obj = merger.make_merger()
2787
2917
        entries = list(merge_obj._entries_lca())
2788
 
        root_id = 'a-root-id'
2789
 
        self.assertEqual([('sub-tree-root', False,
 
2918
        root_id = b'a-root-id'
 
2919
        self.assertEqual([(b'sub-tree-root', False,
 
2920
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2790
2921
                           ((root_id, [root_id, root_id]), root_id, root_id),
2791
2922
                           ((u'sub', [u'sub', u'sub']), u'alt_sub', u'sub'),
2792
 
                           ((False, [False, False]), False, False)),
2793
 
                         ], entries)
 
2923
                           ((False, [False, False]), False, False),
 
2924
                           False),
 
2925
                          ], entries)
2794
2926
 
2795
2927
 
2796
2928
class TestLCAMultiWay(tests.TestCase):
2798
2930
    def assertLCAMultiWay(self, expected, base, lcas, other, this,
2799
2931
                          allow_overriding_lca=True):
2800
2932
        self.assertEqual(expected, _mod_merge.Merge3Merger._lca_multi_way(
2801
 
                                (base, lcas), other, this,
2802
 
                                allow_overriding_lca=allow_overriding_lca))
 
2933
            (base, lcas), other, this,
 
2934
            allow_overriding_lca=allow_overriding_lca))
2803
2935
 
2804
2936
    def test_other_equal_equal_lcas(self):
2805
2937
        """Test when OTHER=LCA and all LCAs are identical."""
2806
2938
        self.assertLCAMultiWay('this',
2807
 
            'bval', ['bval', 'bval'], 'bval', 'bval')
2808
 
        self.assertLCAMultiWay('this',
2809
 
            'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
2810
 
        self.assertLCAMultiWay('this',
2811
 
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
2812
 
        self.assertLCAMultiWay('this',
2813
 
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
2814
 
        self.assertLCAMultiWay('this',
2815
 
            'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
 
2939
                               'bval', ['bval', 'bval'], 'bval', 'bval')
 
2940
        self.assertLCAMultiWay('this',
 
2941
                               'bval', ['lcaval', 'lcaval'], 'lcaval', 'bval')
 
2942
        self.assertLCAMultiWay('this',
 
2943
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'bval')
 
2944
        self.assertLCAMultiWay('this',
 
2945
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', 'tval')
 
2946
        self.assertLCAMultiWay('this',
 
2947
                               'bval', ['lcaval', 'lcaval', 'lcaval'], 'lcaval', None)
2816
2948
 
2817
2949
    def test_other_equal_this(self):
2818
2950
        """Test when other and this are identical."""
2819
2951
        self.assertLCAMultiWay('this',
2820
 
            'bval', ['bval', 'bval'], 'oval', 'oval')
2821
 
        self.assertLCAMultiWay('this',
2822
 
            'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
2823
 
        self.assertLCAMultiWay('this',
2824
 
            'bval', ['cval', 'dval'], 'oval', 'oval')
2825
 
        self.assertLCAMultiWay('this',
2826
 
            'bval', [None, 'lcaval'], 'oval', 'oval')
2827
 
        self.assertLCAMultiWay('this',
2828
 
            None, [None, 'lcaval'], 'oval', 'oval')
2829
 
        self.assertLCAMultiWay('this',
2830
 
            None, ['lcaval', 'lcaval'], 'oval', 'oval')
2831
 
        self.assertLCAMultiWay('this',
2832
 
            None, ['cval', 'dval'], 'oval', 'oval')
2833
 
        self.assertLCAMultiWay('this',
2834
 
            None, ['cval', 'dval'], None, None)
2835
 
        self.assertLCAMultiWay('this',
2836
 
            None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
 
2952
                               'bval', ['bval', 'bval'], 'oval', 'oval')
 
2953
        self.assertLCAMultiWay('this',
 
2954
                               'bval', ['lcaval', 'lcaval'], 'oval', 'oval')
 
2955
        self.assertLCAMultiWay('this',
 
2956
                               'bval', ['cval', 'dval'], 'oval', 'oval')
 
2957
        self.assertLCAMultiWay('this',
 
2958
                               'bval', [None, 'lcaval'], 'oval', 'oval')
 
2959
        self.assertLCAMultiWay('this',
 
2960
                               None, [None, 'lcaval'], 'oval', 'oval')
 
2961
        self.assertLCAMultiWay('this',
 
2962
                               None, ['lcaval', 'lcaval'], 'oval', 'oval')
 
2963
        self.assertLCAMultiWay('this',
 
2964
                               None, ['cval', 'dval'], 'oval', 'oval')
 
2965
        self.assertLCAMultiWay('this',
 
2966
                               None, ['cval', 'dval'], None, None)
 
2967
        self.assertLCAMultiWay('this',
 
2968
                               None, ['cval', 'dval', 'eval', 'fval'], 'oval', 'oval')
2837
2969
 
2838
2970
    def test_no_lcas(self):
2839
2971
        self.assertLCAMultiWay('this',
2840
 
            'bval', [], 'bval', 'tval')
 
2972
                               'bval', [], 'bval', 'tval')
2841
2973
        self.assertLCAMultiWay('other',
2842
 
            'bval', [], 'oval', 'bval')
 
2974
                               'bval', [], 'oval', 'bval')
2843
2975
        self.assertLCAMultiWay('conflict',
2844
 
            'bval', [], 'oval', 'tval')
 
2976
                               'bval', [], 'oval', 'tval')
2845
2977
        self.assertLCAMultiWay('this',
2846
 
            'bval', [], 'oval', 'oval')
 
2978
                               'bval', [], 'oval', 'oval')
2847
2979
 
2848
2980
    def test_lca_supersedes_other_lca(self):
2849
2981
        """If one lca == base, the other lca takes precedence"""
2850
2982
        self.assertLCAMultiWay('this',
2851
 
            'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
 
2983
                               'bval', ['bval', 'lcaval'], 'lcaval', 'tval')
2852
2984
        self.assertLCAMultiWay('this',
2853
 
            'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
 
2985
                               'bval', ['bval', 'lcaval'], 'lcaval', 'bval')
2854
2986
        # This is actually considered a 'revert' because the 'lcaval' in LCAS
2855
2987
        # supersedes the BASE val (in the other LCA) but then OTHER reverts it
2856
2988
        # back to bval.
2857
2989
        self.assertLCAMultiWay('other',
2858
 
            'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
 
2990
                               'bval', ['bval', 'lcaval'], 'bval', 'lcaval')
2859
2991
        self.assertLCAMultiWay('conflict',
2860
 
            'bval', ['bval', 'lcaval'], 'bval', 'tval')
 
2992
                               'bval', ['bval', 'lcaval'], 'bval', 'tval')
2861
2993
 
2862
2994
    def test_other_and_this_pick_different_lca(self):
2863
2995
        # OTHER and THIS resolve the lca conflict in different ways
2864
2996
        self.assertLCAMultiWay('conflict',
2865
 
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
2866
 
        self.assertLCAMultiWay('conflict',
2867
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
2868
 
        self.assertLCAMultiWay('conflict',
2869
 
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
 
2997
                               'bval', ['lca1val', 'lca2val'], 'lca1val', 'lca2val')
 
2998
        self.assertLCAMultiWay('conflict',
 
2999
                               'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'lca2val')
 
3000
        self.assertLCAMultiWay('conflict',
 
3001
                               'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'lca2val')
2870
3002
 
2871
3003
    def test_other_in_lca(self):
2872
3004
        # OTHER takes a value of one of the LCAs, THIS takes a new value, which
2873
3005
        # theoretically supersedes both LCA values and 'wins'
2874
 
        self.assertLCAMultiWay('this',
2875
 
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
2876
 
        self.assertLCAMultiWay('this',
2877
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval')
2878
 
        self.assertLCAMultiWay('conflict',
2879
 
            'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval',
2880
 
            allow_overriding_lca=False)
2881
 
        self.assertLCAMultiWay('conflict',
2882
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'newval',
2883
 
            allow_overriding_lca=False)
 
3006
        self.assertLCAMultiWay(
 
3007
            'this', 'bval', ['lca1val', 'lca2val'], 'lca1val', 'newval')
 
3008
        self.assertLCAMultiWay(
 
3009
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
 
3010
            'newval')
 
3011
        self.assertLCAMultiWay('conflict',
 
3012
                               'bval', ['lca1val',
 
3013
                                        'lca2val'], 'lca1val', 'newval',
 
3014
                               allow_overriding_lca=False)
 
3015
        self.assertLCAMultiWay('conflict',
 
3016
                               'bval', ['lca1val', 'lca2val',
 
3017
                                        'lca3val'], 'lca1val', 'newval',
 
3018
                               allow_overriding_lca=False)
2884
3019
        # THIS reverted back to BASE, but that is an explicit supersede of all
2885
3020
        # LCAs
2886
 
        self.assertLCAMultiWay('this',
2887
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval')
2888
 
        self.assertLCAMultiWay('this',
2889
 
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
2890
 
        self.assertLCAMultiWay('conflict',
2891
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val', 'bval',
2892
 
            allow_overriding_lca=False)
2893
 
        self.assertLCAMultiWay('conflict',
2894
 
            'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval',
2895
 
            allow_overriding_lca=False)
 
3021
        self.assertLCAMultiWay(
 
3022
            'this', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'lca1val',
 
3023
            'bval')
 
3024
        self.assertLCAMultiWay(
 
3025
            'this', 'bval', ['lca1val', 'lca2val', 'bval'], 'lca1val', 'bval')
 
3026
        self.assertLCAMultiWay('conflict',
 
3027
                               'bval', ['lca1val', 'lca2val',
 
3028
                                        'lca3val'], 'lca1val', 'bval',
 
3029
                               allow_overriding_lca=False)
 
3030
        self.assertLCAMultiWay('conflict',
 
3031
                               'bval', ['lca1val', 'lca2val',
 
3032
                                        'bval'], 'lca1val', 'bval',
 
3033
                               allow_overriding_lca=False)
2896
3034
 
2897
3035
    def test_this_in_lca(self):
2898
3036
        # THIS takes a value of one of the LCAs, OTHER takes a new value, which
2899
3037
        # theoretically supersedes both LCA values and 'wins'
2900
 
        self.assertLCAMultiWay('other',
2901
 
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
2902
 
        self.assertLCAMultiWay('other',
2903
 
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
2904
 
        self.assertLCAMultiWay('conflict',
2905
 
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val',
2906
 
            allow_overriding_lca=False)
2907
 
        self.assertLCAMultiWay('conflict',
2908
 
            'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val',
2909
 
            allow_overriding_lca=False)
 
3038
        self.assertLCAMultiWay(
 
3039
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca1val')
 
3040
        self.assertLCAMultiWay(
 
3041
            'other', 'bval', ['lca1val', 'lca2val'], 'oval', 'lca2val')
 
3042
        self.assertLCAMultiWay('conflict',
 
3043
                               'bval', ['lca1val',
 
3044
                                        'lca2val'], 'oval', 'lca1val',
 
3045
                               allow_overriding_lca=False)
 
3046
        self.assertLCAMultiWay('conflict',
 
3047
                               'bval', ['lca1val',
 
3048
                                        'lca2val'], 'oval', 'lca2val',
 
3049
                               allow_overriding_lca=False)
2910
3050
        # OTHER reverted back to BASE, but that is an explicit supersede of all
2911
3051
        # LCAs
2912
 
        self.assertLCAMultiWay('other',
2913
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val')
2914
 
        self.assertLCAMultiWay('conflict',
2915
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval', 'lca3val',
2916
 
            allow_overriding_lca=False)
 
3052
        self.assertLCAMultiWay(
 
3053
            'other', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'bval',
 
3054
            'lca3val')
 
3055
        self.assertLCAMultiWay(
 
3056
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'],
 
3057
            'bval', 'lca3val', allow_overriding_lca=False)
2917
3058
 
2918
3059
    def test_all_differ(self):
2919
 
        self.assertLCAMultiWay('conflict',
2920
 
            'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
2921
 
        self.assertLCAMultiWay('conflict',
2922
 
            'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval', 'tval')
2923
 
        self.assertLCAMultiWay('conflict',
2924
 
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval', 'tval')
 
3060
        self.assertLCAMultiWay(
 
3061
            'conflict', 'bval', ['lca1val', 'lca2val'], 'oval', 'tval')
 
3062
        self.assertLCAMultiWay(
 
3063
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval',
 
3064
            'tval')
 
3065
        self.assertLCAMultiWay(
 
3066
            'conflict', 'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval',
 
3067
            'tval')
2925
3068
 
2926
3069
 
2927
3070
class TestConfigurableFileMerger(tests.TestCaseWithTransport):
2965
3108
        factory = self.get_merger_factory()
2966
3109
        self._install_hook(factory)
2967
3110
        builder = self.make_builder()
2968
 
        builder.add_file('bar-id', builder.tree_root, file_name, 'text1', True)
2969
 
        builder.change_contents('bar-id', other='text4', this='text3')
 
3111
        builder.add_file(b'bar-id', builder.tree_root,
 
3112
                         file_name, b'text1', True)
 
3113
        builder.change_contents(b'bar-id', other=b'text4', this=b'text3')
2970
3114
        return builder
2971
3115
 
2972
3116
    def make_kind_change(self):
2973
3117
        factory = self.get_merger_factory()
2974
3118
        self._install_hook(factory)
2975
3119
        builder = self.make_builder()
2976
 
        builder.add_file('bar-id', builder.tree_root, 'bar', 'text1', True,
 
3120
        builder.add_file(b'bar-id', builder.tree_root, 'bar', b'text1', True,
2977
3121
                         this=False)
2978
 
        builder.add_dir('bar-dir', builder.tree_root, 'bar-id',
 
3122
        builder.add_dir(b'bar-dir', builder.tree_root, 'bar-id',
2979
3123
                        base=False, other=False)
2980
3124
        return builder
2981
3125
 
2982
3126
    def test_uses_this_branch(self):
2983
3127
        builder = self.make_text_conflict()
2984
 
        tt = builder.make_preview_transform()
2985
 
        self.addCleanup(tt.finalize)
 
3128
        with builder.make_preview_transform() as tt:
 
3129
            pass
2986
3130
 
2987
3131
    def test_affected_files_cached(self):
2988
3132
        """Ensures that the config variable is cached"""
2994
3138
 
2995
3139
    def test_hook_called_for_text_conflicts(self):
2996
3140
        builder = self.make_text_conflict()
2997
 
        conflicts = builder.merge()
 
3141
        builder.merge()
2998
3142
        # The hook should call the merge_text() method
2999
3143
        self.assertEqual(['merge_text'], self.calls)
3000
3144
 
3001
3145
    def test_hook_not_called_for_kind_change(self):
3002
3146
        builder = self.make_kind_change()
3003
 
        conflicts = builder.merge()
 
3147
        builder.merge()
3004
3148
        # The hook should not call the merge_text() method
3005
3149
        self.assertEqual([], self.calls)
3006
3150
 
3007
3151
    def test_hook_not_called_for_other_files(self):
3008
3152
        builder = self.make_text_conflict('foobar')
3009
 
        conflicts = builder.merge()
 
3153
        builder.merge()
3010
3154
        # The hook should not call the merge_text() method
3011
3155
        self.assertEqual([], self.calls)
3012
3156
 
3015
3159
 
3016
3160
    def setup_simple_branch(self, relpath, shape=None, root_id=None):
3017
3161
        """One commit, containing tree specified by optional shape.
3018
 
        
 
3162
 
3019
3163
        Default is empty tree (just root entry).
3020
3164
        """
3021
3165
        if root_id is None:
3022
 
            root_id = '%s-root-id' % (relpath,)
 
3166
            root_id = b'%s-root-id' % (relpath.encode('ascii'),)
3023
3167
        wt = self.make_branch_and_tree(relpath)
3024
3168
        wt.set_root_id(root_id)
3025
3169
        if shape is not None:
3026
3170
            adjusted_shape = [relpath + '/' + elem for elem in shape]
3027
3171
            self.build_tree(adjusted_shape)
3028
 
            ids = ['%s-%s-id' % (relpath, basename(elem.rstrip('/')))
3029
 
                   for elem in shape]
 
3172
            ids = [
 
3173
                (b'%s-%s-id' % (relpath.encode('utf-8'),
 
3174
                                basename(elem.rstrip('/')).encode('ascii')))
 
3175
                for elem in shape]
3030
3176
            wt.add(shape, ids=ids)
3031
 
        rev_id = 'r1-%s' % (relpath,)
 
3177
        rev_id = b'r1-%s' % (relpath.encode('utf-8'),)
3032
3178
        wt.commit("Initial commit of %s" % (relpath,), rev_id=rev_id)
3033
3179
        self.assertEqual(root_id, wt.path2id(''))
3034
3180
        return wt
3049
3195
 
3050
3196
    def do_merge_into(self, location, merge_as):
3051
3197
        """Helper for using MergeIntoMerger.
3052
 
        
 
3198
 
3053
3199
        :param location: location of directory to merge from, either the
3054
3200
            location of a branch or of a path inside a branch.
3055
3201
        :param merge_as: the path in a tree to add the new directory as.
3056
3202
        :returns: the conflicts from 'do_merge'.
3057
3203
        """
3058
 
        operation = cleanup.OperationWithCleanups(self._merge_into)
3059
 
        return operation.run(location, merge_as)
3060
 
 
3061
 
    def _merge_into(self, op, location, merge_as):
3062
 
        # Open and lock the various tree and branch objects
3063
 
        wt, subdir_relpath = WorkingTree.open_containing(merge_as)
3064
 
        op.add_cleanup(wt.lock_write().unlock)
3065
 
        branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
3066
 
            location)
3067
 
        op.add_cleanup(branch_to_merge.lock_read().unlock)
3068
 
        other_tree = branch_to_merge.basis_tree()
3069
 
        op.add_cleanup(other_tree.lock_read().unlock)
3070
 
        # Perform the merge
3071
 
        merger = _mod_merge.MergeIntoMerger(this_tree=wt, other_tree=other_tree,
3072
 
            other_branch=branch_to_merge, target_subdir=subdir_relpath,
3073
 
            source_subpath=subdir_to_merge)
3074
 
        merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
3075
 
        conflicts = merger.do_merge()
3076
 
        merger.set_pending()
3077
 
        return conflicts
 
3204
        with contextlib.ExitStack() as stack:
 
3205
            # Open and lock the various tree and branch objects
 
3206
            wt, subdir_relpath = WorkingTree.open_containing(merge_as)
 
3207
            stack.enter_context(wt.lock_write())
 
3208
            branch_to_merge, subdir_to_merge = _mod_branch.Branch.open_containing(
 
3209
                location)
 
3210
            stack.enter_context(branch_to_merge.lock_read())
 
3211
            other_tree = branch_to_merge.basis_tree()
 
3212
            stack.enter_context(other_tree.lock_read())
 
3213
            # Perform the merge
 
3214
            merger = _mod_merge.MergeIntoMerger(
 
3215
                this_tree=wt, other_tree=other_tree, other_branch=branch_to_merge,
 
3216
                target_subdir=subdir_relpath, source_subpath=subdir_to_merge)
 
3217
            merger.set_base_revision(_mod_revision.NULL_REVISION, branch_to_merge)
 
3218
            conflicts = merger.do_merge()
 
3219
            merger.set_pending()
 
3220
            return conflicts
3078
3221
 
3079
3222
    def assertTreeEntriesEqual(self, expected_entries, tree):
3080
3223
        """Assert that 'tree' contains the expected inventory entries.
3094
3237
        project_wt.lock_read()
3095
3238
        self.addCleanup(project_wt.unlock)
3096
3239
        # The r1-lib1 revision should be merged into this one
3097
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
 
3240
        self.assertEqual([b'r1-project', b'r1-lib1'],
 
3241
                         project_wt.get_parent_ids())
3098
3242
        self.assertTreeEntriesEqual(
3099
 
            [('', 'project-root-id'),
3100
 
             ('README', 'project-README-id'),
3101
 
             ('dir', 'project-dir-id'),
3102
 
             ('lib1', 'lib1-root-id'),
3103
 
             ('dir/file.c', 'project-file.c-id'),
3104
 
             ('lib1/Makefile', 'lib1-Makefile-id'),
3105
 
             ('lib1/README', 'lib1-README-id'),
3106
 
             ('lib1/foo.c', 'lib1-foo.c-id'),
3107
 
            ], project_wt)
 
3243
            [('', b'project-root-id'),
 
3244
             ('README', b'project-README-id'),
 
3245
             ('dir', b'project-dir-id'),
 
3246
             ('lib1', b'lib1-root-id'),
 
3247
             ('dir/file.c', b'project-file.c-id'),
 
3248
             ('lib1/Makefile', b'lib1-Makefile-id'),
 
3249
             ('lib1/README', b'lib1-README-id'),
 
3250
             ('lib1/foo.c', b'lib1-foo.c-id'),
 
3251
             ], project_wt)
3108
3252
 
3109
3253
    def test_subdir(self):
3110
3254
        """Merge a branch into a subdirectory of an existing directory."""
3113
3257
        project_wt.lock_read()
3114
3258
        self.addCleanup(project_wt.unlock)
3115
3259
        # The r1-lib1 revision should be merged into this one
3116
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
 
3260
        self.assertEqual([b'r1-project', b'r1-lib1'],
 
3261
                         project_wt.get_parent_ids())
3117
3262
        self.assertTreeEntriesEqual(
3118
 
            [('', 'project-root-id'),
3119
 
             ('README', 'project-README-id'),
3120
 
             ('dir', 'project-dir-id'),
3121
 
             ('dir/file.c', 'project-file.c-id'),
3122
 
             ('dir/lib1', 'lib1-root-id'),
3123
 
             ('dir/lib1/Makefile', 'lib1-Makefile-id'),
3124
 
             ('dir/lib1/README', 'lib1-README-id'),
3125
 
             ('dir/lib1/foo.c', 'lib1-foo.c-id'),
3126
 
            ], project_wt)
 
3263
            [('', b'project-root-id'),
 
3264
             ('README', b'project-README-id'),
 
3265
             ('dir', b'project-dir-id'),
 
3266
             ('dir/file.c', b'project-file.c-id'),
 
3267
             ('dir/lib1', b'lib1-root-id'),
 
3268
             ('dir/lib1/Makefile', b'lib1-Makefile-id'),
 
3269
             ('dir/lib1/README', b'lib1-README-id'),
 
3270
             ('dir/lib1/foo.c', b'lib1-foo.c-id'),
 
3271
             ], project_wt)
3127
3272
 
3128
3273
    def test_newdir_with_repeat_roots(self):
3129
3274
        """If the file-id of the dir to be merged already exists a new ID will
3135
3280
        project_wt.lock_read()
3136
3281
        self.addCleanup(project_wt.unlock)
3137
3282
        # The r1-lib1 revision should be merged into this one
3138
 
        self.assertEqual(['r1-project', 'r1-lib1'], project_wt.get_parent_ids())
 
3283
        self.assertEqual([b'r1-project', b'r1-lib1'],
 
3284
                         project_wt.get_parent_ids())
3139
3285
        new_lib1_id = project_wt.path2id('lib1')
3140
3286
        self.assertNotEqual(None, new_lib1_id)
3141
3287
        self.assertTreeEntriesEqual(
3142
3288
            [('', root_id),
3143
 
             ('README', 'project-README-id'),
3144
 
             ('dir', 'project-dir-id'),
 
3289
             ('README', b'project-README-id'),
 
3290
             ('dir', b'project-dir-id'),
3145
3291
             ('lib1', new_lib1_id),
3146
 
             ('dir/file.c', 'project-file.c-id'),
3147
 
             ('lib1/Makefile', 'lib1-Makefile-id'),
3148
 
             ('lib1/README', 'lib1-README-id'),
3149
 
             ('lib1/foo.c', 'lib1-foo.c-id'),
3150
 
            ], project_wt)
 
3292
             ('dir/file.c', b'project-file.c-id'),
 
3293
             ('lib1/Makefile', b'lib1-Makefile-id'),
 
3294
             ('lib1/README', b'lib1-README-id'),
 
3295
             ('lib1/foo.c', b'lib1-foo.c-id'),
 
3296
             ], project_wt)
3151
3297
 
3152
3298
    def test_name_conflict(self):
3153
3299
        """When the target directory name already exists a conflict is
3154
3300
        generated and the original directory is renamed to foo.moved.
3155
3301
        """
3156
3302
        dest_wt = self.setup_simple_branch('dest', ['dir/', 'dir/file.txt'])
3157
 
        src_wt = self.setup_simple_branch('src', ['README'])
 
3303
        self.setup_simple_branch('src', ['README'])
3158
3304
        conflicts = self.do_merge_into('src', 'dest/dir')
3159
3305
        self.assertEqual(1, conflicts)
3160
3306
        dest_wt.lock_read()
3161
3307
        self.addCleanup(dest_wt.unlock)
3162
3308
        # The r1-lib1 revision should be merged into this one
3163
 
        self.assertEqual(['r1-dest', 'r1-src'], dest_wt.get_parent_ids())
 
3309
        self.assertEqual([b'r1-dest', b'r1-src'], dest_wt.get_parent_ids())
3164
3310
        self.assertTreeEntriesEqual(
3165
 
            [('', 'dest-root-id'),
3166
 
             ('dir', 'src-root-id'),
3167
 
             ('dir.moved', 'dest-dir-id'),
3168
 
             ('dir/README', 'src-README-id'),
3169
 
             ('dir.moved/file.txt', 'dest-file.txt-id'),
3170
 
            ], dest_wt)
 
3311
            [('', b'dest-root-id'),
 
3312
             ('dir', b'src-root-id'),
 
3313
             ('dir.moved', b'dest-dir-id'),
 
3314
             ('dir/README', b'src-README-id'),
 
3315
             ('dir.moved/file.txt', b'dest-file.txt-id'),
 
3316
             ], dest_wt)
3171
3317
 
3172
3318
    def test_file_id_conflict(self):
3173
3319
        """A conflict is generated if the merge-into adds a file (or other
3174
3320
        inventory entry) with a file-id that already exists in the target tree.
3175
3321
        """
3176
 
        dest_wt = self.setup_simple_branch('dest', ['file.txt'])
 
3322
        self.setup_simple_branch('dest', ['file.txt'])
3177
3323
        # Make a second tree with a file-id that will clash with file.txt in
3178
3324
        # dest.
3179
3325
        src_wt = self.make_branch_and_tree('src')
3180
3326
        self.build_tree(['src/README'])
3181
 
        src_wt.add(['README'], ids=['dest-file.txt-id'])
3182
 
        src_wt.commit("Rev 1 of src.", rev_id='r1-src')
 
3327
        src_wt.add(['README'], ids=[b'dest-file.txt-id'])
 
3328
        src_wt.commit("Rev 1 of src.", rev_id=b'r1-src')
3183
3329
        conflicts = self.do_merge_into('src', 'dest/dir')
3184
3330
        # This is an edge case that shouldn't happen to users very often.  So
3185
3331
        # we don't care really about the exact presentation of the conflict,
3191
3337
        subtree.
3192
3338
        """
3193
3339
        dest_wt = self.setup_simple_branch('dest')
3194
 
        src_wt = self.setup_simple_branch(
3195
 
            'src', ['hello.txt', 'dir/', 'dir/foo.c'])
3196
 
        conflicts = self.do_merge_into('src/dir', 'dest/dir')
 
3340
        self.setup_simple_branch('src', ['hello.txt', 'dir/', 'dir/foo.c'])
 
3341
        self.do_merge_into('src/dir', 'dest/dir')
3197
3342
        dest_wt.lock_read()
3198
3343
        self.addCleanup(dest_wt.unlock)
3199
3344
        # The r1-lib1 revision should NOT be merged into this one (this is a
3200
3345
        # partial merge).
3201
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
 
3346
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3202
3347
        self.assertTreeEntriesEqual(
3203
 
            [('', 'dest-root-id'),
3204
 
             ('dir', 'src-dir-id'),
3205
 
             ('dir/foo.c', 'src-foo.c-id'),
3206
 
            ], dest_wt)
 
3348
            [('', b'dest-root-id'),
 
3349
             ('dir', b'src-dir-id'),
 
3350
             ('dir/foo.c', b'src-foo.c-id'),
 
3351
             ], dest_wt)
3207
3352
 
3208
3353
    def test_only_file(self):
3209
3354
        """An edge case: merge just one file, not a whole dir."""
3210
3355
        dest_wt = self.setup_simple_branch('dest')
3211
 
        two_file_wt = self.setup_simple_branch(
3212
 
            'two-file', ['file1.txt', 'file2.txt'])
3213
 
        conflicts = self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
 
3356
        self.setup_simple_branch('two-file', ['file1.txt', 'file2.txt'])
 
3357
        self.do_merge_into('two-file/file1.txt', 'dest/file1.txt')
3214
3358
        dest_wt.lock_read()
3215
3359
        self.addCleanup(dest_wt.unlock)
3216
3360
        # The r1-lib1 revision should NOT be merged into this one
3217
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
 
3361
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
3218
3362
        self.assertTreeEntriesEqual(
3219
 
            [('', 'dest-root-id'), ('file1.txt', 'two-file-file1.txt-id')],
 
3363
            [('', b'dest-root-id'), ('file1.txt', b'two-file-file1.txt-id')],
3220
3364
            dest_wt)
3221
3365
 
3222
3366
    def test_no_such_source_path(self):
3224
3368
        does not exist.
3225
3369
        """
3226
3370
        dest_wt = self.setup_simple_branch('dest')
3227
 
        two_file_wt = self.setup_simple_branch('src', ['dir/'])
 
3371
        self.setup_simple_branch('src', ['dir/'])
3228
3372
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3229
 
            'src/no-such-dir', 'dest/foo')
 
3373
                          'src/no-such-dir', 'dest/foo')
3230
3374
        dest_wt.lock_read()
3231
3375
        self.addCleanup(dest_wt.unlock)
3232
3376
        # The dest tree is unmodified.
3233
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3234
 
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
 
3377
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
 
3378
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
3235
3379
 
3236
3380
    def test_no_such_target_path(self):
3237
3381
        """PathNotInTree is also raised if the specified path in the target
3238
3382
        tree does not exist.
3239
3383
        """
3240
3384
        dest_wt = self.setup_simple_branch('dest')
3241
 
        two_file_wt = self.setup_simple_branch('src', ['file.txt'])
 
3385
        self.setup_simple_branch('src', ['file.txt'])
3242
3386
        self.assertRaises(_mod_merge.PathNotInTree, self.do_merge_into,
3243
 
            'src', 'dest/no-such-dir/foo')
 
3387
                          'src', 'dest/no-such-dir/foo')
3244
3388
        dest_wt.lock_read()
3245
3389
        self.addCleanup(dest_wt.unlock)
3246
3390
        # The dest tree is unmodified.
3247
 
        self.assertEqual(['r1-dest'], dest_wt.get_parent_ids())
3248
 
        self.assertTreeEntriesEqual([('', 'dest-root-id')], dest_wt)
 
3391
        self.assertEqual([b'r1-dest'], dest_wt.get_parent_ids())
 
3392
        self.assertTreeEntriesEqual([('', b'dest-root-id')], dest_wt)
3249
3393
 
3250
3394
 
3251
3395
class TestMergeHooks(TestCaseWithTransport):
3253
3397
    def setUp(self):
3254
3398
        super(TestMergeHooks, self).setUp()
3255
3399
        self.tree_a = self.make_branch_and_tree('tree_a')
3256
 
        self.build_tree_contents([('tree_a/file', 'content_1')])
3257
 
        self.tree_a.add('file', 'file-id')
 
3400
        self.build_tree_contents([('tree_a/file', b'content_1')])
 
3401
        self.tree_a.add('file', b'file-id')
3258
3402
        self.tree_a.commit('added file')
3259
3403
 
3260
 
        self.tree_b = self.tree_a.bzrdir.sprout('tree_b').open_workingtree()
3261
 
        self.build_tree_contents([('tree_b/file', 'content_2')])
 
3404
        self.tree_b = self.tree_a.controldir.sprout(
 
3405
            'tree_b').open_workingtree()
 
3406
        self.build_tree_contents([('tree_b/file', b'content_2')])
3262
3407
        self.tree_b.commit('modify file')
3263
3408
 
3264
3409
    def test_pre_merge_hook_inject_different_tree(self):
3265
 
        tree_c = self.tree_b.bzrdir.sprout('tree_c').open_workingtree()
3266
 
        self.build_tree_contents([('tree_c/file', 'content_3')])
 
3410
        tree_c = self.tree_b.controldir.sprout('tree_c').open_workingtree()
 
3411
        self.build_tree_contents([('tree_c/file', b'content_3')])
3267
3412
        tree_c.commit("more content")
3268
3413
        calls = []
 
3414
 
3269
3415
        def factory(merger):
3270
3416
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3271
3417
            merger.other_tree = tree_c
3274
3420
                                                   factory, 'test factory')
3275
3421
        self.tree_a.merge_from_branch(self.tree_b.branch)
3276
3422
 
3277
 
        self.assertFileEqual("content_3", 'tree_a/file')
 
3423
        self.assertFileEqual(b"content_3", 'tree_a/file')
3278
3424
        self.assertLength(1, calls)
3279
3425
 
3280
3426
    def test_post_merge_hook_called(self):
3281
3427
        calls = []
 
3428
 
3282
3429
        def factory(merger):
3283
3430
            self.assertIsInstance(merger, _mod_merge.Merge3Merger)
3284
3431
            calls.append(merger)
3287
3434
 
3288
3435
        self.tree_a.merge_from_branch(self.tree_b.branch)
3289
3436
 
3290
 
        self.assertFileEqual("content_2", 'tree_a/file')
 
3437
        self.assertFileEqual(b"content_2", 'tree_a/file')
3291
3438
        self.assertLength(1, calls)