24
24
from bzrlib.tests import TestCase, TestCaseWithTransport
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
27
31
class TestErrors(TestCaseWithTransport):
29
33
def test_inventory_modified(self):
33
37
"read without data loss.",
40
def test_install_failed(self):
41
error = errors.InstallFailed(['rev-one'])
42
self.assertEqual("Could not install revisions:\nrev-one", str(error))
43
error = errors.InstallFailed(['rev-one', 'rev-two'])
44
self.assertEqual("Could not install revisions:\nrev-one, rev-two",
46
error = errors.InstallFailed([None])
47
self.assertEqual("Could not install revisions:\nNone", str(error))
36
49
def test_medium_not_connected(self):
37
50
error = errors.MediumNotConnected("a medium")
38
51
self.assertEqualDiff(
84
97
repo.bzrdir.root_transport.base,
100
def test_bzrnewerror_is_deprecated(self):
101
class DeprecatedError(errors.BzrNewError):
103
self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
104
'please convert DeprecatedError to use BzrError instead'],
107
def test_bzrerror_from_literal_string(self):
108
# Some code constructs BzrError from a literal string, in which case
109
# no further formatting is done. (I'm not sure raising the base class
110
# is a great idea, but if the exception is not intended to be caught
111
# perhaps no more is needed.)
113
raise errors.BzrError('this is my errors; %d is not expanded')
114
except errors.BzrError, e:
115
self.assertEqual('this is my errors; %d is not expanded', str(e))
87
117
def test_reading_completed(self):
88
118
error = errors.ReadingCompleted("a request")
89
119
self.assertEqualDiff("The MediumRequest 'a request' has already had "
105
135
" no data may be read.",
109
class PassThroughError(errors.BzrNewError):
110
"""Pass through %(foo)s and %(bar)s"""
112
def __init__(self, foo, bar):
113
errors.BzrNewError.__init__(self, foo=foo, bar=bar)
116
class ErrorWithBadFormat(errors.BzrNewError):
117
"""One format specifier: %(thing)s"""
120
class TestErrorFormatting(TestCase):
122
def test_always_str(self):
123
e = PassThroughError(u'\xb5', 'bar')
124
self.assertIsInstance(e.__str__(), str)
125
# In Python str(foo) *must* return a real byte string
126
# not a Unicode string. The following line would raise a
127
# Unicode error, because it tries to call str() on the string
128
# returned from e.__str__(), and it has non ascii characters
130
self.assertEqual('Pass through \xc2\xb5 and bar', s)
132
def test_mismatched_format_args(self):
133
# Even though ErrorWithBadFormat's format string does not match the
134
# arguments we constructing it with, we can still stringify an instance
135
# of this exception. The resulting string will say its unprintable.
136
e = ErrorWithBadFormat(not_thing='x')
137
self.assertStartsWith(
138
str(e), 'Unprintable exception ErrorWithBadFormat(')
141
class TestSpecificErrors(TestCase):
143
138
def test_transport_not_possible(self):
144
139
e = errors.TransportNotPossible('readonly', 'original error')
145
140
self.assertEqual('Transport operation not possible:'
189
184
orig_error='my_error')
188
class PassThroughError(errors.BzrError):
190
_fmt = """Pass through %(foo)s and %(bar)s"""
192
def __init__(self, foo, bar):
193
errors.BzrError.__init__(self, foo=foo, bar=bar)
196
class ErrorWithBadFormat(errors.BzrError):
198
_fmt = """One format specifier: %(thing)s"""
201
class ErrorWithNoFormat(errors.BzrError):
202
"""This class has a docstring but no format string."""
205
class TestErrorFormatting(TestCase):
207
def test_always_str(self):
208
e = PassThroughError(u'\xb5', 'bar')
209
self.assertIsInstance(e.__str__(), str)
210
# In Python str(foo) *must* return a real byte string
211
# not a Unicode string. The following line would raise a
212
# Unicode error, because it tries to call str() on the string
213
# returned from e.__str__(), and it has non ascii characters
215
self.assertEqual('Pass through \xc2\xb5 and bar', s)
217
def test_missing_format_string(self):
218
e = ErrorWithNoFormat(param='randomvalue')
219
s = self.callDeprecated(
220
['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
224
"This class has a docstring but no format string.")
226
def test_mismatched_format_args(self):
227
# Even though ErrorWithBadFormat's format string does not match the
228
# arguments we constructing it with, we can still stringify an instance
229
# of this exception. The resulting string will say its unprintable.
230
e = ErrorWithBadFormat(not_thing='x')
231
self.assertStartsWith(
232
str(e), 'Unprintable exception ErrorWithBadFormat')
added
removed
bzrlib/tests/test_errors.py
