/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/lockable_files.py

  • Committer: John Arbash Meinel
  • Date: 2007-12-13 20:17:06 UTC
  • mto: This revision was merged to the branch mainline in revision 3121.
  • Revision ID: john@arbash-meinel.com-20071213201706-nt8f4om80gyn6l6v
Fix LockableFiles to not use modes that allow the user to write to things they create.
It seems that cygwin + FAT32 will report all directories as readonly,
even though they are not.
Regardless, someone might have .bzr/repository as readonly, but still
allow you to create files in a subdirectory.
Either way, there is no reason to have a file that we are going to
write to be created readonly.

Show diffs side-by-side

added added

removed removed

Lines of Context:
132
132
            self._dir_mode = 0755
133
133
            self._file_mode = 0644
134
134
        else:
135
 
            self._dir_mode = st.st_mode & 07777
 
135
            # Check the directory mode, but also make sure the created
 
136
            # directories and files are read-write for this user. This is
 
137
            # mostly a workaround for filesystems which lie about being able to
 
138
            # write to a directory (cygwin & win32)
 
139
            self._dir_mode = (st.st_mode & 07777) | 00700
136
140
            # Remove the sticky and execute bits for files
137
141
            self._file_mode = self._dir_mode & ~07111
138
142
        if not self._set_dir_mode: