/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: Robert Collins
  • Date: 2009-03-25 05:08:42 UTC
  • mto: This revision was merged to the branch mainline in revision 4216.
  • Revision ID: robertc@robertcollins.net-20090325050842-maz9t0tio264dcya
Enable record_iter_changes for cases where it can work.

Show diffs side-by-side

added added

removed removed

Lines of Context:
104
104
    def completed(self, revno, rev_id):
105
105
        pass
106
106
 
107
 
    def deleted(self, file_id):
 
107
    def deleted(self, path):
108
108
        pass
109
109
 
110
110
    def escaped(self, escape_count, message):
130
130
        note(format, *args)
131
131
 
132
132
    def snapshot_change(self, change, path):
133
 
        if change == 'unchanged':
134
 
            return
135
 
        if change == 'added' and path == '':
 
133
        if path == '' and change in ('added', 'modified'):
136
134
            return
137
135
        self._note("%s %s", change, path)
138
136
 
151
149
    def completed(self, revno, rev_id):
152
150
        self._note('Committed revision %d.', revno)
153
151
 
154
 
    def deleted(self, file_id):
155
 
        self._note('deleted %s', file_id)
 
152
    def deleted(self, path):
 
153
        self._note('deleted %s', path)
156
154
 
157
155
    def escaped(self, escape_count, message):
158
156
        self._note("replaced %d control characters in message", escape_count)
275
273
                minimum_path_selection(specific_files))
276
274
        else:
277
275
            self.specific_files = None
278
 
        self.specific_file_ids = None
 
276
            
279
277
        self.allow_pointless = allow_pointless
280
278
        self.revprops = revprops
281
279
        self.message_callback = message_callback
286
284
        self.verbose = verbose
287
285
 
288
286
        self.work_tree.lock_write()
 
287
        self.parents = self.work_tree.get_parent_ids()
 
288
        # We can use record_iter_changes IFF iter_changes is compatible with
 
289
        # the command line parameters, and the repository has fast delta
 
290
        # generation. See bug 347649.
 
291
        self.use_record_iter_changes = (
 
292
            not self.specific_files and
 
293
            not self.exclude and 
 
294
            not self.branch.repository._format.supports_tree_reference and
 
295
            self.branch.repository._format.fast_deltas or len(self.parents) < 2)
289
296
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
290
297
        self.basis_revid = self.work_tree.last_revision()
291
298
        self.basis_tree = self.work_tree.basis_tree()
309
316
            if self.config is None:
310
317
                self.config = self.branch.get_config()
311
318
 
312
 
            # If provided, ensure the specified files are versioned
313
 
            if self.specific_files is not None:
314
 
                # Note: This routine is being called because it raises
315
 
                # PathNotVersionedError as a side effect of finding the IDs. We
316
 
                # later use the ids we found as input to the working tree
317
 
                # inventory iterator, so we only consider those ids rather than
318
 
                # examining the whole tree again.
319
 
                # XXX: Dont we have filter_unversioned to do this more
320
 
                # cheaply?
321
 
                self.specific_file_ids = tree.find_ids_across_trees(
322
 
                    specific_files, [self.basis_tree, self.work_tree])
 
319
            self._set_specific_file_ids()
323
320
 
324
321
            # Setup the progress bar. As the number of files that need to be
325
322
            # committed in unknown, progress is reported as stages.
336
333
            self.pb.show_count = True
337
334
            self.pb.show_bar = True
338
335
 
339
 
            self.basis_inv = self.basis_tree.inventory
340
336
            self._gather_parents()
341
337
            # After a merge, a selected file commit is not supported.
342
338
            # See 'bzr help merge' for an explanation as to why.
347
343
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
348
344
 
349
345
            # Collect the changes
350
 
            self._set_progress_stage("Collecting changes",
351
 
                    entries_title="Directory")
 
346
            self._set_progress_stage("Collecting changes", counter=True)
352
347
            self.builder = self.branch.get_commit_builder(self.parents,
353
348
                self.config, timestamp, timezone, committer, revprops, rev_id)
354
349
 
364
359
                self.reporter.started(new_revno, self.rev_id, master_location)
365
360
 
366
361
                self._update_builder_with_changes()
367
 
                self._report_and_accumulate_deletes()
368
362
                self._check_pointless()
369
363
 
370
364
                # TODO: Now the new inventory is known, check for conflicts.
430
424
        # The initial commit adds a root directory, but this in itself is not
431
425
        # a worthwhile commit.
432
426
        if (self.basis_revid == revision.NULL_REVISION and
433
 
            len(self.builder.new_inventory) == 1):
 
427
            ((self.builder.new_inventory is not None and
 
428
             len(self.builder.new_inventory) == 1) or
 
429
            len(self.builder._basis_delta) == 1)):
434
430
            raise PointlessCommit()
435
 
        # If length == 1, then we only have the root entry. Which means
436
 
        # that there is no real difference (only the root could be different)
437
 
        # unless deletes occured, in which case the length is irrelevant.
438
 
        if (self.any_entries_deleted or
439
 
            (len(self.builder.new_inventory) != 1 and
440
 
             self.builder.any_changes())):
 
431
        if self.builder.any_changes():
441
432
            return
442
433
        raise PointlessCommit()
443
434
 
631
622
        """Record the parents of a merge for merge detection."""
632
623
        # TODO: Make sure that this list doesn't contain duplicate
633
624
        # entries and the order is preserved when doing this.
634
 
        self.parents = self.work_tree.get_parent_ids()
 
625
        if self.use_record_iter_changes:
 
626
            return
 
627
        self.basis_inv = self.basis_tree.inventory
635
628
        self.parent_invs = [self.basis_inv]
636
629
        for revision in self.parents[1:]:
637
630
            if self.branch.repository.has_revision(revision):
644
637
    def _update_builder_with_changes(self):
645
638
        """Update the commit builder with the data about what has changed.
646
639
        """
647
 
        # Build the revision inventory.
648
 
        #
649
 
        # This starts by creating a new empty inventory. Depending on
650
 
        # which files are selected for commit, and what is present in the
651
 
        # current tree, the new inventory is populated. inventory entries
652
 
        # which are candidates for modification have their revision set to
653
 
        # None; inventory entries that are carried over untouched have their
654
 
        # revision set to their prior value.
655
 
        #
656
 
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
657
 
        # results to create a new inventory at the same time, which results
658
 
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
659
 
        # ADHB 11-07-2006
660
 
 
661
640
        exclude = self.exclude
662
641
        specific_files = self.specific_files or []
663
642
        mutter("Selecting files for commit with filter %s", specific_files)
664
643
 
665
 
        # Build the new inventory
666
 
        self._populate_from_inventory()
667
 
 
 
644
        self._check_strict()
 
645
        if self.use_record_iter_changes:
 
646
            iter_changes = self.work_tree.iter_changes(self.basis_tree)
 
647
            iter_changes = self._filter_iter_changes(iter_changes)
 
648
            for file_id, path, fs_hash in self.builder.record_iter_changes(
 
649
                self.work_tree, self.basis_revid, iter_changes):
 
650
                self.work_tree._observed_sha1(file_id, path, fs_hash)
 
651
        else:
 
652
            # Build the new inventory
 
653
            self._populate_from_inventory()
 
654
            self._record_unselected()
 
655
            self._report_and_accumulate_deletes()
 
656
 
 
657
    def _filter_iter_changes(self, iter_changes):
 
658
        """Process iter_changes.
 
659
 
 
660
        This method reports on the changes in iter_changes to the user, and 
 
661
        converts 'missing' entries in the iter_changes iterator to 'deleted'
 
662
        entries. 'missing' entries have their
 
663
 
 
664
        :param iter_changes: An iter_changes to process.
 
665
        :return: A generator of changes.
 
666
        """
 
667
        reporter = self.reporter
 
668
        report_changes = reporter.is_verbose()
 
669
        deleted_ids = []
 
670
        for change in iter_changes:
 
671
            if report_changes:
 
672
                old_path = change[1][0]
 
673
                new_path = change[1][1]
 
674
                versioned = change[3][1]
 
675
            kind = change[6][1]
 
676
            versioned = change[3][1]
 
677
            if kind is None and versioned:
 
678
                # 'missing' path
 
679
                if report_changes:
 
680
                    reporter.missing(new_path)
 
681
                deleted_ids.append(change[0])
 
682
                # Reset the new path (None) and new versioned flag (False)
 
683
                change = (change[0], (change[1][0], None), change[2],
 
684
                    (change[3][0], False)) + change[4:]
 
685
            elif kind == 'tree-reference':
 
686
                if self.recursive == 'down':
 
687
                    self._commit_nested_tree(change[0], change[1][1])
 
688
            if change[3][0] or change[3][1]:
 
689
                yield change
 
690
                if report_changes:
 
691
                    if new_path is None:
 
692
                        reporter.deleted(old_path)
 
693
                    elif old_path is None:
 
694
                        reporter.snapshot_change('added', new_path)
 
695
                    elif old_path != new_path:
 
696
                        reporter.renamed('renamed', old_path, new_path)
 
697
                    else:
 
698
                        if (new_path or 
 
699
                            self.work_tree.branch.repository._format.rich_root_data):
 
700
                            # Don't report on changes to '' in non rich root
 
701
                            # repositories.
 
702
                            reporter.snapshot_change('modified', new_path)
 
703
            self._next_progress_entry()
 
704
        # Unversion IDs that were found to be deleted
 
705
        self.work_tree.unversion(deleted_ids)
 
706
 
 
707
    def _record_unselected(self):
668
708
        # If specific files are selected, then all un-selected files must be
669
709
        # recorded in their previous state. For more details, see
670
710
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
671
 
        if specific_files or exclude:
 
711
        if self.specific_files or self.exclude:
 
712
            specific_files = self.specific_files or []
672
713
            for path, old_ie in self.basis_inv.iter_entries():
673
714
                if old_ie.file_id in self.builder.new_inventory:
674
715
                    # already added - skip.
675
716
                    continue
676
717
                if (is_inside_any(specific_files, path)
677
 
                    and not is_inside_any(exclude, path)):
 
718
                    and not is_inside_any(self.exclude, path)):
678
719
                    # was inside the selected path, and not excluded - if not
679
720
                    # present it has been deleted so skip.
680
721
                    continue
681
722
                # From here down it was either not selected, or was excluded:
682
 
                if old_ie.kind == 'directory':
683
 
                    self._next_progress_entry()
684
723
                # We preserve the entry unaltered.
685
724
                ie = old_ie.copy()
686
725
                # Note: specific file commits after a merge are currently
692
731
                    self.basis_tree, None)
693
732
 
694
733
    def _report_and_accumulate_deletes(self):
695
 
        # XXX: Could the list of deleted paths and ids be instead taken from
696
 
        # _populate_from_inventory?
697
734
        if (isinstance(self.basis_inv, Inventory)
698
735
            and isinstance(self.builder.new_inventory, Inventory)):
699
736
            # the older Inventory classes provide a _byid dict, and building a
717
754
                self.builder.record_delete(path, file_id)
718
755
                self.reporter.deleted(path)
719
756
 
720
 
    def _populate_from_inventory(self):
721
 
        """Populate the CommitBuilder by walking the working tree inventory."""
 
757
    def _check_strict(self):
 
758
        # XXX: when we use iter_changes this would likely be faster if
 
759
        # iter_changes would check for us (even in the presence of
 
760
        # selected_files).
722
761
        if self.strict:
723
762
            # raise an exception as soon as we find a single unknown.
724
763
            for unknown in self.work_tree.unknowns():
725
764
                raise StrictCommitFailed()
726
765
 
 
766
    def _populate_from_inventory(self):
 
767
        """Populate the CommitBuilder by walking the working tree inventory."""
 
768
        # Build the revision inventory.
 
769
        #
 
770
        # This starts by creating a new empty inventory. Depending on
 
771
        # which files are selected for commit, and what is present in the
 
772
        # current tree, the new inventory is populated. inventory entries
 
773
        # which are candidates for modification have their revision set to
 
774
        # None; inventory entries that are carried over untouched have their
 
775
        # revision set to their prior value.
 
776
        #
 
777
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
 
778
        # results to create a new inventory at the same time, which results
 
779
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
 
780
        # ADHB 11-07-2006
 
781
 
727
782
        specific_files = self.specific_files
728
783
        exclude = self.exclude
729
784
        report_changes = self.reporter.is_verbose()
743
798
            name = existing_ie.name
744
799
            parent_id = existing_ie.parent_id
745
800
            kind = existing_ie.kind
746
 
            if kind == 'directory':
747
 
                self._next_progress_entry()
748
801
            # Skip files that have been deleted from the working tree.
749
802
            # The deleted path ids are also recorded so they can be explicitly
750
803
            # unversioned later.
779
832
                    for segment in path_segments:
780
833
                        deleted_dict = deleted_dict.setdefault(segment, {})
781
834
                    self.reporter.missing(path)
 
835
                    self._next_progress_entry()
782
836
                    deleted_ids.append(file_id)
783
837
                    continue
784
838
            # TODO: have the builder do the nested commit just-in-time IF and
874
928
            InventoryEntry.MODIFIED_AND_RENAMED):
875
929
            old_path = self.basis_inv.id2path(ie.file_id)
876
930
            self.reporter.renamed(change, old_path, path)
 
931
            self._next_progress_entry()
877
932
        else:
 
933
            if change == 'unchanged':
 
934
                return
878
935
            self.reporter.snapshot_change(change, path)
 
936
            self._next_progress_entry()
879
937
 
880
 
    def _set_progress_stage(self, name, entries_title=None):
 
938
    def _set_progress_stage(self, name, counter=False):
881
939
        """Set the progress stage and emit an update to the progress bar."""
882
940
        self.pb_stage_name = name
883
941
        self.pb_stage_count += 1
884
 
        self.pb_entries_title = entries_title
885
 
        if entries_title is not None:
 
942
        if counter:
886
943
            self.pb_entries_count = 0
887
 
            self.pb_entries_total = '?'
 
944
        else:
 
945
            self.pb_entries_count = None
888
946
        self._emit_progress()
889
947
 
890
948
    def _next_progress_entry(self):
893
951
        self._emit_progress()
894
952
 
895
953
    def _emit_progress(self):
896
 
        if self.pb_entries_title:
897
 
            if self.pb_entries_total == '?':
898
 
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
899
 
                    self.pb_entries_title, self.pb_entries_count)
900
 
            else:
901
 
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
902
 
                    self.pb_entries_title, self.pb_entries_count,
903
 
                    str(self.pb_entries_total))
 
954
        if self.pb_entries_count is not None:
 
955
            text = "%s [%d] - Stage" % (self.pb_stage_name,
 
956
                self.pb_entries_count)
904
957
        else:
905
 
            text = "%s - Stage" % (self.pb_stage_name)
 
958
            text = "%s - Stage" % (self.pb_stage_name, )
906
959
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
907
960
 
 
961
    def _set_specific_file_ids(self):
 
962
        """populate self.specific_file_ids if we will use it."""
 
963
        if not self.use_record_iter_changes:
 
964
            # If provided, ensure the specified files are versioned
 
965
            if self.specific_files is not None:
 
966
                # Note: This routine is being called because it raises
 
967
                # PathNotVersionedError as a side effect of finding the IDs. We
 
968
                # later use the ids we found as input to the working tree
 
969
                # inventory iterator, so we only consider those ids rather than
 
970
                # examining the whole tree again.
 
971
                # XXX: Dont we have filter_unversioned to do this more
 
972
                # cheaply?
 
973
                self.specific_file_ids = tree.find_ids_across_trees(
 
974
                    self.specific_files, [self.basis_tree, self.work_tree])
 
975
            else:
 
976
                self.specific_file_ids = None