/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/_btree_serializer_pyx.pyx

  • Committer: John Arbash Meinel
  • Date: 2009-10-12 20:07:09 UTC
  • mto: This revision was merged to the branch mainline in revision 4749.
  • Revision ID: john@arbash-meinel.com-20091012200709-hjmn47sbqw12fzpt
Comment about compiled code quality.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/_btree_serializer_pyx.pyx
356
356
    #       And when there are 2 items, we could do a single malloc + len() + 1
357
357
    #       also, doing .join() requires a PyObject_GetAttrString call, which
358
358
    #       we could also avoid.
 
359
    # TODO: Note that pyrex 0.9.6 generates fairly crummy code here, using the
 
360
    #       python object interface, versus 0.9.8+ which uses a helper that
 
361
    #       checks if this supports the sequence interface.
 
362
    #       We *could* do more work on our own, and grab the actual items
 
363
    #       lists. For now, just ask people to use a better compiler. :)
359
364
    string_key = '\0'.join(node[1])
360
365
 
361
366
    # TODO: instead of using string joins, precompute the final string length,