/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_log.py

  • Committer: Vincent Ladeuil
  • Date: 2010-02-01 16:26:37 UTC
  • mto: (4999.2.1 integration2)
  • mto: This revision was merged to the branch mainline in revision 5001.
  • Revision ID: v.ladeuil+lp@free.fr-20100201162637-um0ei9j2yktu6zob
Check ancestry so we don't output random revisions.

* bzrlib/tests/blackbox/test_log.py:
(TestBug476293): Reproduce the bug.

* bzrlib/log.py:
(_generate_all_revisions): If merged revisions are involved, the
ancestor check should be explicit.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/blackbox/test_log.py
23
23
 
24
24
from bzrlib import (
25
25
    branchbuilder,
 
26
    errors,
26
27
    log,
27
28
    osutils,
28
29
    tests,
202
203
                             ['1.1.1', '1.1.2', '1.1.3', '1.1.4'])
203
204
 
204
205
 
 
206
class TestBug476293(TestLogWithLogCatcher):
 
207
 
 
208
    def make_tagged_branch(self, path='.', format=None):
 
209
        builder = branchbuilder.BranchBuilder(self.get_transport())
 
210
        builder.start_series()
 
211
        # The graph below may look a bit complicated (and it may be but I've
 
212
        # banged my head enough on it) but the bug requires at least dotted
 
213
        # revnos *and* merged revisions below that.
 
214
        builder.build_snapshot('1', None, [
 
215
            ('add', ('', 'root-id', 'directory', ''))])
 
216
        builder.build_snapshot('2', ['1'], [])
 
217
        builder.build_snapshot('1.1.1', ['1'], [])
 
218
        builder.build_snapshot('2.1.1', ['2'], [])
 
219
        builder.build_snapshot('3', ['2', '1.1.1'], [])
 
220
        builder.build_snapshot('2.1.2', ['2.1.1'], [])
 
221
        builder.build_snapshot('2.2.1', ['2.1.1'], [])
 
222
        builder.build_snapshot('2.1.3', ['2.1.2', '2.2.1'], [])
 
223
        builder.build_snapshot('4', ['3', '2.1.3'], [])
 
224
        builder.build_snapshot('5', ['4', '2.1.2'], [])
 
225
        builder.finish_series()
 
226
        tags = builder.get_branch().tags
 
227
        return builder
 
228
 
 
229
    def test_not_an_ancestor(self):
 
230
        builder = self.make_tagged_branch()
 
231
        b = builder.get_branch()
 
232
        b.lock_read()
 
233
        self.addCleanup(b.unlock)
 
234
        self.assertRaises(errors.BzrCommandError,
 
235
                          log._generate_all_revisions,
 
236
                          b, '1.1.1', '2.1.3', 'reverse',
 
237
                          delayed_graph_generation=True)
 
238
 
 
239
    def test_wrong_order(self):
 
240
        builder = self.make_tagged_branch()
 
241
        b = builder.get_branch()
 
242
        b.lock_read()
 
243
        self.addCleanup(b.unlock)
 
244
        self.assertRaises(errors.BzrCommandError,
 
245
                          log._generate_all_revisions,
 
246
                          b, '5', '2.1.3', 'reverse',
 
247
                          delayed_graph_generation=True)
 
248
 
 
249
 
205
250
class TestLogRevSpecsWithPaths(TestLogWithLogCatcher):
206
251
 
207
252
    def test_log_revno_n_path_wrong_namespace(self):
210
255
        # There is no guarantee that a path exist between two arbitrary
211
256
        # revisions.
212
257
        self.run_bzr("log -r revno:2:branch1..revno:3:branch2", retcode=3)
213
 
        # But may be it's worth trying though ? -- vila 100115
214
258
 
215
259
    def test_log_revno_n_path_correct_order(self):
216
260
        self.make_linear_branch('branch2')