/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_remote.py

  • Committer: Vincent Ladeuil
  • Date: 2010-01-25 15:55:48 UTC
  • mto: (4985.1.4 add-attr-cleanup)
  • mto: This revision was merged to the branch mainline in revision 4988.
  • Revision ID: v.ladeuil+lp@free.fr-20100125155548-0l352pujvt5bzl5e
Deploy addAttrCleanup on the whole test suite.

Several use case worth mentioning:

- setting a module or any other object attribute is the majority
by far. In some cases the setting itself is deferred but most of
the time we want to set at the same time we add the cleanup.

- there multiple occurrences of protecting hooks or ui factory
which are now useless (the test framework takes care of that now),

- there was some lambda uses that can now be avoided.

That first cleanup already simplifies things a lot.

Show diffs side-by-side

added added

removed removed

Lines of Context:
2008
2008
        self.assertLength(1, self.hpss_calls)
2009
2009
 
2010
2010
    def disableExtraResults(self):
2011
 
        old_flag = SmartServerRepositoryGetParentMap.no_extra_results
 
2011
        self.addAttrCleanup(SmartServerRepositoryGetParentMap,
 
2012
                            'no_extra_results')
2012
2013
        SmartServerRepositoryGetParentMap.no_extra_results = True
2013
 
        def reset_values():
2014
 
            SmartServerRepositoryGetParentMap.no_extra_results = old_flag
2015
 
        self.addCleanup(reset_values)
2016
2014
 
2017
2015
    def test_null_cached_missing_and_stop_key(self):
2018
2016
        self.setup_smart_server_with_call_log()